Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support securing barkeep with a whitelist of authorized users #361

Open
philc opened this issue Nov 13, 2012 · 2 comments
Open

Support securing barkeep with a whitelist of authorized users #361

philc opened this issue Nov 13, 2012 · 2 comments

Comments

@philc
Copy link
Contributor

philc commented Nov 13, 2012

Today we support openid logins, but it's not secure unless hosted behind a firewall, since a user from any domain can log in. In addition to regular username/password authorization (#354), ldap (#347), and restricting openid by domain (#207), we should support openid with a whitelist of emails.

The workflow for this should be the admin sets up barkeep, logs in, and can then add users via the /admin section. A nice feature would be to optionally send out an invite email when their name gets added.

We could also configure this list of users by an ENV variable instead of via UI, but I think that's more klunky since it requires editing a file and perhaps deploying. What do you think?

philc added a commit that referenced this issue Nov 13, 2012
irabinovitch pushed a commit to irabinovitch/barkeep that referenced this issue Dec 12, 2012
@irabinovitch
Copy link

I was thinking about adding a similar env variable for authorized domains to provide a solution for #207. Thoughts?

@cespare
Copy link
Contributor

cespare commented Feb 28, 2013

From a Barkeep meeting today: our plan is to put the whitelist into the DB, and add an admin UI for modifying the list. At that point, we should remove the environment configuration stopgap solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants