Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning that the changes are not submitted when the user is about to close the tab #30

Open
hellais opened this issue Apr 13, 2022 · 2 comments · May be fixed by #33
Open

Add a warning that the changes are not submitted when the user is about to close the tab #30

hellais opened this issue Apr 13, 2022 · 2 comments · May be fixed by #33
Assignees
@majakomel
Labels
enhancement improving existing code or new feature priority/low

Comments

@hellais
Copy link
Member

hellais commented Apr 13, 2022

It might not be apparent to a user that they haven't clicked on propose changes, so we should add a warning about that when they are going to close the browser tab.
@hellais hellais added enhancement improving existing code or new feature priority/low labels Apr 13, 2022
@sarathms sarathms linked a pull request Apr 29, 2022 that will close this issue
Draft
@hellais
Copy link
Member Author

hellais commented May 4, 2022

It looks like we can't customise the text of the dialog (which misleadingly says that the changes might not be saved when they navigate away).

Moreover, the dialog will appear also when you reload the page, which is not what we want.

It's also unclear if this is useful for users, so we aren't going to be implementing this at this time.

@sarathms
Copy link
Contributor

sarathms commented May 4, 2022

This is the message the browser shows when you try to close the page/tab or reload the page.

image

@bassosimone bassosimone assigned majakomel and unassigned sarathms Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majakomel majakomel

Labels
enhancement improving existing code or new feature priority/low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show warning before navigating away without submitting ooni/test-lists-ui
3 participants
@hellais @sarathms @majakomel