Results: Show success, anomaly and failed counts on items #346
Conversation
| } | ||
|
|
||
| when { | ||
| descriptorName == "websites" || firstTest == TestType.WebConnectivity -> { |
There was a problem hiding this comment.
I would rather the test names come from a defined type/enum
There was a problem hiding this comment.
Is there some way we can make this view be general enough to not be so reliant on specific descriptor name and test_names?
There was a problem hiding this comment.
Is there some way we can make this view be general enough to not be so reliant on specific descriptor name and test_names?
The requirement was to match the previous UI we had. Each one has a different name for anomalies, and we show the total websites tested. If it's OK to just use a more generic term for all of them, then we can simplify this.
Not sure how to deal with performance, which is showing quite different information. Should we just show if the tests didn't fail? Or start showing the performance summary like before?
composeApp/src/commonMain/kotlin/org/ooni/probe/ui/results/ResultCell.kt
Outdated
Show resolved
Hide resolved
| val doneMeasurementsCount: Long, | ||
| val failedMeasurementsCount: Long, | ||
| val anomalyMeasurementsCount: Long, |
There was a problem hiding this comment.
Maybe something like this.
measurementCount: MeasurementCount
data class MeasurementCount( val done: Int, val failed: Int, val anomaly: Int ) { fun total() = done + failed + anomaly }
|
I made changes in the migrations in #355. So let's merge that PR first, before merging this one, to avoid DB corruptions. |
Closes #340