Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to logging #20

Open
3 of 6 tasks
hellais opened this issue Sep 13, 2018 · 0 comments
Open
3 of 6 tasks

Improvements to logging #20

hellais opened this issue Sep 13, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@hellais
Copy link
Member

hellais commented Sep 13, 2018

@hellais commented on Fri May 13 2016

In discussing logging issues @anadahz it seems like ooniprobe generates too much logging information that is especially bad when running it on a raspberry pi.

I am going to propose that as part of reducing the amount of logs ooniprobe generates we do the following:

  • Separate the logging to file from writing messages to the console (there are certain bits of information that are not needed in the log and are only useful to a user running ooniprobe)
  • Introduce log levels to separate critical logging from non critical logging
  • Add option to disable logging entirely (https://github.com/TheTorProject/ooni-probe/issues/501)
  • Add support for differentiating between standard error and standard output

@anadahz commented on Mon May 16 2016

After discussion with @hellais I 'll add to this list:

  • Add support for STDERR logging to file
  • Ensure that logging applies to all ooni-probe components (oonideckgen, oonireport, ooniprobe, ooniresources)

@bassosimone commented on Mon May 16 2016

Regarding logging, see also #415.


@hellais commented on Thu Jul 28 2016

@anadahz what do you mean exactly by "Add support for STDERR logging to file"?


@anadahz commented on Fri Jul 29 2016

@hellais
Currently ooniprobe logging does not differentiate messages printed in stdout (screen output) and stderr (error messages output to the screen). It will be really useful and save a vast amount of disk space if the error log msgs could be save in a separate file rather than one log file.

Perhaps this is already implemented in:
Add support for differentiating between standard error and standard output


@hellais commented on Fri Jul 29 2016

Hum, well what I have added support for in 109fffc864d946ad83d20a74c66639500960c5e8 is loglevels. This means you can set the loglevel to be, say, WARNING or ERROR and the logfile will only have in it error level messages.

Moreover now there is a distinction between stderr and stdout, in the sense that error messages are printed to the standard error output stream, while other messages are printed to the standard output.

@hellais hellais added the enhancement New feature or request label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant