Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter manager could use document properties instead of real field names #152

Open
mvar opened this issue Jan 8, 2016 · 2 comments
Open
Labels

Comments

@mvar
Copy link
Member

mvar commented Jan 8, 2016

After testing filter manager bundle in user role I got an idea. Each field in configuration should be document property but not plain Elasticsearch field name. I think this would be quite simple to implement because user does not interact with filter manager using fields in runtime. Only in configuration, so implementation would not add any overhead.

@saimaz @murnieza what do you think? If we see "properties only" as our long-term goal, we should get started.

@mvar mvar added the question label Jan 8, 2016
@mvar mvar added this to the v1.0.0 milestone Jan 11, 2016
@saimaz
Copy link
Member

saimaz commented Jan 27, 2016

Eventually, would be really good to get rid of using elasticsearch type fields. In this particular example, I don't think is very difficult to introduce the usage of Document class properties.

IMO we should rethink about all configuration structure before a major release. Since elasticsearch doesn't support any more multiple repositories in a single instance we could simplify configuration in filter manager.

@mvar
Copy link
Member Author

mvar commented Feb 1, 2016

OK, after some deeper investigations I see that this is not that easy. Filter itself is not associated with any document (needs document to resolve field name). It is only indirectly associated on runtime while building search query. Currently it would be hardly possible to resolve that association without big architecture changes.

@mvar mvar removed this from the v1.0.0 milestone Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants