Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #344

Open
matchish opened this issue Dec 12, 2020 · 7 comments
Open

PHP 8 support #344

matchish opened this issue Dec 12, 2020 · 7 comments

Comments

@matchish
Copy link

It will be great to add php8 support(as dependency)
https://www.php.net/releases/8.0/en.php

@francoism90
Copy link

@saimaz Could you please bump this package? Don't why the open PR has changes, does this really rewriting for PHP 8?

@guicara
Copy link

guicara commented May 2, 2021

Hello,

Any news on this issue?
It's really important to support PHP 8 since it's used in production quite a lot now.

Thanks!

@Ocramius
Copy link

As a temporary workaround, I published https://packagist.org/packages/ocramius/elasticsearch-dsl#7.9.999

This allows usage within my local infrastructure, but it comes with ZERO BC promise, since I'd rather see it deleted when @ongr-io releases a compatible version :-)

@solverat
Copy link

Or just use https://github.com/handcraftedinthealps/elasticsearchdsl. It‘s maintained by the guys of sulu so it‘s in good hands i guess. Also supports symfony5 and php8.

@Ocramius
Copy link

That's something I've already done, but we should support @ongr-io first.

@84m
Copy link

84m commented May 27, 2021

hey, i'm currently testing the php8 integration with a local project, will try to release a version with support soonish. Changes are on https://github.com/ongr-io/ElasticsearchDSL/tree/7.2 already i just need to test it and the release the next version (maybe i'll copy a release pipeline from one of @Ocramius projects for that - but i don't have that much experience with github actions yet)

@Ocramius
Copy link

@84m feel free to poke/call me if you need any guidance: anything that brings this lib forward is immediate value :-)

Alternatively, check https://github.com/laminas/laminas-continuous-integration-action, which does a bunch of checks, all in one shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants