Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last page at non-existing pages #4

Open
asev opened this issue Jan 28, 2015 · 0 comments
Open

Last page at non-existing pages #4

asev opened this issue Jan 28, 2015 · 0 comments

Comments

@asev
Copy link

asev commented Jan 28, 2015

Hello.
pager.getPage() on non-existing pages returns last page. This is not what UX and SEO guys want.

If product list has a 3 pages, and I'm trying to access 4th page (?page=4), I see no products (this is fine), but pager.getPage() returns 3.

I suggest remove lastPage option at setPage
Maybe it would be nice to have isPageValid() method, that checks if currentPage <= lastPage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant