Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transactions to avoid DUC leakage #104

Open
austinsamsel opened this issue Dec 9, 2022 · 0 comments
Open

Update transactions to avoid DUC leakage #104

austinsamsel opened this issue Dec 9, 2022 · 0 comments

Comments

@austinsamsel
Copy link
Collaborator

austinsamsel commented Dec 9, 2022

@satyamakgec has done some excellent work to avoid DUC leakage in the "StorefrontListItem" and "StorefrontBuyItem" transactions:

https://github.com/onflow/TransactionMix/tree/main/transactions/nft-storefront-v2

Can we update the corresponding nft-catalog transactions to include these checks to avoid DUC leakage?

I'm not sure if there are wider implications or some additional context to consider.

I'd also be happy to open a PR to do this myself.

I think it'd be a good thing if we start considering the nft-catalog transaction templates as exemplar/standard.

i'm currently working on setting up some re-usable/multi-project workflow functionality around marketplace/storefront transactions and I'd like to depend more on nft-catalog.

I don't think I can start to rely on nft-catalog yet, until we can resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant