Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning of OncoKB #30

Open
kpjonsson opened this issue Jul 2, 2019 · 10 comments
Open

Versioning of OncoKB #30

kpjonsson opened this issue Jul 2, 2019 · 10 comments

Comments

@kpjonsson
Copy link

Is there any way to use specific versions of OncoKB itself (not the annotator)?

Say for example I wanted to stick to the release from May 9, 2019 here: https://oncokb.org/news.

@zhx828
Copy link
Member

zhx828 commented Jul 3, 2019

@kpjonsson we currently don't have anything set up for that. If you want, you could set up your own oncokb instance, the sql dump is here https://github.com/oncokb/oncokb-public/tree/master/data/v1.20

@jjgao do you think setting up previous versions should be supported?

@kpjonsson
Copy link
Author

kpjonsson commented Jul 3, 2019

Thanks @zhx828.

@jjgao
Copy link
Member

jjgao commented Jul 3, 2019

@zhx828 maybe we can provide docker files in the future for that... but probably not a priority.

@jjgao jjgao closed this as completed Jul 3, 2019
@jjgao jjgao reopened this Jul 3, 2019
@evanbiederstedt
Copy link

evanbiederstedt commented Aug 8, 2019

I do think this may one day become more of a priority (though not soon). I'm happy to help out .

Please send over some marching orders

maybe we can provide docker files in the future for that... but probably not a priority.

I'm happy to help out building Docker images.

EDIT: I took a closer look into this. Yes, it's not a majority priority any time soon.

@zhx828
Copy link
Member

zhx828 commented Aug 8, 2019

@evanbiederstedt thanks for looking into the issue. We actually using docker to do production release. Just need to create few more for previous versions. I do think this is something nice to do and not really difficult. But where should we host these instances? Or should we just let the users host their own by using the docker image? @jjgao thoughts?

@evanbiederstedt
Copy link

I do think this is something nice to do and not really difficult. But where should we host these instances? Or should we just let the users host their own by using the docker image?

I'll slack. I would recommend hosting the Docker images (with organized version schema) on Dockerhub, e.g. this domain would be good https://hub.docker.com/u/onkokb

You can set it up to host the Dockerfiles on Dockerhub, but I think it makes more sense to host them at this repo: e.g.

oncokb/oncokb-annotator/subDirectoryName/Dockerfile

Users can then build the Docker image from that file.

(Caveat: everything I say can be dismissed as unhelpful recommendations.)

@tingchiafelix
Copy link

Hi,
I'm also looking for a way to lock down the oncoKB version. Could I know if you have any updates on this topic?

Thank you in advance,
TC

@zhx828
Copy link
Member

zhx828 commented Oct 25, 2021

@tingchiafelix we haven't made any progress yet, a bit short on the resource to do that. But could you give us more information on how you like to use the versioned oncokb content? Do you prefer to annotate by sending the version, or use a dedicated url?

@tingchiafelix
Copy link

@zhx828 thanks for your response. Actually, I have an API token obtained from the oncoKB license team and I didn't see any option to specify a version by running API annotator. In our research, we hope to lock down certain versions of OncoKB for annotation. Do you have any suggestions on that?

Also, another naive question. When I do the OncoKB annotation via API annotator, I assume the results are from the latest version of oncoKB database. Is that correct?

@zhx828
Copy link
Member

zhx828 commented Oct 27, 2021

@tingchiafelix correct, it uses the latest content from OncoKB and can generate a README file to include the data version info etc. Please see https://github.com/oncokb/oncokb-annotator/blob/master/example.sh#L44

We do not support versioned OncoKB content yet but that's definitely on our road map. We will keep you posted when that becomes available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants