-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update poa-bridge to use v2 contracts #103
base: master
Are you sure you want to change the base?
Conversation
Solution: update deposit-relay, withdraw-relay, and message-to-mainnet to be compatible with v2 contracts, remove withdraw-confirm, create deposit-confirm. Closes #5
I've run into a few problems that maybe someone can help me with:
Right now, it compiles the Command::new("solc")
.arg("--abi")
.arg("--bin")
.arg("--optimize")
.arg("--output-dir").arg("../compiled_contracts")
.arg("--overwrite")
.arg("../contracts/bridge.sol")
.status() I have been using the I think that we should remove the contract compilation step from the bridge's build script, and add a paragraph to
|
Deploy feature it's absolutely going to be removed, there's no point in it with this change. Basically, we just need to make the integration tests use the new deployment method to provision. |
It's the right direction to move forward |
Should I remove it with this PR then? If you are using the v2 contracts and this PR, you will get build errors due to |
Yes, I think this PR should drop deploy altogether and invoke deployment
scripts from v2 from within integration tests.
Also, build.rs can be replaced with just putting submoduled or directly
committed ABIs for v2.
…On Mon, Jun 11, 2018, 11:46 AM DrPeterVanNostrand ***@***.***> wrote:
Should I remove it with this PR then? If you are using the v2 contracts
and this PR, you will get build errors now due to deploy.rs.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABxHC_3XIooBDI92A4zyW_6F65yDvvks5t7rrpgaJpZM4UjBXC>
.
|
@yrashk Ok, I'll add those. |
I'm also happy to assist if the tests need to be adjusted.
…On Mon, Jun 11, 2018, 11:54 AM DrPeterVanNostrand ***@***.***> wrote:
@yrashk <https://github.com/yrashk> Ok, I'll add those.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABxIfojXy2KifiYQHqCv_q6iM7Tj_Vks5t7rzkgaJpZM4UjBXC>
.
|
Ok, thanks. I'll let you know if I hit issues. |
Problem: poa-bridge is not compatible with v2 bridge-contracts
Solution: update deposit-relay, withdraw-relay, and message-to-mainnet to be compatible with v2 contracts, remove withdraw-confirm, create deposit-confirm.
Closes #5