Fix error handling on V1 monitor workers #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
reviewed
May 30, 2019
There was a problem hiding this comment.
@patitonar thanks for rapid work! Is it possible to merge the changes with the monorepo as so we could have one branch of the monitor working for rust and node.js versions of the oracle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment omni/tokenbridge#78 (comment)
Created branch
master-1.xto push fixes forv1version. Please let me know if we should proceed in a different way.Removed
try/catchsentences on every method call inside a monitor worker that previously catched the error, logged and throw it again. This is to avoid logging the same error multiple times.Now all errors are handled at the main execution method of the worker by logging it and finishing execution instead of throwing it again. This fixes the issue with
UnhandledPromiseRejectionWarning.Updated
package-lock.jsonsoNode.js 10can be used.Also fixed error:
ReferenceError: GAS_PRICE_FALLBACK is not defined at getGasPrices.