We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
page.name is currently used for populating the id field:
page.name
id
searchyll/lib/searchyll.rb
Lines 40 to 44 in e601fea
However, there's no guarantee that name contains a defined value, and Elasticsearch will complain if it doesn't.
name
Why don't we use page.url instead, which is unique enough for being used as an ID (definitely more than name) and is guaranteed to be always defined?
page.url
The text was updated successfully, but these errors were encountered:
No branches or pull requests
page.name
is currently used for populating theid
field:searchyll/lib/searchyll.rb
Lines 40 to 44 in e601fea
However, there's no guarantee that
name
contains a defined value, and Elasticsearch will complain if it doesn't.Why don't we use
page.url
instead, which is unique enough for being used as an ID (definitely more thanname
) and is guaranteed to be always defined?The text was updated successfully, but these errors were encountered: