From 6c00cc049ca5613d0f297a960f169bc1b5533972 Mon Sep 17 00:00:00 2001 From: Beats Date: Wed, 30 Oct 2024 01:02:04 -0300 Subject: [PATCH] perf: change shared_ptrs from copy to reference (#2998) This changes the usage of 'shared_ptr' from being copied to being passed as a 'const reference'. This adjustment aims to improve performance by avoiding unnecessary increments in the reference count, especially for functions that do not need to modify the shared object. --------- Co-authored-by: Eduardo Dantas --- cmake/modules/CanaryLib.cmake | 1 + src/creatures/combat/combat.cpp | 273 +-- src/creatures/combat/combat.hpp | 108 +- src/creatures/combat/condition.cpp | 126 +- src/creatures/combat/condition.hpp | 62 +- src/creatures/combat/spells.cpp | 154 +- src/creatures/combat/spells.hpp | 68 +- src/creatures/creature.cpp | 225 +-- src/creatures/creature.hpp | 90 +- src/creatures/creatures_definitions.hpp | 48 +- src/creatures/interactions/chat.cpp | 208 ++- src/creatures/interactions/chat.hpp | 12 +- src/creatures/monsters/monster.cpp | 143 +- src/creatures/monsters/monster.hpp | 46 +- src/creatures/monsters/monsters.cpp | 56 +- src/creatures/monsters/monsters.hpp | 20 +- .../monsters/spawns/spawn_monster.cpp | 76 +- .../monsters/spawns/spawn_monster.hpp | 21 +- src/creatures/npcs/npc.cpp | 96 +- src/creatures/npcs/npc.hpp | 30 +- src/creatures/npcs/npcs.cpp | 18 +- src/creatures/npcs/npcs.hpp | 4 +- src/creatures/npcs/spawns/spawn_npc.cpp | 57 +- src/creatures/npcs/spawns/spawn_npc.hpp | 8 +- .../achievement/player_achievement.cpp | 22 +- .../achievement/player_achievement.hpp | 10 +- .../players/cyclopedia/player_badge.cpp | 22 +- .../players/cyclopedia/player_badge.hpp | 36 +- .../players/cyclopedia/player_cyclopedia.cpp | 44 +- .../players/cyclopedia/player_cyclopedia.hpp | 19 +- .../players/cyclopedia/player_title.cpp | 41 +- .../players/cyclopedia/player_title.hpp | 41 +- src/creatures/players/grouping/familiars.cpp | 12 +- src/creatures/players/grouping/familiars.hpp | 1 - src/creatures/players/grouping/groups.cpp | 18 +- src/creatures/players/grouping/guild.cpp | 10 +- src/creatures/players/grouping/guild.hpp | 4 +- src/creatures/players/grouping/party.cpp | 202 ++- src/creatures/players/grouping/party.hpp | 52 +- .../players/grouping/team_finder.hpp | 6 +- .../players/imbuements/imbuements.cpp | 48 +- .../players/imbuements/imbuements.hpp | 15 +- src/creatures/players/management/ban.cpp | 12 +- src/creatures/players/management/ban.hpp | 12 +- src/creatures/players/management/waitlist.cpp | 30 +- src/creatures/players/management/waitlist.hpp | 10 +- src/creatures/players/player.cpp | 1498 +++++++++-------- src/creatures/players/player.hpp | 585 ++++--- src/creatures/players/storages/storages.cpp | 17 +- src/creatures/players/storages/storages.hpp | 6 +- src/creatures/players/vip/player_vip.cpp | 31 +- src/creatures/players/vip/player_vip.hpp | 19 +- src/creatures/players/vocations/vocation.cpp | 89 +- src/creatures/players/vocations/vocation.hpp | 40 +- src/creatures/players/wheel/player_wheel.cpp | 441 +++-- src/creatures/players/wheel/player_wheel.hpp | 58 +- .../players/wheel/wheel_definitions.hpp | 4 +- src/creatures/players/wheel/wheel_gems.cpp | 320 ++-- src/creatures/players/wheel/wheel_gems.hpp | 12 +- src/database/database.cpp | 10 +- src/database/database.hpp | 39 +- src/database/databasetasks.cpp | 4 +- src/database/databasetasks.hpp | 4 +- src/enums/item_attribute.hpp | 2 +- src/enums/player_cyclopedia.hpp | 2 +- src/game/bank/bank.cpp | 15 +- src/game/bank/bank.hpp | 10 +- src/game/game.cpp | 859 +++++----- src/game/game.hpp | 276 +-- src/game/movement/position.hpp | 2 +- src/game/movement/teleport.cpp | 28 +- src/game/movement/teleport.hpp | 26 +- src/game/scheduling/dispatcher.cpp | 6 +- src/game/scheduling/dispatcher.hpp | 13 +- src/game/scheduling/events_scheduler.hpp | 2 +- src/game/scheduling/task.cpp | 31 +- src/game/scheduling/task.hpp | 92 +- src/game/zones/zone.cpp | 6 +- src/game/zones/zone.hpp | 6 +- src/io/fileloader.cpp | 4 +- src/io/functions/iologindata_load_player.cpp | 135 +- src/io/functions/iologindata_load_player.hpp | 56 +- src/io/functions/iologindata_save_player.cpp | 81 +- src/io/functions/iologindata_save_player.hpp | 30 +- src/io/io_bosstiary.cpp | 10 +- src/io/io_bosstiary.hpp | 4 +- src/io/iobestiary.cpp | 32 +- src/io/iobestiary.hpp | 30 +- src/io/ioguild.cpp | 4 +- src/io/ioguild.hpp | 2 +- src/io/iologindata.cpp | 31 +- src/io/iologindata.hpp | 11 +- src/io/iomap.cpp | 2 +- src/io/iomap.hpp | 5 +- src/io/iomapserialize.cpp | 16 +- src/io/iomapserialize.hpp | 8 +- src/io/iomarket.cpp | 16 +- src/io/iomarket.hpp | 2 +- src/io/ioprey.cpp | 6 +- src/io/ioprey.hpp | 6 +- src/items/bed.cpp | 36 +- src/items/bed.hpp | 20 +- src/items/containers/container.cpp | 217 +-- src/items/containers/container.hpp | 88 +- src/items/containers/depot/depotchest.cpp | 20 +- src/items/containers/depot/depotchest.hpp | 6 +- src/items/containers/depot/depotlocker.cpp | 14 +- src/items/containers/depot/depotlocker.hpp | 8 +- src/items/containers/inbox/inbox.cpp | 16 +- src/items/containers/inbox/inbox.hpp | 6 +- src/items/containers/mailbox/mailbox.cpp | 42 +- src/items/containers/mailbox/mailbox.hpp | 28 +- src/items/containers/rewards/reward.cpp | 14 +- src/items/containers/rewards/reward.hpp | 16 +- src/items/containers/rewards/rewardchest.cpp | 16 +- src/items/containers/rewards/rewardchest.hpp | 12 +- src/items/cylinder.cpp | 6 +- src/items/cylinder.hpp | 46 +- src/items/decay/decay.cpp | 20 +- src/items/decay/decay.hpp | 2 +- src/items/functions/item/attribute.cpp | 16 +- src/items/functions/item/attribute.hpp | 26 +- src/items/functions/item/custom_attribute.cpp | 16 +- src/items/functions/item/custom_attribute.hpp | 8 +- src/items/functions/item/item_parse.cpp | 434 +++-- src/items/functions/item/item_parse.hpp | 132 +- src/items/item.cpp | 133 +- src/items/item.hpp | 74 +- src/items/items.cpp | 36 +- src/items/items.hpp | 11 +- src/items/items_classification.hpp | 6 +- src/items/items_definitions.hpp | 6 +- src/items/thing.cpp | 2 +- src/items/tile.cpp | 424 +++-- src/items/tile.hpp | 76 +- src/items/trashholder.cpp | 30 +- src/items/trashholder.hpp | 22 +- src/items/weapons/weapons.cpp | 196 +-- src/items/weapons/weapons.hpp | 62 +- src/kv/kv.cpp | 6 +- src/kv/kv.hpp | 18 +- src/kv/kv_sql.cpp | 20 +- src/kv/kv_sql.hpp | 2 +- src/kv/value_wrapper.cpp | 8 +- src/kv/value_wrapper.hpp | 2 +- src/kv/value_wrapper_proto.cpp | 4 +- src/kv/value_wrapper_proto.hpp | 10 +- src/lib/di/runtime_provider.hpp | 10 +- src/lib/di/shared.hpp | 2 +- src/lib/metrics/metrics.hpp | 12 +- src/lib/thread/thread_pool.cpp | 2 +- src/lib/thread/thread_pool.hpp | 2 +- src/lua/callbacks/creaturecallback.cpp | 17 +- src/lua/callbacks/creaturecallback.hpp | 12 +- src/lua/callbacks/event_callback.cpp | 296 ++-- src/lua/callbacks/event_callback.hpp | 88 +- src/lua/creature/actions.cpp | 79 +- src/lua/creature/actions.hpp | 56 +- src/lua/creature/creatureevent.cpp | 98 +- src/lua/creature/creatureevent.hpp | 34 +- src/lua/creature/events.cpp | 258 +-- src/lua/creature/events.hpp | 70 +- src/lua/creature/movement.cpp | 119 +- src/lua/creature/movement.hpp | 68 +- src/lua/creature/raids.cpp | 46 +- src/lua/creature/raids.hpp | 10 +- src/lua/creature/talkaction.cpp | 22 +- src/lua/creature/talkaction.hpp | 10 +- src/lua/functions/core/core_functions.hpp | 6 + .../functions/core/game/bank_functions.cpp | 30 +- .../functions/core/game/bank_functions.hpp | 6 + .../functions/core/game/config_functions.cpp | 8 +- .../functions/core/game/config_functions.hpp | 6 + .../core/game/core_game_functions.hpp | 6 + .../functions/core/game/game_functions.cpp | 143 +- .../functions/core/game/game_functions.hpp | 6 + .../functions/core/game/global_functions.cpp | 152 +- .../functions/core/game/global_functions.hpp | 6 + src/lua/functions/core/game/lua_enums.cpp | 24 +- src/lua/functions/core/game/lua_enums.hpp | 6 + .../core/game/modal_window_functions.hpp | 6 + .../functions/core/game/zone_functions.cpp | 92 +- .../functions/core/game/zone_functions.hpp | 6 + src/lua/functions/core/libs/bit_functions.hpp | 6 + .../core/libs/core_libs_functions.hpp | 6 + src/lua/functions/core/libs/db_functions.cpp | 12 +- src/lua/functions/core/libs/db_functions.hpp | 6 + src/lua/functions/core/libs/kv_functions.cpp | 28 +- src/lua/functions/core/libs/kv_functions.hpp | 6 + .../functions/core/libs/logger_functions.hpp | 6 + .../functions/core/libs/metrics_functions.cpp | 6 +- .../functions/core/libs/metrics_functions.hpp | 6 + .../functions/core/libs/result_functions.cpp | 8 +- .../functions/core/libs/result_functions.hpp | 6 + .../core/network/core_network_functions.hpp | 6 + .../network/network_message_functions.cpp | 26 +- .../network/network_message_functions.hpp | 6 + .../core/network/webhook_functions.cpp | 8 +- .../core/network/webhook_functions.hpp | 6 + .../creatures/combat/combat_functions.cpp | 30 +- .../creatures/combat/combat_functions.hpp | 6 + .../creatures/combat/condition_functions.cpp | 54 +- .../creatures/combat/condition_functions.hpp | 6 + .../creatures/combat/spell_functions.cpp | 144 +- .../creatures/combat/spell_functions.hpp | 6 + .../creatures/combat/variant_functions.cpp | 2 +- .../creatures/combat/variant_functions.hpp | 6 + .../creatures/creature_functions.cpp | 220 +-- .../creatures/creature_functions.hpp | 6 + .../creatures/monster/charm_functions.cpp | 26 +- .../creatures/monster/charm_functions.hpp | 6 + .../creatures/monster/loot_functions.cpp | 40 +- .../creatures/monster/loot_functions.hpp | 6 + .../creatures/monster/monster_functions.cpp | 134 +- .../creatures/monster/monster_functions.hpp | 6 + .../monster/monster_spell_functions.cpp | 46 +- .../monster/monster_spell_functions.hpp | 8 +- .../monster/monster_type_functions.cpp | 210 +-- .../monster/monster_type_functions.hpp | 6 + .../functions/creatures/npc/npc_functions.cpp | 112 +- .../functions/creatures/npc/npc_functions.hpp | 6 + .../creatures/npc/npc_type_functions.cpp | 2 +- .../creatures/npc/npc_type_functions.hpp | 6 + .../creatures/npc/shop_functions.cpp | 2 +- .../creatures/npc/shop_functions.hpp | 6 + .../creatures/player/group_functions.cpp | 4 +- .../creatures/player/group_functions.hpp | 6 + .../creatures/player/guild_functions.cpp | 38 +- .../creatures/player/guild_functions.hpp | 6 + .../creatures/player/mount_functions.cpp | 10 +- .../creatures/player/mount_functions.hpp | 6 + .../creatures/player/party_functions.cpp | 44 +- .../creatures/player/party_functions.hpp | 6 + .../creatures/player/player_functions.cpp | 907 +++++----- .../creatures/player/player_functions.hpp | 7 +- .../creatures/player/vocation_functions.cpp | 58 +- .../creatures/player/vocation_functions.hpp | 6 + src/lua/functions/events/action_functions.cpp | 30 +- src/lua/functions/events/action_functions.hpp | 6 + .../events/creature_event_functions.cpp | 10 +- .../events/creature_event_functions.hpp | 6 + .../events/event_callback_functions.cpp | 7 +- .../events/event_callback_functions.hpp | 8 +- src/lua/functions/events/events_functions.hpp | 8 +- .../events/events_scheduler_functions.hpp | 6 + .../events/global_event_functions.cpp | 23 +- .../events/global_event_functions.hpp | 6 + .../functions/events/move_event_functions.cpp | 34 +- .../functions/events/move_event_functions.hpp | 6 + .../events/talk_action_functions.cpp | 26 +- .../events/talk_action_functions.hpp | 6 + .../functions/items/container_functions.cpp | 66 +- .../functions/items/container_functions.hpp | 7 +- .../functions/items/imbuement_functions.cpp | 20 +- .../functions/items/imbuement_functions.hpp | 6 + .../items/item_classification_functions.cpp | 2 +- .../items/item_classification_functions.hpp | 6 + src/lua/functions/items/item_functions.cpp | 170 +- src/lua/functions/items/item_functions.hpp | 6 + .../functions/items/item_type_functions.cpp | 114 +- .../functions/items/item_type_functions.hpp | 6 + src/lua/functions/items/weapon_functions.cpp | 51 +- src/lua/functions/items/weapon_functions.hpp | 6 + src/lua/functions/lua_functions_loader.cpp | 56 +- src/lua/functions/lua_functions_loader.hpp | 12 +- src/lua/functions/map/house_functions.cpp | 50 +- src/lua/functions/map/house_functions.hpp | 6 + src/lua/functions/map/map_functions.hpp | 8 +- src/lua/functions/map/position_functions.cpp | 26 +- src/lua/functions/map/position_functions.hpp | 8 +- src/lua/functions/map/teleport_functions.cpp | 8 +- src/lua/functions/map/teleport_functions.hpp | 6 + src/lua/functions/map/tile_functions.cpp | 138 +- src/lua/functions/map/tile_functions.hpp | 6 + src/lua/functions/map/town_functions.hpp | 7 +- src/lua/global/baseevents.cpp | 18 +- src/lua/global/baseevents.hpp | 8 +- src/lua/global/globalevent.cpp | 32 +- src/lua/global/globalevent.hpp | 6 +- src/lua/modules/modules.cpp | 94 +- src/lua/modules/modules.hpp | 27 +- src/lua/scripts/lua_environment.cpp | 16 +- src/lua/scripts/lua_environment.hpp | 14 +- src/lua/scripts/luascript.cpp | 20 +- src/lua/scripts/luascript.hpp | 10 +- src/lua/scripts/script_environment.cpp | 48 +- src/lua/scripts/script_environment.hpp | 22 +- src/lua/scripts/scripts.cpp | 8 +- src/lua/scripts/scripts.hpp | 2 +- src/map/house/house.cpp | 130 +- src/map/house/house.hpp | 50 +- src/map/house/housetile.cpp | 42 +- src/map/house/housetile.hpp | 14 +- src/map/map.cpp | 70 +- src/map/map.hpp | 12 +- src/map/mapcache.cpp | 26 +- src/map/mapcache.hpp | 12 +- src/map/spectators.hpp | 4 +- src/map/town.hpp | 13 +- src/map/utils/astarnodes.cpp | 22 +- src/map/utils/astarnodes.hpp | 6 +- src/map/utils/mapsector.cpp | 4 +- src/map/utils/mapsector.hpp | 46 +- src/pch.hpp | 18 +- src/security/argon.cpp | 23 +- src/security/argon.hpp | 8 +- src/security/rsa.cpp | 26 +- src/security/rsa.hpp | 6 +- src/server/network/connection/connection.cpp | 4 +- src/server/network/connection/connection.hpp | 2 +- src/server/network/message/outputmessage.cpp | 12 +- src/server/network/message/outputmessage.hpp | 3 +- src/server/network/protocol/protocol.cpp | 24 +- src/server/network/protocol/protocol.hpp | 3 +- src/server/network/protocol/protocolgame.cpp | 362 ++-- src/server/network/protocol/protocolgame.hpp | 138 +- src/server/network/protocol/protocollogin.cpp | 8 +- src/server/network/protocol/protocollogin.hpp | 10 +- .../network/protocol/protocolstatus.cpp | 18 +- .../network/protocol/protocolstatus.hpp | 4 +- src/server/network/webhook/webhook.cpp | 26 +- src/server/network/webhook/webhook.hpp | 2 +- src/server/server.cpp | 24 +- src/server/server.hpp | 11 +- src/utils/CMakeLists.txt | 1 + src/utils/arraylist.hpp | 2 +- src/utils/benchmark.hpp | 3 +- src/utils/counter_pointer.cpp | 31 + src/utils/counter_pointer.hpp | 34 + src/utils/hash.hpp | 12 +- src/utils/lockfree.hpp | 68 + src/utils/pugicast.hpp | 2 +- src/utils/simd.hpp | 4 +- src/utils/tools.cpp | 284 ++-- src/utils/tools.hpp | 10 +- src/utils/vectorsort.hpp | 2 +- src/utils/wildcardtree.cpp | 22 +- src/utils/wildcardtree.hpp | 2 +- vcpkg.json | 1 + 339 files changed, 8989 insertions(+), 8206 deletions(-) create mode 100644 src/utils/counter_pointer.cpp create mode 100644 src/utils/counter_pointer.hpp create mode 100644 src/utils/lockfree.hpp diff --git a/cmake/modules/CanaryLib.cmake b/cmake/modules/CanaryLib.cmake index 3e168d0569b..916970c37ea 100644 --- a/cmake/modules/CanaryLib.cmake +++ b/cmake/modules/CanaryLib.cmake @@ -62,6 +62,7 @@ target_include_directories(${PROJECT_NAME}_lib ${GMP_INCLUDE_DIRS} ${LUAJIT_INCLUDE_DIRS} ${PARALLEL_HASHMAP_INCLUDE_DIRS} + ${ATOMIC_QUEUE_INCLUDE_DIRS} ) # ***************************************************************************** diff --git a/src/creatures/combat/combat.cpp b/src/creatures/combat/combat.cpp index 9aefb280bbf..c65fdf7f053 100644 --- a/src/creatures/combat/combat.cpp +++ b/src/creatures/combat/combat.cpp @@ -24,7 +24,7 @@ #include "lua/callbacks/event_callback.hpp" #include "lua/callbacks/events_callbacks.hpp" -int32_t Combat::getLevelFormula(std::shared_ptr player, const std::shared_ptr wheelSpell, const CombatDamage &damage) const { +int32_t Combat::getLevelFormula(const std::shared_ptr &player, const std::shared_ptr &wheelSpell, const CombatDamage &damage) const { if (!player) { return 0; } @@ -43,7 +43,7 @@ int32_t Combat::getLevelFormula(std::shared_ptr player, const std::share return levelFormula; } -CombatDamage Combat::getCombatDamage(std::shared_ptr creature, std::shared_ptr target) const { +CombatDamage Combat::getCombatDamage(const std::shared_ptr &creature, const std::shared_ptr &target) const { CombatDamage damage; damage.origin = params.origin; damage.primary.type = params.combatType; @@ -66,7 +66,7 @@ CombatDamage Combat::getCombatDamage(std::shared_ptr creature, std::sh int32_t min, max; if (creature->getCombatValues(min, max)) { damage.primary.value = normal_random(min, max); - } else if (std::shared_ptr player = creature->getPlayer()) { + } else if (const auto &player = creature->getPlayer()) { if (params.valueCallback) { params.valueCallback->getMinMaxValues(player, damage, params.useCharges); } else if (formulaType == COMBAT_FORMULA_LEVELMAGIC) { @@ -76,8 +76,8 @@ CombatDamage Combat::getCombatDamage(std::shared_ptr creature, std::sh static_cast(levelFormula * maxa + maxb) ); } else if (formulaType == COMBAT_FORMULA_SKILL) { - std::shared_ptr tool = player->getWeapon(); - const WeaponShared_ptr weapon = g_weapons().getWeapon(tool); + const auto &tool = player->getWeapon(); + const WeaponShared_ptr &weapon = g_weapons().getWeapon(tool); if (weapon) { damage.primary.value = normal_random( static_cast(minb), @@ -184,7 +184,7 @@ ConditionType_t Combat::DamageToConditionType(CombatType_t type) { } } -bool Combat::isPlayerCombat(std::shared_ptr target) { +bool Combat::isPlayerCombat(const std::shared_ptr &target) { if (target->getPlayer()) { return true; } @@ -196,7 +196,7 @@ bool Combat::isPlayerCombat(std::shared_ptr target) { return false; } -ReturnValue Combat::canTargetCreature(std::shared_ptr player, std::shared_ptr target) { +ReturnValue Combat::canTargetCreature(const std::shared_ptr &player, const std::shared_ptr &target) { if (player == target) { return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER; } @@ -241,10 +241,10 @@ ReturnValue Combat::canTargetCreature(std::shared_ptr player, std::share } } - return Combat::canDoCombat(player, target, true); + return canDoCombat(player, target, true); } -ReturnValue Combat::canDoCombat(std::shared_ptr caster, std::shared_ptr tile, bool aggressive) { +ReturnValue Combat::canDoCombat(const std::shared_ptr &caster, const std::shared_ptr &tile, bool aggressive) { if (tile->hasProperty(CONST_PROP_BLOCKPROJECTILE)) { return RETURNVALUE_NOTENOUGHROOM; } @@ -269,7 +269,7 @@ ReturnValue Combat::canDoCombat(std::shared_ptr caster, std::shared_pt return RETURNVALUE_FIRSTGOUPSTAIRS; } - if (std::shared_ptr player = caster->getPlayer()) { + if (const auto &player = caster->getPlayer()) { if (player->hasFlag(PlayerFlags_t::IgnoreProtectionZone)) { return RETURNVALUE_NOERROR; } @@ -282,11 +282,11 @@ ReturnValue Combat::canDoCombat(std::shared_ptr caster, std::shared_pt return ret; } -bool Combat::isInPvpZone(std::shared_ptr attacker, std::shared_ptr target) { +bool Combat::isInPvpZone(const std::shared_ptr &attacker, const std::shared_ptr &target) { return attacker->getZoneType() == ZONE_PVP && target->getZoneType() == ZONE_PVP; } -bool Combat::isProtected(std::shared_ptr attacker, std::shared_ptr target) { +bool Combat::isProtected(const std::shared_ptr &attacker, const std::shared_ptr &target) { uint32_t protectionLevel = g_configManager().getNumber(PROTECTION_LEVEL); if (target->getLevel() < protectionLevel || attacker->getLevel() < protectionLevel) { return true; @@ -303,33 +303,33 @@ bool Combat::isProtected(std::shared_ptr attacker, std::shared_ptr attacker, std::shared_ptr target, bool aggressive) { +ReturnValue Combat::canDoCombat(const std::shared_ptr &attacker, const std::shared_ptr &target, bool aggressive) { if (!aggressive) { return RETURNVALUE_NOERROR; } - auto targetPlayer = target ? target->getPlayer() : nullptr; + const auto &targetPlayer = target ? target->getPlayer() : nullptr; if (target) { - std::shared_ptr tile = target->getTile(); + const std::shared_ptr &tile = target->getTile(); if (tile->hasProperty(CONST_PROP_BLOCKPROJECTILE)) { return RETURNVALUE_NOTENOUGHROOM; } - if (tile->hasFlag(TILESTATE_PROTECTIONZONE)) { - auto permittedOnPz = targetPlayer ? targetPlayer->hasPermittedConditionInPZ() : false; + if (targetPlayer && tile->hasFlag(TILESTATE_PROTECTIONZONE)) { + const auto permittedOnPz = targetPlayer->hasPermittedConditionInPZ(); return permittedOnPz ? RETURNVALUE_NOERROR : RETURNVALUE_ACTIONNOTPERMITTEDINPROTECTIONZONE; } } if (attacker) { - const std::shared_ptr attackerMaster = attacker->getMaster(); + const auto &attackerMaster = attacker->getMaster(); + const auto &attackerPlayer = attacker->getPlayer(); if (targetPlayer) { if (targetPlayer->hasFlag(PlayerFlags_t::CannotBeAttacked)) { return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER; } - const std::shared_ptr targetPlayerTile = targetPlayer->getTile(); - - if (const std::shared_ptr attackerPlayer = attacker->getPlayer()) { + const auto &targetPlayerTile = targetPlayer->getTile(); + if (attackerPlayer) { if (attackerPlayer->hasFlag(PlayerFlags_t::CannotAttackPlayer)) { return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER; } @@ -339,7 +339,7 @@ ReturnValue Combat::canDoCombat(std::shared_ptr attacker, std::shared_ } // nopvp-zone - auto attackerTile = attackerPlayer->getTile(); + const auto &attackerTile = attackerPlayer->getTile(); if (targetPlayerTile && targetPlayerTile->hasFlag(TILESTATE_NOPVPZONE)) { return RETURNVALUE_ACTIONNOTPERMITTEDINANOPVPZONE; } else if (attackerTile && attackerTile->hasFlag(TILESTATE_NOPVPZONE) && targetPlayerTile && !targetPlayerTile->hasFlag(TILESTATE_NOPVPZONE | TILESTATE_PROTECTIONZONE)) { @@ -352,7 +352,7 @@ ReturnValue Combat::canDoCombat(std::shared_ptr attacker, std::shared_ } if (attackerMaster) { - if (const std::shared_ptr masterAttackerPlayer = attackerMaster->getPlayer()) { + if (const auto &masterAttackerPlayer = attackerMaster->getPlayer()) { if (masterAttackerPlayer->hasFlag(PlayerFlags_t::CannotAttackPlayer)) { return RETURNVALUE_YOUMAYNOTATTACKTHISPLAYER; } @@ -377,7 +377,7 @@ ReturnValue Combat::canDoCombat(std::shared_ptr attacker, std::shared_ return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE; } - if (const std::shared_ptr attackerPlayer = attacker->getPlayer()) { + if (attackerPlayer) { if (attackerPlayer->hasFlag(PlayerFlags_t::CannotAttackMonster)) { return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE; } @@ -386,7 +386,7 @@ ReturnValue Combat::canDoCombat(std::shared_ptr attacker, std::shared_ return RETURNVALUE_ACTIONNOTPERMITTEDINANOPVPZONE; } } else if (attacker->getMonster()) { - const std::shared_ptr targetMaster = target->getMaster(); + const auto &targetMaster = target->getMaster(); if ((!targetMaster || !targetMaster->getPlayer()) && attacker->getFaction() == FACTION_DEFAULT) { if (!attackerMaster || !attackerMaster->getPlayer()) { @@ -540,7 +540,7 @@ void Combat::setChainCallback(uint8_t chainTargets, uint8_t chainDistance, bool g_logger().trace("ChainCallback created: {}, with targets: {}, distance: {}, backtracking: {}", params.chainCallback != nullptr, chainTargets, chainDistance, backtracking); } -CallBack* Combat::getCallback(CallBackParam_t key) { +CallBack* Combat::getCallback(CallBackParam_t key) const { switch (key) { case CALLBACK_PARAM_LEVELMAGICVALUE: case CALLBACK_PARAM_SKILLVALUE: { @@ -566,7 +566,7 @@ CallBack* Combat::getCallback(CallBackParam_t key) { return nullptr; } -void Combat::CombatHealthFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* data) { +void Combat::CombatHealthFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* data) { if (!data) { g_logger().error("[{}]: CombatDamage is nullptr", __FUNCTION__); return; @@ -600,7 +600,7 @@ void Combat::CombatHealthFunc(std::shared_ptr caster, std::shared_ptr< g_logger().trace("[{}] (new) eventcallback: 'creatureOnCombat', damage primary: '{}', secondary: '{}'", __FUNCTION__, damage.primary.value, damage.secondary.value); if (attackerPlayer) { - std::shared_ptr item = attackerPlayer->getWeapon(); + const auto &item = attackerPlayer->getWeapon(); damage = applyImbuementElementalDamage(attackerPlayer, item, damage); g_events().eventPlayerOnCombat(attackerPlayer, target, item, damage); g_callbacks().executeCallback(EventCallback_t::playerOnCombat, &EventCallback::playerOnCombat, attackerPlayer, target, item, std::ref(damage)); @@ -624,7 +624,7 @@ void Combat::CombatHealthFunc(std::shared_ptr caster, std::shared_ptr< // Player attacking monster if (attackerPlayer && targetMonster) { - const std::unique_ptr &slot = attackerPlayer->getPreyWithMonster(targetMonster->getRaceId()); + const auto &slot = attackerPlayer->getPreyWithMonster(targetMonster->getRaceId()); if (slot && slot->isOccupied() && slot->bonus == PreyBonus_Damage && slot->bonusTimeLeft > 0) { damage.primary.value += static_cast(std::ceil((damage.primary.value * slot->bonusPercentage) / 100)); damage.secondary.value += static_cast(std::ceil((damage.secondary.value * slot->bonusPercentage) / 100)); @@ -636,7 +636,7 @@ void Combat::CombatHealthFunc(std::shared_ptr caster, std::shared_ptr< // Monster attacking player if (attackerMonster && targetPlayer) { - const std::unique_ptr &slot = targetPlayer->getPreyWithMonster(attackerMonster->getRaceId()); + const auto &slot = targetPlayer->getPreyWithMonster(attackerMonster->getRaceId()); if (slot && slot->isOccupied() && slot->bonus == PreyBonus_Defense && slot->bonusTimeLeft > 0) { damage.primary.value -= static_cast(std::ceil((damage.primary.value * slot->bonusPercentage) / 100)); damage.secondary.value -= static_cast(std::ceil((damage.secondary.value * slot->bonusPercentage) / 100)); @@ -649,7 +649,7 @@ void Combat::CombatHealthFunc(std::shared_ptr caster, std::shared_ptr< } } -CombatDamage Combat::applyImbuementElementalDamage(std::shared_ptr attackerPlayer, std::shared_ptr item, CombatDamage damage) { +CombatDamage Combat::applyImbuementElementalDamage(const std::shared_ptr &attackerPlayer, std::shared_ptr item, CombatDamage damage) { if (!item) { return damage; } @@ -691,7 +691,7 @@ CombatDamage Combat::applyImbuementElementalDamage(std::shared_ptr attac return damage; } -void Combat::CombatManaFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* data) { +void Combat::CombatManaFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* data) { if (!data) { g_logger().error("[{}]: CombatDamage is nullptr", __FUNCTION__); return; @@ -710,7 +710,7 @@ void Combat::CombatManaFunc(std::shared_ptr caster, std::shared_ptr player) { +bool Combat::checkFearConditionAffected(const std::shared_ptr &player) { if (player->isImmuneFear()) { return false; } @@ -719,7 +719,7 @@ bool Combat::checkFearConditionAffected(std::shared_ptr player) { return false; } - auto party = player->getParty(); + const auto &party = player->getParty(); if (party) { auto affectedCount = (party->getMemberCount() + 5) / 5; g_logger().debug("[{}] Player is member of a party, {} members can be feared", __FUNCTION__, affectedCount); @@ -738,7 +738,7 @@ bool Combat::checkFearConditionAffected(std::shared_ptr player) { return true; } -void Combat::CombatConditionFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* data) { +void Combat::CombatConditionFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* data) { if (params.origin == ORIGIN_MELEE && data && data->primary.value == 0 && data->secondary.value == 0) { return; } @@ -756,7 +756,7 @@ void Combat::CombatConditionFunc(std::shared_ptr caster, std::shared_p } else if (caster && caster->getMonster()) { uint16_t playerCharmRaceid = player->parseRacebyCharm(CHARM_CLEANSE, false, 0); if (playerCharmRaceid != 0) { - const auto mType = g_monsters().getMonsterType(caster->getName()); + const auto &mType = g_monsters().getMonsterType(caster->getName()); if (mType && playerCharmRaceid == mType->info.raceid) { const auto charm = g_iobestiary().getBestiaryCharm(CHARM_CLEANSE); if (charm && (charm->chance > normal_random(0, 100))) { @@ -791,18 +791,18 @@ void Combat::CombatConditionFunc(std::shared_ptr caster, std::shared_p } } -void Combat::CombatDispelFunc(std::shared_ptr, std::shared_ptr target, const CombatParams ¶ms, CombatDamage*) { +void Combat::CombatDispelFunc(const std::shared_ptr &, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage*) { if (target) { target->removeCombatCondition(params.dispelType); } } -void Combat::CombatNullFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage*) { +void Combat::CombatNullFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage*) { CombatConditionFunc(caster, target, params, nullptr); CombatDispelFunc(caster, target, params, nullptr); } -void Combat::combatTileEffects(const CreatureVector &spectators, std::shared_ptr caster, std::shared_ptr tile, const CombatParams ¶ms) { +void Combat::combatTileEffects(const CreatureVector &spectators, const std::shared_ptr &caster, const std::shared_ptr &tile, const CombatParams ¶ms) { if (params.itemId != 0) { uint16_t itemId = params.itemId; switch (itemId) { @@ -865,7 +865,7 @@ void Combat::combatTileEffects(const CreatureVector &spectators, std::shared_ptr } } - std::shared_ptr item = Item::CreateItem(itemId); + const auto &item = Item::CreateItem(itemId); if (caster) { item->setOwner(caster); } @@ -891,7 +891,7 @@ void Combat::combatTileEffects(const CreatureVector &spectators, std::shared_ptr } } -void Combat::postCombatEffects(std::shared_ptr caster, const Position &origin, const Position &pos, const CombatParams ¶ms) { +void Combat::postCombatEffects(const std::shared_ptr &caster, const Position &origin, const Position &pos, const CombatParams ¶ms) { if (caster && params.distanceEffect != CONST_ANI_NONE) { addDistanceEffect(caster, origin, pos, params.distanceEffect); } @@ -903,13 +903,13 @@ void Combat::postCombatEffects(std::shared_ptr caster, const Position } } -void Combat::addDistanceEffect(std::shared_ptr caster, const Position &fromPos, const Position &toPos, uint16_t effect) { +void Combat::addDistanceEffect(const std::shared_ptr &caster, const Position &fromPos, const Position &toPos, uint16_t effect) { if (effect == CONST_ANI_WEAPONTYPE) { if (!caster) { return; } - std::shared_ptr player = caster->getPlayer(); + const auto &player = caster->getPlayer(); if (!player) { return; } @@ -953,7 +953,7 @@ void Combat::doChainEffect(const Position &origin, const Position &dest, uint8_t fpp.maxSearchDist = 9; Position pos = origin; if (g_game().map.getPathMatching(origin, dirList, FrozenPathingConditionCall(dest), fpp)) { - for (auto dir : dirList) { + for (const auto &dir : dirList) { pos = getNextPosition(dir, pos); g_game().addMagicEffect(pos, effect); } @@ -1038,7 +1038,7 @@ void Combat::setupChain(const std::shared_ptr &weapon) { } } -bool Combat::doCombatChain(std::shared_ptr caster, std::shared_ptr target, bool aggressive) const { +bool Combat::doCombatChain(const std::shared_ptr &caster, const std::shared_ptr &target, bool aggressive) const { metrics::method_latency measure(__METHOD_NAME__); if (!params.chainCallback) { return false; @@ -1048,7 +1048,7 @@ bool Combat::doCombatChain(std::shared_ptr caster, std::shared_ptrgetChainValues(caster, maxTargets, chainDistance, backtracking); - auto targets = pickChainTargets(caster, params, chainDistance, maxTargets, aggressive, backtracking, std::move(target)); + auto targets = pickChainTargets(caster, params, chainDistance, maxTargets, aggressive, backtracking, target); g_logger().debug("[{}] Chain targets: {}", __FUNCTION__, targets.size()); if (targets.empty() || (targets.size() == 1 && targets.begin()->second.empty())) { @@ -1057,11 +1057,11 @@ bool Combat::doCombatChain(std::shared_ptr caster, std::shared_ptr(50, g_configManager().getNumber(COMBAT_CHAIN_DELAY)); ++i; - for (auto to : toVector) { + for (const auto &to : toVector) { auto nextTarget = g_game().getCreatureByID(to); if (!nextTarget) { continue; @@ -1069,7 +1069,7 @@ bool Combat::doCombatChain(std::shared_ptr caster, std::shared_ptrdoChainEffect(from, nextTarget->getPosition(), combat->params.chainEffect); + Combat::doChainEffect(from, nextTarget->getPosition(), combat->params.chainEffect); combat->doCombat(caster, nextTarget, from, affected); } }, @@ -1081,7 +1081,7 @@ bool Combat::doCombatChain(std::shared_ptr caster, std::shared_ptr caster, std::shared_ptr target) const { +bool Combat::doCombat(const std::shared_ptr &caster, const std::shared_ptr &target) const { if (caster != nullptr && params.chainCallback) { return doCombatChain(caster, target, params.aggressive); } @@ -1089,7 +1089,7 @@ bool Combat::doCombat(std::shared_ptr caster, std::shared_ptrgetPosition() : Position()); } -bool Combat::doCombat(std::shared_ptr caster, std::shared_ptr target, const Position &origin, int affected /* = 1 */) const { +bool Combat::doCombat(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, int affected /* = 1 */) const { // target combat callback function if (params.combatType != COMBAT_NONE) { CombatDamage damage = getCombatDamage(caster, target); @@ -1106,7 +1106,7 @@ bool Combat::doCombat(std::shared_ptr caster, std::shared_ptr caster, const Position &position) const { +bool Combat::doCombat(const std::shared_ptr &caster, const Position &position) const { if (caster != nullptr && params.chainCallback) { return doCombatChain(caster, caster, params.aggressive); } @@ -1127,7 +1127,7 @@ bool Combat::doCombat(std::shared_ptr caster, const Position &position return true; } -void Combat::CombatFunc(std::shared_ptr caster, const Position &origin, const Position &pos, const std::unique_ptr &area, const CombatParams ¶ms, CombatFunction func, CombatDamage* data) { +void Combat::CombatFunc(const std::shared_ptr &caster, const Position &origin, const Position &pos, const std::unique_ptr &area, const CombatParams ¶ms, const CombatFunction &func, CombatDamage* data) { std::vector> tileList; if (caster) { @@ -1140,7 +1140,7 @@ void Combat::CombatFunc(std::shared_ptr caster, const Position &origin uint32_t maxY = 0; // calculate the max viewable range - for (const std::shared_ptr &tile : tileList) { + for (const auto &tile : tileList) { const Position &tilePos = tile->getPosition(); uint32_t diff = Position::getDistanceX(tilePos, pos); @@ -1158,16 +1158,16 @@ void Combat::CombatFunc(std::shared_ptr caster, const Position &origin const int32_t rangeY = maxY + MAP_MAX_VIEW_PORT_Y; int affected = 0; - for (const std::shared_ptr &tile : tileList) { + for (const auto &tile : tileList) { if (canDoCombat(caster, tile, params.aggressive) != RETURNVALUE_NOERROR) { continue; } if (CreatureVector* creatures = tile->getCreatures()) { - const std::shared_ptr topCreature = tile->getTopCreature(); + const auto &topCreature = tile->getTopCreature(); // A copy of the tile's creature list is made because modifications to this vector, such as adding or removing creatures through a Lua callback, may occur during the iteration within the for loop. CreatureVector creaturesCopy = *creatures; - for (auto &creature : creaturesCopy) { + for (const auto &creature : creaturesCopy) { if (params.targetCasterOrTopMost) { if (caster && caster->getTile() == tile) { if (creature != caster) { @@ -1210,21 +1210,21 @@ void Combat::CombatFunc(std::shared_ptr caster, const Position &origin // Wheel of destiny get beam affected total auto spectators = Spectators().find(pos, true, rangeX, rangeX, rangeY, rangeY); - std::shared_ptr casterPlayer = caster ? caster->getPlayer() : nullptr; + const std::shared_ptr &casterPlayer = caster ? caster->getPlayer() : nullptr; uint8_t beamAffectedTotal = casterPlayer ? casterPlayer->wheel()->getBeamAffectedTotal(tmpDamage) : 0; uint8_t beamAffectedCurrent = 0; tmpDamage.affected = affected; - for (const std::shared_ptr &tile : tileList) { + for (const auto &tile : tileList) { if (canDoCombat(caster, tile, params.aggressive) != RETURNVALUE_NOERROR) { continue; } if (CreatureVector* creatures = tile->getCreatures()) { - const std::shared_ptr topCreature = tile->getTopCreature(); + const auto &topCreature = tile->getTopCreature(); // A copy of the tile's creature list is made because modifications to this vector, such as adding or removing creatures through a Lua callback, may occur during the iteration within the for loop. CreatureVector creaturesCopy = *creatures; - for (auto &creature : creaturesCopy) { + for (const auto &creature : creaturesCopy) { if (params.targetCasterOrTopMost) { if (caster && caster->getTile() == tile) { if (creature != caster) { @@ -1262,11 +1262,11 @@ void Combat::CombatFunc(std::shared_ptr caster, const Position &origin postCombatEffects(caster, origin, pos, params); } -void Combat::doCombatHealth(std::shared_ptr caster, std::shared_ptr target, CombatDamage &damage, const CombatParams ¶ms) { - doCombatHealth(caster, std::move(target), caster ? caster->getPosition() : Position(), damage, params); +void Combat::doCombatHealth(const std::shared_ptr &caster, const std::shared_ptr &target, CombatDamage &damage, const CombatParams ¶ms) { + doCombatHealth(caster, target, caster ? caster->getPosition() : Position(), damage, params); } -void Combat::doCombatHealth(std::shared_ptr caster, std::shared_ptr target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms) { +void Combat::doCombatHealth(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms) { bool canCombat = !params.aggressive || (caster != target && Combat::canDoCombat(caster, target, params.aggressive) == RETURNVALUE_NOERROR); if ((caster && target) && (caster == target || canCombat) @@ -1300,17 +1300,17 @@ void Combat::doCombatHealth(std::shared_ptr caster, std::shared_ptr caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms) { +void Combat::doCombatHealth(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms) { applyExtensions(caster, nullptr, damage, params); const auto origin = caster ? caster->getPosition() : Position(); CombatFunc(caster, origin, position, area, params, CombatHealthFunc, &damage); } -void Combat::doCombatMana(std::shared_ptr caster, std::shared_ptr target, CombatDamage &damage, const CombatParams ¶ms) { +void Combat::doCombatMana(const std::shared_ptr &caster, const std::shared_ptr &target, CombatDamage &damage, const CombatParams ¶ms) { doCombatMana(caster, target, caster ? caster->getPosition() : Position(), damage, params); } -void Combat::doCombatMana(std::shared_ptr caster, std::shared_ptr target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms) { +void Combat::doCombatMana(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms) { bool canCombat = !params.aggressive || (caster != target && Combat::canDoCombat(caster, target, params.aggressive) == RETURNVALUE_NOERROR); if ((caster && target) && (caster == target || canCombat) @@ -1338,18 +1338,18 @@ void Combat::doCombatMana(std::shared_ptr caster, std::shared_ptr caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms) { +void Combat::doCombatMana(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms) { applyExtensions(caster, nullptr, damage, params); const auto origin = caster ? caster->getPosition() : Position(); CombatFunc(caster, origin, position, area, params, CombatManaFunc, &damage); } -void Combat::doCombatCondition(std::shared_ptr caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms) { +void Combat::doCombatCondition(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms) { const auto origin = caster ? caster->getPosition() : Position(); CombatFunc(caster, origin, position, area, params, CombatConditionFunc, nullptr); } -void Combat::doCombatCondition(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms) { +void Combat::doCombatCondition(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms) { bool canCombat = !params.aggressive || (caster != target && Combat::canDoCombat(caster, target, params.aggressive) == RETURNVALUE_NOERROR); if ((caster == target || canCombat) && params.impactEffect != CONST_ME_NONE) { g_game().addMagicEffect(target->getPosition(), params.impactEffect); @@ -1373,12 +1373,12 @@ void Combat::doCombatCondition(std::shared_ptr caster, std::shared_ptr } } -void Combat::doCombatDispel(std::shared_ptr caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms) { +void Combat::doCombatDispel(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms) { const auto origin = caster ? caster->getPosition() : Position(); CombatFunc(caster, origin, position, area, params, CombatDispelFunc, nullptr); } -void Combat::doCombatDispel(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms) { +void Combat::doCombatDispel(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms) { bool canCombat = !params.aggressive || (caster != target && Combat::canDoCombat(caster, target, params.aggressive) == RETURNVALUE_NOERROR); if ((caster && target) && (caster == target || canCombat) @@ -1404,11 +1404,11 @@ void Combat::doCombatDispel(std::shared_ptr caster, std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms) { +[[maybe_unused]] void Combat::doCombatDefault(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms) { doCombatDefault(caster, target, caster ? caster->getPosition() : Position(), params); } -void Combat::doCombatDefault(std::shared_ptr caster, std::shared_ptr target, const Position &origin, const CombatParams ¶ms) { +void Combat::doCombatDefault(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, const CombatParams ¶ms) { if (!params.aggressive || (caster != target && Combat::canDoCombat(caster, target, params.aggressive) == RETURNVALUE_NOERROR)) { auto spectators = Spectators().find(target->getPosition(), true); @@ -1445,7 +1445,7 @@ void Combat::setRuneSpellName(const std::string &value) { runeSpellName = value; } -std::vector>> Combat::pickChainTargets(std::shared_ptr caster, const CombatParams ¶ms, uint8_t chainDistance, uint8_t maxTargets, bool backtracking, bool aggressive, std::shared_ptr initialTarget /* = nullptr */) { +std::vector>> Combat::pickChainTargets(const std::shared_ptr &caster, const CombatParams ¶ms, uint8_t chainDistance, uint8_t maxTargets, bool backtracking, bool aggressive, const std::shared_ptr &initialTarget /* = nullptr */) { Benchmark bm_pickChain; metrics::method_latency measure(__METHOD_NAME__); if (!caster) { @@ -1457,11 +1457,11 @@ std::vector>> Combat::pickChainTargets phmap::flat_hash_set visited; if (initialTarget && initialTarget != caster) { - targets.push_back(initialTarget); + targets.emplace_back(initialTarget); visited.insert(initialTarget->getID()); - resultMap.push_back({ caster->getPosition(), { initialTarget->getID() } }); + resultMap.emplace_back(caster->getPosition(), std::vector { initialTarget->getID() }); } else { - targets.push_back(caster); + targets.emplace_back(caster); maxTargets++; } @@ -1495,19 +1495,20 @@ std::vector>> Combat::pickChainTargets bool found = false; for (auto &[pos, vec] : resultMap) { if (pos == currentTarget->getPosition()) { - vec.push_back(closestSpectator->getID()); + vec.emplace_back(closestSpectator->getID()); found = true; break; } } if (!found) { - resultMap.push_back({ currentTarget->getPosition(), { closestSpectator->getID() } }); + resultMap.emplace_back(currentTarget->getPosition(), std::vector { closestSpectator->getID() }); } - targets.push_back(closestSpectator); + targets.emplace_back(closestSpectator); visited.insert(closestSpectator->getID()); continue; - } else if (backtracking) { + } + if (backtracking) { g_logger().debug("[{}] backtracking", __METHOD_NAME__); targets.pop_back(); backtrackingAttempts--; @@ -1520,7 +1521,7 @@ std::vector>> Combat::pickChainTargets return resultMap; } -bool Combat::isValidChainTarget(std::shared_ptr caster, std::shared_ptr currentTarget, std::shared_ptr potentialTarget, const CombatParams ¶ms, bool aggressive) { +bool Combat::isValidChainTarget(const std::shared_ptr &caster, const std::shared_ptr ¤tTarget, const std::shared_ptr &potentialTarget, const CombatParams ¶ms, bool aggressive) { bool canCombat = canDoCombat(caster, potentialTarget, aggressive) == RETURNVALUE_NOERROR; bool pick = params.chainPickerCallback ? params.chainPickerCallback->onChainCombat(caster, potentialTarget) : true; bool hasSight = g_game().isSightClear(currentTarget->getPosition(), potentialTarget->getPosition(), true); @@ -1529,7 +1530,7 @@ bool Combat::isValidChainTarget(std::shared_ptr caster, std::shared_pt //**********************************************************// -uint32_t ValueCallback::getMagicLevelSkill(std::shared_ptr player, const CombatDamage &damage) const { +uint32_t ValueCallback::getMagicLevelSkill(const std::shared_ptr &player, const CombatDamage &damage) const { if (!player) { return 0; } @@ -1537,9 +1538,9 @@ uint32_t ValueCallback::getMagicLevelSkill(std::shared_ptr player, const uint32_t magicLevelSkill = player->getMagicLevel(); // Wheel of destiny if (player && player->wheel()->getInstant("Runic Mastery") && damage.instantSpellName.empty()) { - const std::shared_ptr spell = g_spells().getRuneSpellByName(damage.runeSpellName); + const std::shared_ptr &spell = g_spells().getRuneSpellByName(damage.runeSpellName); // Rune conjuring spell have the same name as the rune item spell. - const std::shared_ptr conjuringSpell = g_spells().getInstantSpellByName(damage.runeSpellName); + const std::shared_ptr &conjuringSpell = g_spells().getInstantSpellByName(damage.runeSpellName); if (spell && conjuringSpell && conjuringSpell != spell && normal_random(0, 100) <= 25) { uint32_t castResult = conjuringSpell->canCast(player) ? 20 : 10; magicLevelSkill += magicLevelSkill * castResult / 100; @@ -1549,18 +1550,18 @@ uint32_t ValueCallback::getMagicLevelSkill(std::shared_ptr player, const return magicLevelSkill + player->getSpecializedMagicLevel(damage.primary.type, true); } -void ValueCallback::getMinMaxValues(std::shared_ptr player, CombatDamage &damage, bool useCharges) const { +void ValueCallback::getMinMaxValues(const std::shared_ptr &player, CombatDamage &damage, bool useCharges) const { // onGetPlayerMinMaxValues(...) - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[ValueCallback::getMinMaxValues - Player {} formula {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), fmt::underlying(type)); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); if (!env->setCallbackId(scriptId, scriptInterface)) { - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return; } @@ -1587,7 +1588,7 @@ void ValueCallback::getMinMaxValues(std::shared_ptr player, CombatDamage case COMBAT_FORMULA_SKILL: { // onGetPlayerMinMaxValues(player, attackSkill, attackValue, attackFactor) - std::shared_ptr tool = player->getWeapon(); + const auto &tool = player->getWeapon(); const auto &weapon = g_weapons().getWeapon(tool); int32_t attackSkill = 0; float attackFactor = 0; @@ -1604,7 +1605,7 @@ void ValueCallback::getMinMaxValues(std::shared_ptr player, CombatDamage default: { g_logger().warn("[ValueCallback::getMinMaxValues] - Unknown callback type"); - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return; } } @@ -1619,7 +1620,7 @@ void ValueCallback::getMinMaxValues(std::shared_ptr player, CombatDamage ); if (shouldCalculateSecondaryDamage) { - double factor = (double)elementAttack / (double)attackValue; // attack value here is phys dmg + element dmg + double factor = static_cast(elementAttack) / static_cast(attackValue); // attack value here is phys dmg + element dmg int32_t elementDamage = std::round(defaultDmg * factor); int32_t physDmg = std::round(defaultDmg * (1.0 - factor)); damage.primary.value = physDmg; @@ -1637,23 +1638,23 @@ void ValueCallback::getMinMaxValues(std::shared_ptr player, CombatDamage LuaScriptInterface::reportError(nullptr, "Stack size changed!"); } - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } //**********************************************************// -void TileCallback::onTileCombat(std::shared_ptr creature, std::shared_ptr tile) const { +void TileCallback::onTileCombat(const std::shared_ptr &creature, const std::shared_ptr &tile) const { // onTileCombat(creature, pos) - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[TileCallback::onTileCombat - Creature {} type {} on tile x: {} y: {} z: {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName(), fmt::underlying(type), (tile->getPosition()).getX(), (tile->getPosition()).getY(), (tile->getPosition()).getZ()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); if (!env->setCallbackId(scriptId, scriptInterface)) { - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return; } @@ -1673,18 +1674,18 @@ void TileCallback::onTileCombat(std::shared_ptr creature, std::shared_ //**********************************************************// -void TargetCallback::onTargetCombat(std::shared_ptr creature, std::shared_ptr target) const { +void TargetCallback::onTargetCombat(const std::shared_ptr &creature, const std::shared_ptr &target) const { // onTargetCombat(creature, target) - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[TargetCallback::onTargetCombat - Creature {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); if (!env->setCallbackId(scriptId, scriptInterface)) { - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return; } @@ -1716,7 +1717,7 @@ void TargetCallback::onTargetCombat(std::shared_ptr creature, std::sha LuaScriptInterface::reportError(nullptr, "Stack size changed!"); } - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } //**********************************************************// @@ -1733,18 +1734,18 @@ void ChainCallback::getChainValues(const std::shared_ptr &creature, ui backtracking = m_backtracking; } } -void ChainCallback::onChainCombat(std::shared_ptr creature, uint8_t &maxTargets, uint8_t &chainDistance, bool &backtracking) { +void ChainCallback::onChainCombat(const std::shared_ptr &creature, uint8_t &maxTargets, uint8_t &chainDistance, bool &backtracking) const { // onChainCombat(creature) - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[ChainCallback::onTargetCombat - Creature {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); if (!env->setCallbackId(scriptId, scriptInterface)) { - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return; } @@ -1772,21 +1773,21 @@ void ChainCallback::onChainCombat(std::shared_ptr creature, uint8_t &m LuaScriptInterface::reportError(nullptr, "Stack size changed!"); } - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -bool ChainPickerCallback::onChainCombat(std::shared_ptr creature, std::shared_ptr target) const { +bool ChainPickerCallback::onChainCombat(const std::shared_ptr &creature, const std::shared_ptr &target) const { // onChainCombat(creature, target) - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[ChainPickerCallback::onTargetCombat - Creature {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName()); return true; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); if (!env->setCallbackId(scriptId, scriptInterface)) { - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return true; } @@ -1821,7 +1822,7 @@ bool ChainPickerCallback::onChainCombat(std::shared_ptr creature, std: LuaScriptInterface::reportError(nullptr, "Stack size changed!"); } - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return result; } @@ -1935,8 +1936,8 @@ void AreaCombat::copyArea(const std::unique_ptr &input, const std::u int32_t newY = y - centerY; // perform rotation - int32_t rotatedX = static_cast(round(newX * a + newY * b)); - int32_t rotatedY = static_cast(round(newX * c + newY * d)); + auto rotatedX = static_cast(round(newX * a + newY * b)); + auto rotatedY = static_cast(round(newX * c + newY * d)); // write in the output matrix using rotated coordinates (*output)[rotatedY + rotateCenterY][rotatedX + rotateCenterX] = (*input)[y][x]; @@ -1979,7 +1980,7 @@ std::unique_ptr AreaCombat::createArea(const std::list &li return area; } -void AreaCombat::setupArea(const std::list &list, uint32_t rows) { +void AreaCombat::setupArea(const std::list &list, const uint32_t rows) { auto northArea = createArea(list, rows); const uint32_t maxOutput = std::max(northArea->getCols(), northArea->getRows()) * 2; @@ -2017,11 +2018,11 @@ void AreaCombat::setupArea(int32_t length, int32_t spread) { for (int32_t x = 1; x <= cols; ++x) { if (y == rows && x == ((cols - (cols % 2)) / 2) + 1) { - list.push_back(3); + list.emplace_back(3); } else if (x >= mincol && x <= maxcol) { - list.push_back(1); + list.emplace_back(1); } else { - list.push_back(0); + list.emplace_back(0); } } @@ -2055,11 +2056,11 @@ void AreaCombat::setupArea(int32_t radius) { for (auto &row : area) { for (int cell : row) { if (cell == 1) { - list.push_back(3); + list.emplace_back(3); } else if (cell > 0 && cell <= radius) { - list.push_back(1); + list.emplace_back(1); } else { - list.push_back(0); + list.emplace_back(0); } } } @@ -2111,17 +2112,17 @@ void MagicField::onStepInField(const std::shared_ptr &creature) { const ItemType &it = items[getID()]; if (it.conditionDamage) { - auto conditionCopy = it.conditionDamage->clone(); + const auto &conditionCopy = it.conditionDamage->clone(); auto ownerId = getOwnerId(); if (ownerId) { bool harmfulField = true; - auto itemTile = getTile(); + const auto &itemTile = getTile(); if (g_game().getWorldType() == WORLD_TYPE_NO_PVP || (itemTile && itemTile->hasFlag(TILESTATE_NOPVPZONE))) { - auto ownerPlayer = g_game().getPlayerByGUID(ownerId); + const auto &ownerPlayer = g_game().getPlayerByGUID(ownerId); if (ownerPlayer) { harmfulField = false; } - auto ownerCreature = g_game().getCreatureByID(ownerId); + const auto &ownerCreature = g_game().getCreatureByID(ownerId); if (ownerCreature) { if (ownerCreature->getPlayer() || (ownerCreature->isSummon() && ownerCreature->getMaster()->getPlayer())) { harmfulField = false; @@ -2129,9 +2130,9 @@ void MagicField::onStepInField(const std::shared_ptr &creature) { } } - std::shared_ptr targetPlayer = creature->getPlayer(); + const auto &targetPlayer = creature->getPlayer(); if (targetPlayer) { - const std::shared_ptr attackerPlayer = g_game().getPlayerByID(ownerId); + const auto &attackerPlayer = g_game().getPlayerByID(ownerId); if (attackerPlayer) { if (Combat::isProtected(attackerPlayer, targetPlayer)) { harmfulField = false; @@ -2148,7 +2149,7 @@ void MagicField::onStepInField(const std::shared_ptr &creature) { } } -void Combat::applyExtensions(std::shared_ptr caster, std::shared_ptr target, CombatDamage &damage, const CombatParams ¶ms) { +void Combat::applyExtensions(const std::shared_ptr &caster, const std::shared_ptr &target, CombatDamage &damage, const CombatParams ¶ms) { metrics::method_latency measure(__METHOD_NAME__); if (damage.extension || !caster || damage.primary.type == COMBAT_HEALING) { return; @@ -2159,15 +2160,15 @@ void Combat::applyExtensions(std::shared_ptr caster, std::shared_ptrgetPlayer(); - auto monster = caster->getMonster(); + const auto &player = caster->getPlayer(); + const auto &monster = caster->getMonster(); if (player) { chance = player->getSkillLevel(SKILL_CRITICAL_HIT_CHANCE); bonus = player->getSkillLevel(SKILL_CRITICAL_HIT_DAMAGE); if (target && target->getMonster()) { uint16_t playerCharmRaceid = player->parseRacebyCharm(CHARM_LOW, false, 0); if (playerCharmRaceid != 0) { - const auto mType = g_monsters().getMonsterType(target->getName()); + const auto &mType = g_monsters().getMonsterType(target->getName()); if (mType && playerCharmRaceid == mType->info.raceid) { const auto charm = g_iobestiary().getBestiaryCharm(CHARM_LOW); if (charm) { @@ -2183,7 +2184,7 @@ void Combat::applyExtensions(std::shared_ptr caster, std::shared_ptr(bonus) / 10000; - chance += (uint16_t)damage.criticalChance; + chance += static_cast(damage.criticalChance); if (chance != 0 && uniform_random(1, 10000) <= chance) { damage.critical = true; @@ -2193,10 +2194,10 @@ void Combat::applyExtensions(std::shared_ptr caster, std::shared_ptrgetInventoryItem(CONST_SLOT_LEFT); + if (const auto &playerWeapon = player->getInventoryItem(CONST_SLOT_LEFT); playerWeapon != nullptr && playerWeapon->getTier() > 0) { - double_t fatalChance = playerWeapon->getFatalChance(); - double_t randomChance = uniform_random(0, 10000) / 100; + const double_t fatalChance = playerWeapon->getFatalChance(); + const double_t randomChance = uniform_random(0, 10000) / 100; if (fatalChance > 0 && randomChance < fatalChance) { damage.fatal = true; damage.primary.value += static_cast(std::round(damage.primary.value * 0.6)); diff --git a/src/creatures/combat/combat.hpp b/src/creatures/combat/combat.hpp index 304a709135d..d842826769d 100644 --- a/src/creatures/combat/combat.hpp +++ b/src/creatures/combat/combat.hpp @@ -11,7 +11,6 @@ #include "lua/global/baseevents.hpp" #include "creatures/combat/condition.hpp" -#include "declarations.hpp" #include "map/map.hpp" class Condition; @@ -35,33 +34,33 @@ class ValueCallback final : public CallBack { * @param damage The combat damage information. * @return The magic level skill of the player. */ - uint32_t getMagicLevelSkill(std::shared_ptr player, const CombatDamage &damage) const; - void getMinMaxValues(std::shared_ptr player, CombatDamage &damage, bool useCharges) const; + uint32_t getMagicLevelSkill(const std::shared_ptr &player, const CombatDamage &damage) const; + void getMinMaxValues(const std::shared_ptr &player, CombatDamage &damage, bool useCharges) const; private: - formulaType_t type; + formulaType_t type {}; }; class TileCallback final : public CallBack { public: - void onTileCombat(std::shared_ptr creature, std::shared_ptr tile) const; + void onTileCombat(const std::shared_ptr &creature, const std::shared_ptr &tile) const; protected: - formulaType_t type; + formulaType_t type {}; }; class TargetCallback final : public CallBack { public: - void onTargetCombat(std::shared_ptr creature, std::shared_ptr target) const; + void onTargetCombat(const std::shared_ptr &creature, const std::shared_ptr &target) const; protected: - formulaType_t type; + formulaType_t type {}; }; class ChainCallback final : public CallBack { public: ChainCallback() = default; - ChainCallback(uint8_t &chainTargets, uint8_t &chainDistance, bool &backtracking) : + ChainCallback(const uint8_t &chainTargets, const uint8_t &chainDistance, const bool &backtracking) : m_chainDistance(chainDistance), m_chainTargets(chainTargets), m_backtracking(backtracking) { } void getChainValues(const std::shared_ptr &creature, uint8_t &maxTargets, uint8_t &chainDistance, bool &backtracking); @@ -70,7 +69,7 @@ class ChainCallback final : public CallBack { } private: - void onChainCombat(std::shared_ptr creature, uint8_t &chainTargets, uint8_t &chainDistance, bool &backtracking); + void onChainCombat(const std::shared_ptr &creature, uint8_t &chainTargets, uint8_t &chainDistance, bool &backtracking) const; uint8_t m_chainDistance = 0; uint8_t m_chainTargets = 0; @@ -80,7 +79,7 @@ class ChainCallback final : public CallBack { class ChainPickerCallback final : public CallBack { public: - bool onChainCombat(std::shared_ptr creature, std::shared_ptr target) const; + bool onChainCombat(const std::shared_ptr &creature, const std::shared_ptr &target) const; }; struct CombatParams { @@ -162,12 +161,11 @@ class MatrixArea { // non-assignable MatrixArea &operator=(const MatrixArea &) = delete; - void setValue(uint32_t row, uint32_t col, bool value) { + void setValue(uint32_t row, uint32_t col, bool value) const { if (row < rows && col < cols) { data_[row][col] = value; } else { g_logger().error("[{}] Access exceeds the upper limit of memory block"); - throw std::out_of_range("Access exceeds the upper limit of memory block"); } } bool getValue(uint32_t row, uint32_t col) const { @@ -276,41 +274,41 @@ class Combat { Combat(const Combat &) = delete; Combat &operator=(const Combat &) = delete; - static void applyExtensions(std::shared_ptr caster, std::shared_ptr target, CombatDamage &damage, const CombatParams ¶ms); + static void applyExtensions(const std::shared_ptr &caster, const std::shared_ptr &target, CombatDamage &damage, const CombatParams ¶ms); - static void doCombatHealth(std::shared_ptr caster, std::shared_ptr target, CombatDamage &damage, const CombatParams ¶ms); - static void doCombatHealth(std::shared_ptr caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms); + static void doCombatHealth(const std::shared_ptr &caster, const std::shared_ptr &target, CombatDamage &damage, const CombatParams ¶ms); + static void doCombatHealth(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms); - static void doCombatMana(std::shared_ptr caster, std::shared_ptr target, CombatDamage &damage, const CombatParams ¶ms); - static void doCombatMana(std::shared_ptr caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms); + static void doCombatMana(const std::shared_ptr &caster, const std::shared_ptr &target, CombatDamage &damage, const CombatParams ¶ms); + static void doCombatMana(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, CombatDamage &damage, const CombatParams ¶ms); - static void doCombatCondition(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms); - static void doCombatCondition(std::shared_ptr caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms); + static void doCombatCondition(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms); + static void doCombatCondition(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms); - static void doCombatDispel(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms); - static void doCombatDispel(std::shared_ptr caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms); + static void doCombatDispel(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms); + static void doCombatDispel(const std::shared_ptr &caster, const Position &position, const std::unique_ptr &area, const CombatParams ¶ms); static void getCombatArea(const Position ¢erPos, const Position &targetPos, const std::unique_ptr &area, std::vector> &list); - static bool isInPvpZone(std::shared_ptr attacker, std::shared_ptr target); - static bool isProtected(std::shared_ptr attacker, std::shared_ptr target); - static bool isPlayerCombat(std::shared_ptr target); + static bool isInPvpZone(const std::shared_ptr &attacker, const std::shared_ptr &target); + static bool isProtected(const std::shared_ptr &attacker, const std::shared_ptr &target); + static bool isPlayerCombat(const std::shared_ptr &target); static CombatType_t ConditionToDamageType(ConditionType_t type); static ConditionType_t DamageToConditionType(CombatType_t type); - static ReturnValue canTargetCreature(std::shared_ptr attacker, std::shared_ptr target); - static ReturnValue canDoCombat(std::shared_ptr caster, std::shared_ptr tile, bool aggressive); - static ReturnValue canDoCombat(std::shared_ptr attacker, std::shared_ptr target, bool aggressive); - static void postCombatEffects(std::shared_ptr caster, const Position &origin, const Position &pos, const CombatParams ¶ms); + static ReturnValue canTargetCreature(const std::shared_ptr &attacker, const std::shared_ptr &target); + static ReturnValue canDoCombat(const std::shared_ptr &caster, const std::shared_ptr &tile, bool aggressive); + static ReturnValue canDoCombat(const std::shared_ptr &attacker, const std::shared_ptr &target, bool aggressive); + static void postCombatEffects(const std::shared_ptr &caster, const Position &origin, const Position &pos, const CombatParams ¶ms); - static void addDistanceEffect(std::shared_ptr caster, const Position &fromPos, const Position &toPos, uint16_t effect); + static void addDistanceEffect(const std::shared_ptr &caster, const Position &fromPos, const Position &toPos, uint16_t effect); - bool doCombat(std::shared_ptr caster, std::shared_ptr target) const; - bool doCombat(std::shared_ptr caster, std::shared_ptr target, const Position &origin, int affected = 1) const; - bool doCombat(std::shared_ptr caster, const Position &pos) const; + bool doCombat(const std::shared_ptr &caster, const std::shared_ptr &target) const; + bool doCombat(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, int affected = 1) const; + bool doCombat(const std::shared_ptr &caster, const Position &pos) const; bool setCallback(CallBackParam_t key); void setChainCallback(uint8_t chainTargets, uint8_t chainDistance, bool backtracking); - CallBack* getCallback(CallBackParam_t key); + CallBack* getCallback(CallBackParam_t key) const; bool setParam(CombatParam_t param, uint32_t value); void setArea(std::unique_ptr &newArea) { @@ -319,12 +317,12 @@ class Combat { bool hasArea() const { return area != nullptr; } - void addCondition(const std::shared_ptr condition) { + void addCondition(const std::shared_ptr &condition) { params.conditionList.emplace_back(condition); } void setPlayerCombatValues(formulaType_t formulaType, double mina, double minb, double maxa, double maxb); - void postCombatEffects(std::shared_ptr caster, const Position &origin, const Position &pos) const { - postCombatEffects(std::move(caster), origin, pos, params); + void postCombatEffects(const std::shared_ptr &caster, const Position &origin, const Position &pos) const { + postCombatEffects(caster, origin, pos, params); } void setOrigin(CombatOrigin origin) { @@ -346,24 +344,24 @@ class Combat { void setRuneSpellName(const std::string &value); void setupChain(const std::shared_ptr &weapon); - bool doCombatChain(std::shared_ptr caster, std::shared_ptr target, bool aggressive) const; + bool doCombatChain(const std::shared_ptr &caster, const std::shared_ptr &target, bool aggressive) const; private: static void doChainEffect(const Position &origin, const Position &pos, uint8_t effect); - static std::vector>> pickChainTargets(std::shared_ptr caster, const CombatParams ¶ms, uint8_t chainDistance, uint8_t maxTargets, bool aggressive, bool backtracking, std::shared_ptr initialTarget = nullptr); - static bool isValidChainTarget(std::shared_ptr caster, std::shared_ptr currentTarget, std::shared_ptr potentialTarget, const CombatParams ¶ms, bool aggressive); + static std::vector>> pickChainTargets(const std::shared_ptr &caster, const CombatParams ¶ms, uint8_t chainDistance, uint8_t maxTargets, bool aggressive, bool backtracking, const std::shared_ptr &initialTarget = nullptr); + static bool isValidChainTarget(const std::shared_ptr &caster, const std::shared_ptr ¤tTarget, const std::shared_ptr &potentialTarget, const CombatParams ¶ms, bool aggressive); - static void doCombatDefault(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms); + static void doCombatDefault(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms); - static void doCombatHealth(std::shared_ptr caster, std::shared_ptr target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms); - static void doCombatMana(std::shared_ptr caster, std::shared_ptr target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms); - static void doCombatDefault(std::shared_ptr caster, std::shared_ptr target, const Position &origin, const CombatParams ¶ms); + static void doCombatHealth(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms); + static void doCombatMana(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, CombatDamage &damage, const CombatParams ¶ms); + static void doCombatDefault(const std::shared_ptr &caster, const std::shared_ptr &target, const Position &origin, const CombatParams ¶ms); - static void CombatFunc(std::shared_ptr caster, const Position &origin, const Position &pos, const std::unique_ptr &area, const CombatParams ¶ms, CombatFunction func, CombatDamage* data); + static void CombatFunc(const std::shared_ptr &caster, const Position &origin, const Position &pos, const std::unique_ptr &area, const CombatParams ¶ms, const CombatFunction &func, CombatDamage* data); - static void CombatHealthFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* data); - static CombatDamage applyImbuementElementalDamage(std::shared_ptr attackerPlayer, std::shared_ptr item, CombatDamage damage); - static void CombatManaFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* damage); + static void CombatHealthFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* data); + static CombatDamage applyImbuementElementalDamage(const std::shared_ptr &attackerPlayer, std::shared_ptr item, CombatDamage damage); + static void CombatManaFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* damage); /** * @brief Checks if a fear condition can be applied to a player. * @@ -378,12 +376,12 @@ class Combat { * @param player Pointer to the Player object to be checked. * @return true if the fear condition can be applied, false otherwise. */ - static bool checkFearConditionAffected(std::shared_ptr player); - static void CombatConditionFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* data); - static void CombatDispelFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* data); - static void CombatNullFunc(std::shared_ptr caster, std::shared_ptr target, const CombatParams ¶ms, CombatDamage* data); + static bool checkFearConditionAffected(const std::shared_ptr &player); + static void CombatConditionFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* data); + static void CombatDispelFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* data); + static void CombatNullFunc(const std::shared_ptr &caster, const std::shared_ptr &target, const CombatParams ¶ms, CombatDamage* data); - static void combatTileEffects(const CreatureVector &spectators, std::shared_ptr caster, std::shared_ptr tile, const CombatParams ¶ms); + static void combatTileEffects(const CreatureVector &spectators, const std::shared_ptr &caster, const std::shared_ptr &tile, const CombatParams ¶ms); /** * @brief Calculate the level formula for combat. @@ -393,8 +391,8 @@ class Combat { * @param damage The combat damage. * @return The calculated level formula. */ - int32_t getLevelFormula(std::shared_ptr player, std::shared_ptr wheelSpell, const CombatDamage &damage) const; - CombatDamage getCombatDamage(std::shared_ptr creature, std::shared_ptr target) const; + int32_t getLevelFormula(const std::shared_ptr &player, const std::shared_ptr &wheelSpell, const CombatDamage &damage) const; + CombatDamage getCombatDamage(const std::shared_ptr &creature, const std::shared_ptr &target) const; // configureable CombatParams params; diff --git a/src/creatures/combat/condition.cpp b/src/creatures/combat/condition.cpp index bc262a41c76..a464f3db062 100644 --- a/src/creatures/combat/condition.cpp +++ b/src/creatures/combat/condition.cpp @@ -178,7 +178,7 @@ void Condition::setTicks(int32_t newTicks) { endTime = ticks + OTSYS_TIME(); } -bool Condition::executeCondition(std::shared_ptr creature, int32_t interval) { +bool Condition::executeCondition(const std::shared_ptr &creature, int32_t interval) { if (ticks == -1) { return true; } @@ -368,7 +368,7 @@ std::unordered_set Condition::getIcons() const { return icons; } -bool Condition::updateCondition(const std::shared_ptr addCondition) { +bool Condition::updateCondition(const std::shared_ptr &addCondition) { if (conditionType != addCondition->getType()) { return false; } @@ -392,7 +392,7 @@ bool ConditionGeneric::startCondition(std::shared_ptr creature) { return Condition::startCondition(creature); } -bool ConditionGeneric::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionGeneric::executeCondition(const std::shared_ptr &creature, int32_t interval) { return Condition::executeCondition(creature, interval); } @@ -491,7 +491,7 @@ void ConditionAttributes::addCondition(std::shared_ptr creature, const updateCharmChanceModifier(creature); disableDefense = conditionAttrs->disableDefense; - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { updatePercentSkills(player); updateSkills(player); updatePercentStats(player); @@ -595,7 +595,7 @@ bool ConditionAttributes::startCondition(std::shared_ptr creature) { updatePercentIncreases(creature); updateIncreases(creature); updateCharmChanceModifier(creature); - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { updatePercentSkills(player); updateSkills(player); updatePercentStats(player); @@ -605,7 +605,7 @@ bool ConditionAttributes::startCondition(std::shared_ptr creature) { return true; } -void ConditionAttributes::updatePercentStats(std::shared_ptr player) { +void ConditionAttributes::updatePercentStats(const std::shared_ptr &player) { for (int32_t i = STAT_FIRST; i <= STAT_LAST; ++i) { if (statsPercent[i] == 0) { continue; @@ -631,7 +631,7 @@ void ConditionAttributes::updatePercentStats(std::shared_ptr player) { } } -void ConditionAttributes::updateStats(std::shared_ptr player) { +void ConditionAttributes::updateStats(const std::shared_ptr &player) const { bool needUpdate = false; for (int32_t i = STAT_FIRST; i <= STAT_LAST; ++i) { @@ -647,9 +647,9 @@ void ConditionAttributes::updateStats(std::shared_ptr player) { } } -void ConditionAttributes::updatePercentSkills(std::shared_ptr player) { +void ConditionAttributes::updatePercentSkills(const std::shared_ptr &player) { for (uint8_t i = SKILL_FIRST; i <= SKILL_LAST; ++i) { - skills_t skill = static_cast(i); + auto skill = static_cast(i); if (skillsPercent[skill] == 0) { continue; } @@ -659,7 +659,7 @@ void ConditionAttributes::updatePercentSkills(std::shared_ptr player) { } } -void ConditionAttributes::updateSkills(std::shared_ptr player) { +void ConditionAttributes::updateSkills(const std::shared_ptr &player) const { bool needUpdateSkills = false; for (int32_t i = SKILL_FIRST; i <= SKILL_LAST; ++i) { @@ -674,7 +674,7 @@ void ConditionAttributes::updateSkills(std::shared_ptr player) { } } -void ConditionAttributes::updatePercentAbsorbs(std::shared_ptr creature) { +void ConditionAttributes::updatePercentAbsorbs(const std::shared_ptr &creature) { for (uint8_t i = 0; i < COMBAT_COUNT; i++) { auto value = getAbsorbPercentByIndex(i); if (value == 0) { @@ -684,7 +684,7 @@ void ConditionAttributes::updatePercentAbsorbs(std::shared_ptr creatur } } -void ConditionAttributes::updateAbsorbs(std::shared_ptr creature) const { +void ConditionAttributes::updateAbsorbs(const std::shared_ptr &creature) const { for (uint8_t i = 0; i < COMBAT_COUNT; i++) { auto value = getAbsorbByIndex(i); if (value == 0) { @@ -695,7 +695,7 @@ void ConditionAttributes::updateAbsorbs(std::shared_ptr creature) cons } } -void ConditionAttributes::updatePercentIncreases(std::shared_ptr creature) { +void ConditionAttributes::updatePercentIncreases(const std::shared_ptr &creature) { for (uint8_t i = 0; i < COMBAT_COUNT; i++) { auto increasePercentValue = getIncreasePercentById(i); if (increasePercentValue == 0) { @@ -705,7 +705,7 @@ void ConditionAttributes::updatePercentIncreases(std::shared_ptr creat } } -void ConditionAttributes::updateIncreases(std::shared_ptr creature) const { +void ConditionAttributes::updateIncreases(const std::shared_ptr &creature) const { for (uint8_t i = 0; i < COMBAT_COUNT; i++) { auto increaseValue = getIncreaseByIndex(i); if (increaseValue == 0) { @@ -715,11 +715,11 @@ void ConditionAttributes::updateIncreases(std::shared_ptr creature) co } } -void ConditionAttributes::updateCharmChanceModifier(std::shared_ptr creature) const { +void ConditionAttributes::updateCharmChanceModifier(const std::shared_ptr &creature) const { creature->setCharmChanceModifier(creature->getCharmChanceModifier() + charmChanceModifier); } -void ConditionAttributes::updatePercentBuffs(std::shared_ptr creature) { +void ConditionAttributes::updatePercentBuffs(const std::shared_ptr &creature) { for (int32_t i = BUFF_FIRST; i <= BUFF_LAST; ++i) { if (buffsPercent[i] == 0) { continue; @@ -730,7 +730,7 @@ void ConditionAttributes::updatePercentBuffs(std::shared_ptr creature) } } -void ConditionAttributes::updateBuffs(std::shared_ptr creature) { +void ConditionAttributes::updateBuffs(const std::shared_ptr &creature) const { bool needUpdate = false; for (int32_t i = BUFF_FIRST; i <= BUFF_LAST; ++i) { if (buffs[i]) { @@ -743,12 +743,12 @@ void ConditionAttributes::updateBuffs(std::shared_ptr creature) { } } -bool ConditionAttributes::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionAttributes::executeCondition(const std::shared_ptr &creature, int32_t interval) { return ConditionGeneric::executeCondition(creature, interval); } void ConditionAttributes::endCondition(std::shared_ptr creature) { - std::shared_ptr player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { bool needUpdate = false; @@ -1155,14 +1155,14 @@ bool ConditionRegeneration::startCondition(std::shared_ptr creature) { return false; } - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->sendStats(); } return true; } void ConditionRegeneration::endCondition(std::shared_ptr creature) { - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->sendStats(); } } @@ -1171,7 +1171,7 @@ void ConditionRegeneration::addCondition(std::shared_ptr creature, con if (updateCondition(addCondition)) { setTicks(addCondition->getTicks()); - const std::shared_ptr &conditionRegen = addCondition->static_self_cast(); + const auto &conditionRegen = addCondition->static_self_cast(); healthTicks = conditionRegen->healthTicks; manaTicks = conditionRegen->manaTicks; @@ -1180,7 +1180,7 @@ void ConditionRegeneration::addCondition(std::shared_ptr creature, con manaGain = conditionRegen->manaGain; } - if (auto player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->sendStats(); } } @@ -1214,10 +1214,10 @@ void ConditionRegeneration::serialize(PropWriteStream &propWriteStream) { propWriteStream.write(manaGain); } -bool ConditionRegeneration::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionRegeneration::executeCondition(const std::shared_ptr &creature, int32_t interval) { internalHealthTicks += interval; internalManaTicks += interval; - auto player = creature->getPlayer(); + const auto &player = creature->getPlayer(); int32_t dailyStreak = 0; if (player) { dailyStreak = static_cast(player->kv()->scoped("daily-reward")->get("streak")->getNumber()); @@ -1297,8 +1297,8 @@ bool ConditionRegeneration::setParam(ConditionParam_t param, int32_t value) { } } -uint32_t ConditionRegeneration::getHealthTicks(std::shared_ptr creature) const { - std::shared_ptr player = creature->getPlayer(); +uint32_t ConditionRegeneration::getHealthTicks(const std::shared_ptr &creature) const { + const auto &player = creature->getPlayer(); if (player != nullptr && isBuff) { return healthTicks / g_configManager().getFloat(RATE_SPELL_COOLDOWN); @@ -1307,8 +1307,8 @@ uint32_t ConditionRegeneration::getHealthTicks(std::shared_ptr creatur return healthTicks; } -uint32_t ConditionRegeneration::getManaTicks(std::shared_ptr creature) const { - std::shared_ptr player = creature->getPlayer(); +uint32_t ConditionRegeneration::getManaTicks(const std::shared_ptr &creature) const { + const auto &player = creature->getPlayer(); if (player != nullptr && isBuff) { return manaTicks / g_configManager().getFloat(RATE_SPELL_COOLDOWN); @@ -1329,7 +1329,7 @@ bool ConditionManaShield::startCondition(std::shared_ptr creature) { creature->setManaShield(manaShield); creature->setMaxManaShield(manaShield); - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->sendStats(); } @@ -1339,7 +1339,7 @@ bool ConditionManaShield::startCondition(std::shared_ptr creature) { void ConditionManaShield::endCondition(std::shared_ptr creature) { creature->setManaShield(0); creature->setMaxManaShield(0); - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->sendStats(); } } @@ -1354,7 +1354,7 @@ void ConditionManaShield::addCondition(std::shared_ptr creature, const creature->setManaShield(manaShield); creature->setMaxManaShield(manaShield); - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->sendStats(); } } @@ -1403,7 +1403,7 @@ void ConditionSoul::addCondition(std::shared_ptr, const std::shared_pt if (updateCondition(addCondition)) { setTicks(addCondition->getTicks()); - const std::shared_ptr &conditionSoul = addCondition->static_self_cast(); + const auto &conditionSoul = addCondition->static_self_cast(); soulTicks = conditionSoul->soulTicks; soulGain = conditionSoul->soulGain; @@ -1429,10 +1429,10 @@ void ConditionSoul::serialize(PropWriteStream &propWriteStream) { propWriteStream.write(soulTicks); } -bool ConditionSoul::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionSoul::executeCondition(const std::shared_ptr &creature, int32_t interval) { internalSoulTicks += interval; - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { if (player->getZoneType() != ZONE_PROTECTION) { if (internalSoulTicks >= soulTicks) { internalSoulTicks = 0; @@ -1530,7 +1530,7 @@ bool ConditionDamage::unserializeProp(ConditionAttr_t attr, PropStream &propStre return false; } - damageList.push_back(damageInfo); + damageList.emplace_back(damageInfo); if (ticks != -1) { setTicks(ticks + damageInfo.interval); } @@ -1554,8 +1554,8 @@ void ConditionDamage::serialize(PropWriteStream &propWriteStream) { } } -bool ConditionDamage::updateCondition(const std::shared_ptr addCondition) { - const std::shared_ptr &conditionDamage = addCondition->static_self_cast(); +bool ConditionDamage::updateCondition(const std::shared_ptr &addCondition) { + const auto &conditionDamage = addCondition->static_self_cast(); if (conditionDamage->doForceUpdate()) { return true; } @@ -1588,7 +1588,7 @@ bool ConditionDamage::addDamage(int32_t rounds, int32_t time, int32_t value) { damageInfo.timeLeft = time; damageInfo.value = value; - damageList.push_back(damageInfo); + damageList.emplace_back(damageInfo); if (ticks != -1) { setTicks(ticks + damageInfo.interval); @@ -1642,7 +1642,7 @@ bool ConditionDamage::startCondition(std::shared_ptr creature) { return true; } -bool ConditionDamage::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionDamage::executeCondition(const std::shared_ptr &creature, int32_t interval) { if (periodDamage != 0) { periodDamageTick += interval; @@ -1696,8 +1696,8 @@ bool ConditionDamage::getNextDamage(int32_t &damage) { return false; } -bool ConditionDamage::doDamage(std::shared_ptr creature, int32_t healthChange) { - auto attacker = g_game().getPlayerByGUID(owner) ? g_game().getPlayerByGUID(owner)->getCreature() : g_game().getCreatureByID(owner); +bool ConditionDamage::doDamage(const std::shared_ptr &creature, int32_t healthChange) const { + const auto &attacker = g_game().getPlayerByGUID(owner) ? g_game().getPlayerByGUID(owner)->getCreature() : g_game().getCreatureByID(owner); bool isPlayer = attacker && attacker->getPlayer(); if (creature->isSuppress(getType(), isPlayer)) { return true; @@ -1844,7 +1844,7 @@ void ConditionDamage::generateDamageList(int32_t amount, int32_t start, std::lis do { sum += i; - list.push_back(i); + list.emplace_back(i); x1 = std::fabs(1.0 - ((static_cast(sum)) + i) / med); x2 = std::fabs(1.0 - (static_cast(sum) / med)); @@ -1855,13 +1855,13 @@ void ConditionDamage::generateDamageList(int32_t amount, int32_t start, std::lis /** * ConditionFeared */ -bool ConditionFeared::isStuck(std::shared_ptr creature, Position pos) const { +bool ConditionFeared::isStuck(const std::shared_ptr &creature, Position pos) const { return std::ranges::all_of(m_directionsVector, [&](Direction dir) { return !canWalkTo(creature, pos, dir); }); } -bool ConditionFeared::getRandomDirection(std::shared_ptr creature, Position pos) { +bool ConditionFeared::getRandomDirection(const std::shared_ptr &creature, Position pos) { static std::vector directions { DIRECTION_NORTH, DIRECTION_NORTHEAST, @@ -1887,7 +1887,7 @@ bool ConditionFeared::getRandomDirection(std::shared_ptr creature, Pos return false; } -bool ConditionFeared::canWalkTo(std::shared_ptr creature, Position pos, Direction moveDirection) const { +bool ConditionFeared::canWalkTo(const std::shared_ptr &creature, Position pos, Direction moveDirection) const { pos = getNextPosition(moveDirection, pos); if (!creature) { g_logger().error("[{}] creature is nullptr", __FUNCTION__); @@ -1896,7 +1896,7 @@ bool ConditionFeared::canWalkTo(std::shared_ptr creature, Position pos auto tile = g_game().map.getTile(pos); if (tile && tile->getTopVisibleCreature(creature) == nullptr && tile->queryAdd(0, creature, 1, FLAG_PATHFINDING) == RETURNVALUE_NOERROR) { - std::shared_ptr field = tile->getFieldItem(); + const auto &field = tile->getFieldItem(); if (field && !field->isBlocking() && field->getDamage() != 0) { return false; } @@ -1906,7 +1906,7 @@ bool ConditionFeared::canWalkTo(std::shared_ptr creature, Position pos return false; } -bool ConditionFeared::getFleeDirection(std::shared_ptr creature) { +bool ConditionFeared::getFleeDirection(const std::shared_ptr &creature) { Position creaturePos = creature->getPosition(); int_fast32_t offx = Position::getOffsetX(creaturePos, fleeingFromPos); @@ -1982,7 +1982,7 @@ bool ConditionFeared::getFleeDirection(std::shared_ptr creature) { return false; } -bool ConditionFeared::getFleePath(std::shared_ptr creature, const Position &pos, std::vector &dirList) { +bool ConditionFeared::getFleePath(const std::shared_ptr &creature, const Position &pos, std::vector &dirList) { const std::vector walkSize { 15, 9, 3, 1 }; bool found = false; std::ptrdiff_t found_size = 0; @@ -2083,7 +2083,7 @@ bool ConditionFeared::startCondition(std::shared_ptr creature) { return Condition::startCondition(creature); } -bool ConditionFeared::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionFeared::executeCondition(const std::shared_ptr &creature, int32_t interval) { Position currentPos = creature->getPosition(); std::vector listDir; @@ -2114,7 +2114,7 @@ void ConditionFeared::endCondition(std::shared_ptr creature) { /* * After a player is feared there's a 10 seconds before they can can feared again. */ - std::shared_ptr player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { player->setImmuneFear(); } @@ -2220,7 +2220,7 @@ bool ConditionSpeed::startCondition(std::shared_ptr creature) { return true; } -bool ConditionSpeed::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionSpeed::executeCondition(const std::shared_ptr &creature, int32_t interval) { return Condition::executeCondition(creature, interval); } @@ -2334,7 +2334,7 @@ bool ConditionOutfit::startCondition(std::shared_ptr creature) { } if ((outfit.lookType == 0 && outfit.lookTypeEx == 0) && !monsterName.empty()) { - const auto monsterType = g_monsters().getMonsterType(monsterName); + const auto &monsterType = g_monsters().getMonsterType(monsterName); if (monsterType) { setOutfit(monsterType->info.outfit); } else { @@ -2351,7 +2351,7 @@ bool ConditionOutfit::startCondition(std::shared_ptr creature) { return true; } -bool ConditionOutfit::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionOutfit::executeCondition(const std::shared_ptr &creature, int32_t interval) { return Condition::executeCondition(creature, interval); } @@ -2368,9 +2368,9 @@ void ConditionOutfit::addCondition(std::shared_ptr creature, const std if (updateCondition(addCondition)) { setTicks(addCondition->getTicks()); - const std::shared_ptr &conditionOutfit = addCondition->static_self_cast(); - if (!conditionOutfit->monsterName.empty() && conditionOutfit->monsterName.compare(monsterName) != 0) { - const auto monsterType = g_monsters().getMonsterType(conditionOutfit->monsterName); + const auto &conditionOutfit = addCondition->static_self_cast(); + if (!conditionOutfit->monsterName.empty() && conditionOutfit->monsterName != monsterName) { + const auto &monsterType = g_monsters().getMonsterType(conditionOutfit->monsterName); if (monsterType) { setOutfit(monsterType->info.outfit); } else { @@ -2401,7 +2401,7 @@ bool ConditionLight::startCondition(std::shared_ptr creature) { return true; } -bool ConditionLight::executeCondition(std::shared_ptr creature, int32_t interval) { +bool ConditionLight::executeCondition(const std::shared_ptr &creature, int32_t interval) { internalLightTicks += interval; if (internalLightTicks >= lightChangeInterval) { @@ -2427,7 +2427,7 @@ void ConditionLight::addCondition(std::shared_ptr creature, const std: if (updateCondition(condition)) { setTicks(condition->getTicks()); - const std::shared_ptr &conditionLight = condition->static_self_cast(); + const auto &conditionLight = condition->static_self_cast(); lightInfo.level = conditionLight->lightInfo.level; lightInfo.color = conditionLight->lightInfo.color; lightChangeInterval = ticks / lightInfo.level; @@ -2510,7 +2510,7 @@ void ConditionSpellCooldown::addCondition(std::shared_ptr creature, co setTicks(addCondition->getTicks()); if (subId != 0 && ticks > 0) { - std::shared_ptr player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { player->sendSpellCooldown(subId, ticks); } @@ -2524,7 +2524,7 @@ bool ConditionSpellCooldown::startCondition(std::shared_ptr creature) } if (subId != 0 && ticks > 0) { - std::shared_ptr player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { player->sendSpellCooldown(subId, ticks); } @@ -2541,7 +2541,7 @@ void ConditionSpellGroupCooldown::addCondition(std::shared_ptr creatur setTicks(addCondition->getTicks()); if (subId != 0 && ticks > 0) { - std::shared_ptr player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { player->sendSpellGroupCooldown(static_cast(subId), ticks); } @@ -2555,7 +2555,7 @@ bool ConditionSpellGroupCooldown::startCondition(std::shared_ptr creat } if (subId != 0 && ticks > 0) { - std::shared_ptr player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { player->sendSpellGroupCooldown(static_cast(subId), ticks); } diff --git a/src/creatures/combat/condition.hpp b/src/creatures/combat/condition.hpp index ea59943e5c7..88949d5e3fb 100644 --- a/src/creatures/combat/condition.hpp +++ b/src/creatures/combat/condition.hpp @@ -27,7 +27,7 @@ class Condition : public SharedObject { virtual ~Condition() = default; virtual bool startCondition(std::shared_ptr creature); - virtual bool executeCondition(std::shared_ptr creature, int32_t interval); + virtual bool executeCondition(const std::shared_ptr &creature, int32_t interval); virtual void endCondition(std::shared_ptr creature) = 0; virtual void addCondition(std::shared_ptr creature, std::shared_ptr condition) = 0; virtual std::unordered_set getIcons() const; @@ -75,7 +75,7 @@ class Condition : public SharedObject { bool isBuff {}; bool m_isPersistent {}; - virtual bool updateCondition(std::shared_ptr addCondition); + virtual bool updateCondition(const std::shared_ptr &addCondition); private: SoundEffect_t tickSound = SoundEffect_t::SILENCE; @@ -91,7 +91,7 @@ class ConditionGeneric : public Condition { Condition(initId, initType, initTicks, initBuff, initSubId, isPersistent) { } bool startCondition(std::shared_ptr creature) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; void endCondition(std::shared_ptr creature) override; void addCondition(std::shared_ptr creature, std::shared_ptr condition) override; std::unordered_set getIcons() const override; @@ -107,7 +107,7 @@ class ConditionAttributes final : public ConditionGeneric { ConditionGeneric(initId, initType, initTicks, initBuff, initSubId) { } bool startCondition(std::shared_ptr creature) final; - bool executeCondition(std::shared_ptr creature, int32_t interval) final; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) final; void endCondition(std::shared_ptr creature) final; void addCondition(std::shared_ptr creature, std::shared_ptr condition) final; @@ -153,19 +153,19 @@ class ConditionAttributes final : public ConditionGeneric { bool disableDefense = false; - void updatePercentStats(std::shared_ptr player); - void updateStats(std::shared_ptr player); - void updatePercentSkills(std::shared_ptr player); - void updateSkills(std::shared_ptr player); - void updateBuffs(std::shared_ptr creature); + void updatePercentStats(const std::shared_ptr &player); + void updateStats(const std::shared_ptr &player) const; + void updatePercentSkills(const std::shared_ptr &player); + void updateSkills(const std::shared_ptr &player) const; + void updateBuffs(const std::shared_ptr &creature) const; // 12.72 mechanics - void updatePercentAbsorbs(std::shared_ptr creature); - void updateAbsorbs(std::shared_ptr creature) const; - void updatePercentIncreases(std::shared_ptr creature); - void updateIncreases(std::shared_ptr creature) const; - void updateCharmChanceModifier(std::shared_ptr creature) const; - void updatePercentBuffs(std::shared_ptr creature); + void updatePercentAbsorbs(const std::shared_ptr &creature); + void updateAbsorbs(const std::shared_ptr &creature) const; + void updatePercentIncreases(const std::shared_ptr &creature); + void updateIncreases(const std::shared_ptr &creature) const; + void updateCharmChanceModifier(const std::shared_ptr &creature) const; + void updatePercentBuffs(const std::shared_ptr &creature); }; class ConditionRegeneration final : public ConditionGeneric { @@ -176,12 +176,12 @@ class ConditionRegeneration final : public ConditionGeneric { bool startCondition(std::shared_ptr creature) override; void endCondition(std::shared_ptr creature) override; void addCondition(std::shared_ptr creature, std::shared_ptr addCondition) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; bool setParam(ConditionParam_t param, int32_t value) override; - uint32_t getHealthTicks(std::shared_ptr creature) const; - uint32_t getManaTicks(std::shared_ptr creature) const; + uint32_t getHealthTicks(const std::shared_ptr &creature) const; + uint32_t getManaTicks(const std::shared_ptr &creature) const; std::shared_ptr clone() const override { return std::make_shared(*this); @@ -231,7 +231,7 @@ class ConditionSoul final : public ConditionGeneric { ConditionGeneric(initId, initType, iniTicks, initBuff, initSubId) { } void addCondition(std::shared_ptr creature, std::shared_ptr addCondition) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; bool setParam(ConditionParam_t param, int32_t value) override; @@ -271,7 +271,7 @@ class ConditionDamage final : public Condition { static void generateDamageList(int32_t amount, int32_t start, std::list &list); bool startCondition(std::shared_ptr creature) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; void endCondition(std::shared_ptr creature) override; void addCondition(std::shared_ptr creature, std::shared_ptr condition) override; std::unordered_set getIcons() const override; @@ -310,9 +310,9 @@ class ConditionDamage final : public Condition { std::list damageList; bool getNextDamage(int32_t &damage); - bool doDamage(std::shared_ptr creature, int32_t healthChange); + bool doDamage(const std::shared_ptr &creature, int32_t healthChange) const; - bool updateCondition(std::shared_ptr addCondition) override; + bool updateCondition(const std::shared_ptr &addCondition) override; }; class ConditionFeared final : public Condition { @@ -322,7 +322,7 @@ class ConditionFeared final : public Condition { Condition(intiId, initType, initTicks, initBuff, initSubId) { } bool startCondition(std::shared_ptr creature) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; void endCondition(std::shared_ptr creature) override; void addCondition(std::shared_ptr creature, std::shared_ptr condition) override; std::unordered_set getIcons() const override; @@ -334,11 +334,11 @@ class ConditionFeared final : public Condition { bool setPositionParam(ConditionParam_t param, const Position &pos) override; private: - bool canWalkTo(std::shared_ptr creature, Position pos, Direction moveDirection) const; - bool getFleeDirection(std::shared_ptr creature); - bool getFleePath(std::shared_ptr creature, const Position &pos, std::vector &dirList); - bool getRandomDirection(std::shared_ptr creature, Position pos); - bool isStuck(std::shared_ptr creature, Position pos) const; + bool canWalkTo(const std::shared_ptr &creature, Position pos, Direction moveDirection) const; + bool getFleeDirection(const std::shared_ptr &creature); + bool getFleePath(const std::shared_ptr &creature, const Position &pos, std::vector &dirList); + bool getRandomDirection(const std::shared_ptr &creature, Position pos); + bool isStuck(const std::shared_ptr &creature, Position pos) const; std::vector m_directionsVector { DIRECTION_NORTH, @@ -361,7 +361,7 @@ class ConditionSpeed final : public Condition { Condition(initId, initType, initTicks, initBuff, initSubId), speedDelta(initChangeSpeed) { } bool startCondition(std::shared_ptr creature) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; void endCondition(std::shared_ptr creature) override; void addCondition(std::shared_ptr creature, std::shared_ptr condition) override; std::unordered_set getIcons() const override; @@ -396,7 +396,7 @@ class ConditionOutfit final : public Condition { Condition(initId, initType, initTicks, initBuff, initSubId) { } bool startCondition(std::shared_ptr creature) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; void endCondition(std::shared_ptr creature) override; void addCondition(std::shared_ptr creature, std::shared_ptr condition) override; @@ -422,7 +422,7 @@ class ConditionLight final : public Condition { Condition(initId, initType, initTicks, initBuff, initSubId), lightInfo(initLightlevel, initLightcolor) { } bool startCondition(std::shared_ptr creature) override; - bool executeCondition(std::shared_ptr creature, int32_t interval) override; + bool executeCondition(const std::shared_ptr &creature, int32_t interval) override; void endCondition(std::shared_ptr creature) override; void addCondition(std::shared_ptr creature, std::shared_ptr addCondition) override; diff --git a/src/creatures/combat/spells.cpp b/src/creatures/combat/spells.cpp index b7ae69a8bd3..26635d84421 100644 --- a/src/creatures/combat/spells.cpp +++ b/src/creatures/combat/spells.cpp @@ -22,9 +22,9 @@ Spells::Spells() = default; Spells::~Spells() = default; -TalkActionResult_t Spells::playerSaySpell(std::shared_ptr player, std::string &words) { +TalkActionResult_t Spells::playerSaySpell(const std::shared_ptr &player, std::string &words) { auto maxOnline = g_configManager().getNumber(MAX_PLAYERS_PER_ACCOUNT); - auto tile = player->getTile(); + const auto &tile = player->getTile(); if (maxOnline > 1 && player->getAccountType() < ACCOUNT_TYPE_GAMEMASTER && tile && !tile->hasFlag(TILESTATE_PROTECTIONZONE)) { auto maxOutsizePZ = g_configManager().getNumber(MAX_PLAYERS_OUTSIDE_PZ_PER_ACCOUNT); auto accountPlayers = g_game().getPlayersByAccount(player->getAccount()); @@ -52,7 +52,7 @@ TalkActionResult_t Spells::playerSaySpell(std::shared_ptr player, std::s // strip trailing spaces trimString(str_words); - const std::shared_ptr instantSpell = getInstantSpell(str_words); + const auto &instantSpell = getInstantSpell(str_words); if (!instantSpell) { return TALKACTION_CONTINUE; } @@ -112,7 +112,7 @@ bool Spells::hasInstantSpell(const std::string &word) const { return false; } -bool Spells::registerInstantLuaEvent(const std::shared_ptr instant) { +bool Spells::registerInstantLuaEvent(const std::shared_ptr &instant) { if (instant) { // If the spell not have the "spell:words()" return a error message const std::string &instantName = instant->getName(); @@ -131,16 +131,17 @@ bool Spells::registerInstantLuaEvent(const std::shared_ptr instant } // Register spell word in the map setInstantSpell(words, instant); + return true; } return false; } -bool Spells::registerRuneLuaEvent(const std::shared_ptr rune) { +bool Spells::registerRuneLuaEvent(const std::shared_ptr &rune) { if (rune) { uint16_t id = rune->getRuneItemId(); - auto result = runes.emplace(rune->getRuneItemId(), rune); - if (!result.second) { + const auto &[iter, inserted] = runes.try_emplace(rune->getRuneItemId(), rune); + if (!inserted) { g_logger().warn( "[{}] duplicate registered rune with id: {}, for script: {}", __FUNCTION__, @@ -148,7 +149,7 @@ bool Spells::registerRuneLuaEvent(const std::shared_ptr rune) { rune->getScriptInterface()->getLoadingScriptName() ); } - return result.second; + return inserted; } return false; @@ -254,11 +255,11 @@ std::shared_ptr Spells::getInstantSpellByName(const std::string &n return nullptr; } -Position Spells::getCasterPosition(std::shared_ptr creature, Direction dir) { +Position Spells::getCasterPosition(const std::shared_ptr &creature, Direction dir) { return getNextPosition(dir, creature->getPosition()); } -CombatSpell::CombatSpell(const std::shared_ptr newCombat, bool newNeedTarget, bool newNeedDirection) : +CombatSpell::CombatSpell(const std::shared_ptr &newCombat, bool newNeedTarget, bool newNeedDirection) : Script(&g_spells().getScriptInterface()), m_combat(newCombat), needDirection(newNeedDirection), @@ -271,28 +272,32 @@ bool CombatSpell::loadScriptCombat() { return m_combat != nullptr; } -bool CombatSpell::castSpell(std::shared_ptr creature) { +bool CombatSpell::castSpell(const std::shared_ptr &creature) { if (isLoadedCallback()) { LuaVariant var; var.type = VARIANT_POSITION; - if (needDirection) { - var.pos = Spells::getCasterPosition(creature, creature->getDirection()); - } else { - var.pos = creature->getPosition(); + if (creature) { + if (needDirection) { + var.pos = Spells::getCasterPosition(creature, creature->getDirection()); + } else { + var.pos = creature->getPosition(); + } } return executeCastSpell(creature, var); } Position pos; - if (needDirection) { - pos = Spells::getCasterPosition(creature, creature->getDirection()); - } else { - pos = creature->getPosition(); + if (creature) { + if (needDirection) { + pos = Spells::getCasterPosition(creature, creature->getDirection()); + } else { + pos = creature->getPosition(); + } } - auto combat = getCombat(); + const auto &combat = getCombat(); if (!combat) { return false; } @@ -309,8 +314,8 @@ bool CombatSpell::castSpell(std::shared_ptr creature) { return true; } -bool CombatSpell::castSpell(std::shared_ptr creature, std::shared_ptr target) { - auto combat = getCombat(); +bool CombatSpell::castSpell(const std::shared_ptr &creature, const std::shared_ptr &target) { + const auto &combat = getCombat(); if (!combat) { return false; } @@ -320,12 +325,14 @@ bool CombatSpell::castSpell(std::shared_ptr creature, std::shared_ptr< if (combat->hasArea()) { var.type = VARIANT_POSITION; - if (needTarget) { + if (needTarget && target) { var.pos = target->getPosition(); - } else if (needDirection) { + } else if (needDirection && creature) { var.pos = Spells::getCasterPosition(creature, creature->getDirection()); } else { - var.pos = creature->getPosition(); + if (creature) { + var.pos = creature->getPosition(); + } } } else { var.type = VARIANT_NUMBER; @@ -344,7 +351,7 @@ bool CombatSpell::castSpell(std::shared_ptr creature, std::shared_ptr< } if (combat->hasArea()) { - if (needTarget) { + if (needTarget && target) { combat->doCombat(creature, target->getPosition()); } else { return castSpell(creature); @@ -355,16 +362,16 @@ bool CombatSpell::castSpell(std::shared_ptr creature, std::shared_ptr< return true; } -bool CombatSpell::executeCastSpell(std::shared_ptr creature, const LuaVariant &var) const { +bool CombatSpell::executeCastSpell(const std::shared_ptr &creature, const LuaVariant &var) const { // onCastSpell(creature, var) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaEnvironment::reserveScriptEnv()) { g_logger().error("[CombatSpell::executeCastSpell - Creature {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaEnvironment::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -379,7 +386,7 @@ bool CombatSpell::executeCastSpell(std::shared_ptr creature, const Lua return getScriptInterface()->callFunction(2); } -bool Spell::playerSpellCheck(std::shared_ptr player) const { +bool Spell::playerSpellCheck(const std::shared_ptr &player) const { if (player->hasFlag(PlayerFlags_t::CannotUseSpells)) { return false; } @@ -483,7 +490,7 @@ bool Spell::playerSpellCheck(std::shared_ptr player) const { return true; } -bool Spell::playerInstantSpellCheck(std::shared_ptr player, const Position &toPos) const { +bool Spell::playerInstantSpellCheck(const std::shared_ptr &player, const Position &toPos) const { if (toPos.x == 0xFFFF) { return true; } @@ -499,7 +506,7 @@ bool Spell::playerInstantSpellCheck(std::shared_ptr player, const Positi return false; } - const auto tile = g_game().map.getOrCreateTile(toPos); + const auto &tile = g_game().map.getOrCreateTile(toPos); ReturnValue ret = Combat::canDoCombat(player, tile, aggressive); if (ret != RETURNVALUE_NOERROR) { @@ -523,7 +530,7 @@ bool Spell::playerInstantSpellCheck(std::shared_ptr player, const Positi return true; } -bool Spell::playerRuneSpellCheck(std::shared_ptr player, const Position &toPos) { +bool Spell::playerRuneSpellCheck(const std::shared_ptr &player, const Position &toPos) const { if (!playerSpellCheck(player)) { return false; } @@ -543,7 +550,7 @@ bool Spell::playerRuneSpellCheck(std::shared_ptr player, const Position return false; } - std::shared_ptr tile = g_game().map.getTile(toPos); + const auto &tile = g_game().map.getTile(toPos); if (!tile) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); g_game().addMagicEffect(player->getPosition(), CONST_ME_POFF); @@ -563,12 +570,8 @@ bool Spell::playerRuneSpellCheck(std::shared_ptr player, const Position return false; } - const std::shared_ptr topVisibleCreature = tile->getBottomVisibleCreature(player); - if (blockingCreature && topVisibleCreature) { - player->sendCancelMessage(RETURNVALUE_NOTENOUGHROOM); - g_game().addMagicEffect(player->getPosition(), CONST_ME_POFF); - return false; - } else if (blockingSolid && tile->hasFlag(TILESTATE_BLOCKSOLID) && !topVisibleCreature) { + const auto &topVisibleCreature = tile->getBottomVisibleCreature(player); + if ((blockingCreature && topVisibleCreature) || (blockingSolid && tile->hasFlag(TILESTATE_BLOCKSOLID) && !topVisibleCreature)) { player->sendCancelMessage(RETURNVALUE_NOTENOUGHROOM); g_game().addMagicEffect(player->getPosition(), CONST_ME_POFF); return false; @@ -581,7 +584,7 @@ bool Spell::playerRuneSpellCheck(std::shared_ptr player, const Position } if (aggressive && needTarget && topVisibleCreature && player->hasSecureMode()) { - const std::shared_ptr targetPlayer = topVisibleCreature->getPlayer(); + const auto &targetPlayer = topVisibleCreature->getPlayer(); if (targetPlayer && targetPlayer != player && player->getSkullClient(targetPlayer) == SKULL_NONE && !Combat::isInPvpZone(player, targetPlayer)) { player->sendCancelMessage(RETURNVALUE_TURNSECUREMODETOATTACKUNMARKEDPLAYERS); g_game().addMagicEffect(player->getPosition(), CONST_ME_POFF); @@ -628,11 +631,11 @@ void Spell::setWheelOfDestinyBoost(WheelSpellBoost_t boost, WheelSpellGrade_t gr } } -void Spell::getCombatDataAugment(std::shared_ptr player, CombatDamage &damage) { +void Spell::getCombatDataAugment(const std::shared_ptr &player, CombatDamage &damage) const { if (!(damage.instantSpellName).empty()) { const auto equippedAugmentItems = player->getEquippedAugmentItems(); for (const auto &item : equippedAugmentItems) { - const auto augments = item->getAugmentsBySpellName(damage.instantSpellName); + const auto &augments = item->getAugmentsBySpellName(damage.instantSpellName); for (auto &augment : augments) { if (augment->value == 0) { continue; @@ -652,12 +655,12 @@ void Spell::getCombatDataAugment(std::shared_ptr player, CombatDamage &d } }; -int32_t Spell::calculateAugmentSpellCooldownReduction(std::shared_ptr player) const { +int32_t Spell::calculateAugmentSpellCooldownReduction(const std::shared_ptr &player) const { int32_t spellCooldown = 0; - const auto equippedAugmentItems = player->getEquippedAugmentItemsByType(Augment_t::Cooldown); + const auto &equippedAugmentItems = player->getEquippedAugmentItemsByType(Augment_t::Cooldown); for (const auto &item : equippedAugmentItems) { const auto augments = item->getAugmentsBySpellNameAndType(getName(), Augment_t::Cooldown); - for (auto &augment : augments) { + for (const auto &augment : augments) { spellCooldown += augment->value; } } @@ -665,7 +668,7 @@ int32_t Spell::calculateAugmentSpellCooldownReduction(std::shared_ptr pl return spellCooldown; } -void Spell::applyCooldownConditions(std::shared_ptr player) const { +void Spell::applyCooldownConditions(const std::shared_ptr &player) const { WheelSpellGrade_t spellGrade = player->wheel()->getSpellUpgrade(getName()); bool isUpgraded = getWheelOfDestinyUpgraded() && static_cast(spellGrade) > 0; // Safety check to prevent division by zero @@ -684,7 +687,7 @@ void Spell::applyCooldownConditions(std::shared_ptr player) const { spellCooldown -= player->wheel()->getSpellBonus(name, WheelSpellBoost_t::COOLDOWN); spellCooldown -= augmentCooldownReduction; if (spellCooldown > 0) { - std::shared_ptr condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_SPELLCOOLDOWN, spellCooldown / rateCooldown, 0, false, m_spellId); + const auto &condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_SPELLCOOLDOWN, spellCooldown / rateCooldown, 0, false, m_spellId); player->addCondition(condition); } } @@ -695,7 +698,7 @@ void Spell::applyCooldownConditions(std::shared_ptr player) const { spellGroupCooldown -= getWheelOfDestinyBoost(WheelSpellBoost_t::GROUP_COOLDOWN, spellGrade); } if (spellGroupCooldown > 0) { - std::shared_ptr condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_SPELLGROUPCOOLDOWN, spellGroupCooldown / rateCooldown, 0, false, group); + const auto &condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_SPELLGROUPCOOLDOWN, spellGroupCooldown / rateCooldown, 0, false, group); player->addCondition(condition); } } @@ -706,13 +709,13 @@ void Spell::applyCooldownConditions(std::shared_ptr player) const { spellSecondaryGroupCooldown -= getWheelOfDestinyBoost(WheelSpellBoost_t::SECONDARY_GROUP_COOLDOWN, spellGrade); } if (spellSecondaryGroupCooldown > 0) { - std::shared_ptr condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_SPELLGROUPCOOLDOWN, spellSecondaryGroupCooldown / rateCooldown, 0, false, secondaryGroup); + const auto &condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_SPELLGROUPCOOLDOWN, spellSecondaryGroupCooldown / rateCooldown, 0, false, secondaryGroup); player->addCondition(condition); } } } -void Spell::postCastSpell(std::shared_ptr player, bool finishedCast /*= true*/, bool payCost /*= true*/) const { +void Spell::postCastSpell(const std::shared_ptr &player, bool finishedCast /*= true*/, bool payCost /*= true*/) const { if (finishedCast) { if (!player->hasFlag(PlayerFlags_t::HasNoExhaustion)) { applyCooldownConditions(player); @@ -729,11 +732,11 @@ void Spell::postCastSpell(std::shared_ptr player, bool finishedCast /*= } if (payCost) { - Spell::postCastSpell(player, getManaCost(player), getSoulCost()); + postCastSpell(player, getManaCost(player), getSoulCost()); } } -void Spell::postCastSpell(std::shared_ptr player, uint32_t manaCost, uint32_t soulCost) { +void Spell::postCastSpell(const std::shared_ptr &player, uint32_t manaCost, uint32_t soulCost) { if (manaCost > 0) { player->addManaSpent(manaCost); player->changeMana(-static_cast(manaCost)); @@ -746,7 +749,7 @@ void Spell::postCastSpell(std::shared_ptr player, uint32_t manaCost, uin } } -uint32_t Spell::getManaCost(std::shared_ptr player) const { +uint32_t Spell::getManaCost(const std::shared_ptr &player) const { WheelSpellGrade_t spellGrade = player->wheel()->getSpellUpgrade(getName()); uint32_t manaRedution = 0; if (getWheelOfDestinyUpgraded() && static_cast(spellGrade) > 0) { @@ -773,7 +776,7 @@ uint32_t Spell::getManaCost(std::shared_ptr player) const { return 0; } -bool InstantSpell::playerCastInstant(std::shared_ptr player, std::string ¶m) { +bool InstantSpell::playerCastInstant(const std::shared_ptr &player, std::string ¶m) const { if (!playerSpellCheck(player)) { return false; } @@ -895,7 +898,7 @@ bool InstantSpell::playerCastInstant(std::shared_ptr player, std::string return result; } -bool InstantSpell::canThrowSpell(std::shared_ptr creature, std::shared_ptr target) const { +bool InstantSpell::canThrowSpell(const std::shared_ptr &creature, const std::shared_ptr &target) const { const Position &fromPos = creature->getPosition(); const Position &toPos = target->getPosition(); if (fromPos.z != toPos.z || (range == -1 && !g_game().canThrowObjectTo(fromPos, toPos, checkLineOfSight ? SightLine_CheckSightLineAndFloor : SightLine_NoCheck)) || (range != -1 && !g_game().canThrowObjectTo(fromPos, toPos, checkLineOfSight ? SightLine_CheckSightLineAndFloor : SightLine_NoCheck, range, range))) { @@ -904,12 +907,12 @@ bool InstantSpell::canThrowSpell(std::shared_ptr creature, std::shared return true; } -bool InstantSpell::castSpell(std::shared_ptr creature) { +bool InstantSpell::castSpell(const std::shared_ptr &creature) { LuaVariant var; var.instantName = getName(); if (casterTargetOrDirection) { - std::shared_ptr target = creature->getAttackedCreature(); + const auto &target = creature->getAttackedCreature(); if (target && target->getHealth() > 0) { if (!canThrowSpell(creature, target)) { return false; @@ -933,27 +936,26 @@ bool InstantSpell::castSpell(std::shared_ptr creature) { return executeCastSpell(creature, var); } -bool InstantSpell::castSpell(std::shared_ptr creature, std::shared_ptr target) { +bool InstantSpell::castSpell(const std::shared_ptr &creature, const std::shared_ptr &target) { if (needTarget) { LuaVariant var; var.type = VARIANT_NUMBER; var.number = target->getID(); return executeCastSpell(creature, var); - } else { - return castSpell(creature); } + return castSpell(creature); } -bool InstantSpell::executeCastSpell(std::shared_ptr creature, const LuaVariant &var) const { +bool InstantSpell::executeCastSpell(const std::shared_ptr &creature, const LuaVariant &var) const { // onCastSpell(creature, var) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaEnvironment::reserveScriptEnv()) { g_logger().error("[InstantSpell::executeCastSpell - Creature {} words {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName(), getWords()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaEnvironment::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -968,7 +970,7 @@ bool InstantSpell::executeCastSpell(std::shared_ptr creature, const Lu return getScriptInterface()->callFunction(2); } -bool InstantSpell::canCast(std::shared_ptr player) const { +bool InstantSpell::canCast(const std::shared_ptr &player) const { if (player->hasFlag(PlayerFlags_t::CannotUseSpells)) { return false; } @@ -990,7 +992,7 @@ bool InstantSpell::canCast(std::shared_ptr player) const { return false; } -ReturnValue RuneSpell::canExecuteAction(std::shared_ptr player, const Position &toPos) { +ReturnValue RuneSpell::canExecuteAction(const std::shared_ptr &player, const Position &toPos) { if (player->hasFlag(PlayerFlags_t::CannotUseSpells)) { return RETURNVALUE_CANNOTUSETHISOBJECT; } @@ -1011,7 +1013,7 @@ ReturnValue RuneSpell::canExecuteAction(std::shared_ptr player, const Po return RETURNVALUE_NOERROR; } -bool RuneSpell::executeUse(std::shared_ptr player, std::shared_ptr item, const Position &, std::shared_ptr target, const Position &toPosition, bool isHotkey) { +bool RuneSpell::executeUse(const std::shared_ptr &player, const std::shared_ptr &item, const Position &, const std::shared_ptr &target, const Position &toPosition, bool isHotkey) { if (!playerRuneSpellCheck(player, toPosition)) { return false; } @@ -1028,9 +1030,9 @@ bool RuneSpell::executeUse(std::shared_ptr player, std::shared_ptr var.type = VARIANT_NUMBER; if (target == nullptr) { - std::shared_ptr toTile = g_game().map.getTile(toPosition); + const auto &toTile = g_game().map.getTile(toPosition); if (toTile) { - std::shared_ptr visibleCreature = toTile->getBottomVisibleCreature(player); + const auto &visibleCreature = toTile->getBottomVisibleCreature(player); if (visibleCreature) { var.number = visibleCreature->getID(); } @@ -1063,7 +1065,7 @@ bool RuneSpell::executeUse(std::shared_ptr player, std::shared_ptr return true; } -bool RuneSpell::castSpell(std::shared_ptr creature) { +bool RuneSpell::castSpell(const std::shared_ptr &creature) { LuaVariant var; var.type = VARIANT_NUMBER; var.number = creature->getID(); @@ -1071,7 +1073,7 @@ bool RuneSpell::castSpell(std::shared_ptr creature) { return internalCastSpell(creature, var, false); } -bool RuneSpell::castSpell(std::shared_ptr creature, std::shared_ptr target) { +bool RuneSpell::castSpell(const std::shared_ptr &creature, const std::shared_ptr &target) { LuaVariant var; var.type = VARIANT_NUMBER; var.number = target->getID(); @@ -1079,26 +1081,26 @@ bool RuneSpell::castSpell(std::shared_ptr creature, std::shared_ptr creature, const LuaVariant &var, bool isHotkey) { +bool RuneSpell::internalCastSpell(const std::shared_ptr &creature, const LuaVariant &var, bool isHotkey) const { bool result; if (isLoadedCallback()) { - result = executeCastSpell(std::move(creature), var, isHotkey); + result = executeCastSpell(creature, var, isHotkey); } else { result = false; } return result; } -bool RuneSpell::executeCastSpell(std::shared_ptr creature, const LuaVariant &var, bool isHotkey) const { +bool RuneSpell::executeCastSpell(const std::shared_ptr &creature, const LuaVariant &var, bool isHotkey) const { // onCastSpell(creature, var, isHotkey) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaEnvironment::reserveScriptEnv()) { g_logger().error("[RuneSpell::executeCastSpell - Creature {} runeId {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName(), getRuneItemId()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaEnvironment::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); diff --git a/src/creatures/combat/spells.hpp b/src/creatures/combat/spells.hpp index 5bcc1e02c19..4e929b35e89 100644 --- a/src/creatures/combat/spells.hpp +++ b/src/creatures/combat/spells.hpp @@ -46,9 +46,9 @@ class Spells final : public Scripts { std::shared_ptr getInstantSpellById(uint16_t spellId); - TalkActionResult_t playerSaySpell(std::shared_ptr player, std::string &words); + TalkActionResult_t playerSaySpell(const std::shared_ptr &player, std::string &words); - static Position getCasterPosition(std::shared_ptr creature, Direction dir); + static Position getCasterPosition(const std::shared_ptr &creature, Direction dir); std::list getSpellsByVocation(uint16_t vocationId); @@ -58,13 +58,13 @@ class Spells final : public Scripts { [[nodiscard]] bool hasInstantSpell(const std::string &word) const; - void setInstantSpell(const std::string &word, const std::shared_ptr instant) { + void setInstantSpell(const std::string &word, const std::shared_ptr &instant) { instants.try_emplace(word, instant); } void clear(); - bool registerInstantLuaEvent(std::shared_ptr instant); - bool registerRuneLuaEvent(std::shared_ptr rune); + bool registerInstantLuaEvent(const std::shared_ptr &instant); + bool registerRuneLuaEvent(const std::shared_ptr &rune); private: std::map> runes; @@ -75,15 +75,15 @@ class Spells final : public Scripts { constexpr auto g_spells = Spells::getInstance; -using RuneSpellFunction = std::function spell, std::shared_ptr player, const Position &posTo)>; +using RuneSpellFunction [[maybe_unused]] = std::function &spell, const std::shared_ptr &player, const Position &posTo)>; class BaseSpell { public: constexpr BaseSpell() = default; virtual ~BaseSpell() = default; - virtual bool castSpell(std::shared_ptr creature) = 0; - virtual bool castSpell(std::shared_ptr creature, std::shared_ptr target) = 0; + virtual bool castSpell(const std::shared_ptr &creature) = 0; + virtual bool castSpell(const std::shared_ptr &creature, const std::shared_ptr &target) = 0; SoundEffect_t soundImpactEffect = SoundEffect_t::SILENCE; SoundEffect_t soundCastEffect = SoundEffect_t::SPELL_OR_RUNE; @@ -92,17 +92,17 @@ class BaseSpell { class CombatSpell final : public Script, public BaseSpell, public std::enable_shared_from_this { public: // Constructor - CombatSpell(std::shared_ptr newCombat, bool newNeedTarget, bool newNeedDirection); + CombatSpell(const std::shared_ptr &newCombat, bool newNeedTarget, bool newNeedDirection); // The copy constructor and the assignment operator have been deleted to prevent accidental copying. CombatSpell(const CombatSpell &) = delete; CombatSpell &operator=(const CombatSpell &) = delete; - bool castSpell(std::shared_ptr creature) override; - bool castSpell(std::shared_ptr creature, std::shared_ptr target) override; + bool castSpell(const std::shared_ptr &creature) override; + bool castSpell(const std::shared_ptr &creature, const std::shared_ptr &target) override; // Scripting spell - bool executeCastSpell(std::shared_ptr creature, const LuaVariant &var) const; + bool executeCastSpell(const std::shared_ptr &creature, const LuaVariant &var) const; bool loadScriptCombat(); std::shared_ptr getCombat() const { @@ -137,14 +137,14 @@ class Spell : public BaseSpell { m_spellId = id; } - void postCastSpell(std::shared_ptr player, bool finishedCast = true, bool payCost = true) const; - static void postCastSpell(std::shared_ptr player, uint32_t manaCost, uint32_t soulCost); + void postCastSpell(const std::shared_ptr &player, bool finishedCast = true, bool payCost = true) const; + static void postCastSpell(const std::shared_ptr &player, uint32_t manaCost, uint32_t soulCost); [[nodiscard]] virtual bool isInstant() const = 0; [[nodiscard]] bool isLearnable() const { return learnable; } - uint32_t getManaCost(std::shared_ptr player) const; + uint32_t getManaCost(const std::shared_ptr &player) const; [[nodiscard]] uint32_t getSoulCost() const { return soul; } @@ -345,14 +345,14 @@ class Spell : public BaseSpell { m_separator = newSeparator.data(); } - void getCombatDataAugment(std::shared_ptr player, CombatDamage &damage); - int32_t calculateAugmentSpellCooldownReduction(std::shared_ptr player) const; + void getCombatDataAugment(const std::shared_ptr &player, CombatDamage &damage) const; + int32_t calculateAugmentSpellCooldownReduction(const std::shared_ptr &player) const; protected: - void applyCooldownConditions(std::shared_ptr player) const; - bool playerSpellCheck(std::shared_ptr player) const; - bool playerInstantSpellCheck(std::shared_ptr player, const Position &toPos) const; - bool playerRuneSpellCheck(std::shared_ptr player, const Position &toPos); + void applyCooldownConditions(const std::shared_ptr &player) const; + bool playerSpellCheck(const std::shared_ptr &player) const; + bool playerInstantSpellCheck(const std::shared_ptr &player, const Position &toPos) const; + bool playerRuneSpellCheck(const std::shared_ptr &player, const Position &toPos) const; VocSpellMap vocSpellMap; @@ -399,13 +399,13 @@ class InstantSpell final : public Script, public Spell { public: using Script::Script; - virtual bool playerCastInstant(std::shared_ptr player, std::string ¶m); + bool playerCastInstant(const std::shared_ptr &player, std::string ¶m) const; - bool castSpell(std::shared_ptr creature) override; - bool castSpell(std::shared_ptr creature, std::shared_ptr target) override; + bool castSpell(const std::shared_ptr &creature) override; + bool castSpell(const std::shared_ptr &creature, const std::shared_ptr &target) override; // Scripting spell - bool executeCastSpell(std::shared_ptr creature, const LuaVariant &var) const; + bool executeCastSpell(const std::shared_ptr &creature, const LuaVariant &var) const; [[nodiscard]] bool isInstant() const override { return true; @@ -440,8 +440,8 @@ class InstantSpell final : public Script, public Spell { void setBlockWalls(bool w) { checkLineOfSight = w; } - bool canCast(std::shared_ptr player) const; - bool canThrowSpell(std::shared_ptr creature, std::shared_ptr target) const; + bool canCast(const std::shared_ptr &player) const; + bool canThrowSpell(const std::shared_ptr &creature, const std::shared_ptr &target) const; private: [[nodiscard]] std::string getScriptTypeName() const override { @@ -459,21 +459,21 @@ class RuneSpell final : public Action, public Spell { public: using Action::Action; - ReturnValue canExecuteAction(std::shared_ptr player, const Position &toPos) override; + ReturnValue canExecuteAction(const std::shared_ptr &player, const Position &toPos) override; bool hasOwnErrorHandler() override { return true; } - std::shared_ptr getTarget(std::shared_ptr, std::shared_ptr targetCreature, const Position &, uint8_t) const override { + std::shared_ptr getTarget(const std::shared_ptr &, const std::shared_ptr &targetCreature, const Position &, uint8_t) const override { return targetCreature; } - bool executeUse(std::shared_ptr player, std::shared_ptr item, const Position &fromPosition, std::shared_ptr target, const Position &toPosition, bool isHotkey) override; + bool executeUse(const std::shared_ptr &player, const std::shared_ptr &item, const Position &fromPosition, const std::shared_ptr &target, const Position &toPosition, bool isHotkey) override; - bool castSpell(std::shared_ptr creature) override; - bool castSpell(std::shared_ptr creature, std::shared_ptr target) override; + bool castSpell(const std::shared_ptr &creature) override; + bool castSpell(const std::shared_ptr &creature, const std::shared_ptr &target) override; // Scripting spell - bool executeCastSpell(std::shared_ptr creature, const LuaVariant &var, bool isHotkey) const; + bool executeCastSpell(const std::shared_ptr &creature, const LuaVariant &var, bool isHotkey) const; [[nodiscard]] bool isInstant() const override { return false; @@ -499,7 +499,7 @@ class RuneSpell final : public Action, public Spell { return "onCastSpell"; } - bool internalCastSpell(std::shared_ptr creature, const LuaVariant &var, bool isHotkey); + bool internalCastSpell(const std::shared_ptr &creature, const LuaVariant &var, bool isHotkey) const; uint16_t runeId = 0; uint32_t charges = 0; diff --git a/src/creatures/creature.cpp b/src/creatures/creature.cpp index 17c99a00d38..32b5ec10941 100644 --- a/src/creatures/creature.cpp +++ b/src/creatures/creature.cpp @@ -17,7 +17,7 @@ #include "lib/metrics/metrics.hpp" Creature::Creature() { - onIdleStatus(); + Creature::onIdleStatus(); } Creature::~Creature() { @@ -52,7 +52,7 @@ bool Creature::canSee(const Position &pos) { return canSee(getPosition(), pos, MAP_MAX_VIEW_PORT_X, MAP_MAX_VIEW_PORT_Y); } -bool Creature::canSeeCreature(std::shared_ptr creature) const { +bool Creature::canSeeCreature(const std::shared_ptr &creature) const { if (!canSeeInvisibility() && creature->isInvisible()) { return false; } @@ -94,13 +94,13 @@ void Creature::onThink(uint32_t interval) { updateMapCache(); } - auto followCreature = getFollowCreature(); - auto master = getMaster(); + const auto &followCreature = getFollowCreature(); + const auto &master = getMaster(); if (followCreature && master != followCreature && !canSeeCreature(followCreature)) { onCreatureDisappear(followCreature, false); } - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (attackedCreature && master != attackedCreature && !canSeeCreature(attackedCreature)) { onCreatureDisappear(attackedCreature, false); } @@ -138,7 +138,7 @@ void Creature::onThink(uint32_t interval) { } void Creature::onAttacking(uint32_t interval) { - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (!attackedCreature) { return; } @@ -304,19 +304,19 @@ void Creature::updateMapCache() { } } -void Creature::updateTileCache(std::shared_ptr newTile, int32_t dx, int32_t dy) { +void Creature::updateTileCache(const std::shared_ptr &newTile, int32_t dx, int32_t dy) { metrics::method_latency measure(__METHOD_NAME__); if (std::abs(dx) <= maxWalkCacheWidth && std::abs(dy) <= maxWalkCacheHeight) { localMapCache[maxWalkCacheHeight + dy][maxWalkCacheWidth + dx] = newTile && newTile->queryAdd(0, getCreature(), 1, FLAG_PATHFINDING | FLAG_IGNOREFIELDDAMAGE) == RETURNVALUE_NOERROR; } } -void Creature::updateTileCache(std::shared_ptr upTile, const Position &pos) { +void Creature::updateTileCache(const std::shared_ptr &upTile, const Position &pos) { const Position &myPos = getPosition(); if (pos.z == myPos.z) { int32_t dx = Position::getOffsetX(pos, myPos); int32_t dy = Position::getOffsetY(pos, myPos); - updateTileCache(std::move(upTile), dx, dy); + updateTileCache(upTile, dx, dy); } } @@ -347,37 +347,37 @@ int32_t Creature::getWalkCache(const Position &pos) { return 2; } -void Creature::onAddTileItem(std::shared_ptr tileItem, const Position &pos) { +void Creature::onAddTileItem(const std::shared_ptr &tileItem, const Position &pos) { if (isMapLoaded && pos.z == getPosition().z) { - updateTileCache(std::move(tileItem), pos); + updateTileCache(tileItem, pos); } } -void Creature::onUpdateTileItem(std::shared_ptr updateTile, const Position &pos, std::shared_ptr, const ItemType &oldType, std::shared_ptr, const ItemType &newType) { +void Creature::onUpdateTileItem(const std::shared_ptr &updateTile, const Position &pos, const std::shared_ptr &, const ItemType &oldType, const std::shared_ptr &, const ItemType &newType) { if (!isMapLoaded) { return; } if (oldType.blockSolid || oldType.blockPathFind || newType.blockPathFind || newType.blockSolid) { if (pos.z == getPosition().z) { - updateTileCache(std::move(updateTile), pos); + updateTileCache(updateTile, pos); } } } -void Creature::onRemoveTileItem(std::shared_ptr updateTile, const Position &pos, const ItemType &iType, std::shared_ptr) { +void Creature::onRemoveTileItem(const std::shared_ptr &updateTile, const Position &pos, const ItemType &iType, const std::shared_ptr &) { if (!isMapLoaded) { return; } if (iType.blockSolid || iType.blockPathFind || iType.isGroundTile()) { if (pos.z == getPosition().z) { - updateTileCache(std::move(updateTile), pos); + updateTileCache(updateTile, pos); } } } -void Creature::onCreatureAppear(std::shared_ptr creature, bool isLogin) { +void Creature::onCreatureAppear(const std::shared_ptr &creature, bool isLogin) { metrics::method_latency measure(__METHOD_NAME__); if (creature.get() == this) { if (useCacheMap()) { @@ -395,23 +395,23 @@ void Creature::onCreatureAppear(std::shared_ptr creature, bool isLogin } } -void Creature::onRemoveCreature(std::shared_ptr creature, bool) { +void Creature::onRemoveCreature(const std::shared_ptr &creature, bool) { metrics::method_latency measure(__METHOD_NAME__); onCreatureDisappear(creature, true); - if (creature != getCreature() && isMapLoaded) { + if (creature && creature != getCreature() && isMapLoaded) { if (creature->getPosition().z == getPosition().z) { updateTileCache(creature->getTile(), creature->getPosition()); } } // Update player from monster target list (avoid memory usage after clean) - if (auto monster = getMonster(); monster && monster->getAttackedCreature() == creature) { + if (const auto &monster = getMonster(); monster && monster->getAttackedCreature() == creature) { monster->setAttackedCreature(creature); monster->setFollowCreature(creature); } } -void Creature::onCreatureDisappear(std::shared_ptr creature, bool isLogout) { +void Creature::onCreatureDisappear(const std::shared_ptr &creature, bool isLogout) { metrics::method_latency measure(__METHOD_NAME__); if (getAttackedCreature() == creature) { setAttackedCreature(nullptr); @@ -426,7 +426,7 @@ void Creature::onCreatureDisappear(std::shared_ptr creature, bool isLo void Creature::onChangeZone(ZoneType_t zone) { metrics::method_latency measure(__METHOD_NAME__); - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (attackedCreature && zone == ZONE_PROTECTION) { onCreatureDisappear(attackedCreature, false); } @@ -435,7 +435,7 @@ void Creature::onChangeZone(ZoneType_t zone) { void Creature::onAttackedCreatureChangeZone(ZoneType_t zone) { metrics::method_latency measure(__METHOD_NAME__); if (zone == ZONE_PROTECTION) { - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (attackedCreature) { onCreatureDisappear(attackedCreature, false); } @@ -447,6 +447,10 @@ void Creature::checkSummonMove(const Position &newPos, bool teleportSummon) { if (hasSummons()) { std::vector> despawnMonsterList; for (const auto &summon : getSummons()) { + if (!summon) { + continue; + } + const auto &pos = summon->getPosition(); const auto &monster = summon->getMonster(); const auto &tile = getTile(); @@ -507,7 +511,7 @@ void Creature::onCreatureMove(const std::shared_ptr &creature, const s handleLostSummon(configTeleportSummons); } - if (std::shared_ptr player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { if (player->isExerciseTraining()) { player->setTraining(false); } @@ -591,7 +595,7 @@ void Creature::onCreatureMove(const std::shared_ptr &creature, const s // update 0 for (int32_t y = -maxWalkCacheHeight; y <= maxWalkCacheHeight; ++y) { - std::shared_ptr cacheTile = g_game().map.getTile(myPos.x - maxWalkCacheWidth, static_cast(myPos.y + y), myPos.z); + const auto &cacheTile = g_game().map.getTile(myPos.x - maxWalkCacheWidth, static_cast(myPos.y + y), myPos.z); updateTileCache(cacheTile, -maxWalkCacheWidth, y); } } @@ -646,7 +650,7 @@ void Creature::onDeath() { metrics::method_latency measure(__METHOD_NAME__); bool lastHitUnjustified = false; bool mostDamageUnjustified = false; - std::shared_ptr lastHitCreature = g_game().getCreatureByID(lastHitCreatureId); + const auto &lastHitCreature = g_game().getCreatureByID(lastHitCreatureId); std::shared_ptr lastHitCreatureMaster; if (lastHitCreature && getPlayer()) { /** @@ -666,21 +670,29 @@ void Creature::onDeath() { int32_t mostDamage = 0; std::map, uint64_t> experienceMap; std::unordered_set> killers; - for (const auto &it : damageMap) { - if (auto attacker = g_game().getCreatureByID(it.first)) { - CountBlock_t cb = it.second; - if ((cb.total > mostDamage && (timeNow - cb.ticks <= inFightTicks))) { - mostDamage = cb.total; + for (const auto &[creatureId, damageInfo] : damageMap) { + if (creatureId == 0) { + continue; + } + + if (auto attacker = g_game().getCreatureByID(creatureId)) { + const auto &[total, ticks] = damageInfo; + if (total == 0 || ticks == 0) { + continue; + } + + if (total > mostDamage && timeNow - ticks <= inFightTicks) { + mostDamage = total; mostDamageCreature = attacker; } if (attacker != getCreature()) { - uint64_t gainExp = getGainedExperience(attacker); - auto attackerMaster = attacker->getMaster() ? attacker->getMaster() : attacker; + const uint64_t gainExp = getGainedExperience(attacker); + const auto &attackerMaster = attacker->getMaster() ? attacker->getMaster() : attacker; if (auto attackerPlayer = attackerMaster->getPlayer()) { attackerPlayer->removeAttacked(getPlayer()); - auto party = attackerPlayer->getParty(); + const auto &party = attackerPlayer->getParty(); killers.insert(attackerPlayer); if (party && party->getLeader() && party->isSharedExperienceActive() && party->isSharedExperienceEnabled()) { attacker = party->getLeader(); @@ -703,15 +715,15 @@ void Creature::onDeath() { } } - for (const auto &it : experienceMap) { - it.first->onGainExperience(it.second, getCreature()); + for (const auto &[creature, experience] : experienceMap) { + creature->onGainExperience(experience, getCreature()); } mostDamageCreature = mostDamageCreature && mostDamageCreature->getMaster() ? mostDamageCreature->getMaster() : mostDamageCreature; for (const auto &killer : killers) { - if (auto monster = getMonster()) { + if (const auto &monster = getMonster()) { killer->onKilledMonster(monster); - } else if (auto player = getPlayer(); player && mostDamageCreature != killer) { + } else if (const auto &player = getPlayer(); player && mostDamageCreature != killer) { killer->onKilledPlayer(player, false); } } @@ -719,7 +731,7 @@ void Creature::onDeath() { /** * @deprecated -- This is here to trigger the deprecated onKill events in lua */ - auto mostDamageCreatureMaster = mostDamageCreature ? mostDamageCreature->getMaster() : nullptr; + const auto &mostDamageCreatureMaster = mostDamageCreature ? mostDamageCreature->getMaster() : nullptr; if (mostDamageCreature && (mostDamageCreature != lastHitCreature || getMonster()) && mostDamageCreature != lastHitCreatureMaster) { if (lastHitCreature != mostDamageCreatureMaster && (lastHitCreatureMaster == nullptr || mostDamageCreatureMaster != lastHitCreatureMaster)) { mostDamageUnjustified = mostDamageCreature->deprecatedOnKilledCreature(getCreature(), false); @@ -772,7 +784,7 @@ void Creature::onDeath() { } } -bool Creature::dropCorpse(std::shared_ptr lastHitCreature, std::shared_ptr mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified) { +bool Creature::dropCorpse(const std::shared_ptr &lastHitCreature, const std::shared_ptr &mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified) { metrics::method_latency measure(__METHOD_NAME__); if (!lootDrop && getMonster()) { if (getMaster()) { @@ -804,22 +816,22 @@ bool Creature::dropCorpse(std::shared_ptr lastHitCreature, std::shared break; } - std::shared_ptr tile = getTile(); + const auto &tile = getTile(); if (tile && splash) { g_game().internalAddItem(tile, splash, INDEX_WHEREEVER, FLAG_NOLIMIT); splash->startDecaying(); } - std::shared_ptr corpse = getCorpse(lastHitCreature, mostDamageCreature); + const auto &corpse = getCorpse(lastHitCreature, mostDamageCreature); if (tile && corpse) { g_game().internalAddItem(tile, corpse, INDEX_WHEREEVER, FLAG_NOLIMIT); dropLoot(corpse->getContainer(), lastHitCreature); corpse->startDecaying(); - bool disallowedCorpses = corpse->isRewardCorpse() || (corpse->getID() == ITEM_MALE_CORPSE || corpse->getID() == ITEM_FEMALE_CORPSE); - const auto player = mostDamageCreature ? mostDamageCreature->getPlayer() : nullptr; - auto corpseContainer = corpse->getContainer(); + const bool disallowedCorpses = corpse->isRewardCorpse() || (corpse->getID() == ITEM_MALE_CORPSE || corpse->getID() == ITEM_FEMALE_CORPSE); + const auto &player = mostDamageCreature ? mostDamageCreature->getPlayer() : nullptr; + const auto &corpseContainer = corpse->getContainer(); if (corpseContainer && player && !disallowedCorpses) { - auto monster = getMonster(); + const auto &monster = getMonster(); if (monster && !monster->isRewardBoss()) { std::ostringstream lootMessage; auto collorMessage = player->getProtocolVersion() > 1200; @@ -869,7 +881,7 @@ bool Creature::hasBeenAttacked(uint32_t attackerId) { return (OTSYS_TIME() - it->second.ticks) <= g_configManager().getNumber(PZ_LOCKED); } -std::shared_ptr Creature::getCorpse(std::shared_ptr, std::shared_ptr) { +std::shared_ptr Creature::getCorpse(const std::shared_ptr &, const std::shared_ptr &) { if (getLookCorpse() != 0) { return Item::CreateItem(getLookCorpse()); } @@ -901,14 +913,14 @@ void Creature::changeMana(int32_t manaChange) { } } -void Creature::gainHealth(std::shared_ptr healer, int32_t healthGain) { +void Creature::gainHealth(const std::shared_ptr &healer, int32_t healthGain) { changeHealth(healthGain); if (healer) { healer->onTargetCreatureGainHealth(static_self_cast(), healthGain); } } -void Creature::drainHealth(std::shared_ptr attacker, int32_t damage) { +void Creature::drainHealth(const std::shared_ptr &attacker, int32_t damage) { changeHealth(-damage, false); if (attacker) { @@ -916,7 +928,7 @@ void Creature::drainHealth(std::shared_ptr attacker, int32_t damage) { } } -void Creature::drainMana(std::shared_ptr attacker, int32_t manaLoss) { +void Creature::drainMana(const std::shared_ptr &attacker, int32_t manaLoss) { onAttacked(); changeMana(-manaLoss); @@ -939,7 +951,7 @@ void Creature::mitigateDamage(const CombatType_t &combatType, BlockType_t &block } } -void Creature::applyAbsorbDamageModifications(std::shared_ptr attacker, int32_t &damage, CombatType_t combatType) const { +void Creature::applyAbsorbDamageModifications(const std::shared_ptr &attacker, int32_t &damage, CombatType_t combatType) const { if (combatType != COMBAT_HEALING && damage != 0) { int32_t value = getAbsorbPercent(combatType); if (value != 0) { @@ -959,7 +971,7 @@ void Creature::applyAbsorbDamageModifications(std::shared_ptr attacker } } -BlockType_t Creature::blockHit(std::shared_ptr attacker, CombatType_t combatType, int32_t &damage, bool checkDefense /* = false */, bool checkArmor /* = false */, bool /* field = false */) { +BlockType_t Creature::blockHit(const std::shared_ptr &attacker, const CombatType_t &combatType, int32_t &damage, bool checkDefense /* = false */, bool checkArmor /* = false */, bool /* field = false */) { BlockType_t blockType = BLOCK_NONE; // Apply skills 12.72 absorbs damage @@ -1026,10 +1038,10 @@ BlockType_t Creature::blockHit(std::shared_ptr attacker, CombatType_t return blockType; } -bool Creature::setAttackedCreature(std::shared_ptr creature) { +bool Creature::setAttackedCreature(const std::shared_ptr &creature) { if (creature) { - auto monster = getMonster(); - auto tile = getTile(); + const auto &monster = getMonster(); + const auto &tile = getTile(); if (monster && monster->isFamiliar() && tile && tile->hasFlag(TILESTATE_PROTECTIONZONE)) { return false; } @@ -1115,16 +1127,16 @@ void Creature::goToFollowCreature() { } } -bool Creature::canFollowMaster() { - auto master = getMaster(); +bool Creature::canFollowMaster() const { + const auto &master = getMaster(); if (!master) { return false; } - auto tile = master->getTile(); + const auto &tile = master->getTile(); return tile && !tile->hasFlag(TILESTATE_PROTECTIONZONE) && (canSeeInvisibility() || !master->isInvisible()); } -bool Creature::setFollowCreature(std::shared_ptr creature) { +bool Creature::setFollowCreature(const std::shared_ptr &creature) { metrics::method_latency measure(__METHOD_NAME__); if (creature) { if (getFollowCreature() == creature) { @@ -1160,15 +1172,19 @@ bool Creature::setFollowCreature(std::shared_ptr creature) { return true; } -double Creature::getDamageRatio(std::shared_ptr attacker) const { +double Creature::getDamageRatio(const std::shared_ptr &attacker) const { uint32_t totalDamage = 0; uint32_t attackerDamage = 0; - for (const auto &it : damageMap) { - const CountBlock_t &cb = it.second; - totalDamage += cb.total; - if (it.first == attacker->getID()) { - attackerDamage += cb.total; + for (const auto &[attackerId, damageInfo] : damageMap) { + const auto &[totalDamageValue, ticks] = damageInfo; + if (attackerId == 0 || totalDamageValue == 0) { + continue; + } + + totalDamage += totalDamageValue; + if (attackerId == attacker->getID()) { + attackerDamage += totalDamageValue; } } @@ -1179,11 +1195,11 @@ double Creature::getDamageRatio(std::shared_ptr attacker) const { return (static_cast(attackerDamage) / totalDamage); } -uint64_t Creature::getGainedExperience(std::shared_ptr attacker) const { - return std::floor(getDamageRatio(std::move(attacker)) * getLostExperience()); +uint64_t Creature::getGainedExperience(const std::shared_ptr &attacker) const { + return std::floor(getDamageRatio(attacker) * getLostExperience()); } -void Creature::addDamagePoints(std::shared_ptr attacker, int32_t damagePoints) { +void Creature::addDamagePoints(const std::shared_ptr &attacker, int32_t damagePoints) { if (damagePoints <= 0) { return; } @@ -1221,8 +1237,8 @@ void Creature::onEndCondition(ConditionType_t) { } void Creature::onTickCondition(ConditionType_t type, bool &bRemove) { - auto tile = getTile(); - std::shared_ptr field = tile ? tile->getFieldItem() : nullptr; + const auto &tile = getTile(); + const auto &field = tile ? tile->getFieldItem() : nullptr; if (!field) { return; } @@ -1257,19 +1273,19 @@ void Creature::onTickCondition(ConditionType_t type, bool &bRemove) { } } -void Creature::onCombatRemoveCondition(std::shared_ptr condition) { - removeCondition(std::move(condition)); +void Creature::onCombatRemoveCondition(const std::shared_ptr &condition) { + removeCondition(condition); } void Creature::onAttacked() { // } -void Creature::onAttackedCreatureDrainHealth(std::shared_ptr target, int32_t points) { +void Creature::onAttackedCreatureDrainHealth(const std::shared_ptr &target, int32_t points) { target->addDamagePoints(static_self_cast(), points); } -void Creature::onAttackedCreatureKilled(std::shared_ptr target) { +void Creature::onAttackedCreatureKilled(const std::shared_ptr &target) { metrics::method_latency measure(__METHOD_NAME__); if (target != getCreature()) { uint64_t gainExp = target->getGainedExperience(static_self_cast()); @@ -1277,9 +1293,9 @@ void Creature::onAttackedCreatureKilled(std::shared_ptr target) { } } -bool Creature::deprecatedOnKilledCreature(std::shared_ptr target, bool lastHit) { +bool Creature::deprecatedOnKilledCreature(const std::shared_ptr &target, bool lastHit) { metrics::method_latency measure(__METHOD_NAME__); - auto master = getMaster(); + const auto &master = getMaster(); if (master) { master->deprecatedOnKilledCreature(target, lastHit); } @@ -1292,19 +1308,19 @@ bool Creature::deprecatedOnKilledCreature(std::shared_ptr target, bool return false; } -void Creature::onGainExperience(uint64_t gainExp, std::shared_ptr target) { +void Creature::onGainExperience(uint64_t gainExp, const std::shared_ptr &target) { metrics::method_latency measure(__METHOD_NAME__); - auto master = getMaster(); + const auto &master = getMaster(); if (gainExp == 0 || !master) { return; } - std::shared_ptr m = getMonster(); + const auto &m = getMonster(); if (!m->isFamiliar()) { gainExp /= 2; } - master->onGainExperience(gainExp, std::move(target)); + master->onGainExperience(gainExp, target); if (!m->isFamiliar()) { auto spectators = Spectators().find(position); @@ -1323,11 +1339,11 @@ void Creature::onGainExperience(uint64_t gainExp, std::shared_ptr targ } } -bool Creature::setMaster(std::shared_ptr newMaster, bool reloadCreature /* = false*/) { +bool Creature::setMaster(const std::shared_ptr &newMaster, bool reloadCreature /* = false*/) { metrics::method_latency measure(__METHOD_NAME__); // Persists if this creature has ever been a summon this->summoned = true; - auto oldMaster = getMaster(); + const auto &oldMaster = getMaster(); if (!newMaster && !oldMaster) { return false; @@ -1348,7 +1364,7 @@ bool Creature::setMaster(std::shared_ptr newMaster, bool reloadCreatur m_master = newMaster; if (oldMaster) { - const auto &it = std::ranges::find(oldMaster->m_summons, self); + auto it = std::ranges::find(oldMaster->m_summons, self); if (it != oldMaster->m_summons.end()) { oldMaster->m_summons.erase(it); } @@ -1356,7 +1372,7 @@ bool Creature::setMaster(std::shared_ptr newMaster, bool reloadCreatur return true; } -bool Creature::addCondition(std::shared_ptr condition, bool attackerPlayer /* = false*/) { +bool Creature::addCondition(const std::shared_ptr &condition, bool attackerPlayer /* = false*/) { metrics::method_latency measure(__METHOD_NAME__); if (condition == nullptr) { return false; @@ -1364,14 +1380,14 @@ bool Creature::addCondition(std::shared_ptr condition, bool attackerP if (isSuppress(condition->getType(), attackerPlayer)) { return false; } - std::shared_ptr prevCond = getCondition(condition->getType(), condition->getId(), condition->getSubId()); + const auto &prevCond = getCondition(condition->getType(), condition->getId(), condition->getSubId()); if (prevCond) { prevCond->addCondition(getCreature(), condition); return true; } if (condition->startCondition(getCreature())) { - conditions.push_back(condition); + conditions.emplace_back(condition); onAddCondition(condition->getType()); return true; } @@ -1379,8 +1395,11 @@ bool Creature::addCondition(std::shared_ptr condition, bool attackerP return false; } -bool Creature::addCombatCondition(std::shared_ptr condition, bool attackerPlayer /* = false*/) { - // Caution: condition variable could be deleted after the call to addCondition +bool Creature::addCombatCondition(const std::shared_ptr &condition, bool attackerPlayer /* = false*/) { + if (condition == nullptr) { + return false; + } + ConditionType_t type = condition->getType(); if (!addCondition(condition, attackerPlayer)) { @@ -1411,9 +1430,10 @@ void Creature::removeCondition(ConditionType_t type) { void Creature::removeCondition(ConditionType_t conditionType, ConditionId_t conditionId, bool force /* = false*/) { metrics::method_latency measure(__METHOD_NAME__); - auto it = conditions.begin(), end = conditions.end(); + auto it = conditions.begin(); + const auto end = conditions.end(); while (it != end) { - std::shared_ptr condition = *it; + auto condition = *it; if (condition->getType() != conditionType || condition->getId() != conditionId) { ++it; continue; @@ -1441,7 +1461,7 @@ void Creature::removeCombatCondition(ConditionType_t type) { std::vector> removeConditions; for (const auto &condition : conditions) { if (condition->getType() == type) { - removeConditions.push_back(condition); + removeConditions.emplace_back(condition); } } @@ -1450,8 +1470,8 @@ void Creature::removeCombatCondition(ConditionType_t type) { } } -void Creature::removeCondition(std::shared_ptr condition) { - auto it = std::find(conditions.begin(), conditions.end(), condition); +void Creature::removeCondition(const std::shared_ptr &condition) { + const auto it = std::ranges::find(conditions, condition); if (it == conditions.end()) { return; } @@ -1485,7 +1505,7 @@ std::vector> Creature::getConditionsByType(ConditionT std::vector> conditionsVec; for (const auto &condition : conditions) { if (condition->getType() == type) { - conditionsVec.push_back(condition); + conditionsVec.emplace_back(condition); } } return conditionsVec; @@ -1593,7 +1613,7 @@ void Creature::setNormalCreatureLight() { } bool Creature::registerCreatureEvent(const std::string &name) { - const auto event = g_creatureEvents().getEventByName(name); + const auto &event = g_creatureEvents().getEventByName(name); if (!event) { return false; } @@ -1609,12 +1629,12 @@ bool Creature::registerCreatureEvent(const std::string &name) { scriptEventsBitField |= static_cast(1) << type; } - eventsList.push_back(event); + eventsList.emplace_back(event); return true; } bool Creature::unregisterCreatureEvent(const std::string &name) { - const auto event = g_creatureEvents().getEventByName(name); + const auto &event = g_creatureEvents().getEventByName(name); if (!event) { return false; } @@ -1646,7 +1666,7 @@ bool Creature::unregisterCreatureEvent(const std::string &name) { return true; } -CreatureEventList Creature::getCreatureEvents(CreatureEventType_t type) { +CreatureEventList Creature::getCreatureEvents(CreatureEventType_t type) const { CreatureEventList tmpEventList; if (!hasEventRegistered(type)) { @@ -1655,7 +1675,7 @@ CreatureEventList Creature::getCreatureEvents(CreatureEventType_t type) { for (const auto &creatureEventPtr : eventsList) { if (creatureEventPtr->getEventType() == type) { - tmpEventList.push_back(creatureEventPtr); + tmpEventList.emplace_back(creatureEventPtr); } } @@ -1728,8 +1748,7 @@ bool FrozenPathingConditionCall::operator()(const Position &startPos, const Posi if (testDist == fpp.maxTargetDist) { bestMatchDist = 0; return true; - } else if (testDist > bestMatchDist) { - // not quite what we want, but the best so far + } else if (testDist > bestMatchDist) { // not quite what we want, but the best so far bestMatchDist = testDist; return true; } @@ -1738,7 +1757,7 @@ bool FrozenPathingConditionCall::operator()(const Position &startPos, const Posi } bool Creature::isInvisible() const { - return std::find_if(conditions.begin(), conditions.end(), [](const std::shared_ptr &condition) { + return std::ranges::find_if(conditions, [](const std::shared_ptr &condition) { return condition->getType() == CONDITION_INVISIBLE; }) != conditions.end(); @@ -1762,7 +1781,7 @@ bool Creature::getPathTo(const Position &targetPos, std::vector &dirL return getPathTo(targetPos, dirList, fpp); } -void Creature::turnToCreature(std::shared_ptr creature) { +void Creature::turnToCreature(const std::shared_ptr &creature) { const Position &creaturePos = creature->getPosition(); const auto dx = Position::getOffsetX(position, creaturePos); const auto dy = Position::getOffsetY(position, creaturePos); @@ -1901,7 +1920,7 @@ std::unordered_set> Creature::getZones() { } void Creature::iconChanged() { - auto tile = getTile(); + const auto &tile = getTile(); if (!tile) { return; } diff --git a/src/creatures/creature.hpp b/src/creatures/creature.hpp index eea144448ba..5a8463e9e30 100644 --- a/src/creatures/creature.hpp +++ b/src/creatures/creature.hpp @@ -40,7 +40,7 @@ static constexpr int32_t EVENT_CHECK_CREATURE_INTERVAL = (EVENT_CREATURE_THINK_I class FrozenPathingConditionCall { public: explicit FrozenPathingConditionCall(Position newTargetPos) : - targetPos(std::move(newTargetPos)) { } + targetPos(newTargetPos) { } bool operator()(const Position &startPos, const Position &testPos, const FindPathParams &fpp, int32_t &bestMatchDist) const; @@ -79,7 +79,7 @@ class Creature : virtual public Thing, public SharedObject { std::shared_ptr getCreature() const override final { return static_self_cast(); } - virtual std::shared_ptr getPlayer() { + std::shared_ptr getPlayer() override { return nullptr; } virtual std::shared_ptr getPlayer() const { @@ -117,7 +117,7 @@ class Creature : virtual public Thing, public SharedObject { virtual void addList() = 0; virtual bool canSee(const Position &pos); - virtual bool canSeeCreature(std::shared_ptr creature) const; + virtual bool canSeeCreature(const std::shared_ptr &creature) const; virtual RaceType_t getRace() const { return RACE_NONE; @@ -125,7 +125,7 @@ class Creature : virtual public Thing, public SharedObject { virtual Skulls_t getSkull() const { return skull; } - virtual Skulls_t getSkullClient(std::shared_ptr creature) { + virtual Skulls_t getSkullClient(const std::shared_ptr &creature) { return creature->getSkull(); } void setSkull(Skulls_t newSkull); @@ -322,7 +322,7 @@ class Creature : virtual public Thing, public SharedObject { std::shared_ptr getFollowCreature() const { return m_followCreature.lock(); } - virtual bool setFollowCreature(std::shared_ptr creature); + virtual bool setFollowCreature(const std::shared_ptr &creature); // follow events virtual void onFollowCreature(const std::shared_ptr &) { @@ -333,10 +333,10 @@ class Creature : virtual public Thing, public SharedObject { } // combat functions - std::shared_ptr getAttackedCreature() { + std::shared_ptr getAttackedCreature() const { return m_attackedCreature.lock(); } - virtual bool setAttackedCreature(std::shared_ptr creature); + virtual bool setAttackedCreature(const std::shared_ptr &creature); /** * @brief Mitigates damage inflicted on a creature. @@ -351,11 +351,11 @@ class Creature : virtual public Thing, public SharedObject { * @param damage Reference to the amount of damage inflicted, which will be reduced by the creature's mitigation factor. */ void mitigateDamage(const CombatType_t &combatType, BlockType_t &blockType, int32_t &damage) const; - virtual BlockType_t blockHit(std::shared_ptr attacker, CombatType_t combatType, int32_t &damage, bool checkDefense = false, bool checkArmor = false, bool field = false); + virtual BlockType_t blockHit(const std::shared_ptr &attacker, const CombatType_t &combatType, int32_t &damage, bool checkDefense = false, bool checkArmor = false, bool field = false); - void applyAbsorbDamageModifications(std::shared_ptr attacker, int32_t &damage, CombatType_t combatType) const; + void applyAbsorbDamageModifications(const std::shared_ptr &attacker, int32_t &damage, CombatType_t combatType) const; - bool setMaster(std::shared_ptr newMaster, bool reloadCreature = false); + bool setMaster(const std::shared_ptr &newMaster, bool reloadCreature = false); void removeMaster() { if (getMaster()) { @@ -401,11 +401,11 @@ class Creature : virtual public Thing, public SharedObject { return SPEECHBUBBLE_NONE; } - bool addCondition(std::shared_ptr condition, bool attackerPlayer = false); - bool addCombatCondition(std::shared_ptr condition, bool attackerPlayer = false); + bool addCondition(const std::shared_ptr &condition, bool attackerPlayer = false); + bool addCombatCondition(const std::shared_ptr &condition, bool attackerPlayer = false); void removeCondition(ConditionType_t conditionType, ConditionId_t conditionId, bool force = false); void removeCondition(ConditionType_t type); - void removeCondition(std::shared_ptr condition); + void removeCondition(const std::shared_ptr &condition); void removeCombatCondition(ConditionType_t type); std::shared_ptr getCondition(ConditionType_t type) const; std::shared_ptr getCondition(ConditionType_t type, ConditionId_t conditionId, uint32_t subId = 0) const; @@ -433,17 +433,17 @@ class Creature : virtual public Thing, public SharedObject { virtual void changeHealth(int32_t healthChange, bool sendHealthChange = true); virtual void changeMana(int32_t manaChange); - void gainHealth(std::shared_ptr attacker, int32_t healthGain); - virtual void drainHealth(std::shared_ptr attacker, int32_t damage); - virtual void drainMana(std::shared_ptr attacker, int32_t manaLoss); + void gainHealth(const std::shared_ptr &attacker, int32_t healthGain); + virtual void drainHealth(const std::shared_ptr &attacker, int32_t damage); + virtual void drainMana(const std::shared_ptr &attacker, int32_t manaLoss); - virtual bool challengeCreature(std::shared_ptr, [[maybe_unused]] int targetChangeCooldown) { + virtual bool challengeCreature(const std::shared_ptr &, [[maybe_unused]] int targetChangeCooldown) { return false; } void onDeath(); - virtual uint64_t getGainedExperience(std::shared_ptr attacker) const; - void addDamagePoints(std::shared_ptr attacker, int32_t damagePoints); + virtual uint64_t getGainedExperience(const std::shared_ptr &attacker) const; + void addDamagePoints(const std::shared_ptr &attacker, int32_t damagePoints); bool hasBeenAttacked(uint32_t attackerId); // combat event functions @@ -451,26 +451,26 @@ class Creature : virtual public Thing, public SharedObject { virtual void onAddCombatCondition(ConditionType_t type); virtual void onEndCondition(ConditionType_t type); void onTickCondition(ConditionType_t type, bool &bRemove); - virtual void onCombatRemoveCondition(std::shared_ptr condition); - virtual void onAttackedCreature(std::shared_ptr) { } + virtual void onCombatRemoveCondition(const std::shared_ptr &condition); + virtual void onAttackedCreature(const std::shared_ptr &) { } virtual void onAttacked(); - virtual void onAttackedCreatureDrainHealth(std::shared_ptr target, int32_t points); - virtual void onTargetCreatureGainHealth(std::shared_ptr, int32_t) { } - void onAttackedCreatureKilled(std::shared_ptr target); + virtual void onAttackedCreatureDrainHealth(const std::shared_ptr &target, int32_t points); + virtual void onTargetCreatureGainHealth(const std::shared_ptr &, int32_t) { } + void onAttackedCreatureKilled(const std::shared_ptr &target); /** * @deprecated -- This is here to trigger the deprecated onKill events in lua */ - bool deprecatedOnKilledCreature(std::shared_ptr target, bool lastHit); + bool deprecatedOnKilledCreature(const std::shared_ptr &target, bool lastHit); virtual bool onKilledPlayer([[maybe_unused]] const std::shared_ptr &target, [[maybe_unused]] bool lastHit) { return false; }; virtual bool onKilledMonster([[maybe_unused]] const std::shared_ptr &target) { return false; }; - virtual void onGainExperience(uint64_t gainExp, std::shared_ptr target); - virtual void onAttackedCreatureBlockHit(BlockType_t) { } + virtual void onGainExperience(uint64_t gainExp, const std::shared_ptr &target); + virtual void onAttackedCreatureBlockHit(const BlockType_t &) { } virtual void onBlockHit() { } - virtual void onTakeDamage(std::shared_ptr, int32_t) { } + virtual void onTakeDamage(const std::shared_ptr &, int32_t) { } virtual void onChangeZone(ZoneType_t zone); virtual void onAttackedCreatureChangeZone(ZoneType_t zone); virtual void onIdleStatus(); @@ -484,14 +484,14 @@ class Creature : virtual public Thing, public SharedObject { virtual void onCreatureWalk(); virtual bool getNextStep(Direction &dir, uint32_t &flags); - virtual void turnToCreature(std::shared_ptr creature); + virtual void turnToCreature(const std::shared_ptr &creature); - void onAddTileItem(std::shared_ptr tile, const Position &pos); - virtual void onUpdateTileItem(std::shared_ptr tile, const Position &pos, std::shared_ptr oldItem, const ItemType &oldType, std::shared_ptr newItem, const ItemType &newType); - virtual void onRemoveTileItem(std::shared_ptr tile, const Position &pos, const ItemType &iType, std::shared_ptr item); + void onAddTileItem(const std::shared_ptr &tile, const Position &pos); + virtual void onUpdateTileItem(const std::shared_ptr &tile, const Position &pos, const std::shared_ptr &oldItem, const ItemType &oldType, const std::shared_ptr &newItem, const ItemType &newType); + virtual void onRemoveTileItem(const std::shared_ptr &tile, const Position &pos, const ItemType &iType, const std::shared_ptr &item); - virtual void onCreatureAppear(std::shared_ptr creature, bool isLogin); - virtual void onRemoveCreature(std::shared_ptr creature, bool isLogout); + virtual void onCreatureAppear(const std::shared_ptr &creature, bool isLogin); + virtual void onRemoveCreature(const std::shared_ptr &creature, bool isLogout); /** * @brief Check if the summon can move/spawn and if the familiar can teleport to the master @@ -507,7 +507,7 @@ class Creature : virtual public Thing, public SharedObject { virtual void onAttackedCreatureDisappear(bool) { } virtual void onFollowCreatureDisappear(bool) { } - virtual void onCreatureSay(std::shared_ptr, SpeakClasses, const std::string &) { } + virtual void onCreatureSay(const std::shared_ptr &, SpeakClasses, const std::string &) { } virtual void onPlacedCreature() { } @@ -591,7 +591,7 @@ class Creature : virtual public Thing, public SharedObject { static bool canSee(const Position &myPos, const Position &pos, int32_t viewRangeX, int32_t viewRangeY); - double getDamageRatio(std::shared_ptr attacker) const; + double getDamageRatio(const std::shared_ptr &attacker) const; bool getPathTo(const Position &targetPos, std::vector &dirList, const FindPathParams &fpp); bool getPathTo(const Position &targetPos, std::vector &dirList, int32_t minTargetDist, int32_t maxTargetDist, bool fullPathSearch = true, bool clearSight = true, int32_t maxSearchDist = 7); @@ -821,12 +821,12 @@ class Creature : virtual public Thing, public SharedObject { bool hasEventRegistered(CreatureEventType_t event) const { return (0 != (scriptEventsBitField & (static_cast(1) << event))); } - CreatureEventList getCreatureEvents(CreatureEventType_t type); + CreatureEventList getCreatureEvents(CreatureEventType_t type) const; void updateMapCache(); - void updateTileCache(std::shared_ptr tile, int32_t dx, int32_t dy); - void updateTileCache(std::shared_ptr tile, const Position &pos); - void onCreatureDisappear(std::shared_ptr creature, bool isLogout); + void updateTileCache(const std::shared_ptr &tile, int32_t dx, int32_t dy); + void updateTileCache(const std::shared_ptr &tile, const Position &pos); + void onCreatureDisappear(const std::shared_ptr &creature, bool isLogout); virtual void doAttacking(uint32_t) { } virtual bool hasExtraSwing() { return false; @@ -835,14 +835,14 @@ class Creature : virtual public Thing, public SharedObject { virtual uint64_t getLostExperience() const { return 0; } - virtual void dropLoot(std::shared_ptr, std::shared_ptr) { } + virtual void dropLoot(const std::shared_ptr &, const std::shared_ptr &) { } virtual uint16_t getLookCorpse() const { return 0; } virtual void getPathSearchParams(const std::shared_ptr &, FindPathParams &fpp); - virtual void death(std::shared_ptr) { } - virtual bool dropCorpse(std::shared_ptr lastHitCreature, std::shared_ptr mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified); - virtual std::shared_ptr getCorpse(std::shared_ptr lastHitCreature, std::shared_ptr mostDamageCreature); + virtual void death(const std::shared_ptr &) { } + virtual bool dropCorpse(const std::shared_ptr &lastHitCreature, const std::shared_ptr &mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified); + virtual std::shared_ptr getCorpse(const std::shared_ptr &lastHitCreature, const std::shared_ptr &mostDamageCreature); friend class Game; friend class Map; @@ -869,7 +869,7 @@ class Creature : virtual public Thing, public SharedObject { virtual void onExecuteAsyncTasks() {}; private: - bool canFollowMaster(); + bool canFollowMaster() const; bool isLostSummon(); void sendAsyncTasks(); void handleLostSummon(bool teleportSummons); diff --git a/src/creatures/creatures_definitions.hpp b/src/creatures/creatures_definitions.hpp index 9594a704eed..7ca12916946 100644 --- a/src/creatures/creatures_definitions.hpp +++ b/src/creatures/creatures_definitions.hpp @@ -11,6 +11,7 @@ #ifndef USE_PRECOMPILED_HEADERS #include + #include #include #include #include @@ -1368,7 +1369,7 @@ struct CreatureIcon { explicit constexpr CreatureIcon(CreatureIconQuests_t quest, uint16_t count = 0) : category(CreatureIconCategory_t::Quests), quest(quest), count(count) { } - CreatureIconCategory_t category; + CreatureIconCategory_t category {}; CreatureIconModifications_t modification = CreatureIconModifications_t::None; CreatureIconQuests_t quest = CreatureIconQuests_t::None; uint16_t count = 0; @@ -1397,7 +1398,7 @@ struct CreatureIcon { struct Position; struct VIPEntry { - VIPEntry(uint32_t initGuid, const std::string &initName, const std::string &initDescription, uint32_t initIcon, bool initNotify) : + VIPEntry(uint32_t initGuid, std::string initName, std::string initDescription, uint32_t initIcon, bool initNotify) : guid(initGuid), name(std::move(initName)), description(std::move(initDescription)), @@ -1405,20 +1406,20 @@ struct VIPEntry { notify(initNotify) { } uint32_t guid = 0; - std::string name = ""; - std::string description = ""; + std::string name; + std::string description; uint32_t icon = 0; bool notify = false; }; struct VIPGroupEntry { - VIPGroupEntry(uint8_t initId, const std::string &initName, bool initCustomizable) : + VIPGroupEntry(uint8_t initId, std::string initName, bool initCustomizable) : id(initId), name(std::move(initName)), customizable(initCustomizable) { } uint8_t id = 0; - std::string name = ""; + std::string name; bool customizable = false; }; @@ -1485,7 +1486,7 @@ struct MarketOffer { struct MarketOfferEx { MarketOfferEx() = default; - MarketOfferEx(MarketOfferEx &&other) : + MarketOfferEx(MarketOfferEx &&other) noexcept : id(other.id), playerId(other.playerId), timestamp(other.timestamp), @@ -1497,15 +1498,15 @@ struct MarketOfferEx { tier(other.tier), playerName(std::move(other.playerName)) { } - uint32_t id; - uint32_t playerId; - uint32_t timestamp; - uint64_t price; - uint16_t amount; - uint16_t counter; - uint16_t itemId; - MarketAction_t type; - uint8_t tier; + uint32_t id {}; + uint32_t playerId {}; + uint32_t timestamp {}; + uint64_t price {}; + uint16_t amount {}; + uint16_t counter {}; + uint16_t itemId {}; + MarketAction_t type {}; + uint8_t tier {}; std::string playerName; }; @@ -1625,17 +1626,16 @@ struct LootBlock { }; struct ShopBlock { - uint16_t itemId; + uint16_t itemId {}; std::string itemName; - int32_t itemSubType; - uint32_t itemBuyPrice; - uint32_t itemSellPrice; - int32_t itemStorageKey; - int32_t itemStorageValue; + int32_t itemSubType {}; + uint32_t itemBuyPrice {}; + uint32_t itemSellPrice {}; + int32_t itemStorageKey {}; + int32_t itemStorageValue {}; std::vector childShop; - ShopBlock() : - itemId(0), itemName(""), itemSubType(0), itemBuyPrice(0), itemSellPrice(0), itemStorageKey(0), itemStorageValue(0) { } + ShopBlock() = default; explicit ShopBlock(uint16_t newItemId, std::string newName = "", int32_t newSubType = 0, uint32_t newBuyPrice = 0, uint32_t newSellPrice = 0, int32_t newStorageKey = 0, int32_t newStorageValue = 0) : itemId(newItemId), itemName(std::move(newName)), itemSubType(newSubType), itemBuyPrice(newBuyPrice), itemSellPrice(newSellPrice), itemStorageKey(newStorageKey), itemStorageValue(newStorageValue) { } diff --git a/src/creatures/interactions/chat.cpp b/src/creatures/interactions/chat.cpp index 9b73e6caad8..f81eaa96553 100644 --- a/src/creatures/interactions/chat.cpp +++ b/src/creatures/interactions/chat.cpp @@ -16,7 +16,7 @@ bool PrivateChatChannel::isInvited(uint32_t guid) const { if (guid == getOwner()) { return true; } - return invites.find(guid) != invites.end(); + return invites.contains(guid); } bool PrivateChatChannel::removeInvite(uint32_t guid) { @@ -24,8 +24,8 @@ bool PrivateChatChannel::removeInvite(uint32_t guid) { } void PrivateChatChannel::invitePlayer(const std::shared_ptr &player, const std::shared_ptr &invitePlayer) { - auto result = invites.emplace(invitePlayer->getGUID(), invitePlayer); - if (!result.second) { + auto [iter, inserted] = invites.try_emplace(invitePlayer->getGUID(), invitePlayer); + if (!inserted) { return; } @@ -37,8 +37,12 @@ void PrivateChatChannel::invitePlayer(const std::shared_ptr &player, con ss << invitePlayer->getName() << " has been invited."; player->sendTextMessage(MESSAGE_PARTY_MANAGEMENT, ss.str()); - for (const auto &it : users) { - it.second->sendChannelEvent(id, invitePlayer->getName(), CHANNELEVENT_INVITE); + for (const auto &[playerUserId, playerUser] : users) { + if (playerUserId == 0 || !playerUser) { + continue; + } + + playerUser->sendChannelEvent(id, invitePlayer->getName(), CHANNELEVENT_INVITE); } } @@ -55,19 +59,27 @@ void PrivateChatChannel::excludePlayer(const std::shared_ptr &player, co excludePlayer->sendClosePrivate(id); - for (const auto &it : users) { - it.second->sendChannelEvent(id, excludePlayer->getName(), CHANNELEVENT_EXCLUDE); + for (const auto &[playerUserId, playerUser] : users) { + if (playerUserId == 0) { + continue; + } + + playerUser->sendChannelEvent(id, excludePlayer->getName(), CHANNELEVENT_EXCLUDE); } } void PrivateChatChannel::closeChannel() const { - for (const auto &it : users) { - it.second->sendClosePrivate(id); + for (const auto &[playerUserId, playerUser] : users) { + if (playerUserId == 0) { + continue; + } + + playerUser->sendClosePrivate(id); } } bool ChatChannel::addUser(const std::shared_ptr &player) { - if (users.find(player->getID()) != users.end()) { + if (users.contains(player->getID())) { return false; } @@ -77,7 +89,7 @@ bool ChatChannel::addUser(const std::shared_ptr &player) { // TODO: Move to script when guild channels can be scripted if (id == CHANNEL_GUILD) { - const auto guild = player->getGuild(); + const auto &guild = player->getGuild(); if (guild && !guild->getMotd().empty()) { g_dispatcher().scheduleEvent( 150, [playerId = player->getID()] { g_game().sendGuildMotd(playerId); }, "Game::sendGuildMotd" @@ -86,8 +98,12 @@ bool ChatChannel::addUser(const std::shared_ptr &player) { } if (!publicChannel) { - for (const auto &it : users) { - it.second->sendChannelEvent(id, player->getName(), CHANNELEVENT_JOIN); + for (const auto &[playerUserId, playerUser] : users) { + if (playerUserId == 0) { + continue; + } + + playerUser->sendChannelEvent(id, player->getName(), CHANNELEVENT_JOIN); } } @@ -104,8 +120,12 @@ bool ChatChannel::removeUser(const std::shared_ptr &player) { users.erase(iter); if (!publicChannel) { - for (const auto &it : users) { - it.second->sendChannelEvent(id, player->getName(), CHANNELEVENT_LEAVE); + for (const auto &[playerUserId, playerUser] : users) { + if (playerUserId == 0) { + continue; + } + + playerUser->sendChannelEvent(id, player->getName(), CHANNELEVENT_LEAVE); } } @@ -113,42 +133,50 @@ bool ChatChannel::removeUser(const std::shared_ptr &player) { return true; } -bool ChatChannel::hasUser(const std::shared_ptr &player) { - return users.find(player->getID()) != users.end(); +bool ChatChannel::hasUser(const std::shared_ptr &player) const { + return users.contains(player->getID()); } void ChatChannel::sendToAll(const std::string &message, SpeakClasses type) const { - for (const auto &it : users) { - it.second->sendChannelMessage("", message, type, id); + for (const auto &[playerUserId, playerUser] : users) { + if (playerUserId == 0) { + continue; + } + + playerUser->sendChannelMessage("", message, type, id); } } -bool ChatChannel::talk(const std::shared_ptr &fromPlayer, SpeakClasses type, const std::string &text) { - if (users.find(fromPlayer->getID()) == users.end()) { +bool ChatChannel::talk(const std::shared_ptr &fromPlayer, SpeakClasses type, const std::string &text) const { + if (!users.contains(fromPlayer->getID())) { return false; } - for (const auto &it : users) { - it.second->sendToChannel(fromPlayer, type, text, id); + for (const auto &[playerUserId, playerUser] : users) { + if (playerUserId == 0) { + continue; + } + + playerUser->sendToChannel(fromPlayer, type, text, id); } return true; } -bool ChatChannel::executeCanJoinEvent(const std::shared_ptr &player) { +bool ChatChannel::executeCanJoinEvent(const std::shared_ptr &player) const { if (canJoinEvent == -1) { return true; } // canJoin(player) LuaScriptInterface* scriptInterface = g_chat().getScriptInterface(); - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CanJoinChannelEvent::execute - Player {}, on channel {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), getName()); return false; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(canJoinEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -160,21 +188,21 @@ bool ChatChannel::executeCanJoinEvent(const std::shared_ptr &player) { return scriptInterface->callFunction(1); } -bool ChatChannel::executeOnJoinEvent(const std::shared_ptr &player) { +bool ChatChannel::executeOnJoinEvent(const std::shared_ptr &player) const { if (onJoinEvent == -1) { return true; } // onJoin(player) LuaScriptInterface* scriptInterface = g_chat().getScriptInterface(); - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[OnJoinChannelEvent::execute - Player {}, on channel {}] " "Call stack overflow. Too many lua script calls being nested", player->getName(), getName()); return false; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(onJoinEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -186,21 +214,21 @@ bool ChatChannel::executeOnJoinEvent(const std::shared_ptr &player) { return scriptInterface->callFunction(1); } -bool ChatChannel::executeOnLeaveEvent(const std::shared_ptr &player) { +bool ChatChannel::executeOnLeaveEvent(const std::shared_ptr &player) const { if (onLeaveEvent == -1) { return true; } // onLeave(player) LuaScriptInterface* scriptInterface = g_chat().getScriptInterface(); - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[OnLeaveChannelEvent::execute - Player {}, on channel {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), getName()); return false; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(onLeaveEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -212,21 +240,21 @@ bool ChatChannel::executeOnLeaveEvent(const std::shared_ptr &player) { return scriptInterface->callFunction(1); } -bool ChatChannel::executeOnSpeakEvent(const std::shared_ptr &player, SpeakClasses &type, const std::string &message) { +bool ChatChannel::executeOnSpeakEvent(const std::shared_ptr &player, SpeakClasses &type, const std::string &message) const { if (onSpeakEvent == -1) { return true; } // onSpeak(player, type, message) LuaScriptInterface* scriptInterface = g_chat().getScriptInterface(); - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[OnSpeakChannelEvent::execute - Player {}, type {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), fmt::underlying(type)); return false; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(onSpeakEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -240,7 +268,7 @@ bool ChatChannel::executeOnSpeakEvent(const std::shared_ptr &player, Spe bool result = false; int size0 = lua_gettop(L); - int ret = scriptInterface->protectedCall(L, 3, 1); + int ret = LuaScriptInterface::protectedCall(L, 3, 1); if (ret != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else if (lua_gettop(L) > 0) { @@ -256,7 +284,7 @@ bool ChatChannel::executeOnSpeakEvent(const std::shared_ptr &player, Spe if ((lua_gettop(L) + 4) != size0) { LuaScriptInterface::reportError(nullptr, "Stack size changed!"); } - scriptInterface->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return result; } @@ -276,8 +304,8 @@ bool Chat::load() { return false; } - for (auto channelNode : doc.child("channels").children()) { - uint16_t channelId = pugi::cast(channelNode.attribute("id").value()); + for (const auto &channelNode : doc.child("channels").children()) { + auto channelId = pugi::cast(channelNode.attribute("id").value()); std::string channelName = channelNode.attribute("name").as_string(); bool isPublic = channelNode.attribute("public").as_bool(); pugi::xml_attribute scriptAttribute = channelNode.attribute("script"); @@ -300,8 +328,12 @@ bool Chat::load() { } UsersMap tempUserMap = std::move(channel->users); - for (const auto &pair : tempUserMap) { - channel->addUser(pair.second); + for (const auto &[playerUserId, playerUser] : tempUserMap) { + if (playerUserId == 0) { + continue; + } + + channel->addUser(playerUser); } continue; } @@ -332,19 +364,23 @@ std::shared_ptr Chat::createChannel(const std::shared_ptr & switch (channelId) { case CHANNEL_GUILD: { - const auto guild = player->getGuild(); + const auto &guild = player->getGuild(); if (guild != nullptr) { - auto ret = guildChannels.emplace(std::make_pair(guild->getId(), std::make_shared(channelId, guild->getName()))); - return ret.first->second; + auto [iter, inserted] = guildChannels.try_emplace(guild->getId(), std::make_shared(channelId, guild->getName())); + if (inserted) { + return iter->second; + } } break; } case CHANNEL_PARTY: { - auto party = player->getParty(); + const auto &party = player->getParty(); if (party != nullptr) { - auto ret = partyChannels.emplace(std::make_pair(party, std::make_shared(channelId, "Party"))); - return ret.first->second; + auto [iter, inserted] = partyChannels.try_emplace(party, std::make_shared(channelId, "Party")); + if (inserted) { + return iter->second; + } } break; } @@ -357,9 +393,9 @@ std::shared_ptr Chat::createChannel(const std::shared_ptr & // find a free private channel slot for (uint16_t i = 100; i < 10000; ++i) { - auto ret = privateChannels.emplace(std::make_pair(i, std::make_shared(i, player->getName() + "'s Channel"))); - if (ret.second) { // second is a bool that indicates that a new channel has been placed in the map - const auto &newChannel = (*ret.first).second; + auto [iter, inserted] = privateChannels.try_emplace(i, std::make_shared(i, player->getName() + "'s Channel")); + if (inserted) { + const auto &newChannel = iter->second; newChannel->setOwner(player->getGUID()); return newChannel; } @@ -376,7 +412,7 @@ std::shared_ptr Chat::createChannel(const std::shared_ptr & bool Chat::deleteChannel(const std::shared_ptr &player, uint16_t channelId) { switch (channelId) { case CHANNEL_GUILD: { - const auto guild = player->getGuild(); + const auto &guild = player->getGuild(); if (guild == nullptr) { return false; } @@ -391,7 +427,7 @@ bool Chat::deleteChannel(const std::shared_ptr &player, uint16_t channel } case CHANNEL_PARTY: { - auto party = player->getParty(); + const auto &party = player->getParty(); if (party == nullptr) { return false; } @@ -441,16 +477,28 @@ bool Chat::removeUserFromChannel(const std::shared_ptr &player, uint16_t } void Chat::removeUserFromAllChannels(const std::shared_ptr &player) { - for (auto &it : normalChannels) { - it.second->removeUser(player); + for (const auto &[playerUserId, playerUser] : normalChannels) { + if (playerUserId == 0) { + continue; + } + + playerUser->removeUser(player); } - for (auto &it : partyChannels) { - it.second->removeUser(player); + for (const auto &[playerUserId, playerUser] : partyChannels) { + if (playerUserId == 0) { + continue; + } + + playerUser->removeUser(player); } - for (auto &it : guildChannels) { - it.second->removeUser(player); + for (const auto &[playerUserId, playerUser] : guildChannels) { + if (playerUserId == 0) { + continue; + } + + playerUser->removeUser(player); } auto it = privateChannels.begin(); @@ -474,7 +522,7 @@ bool Chat::talkToChannel(const std::shared_ptr &player, SpeakClasses typ } if (channelId == CHANNEL_GUILD) { - GuildRank_ptr rank = player->getGuildRank(); + const auto &rank = player->getGuildRank(); if (rank && rank->level > 1) { type = TALKTYPE_CHANNEL_O; } else if (type != TALKTYPE_CHANNEL_Y) { @@ -496,11 +544,11 @@ ChannelList Chat::getChannelList(const std::shared_ptr &player) { if (player->getGuild()) { auto channel = getChannel(player, CHANNEL_GUILD); if (channel) { - list.push_back(channel); + list.emplace_back(channel); } else { channel = createChannel(player, CHANNEL_GUILD); if (channel) { - list.push_back(channel); + list.emplace_back(channel); } } } @@ -508,28 +556,36 @@ ChannelList Chat::getChannelList(const std::shared_ptr &player) { if (player->getParty()) { auto channel = getChannel(player, CHANNEL_PARTY); if (channel) { - list.push_back(channel); + list.emplace_back(channel); } else { channel = createChannel(player, CHANNEL_PARTY); if (channel) { - list.push_back(channel); + list.emplace_back(channel); } } } - for (const auto &it : normalChannels) { - const auto &channel = getChannel(player, it.first); + for (const auto &[playerUserId, playerUser] : normalChannels) { + if (playerUserId == 0) { + continue; + } + + const auto &channel = getChannel(player, playerUserId); if (channel) { - list.push_back(channel); + list.emplace_back(channel); } } bool hasPrivate = false; - for (auto &it : privateChannels) { - if (const auto &channel = it.second) { - uint32_t guid = player->getGUID(); + for (const auto &[playerUserId, playerUser] : privateChannels) { + if (playerUserId == 0) { + continue; + } + + if (const auto &channel = playerUser) { + const uint32_t guid = player->getGUID(); if (channel->isInvited(guid)) { - list.push_back(channel); + list.emplace_back(channel); } if (channel->getOwner() == guid) { @@ -539,7 +595,7 @@ ChannelList Chat::getChannelList(const std::shared_ptr &player) { } if (!hasPrivate && player->isPremium()) { - list.push_front(dummyPrivate); + list.emplace_back(dummyPrivate); } return list; } @@ -547,7 +603,7 @@ ChannelList Chat::getChannelList(const std::shared_ptr &player) { std::shared_ptr Chat::getChannel(const std::shared_ptr &player, uint16_t channelId) { switch (channelId) { case CHANNEL_GUILD: { - const auto guild = player->getGuild(); + const auto &guild = player->getGuild(); if (guild != nullptr) { auto it = guildChannels.find(guild->getId()); if (it != guildChannels.end()) { @@ -558,7 +614,7 @@ std::shared_ptr Chat::getChannel(const std::shared_ptr &pla } case CHANNEL_PARTY: { - auto party = player->getParty(); + const auto &party = player->getParty(); if (party != nullptr) { auto it = partyChannels.find(party); if (it != partyChannels.end()) { @@ -578,9 +634,9 @@ std::shared_ptr Chat::getChannel(const std::shared_ptr &pla return channel; } - auto it2 = privateChannels.find(channelId); - if (it2 != privateChannels.end() && it2->second->isInvited(player->getGUID())) { - return it2->second; + auto privateIt = privateChannels.find(channelId); + if (privateIt != privateChannels.end() && privateIt->second->isInvited(player->getGUID())) { + return privateIt->second; } break; } diff --git a/src/creatures/interactions/chat.hpp b/src/creatures/interactions/chat.hpp index fcc74563c34..7e2b471f4be 100644 --- a/src/creatures/interactions/chat.hpp +++ b/src/creatures/interactions/chat.hpp @@ -30,9 +30,9 @@ class ChatChannel { bool addUser(const std::shared_ptr &player); bool removeUser(const std::shared_ptr &player); - bool hasUser(const std::shared_ptr &player); + bool hasUser(const std::shared_ptr &player) const; - bool talk(const std::shared_ptr &fromPlayer, SpeakClasses type, const std::string &text); + bool talk(const std::shared_ptr &fromPlayer, SpeakClasses type, const std::string &text) const; void sendToAll(const std::string &message, SpeakClasses type) const; const std::string &getName() const { @@ -56,10 +56,10 @@ class ChatChannel { return publicChannel; } - bool executeOnJoinEvent(const std::shared_ptr &player); - bool executeCanJoinEvent(const std::shared_ptr &player); - bool executeOnLeaveEvent(const std::shared_ptr &player); - bool executeOnSpeakEvent(const std::shared_ptr &player, SpeakClasses &type, const std::string &message); + bool executeOnJoinEvent(const std::shared_ptr &player) const; + bool executeCanJoinEvent(const std::shared_ptr &player) const; + bool executeOnLeaveEvent(const std::shared_ptr &player) const; + bool executeOnSpeakEvent(const std::shared_ptr &player, SpeakClasses &type, const std::string &message) const; protected: UsersMap users; diff --git a/src/creatures/monsters/monster.cpp b/src/creatures/monsters/monster.cpp index 4d225dee696..92c10a9f534 100644 --- a/src/creatures/monsters/monster.cpp +++ b/src/creatures/monsters/monster.cpp @@ -22,15 +22,14 @@ int32_t Monster::despawnRadius; uint32_t Monster::monsterAutoID = 0x50000001; std::shared_ptr Monster::createMonster(const std::string &name) { - const auto mType = g_monsters().getMonsterType(name); + const auto &mType = g_monsters().getMonsterType(name); if (!mType) { return nullptr; } return std::make_shared(mType); } -Monster::Monster(const std::shared_ptr mType) : - Creature(), +Monster::Monster(const std::shared_ptr &mType) : nameDescription(asLowerCaseString(mType->nameDescription)), mType(mType) { defaultOutfit = mType->info.outfit; @@ -170,20 +169,20 @@ void Monster::onAttackedCreatureDisappear(bool) { extraMeleeAttack = true; } -void Monster::onCreatureAppear(std::shared_ptr creature, bool isLogin) { +void Monster::onCreatureAppear(const std::shared_ptr &creature, bool isLogin) { Creature::onCreatureAppear(creature, isLogin); if (mType->info.creatureAppearEvent != -1) { // onCreatureAppear(self, creature) LuaScriptInterface* scriptInterface = mType->info.scriptInterface; - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Monster::onCreatureAppear - Monster {} creature {}] " "Call stack overflow. Too many lua script calls being nested.", getName(), creature->getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(mType->info.creatureAppearEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -210,20 +209,20 @@ void Monster::onCreatureAppear(std::shared_ptr creature, bool isLogin) } } -void Monster::onRemoveCreature(std::shared_ptr creature, bool isLogout) { +void Monster::onRemoveCreature(const std::shared_ptr &creature, bool isLogout) { Creature::onRemoveCreature(creature, isLogout); if (mType->info.creatureDisappearEvent != -1) { // onCreatureDisappear(self, creature) LuaScriptInterface* scriptInterface = mType->info.scriptInterface; - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Monster::onCreatureDisappear - Monster {} creature {}] " "Call stack overflow. Too many lua script calls being nested.", getName(), creature->getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(mType->info.creatureDisappearEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -257,14 +256,14 @@ void Monster::onCreatureMove(const std::shared_ptr &creature, const st if (mType->info.creatureMoveEvent != -1) { // onCreatureMove(self, creature, oldPosition, newPosition) LuaScriptInterface* scriptInterface = mType->info.scriptInterface; - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Monster::onCreatureMove - Monster {} creature {}] " "Call stack overflow. Too many lua script calls being nested.", getName(), creature->getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(mType->info.creatureMoveEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -347,20 +346,20 @@ void Monster::onCreatureMove(const std::shared_ptr &creature, const st } } -void Monster::onCreatureSay(std::shared_ptr creature, SpeakClasses type, const std::string &text) { +void Monster::onCreatureSay(const std::shared_ptr &creature, SpeakClasses type, const std::string &text) { Creature::onCreatureSay(creature, type, text); if (mType->info.creatureSayEvent != -1) { // onCreatureSay(self, creature, type, message) LuaScriptInterface* scriptInterface = mType->info.scriptInterface; - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("Monster {} creature {}] Call stack overflow. Too many lua " "script calls being nested.", getName(), creature->getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(mType->info.creatureSayEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -379,7 +378,7 @@ void Monster::onCreatureSay(std::shared_ptr creature, SpeakClasses typ } } -void Monster::onAttackedByPlayer(std::shared_ptr attackerPlayer) { +void Monster::onAttackedByPlayer(const std::shared_ptr &attackerPlayer) { if (mType->info.monsterAttackedByPlayerEvent != -1) { // onPlayerAttack(self, attackerPlayer) LuaScriptInterface* scriptInterface = mType->info.scriptInterface; @@ -455,7 +454,7 @@ bool Monster::addTarget(const std::shared_ptr &creature, bool pushFron assert(creature != getMonster()); - const auto &it = getTargetIterator(creature); + auto it = getTargetIterator(creature); if (it != targetList.end()) { return false; } @@ -478,7 +477,7 @@ bool Monster::removeTarget(const std::shared_ptr &creature) { return false; } - const auto &it = getTargetIterator(creature); + auto it = getTargetIterator(creature); if (it == targetList.end()) { return false; } @@ -523,7 +522,7 @@ void Monster::clearFriendList() { friendList.clear(); } -void Monster::onCreatureFound(std::shared_ptr creature, bool pushFront /* = false*/) { +void Monster::onCreatureFound(const std::shared_ptr &creature, bool pushFront /* = false*/) { if (isFriend(creature)) { addFriend(creature); } @@ -535,8 +534,8 @@ void Monster::onCreatureFound(std::shared_ptr creature, bool pushFront updateIdleStatus(); } -void Monster::onCreatureEnter(std::shared_ptr creature) { - onCreatureFound(std::move(creature), true); +void Monster::onCreatureEnter(const std::shared_ptr &creature) { + onCreatureFound(creature, true); } bool Monster::isFriend(const std::shared_ptr &creature) const { @@ -583,7 +582,7 @@ bool Monster::isOpponent(const std::shared_ptr &creature) const { return false; } -void Monster::onCreatureLeave(std::shared_ptr creature) { +void Monster::onCreatureLeave(const std::shared_ptr &creature) { // update friendList if (isFriend(creature)) { removeFriend(creature); @@ -626,7 +625,7 @@ bool Monster::searchTarget(TargetSearchType_t searchType /*= TARGETSEARCH_DEFAUL const auto &creature = cref.lock(); if (creature && isTarget(creature)) { if ((static_self_cast()->targetDistance == 1) || canUseAttack(myPos, creature)) { - resultList.push_back(creature); + resultList.emplace_back(creature); } } } @@ -756,7 +755,7 @@ float Monster::getMitigation() const { return std::min(mitigation, 30.f); } -BlockType_t Monster::blockHit(std::shared_ptr attacker, CombatType_t combatType, int32_t &damage, bool checkDefense /* = false*/, bool checkArmor /* = false*/, bool /* field = false */) { +BlockType_t Monster::blockHit(const std::shared_ptr &attacker, const CombatType_t &combatType, int32_t &damage, bool checkDefense /* = false*/, bool checkArmor /* = false*/, bool /* field = false */) { BlockType_t blockType = Creature::blockHit(attacker, combatType, damage, checkDefense, checkArmor); if (damage != 0) { @@ -767,7 +766,7 @@ BlockType_t Monster::blockHit(std::shared_ptr attacker, CombatType_t c } // Wheel of destiny - std::shared_ptr player = attacker ? attacker->getPlayer() : nullptr; + const auto &player = attacker ? attacker->getPlayer() : nullptr; if (player && player->wheel()->getInstant("Ballistic Mastery")) { elementMod -= player->wheel()->checkElementSensitiveReduction(combatType); } @@ -784,7 +783,7 @@ BlockType_t Monster::blockHit(std::shared_ptr attacker, CombatType_t c return blockType; } -bool Monster::isTarget(std::shared_ptr creature) { +bool Monster::isTarget(const std::shared_ptr &creature) { if (creature->isRemoved() || !creature->isAttackable() || creature->getZoneType() == ZONE_PROTECTION || !canSeeCreature(creature)) { return false; } @@ -811,7 +810,7 @@ bool Monster::selectTarget(const std::shared_ptr &creature) { return false; } - const auto &it = getTargetIterator(creature); + auto it = getTargetIterator(creature); if (it == targetList.end()) { // Target not found in our target list. return false; @@ -878,7 +877,7 @@ void Monster::onAddCondition(ConditionType_t type) { onConditionStatusChange(type); } -void Monster::onConditionStatusChange(const ConditionType_t &type) { +void Monster::onConditionStatusChange(ConditionType_t type) { if (type == CONDITION_FIRE || type == CONDITION_ENERGY || type == CONDITION_POISON) { updateMapCache(); } @@ -895,14 +894,14 @@ void Monster::onThink(uint32_t interval) { if (mType->info.thinkEvent != -1) { // onThink(self, interval) LuaScriptInterface* scriptInterface = mType->info.scriptInterface; - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("Monster {} Call stack overflow. Too many lua script calls " "being nested.", getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(mType->info.thinkEvent, scriptInterface); lua_State* L = scriptInterface->getLuaState(); @@ -980,7 +979,7 @@ void Monster::onThink(uint32_t interval) { } void Monster::doAttacking(uint32_t interval) { - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (!attackedCreature || (isSummon() && attackedCreature.get() == this)) { return; } @@ -1154,8 +1153,8 @@ void Monster::onThinkDefense(uint32_t interval) { } if (!isSummon() && m_summons.size() < mType->info.maxSummons && hasFollowPath) { - for (const summonBlock_t &summonBlock : mType->info.summons) { - if (summonBlock.speed > defenseTicks) { + for (const auto &[summonName, summonChance, summonSpeed, summonCount, summonForce] : mType->info.summons) { + if (summonSpeed > defenseTicks) { resetTicks = false; continue; } @@ -1164,29 +1163,29 @@ void Monster::onThinkDefense(uint32_t interval) { continue; } - if (defenseTicks % summonBlock.speed >= interval) { + if (defenseTicks % summonSpeed >= interval) { // already used this spell for this round continue; } - uint32_t summonCount = 0; + uint32_t summonsCount = 0; for (const auto &summon : m_summons) { - if (summon && summon->getName() == summonBlock.name) { - ++summonCount; + if (summon && summon->getName() == summonName) { + ++summonsCount; } } - if (summonCount >= summonBlock.count) { + if (summonsCount >= summonCount) { continue; } - if (summonBlock.chance < static_cast(uniform_random(1, 100))) { + if (summonChance < static_cast(uniform_random(1, 100))) { continue; } - std::shared_ptr summon = Monster::createMonster(summonBlock.name); + const auto &summon = Monster::createMonster(summonName); if (summon) { - if (g_game().placeCreature(summon, getPosition(), false, summonBlock.force)) { + if (g_game().placeCreature(summon, getPosition(), false, summonForce)) { summon->setMaster(static_self_cast(), true); g_game().addMagicEffect(getPosition(), CONST_ME_MAGIC_BLUE); g_game().addMagicEffect(summon->getPosition(), CONST_ME_TELEPORT); @@ -1211,13 +1210,13 @@ void Monster::onThinkYell(uint32_t interval) { yellTicks = 0; if (!mType->info.voiceVector.empty() && (mType->info.yellChance >= static_cast(uniform_random(1, 100)))) { - uint32_t index = uniform_random(0, mType->info.voiceVector.size() - 1); - const voiceBlock_t &vb = mType->info.voiceVector[index]; + const uint32_t index = uniform_random(0, mType->info.voiceVector.size() - 1); + const auto &[text, yellText] = mType->info.voiceVector[index]; - if (vb.yellText) { - g_game().internalCreatureSay(static_self_cast(), TALKTYPE_MONSTER_YELL, vb.text, false); + if (yellText) { + g_game().internalCreatureSay(static_self_cast(), TALKTYPE_MONSTER_YELL, text, false); } else { - g_game().internalCreatureSay(static_self_cast(), TALKTYPE_MONSTER_SAY, vb.text, false); + g_game().internalCreatureSay(static_self_cast(), TALKTYPE_MONSTER_SAY, text, false); } } } @@ -1239,7 +1238,7 @@ void Monster::onThinkSound(uint32_t interval) { } } -bool Monster::pushItem(std::shared_ptr item, const Direction &nextDirection) { +bool Monster::pushItem(const std::shared_ptr &item, const Direction &nextDirection) { const Position ¢erPos = item->getPosition(); for (const auto &[x, y] : getPushItemLocationOptions(nextDirection)) { Position tryPos(centerPos.x + x, centerPos.y + y, centerPos.z); @@ -1251,11 +1250,11 @@ bool Monster::pushItem(std::shared_ptr item, const Direction &nextDirectio return false; } -void Monster::pushItems(std::shared_ptr tile, const Direction &nextDirection) { +void Monster::pushItems(const std::shared_ptr &tile, const Direction &nextDirection) { // We can not use iterators here since we can push the item to another tile // which will invalidate the iterator. // start from the end to minimize the amount of traffic - if (const auto items = tile->getItemList()) { + if (const auto &items = tile->getItemList()) { uint32_t moveCount = 0; uint32_t removeCount = 0; int32_t downItemSize = tile->getDownItemCount(); @@ -1275,17 +1274,17 @@ void Monster::pushItems(std::shared_ptr tile, const Direction &nextDirecti } } -bool Monster::pushCreature(std::shared_ptr creature) { +bool Monster::pushCreature(const std::shared_ptr &creature) { static std::vector dirList { DIRECTION_NORTH, DIRECTION_WEST, DIRECTION_EAST, DIRECTION_SOUTH }; - std::shuffle(dirList.begin(), dirList.end(), getRandomGenerator()); + std::ranges::shuffle(dirList, getRandomGenerator()); - for (Direction dir : dirList) { + for (const Direction &dir : dirList) { const Position &tryPos = Spells::getCasterPosition(creature, dir); - const auto toTile = g_game().map.getTile(tryPos); + const auto &toTile = g_game().map.getTile(tryPos); if (toTile && !toTile->hasFlag(TILESTATE_BLOCKPATH) && g_game().internalMoveCreature(creature, dir) == RETURNVALUE_NOERROR) { return true; } @@ -1293,15 +1292,15 @@ bool Monster::pushCreature(std::shared_ptr creature) { return false; } -void Monster::pushCreatures(std::shared_ptr tile) { +void Monster::pushCreatures(const std::shared_ptr &tile) { // We can not use iterators here since we can push a creature to another tile // which will invalidate the iterator. - if (CreatureVector* creatures = tile->getCreatures()) { + if (const CreatureVector* creatures = tile->getCreatures()) { uint32_t removeCount = 0; std::shared_ptr lastPushedMonster = nullptr; for (size_t i = 0; i < creatures->size();) { - std::shared_ptr monster = creatures->at(i)->getMonster(); + const auto &monster = creatures->at(i)->getMonster(); if (monster && monster->isPushable()) { if (monster != lastPushedMonster && Monster::pushCreature(monster)) { lastPushedMonster = monster; @@ -1341,7 +1340,7 @@ bool Monster::getNextStep(Direction &nextDirection, uint32_t &flags) { if (result && (canPushItems() || canPushCreatures())) { const Position &pos = getNextPosition(nextDirection, getPosition()); - auto posTile = g_game().map.getTile(pos); + const auto &posTile = g_game().map.getTile(pos); if (posTile) { if (canPushItems()) { Monster::pushItems(posTile, nextDirection); @@ -1405,8 +1404,8 @@ void Monster::doFollowCreature(uint32_t &flags, Direction &nextDirection, bool & updateMapCache(); } // target dancing - auto attackedCreature = getAttackedCreature(); - auto followCreature = getFollowCreature(); + const auto &attackedCreature = getAttackedCreature(); + const auto &followCreature = getFollowCreature(); if (attackedCreature && attackedCreature == followCreature) { if (isFleeing()) { result = getDanceStep(getPosition(), nextDirection, false, false); @@ -1423,9 +1422,9 @@ bool Monster::getRandomStep(const Position &creaturePos, Direction &moveDirectio DIRECTION_WEST, DIRECTION_EAST, DIRECTION_SOUTH }; - std::shuffle(dirList.begin(), dirList.end(), getRandomGenerator()); + std::ranges::shuffle(dirList, getRandomGenerator()); - for (Direction dir : dirList) { + for (const Direction &dir : dirList) { if (canWalkTo(creaturePos, dir)) { moveDirection = dir; return true; @@ -1435,7 +1434,7 @@ bool Monster::getRandomStep(const Position &creaturePos, Direction &moveDirectio } bool Monster::getDanceStep(const Position &creaturePos, Direction &moveDirection, bool keepAttack /*= true*/, bool keepDistance /*= true*/) { - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (!attackedCreature) { return false; } @@ -2023,7 +2022,7 @@ bool Monster::canWalkTo(Position pos, Direction moveDirection) { return false; } - const auto tile = g_game().map.getTile(pos); + const auto &tile = g_game().map.getTile(pos); if (tile && tile->getTopVisibleCreature(getMonster()) == nullptr && tile->queryAdd(0, getMonster(), 1, FLAG_PATHFINDING | FLAG_IGNOREFIELDDAMAGE) == RETURNVALUE_NOERROR) { return true; } @@ -2031,7 +2030,7 @@ bool Monster::canWalkTo(Position pos, Direction moveDirection) { return false; } -void Monster::death(std::shared_ptr) { +void Monster::death(const std::shared_ptr &) { if (monsterForgeClassification > ForgeClassifications_t::FORGE_NORMAL_MONSTER) { g_game().removeForgeMonster(getID(), monsterForgeClassification, true); } @@ -2057,14 +2056,14 @@ void Monster::death(std::shared_ptr) { setDead(true); } -std::shared_ptr Monster::getCorpse(std::shared_ptr lastHitCreature, std::shared_ptr mostDamageCreature) { - std::shared_ptr corpse = Creature::getCorpse(lastHitCreature, mostDamageCreature); +std::shared_ptr Monster::getCorpse(const std::shared_ptr &lastHitCreature, const std::shared_ptr &mostDamageCreature) { + const auto &corpse = Creature::getCorpse(lastHitCreature, mostDamageCreature); if (corpse) { if (mostDamageCreature) { if (mostDamageCreature->getPlayer()) { corpse->setAttribute(ItemAttribute_t::CORPSEOWNER, mostDamageCreature->getID()); } else { - std::shared_ptr mostDamageCreatureMaster = mostDamageCreature->getMaster(); + const auto &mostDamageCreatureMaster = mostDamageCreature->getMaster(); if (mostDamageCreatureMaster && mostDamageCreatureMaster->getPlayer()) { corpse->setAttribute(ItemAttribute_t::CORPSEOWNER, mostDamageCreatureMaster->getID()); } @@ -2110,7 +2109,7 @@ bool Monster::getCombatValues(int32_t &min, int32_t &max) { void Monster::updateLookDirection() { Direction newDir = getDirection(); - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (!attackedCreature) { return; } @@ -2167,7 +2166,7 @@ void Monster::updateLookDirection() { g_game().internalCreatureTurn(getMonster(), newDir); } -void Monster::dropLoot(std::shared_ptr corpse, std::shared_ptr) { +void Monster::dropLoot(const std::shared_ptr &corpse, const std::shared_ptr &) { if (corpse && lootDrop) { // Only fiendish drops sliver if (ForgeClassifications_t classification = getMonsterForgeClassification(); @@ -2178,7 +2177,7 @@ void Monster::dropLoot(std::shared_ptr corpse, std::shared_ptr(uniform_random(minSlivers, maxSlivers)); - std::shared_ptr sliver = Item::CreateItem(ITEM_FORGE_SLIVER, sliverCount); + const auto &sliver = Item::CreateItem(ITEM_FORGE_SLIVER, sliverCount); if (g_game().internalAddItem(corpse, sliver) != RETURNVALUE_NOERROR) { corpse->internalAddThing(sliver); } @@ -2194,7 +2193,7 @@ void Monster::setNormalCreatureLight() { internalLight = mType->info.light; } -void Monster::drainHealth(std::shared_ptr attacker, int32_t damage) { +void Monster::drainHealth(const std::shared_ptr &attacker, int32_t damage) { Creature::drainHealth(attacker, damage); if (damage > 0 && randomStepping) { @@ -2218,7 +2217,7 @@ void Monster::changeHealth(int32_t healthChange, bool sendHealthChange /* = true Creature::changeHealth(healthChange, sendHealthChange); } -bool Monster::challengeCreature(std::shared_ptr creature, int targetChangeCooldown) { +bool Monster::challengeCreature(const std::shared_ptr &creature, int targetChangeCooldown) { if (isSummon()) { return false; } @@ -2228,7 +2227,7 @@ bool Monster::challengeCreature(std::shared_ptr creature, int targetCh challengeFocusDuration = targetChangeCooldown; targetChangeTicks = 0; // Wheel of destiny - std::shared_ptr player = creature ? creature->getPlayer() : nullptr; + const auto &player = creature ? creature->getPlayer() : nullptr; if (player && !player->isRemoved()) { player->wheel()->healIfBattleHealingActive(); } diff --git a/src/creatures/monsters/monster.hpp b/src/creatures/monsters/monster.hpp index 36562af1e0f..3b7026e4134 100644 --- a/src/creatures/monsters/monster.hpp +++ b/src/creatures/monsters/monster.hpp @@ -22,7 +22,7 @@ class Monster final : public Creature { static int32_t despawnRange; static int32_t despawnRadius; - explicit Monster(std::shared_ptr mType); + explicit Monster(const std::shared_ptr &mType); // non-copyable Monster(const Monster &) = delete; @@ -90,7 +90,7 @@ class Monster final : public Creature { } bool isEnemyFaction(Faction_t faction) const { - auto master = getMaster(); + const auto &master = getMaster(); if (master && master->getMonster()) { return master->getMonster()->isEnemyFaction(faction); } @@ -130,7 +130,7 @@ class Monster final : public Creature { RespawnType getRespawnType() const { return mType->info.respawnType; } - void setSpawnMonster(SpawnMonster* newSpawnMonster) { + void setSpawnMonster(const std::shared_ptr &newSpawnMonster) { this->spawnMonster = newSpawnMonster; } @@ -142,21 +142,21 @@ class Monster final : public Creature { bool canWalkOnFieldType(CombatType_t combatType) const; void onAttackedCreatureDisappear(bool isLogout) override; - void onCreatureAppear(std::shared_ptr creature, bool isLogin) override; - void onRemoveCreature(std::shared_ptr creature, bool isLogout) override; + void onCreatureAppear(const std::shared_ptr &creature, bool isLogin) override; + void onRemoveCreature(const std::shared_ptr &creature, bool isLogout) override; void onCreatureMove(const std::shared_ptr &creature, const std::shared_ptr &newTile, const Position &newPos, const std::shared_ptr &oldTile, const Position &oldPos, bool teleport) override; - void onCreatureSay(std::shared_ptr creature, SpeakClasses type, const std::string &text) override; - void onAttackedByPlayer(std::shared_ptr attackerPlayer); + void onCreatureSay(const std::shared_ptr &creature, SpeakClasses type, const std::string &text) override; + void onAttackedByPlayer(const std::shared_ptr &attackerPlayer); void onSpawn(); - void drainHealth(std::shared_ptr attacker, int32_t damage) override; + void drainHealth(const std::shared_ptr &attacker, int32_t damage) override; void changeHealth(int32_t healthChange, bool sendHealthChange = true) override; bool getNextStep(Direction &direction, uint32_t &flags) override; void onFollowCreatureComplete(const std::shared_ptr &creature) override; void onThink(uint32_t interval) override; - bool challengeCreature(std::shared_ptr creature, int targetChangeCooldown) override; + bool challengeCreature(const std::shared_ptr &creature, int targetChangeCooldown) override; bool changeTargetDistance(int32_t distance, uint32_t duration = 12000); bool isChallenged() const { @@ -221,7 +221,7 @@ class Monster final : public Creature { return list; } - bool isTarget(std::shared_ptr creature); + bool isTarget(const std::shared_ptr &creature); bool isFleeing() const { return !isSummon() && getHealth() <= runAwayHealth && challengeFocusDuration <= 0 && challengeMeleeDuration <= 0; } @@ -286,7 +286,7 @@ class Monster final : public Creature { void clearTargetList(); void clearFriendList(); - BlockType_t blockHit(std::shared_ptr attacker, CombatType_t combatType, int32_t &damage, bool checkDefense = false, bool checkArmor = false, bool field = false) override; + BlockType_t blockHit(const std::shared_ptr &attacker, const CombatType_t &combatType, int32_t &damage, bool checkDefense = false, bool checkArmor = false, bool field = false) override; static uint32_t monsterAutoID; @@ -392,7 +392,7 @@ class Monster final : public Creature { std::string nameDescription; std::shared_ptr mType; - SpawnMonster* spawnMonster = nullptr; + std::shared_ptr spawnMonster = nullptr; int64_t lastMeleeAttack = 0; @@ -433,9 +433,9 @@ class Monster final : public Creature { bool m_isDead = false; bool m_isImmune = false; - void onCreatureEnter(std::shared_ptr creature); - void onCreatureLeave(std::shared_ptr creature); - void onCreatureFound(std::shared_ptr creature, bool pushFront = false); + void onCreatureEnter(const std::shared_ptr &creature); + void onCreatureLeave(const std::shared_ptr &creature); + void onCreatureFound(const std::shared_ptr &creature, bool pushFront = false); void updateLookDirection(); @@ -444,8 +444,8 @@ class Monster final : public Creature { bool addTarget(const std::shared_ptr &creature, bool pushFront = false); bool removeTarget(const std::shared_ptr &creature); - void death(std::shared_ptr lastHitCreature) override; - std::shared_ptr getCorpse(std::shared_ptr lastHitCreature, std::shared_ptr mostDamageCreature) override; + void death(const std::shared_ptr &lastHitCreature) override; + std::shared_ptr getCorpse(const std::shared_ptr &lastHitCreature, const std::shared_ptr &mostDamageCreature) override; void setIdle(bool idle); void updateIdleStatus(); @@ -464,10 +464,10 @@ class Monster final : public Creature { bool isInSpawnRange(const Position &pos) const; bool canWalkTo(Position pos, Direction direction); - static bool pushItem(std::shared_ptr item, const Direction &nextDirection); - static void pushItems(std::shared_ptr tile, const Direction &nextDirection); - static bool pushCreature(std::shared_ptr creature); - static void pushCreatures(std::shared_ptr tile); + static bool pushItem(const std::shared_ptr &item, const Direction &nextDirection); + static void pushItems(const std::shared_ptr &tile, const Direction &nextDirection); + static bool pushCreature(const std::shared_ptr &creature); + static void pushCreatures(const std::shared_ptr &tile); void onThinkTarget(uint32_t interval); void onThinkYell(uint32_t interval); @@ -483,7 +483,7 @@ class Monster final : public Creature { uint16_t getLookCorpse() const override { return mType->info.lookcorpse; } - void dropLoot(std::shared_ptr corpse, std::shared_ptr lastHitCreature) override; + void dropLoot(const std::shared_ptr &corpse, const std::shared_ptr &lastHitCreature) override; void getPathSearchParams(const std::shared_ptr &creature, FindPathParams &fpp) override; bool useCacheMap() const override { // return !randomStepping; @@ -502,5 +502,5 @@ class Monster final : public Creature { void doFollowCreature(uint32_t &flags, Direction &nextDirection, bool &result); void doRandomStep(Direction &nextDirection, bool &result); - void onConditionStatusChange(const ConditionType_t &type); + void onConditionStatusChange(ConditionType_t type); }; diff --git a/src/creatures/monsters/monsters.cpp b/src/creatures/monsters/monsters.cpp index 9a1c2b70634..75cec75fe16 100644 --- a/src/creatures/monsters/monsters.cpp +++ b/src/creatures/monsters/monsters.cpp @@ -14,23 +14,23 @@ #include "game/game.hpp" #include "items/weapons/weapons.hpp" -void MonsterType::loadLoot(const std::shared_ptr monsterType, LootBlock lootBlock) { +void MonsterType::loadLoot(const std::shared_ptr &monsterType, LootBlock lootBlock) const { if (lootBlock.childLoot.empty()) { - bool isContainer = Item::items[lootBlock.id].isContainer(); + const bool isContainer = Item::items[lootBlock.id].isContainer(); if (isContainer) { for (const LootBlock &child : lootBlock.childLoot) { - lootBlock.childLoot.push_back(child); + lootBlock.childLoot.emplace_back(child); } } - monsterType->info.lootItems.push_back(lootBlock); + monsterType->info.lootItems.emplace_back(lootBlock); } else { - monsterType->info.lootItems.push_back(lootBlock); + monsterType->info.lootItems.emplace_back(lootBlock); } } -bool MonsterType::canSpawn(const Position &pos) { +bool MonsterType::canSpawn(const Position &pos) const { bool canSpawn = true; - bool isDay = g_game().gameIsDay(); + const bool isDay = g_game().gameIsDay(); if ((isDay && info.respawnType.period == RESPAWNPERIOD_NIGHT) || (!isDay && info.respawnType.period == RESPAWNPERIOD_DAY)) { // It will ignore day and night if underground @@ -40,8 +40,8 @@ bool MonsterType::canSpawn(const Position &pos) { return canSpawn; } -std::shared_ptr Monsters::getDamageCondition(ConditionType_t conditionType, int32_t maxDamage, int32_t minDamage, int32_t startDamage, uint32_t tickInterval) { - std::shared_ptr condition = Condition::createCondition(CONDITIONID_COMBAT, conditionType, 0, 0)->static_self_cast(); +std::shared_ptr Monsters::getDamageCondition(ConditionType_t conditionType, int32_t maxDamage, int32_t minDamage, int32_t startDamage, uint32_t tickInterval) const { + const auto &condition = Condition::createCondition(CONDITIONID_COMBAT, conditionType, 0, 0)->static_self_cast(); condition->setParam(CONDITION_PARAM_TICKINTERVAL, tickInterval); condition->setParam(CONDITION_PARAM_MINVALUE, minDamage); condition->setParam(CONDITION_PARAM_MAXVALUE, maxDamage); @@ -50,7 +50,7 @@ std::shared_ptr Monsters::getDamageCondition(ConditionType_t co return condition; } -bool Monsters::deserializeSpell(const std::shared_ptr spell, spellBlock_t &sb, const std::string &description) { +bool Monsters::deserializeSpell(const std::shared_ptr &spell, spellBlock_t &sb, const std::string &description) const { if (!spell->scriptName.empty()) { spell->isScripted = true; } else if (!spell->name.empty()) { @@ -60,8 +60,8 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell } sb.speed = spell->interval; - sb.chance = std::min((int)spell->chance, 100); - sb.range = std::min((int)spell->range, MAP_MAX_VIEW_PORT_X * 2); + sb.chance = std::min(static_cast(spell->chance), 100); + sb.range = std::min(static_cast(spell->range), MAP_MAX_VIEW_PORT_X * 2); sb.minCombatValue = std::min(spell->minCombatValue, spell->maxCombatValue); sb.maxCombatValue = std::max(spell->minCombatValue, spell->maxCombatValue); sb.soundCastEffect = spell->soundCastEffect; @@ -94,7 +94,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell combatPtr->setArea(area); } - if (std::string spellName = asLowerCaseString(spell->name); + if (const std::string spellName = asLowerCaseString(spell->name); spellName == "melee") { sb.isMelee = true; @@ -141,8 +141,8 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell conditionType = CONDITION_PARALYZE; } - std::shared_ptr condition = Condition::createCondition(CONDITIONID_COMBAT, conditionType, duration, 0)->static_self_cast(); - float multiplier = 1.0f + static_cast(speedChange) / 1000.0f; + const auto &condition = Condition::createCondition(CONDITIONID_COMBAT, conditionType, duration, 0)->static_self_cast(); + const float multiplier = 1.0f + static_cast(speedChange) / 1000.0f; condition->setFormulaVars(multiplier / 2, 40, multiplier, 40); combatPtr->addCondition(condition); } else if (spellName == "outfit") { @@ -152,7 +152,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell duration = spell->duration; } - std::shared_ptr condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_OUTFIT, duration, 0)->static_self_cast(); + const auto &condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_OUTFIT, duration, 0)->static_self_cast(); if (!spell->outfitMonster.empty()) { condition->setLazyMonsterOutfit(spell->outfitMonster); @@ -176,7 +176,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell duration = spell->duration; } - std::shared_ptr condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_INVISIBLE, duration, 0); + const auto &condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_INVISIBLE, duration, 0); combatPtr->setParam(COMBAT_PARAM_AGGRESSIVE, 0); combatPtr->addCondition(condition); } else if (spellName == "drunk") { @@ -186,7 +186,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell duration = spell->duration; } - std::shared_ptr condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_DRUNK, duration, 0); + const auto &condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_DRUNK, duration, 0); combatPtr->addCondition(condition); } else if (spellName == "soulwars fear" || spellName == "fear") { int32_t duration = 6000; @@ -195,7 +195,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell duration = spell->duration; } - const auto condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_FEARED, duration, 0); + const auto &condition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_FEARED, duration, 0); combatPtr->addCondition(condition); } else if (spellName == "firefield") { combatPtr->setParam(COMBAT_PARAM_CREATEITEM, ITEM_FIREFIELD_PVP_FULL); @@ -229,7 +229,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell // If a spell has a condition, it always applies, no matter what kind of spell it is if (spell->conditionType != CONDITION_NONE) { - int32_t minDamage = std::abs(spell->conditionMinDamage); + const int32_t minDamage = std::abs(spell->conditionMinDamage); int32_t maxDamage = std::abs(spell->conditionMaxDamage); int32_t startDamage = std::abs(spell->conditionStartDamage); uint32_t tickInterval = 2000; @@ -246,7 +246,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell maxDamage = minDamage; } - std::shared_ptr condition = getDamageCondition(spell->conditionType, maxDamage, minDamage, startDamage, tickInterval); + const auto &condition = getDamageCondition(spell->conditionType, maxDamage, minDamage, startDamage, tickInterval); combatPtr->addCondition(condition); } @@ -269,7 +269,7 @@ bool Monsters::deserializeSpell(const std::shared_ptr spell, spell } bool MonsterType::loadCallback(LuaScriptInterface* scriptInterface) { - int32_t id = scriptInterface->getEvent(); + const int32_t id = scriptInterface->getEvent(); if (id == -1) { g_logger().warn("[MonsterType::loadCallback] - Event not found"); return false; @@ -312,7 +312,7 @@ std::shared_ptr Monsters::getMonsterType(const std::string &name, b if (auto it = monsters.find(lowerCaseName); it != monsters.end() // We will only return the MonsterType if it match the exact name of the monster - && it->first.find(lowerCaseName) != it->first.npos) { + && it->first.find(lowerCaseName) != std::basic_string::npos) { return it->second; } if (!silent) { @@ -322,12 +322,12 @@ std::shared_ptr Monsters::getMonsterType(const std::string &name, b } std::shared_ptr Monsters::getMonsterTypeByRaceId(uint16_t raceId, bool isBoss /* = false*/) const { - auto bossType = g_ioBosstiary().getMonsterTypeByBossRaceId(raceId); + const auto &bossType = g_ioBosstiary().getMonsterTypeByBossRaceId(raceId); if (isBoss && bossType) { return bossType; } - auto monster_race_map = g_game().getBestiaryList(); + const auto &monster_race_map = g_game().getBestiaryList(); auto it = monster_race_map.find(raceId); if (it == monster_race_map.end()) { return nullptr; @@ -336,9 +336,9 @@ std::shared_ptr Monsters::getMonsterTypeByRaceId(uint16_t raceId, b return g_monsters().getMonsterType(it->second); } -bool Monsters::tryAddMonsterType(const std::string &name, const std::shared_ptr mType) { - std::string lowerName = asLowerCaseString(name); - if (monsters.find(lowerName) != monsters.end()) { +bool Monsters::tryAddMonsterType(const std::string &name, const std::shared_ptr &mType) { + const std::string lowerName = asLowerCaseString(name); + if (monsters.contains(lowerName)) { g_logger().debug("[{}] the monster with name '{}' already exist", __FUNCTION__, name); return false; } diff --git a/src/creatures/monsters/monsters.hpp b/src/creatures/monsters/monsters.hpp index a28903e0ad5..523a320557d 100644 --- a/src/creatures/monsters/monsters.hpp +++ b/src/creatures/monsters/monsters.hpp @@ -31,7 +31,7 @@ struct spellBlock_t { spellBlock_t(const spellBlock_t &other) = delete; spellBlock_t &operator=(const spellBlock_t &other) = delete; spellBlock_t(spellBlock_t &&other) noexcept : - spell(other.spell), + spell(std::move(other.spell)), chance(other.chance), speed(other.speed), range(other.range), @@ -166,7 +166,7 @@ class MonsterType { public: MonsterType() = default; explicit MonsterType(const std::string &initName) : - name(initName), typeName(initName), nameDescription(initName), variantName("") {}; + name(initName), typeName(initName), nameDescription(initName) { } // non-copyable MonsterType(const MonsterType &) = delete; @@ -205,9 +205,9 @@ class MonsterType { return !info.bosstiaryClass.empty(); } - void loadLoot(std::shared_ptr monsterType, LootBlock lootblock); + void loadLoot(const std::shared_ptr &monsterType, LootBlock lootblock) const; - bool canSpawn(const Position &pos); + bool canSpawn(const Position &pos) const; }; class MonsterSpell { @@ -217,8 +217,8 @@ class MonsterSpell { MonsterSpell(const MonsterSpell &) = delete; MonsterSpell &operator=(const MonsterSpell &) = delete; - std::string name = ""; - std::string scriptName = ""; + std::string name; + std::string scriptName; uint8_t chance = 100; uint8_t range = 0; @@ -246,7 +246,7 @@ class MonsterSpell { bool isMelee = false; Outfit_t outfit = {}; - std::string outfitMonster = ""; + std::string outfitMonster; uint16_t outfitItem = 0; ShootType_t shoot = CONST_ANI_NONE; @@ -275,14 +275,14 @@ class Monsters { std::shared_ptr getMonsterType(const std::string &name, bool silent = false) const; std::shared_ptr getMonsterTypeByRaceId(uint16_t raceId, bool isBoss = false) const; - bool tryAddMonsterType(const std::string &name, std::shared_ptr mType); - bool deserializeSpell(std::shared_ptr spell, spellBlock_t &sb, const std::string &description = ""); + bool tryAddMonsterType(const std::string &name, const std::shared_ptr &mType); + bool deserializeSpell(const std::shared_ptr &spell, spellBlock_t &sb, const std::string &description = "") const; std::unique_ptr scriptInterface; std::map> monsters; private: - std::shared_ptr getDamageCondition(ConditionType_t conditionType, int32_t maxDamage, int32_t minDamage, int32_t startDamage, uint32_t tickInterval); + std::shared_ptr getDamageCondition(ConditionType_t conditionType, int32_t maxDamage, int32_t minDamage, int32_t startDamage, uint32_t tickInterval) const; }; constexpr auto g_monsters = Monsters::getInstance; diff --git a/src/creatures/monsters/spawns/spawn_monster.cpp b/src/creatures/monsters/spawns/spawn_monster.cpp index 922f0210000..8578c3e2a15 100644 --- a/src/creatures/monsters/spawns/spawn_monster.cpp +++ b/src/creatures/monsters/spawns/spawn_monster.cpp @@ -28,7 +28,7 @@ bool SpawnsMonster::loadFromXML(const std::string &filemonstername) { } pugi::xml_document doc; - pugi::xml_parse_result result = doc.load_file(filemonstername.c_str()); + const pugi::xml_parse_result result = doc.load_file(filemonstername.c_str()); if (!result) { printXMLError(__FUNCTION__, filemonstername, result); return false; @@ -39,7 +39,8 @@ bool SpawnsMonster::loadFromXML(const std::string &filemonstername) { std::string boostedNameGet = g_game().getBoostedMonsterName(); - for (auto spawnMonsterNode : doc.child("monsters").children()) { + spawnMonsterList.reserve(100000); + for (const auto &spawnMonsterNode : doc.child("monsters").children()) { Position centerPos( pugi::cast(spawnMonsterNode.attribute("centerx").value()), pugi::cast(spawnMonsterNode.attribute("centery").value()), @@ -59,9 +60,8 @@ bool SpawnsMonster::loadFromXML(const std::string &filemonstername) { continue; } - SpawnMonster &spawnMonster = spawnMonsterList.emplace_back(centerPos, radius); - - for (auto childMonsterNode : spawnMonsterNode.children()) { + const auto &spawnMonster = spawnMonsterList.emplace_back(std::make_shared(centerPos, radius)); + for (const auto &childMonsterNode : spawnMonsterNode.children()) { if (strcasecmp(childMonsterNode.name(), "monster") == 0) { pugi::xml_attribute nameAttribute = childMonsterNode.attribute("name"); if (!nameAttribute) { @@ -77,8 +77,8 @@ bool SpawnsMonster::loadFromXML(const std::string &filemonstername) { dir = DIRECTION_NORTH; } - auto xOffset = pugi::cast(childMonsterNode.attribute("x").value()); - auto yOffset = pugi::cast(childMonsterNode.attribute("y").value()); + const auto xOffset = pugi::cast(childMonsterNode.attribute("x").value()); + const auto yOffset = pugi::cast(childMonsterNode.attribute("y").value()); Position pos( static_cast(centerPos.x + xOffset), static_cast(centerPos.y + yOffset), @@ -93,16 +93,25 @@ bool SpawnsMonster::loadFromXML(const std::string &filemonstername) { uint32_t scheduleInterval = g_configManager().getNumber(DEFAULT_RESPAWN_TIME); - try { - scheduleInterval = pugi::cast(childMonsterNode.attribute("spawntime").value()); - } catch (...) { - g_logger().warn("Failed to add schedule interval to monster: {}, interval: {}. Setting to default respawn time: {}", nameAttribute.value(), childMonsterNode.attribute("spawntime").value(), scheduleInterval); + pugi::xml_attribute spawnTimeAttr = childMonsterNode.attribute("spawntime"); + if (spawnTimeAttr) { + const auto xmlSpawnTime = pugi::cast(spawnTimeAttr.value()); + if (xmlSpawnTime > 0) { + scheduleInterval = xmlSpawnTime; + } else { + g_logger().warn("Invalid spawntime value '{}' for monster '{}'. Setting to default respawn time: {}", spawnTimeAttr.value(), nameAttribute.value(), scheduleInterval); + } + } else { + g_logger().warn("Missing spawntime attribute for monster '{}'. Setting to default respawn time: {}", nameAttribute.value(), scheduleInterval); } - spawnMonster.addMonster(nameAttribute.as_string(), pos, dir, scheduleInterval * 1000, weight); + spawnMonster->addMonster(nameAttribute.as_string(), pos, dir, scheduleInterval * 1000, weight); } } } + + // Clears unused memory that has been reserved + spawnMonsterList.shrink_to_fit(); return true; } @@ -111,16 +120,16 @@ void SpawnsMonster::startup() { return; } - for (SpawnMonster &spawnMonster : spawnMonsterList) { - spawnMonster.startup(); + for (const auto &spawnMonster : spawnMonsterList) { + spawnMonster->startup(); } started = true; } void SpawnsMonster::clear() { - for (SpawnMonster &spawnMonster : spawnMonsterList) { - spawnMonster.stopEvent(); + for (const auto &spawnMonster : spawnMonsterList) { + spawnMonster->stopEvent(); } spawnMonsterList.clear(); @@ -146,11 +155,7 @@ void SpawnMonster::startSpawnMonsterCheck() { } SpawnMonster::~SpawnMonster() { - for (const auto &[_, monster] : spawnedMonsterMap) { - monster->setSpawnMonster(nullptr); - } stopEvent(); - spawnMonsterMap.clear(); } bool SpawnMonster::findPlayer(const Position &pos) { @@ -160,11 +165,11 @@ bool SpawnMonster::findPlayer(const Position &pos) { }); } -bool SpawnMonster::isInSpawnMonsterZone(const Position &pos) { +bool SpawnMonster::isInSpawnMonsterZone(const Position &pos) const { return SpawnsMonster::isInZone(centerPos, radius, pos); } -bool SpawnMonster::spawnMonster(uint32_t spawnMonsterId, spawnBlock_t &sb, const std::shared_ptr monsterType, bool startup /*= false*/) { +bool SpawnMonster::spawnMonster(uint32_t spawnMonsterId, spawnBlock_t &sb, const std::shared_ptr &monsterType, bool startup /*= false*/) { if (spawnedMonsterMap.contains(spawnMonsterId)) { return false; } @@ -182,7 +187,7 @@ bool SpawnMonster::spawnMonster(uint32_t spawnMonsterId, spawnBlock_t &sb, const } monster->setDirection(sb.direction); - monster->setSpawnMonster(this); + monster->setSpawnMonster(static_self_cast()); monster->setMasterPos(sb.pos); spawnedMonsterMap[spawnMonsterId] = monster; @@ -270,7 +275,7 @@ void SpawnMonster::checkSpawnMonster() { } } -void SpawnMonster::scheduleSpawn(uint32_t spawnMonsterId, spawnBlock_t &sb, const std::shared_ptr mType, uint16_t interval, bool startup /*= false*/) { +void SpawnMonster::scheduleSpawn(uint32_t spawnMonsterId, spawnBlock_t &sb, const std::shared_ptr &mType, uint16_t interval, bool startup /*= false*/) { if (interval <= 0) { spawnMonster(spawnMonsterId, sb, mType, startup); } else { @@ -303,20 +308,21 @@ bool SpawnMonster::addMonster(const std::string &name, const Position &pos, Dire break; } } - const auto monsterType = g_monsters().getMonsterType(variant + name); + const auto &monsterType = g_monsters().getMonsterType(variant + name); if (!monsterType) { g_logger().error("Can not find {}", name); return false; } - uint32_t eventschedule = g_eventsScheduler().getSpawnMonsterSchedule(); - std::string boostedMonster = g_game().getBoostedMonsterName(); + const uint32_t eventschedule = g_eventsScheduler().getSpawnMonsterSchedule(); + const std::string boostedMonster = g_game().getBoostedMonsterName(); int32_t boostedrate = 1; if (name == boostedMonster) { boostedrate = 2; } + auto rateSpawn = g_configManager().getNumber(RATE_SPAWN); // eventschedule is a whole percentage, so we need to multiply by 100 to match the order of magnitude of the other values - scheduleInterval = scheduleInterval * 100 / std::max((uint32_t)1, (g_configManager().getNumber(RATE_SPAWN) * boostedrate * eventschedule)); + scheduleInterval = scheduleInterval * 100 / std::max(static_cast(1), (rateSpawn * boostedrate * eventschedule)); if (scheduleInterval < MONSTER_MINSPAWN_INTERVAL) { g_logger().warn("[SpawnsMonster::addMonster] - {} {} spawntime cannot be less than {} seconds, set to {} by default.", name, pos.toString(), MONSTER_MINSPAWN_INTERVAL / 1000, MONSTER_MINSPAWN_INTERVAL / 1000); scheduleInterval = MONSTER_MINSPAWN_INTERVAL; @@ -360,7 +366,7 @@ bool SpawnMonster::addMonster(const std::string &name, const Position &pos, Dire return true; } -void SpawnMonster::removeMonster(std::shared_ptr monster) { +void SpawnMonster::removeMonster(const std::shared_ptr &monster) { uint32_t spawnMonsterId = 0; for (const auto &[id, m] : spawnedMonsterMap) { if (m == monster) { @@ -377,9 +383,13 @@ void SpawnMonster::removeMonsters() { } void SpawnMonster::setMonsterVariant(const std::string &variant) { - for (auto &it : spawnMonsterMap) { + for (auto &[monsterId, monsterInfo] : spawnMonsterMap) { + if (monsterId == 0) { + continue; + } + std::unordered_map, uint32_t> monsterTypes; - for (const auto &[monsterType, weight] : it.second.monsterTypes) { + for (const auto &[monsterType, weight] : monsterInfo.monsterTypes) { if (!monsterType || monsterType->typeName.empty()) { continue; } @@ -389,7 +399,7 @@ void SpawnMonster::setMonsterVariant(const std::string &variant) { monsterTypes.emplace(variantType, weight); } } - it.second.monsterTypes = monsterTypes; + monsterInfo.monsterTypes = monsterTypes; } } @@ -420,7 +430,7 @@ std::shared_ptr spawnBlock_t::getMonsterType() const { uint32_t randomWeight = uniform_random(0, totalWeight - 1); // order monsters by weight DESC std::vector, uint32_t>> orderedMonsterTypes(monsterTypes.begin(), monsterTypes.end()); - std::sort(orderedMonsterTypes.begin(), orderedMonsterTypes.end(), [](const auto &a, const auto &b) { + std::ranges::sort(orderedMonsterTypes, [](const auto &a, const auto &b) { return a.second > b.second; }); for (const auto &[mType, weight] : orderedMonsterTypes) { diff --git a/src/creatures/monsters/spawns/spawn_monster.hpp b/src/creatures/monsters/spawns/spawn_monster.hpp index caf454c41b5..a20fd050c47 100644 --- a/src/creatures/monsters/spawns/spawn_monster.hpp +++ b/src/creatures/monsters/spawns/spawn_monster.hpp @@ -9,7 +9,6 @@ #pragma once -#include "items/tile.hpp" #include "game/movement/position.hpp" class Monster; @@ -17,16 +16,16 @@ class MonsterType; struct spawnBlock_t { Position pos; - std::unordered_map, uint32_t> monsterTypes; - int64_t lastSpawn; - uint32_t interval; + std::unordered_map, uint32_t> monsterTypes {}; + int64_t lastSpawn {}; + uint32_t interval {}; Direction direction; std::shared_ptr getMonsterType() const; bool hasBoss() const; }; -class SpawnMonster { +class SpawnMonster : public SharedObject { public: SpawnMonster(Position initPos, int32_t initRadius) : centerPos(initPos), radius(initRadius) { } @@ -59,7 +58,7 @@ class SpawnMonster { } bool addMonster(const std::string &name, const Position &pos, Direction dir, uint32_t interval, uint32_t weight = 1); - void removeMonster(std::shared_ptr monster); + void removeMonster(const std::shared_ptr &monster); void removeMonsters(); uint32_t getInterval() const { @@ -70,7 +69,7 @@ class SpawnMonster { void startSpawnMonsterCheck(); void stopEvent(); - bool isInSpawnMonsterZone(const Position &pos); + bool isInSpawnMonsterZone(const Position &pos) const; void cleanup(); const Position &getCenterPos() const { @@ -90,9 +89,9 @@ class SpawnMonster { uint32_t checkSpawnMonsterEvent = 0; static bool findPlayer(const Position &pos); - bool spawnMonster(uint32_t spawnMonsterId, spawnBlock_t &sb, std::shared_ptr monsterType, bool startup = false); + bool spawnMonster(uint32_t spawnMonsterId, spawnBlock_t &sb, const std::shared_ptr &monsterType, bool startup = false); void checkSpawnMonster(); - void scheduleSpawn(uint32_t spawnMonsterId, spawnBlock_t &sb, std::shared_ptr monsterType, uint16_t interval, bool startup = false); + void scheduleSpawn(uint32_t spawnMonsterId, spawnBlock_t &sb, const std::shared_ptr &monsterType, uint16_t interval, bool startup = false); }; class SpawnsMonster { @@ -109,12 +108,12 @@ class SpawnsMonster { bool isLoaded() const { return loaded; } - std::vector &getspawnMonsterList() { + std::vector> &getspawnMonsterList() { return spawnMonsterList; } private: - std::vector spawnMonsterList; + std::vector> spawnMonsterList; std::string filemonstername; bool loaded = false; bool started = false; diff --git a/src/creatures/npcs/npc.cpp b/src/creatures/npcs/npc.cpp index 2d615c022e4..0985881e971 100644 --- a/src/creatures/npcs/npc.cpp +++ b/src/creatures/npcs/npc.cpp @@ -35,7 +35,7 @@ Npc::Npc(const std::shared_ptr &npcType) : npcType(npcType) { defaultOutfit = npcType->info.outfit; currentOutfit = npcType->info.outfit; - float multiplier = g_configManager().getFloat(RATE_NPC_HEALTH); + const float multiplier = g_configManager().getFloat(RATE_NPC_HEALTH); health = npcType->info.health * multiplier; healthMax = npcType->info.healthMax * multiplier; baseSpeed = npcType->info.baseSpeed; @@ -88,15 +88,15 @@ bool Npc::isPlayerInteractingOnTopic(uint32_t playerId, uint16_t topicId) { return it->second == topicId; } -void Npc::onCreatureAppear(std::shared_ptr creature, bool isLogin) { +void Npc::onCreatureAppear(const std::shared_ptr &creature, bool isLogin) { Creature::onCreatureAppear(creature, isLogin); - if (auto player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { onPlayerAppear(player); } // onCreatureAppear(self, creature) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.creatureAppearEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(creature); @@ -107,11 +107,11 @@ void Npc::onCreatureAppear(std::shared_ptr creature, bool isLogin) { } } -void Npc::onRemoveCreature(std::shared_ptr creature, bool isLogout) { +void Npc::onRemoveCreature(const std::shared_ptr &creature, bool isLogout) { Creature::onRemoveCreature(creature, isLogout); // onCreatureDisappear(self, creature) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.creatureDisappearEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(creature); @@ -121,7 +121,7 @@ void Npc::onRemoveCreature(std::shared_ptr creature, bool isLogout) { return; } - if (auto player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { removeShopPlayer(player->getGUID()); onPlayerDisappear(player); } @@ -135,7 +135,7 @@ void Npc::onCreatureMove(const std::shared_ptr &creature, const std::s Creature::onCreatureMove(creature, newTile, newPos, oldTile, oldPos, teleport); // onCreatureMove(self, creature, oldPosition, newPosition) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.creatureMoveEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(creature); @@ -165,7 +165,7 @@ void Npc::manageIdle() { } } -void Npc::onPlayerAppear(std::shared_ptr player) { +void Npc::onPlayerAppear(const std::shared_ptr &player) { if (player->hasFlag(PlayerFlags_t::IgnoredByNpcs) || playerSpectators.contains(player)) { return; } @@ -173,7 +173,7 @@ void Npc::onPlayerAppear(std::shared_ptr player) { manageIdle(); } -void Npc::onPlayerDisappear(std::shared_ptr player) { +void Npc::onPlayerDisappear(const std::shared_ptr &player) { removePlayerInteraction(player); if (!player->hasFlag(PlayerFlags_t::IgnoredByNpcs) && playerSpectators.contains(player)) { playerSpectators.erase(player); @@ -181,7 +181,7 @@ void Npc::onPlayerDisappear(std::shared_ptr player) { } } -void Npc::onCreatureSay(std::shared_ptr creature, SpeakClasses type, const std::string &text) { +void Npc::onCreatureSay(const std::shared_ptr &creature, SpeakClasses type, const std::string &text) { Creature::onCreatureSay(creature, type, text); if (!creature->getPlayer()) { @@ -189,7 +189,7 @@ void Npc::onCreatureSay(std::shared_ptr creature, SpeakClasses type, c } // onCreatureSay(self, creature, type, message) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.creatureSayEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(creature); @@ -212,7 +212,7 @@ void Npc::onThinkSound(uint32_t interval) { soundTicks = 0; if (!npcType->info.soundVector.empty() && (npcType->info.soundChance >= static_cast(uniform_random(1, 100)))) { - auto index = uniform_random(0, npcType->info.soundVector.size() - 1); + const auto index = uniform_random(0, npcType->info.soundVector.size() - 1); g_game().sendSingleSoundEffect(static_self_cast()->getPosition(), npcType->info.soundVector[index], getNpc()); } } @@ -222,7 +222,7 @@ void Npc::onThink(uint32_t interval) { Creature::onThink(interval); // onThink(self, interval) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.thinkEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushNumber(interval); @@ -249,7 +249,7 @@ void Npc::onThink(uint32_t interval) { } } -void Npc::onPlayerBuyItem(std::shared_ptr player, uint16_t itemId, uint8_t subType, uint16_t amount, bool ignore, bool inBackpacks) { +void Npc::onPlayerBuyItem(const std::shared_ptr &player, uint16_t itemId, uint8_t subType, uint16_t amount, bool ignore, bool inBackpacks) { if (player == nullptr) { g_logger().error("[Npc::onPlayerBuyItem] - Player is nullptr"); return; @@ -261,10 +261,10 @@ void Npc::onPlayerBuyItem(std::shared_ptr player, uint16_t itemId, uint8 return; } - uint32_t shoppingBagPrice = 20; - uint32_t shoppingBagSlots = 20; + constexpr uint32_t shoppingBagPrice = 20; + constexpr uint32_t shoppingBagSlots = 20; const ItemType &itemType = Item::items[itemId]; - if (std::shared_ptr tile = ignore ? player->getTile() : nullptr; tile) { + if (const std::shared_ptr &tile = ignore ? player->getTile() : nullptr; tile) { double slotsNedeed; if (itemType.stackable) { slotsNedeed = inBackpacks ? std::ceil(std::ceil(static_cast(amount) / itemType.stackSize) / shoppingBagSlots) : std::ceil(static_cast(amount) / itemType.stackSize); @@ -286,7 +286,7 @@ void Npc::onPlayerBuyItem(std::shared_ptr player, uint16_t itemId, uint8 } } - uint32_t totalCost = buyPrice * amount; + const uint32_t totalCost = buyPrice * amount; uint32_t bagsCost = 0; if (inBackpacks && itemType.stackable) { bagsCost = shoppingBagPrice * static_cast(std::ceil(std::ceil(static_cast(amount) / itemType.stackSize) / shoppingBagSlots)); @@ -306,7 +306,7 @@ void Npc::onPlayerBuyItem(std::shared_ptr player, uint16_t itemId, uint8 } // npc:onBuyItem(player, itemId, subType, amount, ignore, inBackpacks, totalCost) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.playerBuyEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(player); @@ -323,18 +323,18 @@ void Npc::onPlayerBuyItem(std::shared_ptr player, uint16_t itemId, uint8 } } -void Npc::onPlayerSellItem(std::shared_ptr player, uint16_t itemId, uint8_t subType, uint16_t amount, bool ignore) { +void Npc::onPlayerSellItem(const std::shared_ptr &player, uint16_t itemId, uint8_t subType, uint16_t amount, bool ignore) { uint64_t totalPrice = 0; - onPlayerSellItem(std::move(player), itemId, subType, amount, ignore, totalPrice); + onPlayerSellItem(player, itemId, subType, amount, ignore, totalPrice); } void Npc::onPlayerSellAllLoot(uint32_t playerId, uint16_t itemId, bool ignore, uint64_t totalPrice) { - std::shared_ptr player = g_game().getPlayerByID(playerId); + const auto &player = g_game().getPlayerByID(playerId); if (!player) { return; } if (itemId == ITEM_GOLD_POUCH) { - auto container = player->getLootPouch(); + const auto &container = player->getLootPouch(); if (!container) { return; } @@ -346,7 +346,7 @@ void Npc::onPlayerSellAllLoot(uint32_t playerId, uint16_t itemId, bool ignore, u hasMore = true; break; } - auto item = *it; + const auto &item = *it; if (!item) { continue; } @@ -357,7 +357,7 @@ void Npc::onPlayerSellAllLoot(uint32_t playerId, uint16_t itemId, bool ignore, u toSellCount += item->getItemAmount(); } } - for (auto &[m_itemId, amount] : toSell) { + for (const auto &[m_itemId, amount] : toSell) { onPlayerSellItem(player, m_itemId, 0, amount, ignore, totalPrice, container); } auto ss = std::stringstream(); @@ -379,7 +379,7 @@ void Npc::onPlayerSellAllLoot(uint32_t playerId, uint16_t itemId, bool ignore, u } } -void Npc::onPlayerSellItem(std::shared_ptr player, uint16_t itemId, uint8_t subType, uint16_t amount, bool ignore, uint64_t &totalPrice, std::shared_ptr parent /*= nullptr*/) { +void Npc::onPlayerSellItem(const std::shared_ptr &player, uint16_t itemId, uint8_t subType, uint16_t amount, bool ignore, uint64_t &totalPrice, const std::shared_ptr &parent /*= nullptr*/) { if (!player) { return; } @@ -453,7 +453,7 @@ void Npc::onPlayerSellItem(std::shared_ptr player, uint16_t itemId, uint } g_metrics().addCounter("balance_increase", totalCost, { { "player", player->getName() }, { "context", "npc_sale" } }); } else { - std::shared_ptr newItem = Item::CreateItem(getCurrency(), totalCost); + const auto &newItem = Item::CreateItem(getCurrency(), totalCost); if (newItem) { g_game().internalPlayerAddItem(player, newItem, true); } @@ -461,7 +461,7 @@ void Npc::onPlayerSellItem(std::shared_ptr player, uint16_t itemId, uint } // npc:onSellItem(player, itemId, subType, amount, ignore, itemName, totalCost) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.playerSellEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(player); @@ -478,13 +478,13 @@ void Npc::onPlayerSellItem(std::shared_ptr player, uint16_t itemId, uint } } -void Npc::onPlayerCheckItem(std::shared_ptr player, uint16_t itemId, uint8_t subType) { +void Npc::onPlayerCheckItem(const std::shared_ptr &player, uint16_t itemId, uint8_t subType) { if (!player) { return; } // onPlayerCheckItem(self, player, itemId, subType) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.playerLookEvent)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(player); @@ -497,14 +497,14 @@ void Npc::onPlayerCheckItem(std::shared_ptr player, uint16_t itemId, uin } } -void Npc::onPlayerCloseChannel(std::shared_ptr creature) { - std::shared_ptr player = creature->getPlayer(); +void Npc::onPlayerCloseChannel(const std::shared_ptr &creature) { + const auto &player = creature->getPlayer(); if (!player) { return; } // onPlayerCloseChannel(npc, player) - CreatureCallback callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); + auto callback = CreatureCallback(npcType->info.scriptInterface, getNpc()); if (callback.startScriptInterface(npcType->info.playerCloseChannel)) { callback.pushSpecificCreature(static_self_cast()); callback.pushCreature(player); @@ -527,13 +527,13 @@ void Npc::onThinkYell(uint32_t interval) { yellTicks = 0; if (!npcType->info.voiceVector.empty() && (npcType->info.yellChance >= static_cast(uniform_random(1, 100)))) { - uint32_t index = uniform_random(0, npcType->info.voiceVector.size() - 1); - const voiceBlock_t &vb = npcType->info.voiceVector[index]; + const uint32_t index = uniform_random(0, npcType->info.voiceVector.size() - 1); + const auto &[text, yellText] = npcType->info.voiceVector[index]; - if (vb.yellText) { - g_game().internalCreatureSay(static_self_cast(), TALKTYPE_YELL, vb.text, false); + if (yellText) { + g_game().internalCreatureSay(static_self_cast(), TALKTYPE_YELL, text, false); } else { - g_game().internalCreatureSay(static_self_cast(), TALKTYPE_SAY, vb.text, false); + g_game().internalCreatureSay(static_self_cast(), TALKTYPE_SAY, text, false); } } } @@ -575,7 +575,7 @@ void Npc::onPlacedCreature() { } void Npc::loadPlayerSpectators() { - auto spec = Spectators().find(position, true); + const auto &spec = Spectators().find(position, true); for (const auto &creature : spec) { if (!creature->getPlayer()->hasFlag(PlayerFlags_t::IgnoredByNpcs)) { playerSpectators.emplace(creature->getPlayer()); @@ -608,7 +608,7 @@ bool Npc::isInSpawnRange(const Position &pos) const { } void Npc::setPlayerInteraction(uint32_t playerId, uint16_t topicId /*= 0*/) { - std::shared_ptr creature = g_game().getCreatureByID(playerId); + const auto &creature = g_game().getCreatureByID(playerId); if (!creature) { return; } @@ -621,7 +621,7 @@ void Npc::setPlayerInteraction(uint32_t playerId, uint16_t topicId /*= 0*/) { playerInteractions[playerId] = topicId; } -void Npc::removePlayerInteraction(std::shared_ptr player) { +void Npc::removePlayerInteraction(const std::shared_ptr &player) { auto view = std::ranges::remove(playerInteractionsOrder, player->getID()); playerInteractionsOrder.erase(view.begin(), view.end()); if (playerInteractions.contains(player->getID())) { @@ -645,12 +645,12 @@ bool Npc::canWalkTo(const Position &fromPos, Direction dir) { return false; } - Position toPos = getNextPosition(dir, fromPos); + const Position toPos = getNextPosition(dir, fromPos); if (!SpawnsNpc::isInZone(masterPos, npcType->info.walkRadius, toPos)) { return false; } - std::shared_ptr toTile = g_game().map.getTile(toPos); + const auto &toTile = g_game().map.getTile(toPos); if (!toTile || toTile->queryAdd(0, getNpc(), 1, 0) != RETURNVALUE_NOERROR) { return false; } @@ -680,7 +680,7 @@ bool Npc::getRandomStep(Direction &moveDirection) { std::ranges::shuffle(directionvector, getRandomGenerator()); for (const Position &creaturePos = getPosition(); - Direction direction : directionvector) { + const Direction &direction : directionvector) { if (canWalkTo(creaturePos, direction)) { moveDirection = direction; return true; @@ -690,7 +690,7 @@ bool Npc::getRandomStep(Direction &moveDirection) { } bool Npc::isShopPlayer(uint32_t playerGUID) const { - return shopPlayers.find(playerGUID) != shopPlayers.end(); + return shopPlayers.contains(playerGUID); } void Npc::addShopPlayer(uint32_t playerGUID, const std::vector &shopItems) { @@ -702,7 +702,7 @@ void Npc::removeShopPlayer(uint32_t playerGUID) { } void Npc::closeAllShopWindows() { - for (const auto &[playerGUID, shopBlock] : shopPlayers) { + for (const auto &playerGUID : shopPlayers | std::views::keys) { const auto &player = g_game().getPlayerByGUID(playerGUID); if (player) { player->closeShopWindow(); @@ -711,7 +711,7 @@ void Npc::closeAllShopWindows() { shopPlayers.clear(); } -void Npc::handlePlayerMove(std::shared_ptr player, const Position &newPos) { +void Npc::handlePlayerMove(const std::shared_ptr &player, const Position &newPos) { if (!canInteract(newPos)) { onPlayerCloseChannel(player); } else if (canInteract(newPos) && !playerInteractionsOrder.empty() && playerInteractionsOrder.back() == player->getID()) { diff --git a/src/creatures/npcs/npc.hpp b/src/creatures/npcs/npc.hpp index 382ab250156..79b4c78c544 100644 --- a/src/creatures/npcs/npc.hpp +++ b/src/creatures/npcs/npc.hpp @@ -66,7 +66,7 @@ class Npc final : public Creature { return strDescription + '.'; } - void setName(std::string newName) { + void setName(std::string newName) const { npcType->name = std::move(newName); } @@ -84,14 +84,14 @@ class Npc final : public Creature { uint8_t getSpeechBubble() const override { return npcType->info.speechBubble; } - void setSpeechBubble(const uint8_t bubble) { + void setSpeechBubble(const uint8_t bubble) const { npcType->info.speechBubble = bubble; } uint16_t getCurrency() const { return npcType->info.currencyId; } - void setCurrency(uint16_t currency) { + void setCurrency(uint16_t currency) const { npcType->info.currencyId = currency; } @@ -126,23 +126,23 @@ class Npc final : public Creature { } void setPlayerInteraction(uint32_t playerId, uint16_t topicId = 0); - void removePlayerInteraction(std::shared_ptr player); + void removePlayerInteraction(const std::shared_ptr &player); void resetPlayerInteractions(); bool isInteractingWithPlayer(uint32_t playerId); bool isPlayerInteractingOnTopic(uint32_t playerId, uint16_t topicId); - void onCreatureAppear(std::shared_ptr creature, bool isLogin) override; - void onRemoveCreature(std::shared_ptr creature, bool isLogout) override; + void onCreatureAppear(const std::shared_ptr &creature, bool isLogin) override; + void onRemoveCreature(const std::shared_ptr &creature, bool isLogout) override; void onCreatureMove(const std::shared_ptr &creature, const std::shared_ptr &newTile, const Position &newPos, const std::shared_ptr &oldTile, const Position &oldPos, bool teleport) override; - void onCreatureSay(std::shared_ptr creature, SpeakClasses type, const std::string &text) override; + void onCreatureSay(const std::shared_ptr &creature, SpeakClasses type, const std::string &text) override; void onThink(uint32_t interval) override; - void onPlayerBuyItem(std::shared_ptr player, uint16_t itemid, uint8_t count, uint16_t amount, bool ignore, bool inBackpacks); + void onPlayerBuyItem(const std::shared_ptr &player, uint16_t itemid, uint8_t count, uint16_t amount, bool ignore, bool inBackpacks); void onPlayerSellAllLoot(uint32_t playerId, uint16_t itemid, bool ignore, uint64_t totalPrice); - void onPlayerSellItem(std::shared_ptr player, uint16_t itemid, uint8_t count, uint16_t amount, bool ignore); - void onPlayerSellItem(std::shared_ptr player, uint16_t itemid, uint8_t count, uint16_t amount, bool ignore, uint64_t &totalPrice, std::shared_ptr parent = nullptr); - void onPlayerCheckItem(std::shared_ptr player, uint16_t itemid, uint8_t count); - void onPlayerCloseChannel(std::shared_ptr creature); + void onPlayerSellItem(const std::shared_ptr &player, uint16_t itemid, uint8_t count, uint16_t amount, bool ignore); + void onPlayerSellItem(const std::shared_ptr &player, uint16_t itemid, uint8_t count, uint16_t amount, bool ignore, uint64_t &totalPrice, const std::shared_ptr &parent = nullptr); + void onPlayerCheckItem(const std::shared_ptr &player, uint16_t itemid, uint8_t count); + void onPlayerCloseChannel(const std::shared_ptr &creature); void onPlacedCreature() override; bool canWalkTo(const Position &fromPos, Direction dir); @@ -195,10 +195,10 @@ class Npc final : public Creature { friend class LuaScriptInterface; friend class Map; - void onPlayerAppear(std::shared_ptr player); - void onPlayerDisappear(std::shared_ptr player); + void onPlayerAppear(const std::shared_ptr &player); + void onPlayerDisappear(const std::shared_ptr &player); void manageIdle(); - void handlePlayerMove(std::shared_ptr player, const Position &newPos); + void handlePlayerMove(const std::shared_ptr &player, const Position &newPos); void loadPlayerSpectators(); }; diff --git a/src/creatures/npcs/npcs.cpp b/src/creatures/npcs/npcs.cpp index 7678daf38b0..b6c6a5cb8e7 100644 --- a/src/creatures/npcs/npcs.cpp +++ b/src/creatures/npcs/npcs.cpp @@ -15,9 +15,9 @@ #include "lua/scripts/scripts.hpp" #include "game/game.hpp" -bool NpcType::canSpawn(const Position &pos) { +bool NpcType::canSpawn(const Position &pos) const { bool canSpawn = true; - bool isDay = g_game().gameIsDay(); + const bool isDay = g_game().gameIsDay(); if ((isDay && info.respawnType.period == RESPAWNPERIOD_NIGHT) || (!isDay && info.respawnType.period == RESPAWNPERIOD_DAY)) { // It will ignore day and night if underground @@ -28,7 +28,7 @@ bool NpcType::canSpawn(const Position &pos) { } bool NpcType::loadCallback(LuaScriptInterface* scriptInterface) { - int32_t id = scriptInterface->getEvent(); + const int32_t id = scriptInterface->getEvent(); if (id == -1) { g_logger().warn("[NpcType::loadCallback] - Event not found"); return false; @@ -82,32 +82,32 @@ void NpcType::loadShop(const std::shared_ptr &npcType, ShopBlock shopBl } // Check if the item already exists in the shop vector and ignore it - if (std::any_of(npcType->info.shopItemVector.begin(), npcType->info.shopItemVector.end(), [&shopBlock](const auto &shopIterator) { + if (std::ranges::any_of(npcType->info.shopItemVector, [&shopBlock](const auto &shopIterator) { return shopIterator == shopBlock; })) { return; } if (shopBlock.childShop.empty()) { - bool isContainer = iType.isContainer(); + const bool &isContainer = iType.isContainer(); if (isContainer) { for (const ShopBlock &child : shopBlock.childShop) { shopBlock.childShop.push_back(child); } } } - npcType->info.shopItemVector.push_back(shopBlock); + npcType->info.shopItemVector.emplace_back(shopBlock); info.speechBubble = SPEECHBUBBLE_TRADE; } bool Npcs::load(bool loadLibs /* = true*/, bool loadNpcs /* = true*/, bool reloading /* = false*/) const { if (loadLibs) { - auto coreFolder = g_configManager().getString(CORE_DIRECTORY); + const auto coreFolder = g_configManager().getString(CORE_DIRECTORY); return g_luaEnvironment().loadFile(coreFolder + "/npclib/load.lua", "load.lua") == 0; } if (loadNpcs) { - auto datapackFolder = g_configManager().getString(DATA_DIRECTORY); + const auto datapackFolder = g_configManager().getString(DATA_DIRECTORY); return g_scripts().loadScripts(datapackFolder + "/npc", false, reloading); } return false; @@ -130,7 +130,7 @@ bool Npcs::reload() { } std::shared_ptr Npcs::getNpcType(const std::string &name, bool create /* = false*/) { - std::string key = asLowerCaseString(name); + const std::string key = asLowerCaseString(name); auto it = npcs.find(key); if (it != npcs.end()) { diff --git a/src/creatures/npcs/npcs.hpp b/src/creatures/npcs/npcs.hpp index ab5e700caea..c12f6125bfe 100644 --- a/src/creatures/npcs/npcs.hpp +++ b/src/creatures/npcs/npcs.hpp @@ -23,7 +23,7 @@ class Shop { ShopBlock shopBlock; }; -class NpcType : public SharedObject { +class NpcType final : public SharedObject { struct NpcInfo { LuaScriptInterface* scriptInterface {}; @@ -90,7 +90,7 @@ class NpcType : public SharedObject { void loadShop(const std::shared_ptr &npcType, ShopBlock shopBlock); bool loadCallback(LuaScriptInterface* scriptInterface); - bool canSpawn(const Position &pos); + bool canSpawn(const Position &pos) const; }; class Npcs { diff --git a/src/creatures/npcs/spawns/spawn_npc.cpp b/src/creatures/npcs/spawns/spawn_npc.cpp index 0976e96b68f..54450b14b3d 100644 --- a/src/creatures/npcs/spawns/spawn_npc.cpp +++ b/src/creatures/npcs/spawns/spawn_npc.cpp @@ -26,7 +26,7 @@ bool SpawnsNpc::loadFromXml(const std::string &fileNpcName) { } pugi::xml_document doc; - pugi::xml_parse_result result = doc.load_file(fileNpcName.c_str()); + const pugi::xml_parse_result result = doc.load_file(fileNpcName.c_str()); if (!result) { printXMLError(__FUNCTION__, fileNpcName, result); return false; @@ -35,7 +35,7 @@ bool SpawnsNpc::loadFromXml(const std::string &fileNpcName) { setFileName(fileNpcName); setLoaded(true); - for (auto spawnNode : doc.child("npcs").children()) { + for (const auto &spawnNode : doc.child("npcs").children()) { Position centerPos( pugi::cast(spawnNode.attribute("centerx").value()), pugi::cast(spawnNode.attribute("centery").value()), @@ -57,7 +57,7 @@ bool SpawnsNpc::loadFromXml(const std::string &fileNpcName) { const auto &spawnNpc = spawnNpcList.emplace_back(std::make_shared(centerPos, radius)); - for (auto childNode : spawnNode.children()) { + for (const auto &childNode : spawnNode.children()) { if (strcasecmp(childNode.name(), "npc") == 0) { pugi::xml_attribute nameAttribute = childNode.attribute("name"); if (!nameAttribute) { @@ -73,14 +73,14 @@ bool SpawnsNpc::loadFromXml(const std::string &fileNpcName) { dir = DIRECTION_NORTH; } - auto xOffset = pugi::cast(childNode.attribute("x").value()); - auto yOffset = pugi::cast(childNode.attribute("y").value()); + const auto xOffset = pugi::cast(childNode.attribute("x").value()); + const auto yOffset = pugi::cast(childNode.attribute("y").value()); Position pos( static_cast(centerPos.x + xOffset), static_cast(centerPos.y + yOffset), centerPos.z ); - int64_t interval = pugi::cast(childNode.attribute("spawntime").value()) * 1000; + const int64_t interval = pugi::cast(childNode.attribute("spawntime").value()) * 1000; if (interval >= MINSPAWN_INTERVAL && interval <= MAXSPAWN_INTERVAL) { spawnNpc->addNpc(nameAttribute.as_string(), pos, dir, static_cast(interval)); } else { @@ -136,8 +136,11 @@ void SpawnNpc::startSpawnNpcCheck() { } SpawnNpc::~SpawnNpc() { - for (const auto &it : spawnedNpcMap) { - auto npc = it.second; + for (const auto &[spawnId, npc] : spawnedNpcMap) { + if (spawnId == 0) { + continue; + } + npc->setSpawnNpc(nullptr); } } @@ -149,7 +152,7 @@ bool SpawnNpc::findPlayer(const Position &pos) { }); } -bool SpawnNpc::isInSpawnNpcZone(const Position &pos) { +bool SpawnNpc::isInSpawnNpcZone(const Position &pos) const { return SpawnsNpc::isInZone(centerPos, radius, pos); } @@ -179,10 +182,13 @@ bool SpawnNpc::spawnNpc(uint32_t spawnId, const std::shared_ptr &npcTyp } void SpawnNpc::startup() { - for (const auto &it : spawnNpcMap) { - uint32_t spawnId = it.first; - const spawnBlockNpc_t &sb = it.second; - spawnNpc(spawnId, sb.npcType, sb.pos, sb.direction, true); + for (const auto &[spawnId, npcInfo] : spawnNpcMap) { + if (spawnId == 0) { + continue; + } + + const auto &[pos, npcType, lastSpawnNpc, _, direction] = npcInfo; + spawnNpc(spawnId, npcType, pos, direction, true); } } @@ -191,25 +197,24 @@ void SpawnNpc::checkSpawnNpc() { cleanup(); - for (auto &it : spawnNpcMap) { - uint32_t spawnId = it.first; - if (spawnedNpcMap.find(spawnId) != spawnedNpcMap.end()) { + for (auto &[spawnId, npcInfo] : spawnNpcMap) { + if (spawnedNpcMap.contains(spawnId)) { continue; } - spawnBlockNpc_t &sb = it.second; - if (!sb.npcType->canSpawn(sb.pos)) { - sb.lastSpawnNpc = OTSYS_TIME(); + auto &[pos, npcType, lastSpawnNpc, mapInterval, direction] = npcInfo; + if (!npcType->canSpawn(pos)) { + lastSpawnNpc = OTSYS_TIME(); continue; } - if (OTSYS_TIME() >= sb.lastSpawnNpc + sb.interval) { - if (findPlayer(sb.pos)) { - sb.lastSpawnNpc = OTSYS_TIME(); + if (OTSYS_TIME() >= lastSpawnNpc + mapInterval) { + if (findPlayer(pos)) { + lastSpawnNpc = OTSYS_TIME(); continue; } - scheduleSpawnNpc(spawnId, sb, 3 * NONBLOCKABLE_SPAWN_NPC_INTERVAL); + scheduleSpawnNpc(spawnId, npcInfo, 3 * NONBLOCKABLE_SPAWN_NPC_INTERVAL); } } @@ -235,7 +240,7 @@ void SpawnNpc::cleanup() { auto it = spawnedNpcMap.begin(); while (it != spawnedNpcMap.end()) { uint32_t spawnId = it->first; - auto npc = it->second; + const auto &npc = it->second; if (npc->isRemoved()) { spawnNpcMap[spawnId].lastSpawnNpc = OTSYS_TIME(); it = spawnedNpcMap.erase(it); @@ -261,12 +266,12 @@ bool SpawnNpc::addNpc(const std::string &name, const Position &pos, Direction di sb.interval = scheduleInterval; sb.lastSpawnNpc = 0; - uint32_t spawnId = spawnNpcMap.size() + 1; + const uint32_t spawnId = spawnNpcMap.size() + 1; spawnNpcMap[spawnId] = sb; return true; } -void SpawnNpc::removeNpc(std::shared_ptr npc) { +void SpawnNpc::removeNpc(const std::shared_ptr &npc) { for (auto it = spawnedNpcMap.begin(), end = spawnedNpcMap.end(); it != end; ++it) { if (it->second == npc) { spawnedNpcMap.erase(it); diff --git a/src/creatures/npcs/spawns/spawn_npc.hpp b/src/creatures/npcs/spawns/spawn_npc.hpp index b0d0ab8622a..96c9597559f 100644 --- a/src/creatures/npcs/spawns/spawn_npc.hpp +++ b/src/creatures/npcs/spawns/spawn_npc.hpp @@ -23,18 +23,18 @@ struct spawnBlockNpc_t { Direction direction; }; -class SpawnNpc : public SharedObject { +class SpawnNpc final : public SharedObject { public: SpawnNpc(Position initPos, int32_t initRadius) : centerPos(initPos), radius(initRadius) { } - ~SpawnNpc(); + ~SpawnNpc() override; // non-copyable SpawnNpc(const SpawnNpc &) = delete; SpawnNpc &operator=(const SpawnNpc &) = delete; bool addNpc(const std::string &name, const Position &pos, Direction dir, uint32_t interval); - void removeNpc(std::shared_ptr npc); + void removeNpc(const std::shared_ptr &npc); uint32_t getInterval() const { return interval; @@ -44,7 +44,7 @@ class SpawnNpc : public SharedObject { void startSpawnNpcCheck(); void stopEvent(); - bool isInSpawnNpcZone(const Position &pos); + bool isInSpawnNpcZone(const Position &pos) const; void cleanup(); private: diff --git a/src/creatures/players/achievement/player_achievement.cpp b/src/creatures/players/achievement/player_achievement.cpp index 5a9c1f55858..a8ef3fefdb7 100644 --- a/src/creatures/players/achievement/player_achievement.cpp +++ b/src/creatures/players/achievement/player_achievement.cpp @@ -21,7 +21,7 @@ bool PlayerAchievement::add(uint16_t id, bool message /* = true*/, uint32_t time return false; } - const Achievement &achievement = g_game().getAchievementById(id); + const auto &achievement = g_game().getAchievementById(id); if (achievement.id == 0) { return false; } @@ -43,12 +43,12 @@ bool PlayerAchievement::remove(uint16_t id) { return false; } - Achievement achievement = g_game().getAchievementById(id); + const auto achievement = g_game().getAchievementById(id); if (achievement.id == 0) { return false; } - if (auto it = std::find_if(m_achievementsUnlocked.begin(), m_achievementsUnlocked.end(), [id](auto achievement_it) { + if (auto it = std::ranges::find_if(m_achievementsUnlocked, [id](auto achievement_it) { return achievement_it.first == id; }); it != m_achievementsUnlocked.end()) { @@ -67,7 +67,7 @@ bool PlayerAchievement::isUnlocked(uint16_t id) const { return false; } - if (auto it = std::find_if(m_achievementsUnlocked.begin(), m_achievementsUnlocked.end(), [id](auto achievement_it) { + if (auto it = std::ranges::find_if(m_achievementsUnlocked, [id](auto achievement_it) { return achievement_it.first == id; }); it != m_achievementsUnlocked.end()) { @@ -78,17 +78,17 @@ bool PlayerAchievement::isUnlocked(uint16_t id) const { } uint16_t PlayerAchievement::getPoints() const { - auto kvScoped = m_player.kv()->scoped("achievements")->get("points"); + const auto kvScoped = m_player.kv()->scoped("achievements")->get("points"); return kvScoped ? static_cast(kvScoped->getNumber()) : 0; } -void PlayerAchievement::addPoints(uint16_t toAddPoints) { - auto oldPoints = getPoints(); +void PlayerAchievement::addPoints(uint16_t toAddPoints) const { + const auto oldPoints = getPoints(); m_player.kv()->scoped("achievements")->set("points", oldPoints + toAddPoints); } -void PlayerAchievement::removePoints(uint16_t points) { - auto oldPoints = getPoints(); +void PlayerAchievement::removePoints(uint16_t points) const { + const auto oldPoints = getPoints(); m_player.kv()->scoped("achievements")->set("points", oldPoints - std::min(oldPoints, points)); } @@ -112,11 +112,11 @@ void PlayerAchievement::loadUnlockedAchievements() { } } -void PlayerAchievement::sendUnlockedSecretAchievements() { +void PlayerAchievement::sendUnlockedSecretAchievements() const { std::vector> achievementsUnlocked; uint16_t unlockedSecret = 0; for (const auto &[achievId, achievCreatedTime] : getUnlockedAchievements()) { - Achievement achievement = g_game().getAchievementById(achievId); + const auto &achievement = g_game().getAchievementById(achievId); if (achievement.id == 0) { continue; } diff --git a/src/creatures/players/achievement/player_achievement.hpp b/src/creatures/players/achievement/player_achievement.hpp index e0c027e5808..946be626e0e 100644 --- a/src/creatures/players/achievement/player_achievement.hpp +++ b/src/creatures/players/achievement/player_achievement.hpp @@ -15,8 +15,8 @@ class KV; struct Achievement { Achievement() = default; - std::string name; - std::string description; + std::string name {}; + std::string description {}; bool secret = false; @@ -33,11 +33,11 @@ class PlayerAchievement { bool remove(uint16_t id); [[nodiscard]] bool isUnlocked(uint16_t id) const; [[nodiscard]] uint16_t getPoints() const; - void addPoints(uint16_t toAddPoints); - void removePoints(uint16_t toRemovePoints); + void addPoints(uint16_t toAddPoints) const; + void removePoints(uint16_t toRemovePoints) const; [[nodiscard]] std::vector> getUnlockedAchievements() const; void loadUnlockedAchievements(); - void sendUnlockedSecretAchievements(); + void sendUnlockedSecretAchievements() const; const std::shared_ptr &getUnlockedKV(); private: diff --git a/src/creatures/players/cyclopedia/player_badge.cpp b/src/creatures/players/cyclopedia/player_badge.cpp index b509ef041e3..566de007549 100644 --- a/src/creatures/players/cyclopedia/player_badge.cpp +++ b/src/creatures/players/cyclopedia/player_badge.cpp @@ -8,7 +8,7 @@ */ #include "player_badge.hpp" - +#include "enums/player_cyclopedia.hpp" #include "creatures/players/player.hpp" #include "game/game.hpp" #include "kv/kv.hpp" @@ -23,7 +23,7 @@ bool PlayerBadge::hasBadge(uint8_t id) const { return false; } - if (auto it = std::find_if(m_badgesUnlocked.begin(), m_badgesUnlocked.end(), [id](auto badge_it) { + if (auto it = std::ranges::find_if(m_badgesUnlocked, [id](auto badge_it) { return badge_it.first.m_id == id; }); it != m_badgesUnlocked.end()) { @@ -107,16 +107,16 @@ const std::shared_ptr &PlayerBadge::getUnlockedKV() { } // Badge Calculate Functions -bool PlayerBadge::accountAge(uint8_t amount) { +bool PlayerBadge::accountAge(uint8_t amount) const { return std::floor(m_player.getLoyaltyPoints() / 365) >= amount; } -bool PlayerBadge::loyalty(uint8_t amount) { +bool PlayerBadge::loyalty(uint8_t amount) const { return m_player.getLoyaltyPoints() >= amount; } -std::vector> PlayerBadge::getPlayersInfoByAccount(std::shared_ptr acc) const { - auto [accountPlayers, error] = acc->getAccountPlayers(); +std::vector> PlayerBadge::getPlayersInfoByAccount(const std::shared_ptr &acc) const { + const auto [accountPlayers, error] = acc->getAccountPlayers(); if (error != enumToValue(AccountErrors_t::Ok) || accountPlayers.empty()) { return {}; } @@ -145,7 +145,7 @@ std::vector> PlayerBadge::getPlayersInfoByAccount(std::s return players; } -bool PlayerBadge::accountAllLevel(uint8_t amount) { +bool PlayerBadge::accountAllLevel(uint8_t amount) const { auto players = getPlayersInfoByAccount(m_player.getAccount()); uint16_t total = std::accumulate(players.begin(), players.end(), 0, [](uint16_t sum, const std::shared_ptr &player) { return sum + player->getLevel(); @@ -153,14 +153,14 @@ bool PlayerBadge::accountAllLevel(uint8_t amount) { return total >= amount; } -bool PlayerBadge::accountAllVocations(uint8_t amount) { +bool PlayerBadge::accountAllVocations(uint8_t amount) const { auto knight = false; auto paladin = false; auto druid = false; auto sorcerer = false; for (const auto &player : getPlayersInfoByAccount(m_player.getAccount())) { if (player->getLevel() >= amount) { - auto vocationEnum = player->getPlayerVocationEnum(); + const auto &vocationEnum = player->getPlayerVocationEnum(); if (vocationEnum == Vocation_t::VOCATION_KNIGHT_CIP) { knight = true; } else if (vocationEnum == Vocation_t::VOCATION_SORCERER_CIP) { @@ -175,12 +175,12 @@ bool PlayerBadge::accountAllVocations(uint8_t amount) { return knight && paladin && druid && sorcerer; } -bool PlayerBadge::tournamentParticipation(uint8_t skill) { +bool PlayerBadge::tournamentParticipation(uint8_t skill) const { // todo check if is used return false; } -bool PlayerBadge::tournamentPoints(uint8_t race) { +bool PlayerBadge::tournamentPoints(uint8_t race) const { // todo check if is used return false; } diff --git a/src/creatures/players/cyclopedia/player_badge.hpp b/src/creatures/players/cyclopedia/player_badge.hpp index 25eaea0666f..cc8135b41e4 100644 --- a/src/creatures/players/cyclopedia/player_badge.hpp +++ b/src/creatures/players/cyclopedia/player_badge.hpp @@ -9,16 +9,16 @@ #pragma once -#include "enums/player_cyclopedia.hpp" - class Player; class KV; class Account; +enum class CyclopediaBadge_t : uint8_t; + struct Badge { uint8_t m_id = 0; - CyclopediaBadge_t m_type; - std::string m_name; + CyclopediaBadge_t m_type {}; + std::string m_name {}; uint16_t m_amount = 0; Badge() = default; @@ -31,14 +31,12 @@ struct Badge { } }; -namespace std { - template <> - struct hash { - std::size_t operator()(const Badge &b) const { - return hash()(b.m_id); - } - }; -} +template <> +struct std::hash { + std::size_t operator()(const Badge &b) const noexcept { + return hash()(b.m_id); + } +}; class PlayerBadge { public: @@ -51,13 +49,13 @@ class PlayerBadge { const std::shared_ptr &getUnlockedKV(); // Badge Calculate Functions - bool accountAge(uint8_t amount); - bool loyalty(uint8_t amount); - std::vector> getPlayersInfoByAccount(std::shared_ptr acc) const; - bool accountAllLevel(uint8_t amount); - bool accountAllVocations(uint8_t amount); - [[nodiscard]] bool tournamentParticipation(uint8_t skill); - [[nodiscard]] bool tournamentPoints(uint8_t race); + bool accountAge(uint8_t amount) const; + bool loyalty(uint8_t amount) const; + std::vector> getPlayersInfoByAccount(const std::shared_ptr &acc) const; + bool accountAllLevel(uint8_t amount) const; + bool accountAllVocations(uint8_t amount) const; + [[nodiscard]] bool tournamentParticipation(uint8_t skill) const; + [[nodiscard]] bool tournamentPoints(uint8_t race) const; private: // {badge ID, time when it was unlocked} diff --git a/src/creatures/players/cyclopedia/player_cyclopedia.cpp b/src/creatures/players/cyclopedia/player_cyclopedia.cpp index de34e1d8250..bf2093a83cb 100644 --- a/src/creatures/players/cyclopedia/player_cyclopedia.cpp +++ b/src/creatures/players/cyclopedia/player_cyclopedia.cpp @@ -19,28 +19,28 @@ PlayerCyclopedia::PlayerCyclopedia(Player &player) : m_player(player) { } -Summary PlayerCyclopedia::getSummary() { +Summary PlayerCyclopedia::getSummary() const { return { getAmount(Summary_t::PREY_CARDS), getAmount(Summary_t::INSTANT_REWARDS), getAmount(Summary_t::HIRELINGS) }; } -void PlayerCyclopedia::loadSummaryData() { - DBResult_ptr result = g_database().storeQuery(fmt::format("SELECT COUNT(*) as `count` FROM `player_hirelings` WHERE `player_id` = {}", m_player.getGUID())); - auto kvScoped = m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(static_cast(Summary_t::HIRELINGS))); +void PlayerCyclopedia::loadSummaryData() const { + const DBResult_ptr result = g_database().storeQuery(fmt::format("SELECT COUNT(*) as `count` FROM `player_hirelings` WHERE `player_id` = {}", m_player.getGUID())); + const auto kvScoped = m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(static_cast(Summary_t::HIRELINGS))); if (result && !kvScoped->get("amount").has_value()) { kvScoped->set("amount", result->getNumber("count")); } } -void PlayerCyclopedia::loadDeathHistory(uint16_t page, uint16_t entriesPerPage) { +void PlayerCyclopedia::loadDeathHistory(uint16_t page, uint16_t entriesPerPage) const { Benchmark bm_check; uint32_t offset = static_cast(page - 1) * entriesPerPage; - auto query = fmt::format("SELECT `time`, `level`, `killed_by`, `mostdamage_by`, (select count(*) FROM `player_deaths` WHERE `player_id` = {}) as `entries` FROM `player_deaths` WHERE `player_id` = {} AND `time` >= UNIX_TIMESTAMP(DATE_SUB(NOW(), INTERVAL 30 DAY)) ORDER BY `time` DESC LIMIT {}, {}", m_player.getGUID(), m_player.getGUID(), offset, entriesPerPage); + const auto query = fmt::format("SELECT `time`, `level`, `killed_by`, `mostdamage_by`, (select count(*) FROM `player_deaths` WHERE `player_id` = {}) as `entries` FROM `player_deaths` WHERE `player_id` = {} AND `time` >= UNIX_TIMESTAMP(DATE_SUB(NOW(), INTERVAL 30 DAY)) ORDER BY `time` DESC LIMIT {}, {}", m_player.getGUID(), m_player.getGUID(), offset, entriesPerPage); uint32_t playerID = m_player.getID(); - std::function callback = [playerID, page, entriesPerPage](const DBResult_ptr &result, bool) { - std::shared_ptr player = g_game().getPlayerByID(playerID); + const std::function callback = [playerID, page, entriesPerPage](const DBResult_ptr &result, bool) { + const auto &player = g_game().getPlayerByID(playerID); if (!player) { return; } @@ -81,16 +81,16 @@ void PlayerCyclopedia::loadDeathHistory(uint16_t page, uint16_t entriesPerPage) g_logger().debug("Loading death history from the player {} took {} milliseconds.", m_player.getName(), bm_check.duration()); } -void PlayerCyclopedia::loadRecentKills(uint16_t page, uint16_t entriesPerPage) { +void PlayerCyclopedia::loadRecentKills(uint16_t page, uint16_t entriesPerPage) const { Benchmark bm_check; const std::string &escapedName = g_database().escapeString(m_player.getName()); uint32_t offset = static_cast(page - 1) * entriesPerPage; - auto query = fmt::format("SELECT `d`.`time`, `d`.`killed_by`, `d`.`mostdamage_by`, `d`.`unjustified`, `d`.`mostdamage_unjustified`, `p`.`name`, (select count(*) FROM `player_deaths` WHERE ((`killed_by` = {} AND `is_player` = 1) OR (`mostdamage_by` = {} AND `mostdamage_is_player` = 1))) as `entries` FROM `player_deaths` AS `d` INNER JOIN `players` AS `p` ON `d`.`player_id` = `p`.`id` WHERE ((`d`.`killed_by` = {} AND `d`.`is_player` = 1) OR (`d`.`mostdamage_by` = {} AND `d`.`mostdamage_is_player` = 1)) AND `time` >= UNIX_TIMESTAMP(DATE_SUB(NOW(), INTERVAL 70 DAY)) ORDER BY `time` DESC LIMIT {}, {}", escapedName, escapedName, escapedName, escapedName, offset, entriesPerPage); + const auto query = fmt::format("SELECT `d`.`time`, `d`.`killed_by`, `d`.`mostdamage_by`, `d`.`unjustified`, `d`.`mostdamage_unjustified`, `p`.`name`, (select count(*) FROM `player_deaths` WHERE ((`killed_by` = {} AND `is_player` = 1) OR (`mostdamage_by` = {} AND `mostdamage_is_player` = 1))) as `entries` FROM `player_deaths` AS `d` INNER JOIN `players` AS `p` ON `d`.`player_id` = `p`.`id` WHERE ((`d`.`killed_by` = {} AND `d`.`is_player` = 1) OR (`d`.`mostdamage_by` = {} AND `d`.`mostdamage_is_player` = 1)) AND `time` >= UNIX_TIMESTAMP(DATE_SUB(NOW(), INTERVAL 70 DAY)) ORDER BY `time` DESC LIMIT {}, {}", escapedName, escapedName, escapedName, escapedName, offset, entriesPerPage); uint32_t playerID = m_player.getID(); - std::function callback = [playerID, page, entriesPerPage](const DBResult_ptr &result, bool) { - std::shared_ptr player = g_game().getPlayerByID(playerID); + const std::function callback = [playerID, page, entriesPerPage](const DBResult_ptr &result, bool) { + const auto &player = g_game().getPlayerByID(playerID); if (!player) { return; } @@ -133,7 +133,7 @@ void PlayerCyclopedia::loadRecentKills(uint16_t page, uint16_t entriesPerPage) { g_logger().debug("Loading recent kills from the player {} took {} milliseconds.", m_player.getName(), bm_check.duration()); } -void PlayerCyclopedia::updateStoreSummary(uint8_t type, uint16_t amount, const std::string &id) { +void PlayerCyclopedia::updateStoreSummary(uint8_t type, uint16_t amount, const std::string &id) const { switch (type) { case Summary_t::HOUSE_ITEMS: case Summary_t::BLESSINGS: @@ -150,35 +150,35 @@ void PlayerCyclopedia::updateStoreSummary(uint8_t type, uint16_t amount, const s } } -uint16_t PlayerCyclopedia::getAmount(uint8_t type) { - auto kvScope = m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(type))->get("amount"); +uint16_t PlayerCyclopedia::getAmount(uint8_t type) const { + const auto kvScope = m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(type))->get("amount"); return static_cast(kvScope ? kvScope->getNumber() : 0); } -void PlayerCyclopedia::updateAmount(uint8_t type, uint16_t amount) { - auto oldAmount = getAmount(type); +void PlayerCyclopedia::updateAmount(uint8_t type, uint16_t amount) const { + const auto oldAmount = getAmount(type); m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(type))->set("amount", oldAmount + amount); } std::map PlayerCyclopedia::getResult(uint8_t type) const { - auto kvScope = m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(type)); + const auto kvScope = m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(type)); std::map result; // ID, amount for (const auto &scope : kvScope->keys()) { - size_t pos = scope.find('.'); + const size_t &pos = scope.find('.'); if (pos == std::string::npos) { g_logger().error("[{}] Invalid key format: {}", __FUNCTION__, scope); continue; } std::string id = scope.substr(0, pos); - auto amount = kvScope->scoped(id)->get("amount"); + const auto amount = kvScope->scoped(id)->get("amount"); result.emplace(std::stoll(id), static_cast(amount ? amount->getNumber() : 0)); } return result; } -void PlayerCyclopedia::insertValue(uint8_t type, uint16_t amount, const std::string &id) { +void PlayerCyclopedia::insertValue(uint8_t type, uint16_t amount, const std::string &id) const { auto result = getResult(type); - auto it = result.find(std::stoll(id)); + const auto it = result.find(std::stoll(id)); auto oldAmount = (it != result.end() ? it->second : 0); auto newAmount = oldAmount + amount; m_player.kv()->scoped("summary")->scoped(g_game().getSummaryKeyByType(type))->scoped(id)->set("amount", newAmount); diff --git a/src/creatures/players/cyclopedia/player_cyclopedia.hpp b/src/creatures/players/cyclopedia/player_cyclopedia.hpp index 32c446cc368..0f399af03b2 100644 --- a/src/creatures/players/cyclopedia/player_cyclopedia.hpp +++ b/src/creatures/players/cyclopedia/player_cyclopedia.hpp @@ -9,9 +9,6 @@ #pragma once -#include "creatures/creatures_definitions.hpp" -#include "enums/player_cyclopedia.hpp" - class Player; class KV; @@ -28,18 +25,18 @@ class PlayerCyclopedia { public: explicit PlayerCyclopedia(Player &player); - Summary getSummary(); + Summary getSummary() const; - void loadSummaryData(); - void loadDeathHistory(uint16_t page, uint16_t entriesPerPage); - void loadRecentKills(uint16_t page, uint16_t entriesPerPage); + void loadSummaryData() const; + void loadDeathHistory(uint16_t page, uint16_t entriesPerPage) const; + void loadRecentKills(uint16_t page, uint16_t entriesPerPage) const; - void updateStoreSummary(uint8_t type, uint16_t amount = 1, const std::string &id = ""); - uint16_t getAmount(uint8_t type); - void updateAmount(uint8_t type, uint16_t amount = 1); + void updateStoreSummary(uint8_t type, uint16_t amount = 1, const std::string &id = "") const; + uint16_t getAmount(uint8_t type) const; + void updateAmount(uint8_t type, uint16_t amount = 1) const; [[nodiscard]] std::map getResult(uint8_t type) const; - void insertValue(uint8_t type, uint16_t amount = 1, const std::string &id = ""); + void insertValue(uint8_t type, uint16_t amount = 1, const std::string &id = "") const; private: Player &m_player; diff --git a/src/creatures/players/cyclopedia/player_title.cpp b/src/creatures/players/cyclopedia/player_title.cpp index 38e4e6428d0..5bbe8252fba 100644 --- a/src/creatures/players/cyclopedia/player_title.cpp +++ b/src/creatures/players/cyclopedia/player_title.cpp @@ -12,6 +12,7 @@ #include "creatures/players/player.hpp" #include "game/game.hpp" #include "kv/kv.hpp" +#include "enums/account_group_type.hpp" PlayerTitle::PlayerTitle(Player &player) : m_player(player) { } @@ -21,7 +22,7 @@ bool PlayerTitle::isTitleUnlocked(uint8_t id) const { return false; } - if (auto it = std::find_if(m_titlesUnlocked.begin(), m_titlesUnlocked.end(), [id](auto title_it) { + if (auto it = std::ranges::find_if(m_titlesUnlocked, [id](auto title_it) { return title_it.first.m_id == id; }); it != m_titlesUnlocked.end()) { @@ -63,7 +64,7 @@ void PlayerTitle::remove(const Title &title) { return; } - auto it = std::find_if(m_titlesUnlocked.begin(), m_titlesUnlocked.end(), [id](auto title_it) { + auto it = std::ranges::find_if(m_titlesUnlocked, [id](auto title_it) { return title_it.first.m_id == id; }); @@ -82,21 +83,21 @@ const std::vector> &PlayerTitle::getUnlockedTitles() } uint8_t PlayerTitle::getCurrentTitle() const { - auto title = m_player.kv()->scoped("titles")->get("current-title"); + const auto title = m_player.kv()->scoped("titles")->get("current-title"); return title ? static_cast(title->getNumber()) : 0; } -void PlayerTitle::setCurrentTitle(uint8_t id) { +void PlayerTitle::setCurrentTitle(uint8_t id) const { m_player.kv()->scoped("titles")->set("current-title", id != 0 && isTitleUnlocked(id) ? id : 0); } -std::string PlayerTitle::getCurrentTitleName() { - auto currentTitle = getCurrentTitle(); +std::string PlayerTitle::getCurrentTitleName() const { + const auto currentTitle = getCurrentTitle(); if (currentTitle == 0) { return ""; } - auto title = g_game().getTitleById(currentTitle); + const auto &title = g_game().getTitleById(currentTitle); if (title.m_id == 0) { return ""; } @@ -176,11 +177,11 @@ const std::shared_ptr &PlayerTitle::getUnlockedKV() { } // Title Calculate Functions -bool PlayerTitle::checkGold(uint32_t amount) { +bool PlayerTitle::checkGold(uint32_t amount) const { return m_player.getBankBalance() >= amount; } -bool PlayerTitle::checkMount(uint32_t amount) { +bool PlayerTitle::checkMount(uint32_t amount) const { uint8_t total = 0; for (const auto &mount : g_game().mounts.getMounts()) { if (m_player.hasMount(mount)) { @@ -190,15 +191,15 @@ bool PlayerTitle::checkMount(uint32_t amount) { return total >= amount; } -bool PlayerTitle::checkOutfit(uint32_t amount) { +bool PlayerTitle::checkOutfit(uint32_t amount) const { return m_player.outfits.size() >= amount; } -bool PlayerTitle::checkLevel(uint32_t amount) { +bool PlayerTitle::checkLevel(uint32_t amount) const { return m_player.getLevel() >= amount; } -bool PlayerTitle::checkHighscore(uint8_t skill) { +bool PlayerTitle::checkHighscore(uint8_t skill) const { Database &db = Database::getInstance(); std::string query; std::string fieldCheck = "id"; @@ -226,7 +227,7 @@ bool PlayerTitle::checkHighscore(uint8_t skill) { break; } - DBResult_ptr result = db.storeQuery(query); + const DBResult_ptr result = db.storeQuery(query); if (!result) { return false; } @@ -237,7 +238,7 @@ bool PlayerTitle::checkHighscore(uint8_t skill) { return resultValue == m_player.getGUID(); } -bool PlayerTitle::checkBestiary(const std::string &name, uint16_t race, bool isBoss /* = false*/, uint32_t amount) { +bool PlayerTitle::checkBestiary(const std::string &name, uint16_t race, bool isBoss /* = false*/, uint32_t amount) const { if (race == 0) { if (name == "Executioner") { // todo check if player has unlocked all bestiary @@ -253,23 +254,23 @@ bool PlayerTitle::checkBestiary(const std::string &name, uint16_t race, bool isB return m_player.isCreatureUnlockedOnTaskHunting(g_monsters().getMonsterTypeByRaceId(race, isBoss)); } -bool PlayerTitle::checkLoginStreak(uint32_t amount) { - auto streakKV = m_player.kv()->scoped("daily-reward")->get("streak"); +bool PlayerTitle::checkLoginStreak(uint32_t amount) const { + const auto streakKV = m_player.kv()->scoped("daily-reward")->get("streak"); return streakKV && streakKV.has_value() && static_cast(streakKV->getNumber()) >= amount; } -bool PlayerTitle::checkTask(uint32_t amount) { +bool PlayerTitle::checkTask(uint32_t amount) const { return m_player.getTaskHuntingPoints() >= amount; } -bool PlayerTitle::checkMap(uint32_t amount) { +bool PlayerTitle::checkMap(uint32_t amount) const { // todo cyclopledia return false; } -bool PlayerTitle::checkOther(const std::string &name) { +bool PlayerTitle::checkOther(const std::string &name) const { if (name == "Guild Leader") { - auto rank = m_player.getGuildRank(); + const auto &rank = m_player.getGuildRank(); return rank && rank->level == 3; } else if (name == "Proconsul of Iksupan") { // Win Ancient Aucar Outfits complete so fight with Atab and be teleported to the arena. diff --git a/src/creatures/players/cyclopedia/player_title.hpp b/src/creatures/players/cyclopedia/player_title.hpp index 0530fcc083d..c3098f80159 100644 --- a/src/creatures/players/cyclopedia/player_title.hpp +++ b/src/creatures/players/cyclopedia/player_title.hpp @@ -9,11 +9,8 @@ #pragma once -#include - #include "creatures/creatures_definitions.hpp" #include "enums/player_cyclopedia.hpp" -#include "enums/account_group_type.hpp" class Player; class KV; @@ -60,14 +57,12 @@ struct Title { } }; -namespace std { - template <> - struct hash { - std::size_t operator()(const Title &t) const { - return hash<uint8_t>()(t.m_id); - } - }; -} +template <> +struct std::hash<Title> { + std::size_t operator()(const Title &t) const noexcept { + return hash<uint8_t>()(t.m_id); + } +}; class PlayerTitle { public: @@ -78,24 +73,24 @@ class PlayerTitle { void remove(const Title &title); const std::vector<std::pair<Title, uint32_t>> &getUnlockedTitles(); [[nodiscard]] uint8_t getCurrentTitle() const; - void setCurrentTitle(uint8_t id); - std::string getCurrentTitleName(); + void setCurrentTitle(uint8_t id) const; + std::string getCurrentTitleName() const; static const std::string &getNameBySex(PlayerSex_t sex, const std::string &male, const std::string &female); void checkAndUpdateNewTitles(); void loadUnlockedTitles(); const std::shared_ptr<KV> &getUnlockedKV(); // Title Calculate Functions - bool checkGold(uint32_t amount); - bool checkMount(uint32_t amount); - bool checkOutfit(uint32_t amount); - bool checkLevel(uint32_t amount); - bool checkHighscore(uint8_t skill); - bool checkBestiary(const std::string &name, uint16_t race, bool isBoss = false, uint32_t amount = 0); - bool checkLoginStreak(uint32_t amount); - bool checkTask(uint32_t amount); - bool checkMap(uint32_t amount); - bool checkOther(const std::string &name); + bool checkGold(uint32_t amount) const; + bool checkMount(uint32_t amount) const; + bool checkOutfit(uint32_t amount) const; + bool checkLevel(uint32_t amount) const; + bool checkHighscore(uint8_t skill) const; + bool checkBestiary(const std::string &name, uint16_t race, bool isBoss = false, uint32_t amount = 0) const; + bool checkLoginStreak(uint32_t amount) const; + bool checkTask(uint32_t amount) const; + bool checkMap(uint32_t amount) const; + bool checkOther(const std::string &name) const; private: // {title ID, time when it was unlocked} diff --git a/src/creatures/players/grouping/familiars.cpp b/src/creatures/players/grouping/familiars.cpp index 49394714997..fba87d88678 100644 --- a/src/creatures/players/grouping/familiars.cpp +++ b/src/creatures/players/grouping/familiars.cpp @@ -26,21 +26,21 @@ bool Familiars::reload() { bool Familiars::loadFromXml() { pugi::xml_document doc; - auto folder = g_configManager().getString(CORE_DIRECTORY) + "/XML/familiars.xml"; - pugi::xml_parse_result result = doc.load_file(folder.c_str()); + const auto folder = g_configManager().getString(CORE_DIRECTORY) + "/XML/familiars.xml"; + const pugi::xml_parse_result result = doc.load_file(folder.c_str()); if (!result) { g_logger().error("Failed to load Familiars"); printXMLError(__FUNCTION__, folder, result); return false; } - for (auto familiarsNode : doc.child("familiars").children()) { + for (const auto &familiarsNode : doc.child("familiars").children()) { pugi::xml_attribute attr; - if ((attr = familiarsNode.attribute("enabled")) && !attr.as_bool()) { + if ((attr = familiarsNode.attribute("enabled") && !attr.as_bool())) { continue; } - if (!(attr = familiarsNode.attribute("vocation"))) { + if (!((attr = familiarsNode.attribute("vocation")))) { g_logger().warn("[Familiars::loadFromXml] - Missing familiar vocation."); continue; } @@ -72,7 +72,7 @@ bool Familiars::loadFromXml() { } std::shared_ptr<Familiar> Familiars::getFamiliarByLookType(uint16_t vocation, uint16_t lookType) const { - if (auto it = std::find_if(familiars[vocation].begin(), familiars[vocation].end(), [lookType](auto familiar_it) { + if (auto it = std::ranges::find_if(familiars[vocation], [lookType](const auto &familiar_it) { return familiar_it->lookType == lookType; }); it != familiars[vocation].end()) { diff --git a/src/creatures/players/grouping/familiars.hpp b/src/creatures/players/grouping/familiars.hpp index 9eda7d95ba2..e00e1fb8884 100644 --- a/src/creatures/players/grouping/familiars.hpp +++ b/src/creatures/players/grouping/familiars.hpp @@ -10,7 +10,6 @@ #pragma once #include "declarations.hpp" -#include "lib/di/container.hpp" struct FamiliarEntry { constexpr explicit FamiliarEntry(uint16_t initLookType) : diff --git a/src/creatures/players/grouping/groups.cpp b/src/creatures/players/grouping/groups.cpp index d1a9568cb11..c6788dc6a13 100644 --- a/src/creatures/players/grouping/groups.cpp +++ b/src/creatures/players/grouping/groups.cpp @@ -18,7 +18,7 @@ namespace ParsePlayerFlagMap { phmap::flat_hash_map<std::string, PlayerFlags_t> initParsePlayerFlagMap() { phmap::flat_hash_map<std::string, PlayerFlags_t> map; // Iterate through all values of the PlayerFlags_t enumeration - for (auto value : magic_enum::enum_values<PlayerFlags_t>()) { + for (const auto &value : magic_enum::enum_values<PlayerFlags_t>()) { // Get the string representation of the current enumeration value std::string name(magic_enum::enum_name(value).data()); // Convert the string to lowercase @@ -48,8 +48,8 @@ bool Groups::reload() { } void parseGroupFlags(Group &group, const pugi::xml_node &groupNode) { - if (pugi::xml_node node = groupNode.child("flags")) { - for (auto flagNode : node.children()) { + if (const pugi::xml_node node = groupNode.child("flags")) { + for (const auto &flagNode : node.children()) { pugi::xml_attribute attr = flagNode.first_attribute(); if (!attr || !attr.as_bool()) { continue; @@ -67,24 +67,24 @@ void parseGroupFlags(Group &group, const pugi::xml_node &groupNode) { bool Groups::load() { pugi::xml_document doc; - auto folder = g_configManager().getString(CORE_DIRECTORY) + "/XML/groups.xml"; - pugi::xml_parse_result result = doc.load_file(folder.c_str()); + const auto folder = g_configManager().getString(CORE_DIRECTORY) + "/XML/groups.xml"; + const pugi::xml_parse_result result = doc.load_file(folder.c_str()); if (!result) { printXMLError(__FUNCTION__, folder, result); return false; } - for (auto groupNode : doc.child("groups").children()) { + for (const auto &groupNode : doc.child("groups").children()) { Group group; group.id = pugi::cast<uint32_t>(groupNode.attribute("id").value()); group.name = groupNode.attribute("name").as_string(); group.access = groupNode.attribute("access").as_bool(); group.maxDepotItems = pugi::cast<uint32_t>(groupNode.attribute("maxdepotitems").value()); group.maxVipEntries = pugi::cast<uint32_t>(groupNode.attribute("maxvipentries").value()); - auto flagsInt = static_cast<uint8_t>(groupNode.attribute("flags").as_uint()); + const auto flagsInt = static_cast<uint8_t>(groupNode.attribute("flags").as_uint()); std::bitset<magic_enum::enum_integer(PlayerFlags_t::FlagLast)> flags(flagsInt); for (uint8_t i = 0; i < getFlagNumber(PlayerFlags_t::FlagLast); i++) { - PlayerFlags_t flag = getFlagFromNumber(i); + const PlayerFlags_t flag = getFlagFromNumber(i); group.flags[i] = flags[Groups::getFlagNumber(flag)]; } @@ -98,7 +98,7 @@ bool Groups::load() { } std::shared_ptr<Group> Groups::getGroup(uint16_t id) const { - if (auto it = std::find_if(groups_vector.begin(), groups_vector.end(), [id](auto group_it) { + if (auto it = std::ranges::find_if(groups_vector, [id](auto group_it) { return group_it->id == id; }); it != groups_vector.end()) { diff --git a/src/creatures/players/grouping/guild.cpp b/src/creatures/players/grouping/guild.cpp index 240593c1047..a9bac7989ac 100644 --- a/src/creatures/players/grouping/guild.cpp +++ b/src/creatures/players/grouping/guild.cpp @@ -11,7 +11,7 @@ #include "game/game.hpp" void Guild::addMember(const std::shared_ptr<Player> &player) { - membersOnline.push_back(player); + membersOnline.emplace_back(player); for (const auto &member : getMembersOnline()) { g_game().updatePlayerHelpers(member); } @@ -30,8 +30,8 @@ void Guild::removeMember(const std::shared_ptr<Player> &player) { } } -GuildRank_ptr Guild::getRankById(uint32_t rankId) { - for (auto rank : ranks) { +GuildRank_ptr Guild::getRankById(uint32_t rankId) const { + for (const auto &rank : ranks) { if (rank->id == rankId) { return rank; } @@ -40,7 +40,7 @@ GuildRank_ptr Guild::getRankById(uint32_t rankId) { } GuildRank_ptr Guild::getRankByName(const std::string &guildName) const { - for (auto rank : ranks) { + for (const auto &rank : ranks) { if (rank->name == guildName) { return rank; } @@ -49,7 +49,7 @@ GuildRank_ptr Guild::getRankByName(const std::string &guildName) const { } GuildRank_ptr Guild::getRankByLevel(uint8_t level) const { - for (auto rank : ranks) { + for (const auto &rank : ranks) { if (rank->level == level) { return rank; } diff --git a/src/creatures/players/grouping/guild.hpp b/src/creatures/players/grouping/guild.hpp index 82b0a7367ea..f4c3f605ac6 100644 --- a/src/creatures/players/grouping/guild.hpp +++ b/src/creatures/players/grouping/guild.hpp @@ -24,7 +24,7 @@ struct GuildRank { using GuildRank_ptr = std::shared_ptr<GuildRank>; -class Guild : public Bankable { +class Guild final : public Bankable { public: Guild(uint32_t initId, std::string initName) : name(std::move(initName)), id(initId) { } @@ -72,7 +72,7 @@ class Guild : public Bankable { return ranks; } - GuildRank_ptr getRankById(uint32_t id); + GuildRank_ptr getRankById(uint32_t id) const; GuildRank_ptr getRankByName(const std::string &name) const; GuildRank_ptr getRankByLevel(uint8_t level) const; void addRank(uint32_t id, const std::string &name, uint8_t level); diff --git a/src/creatures/players/grouping/party.cpp b/src/creatures/players/grouping/party.cpp index 3a5d4d78183..0098236bfa8 100644 --- a/src/creatures/players/grouping/party.cpp +++ b/src/creatures/players/grouping/party.cpp @@ -7,15 +7,13 @@ * Website: https://docs.opentibiabr.com/ */ -#include <utility> - #include "creatures/players/grouping/party.hpp" #include "game/game.hpp" #include "lua/creature/events.hpp" #include "lua/callbacks/event_callback.hpp" #include "lua/callbacks/events_callbacks.hpp" -std::shared_ptr<Party> Party::create(std::shared_ptr<Player> leader) { +std::shared_ptr<Party> Party::create(const std::shared_ptr<Player> &leader) { auto party = std::make_shared<Party>(); party->m_leader = leader; leader->setParty(party); @@ -34,7 +32,7 @@ void Party::disband() { return; } - auto currentLeader = getLeader(); + const auto ¤tLeader = getLeader(); if (!currentLeader) { return; } @@ -53,7 +51,7 @@ void Party::disband() { } inviteList.clear(); - auto members = getMembers(); + const auto &members = getMembers(); for (const auto &member : members) { member->setParty(nullptr); member->sendClosePrivate(CHANNEL_PARTY); @@ -75,12 +73,12 @@ void Party::disband() { membersData.clear(); } -bool Party::leaveParty(std::shared_ptr<Player> player, bool forceRemove /* = false */) { +bool Party::leaveParty(const std::shared_ptr<Player> &player, bool forceRemove /* = false */) { if (!player) { return false; } - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return false; } @@ -123,7 +121,7 @@ bool Party::leaveParty(std::shared_ptr<Player> player, bool forceRemove /* = fal } // since we already passed the leadership, we remove the player from the list - auto it = std::find(memberList.begin(), memberList.end(), player); + auto it = std::ranges::find(memberList, player); if (it != memberList.end()) { memberList.erase(it); } @@ -162,14 +160,14 @@ bool Party::leaveParty(std::shared_ptr<Player> player, bool forceRemove /* = fal return true; } -bool Party::passPartyLeadership(std::shared_ptr<Player> player) { - auto leader = getLeader(); +bool Party::passPartyLeadership(const std::shared_ptr<Player> &player) { + const auto &leader = getLeader(); if (!leader || !player || leader == player || player->getParty().get() != this) { return false; } // Remove it before to broadcast the message correctly - auto it = std::find(memberList.begin(), memberList.end(), player); + auto it = std::ranges::find(memberList, player); if (it != memberList.end()) { memberList.erase(it); } @@ -178,7 +176,7 @@ bool Party::passPartyLeadership(std::shared_ptr<Player> player) { ss << player->getName() << " is now the leader of the party."; broadcastPartyMessage(MESSAGE_PARTY_MANAGEMENT, ss.str(), true); - auto oldLeader = leader; + const auto &oldLeader = leader; m_leader = player; memberList.insert(memberList.begin(), oldLeader); @@ -204,7 +202,7 @@ bool Party::passPartyLeadership(std::shared_ptr<Player> player) { } bool Party::joinParty(const std::shared_ptr<Player> &player) { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return false; } @@ -217,7 +215,7 @@ bool Party::joinParty(const std::shared_ptr<Player> &player) { return false; } - auto it = std::find(inviteList.begin(), inviteList.end(), player); + auto it = std::ranges::find(inviteList, player); if (it == inviteList.end()) { return false; } @@ -243,7 +241,7 @@ bool Party::joinParty(const std::shared_ptr<Player> &player) { leader->sendPlayerPartyIcons(player); player->sendPlayerPartyIcons(leader); - memberList.push_back(player); + memberList.emplace_back(player); g_game().updatePlayerHelpers(player); @@ -261,12 +259,12 @@ bool Party::joinParty(const std::shared_ptr<Player> &player) { } bool Party::removeInvite(const std::shared_ptr<Player> &player, bool removeFromPlayer /* = true*/) { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return false; } - auto it = std::find(inviteList.begin(), inviteList.end(), player); + auto it = std::ranges::find(inviteList, player); if (it == inviteList.end()) { return false; } @@ -294,7 +292,7 @@ bool Party::removeInvite(const std::shared_ptr<Player> &player, bool removeFromP } void Party::revokeInvitation(const std::shared_ptr<Player> &player) { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return; } @@ -311,7 +309,7 @@ void Party::revokeInvitation(const std::shared_ptr<Player> &player) { } bool Party::invitePlayer(const std::shared_ptr<Player> &player) { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return false; } @@ -331,7 +329,7 @@ bool Party::invitePlayer(const std::shared_ptr<Player> &player) { leader->sendTextMessage(MESSAGE_PARTY_MANAGEMENT, ss.str()); - inviteList.push_back(player); + inviteList.emplace_back(player); for (const auto &member : getMembers()) { g_game().updatePlayerHelpers(member); @@ -351,15 +349,15 @@ bool Party::invitePlayer(const std::shared_ptr<Player> &player) { } bool Party::isPlayerInvited(const std::shared_ptr<Player> &player) const { - return std::find(inviteList.begin(), inviteList.end(), player) != inviteList.end(); + return std::ranges::find(inviteList, player) != inviteList.end(); } void Party::updateAllPartyIcons() { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return; } - auto members = getMembers(); + const auto &members = getMembers(); for (const auto &member : members) { for (const auto &otherMember : members) { member->sendPartyCreatureShield(otherMember); @@ -373,7 +371,7 @@ void Party::updateAllPartyIcons() { } void Party::broadcastPartyMessage(MessageClasses msgClass, const std::string &msg, bool sendToInvitations /*= false*/) { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return; } @@ -392,7 +390,7 @@ void Party::broadcastPartyMessage(MessageClasses msgClass, const std::string &ms void Party::updateSharedExperience() { if (sharedExpActive) { - bool result = getSharedExperienceStatus() == SHAREDEXP_OK; + const bool result = getSharedExperienceStatus() == SHAREDEXP_OK; if (result != sharedExpEnabled) { sharedExpEnabled = result; updateAllPartyIcons(); @@ -400,7 +398,7 @@ void Party::updateSharedExperience() { } } -const char* Party::getSharedExpReturnMessage(SharedExpStatus_t value) { +const char* Party::getSharedExpReturnMessage(SharedExpStatus_t value) const { switch (value) { case SHAREDEXP_OK: return "Shared Experience is now active."; @@ -417,8 +415,8 @@ const char* Party::getSharedExpReturnMessage(SharedExpStatus_t value) { } } -bool Party::setSharedExperience(std::shared_ptr<Player> player, bool newSharedExpActive, bool silent /*= false*/) { - auto leader = getLeader(); +bool Party::setSharedExperience(const std::shared_ptr<Player> &player, bool newSharedExpActive, bool silent /*= false*/) { + const auto &leader = getLeader(); if (!player || leader != player) { return false; } @@ -430,7 +428,7 @@ bool Party::setSharedExperience(std::shared_ptr<Player> player, bool newSharedEx this->sharedExpActive = newSharedExpActive; if (newSharedExpActive) { - SharedExpStatus_t sharedExpStatus = getSharedExperienceStatus(); + const SharedExpStatus_t &sharedExpStatus = getSharedExperienceStatus(); this->sharedExpEnabled = sharedExpStatus == SHAREDEXP_OK; if (!silent) { leader->sendTextMessage(MESSAGE_PARTY_MANAGEMENT, getSharedExpReturnMessage(sharedExpStatus)); @@ -445,8 +443,8 @@ bool Party::setSharedExperience(std::shared_ptr<Player> player, bool newSharedEx return true; } -void Party::shareExperience(uint64_t experience, std::shared_ptr<Creature> target /* = nullptr*/) { - auto leader = getLeader(); +void Party::shareExperience(uint64_t experience, const std::shared_ptr<Creature> &target /* = nullptr*/) { + const auto &leader = getLeader(); if (!leader) { return; } @@ -461,12 +459,12 @@ void Party::shareExperience(uint64_t experience, std::shared_ptr<Creature> targe leader->onGainSharedExperience(shareExperience, target); } -bool Party::canUseSharedExperience(std::shared_ptr<Player> player) { - return getMemberSharedExperienceStatus(std::move(player)) == SHAREDEXP_OK; +bool Party::canUseSharedExperience(const std::shared_ptr<Player> &player) { + return getMemberSharedExperienceStatus(player) == SHAREDEXP_OK; } -SharedExpStatus_t Party::getMemberSharedExperienceStatus(std::shared_ptr<Player> player) { - auto leader = getLeader(); +SharedExpStatus_t Party::getMemberSharedExperienceStatus(const std::shared_ptr<Player> &player) { + const auto &leader = getLeader(); if (!leader) { return SHAREDEXP_EMPTYPARTY; } @@ -474,7 +472,7 @@ SharedExpStatus_t Party::getMemberSharedExperienceStatus(std::shared_ptr<Player> return SHAREDEXP_EMPTYPARTY; } - uint32_t minLevel = getMinLevel(); + const uint32_t minLevel = getMinLevel(); if (player->getLevel() < minLevel) { return SHAREDEXP_LEVELDIFFTOOLARGE; } @@ -496,7 +494,7 @@ float Party::shareRangeMultiplier() const { } uint32_t Party::getHighestLevel() { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return 0; } @@ -515,7 +513,7 @@ uint32_t Party::getMinLevel() { } uint32_t Party::getLowestLevel() { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return 0; } @@ -532,27 +530,27 @@ uint32_t Party::getMaxLevel() { return static_cast<uint32_t>(std::floor(static_cast<float>(getLowestLevel()) * shareRangeMultiplier())); } -bool Party::isPlayerActive(std::shared_ptr<Player> player) { +bool Party::isPlayerActive(const std::shared_ptr<Player> &player) { auto it = ticksMap.find(player->getID()); if (it == ticksMap.end()) { return false; } - uint64_t timeDiff = OTSYS_TIME() - it->second; + const uint64_t timeDiff = OTSYS_TIME() - it->second; return timeDiff <= 2 * 60 * 1000; } SharedExpStatus_t Party::getSharedExperienceStatus() { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return SHAREDEXP_EMPTYPARTY; } - SharedExpStatus_t leaderStatus = getMemberSharedExperienceStatus(leader); + const SharedExpStatus_t &leaderStatus = getMemberSharedExperienceStatus(leader); if (leaderStatus != SHAREDEXP_OK) { return leaderStatus; } for (const auto &member : getMembers()) { - SharedExpStatus_t memberStatus = getMemberSharedExperienceStatus(member); + const SharedExpStatus_t &memberStatus = getMemberSharedExperienceStatus(member); if (memberStatus != SHAREDEXP_OK) { return memberStatus; } @@ -560,14 +558,14 @@ SharedExpStatus_t Party::getSharedExperienceStatus() { return SHAREDEXP_OK; } -void Party::updatePlayerTicks(std::shared_ptr<Player> player, uint32_t points) { +void Party::updatePlayerTicks(const std::shared_ptr<Player> &player, uint32_t points) { if (points != 0 && !player->hasFlag(PlayerFlags_t::NotGainInFight)) { ticksMap[player->getID()] = OTSYS_TIME(); updateSharedExperience(); } } -void Party::clearPlayerPoints(std::shared_ptr<Player> player) { +void Party::clearPlayerPoints(const std::shared_ptr<Player> &player) { auto it = ticksMap.find(player->getID()); if (it != ticksMap.end()) { ticksMap.erase(it); @@ -576,18 +574,18 @@ void Party::clearPlayerPoints(std::shared_ptr<Player> player) { } bool Party::canOpenCorpse(uint32_t ownerId) const { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return false; } - if (std::shared_ptr<Player> player = g_game().getPlayerByID(ownerId)) { + if (const auto &player = g_game().getPlayerByID(ownerId)) { return leader->getID() == ownerId || player->getParty().get() == this; } return false; } -void Party::showPlayerStatus(std::shared_ptr<Player> player, std::shared_ptr<Player> member, bool showStatus) { +void Party::showPlayerStatus(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &member, bool showStatus) const { player->sendPartyCreatureShowStatus(member, showStatus); member->sendPartyCreatureShowStatus(player, showStatus); if (showStatus) { @@ -613,22 +611,22 @@ void Party::showPlayerStatus(std::shared_ptr<Player> player, std::shared_ptr<Pla } } -void Party::updatePlayerStatus(std::shared_ptr<Player> player) { - auto leader = getLeader(); +void Party::updatePlayerStatus(const std::shared_ptr<Player> &player) { + const auto &leader = getLeader(); if (!leader) { return; } - int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); + const int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); for (const auto &member : getMembers()) { - bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), member->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), member->getPosition()) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), member->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), member->getPosition()) <= maxDistance)); if (condition) { showPlayerStatus(player, member, true); } else { showPlayerStatus(player, member, false); } } - bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), leader->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), leader->getPosition()) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), leader->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), leader->getPosition()) <= maxDistance)); if (condition) { showPlayerStatus(player, leader, true); } else { @@ -636,17 +634,17 @@ void Party::updatePlayerStatus(std::shared_ptr<Player> player) { } } -void Party::updatePlayerStatus(std::shared_ptr<Player> player, const Position &oldPos, const Position &newPos) { - auto leader = getLeader(); +void Party::updatePlayerStatus(const std::shared_ptr<Player> &player, const Position &oldPos, const Position &newPos) { + const auto &leader = getLeader(); if (!leader) { return; } - int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); + const int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); if (maxDistance != 0) { for (const auto &member : getMembers()) { - bool condition1 = (Position::getDistanceX(oldPos, member->getPosition()) <= maxDistance && Position::getDistanceY(oldPos, member->getPosition()) <= maxDistance); - bool condition2 = (Position::getDistanceX(newPos, member->getPosition()) <= maxDistance && Position::getDistanceY(newPos, member->getPosition()) <= maxDistance); + const bool condition1 = Position::getDistanceX(oldPos, member->getPosition()) <= maxDistance && Position::getDistanceY(oldPos, member->getPosition()) <= maxDistance; + const bool condition2 = Position::getDistanceX(newPos, member->getPosition()) <= maxDistance && Position::getDistanceY(newPos, member->getPosition()) <= maxDistance; if (condition1 && !condition2) { showPlayerStatus(player, member, false); } else if (!condition1 && condition2) { @@ -654,8 +652,8 @@ void Party::updatePlayerStatus(std::shared_ptr<Player> player, const Position &o } } - bool condition1 = (Position::getDistanceX(oldPos, leader->getPosition()) <= maxDistance && Position::getDistanceY(oldPos, leader->getPosition()) <= maxDistance); - bool condition2 = (Position::getDistanceX(newPos, leader->getPosition()) <= maxDistance && Position::getDistanceY(newPos, leader->getPosition()) <= maxDistance); + const bool condition1 = Position::getDistanceX(oldPos, leader->getPosition()) <= maxDistance && Position::getDistanceY(oldPos, leader->getPosition()) <= maxDistance; + const bool condition2 = Position::getDistanceX(newPos, leader->getPosition()) <= maxDistance && Position::getDistanceY(newPos, leader->getPosition()) <= maxDistance; if (condition1 && !condition2) { showPlayerStatus(player, leader, false); } else if (!condition1 && condition2) { @@ -664,68 +662,68 @@ void Party::updatePlayerStatus(std::shared_ptr<Player> player, const Position &o } } -void Party::updatePlayerHealth(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint8_t healthPercent) { - auto leader = getLeader(); +void Party::updatePlayerHealth(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint8_t healthPercent) { + const auto &leader = getLeader(); if (!leader) { return; } - int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); - auto playerPosition = player->getPosition(); - auto leaderPosition = leader->getPosition(); + const int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); + const auto playerPosition = player->getPosition(); + const auto leaderPosition = leader->getPosition(); for (const auto &member : getMembers()) { auto memberPosition = member->getPosition(); - bool condition = (maxDistance == 0 || (Position::getDistanceX(playerPosition, memberPosition) <= maxDistance && Position::getDistanceY(playerPosition, memberPosition) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(playerPosition, memberPosition) <= maxDistance && Position::getDistanceY(playerPosition, memberPosition) <= maxDistance)); if (condition) { member->sendPartyCreatureHealth(target, healthPercent); } } - bool condition = (maxDistance == 0 || (Position::getDistanceX(playerPosition, leaderPosition) <= maxDistance && Position::getDistanceY(playerPosition, leaderPosition) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(playerPosition, leaderPosition) <= maxDistance && Position::getDistanceY(playerPosition, leaderPosition) <= maxDistance)); if (condition) { leader->sendPartyCreatureHealth(target, healthPercent); } } -void Party::updatePlayerMana(std::shared_ptr<Player> player, uint8_t manaPercent) { - auto leader = getLeader(); +void Party::updatePlayerMana(const std::shared_ptr<Player> &player, uint8_t manaPercent) { + const auto &leader = getLeader(); if (!leader) { return; } - int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); + const int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); for (const auto &member : getMembers()) { - bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), member->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), member->getPosition()) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), member->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), member->getPosition()) <= maxDistance)); if (condition) { member->sendPartyPlayerMana(player, manaPercent); } } - bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), leader->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), leader->getPosition()) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), leader->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), leader->getPosition()) <= maxDistance)); if (condition) { leader->sendPartyPlayerMana(player, manaPercent); } } -void Party::updatePlayerVocation(std::shared_ptr<Player> player) { - auto leader = getLeader(); +void Party::updatePlayerVocation(const std::shared_ptr<Player> &player) { + const auto &leader = getLeader(); if (!leader) { return; } - int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); + const int32_t maxDistance = g_configManager().getNumber(PARTY_LIST_MAX_DISTANCE); for (const auto &member : getMembers()) { - bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), member->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), member->getPosition()) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), member->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), member->getPosition()) <= maxDistance)); if (condition) { member->sendPartyPlayerVocation(player); } } - bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), leader->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), leader->getPosition()) <= maxDistance)); + const bool condition = (maxDistance == 0 || (Position::getDistanceX(player->getPosition(), leader->getPosition()) <= maxDistance && Position::getDistanceY(player->getPosition(), leader->getPosition()) <= maxDistance)); if (condition) { leader->sendPartyPlayerVocation(player); } } void Party::updateTrackerAnalyzer() { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return; } @@ -737,21 +735,21 @@ void Party::updateTrackerAnalyzer() { leader->updatePartyTrackerAnalyzer(); } -void Party::addPlayerLoot(std::shared_ptr<Player> player, std::shared_ptr<Item> item) { - auto leader = getLeader(); +void Party::addPlayerLoot(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) { + const auto &leader = getLeader(); if (!leader) { return; } - auto playerAnalyzer = getPlayerPartyAnalyzerStruct(player->getID()); + std::shared_ptr<PartyAnalyzer> playerAnalyzer = getPlayerPartyAnalyzerStruct(player->getID()); if (!playerAnalyzer) { playerAnalyzer = std::make_shared<PartyAnalyzer>(player->getID(), player->getName()); - membersData.push_back(playerAnalyzer); + membersData.emplace_back(playerAnalyzer); } uint32_t count = std::max<uint32_t>(1, item->getItemCount()); if (auto it = playerAnalyzer->lootMap.find(item->getID()); it != playerAnalyzer->lootMap.end()) { - (*it).second += count; + it->second += count; } else { playerAnalyzer->lootMap.insert({ item->getID(), count }); } @@ -759,14 +757,14 @@ void Party::addPlayerLoot(std::shared_ptr<Player> player, std::shared_ptr<Item> if (priceType == LEADER_PRICE) { playerAnalyzer->lootPrice += leader->getItemCustomPrice(item->getID()) * count; } else { - std::map<uint16_t, uint64_t> itemMap { { item->getID(), count } }; + const std::map<uint16_t, uint64_t> itemMap { { item->getID(), count } }; playerAnalyzer->lootPrice += g_game().getItemMarketPrice(itemMap, false); } updateTrackerAnalyzer(); } -void Party::addPlayerSupply(std::shared_ptr<Player> player, std::shared_ptr<Item> item) { - auto leader = getLeader(); +void Party::addPlayerSupply(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) { + const auto &leader = getLeader(); if (!leader) { return; } @@ -774,11 +772,11 @@ void Party::addPlayerSupply(std::shared_ptr<Player> player, std::shared_ptr<Item std::shared_ptr<PartyAnalyzer> playerAnalyzer = getPlayerPartyAnalyzerStruct(player->getID()); if (!playerAnalyzer) { playerAnalyzer = std::make_shared<PartyAnalyzer>(player->getID(), player->getName()); - membersData.push_back(playerAnalyzer); + membersData.emplace_back(playerAnalyzer); } if (auto it = playerAnalyzer->supplyMap.find(item->getID()); it != playerAnalyzer->supplyMap.end()) { - (*it).second += 1; + it->second += 1; } else { playerAnalyzer->supplyMap.insert({ item->getID(), 1 }); } @@ -786,28 +784,28 @@ void Party::addPlayerSupply(std::shared_ptr<Player> player, std::shared_ptr<Item if (priceType == LEADER_PRICE) { playerAnalyzer->supplyPrice += leader->getItemCustomPrice(item->getID(), true); } else { - std::map<uint16_t, uint64_t> itemMap { { item->getID(), 1 } }; + const std::map<uint16_t, uint64_t> itemMap { { item->getID(), 1 } }; playerAnalyzer->supplyPrice += g_game().getItemMarketPrice(itemMap, true); } updateTrackerAnalyzer(); } -void Party::addPlayerDamage(std::shared_ptr<Player> player, uint64_t amount) { - auto playerAnalyzer = getPlayerPartyAnalyzerStruct(player->getID()); +void Party::addPlayerDamage(const std::shared_ptr<Player> &player, uint64_t amount) { + std::shared_ptr<PartyAnalyzer> playerAnalyzer = getPlayerPartyAnalyzerStruct(player->getID()); if (!playerAnalyzer) { playerAnalyzer = std::make_shared<PartyAnalyzer>(player->getID(), player->getName()); - membersData.push_back(playerAnalyzer); + membersData.emplace_back(playerAnalyzer); } playerAnalyzer->damage += amount; updateTrackerAnalyzer(); } -void Party::addPlayerHealing(std::shared_ptr<Player> player, uint64_t amount) { - auto playerAnalyzer = getPlayerPartyAnalyzerStruct(player->getID()); +void Party::addPlayerHealing(const std::shared_ptr<Player> &player, uint64_t amount) { + std::shared_ptr<PartyAnalyzer> playerAnalyzer = getPlayerPartyAnalyzerStruct(player->getID()); if (!playerAnalyzer) { playerAnalyzer = std::make_shared<PartyAnalyzer>(player->getID(), player->getName()); - membersData.push_back(playerAnalyzer); + membersData.emplace_back(playerAnalyzer); } playerAnalyzer->healing += amount; @@ -815,7 +813,7 @@ void Party::addPlayerHealing(std::shared_ptr<Player> player, uint64_t amount) { } void Party::switchAnalyzerPriceType() { - auto leader = getLeader(); + const auto &leader = getLeader(); if (!leader) { return; } @@ -831,8 +829,8 @@ void Party::resetAnalyzer() { updateTrackerAnalyzer(); } -void Party::reloadPrices() { - auto leader = getLeader(); +void Party::reloadPrices() const { + const auto &leader = getLeader(); if (!leader) { return; } @@ -845,13 +843,13 @@ void Party::reloadPrices() { } analyzer->lootPrice = 0; - for (const auto it : analyzer->lootMap) { - analyzer->lootPrice += leader->getItemCustomPrice(it.first) * it.second; + for (const auto &[itemId, price] : analyzer->lootMap) { + analyzer->lootPrice += leader->getItemCustomPrice(itemId) * price; } analyzer->supplyPrice = 0; - for (const auto it : analyzer->supplyMap) { - analyzer->supplyPrice += leader->getItemCustomPrice(it.first, true) * it.second; + for (const auto &[itemId, price] : analyzer->supplyMap) { + analyzer->supplyPrice += leader->getItemCustomPrice(itemId, true) * price; } } } diff --git a/src/creatures/players/grouping/party.hpp b/src/creatures/players/grouping/party.hpp index c8bc9b6a653..4c96c6a8824 100644 --- a/src/creatures/players/grouping/party.hpp +++ b/src/creatures/players/grouping/party.hpp @@ -24,9 +24,9 @@ enum SharedExpStatus_t : uint8_t { class Player; class Party; -class Party : public SharedObject { +class Party final : public SharedObject { public: - static std::shared_ptr<Party> create(std::shared_ptr<Player> leader); + static std::shared_ptr<Party> create(const std::shared_ptr<Player> &leader); std::shared_ptr<Party> getParty() { return static_self_cast<Party>(); @@ -38,9 +38,9 @@ class Party : public SharedObject { std::vector<std::shared_ptr<Player>> getPlayers() const { std::vector<std::shared_ptr<Player>> players; for (auto &member : memberList) { - players.push_back(member); + players.emplace_back(member); } - players.push_back(getLeader()); + players.emplace_back(getLeader()); return players; } std::vector<std::shared_ptr<Player>> getMembers() { @@ -60,8 +60,8 @@ class Party : public SharedObject { bool invitePlayer(const std::shared_ptr<Player> &player); bool joinParty(const std::shared_ptr<Player> &player); void revokeInvitation(const std::shared_ptr<Player> &player); - bool passPartyLeadership(std::shared_ptr<Player> player); - bool leaveParty(std::shared_ptr<Player> player, bool forceRemove = false); + bool passPartyLeadership(const std::shared_ptr<Player> &player); + bool leaveParty(const std::shared_ptr<Player> &player, bool forceRemove = false); bool removeInvite(const std::shared_ptr<Player> &player, bool removeFromPlayer = true); @@ -73,39 +73,39 @@ class Party : public SharedObject { } bool canOpenCorpse(uint32_t ownerId) const; - void shareExperience(uint64_t experience, std::shared_ptr<Creature> target = nullptr); - bool setSharedExperience(std::shared_ptr<Player> player, bool sharedExpActive, bool silent = false); + void shareExperience(uint64_t experience, const std::shared_ptr<Creature> &target = nullptr); + bool setSharedExperience(const std::shared_ptr<Player> &player, bool sharedExpActive, bool silent = false); bool isSharedExperienceActive() const { return sharedExpActive; } bool isSharedExperienceEnabled() const { return sharedExpEnabled; } - bool canUseSharedExperience(std::shared_ptr<Player> player); - SharedExpStatus_t getMemberSharedExperienceStatus(std::shared_ptr<Player> player); + bool canUseSharedExperience(const std::shared_ptr<Player> &player); + SharedExpStatus_t getMemberSharedExperienceStatus(const std::shared_ptr<Player> &player); void updateSharedExperience(); - void updatePlayerTicks(std::shared_ptr<Player> player, uint32_t points); - void clearPlayerPoints(std::shared_ptr<Player> player); + void updatePlayerTicks(const std::shared_ptr<Player> &player, uint32_t points); + void clearPlayerPoints(const std::shared_ptr<Player> &player); - void showPlayerStatus(std::shared_ptr<Player> player, std::shared_ptr<Player> member, bool showStatus); - void updatePlayerStatus(std::shared_ptr<Player> player); - void updatePlayerStatus(std::shared_ptr<Player> player, const Position &oldPos, const Position &newPos); - void updatePlayerHealth(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint8_t healthPercent); - void updatePlayerMana(std::shared_ptr<Player> player, uint8_t manaPercent); - void updatePlayerVocation(std::shared_ptr<Player> player); + void showPlayerStatus(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &member, bool showStatus) const; + void updatePlayerStatus(const std::shared_ptr<Player> &player); + void updatePlayerStatus(const std::shared_ptr<Player> &player, const Position &oldPos, const Position &newPos); + void updatePlayerHealth(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint8_t healthPercent); + void updatePlayerMana(const std::shared_ptr<Player> &player, uint8_t manaPercent); + void updatePlayerVocation(const std::shared_ptr<Player> &player); void updateTrackerAnalyzer(); - void addPlayerLoot(std::shared_ptr<Player> player, std::shared_ptr<Item> item); - void addPlayerSupply(std::shared_ptr<Player> player, std::shared_ptr<Item> item); - void addPlayerDamage(std::shared_ptr<Player> player, uint64_t amount); - void addPlayerHealing(std::shared_ptr<Player> player, uint64_t amount); + void addPlayerLoot(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item); + void addPlayerSupply(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item); + void addPlayerDamage(const std::shared_ptr<Player> &player, uint64_t amount); + void addPlayerHealing(const std::shared_ptr<Player> &player, uint64_t amount); void switchAnalyzerPriceType(); void resetAnalyzer(); - void reloadPrices(); + void reloadPrices() const; std::shared_ptr<PartyAnalyzer> getPlayerPartyAnalyzerStruct(uint32_t playerId) const { - if (auto it = std::find_if(membersData.begin(), membersData.end(), [playerId](const std::shared_ptr<PartyAnalyzer> &preyIt) { + if (auto it = std::ranges::find_if(membersData, [playerId](const std::shared_ptr<PartyAnalyzer> &preyIt) { return preyIt->id == playerId; }); it != membersData.end()) { @@ -126,8 +126,8 @@ class Party : public SharedObject { std::vector<std::shared_ptr<PartyAnalyzer>> membersData; private: - const char* getSharedExpReturnMessage(SharedExpStatus_t value); - bool isPlayerActive(std::shared_ptr<Player> player); + const char* getSharedExpReturnMessage(SharedExpStatus_t value) const; + bool isPlayerActive(const std::shared_ptr<Player> &player); SharedExpStatus_t getSharedExperienceStatus(); uint32_t getHighestLevel(); uint32_t getLowestLevel(); diff --git a/src/creatures/players/grouping/team_finder.hpp b/src/creatures/players/grouping/team_finder.hpp index 9fafbd03227..e46217560b6 100644 --- a/src/creatures/players/grouping/team_finder.hpp +++ b/src/creatures/players/grouping/team_finder.hpp @@ -1,5 +1,3 @@ -#include <utility> - /** * Canary - A free and open-source MMORPG server emulator * Copyright (©) 2019-2024 OpenTibiaBR <opentibiabr@outlook.com> @@ -16,7 +14,7 @@ * This class is responsible control and manage the team finder feature. **/ -class TeamFinder { +class TeamFinder final { public: TeamFinder() = default; TeamFinder(uint16_t initMinLevel, uint16_t initMaxLevel, uint8_t initVocationIDs, uint16_t initTeamSlots, uint16_t initFreeSlots, bool initPartyBool, uint32_t initTimestamp, uint8_t initTeamType, uint16_t initBossID, uint16_t initHunt_type, uint16_t initHunt_area, uint16_t initQuestID, uint32_t initLeaderGuid, std::map<uint32_t, uint8_t> initMembersMap) : @@ -34,7 +32,7 @@ class TeamFinder { questID(initQuestID), leaderGuid(initLeaderGuid), membersMap(std::move(initMembersMap)) { } - virtual ~TeamFinder() = default; + ~TeamFinder() = default; uint16_t minLevel = 0; uint16_t maxLevel = 0; diff --git a/src/creatures/players/imbuements/imbuements.cpp b/src/creatures/players/imbuements/imbuements.cpp index 06db26b7210..4fe13bc5ad7 100644 --- a/src/creatures/players/imbuements/imbuements.cpp +++ b/src/creatures/players/imbuements/imbuements.cpp @@ -34,7 +34,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { } loaded = true; - for (auto baseNode : doc.child("imbuements").children()) { + for (const auto &baseNode : doc.child("imbuements").children()) { pugi::xml_attribute attr; // Base for imbue if (strcasecmp(baseNode.name(), "base") == 0) { @@ -82,14 +82,14 @@ bool Imbuements::loadFromXml(bool /* reloading */) { continue; } - auto imbuements = imbuementMap.emplace(std::piecewise_construct, std::forward_as_tuple(runningid), std::forward_as_tuple(runningid, baseid)); + auto [imbuementInfo, inserted] = imbuementMap.emplace(std::piecewise_construct, std::forward_as_tuple(runningid), std::forward_as_tuple(runningid, baseid)); - if (!imbuements.second) { + if (!inserted) { g_logger().warn("Duplicate imbuement of Base ID: '{}' ignored", baseid); continue; } - Imbuement &imbuement = imbuements.first->second; + Imbuement &imbuement = imbuementInfo->second; pugi::xml_attribute iconBase = baseNode.attribute("iconid"); if (!iconBase) { @@ -122,7 +122,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { continue; } - uint16_t category = pugi::cast<uint16_t>(categorybase.value()); + auto category = pugi::cast<uint16_t>(categorybase.value()); auto category_p = getCategoryByID(category); if (category_p == nullptr) { g_logger().warn("Category imbuement {} not exist", category); @@ -138,26 +138,26 @@ bool Imbuements::loadFromXml(bool /* reloading */) { } imbuement.name = nameBase.value(); - for (auto childNode : baseNode.children()) { - if (!(attr = childNode.attribute("key"))) { + for (const auto &childNode : baseNode.children()) { + if (!((attr = childNode.attribute("key")))) { g_logger().warn("Missing key attribute in imbuement id: {}", runningid); continue; } std::string type = attr.as_string(); if (strcasecmp(type.c_str(), "item") == 0) { - if (!(attr = childNode.attribute("value"))) { + if (!((attr = childNode.attribute("value")))) { g_logger().warn("Missing item ID for imbuement name '{}'", imbuement.name); continue; } - uint16_t sourceId = pugi::cast<uint16_t>(attr.value()); + auto sourceId = pugi::cast<uint16_t>(attr.value()); uint16_t count = 1; if ((attr = childNode.attribute("count"))) { count = pugi::cast<uint16_t>(childNode.attribute("count").value()); } - auto it2 = std::find_if(imbuement.items.begin(), imbuement.items.end(), [sourceId](const std::pair<uint16_t, uint16_t> &source) -> bool { + const auto &it2 = std::ranges::find_if(imbuement.items, [sourceId](const std::pair<uint16_t, uint16_t> &source) -> bool { return source.first == sourceId; }); @@ -177,7 +177,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { imbuement.description = description; } else if (strcasecmp(type.c_str(), "effect") == 0) { // Effects - if (!(attr = childNode.attribute("type"))) { + if (!((attr = childNode.attribute("type")))) { g_logger().warn("Missing effect type for imbuement name: {}", imbuement.name); continue; } @@ -185,7 +185,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { std::string effecttype = attr.as_string(); if (strcasecmp(effecttype.c_str(), "skill") == 0) { - if (!(attr = childNode.attribute("value"))) { + if (!((attr = childNode.attribute("value")))) { g_logger().warn("Missing effect value for imbuement name {}", imbuement.name); continue; } @@ -225,11 +225,11 @@ bool Imbuements::loadFromXml(bool /* reloading */) { continue; } - if (!(attr = childNode.attribute("bonus"))) { + if (!((attr = childNode.attribute("bonus")))) { g_logger().warn("Missing skill bonus for imbuement name {}", imbuement.name); continue; } - int32_t bonus = pugi::cast<int32_t>(attr.value()); + auto bonus = pugi::cast<int32_t>(attr.value()); if (usenormalskill == 1) { imbuement.skills[skillId] = bonus; @@ -245,7 +245,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { imbuement.skills[skillId - 1] = chance; } } else if (strcasecmp(effecttype.c_str(), "damage") == 0) { - if (!(attr = childNode.attribute("combat"))) { + if (!((attr = childNode.attribute("combat")))) { g_logger().warn("Missing combat for imbuement name {}", imbuement.name); continue; } @@ -256,7 +256,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { continue; } - if (!(attr = childNode.attribute("value"))) { + if (!((attr = childNode.attribute("value")))) { g_logger().warn("Missing damage reduction percentage for imbuement name {}", imbuement.name); continue; } @@ -266,7 +266,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { imbuement.combatType = combatType; imbuement.elementDamage = std::min<int16_t>(100, percent); } else if (strcasecmp(effecttype.c_str(), "reduction") == 0) { - if (!(attr = childNode.attribute("combat"))) { + if (!((attr = childNode.attribute("combat")))) { g_logger().warn("Missing combat for imbuement name {}", imbuement.name); continue; } @@ -277,7 +277,7 @@ bool Imbuements::loadFromXml(bool /* reloading */) { continue; } - if (!(attr = childNode.attribute("value"))) { + if (!((attr = childNode.attribute("value")))) { g_logger().warn("Missing damage reduction percentage for imbuement name {}", imbuement.name); continue; } @@ -286,14 +286,14 @@ bool Imbuements::loadFromXml(bool /* reloading */) { imbuement.absorbPercent[combatTypeToIndex(combatType)] = percent; } else if (strcasecmp(effecttype.c_str(), "speed") == 0) { - if (!(attr = childNode.attribute("value"))) { + if (!((attr = childNode.attribute("value")))) { g_logger().warn("Missing speed value for imbuement name {}", imbuement.name); continue; } imbuement.speed = pugi::cast<uint32_t>(attr.value()); } else if (strcasecmp(effecttype.c_str(), "capacity") == 0) { - if (!(attr = childNode.attribute("value"))) { + if (!((attr = childNode.attribute("value")))) { g_logger().warn("Missing cap value for imbuement name {}", imbuement.name); continue; } @@ -320,7 +320,7 @@ bool Imbuements::reload() { } BaseImbuement* Imbuements::getBaseByID(uint16_t id) { - auto baseImbuements = std::find_if(basesImbuement.begin(), basesImbuement.end(), [id](const BaseImbuement &groupImbuement) { + const auto &baseImbuements = std::ranges::find_if(basesImbuement, [id](const BaseImbuement &groupImbuement) { return groupImbuement.id == id; }); @@ -328,14 +328,14 @@ BaseImbuement* Imbuements::getBaseByID(uint16_t id) { } CategoryImbuement* Imbuements::getCategoryByID(uint16_t id) { - auto categoryImbuements = std::find_if(categoriesImbuement.begin(), categoriesImbuement.end(), [id](const CategoryImbuement &categoryImbuement) { + const auto &categoryImbuements = std::ranges::find_if(categoriesImbuement, [id](const CategoryImbuement &categoryImbuement) { return categoryImbuement.id == id; }); return categoryImbuements != categoriesImbuement.end() ? &*categoryImbuements : nullptr; } -std::vector<Imbuement*> Imbuements::getImbuements(std::shared_ptr<Player> player, std::shared_ptr<Item> item) { +std::vector<Imbuement*> Imbuements::getImbuements(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) { std::vector<Imbuement*> imbuements; for (auto &[key, value] : imbuementMap) { @@ -363,7 +363,7 @@ std::vector<Imbuement*> Imbuements::getImbuements(std::shared_ptr<Player> player continue; } - imbuements.push_back(imbuement); + imbuements.emplace_back(imbuement); } return imbuements; diff --git a/src/creatures/players/imbuements/imbuements.hpp b/src/creatures/players/imbuements/imbuements.hpp index 265e813aa1c..c89e3f80df0 100644 --- a/src/creatures/players/imbuements/imbuements.hpp +++ b/src/creatures/players/imbuements/imbuements.hpp @@ -12,13 +12,14 @@ #include "creatures/players/player.hpp" #include "declarations.hpp" #include "lib/di/container.hpp" -#include "utils/tools.hpp" class Player; class Item; class Imbuement; +constexpr int32_t maxSkillOrStatId = std::max<int32_t>(STAT_LAST, SKILL_LAST); + struct BaseImbuement { BaseImbuement(uint16_t initId, std::string initName, uint32_t initPrice, uint32_t initProtectionPrice, uint32_t initRemoveCost, uint32_t initDuration, uint8_t initPercent) : id(initId), name(std::move(initName)), price(initPrice), protectionPrice(initProtectionPrice), removeCost(initRemoveCost), duration(initDuration), percent(initPercent) { } @@ -60,7 +61,7 @@ class Imbuements { BaseImbuement* getBaseByID(uint16_t id); CategoryImbuement* getCategoryByID(uint16_t id); - std::vector<Imbuement*> getImbuements(std::shared_ptr<Player> player, std::shared_ptr<Item> item); + std::vector<Imbuement*> getImbuements(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item); protected: friend class Imbuement; @@ -94,7 +95,7 @@ class Imbuement { return storage; } - bool isPremium() { + bool isPremium() const { return premium; } std::string getName() const { @@ -116,12 +117,12 @@ class Imbuement { return items; } - uint16_t getIconID() { + uint16_t getIconID() const { return icon + (baseid - 1); } uint16_t icon = 1; - int32_t stats[STAT_LAST + 1] = {}; + int32_t stats[maxSkillOrStatId + 1] = {}; int32_t skills[SKILL_LAST + 1] = {}; int32_t speed = 0; uint32_t capacity = 0; @@ -139,7 +140,9 @@ class Imbuement { bool premium = false; uint32_t storage = 0; uint16_t id, baseid, category = 0; - std::string name, description, subgroup = ""; + std::string name; + std::string description; + std::string subgroup; std::vector<std::pair<uint16_t, uint16_t>> items; }; diff --git a/src/creatures/players/management/ban.cpp b/src/creatures/players/management/ban.cpp index 748b784a77a..0a4efcd2559 100644 --- a/src/creatures/players/management/ban.cpp +++ b/src/creatures/players/management/ban.cpp @@ -15,7 +15,7 @@ bool Ban::acceptConnection(uint32_t clientIP) { std::scoped_lock<std::recursive_mutex> lockClass(lock); - uint64_t currentTime = OTSYS_TIME(); + const uint64_t currentTime = OTSYS_TIME(); auto it = ipConnectMap.find(clientIP); if (it == ipConnectMap.end()) { @@ -29,7 +29,7 @@ bool Ban::acceptConnection(uint32_t clientIP) { return false; } - int64_t timeDiff = currentTime - connectBlock.lastAttempt; + const int64_t timeDiff = currentTime - connectBlock.lastAttempt; connectBlock.lastAttempt = currentTime; if (timeDiff <= 5000) { if (++connectBlock.count > 5) { @@ -51,12 +51,12 @@ bool IOBan::isAccountBanned(uint32_t accountId, BanInfo &banInfo) { std::ostringstream query; query << "SELECT `reason`, `expires_at`, `banned_at`, `banned_by`, (SELECT `name` FROM `players` WHERE `id` = `banned_by`) AS `name` FROM `account_bans` WHERE `account_id` = " << accountId; - DBResult_ptr result = db.storeQuery(query.str()); + const DBResult_ptr result = db.storeQuery(query.str()); if (!result) { return false; } - int64_t expiresAt = result->getNumber<int64_t>("expires_at"); + const auto expiresAt = result->getNumber<int64_t>("expires_at"); if (expiresAt != 0 && time(nullptr) > expiresAt) { // Move the ban to history if it has expired query.str(std::string()); @@ -85,12 +85,12 @@ bool IOBan::isIpBanned(uint32_t clientIP, BanInfo &banInfo) { std::ostringstream query; query << "SELECT `reason`, `expires_at`, (SELECT `name` FROM `players` WHERE `id` = `banned_by`) AS `name` FROM `ip_bans` WHERE `ip` = " << clientIP; - DBResult_ptr result = db.storeQuery(query.str()); + const DBResult_ptr result = db.storeQuery(query.str()); if (!result) { return false; } - int64_t expiresAt = result->getNumber<int64_t>("expires_at"); + const auto expiresAt = result->getNumber<int64_t>("expires_at"); if (expiresAt != 0 && time(nullptr) > expiresAt) { query.str(std::string()); query << "DELETE FROM `ip_bans` WHERE `ip` = " << clientIP; diff --git a/src/creatures/players/management/ban.hpp b/src/creatures/players/management/ban.hpp index 6fdb94296df..3e9b3f07f58 100644 --- a/src/creatures/players/management/ban.hpp +++ b/src/creatures/players/management/ban.hpp @@ -10,18 +10,18 @@ #pragma once struct BanInfo { - std::string bannedBy; - std::string reason; - time_t expiresAt; + std::string bannedBy {}; + std::string reason {}; + time_t expiresAt {}; }; struct ConnectBlock { constexpr ConnectBlock(uint64_t lastAttempt, uint64_t blockTime, uint32_t count) : lastAttempt(lastAttempt), blockTime(blockTime), count(count) { } - uint64_t lastAttempt; - uint64_t blockTime; - uint32_t count; + uint64_t lastAttempt {}; + uint64_t blockTime {}; + uint32_t count {}; }; using IpConnectMap = std::map<uint32_t, ConnectBlock>; diff --git a/src/creatures/players/management/waitlist.cpp b/src/creatures/players/management/waitlist.cpp index da658453161..374d7329855 100644 --- a/src/creatures/players/management/waitlist.cpp +++ b/src/creatures/players/management/waitlist.cpp @@ -25,13 +25,13 @@ WaitingList &WaitingList::getInstance() { return inject<WaitingList>(); } -void WaitingList::cleanupList(WaitList &list) { - int64_t time = OTSYS_TIME(); +void WaitingList::cleanupList(WaitList &list) const { + const int64_t time = OTSYS_TIME(); auto it = list.begin(); while (it != list.end()) { - auto timeout = static_cast<int64_t>(it->timeout); - g_logger().warn("time: {}", timeout - time); + const auto timeout = static_cast<int64_t>(it->timeout); + g_logger().debug("[{}] time: {}", __FUNCTION__, timeout - time); if ((timeout - time) <= 0) { info->playerReferences.erase(it->playerGUID); it = list.erase(it); @@ -41,25 +41,27 @@ void WaitingList::cleanupList(WaitList &list) { } } -std::size_t WaitingList::getTimeout(std::size_t slot) { +std::size_t WaitingList::getTimeout(std::size_t slot) const { return WaitingList::getTime(slot) + TIMEOUT_EXTRA; } std::size_t WaitingList::getTime(std::size_t slot) { if (slot < SLOT_LIMIT_ONE) { return 5; - } else if (slot < SLOT_LIMIT_TWO) { + } + if (slot < SLOT_LIMIT_TWO) { return 10; - } else if (slot < SLOT_LIMIT_THREE) { + } + if (slot < SLOT_LIMIT_THREE) { return 20; - } else if (slot < SLOT_LIMIT_FOUR) { + } + if (slot < SLOT_LIMIT_FOUR) { return 60; - } else { - return 120; } + return 120; } -bool WaitingList::clientLogin(std::shared_ptr<Player> player) { +bool WaitingList::clientLogin(const std::shared_ptr<Player> &player) const { if (player->hasFlag(PlayerFlags_t::CanAlwaysLogin) || player->getAccountType() >= ACCOUNT_TYPE_GAMEMASTER) { return true; } @@ -75,7 +77,7 @@ bool WaitingList::clientLogin(std::shared_ptr<Player> player) { addPlayerToList(player); auto it = info->playerReferences.find(player->getGUID()); - std::size_t slot = it->second.second; + const std::size_t slot = it->second.second; if ((g_game().getPlayersOnline() + slot) <= maxPlayers) { // should be able to login now info->waitList.erase(it->second.first); @@ -85,7 +87,7 @@ bool WaitingList::clientLogin(std::shared_ptr<Player> player) { return false; } -void WaitingList::addPlayerToList(std::shared_ptr<Player> player) { +void WaitingList::addPlayerToList(const std::shared_ptr<Player> &player) const { auto it = info->playerReferences.find(player->getGUID()); if (it != info->playerReferences.end()) { std::size_t slot; @@ -111,7 +113,7 @@ void WaitingList::addPlayerToList(std::shared_ptr<Player> player) { } } -std::size_t WaitingList::getClientSlot(std::shared_ptr<Player> player) { +std::size_t WaitingList::getClientSlot(const std::shared_ptr<Player> &player) const { auto it = info->playerReferences.find(player->getGUID()); if (it == info->playerReferences.end()) { return 0; diff --git a/src/creatures/players/management/waitlist.hpp b/src/creatures/players/management/waitlist.hpp index 24752f2647d..28a21b4a4b1 100644 --- a/src/creatures/players/management/waitlist.hpp +++ b/src/creatures/players/management/waitlist.hpp @@ -34,13 +34,13 @@ class WaitingList { public: WaitingList(); static WaitingList &getInstance(); - bool clientLogin(std::shared_ptr<Player> player); - std::size_t getClientSlot(std::shared_ptr<Player> player); + bool clientLogin(const std::shared_ptr<Player> &player) const; + std::size_t getClientSlot(const std::shared_ptr<Player> &player) const; static std::size_t getTime(std::size_t slot); private: - void cleanupList(WaitList &list); - std::size_t getTimeout(std::size_t slot); - void addPlayerToList(std::shared_ptr<Player> player); + void cleanupList(WaitList &list) const; + std::size_t getTimeout(std::size_t slot) const; + void addPlayerToList(const std::shared_ptr<Player> &player) const; std::unique_ptr<WaitListInfo> info; }; diff --git a/src/creatures/players/player.cpp b/src/creatures/players/player.cpp index 5a6c4cbf6cc..3846d9ca99b 100644 --- a/src/creatures/players/player.cpp +++ b/src/creatures/players/player.cpp @@ -32,10 +32,12 @@ #include "lua/creature/movement.hpp" #include "io/iologindata.hpp" #include "items/bed.hpp" +#include "map/town.hpp" #include "items/weapons/weapons.hpp" #include "core.hpp" #include "map/spectators.hpp" #include "lib/metrics/metrics.hpp" + #include "enums/object_category.hpp" #include "enums/account_errors.hpp" #include "enums/account_type.hpp" @@ -45,7 +47,6 @@ MuteCountMap Player::muteCountMap; Player::Player(ProtocolGame_ptr p) : - Creature(), lastPing(OTSYS_TIME()), lastPong(lastPing), inbox(std::make_shared<Inbox>(ITEM_INBOX)), @@ -59,19 +60,20 @@ Player::Player(ProtocolGame_ptr p) : } Player::~Player() { - for (const std::shared_ptr<Item> &item : inventory) { + for (const auto &item : inventory) { if (item) { item->resetParent(); item->stopDecaying(); } } - for (const auto &it : depotLockerMap) { - it.second->removeInbox(inbox); - it.second->stopDecaying(); - } + for (const auto &[depotId, depotLocker] : depotLockerMap) { + if (depotId == 0) { + continue; + } - inbox->stopDecaying(); + depotLocker->removeInbox(inbox); + } setWriteItem(nullptr); setEditHouse(nullptr); @@ -97,8 +99,8 @@ bool Player::isPushable() { return Creature::isPushable(); } -std::shared_ptr<Task> Player::createPlayerTask(uint32_t delay, std::function<void(void)> f, std::string context) { - return std::make_shared<Task>(std::move(f), std::move(context), delay); +std::shared_ptr<Task> Player::createPlayerTask(uint32_t delay, std::function<void(void)> f, const std::string &context) { + return std::make_shared<Task>(std::move(f), context, delay); } uint32_t Player::playerFirstID = 0x10000000; @@ -124,7 +126,7 @@ std::string Player::getDescription(int32_t lookDistance) { std::ostringstream s; std::string subjectPronoun = getSubjectPronoun(); capitalizeWords(subjectPronoun); - auto playerTitle = title()->getCurrentTitle() == 0 ? "" : (", " + title()->getCurrentTitleName()); + const auto playerTitle = title()->getCurrentTitle() == 0 ? "" : (", " + title()->getCurrentTitleName()); if (lookDistance == -1) { s << "yourself" << playerTitle << "."; @@ -180,14 +182,14 @@ std::string Player::getDescription(int32_t lookDistance) { s << " " << subjectPronoun << " " << getSubjectVerb() << " in a party with "; } - size_t memberCount = m_party->getMemberCount() + 1; + const size_t memberCount = m_party->getMemberCount() + 1; if (memberCount == 1) { s << "1 member and "; } else { s << memberCount << " members and "; } - size_t invitationCount = m_party->getInvitationCount(); + const size_t invitationCount = m_party->getInvitationCount(); if (invitationCount == 1) { s << "1 pending invitation."; } else { @@ -196,7 +198,7 @@ std::string Player::getDescription(int32_t lookDistance) { } if (guild && guildRank) { - size_t memberCount = guild->getMemberCount(); + const size_t memberCount = guild->getMemberCount(); if (memberCount >= 1000) { s << ""; return s.str(); @@ -249,12 +251,12 @@ void Player::removeConditionSuppressions() { } std::shared_ptr<Item> Player::getWeapon(Slots_t slot, bool ignoreAmmo) const { - std::shared_ptr<Item> item = inventory[slot]; + const auto &item = inventory[slot]; if (!item) { return nullptr; } - WeaponType_t weaponType = item->getWeaponType(); + const WeaponType_t &weaponType = item->getWeaponType(); if (weaponType == WEAPON_NONE || weaponType == WEAPON_SHIELD || weaponType == WEAPON_AMMO) { return nullptr; } @@ -262,7 +264,7 @@ std::shared_ptr<Item> Player::getWeapon(Slots_t slot, bool ignoreAmmo) const { if (!ignoreAmmo && (weaponType == WEAPON_DISTANCE || weaponType == WEAPON_MISSILE)) { const ItemType &it = Item::items[item->getID()]; if (it.ammoType != AMMO_NONE) { - item = getQuiverAmmoOfType(it); + return getQuiverAmmoOfType(it); } } @@ -270,12 +272,12 @@ std::shared_ptr<Item> Player::getWeapon(Slots_t slot, bool ignoreAmmo) const { } bool Player::hasQuiverEquipped() const { - std::shared_ptr<Item> quiver = inventory[CONST_SLOT_RIGHT]; + const auto &quiver = inventory[CONST_SLOT_RIGHT]; return quiver && quiver->isQuiver() && quiver->getContainer(); } bool Player::hasWeaponDistanceEquipped() const { - std::shared_ptr<Item> item = inventory[CONST_SLOT_LEFT]; + const auto &item = inventory[CONST_SLOT_LEFT]; return item && item->getWeaponType() == WEAPON_DISTANCE; } @@ -284,9 +286,9 @@ std::shared_ptr<Item> Player::getQuiverAmmoOfType(const ItemType &it) const { return nullptr; } - std::shared_ptr<Item> quiver = inventory[CONST_SLOT_RIGHT]; - for (std::shared_ptr<Container> container = quiver->getContainer(); - auto ammoItem : container->getItemList()) { + const auto &quiver = inventory[CONST_SLOT_RIGHT]; + for (const auto &container = quiver->getContainer(); + const auto &ammoItem : container->getItemList()) { if (ammoItem->getAmmoType() == it.ammoType) { if (level >= Item::items[ammoItem->getID()].minReqLevel) { return ammoItem; @@ -297,34 +299,34 @@ std::shared_ptr<Item> Player::getQuiverAmmoOfType(const ItemType &it) const { } std::shared_ptr<Item> Player::getWeapon(bool ignoreAmmo /* = false*/) const { - std::shared_ptr<Item> item = getWeapon(CONST_SLOT_LEFT, ignoreAmmo); - if (item) { - return item; + const auto &itemLeft = getWeapon(CONST_SLOT_LEFT, ignoreAmmo); + if (itemLeft) { + return itemLeft; } - item = getWeapon(CONST_SLOT_RIGHT, ignoreAmmo); - if (item) { - return item; + const auto &itemRight = getWeapon(CONST_SLOT_RIGHT, ignoreAmmo); + if (itemRight) { + return itemRight; } return nullptr; } WeaponType_t Player::getWeaponType() const { - std::shared_ptr<Item> item = getWeapon(); + const auto &item = getWeapon(); if (!item) { return WEAPON_NONE; } return item->getWeaponType(); } -int32_t Player::getWeaponSkill(std::shared_ptr<Item> item) const { +int32_t Player::getWeaponSkill(const std::shared_ptr<Item> &item) const { if (!item) { return getSkillLevel(SKILL_FIST); } int32_t attackSkill; - WeaponType_t weaponType = item->getWeaponType(); + const WeaponType_t &weaponType = item->getWeaponType(); switch (weaponType) { case WEAPON_SWORD: { attackSkill = getSkillLevel(SKILL_SWORD); @@ -358,14 +360,14 @@ int32_t Player::getWeaponSkill(std::shared_ptr<Item> item) const { int32_t Player::getArmor() const { int32_t armor = 0; - static const Slots_t armorSlots[] = { CONST_SLOT_HEAD, CONST_SLOT_NECKLACE, CONST_SLOT_ARMOR, CONST_SLOT_LEGS, CONST_SLOT_FEET, CONST_SLOT_RING, CONST_SLOT_AMMO }; - for (Slots_t slot : armorSlots) { - std::shared_ptr<Item> inventoryItem = inventory[slot]; + static constexpr Slots_t armorSlots[] = { CONST_SLOT_HEAD, CONST_SLOT_NECKLACE, CONST_SLOT_ARMOR, CONST_SLOT_LEGS, CONST_SLOT_FEET, CONST_SLOT_RING, CONST_SLOT_AMMO }; + for (const Slots_t &slot : armorSlots) { + const auto &inventoryItem = inventory[slot]; if (inventoryItem) { armor += inventoryItem->getArmor(); } } - return static_cast<int32_t>(armor * vocation->armorMultiplier); + return armor * static_cast<int32_t>(vocation->armorMultiplier); } void Player::getShieldAndWeapon(std::shared_ptr<Item> &shield, std::shared_ptr<Item> &weapon) const { @@ -373,7 +375,7 @@ void Player::getShieldAndWeapon(std::shared_ptr<Item> &shield, std::shared_ptr<I weapon = nullptr; for (uint32_t slot = CONST_SLOT_RIGHT; slot <= CONST_SLOT_LEFT; slot++) { - std::shared_ptr<Item> item = inventory[slot]; + const auto &item = inventory[slot]; if (!item) { continue; } @@ -483,7 +485,7 @@ std::unordered_set<PlayerIcon> Player::getClientIcons() { icons.insert(PlayerIcon::RedSwords); } - auto tile = getTile(); + const auto &tile = getTile(); if (tile && tile->hasFlag(TILESTATE_PROTECTIONZONE)) { if (icons.size() < 9) { icons.insert(PlayerIcon::Pigeon); @@ -498,7 +500,7 @@ std::unordered_set<PlayerIcon> Player::getClientIcons() { return icons; } -void Player::addMonsterToCyclopediaTrackerList(const std::shared_ptr<MonsterType> mtype, bool isBoss, bool reloadClient /* = false */) { +void Player::addMonsterToCyclopediaTrackerList(const std::shared_ptr<MonsterType> &mtype, bool isBoss, bool reloadClient /* = false */) { if (!client) { return; } @@ -518,7 +520,7 @@ void Player::addMonsterToCyclopediaTrackerList(const std::shared_ptr<MonsterType } } -void Player::removeMonsterFromCyclopediaTrackerList(std::shared_ptr<MonsterType> mtype, bool isBoss, bool reloadClient /* = false */) { +void Player::removeMonsterFromCyclopediaTrackerList(const std::shared_ptr<MonsterType> &mtype, bool isBoss, bool reloadClient /* = false */) { if (!client) { return; } @@ -550,7 +552,7 @@ void Player::updateInventoryWeight() { inventoryWeight = 0; for (int i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (item) { inventoryWeight += item->getWeight(); } @@ -559,17 +561,16 @@ void Player::updateInventoryWeight() { void Player::updateInventoryImbuement() { // Get the tile the player is currently on - std::shared_ptr<Tile> playerTile = getTile(); + const auto &playerTile = getTile(); // Check if the player is in a protection zone - bool isInProtectionZone = playerTile && playerTile->hasFlag(TILESTATE_PROTECTIONZONE); + const bool &isInProtectionZone = playerTile && playerTile->hasFlag(TILESTATE_PROTECTIONZONE); // Check if the player is in fight mode bool isInFightMode = hasCondition(CONDITION_INFIGHT); bool nonAggressiveFightOnly = g_configManager().getBoolean(TOGGLE_IMBUEMENT_NON_AGGRESSIVE_FIGHT_ONLY); // Iterate through all items in the player's inventory - for (auto [key, item] : getAllSlotItems()) { + for (const auto &[slodNumber, item] : getAllSlotItems()) { // Iterate through all imbuement slots on the item - for (uint8_t slotid = 0; slotid < item->getImbuementSlot(); slotid++) { ImbuementInfo imbuementInfo; // Get the imbuement information for the current slot @@ -579,12 +580,12 @@ void Player::updateInventoryImbuement() { } // Imbuement from imbuementInfo, this variable reduces code complexity - auto imbuement = imbuementInfo.imbuement; + const auto imbuement = imbuementInfo.imbuement; // Get the category of the imbuement const CategoryImbuement* categoryImbuement = g_imbuements().getCategoryByID(imbuement->getCategory()); // Parent of the imbued item - auto parent = item->getParent(); - bool isInBackpack = parent && parent->getContainer(); + const auto &parent = item->getParent(); + const bool &isInBackpack = parent && parent->getContainer(); // If the imbuement is aggressive and the player is not in fight mode or is in a protection zone, or the item is in a container, ignore it. if (categoryImbuement && (categoryImbuement->agressive || nonAggressiveFightOnly) && (isInProtectionZone || !isInFightMode || isInBackpack)) { continue; @@ -603,14 +604,13 @@ void Player::updateInventoryImbuement() { g_logger().trace("Decaying imbuement {} from item {} of player {}", imbuement->getName(), item->getName(), getName()); // Calculate the new duration of the imbuement, making sure it doesn't go below 0 - uint32_t duration = std::max<uint32_t>(0, imbuementInfo.duration - EVENT_IMBUEMENT_INTERVAL / 1000); + const uint32_t duration = std::max<uint32_t>(0, imbuementInfo.duration - EVENT_IMBUEMENT_INTERVAL / 1000); // Update the imbuement's duration in the item item->decayImbuementTime(slotid, imbuement->getID(), duration); if (duration == 0) { removeItemImbuementStats(imbuement); updateImbuementTrackerStats(); - continue; } } } @@ -619,7 +619,7 @@ void Player::updateInventoryImbuement() { phmap::flat_hash_map<uint8_t, std::shared_ptr<Item>> Player::getAllSlotItems() const { phmap::flat_hash_map<uint8_t, std::shared_ptr<Item>> itemMap; for (uint8_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } @@ -650,7 +650,7 @@ uint16_t Player::getLoyaltySkill(skills_t skill) const { } absl::uint128 tries = skills[skill].tries; - absl::uint128 totalTries = vocation->getTotalSkillTries(skill, skills[skill].level) + tries; + const absl::uint128 totalTries = vocation->getTotalSkillTries(skill, skills[skill].level) + tries; absl::uint128 loyaltyTries = (totalTries * getLoyaltyBonus()) / 100; while ((tries + loyaltyTries) >= nextReqTries) { loyaltyTries -= nextReqTries - tries; @@ -769,7 +769,7 @@ int32_t Player::getDefaultStats(stats_t stat) const { } } -void Player::addContainer(uint8_t cid, std::shared_ptr<Container> container) { +void Player::addContainer(uint8_t cid, const std::shared_ptr<Container> &container) { if (cid > 0xF) { return; } @@ -778,13 +778,9 @@ void Player::addContainer(uint8_t cid, std::shared_ptr<Container> container) { return; } - auto it = openContainers.find(cid); + const auto it = openContainers.find(cid); if (it != openContainers.end()) { OpenContainer &openContainer = it->second; - auto oldContainer = openContainer.container; - if (oldContainer->getID() == ITEM_BROWSEFIELD) { - } - openContainer.container = container; openContainer.index = 0; } else { @@ -796,13 +792,13 @@ void Player::addContainer(uint8_t cid, std::shared_ptr<Container> container) { } void Player::closeContainer(uint8_t cid) { - auto it = openContainers.find(cid); + const auto it = openContainers.find(cid); if (it == openContainers.end()) { return; } - OpenContainer openContainer = it->second; - std::shared_ptr<Container> container = openContainer.container; + const OpenContainer &openContainer = it->second; + const auto &container = openContainer.container; if (container && container->isAnyKindOfRewardChest() && !hasOtherRewardContainerOpen(container)) { removeEmptyRewards(); @@ -823,14 +819,14 @@ void Player::removeEmptyRewards() { }); } -bool Player::hasOtherRewardContainerOpen(const std::shared_ptr<Container> container) const { +bool Player::hasOtherRewardContainerOpen(const std::shared_ptr<Container> &container) const { return std::ranges::any_of(openContainers.begin(), openContainers.end(), [container](const auto &containerPair) { return containerPair.second.container != container && containerPair.second.container->isAnyKindOfRewardContainer(); }); } void Player::setContainerIndex(uint8_t cid, uint16_t index) { - auto it = openContainers.find(cid); + const auto it = openContainers.find(cid); if (it == openContainers.end()) { return; } @@ -838,24 +834,24 @@ void Player::setContainerIndex(uint8_t cid, uint16_t index) { } std::shared_ptr<Container> Player::getContainerByID(uint8_t cid) { - auto it = openContainers.find(cid); + const auto it = openContainers.find(cid); if (it == openContainers.end()) { return nullptr; } return it->second.container; } -int8_t Player::getContainerID(std::shared_ptr<Container> container) const { - for (const auto &it : openContainers) { - if (it.second.container == container) { - return it.first; +int8_t Player::getContainerID(const std::shared_ptr<Container> &container) const { + for (const auto &[containerId, containerInfo] : openContainers) { + if (containerInfo.container == container) { + return containerId; } } return -1; } uint16_t Player::getContainerIndex(uint8_t cid) const { - auto it = openContainers.find(cid); + const auto it = openContainers.find(cid); if (it == openContainers.end()) { return 0; } @@ -869,9 +865,8 @@ bool Player::canOpenCorpse(uint32_t ownerId) const { uint16_t Player::getLookCorpse() const { if (sex == PLAYERSEX_FEMALE) { return ITEM_FEMALE_CORPSE; - } else { - return ITEM_MALE_CORPSE; } + return ITEM_MALE_CORPSE; } void Player::addStorageValue(const uint32_t key, const int32_t value, const bool isLogin /* = false*/) { @@ -882,7 +877,8 @@ void Player::addStorageValue(const uint32_t key, const int32_t value, const bool value & 0xFF ); return; - } else if (IS_IN_KEYRANGE(key, MOUNTS_RANGE)) { + } + if (IS_IN_KEYRANGE(key, MOUNTS_RANGE)) { // do nothing } else if (IS_IN_KEYRANGE(key, FAMILIARS_RANGE)) { familiars.emplace_back( @@ -911,7 +907,7 @@ void Player::addStorageValue(const uint32_t key, const int32_t value, const bool int32_t Player::getStorageValue(const uint32_t key) const { int32_t value = -1; - auto it = storageMap.find(key); + const auto it = storageMap.find(key); if (it == storageMap.end()) { return value; } @@ -921,11 +917,11 @@ int32_t Player::getStorageValue(const uint32_t key) const { } int32_t Player::getStorageValueByName(const std::string &storageName) const { - auto it = g_storages().getStorageMap().find(storageName); + const auto it = g_storages().getStorageMap().find(storageName); if (it == g_storages().getStorageMap().end()) { return -1; } - uint32_t key = it->second; + const uint32_t key = it->second; return getStorageValue(key); } @@ -936,7 +932,7 @@ void Player::addStorageValueByName(const std::string &storageName, const int32_t g_logger().error("[{}] Storage name '{}' not found in storage map, register your storage in 'storages.xml' first for use", __func__, storageName); return; } - uint32_t key = it->second; + const uint32_t key = it->second; addStorageValue(key, value, isLogin); } @@ -947,7 +943,7 @@ bool Player::canSee(const Position &pos) { return client->canSee(pos); } -bool Player::canSeeCreature(std::shared_ptr<Creature> creature) const { +bool Player::canSeeCreature(const std::shared_ptr<Creature> &creature) const { if (creature.get() == this) { return true; } @@ -962,14 +958,14 @@ bool Player::canSeeCreature(std::shared_ptr<Creature> creature) const { return true; } -bool Player::canWalkthrough(std::shared_ptr<Creature> creature) { +bool Player::canWalkthrough(const std::shared_ptr<Creature> &creature) { if (group->access || creature->isInGhostMode()) { return true; } - std::shared_ptr<Player> player = creature->getPlayer(); - std::shared_ptr<Monster> monster = creature->getMonster(); - std::shared_ptr<Npc> npc = creature->getNpc(); + const auto &player = creature->getPlayer(); + const auto &monster = creature->getMonster(); + const auto &npc = creature->getNpc(); if (monster) { if (!monster->isFamiliar()) { return false; @@ -978,17 +974,17 @@ bool Player::canWalkthrough(std::shared_ptr<Creature> creature) { } if (player) { - std::shared_ptr<Tile> playerTile = player->getTile(); + const auto &playerTile = player->getTile(); if (!playerTile || (!playerTile->hasFlag(TILESTATE_NOPVPZONE) && !playerTile->hasFlag(TILESTATE_PROTECTIONZONE) && player->getLevel() > static_cast<uint32_t>(g_configManager().getNumber(PROTECTION_LEVEL)) && g_game().getWorldType() != WORLD_TYPE_NO_PVP)) { return false; } - std::shared_ptr<Item> playerTileGround = playerTile->getGround(); + const auto &playerTileGround = playerTile->getGround(); if (!playerTileGround || !playerTileGround->hasWalkStack()) { return false; } - std::shared_ptr<Player> thisPlayer = getPlayer(); + const auto &thisPlayer = getPlayer(); if ((OTSYS_TIME() - lastWalkthroughAttempt) > 2000) { thisPlayer->setLastWalkthroughAttempt(OTSYS_TIME()); return false; @@ -1002,20 +998,20 @@ bool Player::canWalkthrough(std::shared_ptr<Creature> creature) { thisPlayer->setLastWalkthroughPosition(creature->getPosition()); return true; } else if (npc) { - std::shared_ptr<Tile> tile = npc->getTile(); - std::shared_ptr<HouseTile> houseTile = std::dynamic_pointer_cast<HouseTile>(tile); + const auto &tile = npc->getTile(); + const auto &houseTile = std::dynamic_pointer_cast<HouseTile>(tile); return (houseTile != nullptr); } return false; } -bool Player::canWalkthroughEx(std::shared_ptr<Creature> creature) { +bool Player::canWalkthroughEx(const std::shared_ptr<Creature> &creature) const { if (group->access) { return true; } - std::shared_ptr<Monster> monster = creature->getMonster(); + const auto &monster = creature->getMonster(); if (monster) { if (!monster->isFamiliar()) { return false; @@ -1023,14 +1019,14 @@ bool Player::canWalkthroughEx(std::shared_ptr<Creature> creature) { return true; } - std::shared_ptr<Player> player = creature->getPlayer(); - std::shared_ptr<Npc> npc = creature->getNpc(); + const auto &player = creature->getPlayer(); + const auto &npc = creature->getNpc(); if (player) { - std::shared_ptr<Tile> playerTile = player->getTile(); + const auto &playerTile = player->getTile(); return playerTile && (playerTile->hasFlag(TILESTATE_NOPVPZONE) || playerTile->hasFlag(TILESTATE_PROTECTIONZONE) || player->getLevel() <= static_cast<uint32_t>(g_configManager().getNumber(PROTECTION_LEVEL)) || g_game().getWorldType() == WORLD_TYPE_NO_PVP); } else if (npc) { - std::shared_ptr<Tile> tile = npc->getTile(); - std::shared_ptr<HouseTile> houseTile = std::dynamic_pointer_cast<HouseTile>(tile); + const auto &tile = npc->getTile(); + const auto &houseTile = std::dynamic_pointer_cast<HouseTile>(tile); return (houseTile != nullptr); } else { return false; @@ -1043,9 +1039,9 @@ void Player::onReceiveMail() { } } -std::shared_ptr<Container> Player::refreshManagedContainer(ObjectCategory_t category, std::shared_ptr<Container> container, bool isLootContainer, bool loading /* = false*/) { +std::shared_ptr<Container> Player::refreshManagedContainer(ObjectCategory_t category, const std::shared_ptr<Container> &container, bool isLootContainer, bool loading /* = false*/) { std::shared_ptr<Container> previousContainer = nullptr; - auto toSetAttribute = isLootContainer ? ItemAttribute_t::QUICKLOOTCONTAINER : ItemAttribute_t::OBTAINCONTAINER; + const auto toSetAttribute = isLootContainer ? ItemAttribute_t::QUICKLOOTCONTAINER : ItemAttribute_t::OBTAINCONTAINER; if (auto it = m_managedContainers.find(category); it != m_managedContainers.end() && !loading) { previousContainer = isLootContainer ? it->second.first : it->second.second; if (previousContainer) { @@ -1071,7 +1067,7 @@ std::shared_ptr<Container> Player::refreshManagedContainer(ObjectCategory_t cate if (container) { previousContainer = container; - if (m_managedContainers.find(category) != m_managedContainers.end()) { + if (m_managedContainers.contains(category)) { if (isLootContainer) { m_managedContainers[category].first = container; } else { @@ -1090,8 +1086,8 @@ std::shared_ptr<Container> Player::refreshManagedContainer(ObjectCategory_t cate } if (!loading) { - auto flags = container->getAttribute<uint32_t>(toSetAttribute); - auto sendAttribute = flags | (1 << category); + const auto flags = container->getAttribute<uint32_t>(toSetAttribute); + const auto sendAttribute = flags | (1 << category); container->setAttribute(toSetAttribute, sendAttribute); } } @@ -1104,7 +1100,7 @@ std::shared_ptr<Container> Player::getManagedContainer(ObjectCategory_t category category = OBJECTCATEGORY_DEFAULT; } - auto it = m_managedContainers.find(category); + const auto it = m_managedContainers.find(category); std::shared_ptr<Container> container = nullptr; if (it != m_managedContainers.end()) { container = isLootContainer ? it->second.first : it->second.second; @@ -1118,15 +1114,15 @@ std::shared_ptr<Container> Player::getManagedContainer(ObjectCategory_t category return container; } -void Player::checkLootContainers(std::shared_ptr<Container> container) { +void Player::checkLootContainers(const std::shared_ptr<Container> &container) { if (!container) { return; } bool shouldSend = false; for (auto it = m_managedContainers.begin(); it != m_managedContainers.end();) { - std::shared_ptr<Container> &lootContainer = it->second.first; - std::shared_ptr<Container> &obtainContainer = it->second.second; + auto &lootContainer = it->second.first; + auto &obtainContainer = it->second.second; bool removeLoot = false; bool removeObtain = false; if (lootContainer && container->getHoldingPlayer() != getPlayer() && (container == lootContainer || container->isHoldingItem(lootContainer))) { @@ -1161,15 +1157,15 @@ void Player::checkLootContainers(std::shared_ptr<Container> container) { } } -void Player::setMainBackpackUnassigned(std::shared_ptr<Container> container) { +void Player::setMainBackpackUnassigned(const std::shared_ptr<Container> &container) { if (!container) { return; } // Update containers bool toSendInventoryUpdate = false; - for (bool isLootContainer : { true, false }) { - std::shared_ptr<Container> managedContainer = getManagedContainer(OBJECTCATEGORY_DEFAULT, isLootContainer); + for (const bool isLootContainer : { true, false }) { + const auto &managedContainer = getManagedContainer(OBJECTCATEGORY_DEFAULT, isLootContainer); if (!managedContainer) { refreshManagedContainer(OBJECTCATEGORY_DEFAULT, container, isLootContainer); toSendInventoryUpdate = true; @@ -1182,7 +1178,7 @@ void Player::setMainBackpackUnassigned(std::shared_ptr<Container> container) { } } -void Player::sendLootStats(std::shared_ptr<Item> item, uint8_t count) { +void Player::sendLootStats(const std::shared_ptr<Item> &item, uint8_t count) { uint64_t value = 0; if (item->getID() == ITEM_GOLD_COIN || item->getID() == ITEM_PLATINUM_COIN || item->getID() == ITEM_CRYSTAL_COIN) { if (item->getID() == ITEM_PLATINUM_COIN) { @@ -1193,7 +1189,7 @@ void Player::sendLootStats(std::shared_ptr<Item> item, uint8_t count) { value = count; } } else if ( - auto npc = g_game().getNpcByName("The Lootmonger") + const auto &npc = g_game().getNpcByName("The Lootmonger") ) { const auto &iType = Item::items.getItemType(item->getID()); value = iType.sellPrice * count; @@ -1213,7 +1209,7 @@ bool Player::isNearDepotBox() { const Position &pos = getPosition(); for (int32_t cx = -1; cx <= 1; ++cx) { for (int32_t cy = -1; cy <= 1; ++cy) { - std::shared_ptr<Tile> posTile = g_game().map.getTile(static_cast<uint16_t>(pos.x + cx), static_cast<uint16_t>(pos.y + cy), pos.z); + const auto &posTile = g_game().map.getTile(static_cast<uint16_t>(pos.x + cx), static_cast<uint16_t>(pos.y + cy), pos.z); if (!posTile) { continue; } @@ -1227,7 +1223,7 @@ bool Player::isNearDepotBox() { } std::shared_ptr<DepotChest> Player::getDepotChest(uint32_t depotId, bool autoCreate) { - auto it = depotChests.find(depotId); + const auto it = depotChests.find(depotId); if (it != depotChests.end()) { return it->second; } @@ -1252,11 +1248,11 @@ std::shared_ptr<DepotChest> Player::getDepotChest(uint32_t depotId, bool autoCre } std::shared_ptr<DepotLocker> Player::getDepotLocker(uint32_t depotId) { - auto it = depotLockerMap.find(depotId); + const auto it = depotLockerMap.find(depotId); if (it != depotLockerMap.end()) { inbox->setParent(it->second); for (uint32_t i = g_configManager().getNumber(DEPOT_BOXES); i > 0; i--) { - if (std::shared_ptr<DepotChest> depotBox = getDepotChest(i, false)) { + if (const auto &depotBox = getDepotChest(i, false)) { depotBox->setParent(it->second->getItemByIndex(0)->getContainer()); } } @@ -1264,18 +1260,20 @@ std::shared_ptr<DepotLocker> Player::getDepotLocker(uint32_t depotId) { } // We need to make room for supply stash on 12+ protocol versions and remove it for 10x. - bool createSupplyStash = !client->oldProtocol; + const bool createSupplyStash = !client->oldProtocol; - std::shared_ptr<DepotLocker> depotLocker = std::make_shared<DepotLocker>(ITEM_LOCKER, createSupplyStash ? 4 : 3); + auto depotLocker = std::make_shared<DepotLocker>(ITEM_LOCKER, createSupplyStash ? 4 : 3); depotLocker->setDepotId(depotId); - depotLocker->internalAddThing(Item::CreateItem(ITEM_MARKET)); + const auto &marketItem = Item::CreateItem(ITEM_MARKET); + depotLocker->internalAddThing(marketItem); depotLocker->internalAddThing(inbox); if (createSupplyStash) { - depotLocker->internalAddThing(Item::CreateItem(ITEM_SUPPLY_STASH)); + const auto &supplyStash = Item::CreateItem(ITEM_SUPPLY_STASH); + depotLocker->internalAddThing(supplyStash); } - std::shared_ptr<Container> depotChest = Item::CreateItemAsContainer(ITEM_DEPOT, static_cast<uint16_t>(g_configManager().getNumber(DEPOT_BOXES))); + const auto &depotChest = Item::CreateItemAsContainer(ITEM_DEPOT, static_cast<uint16_t>(g_configManager().getNumber(DEPOT_BOXES))); for (uint32_t i = g_configManager().getNumber(DEPOT_BOXES); i > 0; i--) { - std::shared_ptr<DepotChest> depotBox = getDepotChest(i, true); + const auto &depotBox = getDepotChest(i, true); depotChest->internalAddThing(depotBox); depotBox->setParent(depotChest); } @@ -1294,7 +1292,7 @@ std::shared_ptr<RewardChest> Player::getRewardChest() { } std::shared_ptr<Reward> Player::getReward(const uint64_t rewardId, const bool autoCreate) { - auto it = rewardMap.find(rewardId); + const auto it = rewardMap.find(rewardId); if (it != rewardMap.end()) { return it->second; } @@ -1316,20 +1314,20 @@ void Player::removeReward(uint64_t rewardId) { void Player::getRewardList(std::vector<uint64_t> &rewards) const { rewards.reserve(rewardMap.size()); - for (auto &it : rewardMap) { - rewards.push_back(it.first); + for (const auto &[rewardId, snd] : rewardMap) { + rewards.emplace_back(rewardId); } } -std::vector<std::shared_ptr<Item>> Player::getRewardsFromContainer(std::shared_ptr<Container> container) const { +std::vector<std::shared_ptr<Item>> Player::getRewardsFromContainer(const std::shared_ptr<Container> &container) const { std::vector<std::shared_ptr<Item>> rewardItemsVector; if (container) { for (const auto &item : container->getItems(false)) { if (item->getID() == ITEM_REWARD_CONTAINER) { - auto items = getRewardsFromContainer(item->getContainer()); + const auto &items = getRewardsFromContainer(item->getContainer()); rewardItemsVector.insert(rewardItemsVector.end(), items.begin(), items.end()); } else { - rewardItemsVector.push_back(item); + rewardItemsVector.emplace_back(item); } } } @@ -1348,9 +1346,9 @@ void Player::sendStats() { } } -void Player::updateSupplyTracker(std::shared_ptr<Item> item) { +void Player::updateSupplyTracker(const std::shared_ptr<Item> &item) { const auto &iType = Item::items.getItemType(item->getID()); - auto value = iType.buyPrice; + const auto value = iType.buyPrice; g_metrics().addCounter("player_supply", value, { { "player", getName() } }); if (client) { @@ -1369,7 +1367,7 @@ void Player::updateImpactTracker(CombatType_t type, int32_t amount) const { } void Player::sendPing() { - int64_t timeNow = OTSYS_TIME(); + const int64_t timeNow = OTSYS_TIME(); bool hasLostConnection = false; if ((timeNow - lastPing) >= 5000) { @@ -1381,8 +1379,8 @@ void Player::sendPing() { } } - int64_t noPongTime = timeNow - lastPong; - auto attackedCreature = getAttackedCreature(); + const int64_t noPongTime = timeNow - lastPong; + const auto &attackedCreature = getAttackedCreature(); if ((hasLostConnection || noPongTime >= 7000) && attackedCreature && attackedCreature->getPlayer()) { setAttackedCreature(nullptr); } @@ -1403,11 +1401,11 @@ std::shared_ptr<Item> Player::getWriteItem(uint32_t &retWindowTextId, uint16_t & return writeItem; } -void Player::setImbuingItem(std::shared_ptr<Item> item) { +void Player::setImbuingItem(const std::shared_ptr<Item> &item) { imbuingItem = item; } -void Player::setWriteItem(std::shared_ptr<Item> item, uint16_t maxWriteLength /*= 0*/) { +void Player::setWriteItem(const std::shared_ptr<Item> &item, uint16_t maxWriteLength /*= 0*/) { windowTextId++; if (item) { @@ -1425,13 +1423,13 @@ std::shared_ptr<House> Player::getEditHouse(uint32_t &retWindowTextId, uint32_t return editHouse; } -void Player::setEditHouse(std::shared_ptr<House> house, uint32_t listId /*= 0*/) { +void Player::setEditHouse(const std::shared_ptr<House> &house, uint32_t listId /*= 0*/) { windowTextId++; editHouse = house; editListId = listId; } -void Player::sendHouseWindow(std::shared_ptr<House> house, uint32_t listId) const { +void Player::sendHouseWindow(const std::shared_ptr<House> &house, uint32_t listId) const { if (!client) { return; } @@ -1442,7 +1440,7 @@ void Player::sendHouseWindow(std::shared_ptr<House> house, uint32_t listId) cons } } -void Player::onApplyImbuement(Imbuement* imbuement, std::shared_ptr<Item> item, uint8_t slot, bool protectionCharm) { +void Player::onApplyImbuement(const Imbuement* imbuement, const std::shared_ptr<Item> &item, uint8_t slot, bool protectionCharm) { if (!imbuement || !item) { return; } @@ -1454,7 +1452,7 @@ void Player::onApplyImbuement(Imbuement* imbuement, std::shared_ptr<Item> item, return; } - const auto items = imbuement->getItems(); + const auto &items = imbuement->getItems(); for (auto &[key, value] : items) { const ItemType &itemType = Item::items[key]; if (static_self_cast<Player>()->getItemTypeCount(key) + this->getStashItemCount(itemType.id) < value) { @@ -1472,7 +1470,7 @@ void Player::onApplyImbuement(Imbuement* imbuement, std::shared_ptr<Item> item, price += protectionCharm ? baseImbuement->protectionPrice : 0; if (!g_game().removeMoney(static_self_cast<Player>(), price, 0, true)) { - std::string message = fmt::format("You don't have {} gold coins.", price); + const std::string message = fmt::format("You don't have {} gold coins.", price); g_logger().error("[Player::onApplyImbuement] - An error occurred while player with name {} try to apply imbuement, player do not have money", this->getName()); sendImbuementResult(message); @@ -1484,7 +1482,7 @@ void Player::onApplyImbuement(Imbuement* imbuement, std::shared_ptr<Item> item, for (auto &[key, value] : items) { std::stringstream withdrawItemMessage; - uint32_t inventoryItemCount = getItemTypeCount(key); + const uint32_t inventoryItemCount = getItemTypeCount(key); if (inventoryItemCount >= value) { removeItemOfType(key, value, -1, true); continue; @@ -1518,7 +1516,7 @@ void Player::onApplyImbuement(Imbuement* imbuement, std::shared_ptr<Item> item, openImbuementWindow(item); } -void Player::onClearImbuement(std::shared_ptr<Item> item, uint8_t slot) { +void Player::onClearImbuement(const std::shared_ptr<Item> &item, uint8_t slot) { if (!item) { return; } @@ -1536,7 +1534,7 @@ void Player::onClearImbuement(std::shared_ptr<Item> item, uint8_t slot) { } if (!g_game().removeMoney(static_self_cast<Player>(), baseImbuement->removeCost, 0, true)) { - std::string message = fmt::format("You don't have {} gold coins.", baseImbuement->removeCost); + const std::string message = fmt::format("You don't have {} gold coins.", baseImbuement->removeCost); g_logger().error("[Player::onClearImbuement] - An error occurred while player with name {} try to apply imbuement, player do not have money", this->getName()); this->sendImbuementResult(message); @@ -1553,7 +1551,7 @@ void Player::onClearImbuement(std::shared_ptr<Item> item, uint8_t slot) { this->openImbuementWindow(item); } -void Player::openImbuementWindow(std::shared_ptr<Item> item) { +void Player::openImbuementWindow(const std::shared_ptr<Item> &item) { if (!client || !item) { return; } @@ -1563,7 +1561,7 @@ void Player::openImbuementWindow(std::shared_ptr<Item> item) { return; } - auto itemParent = item->getTopParent(); + const auto &itemParent = item->getTopParent(); if (itemParent && itemParent != getPlayer()) { this->sendTextMessage(MESSAGE_EVENT_ADVANCE, "You have to pick up the item to imbue it."); return; @@ -1578,7 +1576,7 @@ void Player::sendSaleItemList(const std::map<uint16_t, uint16_t> &inventoryMap) } } -void Player::sendMarketEnter(uint32_t depotId) { +void Player::sendMarketEnter(uint32_t depotId) const { if (!client || this->getLastDepotId() == -1 || !depotId) { return; } @@ -1587,7 +1585,7 @@ void Player::sendMarketEnter(uint32_t depotId) { } // container -void Player::sendAddContainerItem(std::shared_ptr<Container> container, std::shared_ptr<Item> item) { +void Player::sendAddContainerItem(const std::shared_ptr<Container> &container, std::shared_ptr<Item> item) { if (!client) { return; } @@ -1596,54 +1594,52 @@ void Player::sendAddContainerItem(std::shared_ptr<Container> container, std::sha return; } - for (const auto &it : openContainers) { - const OpenContainer &openContainer = it.second; - if (openContainer.container != container) { + for (const auto &[containerId, containerInfo] : openContainers) { + if (containerInfo.container != container) { continue; } - uint16_t slot = openContainer.index; + uint16_t slot = containerInfo.index; if (container->getID() == ITEM_BROWSEFIELD) { - uint16_t containerSize = container->size() - 1; - uint16_t pageEnd = openContainer.index + container->capacity() - 1; + const uint16_t containerSize = container->size() - 1; + const uint16_t pageEnd = containerInfo.index + container->capacity() - 1; if (containerSize > pageEnd) { slot = pageEnd; item = container->getItemByIndex(pageEnd); } else { slot = containerSize; } - } else if (openContainer.index >= container->capacity()) { - item = container->getItemByIndex(openContainer.index - 1); + } else if (containerInfo.index >= container->capacity()) { + item = container->getItemByIndex(containerInfo.index - 1); } - client->sendAddContainerItem(it.first, slot, item); + client->sendAddContainerItem(containerId, slot, item); } } -void Player::sendUpdateContainerItem(std::shared_ptr<Container> container, uint16_t slot, std::shared_ptr<Item> newItem) { +void Player::sendUpdateContainerItem(const std::shared_ptr<Container> &container, uint16_t slot, const std::shared_ptr<Item> &newItem) { if (!client) { return; } - for (const auto &it : openContainers) { - const OpenContainer &openContainer = it.second; - if (openContainer.container != container) { + for (const auto &[containerId, containerInfo] : openContainers) { + if (containerInfo.container != container) { continue; } - if (slot < openContainer.index) { + if (slot < containerInfo.index) { continue; } - uint16_t pageEnd = openContainer.index + container->capacity(); + const uint16_t pageEnd = containerInfo.index + container->capacity(); if (slot >= pageEnd) { continue; } - client->sendUpdateContainerItem(it.first, slot, newItem); + client->sendUpdateContainerItem(containerId, slot, newItem); } } -void Player::sendRemoveContainerItem(std::shared_ptr<Container> container, uint16_t slot) { +void Player::sendRemoveContainerItem(const std::shared_ptr<Container> &container, uint16_t slot) { if (!client) { return; } @@ -1652,23 +1648,22 @@ void Player::sendRemoveContainerItem(std::shared_ptr<Container> container, uint1 return; } - for (auto &it : openContainers) { - OpenContainer &openContainer = it.second; - if (openContainer.container != container) { + for (auto &[containerId, containerInfo] : openContainers) { + if (containerInfo.container != container) { continue; } - uint16_t &firstIndex = openContainer.index; + uint16_t &firstIndex = containerInfo.index; if (firstIndex > 0 && firstIndex >= container->size() - 1) { firstIndex -= container->capacity(); - sendContainer(it.first, container, false, firstIndex); + sendContainer(containerId, container, false, firstIndex); } - client->sendRemoveContainerItem(it.first, std::max<uint16_t>(slot, firstIndex), container->getItemByIndex(container->capacity() + firstIndex)); + client->sendRemoveContainerItem(containerId, std::max<uint16_t>(slot, firstIndex), container->getItemByIndex(container->capacity() + firstIndex)); } } -void Player::onUpdateTileItem(std::shared_ptr<Tile> updateTile, const Position &pos, std::shared_ptr<Item> oldItem, const ItemType &oldType, std::shared_ptr<Item> newItem, const ItemType &newType) { +void Player::onUpdateTileItem(const std::shared_ptr<Tile> &updateTile, const Position &pos, const std::shared_ptr<Item> &oldItem, const ItemType &oldType, const std::shared_ptr<Item> &newItem, const ItemType &newType) { Creature::onUpdateTileItem(updateTile, pos, oldItem, oldType, newItem, newType); if (oldItem != newItem) { @@ -1682,14 +1677,14 @@ void Player::onUpdateTileItem(std::shared_ptr<Tile> updateTile, const Position & } } -void Player::onRemoveTileItem(std::shared_ptr<Tile> fromTile, const Position &pos, const ItemType &iType, std::shared_ptr<Item> item) { +void Player::onRemoveTileItem(const std::shared_ptr<Tile> &fromTile, const Position &pos, const ItemType &iType, const std::shared_ptr<Item> &item) { Creature::onRemoveTileItem(fromTile, pos, iType, item); if (tradeState != TRADE_TRANSFER) { checkTradeState(item); if (tradeItem) { - std::shared_ptr<Container> container = item->getContainer(); + const auto &container = item->getContainer(); if (container && container->isHoldingItem(tradeItem)) { g_game().internalCloseTrade(static_self_cast<Player>()); } @@ -1699,7 +1694,7 @@ void Player::onRemoveTileItem(std::shared_ptr<Tile> fromTile, const Position &po checkLootContainers(item->getContainer()); } -void Player::onCreatureAppear(std::shared_ptr<Creature> creature, bool isLogin) { +void Player::onCreatureAppear(const std::shared_ptr<Creature> &creature, bool isLogin) { Creature::onCreatureAppear(creature, isLogin); if (isLogin && creature == getPlayer()) { @@ -1717,7 +1712,7 @@ void Player::onCreatureAppear(std::shared_ptr<Creature> creature, bool isLogin) updateRegeneration(); - std::shared_ptr<BedItem> bed = g_game().getBedBySleeper(guid); + const auto &bed = g_game().getBedBySleeper(guid); if (bed) { bed->wakeUp(static_self_cast<Player>()); } @@ -1737,7 +1732,7 @@ void Player::onCreatureAppear(std::shared_ptr<Creature> creature, bool isLogin) offlineTime = 0; } - for (const std::shared_ptr<Condition> &condition : getMuteConditions()) { + for (const auto &condition : getMuteConditions()) { condition->setTicks(condition->getTicks() - (offlineTime * 1000)); if (condition->getTicks() <= 0) { removeCondition(condition); @@ -1745,7 +1740,6 @@ void Player::onCreatureAppear(std::shared_ptr<Creature> creature, bool isLogin) } g_game().checkPlayersRecord(); - IOLoginData::updateOnlineStatus(guid, true); if (getLevel() < g_configManager().getNumber(ADVENTURERSBLESSING_LEVEL) && getVocationId() > VOCATION_NONE) { for (uint8_t i = 2; i <= 6; i++) { if (!hasBlessing(i)) { @@ -1815,7 +1809,7 @@ void Player::onChangeZone(ZoneType_t zone) { } void Player::onAttackedCreatureChangeZone(ZoneType_t zone) { - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (!attackedCreature) { return; } @@ -1840,10 +1834,10 @@ void Player::onAttackedCreatureChangeZone(ZoneType_t zone) { } } -void Player::onRemoveCreature(std::shared_ptr<Creature> creature, bool isLogout) { +void Player::onRemoveCreature(const std::shared_ptr<Creature> &creature, bool isLogout) { Creature::onRemoveCreature(creature, isLogout); - if (auto player = getPlayer(); player == creature) { + if (const auto &player = getPlayer(); player == creature) { if (isLogout) { onDeEquipInventory(); @@ -1860,7 +1854,6 @@ void Player::onRemoveCreature(std::shared_ptr<Creature> creature, bool isLogout) g_logger().info("{} has logged out", getName()); g_chat().removeUserFromAllChannels(player); clearPartyInvitations(); - IOLoginData::updateOnlineStatus(guid, false); } if (eventWalk != 0) { @@ -1882,7 +1875,7 @@ void Player::onRemoveCreature(std::shared_ptr<Creature> creature, bool isLogout) } } -bool Player::openShopWindow(std::shared_ptr<Npc> npc, const std::vector<ShopBlock> &shopItems) { +bool Player::openShopWindow(const std::shared_ptr<Npc> &npc, const std::vector<ShopBlock> &shopItems) { Benchmark brenchmark; if (!npc) { g_logger().error("[Player::openShopWindow] - Npc is wrong or nullptr"); @@ -1920,11 +1913,11 @@ bool Player::closeShopWindow() { void Player::onWalk(Direction &dir) { if (hasCondition(CONDITION_FEARED)) { - Position pos = getNextPosition(dir, getPosition()); + const Position pos = getNextPosition(dir, getPosition()); - std::shared_ptr<Tile> tile = g_game().map.getTile(pos); + const auto &tile = g_game().map.getTile(pos); if (tile) { - std::shared_ptr<MagicField> field = tile->getFieldItem(); + const auto &field = tile->getFieldItem(); if (field && !field->isBlocking() && field->getDamage() != 0) { setNextActionTask(nullptr); setNextAction(OTSYS_TIME() + getStepDuration(dir)); @@ -1966,7 +1959,7 @@ void Player::onCreatureMove(const std::shared_ptr<Creature> &creature, const std // close modal windows if (!modalWindows.empty()) { // TODO: This shouldn't be hardcoded - for (uint32_t modalWindowId : modalWindows) { + for (const uint32_t modalWindowId : modalWindows) { if (modalWindowId == std::numeric_limits<uint32_t>::max()) { sendTextMessage(MESSAGE_EVENT_ADVANCE, "Offline training aborted."); break; @@ -1997,7 +1990,7 @@ void Player::onCreatureMove(const std::shared_ptr<Creature> &creature, const std void Player::onEquipInventory() { for (int32_t slot = CONST_SLOT_FIRST; slot <= CONST_SLOT_LAST; ++slot) { - std::shared_ptr<Item> item = inventory[slot]; + const auto &item = inventory[slot]; if (item) { item->startDecaying(); g_moveEvents().onPlayerEquip(getPlayer(), item, static_cast<Slots_t>(slot), false); @@ -2007,7 +2000,7 @@ void Player::onEquipInventory() { void Player::onDeEquipInventory() { for (int32_t slot = CONST_SLOT_FIRST; slot <= CONST_SLOT_LAST; ++slot) { - std::shared_ptr<Item> item = inventory[slot]; + const auto &item = inventory[slot]; if (item) { g_moveEvents().onPlayerDeEquip(getPlayer(), item, static_cast<Slots_t>(slot)); } @@ -2015,11 +2008,11 @@ void Player::onDeEquipInventory() { } // container -void Player::onAddContainerItem(std::shared_ptr<Item> item) { +void Player::onAddContainerItem(const std::shared_ptr<Item> &item) { checkTradeState(item); } -void Player::onUpdateContainerItem(std::shared_ptr<Container> container, std::shared_ptr<Item> oldItem, std::shared_ptr<Item> newItem) { +void Player::onUpdateContainerItem(const std::shared_ptr<Container> &container, const std::shared_ptr<Item> &oldItem, const std::shared_ptr<Item> &newItem) { if (oldItem != newItem) { onRemoveContainerItem(container, oldItem); } @@ -2029,7 +2022,7 @@ void Player::onUpdateContainerItem(std::shared_ptr<Container> container, std::sh } } -void Player::onRemoveContainerItem(std::shared_ptr<Container> container, std::shared_ptr<Item> item) { +void Player::onRemoveContainerItem(const std::shared_ptr<Container> &container, const std::shared_ptr<Item> &item) { if (tradeState != TRADE_TRANSFER) { checkTradeState(item); @@ -2043,34 +2036,33 @@ void Player::onRemoveContainerItem(std::shared_ptr<Container> container, std::sh checkLootContainers(item->getContainer()); } -void Player::onCloseContainer(std::shared_ptr<Container> container) { +void Player::onCloseContainer(const std::shared_ptr<Container> &container) { if (!client) { return; } - for (const auto &it : openContainers) { - if (it.second.container == container) { - client->sendCloseContainer(it.first); + for (const auto &[containerId, containerInfo] : openContainers) { + if (containerInfo.container == container) { + client->sendCloseContainer(containerId); } } } -void Player::onSendContainer(std::shared_ptr<Container> container) { +void Player::onSendContainer(const std::shared_ptr<Container> &container) { if (!client || !container) { return; } - bool hasParent = container->hasParent(); - for (const auto &it : openContainers) { - const OpenContainer &openContainer = it.second; - if (openContainer.container == container) { - client->sendContainer(it.first, container, hasParent, openContainer.index); + const bool hasParent = container->hasParent(); + for (const auto &[containerId, containerInfo] : openContainers) { + if (containerInfo.container == container) { + client->sendContainer(containerId, container, hasParent, containerInfo.index); } } } // inventory -void Player::onUpdateInventoryItem(std::shared_ptr<Item> oldItem, std::shared_ptr<Item> newItem) { +void Player::onUpdateInventoryItem(const std::shared_ptr<Item> &oldItem, const std::shared_ptr<Item> &newItem) { if (oldItem != newItem) { onRemoveInventoryItem(oldItem); } @@ -2080,12 +2072,12 @@ void Player::onUpdateInventoryItem(std::shared_ptr<Item> oldItem, std::shared_pt } } -void Player::onRemoveInventoryItem(std::shared_ptr<Item> item) { +void Player::onRemoveInventoryItem(const std::shared_ptr<Item> &item) { if (tradeState != TRADE_TRANSFER) { checkTradeState(item); if (tradeItem) { - std::shared_ptr<Container> container = item->getContainer(); + const auto &container = item->getContainer(); if (container && container->isHoldingItem(tradeItem)) { g_game().internalCloseTrade(static_self_cast<Player>()); } @@ -2095,7 +2087,7 @@ void Player::onRemoveInventoryItem(std::shared_ptr<Item> item) { checkLootContainers(item->getContainer()); } -void Player::checkTradeState(std::shared_ptr<Item> item) { +void Player::checkTradeState(const std::shared_ptr<Item> &item) { if (!tradeItem || tradeState == TRADE_TRANSFER) { return; } @@ -2103,7 +2095,7 @@ void Player::checkTradeState(std::shared_ptr<Item> item) { if (tradeItem == item) { g_game().internalCloseTrade(static_self_cast<Player>()); } else { - std::shared_ptr<Container> container = std::dynamic_pointer_cast<Container>(item->getParent()); + auto container = std::dynamic_pointer_cast<Container>(item->getParent()); while (container) { if (container == tradeItem) { g_game().internalCloseTrade(static_self_cast<Player>()); @@ -2115,7 +2107,7 @@ void Player::checkTradeState(std::shared_ptr<Item> item) { } } -void Player::setNextWalkActionTask(std::shared_ptr<Task> task) { +void Player::setNextWalkActionTask(const std::shared_ptr<Task> &task) { if (walkTaskEvent != 0) { g_dispatcher().stopEvent(walkTaskEvent); walkTaskEvent = 0; @@ -2124,7 +2116,7 @@ void Player::setNextWalkActionTask(std::shared_ptr<Task> task) { walkTask = task; } -void Player::setNextWalkTask(std::shared_ptr<Task> task) { +void Player::setNextWalkTask(const std::shared_ptr<Task> &task) { if (nextStepEvent != 0) { g_dispatcher().stopEvent(nextStepEvent); nextStepEvent = 0; @@ -2136,7 +2128,7 @@ void Player::setNextWalkTask(std::shared_ptr<Task> task) { } } -void Player::setNextActionTask(std::shared_ptr<Task> task, bool resetIdleTime /*= true */) { +void Player::setNextActionTask(const std::shared_ptr<Task> &task, bool resetIdleTime /*= true */) { if (actionTaskEvent != 0) { g_dispatcher().stopEvent(actionTaskEvent); actionTaskEvent = 0; @@ -2154,7 +2146,7 @@ void Player::setNextActionTask(std::shared_ptr<Task> task, bool resetIdleTime /* } } -void Player::setNextActionPushTask(std::shared_ptr<Task> task) { +void Player::setNextActionPushTask(const std::shared_ptr<Task> &task) { if (actionTaskEventPush != 0) { g_dispatcher().stopEvent(actionTaskEventPush); actionTaskEventPush = 0; @@ -2165,7 +2157,7 @@ void Player::setNextActionPushTask(std::shared_ptr<Task> task) { } } -void Player::setNextPotionActionTask(std::shared_ptr<Task> task) { +void Player::setNextPotionActionTask(const std::shared_ptr<Task> &task) { if (actionPotionTaskEvent != 0) { g_dispatcher().stopEvent(actionPotionTaskEvent); actionPotionTaskEvent = 0; @@ -2210,7 +2202,7 @@ void Player::onThink(uint32_t interval) { triggerTranscendance(); // Momentum (cooldown resets) triggerMomentum(); - auto playerTile = getTile(); + const auto &playerTile = getTile(); const bool vipStaysOnline = isVip() && g_configManager().getBoolean(VIP_STAY_ONLINE); idleTime += interval; if (playerTile && !playerTile->hasFlag(TILESTATE_NOLOGOUT) && !isAccessPlayer() && !isExerciseTraining() && !vipStaysOnline) { @@ -2245,7 +2237,7 @@ uint32_t Player::isMuted() const { } int32_t muteTicks = 0; - for (const std::shared_ptr<Condition> &condition : conditions) { + for (const auto &condition : conditions) { if (condition->getType() == CONDITION_MUTED && condition->getTicks() > muteTicks) { muteTicks = condition->getTicks(); } @@ -2268,14 +2260,14 @@ void Player::removeMessageBuffer() { if (maxMessageBuffer != 0 && MessageBufferCount <= maxMessageBuffer + 1) { if (++MessageBufferCount > maxMessageBuffer) { uint32_t muteCount = 1; - auto it = muteCountMap.find(guid); + const auto it = muteCountMap.find(guid); if (it != muteCountMap.end()) { muteCount = it->second; } - uint32_t muteTime = 5 * muteCount * muteCount; + const uint32_t muteTime = 5 * muteCount * muteCount; muteCountMap[guid] = muteCount + 1; - std::shared_ptr<Condition> condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_MUTED, muteTime * 1000, 0); + const auto &condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_MUTED, muteTime * 1000, 0); addCondition(condition); std::ostringstream ss; @@ -2285,7 +2277,7 @@ void Player::removeMessageBuffer() { } } -void Player::drainHealth(std::shared_ptr<Creature> attacker, int32_t damage) { +void Player::drainHealth(const std::shared_ptr<Creature> &attacker, int32_t damage) { if (PLAYER_SOUND_HEALTH_CHANGE >= static_cast<uint32_t>(uniform_random(1, 100))) { g_game().sendSingleSoundEffect(static_self_cast<Player>()->getPosition(), sex == PLAYERSEX_FEMALE ? SoundEffect_t::HUMAN_FEMALE_BARK : SoundEffect_t::HUMAN_MALE_BARK, getPlayer()); } @@ -2294,7 +2286,7 @@ void Player::drainHealth(std::shared_ptr<Creature> attacker, int32_t damage) { sendStats(); } -void Player::drainMana(std::shared_ptr<Creature> attacker, int32_t manaLoss) { +void Player::drainMana(const std::shared_ptr<Creature> &attacker, int32_t manaLoss) { Creature::drainMana(attacker, manaLoss); sendStats(); } @@ -2342,7 +2334,7 @@ void Player::addManaSpent(uint64_t amount) { manaSpent += amount; - uint8_t oldPercent = magLevelPercent; + const uint8_t oldPercent = magLevelPercent; if (nextReqMana > currReqMana) { magLevelPercent = Player::getPercentLevel(manaSpent, nextReqMana); } else { @@ -2359,9 +2351,9 @@ void Player::addManaSpent(uint64_t amount) { } } -void Player::addExperience(std::shared_ptr<Creature> target, uint64_t exp, bool sendText /* = false*/) { - uint64_t currLevelExp = Player::getExpForLevel(level); - uint64_t nextLevelExp = Player::getExpForLevel(level + 1); +void Player::addExperience(const std::shared_ptr<Creature> &target, uint64_t exp, bool sendText /* = false*/) { + uint64_t currLevelExp = getExpForLevel(level); + uint64_t nextLevelExp = getExpForLevel(level + 1); uint64_t rawExp = exp; if (currLevelExp >= nextLevelExp) { // player has reached max level @@ -2377,8 +2369,8 @@ void Player::addExperience(std::shared_ptr<Creature> target, uint64_t exp, bool return; } - auto rate = exp / rawExp; - std::map<std::string, std::string> attrs({ { "player", getName() }, { "level", std::to_string(getLevel()) }, { "rate", std::to_string(rate) } }); + const auto rate = exp / rawExp; + const std::map<std::string, std::string> attrs({ { "player", getName() }, { "level", std::to_string(getLevel()) }, { "rate", std::to_string(rate) } }); if (sendText) { g_metrics().addCounter("player_experience_raw", rawExp, attrs); g_metrics().addCounter("player_experience_actual", exp, attrs); @@ -2388,8 +2380,8 @@ void Player::addExperience(std::shared_ptr<Creature> target, uint64_t exp, bool } // Hazard system experience - std::shared_ptr<Monster> monster = target && target->getMonster() ? target->getMonster() : nullptr; - bool handleHazardExperience = monster && monster->getHazard() && getHazardSystemPoints() > 0; + const auto &monster = target && target->getMonster() ? target->getMonster() : nullptr; + const bool handleHazardExperience = monster && monster->getHazard() && getHazardSystemPoints() > 0; if (handleHazardExperience) { exp += (exp * (1.75 * getHazardSystemPoints() * g_configManager().getFloat(HAZARD_EXP_BONUS_MULTIPLIER))) / 100.; } @@ -2416,13 +2408,13 @@ void Player::addExperience(std::shared_ptr<Creature> target, uint64_t exp, bool if (!spectators.empty()) { message.type = MESSAGE_EXPERIENCE_OTHERS; message.text = getName() + " gained " + expString; - for (const std::shared_ptr<Creature> &spectator : spectators) { + for (const auto &spectator : spectators) { spectator->getPlayer()->sendTextMessage(message); } } } - uint32_t prevLevel = level; + const uint32_t prevLevel = level; while (experience >= nextLevelExp) { ++level; // Player stats gain for vocations level <= 8 @@ -2442,7 +2434,7 @@ void Player::addExperience(std::shared_ptr<Creature> target, uint64_t exp, bool } currLevelExp = nextLevelExp; - nextLevelExp = Player::getExpForLevel(level + 1); + nextLevelExp = getExpForLevel(level + 1); if (currLevelExp >= nextLevelExp) { // player has reached max level break; @@ -2497,7 +2489,7 @@ void Player::removeExperience(uint64_t exp, bool sendText /* = false*/) { if (sendText) { lostExp -= experience; - std::string expString = fmt::format("You lost {} experience point{}.", lostExp, (lostExp != 1 ? "s" : "")); + const std::string expString = fmt::format("You lost {} experience point{}.", lostExp, (lostExp != 1 ? "s" : "")); TextMessage message(MESSAGE_EXPERIENCE, expString); message.position = position; @@ -2510,13 +2502,13 @@ void Player::removeExperience(uint64_t exp, bool sendText /* = false*/) { if (!spectators.empty()) { message.type = MESSAGE_EXPERIENCE_OTHERS; message.text = getName() + " lost " + expString; - for (const std::shared_ptr<Creature> &spectator : spectators) { + for (const auto &spectator : spectators) { spectator->getPlayer()->sendTextMessage(message); } } } - uint32_t oldLevel = level; + const uint32_t oldLevel = level; uint64_t currLevelExp = Player::getExpForLevel(level); while (level > 1 && experience < currLevelExp) { @@ -2555,7 +2547,7 @@ void Player::removeExperience(uint64_t exp, bool sendText /* = false*/) { sendTextMessage(MESSAGE_EVENT_ADVANCE, ss.str()); } - uint64_t nextLevelExp = Player::getExpForLevel(level + 1); + const uint64_t nextLevelExp = Player::getExpForLevel(level + 1); if (nextLevelExp > currLevelExp) { levelPercent = Player::getPercentLevel(experience - currLevelExp, nextLevelExp - currLevelExp); } else { @@ -2570,7 +2562,7 @@ double_t Player::getPercentLevel(uint64_t count, uint64_t nextLevelCount) { return 0; } - double_t result = round(((count * 100.) / nextLevelCount) * 100.) / 100.; + const double_t result = round(((count * 100.) / nextLevelCount) * 100.) / 100.; if (result > 100) { return 0; } @@ -2587,11 +2579,11 @@ void Player::onBlockHit() { } } -void Player::onTakeDamage(std::shared_ptr<Creature> attacker, int32_t damage) { +void Player::onTakeDamage(const std::shared_ptr<Creature> &attacker, int32_t damage) { // nothing here yet } -void Player::onAttackedCreatureBlockHit(BlockType_t blockType) { +void Player::onAttackedCreatureBlockHit(const BlockType_t &blockType) { lastAttackBlockType = blockType; switch (blockType) { @@ -2622,19 +2614,19 @@ void Player::onAttackedCreatureBlockHit(BlockType_t blockType) { } bool Player::hasShield() const { - std::shared_ptr<Item> item = inventory[CONST_SLOT_LEFT]; - if (item && item->getWeaponType() == WEAPON_SHIELD) { + const auto &itemLeft = inventory[CONST_SLOT_LEFT]; + if (itemLeft && itemLeft->getWeaponType() == WEAPON_SHIELD) { return true; } - item = inventory[CONST_SLOT_RIGHT]; - if (item && item->getWeaponType() == WEAPON_SHIELD) { + const auto &itemRight = inventory[CONST_SLOT_RIGHT]; + if (itemRight && itemRight->getWeaponType() == WEAPON_SHIELD) { return true; } return false; } -BlockType_t Player::blockHit(std::shared_ptr<Creature> attacker, CombatType_t combatType, int32_t &damage, bool checkDefense /* = false*/, bool checkArmor /* = false*/, bool field /* = false*/) { +BlockType_t Player::blockHit(const std::shared_ptr<Creature> &attacker, const CombatType_t &combatType, int32_t &damage, bool checkDefense /* = false*/, bool checkArmor /* = false*/, bool field /* = false*/) { BlockType_t blockType = Creature::blockHit(attacker, combatType, damage, checkDefense, checkArmor, field); if (attacker) { sendCreatureSquare(attacker, SQ_COLOR_BLACK); @@ -2650,43 +2642,47 @@ BlockType_t Player::blockHit(std::shared_ptr<Creature> attacker, CombatType_t co continue; } - std::shared_ptr<Item> item = inventory[slot]; + const auto &item = inventory[slot]; if (!item) { continue; } + for (uint8_t slotid = 0; slotid < item->getImbuementSlot(); slotid++) { + ImbuementInfo imbuementInfo; + if (!item->getImbuementInfo(slotid, &imbuementInfo)) { + continue; + } + + const int16_t &imbuementAbsorbPercent = imbuementInfo.imbuement->absorbPercent[combatTypeToIndex(combatType)]; + + if (imbuementAbsorbPercent != 0) { + damage -= std::ceil(damage * (imbuementAbsorbPercent / 100.)); + } + } + + // const ItemType &it = Item::items[item->getID()]; if (it.abilities) { + int totalAbsorbPercent = 0; const int16_t &absorbPercent = it.abilities->absorbPercent[combatTypeToIndex(combatType)]; - auto charges = item->getAttribute<uint16_t>(ItemAttribute_t::CHARGES); if (absorbPercent != 0) { - damage -= std::round(damage * (absorbPercent / 100.)); - if (charges != 0) { - g_game().transformItem(item, item->getID(), charges - 1); - } + totalAbsorbPercent += absorbPercent; } if (field) { const int16_t &fieldAbsorbPercent = it.abilities->fieldAbsorbPercent[combatTypeToIndex(combatType)]; if (fieldAbsorbPercent != 0) { - damage -= std::round(damage * (fieldAbsorbPercent / 100.)); - if (charges != 0) { - g_game().transformItem(item, item->getID(), charges - 1); - } + totalAbsorbPercent += fieldAbsorbPercent; } } - } - - for (uint8_t slotid = 0; slotid < item->getImbuementSlot(); slotid++) { - ImbuementInfo imbuementInfo; - if (!item->getImbuementInfo(slotid, &imbuementInfo)) { - continue; - } - const int16_t &imbuementAbsorbPercent = imbuementInfo.imbuement->absorbPercent[combatTypeToIndex(combatType)]; + if (totalAbsorbPercent > 0) { + damage -= std::round(damage * (totalAbsorbPercent / 100.0)); - if (imbuementAbsorbPercent != 0) { - damage -= std::ceil(damage * (imbuementAbsorbPercent / 100.)); + const auto charges = item->getAttribute<uint16_t>(ItemAttribute_t::CHARGES); + if (charges != 0) { + g_game().transformItem(item, item->getID(), charges - 1); + } } } } @@ -2703,7 +2699,7 @@ BlockType_t Player::blockHit(std::shared_ptr<Creature> attacker, CombatType_t co return blockType; } -void Player::death(std::shared_ptr<Creature> lastHitCreature) { +void Player::death(const std::shared_ptr<Creature> &lastHitCreature) { if (!g_configManager().getBoolean(TOGGLE_MOUNT_IN_PZ) && isMounted()) { dismount(); g_game().internalCreatureChangeOutfit(getPlayer(), defaultOutfit); @@ -2718,15 +2714,15 @@ void Player::death(std::shared_ptr<Creature> lastHitCreature) { int othersDmg = 0; uint32_t sumLevels = 0; uint32_t inFightTicks = 5 * 60 * 1000; - for (const auto &it : damageMap) { - CountBlock_t cb = it.second; - if ((OTSYS_TIME() - cb.ticks) <= inFightTicks) { - std::shared_ptr<Player> damageDealer = g_game().getPlayerByID(it.first); + for (const auto &[creatureId, damageInfo] : damageMap) { + const auto &[total, ticks] = damageInfo; + if ((OTSYS_TIME() - ticks) <= inFightTicks) { + const auto &damageDealer = g_game().getPlayerByID(creatureId); if (damageDealer) { - playerDmg += cb.total; + playerDmg += total; sumLevels += damageDealer->getLevel(); } else { - othersDmg += cb.total; + othersDmg += total; } } } @@ -2780,7 +2776,7 @@ void Player::death(std::shared_ptr<Creature> lastHitCreature) { } // Level loss - uint64_t expLoss = static_cast<uint64_t>(experience * deathLossPercent); + auto expLoss = static_cast<uint64_t>(experience * deathLossPercent); g_events().eventPlayerOnLoseExperience(static_self_cast<Player>(), expLoss); g_callbacks().executeCallback(EventCallback_t::playerOnLoseExperience, &EventCallback::playerOnLoseExperience, getPlayer(), expLoss); @@ -2797,7 +2793,7 @@ void Player::death(std::shared_ptr<Creature> lastHitCreature) { sumSkillTries += skills[i].tries; - uint32_t lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent); + auto lostSkillTries = static_cast<uint32_t>(sumSkillTries * deathLossPercent); while (lostSkillTries > skills[i].tries) { lostSkillTries -= skills[i].tries; @@ -2893,7 +2889,7 @@ void Player::death(std::shared_ptr<Creature> lastHitCreature) { auto it = conditions.begin(), end = conditions.end(); while (it != end) { - std::shared_ptr<Condition> condition = *it; + auto condition = *it; // isSupress block to delete spells conditions (ensures that the player cannot, for example, reset the cooldown time of the familiar and summon several) if (condition->isPersistent() && condition->isRemovableOnDeath()) { it = conditions.erase(it); @@ -2910,7 +2906,7 @@ void Player::death(std::shared_ptr<Creature> lastHitCreature) { auto it = conditions.begin(), end = conditions.end(); while (it != end) { - std::shared_ptr<Condition> condition = *it; + auto condition = *it; if (condition->isPersistent()) { it = conditions.erase(it); @@ -2940,7 +2936,7 @@ bool Player::spawn() { return false; } - auto spectators = Spectators().find<Creature>(position, true); + const auto &spectators = Spectators().find<Creature>(position, true); for (const auto &spectator : spectators) { if (const auto &tmpPlayer = spectator->getPlayer()) { tmpPlayer->sendCreatureAppear(static_self_cast<Player>(), pos, true); @@ -2972,18 +2968,18 @@ void Player::despawn() { Game::removeCreatureCheck(static_self_cast<Player>()); // remove from map - std::shared_ptr<Tile> tile = getTile(); + const auto &tile = getTile(); if (!tile) { return; } std::vector<int32_t> oldStackPosVector; - auto spectators = Spectators().find<Creature>(tile->getPosition(), true); + const auto &spectators = Spectators().find<Creature>(tile->getPosition(), true); size_t i = 0; for (const auto &spectator : spectators) { if (const auto &player = spectator->getPlayer()) { - oldStackPosVector.push_back(player->canSeeCreature(static_self_cast<Player>()) ? tile->getStackposOfCreature(player, getPlayer()) : -1); + oldStackPosVector.emplace_back(player->canSeeCreature(static_self_cast<Player>()) ? tile->getStackposOfCreature(player, getPlayer()) : -1); } if (const auto &player = spectator->getPlayer()) { player->sendRemoveTileThing(tile->getPosition(), oldStackPosVector[i++]); @@ -3006,7 +3002,7 @@ void Player::despawn() { setDead(true); } -bool Player::dropCorpse(std::shared_ptr<Creature> lastHitCreature, std::shared_ptr<Creature> mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified) { +bool Player::dropCorpse(const std::shared_ptr<Creature> &lastHitCreature, const std::shared_ptr<Creature> &mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified) { if (getZoneType() != ZONE_PVP || !Player::lastHitIsPlayer(lastHitCreature)) { return Creature::dropCorpse(lastHitCreature, mostDamageCreature, lastHitUnjustified, mostDamageUnjustified); } @@ -3015,8 +3011,8 @@ bool Player::dropCorpse(std::shared_ptr<Creature> lastHitCreature, std::shared_p return false; } -std::shared_ptr<Item> Player::getCorpse(std::shared_ptr<Creature> lastHitCreature, std::shared_ptr<Creature> mostDamageCreature) { - std::shared_ptr<Item> corpse = Creature::getCorpse(lastHitCreature, mostDamageCreature); +std::shared_ptr<Item> Player::getCorpse(const std::shared_ptr<Creature> &lastHitCreature, const std::shared_ptr<Creature> &mostDamageCreature) { + const auto &corpse = Creature::getCorpse(lastHitCreature, mostDamageCreature); if (corpse && corpse->getContainer()) { std::ostringstream ss; if (lastHitCreature) { @@ -3049,7 +3045,8 @@ void Player::addInFightTicks(bool pzlock /*= false*/) { // this method can be called asynchronously. g_dispatcher().context().tryAddEvent([self = std::weak_ptr<Player>(getPlayer())] { if (const auto &player = self.lock()) { - player->addCondition(Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_INFIGHT, g_configManager().getNumber(PZ_LOCKED), 0)); + const auto &condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_INFIGHT, g_configManager().getNumber(PZ_LOCKED), 0); + player->addCondition(condition); } }, "Player::addInFightTicks"); @@ -3081,13 +3078,13 @@ void Player::removePlayer(bool displayEffect, bool forced /*= true*/) { } // close container and its child containers -void Player::autoCloseContainers(std::shared_ptr<Container> container) { +void Player::autoCloseContainers(const std::shared_ptr<Container> &container) { std::vector<uint32_t> closeList; - for (const auto &it : openContainers) { - std::shared_ptr<Container> tmpContainer = it.second.container; + for (const auto &[containerId, containerInfo] : openContainers) { + auto tmpContainer = containerInfo.container; while (tmpContainer) { if (tmpContainer->isRemoved() || tmpContainer == container) { - closeList.push_back(it.first); + closeList.emplace_back(containerId); break; } @@ -3095,7 +3092,7 @@ void Player::autoCloseContainers(std::shared_ptr<Container> container) { } } - for (uint32_t containerId : closeList) { + for (const uint32_t containerId : closeList) { closeContainer(containerId); if (client) { client->sendCloseContainer(containerId); @@ -3103,7 +3100,7 @@ void Player::autoCloseContainers(std::shared_ptr<Container> container) { } } -bool Player::hasCapacity(std::shared_ptr<Item> item, uint32_t count) const { +bool Player::hasCapacity(const std::shared_ptr<Item> &item, uint32_t count) const { if (hasFlag(PlayerFlags_t::CannotPickupItem)) { return false; } @@ -3119,8 +3116,8 @@ bool Player::hasCapacity(std::shared_ptr<Item> item, uint32_t count) const { return itemWeight <= getFreeCapacity(); } -ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature>) { - std::shared_ptr<Item> item = thing->getItem(); +ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &) { + const auto &item = thing->getItem(); if (item == nullptr) { g_logger().error("[Player::queryAdd] - Item is nullptr"); return RETURNVALUE_NOTPOSSIBLE; @@ -3129,10 +3126,10 @@ ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, return RETURNVALUE_ITEMISNOTYOURS; } - bool childIsOwner = hasBitSet(FLAG_CHILDISOWNER, flags); + const bool childIsOwner = hasBitSet(FLAG_CHILDISOWNER, flags); if (childIsOwner) { // a child container is querying the player, just check if enough capacity - bool skipLimit = hasBitSet(FLAG_NOLIMIT, flags); + const bool skipLimit = hasBitSet(FLAG_NOLIMIT, flags); if (skipLimit || hasCapacity(item, count)) { return RETURNVALUE_NOERROR; } @@ -3194,7 +3191,7 @@ ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, if (item->getWeaponType() != WEAPON_SHIELD && !item->isQuiver()) { ret = RETURNVALUE_CANNOTBEDRESSED; } else { - std::shared_ptr<Item> leftItem = inventory[CONST_SLOT_LEFT]; + const auto &leftItem = inventory[CONST_SLOT_LEFT]; if (leftItem) { if ((leftItem->getSlotPosition() | slotPosition) & SLOTP_TWO_HAND) { if (item->isQuiver() && leftItem->getWeaponType() == WEAPON_DISTANCE) { @@ -3212,12 +3209,12 @@ ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, } else if (slotPosition & SLOTP_TWO_HAND) { ret = RETURNVALUE_CANNOTBEDRESSED; } else if (inventory[CONST_SLOT_LEFT]) { - std::shared_ptr<Item> leftItem = inventory[CONST_SLOT_LEFT]; - WeaponType_t type = item->getWeaponType(), leftType = leftItem->getWeaponType(); - - if (leftItem->getSlotPosition() & SLOTP_TWO_HAND) { + const auto &leftItem = inventory[CONST_SLOT_LEFT]; + const WeaponType_t type = item->getWeaponType(); + const WeaponType_t leftType = leftItem ? leftItem->getWeaponType() : WEAPON_NONE; + if (leftItem && leftItem->getSlotPosition() & SLOTP_TWO_HAND) { ret = RETURNVALUE_DROPTWOHANDEDITEM; - } else if (item == leftItem && count == item->getItemCount()) { + } else if (leftItem && item == leftItem && count == item->getItemCount()) { ret = RETURNVALUE_NOERROR; } else if (leftType == WEAPON_SHIELD && type == WEAPON_SHIELD) { ret = RETURNVALUE_CANONLYUSEONESHIELD; @@ -3237,7 +3234,7 @@ ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, ret = RETURNVALUE_CANNOTBEDRESSED; } else if (slotPosition & SLOTP_TWO_HAND) { if (inventory[CONST_SLOT_RIGHT]) { - WeaponType_t type = item->getWeaponType(); + const WeaponType_t type = item->getWeaponType(); // Allow equip bow when quiver is in SLOT_RIGHT if (type == WEAPON_DISTANCE && inventory[CONST_SLOT_RIGHT]->isQuiver()) { ret = RETURNVALUE_NOERROR; @@ -3248,19 +3245,20 @@ ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, ret = RETURNVALUE_NOERROR; } } else if (slotPosition & SLOTP_LEFT) { - WeaponType_t type = item->getWeaponType(); + const WeaponType_t type = item->getWeaponType(); if (type == WEAPON_NONE || type == WEAPON_SHIELD || type == WEAPON_AMMO) { ret = RETURNVALUE_CANNOTBEDRESSED; } else { ret = RETURNVALUE_NOERROR; } } else if (inventory[CONST_SLOT_RIGHT]) { - std::shared_ptr<Item> rightItem = inventory[CONST_SLOT_RIGHT]; - WeaponType_t type = item->getWeaponType(), rightType = rightItem->getWeaponType(); + const auto &rightItem = inventory[CONST_SLOT_RIGHT]; + const WeaponType_t type = item->getWeaponType(); + const WeaponType_t rightType = rightItem ? rightItem->getWeaponType() : WEAPON_NONE; - if (rightItem->getSlotPosition() & SLOTP_TWO_HAND) { + if (rightItem && rightItem->getSlotPosition() & SLOTP_TWO_HAND) { ret = RETURNVALUE_DROPTWOHANDEDITEM; - } else if (item == rightItem && count == item->getItemCount()) { + } else if (rightItem && item == rightItem && count == item->getItemCount()) { ret = RETURNVALUE_NOERROR; } else if (rightType == WEAPON_SHIELD && type == WEAPON_SHIELD) { ret = RETURNVALUE_CANONLYUSEONESHIELD; @@ -3319,7 +3317,7 @@ ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, if (ret == RETURNVALUE_NOERROR || ret == RETURNVALUE_NOTENOUGHROOM) { // need an exchange with source? - std::shared_ptr<Item> inventoryItem = getInventoryItem(static_cast<Slots_t>(index)); + const auto &inventoryItem = getInventoryItem(static_cast<Slots_t>(index)); if (inventoryItem && (!inventoryItem->isStackable() || inventoryItem->getID() != item->getID())) { return RETURNVALUE_NEEDEXCHANGE; } @@ -3338,7 +3336,7 @@ ReturnValue Player::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, } ReturnValue Player::queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) { - auto item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { maxQueryCount = 0; return RETURNVALUE_NOTPOSSIBLE; @@ -3347,23 +3345,23 @@ ReturnValue Player::queryMaxCount(int32_t index, const std::shared_ptr<Thing> &t if (index == INDEX_WHEREEVER) { uint32_t n = 0; for (int32_t slotIndex = CONST_SLOT_FIRST; slotIndex <= CONST_SLOT_LAST; ++slotIndex) { - std::shared_ptr<Item> inventoryItem = inventory[slotIndex]; + const auto &inventoryItem = inventory[slotIndex]; if (inventoryItem) { - if (std::shared_ptr<Container> subContainer = inventoryItem->getContainer()) { + if (const auto &subContainer = inventoryItem->getContainer()) { uint32_t queryCount = 0; subContainer->queryMaxCount(INDEX_WHEREEVER, item, item->getItemCount(), queryCount, flags); n += queryCount; // iterate through all items, including sub-containers (deep search) for (ContainerIterator it = subContainer->iterator(); it.hasNext(); it.advance()) { - if (std::shared_ptr<Container> tmpContainer = (*it)->getContainer()) { + if (const auto &tmpContainer = (*it)->getContainer()) { queryCount = 0; tmpContainer->queryMaxCount(INDEX_WHEREEVER, item, item->getItemCount(), queryCount, flags); n += queryCount; } } } else if (inventoryItem->isStackable() && item->equals(inventoryItem) && inventoryItem->getItemCount() < inventoryItem->getStackSize()) { - uint32_t remainder = (inventoryItem->getStackSize() - inventoryItem->getItemCount()); + const uint32_t remainder = (inventoryItem->getStackSize() - inventoryItem->getItemCount()); if (queryAdd(slotIndex, item, remainder, flags) == RETURNVALUE_NOERROR) { n += remainder; @@ -3382,7 +3380,7 @@ ReturnValue Player::queryMaxCount(int32_t index, const std::shared_ptr<Thing> &t } else { std::shared_ptr<Item> destItem = nullptr; - std::shared_ptr<Thing> destThing = getThing(index); + const auto &destThing = getThing(index); if (destThing) { destItem = destThing->getItem(); } @@ -3406,18 +3404,17 @@ ReturnValue Player::queryMaxCount(int32_t index, const std::shared_ptr<Thing> &t if (maxQueryCount < count) { return RETURNVALUE_NOTENOUGHROOM; - } else { - return RETURNVALUE_NOERROR; } + return RETURNVALUE_NOERROR; } -ReturnValue Player::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> /*= nullptr*/) { - int32_t index = getThingIndex(thing); +ReturnValue Player::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> & /*= nullptr */) { + const int32_t index = getThingIndex(thing); if (index == -1) { return RETURNVALUE_NOTPOSSIBLE; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return RETURNVALUE_NOTPOSSIBLE; } @@ -3433,17 +3430,17 @@ ReturnValue Player::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t co return RETURNVALUE_NOERROR; } -std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) { +std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) { if (index == 0 /*drop to capacity window*/ || index == INDEX_WHEREEVER) { - *destItem = nullptr; + destItem = nullptr; - std::shared_ptr<Item> item = thing->getItem(); - if (item == nullptr) { + const auto &item = thing->getItem(); + if (!item) { return getPlayer(); } - bool autoStack = !((flags & FLAG_IGNOREAUTOSTACK) == FLAG_IGNOREAUTOSTACK); - bool isStackable = item->isStackable(); + const bool autoStack = !(flags & FLAG_IGNOREAUTOSTACK); + const bool isStackable = item->isStackable(); std::vector<std::shared_ptr<Container>> containers; @@ -3463,20 +3460,20 @@ std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::sh if (queryAdd(slotIndex, item, item->getItemCount(), 0) == RETURNVALUE_NOERROR) { if (inventoryItem->equals(item) && inventoryItem->getItemCount() < inventoryItem->getStackSize()) { index = slotIndex; - *destItem = inventoryItem; + destItem = inventoryItem; return getPlayer(); } } - if (std::shared_ptr<Container> subContainer = inventoryItem->getContainer()) { + if (const auto &subContainer = inventoryItem->getContainer()) { containers.push_back(subContainer); } - } else if (std::shared_ptr<Container> subContainer = inventoryItem->getContainer()) { + } else if (const auto &subContainer = inventoryItem->getContainer()) { containers.push_back(subContainer); } } else if (queryAdd(slotIndex, item, item->getItemCount(), flags) == RETURNVALUE_NOERROR) { // empty slot index = slotIndex; - *destItem = nullptr; + destItem = nullptr; return getPlayer(); } } @@ -3490,15 +3487,15 @@ std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::sh while (n) { if (tmpContainer->queryAdd(tmpContainer->capacity() - n, item, item->getItemCount(), flags) == RETURNVALUE_NOERROR) { index = tmpContainer->capacity() - n; - *destItem = nullptr; + destItem = nullptr; return tmpContainer; } n--; } - for (const std::shared_ptr<Item> &tmpContainerItem : tmpContainer->getItemList()) { - if (std::shared_ptr<Container> subContainer = tmpContainerItem->getContainer()) { + for (const auto &tmpContainerItem : tmpContainer->getItemList()) { + if (const auto &subContainer = tmpContainerItem->getContainer()) { containers.push_back(subContainer); } } @@ -3520,11 +3517,11 @@ std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::sh // try find an already existing item to stack with if (tmpItem->equals(item) && tmpItem->getItemCount() < tmpItem->getStackSize()) { index = n; - *destItem = tmpItem; + destItem = tmpItem; return tmpContainer; } - if (std::shared_ptr<Container> subContainer = tmpItem->getContainer()) { + if (const auto &subContainer = tmpItem->getContainer()) { containers.push_back(subContainer); } @@ -3533,7 +3530,7 @@ std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::sh if (n < tmpContainer->capacity() && tmpContainer->queryAdd(n, item, item->getItemCount(), flags) == RETURNVALUE_NOERROR) { index = n; - *destItem = nullptr; + destItem = nullptr; return tmpContainer; } } @@ -3543,11 +3540,11 @@ std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::sh std::shared_ptr<Thing> destThing = getThing(index); if (destThing) { - *destItem = destThing->getItem(); + destItem = destThing->getItem(); } std::shared_ptr<Item> item = thing->getItem(); - bool movingAmmoToQuiver = item && *destItem && (*destItem)->isQuiver() && item->isAmmo(); + bool movingAmmoToQuiver = item && destItem && destItem->isQuiver() && item->isAmmo(); // force shield any slot right to player cylinder if (index == CONST_SLOT_RIGHT && !movingAmmoToQuiver) { return getPlayer(); @@ -3556,14 +3553,14 @@ std::shared_ptr<Cylinder> Player::queryDestination(int32_t &index, const std::sh std::shared_ptr<Cylinder> subCylinder = std::dynamic_pointer_cast<Cylinder>(destThing); if (subCylinder) { index = INDEX_WHEREEVER; - *destItem = nullptr; + destItem = nullptr; return subCylinder; } else { return getPlayer(); } } -void Player::addThing(int32_t index, std::shared_ptr<Thing> thing) { +void Player::addThing(int32_t index, const std::shared_ptr<Thing> &thing) { if (!thing) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -3572,7 +3569,7 @@ void Player::addThing(int32_t index, std::shared_ptr<Thing> thing) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -3584,13 +3581,13 @@ void Player::addThing(int32_t index, std::shared_ptr<Thing> thing) { sendInventoryItem(static_cast<Slots_t>(index), item); } -void Player::updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) { +void Player::updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) { int32_t index = getThingIndex(thing); if (index == -1) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -3605,17 +3602,17 @@ void Player::updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t onUpdateInventoryItem(item, item); } -void Player::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { +void Player::replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) { if (index > CONST_SLOT_LAST) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> oldItem = getInventoryItem(static_cast<Slots_t>(index)); + const auto &oldItem = getInventoryItem(static_cast<Slots_t>(index)); if (!oldItem) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -3631,8 +3628,8 @@ void Player::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { inventory[index] = item; } -void Player::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { - std::shared_ptr<Item> item = thing->getItem(); +void Player::removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) { + const auto &item = thing->getItem(); if (!item) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -3653,7 +3650,7 @@ void Player::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { item->resetParent(); inventory[index] = nullptr; } else { - uint8_t newCount = static_cast<uint8_t>(std::max<int32_t>(0, item->getItemCount() - count)); + const auto newCount = static_cast<uint8_t>(std::max<int32_t>(0, item->getItemCount() - count)); item->setItemCount(newCount); // send change to client @@ -3674,7 +3671,7 @@ void Player::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { } } -int32_t Player::getThingIndex(std::shared_ptr<Thing> thing) const { +int32_t Player::getThingIndex(const std::shared_ptr<Thing> &thing) const { for (uint8_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) { if (inventory[i] == thing) { return i; @@ -3694,7 +3691,7 @@ size_t Player::getLastIndex() const { uint32_t Player::getItemTypeCount(uint16_t itemId, int32_t subType /*= -1*/) const { uint32_t count = 0; for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; i++) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } @@ -3703,7 +3700,7 @@ uint32_t Player::getItemTypeCount(uint16_t itemId, int32_t subType /*= -1*/) con count += Item::countByType(item, subType); } - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const auto &container = item->getContainer()) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { if ((*it)->getID() == itemId) { count += Item::countByType(*it, subType); @@ -3714,17 +3711,21 @@ uint32_t Player::getItemTypeCount(uint16_t itemId, int32_t subType /*= -1*/) con return count; } -void Player::stashContainer(StashContainerList itemDict) { +void Player::stashContainer(const StashContainerList &itemDict) { StashItemList stashItemDict; // ItemID - Count - for (const auto &it_dict : itemDict) { - stashItemDict[(it_dict.first)->getID()] = it_dict.second; + for (const auto &[item, itemCount] : itemDict) { + if (!item) { + continue; + } + + stashItemDict[item->getID()] = itemCount; } - for (auto it : stashItems) { - if (!stashItemDict[it.first]) { - stashItemDict[it.first] = it.second; + for (const auto &[itemId, itemCount] : stashItems) { + if (!stashItemDict[itemId]) { + stashItemDict[itemId] = itemCount; } else { - stashItemDict[it.first] += it.second; + stashItemDict[itemId] += itemCount; } } @@ -3736,11 +3737,14 @@ void Player::stashContainer(StashContainerList itemDict) { uint32_t totalStowed = 0; std::ostringstream retString; uint16_t refreshDepotSearchOnItem = 0; - for (const auto &stashIterator : itemDict) { - uint16_t iteratorCID = (stashIterator.first)->getID(); - if (g_game().internalRemoveItem(stashIterator.first, stashIterator.second) == RETURNVALUE_NOERROR) { - addItemOnStash(iteratorCID, stashIterator.second); - totalStowed += stashIterator.second; + for (const auto &[item, itemCount] : itemDict) { + if (!item) { + continue; + } + const uint16_t iteratorCID = item->getID(); + if (g_game().internalRemoveItem(item, itemCount) == RETURNVALUE_NOERROR) { + addItemOnStash(iteratorCID, itemCount); + totalStowed += itemCount; if (isDepotSearchOpenOnItem(iteratorCID)) { refreshDepotSearchOnItem = iteratorCID; } @@ -3765,7 +3769,7 @@ void Player::stashContainer(StashContainerList itemDict) { } } -bool Player::removeItemOfType(uint16_t itemId, uint32_t amount, int32_t subType, bool ignoreEquipped /* = false*/) { +bool Player::removeItemOfType(uint16_t itemId, uint32_t amount, int32_t subType, bool ignoreEquipped /* = false*/) const { if (amount == 0) { return true; } @@ -3774,41 +3778,41 @@ bool Player::removeItemOfType(uint16_t itemId, uint32_t amount, int32_t subType, uint32_t count = 0; for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; i++) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } if (!ignoreEquipped && item->getID() == itemId) { - uint32_t itemCount = Item::countByType(item, subType); + const uint32_t itemCount = Item::countByType(item, subType); if (itemCount == 0) { continue; } - itemList.push_back(item); + itemList.emplace_back(item); count += itemCount; if (count >= amount) { - g_game().internalRemoveItems(std::move(itemList), amount, Item::items[itemId].stackable); + g_game().internalRemoveItems(itemList, amount, Item::items[itemId].stackable); return true; } - } else if (std::shared_ptr<Container> container = item->getContainer()) { + } else if (const auto &container = item->getContainer()) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> containerItem = *it; + const auto &containerItem = *it; if (containerItem->getID() == itemId) { - uint32_t itemCount = Item::countByType(containerItem, subType); + const uint32_t itemCount = Item::countByType(containerItem, subType); if (itemCount == 0) { continue; } - itemList.push_back(containerItem); + itemList.emplace_back(containerItem); count += itemCount; - auto stackable = Item::items[itemId].stackable; + const auto stackable = Item::items[itemId].stackable; // If the amount of items in the backpack is equal to or greater than the amount // It will remove items and stop the iteration if (count >= amount) { - g_game().internalRemoveItems(std::move(itemList), amount, stackable); + g_game().internalRemoveItems(itemList, amount, stackable); return true; } } @@ -3832,7 +3836,7 @@ bool Player::hasItemCountById(uint16_t itemId, uint32_t itemAmount, bool checkSt // Check items from stash for (StashItemList stashToSend = getStashItems(); - auto [stashItemId, itemCount] : stashToSend) { + const auto &[stashItemId, itemCount] : stashToSend) { if (!checkStash) { break; } @@ -3880,7 +3884,7 @@ bool Player::removeItemCountById(uint16_t itemId, uint32_t itemAmount, bool remo ItemsTierCountList Player::getInventoryItemsId(bool ignoreStoreInbox /* false */) const { ItemsTierCountList itemMap; for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; i++) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } @@ -3905,20 +3909,20 @@ ItemsTierCountList Player::getInventoryItemsId(bool ignoreStoreInbox /* false */ std::vector<std::shared_ptr<Item>> Player::getInventoryItemsFromId(uint16_t itemId, bool ignore /*= true*/) const { std::vector<std::shared_ptr<Item>> itemVector; for (int i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } if (!ignore && item->getID() == itemId) { - itemVector.push_back(item); + itemVector.emplace_back(item); } - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const auto &container = item->getContainer()) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { - auto containerItem = *it; + const auto &containerItem = *it; if (containerItem->getID() == itemId) { - itemVector.push_back(containerItem); + itemVector.emplace_back(containerItem); } } } @@ -3928,7 +3932,7 @@ std::vector<std::shared_ptr<Item>> Player::getInventoryItemsFromId(uint16_t item } std::array<double_t, COMBAT_COUNT> Player::getFinalDamageReduction() const { - std::array<double_t, COMBAT_COUNT> combatReductionArray; + std::array<double_t, COMBAT_COUNT> combatReductionArray {}; combatReductionArray.fill(0); calculateDamageReductionFromEquipedItems(combatReductionArray); for (int combatTypeIndex = 0; combatTypeIndex < COMBAT_COUNT; combatTypeIndex++) { @@ -3943,14 +3947,14 @@ std::array<double_t, COMBAT_COUNT> Player::getFinalDamageReduction() const { void Player::calculateDamageReductionFromEquipedItems(std::array<double_t, COMBAT_COUNT> &combatReductionArray) const { for (uint8_t slot = CONST_SLOT_FIRST; slot <= CONST_SLOT_LAST; ++slot) { - std::shared_ptr<Item> item = inventory[slot]; + const auto &item = inventory[slot]; if (item) { calculateDamageReductionFromItem(combatReductionArray, item); } } } -void Player::calculateDamageReductionFromItem(std::array<double_t, COMBAT_COUNT> &combatReductionArray, std::shared_ptr<Item> item) const { +void Player::calculateDamageReductionFromItem(std::array<double_t, COMBAT_COUNT> &combatReductionArray, const std::shared_ptr<Item> &item) const { for (uint16_t combatTypeIndex = 0; combatTypeIndex < COMBAT_COUNT; combatTypeIndex++) { updateDamageReductionFromItemImbuement(combatReductionArray, item, combatTypeIndex); updateDamageReductionFromItemAbility(combatReductionArray, item, combatTypeIndex); @@ -3958,12 +3962,12 @@ void Player::calculateDamageReductionFromItem(std::array<double_t, COMBAT_COUNT> } void Player::updateDamageReductionFromItemImbuement( - std::array<double_t, COMBAT_COUNT> &combatReductionArray, std::shared_ptr<Item> item, uint16_t combatTypeIndex + std::array<double_t, COMBAT_COUNT> &combatReductionArray, const std::shared_ptr<Item> &item, uint16_t combatTypeIndex ) const { for (uint8_t imbueSlotId = 0; imbueSlotId < item->getImbuementSlot(); imbueSlotId++) { ImbuementInfo imbuementInfo; if (item->getImbuementInfo(imbueSlotId, &imbuementInfo) && imbuementInfo.imbuement) { - int16_t imbuementAbsorption = imbuementInfo.imbuement->absorbPercent[combatTypeIndex]; + const int16_t imbuementAbsorption = imbuementInfo.imbuement->absorbPercent[combatTypeIndex]; if (imbuementAbsorption != 0) { combatReductionArray[combatTypeIndex] = calculateDamageReduction(combatReductionArray[combatTypeIndex], imbuementAbsorption); } @@ -3972,7 +3976,7 @@ void Player::updateDamageReductionFromItemImbuement( } void Player::updateDamageReductionFromItemAbility( - std::array<double_t, COMBAT_COUNT> &combatReductionArray, std::shared_ptr<Item> item, uint16_t combatTypeIndex + std::array<double_t, COMBAT_COUNT> &combatReductionArray, const std::shared_ptr<Item> &item, uint16_t combatTypeIndex ) const { if (!item) { return; @@ -3980,7 +3984,7 @@ void Player::updateDamageReductionFromItemAbility( const ItemType &itemType = Item::items[item->getID()]; if (itemType.abilities) { - int16_t elementReduction = itemType.abilities->absorbPercent[combatTypeIndex]; + const int16_t elementReduction = itemType.abilities->absorbPercent[combatTypeIndex]; if (elementReduction != 0) { combatReductionArray[combatTypeIndex] = calculateDamageReduction(combatReductionArray[combatTypeIndex], elementReduction); } @@ -3996,7 +4000,7 @@ ItemsTierCountList Player::getStoreInboxItemsId() const { const auto &container = getStoreInbox(); if (container) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; + const auto &item = *it; (itemMap[item->getID()])[item->getTier()] += Item::countByType(item, -1); } } @@ -4008,9 +4012,9 @@ ItemsTierCountList Player::getDepotChestItemsId() const { ItemsTierCountList itemMap; for (const auto &[index, depot] : depotChests) { - const std::shared_ptr<Container> &container = depot->getContainer(); + const auto &container = depot->getContainer(); for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; + const auto &item = *it; (itemMap[item->getID()])[item->getTier()] += Item::countByType(item, -1); } } @@ -4021,8 +4025,8 @@ ItemsTierCountList Player::getDepotChestItemsId() const { ItemsTierCountList Player::getDepotInboxItemsId() const { ItemsTierCountList itemMap; - const std::shared_ptr<Inbox> &inbox = getInbox(); - const std::shared_ptr<Container> &container = inbox->getContainer(); + const auto &inbox = getInbox(); + const auto &container = inbox->getContainer(); if (container) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { const auto &item = *it; @@ -4036,22 +4040,22 @@ ItemsTierCountList Player::getDepotInboxItemsId() const { std::vector<std::shared_ptr<Item>> Player::getAllInventoryItems(bool ignoreEquiped /*= false*/, bool ignoreItemWithTier /* false*/) const { std::vector<std::shared_ptr<Item>> itemVector; for (int i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } // Only get equiped items if ignored equipped is false if (!ignoreEquiped) { - itemVector.push_back(item); + itemVector.emplace_back(item); } - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const auto &container = item->getContainer()) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { if (ignoreItemWithTier && (*it)->getTier() > 0) { continue; } - itemVector.push_back(*it); + itemVector.emplace_back(*it); } } } @@ -4061,12 +4065,12 @@ std::vector<std::shared_ptr<Item>> Player::getAllInventoryItems(bool ignoreEquip std::vector<std::shared_ptr<Item>> Player::getEquippedAugmentItemsByType(Augment_t augmentType) const { std::vector<std::shared_ptr<Item>> equippedAugmentItemsByType; - const auto equippedAugmentItems = getEquippedItems(); + auto equippedAugmentItems = getEquippedItems(); for (const auto &item : equippedAugmentItems) { - for (auto &augment : item->getAugments()) { + for (const auto &augment : item->getAugments()) { if (augment->type == augmentType) { - equippedAugmentItemsByType.push_back(item); + equippedAugmentItemsByType.emplace_back(item); } } } @@ -4076,20 +4080,20 @@ std::vector<std::shared_ptr<Item>> Player::getEquippedAugmentItemsByType(Augment std::vector<std::shared_ptr<Item>> Player::getEquippedAugmentItems() const { std::vector<std::shared_ptr<Item>> equippedAugmentItems; - const auto equippedItems = getEquippedItems(); + auto equippedItems = getEquippedItems(); for (const auto &item : equippedItems) { - if (item->getAugments().size() < 1) { + if (item->getAugments().empty()) { continue; } - equippedAugmentItems.push_back(item); + equippedAugmentItems.emplace_back(item); } return equippedAugmentItems; } std::vector<std::shared_ptr<Item>> Player::getEquippedItems() const { - std::vector<Slots_t> valid_slots { + static const std::vector valid_slots { CONST_SLOT_HEAD, CONST_SLOT_NECKLACE, CONST_SLOT_BACKPACK, @@ -4103,12 +4107,12 @@ std::vector<std::shared_ptr<Item>> Player::getEquippedItems() const { std::vector<std::shared_ptr<Item>> valid_items; for (const auto &slot : valid_slots) { - std::shared_ptr<Item> item = inventory[slot]; + const auto &item = inventory[slot]; if (!item) { continue; } - valid_items.push_back(item); + valid_items.emplace_back(item); } return valid_items; @@ -4143,7 +4147,7 @@ std::map<uint16_t, uint16_t> &Player::getAllSaleItemIdAndCount(std::map<uint16_t void Player::getAllItemTypeCountAndSubtype(std::map<uint32_t, uint32_t> &countMap) const { for (const auto &item : getAllInventoryItems()) { - uint16_t itemId = item->getID(); + const uint16_t itemId = item->getID(); if (Item::items[itemId].isFluidContainer()) { countMap[static_cast<uint32_t>(itemId) | (item->getAttribute<uint32_t>(ItemAttribute_t::FLUIDTYPE)) << 16] += item->getItemCount(); } else { @@ -4152,8 +4156,8 @@ void Player::getAllItemTypeCountAndSubtype(std::map<uint32_t, uint32_t> &countMa } } -std::shared_ptr<Item> Player::getForgeItemFromId(uint16_t itemId, uint8_t tier) { - for (auto item : getAllInventoryItems(true)) { +std::shared_ptr<Item> Player::getForgeItemFromId(uint16_t itemId, uint8_t tier) const { + for (const auto &item : getAllInventoryItems(true)) { if (item->hasImbuements()) { continue; } @@ -4173,7 +4177,7 @@ std::shared_ptr<Thing> Player::getThing(size_t index) const { return nullptr; } -void Player::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link /*= LINK_OWNER*/) { +void Player::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, const CylinderLink_t link /*= LINK_OWNER*/) { if (link == LINK_OWNER) { // calling movement scripts g_moveEvents().onPlayerEquip(getPlayer(), thing->getItem(), static_cast<Slots_t>(index), false); @@ -4181,8 +4185,8 @@ void Player::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<C bool requireListUpdate = true; if (link == LINK_OWNER || link == LINK_TOPPARENT) { - std::shared_ptr<Item> i = (oldParent ? oldParent->getItem() : nullptr); - const auto &container = i ? i->getContainer() : nullptr; + const auto &item = oldParent ? oldParent->getItem() : nullptr; + const auto &container = item ? item->getContainer() : nullptr; if (container) { requireListUpdate = container->getHoldingPlayer() != getPlayer(); } else { @@ -4195,52 +4199,59 @@ void Player::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<C sendStats(); } - if (std::shared_ptr<Item> item = thing->getItem()) { - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const auto &item = thing->getItem()) { + if (const auto &container = item->getContainer()) { onSendContainer(container); } if (shopOwner && !scheduledSaleUpdate && requireListUpdate) { updateSaleShopList(item); } - } else if (std::shared_ptr<Creature> creature = thing->getCreature()) { + } else if (const auto &creature = thing->getCreature()) { if (creature == getPlayer()) { // check containers std::vector<std::shared_ptr<Container>> containers; - for (const auto &it : openContainers) { - std::shared_ptr<Container> container = it.second.container; + for (const auto &[containerId, containerInfo] : openContainers) { + const auto &container = containerInfo.container; if (container == nullptr) { continue; } if (!Position::areInRange<1, 1, 0>(container->getPosition(), getPosition())) { - containers.push_back(container); + containers.emplace_back(container); } } - for (const std::shared_ptr<Container> &container : containers) { + for (const auto &container : containers) { autoCloseContainers(container); } } } } -void Player::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link /*= LINK_OWNER*/) { - if (link == LINK_OWNER) { - // calling movement scripts - g_moveEvents().onPlayerDeEquip(getPlayer(), thing->getItem(), static_cast<Slots_t>(index)); +void Player::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link /*= LINK_OWNER*/) { + if (!thing) { + return; } + const auto copyThing = thing; + const auto copyNewParent = newParent; + + if (link == LINK_OWNER) { + if (const auto &item = copyThing->getItem()) { + g_moveEvents().onPlayerDeEquip(getPlayer(), item, static_cast<Slots_t>(index)); + } + } bool requireListUpdate = true; if (link == LINK_OWNER || link == LINK_TOPPARENT) { - std::shared_ptr<Item> i = (newParent ? newParent->getItem() : nullptr); - const auto &container = i ? i->getContainer() : nullptr; + const auto &item = copyNewParent ? copyNewParent->getItem() : nullptr; + const auto &container = item ? item->getContainer() : nullptr; if (container) { requireListUpdate = container->getHoldingPlayer() != getPlayer(); } else { - requireListUpdate = newParent != getPlayer(); + requireListUpdate = copyNewParent != getPlayer(); } updateInventoryWeight(); @@ -4249,22 +4260,25 @@ void Player::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_pt sendStats(); } - if (std::shared_ptr<Item> item = thing->getItem()) { - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const auto &item = copyThing->getItem()) { + if (const auto &container = item->getContainer()) { checkLootContainers(container); if (container->isRemoved() || !Position::areInRange<1, 1, 0>(getPosition(), container->getPosition())) { autoCloseContainers(container); } else if (container->getTopParent() == getPlayer()) { onSendContainer(container); - } else if (std::shared_ptr<Container> topContainer = std::dynamic_pointer_cast<Container>(container->getTopParent())) { - if (std::shared_ptr<DepotChest> depotChest = std::dynamic_pointer_cast<DepotChest>(topContainer)) { + } else if (const auto &topContainer = std::dynamic_pointer_cast<Container>(container->getTopParent())) { + if (const auto &depotChest = std::dynamic_pointer_cast<DepotChest>(topContainer)) { bool isOwner = false; - for (const auto &it : depotChests) { - if (it.second == depotChest) { + for (const auto &[depotId, depotChestMap] : depotChests) { + if (depotId == 0) { + continue; + } + + if (depotChestMap == depotChest) { isOwner = true; - it.second->stopDecaying(); onSendContainer(container); } } @@ -4291,9 +4305,9 @@ void Player::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_pt } } -// i will keep this function so it can be reviewed -bool Player::updateSaleShopList(std::shared_ptr<Item> item) { - uint16_t itemId = item->getID(); +// TODO: review this function +bool Player::updateSaleShopList(const std::shared_ptr<Item> &item) { + const uint16_t itemId = item->getID(); if (!itemId || !item) { return true; } @@ -4310,21 +4324,21 @@ bool Player::hasShopItemForSale(uint16_t itemId, uint8_t subType) const { const ItemType &itemType = Item::items[itemId]; const auto &shoplist = shopOwner->getShopItemVector(getGUID()); - return std::any_of(shoplist.begin(), shoplist.end(), [&](const ShopBlock &shopBlock) { + return std::ranges::any_of(shoplist, [&](const ShopBlock &shopBlock) { return shopBlock.itemId == itemId && shopBlock.itemBuyPrice != 0 && (!itemType.isFluidContainer() || shopBlock.itemSubType == subType); }); } -void Player::internalAddThing(std::shared_ptr<Thing> thing) { +void Player::internalAddThing(const std::shared_ptr<Thing> &thing) { internalAddThing(0, thing); } -void Player::internalAddThing(uint32_t index, std::shared_ptr<Thing> thing) { +void Player::internalAddThing(uint32_t index, const std::shared_ptr<Thing> &thing) { if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return; } @@ -4340,7 +4354,7 @@ void Player::internalAddThing(uint32_t index, std::shared_ptr<Thing> thing) { } } -bool Player::setFollowCreature(std::shared_ptr<Creature> creature) { +bool Player::setFollowCreature(const std::shared_ptr<Creature> &creature) { if (!Creature::setFollowCreature(creature)) { setFollowCreature(nullptr); setAttackedCreature(nullptr); @@ -4353,13 +4367,13 @@ bool Player::setFollowCreature(std::shared_ptr<Creature> creature) { return true; } -bool Player::setAttackedCreature(std::shared_ptr<Creature> creature) { +bool Player::setAttackedCreature(const std::shared_ptr<Creature> &creature) { if (!Creature::setAttackedCreature(creature)) { sendCancelTarget(); return false; } - auto followCreature = getFollowCreature(); + const auto &followCreature = getFollowCreature(); if (chaseMode && creature) { if (followCreature != creature) { setFollowCreature(creature); @@ -4402,7 +4416,7 @@ void Player::doAttacking(uint32_t) { return; } - auto attackedCreature = getAttackedCreature(); + const auto &attackedCreature = getAttackedCreature(); if (!attackedCreature) { return; } @@ -4410,8 +4424,8 @@ void Player::doAttacking(uint32_t) { if ((OTSYS_TIME() - lastAttack) >= getAttackSpeed()) { bool result = false; - std::shared_ptr<Item> tool = getWeapon(); - const WeaponShared_ptr weapon = g_weapons().getWeapon(tool); + const auto &tool = getWeapon(); + const auto &weapon = g_weapons().getWeapon(tool); uint32_t delay = getAttackSpeed(); bool classicSpeed = g_configManager().getBoolean(CLASSIC_ATTACK_SPEED); @@ -4448,9 +4462,9 @@ void Player::doAttacking(uint32_t) { } } -uint64_t Player::getGainedExperience(std::shared_ptr<Creature> attacker) const { +uint64_t Player::getGainedExperience(const std::shared_ptr<Creature> &attacker) const { if (g_configManager().getBoolean(EXPERIENCE_FROM_PLAYERS)) { - auto attackerPlayer = attacker->getPlayer(); + const auto &attackerPlayer = attacker->getPlayer(); if (attackerPlayer && attackerPlayer.get() != this && skillLoss && std::abs(static_cast<int32_t>(attackerPlayer->getLevel() - level)) <= g_configManager().getNumber(EXP_FROM_PLAYERS_LEVEL_RANGE)) { return std::max<uint64_t>(0, std::floor(getLostExperience() * getDamageRatio(attacker) * 0.75)); } @@ -4465,10 +4479,10 @@ void Player::onFollowCreature(const std::shared_ptr<Creature> &creature) { } void Player::setChaseMode(bool mode) { - bool prevChaseMode = chaseMode; + const bool prevChaseMode = chaseMode; chaseMode = mode; - auto attackedCreature = getAttackedCreature(); - auto followCreature = getFollowCreature(); + const auto &attackedCreature = getAttackedCreature(); + const auto &followCreature = getFollowCreature(); if (prevChaseMode != chaseMode) { if (chaseMode) { @@ -4497,8 +4511,10 @@ void Player::onWalkComplete() { */ g_logger().debug("[Player::onWalkComplete] Executing feared conditions as players completed it's walk."); - std::shared_ptr<Condition> f = getCondition(CONDITION_FEARED); - f->executeCondition(static_self_cast<Player>(), 0); + const auto &fearedCondition = getCondition(CONDITION_FEARED); + if (fearedCondition) { + fearedCondition->executeCondition(static_self_cast<Player>(), 0); + } } if (walkTask) { @@ -4522,9 +4538,9 @@ void Player::updateItemsLight(bool internal /*=false*/) { LightInfo maxLight; for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (item) { - LightInfo curLight = item->getLightInfo(); + const auto &curLight = item->getLightInfo(); if (curLight.level > maxLight.level) { maxLight = curLight; @@ -4630,12 +4646,16 @@ void Player::onEndCondition(ConditionType_t type) { sendIcons(); } -void Player::onCombatRemoveCondition(std::shared_ptr<Condition> condition) { +void Player::onCombatRemoveCondition(const std::shared_ptr<Condition> &condition) { + if (!condition) { + return; + } + // Creature::onCombatRemoveCondition(condition); if (condition->getId() > 0) { // Means the condition is from an item, id == slot if (g_game().getWorldType() == WORLD_TYPE_PVP_ENFORCED) { - std::shared_ptr<Item> item = getInventoryItem(static_cast<Slots_t>(condition->getId())); + const auto &item = getInventoryItem(static_cast<Slots_t>(condition->getId())); if (item) { // 25% chance to destroy the item if (25 >= uniform_random(1, 100)) { @@ -4658,9 +4678,13 @@ void Player::onCombatRemoveCondition(std::shared_ptr<Condition> condition) { } } -void Player::onAttackedCreature(std::shared_ptr<Creature> target) { +void Player::onAttackedCreature(const std::shared_ptr<Creature> &target) { Creature::onAttackedCreature(target); + if (!target) { + return; + } + if (target->getZoneType() == ZONE_PVP) { return; } @@ -4674,7 +4698,7 @@ void Player::onAttackedCreature(std::shared_ptr<Creature> target) { return; } - auto targetPlayer = target->getPlayer(); + const auto &targetPlayer = target->getPlayer(); if (targetPlayer && !isPartner(targetPlayer) && !isGuildMate(targetPlayer)) { if (!pzLocked && g_game().getWorldType() == WORLD_TYPE_PVP_ENFORCED) { pzLocked = true; @@ -4732,12 +4756,12 @@ void Player::onPlacedCreature() { sendUnjustifiedPoints(); } -void Player::onAttackedCreatureDrainHealth(std::shared_ptr<Creature> target, int32_t points) { +void Player::onAttackedCreatureDrainHealth(const std::shared_ptr<Creature> &target, int32_t points) { Creature::onAttackedCreatureDrainHealth(target, points); if (target) { if (m_party && !Combat::isPlayerCombat(target)) { - auto tmpMonster = target->getMonster(); + const auto &tmpMonster = target->getMonster(); if (tmpMonster && tmpMonster->isHostile()) { // We have fulfilled a requirement for shared experience m_party->updatePlayerTicks(static_self_cast<Player>(), points); @@ -4746,14 +4770,14 @@ void Player::onAttackedCreatureDrainHealth(std::shared_ptr<Creature> target, int } } -void Player::onTargetCreatureGainHealth(std::shared_ptr<Creature> target, int32_t points) { +void Player::onTargetCreatureGainHealth(const std::shared_ptr<Creature> &target, int32_t points) { if (target && m_party) { std::shared_ptr<Player> tmpPlayer = nullptr; if (isPartner(tmpPlayer) && (tmpPlayer != getPlayer())) { tmpPlayer = target->getPlayer(); - } else if (std::shared_ptr<Creature> targetMaster = target->getMaster()) { - if (std::shared_ptr<Player> targetMasterPlayer = targetMaster->getPlayer()) { + } else if (const auto &targetMaster = target->getMaster()) { + if (const auto &targetMasterPlayer = targetMaster->getPlayer()) { tmpPlayer = targetMasterPlayer; } } @@ -4786,7 +4810,7 @@ bool Player::onKilledPlayer(const std::shared_ptr<Player> &target, bool lastHit) if (lastHit && hasCondition(CONDITION_INFIGHT)) { pzLocked = true; - std::shared_ptr<Condition> condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_INFIGHT, g_configManager().getNumber(WHITE_SKULL_TIME), 0); + const auto &condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_INFIGHT, g_configManager().getNumber(WHITE_SKULL_TIME), 0); addCondition(condition); } } @@ -4804,7 +4828,7 @@ void Player::addHuntingTaskKill(const std::shared_ptr<MonsterType> &mType) { taskSlot->currentKills += 1; if ((taskSlot->upgrade && taskSlot->currentKills >= option->secondKills) || (!taskSlot->upgrade && taskSlot->currentKills >= option->firstKills)) { taskSlot->state = PreyTaskDataState_Completed; - std::string message = "You succesfully finished your hunting task. Your reward is ready to be claimed!"; + const std::string message = "You succesfully finished your hunting task. Your reward is ready to be claimed!"; sendTextMessage(MESSAGE_STATUS, message); } reloadTaskSlot(taskSlot->id); @@ -4840,14 +4864,18 @@ bool Player::onKilledMonster(const std::shared_ptr<Monster> &monster) { if (monster->hasBeenSummoned()) { return false; } - auto mType = monster->getMonsterType(); + const auto &mType = monster->getMonsterType(); + if (mType == nullptr) { + g_logger().error("[{}] Monster type is null.", __FUNCTION__); + return false; + } addHuntingTaskKill(mType); addBestiaryKill(mType); addBosstiaryKill(mType); return false; } -void Player::gainExperience(uint64_t gainExp, std::shared_ptr<Creature> target) { +void Player::gainExperience(uint64_t gainExp, const std::shared_ptr<Creature> &target) { if (hasFlag(PlayerFlags_t::NotGainExperience) || gainExp == 0 || staminaMinutes == 0) { return; } @@ -4855,7 +4883,7 @@ void Player::gainExperience(uint64_t gainExp, std::shared_ptr<Creature> target) addExperience(target, gainExp, true); } -void Player::onGainExperience(uint64_t gainExp, std::shared_ptr<Creature> target) { +void Player::onGainExperience(uint64_t gainExp, const std::shared_ptr<Creature> &target) { if (hasFlag(PlayerFlags_t::NotGainExperience)) { return; } @@ -4870,7 +4898,7 @@ void Player::onGainExperience(uint64_t gainExp, std::shared_ptr<Creature> target gainExperience(gainExp, target); } -void Player::onGainSharedExperience(uint64_t gainExp, std::shared_ptr<Creature> target) { +void Player::onGainSharedExperience(uint64_t gainExp, const std::shared_ptr<Creature> &target) { gainExperience(gainExp, target); } @@ -4893,7 +4921,7 @@ bool Player::isAttackable() const { return !hasFlag(PlayerFlags_t::CannotBeAttacked); } -bool Player::lastHitIsPlayer(std::shared_ptr<Creature> lastHitCreature) { +bool Player::lastHitIsPlayer(const std::shared_ptr<Creature> &lastHitCreature) { if (!lastHitCreature) { return false; } @@ -4902,7 +4930,7 @@ bool Player::lastHitIsPlayer(std::shared_ptr<Creature> lastHitCreature) { return true; } - std::shared_ptr<Creature> lastHitMaster = lastHitCreature->getMaster(); + const auto &lastHitMaster = lastHitCreature->getMaster(); return lastHitMaster && lastHitMaster->getPlayer(); } @@ -4952,7 +4980,7 @@ bool Player::canWear(uint16_t lookType, uint8_t addons) const { return true; } - for (const OutfitEntry &outfitEntry : outfits) { + for (const auto &outfitEntry : outfits) { if (outfitEntry.lookType != lookType) { continue; } @@ -4966,7 +4994,7 @@ bool Player::canLogout() { return false; } - auto tile = getTile(); + const auto &tile = getTile(); if (!tile) { return false; } @@ -4985,18 +5013,18 @@ bool Player::canLogout() { void Player::genReservedStorageRange() { // generate outfits range uint32_t outfits_key = PSTRG_OUTFITS_RANGE_START; - for (const OutfitEntry &entry : outfits) { + for (const auto &entry : outfits) { storageMap[++outfits_key] = (entry.lookType << 16) | entry.addons; } // generate familiars range uint32_t familiar_key = PSTRG_FAMILIARS_RANGE_START; - for (const FamiliarEntry &entry : familiars) { + for (const auto &entry : familiars) { storageMap[++familiar_key] = (entry.lookType << 16); } } void Player::addOutfit(uint16_t lookType, uint8_t addons) { - for (OutfitEntry &outfitEntry : outfits) { + for (auto &outfitEntry : outfits) { if (outfitEntry.lookType == lookType) { outfitEntry.addons |= addons; return; @@ -5007,7 +5035,7 @@ void Player::addOutfit(uint16_t lookType, uint8_t addons) { bool Player::removeOutfit(uint16_t lookType) { for (auto it = outfits.begin(), end = outfits.end(); it != end; ++it) { - OutfitEntry &entry = *it; + const auto &entry = *it; if (entry.lookType == lookType) { outfits.erase(it); return true; @@ -5071,32 +5099,29 @@ bool Player::canFamiliar(uint16_t lookType) const { return true; } - for (const FamiliarEntry &familiarEntry : familiars) { - if (familiarEntry.lookType == lookType) { - return true; - } + if (std::ranges::any_of(familiars, [&](const FamiliarEntry &familiarEntry) { + return familiarEntry.lookType == lookType; + })) { + return true; } + return false; } void Player::addFamiliar(uint16_t lookType) { - for (FamiliarEntry &familiarEntry : familiars) { - if (familiarEntry.lookType == lookType) { - return; - } + if (std::ranges::none_of(familiars, [&](const FamiliarEntry &familiarEntry) { + return familiarEntry.lookType == lookType; + })) { + familiars.emplace_back(lookType); } - familiars.emplace_back(lookType); } bool Player::removeFamiliar(uint16_t lookType) { - for (auto it = familiars.begin(), end = familiars.end(); it != end; ++it) { - FamiliarEntry &entry = *it; - if (entry.lookType == lookType) { - familiars.erase(it); - return true; - } - } - return false; + const auto initialSize = familiars.size(); + std::erase_if(familiars, [lookType](const FamiliarEntry &entry) { + return entry.lookType == lookType; + }); + return familiars.size() != initialSize; } bool Player::getFamiliar(const std::shared_ptr<Familiar> &familiar) const { @@ -5108,11 +5133,9 @@ bool Player::getFamiliar(const std::shared_ptr<Familiar> &familiar) const { return false; } - for (const FamiliarEntry &familiarEntry : familiars) { - if (familiarEntry.lookType != familiar->lookType) { - continue; - } - + if (std::ranges::any_of(familiars, [&](const FamiliarEntry &familiarEntry) { + return familiarEntry.lookType == familiar->lookType; + })) { return true; } @@ -5138,18 +5161,18 @@ Skulls_t Player::getSkull() const { return skull; } -Skulls_t Player::getSkullClient(std::shared_ptr<Creature> creature) { +Skulls_t Player::getSkullClient(const std::shared_ptr<Creature> &creature) { if (!creature || g_game().getWorldType() != WORLD_TYPE_PVP) { return SKULL_NONE; } - std::shared_ptr<Player> player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player && player->getSkull() == SKULL_NONE) { if (player.get() == this) { - for (const auto &kill : unjustifiedKills) { - if (kill.unavenged && (time(nullptr) - kill.time) < g_configManager().getNumber(ORANGE_SKULL_DURATION) * 24 * 60 * 60) { - return SKULL_ORANGE; - } + if (std::ranges::any_of(unjustifiedKills, [&](const auto &kill) { + return kill.unavenged && (getTimeNow() - kill.time) < g_configManager().getNumber(ORANGE_SKULL_DURATION) * 24 * 60 * 60; + })) { + return SKULL_ORANGE; } } @@ -5168,17 +5191,13 @@ Skulls_t Player::getSkullClient(std::shared_ptr<Creature> creature) { return Creature::getSkullClient(creature); } -bool Player::hasKilled(std::shared_ptr<Player> player) const { - for (const auto &kill : unjustifiedKills) { - if (kill.target == player->getGUID() && (time(nullptr) - kill.time) < g_configManager().getNumber(ORANGE_SKULL_DURATION) * 24 * 60 * 60 && kill.unavenged) { - return true; - } - } - - return false; +bool Player::hasKilled(const std::shared_ptr<Player> &player) const { + return std::ranges::any_of(unjustifiedKills, [&](const auto &kill) { + return kill.target == player->getGUID() && (getTimeNow() - kill.time) < g_configManager().getNumber(ORANGE_SKULL_DURATION) * 24 * 60 * 60 && kill.unavenged; + }); } -bool Player::hasAttacked(std::shared_ptr<Player> attacked) const { +bool Player::hasAttacked(const std::shared_ptr<Player> &attacked) const { if (hasFlag(PlayerFlags_t::NotGainInFight) || !attacked) { return false; } @@ -5186,7 +5205,7 @@ bool Player::hasAttacked(std::shared_ptr<Player> attacked) const { return attackedSet.contains(attacked->guid); } -void Player::addAttacked(std::shared_ptr<Player> attacked) { +void Player::addAttacked(const std::shared_ptr<Player> &attacked) { if (hasFlag(PlayerFlags_t::NotGainInFight) || !attacked || attacked == getPlayer()) { return; } @@ -5194,7 +5213,7 @@ void Player::addAttacked(std::shared_ptr<Player> attacked) { attackedSet.emplace(attacked->guid); } -void Player::removeAttacked(std::shared_ptr<Player> attacked) { +void Player::removeAttacked(const std::shared_ptr<Player> &attacked) { if (!attacked || attacked == getPlayer()) { return; } @@ -5206,7 +5225,7 @@ void Player::clearAttacked() { attackedSet.clear(); } -void Player::addUnjustifiedDead(std::shared_ptr<Player> attacked) { +void Player::addUnjustifiedDead(const std::shared_ptr<Player> &attacked) { if (hasFlag(PlayerFlags_t::NotGainInFight) || attacked == getPlayer() || g_game().getWorldType() == WORLD_TYPE_PVP_ENFORCED) { return; } @@ -5248,7 +5267,7 @@ void Player::addUnjustifiedDead(std::shared_ptr<Player> attacked) { } void Player::checkSkullTicks(int64_t ticks) { - int64_t newTicks = skullTicks - ticks; + const int64_t newTicks = skullTicks - ticks; if (newTicks < 0) { skullTicks = 0; } else { @@ -5261,13 +5280,13 @@ void Player::checkSkullTicks(int64_t ticks) { } bool Player::isPromoted() const { - uint16_t promotedVocation = g_vocations().getPromotedVocation(vocation->getId()); + const uint16_t promotedVocation = g_vocations().getPromotedVocation(vocation->getId()); return promotedVocation == VOCATION_NONE && vocation->getId() != promotedVocation; } double Player::getLostPercent() const { int32_t blessingCount = 0; - uint8_t maxBlessing = (operatingSystem == CLIENTOS_NEW_WINDOWS || operatingSystem == CLIENTOS_NEW_MAC) ? 8 : 6; + const uint8_t maxBlessing = (operatingSystem == CLIENTOS_NEW_WINDOWS || operatingSystem == CLIENTOS_NEW_MAC) ? 8 : 6; for (int i = 2; i <= maxBlessing; i++) { if (hasBlessing(i)) { blessingCount++; @@ -5286,7 +5305,7 @@ double Player::getLostPercent() const { double lossPercent; if (level >= 24) { - double tmpLevel = level + (levelPercent / 100.); + const double tmpLevel = level + (levelPercent / 100.); lossPercent = ((tmpLevel + 50) * 50 * ((tmpLevel * tmpLevel) - (5 * tmpLevel) + 8)) / experience; } else { lossPercent = 5; @@ -5320,15 +5339,12 @@ bool Player::hasLearnedInstantSpell(const std::string &spellName) const { return true; } - for (const auto &learnedSpellName : learnedInstantSpellList) { - if (strcasecmp(learnedSpellName.c_str(), spellName.c_str()) == 0) { - return true; - } - } - return false; + return std::ranges::any_of(learnedInstantSpellList, [&](const auto &learnedSpellName) { + return strcasecmp(learnedSpellName.c_str(), spellName.c_str()) == 0; + }); } -bool Player::isInWar(std::shared_ptr<Player> player) const { +bool Player::isInWar(const std::shared_ptr<Player> &player) const { if (!player || !guild) { return false; } @@ -5342,7 +5358,7 @@ bool Player::isInWar(std::shared_ptr<Player> player) const { } bool Player::isInWarList(uint32_t guildId) const { - return std::find(guildWarVector.begin(), guildWarVector.end(), guildId) != guildWarVector.end(); + return std::ranges::find(guildWarVector, guildId) != guildWarVector.end(); } uint32_t Player::getMagicLevel() const { @@ -5363,7 +5379,7 @@ uint32_t Player::getLoyaltyMagicLevel() const { } absl::uint128 spent = manaSpent; - absl::uint128 totalMana = vocation->getTotalMana(level) + spent; + const absl::uint128 totalMana = vocation->getTotalMana(level) + spent; absl::uint128 loyaltyMana = (totalMana * getLoyaltyBonus()) / 100; while ((spent + loyaltyMana) >= nextReqMana) { loyaltyMana -= nextReqMana - spent; @@ -5383,7 +5399,8 @@ uint32_t Player::getLoyaltyMagicLevel() const { uint32_t Player::getCapacity() const { if (hasFlag(PlayerFlags_t::CannotPickupItem)) { return 0; - } else if (hasFlag(PlayerFlags_t::HasInfiniteCapacity)) { + } + if (hasFlag(PlayerFlags_t::HasInfiniteCapacity)) { return std::numeric_limits<uint32_t>::max(); } return capacity + bonusCapacity + varStats[STAT_CAPACITY] + (m_wheelPlayer->getStat(WheelStat_t::CAPACITY) * 100); @@ -5401,7 +5418,7 @@ uint16_t Player::getSkillLevel(skills_t skill) const { auto skillLevel = getLoyaltySkill(skill); skillLevel = std::max<int32_t>(0, skillLevel + varSkills[skill]); - if (auto it = maxValuePerSkill.find(skill); + if (const auto it = maxValuePerSkill.find(skill); it != maxValuePerSkill.end()) { skillLevel = std::min<int32_t>(it->second, skillLevel); } @@ -5429,7 +5446,7 @@ uint16_t Player::getSkillLevel(skills_t skill) const { skillLevel += m_wheelPlayer->checkAvatarSkill(WheelAvatarSkill_t::CRITICAL_DAMAGE); } - int32_t avatarCritChance = m_wheelPlayer->checkAvatarSkill(WheelAvatarSkill_t::CRITICAL_CHANCE); + const int32_t avatarCritChance = m_wheelPlayer->checkAvatarSkill(WheelAvatarSkill_t::CRITICAL_CHANCE); if (skill == SKILL_CRITICAL_HIT_CHANCE && avatarCritChance > 0) { skillLevel = avatarCritChance; // 100% } @@ -5480,7 +5497,7 @@ int32_t Player::getCleavePercent(bool useCharges) const { const int32_t &cleave_percent = it.abilities->cleavePercent; if (cleave_percent != 0) { result += cleave_percent; - uint16_t charges = item->getCharges(); + const uint16_t charges = item->getCharges(); if (useCharges && charges != 0) { g_game().transformItem(item, item->getID(), charges - 1); } @@ -5509,7 +5526,7 @@ int32_t Player::getPerfectShotDamage(uint8_t range, bool useCharges) const { if (itemType.abilities->perfectShotRange == range) { result += itemType.abilities->perfectShotDamage; - uint16_t charges = item->getCharges(); + const uint16_t charges = item->getCharges(); if (useCharges && charges != 0) { g_game().transformItem(item, item->getID(), charges - 1); } @@ -5527,10 +5544,10 @@ int32_t Player::getSpecializedMagicLevel(CombatType_t combat, bool useCharges) c continue; } - int32_t specialized_magic_level = itemType.abilities->specializedMagicLevel[combatTypeToIndex(combat)]; + const int32_t specialized_magic_level = itemType.abilities->specializedMagicLevel[combatTypeToIndex(combat)]; if (specialized_magic_level > 0) { result += specialized_magic_level; - uint16_t charges = item->getCharges(); + const uint16_t charges = item->getCharges(); if (useCharges && charges != 0) { g_game().transformItem(item, item->getID(), charges - 1); } @@ -5548,10 +5565,10 @@ int32_t Player::getMagicShieldCapacityFlat(bool useCharges) const { continue; } - int32_t magicCapacity = itemType.abilities->magicShieldCapacityFlat; + const int32_t magicCapacity = itemType.abilities->magicShieldCapacityFlat; if (magicCapacity != 0) { result += magicCapacity; - uint16_t charges = item->getCharges(); + const uint16_t charges = item->getCharges(); if (useCharges && charges != 0) { g_game().transformItem(item, item->getID(), charges - 1); } @@ -5569,10 +5586,10 @@ int32_t Player::getMagicShieldCapacityPercent(bool useCharges) const { continue; } - int32_t magicPercent = itemType.abilities->magicShieldCapacityPercent; + const int32_t magicPercent = itemType.abilities->magicShieldCapacityPercent; if (magicPercent != 0) { result += magicPercent; - uint16_t charges = item->getCharges(); + const uint16_t charges = item->getCharges(); if (useCharges && charges != 0) { g_game().transformItem(item, item->getID(), charges - 1); } @@ -5593,7 +5610,7 @@ double_t Player::getReflectPercent(CombatType_t combat, bool useCharges) const { double_t reflectPercent = itemType.abilities->reflectPercent[combatTypeToIndex(combat)]; if (reflectPercent != 0) { result += reflectPercent; - uint16_t charges = item->getCharges(); + const uint16_t charges = item->getCharges(); if (useCharges && charges != 0) { g_game().transformItem(item, item->getID(), charges - 1); } @@ -5611,10 +5628,10 @@ int32_t Player::getReflectFlat(CombatType_t combat, bool useCharges) const { continue; } - int32_t reflectFlat = itemType.abilities->reflectFlat[combatTypeToIndex(combat)]; + const int32_t reflectFlat = itemType.abilities->reflectFlat[combatTypeToIndex(combat)]; if (reflectFlat != 0) { result += reflectFlat; - uint16_t charges = item->getCharges(); + const uint16_t charges = item->getCharges(); if (useCharges && charges != 0) { g_game().transformItem(item, item->getID(), charges - 1); } @@ -5628,7 +5645,7 @@ void Player::setTransferableTibiaCoins(int32_t v) { coinTransferableBalance = v; } -PartyShields_t Player::getPartyShield(std::shared_ptr<Player> player) { +PartyShields_t Player::getPartyShield(const std::shared_ptr<Player> &player) { if (!player) { return SHIELD_NONE; } @@ -5682,34 +5699,34 @@ PartyShields_t Player::getPartyShield(std::shared_ptr<Player> player) { return SHIELD_NONE; } -bool Player::isInviting(std::shared_ptr<Player> player) const { +bool Player::isInviting(const std::shared_ptr<Player> &player) const { if (!player || !m_party || m_party->getLeader().get() != this) { return false; } return m_party->isPlayerInvited(player); } -bool Player::isPartner(std::shared_ptr<Player> player) const { +bool Player::isPartner(const std::shared_ptr<Player> &player) const { if (!player || !m_party || player.get() == this) { return false; } return m_party == player->m_party; } -bool Player::isGuildMate(std::shared_ptr<Player> player) const { +bool Player::isGuildMate(const std::shared_ptr<Player> &player) const { if (!player || !guild) { return false; } return guild == player->guild; } -void Player::sendPlayerPartyIcons(std::shared_ptr<Player> player) { +void Player::sendPlayerPartyIcons(const std::shared_ptr<Player> &player) const { sendPartyCreatureShield(player); sendPartyCreatureSkull(player); } -bool Player::addPartyInvitation(std::shared_ptr<Party> newParty) { - auto it = std::find(invitePartyList.begin(), invitePartyList.end(), newParty); +bool Player::addPartyInvitation(const std::shared_ptr<Party> &newParty) { + auto it = std::ranges::find(invitePartyList, newParty); if (it != invitePartyList.end()) { return false; } @@ -5718,7 +5735,7 @@ bool Player::addPartyInvitation(std::shared_ptr<Party> newParty) { return true; } -void Player::removePartyInvitation(std::shared_ptr<Party> remParty) { +void Player::removePartyInvitation(const std::shared_ptr<Party> &remParty) { std::erase(invitePartyList, remParty); } @@ -5729,12 +5746,12 @@ void Player::clearPartyInvitations() { invitePartyList.clear(); } -GuildEmblems_t Player::getGuildEmblem(std::shared_ptr<Player> player) const { +GuildEmblems_t Player::getGuildEmblem(const std::shared_ptr<Player> &player) const { if (!player) { return GUILDEMBLEM_NONE; } - const auto playerGuild = player->getGuild(); + const auto &playerGuild = player->getGuild(); if (!playerGuild) { return GUILDEMBLEM_NONE; } @@ -5742,19 +5759,20 @@ GuildEmblems_t Player::getGuildEmblem(std::shared_ptr<Player> player) const { if (player->getGuildWarVector().empty()) { if (guild == playerGuild) { return GUILDEMBLEM_MEMBER; - } else { - return GUILDEMBLEM_OTHER; } - } else if (guild == playerGuild) { + return GUILDEMBLEM_OTHER; + } + if (guild == playerGuild) { return GUILDEMBLEM_ALLY; - } else if (isInWar(player)) { + } + if (isInWar(player)) { return GUILDEMBLEM_ENEMY; } return GUILDEMBLEM_NEUTRAL; } -void Player::sendUnjustifiedPoints() { +void Player::sendUnjustifiedPoints() const { if (client) { double dayKills = 0; double weekKills = 0; @@ -5773,15 +5791,15 @@ void Player::sendUnjustifiedPoints() { } } - bool isRed = getSkull() == SKULL_RED; + const bool isRed = getSkull() == SKULL_RED; auto dayMax = ((isRed ? 2 : 1) * g_configManager().getNumber(DAY_KILLS_TO_RED)); auto weekMax = ((isRed ? 2 : 1) * g_configManager().getNumber(WEEK_KILLS_TO_RED)); auto monthMax = ((isRed ? 2 : 1) * g_configManager().getNumber(MONTH_KILLS_TO_RED)); - uint8_t dayProgress = std::min(std::round(dayKills / dayMax * 100), 100.0); - uint8_t weekProgress = std::min(std::round(weekKills / weekMax * 100), 100.0); - uint8_t monthProgress = std::min(std::round(monthKills / monthMax * 100), 100.0); + const uint8_t dayProgress = std::min(std::round(dayKills / dayMax * 100), 100.0); + const uint8_t weekProgress = std::min(std::round(weekKills / weekMax * 100), 100.0); + const uint8_t monthProgress = std::min(std::round(monthKills / monthMax * 100), 100.0); uint8_t skullDuration = 0; if (skullTicks != 0) { skullDuration = std::floor<uint8_t>(skullTicks / (24 * 60 * 60 * 1000)); @@ -5791,7 +5809,7 @@ void Player::sendUnjustifiedPoints() { } uint8_t Player::getLastMount() const { - int32_t value = getStorageValue(PSTRG_MOUNTS_CURRENTMOUNT); + const int32_t value = getStorageValue(PSTRG_MOUNTS_CURRENTMOUNT); if (value > 0) { return value; } @@ -5799,7 +5817,7 @@ uint8_t Player::getLastMount() const { } uint8_t Player::getCurrentMount() const { - int32_t value = getStorageValue(PSTRG_MOUNTS_CURRENTMOUNT); + const int32_t value = getStorageValue(PSTRG_MOUNTS_CURRENTMOUNT); if (value > 0) { return value; } @@ -5811,13 +5829,10 @@ void Player::setCurrentMount(uint8_t mount) { } bool Player::hasAnyMount() const { - const auto mounts = g_game().mounts.getMounts(); - for (const auto &mount : mounts) { - if (hasMount(mount)) { - return true; - } - } - return false; + const auto &mounts = g_game().mounts.getMounts(); + return std::ranges::any_of(mounts, [&](const auto &mount) { + return hasMount(mount); + }); } uint8_t Player::getRandomMountId() const { @@ -5825,12 +5840,12 @@ uint8_t Player::getRandomMountId() const { const auto mounts = g_game().mounts.getMounts(); for (const auto &mount : mounts) { if (hasMount(mount)) { - playerMounts.push_back(mount->id); + playerMounts.emplace_back(mount->id); } } - auto playerMountsSize = static_cast<int32_t>(playerMounts.size() - 1); - auto randomIndex = uniform_random(0, std::max<int32_t>(0, playerMountsSize)); + const auto playerMountsSize = static_cast<int32_t>(playerMounts.size() - 1); + const auto randomIndex = uniform_random(0, std::max<int32_t>(0, playerMountsSize)); return playerMounts.at(randomIndex); } @@ -5849,7 +5864,7 @@ bool Player::toggleMount(bool mount) { return false; } - auto tile = getTile(); + const auto &tile = getTile(); if (!g_configManager().getBoolean(TOGGLE_MOUNT_IN_PZ) && !group->access && tile && tile->hasFlag(TILESTATE_PROTECTIONZONE)) { sendCancelMessage(RETURNVALUE_ACTIONNOTPERMITTEDINPROTECTIONZONE); return false; @@ -5870,7 +5885,7 @@ bool Player::toggleMount(bool mount) { currentMountId = getRandomMountId(); } - const auto currentMount = g_game().mounts.getMountByID(currentMountId); + const auto ¤tMount = g_game().mounts.getMountByID(currentMountId); if (!currentMount) { return false; } @@ -5960,7 +5975,7 @@ bool Player::untameMount(uint8_t mountId) { return true; } -bool Player::hasMount(const std::shared_ptr<Mount> mount) const { +bool Player::hasMount(const std::shared_ptr<Mount> &mount) const { if (isAccessPlayer()) { return true; } @@ -5971,7 +5986,7 @@ bool Player::hasMount(const std::shared_ptr<Mount> mount) const { const uint8_t tmpMountId = mount->id - 1; - int32_t value = getStorageValue(PSTRG_MOUNTS_RANGE_START + (tmpMountId / 31)); + const int32_t value = getStorageValue(PSTRG_MOUNTS_RANGE_START + (tmpMountId / 31)); if (value == -1) { return false; } @@ -5980,7 +5995,7 @@ bool Player::hasMount(const std::shared_ptr<Mount> mount) const { } void Player::dismount() { - const auto mount = g_game().mounts.getMountByID(getCurrentMount()); + const auto &mount = g_game().mounts.getMountByID(getCurrentMount()); if (mount && mount->speed > 0) { g_game().changeSpeed(static_self_cast<Player>(), -mount->speed); } @@ -6137,8 +6152,15 @@ bool Player::addOfflineTrainingTries(skills_t skill, uint64_t tries) { return sendUpdate; } +std::shared_ptr<Town> Player::getTown() const { + return town; +} +void Player::setTown(const std::shared_ptr<Town> &newTown) { + this->town = newTown; +} + bool Player::hasModalWindowOpen(uint32_t modalWindowId) const { - return find(modalWindows.begin(), modalWindows.end(), modalWindowId) != modalWindows.end(); + return std::ranges::find(modalWindows, modalWindowId) != modalWindows.end(); } void Player::onModalWindowHandled(uint32_t modalWindowId) { @@ -6199,8 +6221,8 @@ void Player::sendIcons() { } // Iterates over the Bakragore icons to check if the player has any - IconBakragore iconBakragore = IconBakragore::None; - for (auto icon : magic_enum::enum_values<IconBakragore>()) { + auto iconBakragore = IconBakragore::None; + for (const auto &icon : magic_enum::enum_values<IconBakragore>()) { if (icon == IconBakragore::None) { continue; } @@ -6223,7 +6245,7 @@ void Player::sendIcons() { client->sendIcons(iconSet, iconBakragore); } -void Player::sendIconBakragore(const IconBakragore icon) { +void Player::sendIconBakragore(const IconBakragore icon) const { if (client) { client->sendIconBakragore(icon); } @@ -6243,42 +6265,38 @@ void Player::removeBakragoreIcon(const IconBakragore icon) { } } -void Player::sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, std::vector<std::pair<Achievement, uint32_t>> achievementsUnlocked) { +void Player::sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, const std::vector<std::pair<Achievement, uint32_t>> &achievementsUnlocked) const { if (client) { client->sendCyclopediaCharacterAchievements(secretsUnlocked, achievementsUnlocked); } } uint64_t Player::getMoney() const { - std::vector<std::shared_ptr<Container>> containers; uint64_t moneyCount = 0; + auto countMoneyInContainer = [&moneyCount](const auto &self, const std::shared_ptr<Container> &container) -> void { + for (const auto &item : container->getItemList()) { + if (const auto &tmpContainer = item->getContainer()) { + self(self, tmpContainer); + } else { + moneyCount += item->getWorth(); + } + } + }; + for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } - std::shared_ptr<Container> container = item->getContainer(); - if (container) { - containers.push_back(container); + if (const auto &container = item->getContainer()) { + countMoneyInContainer(countMoneyInContainer, container); } else { moneyCount += item->getWorth(); } } - size_t i = 0; - while (i < containers.size()) { - std::shared_ptr<Container> container = containers[i++]; - for (const std::shared_ptr<Item> &item : container->getItemList()) { - std::shared_ptr<Container> tmpContainer = item->getContainer(); - if (tmpContainer) { - containers.push_back(tmpContainer); - } else { - moneyCount += item->getWorth(); - } - } - } return moneyCount; } @@ -6297,8 +6315,8 @@ std::pair<uint64_t, uint64_t> Player::getForgeSliversAndCores() const { } // Check items from stash - for (StashItemList stashToSend = getStashItems(); - auto [itemId, itemCount] : stashToSend) { + for (const auto &stashToSend = getStashItems(); + const auto &[itemId, itemCount] : stashToSend) { if (itemId == ITEM_FORGE_SLIVER) { sliverCount += itemCount; } @@ -6313,7 +6331,8 @@ std::pair<uint64_t, uint64_t> Player::getForgeSliversAndCores() const { size_t Player::getMaxDepotItems() const { if (group->maxDepotItems != 0) { return group->maxDepotItems; - } else if (isPremium()) { + } + if (isPremium()) { return g_configManager().getNumber(PREMIUM_DEPOT_LIMIT); } return g_configManager().getNumber(FREE_DEPOT_LIMIT); @@ -6323,12 +6342,12 @@ std::vector<std::shared_ptr<Condition>> Player::getMuteConditions() const { std::vector<std::shared_ptr<Condition>> muteConditions; muteConditions.reserve(conditions.size()); - for (const std::shared_ptr<Condition> &condition : conditions) { + for (const auto &condition : conditions) { if (condition->getTicks() <= 0) { continue; } - ConditionType_t type = condition->getType(); + const auto &type = condition->getType(); if (type != CONDITION_MUTED && type != CONDITION_CHANNELMUTEDTICKS && type != CONDITION_YELLTICKS) { continue; } @@ -6338,7 +6357,7 @@ std::vector<std::shared_ptr<Condition>> Player::getMuteConditions() const { return muteConditions; } -void Player::setGuild(const std::shared_ptr<Guild> newGuild) { +void Player::setGuild(const std::shared_ptr<Guild> &newGuild) { if (newGuild == guild) { return; } @@ -6352,7 +6371,7 @@ void Player::setGuild(const std::shared_ptr<Guild> newGuild) { guildRank = nullptr; if (newGuild) { - const auto rank = newGuild->getRankByLevel(1); + const auto &rank = newGuild->getRankByLevel(1); if (!rank) { return; } @@ -6363,12 +6382,12 @@ void Player::setGuild(const std::shared_ptr<Guild> newGuild) { } } -void Player::updateRegeneration() { +void Player::updateRegeneration() const { if (!vocation) { return; } - std::shared_ptr<Condition> condition = getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT); + const auto &condition = getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT); if (condition) { condition->setParam(CONDITION_PARAM_HEALTHGAIN, vocation->getHealthGainAmount()); condition->setParam(CONDITION_PARAM_HEALTHTICKS, vocation->getHealthGainTicks()); @@ -6392,7 +6411,7 @@ void Player::setImmuneFear() { } bool Player::isImmuneFear() const { - uint64_t timenow = OTSYS_TIME(); + const uint64_t timenow = OTSYS_TIME(); return (m_fearCondition.first == CONDITION_FEARED) && (timenow <= m_fearCondition.second); } @@ -6402,22 +6421,22 @@ uint64_t Player::getItemCustomPrice(uint16_t itemId, bool buyPrice /* = false*/) return it->second; } - std::map<uint16_t, uint64_t> itemMap { { itemId, 1 } }; + const std::map<uint16_t, uint64_t> itemMap { { itemId, 1 } }; return g_game().getItemMarketPrice(itemMap, buyPrice); } uint16_t Player::getFreeBackpackSlots() const { - std::shared_ptr<Thing> thing = getThing(CONST_SLOT_BACKPACK); + const auto &thing = getThing(CONST_SLOT_BACKPACK); if (!thing) { return 0; } - std::shared_ptr<Container> backpack = thing->getContainer(); + const auto &backpack = thing->getContainer(); if (!backpack) { return 0; } - uint16_t counter = std::max<uint16_t>(0, backpack->getFreeSlots()); + const uint16_t counter = std::max<uint16_t>(0, backpack->getFreeSlots()); return counter; } @@ -6503,12 +6522,12 @@ void Player::updateImbuementTrackerStats() const { } bool Player::addItemFromStash(uint16_t itemId, uint32_t itemCount) { - uint32_t stackCount = 100u; + const uint32_t stackCount = 100u; while (itemCount > 0) { - auto addValue = itemCount > stackCount ? stackCount : itemCount; + const auto addValue = itemCount > stackCount ? stackCount : itemCount; itemCount -= addValue; - std::shared_ptr<Item> newItem = Item::CreateItem(itemId, addValue); + const auto &newItem = Item::CreateItem(itemId, addValue); if (!g_game().tryRetrieveStashItems(static_self_cast<Player>(), newItem)) { g_game().internalPlayerAddItem(static_self_cast<Player>(), newItem, true); @@ -6525,19 +6544,17 @@ bool Player::addItemFromStash(uint16_t itemId, uint32_t itemCount) { void sendStowItems(const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &stowItem, StashContainerList &itemDict) { if (stowItem->getID() == item->getID()) { - itemDict.push_back(std::pair<std::shared_ptr<Item>, uint32_t>(stowItem, stowItem->getItemCount())); + itemDict.emplace_back(stowItem, stowItem->getItemCount()); } - if (auto container = stowItem->getContainer()) { - for (const auto &stowable_it : container->getStowableItems()) { - if ((stowable_it.first)->getID() == item->getID()) { - itemDict.push_back(stowable_it); - } - } + if (const auto &container = stowItem->getContainer()) { + std::ranges::copy_if(container->getStowableItems(), std::back_inserter(itemDict), [&item](const auto &stowable_it) { + return stowable_it.first->getID() == item->getID(); + }); } } -void Player::stowItem(std::shared_ptr<Item> item, uint32_t count, bool allItems) { +void Player::stowItem(const std::shared_ptr<Item> &item, uint32_t count, bool allItems) { if (!item || !item->isItemStorable()) { sendCancelMessage("This item cannot be stowed here."); return; @@ -6547,21 +6564,21 @@ void Player::stowItem(std::shared_ptr<Item> item, uint32_t count, bool allItems) if (allItems) { if (!item->isInsideDepot(true)) { // Stow "all items" from player backpack - if (auto backpack = getInventoryItem(CONST_SLOT_BACKPACK)) { + if (const auto &backpack = getInventoryItem(CONST_SLOT_BACKPACK)) { sendStowItems(item, backpack, itemDict); } // Stow "all items" from loot pouch - auto itemParent = item->getParent(); - auto lootPouch = itemParent->getItem(); + const auto &itemParent = item->getParent(); + const auto &lootPouch = itemParent->getItem(); if (itemParent && lootPouch && lootPouch->getID() == ITEM_GOLD_POUCH) { sendStowItems(item, lootPouch, itemDict); } } // Stow locker items - std::shared_ptr<DepotLocker> depotLocker = getDepotLocker(getLastDepotId()); - auto [itemVector, itemMap] = requestLockerItems(depotLocker); + const auto &depotLocker = getDepotLocker(getLastDepotId()); + const auto &[itemVector, itemMap] = requestLockerItems(depotLocker); for (const auto &lockerItem : itemVector) { if (lockerItem == nullptr) { break; @@ -6598,21 +6615,21 @@ void Player::openPlayerContainers() { std::vector<std::pair<uint8_t, std::shared_ptr<Container>>> openContainersList; for (int32_t i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; i++) { - std::shared_ptr<Item> item = inventory[i]; + const auto &item = inventory[i]; if (!item) { continue; } - std::shared_ptr<Container> itemContainer = item->getContainer(); + const auto &itemContainer = item->getContainer(); if (itemContainer) { - auto cid = item->getAttribute<int64_t>(ItemAttribute_t::OPENCONTAINER); + const auto &cid = item->getAttribute<int64_t>(ItemAttribute_t::OPENCONTAINER); if (cid > 0) { openContainersList.emplace_back(cid, itemContainer); } for (ContainerIterator it = itemContainer->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Container> subContainer = (*it)->getContainer(); + const auto &subContainer = (*it)->getContainer(); if (subContainer) { - auto subcid = (*it)->getAttribute<uint8_t>(ItemAttribute_t::OPENCONTAINER); + const auto &subcid = (*it)->getAttribute<uint8_t>(ItemAttribute_t::OPENCONTAINER); if (subcid > 0) { openContainersList.emplace_back(subcid, subContainer); } @@ -6621,13 +6638,13 @@ void Player::openPlayerContainers() { } } - std::sort(openContainersList.begin(), openContainersList.end(), [](const std::pair<uint8_t, std::shared_ptr<Container>> &left, const std::pair<uint8_t, std::shared_ptr<Container>> &right) { + std::ranges::sort(openContainersList, [](const std::pair<uint8_t, std::shared_ptr<Container>> &left, const std::pair<uint8_t, std::shared_ptr<Container>> &right) { return left.first < right.first; }); - for (auto &it : openContainersList) { - addContainer(it.first - 1, it.second); - onSendContainer(it.second); + for (const auto &[containerId, container] : openContainersList) { + addContainer(containerId - 1, container); + onSendContainer(container); } } @@ -6652,9 +6669,9 @@ void Player::initializePrey() { } void Player::removePreySlotById(PreySlot_t slotid) { - auto it = std::remove_if(preys.begin(), preys.end(), [slotid](const std::unique_ptr<PreySlot> &preyIt) { - return preyIt->id == slotid; - }); + const auto it = std::ranges::remove_if(preys, [slotid](const auto &preyIt) { + return preyIt->id == slotid; + }).begin(); preys.erase(it, preys.end()); } @@ -6685,7 +6702,7 @@ void Player::initializeTaskHunting() { std::string Player::getBlessingsName() const { std::vector<std::string> blessingNames; - for (auto bless : magic_enum::enum_values<Blessings>()) { + for (const auto &bless : magic_enum::enum_values<Blessings>()) { if (hasBlessing(enumToValue(bless))) { std::string name = toStartCaseWithSpace(magic_enum::enum_name(bless).data()); blessingNames.emplace_back(name); @@ -6707,7 +6724,7 @@ std::string Player::getBlessingsName() const { return os.str(); } -bool Player::isCreatureUnlockedOnTaskHunting(const std::shared_ptr<MonsterType> mtype) const { +bool Player::isCreatureUnlockedOnTaskHunting(const std::shared_ptr<MonsterType> &mtype) const { if (!mtype) { return false; } @@ -6716,10 +6733,8 @@ bool Player::isCreatureUnlockedOnTaskHunting(const std::shared_ptr<MonsterType> } void Player::triggerMomentum() { - auto item = getInventoryItem(CONST_SLOT_HEAD); - double_t chance = 0; - if (item) { + if (const auto &item = getInventoryItem(CONST_SLOT_HEAD)) { chance += item->getMomentumChance(); } @@ -6729,13 +6744,13 @@ void Player::triggerMomentum() { bool triggered = false; auto it = conditions.begin(); while (it != conditions.end()) { - auto condItem = *it; - ConditionType_t type = condItem->getType(); - auto maxu16 = std::numeric_limits<uint16_t>::max(); - auto checkSpellId = condItem->getSubId(); + const auto condItem = *it; + const ConditionType_t type = condItem->getType(); + constexpr auto maxu16 = std::numeric_limits<uint16_t>::max(); + const auto checkSpellId = condItem->getSubId(); auto spellId = checkSpellId > maxu16 ? 0u : static_cast<uint16_t>(checkSpellId); - int32_t ticks = condItem->getTicks(); - int32_t newTicks = (ticks <= 2000) ? 0 : ticks - 2000; + const int32_t ticks = condItem->getTicks(); + const int32_t newTicks = (ticks <= 2000) ? 0 : ticks - 2000; triggered = true; if (type == CONDITION_SPELLCOOLDOWN || (type == CONDITION_SPELLGROUPCOOLDOWN && spellId > SPELLGROUP_SUPPORT)) { condItem->setTicks(newTicks); @@ -6753,10 +6768,15 @@ void Player::triggerMomentum() { void Player::clearCooldowns() { auto it = conditions.begin(); while (it != conditions.end()) { - auto condItem = *it; - ConditionType_t type = condItem->getType(); - auto maxu16 = std::numeric_limits<uint16_t>::max(); - auto checkSpellId = condItem->getSubId(); + const auto &condItem = *it; + if (!condItem) { + ++it; + continue; + } + + const ConditionType_t type = condItem->getType(); + constexpr auto maxu16 = std::numeric_limits<uint16_t>::max(); + const auto checkSpellId = condItem->getSubId(); auto spellId = checkSpellId > maxu16 ? 0u : static_cast<uint16_t>(checkSpellId); if (type == CONDITION_SPELLCOOLDOWN || type == CONDITION_SPELLGROUPCOOLDOWN) { condItem->setTicks(0); @@ -6771,16 +6791,16 @@ void Player::triggerTranscendance() { return; } - auto item = getInventoryItem(CONST_SLOT_LEGS); + const auto &item = getInventoryItem(CONST_SLOT_LEGS); if (item == nullptr) { return; } - double_t chance = item->getTranscendenceChance(); - double_t randomChance = uniform_random(0, 10000) / 100.; + const double_t chance = item->getTranscendenceChance(); + const double_t randomChance = uniform_random(0, 10000) / 100.; if (getZoneType() != ZONE_PROTECTION && checkLastAggressiveActionWithin(2000) && ((OTSYS_TIME() / 1000) % 2) == 0 && chance > 0 && randomChance < chance) { int64_t duration = g_configManager().getNumber(TRANSCENDANCE_AVATAR_DURATION); - auto outfitCondition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_OUTFIT, duration, 0)->static_self_cast<ConditionOutfit>(); + const auto &outfitCondition = Condition::createCondition(CONDITIONID_COMBAT, CONDITION_OUTFIT, duration, 0)->static_self_cast<ConditionOutfit>(); Outfit_t outfit; outfit.lookType = getVocation()->getAvatarLookType(); outfitCondition->setOutfit(outfit); @@ -6798,7 +6818,7 @@ void Player::triggerTranscendance() { const auto &task = createPlayerTask( std::max<uint32_t>(SCHEDULER_MINTICKS, duration), [playerId = getID()] { - auto player = g_game().getPlayerByID(playerId); + const auto &player = g_game().getPlayerByID(playerId); if (player) { player->sendSkills(); player->sendStats(); @@ -6820,13 +6840,13 @@ void Player::triggerTranscendance() { void Player::requestDepotItems() { ItemsTierCountList itemMap; uint16_t count = 0; - std::shared_ptr<DepotLocker> depotLocker = getDepotLocker(getLastDepotId()); + const auto &depotLocker = getDepotLocker(getLastDepotId()); if (!depotLocker) { return; } - for (const std::shared_ptr<Item> &locker : depotLocker->getItemList()) { - std::shared_ptr<Container> c = locker->getContainer(); + for (const auto &locker : depotLocker->getItemList()) { + const auto &c = locker->getContainer(); if (!c || c->empty()) { continue; } @@ -6886,31 +6906,34 @@ void Player::requestDepotSearchItem(uint16_t itemId, uint8_t tier) { stashCount = getStashItemCount(itemId); } - std::shared_ptr<DepotLocker> depotLocker = getDepotLocker(getLastDepotId()); + const auto &depotLocker = getDepotLocker(getLastDepotId()); if (!depotLocker) { return; } - for (const std::shared_ptr<Item> &locker : depotLocker->getItemList()) { - std::shared_ptr<Container> c = locker->getContainer(); + for (const auto &locker : depotLocker->getItemList()) { + const auto &c = locker->getContainer(); if (!c || c->empty()) { continue; } + inboxItems.reserve(inboxItems.size()); + depotItems.reserve(depotItems.size()); + for (ContainerIterator it = c->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; + const auto item = *it; if (!item || item->getID() != itemId || item->getTier() != tier) { continue; } if (c->isInbox()) { if (inboxItems.size() < 255) { - inboxItems.push_back(item); + inboxItems.emplace_back(item); } inboxCount += Item::countByType(item, -1); } else { if (depotItems.size() < 255) { - depotItems.push_back(item); + depotItems.emplace_back(item); } depotCount += Item::countByType(item, -1); } @@ -6922,14 +6945,14 @@ void Player::requestDepotSearchItem(uint16_t itemId, uint8_t tier) { } void Player::retrieveAllItemsFromDepotSearch(uint16_t itemId, uint8_t tier, bool isDepot) { - std::shared_ptr<DepotLocker> depotLocker = getDepotLocker(getLastDepotId()); + const auto &depotLocker = getDepotLocker(getLastDepotId()); if (!depotLocker) { return; } std::vector<std::shared_ptr<Item>> itemsVector; - for (const std::shared_ptr<Item> &locker : depotLocker->getItemList()) { - std::shared_ptr<Container> c = locker->getContainer(); + for (const auto &locker : depotLocker->getItemList()) { + const auto &c = locker->getContainer(); if (!c || c->empty() || // Retrieve from inbox. (c->isInbox() && isDepot) || @@ -6939,19 +6962,23 @@ void Player::retrieveAllItemsFromDepotSearch(uint16_t itemId, uint8_t tier, bool } for (ContainerIterator it = c->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; + const auto &item = *it; if (!item) { continue; } if (item->getID() == itemId && item->getTier() == depotSearchOnItem.second) { - itemsVector.push_back(item); + itemsVector.emplace_back(item); } } } ReturnValue ret = RETURNVALUE_NOERROR; - for (const std::shared_ptr<Item> &item : itemsVector) { + for (const auto &item : itemsVector) { + if (!item) { + continue; + } + // First lets try to retrieve the item to the stash retrieve container. if (g_game().tryRetrieveStashItems(static_self_cast<Player>(), item)) { continue; @@ -6975,13 +7002,13 @@ void Player::openContainerFromDepotSearch(const Position &pos) { return; } - std::shared_ptr<Item> item = getItemFromDepotSearch(depotSearchOnItem.first, pos); + const auto &item = getItemFromDepotSearch(depotSearchOnItem.first, pos); if (!item) { sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - std::shared_ptr<Container> container = item->getParent() ? item->getParent()->getContainer() : nullptr; + const auto &container = item->getParent() ? item->getParent()->getContainer() : nullptr; if (!container) { sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -6991,21 +7018,21 @@ void Player::openContainerFromDepotSearch(const Position &pos) { } std::shared_ptr<Item> Player::getItemFromDepotSearch(uint16_t itemId, const Position &pos) { - std::shared_ptr<DepotLocker> depotLocker = getDepotLocker(getLastDepotId()); + const auto &depotLocker = getDepotLocker(getLastDepotId()); if (!depotLocker) { return nullptr; } uint8_t index = 0; - for (const std::shared_ptr<Item> &locker : depotLocker->getItemList()) { - std::shared_ptr<Container> c = locker->getContainer(); + for (const auto &locker : depotLocker->getItemList()) { + const auto &c = locker->getContainer(); if (!c || c->empty() || (c->isInbox() && pos.y != 0x21) || // From inbox. (!c->isInbox() && pos.y != 0x20)) { // From depot. continue; } for (ContainerIterator it = c->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; + const auto &item = *it; if (!item || item->getID() != itemId || item->getTier() != depotSearchOnItem.second) { continue; } @@ -7021,7 +7048,7 @@ std::shared_ptr<Item> Player::getItemFromDepotSearch(uint16_t itemId, const Posi } std::pair<std::vector<std::shared_ptr<Item>>, std::map<uint16_t, std::map<uint8_t, uint32_t>>> -Player::requestLockerItems(std::shared_ptr<DepotLocker> depotLocker, bool sendToClient /*= false*/, uint8_t tier /*= 0*/) const { +Player::requestLockerItems(const std::shared_ptr<DepotLocker> &depotLocker, bool sendToClient /*= false*/, uint8_t tier /*= 0*/) const { if (!depotLocker) { g_logger().error("{} - Depot locker is nullptr", __FUNCTION__); return {}; @@ -7032,12 +7059,12 @@ Player::requestLockerItems(std::shared_ptr<DepotLocker> depotLocker, bool sendTo std::vector<std::shared_ptr<Container>> containers { depotLocker }; for (size_t i = 0; i < containers.size(); ++i) { - std::shared_ptr<Container> container = containers[i]; + const auto &container = containers[i]; for (const auto &item : container->getItemList()) { - std::shared_ptr<Container> lockerContainers = item->getContainer(); + const auto &lockerContainers = item->getContainer(); if (lockerContainers && !lockerContainers->empty()) { - containers.push_back(lockerContainers); + containers.emplace_back(lockerContainers); continue; } @@ -7055,7 +7082,7 @@ Player::requestLockerItems(std::shared_ptr<DepotLocker> depotLocker, bool sendTo } lockerItems[itemType.wareId][item->getTier()] += Item::countByType(item, -1); - itemVector.push_back(item); + itemVector.emplace_back(item); } } @@ -7070,9 +7097,9 @@ Player::requestLockerItems(std::shared_ptr<DepotLocker> depotLocker, bool sendTo return { itemVector, lockerItems }; } -std::pair<std::vector<std::shared_ptr<Item>>, uint16_t> Player::getLockerItemsAndCountById(const std::shared_ptr<DepotLocker> &depotLocker, uint8_t tier, uint16_t itemId) { +std::pair<std::vector<std::shared_ptr<Item>>, uint16_t> Player::getLockerItemsAndCountById(const std::shared_ptr<DepotLocker> &depotLocker, uint8_t tier, uint16_t itemId) const { std::vector<std::shared_ptr<Item>> lockerItems; - auto [itemVector, itemMap] = requestLockerItems(depotLocker, false, tier); + const auto &[itemVector, itemMap] = requestLockerItems(depotLocker, false, tier); uint16_t totalCount = 0; for (const auto &item : itemVector) { if (!item || item->getID() != itemId) { @@ -7080,7 +7107,7 @@ std::pair<std::vector<std::shared_ptr<Item>>, uint16_t> Player::getLockerItemsAn } totalCount++; - lockerItems.push_back(item); + lockerItems.emplace_back(item); } return std::make_pair(lockerItems, totalCount); @@ -7090,7 +7117,7 @@ bool Player::saySpell( SpeakClasses type, const std::string &text, bool ghostMode, - Spectators* spectatorsPtr /* = nullptr*/, + const Spectators* spectatorsPtr /* = nullptr*/, const Position* pos /* = nullptr*/ ) { if (text.empty()) { @@ -7120,8 +7147,8 @@ bool Player::saySpell( int32_t valueEmote = 0; // Send to client - for (const std::shared_ptr<Creature> &spectator : spectators) { - if (std::shared_ptr<Player> tmpPlayer = spectator->getPlayer()) { + for (const auto &spectator : spectators) { + if (const auto &tmpPlayer = spectator->getPlayer()) { if (g_configManager().getBoolean(EMOTE_SPELLS)) { valueEmote = tmpPlayer->getStorageValue(STORAGEVALUE_EMOTE); } @@ -7136,8 +7163,8 @@ bool Player::saySpell( } // Execute lua event method - for (const std::shared_ptr<Creature> &spectator : spectators) { - auto tmpPlayer = spectator->getPlayer(); + for (const auto &spectator : spectators) { + const auto &tmpPlayer = spectator->getPlayer(); if (!tmpPlayer) { continue; } @@ -7164,7 +7191,7 @@ void Player::forgeFuseItems(ForgeAction_t actionType, uint16_t firstItemId, uint history.success = success; history.tierLoss = reduceTierLoss; - auto firstForgingItem = getForgeItemFromId(firstItemId, tier); + const auto &firstForgingItem = getForgeItemFromId(firstItemId, tier); if (!firstForgingItem) { g_logger().error("[Log 1] Player with name {} failed to fuse item with id {}", getName(), firstItemId); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7177,7 +7204,7 @@ void Player::forgeFuseItems(ForgeAction_t actionType, uint16_t firstItemId, uint sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); return; } - auto secondForgingItem = getForgeItemFromId(secondItemId, tier); + const auto &secondForgingItem = getForgeItemFromId(secondItemId, tier); if (!secondForgingItem) { g_logger().error("[Log 2] Player with name {} failed to fuse item with id {}", getName(), secondItemId); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7191,20 +7218,20 @@ void Player::forgeFuseItems(ForgeAction_t actionType, uint16_t firstItemId, uint return; } - auto exaltationChest = Item::CreateItem(ITEM_EXALTATION_CHEST, 1); + const auto &exaltationChest = Item::CreateItem(ITEM_EXALTATION_CHEST, 1); if (!exaltationChest) { g_logger().error("Failed to create exaltation chest"); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); return; } - auto exaltationContainer = exaltationChest->getContainer(); + const auto &exaltationContainer = exaltationChest->getContainer(); if (!exaltationContainer) { g_logger().error("Failed to create exaltation container"); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); return; } - std::shared_ptr<Item> firstForgedItem = Item::CreateItem(firstItemId, 1); + const auto &firstForgedItem = Item::CreateItem(firstItemId, 1); if (!firstForgedItem) { g_logger().error("[Log 3] Player with name {} failed to fuse item with id {}", getName(), firstItemId); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7248,7 +7275,7 @@ void Player::forgeFuseItems(ForgeAction_t actionType, uint16_t firstItemId, uint history.cost = cost; } else { firstForgedItem->setTier(tier); - std::shared_ptr<Item> secondForgedItem = Item::CreateItem(secondItemId, 1); + const auto &secondForgedItem = Item::CreateItem(secondItemId, 1); if (!secondForgedItem) { g_logger().error("[Log 4] Player with name {} failed to fuse item with id {}", getName(), secondItemId); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7406,7 +7433,7 @@ void Player::forgeTransferItemTier(ForgeAction_t actionType, uint16_t donorItemI history.tier = tier; history.success = true; - auto donorItem = getForgeItemFromId(donorItemId, tier); + const auto &donorItem = getForgeItemFromId(donorItemId, tier); if (!donorItem) { g_logger().error("[Log 1] Player with name {} failed to transfer item with id {}", getName(), donorItemId); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7420,7 +7447,7 @@ void Player::forgeTransferItemTier(ForgeAction_t actionType, uint16_t donorItemI return; } - auto receiveItem = getForgeItemFromId(receiveItemId, 0); + const auto &receiveItem = getForgeItemFromId(receiveItemId, 0); if (!receiveItem) { g_logger().error("[Log 2] Player with name {} failed to transfer item with id {}", getName(), receiveItemId); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7434,20 +7461,20 @@ void Player::forgeTransferItemTier(ForgeAction_t actionType, uint16_t donorItemI return; } - auto exaltationChest = Item::CreateItem(ITEM_EXALTATION_CHEST, 1); + const auto &exaltationChest = Item::CreateItem(ITEM_EXALTATION_CHEST, 1); if (!exaltationChest) { g_logger().error("Exaltation chest is nullptr"); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); return; } - auto exaltationContainer = exaltationChest->getContainer(); + const auto &exaltationContainer = exaltationChest->getContainer(); if (!exaltationContainer) { g_logger().error("Exaltation container is nullptr"); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); return; } - std::shared_ptr<Item> newReceiveItem = Item::CreateItem(receiveItemId, 1); + const auto &newReceiveItem = Item::CreateItem(receiveItemId, 1); if (!newReceiveItem) { g_logger().error("[Log 6] Player with name {} failed to fuse item with id {}", getName(), receiveItemId); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7463,6 +7490,8 @@ void Player::forgeTransferItemTier(ForgeAction_t actionType, uint16_t donorItemI setForgeDusts(getForgeDusts() - g_configManager().getNumber(configKey)); } + setForgeDusts(getForgeDusts() - g_configManager().getNumber(configKey)); + if (convergence) { newReceiveItem->setTier(tier); } else { @@ -7542,7 +7571,7 @@ void Player::forgeResourceConversion(ForgeAction_t actionType) { } auto itemCount = static_cast<uint16_t>(g_configManager().getNumber(FORGE_SLIVER_AMOUNT)); - std::shared_ptr<Item> item = Item::CreateItem(ITEM_FORGE_SLIVER, itemCount); + const auto &item = Item::CreateItem(ITEM_FORGE_SLIVER, itemCount); returnValue = g_game().internalPlayerAddItem(static_self_cast<Player>(), item); if (returnValue != RETURNVALUE_NOERROR) { g_logger().error("Failed to add {} slivers to player with name {}", itemCount, getName()); @@ -7554,7 +7583,7 @@ void Player::forgeResourceConversion(ForgeAction_t actionType) { history.gained = 3; setForgeDusts(dusts - cost); } else if (actionType == ForgeAction_t::SLIVERSTOCORES) { - auto [sliverCount, coreCount] = getForgeSliversAndCores(); + const auto &[sliverCount, coreCount] = getForgeSliversAndCores(); auto cost = static_cast<uint16_t>(g_configManager().getNumber(FORGE_CORE_COST)); if (cost > sliverCount) { g_logger().error("[{}] Not enough sliver", __FUNCTION__); @@ -7568,7 +7597,7 @@ void Player::forgeResourceConversion(ForgeAction_t actionType) { return; } - if (std::shared_ptr<Item> item = Item::CreateItem(ITEM_FORGE_CORE, 1); + if (const auto &item = Item::CreateItem(ITEM_FORGE_CORE, 1); item) { returnValue = g_game().internalPlayerAddItem(static_self_cast<Player>(), item); } @@ -7589,8 +7618,8 @@ void Player::forgeResourceConversion(ForgeAction_t actionType) { return; } - auto upgradeCost = dustLevel - 75; - if (auto dusts = getForgeDusts(); + const auto upgradeCost = dustLevel - 75; + if (const auto dusts = getForgeDusts(); upgradeCost > dusts) { g_logger().error("[{}] Not enough dust", __FUNCTION__); sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR); @@ -7771,25 +7800,25 @@ void Player::closeAllExternalContainers() { } std::vector<std::shared_ptr<Container>> containerToClose; - for (const auto &it : openContainers) { - std::shared_ptr<Container> container = it.second.container; + for (const auto &[containerId, containerInfo] : openContainers) { + const auto &container = containerInfo.container; if (!container) { continue; } if (container->getHoldingPlayer() != getPlayer()) { - containerToClose.push_back(container); + containerToClose.emplace_back(container); } } - for (const std::shared_ptr<Container> &container : containerToClose) { + for (const auto &container : containerToClose) { autoCloseContainers(container); } } SoundEffect_t Player::getHitSoundEffect() const { // Distance sound effects - std::shared_ptr<Item> tool = getWeapon(); + const auto &tool = getWeapon(); if (tool == nullptr) { return SoundEffect_t::SILENCE; } @@ -7798,10 +7827,12 @@ SoundEffect_t Player::getHitSoundEffect() const { case WEAPON_AMMO: { if (it.ammoType == AMMO_BOLT) { return SoundEffect_t::DIST_ATK_CROSSBOW_SHOT; - } else if (it.ammoType == AMMO_ARROW) { + } + if (it.ammoType == AMMO_ARROW) { if (it.shootType == CONST_ANI_BURSTARROW) { return SoundEffect_t::BURST_ARROW_EFFECT; - } else if (it.shootType == CONST_ANI_DIAMONDARROW) { + } + if (it.shootType == CONST_ANI_DIAMONDARROW) { return SoundEffect_t::DIAMOND_ARROW_EFFECT; } } else { @@ -7811,11 +7842,11 @@ SoundEffect_t Player::getHitSoundEffect() const { case WEAPON_DISTANCE: { if (tool->getAmmoType() == AMMO_BOLT) { return SoundEffect_t::DIST_ATK_CROSSBOW_SHOT; - } else if (tool->getAmmoType() == AMMO_ARROW) { + } + if (tool->getAmmoType() == AMMO_ARROW) { return SoundEffect_t::DIST_ATK_BOW_SHOT; - } else { - return SoundEffect_t::DIST_ATK_THROW_SHOT; } + return SoundEffect_t::DIST_ATK_THROW_SHOT; } case WEAPON_WAND: { // Separate between wand and rod here @@ -7831,7 +7862,7 @@ SoundEffect_t Player::getHitSoundEffect() const { } SoundEffect_t Player::getAttackSoundEffect() const { - std::shared_ptr<Item> tool = getWeapon(); + const auto &tool = getWeapon(); if (tool == nullptr) { return SoundEffect_t::HUMAN_CLOSE_ATK_FIST; } @@ -7855,11 +7886,11 @@ SoundEffect_t Player::getAttackSoundEffect() const { case WEAPON_DISTANCE: { if (tool->getAmmoType() == AMMO_BOLT) { return SoundEffect_t::DIST_ATK_CROSSBOW; - } else if (tool->getAmmoType() == AMMO_ARROW) { + } + if (tool->getAmmoType() == AMMO_ARROW) { return SoundEffect_t::DIST_ATK_BOW; - } else { - return SoundEffect_t::DIST_ATK_THROW; } + return SoundEffect_t::DIST_ATK_THROW; break; } @@ -7902,7 +7933,7 @@ bool Player::setAccount(uint32_t accountId) { } uint8_t Player::getAccountType() const { - return static_cast<uint8_t>(account ? account->getAccountType() : static_cast<uint8_t>(AccountType::ACCOUNT_TYPE_NORMAL)); + return account ? account->getAccountType() : static_cast<uint8_t>(AccountType::ACCOUNT_TYPE_NORMAL); } uint32_t Player::getAccountId() const { @@ -7930,7 +7961,7 @@ void Player::setHazardSystemPoints(int32_t count) { } } -void Player::parseAttackRecvHazardSystem(CombatDamage &damage, std::shared_ptr<Monster> monster) { +void Player::parseAttackRecvHazardSystem(CombatDamage &damage, const std::shared_ptr<Monster> &monster) { if (!monster || !monster->getHazard()) { return; } @@ -7989,7 +8020,7 @@ void Player::parseAttackRecvHazardSystem(CombatDamage &damage, std::shared_ptr<M } } -void Player::parseAttackDealtHazardSystem(CombatDamage &damage, std::shared_ptr<Monster> monster) { +void Player::parseAttackDealtHazardSystem(CombatDamage &damage, const std::shared_ptr<Monster> &monster) const { if (!g_configManager().getBoolean(TOGGLE_HAZARDSYSTEM)) { return; } @@ -8038,7 +8069,6 @@ void Player::parseAttackDealtHazardSystem(CombatDamage &damage, std::shared_ptr< if (damage.secondary.value != 0) { damage.secondary.value -= static_cast<int32_t>(std::ceil((static_cast<double>(damage.secondary.value) * stage) / 10000)); } - return; } } } @@ -8102,13 +8132,13 @@ const std::unique_ptr<PlayerCyclopedia> &Player::cyclopedia() const { } void Player::sendLootMessage(const std::string &message) const { - auto party = getParty(); + const auto &party = getParty(); if (!party) { sendTextMessage(MESSAGE_LOOT, message); return; } - if (auto partyLeader = party->getLeader()) { + if (const auto &partyLeader = party->getLeader()) { partyLeader->sendTextMessage(MESSAGE_LOOT, message); } for (const auto &partyMember : party->getMembers()) { @@ -8120,20 +8150,20 @@ void Player::sendLootMessage(const std::string &message) const { std::shared_ptr<Container> Player::getLootPouch() { // Allow players with CM access or higher have the loot pouch anywhere - auto parentItem = getParent() ? getParent()->getItem() : nullptr; + const auto &parentItem = getParent() ? getParent()->getItem() : nullptr; if (isPlayerGroup() && parentItem && parentItem->getID() != ITEM_STORE_INBOX) { return nullptr; } - auto inventoryItems = getInventoryItemsFromId(ITEM_GOLD_POUCH); + const auto &inventoryItems = getInventoryItemsFromId(ITEM_GOLD_POUCH); if (inventoryItems.empty()) { return nullptr; } - auto containerItem = inventoryItems.front(); + const auto &containerItem = inventoryItems.front(); if (!containerItem) { return nullptr; } - auto container = containerItem->getContainer(); + const auto &container = containerItem->getContainer(); if (!container) { return nullptr; } @@ -8142,12 +8172,12 @@ std::shared_ptr<Container> Player::getLootPouch() { } std::shared_ptr<Container> Player::getStoreInbox() const { - auto thing = getThing(CONST_SLOT_STORE_INBOX); + const auto &thing = getThing(CONST_SLOT_STORE_INBOX); if (!thing) { return nullptr; } - auto storeInbox = thing->getContainer(); + const auto &storeInbox = thing->getContainer(); return storeInbox ? storeInbox : nullptr; } @@ -8162,7 +8192,11 @@ bool Player::hasPermittedConditionInPZ() const { }; bool hasPermittedCondition = false; - for (auto condition : allowedConditions) { + for (const auto &condition : allowedConditions) { + if (!condition) { + continue; + } + if (getCondition(condition)) { hasPermittedCondition = true; break; @@ -8174,7 +8208,7 @@ bool Player::hasPermittedConditionInPZ() const { uint16_t Player::getDodgeChance() const { uint16_t chance = 0; - if (auto playerArmor = getInventoryItem(CONST_SLOT_ARMOR); + if (const auto &playerArmor = getInventoryItem(CONST_SLOT_ARMOR); playerArmor != nullptr && playerArmor->getTier()) { chance += static_cast<uint16_t>(playerArmor->getDodgeChance() * 100); } @@ -8222,7 +8256,7 @@ bool Player::canSpeakWithHireling(uint8_t speechbubble) { } uint16_t Player::getPlayerVocationEnum() const { - int cipTibiaId = getVocation()->getClientId(); + const int cipTibiaId = getVocation()->getClientId(); if (cipTibiaId == 1 || cipTibiaId == 11) { return Vocation_t::VOCATION_KNIGHT_CIP; // Knight } else if (cipTibiaId == 2 || cipTibiaId == 12) { diff --git a/src/creatures/players/player.hpp b/src/creatures/players/player.hpp index cd69cec99a0..8be3d7c7a99 100644 --- a/src/creatures/players/player.hpp +++ b/src/creatures/players/player.hpp @@ -29,7 +29,6 @@ #include "server/network/protocol/protocolgame.hpp" #include "items/containers/rewards/reward.hpp" #include "items/containers/rewards/rewardchest.hpp" -#include "map/town.hpp" #include "vocations/vocation.hpp" #include "creatures/npcs/npc.hpp" #include "game/bank/bank.hpp" @@ -47,7 +46,6 @@ class Weapon; class ProtocolGame; class Party; class Task; -class Bed; class Guild; class Imbuement; class PreySlot; @@ -61,12 +59,12 @@ class PlayerTitle; class PlayerVIP; class Spectators; class Account; +class Town; struct ModalWindow; struct Achievement; struct Badge; struct Title; -struct VIPGroup; struct ForgeHistory { ForgeAction_t actionType = ForgeAction_t::FUSION; @@ -124,7 +122,7 @@ class Player final : public Creature, public Cylinder, public Bankable { }; explicit Player(ProtocolGame_ptr p); - ~Player(); + ~Player() override; // non-copyable Player(const Player &) = delete; @@ -137,7 +135,7 @@ class Player final : public Creature, public Cylinder, public Bankable { return static_self_cast<Player>(); } - static std::shared_ptr<Task> createPlayerTask(uint32_t delay, std::function<void(void)> f, std::string context); + static std::shared_ptr<Task> createPlayerTask(uint32_t delay, std::function<void(void)> f, const std::string &context); void setID() override; @@ -180,7 +178,7 @@ class Player final : public Creature, public Cylinder, public Bankable { bool toggleMount(bool mount); bool tameMount(uint8_t mountId); bool untameMount(uint8_t mountId); - bool hasMount(const std::shared_ptr<Mount> mount) const; + bool hasMount(const std::shared_ptr<Mount> &mount) const; bool hasAnyMount() const; uint8_t getRandomMountId() const; void dismount(); @@ -193,25 +191,25 @@ class Player final : public Creature, public Cylinder, public Bankable { randomMount = isMountRandomized; } - void sendFYIBox(const std::string &message) { + void sendFYIBox(const std::string &message) const { if (client) { client->sendFYIBox(message); } } - void BestiarysendCharms() { + void BestiarysendCharms() const { if (client) { client->BestiarysendCharms(); } } void addBestiaryKillCount(uint16_t raceid, uint32_t amount) { - uint32_t oldCount = getBestiaryKillCount(raceid); - uint32_t key = STORAGEVALUE_BESTIARYKILLCOUNT + raceid; + const uint32_t oldCount = getBestiaryKillCount(raceid); + const uint32_t key = STORAGEVALUE_BESTIARYKILLCOUNT + raceid; addStorageValue(key, static_cast<int32_t>(oldCount + amount), true); } uint32_t getBestiaryKillCount(uint16_t raceid) const { - uint32_t key = STORAGEVALUE_BESTIARYKILLCOUNT + raceid; - auto value = getStorageValue(key); + const uint32_t key = STORAGEVALUE_BESTIARYKILLCOUNT + raceid; + const auto value = getStorageValue(key); return value > 0 ? static_cast<uint32_t>(value) : 0; } @@ -241,7 +239,7 @@ class Player final : public Creature, public Cylinder, public Bankable { return staminaMinutes; } - void sendItemsPrice() { + void sendItemsPrice() const { if (client) { client->sendItemsPrice(); } @@ -282,25 +280,25 @@ class Player final : public Creature, public Cylinder, public Bankable { [[nodiscard]] std::shared_ptr<Guild> getGuild() const { return guild; } - void setGuild(const std::shared_ptr<Guild> guild); + void setGuild(const std::shared_ptr<Guild> &guild); [[nodiscard]] GuildRank_ptr getGuildRank() const { return guildRank; } void setGuildRank(GuildRank_ptr newGuildRank) { - guildRank = newGuildRank; + guildRank = std::move(newGuildRank); } - bool isGuildMate(std::shared_ptr<Player> player) const; + bool isGuildMate(const std::shared_ptr<Player> &player) const; [[nodiscard]] const std::string &getGuildNick() const { return guildNick; } void setGuildNick(std::string nick) { - guildNick = nick; + guildNick = std::move(nick); } - bool isInWar(std::shared_ptr<Player> player) const; + bool isInWar(const std::shared_ptr<Player> &player) const; bool isInWarList(uint32_t guild_id) const; void setLastWalkthroughAttempt(int64_t walkthroughAttempt) { @@ -324,17 +322,17 @@ class Player final : public Creature, public Cylinder, public Bankable { return isBoss ? m_bosstiaryMonsterTracker : m_bestiaryMonsterTracker; } - void addMonsterToCyclopediaTrackerList(const std::shared_ptr<MonsterType> mtype, bool isBoss, bool reloadClient = false); + void addMonsterToCyclopediaTrackerList(const std::shared_ptr<MonsterType> &mtype, bool isBoss, bool reloadClient = false); - void removeMonsterFromCyclopediaTrackerList(std::shared_ptr<MonsterType> mtype, bool isBoss, bool reloadClient = false); + void removeMonsterFromCyclopediaTrackerList(const std::shared_ptr<MonsterType> &mtype, bool isBoss, bool reloadClient = false); - void sendBestiaryEntryChanged(uint16_t raceid) { + void sendBestiaryEntryChanged(uint16_t raceid) const { if (client) { client->sendBestiaryEntryChanged(raceid); } } - void refreshCyclopediaMonsterTracker(bool isBoss = false) { + void refreshCyclopediaMonsterTracker(bool isBoss = false) const { refreshCyclopediaMonsterTracker(getCyclopediaMonsterTrackerSet(isBoss), isBoss); } @@ -357,7 +355,7 @@ class Player final : public Creature, public Cylinder, public Bankable { operatingSystem = clientos; } - bool isOldProtocol() { + bool isOldProtocol() const { return client && client->oldProtocol; } @@ -374,7 +372,7 @@ class Player final : public Creature, public Cylinder, public Bankable { } void setParty(std::shared_ptr<Party> newParty) { - m_party = newParty; + m_party = std::move(newParty); } std::shared_ptr<Party> getParty() const { return m_party; @@ -390,7 +388,7 @@ class Player final : public Creature, public Cylinder, public Bankable { void setPerfectShotDamage(uint8_t range, int32_t damage) { int32_t actualDamage = getPerfectShotDamage(range); - bool aboveZero = (actualDamage != 0); + const bool aboveZero = (actualDamage != 0); actualDamage += damage; if (actualDamage == 0 && aboveZero) { perfectShot.erase(range); @@ -421,17 +419,17 @@ class Player final : public Creature, public Cylinder, public Bankable { int32_t getReflectFlat(CombatType_t combat, bool useCharges = false) const override; - PartyShields_t getPartyShield(std::shared_ptr<Player> player); - bool isInviting(std::shared_ptr<Player> player) const; - bool isPartner(std::shared_ptr<Player> player) const; - void sendPlayerPartyIcons(std::shared_ptr<Player> player); - bool addPartyInvitation(std::shared_ptr<Party> party); - void removePartyInvitation(std::shared_ptr<Party> party); + PartyShields_t getPartyShield(const std::shared_ptr<Player> &player); + bool isInviting(const std::shared_ptr<Player> &player) const; + bool isPartner(const std::shared_ptr<Player> &player) const; + void sendPlayerPartyIcons(const std::shared_ptr<Player> &player) const; + bool addPartyInvitation(const std::shared_ptr<Party> &party); + void removePartyInvitation(const std::shared_ptr<Party> &party); void clearPartyInvitations(); - void sendUnjustifiedPoints(); + void sendUnjustifiedPoints() const; - GuildEmblems_t getGuildEmblem(std::shared_ptr<Player> player) const; + GuildEmblems_t getGuildEmblem(const std::shared_ptr<Player> &player) const; uint64_t getSpentMana() const { return manaSpent; @@ -453,13 +451,13 @@ class Player final : public Creature, public Cylinder, public Bankable { return bedItem; } void setBedItem(std::shared_ptr<BedItem> b) { - bedItem = b; + bedItem = std::move(b); } - bool hasImbuingItem() { + bool hasImbuingItem() const { return imbuingItem != nullptr; } - void setImbuingItem(std::shared_ptr<Item> item); + void setImbuingItem(const std::shared_ptr<Item> &item); void addBlessing(uint8_t index, uint8_t count) { if (blessings[index - 1] == 255) { @@ -488,7 +486,7 @@ class Player final : public Creature, public Cylinder, public Bankable { return 0; } } - auto amount = kv()->scoped("summary")->scoped("blessings")->scoped(fmt::format("{}", index))->get("amount"); + const auto amount = kv()->scoped("summary")->scoped("blessings")->scoped(fmt::format("{}", index))->get("amount"); return amount ? static_cast<uint8_t>(amount->getNumber()) : 0; } std::string getBlessingsName() const; @@ -496,7 +494,7 @@ class Player final : public Creature, public Cylinder, public Bankable { bool isOffline() const { return (getID() == 0); } - void disconnect() { + void disconnect() const { if (client) { client->disconnect(); } @@ -510,21 +508,21 @@ class Player final : public Creature, public Cylinder, public Bankable { return getIP() == 0; } - void addContainer(uint8_t cid, std::shared_ptr<Container> container); + void addContainer(uint8_t cid, const std::shared_ptr<Container> &container); void closeContainer(uint8_t cid); void setContainerIndex(uint8_t cid, uint16_t index); std::shared_ptr<Container> getContainerByID(uint8_t cid); - int8_t getContainerID(std::shared_ptr<Container> container) const; + int8_t getContainerID(const std::shared_ptr<Container> &container) const; uint16_t getContainerIndex(uint8_t cid) const; bool canOpenCorpse(uint32_t ownerId) const; - void addStorageValue(const uint32_t key, const int32_t value, const bool isLogin = false); - int32_t getStorageValue(const uint32_t key) const; + void addStorageValue(uint32_t key, int32_t value, bool isLogin = false); + int32_t getStorageValue(uint32_t key) const; int32_t getStorageValueByName(const std::string &storageName) const; - void addStorageValueByName(const std::string &storageName, const int32_t value, const bool isLogin = false); + void addStorageValueByName(const std::string &storageName, int32_t value, bool isLogin = false); std::shared_ptr<KV> kv() const { return g_kv().scoped("player")->scoped(fmt::format("{}", getGUID())); @@ -533,7 +531,7 @@ class Player final : public Creature, public Cylinder, public Bankable { void genReservedStorageRange(); void setGroup(std::shared_ptr<Group> newGroup) { - group = newGroup; + group = std::move(newGroup); } std::shared_ptr<Group> getGroup() const { return group; @@ -574,13 +572,13 @@ class Player final : public Creature, public Cylinder, public Bankable { bool isDepotSearchAvailable() const { return depotSearch; } - bool isSupplyStashMenuAvailable() { + bool isSupplyStashMenuAvailable() const { return supplyStash; } - bool isMarketMenuAvailable() { + bool isMarketMenuAvailable() const { return marketMenu; } - bool isExerciseTraining() { + bool isExerciseTraining() const { return exerciseTraining; } void setExerciseTraining(bool isTraining) { @@ -689,12 +687,8 @@ class Player final : public Creature, public Cylinder, public Bankable { return town->getTemplePosition(); } - std::shared_ptr<Town> getTown() const { - return town; - } - void setTown(const std::shared_ptr<Town> &newTown) { - this->town = newTown; - } + std::shared_ptr<Town> getTown() const; + void setTown(const std::shared_ptr<Town> &newTown); void clearModalWindows(); bool hasModalWindowOpen(uint32_t modalWindowId) const; @@ -705,7 +699,7 @@ class Player final : public Creature, public Cylinder, public Bankable { void addMessageBuffer(); void removeMessageBuffer(); - bool removeItemOfType(uint16_t itemId, uint32_t itemAmount, int32_t subType, bool ignoreEquipped = false); + bool removeItemOfType(uint16_t itemId, uint32_t itemAmount, int32_t subType, bool ignoreEquipped = false) const; /** * @param itemAmount is uint32_t because stash item is uint32_t max */ @@ -716,7 +710,7 @@ class Player final : public Creature, public Cylinder, public Bankable { bool removeItemCountById(uint16_t itemId, uint32_t itemAmount, bool removeFromStash = true); void addItemOnStash(uint16_t itemId, uint32_t amount) { - auto it = stashItems.find(itemId); + const auto it = stashItems.find(itemId); if (it != stashItems.end()) { stashItems[itemId] += amount; return; @@ -725,14 +719,14 @@ class Player final : public Creature, public Cylinder, public Bankable { stashItems[itemId] = amount; } uint32_t getStashItemCount(uint16_t itemId) const { - auto it = stashItems.find(itemId); + const auto it = stashItems.find(itemId); if (it != stashItems.end()) { return it->second; } return 0; } bool withdrawItem(uint16_t itemId, uint32_t amount) { - auto it = stashItems.find(itemId); + const auto it = stashItems.find(itemId); if (it != stashItems.end()) { if (it->second > amount) { stashItems[itemId] -= amount; @@ -752,7 +746,8 @@ class Player final : public Creature, public Cylinder, public Bankable { uint32_t getBaseCapacity() const { if (hasFlag(PlayerFlags_t::CannotPickupItem)) { return 0; - } else if (hasFlag(PlayerFlags_t::HasInfiniteCapacity)) { + } + if (hasFlag(PlayerFlags_t::HasInfiniteCapacity)) { return std::numeric_limits<uint32_t>::max(); } return capacity; @@ -799,27 +794,27 @@ class Player final : public Creature, public Cylinder, public Bankable { void addConditionSuppressions(const std::array<ConditionType_t, ConditionType_t::CONDITION_COUNT> &addCondition); void removeConditionSuppressions(); - std::shared_ptr<Reward> getReward(const uint64_t rewardId, const bool autoCreate); + std::shared_ptr<Reward> getReward(uint64_t rewardId, bool autoCreate); void removeReward(uint64_t rewardId); void getRewardList(std::vector<uint64_t> &rewards) const; std::shared_ptr<RewardChest> getRewardChest(); - std::vector<std::shared_ptr<Item>> getRewardsFromContainer(std::shared_ptr<Container> container) const; + std::vector<std::shared_ptr<Item>> getRewardsFromContainer(const std::shared_ptr<Container> &container) const; std::shared_ptr<DepotChest> getDepotChest(uint32_t depotId, bool autoCreate); std::shared_ptr<DepotLocker> getDepotLocker(uint32_t depotId); void onReceiveMail(); bool isNearDepotBox(); - std::shared_ptr<Container> refreshManagedContainer(ObjectCategory_t category, std::shared_ptr<Container> container, bool isLootContainer, bool loading = false); + std::shared_ptr<Container> refreshManagedContainer(ObjectCategory_t category, const std::shared_ptr<Container> &container, bool isLootContainer, bool loading = false); std::shared_ptr<Container> getManagedContainer(ObjectCategory_t category, bool isLootContainer) const; - void setMainBackpackUnassigned(std::shared_ptr<Container> container); + void setMainBackpackUnassigned(const std::shared_ptr<Container> &container); bool canSee(const Position &pos) override; - bool canSeeCreature(std::shared_ptr<Creature> creature) const override; + bool canSeeCreature(const std::shared_ptr<Creature> &creature) const override; - bool canWalkthrough(std::shared_ptr<Creature> creature); - bool canWalkthroughEx(std::shared_ptr<Creature> creature); + bool canWalkthrough(const std::shared_ptr<Creature> &creature); + bool canWalkthroughEx(const std::shared_ptr<Creature> &creature) const; RaceType_t getRace() const override { return RACE_BLOOD; @@ -841,7 +836,7 @@ class Player final : public Creature, public Cylinder, public Bankable { // shop functions void setShopOwner(std::shared_ptr<Npc> owner) { - shopOwner = owner; + shopOwner = std::move(owner); } std::shared_ptr<Npc> getShopOwner() const { @@ -849,7 +844,7 @@ class Player final : public Creature, public Cylinder, public Bankable { } // follow functions - bool setFollowCreature(std::shared_ptr<Creature> creature) override; + bool setFollowCreature(const std::shared_ptr<Creature> &creature) override; void goToFollowCreature() override; // follow events @@ -861,9 +856,9 @@ class Player final : public Creature, public Cylinder, public Bankable { void onWalkComplete() override; void stopWalk(); - bool openShopWindow(std::shared_ptr<Npc> npc, const std::vector<ShopBlock> &shopItems = {}); + bool openShopWindow(const std::shared_ptr<Npc> &npc, const std::vector<ShopBlock> &shopItems = {}); bool closeShopWindow(); - bool updateSaleShopList(std::shared_ptr<Item> item); + bool updateSaleShopList(const std::shared_ptr<Item> &item); bool hasShopItemForSale(uint16_t itemId, uint8_t subType) const; void setChaseMode(bool mode); @@ -882,16 +877,16 @@ class Player final : public Creature, public Cylinder, public Bankable { faction = factionId; } // combat functions - bool setAttackedCreature(std::shared_ptr<Creature> creature) override; + bool setAttackedCreature(const std::shared_ptr<Creature> &creature) override; bool isImmune(CombatType_t type) const override; bool isImmune(ConditionType_t type) const override; bool hasShield() const; bool isAttackable() const override; - static bool lastHitIsPlayer(std::shared_ptr<Creature> lastHitCreature); + static bool lastHitIsPlayer(const std::shared_ptr<Creature> &lastHitCreature); // stash functions bool addItemFromStash(uint16_t itemId, uint32_t itemCount); - void stowItem(std::shared_ptr<Item> item, uint32_t count, bool allItems); + void stowItem(const std::shared_ptr<Item> &item, uint32_t count, bool allItems); void changeHealth(int32_t healthChange, bool sendHealthChange = true) override; void changeMana(int32_t manaChange) override; @@ -900,7 +895,7 @@ class Player final : public Creature, public Cylinder, public Bankable { bool isPzLocked() const { return pzLocked; } - BlockType_t blockHit(std::shared_ptr<Creature> attacker, CombatType_t combatType, int32_t &damage, bool checkDefense = false, bool checkArmor = false, bool field = false) override; + BlockType_t blockHit(const std::shared_ptr<Creature> &attacker, const CombatType_t &combatType, int32_t &damage, bool checkDefense = false, bool checkArmor = false, bool field = false) override; void doAttacking(uint32_t interval) override; bool hasExtraSwing() override { return lastAttack > 0 && !checkLastAttackWithin(getAttackSpeed()); @@ -938,7 +933,7 @@ class Player final : public Creature, public Cylinder, public Bankable { if (!lastConditionTime.contains(static_cast<uint8_t>(type))) { return false; } - auto last = lastConditionTime.at(static_cast<uint8_t>(type)); + const auto last = lastConditionTime.at(static_cast<uint8_t>(type)); return last > 0 && ((OTSYS_TIME() - last) < interval); } @@ -970,16 +965,14 @@ class Player final : public Creature, public Cylinder, public Bankable { lastAggressiveAction = OTSYS_TIME(); } - std::unordered_set<std::string> getNPCSkips(); - std::shared_ptr<Item> getWeapon(Slots_t slot, bool ignoreAmmo) const; std::shared_ptr<Item> getWeapon(bool ignoreAmmo = false) const; WeaponType_t getWeaponType() const; - int32_t getWeaponSkill(std::shared_ptr<Item> item) const; + int32_t getWeaponSkill(const std::shared_ptr<Item> &item) const; void getShieldAndWeapon(std::shared_ptr<Item> &shield, std::shared_ptr<Item> &weapon) const; - void drainHealth(std::shared_ptr<Creature> attacker, int32_t damage) override; - void drainMana(std::shared_ptr<Creature> attacker, int32_t manaLoss) override; + void drainHealth(const std::shared_ptr<Creature> &attacker, int32_t damage) override; + void drainMana(const std::shared_ptr<Creature> &attacker, int32_t manaLoss) override; void addManaSpent(uint64_t amount); void addSkillAdvance(skills_t skill, uint64_t count); @@ -988,28 +981,27 @@ class Player final : public Creature, public Cylinder, public Bankable { float getAttackFactor() const override; float getDefenseFactor() const override; float getMitigation() const override; - double getMitigationMultiplier() const; void addInFightTicks(bool pzlock = false); - uint64_t getGainedExperience(std::shared_ptr<Creature> attacker) const override; + uint64_t getGainedExperience(const std::shared_ptr<Creature> &attacker) const override; // combat event functions void onAddCondition(ConditionType_t type) override; void onAddCombatCondition(ConditionType_t type) override; void onEndCondition(ConditionType_t type) override; - void onCombatRemoveCondition(std::shared_ptr<Condition> condition) override; - void onAttackedCreature(std::shared_ptr<Creature> target) override; + void onCombatRemoveCondition(const std::shared_ptr<Condition> &condition) override; + void onAttackedCreature(const std::shared_ptr<Creature> &target) override; void onAttacked() override; - void onAttackedCreatureDrainHealth(std::shared_ptr<Creature> target, int32_t points) override; - void onTargetCreatureGainHealth(std::shared_ptr<Creature> target, int32_t points) override; + void onAttackedCreatureDrainHealth(const std::shared_ptr<Creature> &target, int32_t points) override; + void onTargetCreatureGainHealth(const std::shared_ptr<Creature> &target, int32_t points) override; bool onKilledPlayer(const std::shared_ptr<Player> &target, bool lastHit) override; bool onKilledMonster(const std::shared_ptr<Monster> &target) override; - void onGainExperience(uint64_t gainExp, std::shared_ptr<Creature> target) override; - void onGainSharedExperience(uint64_t gainExp, std::shared_ptr<Creature> target); - void onAttackedCreatureBlockHit(BlockType_t blockType) override; + void onGainExperience(uint64_t gainExp, const std::shared_ptr<Creature> &target) override; + void onGainSharedExperience(uint64_t gainExp, const std::shared_ptr<Creature> &target); + void onAttackedCreatureBlockHit(const BlockType_t &blockType) override; void onBlockHit() override; - void onTakeDamage(std::shared_ptr<Creature> attacker, int32_t damage) override; + void onTakeDamage(const std::shared_ptr<Creature> &attacker, int32_t damage) override; void onChangeZone(ZoneType_t zone) override; void onAttackedCreatureChangeZone(ZoneType_t zone) override; void onIdleStatus() override; @@ -1018,7 +1010,7 @@ class Player final : public Creature, public Cylinder, public Bankable { LightInfo getCreatureLight() const override; Skulls_t getSkull() const override; - Skulls_t getSkullClient(std::shared_ptr<Creature> creature) override; + Skulls_t getSkullClient(const std::shared_ptr<Creature> &creature) override; int64_t getSkullTicks() const { return skullTicks; } @@ -1026,17 +1018,17 @@ class Player final : public Creature, public Cylinder, public Bankable { skullTicks = ticks; } - bool hasAttacked(std::shared_ptr<Player> attacked) const; - void addAttacked(std::shared_ptr<Player> attacked); - void removeAttacked(std::shared_ptr<Player> attacked); + bool hasAttacked(const std::shared_ptr<Player> &attacked) const; + void addAttacked(const std::shared_ptr<Player> &attacked); + void removeAttacked(const std::shared_ptr<Player> &attacked); void clearAttacked(); - void addUnjustifiedDead(std::shared_ptr<Player> attacked); - void sendCreatureEmblem(std::shared_ptr<Creature> creature) const { + void addUnjustifiedDead(const std::shared_ptr<Player> &attacked); + void sendCreatureEmblem(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendCreatureEmblem(creature); } } - void sendCreatureSkull(std::shared_ptr<Creature> creature) const { + void sendCreatureSkull(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendCreatureSkull(creature); } @@ -1059,60 +1051,60 @@ class Player final : public Creature, public Cylinder, public Bankable { bool canLogout(); - bool hasKilled(std::shared_ptr<Player> player) const; + bool hasKilled(const std::shared_ptr<Player> &player) const; size_t getMaxDepotItems() const; // tile // send methods - void sendAddTileItem(std::shared_ptr<Tile> itemTile, const Position &pos, std::shared_ptr<Item> item) { + void sendAddTileItem(const std::shared_ptr<Tile> &itemTile, const Position &pos, const std::shared_ptr<Item> &item) { if (client) { - int32_t stackpos = itemTile->getStackposOfItem(static_self_cast<Player>(), item); + const int32_t stackpos = itemTile->getStackposOfItem(static_self_cast<Player>(), item); if (stackpos != -1) { client->sendAddTileItem(pos, stackpos, item); } } } - void sendUpdateTileItem(std::shared_ptr<Tile> updateTile, const Position &pos, std::shared_ptr<Item> item) { + void sendUpdateTileItem(const std::shared_ptr<Tile> &updateTile, const Position &pos, const std::shared_ptr<Item> &item) { if (client) { - int32_t stackpos = updateTile->getStackposOfItem(static_self_cast<Player>(), item); + const int32_t stackpos = updateTile->getStackposOfItem(static_self_cast<Player>(), item); if (stackpos != -1) { client->sendUpdateTileItem(pos, stackpos, item); } } } - void sendRemoveTileThing(const Position &pos, int32_t stackpos) { + void sendRemoveTileThing(const Position &pos, int32_t stackpos) const { if (stackpos != -1 && client) { client->sendRemoveTileThing(pos, stackpos); } } - void sendUpdateTileCreature(const std::shared_ptr<Creature> creature) { + void sendUpdateTileCreature(const std::shared_ptr<Creature> &creature) { if (client) { client->sendUpdateTileCreature(creature->getPosition(), creature->getTile()->getClientIndexOfCreature(static_self_cast<Player>(), creature), creature); } } - void sendUpdateTile(std::shared_ptr<Tile> updateTile, const Position &pos) { + void sendUpdateTile(const std::shared_ptr<Tile> &updateTile, const Position &pos) const { if (client) { client->sendUpdateTile(updateTile, pos); } } - void sendChannelMessage(const std::string &author, const std::string &text, SpeakClasses type, uint16_t channel) { + void sendChannelMessage(const std::string &author, const std::string &text, SpeakClasses type, uint16_t channel) const { if (client) { client->sendChannelMessage(author, text, type, channel); } } - void sendChannelEvent(uint16_t channelId, const std::string &playerName, ChannelEvent_t channelEvent) { + void sendChannelEvent(uint16_t channelId, const std::string &playerName, ChannelEvent_t channelEvent) const { if (client) { client->sendChannelEvent(channelId, playerName, channelEvent); } } - void sendCreatureAppear(std::shared_ptr<Creature> creature, const Position &pos, bool isLogin) { + void sendCreatureAppear(const std::shared_ptr<Creature> &creature, const Position &pos, bool isLogin) { if (!creature) { return; } - auto tile = creature->getTile(); + const auto &tile = creature->getTile(); if (!tile) { return; } @@ -1121,54 +1113,54 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendAddCreature(creature, pos, tile->getStackposOfCreature(static_self_cast<Player>(), creature), isLogin); } } - void sendCreatureMove(std::shared_ptr<Creature> creature, const Position &newPos, int32_t newStackPos, const Position &oldPos, int32_t oldStackPos, bool teleport) { + void sendCreatureMove(const std::shared_ptr<Creature> &creature, const Position &newPos, int32_t newStackPos, const Position &oldPos, int32_t oldStackPos, bool teleport) const { if (client) { client->sendMoveCreature(creature, newPos, newStackPos, oldPos, oldStackPos, teleport); } } - void sendCreatureTurn(std::shared_ptr<Creature> creature) { + void sendCreatureTurn(const std::shared_ptr<Creature> &creature) { if (!creature) { return; } - auto tile = creature->getTile(); + const auto &tile = creature->getTile(); if (!tile) { return; } if (client && canSeeCreature(creature)) { - int32_t stackpos = tile->getStackposOfCreature(static_self_cast<Player>(), creature); + const int32_t stackpos = tile->getStackposOfCreature(static_self_cast<Player>(), creature); if (stackpos != -1) { client->sendCreatureTurn(creature, stackpos); } } } - void sendCreatureSay(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, const Position* pos = nullptr) { + void sendCreatureSay(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, const Position* pos = nullptr) const { if (client) { client->sendCreatureSay(creature, type, text, pos); } } - void sendCreatureReload(std::shared_ptr<Creature> creature) { + void sendCreatureReload(const std::shared_ptr<Creature> &creature) const { if (client) { client->reloadCreature(creature); } } - void sendPrivateMessage(std::shared_ptr<Player> speaker, SpeakClasses type, const std::string &text) { + void sendPrivateMessage(const std::shared_ptr<Player> &speaker, SpeakClasses type, const std::string &text) const { if (client) { client->sendPrivateMessage(speaker, type, text); } } - void sendCreatureSquare(std::shared_ptr<Creature> creature, SquareColor_t color) { + void sendCreatureSquare(const std::shared_ptr<Creature> &creature, SquareColor_t color) const { if (client) { client->sendCreatureSquare(creature, color); } } - void sendCreatureChangeOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit) { + void sendCreatureChangeOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit) const { if (client) { client->sendCreatureOutfit(creature, outfit); } } - void sendCreatureChangeVisible(std::shared_ptr<Creature> creature, bool visible) { + void sendCreatureChangeVisible(const std::shared_ptr<Creature> &creature, bool visible) { if (!client || !creature) { return; } @@ -1183,11 +1175,11 @@ class Player final : public Creature, public Cylinder, public Bankable { } else if (canSeeInvisibility()) { client->sendCreatureOutfit(creature, creature->getCurrentOutfit()); } else { - auto tile = creature->getTile(); + const auto tile = creature->getTile(); if (!tile) { return; } - int32_t stackpos = tile->getStackposOfCreature(static_self_cast<Player>(), creature); + const int32_t stackpos = tile->getStackposOfCreature(static_self_cast<Player>(), creature); if (stackpos == -1) { return; } @@ -1199,42 +1191,42 @@ class Player final : public Creature, public Cylinder, public Bankable { } } } - void sendCreatureLight(std::shared_ptr<Creature> creature) { + void sendCreatureLight(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendCreatureLight(creature); } } - void sendCreatureIcon(std::shared_ptr<Creature> creature) { + void sendCreatureIcon(const std::shared_ptr<Creature> &creature) const { if (client && !client->oldProtocol) { client->sendCreatureIcon(creature); } } - void sendUpdateCreature(std::shared_ptr<Creature> creature) const { + void sendUpdateCreature(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendUpdateCreature(creature); } } - void sendCreatureWalkthrough(std::shared_ptr<Creature> creature, bool walkthrough) { + void sendCreatureWalkthrough(const std::shared_ptr<Creature> &creature, bool walkthrough) const { if (client) { client->sendCreatureWalkthrough(creature, walkthrough); } } - void sendCreatureShield(std::shared_ptr<Creature> creature) { + void sendCreatureShield(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendCreatureShield(creature); } } - void sendCreatureType(std::shared_ptr<Creature> creature, uint8_t creatureType) { + void sendCreatureType(const std::shared_ptr<Creature> &creature, uint8_t creatureType) const { if (client) { client->sendCreatureType(creature, creatureType); } } - void sendSpellCooldown(uint16_t spellId, uint32_t time) { + void sendSpellCooldown(uint16_t spellId, uint32_t time) const { if (client) { client->sendSpellCooldown(spellId, time); } } - void sendSpellGroupCooldown(SpellGroup_t groupId, uint32_t time) { + void sendSpellGroupCooldown(SpellGroup_t groupId, uint32_t time) const { if (client) { client->sendSpellGroupCooldown(groupId, time); } @@ -1244,7 +1236,7 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendUseItemCooldown(time); } } - void reloadCreature(std::shared_ptr<Creature> creature) { + void reloadCreature(const std::shared_ptr<Creature> &creature) const { if (client) { client->reloadCreature(creature); } @@ -1253,10 +1245,10 @@ class Player final : public Creature, public Cylinder, public Bankable { // container void closeAllExternalContainers(); - void sendAddContainerItem(std::shared_ptr<Container> container, std::shared_ptr<Item> item); - void sendUpdateContainerItem(std::shared_ptr<Container> container, uint16_t slot, std::shared_ptr<Item> newItem); - void sendRemoveContainerItem(std::shared_ptr<Container> container, uint16_t slot); - void sendContainer(uint8_t cid, std::shared_ptr<Container> container, bool hasParent, uint16_t firstIndex) { + void sendAddContainerItem(const std::shared_ptr<Container> &container, std::shared_ptr<Item> item); + void sendUpdateContainerItem(const std::shared_ptr<Container> &container, uint16_t slot, const std::shared_ptr<Item> &newItem); + void sendRemoveContainerItem(const std::shared_ptr<Container> &container, uint16_t slot); + void sendContainer(uint8_t cid, const std::shared_ptr<Container> &container, bool hasParent, uint16_t firstIndex) const { if (client) { client->sendContainer(cid, container, hasParent, firstIndex); } @@ -1278,17 +1270,17 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendDepotSearchResultDetail(itemId, tier, depotCount, depotItems, inboxCount, inboxItems, stashCount); } } - void sendCoinBalance() { + void sendCoinBalance() const { if (client) { client->sendCoinBalance(); } } - void sendInventoryItem(Slots_t slot, std::shared_ptr<Item> item) { + void sendInventoryItem(Slots_t slot, const std::shared_ptr<Item> &item) const { if (client) { client->sendInventoryItem(slot, item); } } - void sendInventoryIds() { + void sendInventoryIds() const { if (client) { client->sendInventoryIds(); } @@ -1297,19 +1289,19 @@ class Player final : public Creature, public Cylinder, public Bankable { void openPlayerContainers(); // Quickloot - void sendLootContainers() { + void sendLootContainers() const { if (client) { client->sendLootContainers(); } } - void sendSingleSoundEffect(const Position &pos, SoundEffect_t id, SourceEffect_t source) { + void sendSingleSoundEffect(const Position &pos, SoundEffect_t id, SourceEffect_t source) const { if (client) { client->sendSingleSoundEffect(pos, id, source); } } - void sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundId, SourceEffect_t mainSource, SoundEffect_t secondarySoundId, SourceEffect_t secondarySource) { + void sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundId, SourceEffect_t mainSource, SoundEffect_t secondarySoundId, SourceEffect_t secondarySource) const { if (client) { client->sendDoubleSoundEffect(pos, mainSoundId, mainSource, secondarySoundId, secondarySource); } @@ -1319,11 +1311,11 @@ class Player final : public Creature, public Cylinder, public Bankable { SoundEffect_t getHitSoundEffect() const; // event methods - void onUpdateTileItem(std::shared_ptr<Tile> tile, const Position &pos, std::shared_ptr<Item> oldItem, const ItemType &oldType, std::shared_ptr<Item> newItem, const ItemType &newType) override; - void onRemoveTileItem(std::shared_ptr<Tile> tile, const Position &pos, const ItemType &iType, std::shared_ptr<Item> item) override; + void onUpdateTileItem(const std::shared_ptr<Tile> &tile, const Position &pos, const std::shared_ptr<Item> &oldItem, const ItemType &oldType, const std::shared_ptr<Item> &newItem, const ItemType &newType) override; + void onRemoveTileItem(const std::shared_ptr<Tile> &tile, const Position &pos, const ItemType &iType, const std::shared_ptr<Item> &item) override; - void onCreatureAppear(std::shared_ptr<Creature> creature, bool isLogin) override; - void onRemoveCreature(std::shared_ptr<Creature> creature, bool isLogout) override; + void onCreatureAppear(const std::shared_ptr<Creature> &creature, bool isLogin) override; + void onRemoveCreature(const std::shared_ptr<Creature> &creature, bool isLogout) override; void onCreatureMove(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &newTile, const Position &newPos, const std::shared_ptr<Tile> &oldTile, const Position &oldPos, bool teleport) override; void onEquipInventory(); @@ -1333,17 +1325,17 @@ class Player final : public Creature, public Cylinder, public Bankable { void onFollowCreatureDisappear(bool isLogout) override; // container - void onAddContainerItem(std::shared_ptr<Item> item); - void onUpdateContainerItem(std::shared_ptr<Container> container, std::shared_ptr<Item> oldItem, std::shared_ptr<Item> newItem); - void onRemoveContainerItem(std::shared_ptr<Container> container, std::shared_ptr<Item> item); + void onAddContainerItem(const std::shared_ptr<Item> &item); + void onUpdateContainerItem(const std::shared_ptr<Container> &container, const std::shared_ptr<Item> &oldItem, const std::shared_ptr<Item> &newItem); + void onRemoveContainerItem(const std::shared_ptr<Container> &container, const std::shared_ptr<Item> &item); - void onCloseContainer(std::shared_ptr<Container> container); - void onSendContainer(std::shared_ptr<Container> container); - void autoCloseContainers(std::shared_ptr<Container> container); + void onCloseContainer(const std::shared_ptr<Container> &container); + void onSendContainer(const std::shared_ptr<Container> &container); + void autoCloseContainers(const std::shared_ptr<Container> &container); // inventory - void onUpdateInventoryItem(std::shared_ptr<Item> oldItem, std::shared_ptr<Item> newItem); - void onRemoveInventoryItem(std::shared_ptr<Item> item); + void onUpdateInventoryItem(const std::shared_ptr<Item> &oldItem, const std::shared_ptr<Item> &newItem); + void onRemoveInventoryItem(const std::shared_ptr<Item> &item); void sendCancelMessage(const std::string &msg) const { if (client) { @@ -1361,52 +1353,52 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendCancelWalk(); } } - void sendChangeSpeed(std::shared_ptr<Creature> creature, uint16_t newSpeed) const { + void sendChangeSpeed(const std::shared_ptr<Creature> &creature, uint16_t newSpeed) const { if (client) { client->sendChangeSpeed(creature, newSpeed); } } - void sendCreatureHealth(std::shared_ptr<Creature> creature) const { + void sendCreatureHealth(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendCreatureHealth(creature); } } - void sendPartyCreatureUpdate(std::shared_ptr<Creature> creature) const { + void sendPartyCreatureUpdate(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendPartyCreatureUpdate(creature); } } - void sendPartyCreatureShield(std::shared_ptr<Creature> creature) const { + void sendPartyCreatureShield(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendPartyCreatureShield(creature); } } - void sendPartyCreatureSkull(std::shared_ptr<Creature> creature) const { + void sendPartyCreatureSkull(const std::shared_ptr<Creature> &creature) const { if (client) { client->sendPartyCreatureSkull(creature); } } - void sendPartyCreatureHealth(std::shared_ptr<Creature> creature, uint8_t healthPercent) const { + void sendPartyCreatureHealth(const std::shared_ptr<Creature> &creature, uint8_t healthPercent) const { if (client) { client->sendPartyCreatureHealth(creature, healthPercent); } } - void sendPartyPlayerMana(std::shared_ptr<Player> player, uint8_t manaPercent) const { + void sendPartyPlayerMana(const std::shared_ptr<Player> &player, uint8_t manaPercent) const { if (client) { client->sendPartyPlayerMana(player, manaPercent); } } - void sendPartyCreatureShowStatus(std::shared_ptr<Creature> creature, bool showStatus) const { + void sendPartyCreatureShowStatus(const std::shared_ptr<Creature> &creature, bool showStatus) const { if (client) { client->sendPartyCreatureShowStatus(creature, showStatus); } } - void sendPartyPlayerVocation(std::shared_ptr<Player> player) const { + void sendPartyPlayerVocation(const std::shared_ptr<Player> &player) const { if (client) { client->sendPartyPlayerVocation(player); } } - void sendPlayerVocation(std::shared_ptr<Player> player) const { + void sendPlayerVocation(const std::shared_ptr<Player> &player) const { if (client) { client->sendPlayerVocation(player); } @@ -1416,15 +1408,15 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendDistanceShoot(from, to, type); } } - void sendHouseWindow(std::shared_ptr<House> house, uint32_t listId) const; - void sendCreatePrivateChannel(uint16_t channelId, const std::string &channelName) { + void sendHouseWindow(const std::shared_ptr<House> &house, uint32_t listId) const; + void sendCreatePrivateChannel(uint16_t channelId, const std::string &channelName) const { if (client) { client->sendCreatePrivateChannel(channelId, channelName); } } void sendClosePrivate(uint16_t channelId); void sendIcons(); - void sendIconBakragore(const IconBakragore icon); + void sendIconBakragore(IconBakragore icon) const; void removeBakragoreIcons(); void removeBakragoreIcon(const IconBakragore icon); void sendClientCheck() const { @@ -1484,17 +1476,17 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendReLoginWindow(unfairFightReduction); } } - void sendTextWindow(std::shared_ptr<Item> item, uint16_t maxlen, bool canWrite) const { + void sendTextWindow(const std::shared_ptr<Item> &item, uint16_t maxlen, bool canWrite) const { if (client) { client->sendTextWindow(windowTextId, item, maxlen, canWrite); } } - void sendToChannel(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, uint16_t channelId) const { + void sendToChannel(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, uint16_t channelId) const { if (client) { client->sendToChannel(creature, type, text, channelId); } } - void sendShop(std::shared_ptr<Npc> npc) const { + void sendShop(const std::shared_ptr<Npc> &npc) const { if (client) { client->sendShop(npc); } @@ -1505,7 +1497,7 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendCloseShop(); } } - void sendMarketEnter(uint32_t depotId); + void sendMarketEnter(uint32_t depotId) const; void sendMarketLeave() { inMarket = false; if (client) { @@ -1542,7 +1534,7 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendMarketCancelOffer(offer); } } - void sendTradeItemRequest(const std::string &traderName, std::shared_ptr<Item> item, bool ack) const { + void sendTradeItemRequest(const std::string &traderName, const std::shared_ptr<Item> &item, bool ack) const { if (client) { client->sendTradeItemRequest(traderName, item, ack); } @@ -1552,22 +1544,22 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendCloseTrade(); } } - void sendWorldLight(LightInfo lightInfo) { + void sendWorldLight(LightInfo lightInfo) const { if (client) { client->sendWorldLight(lightInfo); } } - void sendTibiaTime(int32_t time) { + void sendTibiaTime(int32_t time) const { if (client) { client->sendTibiaTime(time); } } - void sendChannelsDialog() { + void sendChannelsDialog() const { if (client) { client->sendChannelsDialog(); } } - void sendOpenPrivateChannel(const std::string &receiver) { + void sendOpenPrivateChannel(const std::string &receiver) const { if (client) { client->sendOpenPrivateChannel(receiver); } @@ -1577,16 +1569,16 @@ class Player final : public Creature, public Cylinder, public Bankable { client->sendExperienceTracker(rawExp, finalExp); } } - void sendOutfitWindow() { + void sendOutfitWindow() const { if (client) { client->sendOutfitWindow(); } } // Imbuements - void onApplyImbuement(Imbuement* imbuement, std::shared_ptr<Item> item, uint8_t slot, bool protectionCharm); - void onClearImbuement(std::shared_ptr<Item> item, uint8_t slot); - void openImbuementWindow(std::shared_ptr<Item> item); - void sendImbuementResult(const std::string message) { + void onApplyImbuement(const Imbuement* imbuement, const std::shared_ptr<Item> &item, uint8_t slot, bool protectionCharm); + void onClearImbuement(const std::shared_ptr<Item> &item, uint8_t slot); + void openImbuementWindow(const std::shared_ptr<Item> &item); + void sendImbuementResult(const std::string &message) const { if (client) { client->sendImbuementResult(message); } @@ -1596,104 +1588,104 @@ class Player final : public Creature, public Cylinder, public Bankable { client->closeImbuementWindow(); } } - void sendPodiumWindow(std::shared_ptr<Item> podium, const Position &position, uint16_t itemId, uint8_t stackpos) { + void sendPodiumWindow(const std::shared_ptr<Item> &podium, const Position &position, uint16_t itemId, uint8_t stackpos) const { if (client) { client->sendPodiumWindow(podium, position, itemId, stackpos); } } - void sendCloseContainer(uint8_t cid) { + void sendCloseContainer(uint8_t cid) const { if (client) { client->sendCloseContainer(cid); } } - void sendChannel(uint16_t channelId, const std::string &channelName, const UsersMap* channelUsers, const InvitedMap* invitedUsers) { + void sendChannel(uint16_t channelId, const std::string &channelName, const UsersMap* channelUsers, const InvitedMap* invitedUsers) const { if (client) { client->sendChannel(channelId, channelName, channelUsers, invitedUsers); } } - void sendTutorial(uint8_t tutorialId) { + void sendTutorial(uint8_t tutorialId) const { if (client) { client->sendTutorial(tutorialId); } } - void sendAddMarker(const Position &pos, uint8_t markType, const std::string &desc) { + void sendAddMarker(const Position &pos, uint8_t markType, const std::string &desc) const { if (client) { client->sendAddMarker(pos, markType, desc); } } - void sendItemInspection(uint16_t itemId, uint8_t itemCount, std::shared_ptr<Item> item, bool cyclopedia) { + void sendItemInspection(uint16_t itemId, uint8_t itemCount, const std::shared_ptr<Item> &item, bool cyclopedia) const { if (client) { client->sendItemInspection(itemId, itemCount, item, cyclopedia); } } - void sendCyclopediaCharacterNoData(CyclopediaCharacterInfoType_t characterInfoType, uint8_t errorCode) { + void sendCyclopediaCharacterNoData(CyclopediaCharacterInfoType_t characterInfoType, uint8_t errorCode) const { if (client) { client->sendCyclopediaCharacterNoData(characterInfoType, errorCode); } } - void sendCyclopediaCharacterBaseInformation() { + void sendCyclopediaCharacterBaseInformation() const { if (client) { client->sendCyclopediaCharacterBaseInformation(); } } - void sendCyclopediaCharacterGeneralStats() { + void sendCyclopediaCharacterGeneralStats() const { if (client) { client->sendCyclopediaCharacterGeneralStats(); } } - void sendCyclopediaCharacterCombatStats() { + void sendCyclopediaCharacterCombatStats() const { if (client) { client->sendCyclopediaCharacterCombatStats(); } } - void sendCyclopediaCharacterRecentDeaths(uint16_t page, uint16_t pages, const std::vector<RecentDeathEntry> &entries) { + void sendCyclopediaCharacterRecentDeaths(uint16_t page, uint16_t pages, const std::vector<RecentDeathEntry> &entries) const { if (client) { client->sendCyclopediaCharacterRecentDeaths(page, pages, entries); } } - void sendCyclopediaCharacterRecentPvPKills(uint16_t page, uint16_t pages, const std::vector<RecentPvPKillEntry> &entries) { + void sendCyclopediaCharacterRecentPvPKills(uint16_t page, uint16_t pages, const std::vector<RecentPvPKillEntry> &entries) const { if (client) { client->sendCyclopediaCharacterRecentPvPKills(page, pages, entries); } } - void sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, std::vector<std::pair<Achievement, uint32_t>> achievementsUnlocked); - void sendCyclopediaCharacterItemSummary(const ItemsTierCountList &inventoryItems, const ItemsTierCountList &storeInboxItems, const StashItemList &supplyStashItems, const ItemsTierCountList &depotBoxItems, const ItemsTierCountList &inboxItems) { + void sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, const std::vector<std::pair<Achievement, uint32_t>> &achievementsUnlocked) const; + void sendCyclopediaCharacterItemSummary(const ItemsTierCountList &inventoryItems, const ItemsTierCountList &storeInboxItems, const StashItemList &supplyStashItems, const ItemsTierCountList &depotBoxItems, const ItemsTierCountList &inboxItems) const { if (client) { client->sendCyclopediaCharacterItemSummary(inventoryItems, storeInboxItems, supplyStashItems, depotBoxItems, inboxItems); } } - void sendCyclopediaCharacterOutfitsMounts() { + void sendCyclopediaCharacterOutfitsMounts() const { if (client) { client->sendCyclopediaCharacterOutfitsMounts(); } } - void sendCyclopediaCharacterStoreSummary() { + void sendCyclopediaCharacterStoreSummary() const { if (client) { client->sendCyclopediaCharacterStoreSummary(); } } - void sendCyclopediaCharacterInspection() { + void sendCyclopediaCharacterInspection() const { if (client) { client->sendCyclopediaCharacterInspection(); } } - void sendCyclopediaCharacterBadges() { + void sendCyclopediaCharacterBadges() const { if (client) { client->sendCyclopediaCharacterBadges(); } } - void sendCyclopediaCharacterTitles() { + void sendCyclopediaCharacterTitles() const { if (client) { client->sendCyclopediaCharacterTitles(); } } - void sendHighscoresNoData() { + void sendHighscoresNoData() const { if (client) { client->sendHighscoresNoData(); } } - void sendHighscores(const std::vector<HighscoreCharacter> &characters, uint8_t categoryId, uint32_t vocationId, uint16_t page, uint16_t pages, uint32_t updateTimer) { + void sendHighscores(const std::vector<HighscoreCharacter> &characters, uint8_t categoryId, uint32_t vocationId, uint16_t page, uint16_t pages, uint32_t updateTimer) const { if (client) { client->sendHighscores(characters, categoryId, vocationId, page, pages, updateTimer); } @@ -1707,17 +1699,17 @@ class Player final : public Creature, public Cylinder, public Bankable { void resetAsyncOngoingTask(uint64_t flags) { asyncOngoingTasks &= ~(flags); } - void sendEnterWorld() { + void sendEnterWorld() const { if (client) { client->sendEnterWorld(); } } - void sendFightModes() { + void sendFightModes() const { if (client) { client->sendFightModes(); } } - void sendNetworkMessage(const NetworkMessage &message) { + void sendNetworkMessage(const NetworkMessage &message) const { if (client) { client->writeToOutputBuffer(message); } @@ -1727,13 +1719,13 @@ class Player final : public Creature, public Cylinder, public Bankable { lastPong = OTSYS_TIME(); } - void sendOpenStash(bool isNpc = false) { + void sendOpenStash(bool isNpc = false) const { if (client && ((getLastDepotId() != -1) || isNpc)) { client->sendOpenStash(); } } - void sendTakeScreenshot(Screenshot_t screenshotType) { + void sendTakeScreenshot(Screenshot_t screenshotType) const { if (client) { client->sendTakeScreenshot(screenshotType); } @@ -1741,8 +1733,8 @@ class Player final : public Creature, public Cylinder, public Bankable { void onThink(uint32_t interval) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; void setNextAction(int64_t time) { if (time > nextAction) { @@ -1779,26 +1771,26 @@ class Player final : public Creature, public Cylinder, public Bankable { uint32_t getNextPotionActionTime() const; std::shared_ptr<Item> getWriteItem(uint32_t &windowTextId, uint16_t &maxWriteLen); - void setWriteItem(std::shared_ptr<Item> item, uint16_t maxWriteLen = 0); + void setWriteItem(const std::shared_ptr<Item> &item, uint16_t maxWriteLen = 0); std::shared_ptr<House> getEditHouse(uint32_t &windowTextId, uint32_t &listId); - void setEditHouse(std::shared_ptr<House> house, uint32_t listId = 0); + void setEditHouse(const std::shared_ptr<House> &house, uint32_t listId = 0); void learnInstantSpell(const std::string &spellName); void forgetInstantSpell(const std::string &spellName); bool hasLearnedInstantSpell(const std::string &spellName) const; - void updateRegeneration(); + void updateRegeneration() const; void setScheduledSaleUpdate(bool scheduled) { scheduledSaleUpdate = scheduled; } - bool getScheduledSaleUpdate() { + bool getScheduledSaleUpdate() const { return scheduledSaleUpdate; } - bool inPushEvent() { + bool inPushEvent() const { return inEventMovePush; } @@ -1806,7 +1798,7 @@ class Player final : public Creature, public Cylinder, public Bankable { inEventMovePush = b; } - bool walkExhausted() { + bool walkExhausted() const { if (hasCondition(CONDITION_PARALYZE)) { return lastWalking > OTSYS_TIME(); } @@ -1862,7 +1854,7 @@ class Player final : public Creature, public Cylinder, public Bankable { xpBoostTime = timeLeft; } - uint16_t getXpBoostTime() { + uint16_t getXpBoostTime() const { return xpBoostTime; } @@ -1879,16 +1871,16 @@ class Player final : public Creature, public Cylinder, public Bankable { bool isUIExhausted(uint32_t exhaustionTime = 250) const; void updateUIExhausted(); - bool isQuickLootListedItem(std::shared_ptr<Item> item) const { + bool isQuickLootListedItem(const std::shared_ptr<Item> &item) const { if (!item) { return false; } - auto it = std::find(quickLootListItemIds.begin(), quickLootListItemIds.end(), item->getID()); + auto it = std::ranges::find(quickLootListItemIds, item->getID()); return it != quickLootListItemIds.end(); } - bool updateKillTracker(std::shared_ptr<Container> corpse, const std::string &playerName, const Outfit_t creatureOutfit) const { + bool updateKillTracker(const std::shared_ptr<Container> &corpse, const std::string &playerName, const Outfit_t &creatureOutfit) const { if (client) { client->sendKillTrackerUpdate(corpse, playerName, creatureOutfit); return true; @@ -1903,32 +1895,32 @@ class Player final : public Creature, public Cylinder, public Bankable { } } - void sendLootStats(std::shared_ptr<Item> item, uint8_t count); - void updateSupplyTracker(std::shared_ptr<Item> item); + void sendLootStats(const std::shared_ptr<Item> &item, uint8_t count); + void updateSupplyTracker(const std::shared_ptr<Item> &item); void updateImpactTracker(CombatType_t type, int32_t amount) const; - void updateInputAnalyzer(CombatType_t type, int32_t amount, std::string target) { + void updateInputAnalyzer(CombatType_t type, int32_t amount, const std::string &target) const { if (client) { client->sendUpdateInputAnalyzer(type, amount, target); } } - void createLeaderTeamFinder(NetworkMessage &msg) { + void createLeaderTeamFinder(NetworkMessage &msg) const { if (client) { client->createLeaderTeamFinder(msg); } } - void sendLeaderTeamFinder(bool reset) { + void sendLeaderTeamFinder(bool reset) const { if (client) { client->sendLeaderTeamFinder(reset); } } - void sendTeamFinderList() { + void sendTeamFinderList() const { if (client) { client->sendTeamFinderList(); } } - void sendCreatureHelpers(uint32_t creatureId, uint16_t helpers) { + void sendCreatureHelpers(uint32_t creatureId, uint16_t helpers) const { if (client) { client->sendCreatureHelpers(creatureId, helpers); } @@ -1937,13 +1929,13 @@ class Player final : public Creature, public Cylinder, public Bankable { void setItemCustomPrice(uint16_t itemId, uint64_t price) { itemPriceMap[itemId] = price; } - uint32_t getCharmPoints() { + uint32_t getCharmPoints() const { return charmPoints; } void setCharmPoints(uint32_t points) { charmPoints = points; } - bool hasCharmExpansion() { + bool hasCharmExpansion() const { return charmExpansion; } void setCharmExpansion(bool onOff) { @@ -1952,21 +1944,21 @@ class Player final : public Creature, public Cylinder, public Bankable { void setUsedRunesBit(int32_t bit) { UsedRunesBit = bit; } - int32_t getUsedRunesBit() { + int32_t getUsedRunesBit() const { return UsedRunesBit; } void setUnlockedRunesBit(int32_t bit) { UnlockedRunesBit = bit; } - int32_t getUnlockedRunesBit() { + int32_t getUnlockedRunesBit() const { return UnlockedRunesBit; } void setImmuneCleanse(ConditionType_t conditiontype) { cleanseCondition.first = conditiontype; cleanseCondition.second = OTSYS_TIME() + 10000; } - bool isImmuneCleanse(ConditionType_t conditiontype) { - uint64_t timenow = OTSYS_TIME(); + bool isImmuneCleanse(ConditionType_t conditiontype) const { + const uint64_t timenow = OTSYS_TIME(); if ((cleanseCondition.first == conditiontype) && (timenow <= cleanseCondition.second)) { return true; @@ -2163,7 +2155,7 @@ class Player final : public Creature, public Cylinder, public Bankable { } const std::unique_ptr<PreySlot> &getPreySlotById(PreySlot_t slotid) { - if (auto it = std::find_if(preys.begin(), preys.end(), [slotid](const std::unique_ptr<PreySlot> &preyIt) { + if (auto it = std::ranges::find_if(preys, [slotid](const std::unique_ptr<PreySlot> &preyIt) { return preyIt->id == slotid; }); it != preys.end()) { @@ -2211,16 +2203,16 @@ class Player final : public Creature, public Cylinder, public Bankable { std::vector<uint16_t> getPreyBlackList() const { std::vector<uint16_t> rt; - for (const std::unique_ptr<PreySlot> &slot : preys) { + std::ranges::for_each(preys, [&rt](const std::unique_ptr<PreySlot> &slot) { if (slot) { if (slot->isOccupied()) { - rt.push_back(slot->selectedRaceId); - } - for (uint16_t raceId : slot->raceIdList) { - rt.push_back(raceId); + rt.emplace_back(slot->selectedRaceId); } + std::ranges::for_each(slot->raceIdList, [&rt](uint16_t raceId) { + rt.emplace_back(raceId); + }); } - } + }); return rt; } @@ -2230,10 +2222,11 @@ class Player final : public Creature, public Cylinder, public Bankable { return PreySlotNull; } - if (auto it = std::find_if(preys.begin(), preys.end(), [raceId](const std::unique_ptr<PreySlot> &it) { - return it->selectedRaceId == raceId; - }); - it != preys.end()) { + auto it = std::ranges::find_if(preys, [raceId](const std::unique_ptr<PreySlot> &preySlot) { + return preySlot->selectedRaceId == raceId; + }); + + if (it != preys.end()) { return *it; } @@ -2242,7 +2235,7 @@ class Player final : public Creature, public Cylinder, public Bankable { // Task hunting system void initializeTaskHunting(); - bool isCreatureUnlockedOnTaskHunting(const std::shared_ptr<MonsterType> mtype) const; + bool isCreatureUnlockedOnTaskHunting(const std::shared_ptr<MonsterType> &mtype) const; bool setTaskHuntingSlotClass(std::unique_ptr<TaskHuntingSlot> &slot) { if (getTaskHuntingSlotById(slot->id)) { @@ -2261,7 +2254,7 @@ class Player final : public Creature, public Cylinder, public Bankable { } const std::unique_ptr<TaskHuntingSlot> &getTaskHuntingSlotById(PreySlot_t slotid) { - if (auto it = std::find_if(taskHunting.begin(), taskHunting.end(), [slotid](const std::unique_ptr<TaskHuntingSlot> &itTask) { + if (auto it = std::ranges::find_if(taskHunting, [slotid](const std::unique_ptr<TaskHuntingSlot> &itTask) { return itTask->id == slotid; }); it != taskHunting.end()) { @@ -2274,12 +2267,12 @@ class Player final : public Creature, public Cylinder, public Bankable { std::vector<uint16_t> getTaskHuntingBlackList() const { std::vector<uint16_t> rt; - std::for_each(taskHunting.begin(), taskHunting.end(), [&rt](const std::unique_ptr<TaskHuntingSlot> &slot) { + std::ranges::for_each(taskHunting, [&rt](const std::unique_ptr<TaskHuntingSlot> &slot) { if (slot->isOccupied()) { - rt.push_back(slot->selectedRaceId); + rt.emplace_back(slot->selectedRaceId); } else { - std::for_each(slot->raceIdList.begin(), slot->raceIdList.end(), [&rt](uint16_t raceId) { - rt.push_back(raceId); + std::ranges::for_each(slot->raceIdList, [&rt](uint16_t raceId) { + rt.emplace_back(raceId); }); } }); @@ -2330,7 +2323,7 @@ class Player final : public Creature, public Cylinder, public Bankable { return TaskHuntingSlotNull; } - if (auto it = std::find_if(taskHunting.begin(), taskHunting.end(), [raceId](const std::unique_ptr<TaskHuntingSlot> &itTask) { + if (auto it = std::ranges::find_if(taskHunting, [raceId](const std::unique_ptr<TaskHuntingSlot> &itTask) { return itTask->selectedRaceId == raceId; }); it != taskHunting.end()) { @@ -2349,7 +2342,7 @@ class Player final : public Creature, public Cylinder, public Bankable { sendSkills(); } void setLoyaltyTitle(std::string title) { - loyaltyTitle = title; + loyaltyTitle = std::move(title); } std::string getLoyaltyTitle() const { return loyaltyTitle; @@ -2365,7 +2358,7 @@ class Player final : public Creature, public Cylinder, public Bankable { void openContainerFromDepotSearch(const Position &pos); std::shared_ptr<Item> getItemFromDepotSearch(uint16_t itemId, const Position &pos); - std::pair<std::vector<std::shared_ptr<Item>>, std::map<uint16_t, std::map<uint8_t, uint32_t>>> requestLockerItems(std::shared_ptr<DepotLocker> depotLocker, bool sendToClient = false, uint8_t tier = 0) const; + std::pair<std::vector<std::shared_ptr<Item>>, std::map<uint16_t, std::map<uint8_t, uint32_t>>> requestLockerItems(const std::shared_ptr<DepotLocker> &depotLocker, bool sendToClient = false, uint8_t tier = 0) const; /** This function returns a pair of an array of items and a 16-bit integer from a DepotLocker instance, a 8-bit byte and a 16-bit integer. @@ -2379,13 +2372,13 @@ class Player final : public Creature, public Cylinder, public Bankable { const std::shared_ptr<DepotLocker> &depotLocker, uint8_t tier, uint16_t itemId - ); + ) const; bool saySpell( SpeakClasses type, const std::string &text, bool ghostMode, - Spectators* spectatorsPtr = nullptr, + const Spectators* spectatorsPtr = nullptr, const Position* pos = nullptr ); @@ -2464,7 +2457,7 @@ class Player final : public Creature, public Cylinder, public Bankable { } void setForgeHistory(const ForgeHistory &history) { - forgeHistoryVector.push_back(history); + forgeHistoryVector.emplace_back(history); } void registerForgeHistoryDescription(ForgeHistory history); @@ -2515,19 +2508,19 @@ class Player final : public Creature, public Cylinder, public Bankable { return bossRemoveTimes; } - void sendMonsterPodiumWindow(std::shared_ptr<Item> podium, const Position &position, uint16_t itemId, uint8_t stackpos) const { + void sendMonsterPodiumWindow(const std::shared_ptr<Item> &podium, const Position &position, uint16_t itemId, uint8_t stackpos) const { if (client) { client->sendMonsterPodiumWindow(podium, position, itemId, stackpos); } } - void sendBosstiaryEntryChanged(uint32_t bossid) { + void sendBosstiaryEntryChanged(uint32_t bossid) const { if (client) { client->sendBosstiaryEntryChanged(bossid); } } - void sendInventoryImbuements(const std::map<Slots_t, std::shared_ptr<Item>> items) const { + void sendInventoryImbuements(const std::map<Slots_t, std::shared_ptr<Item>> &items) const { if (client) { client->sendInventoryImbuements(items); } @@ -2537,14 +2530,13 @@ class Player final : public Creature, public Cylinder, public Bankable { * Hazard system ******************************************************************************/ // Parser - void parseAttackRecvHazardSystem(CombatDamage &damage, std::shared_ptr<Monster> monster); - void parseAttackDealtHazardSystem(CombatDamage &damage, std::shared_ptr<Monster> monster); + void parseAttackRecvHazardSystem(CombatDamage &damage, const std::shared_ptr<Monster> &monster); + void parseAttackDealtHazardSystem(CombatDamage &damage, const std::shared_ptr<Monster> &monster) const; // Points increase: void setHazardSystemPoints(int32_t amount); // Points get: uint16_t getHazardSystemPoints() const { - int32_t points = 0; - points = getStorageValue(STORAGEVALUE_HAZARDCOUNT); + const int32_t points = getStorageValue(STORAGEVALUE_HAZARDCOUNT); if (points <= 0) { return 0; } @@ -2565,11 +2557,11 @@ class Player final : public Creature, public Cylinder, public Bankable { return activeConcoctions; } bool isConcoctionActive(Concoction_t concotion) const { - uint16_t itemId = static_cast<uint16_t>(concotion); + const auto itemId = static_cast<uint16_t>(concotion); if (!activeConcoctions.contains(itemId)) { return false; } - auto timeLeft = activeConcoctions.at(itemId); + const auto timeLeft = activeConcoctions.at(itemId); return timeLeft > 0; } @@ -2581,11 +2573,12 @@ class Player final : public Creature, public Cylinder, public Bankable { return false; } - auto featureKV = kv()->scoped("features")->get("autoloot"); - auto value = featureKV.has_value() ? featureKV->getNumber() : 0; + const auto featureKV = kv()->scoped("features")->get("autoloot"); + const auto value = featureKV.has_value() ? featureKV->getNumber() : 0; if (value == 2) { return true; - } else if (value == 1) { + } + if (value == 1) { return !isBoss; } return false; @@ -2669,13 +2662,13 @@ class Player final : public Creature, public Cylinder, public Bankable { std::vector<std::shared_ptr<Condition>> getMuteConditions() const; - void checkTradeState(std::shared_ptr<Item> item); - bool hasCapacity(std::shared_ptr<Item> item, uint32_t count) const; + void checkTradeState(const std::shared_ptr<Item> &item); + bool hasCapacity(const std::shared_ptr<Item> &item, uint32_t count) const; - void checkLootContainers(std::shared_ptr<Container> item); + void checkLootContainers(const std::shared_ptr<Container> &item); - void gainExperience(uint64_t exp, std::shared_ptr<Creature> target); - void addExperience(std::shared_ptr<Creature> target, uint64_t exp, bool sendText = false); + void gainExperience(uint64_t exp, const std::shared_ptr<Creature> &target); + void addExperience(const std::shared_ptr<Creature> &target, uint64_t exp, bool sendText = false); void removeExperience(uint64_t exp, bool sendText = false); void updateInventoryWeight(); @@ -2685,37 +2678,37 @@ class Player final : public Creature, public Cylinder, public Bankable { */ void updateInventoryImbuement(); - void setNextWalkActionTask(std::shared_ptr<Task> task); - void setNextWalkTask(std::shared_ptr<Task> task); - void setNextActionTask(std::shared_ptr<Task> task, bool resetIdleTime = true); - void setNextActionPushTask(std::shared_ptr<Task> task); - void setNextPotionActionTask(std::shared_ptr<Task> task); + void setNextWalkActionTask(const std::shared_ptr<Task> &task); + void setNextWalkTask(const std::shared_ptr<Task> &task); + void setNextActionTask(const std::shared_ptr<Task> &task, bool resetIdleTime = true); + void setNextActionPushTask(const std::shared_ptr<Task> &task); + void setNextPotionActionTask(const std::shared_ptr<Task> &task); - void death(std::shared_ptr<Creature> lastHitCreature) override; + void death(const std::shared_ptr<Creature> &lastHitCreature) override; bool spawn(); void despawn(); - bool dropCorpse(std::shared_ptr<Creature> lastHitCreature, std::shared_ptr<Creature> mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified) override; - std::shared_ptr<Item> getCorpse(std::shared_ptr<Creature> lastHitCreature, std::shared_ptr<Creature> mostDamageCreature) override; + bool dropCorpse(const std::shared_ptr<Creature> &lastHitCreature, const std::shared_ptr<Creature> &mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified) override; + std::shared_ptr<Item> getCorpse(const std::shared_ptr<Creature> &lastHitCreature, const std::shared_ptr<Creature> &mostDamageCreature) override; // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) override; - ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; - std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) override; + ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; + std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) override; - void addThing(std::shared_ptr<Thing>) override { } - void addThing(int32_t index, std::shared_ptr<Thing> thing) override; + void addThing(const std::shared_ptr<Thing> &) override { } + void addThing(int32_t index, const std::shared_ptr<Thing> &thing) override; - void updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) override; - void replaceThing(uint32_t index, std::shared_ptr<Thing> thing) override; + void updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) override; + void replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) override; - void removeThing(std::shared_ptr<Thing> thing, uint32_t count) override; + void removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) override; - int32_t getThingIndex(std::shared_ptr<Thing> thing) const override; + int32_t getThingIndex(const std::shared_ptr<Thing> &thing) const override; size_t getFirstIndex() const override; size_t getLastIndex() const override; uint32_t getItemTypeCount(uint16_t itemId, int32_t subType = -1) const override; - void stashContainer(StashContainerList itemDict); + void stashContainer(const StashContainerList &itemDict); ItemsTierCountList getInventoryItemsId(bool ignoreStoreInbox = false) const; // This function is a override function of base class @@ -2723,17 +2716,17 @@ class Player final : public Creature, public Cylinder, public Bankable { // Function from player class with correct type sizes (uint16_t) std::map<uint16_t, uint16_t> &getAllSaleItemIdAndCount(std::map<uint16_t, uint16_t> &countMap) const; void getAllItemTypeCountAndSubtype(std::map<uint32_t, uint32_t> &countMap) const; - std::shared_ptr<Item> getForgeItemFromId(uint16_t itemId, uint8_t tier); + std::shared_ptr<Item> getForgeItemFromId(uint16_t itemId, uint8_t tier) const; std::shared_ptr<Thing> getThing(size_t index) const override; - void internalAddThing(std::shared_ptr<Thing> thing) override; - void internalAddThing(uint32_t index, std::shared_ptr<Thing> thing) override; + void internalAddThing(const std::shared_ptr<Thing> &thing) override; + void internalAddThing(uint32_t index, const std::shared_ptr<Thing> &thing) override; void addHuntingTaskKill(const std::shared_ptr<MonsterType> &mType); void addBestiaryKill(const std::shared_ptr<MonsterType> &mType); void addBosstiaryKill(const std::shared_ptr<MonsterType> &mType); - phmap::flat_hash_set<uint32_t> attackedSet; + phmap::flat_hash_set<uint32_t> attackedSet {}; std::map<uint8_t, OpenContainer> openContainers; std::map<uint32_t, std::shared_ptr<DepotLocker>> depotLockerMap; @@ -2927,7 +2920,7 @@ class Player final : public Creature, public Cylinder, public Bankable { TradeState_t tradeState = TRADE_NONE; FightMode_t fightMode = FIGHTMODE_ATTACK; Faction_t faction = FACTION_PLAYER; - QuickLootFilter_t quickLootFilter; + QuickLootFilter_t quickLootFilter {}; PlayerPronoun_t pronoun = PLAYERPRONOUN_THEY; bool chaseMode = false; @@ -3066,13 +3059,13 @@ class Player final : public Creature, public Cylinder, public Bankable { std::array<double_t, COMBAT_COUNT> getFinalDamageReduction() const; void calculateDamageReductionFromEquipedItems(std::array<double_t, COMBAT_COUNT> &combatReductionMap) const; - void calculateDamageReductionFromItem(std::array<double_t, COMBAT_COUNT> &combatReductionMap, std::shared_ptr<Item> item) const; - void updateDamageReductionFromItemImbuement(std::array<double_t, COMBAT_COUNT> &combatReductionMap, std::shared_ptr<Item> item, uint16_t combatTypeIndex) const; - void updateDamageReductionFromItemAbility(std::array<double_t, COMBAT_COUNT> &combatReductionMap, std::shared_ptr<Item> item, uint16_t combatTypeIndex) const; + void calculateDamageReductionFromItem(std::array<double_t, COMBAT_COUNT> &combatReductionMap, const std::shared_ptr<Item> &item) const; + void updateDamageReductionFromItemImbuement(std::array<double_t, COMBAT_COUNT> &combatReductionMap, const std::shared_ptr<Item> &item, uint16_t combatTypeIndex) const; + void updateDamageReductionFromItemAbility(std::array<double_t, COMBAT_COUNT> &combatReductionMap, const std::shared_ptr<Item> &item, uint16_t combatTypeIndex) const; double_t calculateDamageReduction(double_t currentTotal, int16_t resistance) const; void removeEmptyRewards(); - bool hasOtherRewardContainerOpen(const std::shared_ptr<Container> container) const; + bool hasOtherRewardContainerOpen(const std::shared_ptr<Container> &container) const; void checkAndShowBlessingMessage(); diff --git a/src/creatures/players/storages/storages.cpp b/src/creatures/players/storages/storages.cpp index 6f6847858ed..e3fd7e13ced 100644 --- a/src/creatures/players/storages/storages.cpp +++ b/src/creatures/players/storages/storages.cpp @@ -8,8 +8,13 @@ */ #include "creatures/players/storages/storages.hpp" - #include "config/configmanager.hpp" +#include "config/config_enums.hpp" +#include "lib/di/container.hpp" + +Storages &Storages::getInstance() { + return inject<Storages>(); +} bool Storages::loadFromXML() { pugi::xml_document doc; @@ -25,12 +30,12 @@ bool Storages::loadFromXML() { std::vector<std::pair<uint32_t, uint32_t>> ranges; - for (pugi::xml_node range : doc.child("storages").children("range")) { + for (const auto &range : doc.child("storages").children("range")) { uint32_t start = range.attribute("start").as_uint(); uint32_t end = range.attribute("end").as_uint(); - for (const auto &existingRange : ranges) { - if ((start >= existingRange.first && start <= existingRange.second) || (end >= existingRange.first && end <= existingRange.second)) { + for (const auto &[rangeStart, rangeEnd] : ranges) { + if ((start >= rangeStart && start <= rangeEnd) || (end >= rangeStart && end <= rangeEnd)) { g_logger().warn("[{}] Storage range from {} to {} conflicts with a previously defined range", __func__, start, end); continue; } @@ -38,11 +43,11 @@ bool Storages::loadFromXML() { ranges.emplace_back(start, end); - for (pugi::xml_node storage : range.children("storage")) { + for (const auto &storage : range.children("storage")) { std::string name = storage.attribute("name").as_string(); uint32_t key = storage.attribute("key").as_uint(); - for (char c : name) { + for (const char &c : name) { if (std::isupper(c)) { g_logger().warn("[{}] Storage from storages.xml with name: {}, contains uppercase letters. Please use dot notation pattern", __func__, name); break; diff --git a/src/creatures/players/storages/storages.hpp b/src/creatures/players/storages/storages.hpp index afc9fe14f90..70e099988fd 100644 --- a/src/creatures/players/storages/storages.hpp +++ b/src/creatures/players/storages/storages.hpp @@ -9,8 +9,6 @@ #pragma once -#include "lib/di/container.hpp" - class Storages { public: Storages() = default; @@ -19,9 +17,7 @@ class Storages { Storages(const Storages &) = delete; void operator=(const Storages &) = delete; - static Storages &getInstance() { - return inject<Storages>(); - } + static Storages &getInstance(); bool loadFromXML(); diff --git a/src/creatures/players/vip/player_vip.cpp b/src/creatures/players/vip/player_vip.cpp index 9d7bb7c27c7..dd49429ba2c 100644 --- a/src/creatures/players/vip/player_vip.cpp +++ b/src/creatures/players/vip/player_vip.cpp @@ -23,7 +23,8 @@ PlayerVIP::PlayerVIP(Player &player) : size_t PlayerVIP::getMaxEntries() const { if (m_player.group && m_player.group->maxVipEntries != 0) { return m_player.group->maxVipEntries; - } else if (m_player.isPremium()) { + } + if (m_player.isPremium()) { return 100; } return 20; @@ -36,7 +37,7 @@ uint8_t PlayerVIP::getMaxGroupEntries() const { return 0; } -void PlayerVIP::notifyStatusChange(std::shared_ptr<Player> loginPlayer, VipStatus_t status, bool message) const { +void PlayerVIP::notifyStatusChange(const std::shared_ptr<Player> &loginPlayer, VipStatus_t vipStatus, bool message) const { if (!m_player.client) { return; } @@ -45,12 +46,12 @@ void PlayerVIP::notifyStatusChange(std::shared_ptr<Player> loginPlayer, VipStatu return; } - m_player.client->sendUpdatedVIPStatus(loginPlayer->getGUID(), status); + m_player.client->sendUpdatedVIPStatus(loginPlayer->getGUID(), vipStatus); if (message) { - if (status == VipStatus_t::Online) { + if (vipStatus == VipStatus_t::Online) { m_player.sendTextMessage(TextMessage(MESSAGE_FAILURE, fmt::format("{} has logged in.", loginPlayer->getName()))); - } else if (status == VipStatus_t::Offline) { + } else if (vipStatus == VipStatus_t::Offline) { m_player.sendTextMessage(TextMessage(MESSAGE_FAILURE, fmt::format("{} has logged out.", loginPlayer->getName()))); } } @@ -99,8 +100,8 @@ bool PlayerVIP::addInternal(uint32_t vipGuid) { return vipGuids.insert(vipGuid).second; } -bool PlayerVIP::edit(uint32_t vipGuid, const std::string &description, uint32_t icon, bool notify, std::vector<uint8_t> groupsId) const { - const auto it = vipGuids.find(vipGuid); +bool PlayerVIP::edit(uint32_t vipGuid, const std::string &description, uint32_t icon, bool notify, const std::vector<uint8_t> &groupsId) const { + auto it = vipGuids.find(vipGuid); if (it == vipGuids.end()) { return false; // player is not in VIP } @@ -111,7 +112,7 @@ bool PlayerVIP::edit(uint32_t vipGuid, const std::string &description, uint32_t IOLoginData::removeGuidVIPGroupEntry(m_player.account->getID(), vipGuid); - for (const auto groupId : groupsId) { + for (const auto &groupId : groupsId) { const auto &group = getGroupByID(groupId); if (group) { group->vipGroupGuids.insert(vipGuid); @@ -123,7 +124,7 @@ bool PlayerVIP::edit(uint32_t vipGuid, const std::string &description, uint32_t } std::shared_ptr<VIPGroup> PlayerVIP::getGroupByID(uint8_t groupId) const { - auto it = std::find_if(vipGroups.begin(), vipGroups.end(), [groupId](const std::shared_ptr<VIPGroup> vipGroup) { + auto it = std::ranges::find_if(vipGroups, [groupId](const auto &vipGroup) { return vipGroup->id == groupId; }); @@ -132,7 +133,7 @@ std::shared_ptr<VIPGroup> PlayerVIP::getGroupByID(uint8_t groupId) const { std::shared_ptr<VIPGroup> PlayerVIP::getGroupByName(const std::string &name) const { const auto groupName = name.c_str(); - auto it = std::find_if(vipGroups.begin(), vipGroups.end(), [groupName](const std::shared_ptr<VIPGroup> vipGroup) { + auto it = std::ranges::find_if(vipGroups, [groupName](const auto &vipGroup) { return strcmp(groupName, vipGroup->name.c_str()) == 0; }); @@ -155,7 +156,7 @@ void PlayerVIP::addGroupInternal(uint8_t groupId, const std::string &name, bool } void PlayerVIP::removeGroup(uint8_t groupId) { - auto it = std::find_if(vipGroups.begin(), vipGroups.end(), [groupId](const std::shared_ptr<VIPGroup> vipGroup) { + auto it = std::ranges::find_if(vipGroups, [groupId](const auto &vipGroup) { return vipGroup->id == groupId; }); @@ -186,7 +187,7 @@ void PlayerVIP::addGroup(const std::string &name, bool customizable /*= true */) return; } - std::shared_ptr<VIPGroup> vipGroup = std::make_shared<VIPGroup>(freeId, name, customizable); + auto vipGroup = std::make_shared<VIPGroup>(freeId, name, customizable); vipGroups.emplace_back(vipGroup); if (m_player.account) { @@ -198,7 +199,7 @@ void PlayerVIP::addGroup(const std::string &name, bool customizable /*= true */) } } -void PlayerVIP::editGroup(uint8_t groupId, const std::string &newName, bool customizable /*= true*/) { +void PlayerVIP::editGroup(uint8_t groupId, const std::string &newName, bool customizable /*= true*/) const { if (getGroupByName(newName) != nullptr) { m_player.sendCancelMessage("A group with this name already exists. Please choose another name."); return; @@ -227,7 +228,7 @@ uint8_t PlayerVIP::getFreeId() const { return 0; } -const std::vector<uint8_t> PlayerVIP::getGroupsIdGuidBelongs(uint32_t guid) { +std::vector<uint8_t> PlayerVIP::getGroupsIdGuidBelongs(uint32_t guid) const { std::vector<uint8_t> guidBelongs; for (const auto &vipGroup : vipGroups) { if (vipGroup->vipGroupGuids.contains(guid)) { @@ -237,7 +238,7 @@ const std::vector<uint8_t> PlayerVIP::getGroupsIdGuidBelongs(uint32_t guid) { return guidBelongs; } -void PlayerVIP::addGuidToGroupInternal(uint8_t groupId, uint32_t guid) { +void PlayerVIP::addGuidToGroupInternal(uint8_t groupId, uint32_t guid) const { const auto &group = getGroupByID(groupId); if (group) { group->vipGroupGuids.insert(guid); diff --git a/src/creatures/players/vip/player_vip.hpp b/src/creatures/players/vip/player_vip.hpp index e9aeaf85326..0eb46b076af 100644 --- a/src/creatures/players/vip/player_vip.hpp +++ b/src/creatures/players/vip/player_vip.hpp @@ -13,18 +13,19 @@ class Player; -struct VIPGroup { +class VIPGroup { +public: uint8_t id = 0; - std::string name = ""; + std::string name; bool customizable = false; phmap::flat_hash_set<uint32_t> vipGroupGuids; VIPGroup() = default; - VIPGroup(uint8_t id, const std::string &name, bool customizable) : + VIPGroup(uint8_t id, std::string name, bool customizable) : id(id), name(std::move(name)), customizable(customizable) { } }; -class PlayerVIP { +class PlayerVIP { public: explicit PlayerVIP(Player &player); @@ -41,11 +42,11 @@ class PlayerVIP { status = newStatus; } - void notifyStatusChange(std::shared_ptr<Player> loginPlayer, VipStatus_t status, bool message = true) const; + void notifyStatusChange(const std::shared_ptr<Player> &loginPlayer, VipStatus_t status, bool message = true) const; bool remove(uint32_t vipGuid); bool add(uint32_t vipGuid, const std::string &vipName, VipStatus_t status); bool addInternal(uint32_t vipGuid); - bool edit(uint32_t vipGuid, const std::string &description, uint32_t icon, bool notify, std::vector<uint8_t> groupsId) const; + bool edit(uint32_t vipGuid, const std::string &description, uint32_t icon, bool notify, const std::vector<uint8_t> &groupsId) const; // VIP Group std::shared_ptr<VIPGroup> getGroupByID(uint8_t groupId) const; @@ -54,12 +55,12 @@ class PlayerVIP { void addGroupInternal(uint8_t groupId, const std::string &name, bool customizable); void removeGroup(uint8_t groupId); void addGroup(const std::string &name, bool customizable = true); - void editGroup(uint8_t groupId, const std::string &newName, bool customizable = true); + void editGroup(uint8_t groupId, const std::string &newName, bool customizable = true) const; - void addGuidToGroupInternal(uint8_t groupId, uint32_t guid); + void addGuidToGroupInternal(uint8_t groupId, uint32_t guid) const; uint8_t getFreeId() const; - const std::vector<uint8_t> getGroupsIdGuidBelongs(uint32_t guid); + std::vector<uint8_t> getGroupsIdGuidBelongs(uint32_t guid) const; [[nodiscard]] const std::vector<std::shared_ptr<VIPGroup>> &getGroups() const { return vipGroups; diff --git a/src/creatures/players/vocations/vocation.cpp b/src/creatures/players/vocations/vocation.cpp index 0217cabe7db..1e7fb083800 100644 --- a/src/creatures/players/vocations/vocation.cpp +++ b/src/creatures/players/vocations/vocation.cpp @@ -9,10 +9,19 @@ #include "creatures/players/vocations/vocation.hpp" +#include "config/configmanager.hpp" +#include "lib/di/container.hpp" +#include "items/item.hpp" #include "utils/pugicast.hpp" #include "utils/tools.hpp" #include "enums/player_wheel.hpp" +#include <creatures/players/wheel/wheel_gems.hpp> + +Vocations &Vocations::getInstance() { + return inject<Vocations>(); +} + bool Vocations::reload() { vocationsMap.clear(); return loadFromXml(); @@ -27,17 +36,17 @@ bool Vocations::loadFromXml() { return false; } - for (auto vocationNode : doc.child("vocations").children()) { + for (const auto &vocationNode : doc.child("vocations").children()) { pugi::xml_attribute attr; - if (!(attr = vocationNode.attribute("id"))) { + if (!((attr = vocationNode.attribute("id")))) { g_logger().warn("[{}] - Missing vocation id", __FUNCTION__); continue; } - uint16_t id = pugi::cast<uint16_t>(attr.value()); + auto id = pugi::cast<uint16_t>(attr.value()); - auto res = vocationsMap.emplace(std::piecewise_construct, std::forward_as_tuple(id), std::forward_as_tuple(std::make_shared<Vocation>(id))); - auto voc = res.first->second; + auto [fst, snd] = vocationsMap.emplace(std::piecewise_construct, std::forward_as_tuple(id), std::forward_as_tuple(std::make_shared<Vocation>(id))); + const auto voc = fst->second; if ((attr = vocationNode.attribute("name"))) { voc->name = attr.as_string(); @@ -119,11 +128,11 @@ bool Vocations::loadFromXml() { voc->avatarLookType = pugi::cast<uint16_t>(attr.value()); } - for (auto childNode : vocationNode.children()) { + for (const auto &childNode : vocationNode.children()) { if (strcasecmp(childNode.name(), "skill") == 0) { pugi::xml_attribute skillIdAttribute = childNode.attribute("id"); if (skillIdAttribute) { - uint16_t skill_id = pugi::cast<uint16_t>(skillIdAttribute.value()); + auto skill_id = pugi::cast<uint16_t>(skillIdAttribute.value()); if (skill_id <= SKILL_LAST) { voc->skillMultipliers[skill_id] = pugi::cast<float>(childNode.attribute("multiplier").value()); } else { @@ -185,7 +194,7 @@ bool Vocations::loadFromXml() { pugi::xml_attribute qualityAttr = childNode.attribute("quality"); pugi::xml_attribute nameAttr = childNode.attribute("name"); auto quality = pugi::cast<uint8_t>(qualityAttr.value()); - auto name = nameAttr.as_string(); + const auto name = nameAttr.as_string(); voc->wheelGems[static_cast<WheelGemQuality_t>(quality)] = name; } } @@ -203,27 +212,26 @@ std::shared_ptr<Vocation> Vocations::getVocation(uint16_t id) { } return it->second; } - uint16_t Vocations::getVocationId(const std::string &name) const { - for (const auto &it : vocationsMap) { - if (strcasecmp(it.second->name.c_str(), name.c_str()) == 0) { - return it.first; + for (const auto &[vocationId, vocationPtr] : vocationsMap) { + if (caseInsensitiveCompare(vocationPtr->name, name)) { + return vocationId; } } - return -1; + return VOCATION_NONE; } uint16_t Vocations::getPromotedVocation(uint16_t vocationId) const { - for (const auto &it : vocationsMap) { - if (it.second->fromVocation == vocationId && it.first != vocationId) { - return it.first; + for (const auto &[currentVocationId, vocationPtr] : vocationsMap) { + if (vocationPtr->fromVocation == vocationId && currentVocationId != vocationId) { + return currentVocationId; } } return VOCATION_NONE; } uint32_t Vocation::skillBase[SKILL_LAST + 1] = { 50, 50, 50, 50, 30, 100, 20 }; -const uint16_t minSkillLevel = 10; +constexpr uint16_t minSkillLevel = 10; absl::uint128 Vocation::getTotalSkillTries(uint8_t skill, uint16_t level) { if (skill > SKILL_LAST) { @@ -253,7 +261,7 @@ uint64_t Vocation::getReqSkillTries(uint8_t skill, uint16_t level) { return it->second; } - uint64_t tries = static_cast<uint64_t>(skillBase[skill] * std::pow(static_cast<double>(skillMultipliers[skill]), level - (minSkillLevel + 1))); + const auto tries = static_cast<uint64_t>(skillBase[skill] * std::pow(static_cast<double>(skillMultipliers[skill]), level - (minSkillLevel + 1))); cacheSkill[skill][level] = tries; return tries; } @@ -282,26 +290,65 @@ uint64_t Vocation::getReqMana(uint32_t magLevel) { return it->second; } - uint64_t reqMana = std::floor<uint64_t>(1600 * std::pow<double>(manaMultiplier, static_cast<int32_t>(magLevel) - 1)); + const uint64_t reqMana = std::floor<uint64_t>(1600 * std::pow<double>(manaMultiplier, static_cast<int32_t>(magLevel) - 1)); cacheMana[magLevel] = reqMana; return reqMana; } +uint32_t Vocation::getManaGainTicks() const { + return gainManaTicks / g_configManager().getFloat(RATE_MANA_REGEN_SPEED); +} + +uint32_t Vocation::getManaGainAmount() const { + return gainManaAmount * g_configManager().getFloat(RATE_MANA_REGEN); +} + +uint32_t Vocation::getHealthGainTicks() const { + return gainHealthTicks / g_configManager().getFloat(RATE_HEALTH_REGEN_SPEED); +} + +uint32_t Vocation::getHealthGainAmount() const { + return gainHealthAmount * g_configManager().getFloat(RATE_HEALTH_REGEN); +} + +uint32_t Vocation::getSoulGainTicks() const { + return gainSoulTicks / g_configManager().getFloat(RATE_SOUL_REGEN_SPEED); +} + +uint32_t Vocation::getAttackSpeed() const { + return attackSpeed / g_configManager().getFloat(RATE_ATTACK_SPEED); +} + +template <> +struct magic_enum::customize::enum_range<WheelGemSupremeModifier_t> { + static constexpr int min = 0; + static constexpr int max = static_cast<int>(WheelGemSupremeModifier_t::Druid_RevelationMastery_TwinBursts); +}; + std::vector<WheelGemSupremeModifier_t> Vocation::getSupremeGemModifiers() { if (!m_supremeGemModifiers.empty()) { return m_supremeGemModifiers; } - auto baseVocation = g_vocations().getVocation(getBaseId()); + const auto baseVocation = g_vocations().getVocation(getBaseId()); auto vocationName = asLowerCaseString(baseVocation->getVocName()); auto allModifiers = magic_enum::enum_entries<WheelGemSupremeModifier_t>(); g_logger().debug("Loading supreme gem modifiers for vocation: {}", vocationName); + for (const auto &[value, modifierName] : allModifiers) { std::string targetVocation(modifierName.substr(0, modifierName.find('_'))); toLowerCaseString(targetVocation); g_logger().debug("Checking supreme gem modifier: {}, targetVocation: {}", modifierName, targetVocation); if (targetVocation == "general" || targetVocation.find(vocationName) != std::string::npos) { - m_supremeGemModifiers.push_back(value); + m_supremeGemModifiers.emplace_back(value); } } return m_supremeGemModifiers; } + +uint16_t Vocation::getWheelGemId(WheelGemQuality_t quality) { + if (!wheelGems.contains(quality)) { + return 0; + } + const auto &gemName = wheelGems[quality]; + return Item::items.getItemIdByName(gemName); +} diff --git a/src/creatures/players/vocations/vocation.hpp b/src/creatures/players/vocations/vocation.hpp index 6bd8d9a2ebc..07127af6fec 100644 --- a/src/creatures/players/vocations/vocation.hpp +++ b/src/creatures/players/vocations/vocation.hpp @@ -9,9 +9,7 @@ #pragma once -#include "declarations.hpp" -#include "items/item.hpp" -#include "lib/di/container.hpp" +#include "creatures/creatures_definitions.hpp" enum class WheelGemQuality_t : uint8_t; enum class WheelGemSupremeModifier_t : uint8_t; @@ -58,37 +56,25 @@ class Vocation { return gainCap; } - uint32_t getManaGainTicks() const { - return gainManaTicks / g_configManager().getFloat(RATE_MANA_REGEN_SPEED); - } + uint32_t getManaGainTicks() const; - uint32_t getManaGainAmount() const { - return gainManaAmount * g_configManager().getFloat(RATE_MANA_REGEN); - } + uint32_t getManaGainAmount() const; - uint32_t getHealthGainTicks() const { - return gainHealthTicks / g_configManager().getFloat(RATE_HEALTH_REGEN_SPEED); - } + uint32_t getHealthGainTicks() const; - uint32_t getHealthGainAmount() const { - return gainHealthAmount * g_configManager().getFloat(RATE_HEALTH_REGEN); - } + uint32_t getHealthGainAmount() const; uint8_t getSoulMax() const { return soulMax; } - uint32_t getSoulGainTicks() const { - return gainSoulTicks / g_configManager().getFloat(RATE_SOUL_REGEN_SPEED); - } + uint32_t getSoulGainTicks() const; uint32_t getBaseAttackSpeed() const { return attackSpeed; } - uint32_t getAttackSpeed() const { - return attackSpeed / g_configManager().getFloat(RATE_ATTACK_SPEED); - } + uint32_t getAttackSpeed() const; uint32_t getBaseSpeed() const { return baseSpeed; @@ -119,13 +105,7 @@ class Vocation { std::vector<WheelGemSupremeModifier_t> getSupremeGemModifiers(); - uint16_t getWheelGemId(WheelGemQuality_t quality) { - if (!wheelGems.contains(quality)) { - return 0; - } - const auto &name = wheelGems[quality]; - return Item::items.getItemIdByName(name); - } + uint16_t getWheelGemId(WheelGemQuality_t quality); private: friend class Vocations; @@ -176,9 +156,7 @@ class Vocations { Vocations(const Vocations &) = delete; void operator=(const Vocations &) = delete; - static Vocations &getInstance() { - return inject<Vocations>(); - } + static Vocations &getInstance(); bool loadFromXml(); bool reload(); diff --git a/src/creatures/players/wheel/player_wheel.cpp b/src/creatures/players/wheel/player_wheel.cpp index b577e998651..344bde5f03b 100644 --- a/src/creatures/players/wheel/player_wheel.cpp +++ b/src/creatures/players/wheel/player_wheel.cpp @@ -317,7 +317,7 @@ PlayerWheel::PlayerWheel(Player &initPlayer) : } bool PlayerWheel::canPlayerSelectPointOnSlot(WheelSlots_t slot, bool recursive) const { - auto playerPoints = getWheelPoints(); + const auto playerPoints = getWheelPoints(); // Green quadrant if (slot == WheelSlots_t::SLOT_GREEN_200) { if (playerPoints < 375u) { @@ -883,19 +883,22 @@ uint16_t PlayerWheel::getUnusedPoints() const { } bool PlayerWheel::getSpellAdditionalArea(const std::string &spellName) const { - auto stage = static_cast<uint8_t>(getSpellUpgrade(spellName)); + const auto stage = static_cast<uint8_t>(getSpellUpgrade(spellName)); if (stage == 0) { return false; } - auto vocationEnum = m_player.getPlayerVocationEnum(); + const auto vocationEnum = m_player.getPlayerVocationEnum(); if (vocationEnum == Vocation_t::VOCATION_KNIGHT_CIP) { return checkSpellArea(g_game().getIOWheel()->getWheelBonusData().spells.knight, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_PALADIN_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_PALADIN_CIP) { return checkSpellArea(g_game().getIOWheel()->getWheelBonusData().spells.paladin, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_DRUID_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_DRUID_CIP) { return checkSpellArea(g_game().getIOWheel()->getWheelBonusData().spells.druid, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_SORCERER_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_SORCERER_CIP) { return checkSpellArea(g_game().getIOWheel()->getWheelBonusData().spells.sorcerer, spellName, stage); } @@ -903,19 +906,22 @@ bool PlayerWheel::getSpellAdditionalArea(const std::string &spellName) const { } int PlayerWheel::getSpellAdditionalTarget(const std::string &spellName) const { - auto stage = static_cast<uint8_t>(getSpellUpgrade(spellName)); + const auto stage = static_cast<uint8_t>(getSpellUpgrade(spellName)); if (stage == 0) { return 0; } - auto vocationEnum = m_player.getPlayerVocationEnum(); + const auto vocationEnum = m_player.getPlayerVocationEnum(); if (vocationEnum == Vocation_t::VOCATION_KNIGHT_CIP) { return checkSpellAdditionalTarget(g_game().getIOWheel()->getWheelBonusData().spells.knight, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_PALADIN_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_PALADIN_CIP) { return checkSpellAdditionalTarget(g_game().getIOWheel()->getWheelBonusData().spells.paladin, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_DRUID_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_DRUID_CIP) { return checkSpellAdditionalTarget(g_game().getIOWheel()->getWheelBonusData().spells.druid, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_SORCERER_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_SORCERER_CIP) { return checkSpellAdditionalTarget(g_game().getIOWheel()->getWheelBonusData().spells.sorcerer, spellName, stage); } @@ -923,19 +929,22 @@ int PlayerWheel::getSpellAdditionalTarget(const std::string &spellName) const { } int PlayerWheel::getSpellAdditionalDuration(const std::string &spellName) const { - auto stage = static_cast<uint8_t>(getSpellUpgrade(spellName)); + const auto stage = static_cast<uint8_t>(getSpellUpgrade(spellName)); if (stage == 0) { return 0; } - auto vocationEnum = m_player.getPlayerVocationEnum(); + const auto vocationEnum = m_player.getPlayerVocationEnum(); if (vocationEnum == Vocation_t::VOCATION_KNIGHT_CIP) { return checkSpellAdditionalDuration(g_game().getIOWheel()->getWheelBonusData().spells.knight, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_PALADIN_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_PALADIN_CIP) { return checkSpellAdditionalDuration(g_game().getIOWheel()->getWheelBonusData().spells.paladin, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_DRUID_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_DRUID_CIP) { return checkSpellAdditionalDuration(g_game().getIOWheel()->getWheelBonusData().spells.druid, spellName, stage); - } else if (vocationEnum == Vocation_t::VOCATION_SORCERER_CIP) { + } + if (vocationEnum == Vocation_t::VOCATION_SORCERER_CIP) { return checkSpellAdditionalDuration(g_game().getIOWheel()->getWheelBonusData().spells.sorcerer, spellName, stage); } @@ -945,15 +954,15 @@ int PlayerWheel::getSpellAdditionalDuration(const std::string &spellName) const void PlayerWheel::addPromotionScrolls(NetworkMessage &msg) const { std::vector<uint16_t> unlockedScrolls; - for (const auto &scroll : WheelOfDestinyPromotionScrolls) { + for (const auto &[itemId, name, extraPoints] : WheelOfDestinyPromotionScrolls) { const auto &scrollKv = m_player.kv()->scoped("wheel-of-destiny")->scoped("scrolls"); if (!scrollKv) { continue; } - auto scrollOpt = scrollKv->get(scroll.name); + const auto scrollOpt = scrollKv->get(name); if (scrollOpt && scrollOpt->get<bool>()) { - unlockedScrolls.push_back(scroll.itemId); + unlockedScrolls.emplace_back(itemId); } } @@ -983,14 +992,14 @@ uint8_t PlayerWheel::getGemGrade(WheelFragmentType_t type, uint8_t pos) const { std::vector<PlayerWheelGem> PlayerWheel::getRevealedGems() const { std::vector<PlayerWheelGem> unlockedGems; - auto unlockedGemUUIDs = gemsKV()->scoped("revealed")->keys(); + const auto unlockedGemUUIDs = gemsKV()->scoped("revealed")->keys(); if (unlockedGemUUIDs.empty()) { return unlockedGems; } std::vector<std::string> sortedUnlockedGemGUIDs; for (const auto &uuid : unlockedGemUUIDs) { - sortedUnlockedGemGUIDs.push_back(uuid); + sortedUnlockedGemGUIDs.emplace_back(uuid); } std::sort(sortedUnlockedGemGUIDs.begin(), sortedUnlockedGemGUIDs.end(), [](const std::string &a, const std::string &b) { @@ -1006,14 +1015,14 @@ std::vector<PlayerWheelGem> PlayerWheel::getRevealedGems() const { if (gem.uuid.empty()) { continue; } - unlockedGems.push_back(gem); + unlockedGems.emplace_back(gem); } return unlockedGems; } std::vector<PlayerWheelGem> PlayerWheel::getActiveGems() const { std::vector<PlayerWheelGem> activeGems; - for (auto affinity : magic_enum::enum_values<WheelGemAffinity_t>()) { + for (const auto &affinity : magic_enum::enum_values<WheelGemAffinity_t>()) { std::string key(magic_enum::enum_name(affinity)); auto uuidKV = gemsKV()->scoped("active")->get(key); if (!uuidKV.has_value()) { @@ -1028,7 +1037,7 @@ std::vector<PlayerWheelGem> PlayerWheel::getActiveGems() const { if (gem.uuid.empty()) { continue; } - activeGems.push_back(gem); + activeGems.emplace_back(gem); } return activeGems; } @@ -1069,7 +1078,7 @@ uint64_t PlayerWheel::getGemRevealCost(WheelGemQuality_t quality) { return static_cast<uint64_t>(g_configManager().getNumber(key)); } -void PlayerWheel::revealGem(WheelGemQuality_t quality) { +void PlayerWheel::revealGem(WheelGemQuality_t quality) const { uint16_t gemId = m_player.getVocation()->getWheelGemId(quality); if (gemId == 0) { g_logger().error("[{}] Failed to get gem id for quality {} and vocation {}", __FUNCTION__, fmt::underlying(quality), m_player.getVocation()->getVocName()); @@ -1088,7 +1097,7 @@ void PlayerWheel::revealGem(WheelGemQuality_t quality) { g_logger().error("[{}] Failed to remove gem with id {} from player with name {}", __FUNCTION__, gemId, m_player.getName()); return; } - auto supremeModifiers = m_player.getVocation()->getSupremeGemModifiers(); + const auto supremeModifiers = m_player.getVocation()->getSupremeGemModifiers(); PlayerWheelGem gem; gem.uuid = KV::generateUUID(); gem.locked = false; @@ -1127,7 +1136,7 @@ PlayerWheelGem PlayerWheel::getGem(const std::string &uuid) const { } uint16_t PlayerWheel::getGemIndex(const std::string &uuid) const { - auto gems = getRevealedGems(); + const auto gems = getRevealedGems(); for (uint16_t i = 0; i < gems.size(); ++i) { if (gems[i].uuid == uuid) { return i; @@ -1137,8 +1146,8 @@ uint16_t PlayerWheel::getGemIndex(const std::string &uuid) const { return 0xFF; } -void PlayerWheel::destroyGem(uint16_t index) { - auto gem = getGem(index); +void PlayerWheel::destroyGem(uint16_t index) const { + const auto gem = getGem(index); if (gem.locked) { g_logger().error("[{}] Player {} destroyed locked gem with index {}", std::source_location::current().function_name(), m_player.getName(), index); return; @@ -1192,7 +1201,7 @@ void PlayerWheel::destroyGem(uint16_t index) { sendOpenWheelWindow(m_player.getID()); } -void PlayerWheel::switchGemDomain(uint16_t index) { +void PlayerWheel::switchGemDomain(uint16_t index) const { auto gem = getGem(index); if (gem.locked) { g_logger().error("[{}] Player {} trying to destroy locked gem with index {}", __FUNCTION__, m_player.getName(), index); @@ -1210,15 +1219,15 @@ void PlayerWheel::switchGemDomain(uint16_t index) { sendOpenWheelWindow(m_player.getID()); } -void PlayerWheel::toggleGemLock(uint16_t index) { +void PlayerWheel::toggleGemLock(uint16_t index) const { auto gem = getGem(index); gem.locked = !gem.locked; gem.save(gemsKV()); sendOpenWheelWindow(m_player.getID()); } -void PlayerWheel::setActiveGem(WheelGemAffinity_t affinity, uint16_t index) { - auto gem = getGem(index); +void PlayerWheel::setActiveGem(WheelGemAffinity_t affinity, uint16_t index) const { + const auto gem = getGem(index); if (gem.uuid.empty()) { g_logger().error("[{}] Failed to load gem with index {}", __FUNCTION__, index); return; @@ -1227,17 +1236,17 @@ void PlayerWheel::setActiveGem(WheelGemAffinity_t affinity, uint16_t index) { g_logger().error("[{}] Gem with index {} has affinity {} but trying to set it to {}", __FUNCTION__, index, fmt::underlying(gem.affinity), fmt::underlying(affinity)); return; } - std::string key(magic_enum::enum_name(affinity)); + const std::string key(magic_enum::enum_name(affinity)); gemsKV()->scoped("active")->set(key, gem.uuid); } -void PlayerWheel::removeActiveGem(WheelGemAffinity_t affinity) { - std::string key(magic_enum::enum_name(affinity)); +void PlayerWheel::removeActiveGem(WheelGemAffinity_t affinity) const { + const std::string key(magic_enum::enum_name(affinity)); gemsKV()->scoped("active")->remove(key); } void PlayerWheel::addGems(NetworkMessage &msg) const { - auto activeGems = getActiveGems(); + const auto activeGems = getActiveGems(); msg.addByte(activeGems.size()); g_logger().debug("[{}] Player {} has {} active gems", __FUNCTION__, m_player.getName(), activeGems.size()); for (const auto &gem : activeGems) { @@ -1246,7 +1255,7 @@ void PlayerWheel::addGems(NetworkMessage &msg) const { msg.add<uint16_t>(getGemIndex(gem.uuid)); } - auto revealedGems = getRevealedGems(); + const auto revealedGems = getRevealedGems(); msg.add<uint16_t>(revealedGems.size()); uint16_t index = 0; for (const auto &gem : revealedGems) { @@ -1380,8 +1389,7 @@ void PlayerWheel::sendOpenWheelWindow(NetworkMessage &msg, uint32_t ownerId) { } msg.addByte(0x5F); - bool canUse = canOpenWheel(); - + const bool canUse = canOpenWheel(); msg.add<uint32_t>(ownerId); // Player ID msg.addByte(canUse ? 1 : 0); // Can Use if (!canUse) { @@ -1401,7 +1409,12 @@ void PlayerWheel::sendOpenWheelWindow(NetworkMessage &msg, uint32_t ownerId) { addGems(msg); addGradeModifiers(msg); // TODO: read items from inventory - auto voc = m_player.getVocation(); + const auto &voc = m_player.getVocation(); + if (!voc) { + g_logger().error("[{}] Failed to get vocation for player {}", __FUNCTION__, m_player.getName()); + return; + } + m_player.client->sendResourceBalance(RESOURCE_BANK, m_player.getBankBalance()); m_player.client->sendResourceBalance(RESOURCE_INVENTORY_MONEY, m_player.getMoney()); m_player.client->sendResourceBalance(RESOURCE_LESSER_GEMS, m_player.getItemTypeCount(voc->getWheelGemId(WheelGemQuality_t::Lesser))); @@ -1440,7 +1453,7 @@ bool PlayerWheel::checkSavePointsBySlotType(WheelSlots_t slotType, uint16_t poin setPointsBySlotType(static_cast<uint8_t>(slotType), 0); - auto unusedPoints = getUnusedPoints(); + const auto unusedPoints = getUnusedPoints(); if (points > unusedPoints) { return false; } @@ -1452,7 +1465,7 @@ bool PlayerWheel::checkSavePointsBySlotType(WheelSlots_t slotType, uint16_t poin void PlayerWheel::saveSlotPointsHandleRetryErrors(std::vector<SlotInfo> &retryTable, int &errors) { std::vector<SlotInfo> temporaryTable; for (const auto &data : retryTable) { - auto saved = checkSavePointsBySlotType(static_cast<WheelSlots_t>(data.slot), data.points); + const auto saved = checkSavePointsBySlotType(static_cast<WheelSlots_t>(data.slot), data.points); if (saved) { errors--; } else { @@ -1486,13 +1499,13 @@ void PlayerWheel::saveSlotPointsOnPressSaveButton(NetworkMessage &msg) { return; } - auto order = g_game().getIOWheel()->getSlotPrioritaryOrder(static_cast<WheelSlots_t>(slot)); + const auto order = g_game().getIOWheel()->getSlotPrioritaryOrder(static_cast<WheelSlots_t>(slot)); if (order == -1) { continue; } // The slot information is then added to the vector in order. - sortedTable.push_back({ order, slot, slotPoints }); + sortedTable.emplace_back(order, slot, slotPoints); } // After iterating over all slots, the vector is sorted according to the slot order. @@ -1505,7 +1518,7 @@ void PlayerWheel::saveSlotPointsOnPressSaveButton(NetworkMessage &msg) { // Processes the vector in the correct order. If it is not possible to save points for a slot, for (const auto &data : sortedTable) { - auto canSave = checkSavePointsBySlotType(static_cast<WheelSlots_t>(data.slot), data.points); + const auto canSave = checkSavePointsBySlotType(static_cast<WheelSlots_t>(data.slot), data.points); if (!canSave) { sortedTableRetry.emplace_back(data); errors++; @@ -1529,13 +1542,13 @@ void PlayerWheel::saveSlotPointsOnPressSaveButton(NetworkMessage &msg) { } // Gem Vessels - for (auto affinity : magic_enum::enum_values<WheelGemAffinity_t>()) { - bool hasGem = msg.getByte(); + for (const auto &affinity : magic_enum::enum_values<WheelGemAffinity_t>()) { + const bool hasGem = msg.getByte(); if (!hasGem) { removeActiveGem(affinity); continue; } - uint16_t gemIndex = msg.get<uint16_t>(); + const auto gemIndex = msg.get<uint16_t>(); setActiveGem(affinity, gemIndex); } @@ -1557,7 +1570,7 @@ void PlayerWheel::loadDBPlayerSlotPointsOnLogin() { } unsigned long size; - auto attribute = result->getStream("slot", size); + const auto attribute = result->getStream("slot", size); PropStream propStream; propStream.init(attribute, size); for (size_t i = 0; i < size; i++) { @@ -1571,7 +1584,7 @@ void PlayerWheel::loadDBPlayerSlotPointsOnLogin() { } bool PlayerWheel::saveDBPlayerSlotPointsOnLogout() const { - Database &db = Database::getInstance(); + const Database &db = Database::getInstance(); std::ostringstream query; DBInsert insertWheelData("INSERT INTO `player_wheeldata` (`player_id`, `slot`) VALUES "); insertWheelData.upsert({ "slot" }); @@ -1591,7 +1604,7 @@ bool PlayerWheel::saveDBPlayerSlotPointsOnLogout() const { size_t attributesSize; const char* attributes = stream.getStream(attributesSize); if (attributesSize > 0) { - query << m_player.getGUID() << ',' << db.escapeBlob(attributes, (uint32_t)attributesSize); + query << m_player.getGUID() << ',' << db.escapeBlob(attributes, static_cast<uint32_t>(attributesSize)); if (!insertWheelData.addRow(query)) { g_logger().debug("[{}] failed to insert row data", __FUNCTION__); return false; @@ -1613,15 +1626,19 @@ uint16_t PlayerWheel::getExtraPoints() const { } uint16_t totalBonus = 0; - for (const auto &scroll : WheelOfDestinyPromotionScrolls) { + for (const auto &[itemId, name, extraPoints] : WheelOfDestinyPromotionScrolls) { + if (itemId == 0) { + continue; + } + const auto &scrollKv = m_player.kv()->scoped("wheel-of-destiny")->scoped("scrolls"); if (!scrollKv) { continue; } - auto scrollKV = scrollKv->get(scroll.name); + const auto scrollKV = scrollKv->get(name); if (scrollKV && scrollKV->get<bool>()) { - totalBonus += scroll.extraPoints; + totalBonus += extraPoints; } } @@ -1629,7 +1646,7 @@ uint16_t PlayerWheel::getExtraPoints() const { } uint16_t PlayerWheel::getWheelPoints(bool includeExtraPoints /* = true*/) const { - uint32_t level = m_player.getLevel(); + const uint32_t level = m_player.getLevel(); auto totalPoints = std::max(0u, (level - m_minLevelToStartCountPoints)) * m_pointsPerLevel; if (includeExtraPoints) { @@ -1703,7 +1720,7 @@ uint8_t PlayerWheel::getOptions(uint32_t ownerId) const { // Check if is in the temple range (we assume the temple is within the range of 10 sqms) if (m_player.getZoneType() == ZONE_PROTECTION) { - for (auto [townid, town] : g_game().map.towns.getTowns()) { + for (const auto &[townid, town] : g_game().map.towns.getTowns()) { if (Position::areInRange<1, 10>(town->getTemplePosition(), m_player.getPosition())) { return 1; } @@ -1780,7 +1797,7 @@ void PlayerWheel::setPlayerCombatStats(CombatType_t type, int32_t leechAmount) { } } -void PlayerWheel::reloadPlayerData() { +void PlayerWheel::reloadPlayerData() const { // Maybe it's not really necessary, but it doesn't hurt to validate if (!m_player.getTile()) { return; @@ -2041,12 +2058,12 @@ void PlayerWheel::printPlayerWheelMethodsBonusData(const PlayerWheelMethodsBonus g_logger().debug("Vessel Resonance:"); for (size_t i = 0; i < bonusData.unlockedVesselResonances.size(); ++i) { - auto count = bonusData.unlockedVesselResonances[i]; + const auto count = bonusData.unlockedVesselResonances[i]; if (count == 0) { continue; } - WheelGemAffinity_t affinity = static_cast<WheelGemAffinity_t>(i); + const auto affinity = static_cast<WheelGemAffinity_t>(i); std::string affinityName(magic_enum::enum_name(affinity)); g_logger().debug(" Affinity: {} count: {}", affinityName, bonusData.unlockedVesselResonances[i]); } @@ -2158,13 +2175,13 @@ void PlayerWheel::printPlayerWheelMethodsBonusData(const PlayerWheelMethodsBonus void PlayerWheel::loadDedicationAndConvictionPerks() { using VocationBonusFunction = std::function<void(const std::shared_ptr<Player> &, uint16_t, uint8_t, PlayerWheelMethodsBonusData &)>; auto wheelFunctions = g_game().getIOWheel()->getWheelMapFunctions(); - auto vocationCipId = m_player.getPlayerVocationEnum(); + const auto vocationCipId = m_player.getPlayerVocationEnum(); if (vocationCipId < VOCATION_KNIGHT_CIP || vocationCipId > VOCATION_DRUID_CIP) { return; } for (uint8_t i = WheelSlots_t::SLOT_FIRST; i <= WheelSlots_t::SLOT_LAST; ++i) { - uint16_t points = getPointsBySlotType(static_cast<WheelSlots_t>(i)); + const uint16_t points = getPointsBySlotType(static_cast<WheelSlots_t>(i)); if (points > 0) { VocationBonusFunction internalData = nullptr; auto it = wheelFunctions.find(static_cast<WheelSlots_t>(i)); @@ -2331,7 +2348,7 @@ void PlayerWheel::applyBlueStageBonus(uint8_t stageValue, Vocation_t vocationEnu WheelStageEnum_t PlayerWheel::getPlayerSliceStage(const std::string &color) const { std::vector<WheelSlots_t> slots; - WheelGemAffinity_t affinity = WheelGemAffinity_t::Green; + auto affinity = WheelGemAffinity_t::Green; if (color == "green") { affinity = WheelGemAffinity_t::Green; slots = { @@ -2423,9 +2440,11 @@ WheelStageEnum_t PlayerWheel::getPlayerSliceStage(const std::string &color) cons if (totalPoints >= static_cast<int>(WheelStagePointsEnum_t::THREE)) { return WheelStageEnum_t::THREE; - } else if (totalPoints >= static_cast<int>(WheelStagePointsEnum_t::TWO)) { + } + if (totalPoints >= static_cast<int>(WheelStagePointsEnum_t::TWO)) { return WheelStageEnum_t::TWO; - } else if (totalPoints >= static_cast<uint8_t>(WheelStagePointsEnum_t::ONE)) { + } + if (totalPoints >= static_cast<uint8_t>(WheelStagePointsEnum_t::ONE)) { return WheelStageEnum_t::ONE; } @@ -2472,12 +2491,12 @@ bool PlayerWheel::checkBattleInstinct() { m_player.getPosition().y + offsetY, m_player.getPosition().z ); - std::shared_ptr<Tile> tile = g_game().map.getTile(playerPositionOffSet); + const auto &tile = g_game().map.getTile(playerPositionOffSet); if (!tile) { continue; } - std::shared_ptr<Creature> creature = tile->getTopVisibleCreature(m_player.getPlayer()); + const auto &creature = tile->getTopVisibleCreature(m_player.getPlayer()); if (!creature || creature == m_player.getPlayer() || (creature->getMaster() && creature->getMaster()->getPlayer() == m_player.getPlayer())) { continue; } @@ -2489,8 +2508,8 @@ bool PlayerWheel::checkBattleInstinct() { if (creaturesNearby >= 5) { m_creaturesNearby = creaturesNearby; creaturesNearby -= 4; - uint16_t meleeSkill = 1 * creaturesNearby; - uint16_t shieldSkill = 6 * creaturesNearby; + const uint16_t meleeSkill = 1 * creaturesNearby; + const uint16_t shieldSkill = 6 * creaturesNearby; if (getMajorStat(WheelMajor_t::MELEE) != meleeSkill || getMajorStat(WheelMajor_t::SHIELD) != shieldSkill) { setMajorStat(WheelMajor_t::MELEE, meleeSkill); setMajorStat(WheelMajor_t::SHIELD, shieldSkill); @@ -2520,12 +2539,12 @@ bool PlayerWheel::checkPositionalTatics() { m_player.getPosition().y + offsetY, m_player.getPosition().z ); - std::shared_ptr<Tile> tile = g_game().map.getTile(playerPositionOffSet); + const auto &tile = g_game().map.getTile(playerPositionOffSet); if (!tile) { continue; } - std::shared_ptr<Creature> creature = tile->getTopVisibleCreature(m_player.getPlayer()); + const auto &creature = tile->getTopVisibleCreature(m_player.getPlayer()); if (!creature || creature == m_player.getPlayer() || !creature->getMonster() || (creature->getMaster() && creature->getMaster()->getPlayer())) { continue; } @@ -2534,8 +2553,8 @@ bool PlayerWheel::checkPositionalTatics() { break; } } - uint16_t magicSkill = 3; - uint16_t distanceSkill = 3; + constexpr uint16_t magicSkill = 3; + constexpr uint16_t distanceSkill = 3; if (creaturesNearby == 0) { m_creaturesNearby = creaturesNearby; if (getMajorStat(WheelMajor_t::DISTANCE) != distanceSkill) { @@ -2563,11 +2582,11 @@ bool PlayerWheel::checkPositionalTatics() { bool PlayerWheel::checkBallisticMastery() { setOnThinkTimer(WheelOnThink_t::BALLISTIC_MASTERY, OTSYS_TIME() + 2000); bool updateClient = false; - int32_t newCritical = 1000; - uint16_t newHolyBonus = 2; // 2% - uint16_t newPhysicalBonus = 2; // 2% + constexpr int32_t newCritical = 1000; + constexpr uint16_t newHolyBonus = 2; // 2% + constexpr uint16_t newPhysicalBonus = 2; // 2% - std::shared_ptr<Item> item = m_player.getWeapon(); + const auto &item = m_player.getWeapon(); if (item && item->getAmmoType() == AMMO_BOLT) { if (getMajorStat(WheelMajor_t::CRITICAL_DMG) != newCritical) { setMajorStat(WheelMajor_t::CRITICAL_DMG, newCritical); @@ -2606,9 +2625,9 @@ bool PlayerWheel::checkBallisticMastery() { bool PlayerWheel::checkCombatMastery() { setOnThinkTimer(WheelOnThink_t::COMBAT_MASTERY, OTSYS_TIME() + 2000); bool updateClient = false; - uint8_t stage = getStage(WheelStage_t::COMBAT_MASTERY); + const uint8_t stage = getStage(WheelStage_t::COMBAT_MASTERY); - std::shared_ptr<Item> item = m_player.getWeapon(); + const auto &item = m_player.getWeapon(); if (item && item->getSlotPosition() & SLOTP_TWO_HAND) { int32_t criticalSkill = 0; if (stage >= 3) { @@ -2653,12 +2672,12 @@ bool PlayerWheel::checkDivineEmpowerment() { bool updateClient = false; setOnThinkTimer(WheelOnThink_t::DIVINE_EMPOWERMENT, OTSYS_TIME() + 1000); - const auto tile = m_player.getTile(); + const auto &tile = m_player.getTile(); if (!tile) { return updateClient; } - const auto items = tile->getItemList(); + const auto &items = tile->getItemList(); if (!items) { return updateClient; } @@ -2673,7 +2692,7 @@ bool PlayerWheel::checkDivineEmpowerment() { } if (isOwner) { - uint8_t stage = getStage(WheelStage_t::DIVINE_EMPOWERMENT); + const uint8_t stage = getStage(WheelStage_t::DIVINE_EMPOWERMENT); if (stage >= 3) { damageBonus = 7; } else if (stage >= 2) { @@ -2691,13 +2710,13 @@ bool PlayerWheel::checkDivineEmpowerment() { return updateClient; } -int32_t PlayerWheel::checkDivineGrenade(std::shared_ptr<Creature> target) const { +int32_t PlayerWheel::checkDivineGrenade(const std::shared_ptr<Creature> &target) const { if (!target || target == m_player.getPlayer()) { return 0; } int32_t damageBonus = 0; - uint8_t stage = getStage(WheelStage_t::DIVINE_GRENADE); + const uint8_t stage = getStage(WheelStage_t::DIVINE_GRENADE); if (stage >= 3) { damageBonus = 100; @@ -2719,7 +2738,7 @@ void PlayerWheel::checkGiftOfLife() { g_game().addMagicEffect(m_player.getPosition(), CONST_ME_WATER_DROP); g_game().combatChangeHealth(m_player.getPlayer(), m_player.getPlayer(), giftDamage); // Condition cooldown reduction - uint16_t reductionTimer = 60000; + constexpr uint16_t reductionTimer = 60000; reduceAllSpellsCooldownTimer(reductionTimer); // Set cooldown @@ -2727,14 +2746,14 @@ void PlayerWheel::checkGiftOfLife() { sendGiftOfLifeCooldown(); } -int32_t PlayerWheel::checkBlessingGroveHealingByTarget(std::shared_ptr<Creature> target) const { +int32_t PlayerWheel::checkBlessingGroveHealingByTarget(const std::shared_ptr<Creature> &target) const { if (!target || target == m_player.getPlayer()) { return 0; } int32_t healingBonus = 0; - uint8_t stage = getStage(WheelStage_t::BLESSING_OF_THE_GROVE); - int32_t healthPercent = std::round((static_cast<double>(target->getHealth()) * 100) / static_cast<double>(target->getMaxHealth())); + const uint8_t stage = getStage(WheelStage_t::BLESSING_OF_THE_GROVE); + const int32_t healthPercent = std::round((static_cast<double>(target->getHealth()) * 100) / static_cast<double>(target->getMaxHealth())); if (healthPercent <= 30) { if (stage >= 3) { healingBonus = 24; @@ -2756,14 +2775,14 @@ int32_t PlayerWheel::checkBlessingGroveHealingByTarget(std::shared_ptr<Creature> return healingBonus; } -int32_t PlayerWheel::checkTwinBurstByTarget(std::shared_ptr<Creature> target) const { +int32_t PlayerWheel::checkTwinBurstByTarget(const std::shared_ptr<Creature> &target) const { if (!target || target == m_player.getPlayer()) { return 0; } int32_t damageBonus = 0; - uint8_t stage = getStage(WheelStage_t::TWIN_BURST); - int32_t healthPercent = std::round((static_cast<double>(target->getHealth()) * 100) / static_cast<double>(target->getMaxHealth())); + const uint8_t stage = getStage(WheelStage_t::TWIN_BURST); + const int32_t healthPercent = std::round((static_cast<double>(target->getHealth()) * 100) / static_cast<double>(target->getMaxHealth())); if (healthPercent > 60) { if (stage >= 3) { damageBonus = 60; @@ -2777,14 +2796,14 @@ int32_t PlayerWheel::checkTwinBurstByTarget(std::shared_ptr<Creature> target) co return damageBonus; } -int32_t PlayerWheel::checkExecutionersThrow(std::shared_ptr<Creature> target) const { +int32_t PlayerWheel::checkExecutionersThrow(const std::shared_ptr<Creature> &target) const { if (!target || target == m_player.getPlayer()) { return 0; } int32_t damageBonus = 0; - uint8_t stage = getStage(WheelStage_t::EXECUTIONERS_THROW); - int32_t healthPercent = std::round((static_cast<double>(target->getHealth()) * 100) / static_cast<double>(target->getMaxHealth())); + const uint8_t stage = getStage(WheelStage_t::EXECUTIONERS_THROW); + const int32_t healthPercent = std::round((static_cast<double>(target->getHealth()) * 100) / static_cast<double>(target->getMaxHealth())); if (healthPercent <= 30) { if (stage >= 3) { damageBonus = 150; @@ -2800,7 +2819,7 @@ int32_t PlayerWheel::checkExecutionersThrow(std::shared_ptr<Creature> target) co int32_t PlayerWheel::checkBeamMasteryDamage() const { int32_t damageBoost = 0; - uint8_t stage = getStage(WheelStage_t::BEAM_MASTERY); + const uint8_t stage = getStage(WheelStage_t::BEAM_MASTERY); if (stage >= 3) { damageBoost = 14; } else if (stage >= 2) { @@ -2812,12 +2831,12 @@ int32_t PlayerWheel::checkBeamMasteryDamage() const { return damageBoost; } -int32_t PlayerWheel::checkDrainBodyLeech(std::shared_ptr<Creature> target, skills_t skill) const { +int32_t PlayerWheel::checkDrainBodyLeech(const std::shared_ptr<Creature> &target, skills_t skill) const { if (!target || !target->getMonster() || target->getWheelOfDestinyDrainBodyDebuff() == 0) { return 0; } - uint8_t stage = target->getWheelOfDestinyDrainBodyDebuff(); + const uint8_t stage = target->getWheelOfDestinyDrainBodyDebuff(); if (target->getBuff(BUFF_DAMAGERECEIVED) > 100 && skill == SKILL_MANA_LEECH_AMOUNT) { int32_t manaLeechSkill = 0; if (stage >= 3) { @@ -2846,14 +2865,14 @@ int32_t PlayerWheel::checkDrainBodyLeech(std::shared_ptr<Creature> target, skill } int32_t PlayerWheel::checkBattleHealingAmount() const { - double amount = (double)m_player.getSkillLevel(SKILL_SHIELD) * 0.2; - uint8_t healthPercent = (m_player.getHealth() * 100) / m_player.getMaxHealth(); + double amount = static_cast<double>(m_player.getSkillLevel(SKILL_SHIELD)) * 0.2; + const uint8_t healthPercent = (m_player.getHealth() * 100) / m_player.getMaxHealth(); if (healthPercent <= 30) { amount *= 3; } else if (healthPercent <= 60) { amount *= 2; } - return (int32_t)amount; + return static_cast<int32_t>(amount); } int32_t PlayerWheel::checkAvatarSkill(WheelAvatarSkill_t skill) const { @@ -2881,9 +2900,11 @@ int32_t PlayerWheel::checkAvatarSkill(WheelAvatarSkill_t skill) const { if (skill == WheelAvatarSkill_t::DAMAGE_REDUCTION) { if (stage >= 3) { return 15; - } else if (stage >= 2) { + } + if (stage >= 2) { return 10; - } else if (stage >= 1) { + } + if (stage >= 1) { return 5; } } else if (skill == WheelAvatarSkill_t::CRITICAL_CHANCE) { @@ -2891,9 +2912,11 @@ int32_t PlayerWheel::checkAvatarSkill(WheelAvatarSkill_t skill) const { } else if (skill == WheelAvatarSkill_t::CRITICAL_DAMAGE) { if (stage >= 3) { return 1500; - } else if (stage >= 2) { + } + if (stage >= 2) { return 1000; - } else if (stage >= 1) { + } + if (stage >= 1) { return 500; } } @@ -2972,7 +2995,7 @@ void PlayerWheel::onThink(bool force /* = false*/) { } } -void PlayerWheel::reduceAllSpellsCooldownTimer(int32_t value) { +void PlayerWheel::reduceAllSpellsCooldownTimer(int32_t value) const { for (const auto &condition : m_player.getConditionsByType(CONDITION_SPELLCOOLDOWN)) { if (condition->getTicks() <= value) { m_player.sendSpellCooldown(condition->getSubId(), 0); @@ -2996,7 +3019,7 @@ void PlayerWheel::resetUpgradedSpells() { for (int i = 0; i < static_cast<int>(WheelMajor_t::TOTAL_COUNT); i++) { setMajorStat(static_cast<WheelMajor_t>(i), 0); } - for (int i = 0; i < static_cast<int>(WheelStage_t::TOTAL_COUNT); i++) { + for (int i = 0; i < static_cast<int>(WheelStage_t::STAGE_COUNT); i++) { setStage(static_cast<WheelStage_t>(i), 0); } setOnThinkTimer(WheelOnThink_t::FOCUS_MASTERY, 0); @@ -3028,7 +3051,7 @@ void PlayerWheel::downgradeSpell(const std::string &name) { std::shared_ptr<Spell> PlayerWheel::getCombatDataSpell(CombatDamage &damage) { std::shared_ptr<Spell> spell = nullptr; - WheelSpellGrade_t spellGrade = WheelSpellGrade_t::NONE; + auto spellGrade = WheelSpellGrade_t::NONE; if (!(damage.instantSpellName).empty()) { spellGrade = getSpellUpgrade(damage.instantSpellName); spell = g_spells().getInstantSpellByName(damage.instantSpellName); @@ -3264,47 +3287,68 @@ bool PlayerWheel::getInstant(WheelInstant_t type) const { return false; } -uint8_t PlayerWheel::getStage(const std::string name) const { +uint8_t PlayerWheel::getStage(std::string_view name) const { + using enum WheelInstant_t; + using enum WheelStage_t; if (name == "Battle Instinct") { - return PlayerWheel::getInstant(WheelInstant_t::BATTLE_INSTINCT); - } else if (name == "Battle Healing") { - return PlayerWheel::getInstant(WheelInstant_t::BATTLE_HEALING); - } else if (name == "Positional Tatics") { - return PlayerWheel::getInstant(WheelInstant_t::POSITIONAL_TATICS); - } else if (name == "Ballistic Mastery") { - return PlayerWheel::getInstant(WheelInstant_t::BALLISTIC_MASTERY); - } else if (name == "Healing Link") { - return PlayerWheel::getInstant(WheelInstant_t::HEALING_LINK); - } else if (name == "Runic Mastery") { - return PlayerWheel::getInstant(WheelInstant_t::RUNIC_MASTERY); - } else if (name == "Focus Mastery") { - return PlayerWheel::getInstant(WheelInstant_t::FOCUS_MASTERY); - } else if (name == "Beam Mastery") { - return PlayerWheel::getStage(WheelStage_t::BEAM_MASTERY); - } else if (name == "Combat Mastery") { - return PlayerWheel::getStage(WheelStage_t::COMBAT_MASTERY); - } else if (name == "Gift of Life") { - return PlayerWheel::getStage(WheelStage_t::GIFT_OF_LIFE); - } else if (name == "Blessing of the Grove") { - return PlayerWheel::getStage(WheelStage_t::BLESSING_OF_THE_GROVE); - } else if (name == "Drain Body") { - return PlayerWheel::getStage(WheelStage_t::DRAIN_BODY); - } else if (name == "Divine Empowerment") { - return PlayerWheel::getStage(WheelStage_t::DIVINE_EMPOWERMENT); - } else if (name == "Divine Grenade") { - return PlayerWheel::getStage(WheelStage_t::DIVINE_GRENADE); - } else if (name == "Twin Burst") { - return PlayerWheel::getStage(WheelStage_t::TWIN_BURST); - } else if (name == "Executioner's Throw") { - return PlayerWheel::getStage(WheelStage_t::EXECUTIONERS_THROW); - } else if (name == "Avatar of Light") { - return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_LIGHT); - } else if (name == "Avatar of Nature") { - return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_NATURE); - } else if (name == "Avatar of Steel") { - return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_STEEL); - } else if (name == "Avatar of Storm") { - return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_STORM); + return PlayerWheel::getInstant(BATTLE_INSTINCT); + } + if (name == "Battle Healing") { + return PlayerWheel::getInstant(BATTLE_HEALING); + } + if (name == "Positional Tatics") { + return PlayerWheel::getInstant(POSITIONAL_TATICS); + } + if (name == "Ballistic Mastery") { + return PlayerWheel::getInstant(BALLISTIC_MASTERY); + } + if (name == "Healing Link") { + return PlayerWheel::getInstant(HEALING_LINK); + } + if (name == "Runic Mastery") { + return PlayerWheel::getInstant(RUNIC_MASTERY); + } + if (name == "Focus Mastery") { + return PlayerWheel::getInstant(FOCUS_MASTERY); + } + if (name == "Beam Mastery") { + return PlayerWheel::getStage(BEAM_MASTERY); + } + if (name == "Combat Mastery") { + return PlayerWheel::getStage(COMBAT_MASTERY); + } + if (name == "Gift of Life") { + return PlayerWheel::getStage(GIFT_OF_LIFE); + } + if (name == "Blessing of the Grove") { + return PlayerWheel::getStage(BLESSING_OF_THE_GROVE); + } + if (name == "Drain Body") { + return PlayerWheel::getStage(DRAIN_BODY); + } + if (name == "Divine Empowerment") { + return PlayerWheel::getStage(DIVINE_EMPOWERMENT); + } + if (name == "Divine Grenade") { + return PlayerWheel::getStage(DIVINE_GRENADE); + } + if (name == "Twin Burst") { + return PlayerWheel::getStage(TWIN_BURST); + } + if (name == "Executioner's Throw") { + return PlayerWheel::getStage(EXECUTIONERS_THROW); + } + if (name == "Avatar of Light") { + return PlayerWheel::getStage(AVATAR_OF_LIGHT); + } + if (name == "Avatar of Nature") { + return PlayerWheel::getStage(AVATAR_OF_NATURE); + } + if (name == "Avatar of Steel") { + return PlayerWheel::getStage(AVATAR_OF_STEEL); + } + if (name == "Avatar of Storm") { + return PlayerWheel::getStage(AVATAR_OF_STORM); } return false; @@ -3388,46 +3432,66 @@ int64_t PlayerWheel::getOnThinkTimer(WheelOnThink_t type) const { return 0; } -bool PlayerWheel::getInstant(const std::string name) const { +bool PlayerWheel::getInstant(std::string_view name) const { + using enum WheelInstant_t; if (name == "Battle Instinct") { - return PlayerWheel::getInstant(WheelInstant_t::BATTLE_INSTINCT); - } else if (name == "Battle Healing") { - return PlayerWheel::getInstant(WheelInstant_t::BATTLE_HEALING); - } else if (name == "Positional Tatics") { - return PlayerWheel::getInstant(WheelInstant_t::POSITIONAL_TATICS); - } else if (name == "Ballistic Mastery") { - return PlayerWheel::getInstant(WheelInstant_t::BALLISTIC_MASTERY); - } else if (name == "Healing Link") { - return PlayerWheel::getInstant(WheelInstant_t::HEALING_LINK); - } else if (name == "Runic Mastery") { - return PlayerWheel::getInstant(WheelInstant_t::RUNIC_MASTERY); - } else if (name == "Focus Mastery") { - return PlayerWheel::getInstant(WheelInstant_t::FOCUS_MASTERY); - } else if (name == "Beam Mastery") { + return PlayerWheel::getInstant(BATTLE_INSTINCT); + } + if (name == "Battle Healing") { + return PlayerWheel::getInstant(BATTLE_HEALING); + } + if (name == "Positional Tatics") { + return PlayerWheel::getInstant(POSITIONAL_TATICS); + } + if (name == "Ballistic Mastery") { + return PlayerWheel::getInstant(BALLISTIC_MASTERY); + } + if (name == "Healing Link") { + return PlayerWheel::getInstant(HEALING_LINK); + } + if (name == "Runic Mastery") { + return PlayerWheel::getInstant(RUNIC_MASTERY); + } + if (name == "Focus Mastery") { + return PlayerWheel::getInstant(FOCUS_MASTERY); + } + if (name == "Beam Mastery") { return PlayerWheel::getStage(WheelStage_t::BEAM_MASTERY); - } else if (name == "Combat Mastery") { + } + if (name == "Combat Mastery") { return PlayerWheel::getStage(WheelStage_t::COMBAT_MASTERY); - } else if (name == "Gift of Life") { + } + if (name == "Gift of Life") { return PlayerWheel::getStage(WheelStage_t::GIFT_OF_LIFE); - } else if (name == "Blessing of the Grove") { + } + if (name == "Blessing of the Grove") { return PlayerWheel::getStage(WheelStage_t::BLESSING_OF_THE_GROVE); - } else if (name == "Drain Body") { + } + if (name == "Drain Body") { return PlayerWheel::getStage(WheelStage_t::DRAIN_BODY); - } else if (name == "Divine Empowerment") { + } + if (name == "Divine Empowerment") { return PlayerWheel::getStage(WheelStage_t::DIVINE_EMPOWERMENT); - } else if (name == "Divine Grenade") { + } + if (name == "Divine Grenade") { return PlayerWheel::getStage(WheelStage_t::DIVINE_GRENADE); - } else if (name == "Twin Burst") { + } + if (name == "Twin Burst") { return PlayerWheel::getStage(WheelStage_t::TWIN_BURST); - } else if (name == "Executioner's Throw") { + } + if (name == "Executioner's Throw") { return PlayerWheel::getStage(WheelStage_t::EXECUTIONERS_THROW); - } else if (name == "Avatar of Light") { + } + if (name == "Avatar of Light") { return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_LIGHT); - } else if (name == "Avatar of Nature") { + } + if (name == "Avatar of Nature") { return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_NATURE); - } else if (name == "Avatar of Steel") { + } + if (name == "Avatar of Steel") { return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_STEEL); - } else if (name == "Avatar of Storm") { + } + if (name == "Avatar of Storm") { return PlayerWheel::getStage(WheelStage_t::AVATAR_OF_STORM); } @@ -3438,9 +3502,11 @@ bool PlayerWheel::getInstant(const std::string name) const { uint32_t PlayerWheel::getGiftOfLifeTotalCooldown() const { if (getStage(WheelStage_t::GIFT_OF_LIFE) == 1) { return 1 * 60 * 60 * 30; - } else if (getStage(WheelStage_t::GIFT_OF_LIFE) == 2) { + } + if (getStage(WheelStage_t::GIFT_OF_LIFE) == 2) { return 1 * 60 * 60 * 20; - } else if (getStage(WheelStage_t::GIFT_OF_LIFE) == 3) { + } + if (getStage(WheelStage_t::GIFT_OF_LIFE) == 3) { return 1 * 60 * 60 * 10; } return 0; @@ -3449,9 +3515,11 @@ uint32_t PlayerWheel::getGiftOfLifeTotalCooldown() const { uint8_t PlayerWheel::getGiftOfLifeValue() const { if (getStage(WheelStage_t::GIFT_OF_LIFE) == 1) { return 20; - } else if (getStage(WheelStage_t::GIFT_OF_LIFE) == 2) { + } + if (getStage(WheelStage_t::GIFT_OF_LIFE) == 2) { return 25; - } else if (getStage(WheelStage_t::GIFT_OF_LIFE) == 3) { + } + if (getStage(WheelStage_t::GIFT_OF_LIFE) == 3) { return 30; } @@ -3459,7 +3527,7 @@ uint8_t PlayerWheel::getGiftOfLifeValue() const { } int32_t PlayerWheel::getGiftOfCooldown() const { - int32_t value = m_player.getStorageValue(STORAGEVALUE_GIFT_OF_LIFE_COOLDOWN_WOD); + const int32_t value = m_player.getStorageValue(STORAGEVALUE_GIFT_OF_LIFE_COOLDOWN_WOD); if (value <= 0) { return 0; } @@ -3474,7 +3542,7 @@ void PlayerWheel::setGiftOfCooldown(int32_t value, bool isOnThink) { } void PlayerWheel::decreaseGiftOfCooldown(int32_t value) { - int32_t cooldown = getGiftOfCooldown() - value; + const int32_t cooldown = getGiftOfCooldown() - value; if (cooldown <= 0) { setOnThinkTimer(WheelOnThink_t::GIFT_OF_LIFE, OTSYS_TIME() + 3600000); return; @@ -3549,7 +3617,7 @@ void PlayerWheel::healIfBattleHealingActive() const { } void PlayerWheel::adjustDamageBasedOnResistanceAndSkill(int32_t &damage, CombatType_t combatType) const { - int32_t wheelOfDestinyElementAbsorb = getResistance(combatType); + const int32_t wheelOfDestinyElementAbsorb = getResistance(combatType); if (wheelOfDestinyElementAbsorb > 0) { damage -= std::ceil((damage * wheelOfDestinyElementAbsorb) / 10000.); } @@ -3558,11 +3626,8 @@ void PlayerWheel::adjustDamageBasedOnResistanceAndSkill(int32_t &damage, CombatT } float PlayerWheel::calculateMitigation() const { - int32_t skill = m_player.getSkillLevel(SKILL_SHIELD); + const int32_t skill = m_player.getSkillLevel(SKILL_SHIELD); int32_t defenseValue = 0; - std::shared_ptr<Item> weapon = m_player.inventory[CONST_SLOT_LEFT]; - std::shared_ptr<Item> shield = m_player.inventory[CONST_SLOT_RIGHT]; - float fightFactor = 1.0f; float shieldFactor = 1.0f; float distanceFactor = 1.0f; @@ -3583,6 +3648,7 @@ float PlayerWheel::calculateMitigation() const { break; } + const auto &shield = m_player.inventory[CONST_SLOT_RIGHT]; if (shield) { if (shield->isSpellBook() || shield->isQuiver()) { distanceFactor = m_player.vocation->mitigationSecondaryShield; @@ -3596,6 +3662,7 @@ float PlayerWheel::calculateMitigation() const { } } + const auto &weapon = m_player.inventory[CONST_SLOT_LEFT]; if (weapon) { if (weapon->getAmmoType() == AMMO_BOLT || weapon->getAmmoType() == AMMO_ARROW) { distanceFactor = m_player.vocation->mitigationSecondaryShield; @@ -3608,8 +3675,8 @@ float PlayerWheel::calculateMitigation() const { } } - float mitigation = std::ceil(((((skill * m_player.vocation->mitigationFactor) + (shieldFactor * (float)defenseValue)) / 100.0f) * fightFactor * distanceFactor) * 100.0f) / 100.0f; - mitigation += (mitigation * (float)getMitigationMultiplier()) / 100.f; + float mitigation = std::ceil(((((skill * m_player.vocation->mitigationFactor) + (shieldFactor * static_cast<float>(defenseValue))) / 100.0f) * fightFactor * distanceFactor) * 100.0f) / 100.0f; + mitigation += (mitigation * static_cast<float>(getMitigationMultiplier())) / 100.f; return mitigation; } diff --git a/src/creatures/players/wheel/player_wheel.hpp b/src/creatures/players/wheel/player_wheel.hpp index a99b3dac49a..82730b76881 100644 --- a/src/creatures/players/wheel/player_wheel.hpp +++ b/src/creatures/players/wheel/player_wheel.hpp @@ -128,7 +128,7 @@ class PlayerWheel { void setPlayerCombatStats(CombatType_t type, int32_t leechAmount); - void reloadPlayerData(); + void reloadPlayerData() const; void registerPlayerBonusData(); @@ -207,18 +207,18 @@ class PlayerWheel { bool checkBallisticMastery(); bool checkCombatMastery(); bool checkDivineEmpowerment(); - int32_t checkDrainBodyLeech(std::shared_ptr<Creature> target, skills_t skill) const; + int32_t checkDrainBodyLeech(const std::shared_ptr<Creature> &target, skills_t skill) const; int32_t checkBeamMasteryDamage() const; int32_t checkBattleHealingAmount() const; - int32_t checkBlessingGroveHealingByTarget(std::shared_ptr<Creature> target) const; - int32_t checkTwinBurstByTarget(std::shared_ptr<Creature> target) const; - int32_t checkExecutionersThrow(std::shared_ptr<Creature> target) const; - int32_t checkDivineGrenade(std::shared_ptr<Creature> target) const; + int32_t checkBlessingGroveHealingByTarget(const std::shared_ptr<Creature> &target) const; + int32_t checkTwinBurstByTarget(const std::shared_ptr<Creature> &target) const; + int32_t checkExecutionersThrow(const std::shared_ptr<Creature> &target) const; + int32_t checkDivineGrenade(const std::shared_ptr<Creature> &target) const; int32_t checkAvatarSkill(WheelAvatarSkill_t skill) const; int32_t checkFocusMasteryDamage(); int32_t checkElementSensitiveReduction(CombatType_t type) const; // Wheel of destiny - General functions: - void reduceAllSpellsCooldownTimer(int32_t value); + void reduceAllSpellsCooldownTimer(int32_t value) const; void resetUpgradedSpells(); void upgradeSpell(const std::string &name); void downgradeSpell(const std::string &name); @@ -300,7 +300,7 @@ class PlayerWheel { // Wheel of destiny - Header get: bool getInstant(WheelInstant_t type) const; bool getHealingLinkUpgrade(const std::string &spell) const; - uint8_t getStage(const std::string name) const; + uint8_t getStage(std::string_view name) const; uint8_t getStage(WheelStage_t type) const; WheelSpellGrade_t getSpellUpgrade(const std::string &name) const; int32_t getMajorStat(WheelMajor_t type) const; @@ -308,7 +308,7 @@ class PlayerWheel { int32_t getResistance(CombatType_t type) const; int32_t getMajorStatConditional(const std::string &instant, WheelMajor_t major) const; int64_t getOnThinkTimer(WheelOnThink_t type) const; - bool getInstant(const std::string name) const; + bool getInstant(std::string_view name) const; double getMitigationMultiplier() const; // Wheel of destiny - Specific functions @@ -367,12 +367,12 @@ class PlayerWheel { PlayerWheelGem getGem(uint16_t index) const; PlayerWheelGem getGem(const std::string &uuid) const; uint16_t getGemIndex(const std::string &uuid) const; - void revealGem(WheelGemQuality_t quality); - void destroyGem(uint16_t index); - void switchGemDomain(uint16_t index); - void toggleGemLock(uint16_t index); - void setActiveGem(WheelGemAffinity_t affinity, uint16_t index); - void removeActiveGem(WheelGemAffinity_t affinity); + void revealGem(WheelGemQuality_t quality) const; + void destroyGem(uint16_t index) const; + void switchGemDomain(uint16_t index) const; + void toggleGemLock(uint16_t index) const; + void setActiveGem(WheelGemAffinity_t affinity, uint16_t index) const; + void removeActiveGem(WheelGemAffinity_t affinity) const; void addRevelationBonus(WheelGemAffinity_t affinity, uint16_t points) { m_bonusRevelationPoints[static_cast<size_t>(affinity)] += points; } @@ -380,7 +380,7 @@ class PlayerWheel { m_bonusRevelationPoints = { 0, 0, 0, 0 }; } - void addSpellBonus(const std::string &spellName, WheelSpells::Bonus bonus) { + void addSpellBonus(const std::string &spellName, const WheelSpells::Bonus &bonus) { if (m_spellsBonuses.contains(spellName)) { m_spellsBonuses[spellName].decrease.cooldown += bonus.decrease.cooldown; m_spellsBonuses[spellName].decrease.manaCost += bonus.decrease.manaCost; @@ -404,28 +404,28 @@ class PlayerWheel { if (!m_spellsBonuses.contains(spellName)) { return 0; } - auto bonus = m_spellsBonuses.at(spellName); + auto [leech, increase, decrease] = m_spellsBonuses.at(spellName); switch (boost) { case WheelSpellBoost_t::COOLDOWN: - return bonus.decrease.cooldown; + return decrease.cooldown; case WheelSpellBoost_t::MANA: - return bonus.decrease.manaCost; + return decrease.manaCost; case WheelSpellBoost_t::SECONDARY_GROUP_COOLDOWN: - return bonus.decrease.secondaryGroupCooldown; + return decrease.secondaryGroupCooldown; case WheelSpellBoost_t::CRITICAL_CHANCE: - return bonus.increase.criticalChance; + return increase.criticalChance; case WheelSpellBoost_t::CRITICAL_DAMAGE: - return bonus.increase.criticalDamage; + return increase.criticalDamage; case WheelSpellBoost_t::DAMAGE: - return bonus.increase.damage; + return increase.damage; case WheelSpellBoost_t::DAMAGE_REDUCTION: - return bonus.increase.damageReduction; + return increase.damageReduction; case WheelSpellBoost_t::HEAL: - return bonus.increase.heal; + return increase.heal; case WheelSpellBoost_t::LIFE_LEECH: - return bonus.leech.life; + return leech.life; case WheelSpellBoost_t::MANA_LEECH: - return bonus.leech.mana; + return leech.mana; default: return 0; } @@ -453,11 +453,11 @@ class PlayerWheel { PlayerWheelMethodsBonusData m_playerBonusData; std::unique_ptr<WheelModifierContext> m_modifierContext; - std::array<uint8_t, static_cast<size_t>(WheelStage_t::TOTAL_COUNT)> m_stages = { 0 }; + std::array<uint8_t, static_cast<size_t>(WheelStage_t::STAGE_COUNT)> m_stages = { 0 }; std::array<int64_t, static_cast<size_t>(WheelOnThink_t::TOTAL_COUNT)> m_onThink = { 0 }; std::array<int32_t, static_cast<size_t>(WheelStat_t::TOTAL_COUNT)> m_stats = { 0 }; std::array<int32_t, static_cast<size_t>(WheelMajor_t::TOTAL_COUNT)> m_majorStats = { 0 }; - std::array<bool, static_cast<size_t>(WheelInstant_t::TOTAL_COUNT)> m_instant = { false }; + std::array<bool, static_cast<size_t>(WheelInstant_t::INSTANT_COUNT)> m_instant = { false }; std::array<int32_t, COMBAT_COUNT> m_resistance = { 0 }; int32_t m_creaturesNearby = 0; diff --git a/src/creatures/players/wheel/wheel_definitions.hpp b/src/creatures/players/wheel/wheel_definitions.hpp index 8fc3783b4cb..5651b8dc216 100644 --- a/src/creatures/players/wheel/wheel_definitions.hpp +++ b/src/creatures/players/wheel/wheel_definitions.hpp @@ -94,7 +94,7 @@ enum class WheelStage_t : uint8_t { AVATAR_OF_STORM = 11, DIVINE_GRENADE = 12, - TOTAL_COUNT = 13 + STAGE_COUNT = 13 }; enum class WheelOnThink_t : uint8_t { @@ -156,7 +156,7 @@ enum class WheelInstant_t : uint8_t { RUNIC_MASTERY = 5, FOCUS_MASTERY = 6, - TOTAL_COUNT = 7 + INSTANT_COUNT = 7 }; enum class WheelAvatarSkill_t : uint8_t { diff --git a/src/creatures/players/wheel/wheel_gems.cpp b/src/creatures/players/wheel/wheel_gems.cpp index fb77643913a..3ee884c077b 100644 --- a/src/creatures/players/wheel/wheel_gems.cpp +++ b/src/creatures/players/wheel/wheel_gems.cpp @@ -40,181 +40,181 @@ void WheelModifierContext::addStrategies(WheelGemBasicModifier_t modifier, uint8 switch (modifier) { case WheelGemBasicModifier_t::General_PhysicalResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_PHYSICALDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_PHYSICALDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_HolyResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_HOLYDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_HOLYDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_DeathResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_DEATHDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_DEATHDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_FireResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 200 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 200 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_EarthResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 200 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 200 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_IceResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 200 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 200 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_EnergyResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 200 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 200 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_HolyResistance_DeathWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_HOLYDAMAGE, 150 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_DEATHDAMAGE, -100)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_HOLYDAMAGE, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_DEATHDAMAGE, -100)); break; case WheelGemBasicModifier_t::General_DeathResistance_HolyWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_DEATHDAMAGE, 150 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_HOLYDAMAGE, -100)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_DEATHDAMAGE, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_HOLYDAMAGE, -100)); break; case WheelGemBasicModifier_t::General_FireResistance_EarthResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_FireResistance_IceResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_FireResistance_EnergyResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_EarthResistance_IceResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_EarthResistance_EnergyResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_IceResistance_EnergyResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_FireResistance_EarthWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_FireResistance_IceWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_FireResistance_EnergyWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_EarthResistance_FireWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_EarthResistance_IceWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_EarthResistance_EnergyWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_IceResistance_EarthWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_IceResistance_FireWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_IceResistance_EnergyWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_EnergyResistance_EarthWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_EnergyResistance_IceWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_EnergyResistance_FireWeakness: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 300 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, -200)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, -200)); break; case WheelGemBasicModifier_t::General_ManaDrainResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_MANADRAIN, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_MANADRAIN, 300 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_LifeDrainResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_LIFEDRAIN, 300 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_LIFEDRAIN, 300 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_ManaDrainResistance_LifeDrainResistance: - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_MANADRAIN, 150 * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_LIFEDRAIN, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_MANADRAIN, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_LIFEDRAIN, 150 * gradeMultiplier)); break; case WheelGemBasicModifier_t::General_MitigationMultiplier: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MITIGATION, 500 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MITIGATION, 500 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Health: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Mana_FireResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Mana_EnergyResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Mana_Earth_Resistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Mana_Ice_Resistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Mana: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Health_FireResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Health_EnergyResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Health_EarthResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Health_IceResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Mixed: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::HEALTH, WheelGemUtils::getHealthValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA, WheelGemUtils::getManaValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Capacity_FireResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_FIREDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Capacity_EnergyResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ENERGYDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Capacity_EarthResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_EARTHDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Capacity_IceResistance: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); - m_strategies.push_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierResistanceStrategy>(m_wheel, CombatType_t::COMBAT_ICEDAMAGE, 100 * gradeMultiplier)); break; case WheelGemBasicModifier_t::Vocation_Capacity: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CAPACITY, WheelGemUtils::getCapacityValue(m_vocation, modifier) * gradeMultiplier)); break; default: @@ -237,331 +237,331 @@ void WheelModifierContext::addStrategies(WheelGemSupremeModifier_t modifier, uin switch (modifier) { case WheelGemSupremeModifier_t::General_Dodge: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::DODGE, 25 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::DODGE, 25 * gradeMultiplier)); break; case WheelGemSupremeModifier_t::General_LifeLeech: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::LIFE_LEECH, 120 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::LIFE_LEECH, 120 * gradeMultiplier)); break; case WheelGemSupremeModifier_t::General_ManaLeech: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA_LEECH, 40 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::MANA_LEECH, 40 * gradeMultiplier)); break; case WheelGemSupremeModifier_t::General_CriticalDamage: - m_strategies.push_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CRITICAL_DAMAGE, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierStatStrategy>(m_wheel, WheelStat_t::CRITICAL_DAMAGE, 150 * gradeMultiplier)); break; case WheelGemSupremeModifier_t::General_RevelationMastery_GiftOfLife: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Green, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Green, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Green, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::SorcererDruid_UltimateHealing: bonus.increase.heal = 10 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ultimate Healing", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ultimate Healing", bonus)); break; case WheelGemSupremeModifier_t::Knight_RevelationMastery_ExecutionersThrow: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Red, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Knight_RevelationMastery_AvatarOfSteel: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Purple, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Knight_RevelationMastery_CombatMastery: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Blue, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Paladin_RevelationMastery_DivineGrenade: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Red, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Paladin_RevelationMastery_AvatarOfLight: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Purple, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Paladin_RevelationMastery_DivineEmpowerment: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Blue, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Druid_RevelationMastery_BlessingOfTheGrove: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Red, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Druid_RevelationMastery_AvatarOfNature: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Purple, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Druid_RevelationMastery_TwinBursts: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Blue, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Sorcerer_RevelationMastery_BeamMastery: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Red, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Red, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Sorcerer_RevelationMastery_AvatarOfStorm: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Purple, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Purple, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Sorcerer_RevelationMastery_DrainBody: - m_strategies.push_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); + m_strategies.emplace_back(std::make_unique<GemModifierRevelationStrategy>(m_wheel, WheelGemAffinity_t::Blue, 150 * gradeMultiplier)); m_wheel.addRevelationBonus(WheelGemAffinity_t::Blue, 150 * gradeMultiplier); break; case WheelGemSupremeModifier_t::Knight_AvatarOfSteel_Cooldown: bonus.decrease.cooldown = 300 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Steel", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Steel", bonus)); break; case WheelGemSupremeModifier_t::Knight_ExecutionersThrow_Cooldown: bonus.decrease.cooldown = 1 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Executioner's Throw", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Executioner's Throw", bonus)); break; case WheelGemSupremeModifier_t::Knight_ExecutionersThrow_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Executioner's Throw", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Executioner's Throw", bonus)); break; case WheelGemSupremeModifier_t::Knight_ExecutionersThrow_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Executioner's Throw", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Executioner's Throw", bonus)); break; case WheelGemSupremeModifier_t::Knight_Fierce_Berserk_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Fierce Berserk", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Fierce Berserk", bonus)); break; case WheelGemSupremeModifier_t::Knight_Fierce_Berserk_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Fierce Berserk", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Fierce Berserk", bonus)); break; case WheelGemSupremeModifier_t::Knight_Berserk_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Berserk", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Berserk", bonus)); break; case WheelGemSupremeModifier_t::Knight_Berserk_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Berserk", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Berserk", bonus)); break; case WheelGemSupremeModifier_t::Knight_Front_Sweep_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Front Sweep", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Front Sweep", bonus)); break; case WheelGemSupremeModifier_t::Knight_Front_Sweep_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Front Sweep", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Front Sweep", bonus)); break; case WheelGemSupremeModifier_t::Knight_Groundshaker_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Groundshaker", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Groundshaker", bonus)); break; case WheelGemSupremeModifier_t::Knight_Groundshaker_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Groundshaker", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Groundshaker", bonus)); break; case WheelGemSupremeModifier_t::Knight_Annihilation_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Annihilation", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Annihilation", bonus)); break; case WheelGemSupremeModifier_t::Knight_Annihilation_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Annihilation", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Annihilation", bonus)); break; case WheelGemSupremeModifier_t::Knight_FairWoundCleansing_HealingIncrease: bonus.increase.heal = 10 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Fair Wound Cleansing", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Fair Wound Cleansing", bonus)); break; case WheelGemSupremeModifier_t::Paladin_AvatarOfLight_Cooldown: bonus.decrease.cooldown = 300 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Light", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Light", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineDazzle_Cooldown: bonus.decrease.cooldown = 2 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Dazzle", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Dazzle", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineGrenade_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Grenade", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Grenade", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineGrenade_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Grenade", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Grenade", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineCaldera_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Caldera", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Caldera", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineCaldera_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Caldera", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Caldera", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineMissile_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Missile", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Missile", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineMissile_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Missile", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Missile", bonus)); break; case WheelGemSupremeModifier_t::Paladin_EtherealSpear_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ethereal Spear", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ethereal Spear", bonus)); break; case WheelGemSupremeModifier_t::Paladin_EtherealSpear_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ethereal Spear", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ethereal Spear", bonus)); break; case WheelGemSupremeModifier_t::Paladin_StrongEtherealSpear_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ethereal Spear", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ethereal Spear", bonus)); break; case WheelGemSupremeModifier_t::Paladin_StrongEtherealSpear_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ethereal Spear", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ethereal Spear", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineEmpowerment_Cooldown: bonus.decrease.cooldown = 3 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Empowerment", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Empowerment", bonus)); break; case WheelGemSupremeModifier_t::Paladin_DivineGrenade_Cooldown: bonus.decrease.cooldown = 1 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Grenade", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Divine Grenade", bonus)); break; case WheelGemSupremeModifier_t::Paladin_Salvation_HealingIncrease: bonus.increase.heal = 10 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Salvation", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Salvation", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_AvatarOfStorm_Cooldown: bonus.decrease.cooldown = 300 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Storm", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Storm", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_EnergyWave_Cooldown: bonus.decrease.cooldown = 1 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Energy Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Energy Wave", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_GreatDeathBeam_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Death Beam", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Death Beam", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_GreatDeathBeam_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Death Beam", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Death Beam", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_HellsCore_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Hell's Core", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Hell's Core", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_HellsCore_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Hell's Core", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Hell's Core", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_EnergyWave_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Energy Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Energy Wave", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_EnergyWave_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Energy Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Energy Wave", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_GreatFireWave_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Fire Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Fire Wave", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_GreatFireWave_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Fire Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Fire Wave", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_RageOfTheSkies_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Rage of the Skies", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Rage of the Skies", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_RageOfTheSkies_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Rage of the Skies", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Rage of the Skies", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_GreatEnergyBeam_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Energy Beam", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Energy Beam", bonus)); break; case WheelGemSupremeModifier_t::Sorcerer_GreatEnergyBeam_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Energy Beam", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Great Energy Beam", bonus)); break; case WheelGemSupremeModifier_t::Druid_AvatarOfNature_Cooldown: bonus.decrease.cooldown = 300 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Nature", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Avatar of Nature", bonus)); break; case WheelGemSupremeModifier_t::Druid_NaturesEmbrace_Cooldown: bonus.decrease.cooldown = 5 * 1000; wheelBonus.momentum += grade < 3 ? 0.33 * grade : 1; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Nature's Embrace", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Nature's Embrace", bonus)); break; case WheelGemSupremeModifier_t::Druid_TerraBurst_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Burst", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Burst", bonus)); break; case WheelGemSupremeModifier_t::Druid_TerraBurst_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Burst", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Burst", bonus)); break; case WheelGemSupremeModifier_t::Druid_IceBurst_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ice Burst", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ice Burst", bonus)); break; case WheelGemSupremeModifier_t::Druid_IceBurst_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ice Burst", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Ice Burst", bonus)); break; case WheelGemSupremeModifier_t::Druid_EternalWinter_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Eternal Winter", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Eternal Winter", bonus)); break; case WheelGemSupremeModifier_t::Druid_EternalWinter_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Eternal Winter", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Eternal Winter", bonus)); break; case WheelGemSupremeModifier_t::Druid_TerraWave_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Wave", bonus)); break; case WheelGemSupremeModifier_t::Druid_TerraWave_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Terra Wave", bonus)); break; case WheelGemSupremeModifier_t::Druid_StrongIceWave_DamageIncrease: bonus.increase.damage = 25 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ice Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ice Wave", bonus)); break; case WheelGemSupremeModifier_t::Druid_StrongIceWave_CriticalExtraDamage: bonus.increase.criticalDamage = 8 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ice Wave", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Strong Ice Wave", bonus)); break; case WheelGemSupremeModifier_t::Druid_HealFriend_HealingIncrease: bonus.increase.heal = 10 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Heal Friend", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Heal Friend", bonus)); break; case WheelGemSupremeModifier_t::Druid_MassHealing_HealingIncrease: bonus.increase.heal = 10 * gradeMultiplier; - m_strategies.push_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Mass Healing", bonus)); + m_strategies.emplace_back(std::make_unique<GemModifierSpellBonusStrategy>(m_wheel, "Mass Healing", bonus)); break; default: g_logger().error("WheelModifierContext::setStrategy: Invalid supreme modifier: {}", static_cast<uint8_t>(modifier)); } } -void WheelModifierContext::executeStrategies() { - for (auto &strategy : m_strategies) { +void WheelModifierContext::executeStrategies() const { + for (const auto &strategy : m_strategies) { strategy->execute(); } } diff --git a/src/creatures/players/wheel/wheel_gems.hpp b/src/creatures/players/wheel/wheel_gems.hpp index dee64225183..7b748266781 100644 --- a/src/creatures/players/wheel/wheel_gems.hpp +++ b/src/creatures/players/wheel/wheel_gems.hpp @@ -32,7 +32,7 @@ class GemModifierStrategy { PlayerWheel &m_wheel; }; -class GemModifierResistanceStrategy : public GemModifierStrategy { +class GemModifierResistanceStrategy final : public GemModifierStrategy { public: explicit GemModifierResistanceStrategy(PlayerWheel &wheel, CombatType_t combatType, int32_t resistance) : GemModifierStrategy(wheel), @@ -46,7 +46,7 @@ class GemModifierResistanceStrategy : public GemModifierStrategy { int32_t m_resistance; }; -class GemModifierStatStrategy : public GemModifierStrategy { +class GemModifierStatStrategy final : public GemModifierStrategy { public: explicit GemModifierStatStrategy(PlayerWheel &wheel, WheelStat_t stat, int32_t value) : GemModifierStrategy(wheel), @@ -60,7 +60,7 @@ class GemModifierStatStrategy : public GemModifierStrategy { int32_t m_value {}; }; -class GemModifierRevelationStrategy : public GemModifierStrategy { +class GemModifierRevelationStrategy final : public GemModifierStrategy { public: explicit GemModifierRevelationStrategy(PlayerWheel &wheel, WheelGemAffinity_t affinity, [[maybe_unused]] uint16_t value) : GemModifierStrategy(wheel), @@ -74,9 +74,9 @@ class GemModifierRevelationStrategy : public GemModifierStrategy { uint16_t m_value {}; }; -class GemModifierSpellBonusStrategy : public GemModifierStrategy { +class GemModifierSpellBonusStrategy final : public GemModifierStrategy { public: - explicit GemModifierSpellBonusStrategy(PlayerWheel &wheel, std::string spellName, WheelSpells::Bonus bonus) : + explicit GemModifierSpellBonusStrategy(PlayerWheel &wheel, std::string spellName, const WheelSpells::Bonus &bonus) : GemModifierStrategy(wheel), m_spellName(std::move(spellName)), m_bonus(bonus) { } @@ -100,7 +100,7 @@ class WheelModifierContext { m_strategies.clear(); } - void executeStrategies(); + void executeStrategies() const; private: std::vector<std::unique_ptr<GemModifierStrategy>> m_strategies; diff --git a/src/database/database.cpp b/src/database/database.cpp index 37fe2b1a3c6..5b0c55fbc29 100644 --- a/src/database/database.cpp +++ b/src/database/database.cpp @@ -101,7 +101,7 @@ bool Database::commit() { return true; } -bool Database::isRecoverableError(unsigned int error) const { +bool Database::isRecoverableError(unsigned int error) { return error == CR_SERVER_LOST || error == CR_SERVER_GONE_ERROR || error == CR_CONN_HOST_ERROR || error == 1053 /*ER_SERVER_SHUTDOWN*/ || error == CR_CONNECTION_ERROR; } @@ -225,10 +225,10 @@ std::string DBResult::getString(const std::string &s) const { auto it = listNames.find(s); if (it == listNames.end()) { g_logger().error("Column '{}' does not exist in result set", s); - return std::string(); + return {}; } if (row[it->second] == nullptr) { - return std::string(); + return {}; } return std::string(row[it->second]); } @@ -250,7 +250,7 @@ const char* DBResult::getStream(const std::string &s, unsigned long &size) const return row[it->second]; } -uint8_t DBResult::getU8FromString(const std::string &string, const std::string &function) const { +uint8_t DBResult::getU8FromString(const std::string &string, const std::string &function) { auto result = static_cast<uint8_t>(std::atoi(string.c_str())); if (result > std::numeric_limits<uint8_t>::max()) { g_logger().error("[{}] Failed to get number value {} for tier table result, on function call: {}", __FUNCTION__, result, function); @@ -260,7 +260,7 @@ uint8_t DBResult::getU8FromString(const std::string &string, const std::string & return result; } -int8_t DBResult::getInt8FromString(const std::string &string, const std::string &function) const { +int8_t DBResult::getInt8FromString(const std::string &string, const std::string &function) { auto result = static_cast<int8_t>(std::atoi(string.c_str())); if (result > std::numeric_limits<int8_t>::max()) { g_logger().error("[{}] Failed to get number value {} for tier table result, on function call: {}", __FUNCTION__, result, function); diff --git a/src/database/database.hpp b/src/database/database.hpp index 4984873ed62..97c12f3de47 100644 --- a/src/database/database.hpp +++ b/src/database/database.hpp @@ -14,6 +14,7 @@ #ifndef USE_PRECOMPILED_HEADERS #include <mysql/mysql.h> #include <mutex> + #include <utility> #endif class DBResult; @@ -62,7 +63,7 @@ class Database { bool rollback(); bool commit(); - bool isRecoverableError(unsigned int error) const; + static bool isRecoverableError(unsigned int error); MYSQL* handle = nullptr; std::recursive_mutex databaseLock; @@ -148,8 +149,8 @@ class DBResult { std::string getString(const std::string &s) const; const char* getStream(const std::string &s, unsigned long &size) const; - uint8_t getU8FromString(const std::string &string, const std::string &function) const; - int8_t getInt8FromString(const std::string &string, const std::string &function) const; + static uint8_t getU8FromString(const std::string &string, const std::string &function); + static int8_t getInt8FromString(const std::string &string, const std::string &function); size_t countResults() const; bool hasNext() const; @@ -171,7 +172,7 @@ class DBInsert { public: explicit DBInsert(std::string query); void upsert(const std::vector<std::string> &columns); - bool addRow(const std::string_view row); + bool addRow(std::string_view row); bool addRow(std::ostringstream &row); bool execute(); @@ -198,16 +199,20 @@ class DBTransaction { template <typename Func> static bool executeWithinTransaction(const Func &toBeExecuted) { - DBTransaction transaction; - try { - transaction.begin(); - bool result = toBeExecuted(); - transaction.commit(); - return result; - } catch (const std::exception &exception) { - transaction.rollback(); - g_logger().error("[{}] Error occurred committing transaction, error: {}", __FUNCTION__, exception.what()); - return false; + bool changesExpected = toBeExecuted(); + if (changesExpected) { + DBTransaction transaction; + try { + transaction.begin(); + transaction.commit(); + return changesExpected; + } catch (const std::exception &exception) { + transaction.rollback(); + g_logger().error("[{}] Error occurred during transaction, error: {}", __FUNCTION__, exception.what()); + return false; + } + } else { + return true; } } @@ -279,10 +284,10 @@ class DBTransaction { class DatabaseException : public std::exception { public: - explicit DatabaseException(const std::string &message) : - message(message) { } + explicit DatabaseException(std::string message) : + message(std::move(message)) { } - virtual const char* what() const throw() { + const char* what() const noexcept override { return message.c_str(); } diff --git a/src/database/databasetasks.cpp b/src/database/databasetasks.cpp index 010b3f16320..69718ec7c53 100644 --- a/src/database/databasetasks.cpp +++ b/src/database/databasetasks.cpp @@ -20,7 +20,7 @@ DatabaseTasks &DatabaseTasks::getInstance() { return inject<DatabaseTasks>(); } -void DatabaseTasks::execute(const std::string &query, std::function<void(DBResult_ptr, bool)> callback /* nullptr */) { +void DatabaseTasks::execute(const std::string &query, const std::function<void(DBResult_ptr, bool)> &callback /* nullptr */) { threadPool.detach_task([this, query, callback]() { bool success = db.executeQuery(query); if (callback != nullptr) { @@ -29,7 +29,7 @@ void DatabaseTasks::execute(const std::string &query, std::function<void(DBResul }); } -void DatabaseTasks::store(const std::string &query, std::function<void(DBResult_ptr, bool)> callback /* nullptr */) { +void DatabaseTasks::store(const std::string &query, const std::function<void(DBResult_ptr, bool)> &callback /* nullptr */) { threadPool.detach_task([this, query, callback]() { DBResult_ptr result = db.storeQuery(query); if (callback != nullptr) { diff --git a/src/database/databasetasks.hpp b/src/database/databasetasks.hpp index 6922dfc566f..a9c86583db4 100644 --- a/src/database/databasetasks.hpp +++ b/src/database/databasetasks.hpp @@ -22,8 +22,8 @@ class DatabaseTasks { static DatabaseTasks &getInstance(); - void execute(const std::string &query, std::function<void(DBResult_ptr, bool)> callback = nullptr); - void store(const std::string &query, std::function<void(DBResult_ptr, bool)> callback = nullptr); + void execute(const std::string &query, const std::function<void(DBResult_ptr, bool)> &callback = nullptr); + void store(const std::string &query, const std::function<void(DBResult_ptr, bool)> &callback = nullptr); private: Database &db; diff --git a/src/enums/item_attribute.hpp b/src/enums/item_attribute.hpp index be7b7445710..a3d76fde70f 100644 --- a/src/enums/item_attribute.hpp +++ b/src/enums/item_attribute.hpp @@ -9,7 +9,7 @@ #pragma once -enum ItemAttribute_t : uint64_t { +enum class ItemAttribute_t : uint64_t { NONE = 0, ACTIONID = 1, UNIQUEID = 2, diff --git a/src/enums/player_cyclopedia.hpp b/src/enums/player_cyclopedia.hpp index 295e573984f..af7ea1701ff 100644 --- a/src/enums/player_cyclopedia.hpp +++ b/src/enums/player_cyclopedia.hpp @@ -13,7 +13,7 @@ #include <cstdint> #endif -enum CyclopediaBadge_t : uint8_t { +enum class CyclopediaBadge_t : uint8_t { ACCOUNT_AGE = 1, LOYALTY, ACCOUNT_ALL_LEVEL, diff --git a/src/game/bank/bank.cpp b/src/game/bank/bank.cpp index b568d322810..50f79c6d494 100644 --- a/src/game/bank/bank.cpp +++ b/src/game/bank/bank.cpp @@ -14,7 +14,7 @@ #include "game/scheduling/save_manager.hpp" #include "lib/metrics/metrics.hpp" -Bank::Bank(const std::shared_ptr<Bankable> bankable) : +Bank::Bank(const std::shared_ptr<Bankable> &bankable) : m_bankable(bankable) { } @@ -23,7 +23,7 @@ Bank::~Bank() { if (bankable == nullptr || bankable->isOnline()) { return; } - std::shared_ptr<Player> player = bankable->getPlayer(); + const auto &player = bankable->getPlayer(); if (player && !player->isOnline()) { g_saveManager().savePlayer(player); @@ -51,7 +51,7 @@ bool Bank::debit(uint64_t amount) { bool Bank::balance(uint64_t amount) const { auto bankable = getBankable(); if (!bankable) { - return 0; + return false; } bankable->setBankBalance(amount); return true; @@ -78,7 +78,7 @@ const std::set<std::string> deniedNames = { "paladinsample" }; -bool Bank::transferTo(const std::shared_ptr<Bank> &destination, const uint64_t amount) { +bool Bank::transferTo(const std::shared_ptr<Bank> &destination, uint64_t amount) { if (!destination) { g_logger().error("Bank::transferTo: destination is nullptr"); return false; @@ -138,11 +138,10 @@ bool Bank::transferTo(const std::shared_ptr<Bank> &destination, const uint64_t a return true; } -bool Bank::withdraw(std::shared_ptr<Player> player, uint64_t amount) { +bool Bank::withdraw(const std::shared_ptr<Player> &player, uint64_t amount) { if (!player) { return false; } - if (!debit(amount)) { return false; } @@ -151,7 +150,7 @@ bool Bank::withdraw(std::shared_ptr<Player> player, uint64_t amount) { return true; } -bool Bank::deposit(const std::shared_ptr<Bank> destination) { +bool Bank::deposit(const std::shared_ptr<Bank> &destination) { auto bankable = getBankable(); if (!bankable) { return false; @@ -163,7 +162,7 @@ bool Bank::deposit(const std::shared_ptr<Bank> destination) { return deposit(destination, amount); } -bool Bank::deposit(const std::shared_ptr<Bank> destination, uint64_t amount) { +bool Bank::deposit(const std::shared_ptr<Bank> &destination, uint64_t amount) { if (!destination) { return false; } diff --git a/src/game/bank/bank.hpp b/src/game/bank/bank.hpp index 7fdb740a022..7149d8ab0d0 100644 --- a/src/game/bank/bank.hpp +++ b/src/game/bank/bank.hpp @@ -29,7 +29,7 @@ class Bankable { class Bank : public SharedObject { public: - explicit Bank(const std::shared_ptr<Bankable> bankable); + explicit Bank(const std::shared_ptr<Bankable> &bankable); ~Bank() override; // Deleted copy constructor and assignment operator. @@ -42,10 +42,10 @@ class Bank : public SharedObject { bool balance(uint64_t amount) const; uint64_t balance(); bool hasBalance(uint64_t amount); - bool transferTo(const std::shared_ptr<Bank> &destination, const uint64_t amount); - bool withdraw(std::shared_ptr<Player> player, uint64_t amount); - bool deposit(const std::shared_ptr<Bank> destination); - bool deposit(const std::shared_ptr<Bank> destination, uint64_t amount); + bool transferTo(const std::shared_ptr<Bank> &destination, uint64_t amount); + bool withdraw(const std::shared_ptr<Player> &player, uint64_t amount); + bool deposit(const std::shared_ptr<Bank> &destination); + bool deposit(const std::shared_ptr<Bank> &destination, uint64_t amount); private: std::shared_ptr<Bankable> getBankable() const { diff --git a/src/game/game.cpp b/src/game/game.cpp index c6ba09311d5..b4ce04f7644 100644 --- a/src/game/game.cpp +++ b/src/game/game.cpp @@ -57,7 +57,7 @@ #include <appearances.pb.h> namespace InternalGame { - void sendBlockEffect(BlockType_t blockType, CombatType_t combatType, const Position &targetPos, std::shared_ptr<Creature> source) { + void sendBlockEffect(BlockType_t blockType, CombatType_t combatType, const Position &targetPos, const std::shared_ptr<Creature> &source) { if (blockType == BLOCK_DEFENSE) { g_game().addMagicEffect(targetPos, CONST_ME_POFF); } else if (blockType == BLOCK_ARMOR) { @@ -95,11 +95,11 @@ namespace InternalGame { } if (blockType != BLOCK_NONE) { - g_game().sendSingleSoundEffect(targetPos, SoundEffect_t::NO_DAMAGE, std::move(source)); + g_game().sendSingleSoundEffect(targetPos, SoundEffect_t::NO_DAMAGE, source); } } - bool playerCanUseItemOnHouseTile(std::shared_ptr<Player> player, std::shared_ptr<Item> item) { + bool playerCanUseItemOnHouseTile(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) { if (!player || !item) { return false; } @@ -136,7 +136,7 @@ namespace InternalGame { return true; } - bool playerCanUseItemWithOnHouseTile(std::shared_ptr<Player> player, std::shared_ptr<Item> item, const Position &toPos, int toStackPos, int toItemId) { + bool playerCanUseItemWithOnHouseTile(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const Position &toPos, int toStackPos, int toItemId) { if (!player || !item) { return false; } @@ -164,7 +164,7 @@ namespace InternalGame { } template <typename T> - T getCustomAttributeValue(std::shared_ptr<Item> item, const std::string &attributeName) { + T getCustomAttributeValue(const auto item, const std::string &attributeName) { static_assert(std::is_integral<T>::value, "T must be an integral type"); auto attribute = item->getCustomAttribute(attributeName); @@ -419,8 +419,8 @@ void Game::loadBoostedCreature() { return; } - const uint16_t date = result->getNumber<uint16_t>("date"); - const time_t now = time(0); + const auto date = result->getNumber<uint16_t>("date"); + const auto now = getTimeNow(); tm* ltm = localtime(&now); if (date == ltm->tm_mday) { @@ -428,7 +428,7 @@ void Game::loadBoostedCreature() { return; } - const uint16_t oldRace = result->getNumber<uint16_t>("raceid"); + const auto oldRace = result->getNumber<uint16_t>("raceid"); const auto monsterlist = getBestiaryList(); struct MonsterRace { @@ -493,7 +493,7 @@ void Game::start(ServiceManager* manager) { serviceManager = manager; - time_t now = time(0); + const auto now = getTimeNow(); const tm* tms = localtime(&now); int minutes = tms->tm_min; lightHour = (minutes * LIGHT_DAY_LENGTH) / 60; @@ -529,6 +529,10 @@ void Game::start(ServiceManager* manager) { marketItemsPriceIntervalMS, [this] { loadItemsPrice(); }, "Game::loadItemsPrice" ); } + + g_dispatcher().cycleEvent( + UPDATE_PLAYERS_ONLINE_DB, [this] { updatePlayersOnline(); }, "Game::updatePlayersOnline" + ); } GameState_t Game::getGameState() const { @@ -638,7 +642,7 @@ void Game::loadItemsPrice() { } // Update active buy offers (market_offers) - auto offers = IOMarket::getInstance().getActiveOffers(MARKETACTION_BUY); + auto offers = IOMarket::getActiveOffers(MARKETACTION_BUY); for (const auto &offer : offers) { itemsPriceMap[offer.itemId][offer.tier] = std::max(itemsPriceMap[offer.itemId][offer.tier], offer.price); } @@ -701,7 +705,7 @@ void Game::loadMap(const std::string &path, const Position &pos) { map.loadMap(path, false, false, false, false, false, pos); } -std::shared_ptr<Cylinder> Game::internalGetCylinder(std::shared_ptr<Player> player, const Position &pos) { +std::shared_ptr<Cylinder> Game::internalGetCylinder(const std::shared_ptr<Player> &player, const Position &pos) { if (pos.x != 0xFFFF) { return map.getTile(pos); } @@ -716,7 +720,7 @@ std::shared_ptr<Cylinder> Game::internalGetCylinder(std::shared_ptr<Player> play return player; } -std::shared_ptr<Thing> Game::internalGetThing(std::shared_ptr<Player> player, const Position &pos, int32_t index, uint32_t itemId, StackPosType_t type) { +std::shared_ptr<Thing> Game::internalGetThing(const std::shared_ptr<Player> &player, const Position &pos, int32_t index, uint32_t itemId, StackPosType_t type) { if (pos.x != 0xFFFF) { std::shared_ptr<Tile> tile = map.getTile(pos); if (!tile) { @@ -730,7 +734,7 @@ std::shared_ptr<Thing> Game::internalGetThing(std::shared_ptr<Player> player, co } case STACKPOS_MOVE: { - std::shared_ptr<Item> item = tile->getTopDownItem(); + const auto &item = tile->getTopDownItem(); if (item && item->isMovable()) { thing = item; } else { @@ -797,13 +801,13 @@ std::shared_ptr<Thing> Game::internalGetThing(std::shared_ptr<Player> player, co if (pos.y & 0x40) { uint8_t fromCid = pos.y & 0x0F; - std::shared_ptr<Container> parentContainer = player->getContainerByID(fromCid); + const std::shared_ptr<Container> &parentContainer = player->getContainerByID(fromCid); if (!parentContainer) { return nullptr; } if (parentContainer->getID() == ITEM_BROWSEFIELD) { - std::shared_ptr<Tile> tile = parentContainer->getTile(); + const std::shared_ptr<Tile> &tile = parentContainer->getTile(); if (tile && tile->hasFlag(TILESTATE_SUPPORTS_HANGABLE)) { if (tile->hasProperty(CONST_PROP_ISVERTICAL)) { if (player->getPosition().x + 1 == tile->getPosition().x) { @@ -851,11 +855,11 @@ std::shared_ptr<Thing> Game::internalGetThing(std::shared_ptr<Player> player, co } // inventory - Slots_t slot = static_cast<Slots_t>(pos.y); + auto slot = static_cast<Slots_t>(pos.y); return player->getInventoryItem(slot); } -void Game::internalGetPosition(std::shared_ptr<Item> item, Position &pos, uint8_t &stackpos) { +void Game::internalGetPosition(const std::shared_ptr<Item> &item, Position &pos, uint8_t &stackpos) { pos.x = 0; pos.y = 0; pos.z = 0; @@ -863,10 +867,10 @@ void Game::internalGetPosition(std::shared_ptr<Item> item, Position &pos, uint8_ std::shared_ptr<Cylinder> topParent = item->getTopParent(); if (topParent) { - if (std::shared_ptr<Player> player = std::dynamic_pointer_cast<Player>(topParent)) { + if (const auto &player = std::dynamic_pointer_cast<Player>(topParent)) { pos.x = 0xFFFF; - std::shared_ptr<Container> container = std::dynamic_pointer_cast<Container>(item->getParent()); + const std::shared_ptr<Container> &container = std::dynamic_pointer_cast<Container>(item->getParent()); if (container) { pos.y = static_cast<uint16_t>(0x40) | static_cast<uint16_t>(player->getContainerID(container)); pos.z = container->getThingIndex(item); @@ -875,7 +879,7 @@ void Game::internalGetPosition(std::shared_ptr<Item> item, Position &pos, uint8_ pos.y = player->getThingIndex(item); stackpos = pos.y; } - } else if (std::shared_ptr<Tile> tile = topParent->getTile()) { + } else if (const std::shared_ptr<Tile> &tile = topParent->getTile()) { pos = tile->getPosition(); stackpos = tile->getThingIndex(item); } @@ -1062,7 +1066,7 @@ ReturnValue Game::getPlayerByNameWildcard(const std::string &s, std::shared_ptr< return RETURNVALUE_NOERROR; } -std::vector<std::shared_ptr<Player>> Game::getPlayersByAccount(std::shared_ptr<Account> acc, bool allowOffline /* = false */) { +std::vector<std::shared_ptr<Player>> Game::getPlayersByAccount(const std::shared_ptr<Account> &acc, bool allowOffline /* = false */) { auto [accountPlayers, error] = acc->getAccountPlayers(); if (error != enumToValue(AccountErrors_t::Ok)) { return {}; @@ -1077,7 +1081,7 @@ std::vector<std::shared_ptr<Player>> Game::getPlayersByAccount(std::shared_ptr<A return ret; } -bool Game::internalPlaceCreature(std::shared_ptr<Creature> creature, const Position &pos, bool extendedPos /*=false*/, bool forced /*= false*/, bool creatureCheck /*= false*/) { +bool Game::internalPlaceCreature(const std::shared_ptr<Creature> &creature, const Position &pos, bool extendedPos /*=false*/, bool forced /*= false*/, bool creatureCheck /*= false*/) { if (creature->getParent() != nullptr) { return false; } @@ -1106,7 +1110,7 @@ bool Game::internalPlaceCreature(std::shared_ptr<Creature> creature, const Posit return true; } -bool Game::placeCreature(std::shared_ptr<Creature> creature, const Position &pos, bool extendedPos /*=false*/, bool forced /*= false*/) { +bool Game::placeCreature(const std::shared_ptr<Creature> &creature, const Position &pos, bool extendedPos /*=false*/, bool forced /*= false*/) { metrics::method_latency measure(__METHOD_NAME__); if (!internalPlaceCreature(creature, pos, extendedPos, forced)) { return false; @@ -1133,7 +1137,7 @@ bool Game::placeCreature(std::shared_ptr<Creature> creature, const Position &pos return true; } -bool Game::removeCreature(std::shared_ptr<Creature> creature, bool isLogout /* = true*/) { +bool Game::removeCreature(const std::shared_ptr<Creature> &creature, bool isLogout /* = true*/) { metrics::method_latency measure(__METHOD_NAME__); if (!creature || creature->isRemoved()) { return false; @@ -1212,7 +1216,7 @@ void Game::executeDeath(uint32_t creatureId) { void Game::playerTeleport(uint32_t playerId, const Position &newPosition) { metrics::method_latency measure(__METHOD_NAME__); - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->hasFlag(PlayerFlags_t::CanMapClickTeleport)) { return; } @@ -1223,15 +1227,15 @@ void Game::playerTeleport(uint32_t playerId, const Position &newPosition) { } } -void Game::playerInspectItem(std::shared_ptr<Player> player, const Position &pos) { +void Game::playerInspectItem(const std::shared_ptr<Player> &player, const Position &pos) { metrics::method_latency measure(__METHOD_NAME__); - std::shared_ptr<Thing> thing = internalGetThing(player, pos, 0, 0, STACKPOS_TOPDOWN_ITEM); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, 0, 0, STACKPOS_TOPDOWN_ITEM); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -1240,7 +1244,7 @@ void Game::playerInspectItem(std::shared_ptr<Player> player, const Position &pos player->sendItemInspection(item->getID(), static_cast<uint8_t>(item->getItemCount()), item, false); } -void Game::playerInspectItem(std::shared_ptr<Player> player, uint16_t itemId, uint8_t itemCount, bool cyclopedia) { +void Game::playerInspectItem(const std::shared_ptr<Player> &player, uint16_t itemId, uint8_t itemCount, bool cyclopedia) { metrics::method_latency measure(__METHOD_NAME__); player->sendItemInspection(itemId, itemCount, nullptr, cyclopedia); } @@ -1296,7 +1300,7 @@ FILELOADER_ERRORS Game::loadAppearanceProtobuf(const std::string &file) { void Game::playerMoveThing(uint32_t playerId, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count) { metrics::method_latency measure(__METHOD_NAME__); - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -1323,14 +1327,14 @@ void Game::playerMoveThing(uint32_t playerId, const Position &fromPos, uint16_t fromIndex = fromStackPos; } - std::shared_ptr<Thing> thing = internalGetThing(player, fromPos, fromIndex, itemId, STACKPOS_MOVE); + const std::shared_ptr<Thing> &thing = internalGetThing(player, fromPos, fromIndex, itemId, STACKPOS_MOVE); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - if (std::shared_ptr<Creature> movingCreature = thing->getCreature()) { - std::shared_ptr<Tile> tile = map.getTile(toPos); + if (const std::shared_ptr<Creature> &movingCreature = thing->getCreature()) { + const std::shared_ptr<Tile> &tile = map.getTile(toPos); if (!tile) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -1360,7 +1364,7 @@ void Game::playerMoveThing(uint32_t playerId, const Position &fromPos, uint16_t } void Game::playerMoveCreatureByID(uint32_t playerId, uint32_t movingCreatureId, const Position &movingCreatureOrigPos, const Position &toPos) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -1379,7 +1383,7 @@ void Game::playerMoveCreatureByID(uint32_t playerId, uint32_t movingCreatureId, playerMoveCreature(player, movingCreature, movingCreatureOrigPos, toTile); } -void Game::playerMoveCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> movingCreature, const Position &movingCreatureOrigPos, std::shared_ptr<Tile> toTile) { +void Game::playerMoveCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &movingCreature, const Position &movingCreatureOrigPos, const std::shared_ptr<Tile> &toTile) { metrics::method_latency measure(__METHOD_NAME__); g_dispatcher().addWalkEvent([=, this] { @@ -1481,7 +1485,7 @@ void Game::playerMoveCreature(std::shared_ptr<Player> player, std::shared_ptr<Cr }); } -ReturnValue Game::internalMoveCreature(std::shared_ptr<Creature> creature, Direction direction, uint32_t flags /*= 0*/) { +ReturnValue Game::internalMoveCreature(const std::shared_ptr<Creature> &creature, Direction direction, uint32_t flags /*= 0*/) { if (!creature) { return RETURNVALUE_NOTPOSSIBLE; } @@ -1493,7 +1497,7 @@ ReturnValue Game::internalMoveCreature(std::shared_ptr<Creature> creature, Direc creature->setLastPosition(creature->getPosition()); const Position ¤tPos = creature->getPosition(); Position destPos = getNextPosition(direction, currentPos); - std::shared_ptr<Player> player = creature->getPlayer(); + const auto &player = creature->getPlayer(); bool diagonalMovement = (direction & DIRECTION_DIAGONAL_MASK) != 0; if (player && !diagonalMovement) { @@ -1566,7 +1570,11 @@ ReturnValue Game::internalMoveCreature(const std::shared_ptr<Creature> &creature std::shared_ptr<Tile> fromCylinder = nullptr; uint32_t n = 0; - while ((subCylinder = toCylinder->queryDestination(index, creature, &toItem, flags)->getTile()) != toCylinder) { + while ((subCylinder = toCylinder->queryDestination(index, creature, toItem, flags)->getTile()) != toCylinder) { + if (subCylinder == nullptr) { + break; + } + map.moveCreature(creature, subCylinder); if (creature->getParent() != subCylinder) { @@ -1600,14 +1608,14 @@ ReturnValue Game::internalMoveCreature(const std::shared_ptr<Creature> &creature } void Game::playerMoveItemByPlayerID(uint32_t playerId, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } playerMoveItem(player, fromPos, itemId, fromStackPos, toPos, count, nullptr, nullptr); } -void Game::playerMoveItem(std::shared_ptr<Player> player, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count, std::shared_ptr<Item> item, std::shared_ptr<Cylinder> toCylinder) { +void Game::playerMoveItem(const std::shared_ptr<Player> &player, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count, std::shared_ptr<Item> item, std::shared_ptr<Cylinder> toCylinder) { if (!player->canDoAction()) { uint32_t delay = player->getNextActionTime(); const auto &task = createPlayerTask( @@ -1641,7 +1649,7 @@ void Game::playerMoveItem(std::shared_ptr<Player> player, const Position &fromPo fromIndex = fromStackPos; } - std::shared_ptr<Thing> thing = internalGetThing(player, fromPos, fromIndex, itemId, STACKPOS_MOVE); + const auto &thing = internalGetThing(player, fromPos, fromIndex, itemId, STACKPOS_MOVE); if (!thing || !thing->getItem()) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -1689,9 +1697,9 @@ void Game::playerMoveItem(std::shared_ptr<Player> player, const Position &fromPo return; } - const Position &playerPos = player->getPosition(); - auto cylinderTile = fromCylinder->getTile(); - const Position &mapFromPos = cylinderTile ? cylinderTile->getPosition() : item->getPosition(); + const auto &playerPos = player->getPosition(); + const auto &cylinderTile = fromCylinder->getTile(); + const auto &mapFromPos = cylinderTile ? cylinderTile->getPosition() : item->getPosition(); if (playerPos.z != mapFromPos.z) { player->sendCancelMessage(playerPos.z > mapFromPos.z ? RETURNVALUE_FIRSTGOUPSTAIRS : RETURNVALUE_FIRSTGODOWNSTAIRS); return; @@ -1838,11 +1846,11 @@ void Game::playerMoveItem(std::shared_ptr<Player> player, const Position &fromPo g_callbacks().executeCallback(EventCallback_t::playerOnItemMoved, &EventCallback::playerOnItemMoved, player, item, count, fromPos, toPos, fromCylinder, toCylinder); } -bool Game::isTryingToStow(const Position &toPos, std::shared_ptr<Cylinder> toCylinder) const { +bool Game::isTryingToStow(const Position &toPos, const std::shared_ptr<Cylinder> &toCylinder) const { return toCylinder->getContainer() && toCylinder->getItem()->getID() == ITEM_LOCKER && toPos.getZ() == ITEM_SUPPLY_STASH_INDEX; } -ReturnValue Game::checkMoveItemToCylinder(std::shared_ptr<Player> player, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder, std::shared_ptr<Item> item, Position toPos) { +ReturnValue Game::checkMoveItemToCylinder(const std::shared_ptr<Player> &player, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder, const std::shared_ptr<Item> &item, Position toPos) { if (!player || !toCylinder || !item) { return RETURNVALUE_NOTPOSSIBLE; } @@ -1946,7 +1954,7 @@ ReturnValue Game::checkMoveItemToCylinder(std::shared_ptr<Player> player, std::s return RETURNVALUE_NOERROR; } -ReturnValue Game::internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder, int32_t index, std::shared_ptr<Item> item, uint32_t count, std::shared_ptr<Item>* movedItem, uint32_t flags /*= 0*/, std::shared_ptr<Creature> actor /*=nullptr*/, std::shared_ptr<Item> tradeItem /* = nullptr*/, bool checkTile /* = true*/) { +ReturnValue Game::internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder, int32_t index, const std::shared_ptr<Item> &item, uint32_t count, std::shared_ptr<Item>* movedItem, uint32_t flags /*= 0*/, const std::shared_ptr<Creature> &actor /*=nullptr*/, const std::shared_ptr<Item> &tradeItem /* = nullptr*/, bool checkTile /* = true*/) { metrics::method_latency measure(__METHOD_NAME__); if (fromCylinder == nullptr) { g_logger().error("[{}] fromCylinder is nullptr", __FUNCTION__); @@ -1958,7 +1966,7 @@ ReturnValue Game::internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std:: } if (checkTile) { - if (std::shared_ptr<Tile> fromTile = fromCylinder->getTile()) { + if (const std::shared_ptr<Tile> &fromTile = fromCylinder->getTile()) { if (fromTile && browseFields.contains(fromTile) && browseFields[fromTile].lock() == fromCylinder) { fromCylinder = fromTile; } @@ -1967,10 +1975,14 @@ ReturnValue Game::internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std:: std::shared_ptr<Item> toItem = nullptr; - std::shared_ptr<Cylinder> subCylinder; + std::shared_ptr<Cylinder> subCylinder = nullptr; int floorN = 0; - while ((subCylinder = toCylinder->queryDestination(index, item, &toItem, flags)) != toCylinder) { + while ((subCylinder = toCylinder->queryDestination(index, item, toItem, flags)) != toCylinder) { + if (subCylinder == nullptr) { + break; + } + toCylinder = subCylinder; flags = 0; @@ -2178,10 +2190,10 @@ ReturnValue Game::internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std:: return ret; } - if (std::shared_ptr<Player> player = actor->getPlayer()) { + if (const auto &playerActor = actor->getPlayer()) { // Refresh depot search window if necessary - if (player->isDepotSearchOpenOnItem(item->getID()) && ((fromCylinder->getItem() && fromCylinder->getItem()->isInsideDepot(true)) || (toCylinder->getItem() && toCylinder->getItem()->isInsideDepot(true)))) { - player->requestDepotSearchItem(item->getID(), item->getTier()); + if (playerActor->isDepotSearchOpenOnItem(item->getID()) && ((fromCylinder->getItem() && fromCylinder->getItem()->isInsideDepot(true)) || (toCylinder->getItem() && toCylinder->getItem()->isInsideDepot(true)))) { + playerActor->requestDepotSearchItem(item->getID(), item->getTier()); } const ItemType &it = Item::items[fromCylinder->getItem()->getID()]; @@ -2190,8 +2202,8 @@ ReturnValue Game::internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std:: } // Looting analyser - if (it.isCorpse && toContainer->getTopParent() == player && item->getIsLootTrackeable()) { - player->sendLootStats(item, static_cast<uint8_t>(item->getItemCount())); + if (it.isCorpse && toContainer->getTopParent() == playerActor && item->getIsLootTrackeable()) { + playerActor->sendLootStats(item, static_cast<uint8_t>(item->getItemCount())); } } } @@ -2199,12 +2211,12 @@ ReturnValue Game::internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std:: return ret; } -ReturnValue Game::internalAddItem(std::shared_ptr<Cylinder> toCylinder, std::shared_ptr<Item> item, int32_t index /*= INDEX_WHEREEVER*/, uint32_t flags /* = 0*/, bool test /* = false*/) { +ReturnValue Game::internalAddItem(std::shared_ptr<Cylinder> toCylinder, const std::shared_ptr<Item> &item, int32_t index /*= INDEX_WHEREEVER*/, uint32_t flags /* = 0*/, bool test /* = false*/) { uint32_t remainderCount = 0; - return internalAddItem(std::move(toCylinder), std::move(item), index, flags, test, remainderCount); + return internalAddItem(std::move(toCylinder), item, index, flags, test, remainderCount); } -ReturnValue Game::internalAddItem(std::shared_ptr<Cylinder> toCylinder, std::shared_ptr<Item> item, int32_t index, uint32_t flags, bool test, uint32_t &remainderCount) { +ReturnValue Game::internalAddItem(std::shared_ptr<Cylinder> toCylinder, const std::shared_ptr<Item> &item, int32_t index, uint32_t flags, bool test, uint32_t &remainderCount) { metrics::method_latency measure(__METHOD_NAME__); if (toCylinder == nullptr) { g_logger().error("[{}] fromCylinder is nullptr", __FUNCTION__); @@ -2219,7 +2231,7 @@ ReturnValue Game::internalAddItem(std::shared_ptr<Cylinder> toCylinder, std::sha std::shared_ptr<Cylinder> destCylinder = toCylinder; std::shared_ptr<Item> toItem = nullptr; - toCylinder = toCylinder->queryDestination(index, item, &toItem, flags); + toCylinder = toCylinder->queryDestination(index, item, toItem, flags); // check if we can add this item ReturnValue ret = toCylinder->queryAdd(index, item, item->getItemCount(), flags); @@ -2291,7 +2303,8 @@ ReturnValue Game::internalAddItem(std::shared_ptr<Cylinder> toCylinder, std::sha return RETURNVALUE_NOERROR; } -ReturnValue Game::internalRemoveItem(std::shared_ptr<Item> item, int32_t count /*= -1*/, bool test /*= false*/, uint32_t flags /*= 0*/, bool force /*= false*/) { +ReturnValue Game::internalRemoveItem(const std::shared_ptr<Item> &items, int32_t count /*= -1*/, bool test /*= false*/, uint32_t flags /*= 0*/, bool force /*= false*/) { + auto item = items; metrics::method_latency measure(__METHOD_NAME__); if (item == nullptr) { g_logger().debug("{} - Item is nullptr", __FUNCTION__); @@ -2302,7 +2315,7 @@ ReturnValue Game::internalRemoveItem(std::shared_ptr<Item> item, int32_t count / g_logger().debug("{} - Cylinder is nullptr", __FUNCTION__); return RETURNVALUE_NOTPOSSIBLE; } - std::shared_ptr<Tile> fromTile = cylinder->getTile(); + const auto &fromTile = cylinder->getTile(); if (fromTile) { if (fromTile && browseFields.contains(fromTile) && browseFields[fromTile].lock() == cylinder) { cylinder = fromTile; @@ -2342,7 +2355,7 @@ ReturnValue Game::internalRemoveItem(std::shared_ptr<Item> item, int32_t count / cylinder->postRemoveNotification(item, nullptr, index); } - std::shared_ptr<Item> quiver = cylinder->getItem(); + const auto &quiver = cylinder->getItem(); if (quiver && quiver->isQuiver() && quiver->getHoldingPlayer() && quiver->getHoldingPlayer()->getThing(CONST_SLOT_RIGHT) == quiver) { @@ -2373,7 +2386,7 @@ std::tuple<ReturnValue, uint32_t, uint32_t> Game::addItemBatch(const std::shared } metrics::method_latency measure(__METHOD_NAME__); - const auto player = toCylinder->getPlayer(); + const auto &player = toCylinder->getPlayer(); bool dropping = false; auto setupDestination = [&]() -> std::shared_ptr<Cylinder> { if (autoContainerId == 0) { @@ -2485,7 +2498,7 @@ std::tuple<ReturnValue, uint32_t, uint32_t> Game::createItem(const std::shared_p return createItemBatch(toCylinder, { std::make_tuple(itemId, count, subType) }, flags, dropOnMap, autoContainerId); } -ReturnValue Game::internalPlayerAddItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, bool dropOnMap /*= true*/, Slots_t slot /*= CONST_SLOT_WHEREEVER*/) { +ReturnValue Game::internalPlayerAddItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, bool dropOnMap /*= true*/, Slots_t slot /*= CONST_SLOT_WHEREEVER*/) { metrics::method_latency measure(__METHOD_NAME__); uint32_t remainderCount = 0; ReturnValue ret; @@ -2517,7 +2530,7 @@ ReturnValue Game::internalPlayerAddItem(std::shared_ptr<Player> player, std::sha return ret; } -std::shared_ptr<Item> Game::findItemOfType(std::shared_ptr<Cylinder> cylinder, uint16_t itemId, bool depthSearch /*= true*/, int32_t subType /*= -1*/) const { +std::shared_ptr<Item> Game::findItemOfType(const std::shared_ptr<Cylinder> &cylinder, uint16_t itemId, bool depthSearch /*= true*/, int32_t subType /*= -1*/) const { metrics::method_latency measure(__METHOD_NAME__); if (cylinder == nullptr) { g_logger().error("[{}] Cylinder is nullptr", __FUNCTION__); @@ -2526,12 +2539,12 @@ std::shared_ptr<Item> Game::findItemOfType(std::shared_ptr<Cylinder> cylinder, u std::vector<std::shared_ptr<Container>> containers; for (size_t i = cylinder->getFirstIndex(), j = cylinder->getLastIndex(); i < j; ++i) { - std::shared_ptr<Thing> thing = cylinder->getThing(i); + const std::shared_ptr<Thing> &thing = cylinder->getThing(i); if (!thing) { continue; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { continue; } @@ -2541,7 +2554,7 @@ std::shared_ptr<Item> Game::findItemOfType(std::shared_ptr<Cylinder> cylinder, u } if (depthSearch) { - std::shared_ptr<Container> container = item->getContainer(); + const std::shared_ptr<Container> &container = item->getContainer(); if (container) { containers.push_back(container); } @@ -2550,13 +2563,13 @@ std::shared_ptr<Item> Game::findItemOfType(std::shared_ptr<Cylinder> cylinder, u size_t i = 0; while (i < containers.size()) { - std::shared_ptr<Container> container = containers[i++]; - for (std::shared_ptr<Item> item : container->getItemList()) { + const std::shared_ptr<Container> &container = containers[i++]; + for (const auto &item : container->getItemList()) { if (item->getID() == itemId && (subType == -1 || subType == item->getSubType())) { return item; } - std::shared_ptr<Container> subContainer = item->getContainer(); + const std::shared_ptr<Container> &subContainer = item->getContainer(); if (subContainer) { containers.push_back(subContainer); } @@ -2565,7 +2578,7 @@ std::shared_ptr<Item> Game::findItemOfType(std::shared_ptr<Cylinder> cylinder, u return nullptr; } -bool Game::removeMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint32_t flags /*= 0*/, bool useBalance /*= false*/) { +bool Game::removeMoney(const std::shared_ptr<Cylinder> &cylinder, uint64_t money, uint32_t flags /*= 0*/, bool useBalance /*= false*/) { if (cylinder == nullptr) { g_logger().error("[{}] cylinder is nullptr", __FUNCTION__); return false; @@ -2577,15 +2590,15 @@ bool Game::removeMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint3 std::multimap<uint32_t, std::shared_ptr<Item>> moneyMap; uint64_t moneyCount = 0; for (size_t i = cylinder->getFirstIndex(), j = cylinder->getLastIndex(); i < j; ++i) { - std::shared_ptr<Thing> thing = cylinder->getThing(i); + const std::shared_ptr<Thing> &thing = cylinder->getThing(i); if (!thing) { continue; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { continue; } - std::shared_ptr<Container> container = item->getContainer(); + const std::shared_ptr<Container> &container = item->getContainer(); if (container) { containers.push_back(container); } else { @@ -2598,9 +2611,9 @@ bool Game::removeMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint3 } size_t i = 0; while (i < containers.size()) { - std::shared_ptr<Container> container = containers[i++]; + const std::shared_ptr<Container> &container = containers[i++]; for (const std::shared_ptr<Item> &item : container->getItemList()) { - std::shared_ptr<Container> tmpContainer = item->getContainer(); + const std::shared_ptr<Container> &tmpContainer = item->getContainer(); if (tmpContainer) { containers.push_back(tmpContainer); } else { @@ -2613,7 +2626,7 @@ bool Game::removeMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint3 } } - std::shared_ptr<Player> player = useBalance ? std::dynamic_pointer_cast<Player>(cylinder) : nullptr; + const auto &player = useBalance ? std::dynamic_pointer_cast<Player>(cylinder) : nullptr; uint64_t balance = 0; if (useBalance && player) { balance = player->getBankBalance(); @@ -2624,7 +2637,7 @@ bool Game::removeMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint3 } for (const auto &moneyEntry : moneyMap) { - std::shared_ptr<Item> item = moneyEntry.second; + const std::shared_ptr<Item> &item = moneyEntry.second; if (moneyEntry.first < money) { internalRemoveItem(item); money -= moneyEntry.first; @@ -2647,7 +2660,7 @@ bool Game::removeMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint3 return true; } -void Game::addMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint32_t flags /*= 0*/) { +void Game::addMoney(const std::shared_ptr<Cylinder> &cylinder, uint64_t money, uint32_t flags /*= 0*/) { if (cylinder == nullptr) { g_logger().error("[{}] cylinder is nullptr", __FUNCTION__); return; @@ -2656,40 +2669,30 @@ void Game::addMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint32_t return; } - uint32_t crystalCoins = money / 10000; - money -= crystalCoins * 10000; - while (crystalCoins > 0) { - const uint16_t count = std::min<uint32_t>(100, crystalCoins); + auto addCoins = [&](uint16_t itemId, uint32_t count) { + while (count > 0) { + const uint16_t createCount = std::min<uint32_t>(100, count); + const std::shared_ptr<Item> &remaindItem = Item::CreateItem(itemId, createCount); - std::shared_ptr<Item> remaindItem = Item::CreateItem(ITEM_CRYSTAL_COIN, count); + ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags); + if (ret != RETURNVALUE_NOERROR) { + internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT); + } - ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags); - if (ret != RETURNVALUE_NOERROR) { - internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT); + count -= createCount; } + }; - crystalCoins -= count; - } + uint32_t crystalCoins = money / 10000; + money -= crystalCoins * 10000; + addCoins(ITEM_CRYSTAL_COIN, crystalCoins); uint16_t platinumCoins = money / 100; - if (platinumCoins != 0) { - std::shared_ptr<Item> remaindItem = Item::CreateItem(ITEM_PLATINUM_COIN, platinumCoins); + money -= platinumCoins * 100; + addCoins(ITEM_PLATINUM_COIN, platinumCoins); - ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags); - if (ret != RETURNVALUE_NOERROR) { - internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT); - } - - money -= platinumCoins * 100; - } - - if (money != 0) { - std::shared_ptr<Item> remaindItem = Item::CreateItem(ITEM_GOLD_COIN, money); - - ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags); - if (ret != RETURNVALUE_NOERROR) { - internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT); - } + if (money > 0) { + addCoins(ITEM_GOLD_COIN, money); } } @@ -2860,13 +2863,13 @@ ReturnValue Game::internalTeleport(const std::shared_ptr<Thing> &thing, const Po }); return RETURNVALUE_NOERROR; - } else if (std::shared_ptr<Item> item = thing->getItem()) { + } else if (const auto &item = thing->getItem()) { return internalMoveItem(item->getParent(), toTile, INDEX_WHEREEVER, item, item->getItemCount(), nullptr, flags); } return RETURNVALUE_NOTPOSSIBLE; } -void Game::playerQuickLootCorpse(std::shared_ptr<Player> player, std::shared_ptr<Container> corpse, const Position &position) { +void Game::playerQuickLootCorpse(const std::shared_ptr<Player> &player, const std::shared_ptr<Container> &corpse, const Position &position) { if (!player || !corpse) { return; } @@ -2878,7 +2881,7 @@ void Game::playerQuickLootCorpse(std::shared_ptr<Player> player, std::shared_ptr bool missedAnyItem = false; for (ContainerIterator it = corpse->iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; + const auto &item = *it; bool listed = player->isQuickLootListedItem(item); if ((listed && ignoreListItems) || (!listed && !ignoreListItems)) { if (item->getWorth() != 0) { @@ -3005,7 +3008,7 @@ void Game::playerQuickLootCorpse(std::shared_ptr<Player> player, std::shared_ptr player->lastQuickLootNotification = OTSYS_TIME(); } -std::shared_ptr<Container> Game::findManagedContainer(std::shared_ptr<Player> player, bool &fallbackConsumed, ObjectCategory_t category, bool isLootContainer) { +std::shared_ptr<Container> Game::findManagedContainer(const std::shared_ptr<Player> &player, bool &fallbackConsumed, ObjectCategory_t category, bool isLootContainer) { auto lootContainer = player->getManagedContainer(category, isLootContainer); if (!lootContainer && player->quickLootFallbackToMainContainer && !fallbackConsumed) { auto fallbackItem = player->getInventoryItem(CONST_SLOT_BACKPACK); @@ -3046,7 +3049,7 @@ std::shared_ptr<Container> Game::findNextAvailableContainer(ContainerIterator &c return nullptr; } -bool Game::handleFallbackLogic(std::shared_ptr<Player> player, std::shared_ptr<Container> &lootContainer, ContainerIterator &containerIterator, const bool &fallbackConsumed) { +bool Game::handleFallbackLogic(const std::shared_ptr<Player> &player, std::shared_ptr<Container> &lootContainer, ContainerIterator &containerIterator, const bool &fallbackConsumed) { if (fallbackConsumed || !player->quickLootFallbackToMainContainer) { return false; } @@ -3062,7 +3065,7 @@ bool Game::handleFallbackLogic(std::shared_ptr<Player> player, std::shared_ptr<C return true; } -ReturnValue Game::processMoveOrAddItemToLootContainer(std::shared_ptr<Item> item, std::shared_ptr<Container> lootContainer, uint32_t &remainderCount, std::shared_ptr<Player> player) { +ReturnValue Game::processMoveOrAddItemToLootContainer(const std::shared_ptr<Item> &item, const std::shared_ptr<Container> &lootContainer, uint32_t &remainderCount, const std::shared_ptr<Player> &player) { std::shared_ptr<Item> moveItem = nullptr; ReturnValue ret; if (item->getParent()) { @@ -3076,7 +3079,7 @@ ReturnValue Game::processMoveOrAddItemToLootContainer(std::shared_ptr<Item> item return ret; } -ReturnValue Game::processLootItems(std::shared_ptr<Player> player, std::shared_ptr<Container> lootContainer, std::shared_ptr<Item> item, bool &fallbackConsumed) { +ReturnValue Game::processLootItems(const std::shared_ptr<Player> &player, std::shared_ptr<Container> lootContainer, const std::shared_ptr<Item> &item, bool &fallbackConsumed) { std::shared_ptr<Container> lastSubContainer = nullptr; uint32_t remainderCount = item->getItemCount(); ContainerIterator containerIterator = lootContainer->iterator(); @@ -3098,7 +3101,7 @@ ReturnValue Game::processLootItems(std::shared_ptr<Player> player, std::shared_p return ret; } -ReturnValue Game::internalCollectManagedItems(std::shared_ptr<Player> player, std::shared_ptr<Item> item, ObjectCategory_t category /* = OBJECTCATEGORY_DEFAULT*/, bool isLootContainer /* = true*/) { +ReturnValue Game::internalCollectManagedItems(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, ObjectCategory_t category /* = OBJECTCATEGORY_DEFAULT*/, bool isLootContainer /* = true*/) { if (!player || !item) { return RETURNVALUE_NOTPOSSIBLE; } @@ -3136,7 +3139,7 @@ ReturnValue Game::internalCollectManagedItems(std::shared_ptr<Player> player, st return processLootItems(player, lootContainer, item, fallbackConsumed); } -ReturnValue Game::collectRewardChestItems(std::shared_ptr<Player> player, uint32_t maxMoveItems /* = 0*/) { +ReturnValue Game::collectRewardChestItems(const std::shared_ptr<Player> &player, uint32_t maxMoveItems /* = 0*/) { // Check if have item on player reward chest std::shared_ptr<RewardChest> rewardChest = player->getRewardChest(); if (rewardChest->empty()) { @@ -3179,7 +3182,7 @@ ReturnValue Game::collectRewardChestItems(std::shared_ptr<Player> player, uint32 return RETURNVALUE_NOERROR; } -ObjectCategory_t Game::getObjectCategory(std::shared_ptr<Item> item) { +ObjectCategory_t Game::getObjectCategory(const std::shared_ptr<Item> &item) { ObjectCategory_t category = OBJECTCATEGORY_DEFAULT; if (!item) { return OBJECTCATEGORY_NONE; @@ -3282,7 +3285,7 @@ uint64_t Game::getItemMarketPrice(const std::map<uint16_t, uint64_t> &itemMap, b return total; } -std::shared_ptr<Item> searchForItem(std::shared_ptr<Container> container, uint16_t itemId, bool hasTier /* = false*/, uint8_t tier /* = 0*/) { +std::shared_ptr<Item> searchForItem(const std::shared_ptr<Container> &container, uint16_t itemId, bool hasTier /* = false*/, uint8_t tier /* = 0*/) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { if ((*it)->getID() == itemId && (!hasTier || (*it)->getTier() == tier)) { return *it; @@ -3319,9 +3322,8 @@ Slots_t getSlotType(const ItemType &it) { return slot; } -// Implementation of player invoked events void Game::playerEquipItem(uint32_t playerId, uint16_t itemId, bool hasTier /* = false*/, uint8_t tier /* = 0*/) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3334,12 +3336,12 @@ void Game::playerEquipItem(uint32_t playerId, uint16_t itemId, bool hasTier /* = return; } - std::shared_ptr<Item> item = player->getInventoryItem(CONST_SLOT_BACKPACK); + const auto &item = player->getInventoryItem(CONST_SLOT_BACKPACK); if (!item) { return; } - std::shared_ptr<Container> backpack = item->getContainer(); + const std::shared_ptr<Container> &backpack = item->getContainer(); if (!backpack) { return; } @@ -3352,8 +3354,8 @@ void Game::playerEquipItem(uint32_t playerId, uint16_t itemId, bool hasTier /* = const ItemType &it = Item::items[itemId]; Slots_t slot = getSlotType(it); - auto slotItem = player->getInventoryItem(slot); - auto equipItem = searchForItem(backpack, it.id, hasTier, tier); + const auto &slotItem = player->getInventoryItem(slot); + const auto &equipItem = searchForItem(backpack, it.id, hasTier, tier); ReturnValue ret = RETURNVALUE_NOERROR; if (slotItem && slotItem->getID() == it.id && (!it.stackable || slotItem->getItemCount() == slotItem->getStackSize() || !equipItem)) { ret = internalMoveItem(slotItem->getParent(), player, CONST_SLOT_WHEREEVER, slotItem, slotItem->getItemCount(), nullptr); @@ -3397,7 +3399,7 @@ void Game::playerEquipItem(uint32_t playerId, uint16_t itemId, bool hasTier /* = } void Game::playerMove(uint32_t playerId, Direction direction) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3410,7 +3412,7 @@ void Game::playerMove(uint32_t playerId, Direction direction) { } void Game::forcePlayerMove(uint32_t playerId, Direction direction) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3422,7 +3424,7 @@ void Game::forcePlayerMove(uint32_t playerId, Direction direction) { player->startAutoWalk(std::vector<Direction> { direction }, true); } -bool Game::playerBroadcastMessage(std::shared_ptr<Player> player, const std::string &text) const { +bool Game::playerBroadcastMessage(const std::shared_ptr<Player> &player, const std::string &text) const { if (!player->hasFlag(PlayerFlags_t::CanBroadcast)) { return false; } @@ -3437,7 +3439,7 @@ bool Game::playerBroadcastMessage(std::shared_ptr<Player> player, const std::str } void Game::playerCreatePrivateChannel(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->isPremium()) { return; } @@ -3451,7 +3453,7 @@ void Game::playerCreatePrivateChannel(uint32_t playerId) { } void Game::playerChannelInvite(uint32_t playerId, const std::string &name) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3474,7 +3476,7 @@ void Game::playerChannelInvite(uint32_t playerId, const std::string &name) { } void Game::playerChannelExclude(uint32_t playerId, const std::string &name) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3497,7 +3499,7 @@ void Game::playerChannelExclude(uint32_t playerId, const std::string &name) { } void Game::playerRequestChannels(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3506,7 +3508,7 @@ void Game::playerRequestChannels(uint32_t playerId) { } void Game::playerOpenChannel(uint32_t playerId, uint16_t channelId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3528,7 +3530,7 @@ void Game::playerOpenChannel(uint32_t playerId, uint16_t channelId) { } void Game::playerCloseChannel(uint32_t playerId, uint16_t channelId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3537,7 +3539,7 @@ void Game::playerCloseChannel(uint32_t playerId, uint16_t channelId) { } void Game::playerOpenPrivateChannel(uint32_t playerId, std::string &receiver) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3567,7 +3569,7 @@ void Game::playerCloseNpcChannel(uint32_t playerId) { } void Game::playerReceivePing(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3576,7 +3578,7 @@ void Game::playerReceivePing(uint32_t playerId) { } void Game::playerReceivePingBack(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3585,7 +3587,7 @@ void Game::playerReceivePingBack(uint32_t playerId) { } void Game::playerAutoWalk(uint32_t playerId, const std::vector<Direction> &listDir) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3596,7 +3598,7 @@ void Game::playerAutoWalk(uint32_t playerId, const std::vector<Direction> &listD } void Game::forcePlayerAutoWalk(uint32_t playerId, const std::vector<Direction> &listDir) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3613,7 +3615,7 @@ void Game::forcePlayerAutoWalk(uint32_t playerId, const std::vector<Direction> & } void Game::playerStopAutoWalk(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3623,7 +3625,7 @@ void Game::playerStopAutoWalk(uint32_t playerId) { void Game::playerUseItemEx(uint32_t playerId, const Position &fromPos, uint8_t fromStackPos, uint16_t fromItemId, const Position &toPos, uint8_t toStackPos, uint16_t toItemId) { metrics::method_latency measure(__METHOD_NAME__); - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3633,13 +3635,13 @@ void Game::playerUseItemEx(uint32_t playerId, const Position &fromPos, uint8_t f return; } - std::shared_ptr<Thing> thing = internalGetThing(player, fromPos, fromStackPos, fromItemId, STACKPOS_FIND_THING); + const std::shared_ptr<Thing> &thing = internalGetThing(player, fromPos, fromStackPos, fromItemId, STACKPOS_FIND_THING); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || !item->isMultiUse() || item->getID() != fromItemId) { player->sendCancelMessage(RETURNVALUE_CANNOTUSETHISOBJECT); return; @@ -3768,7 +3770,7 @@ void Game::playerUseItemEx(uint32_t playerId, const Position &fromPos, uint8_t f void Game::playerUseItem(uint32_t playerId, const Position &pos, uint8_t stackPos, uint8_t index, uint16_t itemId) { metrics::method_latency measure(__METHOD_NAME__); - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -3778,13 +3780,13 @@ void Game::playerUseItem(uint32_t playerId, const Position &pos, uint8_t stackPo return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); + const auto &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->isMultiUse() || item->getID() != itemId) { player->sendCancelMessage(RETURNVALUE_CANNOTUSETHISOBJECT); return; @@ -3878,12 +3880,12 @@ void Game::playerUseItem(uint32_t playerId, const Position &pos, uint8_t stackPo void Game::playerUseWithCreature(uint32_t playerId, const Position &fromPos, uint8_t fromStackPos, uint32_t creatureId, uint16_t itemId) { metrics::method_latency measure(__METHOD_NAME__); - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } - std::shared_ptr<Creature> creature = getCreatureByID(creatureId); + const std::shared_ptr<Creature> &creature = getCreatureByID(creatureId); if (!creature) { return; } @@ -3900,13 +3902,13 @@ void Game::playerUseWithCreature(uint32_t playerId, const Position &fromPos, uin } } - std::shared_ptr<Thing> thing = internalGetThing(player, fromPos, fromStackPos, itemId, STACKPOS_FIND_THING); + const std::shared_ptr<Thing> &thing = internalGetThing(player, fromPos, fromStackPos, itemId, STACKPOS_FIND_THING); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || !item->isMultiUse() || item->getID() != itemId) { player->sendCancelMessage(RETURNVALUE_CANNOTUSETHISOBJECT); return; @@ -4035,7 +4037,7 @@ void Game::playerUseWithCreature(uint32_t playerId, const Position &fromPos, uin } void Game::playerCloseContainer(uint32_t playerId, uint8_t cid) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4045,7 +4047,7 @@ void Game::playerCloseContainer(uint32_t playerId, uint8_t cid) { } void Game::playerMoveUpContainer(uint32_t playerId, uint8_t cid) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4097,7 +4099,7 @@ void Game::playerMoveUpContainer(uint32_t playerId, uint8_t cid) { } void Game::playerUpdateContainer(uint32_t playerId, uint8_t cid) { - std::shared_ptr<Player> player = getPlayerByGUID(playerId); + const auto &player = getPlayerByGUID(playerId); if (!player) { return; } @@ -4111,17 +4113,17 @@ void Game::playerUpdateContainer(uint32_t playerId, uint8_t cid) { } void Game::playerRotateItem(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); + const auto &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->getID() != itemId || !item->isRotatable() || item->hasAttribute(ItemAttribute_t::UNIQUEID)) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -4166,17 +4168,17 @@ void Game::playerRotateItem(uint32_t playerId, const Position &pos, uint8_t stac } void Game::playerConfigureShowOffSocket(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || pos.x == 0xFFFF) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->getID() != itemId || !item->isPodium() || item->hasAttribute(ItemAttribute_t::UNIQUEID)) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -4230,17 +4232,17 @@ void Game::playerConfigureShowOffSocket(uint32_t playerId, const Position &pos, } void Game::playerSetShowOffSocket(uint32_t playerId, Outfit_t &outfit, const Position &pos, uint8_t stackPos, const uint16_t itemId, uint8_t podiumVisible, uint8_t direction) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || pos.x == 0xFFFF) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->getID() != itemId || !item->isPodium() || item->hasAttribute(ItemAttribute_t::UNIQUEID)) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -4256,7 +4258,7 @@ void Game::playerSetShowOffSocket(uint32_t playerId, Outfit_t &outfit, const Pos return; } - const auto tile = item->getParent() ? item->getParent()->getTile() : nullptr; + const auto &tile = item->getParent() ? item->getParent()->getTile() : nullptr; if (!tile) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -4364,24 +4366,35 @@ void Game::playerSetShowOffSocket(uint32_t playerId, Outfit_t &outfit, const Pos } void Game::playerWrapableItem(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); + const auto &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); if (!thing) { return; } - const auto item = thing->getItem(); - const auto tile = map.getTile(item->getPosition()); + const auto &item = thing->getItem(); + if (!item) { + g_logger().error("Game::playerWrapableItem: Invalid item on position: {}", pos.toString()); + player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); + return; + } + const auto &tile = map.getTile(item->getPosition()); + if (!tile) { + g_logger().error("Game::playerWrapableItem: Invalid tile on position: {}", pos.toString()); + player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); + return; + } + const auto houseTile = tile->dynamic_self_cast<HouseTile>(); if (!tile->hasFlag(TILESTATE_PROTECTIONZONE) || !houseTile) { player->sendCancelMessage("You may construct this only inside a house."); return; } - const auto house = houseTile->getHouse(); + const auto &house = houseTile->getHouse(); if (!house) { player->sendCancelMessage("You may construct this only inside a house."); return; @@ -4461,7 +4474,7 @@ void Game::playerWrapableItem(uint32_t playerId, const Position &pos, uint8_t st addMagicEffect(pos, CONST_ME_POFF); } -std::shared_ptr<Item> Game::wrapItem(std::shared_ptr<Item> item, std::shared_ptr<House> house) { +std::shared_ptr<Item> Game::wrapItem(const std::shared_ptr<Item> &item, const std::shared_ptr<House> &house) { uint16_t hiddenCharges = 0; uint16_t amount = item->getItemCount(); if (isCaskItem(item->getID())) { @@ -4477,27 +4490,27 @@ std::shared_ptr<Item> Game::wrapItem(std::shared_ptr<Item> item, std::shared_ptr newItem->setCustomAttribute("unWrapId", static_cast<int64_t>(oldItemID)); newItem->setAttribute(ItemAttribute_t::DESCRIPTION, "Unwrap it in your own house to create a <" + itemName + ">."); if (hiddenCharges > 0) { - newItem->setAttribute(DATE, hiddenCharges); + newItem->setAttribute(ItemAttribute_t::DATE, hiddenCharges); } if (amount > 0) { - newItem->setAttribute(AMOUNT, amount); + newItem->setAttribute(ItemAttribute_t::AMOUNT, amount); } newItem->startDecaying(); return newItem; } -void Game::unwrapItem(std::shared_ptr<Item> item, uint16_t unWrapId, std::shared_ptr<House> house, std::shared_ptr<Player> player) { +void Game::unwrapItem(const std::shared_ptr<Item> &item, uint16_t unWrapId, const std::shared_ptr<House> &house, const std::shared_ptr<Player> &player) { if (item->hasOwner() && !item->isOwner(player)) { player->sendCancelMessage(RETURNVALUE_ITEMISNOTYOURS); return; } - auto hiddenCharges = item->getAttribute<uint16_t>(DATE); + auto hiddenCharges = item->getAttribute<uint16_t>(ItemAttribute_t::DATE); const ItemType &newiType = Item::items.getItemType(unWrapId); if (player != nullptr && house != nullptr && newiType.isBed() && house->getMaxBeds() > -1 && house->getBedCount() >= house->getMaxBeds()) { player->sendCancelMessage("You reached the maximum beds in this house"); return; } - auto amount = item->getAttribute<uint16_t>(AMOUNT); + auto amount = item->getAttribute<uint16_t>(ItemAttribute_t::AMOUNT); if (!amount) { amount = 1; } @@ -4510,13 +4523,13 @@ void Game::unwrapItem(std::shared_ptr<Item> item, uint16_t unWrapId, std::shared newItem->setSubType(hiddenCharges); } newItem->removeCustomAttribute("unWrapId"); - newItem->removeAttribute(DESCRIPTION); + newItem->removeAttribute(ItemAttribute_t::DESCRIPTION); newItem->startDecaying(); } } void Game::playerWriteItem(uint32_t playerId, uint32_t windowTextId, const std::string &text) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4580,7 +4593,7 @@ void Game::playerWriteItem(uint32_t playerId, uint32_t windowTextId, const std:: } void Game::playerBrowseField(uint32_t playerId, const Position &pos) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4644,7 +4657,7 @@ void Game::playerBrowseField(uint32_t playerId, const Position &pos) { } void Game::playerStowItem(uint32_t playerId, const Position &pos, uint16_t itemId, uint8_t stackpos, uint8_t count, bool allItems) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4654,12 +4667,12 @@ void Game::playerStowItem(uint32_t playerId, const Position &pos, uint16_t itemI return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackpos, itemId, STACKPOS_TOPDOWN_ITEM); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackpos, itemId, STACKPOS_TOPDOWN_ITEM); if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->getID() != itemId || item->getItemCount() < count || item->isStoreItem()) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -4685,7 +4698,7 @@ void Game::playerStowItem(uint32_t playerId, const Position &pos, uint16_t itemI } void Game::playerStashWithdraw(uint32_t playerId, uint16_t itemId, uint32_t count, uint8_t) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4760,7 +4773,7 @@ void Game::playerStashWithdraw(uint32_t playerId, uint16_t itemId, uint32_t coun } void Game::playerSeekInContainer(uint32_t playerId, uint8_t containerId, uint16_t index, uint8_t containerCategory) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4785,7 +4798,7 @@ void Game::playerSeekInContainer(uint32_t playerId, uint8_t containerId, uint16_ } void Game::playerUpdateHouseWindow(uint32_t playerId, uint8_t listId, uint32_t windowTextId, const std::string &text) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4802,7 +4815,7 @@ void Game::playerUpdateHouseWindow(uint32_t playerId, uint8_t listId, uint32_t w } void Game::playerRequestTrade(uint32_t playerId, const Position &pos, uint8_t stackPos, uint32_t tradePlayerId, uint16_t itemId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -4876,10 +4889,10 @@ void Game::playerRequestTrade(uint32_t playerId, const Position &pos, uint8_t st return; } - std::shared_ptr<Container> tradeItemContainer = tradeItem->getContainer(); + const std::shared_ptr<Container> &tradeItemContainer = tradeItem->getContainer(); if (tradeItemContainer) { for (const auto &it : tradeItems) { - std::shared_ptr<Item> item = it.first; + const auto &item = it.first; if (tradeItem == item) { player->sendTextMessage(MESSAGE_TRADE, "This item is already being traded."); return; @@ -4890,7 +4903,7 @@ void Game::playerRequestTrade(uint32_t playerId, const Position &pos, uint8_t st return; } - std::shared_ptr<Container> container = item->getContainer(); + const std::shared_ptr<Container> &container = item->getContainer(); if (container && container->isHoldingItem(tradeItem)) { player->sendTextMessage(MESSAGE_TRADE, "This item is already being traded."); return; @@ -4898,13 +4911,13 @@ void Game::playerRequestTrade(uint32_t playerId, const Position &pos, uint8_t st } } else { for (const auto &it : tradeItems) { - std::shared_ptr<Item> item = it.first; + const auto &item = it.first; if (tradeItem == item) { player->sendTextMessage(MESSAGE_TRADE, "This item is already being traded."); return; } - std::shared_ptr<Container> container = item->getContainer(); + const std::shared_ptr<Container> &container = item->getContainer(); if (container && container->isHoldingItem(tradeItem)) { player->sendTextMessage(MESSAGE_TRADE, "This item is already being traded."); return; @@ -4912,8 +4925,7 @@ void Game::playerRequestTrade(uint32_t playerId, const Position &pos, uint8_t st } } - auto tradeContainer = tradeItem->getContainer(); - if (tradeContainer && tradeContainer->getItemHoldingCount() + 1 > 100) { + if (tradeItemContainer && tradeItemContainer->getItemHoldingCount() + 1 > 100) { player->sendTextMessage(MESSAGE_TRADE, "You can not trade more than 100 items."); return; } @@ -4943,7 +4955,7 @@ void Game::playerRequestTrade(uint32_t playerId, const Position &pos, uint8_t st internalStartTrade(player, tradePartner, tradeItem); } -bool Game::internalStartTrade(std::shared_ptr<Player> player, std::shared_ptr<Player> tradePartner, std::shared_ptr<Item> tradeItem) { +bool Game::internalStartTrade(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &tradePartner, const std::shared_ptr<Item> &tradeItem) { if (player->tradeState != TRADE_NONE && !(player->tradeState == TRADE_ACKNOWLEDGE && player->tradePartner == tradePartner)) { player->sendCancelMessage(RETURNVALUE_YOUAREALREADYTRADING); return false; @@ -4979,7 +4991,7 @@ bool Game::internalStartTrade(std::shared_ptr<Player> player, std::shared_ptr<Pl } void Game::playerAcceptTrade(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5080,7 +5092,7 @@ void Game::playerAcceptTrade(uint32_t playerId) { } } -std::string Game::getTradeErrorDescription(ReturnValue ret, std::shared_ptr<Item> item) { +std::string Game::getTradeErrorDescription(ReturnValue ret, const std::shared_ptr<Item> &item) { if (item) { if (ret == RETURNVALUE_NOTENOUGHCAPACITY) { std::ostringstream ss; @@ -5112,7 +5124,7 @@ std::string Game::getTradeErrorDescription(ReturnValue ret, std::shared_ptr<Item } void Game::playerLookInTrade(uint32_t playerId, bool lookAtCounterOffer, uint8_t index) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5171,7 +5183,7 @@ void Game::playerLookInTrade(uint32_t playerId, bool lookAtCounterOffer, uint8_t } void Game::playerCloseTrade(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5179,7 +5191,7 @@ void Game::playerCloseTrade(uint32_t playerId) { internalCloseTrade(player); } -void Game::internalCloseTrade(std::shared_ptr<Player> player) { +void Game::internalCloseTrade(const std::shared_ptr<Player> &player) { std::shared_ptr<Player> tradePartner = player->tradePartner; if ((tradePartner && tradePartner->getTradeState() == TRADE_TRANSFER) || player->getTradeState() == TRADE_TRANSFER) { return; @@ -5226,7 +5238,7 @@ void Game::playerBuyItem(uint32_t playerId, uint16_t itemId, uint8_t count, uint return; } - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5282,7 +5294,7 @@ void Game::playerSellItem(uint32_t playerId, uint16_t itemId, uint8_t count, uin return; } - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5312,7 +5324,7 @@ void Game::playerSellItem(uint32_t playerId, uint16_t itemId, uint8_t count, uin } void Game::playerCloseShop(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5321,7 +5333,7 @@ void Game::playerCloseShop(uint32_t playerId) { } void Game::playerLookInShop(uint32_t playerId, uint16_t itemId, uint8_t count) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5351,12 +5363,12 @@ void Game::playerLookInShop(uint32_t playerId, uint16_t itemId, uint8_t count) { } void Game::playerLookAt(uint32_t playerId, uint16_t itemId, const Position &pos, uint8_t stackPos) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_LOOK); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_LOOK); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -5386,7 +5398,7 @@ void Game::playerLookAt(uint32_t playerId, uint16_t itemId, const Position &pos, } void Game::playerLookInBattleList(uint32_t playerId, uint32_t creatureId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5420,8 +5432,8 @@ void Game::playerLookInBattleList(uint32_t playerId, uint32_t creatureId) { g_callbacks().executeCallback(EventCallback_t::playerOnLookInBattleList, &EventCallback::playerOnLookInBattleList, player, creature, lookDistance); } -void Game::playerQuickLoot(uint32_t playerId, const Position &pos, uint16_t itemId, uint8_t stackPos, std::shared_ptr<Item> defaultItem, bool lootAllCorpses, bool autoLoot) { - std::shared_ptr<Player> player = getPlayerByID(playerId); +void Game::playerQuickLoot(uint32_t playerId, const Position &pos, uint16_t itemId, uint8_t stackPos, const std::shared_ptr<Item> &defaultItem, bool lootAllCorpses, bool autoLoot) { + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5471,7 +5483,7 @@ void Game::playerQuickLoot(uint32_t playerId, const Position &pos, uint16_t item std::shared_ptr<Item> item = nullptr; if (!defaultItem) { - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -5563,7 +5575,7 @@ void Game::playerQuickLoot(uint32_t playerId, const Position &pos, uint16_t item } } -void Game::playerLootAllCorpses(std::shared_ptr<Player> player, const Position &pos, bool lootAllCorpses) { +void Game::playerLootAllCorpses(const std::shared_ptr<Player> &player, const Position &pos, bool lootAllCorpses) { if (lootAllCorpses) { std::shared_ptr<Tile> tile = g_game().map.getTile(pos.x, pos.y, pos.z); if (!tile) { @@ -5613,18 +5625,18 @@ void Game::playerLootAllCorpses(std::shared_ptr<Player> player, const Position & } void Game::playerSetManagedContainer(uint32_t playerId, ObjectCategory_t category, const Position &pos, uint16_t itemId, uint8_t stackPos, bool isLootContainer) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || pos.x != 0xffff) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_USEITEM); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_USEITEM); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - std::shared_ptr<Container> container = thing->getContainer(); + const std::shared_ptr<Container> &container = thing->getContainer(); auto allowConfig = g_configManager().getBoolean(TOGGLE_GOLD_POUCH_ALLOW_ANYTHING) || g_configManager().getBoolean(TOGGLE_GOLD_POUCH_QUICKLOOT_ONLY); if (!container || ((container->getID() == ITEM_GOLD_POUCH && category != OBJECTCATEGORY_GOLD) && !allowConfig)) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); @@ -5658,7 +5670,7 @@ void Game::playerSetManagedContainer(uint32_t playerId, ObjectCategory_t categor } void Game::playerClearManagedContainer(uint32_t playerId, ObjectCategory_t category, bool isLootContainer) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5675,7 +5687,7 @@ void Game::playerClearManagedContainer(uint32_t playerId, ObjectCategory_t categ } void Game::playerOpenManagedContainer(uint32_t playerId, ObjectCategory_t category, bool isLootContainer) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5689,7 +5701,7 @@ void Game::playerOpenManagedContainer(uint32_t playerId, ObjectCategory_t catego } void Game::playerSetQuickLootFallback(uint32_t playerId, bool fallback) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5697,8 +5709,8 @@ void Game::playerSetQuickLootFallback(uint32_t playerId, bool fallback) { player->quickLootFallbackToMainContainer = fallback; } -void Game::playerQuickLootBlackWhitelist(uint32_t playerId, QuickLootFilter_t filter, const std::vector<uint16_t> itemIds) { - std::shared_ptr<Player> player = getPlayerByID(playerId); +void Game::playerQuickLootBlackWhitelist(uint32_t playerId, QuickLootFilter_t filter, const std::vector<uint16_t> &itemIds) { + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5711,7 +5723,7 @@ void Game::playerQuickLootBlackWhitelist(uint32_t playerId, QuickLootFilter_t fi * Depot search system ******************************************************************************/ void Game::playerRequestDepotItems(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->isDepotSearchAvailable()) { return; } @@ -5726,7 +5738,7 @@ void Game::playerRequestDepotItems(uint32_t playerId) { } void Game::playerRequestCloseDepotSearch(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->isDepotSearchOpen()) { return; } @@ -5736,7 +5748,7 @@ void Game::playerRequestCloseDepotSearch(uint32_t playerId) { } void Game::playerRequestDepotSearchItem(uint32_t playerId, uint16_t itemId, uint8_t tier) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->isDepotSearchOpen()) { return; } @@ -5751,7 +5763,7 @@ void Game::playerRequestDepotSearchItem(uint32_t playerId, uint16_t itemId, uint } void Game::playerRequestDepotSearchRetrieve(uint32_t playerId, uint16_t itemId, uint8_t tier, uint8_t type) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->isDepotSearchOpenOnItem(itemId)) { return; } @@ -5766,7 +5778,7 @@ void Game::playerRequestDepotSearchRetrieve(uint32_t playerId, uint16_t itemId, } void Game::playerRequestOpenContainerFromDepotSearch(uint32_t playerId, const Position &pos) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->isDepotSearchOpen()) { return; } @@ -5781,7 +5793,7 @@ void Game::playerRequestOpenContainerFromDepotSearch(uint32_t playerId, const Po } void Game::playerCancelAttackAndFollow(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5792,7 +5804,7 @@ void Game::playerCancelAttackAndFollow(uint32_t playerId) { } void Game::playerSetAttackedCreature(uint32_t playerId, uint32_t creatureId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5823,7 +5835,7 @@ void Game::playerSetAttackedCreature(uint32_t playerId, uint32_t creatureId) { } void Game::playerFollowCreature(uint32_t playerId, uint32_t creatureId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5834,7 +5846,7 @@ void Game::playerFollowCreature(uint32_t playerId, uint32_t creatureId) { } void Game::playerSetFightModes(uint32_t playerId, FightMode_t fightMode, bool chaseMode, bool secureMode) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5849,7 +5861,7 @@ void Game::playerRequestAddVip(uint32_t playerId, const std::string &name) { return; } - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5885,7 +5897,7 @@ void Game::playerRequestAddVip(uint32_t playerId, const std::string &name) { } void Game::playerRequestRemoveVip(uint32_t playerId, uint32_t guid) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5894,7 +5906,7 @@ void Game::playerRequestRemoveVip(uint32_t playerId, uint32_t guid) { } void Game::playerRequestEditVip(uint32_t playerId, uint32_t guid, const std::string &description, uint32_t icon, bool notify, std::vector<uint8_t> vipGroupsId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5903,7 +5915,7 @@ void Game::playerRequestEditVip(uint32_t playerId, uint32_t guid, const std::str } void Game::playerApplyImbuement(uint32_t playerId, uint16_t imbuementid, uint8_t slot, bool protectionCharm) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5917,7 +5929,7 @@ void Game::playerApplyImbuement(uint32_t playerId, uint16_t imbuementid, uint8_t return; } - std::shared_ptr<Item> item = player->imbuingItem; + const auto &item = player->imbuingItem; if (!item) { return; } @@ -5932,7 +5944,7 @@ void Game::playerApplyImbuement(uint32_t playerId, uint16_t imbuementid, uint8_t } void Game::playerClearImbuement(uint32_t playerid, uint8_t slot) { - std::shared_ptr<Player> player = getPlayerByID(playerid); + const auto &player = getPlayerByID(playerid); if (!player) { return; } @@ -5941,7 +5953,7 @@ void Game::playerClearImbuement(uint32_t playerid, uint8_t slot) { return; } - std::shared_ptr<Item> item = player->imbuingItem; + const auto &item = player->imbuingItem; if (!item) { return; } @@ -5950,7 +5962,7 @@ void Game::playerClearImbuement(uint32_t playerid, uint8_t slot) { } void Game::playerCloseImbuementWindow(uint32_t playerid) { - std::shared_ptr<Player> player = getPlayerByID(playerid); + const auto &player = getPlayerByID(playerid); if (!player) { return; } @@ -5959,7 +5971,7 @@ void Game::playerCloseImbuementWindow(uint32_t playerid) { } void Game::playerTurn(uint32_t playerId, Direction dir) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5981,7 +5993,7 @@ void Game::playerRequestOutfit(uint32_t playerId) { return; } - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -5990,7 +6002,7 @@ void Game::playerRequestOutfit(uint32_t playerId) { } void Game::playerToggleMount(uint32_t playerId, bool mount) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -6003,7 +6015,7 @@ void Game::playerChangeOutfit(uint32_t playerId, Outfit_t outfit, uint8_t isMoun return; } - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -6070,7 +6082,7 @@ void Game::playerChangeOutfit(uint32_t playerId, Outfit_t outfit, uint8_t isMoun } void Game::playerShowQuestLog(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -6080,7 +6092,7 @@ void Game::playerShowQuestLog(uint32_t playerId) { } void Game::playerShowQuestLine(uint32_t playerId, uint16_t questId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -6090,7 +6102,7 @@ void Game::playerShowQuestLine(uint32_t playerId, uint16_t questId) { } void Game::playerSay(uint32_t playerId, uint16_t channelId, SpeakClasses type, const std::string &receiver, const std::string &text) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -6154,7 +6166,7 @@ void Game::playerSay(uint32_t playerId, uint16_t channelId, SpeakClasses type, c } } -bool Game::playerSaySpell(std::shared_ptr<Player> player, SpeakClasses type, const std::string &text) { +bool Game::playerSaySpell(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &text) { if (player->walkExhausted()) { return true; } @@ -6178,7 +6190,7 @@ bool Game::playerSaySpell(std::shared_ptr<Player> player, SpeakClasses type, con return false; } -void Game::playerWhisper(std::shared_ptr<Player> player, const std::string &text) { +void Game::playerWhisper(const std::shared_ptr<Player> &player, const std::string &text) { auto spectators = Spectators().find<Player>(player->getPosition(), false, MAP_MAX_CLIENT_VIEW_PORT_X, MAP_MAX_CLIENT_VIEW_PORT_X, MAP_MAX_CLIENT_VIEW_PORT_Y, MAP_MAX_CLIENT_VIEW_PORT_Y); // Send to client @@ -6198,7 +6210,7 @@ void Game::playerWhisper(std::shared_ptr<Player> player, const std::string &text } } -bool Game::playerYell(std::shared_ptr<Player> player, const std::string &text) { +bool Game::playerYell(const std::shared_ptr<Player> &player, const std::string &text) { if (player->getLevel() == 1) { player->sendTextMessage(MESSAGE_FAILURE, "You may not yell as long as you are on level 1."); return false; @@ -6218,7 +6230,7 @@ bool Game::playerYell(std::shared_ptr<Player> player, const std::string &text) { return true; } -bool Game::playerSpeakTo(std::shared_ptr<Player> player, SpeakClasses type, const std::string &receiver, const std::string &text) { +bool Game::playerSpeakTo(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &receiver, const std::string &text) { std::shared_ptr<Player> toPlayer = getPlayerByName(receiver); if (!toPlayer) { player->sendTextMessage(MESSAGE_FAILURE, "A player with this name is not online."); @@ -6244,7 +6256,7 @@ bool Game::playerSpeakTo(std::shared_ptr<Player> player, SpeakClasses type, cons return true; } -void Game::playerSpeakToNpc(std::shared_ptr<Player> player, const std::string &text) { +void Game::playerSpeakToNpc(const std::shared_ptr<Player> &player, const std::string &text) { if (player == nullptr) { g_logger().error("[Game::playerSpeakToNpc] - Player is nullptr"); return; @@ -6267,8 +6279,8 @@ void Game::playerSpeakToNpc(std::shared_ptr<Player> player, const std::string &t player->updateUIExhausted(); } -std::shared_ptr<Task> Game::createPlayerTask(uint32_t delay, std::function<void(void)> f, std::string context) const { - return Player::createPlayerTask(delay, std::move(f), std::move(context)); +std::shared_ptr<Task> Game::createPlayerTask(uint32_t delay, std::function<void(void)> f, const std::string &context) const { + return Player::createPlayerTask(delay, std::move(f), context); } //-- @@ -6280,7 +6292,7 @@ bool Game::isSightClear(const Position &fromPos, const Position &toPos, bool flo return map.isSightClear(fromPos, toPos, floorCheck); } -bool Game::internalCreatureTurn(std::shared_ptr<Creature> creature, Direction dir) { +bool Game::internalCreatureTurn(const std::shared_ptr<Creature> &creature, Direction dir) { if (creature->getDirection() == dir) { return false; } @@ -6299,7 +6311,7 @@ bool Game::internalCreatureTurn(std::shared_ptr<Creature> creature, Direction di return true; } -bool Game::internalCreatureSay(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, bool ghostMode, Spectators* spectatorsPtr /* = nullptr*/, const Position* pos /* = nullptr*/) { +bool Game::internalCreatureSay(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, bool ghostMode, Spectators* spectatorsPtr /* = nullptr*/, const Position* pos /* = nullptr*/) { if (text.empty()) { return false; } @@ -6411,7 +6423,7 @@ void Game::checkCreatures() { index = (index + 1) % EVENT_CREATURECOUNT; } -void Game::changeSpeed(std::shared_ptr<Creature> creature, int32_t varSpeedDelta) { +void Game::changeSpeed(const std::shared_ptr<Creature> &creature, int32_t varSpeedDelta) { int32_t varSpeed = creature->getSpeed() - creature->getBaseSpeed(); varSpeed += varSpeedDelta; @@ -6423,7 +6435,7 @@ void Game::changeSpeed(std::shared_ptr<Creature> creature, int32_t varSpeedDelta } } -void Game::setCreatureSpeed(std::shared_ptr<Creature> creature, int32_t speed) { +void Game::setCreatureSpeed(const std::shared_ptr<Creature> &creature, int32_t speed) { creature->setBaseSpeed(static_cast<uint16_t>(speed)); // Send creature speed to client @@ -6444,7 +6456,7 @@ void Game::changePlayerSpeed(const std::shared_ptr<Player> &player, int32_t varS } } -void Game::internalCreatureChangeOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit) { +void Game::internalCreatureChangeOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit) { if (!g_events().eventCreatureOnChangeOutfit(creature, outfit)) { return; } @@ -6465,28 +6477,28 @@ void Game::internalCreatureChangeOutfit(std::shared_ptr<Creature> creature, cons } } -void Game::internalCreatureChangeVisible(std::shared_ptr<Creature> creature, bool visible) { +void Game::internalCreatureChangeVisible(const std::shared_ptr<Creature> &creature, bool visible) { // Send to clients for (const auto &spectator : Spectators().find<Player>(creature->getPosition(), true)) { spectator->getPlayer()->sendCreatureChangeVisible(creature, visible); } } -void Game::changeLight(std::shared_ptr<Creature> creature) { +void Game::changeLight(const std::shared_ptr<Creature> &creature) { // Send to clients for (const auto &spectator : Spectators().find<Player>(creature->getPosition(), true)) { spectator->getPlayer()->sendCreatureLight(creature); } } -void Game::updateCreatureIcon(std::shared_ptr<Creature> creature) { +void Game::updateCreatureIcon(const std::shared_ptr<Creature> &creature) { // Send to clients for (const auto &spectator : Spectators().find<Player>(creature->getPosition(), true)) { spectator->getPlayer()->sendCreatureIcon(creature); } } -void Game::reloadCreature(std::shared_ptr<Creature> creature) { +void Game::reloadCreature(const std::shared_ptr<Creature> &creature) { if (!creature) { g_logger().error("[{}] Creature is nullptr", __FUNCTION__); return; @@ -6497,7 +6509,7 @@ void Game::reloadCreature(std::shared_ptr<Creature> creature) { } } -void Game::sendSingleSoundEffect(const Position &pos, SoundEffect_t soundId, std::shared_ptr<Creature> actor /* = nullptr*/) { +void Game::sendSingleSoundEffect(const Position &pos, SoundEffect_t soundId, const std::shared_ptr<Creature> &actor /* = nullptr*/) { if (soundId == SoundEffect_t::SILENCE) { return; } @@ -6517,7 +6529,7 @@ void Game::sendSingleSoundEffect(const Position &pos, SoundEffect_t soundId, std } } -void Game::sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundEffect, SoundEffect_t secondarySoundEffect, std::shared_ptr<Creature> actor /* = nullptr*/) { +void Game::sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundEffect, SoundEffect_t secondarySoundEffect, const std::shared_ptr<Creature> &actor /* = nullptr*/) { if (secondarySoundEffect == SoundEffect_t::SILENCE) { sendSingleSoundEffect(pos, mainSoundEffect, actor); return; @@ -6538,7 +6550,7 @@ void Game::sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundEff } } -bool Game::combatBlockHit(CombatDamage &damage, std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, bool checkDefense, bool checkArmor, bool field) { +bool Game::combatBlockHit(CombatDamage &damage, const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, bool checkDefense, bool checkArmor, bool field) { if (damage.primary.type == COMBAT_NONE && damage.secondary.type == COMBAT_NONE) { return true; } @@ -6726,7 +6738,7 @@ bool Game::combatBlockHit(CombatDamage &damage, std::shared_ptr<Creature> attack return (primaryBlockType != BLOCK_NONE) && (secondaryBlockType != BLOCK_NONE); } -void Game::combatGetTypeInfo(CombatType_t combatType, std::shared_ptr<Creature> target, TextColor_t &color, uint16_t &effect) { +void Game::combatGetTypeInfo(CombatType_t combatType, const std::shared_ptr<Creature> &target, TextColor_t &color, uint16_t &effect) { switch (combatType) { case COMBAT_PHYSICALDAMAGE: { std::shared_ptr<Item> splash = nullptr; @@ -6837,7 +6849,7 @@ void Game::combatGetTypeInfo(CombatType_t combatType, std::shared_ptr<Creature> } // Hazard combat helpers -void Game::handleHazardSystemAttack(CombatDamage &damage, std::shared_ptr<Player> player, std::shared_ptr<Monster> monster, bool isPlayerAttacker) { +void Game::handleHazardSystemAttack(CombatDamage &damage, const std::shared_ptr<Player> &player, const std::shared_ptr<Monster> &monster, bool isPlayerAttacker) { if (damage.primary.value != 0 && monster->getHazard()) { if (isPlayerAttacker) { player->parseAttackDealtHazardSystem(damage, monster); @@ -6847,7 +6859,7 @@ void Game::handleHazardSystemAttack(CombatDamage &damage, std::shared_ptr<Player } } -void Game::notifySpectators(const CreatureVector &spectators, const Position &targetPos, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Monster> targetMonster) { +void Game::notifySpectators(const CreatureVector &spectators, const Position &targetPos, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Monster> &targetMonster) { if (!spectators.empty()) { for (const auto &spectator : spectators) { if (!spectator) { @@ -6876,7 +6888,7 @@ void Game::notifySpectators(const CreatureVector &spectators, const Position &ta } // Custom PvP System combat helpers -void Game::applyPvPDamage(CombatDamage &damage, std::shared_ptr<Player> attacker, std::shared_ptr<Player> target) { +void Game::applyPvPDamage(CombatDamage &damage, const std::shared_ptr<Player> &attacker, const std::shared_ptr<Player> &target) { float targetDamageReceivedMultiplier = target->vocation->pvpDamageReceivedMultiplier; float attackerDamageDealtMultiplier = attacker->vocation->pvpDamageDealtMultiplier; float levelDifferenceDamageMultiplier = this->pvpLevelDifferenceDamageMultiplier(attacker, target); @@ -6887,7 +6899,7 @@ void Game::applyPvPDamage(CombatDamage &damage, std::shared_ptr<Player> attacker damage.secondary.value = std::round(damage.secondary.value * pvpDamageMultiplier); } -float Game::pvpLevelDifferenceDamageMultiplier(std::shared_ptr<Player> attacker, std::shared_ptr<Player> target) { +float Game::pvpLevelDifferenceDamageMultiplier(const std::shared_ptr<Player> &attacker, const std::shared_ptr<Player> &target) { int32_t levelDifference = target->getLevel() - attacker->getLevel(); levelDifference = std::abs(levelDifference); bool isLowerLevel = target->getLevel() < attacker->getLevel(); @@ -6908,7 +6920,7 @@ float Game::pvpLevelDifferenceDamageMultiplier(std::shared_ptr<Player> attacker, } // Wheel of destiny combat helpers -void Game::applyWheelOfDestinyHealing(CombatDamage &damage, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Creature> target) { +void Game::applyWheelOfDestinyHealing(CombatDamage &damage, const std::shared_ptr<Player> &attackerPlayer, std::shared_ptr<Creature> target) { damage.primary.value += (damage.primary.value * damage.healingMultiplier) / 100.; if (attackerPlayer) { @@ -6931,7 +6943,7 @@ void Game::applyWheelOfDestinyHealing(CombatDamage &damage, std::shared_ptr<Play } } -void Game::applyWheelOfDestinyEffectsToDamage(CombatDamage &damage, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Creature> target) const { +void Game::applyWheelOfDestinyEffectsToDamage(CombatDamage &damage, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Creature> &target) const { // If damage is 0, it means the target is immune to the damage type, or that we missed. if (damage.primary.value == 0 && damage.secondary.value == 0) { return; @@ -6971,7 +6983,7 @@ void Game::applyWheelOfDestinyEffectsToDamage(CombatDamage &damage, std::shared_ } } -int32_t Game::applyHealthChange(CombatDamage &damage, std::shared_ptr<Creature> target) const { +int32_t Game::applyHealthChange(const CombatDamage &damage, const std::shared_ptr<Creature> &target) const { int32_t targetHealth = target->getHealth(); // Wheel of destiny (Gift of Life) @@ -6988,7 +7000,7 @@ int32_t Game::applyHealthChange(CombatDamage &damage, std::shared_ptr<Creature> return targetHealth; } -bool Game::combatChangeHealth(std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, CombatDamage &damage, bool isEvent /*= false*/) { +bool Game::combatChangeHealth(const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, CombatDamage &damage, bool isEvent /*= false*/) { using namespace std; const Position &targetPos = target->getPosition(); if (damage.primary.value > 0) { @@ -7135,7 +7147,7 @@ bool Game::combatChangeHealth(std::shared_ptr<Creature> attacker, std::shared_pt int32_t distanceY = Position::getDistanceY(targetPos, attackerPos); int32_t damageX = attackerPlayer->getPerfectShotDamage(distanceX, true); int32_t damageY = attackerPlayer->getPerfectShotDamage(distanceY, true); - std::shared_ptr<Item> item = attackerPlayer->getWeapon(); + const auto &item = attackerPlayer->getWeapon(); if (item && item->getWeaponType() == WEAPON_DISTANCE) { std::shared_ptr<Item> quiver = attackerPlayer->getInventoryItem(CONST_SLOT_RIGHT); if (quiver && quiver->getWeaponType()) { @@ -7410,7 +7422,7 @@ bool Game::combatChangeHealth(std::shared_ptr<Creature> attacker, std::shared_pt return true; } -void Game::updatePlayerPartyHuntAnalyzer(const CombatDamage &damage, std::shared_ptr<Player> player) const { +void Game::updatePlayerPartyHuntAnalyzer(const CombatDamage &damage, const std::shared_ptr<Player> &player) const { if (!player) { return; } @@ -7426,8 +7438,8 @@ void Game::updatePlayerPartyHuntAnalyzer(const CombatDamage &damage, std::shared } void Game::sendDamageMessageAndEffects( - std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, const CombatDamage &damage, - const Position &targetPos, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Player> targetPlayer, + const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, const CombatDamage &damage, + const Position &targetPos, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Player> &targetPlayer, TextMessage &message, const CreatureVector &spectators, int32_t realDamage ) { message.primary.value = damage.primary.value; @@ -7436,7 +7448,7 @@ void Game::sendDamageMessageAndEffects( sendEffects(target, damage, targetPos, message, spectators); if (shouldSendMessage(message)) { - sendMessages(std::move(attacker), target, damage, targetPos, std::move(attackerPlayer), std::move(targetPlayer), message, spectators, realDamage); + sendMessages(attacker, target, damage, targetPos, attackerPlayer, targetPlayer, message, spectators, realDamage); } } @@ -7445,8 +7457,8 @@ bool Game::shouldSendMessage(const TextMessage &message) const { } void Game::sendMessages( - std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, const CombatDamage &damage, - const Position &targetPos, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Player> targetPlayer, + const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, const CombatDamage &damage, + const Position &targetPos, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Player> &targetPlayer, TextMessage &message, const CreatureVector &spectators, int32_t realDamage ) const { if (attackerPlayer) { @@ -7493,8 +7505,8 @@ void Game::sendMessages( } void Game::buildMessageAsSpectator( - std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, const CombatDamage &damage, - std::shared_ptr<Player> targetPlayer, TextMessage &message, std::stringstream &ss, + const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, const CombatDamage &damage, + const std::shared_ptr<Player> &targetPlayer, TextMessage &message, std::stringstream &ss, const std::string &damageString, std::string &spectatorMessage ) const { if (spectatorMessage.empty()) { @@ -7526,8 +7538,8 @@ void Game::buildMessageAsSpectator( } void Game::buildMessageAsTarget( - std::shared_ptr<Creature> attacker, const CombatDamage &damage, std::shared_ptr<Player> attackerPlayer, - std::shared_ptr<Player> targetPlayer, TextMessage &message, std::stringstream &ss, + const std::shared_ptr<Creature> &attacker, const CombatDamage &damage, const std::shared_ptr<Player> &attackerPlayer, + const std::shared_ptr<Player> &targetPlayer, TextMessage &message, std::stringstream &ss, const std::string &damageString ) const { ss.str({}); @@ -7549,7 +7561,7 @@ void Game::buildMessageAsTarget( } void Game::buildMessageAsAttacker( - std::shared_ptr<Creature> target, const CombatDamage &damage, TextMessage &message, + const std::shared_ptr<Creature> &target, const CombatDamage &damage, TextMessage &message, std::stringstream &ss, const std::string &damageString ) const { ss.str({}); @@ -7565,7 +7577,7 @@ void Game::buildMessageAsAttacker( } void Game::sendEffects( - std::shared_ptr<Creature> target, const CombatDamage &damage, const Position &targetPos, TextMessage &message, + const std::shared_ptr<Creature> &target, const CombatDamage &damage, const Position &targetPos, TextMessage &message, const CreatureVector &spectators ) { uint16_t hitEffect; @@ -7585,7 +7597,7 @@ void Game::sendEffects( } void Game::applyCharmRune( - std::shared_ptr<Monster> targetMonster, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Creature> target, const int32_t &realDamage + const std::shared_ptr<Monster> &targetMonster, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Creature> &target, const int32_t &realDamage ) const { if (!targetMonster || !attackerPlayer) { return; @@ -7596,14 +7608,14 @@ void Game::applyCharmRune( int8_t chance = charm->id == CHARM_CRIPPLE ? charm->chance : charm->chance + attackerPlayer->getCharmChanceModifier(); g_logger().debug("charm chance: {}, base: {}, bonus: {}", chance, charm->chance, attackerPlayer->getCharmChanceModifier()); if (charm->type == CHARM_OFFENSIVE && (chance >= normal_random(0, 100))) { - g_iobestiary().parseCharmCombat(charm, attackerPlayer, std::move(target), realDamage); + g_iobestiary().parseCharmCombat(charm, attackerPlayer, target, realDamage); } } } // Mana leech void Game::applyManaLeech( - std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Monster> targetMonster, std::shared_ptr<Creature> target, const CombatDamage &damage, const int32_t &realDamage + const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Monster> &targetMonster, const std::shared_ptr<Creature> &target, const CombatDamage &damage, const int32_t &realDamage ) const { // Wheel of destiny bonus - mana leech chance and amount auto wheelLeechChance = attackerPlayer->wheel()->checkDrainBodyLeech(target, SKILL_MANA_LEECH_CHANCE); @@ -7636,7 +7648,7 @@ void Game::applyManaLeech( // Life leech void Game::applyLifeLeech( - std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Monster> targetMonster, std::shared_ptr<Creature> target, const CombatDamage &damage, const int32_t &realDamage + const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Monster> &targetMonster, const std::shared_ptr<Creature> &target, const CombatDamage &damage, const int32_t &realDamage ) const { // Wheel of destiny bonus - life leech chance and amount auto wheelLeechChance = attackerPlayer->wheel()->checkDrainBodyLeech(target, SKILL_LIFE_LEECH_CHANCE); @@ -7670,7 +7682,7 @@ int32_t Game::calculateLeechAmount(const int32_t &realDamage, const uint16_t &sk return std::clamp<int32_t>(static_cast<int32_t>(std::lround(intermediateResult)), 0, realDamage); } -bool Game::combatChangeMana(std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, CombatDamage &damage) { +bool Game::combatChangeMana(const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, CombatDamage &damage) { const Position &targetPos = target->getPosition(); auto manaChange = damage.primary.value + damage.secondary.value; if (manaChange > 0) { @@ -7869,12 +7881,12 @@ bool Game::combatChangeMana(std::shared_ptr<Creature> attacker, std::shared_ptr< return true; } -void Game::addCreatureHealth(std::shared_ptr<Creature> target) { +void Game::addCreatureHealth(const std::shared_ptr<Creature> &target) { auto spectators = Spectators().find<Player>(target->getPosition(), true); addCreatureHealth(spectators.data(), target); } -void Game::addCreatureHealth(const CreatureVector &spectators, std::shared_ptr<Creature> target) { +void Game::addCreatureHealth(const CreatureVector &spectators, const std::shared_ptr<Creature> &target) { uint8_t healthPercent = std::ceil((static_cast<double>(target->getHealth()) / std::max<int32_t>(target->getMaxHealth(), 1)) * 100); if (const auto &targetPlayer = target->getPlayer()) { if (const auto &party = targetPlayer->getParty()) { @@ -7894,14 +7906,14 @@ void Game::addCreatureHealth(const CreatureVector &spectators, std::shared_ptr<C } } -void Game::addPlayerMana(std::shared_ptr<Player> target) { +void Game::addPlayerMana(const std::shared_ptr<Player> &target) { if (const auto &party = target->getParty()) { uint8_t manaPercent = std::ceil((static_cast<double>(target->getMana()) / std::max<int32_t>(target->getMaxMana(), 1)) * 100); party->updatePlayerMana(target, manaPercent); } } -void Game::addPlayerVocation(std::shared_ptr<Player> target) { +void Game::addPlayerVocation(const std::shared_ptr<Player> &target) { if (const auto &party = target->getParty()) { party->updatePlayerVocation(target); } @@ -7950,7 +7962,7 @@ void Game::addDistanceEffect(const CreatureVector &spectators, const Position &f } } -void Game::checkImbuements() { +void Game::checkImbuements() const { for (const auto &[mapPlayerId, mapPlayer] : getPlayers()) { if (!mapPlayer) { continue; @@ -8059,7 +8071,7 @@ void Game::shutdown() { g_logger().info("Done!"); } -void Game::addBestiaryList(uint16_t raceid, std::string name) { +void Game::addBestiaryList(uint16_t raceid, const std::string &name) { auto it = BestiaryList.find(raceid); if (it != BestiaryList.end()) { return; @@ -8077,7 +8089,7 @@ void Game::broadcastMessage(const std::string &text, MessageClasses type) const } } -void Game::updateCreatureWalkthrough(std::shared_ptr<Creature> creature) { +void Game::updateCreatureWalkthrough(const std::shared_ptr<Creature> &creature) { // Send to clients for (const auto &spectator : Spectators().find<Player>(creature->getPosition(), true)) { const auto &tmpPlayer = spectator->getPlayer(); @@ -8085,7 +8097,7 @@ void Game::updateCreatureWalkthrough(std::shared_ptr<Creature> creature) { } } -void Game::updateCreatureSkull(std::shared_ptr<Creature> creature) { +void Game::updateCreatureSkull(const std::shared_ptr<Creature> &creature) const { if (getWorldType() != WORLD_TYPE_PVP) { return; } @@ -8095,13 +8107,13 @@ void Game::updateCreatureSkull(std::shared_ptr<Creature> creature) { } } -void Game::updatePlayerShield(std::shared_ptr<Player> player) { +void Game::updatePlayerShield(const std::shared_ptr<Player> &player) { for (const auto &spectator : Spectators().find<Player>(player->getPosition(), true)) { spectator->getPlayer()->sendCreatureShield(player); } } -void Game::updateCreatureType(std::shared_ptr<Creature> creature) { +void Game::updateCreatureType(const std::shared_ptr<Creature> &creature) { if (!creature) { return; } @@ -8205,7 +8217,7 @@ void Game::playerInviteToParty(uint32_t playerId, uint32_t invitedId) { return; } - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8232,7 +8244,7 @@ void Game::playerInviteToParty(uint32_t playerId, uint32_t invitedId) { party->invitePlayer(invitedPlayer); } -void Game::updatePlayerHelpers(std::shared_ptr<Player> player) { +void Game::updatePlayerHelpers(const std::shared_ptr<Player> &player) { if (!player) { return; } @@ -8244,7 +8256,7 @@ void Game::updatePlayerHelpers(std::shared_ptr<Player> player) { } void Game::playerJoinParty(uint32_t playerId, uint32_t leaderId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8268,7 +8280,7 @@ void Game::playerJoinParty(uint32_t playerId, uint32_t leaderId) { } void Game::playerRevokePartyInvitation(uint32_t playerId, uint32_t invitedId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8287,7 +8299,7 @@ void Game::playerRevokePartyInvitation(uint32_t playerId, uint32_t invitedId) { } void Game::playerPassPartyLeadership(uint32_t playerId, uint32_t newLeaderId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8306,7 +8318,7 @@ void Game::playerPassPartyLeadership(uint32_t playerId, uint32_t newLeaderId) { } void Game::playerLeaveParty(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8321,7 +8333,7 @@ void Game::playerLeaveParty(uint32_t playerId) { } void Game::playerEnableSharedPartyExperience(uint32_t playerId, bool sharedExpActive) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8336,7 +8348,7 @@ void Game::playerEnableSharedPartyExperience(uint32_t playerId, bool sharedExpAc } void Game::sendGuildMotd(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8348,7 +8360,7 @@ void Game::sendGuildMotd(uint32_t playerId) { } void Game::kickPlayer(uint32_t playerId, bool displayEffect) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8356,7 +8368,7 @@ void Game::kickPlayer(uint32_t playerId, bool displayEffect) { player->removePlayer(displayEffect); } -void Game::playerFriendSystemAction(std::shared_ptr<Player> player, uint8_t type, uint8_t titleId) { +void Game::playerFriendSystemAction(const std::shared_ptr<Player> &player, uint8_t type, uint8_t titleId) { if (type == 0x0E) { player->title()->setCurrentTitle(titleId); player->sendCyclopediaCharacterBaseInformation(); @@ -8365,7 +8377,7 @@ void Game::playerFriendSystemAction(std::shared_ptr<Player> player, uint8_t type } } -void Game::playerCyclopediaCharacterInfo(std::shared_ptr<Player> player, uint32_t characterID, CyclopediaCharacterInfoType_t characterInfoType, uint16_t entriesPerPage, uint16_t page) { +void Game::playerCyclopediaCharacterInfo(const std::shared_ptr<Player> &player, uint32_t characterID, CyclopediaCharacterInfoType_t characterInfoType, uint16_t entriesPerPage, uint16_t page) { uint32_t playerGUID = player->getGUID(); if (characterID != playerGUID) { // For now allow viewing only our character since we don't have tournaments supported @@ -8478,8 +8490,8 @@ std::string Game::generateVocationConditionHighscore(uint32_t vocation) { return queryPart.str(); } -void Game::processHighscoreResults(DBResult_ptr result, uint32_t playerID, uint8_t category, uint32_t vocation, uint8_t entriesPerPage) { - std::shared_ptr<Player> player = g_game().getPlayerByID(playerID); +void Game::processHighscoreResults(const DBResult_ptr &result, uint32_t playerID, uint8_t category, uint32_t vocation, uint8_t entriesPerPage) { + const auto &player = g_game().getPlayerByID(playerID); if (!player) { return; } @@ -8491,8 +8503,8 @@ void Game::processHighscoreResults(DBResult_ptr result, uint32_t playerID, uint8 return; } - uint16_t page = result->getNumber<uint16_t>("page"); - uint32_t pages = result->getNumber<uint32_t>("entries"); + auto page = result->getNumber<uint16_t>("page"); + auto pages = result->getNumber<uint32_t>("entries"); pages += entriesPerPage - 1; pages /= entriesPerPage; @@ -8516,7 +8528,7 @@ void Game::processHighscoreResults(DBResult_ptr result, uint32_t playerID, uint8 do { const auto &voc = g_vocations().getVocation(result->getNumber<uint16_t>("vocation")); uint8_t characterVocation = voc ? voc->getClientId() : 0; - std::string loyaltyTitle = ""; // todo get loyalty title from player + std::string loyaltyTitle; // todo get loyalty title from player characters.emplace_back(std::move(result->getString("name")), result->getNumber<uint64_t>("points"), result->getNumber<uint32_t>("id"), result->getNumber<uint32_t>("rank"), result->getNumber<uint16_t>("level"), characterVocation, loyaltyTitle); } while (result->next()); } @@ -8567,7 +8579,7 @@ std::string Game::generateHighscoreOrGetCachedQueryForOurRank(const std::string return newQuery; } -void Game::playerHighscores(std::shared_ptr<Player> player, HighscoreType_t type, uint8_t category, uint32_t vocation, const std::string &, uint16_t page, uint8_t entriesPerPage) { +void Game::playerHighscores(const std::shared_ptr<Player> &player, HighscoreType_t type, uint8_t category, uint32_t vocation, const std::string &, uint16_t page, uint8_t entriesPerPage) { if (player->hasAsyncOngoingTask(PlayerAsyncTask_Highscore)) { return; } @@ -8582,8 +8594,8 @@ void Game::playerHighscores(std::shared_ptr<Player> player, HighscoreType_t type } uint32_t playerID = player->getID(); - std::function<void(DBResult_ptr, bool)> callback = [this, playerID, category, vocation, entriesPerPage](DBResult_ptr result, bool) { - processHighscoreResults(std::move(result), playerID, category, vocation, entriesPerPage); + std::function<void(DBResult_ptr, bool)> callback = [this, playerID, category, vocation, entriesPerPage](const DBResult_ptr &result, bool) { + processHighscoreResults(result, playerID, category, vocation, entriesPerPage); }; g_databaseTasks().store(query, callback); @@ -8617,7 +8629,7 @@ std::string Game::getSkillNameById(uint8_t &skill) { } void Game::playerReportRuleViolationReport(uint32_t playerId, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8627,7 +8639,7 @@ void Game::playerReportRuleViolationReport(uint32_t playerId, const std::string } void Game::playerReportBug(uint32_t playerId, const std::string &message, const Position &position, uint8_t category) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8637,7 +8649,7 @@ void Game::playerReportBug(uint32_t playerId, const std::string &message, const } void Game::playerDebugAssert(uint32_t playerId, const std::string &assertLine, const std::string &date, const std::string &description, const std::string &comment) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8652,7 +8664,7 @@ void Game::playerDebugAssert(uint32_t playerId, const std::string &assertLine, c } void Game::playerPreyAction(uint32_t playerId, uint8_t slot, uint8_t action, uint8_t option, int8_t index, uint16_t raceId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8661,7 +8673,7 @@ void Game::playerPreyAction(uint32_t playerId, uint8_t slot, uint8_t action, uin } void Game::playerTaskHuntingAction(uint32_t playerId, uint8_t slot, uint8_t action, bool upgrade, uint16_t raceId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8706,7 +8718,7 @@ void Game::playerNpcGreet(uint32_t playerId, uint32_t npcId) { } void Game::playerLeaveMarket(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8715,7 +8727,7 @@ void Game::playerLeaveMarket(uint32_t playerId) { } void Game::playerBrowseMarket(uint32_t playerId, uint16_t itemId, uint8_t tier) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8740,7 +8752,7 @@ void Game::playerBrowseMarket(uint32_t playerId, uint16_t itemId, uint8_t tier) } void Game::playerBrowseMarketOwnOffers(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8755,7 +8767,7 @@ void Game::playerBrowseMarketOwnOffers(uint32_t playerId) { } void Game::playerBrowseMarketOwnHistory(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -8841,7 +8853,7 @@ namespace { } } // namespace -bool checkCanInitCreateMarketOffer(std::shared_ptr<Player> player, uint8_t type, const ItemType &it, uint16_t amount, uint64_t price, std::ostringstream &offerStatus) { +bool checkCanInitCreateMarketOffer(const std::shared_ptr<Player> &player, uint8_t type, const ItemType &it, uint16_t amount, uint64_t price, std::ostringstream &offerStatus) { if (!player) { offerStatus << "Failed to load player"; return false; @@ -8907,7 +8919,7 @@ void Game::playerCreateMarketOffer(uint32_t playerId, uint8_t type, uint16_t ite // Initialize variables // Before creating the offer we will compare it with the RETURN VALUE ERROR std::ostringstream offerStatus; - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); const ItemType &it = Item::items[itemId]; // Make sure everything is ok before the create market offer starts @@ -8990,7 +9002,7 @@ void Game::playerCreateMarketOffer(uint32_t playerId, uint8_t type, uint16_t ite } void Game::playerCancelMarketOffer(uint32_t playerId, uint32_t timestamp, uint16_t counter) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->getAccount()) { return; } @@ -9027,7 +9039,7 @@ void Game::playerCancelMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 uint16_t tmpAmount = offer.amount; while (tmpAmount > 0) { int32_t stackCount = std::min<int32_t>(it.stackSize, tmpAmount); - std::shared_ptr<Item> item = Item::CreateItem(it.id, stackCount); + const auto &item = Item::CreateItem(it.id, stackCount); if (internalAddItem(player->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT) != RETURNVALUE_NOERROR) { break; } @@ -9047,7 +9059,7 @@ void Game::playerCancelMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 } for (uint16_t i = 0; i < offer.amount; ++i) { - std::shared_ptr<Item> item = Item::CreateItem(it.id, subType); + const auto &item = Item::CreateItem(it.id, subType); if (internalAddItem(player->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT) != RETURNVALUE_NOERROR) { break; } @@ -9073,7 +9085,7 @@ void Game::playerCancelMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 void Game::playerAcceptMarketOffer(uint32_t playerId, uint32_t timestamp, uint16_t counter, uint16_t amount) { std::ostringstream offerStatus; - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || !player->getAccount()) { offerStatus << "Failed to load player"; return; @@ -9180,7 +9192,7 @@ void Game::playerAcceptMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 uint16_t tmpAmount = amount; while (tmpAmount > 0) { uint16_t stackCount = std::min<uint16_t>(it.stackSize, tmpAmount); - std::shared_ptr<Item> item = Item::CreateItem(it.id, stackCount); + const auto &item = Item::CreateItem(it.id, stackCount); if (internalAddItem(buyerPlayer->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT) != RETURNVALUE_NOERROR) { offerStatus << "Failed to add player inbox stackable item for buy offer for player " << player->getName(); @@ -9202,7 +9214,7 @@ void Game::playerAcceptMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 } for (uint16_t i = 0; i < amount; ++i) { - std::shared_ptr<Item> item = Item::CreateItem(it.id, subType); + const auto &item = Item::CreateItem(it.id, subType); if (internalAddItem(buyerPlayer->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT) != RETURNVALUE_NOERROR) { offerStatus << "Failed to add player inbox item for buy offer for player " << player->getName(); @@ -9251,7 +9263,7 @@ void Game::playerAcceptMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 uint16_t tmpAmount = amount; while (tmpAmount > 0) { uint16_t stackCount = std::min<uint16_t>(it.stackSize, tmpAmount); - std::shared_ptr<Item> item = Item::CreateItem(it.id, stackCount); + const auto &item = Item::CreateItem(it.id, stackCount); if ( // Init-statement auto ret = internalAddItem(player->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT); @@ -9279,7 +9291,7 @@ void Game::playerAcceptMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 } for (uint16_t i = 0; i < amount; ++i) { - std::shared_ptr<Item> item = Item::CreateItem(it.id, subType); + const auto &item = Item::CreateItem(it.id, subType); if ( // Init-statement auto ret = internalAddItem(player->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT); @@ -9300,9 +9312,7 @@ void Game::playerAcceptMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 sellerPlayer->setBankBalance(sellerPlayer->getBankBalance() + totalPrice); g_metrics().addCounter("balance_increase", totalPrice, { { "player", sellerPlayer->getName() }, { "context", "market_sale" } }); if (it.id == ITEM_STORE_COIN) { - const auto &tranferable = enumToValue(CoinType::Transferable); - const auto &removeCoin = enumToValue(CoinTransactionType::Remove); - sellerPlayer->getAccount()->registerCoinTransaction(removeCoin, tranferable, amount, "Sold on Market"); + sellerPlayer->getAccount()->registerCoinTransaction(enumToValue(CoinTransactionType::Remove), enumToValue(CoinType::Transferable), amount, "Sold on Market"); } if (it.id != ITEM_STORE_COIN) { @@ -9345,7 +9355,7 @@ void Game::playerAcceptMarketOffer(uint32_t playerId, uint32_t timestamp, uint16 } void Game::parsePlayerExtendedOpcode(uint32_t playerId, uint8_t opcode, const std::string &buffer) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9364,7 +9374,7 @@ void Game::forceRemoveCondition(uint32_t creatureId, ConditionType_t conditionTy creature->removeCondition(conditionType, conditionId, true); } -void Game::sendOfflineTrainingDialog(std::shared_ptr<Player> player) { +void Game::sendOfflineTrainingDialog(const std::shared_ptr<Player> &player) { if (!player) { return; } @@ -9375,7 +9385,7 @@ void Game::sendOfflineTrainingDialog(std::shared_ptr<Player> player) { } void Game::playerAnswerModalWindow(uint32_t playerId, uint32_t modalWindowId, uint8_t button, uint8_t choice) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9410,7 +9420,7 @@ void Game::playerAnswerModalWindow(uint32_t playerId, uint32_t modalWindowId, ui void Game::playerForgeFuseItems(uint32_t playerId, ForgeAction_t actionType, uint16_t firstItemId, uint8_t tier, uint16_t secondItemId, bool usedCore, bool reduceTierLoss, bool convergence) { metrics::method_latency measure(__METHOD_NAME__); - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9437,7 +9447,7 @@ void Game::playerForgeFuseItems(uint32_t playerId, ForgeAction_t actionType, uin } void Game::playerForgeTransferItemTier(uint32_t playerId, ForgeAction_t actionType, uint16_t donorItemId, uint8_t tier, uint16_t receiveItemId, bool convergence) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9452,7 +9462,7 @@ void Game::playerForgeTransferItemTier(uint32_t playerId, ForgeAction_t actionTy } void Game::playerForgeResourceConversion(uint32_t playerId, ForgeAction_t actionType) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9467,7 +9477,7 @@ void Game::playerForgeResourceConversion(uint32_t playerId, ForgeAction_t action } void Game::playerBrowseForgeHistory(uint32_t playerId, uint8_t page) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9482,7 +9492,7 @@ void Game::playerBrowseForgeHistory(uint32_t playerId, uint8_t page) { } void Game::playerBosstiarySlot(uint32_t playerId, uint8_t slotId, uint32_t selectedBossId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9509,23 +9519,23 @@ void Game::playerBosstiarySlot(uint32_t playerId, uint8_t slotId, uint32_t selec } void Game::playerSetMonsterPodium(uint32_t playerId, uint32_t monsterRaceId, const Position &pos, uint8_t stackPos, const uint16_t itemId, uint8_t direction, const std::pair<uint8_t, uint8_t> &podiumAndMonsterVisible) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || pos.x == 0xFFFF) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->getID() != itemId || !item->isPodium() || item->hasAttribute(ItemAttribute_t::UNIQUEID)) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - const auto tile = item->getParent() ? item->getParent()->getTile() : nullptr; + const auto &tile = item->getParent() ? item->getParent()->getTile() : nullptr; if (!tile) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -9619,17 +9629,17 @@ void Game::playerSetMonsterPodium(uint32_t playerId, uint32_t monsterRaceId, con } void Game::playerRotatePodium(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); + const std::shared_ptr<Thing> &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_TOPDOWN_ITEM); if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->getID() != itemId || item->hasAttribute(ItemAttribute_t::UNIQUEID)) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -9709,7 +9719,7 @@ void Game::playerRotatePodium(uint32_t playerId, const Position &pos, uint8_t st } void Game::playerRequestInventoryImbuements(uint32_t playerId, bool isTrackerOpen) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player || player->isRemoved()) { return; } @@ -9721,7 +9731,7 @@ void Game::playerRequestInventoryImbuements(uint32_t playerId, bool isTrackerOpe std::map<Slots_t, std::shared_ptr<Item>> itemsWithImbueSlotMap; for (uint8_t inventorySlot = CONST_SLOT_FIRST; inventorySlot <= CONST_SLOT_LAST; ++inventorySlot) { - auto item = player->getInventoryItem(static_cast<Slots_t>(inventorySlot)); + const auto &item = player->getInventoryItem(static_cast<Slots_t>(inventorySlot)); if (!item) { continue; } @@ -9741,7 +9751,7 @@ void Game::playerRequestInventoryImbuements(uint32_t playerId, bool isTrackerOpe } void Game::playerOpenWheel(uint32_t playerId, uint32_t ownerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9761,7 +9771,7 @@ void Game::playerOpenWheel(uint32_t playerId, uint32_t ownerId) { } void Game::playerSaveWheel(uint32_t playerId, NetworkMessage &msg) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9776,7 +9786,7 @@ void Game::playerSaveWheel(uint32_t playerId, NetworkMessage &msg) { } void Game::playerWheelGemAction(uint32_t playerId, NetworkMessage &msg) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9818,7 +9828,7 @@ void Game::playerWheelGemAction(uint32_t playerId, NetworkMessage &msg) { ********************/ void Game::updatePlayerSaleItems(uint32_t playerId) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } @@ -9828,33 +9838,33 @@ void Game::updatePlayerSaleItems(uint32_t playerId) { player->setScheduledSaleUpdate(false); } -void Game::addPlayer(std::shared_ptr<Player> player) { +void Game::addPlayer(const std::shared_ptr<Player> &player) { const std::string &lowercase_name = asLowerCaseString(player->getName()); mappedPlayerNames[lowercase_name] = player; wildcardTree->insert(lowercase_name); players[player->getID()] = player; } -void Game::removePlayer(std::shared_ptr<Player> player) { +void Game::removePlayer(const std::shared_ptr<Player> &player) { const std::string &lowercase_name = asLowerCaseString(player->getName()); mappedPlayerNames.erase(lowercase_name); wildcardTree->remove(lowercase_name); players.erase(player->getID()); } -void Game::addNpc(std::shared_ptr<Npc> npc) { +void Game::addNpc(const std::shared_ptr<Npc> &npc) { npcs[npc->getID()] = npc; } -void Game::removeNpc(std::shared_ptr<Npc> npc) { +void Game::removeNpc(const std::shared_ptr<Npc> &npc) { npcs.erase(npc->getID()); } -void Game::addMonster(std::shared_ptr<Monster> monster) { +void Game::addMonster(const std::shared_ptr<Monster> &monster) { monsters[monster->getID()] = monster; } -void Game::removeMonster(std::shared_ptr<Monster> monster) { +void Game::removeMonster(const std::shared_ptr<Monster> &monster) { monsters.erase(monster->getID()); } @@ -9881,7 +9891,7 @@ std::shared_ptr<Guild> Game::getGuildByName(const std::string &name, bool allowO return it->second; } -void Game::addGuild(const std::shared_ptr<Guild> guild) { +void Game::addGuild(const std::shared_ptr<Guild> &guild) { if (!guild) { return; } @@ -9898,7 +9908,7 @@ void Game::removeGuild(uint32_t guildId) { void Game::internalRemoveItems(const std::vector<std::shared_ptr<Item>> &itemVector, uint32_t amount, bool stackable) { if (stackable) { - for (const std::shared_ptr<Item> &item : itemVector) { + for (const auto &item : itemVector) { if (item->getItemCount() > amount) { internalRemoveItem(item, amount); break; @@ -9908,7 +9918,7 @@ void Game::internalRemoveItems(const std::vector<std::shared_ptr<Item>> &itemVec } } } else { - for (const std::shared_ptr<Item> &item : itemVector) { + for (const auto &item : itemVector) { internalRemoveItem(item); } } @@ -9958,7 +9968,7 @@ void Game::removeUniqueItem(uint16_t uniqueId) { bool Game::hasEffect(uint16_t effectId) { for (uint16_t i = CONST_ME_NONE; i < CONST_ME_LAST; i++) { - MagicEffectClasses effect = static_cast<MagicEffectClasses>(i); + auto effect = static_cast<MagicEffectClasses>(i); if (effect == effectId) { return true; } @@ -9968,7 +9978,7 @@ bool Game::hasEffect(uint16_t effectId) { bool Game::hasDistanceEffect(uint16_t effectId) { for (uint16_t i = CONST_ANI_NONE; i <= CONST_ANI_LAST; i++) { - ShootType_t effect = static_cast<ShootType_t>(i); + auto effect = static_cast<ShootType_t>(i); if (effect == effectId) { return true; } @@ -9978,14 +9988,14 @@ bool Game::hasDistanceEffect(uint16_t effectId) { void Game::createLuaItemsOnMap() { for (const auto [position, itemId] : mapLuaItemsStored) { - std::shared_ptr<Item> item = Item::CreateItem(itemId, 1); + const auto &item = Item::CreateItem(itemId, 1); if (!item) { g_logger().warn("[Game::createLuaItemsOnMap] - Cannot create item with id {}", itemId); continue; } if (position.x != 0) { - std::shared_ptr<Tile> tile = g_game().map.getTile(position); + const auto &tile = g_game().map.getTile(position); if (!tile) { g_logger().warn("[Game::createLuaItemsOnMap] - Tile is wrong or not found position: {}", position.toString()); @@ -10003,7 +10013,7 @@ void Game::createLuaItemsOnMap() { } } -void Game::sendUpdateCreature(std::shared_ptr<Creature> creature) { +void Game::sendUpdateCreature(const std::shared_ptr<Creature> &creature) { if (!creature) { return; } @@ -10020,10 +10030,6 @@ uint32_t Game::makeInfluencedMonster() { return 0; } - if (forgeableMonsters.empty()) { - return 0; - } - auto maxTries = forgeableMonsters.size(); uint16_t tries = 0; std::shared_ptr<Monster> monster = nullptr; @@ -10056,7 +10062,7 @@ uint32_t Game::makeInfluencedMonster() { if (monster && monster->canBeForgeMonster()) { monster->setMonsterForgeClassification(ForgeClassifications_t::FORGE_INFLUENCED_MONSTER); monster->configureForgeSystem(); - influencedMonsters.insert(monster->getID()); + influencedMonsters.emplace(monster->getID()); return monster->getID(); } @@ -10165,7 +10171,7 @@ uint32_t Game::makeFiendishMonster(uint32_t forgeableMonsterId /* = 0*/, bool cr monster->setMonsterForgeClassification(ForgeClassifications_t::FORGE_FIENDISH_MONSTER); monster->configureForgeSystem(); monster->setTimeToChangeFiendish(timeToChangeFiendish + getTimeNow()); - fiendishMonsters.insert(monster->getID()); + fiendishMonsters.emplace(monster->getID()); auto schedulerTask = createPlayerTask( finalTime, @@ -10180,7 +10186,7 @@ uint32_t Game::makeFiendishMonster(uint32_t forgeableMonsterId /* = 0*/, bool cr } void Game::updateFiendishMonsterStatus(uint32_t monsterId, const std::string &monsterName) { - std::shared_ptr<Monster> monster = getMonsterByID(monsterId); + const auto &monster = getMonsterByID(monsterId); if (!monster) { g_logger().warn("[{}] Failed to update monster with id {} and name {}, monster not found", __FUNCTION__, monsterId, monsterName); return; @@ -10248,12 +10254,12 @@ void Game::updateForgeableMonsters() { } if (monster->canBeForgeMonster() && !monsterTile->hasFlag(TILESTATE_NOLOGOUT)) { - forgeableMonsters.push_back(monster->getID()); + forgeableMonsters.emplace_back(monster->getID()); } } } - for (const auto monsterId : getFiendishMonsters()) { + for (const auto &monsterId : getFiendishMonsters()) { if (!getMonsterByID(monsterId)) { removeFiendishMonster(monsterId); } @@ -10293,9 +10299,7 @@ void Game::createInfluencedMonsters() { break; } - if (auto ret = makeInfluencedMonster(); - // If condition - ret == 0) { + if (makeInfluencedMonster() == 0) { return; } @@ -10311,7 +10315,7 @@ void Game::checkForgeEventId(uint32_t monsterId) { } } -bool Game::addInfluencedMonster(std::shared_ptr<Monster> monster) { +bool Game::addInfluencedMonster(const std::shared_ptr<Monster> &monster) { if (monster && monster->canBeForgeMonster()) { if (auto maxInfluencedMonsters = static_cast<uint32_t>(g_configManager().getNumber(FORGE_INFLUENCED_CREATURES_LIMIT)); // If condition @@ -10321,14 +10325,14 @@ bool Game::addInfluencedMonster(std::shared_ptr<Monster> monster) { monster->setMonsterForgeClassification(ForgeClassifications_t::FORGE_INFLUENCED_MONSTER); monster->configureForgeSystem(); - influencedMonsters.insert(monster->getID()); + influencedMonsters.emplace(monster->getID()); return true; } return false; } -bool Game::addItemStoreInbox(std::shared_ptr<Player> player, uint32_t itemId) { - std::shared_ptr<Item> decoKit = Item::CreateItem(ITEM_DECORATION_KIT, 1); +bool Game::addItemStoreInbox(const std::shared_ptr<Player> &player, uint32_t itemId) { + const auto &decoKit = Item::CreateItem(ITEM_DECORATION_KIT, 1); if (!decoKit) { return false; } @@ -10337,17 +10341,17 @@ bool Game::addItemStoreInbox(std::shared_ptr<Player> player, uint32_t itemId) { decoKit->setAttribute(ItemAttribute_t::DESCRIPTION, description); decoKit->setCustomAttribute("unWrapId", static_cast<int64_t>(itemId)); - std::shared_ptr<Thing> thing = player->getThing(CONST_SLOT_STORE_INBOX); + const auto &thing = player->getThing(CONST_SLOT_STORE_INBOX); if (!thing) { return false; } - std::shared_ptr<Item> inboxItem = thing->getItem(); + const auto &inboxItem = thing->getItem(); if (!inboxItem) { return false; } - std::shared_ptr<Container> inboxContainer = inboxItem->getContainer(); + const auto &inboxContainer = inboxItem->getContainer(); if (!inboxContainer) { return false; } @@ -10359,7 +10363,7 @@ bool Game::addItemStoreInbox(std::shared_ptr<Player> player, uint32_t itemId) { return true; } -void Game::addPlayerUniqueLogin(std::shared_ptr<Player> player) { +void Game::addPlayerUniqueLogin(const std::shared_ptr<Player> &player) { if (!player) { g_logger().error("Attempted to add null player to unique player names list"); return; @@ -10389,7 +10393,7 @@ void Game::removePlayerUniqueLogin(const std::string &playerName) { m_uniqueLoginPlayerNames.erase(lowercase_name); } -void Game::removePlayerUniqueLogin(std::shared_ptr<Player> player) { +void Game::removePlayerUniqueLogin(const std::shared_ptr<Player> &player) { if (!player) { g_logger().error("Attempted to remove null player from unique player names list."); return; @@ -10400,14 +10404,13 @@ void Game::removePlayerUniqueLogin(std::shared_ptr<Player> player) { } void Game::playerCheckActivity(const std::string &playerName, int interval) { - std::shared_ptr<Player> player = getPlayerUniqueLogin(playerName); + const auto &player = getPlayerUniqueLogin(playerName); if (!player) { return; } if (player->getIP() == 0) { g_game().removePlayerUniqueLogin(playerName); - IOLoginData::updateOnlineStatus(player->guid, false); g_logger().info("Player with name '{}' has logged out due to exited in death screen", player->getName()); player->disconnect(); return; @@ -10423,7 +10426,6 @@ void Game::playerCheckActivity(const std::string &playerName, int interval) { if (player->m_deathTime > (kickAfterMinutes * 60000) + 60000) { g_logger().info("Player with name '{}' has logged out due to inactivity after death", player->getName()); g_game().removePlayerUniqueLogin(playerName); - IOLoginData::updateOnlineStatus(player->guid, false); player->disconnect(); return; } @@ -10435,18 +10437,18 @@ void Game::playerCheckActivity(const std::string &playerName, int interval) { } void Game::playerRewardChestCollect(uint32_t playerId, const Position &pos, uint16_t itemId, uint8_t stackPos, uint32_t maxMoveItems /* = 0*/) { - std::shared_ptr<Player> player = getPlayerByID(playerId); + const auto &player = getPlayerByID(playerId); if (!player) { return; } - std::shared_ptr<Thing> thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); + const auto &thing = internalGetThing(player, pos, stackPos, itemId, STACKPOS_FIND_THING); if (!thing) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; } - auto item = thing->getItem(); + const auto &item = thing->getItem(); if (!item || item->getID() != ITEM_REWARD_CHEST || !item->getContainer()) { player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE); return; @@ -10480,9 +10482,9 @@ void Game::playerRewardChestCollect(uint32_t playerId, const Position &pos, uint } } -bool Game::tryRetrieveStashItems(std::shared_ptr<Player> player, std::shared_ptr<Item> item) { +bool Game::tryRetrieveStashItems(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) { ObjectCategory_t category = getObjectCategory(item); - return internalCollectManagedItems(std::move(player), item, category, false) == RETURNVALUE_NOERROR; + return internalCollectManagedItems(player, item, category, false) == RETURNVALUE_NOERROR; } std::unique_ptr<IOWheel> &Game::getIOWheel() { @@ -10547,7 +10549,7 @@ std::vector<T> setDifference(const std::unordered_set<T> &setA, const std::unord return setResult; } -ReturnValue Game::beforeCreatureZoneChange(std::shared_ptr<Creature> creature, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones, bool force /* = false*/) const { +ReturnValue Game::beforeCreatureZoneChange(const std::shared_ptr<Creature> &creature, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones, bool force /* = false*/) const { if (!creature) { return RETURNVALUE_NOTPOSSIBLE; } @@ -10577,7 +10579,8 @@ ReturnValue Game::beforeCreatureZoneChange(std::shared_ptr<Creature> creature, c return RETURNVALUE_NOERROR; } -void Game::afterCreatureZoneChange(std::shared_ptr<Creature> creature, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones) const { +void Game::afterCreatureZoneChange(const std::shared_ptr<Creature> &creatures, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones) const { + auto creature = creatures; if (!creature) { return; } @@ -10610,7 +10613,7 @@ const std::vector<HighscoreCategory> &Game::getHighscoreCategories() const { return m_highscoreCategories; } -void Game::registerAchievement(uint16_t id, std::string name, std::string description, bool secret, uint8_t grade, uint8_t points) { +void Game::registerAchievement(uint16_t id, const std::string &name, std::string description, bool secret, uint8_t grade, uint8_t points) { m_achievements[id] = Achievement(); m_achievements[id].id = id; m_achievements[id].name = name; @@ -10626,7 +10629,7 @@ Achievement Game::getAchievementById(uint16_t id) { return m_achievements[id]; } -Achievement Game::getAchievementByName(std::string name) { +Achievement Game::getAchievementByName(const std::string &name) { auto it = m_achievementsNameToId.find(name); if (it != m_achievementsNameToId.end()) { return getAchievementById(it->second); @@ -10736,3 +10739,51 @@ const std::unordered_map<uint16_t, std::string> &Game::getHirelingSkills() { const std::unordered_map<uint16_t, std::string> &Game::getHirelingOutfits() { return m_hirelingOutfits; } + +void Game::updatePlayersOnline() const { + // Function to be executed within the transaction + auto updateOperation = [this]() { + const auto &m_players = getPlayers(); + bool changesMade = false; + + // g_metrics().addUpDownCounter("players_online", 1); + // g_metrics().addUpDownCounter("players_online", -1); + + if (m_players.empty()) { + std::string query = "SELECT COUNT(*) AS count FROM players_online;"; + auto result = g_database().storeQuery(query); + int count = result->getNumber<int>("count"); + if (count > 0) { + g_database().executeQuery("DELETE FROM `players_online`;"); + changesMade = true; + } + } else { + // Insert the current players + DBInsert stmt("INSERT IGNORE INTO `players_online` (player_id) VALUES "); + for (const auto &[key, player] : m_players) { + std::ostringstream playerQuery; + playerQuery << "(" << player->getGUID() << ")"; + stmt.addRow(playerQuery.str()); + } + stmt.execute(); + changesMade = true; + + // Remove players who are no longer online + std::ostringstream cleanupQuery; + cleanupQuery << "DELETE FROM `players_online` WHERE `player_id` NOT IN ("; + for (const auto &[key, player] : m_players) { + cleanupQuery << player->getGUID() << ","; + } + cleanupQuery.seekp(-1, std::ostringstream::cur); // Remove the last comma + cleanupQuery << ");"; + g_database().executeQuery(cleanupQuery.str()); + } + + return changesMade; + }; + + const bool success = DBTransaction::executeWithinTransaction(updateOperation); + if (!success) { + g_logger().error("[Game::updatePlayersOnline] Failed to update players online."); + } +} diff --git a/src/game/game.hpp b/src/game/game.hpp index e04dbb26cff..7d614d760e4 100644 --- a/src/game/game.hpp +++ b/src/game/game.hpp @@ -39,7 +39,6 @@ class ServiceManager; class Creature; class Monster; class Npc; -class CombatInfo; class Charm; class IOPrey; class IOWheel; @@ -63,6 +62,7 @@ static constexpr int32_t EVENT_LUA_GARBAGE_COLLECTION = 60000 * 10; // 10min static constexpr std::chrono::minutes CACHE_EXPIRATION_TIME { 10 }; // 10min static constexpr std::chrono::minutes HIGHSCORE_CACHE_EXPIRATION_TIME { 10 }; // 10min +static constexpr int32_t UPDATE_PLAYERS_ONLINE_DB = 60000 * 10; // 10min struct QueryHighscoreCacheEntry { std::string query; @@ -130,7 +130,7 @@ class Game { } const std::unique_ptr<TeamFinder> &getTeamFinder(const std::shared_ptr<Player> &player) const { - auto it = teamFinderMap.find(player->getGUID()); + const auto it = teamFinderMap.find(player->getGUID()); if (it != teamFinderMap.end()) { return it->second; } @@ -139,7 +139,7 @@ class Game { } const std::unique_ptr<TeamFinder> &getOrCreateTeamFinder(const std::shared_ptr<Player> &player) { - auto it = teamFinderMap.find(player->getGUID()); + const auto it = teamFinderMap.find(player->getGUID()); if (it != teamFinderMap.end()) { return it->second; } @@ -151,11 +151,11 @@ class Game { teamFinderMap.erase(leaderGuid); } - std::shared_ptr<Cylinder> internalGetCylinder(std::shared_ptr<Player> player, const Position &pos); - std::shared_ptr<Thing> internalGetThing(std::shared_ptr<Player> player, const Position &pos, int32_t index, uint32_t itemId, StackPosType_t type); - static void internalGetPosition(std::shared_ptr<Item> item, Position &pos, uint8_t &stackpos); + std::shared_ptr<Cylinder> internalGetCylinder(const std::shared_ptr<Player> &player, const Position &pos); + std::shared_ptr<Thing> internalGetThing(const std::shared_ptr<Player> &player, const Position &pos, int32_t index, uint32_t itemId, StackPosType_t type); + static void internalGetPosition(const std::shared_ptr<Item> &item, Position &pos, uint8_t &stackpos); - static std::string getTradeErrorDescription(ReturnValue ret, std::shared_ptr<Item> item); + static std::string getTradeErrorDescription(ReturnValue ret, const std::shared_ptr<Item> &item); std::shared_ptr<Creature> getCreatureByID(uint32_t id); @@ -177,13 +177,13 @@ class Game { ReturnValue getPlayerByNameWildcard(const std::string &s, std::shared_ptr<Player> &player); - std::vector<std::shared_ptr<Player>> getPlayersByAccount(std::shared_ptr<Account> acc, bool allowOffline = false); + std::vector<std::shared_ptr<Player>> getPlayersByAccount(const std::shared_ptr<Account> &acc, bool allowOffline = false); - bool internalPlaceCreature(std::shared_ptr<Creature> creature, const Position &pos, bool extendedPos = false, bool forced = false, bool creatureCheck = false); + bool internalPlaceCreature(const std::shared_ptr<Creature> &creature, const Position &pos, bool extendedPos = false, bool forced = false, bool creatureCheck = false); - bool placeCreature(std::shared_ptr<Creature> creature, const Position &pos, bool extendedPos = false, bool force = false); + bool placeCreature(const std::shared_ptr<Creature> &creature, const Position &pos, bool extendedPos = false, bool force = false); - bool removeCreature(std::shared_ptr<Creature> creature, bool isLogout = true); + bool removeCreature(const std::shared_ptr<Creature> &creature, bool isLogout = true); void executeDeath(uint32_t creatureId); void addCreatureCheck(const std::shared_ptr<Creature> &creature); @@ -206,14 +206,14 @@ class Game { itemsClassifications.push_back(itemsClassification); } ItemClassification* getItemsClassification(uint8_t id, bool create) { - auto it = std::find_if(itemsClassifications.begin(), itemsClassifications.end(), [id](ItemClassification* it) { - return it->id == id; + const auto it = std::ranges::find_if(itemsClassifications, [id](const ItemClassification* item) { + return item->id == id; }); if (it != itemsClassifications.end()) { return *it; } else if (create) { - ItemClassification* itemClassification = new ItemClassification(id); + auto* itemClassification = new ItemClassification(id); addItemsClassification(itemClassification); return itemClassification; } @@ -225,38 +225,38 @@ class Game { bool gameIsDay(); - ReturnValue internalMoveCreature(std::shared_ptr<Creature> creature, Direction direction, uint32_t flags = 0); + ReturnValue internalMoveCreature(const std::shared_ptr<Creature> &creature, Direction direction, uint32_t flags = 0); ReturnValue internalMoveCreature(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &toTile, uint32_t flags = 0); - ReturnValue checkMoveItemToCylinder(std::shared_ptr<Player> player, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder, std::shared_ptr<Item> item, Position toPos); - ReturnValue internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder, int32_t index, std::shared_ptr<Item> item, uint32_t count, std::shared_ptr<Item>* movedItem, uint32_t flags = 0, std::shared_ptr<Creature> actor = nullptr, std::shared_ptr<Item> tradeItem = nullptr, bool checkTile = true); + ReturnValue checkMoveItemToCylinder(const std::shared_ptr<Player> &player, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder, const std::shared_ptr<Item> &item, Position toPos); + ReturnValue internalMoveItem(std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder, int32_t index, const std::shared_ptr<Item> &item, uint32_t count, std::shared_ptr<Item>* movedItem, uint32_t flags = 0, const std::shared_ptr<Creature> &actor = nullptr, const std::shared_ptr<Item> &tradeItem = nullptr, bool checkTile = true); std::tuple<ReturnValue, uint32_t, uint32_t> addItemBatch(const std::shared_ptr<Cylinder> &toCylinder, const std::vector<std::shared_ptr<Item>> &items, uint32_t flags = 0, bool dropOnMap = true, uint32_t autoContainerId = 0); std::tuple<ReturnValue, uint32_t, uint32_t> createItemBatch(const std::shared_ptr<Cylinder> &toCylinder, const std::vector<std::tuple<uint16_t, uint32_t, uint16_t>> &itemCounts, uint32_t flags = 0, bool dropOnMap = true, uint32_t autoContainerId = 0); std::tuple<ReturnValue, uint32_t, uint32_t> createItem(const std::shared_ptr<Cylinder> &toCylinder, uint16_t itemId, uint32_t count, uint16_t subType, uint32_t flags = 0, bool dropOnMap = true, uint32_t autoContainerId = 0); - ReturnValue internalAddItem(std::shared_ptr<Cylinder> toCylinder, std::shared_ptr<Item> item, int32_t index = INDEX_WHEREEVER, uint32_t flags = 0, bool test = false); - ReturnValue internalAddItem(std::shared_ptr<Cylinder> toCylinder, std::shared_ptr<Item> item, int32_t index, uint32_t flags, bool test, uint32_t &remainderCount); - ReturnValue internalRemoveItem(std::shared_ptr<Item> item, int32_t count = -1, bool test = false, uint32_t flags = 0, bool force = false); + ReturnValue internalAddItem(std::shared_ptr<Cylinder> toCylinder, const std::shared_ptr<Item> &item, int32_t index = INDEX_WHEREEVER, uint32_t flags = 0, bool test = false); + ReturnValue internalAddItem(std::shared_ptr<Cylinder> toCylinder, const std::shared_ptr<Item> &item, int32_t index, uint32_t flags, bool test, uint32_t &remainderCount); + ReturnValue internalRemoveItem(const std::shared_ptr<Item> &item, int32_t count = -1, bool test = false, uint32_t flags = 0, bool force = false); - ReturnValue internalPlayerAddItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, bool dropOnMap = true, Slots_t slot = CONST_SLOT_WHEREEVER); + ReturnValue internalPlayerAddItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, bool dropOnMap = true, Slots_t slot = CONST_SLOT_WHEREEVER); - std::shared_ptr<Item> findItemOfType(std::shared_ptr<Cylinder> cylinder, uint16_t itemId, bool depthSearch = true, int32_t subType = -1) const; + std::shared_ptr<Item> findItemOfType(const std::shared_ptr<Cylinder> &cylinder, uint16_t itemId, bool depthSearch = true, int32_t subType = -1) const; void createLuaItemsOnMap(); - bool removeMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint32_t flags = 0, bool useBank = false); + bool removeMoney(const std::shared_ptr<Cylinder> &cylinder, uint64_t money, uint32_t flags = 0, bool useBank = false); - void addMoney(std::shared_ptr<Cylinder> cylinder, uint64_t money, uint32_t flags = 0); + void addMoney(const std::shared_ptr<Cylinder> &cylinder, uint64_t money, uint32_t flags = 0); std::shared_ptr<Item> transformItem(std::shared_ptr<Item> item, uint16_t newId, int32_t newCount = -1); ReturnValue internalTeleport(const std::shared_ptr<Thing> &thing, const Position &newPos, bool pushMove = true, uint32_t flags = 0); - bool internalCreatureTurn(std::shared_ptr<Creature> creature, Direction dir); + bool internalCreatureTurn(const std::shared_ptr<Creature> &creature, Direction dir); - bool internalCreatureSay(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, bool ghostMode, Spectators* spectatorsPtr = nullptr, const Position* pos = nullptr); + bool internalCreatureSay(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, bool ghostMode, Spectators* spectatorsPtr = nullptr, const Position* pos = nullptr); - ObjectCategory_t getObjectCategory(const std::shared_ptr<Item> item); + ObjectCategory_t getObjectCategory(const std::shared_ptr<Item> &item); ObjectCategory_t getObjectCategory(const ItemType &it); uint64_t getItemMarketPrice(const std::map<uint16_t, uint64_t> &itemMap, bool buyPrice) const; @@ -264,8 +264,8 @@ class Game { void loadPlayersRecord(); void checkPlayersRecord(); - void sendSingleSoundEffect(const Position &pos, SoundEffect_t soundId, std::shared_ptr<Creature> actor = nullptr); - void sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundEffect, SoundEffect_t secondarySoundEffect, std::shared_ptr<Creature> actor = nullptr); + void sendSingleSoundEffect(const Position &pos, SoundEffect_t soundId, const std::shared_ptr<Creature> &actor = nullptr); + void sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundEffect, SoundEffect_t secondarySoundEffect, const std::shared_ptr<Creature> &actor = nullptr); void sendGuildMotd(uint32_t playerId); void kickPlayer(uint32_t playerId, bool displayEffect); @@ -297,38 +297,38 @@ class Game { void playerBrowseForgeHistory(uint32_t playerId, uint8_t page); void playerBosstiarySlot(uint32_t playerId, uint8_t slotId, uint32_t selectedBossId); - void playerSetMonsterPodium(uint32_t playerId, uint32_t monsterRaceId, const Position &pos, uint8_t stackPos, const uint16_t itemId, uint8_t direction, const std::pair<uint8_t, uint8_t> &podiumAndMonsterVisible); - void playerRotatePodium(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId); + void playerSetMonsterPodium(uint32_t playerId, uint32_t monsterRaceId, const Position &pos, uint8_t stackPos, uint16_t itemId, uint8_t direction, const std::pair<uint8_t, uint8_t> &podiumAndMonsterVisible); + void playerRotatePodium(uint32_t playerId, const Position &pos, uint8_t stackPos, uint16_t itemId); void playerRequestInventoryImbuements(uint32_t playerId, bool isTrackerOpen); - bool addItemStoreInbox(std::shared_ptr<Player> player, uint32_t itemId); + bool addItemStoreInbox(const std::shared_ptr<Player> &player, uint32_t itemId); void playerRewardChestCollect(uint32_t playerId, const Position &pos, uint16_t itemId, uint8_t stackPos, uint32_t maxMoveItems = 0); void playerReportRuleViolationReport(uint32_t playerId, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation); - void playerFriendSystemAction(std::shared_ptr<Player> player, uint8_t type, uint8_t titleId); + void playerFriendSystemAction(const std::shared_ptr<Player> &player, uint8_t type, uint8_t titleId); - void playerCyclopediaCharacterInfo(std::shared_ptr<Player> player, uint32_t characterID, CyclopediaCharacterInfoType_t characterInfoType, uint16_t entriesPerPage, uint16_t page); + void playerCyclopediaCharacterInfo(const std::shared_ptr<Player> &player, uint32_t characterID, CyclopediaCharacterInfoType_t characterInfoType, uint16_t entriesPerPage, uint16_t page); - void playerHighscores(std::shared_ptr<Player> player, HighscoreType_t type, uint8_t category, uint32_t vocation, const std::string &worldName, uint16_t page, uint8_t entriesPerPage); + void playerHighscores(const std::shared_ptr<Player> &player, HighscoreType_t type, uint8_t category, uint32_t vocation, const std::string &worldName, uint16_t page, uint8_t entriesPerPage); static std::string getSkillNameById(uint8_t &skill); void updatePlayerSaleItems(uint32_t playerId); - bool internalStartTrade(std::shared_ptr<Player> player, std::shared_ptr<Player> partner, std::shared_ptr<Item> tradeItem); - void internalCloseTrade(std::shared_ptr<Player> player); - bool playerBroadcastMessage(std::shared_ptr<Player> player, const std::string &text) const; + bool internalStartTrade(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &partner, const std::shared_ptr<Item> &tradeItem); + void internalCloseTrade(const std::shared_ptr<Player> &player); + bool playerBroadcastMessage(const std::shared_ptr<Player> &player, const std::string &text) const; void broadcastMessage(const std::string &text, MessageClasses type) const; // Implementation of player invoked events void playerTeleport(uint32_t playerId, const Position &pos); void playerMoveThing(uint32_t playerId, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count); void playerMoveCreatureByID(uint32_t playerId, uint32_t movingCreatureId, const Position &movingCreatureOrigPos, const Position &toPos); - void playerMoveCreature(std::shared_ptr<Player> playerId, std::shared_ptr<Creature> movingCreature, const Position &movingCreatureOrigPos, std::shared_ptr<Tile> toTile); + void playerMoveCreature(const std::shared_ptr<Player> &playerId, const std::shared_ptr<Creature> &movingCreature, const Position &movingCreatureOrigPos, const std::shared_ptr<Tile> &toTile); void playerMoveItemByPlayerID(uint32_t playerId, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count); - void playerMoveItem(std::shared_ptr<Player> player, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count, std::shared_ptr<Item> item, std::shared_ptr<Cylinder> toCylinder); + void playerMoveItem(const std::shared_ptr<Player> &player, const Position &fromPos, uint16_t itemId, uint8_t fromStackPos, const Position &toPos, uint8_t count, std::shared_ptr<Item> item, std::shared_ptr<Cylinder> toCylinder); void playerEquipItem(uint32_t playerId, uint16_t itemId, bool hasTier = false, uint8_t tier = 0); void playerMove(uint32_t playerId, Direction direction); void forcePlayerMove(uint32_t playerId, Direction direction); @@ -353,10 +353,10 @@ class Game { void playerCloseContainer(uint32_t playerId, uint8_t cid); void playerMoveUpContainer(uint32_t playerId, uint8_t cid); void playerUpdateContainer(uint32_t playerId, uint8_t cid); - void playerRotateItem(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId); - void playerConfigureShowOffSocket(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId); - void playerSetShowOffSocket(uint32_t playerId, Outfit_t &outfit, const Position &pos, uint8_t stackPos, const uint16_t itemId, uint8_t podiumVisible, uint8_t direction); - void playerWrapableItem(uint32_t playerId, const Position &pos, uint8_t stackPos, const uint16_t itemId); + void playerRotateItem(uint32_t playerId, const Position &pos, uint8_t stackPos, uint16_t itemId); + void playerConfigureShowOffSocket(uint32_t playerId, const Position &pos, uint8_t stackPos, uint16_t itemId); + void playerSetShowOffSocket(uint32_t playerId, Outfit_t &outfit, const Position &pos, uint8_t stackPos, uint16_t itemId, uint8_t podiumVisible, uint8_t direction); + void playerWrapableItem(uint32_t playerId, const Position &pos, uint8_t stackPos, uint16_t itemId); void playerWriteItem(uint32_t playerId, uint32_t windowTextId, const std::string &text); void playerBrowseField(uint32_t playerId, const Position &pos); void playerSeekInContainer(uint32_t playerId, uint8_t containerId, uint16_t index, uint8_t containerCategory); @@ -375,21 +375,21 @@ class Game { void playerSetFightModes(uint32_t playerId, FightMode_t fightMode, bool chaseMode, bool secureMode); void playerLookAt(uint32_t playerId, uint16_t itemId, const Position &pos, uint8_t stackPos); void playerLookInBattleList(uint32_t playerId, uint32_t creatureId); - void playerQuickLootCorpse(std::shared_ptr<Player> player, std::shared_ptr<Container> corpse, const Position &position); - void playerQuickLoot(uint32_t playerId, const Position &pos, uint16_t itemId, uint8_t stackPos, std::shared_ptr<Item> defaultItem = nullptr, bool lootAllCorpses = false, bool autoLoot = false); - void playerLootAllCorpses(std::shared_ptr<Player> player, const Position &pos, bool lootAllCorpses); + void playerQuickLootCorpse(const std::shared_ptr<Player> &player, const std::shared_ptr<Container> &corpse, const Position &position); + void playerQuickLoot(uint32_t playerId, const Position &pos, uint16_t itemId, uint8_t stackPos, const std::shared_ptr<Item> &defaultItem = nullptr, bool lootAllCorpses = false, bool autoLoot = false); + void playerLootAllCorpses(const std::shared_ptr<Player> &player, const Position &pos, bool lootAllCorpses); void playerSetManagedContainer(uint32_t playerId, ObjectCategory_t category, const Position &pos, uint16_t itemId, uint8_t stackPos, bool isLootContainer); void playerClearManagedContainer(uint32_t playerId, ObjectCategory_t category, bool isLootContainer); void playerOpenManagedContainer(uint32_t playerId, ObjectCategory_t category, bool isLootContainer); void playerSetQuickLootFallback(uint32_t playerId, bool fallback); - void playerQuickLootBlackWhitelist(uint32_t playerId, QuickLootFilter_t filter, const std::vector<uint16_t> itemIds); + void playerQuickLootBlackWhitelist(uint32_t playerId, QuickLootFilter_t filter, const std::vector<uint16_t> &itemIds); void playerRequestDepotItems(uint32_t playerId); void playerRequestCloseDepotSearch(uint32_t playerId); void playerRequestDepotSearchItem(uint32_t playerId, uint16_t itemId, uint8_t tier); void playerRequestDepotSearchRetrieve(uint32_t playerId, uint16_t itemId, uint8_t tier, uint8_t type); void playerRequestOpenContainerFromDepotSearch(uint32_t playerId, const Position &pos); - void playerMoveThingFromDepotSearch(std::shared_ptr<Player> player, uint16_t itemId, uint8_t tier, uint8_t count, const Position &fromPos, const Position &toPos, bool allItems = false); + void playerMoveThingFromDepotSearch(const std::shared_ptr<Player> &player, uint16_t itemId, uint8_t tier, uint8_t count, const Position &fromPos, const Position &toPos, bool allItems = false); void playerRequestAddVip(uint32_t playerId, const std::string &name); void playerRequestRemoveVip(uint32_t playerId, uint32_t guid); @@ -424,11 +424,11 @@ class Game { void playerSaveWheel(uint32_t playerId, NetworkMessage &msg); void playerWheelGemAction(uint32_t playerId, NetworkMessage &msg); - void updatePlayerHelpers(std::shared_ptr<Player> player); + void updatePlayerHelpers(const std::shared_ptr<Player> &player); void shutdown(); void dieSafely(const std::string &errorMsg); - void addBestiaryList(uint16_t raceid, std::string name); + void addBestiaryList(uint16_t raceid, const std::string &name); const std::map<uint16_t, std::string> &getBestiaryList() const { return BestiaryList; } @@ -445,18 +445,18 @@ class Game { bool canThrowObjectTo(const Position &fromPos, const Position &toPos, SightLines_t lineOfSight = SightLine_CheckSightLine, int32_t rangex = MAP_MAX_CLIENT_VIEW_PORT_X, int32_t rangey = MAP_MAX_CLIENT_VIEW_PORT_Y); bool isSightClear(const Position &fromPos, const Position &toPos, bool sameFloor); - void changeSpeed(std::shared_ptr<Creature> creature, int32_t varSpeedDelta); - void setCreatureSpeed(std::shared_ptr<Creature> creature, int32_t speed); // setCreatureSpeed + void changeSpeed(const std::shared_ptr<Creature> &creature, int32_t varSpeedDelta); + void setCreatureSpeed(const std::shared_ptr<Creature> &creature, int32_t speed); // setCreatureSpeed void changePlayerSpeed(const std::shared_ptr<Player> &player, int32_t varSpeedDelta); - void internalCreatureChangeOutfit(std::shared_ptr<Creature> creature, const Outfit_t &oufit); - void internalCreatureChangeVisible(std::shared_ptr<Creature> creature, bool visible); - void changeLight(const std::shared_ptr<Creature> creature); - void updateCreatureIcon(const std::shared_ptr<Creature> creature); - void reloadCreature(const std::shared_ptr<Creature> creature); - void updateCreatureSkull(std::shared_ptr<Creature> player); - void updatePlayerShield(std::shared_ptr<Player> player); - void updateCreatureType(std::shared_ptr<Creature> creature); - void updateCreatureWalkthrough(const std::shared_ptr<Creature> creature); + void internalCreatureChangeOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &oufit); + void internalCreatureChangeVisible(const std::shared_ptr<Creature> &creature, bool visible); + void changeLight(const std::shared_ptr<Creature> &creature); + void updateCreatureIcon(const std::shared_ptr<Creature> &creature); + void reloadCreature(const std::shared_ptr<Creature> &creature); + void updateCreatureSkull(const std::shared_ptr<Creature> &player) const; + void updatePlayerShield(const std::shared_ptr<Player> &player); + void updateCreatureType(const std::shared_ptr<Creature> &creature); + void updateCreatureWalkthrough(const std::shared_ptr<Creature> &creature); GameState_t getGameState() const; void setGameState(GameState_t newState); @@ -468,41 +468,41 @@ class Game { void checkCreatures(); void checkLight(); - bool combatBlockHit(CombatDamage &damage, std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, bool checkDefense, bool checkArmor, bool field); + bool combatBlockHit(CombatDamage &damage, const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, bool checkDefense, bool checkArmor, bool field); - void combatGetTypeInfo(CombatType_t combatType, std::shared_ptr<Creature> target, TextColor_t &color, uint16_t &effect); + void combatGetTypeInfo(CombatType_t combatType, const std::shared_ptr<Creature> &target, TextColor_t &color, uint16_t &effect); // Hazard combat helpers - void handleHazardSystemAttack(CombatDamage &damage, std::shared_ptr<Player> player, const std::shared_ptr<Monster> monster, bool isPlayerAttacker); - void notifySpectators(const CreatureVector &spectators, const Position &targetPos, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Monster> targetMonster); + void handleHazardSystemAttack(CombatDamage &damage, const std::shared_ptr<Player> &player, const std::shared_ptr<Monster> &monster, bool isPlayerAttacker); + void notifySpectators(const CreatureVector &spectators, const Position &targetPos, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Monster> &targetMonster); // Custom PvP System combat helpers - void applyPvPDamage(CombatDamage &damage, std::shared_ptr<Player> attacker, std::shared_ptr<Player> target); - float pvpLevelDifferenceDamageMultiplier(std::shared_ptr<Player> attacker, std::shared_ptr<Player> target); + void applyPvPDamage(CombatDamage &damage, const std::shared_ptr<Player> &attacker, const std::shared_ptr<Player> &target); + float pvpLevelDifferenceDamageMultiplier(const std::shared_ptr<Player> &attacker, const std::shared_ptr<Player> &target); // Wheel of destiny combat helpers - void applyWheelOfDestinyHealing(CombatDamage &damage, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Creature> target); - void applyWheelOfDestinyEffectsToDamage(CombatDamage &damage, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Creature> target) const; - int32_t applyHealthChange(CombatDamage &damage, std::shared_ptr<Creature> target) const; + void applyWheelOfDestinyHealing(CombatDamage &damage, const std::shared_ptr<Player> &attackerPlayer, std::shared_ptr<Creature> target); + void applyWheelOfDestinyEffectsToDamage(CombatDamage &damage, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Creature> &target) const; + int32_t applyHealthChange(const CombatDamage &damage, const std::shared_ptr<Creature> &target) const; - bool combatChangeHealth(std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, CombatDamage &damage, bool isEvent = false); - void applyCharmRune(std::shared_ptr<Monster> targetMonster, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Creature> target, const int32_t &realDamage) const; + bool combatChangeHealth(const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, CombatDamage &damage, bool isEvent = false); + void applyCharmRune(const std::shared_ptr<Monster> &targetMonster, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Creature> &target, const int32_t &realDamage) const; void applyManaLeech( - std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Monster> targetMonster, - std::shared_ptr<Creature> target, const CombatDamage &damage, const int32_t &realDamage + const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Monster> &targetMonster, + const std::shared_ptr<Creature> &target, const CombatDamage &damage, const int32_t &realDamage ) const; void applyLifeLeech( - std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Monster> targetMonster, - std::shared_ptr<Creature> target, const CombatDamage &damage, const int32_t &realDamage + const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Monster> &targetMonster, + const std::shared_ptr<Creature> &target, const CombatDamage &damage, const int32_t &realDamage ) const; int32_t calculateLeechAmount(const int32_t &realDamage, const uint16_t &skillAmount, int targetsAffected) const; - bool combatChangeMana(std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, CombatDamage &damage); + bool combatChangeMana(const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, CombatDamage &damage); // Animation help functions - void addCreatureHealth(const std::shared_ptr<Creature> target); - static void addCreatureHealth(const CreatureVector &spectators, const std::shared_ptr<Creature> target); - void addPlayerMana(const std::shared_ptr<Player> target); - void addPlayerVocation(const std::shared_ptr<Player> target); + void addCreatureHealth(const std::shared_ptr<Creature> &target); + static void addCreatureHealth(const CreatureVector &spectators, const std::shared_ptr<Creature> &target); + void addPlayerMana(const std::shared_ptr<Player> &target); + void addPlayerVocation(const std::shared_ptr<Player> &target); void addMagicEffect(const Position &pos, uint16_t effect); static void addMagicEffect(const std::vector<std::shared_ptr<Player>> &players, const Position &pos, uint16_t effect); static void addMagicEffect(const CreatureVector &spectators, const Position &pos, uint16_t effect); @@ -529,7 +529,7 @@ class Game { motdNum++; } - void sendOfflineTrainingDialog(std::shared_ptr<Player> player); + void sendOfflineTrainingDialog(const std::shared_ptr<Player> &player); const std::map<uint16_t, std::map<uint8_t, uint64_t>> &getItemsPrice() const { return itemsPriceMap; @@ -551,18 +551,18 @@ class Game { return itemsClassifications; } - void addPlayer(std::shared_ptr<Player> player); - void removePlayer(std::shared_ptr<Player> player); + void addPlayer(const std::shared_ptr<Player> &player); + void removePlayer(const std::shared_ptr<Player> &player); - void addNpc(std::shared_ptr<Npc> npc); - void removeNpc(std::shared_ptr<Npc> npc); + void addNpc(const std::shared_ptr<Npc> &npc); + void removeNpc(const std::shared_ptr<Npc> &npc); - void addMonster(std::shared_ptr<Monster> npc); - void removeMonster(std::shared_ptr<Monster> npc); + void addMonster(const std::shared_ptr<Monster> &npc); + void removeMonster(const std::shared_ptr<Monster> &npc); std::shared_ptr<Guild> getGuild(uint32_t id, bool allowOffline = false) const; std::shared_ptr<Guild> getGuildByName(const std::string &name, bool allowOffline = false) const; - void addGuild(const std::shared_ptr<Guild> guild); + void addGuild(const std::shared_ptr<Guild> &guild); void removeGuild(uint32_t guildId); phmap::flat_hash_map<std::shared_ptr<Tile>, std::weak_ptr<Container>> browseFields; @@ -591,20 +591,20 @@ class Game { auto getTilesToClean() const { return tilesToClean; } - void addTileToClean(std::shared_ptr<Tile> tile) { + void addTileToClean(const std::shared_ptr<Tile> &tile) { tilesToClean.emplace(tile); } - void removeTileToClean(std::shared_ptr<Tile> tile) { + void removeTileToClean(const std::shared_ptr<Tile> &tile) { tilesToClean.erase(tile); } void clearTilesToClean() { tilesToClean.clear(); } - void playerInspectItem(std::shared_ptr<Player> player, const Position &pos); - void playerInspectItem(std::shared_ptr<Player> player, uint16_t itemId, uint8_t itemCount, bool cyclopedia); + void playerInspectItem(const std::shared_ptr<Player> &player, const Position &pos); + void playerInspectItem(const std::shared_ptr<Player> &player, uint16_t itemId, uint8_t itemCount, bool cyclopedia); - void addCharmRune(const std::shared_ptr<Charm> charm) { + void addCharmRune(const std::shared_ptr<Charm> &charm) { CharmList.push_back(charm); CharmList.shrink_to_fit(); } @@ -615,15 +615,15 @@ class Game { FILELOADER_ERRORS loadAppearanceProtobuf(const std::string &file); bool isMagicEffectRegistered(uint16_t type) const { - return std::find(registeredMagicEffects.begin(), registeredMagicEffects.end(), type) != registeredMagicEffects.end(); + return std::ranges::find(registeredMagicEffects, type) != registeredMagicEffects.end(); } bool isDistanceEffectRegistered(uint16_t type) const { - return std::find(registeredDistanceEffects.begin(), registeredDistanceEffects.end(), type) != registeredDistanceEffects.end(); + return std::ranges::find(registeredDistanceEffects, type) != registeredDistanceEffects.end(); } bool isLookTypeRegistered(uint16_t type) const { - return std::find(registeredLookTypes.begin(), registeredLookTypes.end(), type) != registeredLookTypes.end(); + return std::ranges::find(registeredLookTypes, type) != registeredLookTypes.end(); } void setCreateLuaItems(Position position, uint16_t itemId) { @@ -649,9 +649,9 @@ class Game { uint32_t makeFiendishMonster(uint32_t forgeableMonsterId = 0, bool createForgeableMonsters = false); uint32_t makeInfluencedMonster(); - bool addInfluencedMonster(std::shared_ptr<Monster> monster); - void sendUpdateCreature(std::shared_ptr<Creature> creature); - std::shared_ptr<Item> wrapItem(std::shared_ptr<Item> item, std::shared_ptr<House> house); + bool addInfluencedMonster(const std::shared_ptr<Monster> &monster); + void sendUpdateCreature(const std::shared_ptr<Creature> &creature); + std::shared_ptr<Item> wrapItem(const std::shared_ptr<Item> &item, const std::shared_ptr<House> &house); /** * @brief Adds a player to the unique login map. @@ -660,7 +660,7 @@ class Game { * * @param player A pointer to the Player object to add. */ - void addPlayerUniqueLogin(std::shared_ptr<Player> player); + void addPlayerUniqueLogin(const std::shared_ptr<Player> &player); /** * @brief Gets a player from the unique login map using their name. @@ -689,7 +689,7 @@ class Game { * * @param player A pointer to the Player object to remove. */ - void removePlayerUniqueLogin(std::shared_ptr<Player> player); + void removePlayerUniqueLogin(const std::shared_ptr<Player> &player); void playerCheckActivity(const std::string &playerName, int interval); /** @@ -702,10 +702,10 @@ class Game { * @param item Pointer to the item to be checked. * @return True if stash items can be retrieved, false otherwise. */ - bool tryRetrieveStashItems(std::shared_ptr<Player> player, std::shared_ptr<Item> item); + bool tryRetrieveStashItems(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item); - ReturnValue beforeCreatureZoneChange(std::shared_ptr<Creature> creature, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones, bool force = false) const; - void afterCreatureZoneChange(std::shared_ptr<Creature> creature, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones) const; + ReturnValue beforeCreatureZoneChange(const std::shared_ptr<Creature> &creature, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones, bool force = false) const; + void afterCreatureZoneChange(const std::shared_ptr<Creature> &creature, const std::unordered_set<std::shared_ptr<Zone>> &fromZones, const std::unordered_set<std::shared_ptr<Zone>> &toZones) const; std::unique_ptr<IOWheel> &getIOWheel(); const std::unique_ptr<IOWheel> &getIOWheel() const; @@ -717,9 +717,9 @@ class Game { const std::vector<HighscoreCategory> &getHighscoreCategories() const; - void registerAchievement(uint16_t id, std::string name, std::string description, bool secret, uint8_t grade, uint8_t points); + void registerAchievement(uint16_t id, const std::string &name, std::string description, bool secret, uint8_t grade, uint8_t points); Achievement getAchievementById(uint16_t id); - Achievement getAchievementByName(std::string name); + Achievement getAchievementByName(const std::string &name); std::vector<Achievement> getSecretAchievements(); std::vector<Achievement> getPublicAchievements(); std::map<uint16_t, Achievement> getAchievements(); @@ -755,13 +755,13 @@ class Game { std::map<uint32_t, int32_t> forgeMonsterEventIds; std::unordered_set<uint32_t> fiendishMonsters; std::unordered_set<uint32_t> influencedMonsters; - void checkImbuements(); - bool playerSaySpell(std::shared_ptr<Player> player, SpeakClasses type, const std::string &text); - void playerWhisper(std::shared_ptr<Player> player, const std::string &text); - bool playerYell(std::shared_ptr<Player> player, const std::string &text); - bool playerSpeakTo(std::shared_ptr<Player> player, SpeakClasses type, const std::string &receiver, const std::string &text); - void playerSpeakToNpc(std::shared_ptr<Player> player, const std::string &text); - std::shared_ptr<Task> createPlayerTask(uint32_t delay, std::function<void(void)> f, std::string context) const; + void checkImbuements() const; + bool playerSaySpell(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &text); + void playerWhisper(const std::shared_ptr<Player> &player, const std::string &text); + bool playerYell(const std::shared_ptr<Player> &player, const std::string &text); + bool playerSpeakTo(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &receiver, const std::string &text); + void playerSpeakToNpc(const std::shared_ptr<Player> &player, const std::string &text); + std::shared_ptr<Task> createPlayerTask(uint32_t delay, std::function<void(void)> f, const std::string &context) const; /** * @brief Finds the managed container for loot or obtain based on the given parameters. @@ -775,7 +775,7 @@ class Game { * * @return Pointer to the managed container or nullptr if not found. */ - std::shared_ptr<Container> findManagedContainer(std::shared_ptr<Player> player, bool &fallbackConsumed, ObjectCategory_t category, bool isLootContainer); + std::shared_ptr<Container> findManagedContainer(const std::shared_ptr<Player> &player, bool &fallbackConsumed, ObjectCategory_t category, bool isLootContainer); /** * @brief Finds the next available sub-container within a container. @@ -796,7 +796,7 @@ class Game { * @param fallbackConsumed Reference to a boolean flag indicating whether a fallback has been consumed. * @return True if fallback logic was handled, false otherwise. */ - bool handleFallbackLogic(std::shared_ptr<Player> player, std::shared_ptr<Container> &lootContainer, ContainerIterator &containerIterator, const bool &fallbackConsumed); + bool handleFallbackLogic(const std::shared_ptr<Player> &player, std::shared_ptr<Container> &lootContainer, ContainerIterator &containerIterator, const bool &fallbackConsumed); /** * @brief Processes the movement or addition of an item to a loot container. @@ -807,7 +807,7 @@ class Game { * @param player Pointer to the player object. * @return Return value indicating success or error. */ - ReturnValue processMoveOrAddItemToLootContainer(std::shared_ptr<Item> item, std::shared_ptr<Container> lootContainer, uint32_t &remainderCount, std::shared_ptr<Player> player); + ReturnValue processMoveOrAddItemToLootContainer(const std::shared_ptr<Item> &item, const std::shared_ptr<Container> &lootContainer, uint32_t &remainderCount, const std::shared_ptr<Player> &player); /** * @brief Processes loot items and places them into the appropriate containers. @@ -818,7 +818,7 @@ class Game { * @param fallbackConsumed Reference to a boolean flag indicating whether a fallback has been consumed. * @return Return value indicating success or error. */ - ReturnValue processLootItems(std::shared_ptr<Player> player, std::shared_ptr<Container> lootContainer, std::shared_ptr<Item> item, bool &fallbackConsumed); + ReturnValue processLootItems(const std::shared_ptr<Player> &player, std::shared_ptr<Container> lootContainer, const std::shared_ptr<Item> &item, bool &fallbackConsumed); /** * @brief Internally collects loot or obtain items from a given item and places them into the managed container. @@ -828,7 +828,7 @@ class Game { * @param category Category of the item (default is OBJECTCATEGORY_DEFAULT). * @return Return value indicating success or error. */ - ReturnValue internalCollectManagedItems(std::shared_ptr<Player> player, std::shared_ptr<Item> item, ObjectCategory_t category = OBJECTCATEGORY_DEFAULT, bool isLootContainer = true); + ReturnValue internalCollectManagedItems(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, ObjectCategory_t category = OBJECTCATEGORY_DEFAULT, bool isLootContainer = true); /** * @brief Collects items from the reward chest. @@ -837,7 +837,7 @@ class Game { * @param maxMoveItems Maximum number of items to move (default is 0, which means no limit). * @return Return value indicating success or error. */ - ReturnValue collectRewardChestItems(std::shared_ptr<Player> player, uint32_t maxMoveItems = 0); + ReturnValue collectRewardChestItems(const std::shared_ptr<Player> &player, uint32_t maxMoveItems = 0); phmap::flat_hash_map<std::string, QueryHighscoreCacheEntry> queryCache; phmap::flat_hash_map<std::string, HighscoreCacheEntry> highscoreCache; @@ -856,7 +856,7 @@ class Game { std::map<Position, uint16_t> mapLuaItemsStored; std::map<uint16_t, std::string> BestiaryList; - std::string boostedCreature = ""; + std::string boostedCreature; std::vector<std::shared_ptr<Charm>> CharmList; std::vector<std::shared_ptr<Creature>> checkCreatureLists[EVENT_CREATURECOUNT]; @@ -868,7 +868,7 @@ class Game { size_t lastBucket = 0; size_t lastImbuedBucket = 0; - std::shared_ptr<WildcardTreeNode> wildcardTree; + std::shared_ptr<WildcardTreeNode> wildcardTree = nullptr; std::map<uint32_t, std::shared_ptr<Npc>> npcs; std::map<uint32_t, std::shared_ptr<Monster>> monsters; @@ -919,59 +919,61 @@ class Game { std::vector<ItemClassification*> itemsClassifications; - bool isTryingToStow(const Position &toPos, std::shared_ptr<Cylinder> toCylinder) const; + bool isTryingToStow(const Position &toPos, const std::shared_ptr<Cylinder> &toCylinder) const; void sendDamageMessageAndEffects( - std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, const CombatDamage &damage, const Position &targetPos, - std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Player> targetPlayer, TextMessage &message, + const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, const CombatDamage &damage, const Position &targetPos, + const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Player> &targetPlayer, TextMessage &message, const CreatureVector &spectators, int32_t realDamage ); - void updatePlayerPartyHuntAnalyzer(const CombatDamage &damage, std::shared_ptr<Player> player) const; + void updatePlayerPartyHuntAnalyzer(const CombatDamage &damage, const std::shared_ptr<Player> &player) const; void sendEffects( - std::shared_ptr<Creature> target, const CombatDamage &damage, const Position &targetPos, + const std::shared_ptr<Creature> &target, const CombatDamage &damage, const Position &targetPos, TextMessage &message, const CreatureVector &spectators ); void sendMessages( - std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, const CombatDamage &damage, - const Position &targetPos, std::shared_ptr<Player> attackerPlayer, std::shared_ptr<Player> targetPlayer, + const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, const CombatDamage &damage, + const Position &targetPos, const std::shared_ptr<Player> &attackerPlayer, const std::shared_ptr<Player> &targetPlayer, TextMessage &message, const CreatureVector &spectators, int32_t realDamage ) const; bool shouldSendMessage(const TextMessage &message) const; void buildMessageAsAttacker( - std::shared_ptr<Creature> target, const CombatDamage &damage, TextMessage &message, + const std::shared_ptr<Creature> &target, const CombatDamage &damage, TextMessage &message, std::stringstream &ss, const std::string &damageString ) const; void buildMessageAsTarget( - std::shared_ptr<Creature> attacker, const CombatDamage &damage, std::shared_ptr<Player> attackerPlayer, - std::shared_ptr<Player> targetPlayer, TextMessage &message, std::stringstream &ss, + const std::shared_ptr<Creature> &attacker, const CombatDamage &damage, const std::shared_ptr<Player> &attackerPlayer, + const std::shared_ptr<Player> &targetPlayer, TextMessage &message, std::stringstream &ss, const std::string &damageString ) const; void buildMessageAsSpectator( - std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, const CombatDamage &damage, - std::shared_ptr<Player> targetPlayer, TextMessage &message, std::stringstream &ss, + const std::shared_ptr<Creature> &attacker, const std::shared_ptr<Creature> &target, const CombatDamage &damage, + const std::shared_ptr<Player> &targetPlayer, TextMessage &message, std::stringstream &ss, const std::string &damageString, std::string &spectatorMessage ) const; - void unwrapItem(std::shared_ptr<Item> item, uint16_t unWrapId, std::shared_ptr<House> house, std::shared_ptr<Player> player); + void unwrapItem(const std::shared_ptr<Item> &item, uint16_t unWrapId, const std::shared_ptr<House> &house, const std::shared_ptr<Player> &player); // Variable members (m_) std::unique_ptr<IOWheel> m_IOWheel; void cacheQueryHighscore(const std::string &key, const std::string &query, uint32_t page, uint8_t entriesPerPage); - void processHighscoreResults(DBResult_ptr result, uint32_t playerID, uint8_t category, uint32_t vocation, uint8_t entriesPerPage); + void processHighscoreResults(const DBResult_ptr &result, uint32_t playerID, uint8_t category, uint32_t vocation, uint8_t entriesPerPage); std::string generateVocationConditionHighscore(uint32_t vocation); std::string generateHighscoreQueryForEntries(const std::string &categoryName, uint32_t page, uint8_t entriesPerPage, uint32_t vocation); std::string generateHighscoreQueryForOurRank(const std::string &categoryName, uint8_t entriesPerPage, uint32_t playerGUID, uint32_t vocation); std::string generateHighscoreOrGetCachedQueryForEntries(const std::string &categoryName, uint32_t page, uint8_t entriesPerPage, uint32_t vocation); std::string generateHighscoreOrGetCachedQueryForOurRank(const std::string &categoryName, uint8_t entriesPerPage, uint32_t playerGUID, uint32_t vocation); + + void updatePlayersOnline() const; }; constexpr auto g_game = Game::getInstance; diff --git a/src/game/movement/position.hpp b/src/game/movement/position.hpp index 87e74ee3e22..9e298ee4792 100644 --- a/src/game/movement/position.hpp +++ b/src/game/movement/position.hpp @@ -119,7 +119,7 @@ struct Position { namespace std { template <> struct hash<Position> { - std::size_t operator()(const Position &p) const { + std::size_t operator()(const Position &p) const noexcept { return static_cast<std::size_t>(p.x) | (static_cast<std::size_t>(p.y) << 16) | (static_cast<std::size_t>(p.z) << 32); } }; diff --git a/src/game/movement/teleport.cpp b/src/game/movement/teleport.cpp index 5d674e2a93f..d670aaba329 100644 --- a/src/game/movement/teleport.cpp +++ b/src/game/movement/teleport.cpp @@ -30,7 +30,7 @@ void Teleport::serializeAttr(PropWriteStream &propWriteStream) const { propWriteStream.write<uint8_t>(destPos.z); } -ReturnValue Teleport::queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature>) { +ReturnValue Teleport::queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> &) { return RETURNVALUE_NOTPOSSIBLE; } @@ -38,15 +38,15 @@ ReturnValue Teleport::queryMaxCount(int32_t, const std::shared_ptr<Thing> &, uin return RETURNVALUE_NOTPOSSIBLE; } -ReturnValue Teleport::queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature> /*= nullptr */) { +ReturnValue Teleport::queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> & /*= nullptr */) { return RETURNVALUE_NOERROR; } -std::shared_ptr<Cylinder> Teleport::queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item>*, uint32_t &) { +std::shared_ptr<Cylinder> Teleport::queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item> &, uint32_t &) { return getTeleport(); } -bool Teleport::checkInfinityLoop(std::shared_ptr<Tile> destTile) { +bool Teleport::checkInfinityLoop(const std::shared_ptr<Tile> &destTile) { if (!destTile) { return false; } @@ -61,16 +61,16 @@ bool Teleport::checkInfinityLoop(std::shared_ptr<Tile> destTile) { return false; } -void Teleport::addThing(std::shared_ptr<Thing> thing) { +void Teleport::addThing(const std::shared_ptr<Thing> &thing) { return addThing(0, thing); } -void Teleport::addThing(int32_t, std::shared_ptr<Thing> thing) { +void Teleport::addThing(int32_t, const std::shared_ptr<Thing> &thing) { if (!thing) { return; } - std::shared_ptr<Tile> destTile = g_game().map.getTile(destPos); + const std::shared_ptr<Tile> &destTile = g_game().map.getTile(destPos); if (!destTile) { return; } @@ -86,7 +86,7 @@ void Teleport::addThing(int32_t, std::shared_ptr<Thing> thing) { const MagicEffectClasses effect = Item::items[id].magicEffect; - if (std::shared_ptr<Creature> creature = thing->getCreature()) { + if (const std::shared_ptr<Creature> &creature = thing->getCreature()) { Position origPos = creature->getPosition(); g_game().internalCreatureTurn(creature, origPos.x > destPos.x ? DIRECTION_WEST : DIRECTION_EAST); g_dispatcher().addWalkEvent([=] { @@ -96,7 +96,7 @@ void Teleport::addThing(int32_t, std::shared_ptr<Thing> thing) { g_game().addMagicEffect(origPos, effect); g_game().addMagicEffect(destTile->getPosition(), effect); } - } else if (std::shared_ptr<Item> item = thing->getItem()) { + } else if (const auto &item = thing->getItem()) { if (effect != CONST_ME_NONE) { g_game().addMagicEffect(destTile->getPosition(), effect); g_game().addMagicEffect(item->getPosition(), effect); @@ -105,22 +105,22 @@ void Teleport::addThing(int32_t, std::shared_ptr<Thing> thing) { } } -void Teleport::updateThing(std::shared_ptr<Thing>, uint16_t, uint32_t) { +void Teleport::updateThing(const std::shared_ptr<Thing> &, uint16_t, uint32_t) { // } -void Teleport::replaceThing(uint32_t, std::shared_ptr<Thing>) { +void Teleport::replaceThing(uint32_t, const std::shared_ptr<Thing> &) { // } -void Teleport::removeThing(std::shared_ptr<Thing>, uint32_t) { +void Teleport::removeThing(const std::shared_ptr<Thing> &, uint32_t) { // } -void Teleport::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { +void Teleport::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { getParent()->postAddNotification(thing, oldParent, index, LINK_PARENT); } -void Teleport::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { +void Teleport::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { getParent()->postRemoveNotification(thing, newParent, index, LINK_PARENT); } diff --git a/src/game/movement/teleport.hpp b/src/game/movement/teleport.hpp index 9e26e1864cf..ce41505434c 100644 --- a/src/game/movement/teleport.hpp +++ b/src/game/movement/teleport.hpp @@ -20,7 +20,7 @@ class Teleport final : public Item, public Cylinder { return static_self_cast<Teleport>(); } - std::shared_ptr<Cylinder> getCylinder() override final { + std::shared_ptr<Cylinder> getCylinder() override { return getTeleport(); } @@ -32,27 +32,27 @@ class Teleport final : public Item, public Cylinder { return destPos; } void setDestPos(Position pos) { - destPos = std::move(pos); + destPos = pos; } - bool checkInfinityLoop(std::shared_ptr<Tile> destTile); + bool checkInfinityLoop(const std::shared_ptr<Tile> &destTile); // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) override; - ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; - std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) override; + ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; + std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) override; - void addThing(std::shared_ptr<Thing> thing) override; - void addThing(int32_t index, std::shared_ptr<Thing> thing) override; + void addThing(const std::shared_ptr<Thing> &thing) override; + void addThing(int32_t index, const std::shared_ptr<Thing> &thing) override; - void updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) override; - void replaceThing(uint32_t index, std::shared_ptr<Thing> thing) override; + void updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) override; + void replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) override; - void removeThing(std::shared_ptr<Thing> thing, uint32_t count) override; + void removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; private: Position destPos; diff --git a/src/game/scheduling/dispatcher.cpp b/src/game/scheduling/dispatcher.cpp index a3a767df756..c8fb29b889b 100644 --- a/src/game/scheduling/dispatcher.cpp +++ b/src/game/scheduling/dispatcher.cpp @@ -243,7 +243,7 @@ void Dispatcher::asyncEvent(std::function<void(void)> &&f, TaskGroup group) { } void Dispatcher::stopEvent(uint64_t eventId) { - const auto &it = scheduledTasksRef.find(eventId); + auto it = scheduledTasksRef.find(eventId); if (it != scheduledTasksRef.end()) { it->second->cancel(); scheduledTasksRef.erase(it); @@ -265,3 +265,7 @@ void DispatcherContext::tryAddEvent(std::function<void(void)> &&f, std::string_v f(); } } + +bool DispatcherContext::isOn() { + return OTSYS_TIME() != 0; +} diff --git a/src/game/scheduling/dispatcher.hpp b/src/game/scheduling/dispatcher.hpp index 1b198b58510..5e84d5d5fc7 100644 --- a/src/game/scheduling/dispatcher.hpp +++ b/src/game/scheduling/dispatcher.hpp @@ -33,9 +33,7 @@ enum class DispatcherType : uint8_t { }; struct DispatcherContext { - bool isOn() const { - return OTSYS_TIME() != 0; - } + static bool isOn(); bool isGroup(const TaskGroup _group) const { return group == _group; @@ -90,7 +88,9 @@ class Dispatcher { for (uint_fast16_t i = 0; i < threads.capacity(); ++i) { threads.emplace_back(std::make_unique<ThreadTask>()); } - }; + + scheduledTasksRef.reserve(2000); + } // Ensures that we don't accidentally copy it Dispatcher(const Dispatcher &) = delete; @@ -215,12 +215,13 @@ class Dispatcher { std::vector<std::shared_ptr<Task>> scheduledTasks; std::mutex mutex; }; + std::vector<std::unique_ptr<ThreadTask>> threads; // Main Events std::array<std::vector<Task>, static_cast<uint8_t>(TaskGroup::Last)> m_tasks; - phmap::btree_multiset<std::shared_ptr<Task>, Task::Compare> scheduledTasks; - phmap::parallel_flat_hash_map_m<uint64_t, std::shared_ptr<Task>> scheduledTasksRef; + phmap::btree_multiset<std::shared_ptr<Task>, Task::Compare> scheduledTasks {}; + phmap::parallel_flat_hash_map_m<uint64_t, std::shared_ptr<Task>> scheduledTasksRef {}; bool asyncWaitDisabled = false; diff --git a/src/game/scheduling/events_scheduler.hpp b/src/game/scheduling/events_scheduler.hpp index 6c8233d8b0e..fe56aeb9a12 100644 --- a/src/game/scheduling/events_scheduler.hpp +++ b/src/game/scheduling/events_scheduler.hpp @@ -87,7 +87,7 @@ class EventsScheduler { std::vector<EventScheduler> eventScheduler; - std::string join(const std::vector<std::string> &vec, const std::string &delim); + static std::string join(const std::vector<std::string> &vec, const std::string &delim); }; constexpr auto g_eventsScheduler = EventsScheduler::getInstance; diff --git a/src/game/scheduling/task.cpp b/src/game/scheduling/task.cpp index 8e1b984a905..3049aa29e53 100644 --- a/src/game/scheduling/task.cpp +++ b/src/game/scheduling/task.cpp @@ -11,28 +11,36 @@ #include "lib/metrics/metrics.hpp" +#include "utils/tools.hpp" + std::atomic_uint_fast64_t Task::LAST_EVENT_ID = 0; -Task::Task(uint32_t expiresAfterMs, std::function<void(void)> &&f, std::string_view context) : - func(std::move(f)), context(context), utime(OTSYS_TIME()), expiration(expiresAfterMs > 0 ? OTSYS_TIME() + expiresAfterMs : 0) { +Task::Task(uint32_t expiresAfterMs, std::function<void(void)> &&f, std::string_view context, const std::source_location &location) : + func(std::move(f)), context(context), functionName(location.function_name()), utime(OTSYS_TIME()), + expiration(expiresAfterMs > 0 ? OTSYS_TIME() + expiresAfterMs : 0) { if (this->context.empty()) { - g_logger().error("[{}]: task context cannot be empty!", __FUNCTION__); + g_logger().error("[{}]: task context cannot be empty! Function: {}", __FUNCTION__, functionName); return; } assert(!this->context.empty() && "Context cannot be empty!"); } -Task::Task(std::function<void(void)> &&f, std::string_view context, uint32_t delay, bool cycle /* = false*/, bool log /*= true*/) : - func(std::move(f)), context(context), utime(OTSYS_TIME() + delay), delay(delay), cycle(cycle), log(log) { +Task::Task(std::function<void(void)> &&f, std::string_view context, uint32_t delay, bool cycle /* = false*/, bool log /*= true*/, const std::source_location &location) : + func(std::move(f)), context(context), functionName(location.function_name()), utime(OTSYS_TIME() + delay), delay(delay), + cycle(cycle), log(log) { if (this->context.empty()) { - g_logger().error("[{}]: task context cannot be empty!", __FUNCTION__); + g_logger().error("[{}]: task context cannot be empty! Function: {}", __FUNCTION__, functionName); return; } assert(!this->context.empty() && "Context cannot be empty!"); } +[[nodiscard]] bool Task::hasExpired() const { + return expiration != 0 && expiration < OTSYS_TIME(); +} + bool Task::execute() const { metrics::task_latency measure(context); if (isCanceled()) { @@ -40,19 +48,22 @@ bool Task::execute() const { } if (hasExpired()) { - g_logger().info("The task '{}' has expired, it has not been executed in {}.", getContext(), expiration - utime); + g_logger().info("The task '{}' has expired, it has not been executed in {}. Function: {}", getContext(), expiration - utime, functionName); return false; } if (log) { if (hasTraceableContext()) { - g_logger().trace("Executing task {}.", getContext()); + g_logger().trace("Executing task {}. Function: {}", getContext(), functionName); } else { - g_logger().debug("Executing task {}.", getContext()); + g_logger().debug("Executing task {}. Function: {}", getContext(), functionName); } } func(); - return true; } + +void Task::updateTime() { + utime = OTSYS_TIME() + delay; +} diff --git a/src/game/scheduling/task.hpp b/src/game/scheduling/task.hpp index 3f134abf728..948bdea0215 100644 --- a/src/game/scheduling/task.hpp +++ b/src/game/scheduling/task.hpp @@ -8,14 +8,14 @@ */ #pragma once -#include "utils/tools.hpp" -#include <unordered_set> + +class Dispatcher; class Task { public: - Task(uint32_t expiresAfterMs, std::function<void(void)> &&f, std::string_view context); + Task(uint32_t expiresAfterMs, std::function<void(void)> &&f, std::string_view context, const std::source_location &location = std::source_location::current()); - Task(std::function<void(void)> &&f, std::string_view context, uint32_t delay, bool cycle = false, bool log = true); + Task(std::function<void(void)> &&f, std::string_view context, uint32_t delay, bool cycle = false, bool log = true, const std::source_location &location = std::source_location::current()); ~Task() = default; @@ -24,34 +24,34 @@ class Task { if (++LAST_EVENT_ID == 0) { LAST_EVENT_ID = 1; } - id = LAST_EVENT_ID; } - return id; } - uint32_t getDelay() const { + [[nodiscard]] uint32_t getDelay() const { return delay; } - std::string_view getContext() const { + [[nodiscard]] std::string_view getContext() const { return context; } - auto getTime() const { - return utime; + [[nodiscard]] std::string_view getFunctionName() const { + return functionName; } - bool hasExpired() const { - return expiration != 0 && expiration < OTSYS_TIME(); + [[nodiscard]] auto getTime() const { + return utime; } - bool isCycle() const { + [[nodiscard]] bool hasExpired() const; + + [[nodiscard]] bool isCycle() const { return cycle; } - bool isCanceled() const { + [[nodiscard]] bool isCanceled() const { return func == nullptr; } @@ -64,56 +64,54 @@ class Task { private: static std::atomic_uint_fast64_t LAST_EVENT_ID; - void updateTime() { - utime = OTSYS_TIME() + delay; - } + void updateTime(); bool hasTraceableContext() const { - const static auto tasksContext = std::unordered_set<std::string_view>({ "Decay::checkDecay", - "Dispatcher::asyncEvent", - "Game::checkCreatureAttack", - "Game::checkCreatureWalk", - "Game::checkCreatures", - "Game::checkImbuements", - "Game::checkLight", - "Game::createFiendishMonsters", - "Game::createInfluencedMonsters", - "Game::updateCreatureWalk", - "Game::updateForgeableMonsters", - "GlobalEvents::think", - "LuaEnvironment::executeTimerEvent", - "Modules::executeOnRecvbyte", - "Monster::onCreatureMove", - "OutputMessagePool::sendAll", - "ProtocolGame::addGameTask", - "ProtocolGame::parsePacketFromDispatcher", - "Raids::checkRaids", - "SpawnMonster::checkSpawnMonster", - "SpawnMonster::scheduleSpawn", - "SpawnMonster::startup", - "SpawnNpc::checkSpawnNpc", - "Webhook::run", - "Protocol::sendRecvMessageCallback", - "Player::addInFightTicks" }); + const static std::unordered_set<std::string_view> tasksContext = { + "Decay::checkDecay", + "Dispatcher::asyncEvent", + "Game::checkCreatureAttack", + "Game::checkCreatureWalk", + "Game::checkCreatures", + "Game::checkImbuements", + "Game::checkLight", + "Game::createFiendishMonsters", + "Game::createInfluencedMonsters", + "Game::updateCreatureWalk", + "Game::updateForgeableMonsters", + "GlobalEvents::think", + "LuaEnvironment::executeTimerEvent", + "Modules::executeOnRecvbyte", + "OutputMessagePool::sendAll", + "ProtocolGame::addGameTask", + "ProtocolGame::parsePacketFromDispatcher", + "Raids::checkRaids", + "SpawnMonster::checkSpawnMonster", + "SpawnMonster::scheduleSpawn", + "SpawnMonster::startup", + "SpawnNpc::checkSpawnNpc", + "Webhook::run", + "Protocol::sendRecvMessageCallback", + "Player::addInFightTicks" + }; return tasksContext.contains(context); } struct Compare { bool operator()(const std::shared_ptr<Task> &a, const std::shared_ptr<Task> &b) const { - return a->utime < b->utime; + return a->getTime() < b->getTime(); } }; - std::function<void(void)> func = nullptr; + std::function<void(void)> func; std::string context; + std::string functionName; int64_t utime = 0; int64_t expiration = 0; - uint64_t id = 0; uint32_t delay = 0; - bool cycle = false; bool log = true; diff --git a/src/game/zones/zone.cpp b/src/game/zones/zone.cpp index 9215ef2570f..1f519d29a89 100644 --- a/src/game/zones/zone.cpp +++ b/src/game/zones/zone.cpp @@ -253,11 +253,11 @@ void Zone::refresh() { void Zone::setMonsterVariant(const std::string &variant) { monsterVariant = variant; g_logger().debug("Zone {} monster variant set to {}", name, variant); - for (auto &spawnMonster : g_game().map.spawnsMonster.getspawnMonsterList()) { - if (!contains(spawnMonster.getCenterPos())) { + for (const auto &spawnMonster : g_game().map.spawnsMonster.getspawnMonsterList()) { + if (!contains(spawnMonster->getCenterPos())) { continue; } - spawnMonster.setMonsterVariant(variant); + spawnMonster->setMonsterVariant(variant); } removeMonsters(); diff --git a/src/game/zones/zone.hpp b/src/game/zones/zone.hpp index 82969a25792..a3af961bd7f 100644 --- a/src/game/zones/zone.hpp +++ b/src/game/zones/zone.hpp @@ -143,8 +143,8 @@ namespace weak { class Zone { public: - explicit Zone(const std::string &name, uint32_t id = 0) : - name(name), id(id) { } + explicit Zone(std::string name, uint32_t id = 0) : + name(std::move(name)), id(id) { } explicit Zone(uint32_t id) : id(id) { } @@ -199,7 +199,7 @@ class Zone { static std::shared_ptr<Zone> addZone(const std::string &name, uint32_t id = 0); static std::shared_ptr<Zone> getZone(const std::string &name); static std::shared_ptr<Zone> getZone(uint32_t id); - static std::vector<std::shared_ptr<Zone>> getZones(const Position position); + static std::vector<std::shared_ptr<Zone>> getZones(Position position); static std::vector<std::shared_ptr<Zone>> getZones(); static void refreshAll() { for (const auto &[_, zone] : zones) { diff --git a/src/io/fileloader.cpp b/src/io/fileloader.cpp index a4269ffdd30..c62901f5c51 100644 --- a/src/io/fileloader.cpp +++ b/src/io/fileloader.cpp @@ -20,7 +20,9 @@ namespace OTB { } Identifier fileIdentifier; - std::copy(fileContents.begin(), fileContents.begin() + fileIdentifier.size(), fileIdentifier.begin()); + + std::ranges::copy(fileContents | std::views::take(fileIdentifier.size()), fileIdentifier.begin()); + if (fileIdentifier != acceptedIdentifier && fileIdentifier != wildcard) { throw InvalidOTBFormat {}; } diff --git a/src/io/functions/iologindata_load_player.cpp b/src/io/functions/iologindata_load_player.cpp index 5b2621c1cbf..05e72ba856e 100644 --- a/src/io/functions/iologindata_load_player.cpp +++ b/src/io/functions/iologindata_load_player.cpp @@ -16,20 +16,20 @@ #include "enums/account_errors.hpp" #include "utils/tools.hpp" -void IOLoginDataLoad::loadItems(ItemsMap &itemsMap, DBResult_ptr result, const std::shared_ptr<Player> &player) { +void IOLoginDataLoad::loadItems(ItemsMap &itemsMap, const DBResult_ptr &result, const std::shared_ptr<Player> &player) { try { do { - uint32_t sid = result->getNumber<uint32_t>("sid"); - uint32_t pid = result->getNumber<uint32_t>("pid"); - uint16_t type = result->getNumber<uint16_t>("itemtype"); - uint16_t count = result->getNumber<uint16_t>("count"); + auto sid = result->getNumber<uint32_t>("sid"); + auto pid = result->getNumber<uint32_t>("pid"); + auto type = result->getNumber<uint16_t>("itemtype"); + auto count = result->getNumber<uint16_t>("count"); unsigned long attrSize; const char* attr = result->getStream("attributes", attrSize); PropStream propStream; propStream.init(attr, attrSize); try { - std::shared_ptr<Item> item = Item::CreateItem(type, count); + const auto &item = Item::CreateItem(type, count); if (item) { if (!item->unserializeAttr(propStream)) { g_logger().warn("[{}] - Failed to deserialize item attributes {}, from player {}, from account id {}", __FUNCTION__, item->getID(), player->getName(), player->getAccountId()); @@ -49,7 +49,7 @@ void IOLoginDataLoad::loadItems(ItemsMap &itemsMap, DBResult_ptr result, const s } } -bool IOLoginDataLoad::preLoadPlayer(std::shared_ptr<Player> player, const std::string &name) { +bool IOLoginDataLoad::preLoadPlayer(const std::shared_ptr<Player> &player, const std::string &name) { Database &db = Database::getInstance(); std::ostringstream query; @@ -103,7 +103,7 @@ bool IOLoginDataLoad::preLoadPlayer(std::shared_ptr<Player> player, const std::s return true; } -bool IOLoginDataLoad::loadPlayerBasicInfo(std::shared_ptr<Player> player, DBResult_ptr result) { +bool IOLoginDataLoad::loadPlayerBasicInfo(const std::shared_ptr<Player> &player, const DBResult_ptr &result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return false; @@ -139,7 +139,7 @@ bool IOLoginDataLoad::loadPlayerBasicInfo(std::shared_ptr<Player> player, DBResu player->manaMax = result->getNumber<uint32_t>("manamax"); player->magLevel = result->getNumber<uint32_t>("maglevel"); uint64_t nextManaCount = player->vocation->getReqMana(player->magLevel + 1); - uint64_t manaSpent = result->getNumber<uint64_t>("manaspent"); + auto manaSpent = result->getNumber<uint64_t>("manaspent"); if (manaSpent > nextManaCount) { manaSpent = 0; } @@ -185,13 +185,13 @@ bool IOLoginDataLoad::loadPlayerBasicInfo(std::shared_ptr<Player> player, DBResu return true; } -void IOLoginDataLoad::loadPlayerExperience(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerExperience(const std::shared_ptr<Player> &player, const DBResult_ptr &result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; } - uint64_t experience = result->getNumber<uint64_t>("experience"); + auto experience = result->getNumber<uint64_t>("experience"); uint64_t currExpCount = Player::getExpForLevel(player->level); uint64_t nextExpCount = Player::getExpForLevel(player->level + 1); @@ -208,7 +208,7 @@ void IOLoginDataLoad::loadPlayerExperience(std::shared_ptr<Player> player, DBRes } } -void IOLoginDataLoad::loadPlayerBlessings(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerBlessings(const std::shared_ptr<Player> &player, const DBResult_ptr &result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -219,7 +219,7 @@ void IOLoginDataLoad::loadPlayerBlessings(std::shared_ptr<Player> player, DBResu } } -void IOLoginDataLoad::loadPlayerConditions(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerConditions(const std::shared_ptr<Player> &player, const DBResult_ptr &result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -239,7 +239,7 @@ void IOLoginDataLoad::loadPlayerConditions(std::shared_ptr<Player> player, DBRes } } -void IOLoginDataLoad::loadPlayerDefaultOutfit(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerDefaultOutfit(const std::shared_ptr<Player> &player, const DBResult_ptr &result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -270,7 +270,7 @@ void IOLoginDataLoad::loadPlayerDefaultOutfit(std::shared_ptr<Player> player, DB player->currentOutfit = player->defaultOutfit; } -void IOLoginDataLoad::loadPlayerSkullSystem(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerSkullSystem(const std::shared_ptr<Player> &player, const DBResult_ptr &result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -282,7 +282,7 @@ void IOLoginDataLoad::loadPlayerSkullSystem(std::shared_ptr<Player> player, DBRe // ensure that we round up the number of ticks player->skullTicks = (skullSeconds + 2); - uint16_t skull = result->getNumber<uint16_t>("skull"); + auto skull = result->getNumber<uint16_t>("skull"); if (skull == SKULL_RED) { player->skull = SKULL_RED; } else if (skull == SKULL_BLACK) { @@ -292,7 +292,7 @@ void IOLoginDataLoad::loadPlayerSkullSystem(std::shared_ptr<Player> player, DBRe } } -void IOLoginDataLoad::loadPlayerSkill(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerSkill(const std::shared_ptr<Player> &player, const DBResult_ptr &result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -301,8 +301,8 @@ void IOLoginDataLoad::loadPlayerSkill(std::shared_ptr<Player> player, DBResult_p static const std::array<std::string, 13> skillNames = { "skill_fist", "skill_club", "skill_sword", "skill_axe", "skill_dist", "skill_shielding", "skill_fishing", "skill_critical_hit_chance", "skill_critical_hit_damage", "skill_life_leech_chance", "skill_life_leech_amount", "skill_mana_leech_chance", "skill_mana_leech_amount" }; static const std::array<std::string, 13> skillNameTries = { "skill_fist_tries", "skill_club_tries", "skill_sword_tries", "skill_axe_tries", "skill_dist_tries", "skill_shielding_tries", "skill_fishing_tries", "skill_critical_hit_chance_tries", "skill_critical_hit_damage_tries", "skill_life_leech_chance_tries", "skill_life_leech_amount_tries", "skill_mana_leech_chance_tries", "skill_mana_leech_amount_tries" }; for (size_t i = 0; i < skillNames.size(); ++i) { - uint16_t skillLevel = result->getNumber<uint16_t>(skillNames[i]); - uint64_t skillTries = result->getNumber<uint64_t>(skillNameTries[i]); + auto skillLevel = result->getNumber<uint16_t>(skillNames[i]); + auto skillTries = result->getNumber<uint64_t>(skillNameTries[i]); uint64_t nextSkillTries = player->vocation->getReqSkillTries(static_cast<uint8_t>(i), skillLevel + 1); if (skillTries > nextSkillTries) { skillTries = 0; @@ -314,7 +314,7 @@ void IOLoginDataLoad::loadPlayerSkill(std::shared_ptr<Player> player, DBResult_p } } -void IOLoginDataLoad::loadPlayerKills(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerKills(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -325,7 +325,7 @@ void IOLoginDataLoad::loadPlayerKills(std::shared_ptr<Player> player, DBResult_p query << "SELECT `player_id`, `time`, `target`, `unavenged` FROM `player_kills` WHERE `player_id` = " << player->getGUID(); if ((result = db.storeQuery(query.str()))) { do { - time_t killTime = result->getNumber<time_t>("time"); + auto killTime = result->getNumber<time_t>("time"); if ((time(nullptr) - killTime) <= g_configManager().getNumber(FRAG_TIME)) { player->unjustifiedKills.emplace_back(result->getNumber<uint32_t>("target"), killTime, result->getNumber<bool>("unavenged")); } @@ -333,7 +333,7 @@ void IOLoginDataLoad::loadPlayerKills(std::shared_ptr<Player> player, DBResult_p } } -void IOLoginDataLoad::loadPlayerGuild(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerGuild(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -343,8 +343,8 @@ void IOLoginDataLoad::loadPlayerGuild(std::shared_ptr<Player> player, DBResult_p std::ostringstream query; query << "SELECT `guild_id`, `rank_id`, `nick` FROM `guild_membership` WHERE `player_id` = " << player->getGUID(); if ((result = db.storeQuery(query.str()))) { - uint32_t guildId = result->getNumber<uint32_t>("guild_id"); - uint32_t playerRankId = result->getNumber<uint32_t>("rank_id"); + auto guildId = result->getNumber<uint32_t>("guild_id"); + auto playerRankId = result->getNumber<uint32_t>("rank_id"); player->guildNick = result->getString("nick"); auto guild = g_game().getGuild(guildId); @@ -383,7 +383,7 @@ void IOLoginDataLoad::loadPlayerGuild(std::shared_ptr<Player> player, DBResult_p } } -void IOLoginDataLoad::loadPlayerStashItems(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerStashItems(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -399,7 +399,7 @@ void IOLoginDataLoad::loadPlayerStashItems(std::shared_ptr<Player> player, DBRes } } -void IOLoginDataLoad::loadPlayerBestiaryCharms(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerBestiaryCharms(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -452,7 +452,7 @@ void IOLoginDataLoad::loadPlayerBestiaryCharms(std::shared_ptr<Player> player, D } } -void IOLoginDataLoad::loadPlayerInstantSpellList(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerInstantSpellList(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!player) { g_logger().warn("[{}] - Player nullptr", __FUNCTION__); return; @@ -468,7 +468,7 @@ void IOLoginDataLoad::loadPlayerInstantSpellList(std::shared_ptr<Player> player, } } -void IOLoginDataLoad::loadPlayerInventoryItems(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerInventoryItems(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -485,9 +485,9 @@ void IOLoginDataLoad::loadPlayerInventoryItems(std::shared_ptr<Player> player, D if ((result = g_database().storeQuery(query))) { loadItems(inventoryItems, result, player); - for (ItemsMap::const_reverse_iterator it = inventoryItems.rbegin(), end = inventoryItems.rend(); it != end; ++it) { + for (auto it = inventoryItems.rbegin(), end = inventoryItems.rend(); it != end; ++it) { const std::pair<std::shared_ptr<Item>, int32_t> &pair = it->second; - const std::shared_ptr<Item> &item = pair.first; + const auto &item = pair.first; if (!item) { continue; } @@ -515,13 +515,13 @@ void IOLoginDataLoad::loadPlayerInventoryItems(std::shared_ptr<Player> player, D if (!oldProtocol) { auto cid = item->getAttribute<int64_t>(ItemAttribute_t::OPENCONTAINER); if (cid > 0) { - openContainersList.emplace_back(std::make_pair(cid, itemContainer)); + openContainersList.emplace_back(cid, itemContainer); } } - for (bool isLootContainer : { true, false }) { - auto checkAttribute = isLootContainer ? ItemAttribute_t::QUICKLOOTCONTAINER : ItemAttribute_t::OBTAINCONTAINER; + for (const bool isLootContainer : { true, false }) { + const auto checkAttribute = isLootContainer ? ItemAttribute_t::QUICKLOOTCONTAINER : ItemAttribute_t::OBTAINCONTAINER; if (item->hasAttribute(checkAttribute)) { - auto flags = item->getAttribute<uint32_t>(checkAttribute); + const auto flags = item->getAttribute<uint32_t>(checkAttribute); for (uint8_t category = OBJECTCATEGORY_FIRST; category <= OBJECTCATEGORY_LAST; category++) { if (hasBitSet(1 << category, flags)) { @@ -555,7 +555,7 @@ void IOLoginDataLoad::loadPlayerInventoryItems(std::shared_ptr<Player> player, D } } -void IOLoginDataLoad::loadPlayerStoreInbox(std::shared_ptr<Player> player) { +void IOLoginDataLoad::loadPlayerStoreInbox(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[{}] - Player nullptr", __FUNCTION__); return; @@ -566,7 +566,7 @@ void IOLoginDataLoad::loadPlayerStoreInbox(std::shared_ptr<Player> player) { } } -void IOLoginDataLoad::loadRewardItems(std::shared_ptr<Player> player) { +void IOLoginDataLoad::loadRewardItems(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[{}] - Player nullptr", __FUNCTION__); return; @@ -584,7 +584,7 @@ void IOLoginDataLoad::loadRewardItems(std::shared_ptr<Player> player) { } } -void IOLoginDataLoad::loadPlayerDepotItems(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerDepotItems(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -595,24 +595,27 @@ void IOLoginDataLoad::loadPlayerDepotItems(std::shared_ptr<Player> player, DBRes auto query = fmt::format("SELECT pid, sid, itemtype, count, attributes FROM player_depotitems WHERE player_id = {} ORDER BY sid DESC", player->getGUID()); if ((result = g_database().storeQuery(query))) { loadItems(depotItems, result, player); - for (ItemsMap::const_reverse_iterator it = depotItems.rbegin(), end = depotItems.rend(); it != end; ++it) { + for (auto it = depotItems.rbegin(), end = depotItems.rend(); it != end; ++it) { const std::pair<std::shared_ptr<Item>, int32_t> &pair = it->second; - std::shared_ptr<Item> item = pair.first; + const auto &item = pair.first; + if (!item) { + continue; + } int32_t pid = pair.second; if (pid >= 0 && pid < 100) { - std::shared_ptr<DepotChest> depotChest = player->getDepotChest(pid, true); + const std::shared_ptr<DepotChest> &depotChest = player->getDepotChest(pid, true); if (depotChest) { depotChest->internalAddThing(item); item->startDecaying(); } } else { - ItemsMap::const_iterator it2 = depotItems.find(pid); - if (it2 == depotItems.end()) { + auto depotIt = depotItems.find(pid); + if (depotIt == depotItems.end()) { continue; } - std::shared_ptr<Container> container = it2->second.first->getContainer(); + const std::shared_ptr<Container> &container = depotIt->second.first->getContainer(); if (container) { container->internalAddThing(item); // Here, the sub-containers do not yet have a parent, since the main backpack has not yet been added to the player, so we need to postpone @@ -628,7 +631,7 @@ void IOLoginDataLoad::loadPlayerDepotItems(std::shared_ptr<Player> player, DBRes } } -void IOLoginDataLoad::loadPlayerInboxItems(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerInboxItems(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -640,20 +643,24 @@ void IOLoginDataLoad::loadPlayerInboxItems(std::shared_ptr<Player> player, DBRes ItemsMap inboxItems; loadItems(inboxItems, result, player); - for (ItemsMap::const_reverse_iterator it = inboxItems.rbegin(), end = inboxItems.rend(); it != end; ++it) { + for (auto it = inboxItems.rbegin(), end = inboxItems.rend(); it != end; ++it) { const std::pair<std::shared_ptr<Item>, int32_t> &pair = it->second; - std::shared_ptr<Item> item = pair.first; + const auto &item = pair.first; + if (!item) { + continue; + } + int32_t pid = pair.second; if (pid >= 0 && pid < 100) { player->getInbox()->internalAddThing(item); item->startDecaying(); } else { - ItemsMap::const_iterator it2 = inboxItems.find(pid); - if (it2 == inboxItems.end()) { + auto inboxIt = inboxItems.find(pid); + if (inboxIt == inboxItems.end()) { continue; } - std::shared_ptr<Container> container = it2->second.first->getContainer(); + const std::shared_ptr<Container> &container = inboxIt->second.first->getContainer(); if (container) { container->internalAddThing(item); itemsToStartDecaying.emplace_back(item); @@ -668,7 +675,7 @@ void IOLoginDataLoad::loadPlayerInboxItems(std::shared_ptr<Player> player, DBRes } } -void IOLoginDataLoad::loadPlayerStorageMap(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerStorageMap(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -684,7 +691,7 @@ void IOLoginDataLoad::loadPlayerStorageMap(std::shared_ptr<Player> player, DBRes } } -void IOLoginDataLoad::loadPlayerVip(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerVip(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -722,7 +729,7 @@ void IOLoginDataLoad::loadPlayerVip(std::shared_ptr<Player> player, DBResult_ptr } } -void IOLoginDataLoad::loadPlayerPreyClass(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerPreyClass(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -769,7 +776,7 @@ void IOLoginDataLoad::loadPlayerPreyClass(std::shared_ptr<Player> player, DBResu } } -void IOLoginDataLoad::loadPlayerTaskHuntingClass(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerTaskHuntingClass(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -819,7 +826,7 @@ void IOLoginDataLoad::loadPlayerTaskHuntingClass(std::shared_ptr<Player> player, } } -void IOLoginDataLoad::loadPlayerForgeHistory(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerForgeHistory(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result || !player) { g_logger().warn("[{}] - Player or Result nullptr", __FUNCTION__); return; @@ -840,7 +847,7 @@ void IOLoginDataLoad::loadPlayerForgeHistory(std::shared_ptr<Player> player, DBR } } -void IOLoginDataLoad::loadPlayerBosstiary(std::shared_ptr<Player> player, DBResult_ptr result) { +void IOLoginDataLoad::loadPlayerBosstiary(const std::shared_ptr<Player> &player, DBResult_ptr result) { if (!result) { g_logger().warn("[{}] - Result nullptr", __FUNCTION__); return; @@ -877,7 +884,7 @@ void IOLoginDataLoad::loadPlayerBosstiary(std::shared_ptr<Player> player, DBResu } } -void IOLoginDataLoad::bindRewardBag(std::shared_ptr<Player> player, ItemsMap &rewardItemsMap) { +void IOLoginDataLoad::bindRewardBag(const std::shared_ptr<Player> &player, ItemsMap &rewardItemsMap) { if (!player) { g_logger().warn("[{}] - Player nullptr", __FUNCTION__); return; @@ -899,25 +906,29 @@ void IOLoginDataLoad::bindRewardBag(std::shared_ptr<Player> player, ItemsMap &re void IOLoginDataLoad::insertItemsIntoRewardBag(const ItemsMap &rewardItemsMap) { for (const auto &it : std::views::reverse(rewardItemsMap)) { const std::pair<std::shared_ptr<Item>, int32_t> &pair = it.second; - std::shared_ptr<Item> item = pair.first; + const auto &item = pair.first; + if (!item) { + continue; + } + int32_t pid = pair.second; if (pid == 0) { break; } - ItemsMap::const_iterator it2 = rewardItemsMap.find(pid); - if (it2 == rewardItemsMap.end()) { + auto rewardIt = rewardItemsMap.find(pid); + if (rewardIt == rewardItemsMap.end()) { continue; } - std::shared_ptr<Container> container = it2->second.first->getContainer(); + const std::shared_ptr<Container> &container = rewardIt->second.first->getContainer(); if (container) { container->internalAddThing(item); } } } -void IOLoginDataLoad::loadPlayerInitializeSystem(std::shared_ptr<Player> player) { +void IOLoginDataLoad::loadPlayerInitializeSystem(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[{}] - Player nullptr", __FUNCTION__); return; @@ -936,7 +947,7 @@ void IOLoginDataLoad::loadPlayerInitializeSystem(std::shared_ptr<Player> player) player->initializeTaskHunting(); } -void IOLoginDataLoad::loadPlayerUpdateSystem(std::shared_ptr<Player> player) { +void IOLoginDataLoad::loadPlayerUpdateSystem(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[{}] - Player nullptr", __FUNCTION__); return; diff --git a/src/io/functions/iologindata_load_player.hpp b/src/io/functions/iologindata_load_player.hpp index e67faf4d8c1..2d1a4305cf3 100644 --- a/src/io/functions/iologindata_load_player.hpp +++ b/src/io/functions/iologindata_load_player.hpp @@ -13,38 +13,38 @@ class IOLoginDataLoad : public IOLoginData { public: - static bool loadPlayerBasicInfo(std::shared_ptr<Player> player, DBResult_ptr result); - static bool preLoadPlayer(std::shared_ptr<Player> player, const std::string &name); - static void loadPlayerExperience(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerBlessings(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerConditions(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerDefaultOutfit(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerSkullSystem(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerSkill(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerKills(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerGuild(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerStashItems(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerBestiaryCharms(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerInstantSpellList(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerInventoryItems(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerStoreInbox(std::shared_ptr<Player> player); - static void loadPlayerDepotItems(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadRewardItems(std::shared_ptr<Player> player); - static void loadPlayerInboxItems(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerStorageMap(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerVip(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerPreyClass(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerTaskHuntingClass(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerForgeHistory(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerBosstiary(std::shared_ptr<Player> player, DBResult_ptr result); - static void loadPlayerInitializeSystem(std::shared_ptr<Player> player); - static void loadPlayerUpdateSystem(std::shared_ptr<Player> player); + static bool loadPlayerBasicInfo(const std::shared_ptr<Player> &player, const DBResult_ptr &result); + static bool preLoadPlayer(const std::shared_ptr<Player> &player, const std::string &name); + static void loadPlayerExperience(const std::shared_ptr<Player> &player, const DBResult_ptr &result); + static void loadPlayerBlessings(const std::shared_ptr<Player> &player, const DBResult_ptr &result); + static void loadPlayerConditions(const std::shared_ptr<Player> &player, const DBResult_ptr &result); + static void loadPlayerDefaultOutfit(const std::shared_ptr<Player> &player, const DBResult_ptr &result); + static void loadPlayerSkullSystem(const std::shared_ptr<Player> &player, const DBResult_ptr &result); + static void loadPlayerSkill(const std::shared_ptr<Player> &player, const DBResult_ptr &result); + static void loadPlayerKills(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerGuild(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerStashItems(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerBestiaryCharms(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerInstantSpellList(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerInventoryItems(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerStoreInbox(const std::shared_ptr<Player> &player); + static void loadPlayerDepotItems(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadRewardItems(const std::shared_ptr<Player> &player); + static void loadPlayerInboxItems(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerStorageMap(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerVip(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerPreyClass(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerTaskHuntingClass(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerForgeHistory(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerBosstiary(const std::shared_ptr<Player> &player, DBResult_ptr result); + static void loadPlayerInitializeSystem(const std::shared_ptr<Player> &player); + static void loadPlayerUpdateSystem(const std::shared_ptr<Player> &player); private: using ItemsMap = std::map<uint32_t, std::pair<std::shared_ptr<Item>, uint32_t>>; - static void bindRewardBag(std::shared_ptr<Player> player, ItemsMap &rewardItemsMap); + static void bindRewardBag(const std::shared_ptr<Player> &player, ItemsMap &rewardItemsMap); static void insertItemsIntoRewardBag(const ItemsMap &rewardItemsMap); - static void loadItems(ItemsMap &itemsMap, DBResult_ptr result, const std::shared_ptr<Player> &player); + static void loadItems(ItemsMap &itemsMap, const DBResult_ptr &result, const std::shared_ptr<Player> &player); }; diff --git a/src/io/functions/iologindata_save_player.cpp b/src/io/functions/iologindata_save_player.cpp index ec8ab71fd07..5fa235c7f41 100644 --- a/src/io/functions/iologindata_save_player.cpp +++ b/src/io/functions/iologindata_save_player.cpp @@ -10,7 +10,7 @@ #include "io/functions/iologindata_save_player.hpp" #include "game/game.hpp" -bool IOLoginDataSave::saveItems(std::shared_ptr<Player> player, const ItemBlockList &itemList, DBInsert &query_insert, PropWriteStream &propWriteStream) { +bool IOLoginDataSave::saveItems(const std::shared_ptr<Player> &player, const ItemBlockList &itemList, DBInsert &query_insert, PropWriteStream &propWriteStream) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -25,16 +25,21 @@ bool IOLoginDataSave::saveItems(std::shared_ptr<Player> player, const ItemBlockL int32_t runningId = 100; // Loop through each item in itemList - const auto openContainers = player->getOpenContainers(); + const auto &openContainers = player->getOpenContainers(); for (const auto &it : itemList) { + const auto &item = it.second; + if (!item) { + continue; + } + int32_t pid = it.first; - std::shared_ptr<Item> item = it.second; + ++runningId; // Update container attributes if necessary - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const std::shared_ptr<Container> &container = item->getContainer()) { if (!container) { - continue; // Check for null container + continue; } if (container->getAttribute<int64_t>(ItemAttribute_t::OPENCONTAINER) > 0) { @@ -58,13 +63,8 @@ bool IOLoginDataSave::saveItems(std::shared_ptr<Player> player, const ItemBlockL } // Serialize item attributes - try { - propWriteStream.clear(); - item->serializeAttr(propWriteStream); - } catch (...) { - g_logger().error("Error serializing item attributes."); - return false; - } + propWriteStream.clear(); + item->serializeAttr(propWriteStream); size_t attributesSize; const char* attributes = propWriteStream.getStream(attributesSize); @@ -80,17 +80,17 @@ bool IOLoginDataSave::saveItems(std::shared_ptr<Player> player, const ItemBlockL // Loop through containers in queue while (!queue.empty()) { const ContainerBlock &cb = queue.front(); - std::shared_ptr<Container> container = cb.first; - int32_t parentId = cb.second; - + const std::shared_ptr<Container> &container = cb.first; if (!container) { - continue; // Check for null container + continue; } + int32_t parentId = cb.second; + // Loop through items in container for (auto &item : container->getItemList()) { if (!item) { - continue; // Check for null item + continue; } ++runningId; @@ -117,14 +117,9 @@ bool IOLoginDataSave::saveItems(std::shared_ptr<Player> player, const ItemBlockL } // Serialize item attributes - try { - propWriteStream.clear(); - item->serializeAttr(propWriteStream); - item->stopDecaying(); - } catch (...) { - g_logger().error("Error serializing item attributes in container."); - return false; - } + propWriteStream.clear(); + item->serializeAttr(propWriteStream); + item->stopDecaying(); size_t attributesSize; const char* attributes = propWriteStream.getStream(attributesSize); @@ -149,7 +144,7 @@ bool IOLoginDataSave::saveItems(std::shared_ptr<Player> player, const ItemBlockL return true; } -bool IOLoginDataSave::savePlayerFirst(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerFirst(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -202,7 +197,9 @@ bool IOLoginDataSave::savePlayerFirst(std::shared_ptr<Player> player) { query << "`manamax` = " << player->manaMax << ","; query << "`manaspent` = " << player->manaSpent << ","; query << "`soul` = " << static_cast<uint16_t>(player->soul) << ","; - query << "`town_id` = " << player->town->getID() << ","; + if (player->town) { + query << "`town_id` = " << player->town->getID() << ","; + } const Position &loginPosition = player->getLoginPosition(); query << "`posx` = " << loginPosition.getX() << ","; @@ -315,7 +312,7 @@ bool IOLoginDataSave::savePlayerFirst(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerStash(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerStash(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -344,7 +341,7 @@ bool IOLoginDataSave::savePlayerStash(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerSpells(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerSpells(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -373,7 +370,7 @@ bool IOLoginDataSave::savePlayerSpells(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerKills(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerKills(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -402,7 +399,7 @@ bool IOLoginDataSave::savePlayerKills(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerBestiarySystem(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerBestiarySystem(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -452,7 +449,7 @@ bool IOLoginDataSave::savePlayerBestiarySystem(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerItem(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerItem(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -471,7 +468,7 @@ bool IOLoginDataSave::savePlayerItem(std::shared_ptr<Player> player) { ItemBlockList itemList; for (int32_t slotId = CONST_SLOT_FIRST; slotId <= CONST_SLOT_LAST; ++slotId) { - std::shared_ptr<Item> item = player->inventory[slotId]; + const auto &item = player->inventory[slotId]; if (item) { itemList.emplace_back(slotId, item); } @@ -484,7 +481,7 @@ bool IOLoginDataSave::savePlayerItem(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerDepotItems(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerDepotItems(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -506,7 +503,7 @@ bool IOLoginDataSave::savePlayerDepotItems(std::shared_ptr<Player> player) { DBInsert depotQuery("INSERT INTO `player_depotitems` (`player_id`, `pid`, `sid`, `itemtype`, `count`, `attributes`) VALUES "); for (const auto &[pid, depotChest] : player->depotChests) { - for (std::shared_ptr<Item> item : depotChest->getItemList()) { + for (const std::shared_ptr<Item> &item : depotChest->getItemList()) { depotList.emplace_back(pid, item); } } @@ -519,7 +516,7 @@ bool IOLoginDataSave::savePlayerDepotItems(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::saveRewardItems(std::shared_ptr<Player> player) { +bool IOLoginDataSave::saveRewardItems(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -553,7 +550,7 @@ bool IOLoginDataSave::saveRewardItems(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerInbox(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerInbox(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -581,7 +578,7 @@ bool IOLoginDataSave::savePlayerInbox(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerPreyClass(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerPreyClass(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -635,7 +632,7 @@ bool IOLoginDataSave::savePlayerPreyClass(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerTaskHuntingClass(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerTaskHuntingClass(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -687,7 +684,7 @@ bool IOLoginDataSave::savePlayerTaskHuntingClass(std::shared_ptr<Player> player) return true; } -bool IOLoginDataSave::savePlayerForgeHistory(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerForgeHistory(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -721,7 +718,7 @@ bool IOLoginDataSave::savePlayerForgeHistory(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerBosstiary(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerBosstiary(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; @@ -765,7 +762,7 @@ bool IOLoginDataSave::savePlayerBosstiary(std::shared_ptr<Player> player) { return true; } -bool IOLoginDataSave::savePlayerStorage(std::shared_ptr<Player> player) { +bool IOLoginDataSave::savePlayerStorage(const std::shared_ptr<Player> &player) { if (!player) { g_logger().warn("[IOLoginData::savePlayer] - Player nullptr: {}", __FUNCTION__); return false; diff --git a/src/io/functions/iologindata_save_player.hpp b/src/io/functions/iologindata_save_player.hpp index bbd44105de6..8a35db73d11 100644 --- a/src/io/functions/iologindata_save_player.hpp +++ b/src/io/functions/iologindata_save_player.hpp @@ -13,20 +13,20 @@ class IOLoginDataSave : public IOLoginData { public: - static bool savePlayerFirst(std::shared_ptr<Player> player); - static bool savePlayerStash(std::shared_ptr<Player> player); - static bool savePlayerSpells(std::shared_ptr<Player> player); - static bool savePlayerKills(std::shared_ptr<Player> player); - static bool savePlayerBestiarySystem(std::shared_ptr<Player> player); - static bool savePlayerItem(std::shared_ptr<Player> player); - static bool savePlayerDepotItems(std::shared_ptr<Player> player); - static bool saveRewardItems(std::shared_ptr<Player> player); - static bool savePlayerInbox(std::shared_ptr<Player> player); - static bool savePlayerPreyClass(std::shared_ptr<Player> player); - static bool savePlayerTaskHuntingClass(std::shared_ptr<Player> player); - static bool savePlayerForgeHistory(std::shared_ptr<Player> player); - static bool savePlayerBosstiary(std::shared_ptr<Player> player); - static bool savePlayerStorage(std::shared_ptr<Player> player); + static bool savePlayerFirst(const std::shared_ptr<Player> &player); + static bool savePlayerStash(const std::shared_ptr<Player> &player); + static bool savePlayerSpells(const std::shared_ptr<Player> &player); + static bool savePlayerKills(const std::shared_ptr<Player> &player); + static bool savePlayerBestiarySystem(const std::shared_ptr<Player> &player); + static bool savePlayerItem(const std::shared_ptr<Player> &player); + static bool savePlayerDepotItems(const std::shared_ptr<Player> &player); + static bool saveRewardItems(const std::shared_ptr<Player> &player); + static bool savePlayerInbox(const std::shared_ptr<Player> &player); + static bool savePlayerPreyClass(const std::shared_ptr<Player> &player); + static bool savePlayerTaskHuntingClass(const std::shared_ptr<Player> &player); + static bool savePlayerForgeHistory(const std::shared_ptr<Player> &player); + static bool savePlayerBosstiary(const std::shared_ptr<Player> &player); + static bool savePlayerStorage(const std::shared_ptr<Player> &player); protected: using ItemBlockList = std::list<std::pair<int32_t, std::shared_ptr<Item>>>; @@ -34,5 +34,5 @@ class IOLoginDataSave : public IOLoginData { using ItemRewardList = std::list<std::pair<int32_t, std::shared_ptr<Item>>>; using ItemInboxList = std::list<std::pair<int32_t, std::shared_ptr<Item>>>; - static bool saveItems(std::shared_ptr<Player> player, const ItemBlockList &itemList, DBInsert &query_insert, PropWriteStream &stream); + static bool saveItems(const std::shared_ptr<Player> &player, const ItemBlockList &itemList, DBInsert &query_insert, PropWriteStream &stream); }; diff --git a/src/io/io_bosstiary.cpp b/src/io/io_bosstiary.cpp index d10aed53615..68eaf2f8e3e 100644 --- a/src/io/io_bosstiary.cpp +++ b/src/io/io_bosstiary.cpp @@ -25,7 +25,7 @@ void IOBosstiary::loadBoostedBoss() { return; } - uint16_t date = result->getNumber<uint16_t>("date"); + auto date = result->getNumber<uint16_t>("date"); auto timeNow = getTimeNow(); auto time = localtime(&timeNow); auto today = time->tm_mday; @@ -59,12 +59,12 @@ void IOBosstiary::loadBoostedBoss() { } // Check if not have archfoe registered boss - if (bossInfo.size() == 0) { + if (bossInfo.empty()) { g_logger().error("Failed to boost a boss. There is no boss registered with the Archfoe Rarity."); return; } - uint16_t oldBossRace = result->getNumber<uint16_t>("raceid"); + auto oldBossRace = result->getNumber<uint16_t>("raceid"); while (true) { uint32_t randomIndex = uniform_random(0, static_cast<int32_t>(bossInfo.size())); auto it = std::next(bossInfo.begin(), randomIndex); @@ -167,7 +167,7 @@ std::shared_ptr<MonsterType> IOBosstiary::getMonsterTypeByBossRaceId(uint16_t ra return nullptr; } -void IOBosstiary::addBosstiaryKill(std::shared_ptr<Player> player, const std::shared_ptr<MonsterType> mtype, uint32_t amount /*= 1*/) const { +void IOBosstiary::addBosstiaryKill(const std::shared_ptr<Player> &player, const std::shared_ptr<MonsterType> &mtype, uint32_t amount /*= 1*/) const { if (!player || !mtype) { return; } @@ -267,7 +267,7 @@ std::vector<uint16_t> IOBosstiary::getBosstiaryFinished(const std::shared_ptr<Pl return unlockedMonsters.data(); } -uint8_t IOBosstiary::getBossCurrentLevel(std::shared_ptr<Player> player, uint16_t bossId) const { +uint8_t IOBosstiary::getBossCurrentLevel(const std::shared_ptr<Player> &player, uint16_t bossId) const { if (bossId == 0 || !player) { return 0; } diff --git a/src/io/io_bosstiary.hpp b/src/io/io_bosstiary.hpp index 11eabf30a8b..3afdb936c6d 100644 --- a/src/io/io_bosstiary.hpp +++ b/src/io/io_bosstiary.hpp @@ -60,11 +60,11 @@ class IOBosstiary { uint16_t getBoostedBossId() const; std::shared_ptr<MonsterType> getMonsterTypeByBossRaceId(uint16_t raceId) const; - void addBosstiaryKill(std::shared_ptr<Player> player, const std::shared_ptr<MonsterType> mtype, uint32_t amount = 1) const; + void addBosstiaryKill(const std::shared_ptr<Player> &player, const std::shared_ptr<MonsterType> &mtype, uint32_t amount = 1) const; uint16_t calculateLootBonus(uint32_t bossPoints) const; uint32_t calculateBossPoints(uint16_t lootBonus) const; std::vector<uint16_t> getBosstiaryFinished(const std::shared_ptr<Player> &player, uint8_t level = 1) const; - uint8_t getBossCurrentLevel(std::shared_ptr<Player> player, uint16_t bossId) const; + uint8_t getBossCurrentLevel(const std::shared_ptr<Player> &player, uint16_t bossId) const; uint32_t calculteRemoveBoss(uint8_t removeTimes) const; const std::vector<LevelInfo> &getBossRaceKillStages(BosstiaryRarity_t race) const; diff --git a/src/io/iobestiary.cpp b/src/io/iobestiary.cpp index 83dd2ed806e..3113f14d36d 100644 --- a/src/io/iobestiary.cpp +++ b/src/io/iobestiary.cpp @@ -16,7 +16,7 @@ SoftSingleton IOBestiary::instanceTracker("IOBestiary"); -bool IOBestiary::parseCharmCombat(const std::shared_ptr<Charm> charm, std::shared_ptr<Player> player, std::shared_ptr<Creature> target, int32_t realDamage, bool dueToPotion, bool checkArmor) { +bool IOBestiary::parseCharmCombat(const std::shared_ptr<Charm> &charm, const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, int32_t realDamage, bool dueToPotion, bool checkArmor) { if (!charm || !player || !target) { return false; } @@ -113,7 +113,7 @@ std::shared_ptr<Charm> IOBestiary::getBestiaryCharm(charmRune_t activeCharm, boo } std::map<uint16_t, std::string> IOBestiary::findRaceByName(const std::string &race, bool Onlystring /*= true*/, BestiaryType_t raceNumber /*= BESTY_RACE_NONE*/) const { - std::map<uint16_t, std::string> best_list = g_game().getBestiaryList(); + const std::map<uint16_t, std::string> &best_list = g_game().getBestiaryList(); std::map<uint16_t, std::string> race_list; if (Onlystring) { @@ -134,7 +134,7 @@ std::map<uint16_t, std::string> IOBestiary::findRaceByName(const std::string &ra return race_list; } -uint8_t IOBestiary::getKillStatus(const std::shared_ptr<MonsterType> mtype, uint32_t killAmount) const { +uint8_t IOBestiary::getKillStatus(const std::shared_ptr<MonsterType> &mtype, uint32_t killAmount) const { if (killAmount < mtype->info.bestiaryFirstUnlock) { return 1; } else if (killAmount < mtype->info.bestiarySecondUnlock) { @@ -145,7 +145,7 @@ uint8_t IOBestiary::getKillStatus(const std::shared_ptr<MonsterType> mtype, uint return 4; } -void IOBestiary::resetCharmRuneCreature(std::shared_ptr<Player> player, const std::shared_ptr<Charm> charm) { +void IOBestiary::resetCharmRuneCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Charm> &charm) const { if (!player || !charm) { return; } @@ -155,7 +155,7 @@ void IOBestiary::resetCharmRuneCreature(std::shared_ptr<Player> player, const st player->parseRacebyCharm(charm->id, true, 0); } -void IOBestiary::setCharmRuneCreature(std::shared_ptr<Player> player, const std::shared_ptr<Charm> charm, uint16_t raceid) { +void IOBestiary::setCharmRuneCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Charm> &charm, uint16_t raceid) const { if (!player || !charm) { return; } @@ -165,14 +165,14 @@ void IOBestiary::setCharmRuneCreature(std::shared_ptr<Player> player, const std: player->setUsedRunesBit(Toggle); } -std::list<charmRune_t> IOBestiary::getCharmUsedRuneBitAll(std::shared_ptr<Player> player) { +std::list<charmRune_t> IOBestiary::getCharmUsedRuneBitAll(const std::shared_ptr<Player> &player) { int32_t input = player->getUsedRunesBit(); int8_t i = 0; std::list<charmRune_t> rtn; while (input != 0) { if ((input & 1) == 1) { - charmRune_t tmpcharm = static_cast<charmRune_t>(i); + auto tmpcharm = static_cast<charmRune_t>(i); rtn.push_front(tmpcharm); } input = input >> 1; @@ -181,7 +181,7 @@ std::list<charmRune_t> IOBestiary::getCharmUsedRuneBitAll(std::shared_ptr<Player return rtn; } -uint16_t IOBestiary::getBestiaryRaceUnlocked(std::shared_ptr<Player> player, BestiaryType_t race) const { +uint16_t IOBestiary::getBestiaryRaceUnlocked(const std::shared_ptr<Player> &player, BestiaryType_t race) const { if (!player) { return 0; } @@ -198,7 +198,7 @@ uint16_t IOBestiary::getBestiaryRaceUnlocked(std::shared_ptr<Player> player, Bes return count; } -void IOBestiary::addCharmPoints(std::shared_ptr<Player> player, uint16_t amount, bool negative /*= false*/) { +void IOBestiary::addCharmPoints(const std::shared_ptr<Player> &player, uint16_t amount, bool negative /*= false*/) { if (!player) { return; } @@ -212,7 +212,7 @@ void IOBestiary::addCharmPoints(std::shared_ptr<Player> player, uint16_t amount, player->setCharmPoints(myCharms); } -void IOBestiary::addBestiaryKill(std::shared_ptr<Player> player, const std::shared_ptr<MonsterType> mtype, uint32_t amount /*= 1*/) { +void IOBestiary::addBestiaryKill(const std::shared_ptr<Player> &player, const std::shared_ptr<MonsterType> &mtype, uint32_t amount /*= 1*/) { uint16_t raceid = mtype->info.raceid; if (raceid == 0 || !player || !mtype) { return; @@ -239,7 +239,7 @@ void IOBestiary::addBestiaryKill(std::shared_ptr<Player> player, const std::shar player->refreshCyclopediaMonsterTracker(); } -charmRune_t IOBestiary::getCharmFromTarget(std::shared_ptr<Player> player, const std::shared_ptr<MonsterType> mtype) { +charmRune_t IOBestiary::getCharmFromTarget(const std::shared_ptr<Player> &player, const std::shared_ptr<MonsterType> &mtype) { if (!player || !mtype) { return CHARM_NONE; } @@ -256,7 +256,7 @@ charmRune_t IOBestiary::getCharmFromTarget(std::shared_ptr<Player> player, const return CHARM_NONE; } -bool IOBestiary::hasCharmUnlockedRuneBit(const std::shared_ptr<Charm> charm, int32_t input) const { +bool IOBestiary::hasCharmUnlockedRuneBit(const std::shared_ptr<Charm> &charm, int32_t input) const { if (!charm) { return false; } @@ -264,7 +264,7 @@ bool IOBestiary::hasCharmUnlockedRuneBit(const std::shared_ptr<Charm> charm, int return ((input & charm->binary) != 0); } -int32_t IOBestiary::bitToggle(int32_t input, const std::shared_ptr<Charm> charm, bool on) const { +int32_t IOBestiary::bitToggle(int32_t input, const std::shared_ptr<Charm> &charm, bool on) const { if (!charm) { return CHARM_NONE; } @@ -281,7 +281,7 @@ int32_t IOBestiary::bitToggle(int32_t input, const std::shared_ptr<Charm> charm, } } -void IOBestiary::sendBuyCharmRune(std::shared_ptr<Player> player, charmRune_t runeID, uint8_t action, uint16_t raceid) { +void IOBestiary::sendBuyCharmRune(const std::shared_ptr<Player> &player, charmRune_t runeID, uint8_t action, uint16_t raceid) { const auto charm = getBestiaryCharm(runeID); if (!player || !charm) { return; @@ -343,7 +343,7 @@ void IOBestiary::sendBuyCharmRune(std::shared_ptr<Player> player, charmRune_t ru player->BestiarysendCharms(); } -std::map<uint8_t, int16_t> IOBestiary::getMonsterElements(const std::shared_ptr<MonsterType> mtype) const { +std::map<uint8_t, int16_t> IOBestiary::getMonsterElements(const std::shared_ptr<MonsterType> &mtype) const { std::map<uint8_t, int16_t> defaultMap = {}; for (uint8_t i = 0; i <= 7; i++) { defaultMap[i] = 100; @@ -381,7 +381,7 @@ std::map<uint8_t, int16_t> IOBestiary::getMonsterElements(const std::shared_ptr< return defaultMap; } -std::map<uint16_t, uint32_t> IOBestiary::getBestiaryKillCountByMonsterIDs(std::shared_ptr<Player> player, std::map<uint16_t, std::string> mtype_list) const { +std::map<uint16_t, uint32_t> IOBestiary::getBestiaryKillCountByMonsterIDs(const std::shared_ptr<Player> &player, const std::map<uint16_t, std::string> &mtype_list) const { std::map<uint16_t, uint32_t> raceMonsters = {}; for (const auto &it : mtype_list) { uint16_t raceid = it.first; diff --git a/src/io/iobestiary.hpp b/src/io/iobestiary.hpp index a521ce68852..6baef14c89d 100644 --- a/src/io/iobestiary.hpp +++ b/src/io/iobestiary.hpp @@ -26,7 +26,7 @@ class Charm { std::string name; charmRune_t id = CHARM_NONE; std::string description; - charm_t type; + charm_t type {}; uint16_t points = 0; int32_t binary = 0; std::string cancelMsg; @@ -55,29 +55,29 @@ class IOBestiary { } std::shared_ptr<Charm> getBestiaryCharm(charmRune_t activeCharm, bool force = false) const; - void addBestiaryKill(std::shared_ptr<Player> player, const std::shared_ptr<MonsterType> mtype, uint32_t amount = 1); - bool parseCharmCombat(const std::shared_ptr<Charm> charm, std::shared_ptr<Player> player, std::shared_ptr<Creature> target, int32_t realDamage, bool dueToPotion = false, bool checkArmor = false); - void addCharmPoints(std::shared_ptr<Player> player, uint16_t amount, bool negative = false); - void sendBuyCharmRune(std::shared_ptr<Player> player, charmRune_t runeID, uint8_t action, uint16_t raceid); - void setCharmRuneCreature(std::shared_ptr<Player> player, const std::shared_ptr<Charm> charm, uint16_t raceid); - void resetCharmRuneCreature(std::shared_ptr<Player> player, const std::shared_ptr<Charm> charm); + void addBestiaryKill(const std::shared_ptr<Player> &player, const std::shared_ptr<MonsterType> &mtype, uint32_t amount = 1); + bool parseCharmCombat(const std::shared_ptr<Charm> &charm, const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, int32_t realDamage, bool dueToPotion = false, bool checkArmor = false); + void addCharmPoints(const std::shared_ptr<Player> &player, uint16_t amount, bool negative = false); + void sendBuyCharmRune(const std::shared_ptr<Player> &player, charmRune_t runeID, uint8_t action, uint16_t raceid); + void setCharmRuneCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Charm> &charm, uint16_t raceid) const; + void resetCharmRuneCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Charm> &charm) const; int8_t calculateDifficult(uint32_t chance) const; - uint8_t getKillStatus(const std::shared_ptr<MonsterType> mtype, uint32_t killAmount) const; + uint8_t getKillStatus(const std::shared_ptr<MonsterType> &mtype, uint32_t killAmount) const; - uint16_t getBestiaryRaceUnlocked(std::shared_ptr<Player> player, BestiaryType_t race) const; + uint16_t getBestiaryRaceUnlocked(const std::shared_ptr<Player> &player, BestiaryType_t race) const; - int32_t bitToggle(int32_t input, const std::shared_ptr<Charm> charm, bool on) const; + int32_t bitToggle(int32_t input, const std::shared_ptr<Charm> &charm, bool on) const; - bool hasCharmUnlockedRuneBit(const std::shared_ptr<Charm> charm, int32_t input) const; + bool hasCharmUnlockedRuneBit(const std::shared_ptr<Charm> &charm, int32_t input) const; - std::list<charmRune_t> getCharmUsedRuneBitAll(std::shared_ptr<Player> player); + std::list<charmRune_t> getCharmUsedRuneBitAll(const std::shared_ptr<Player> &player); std::vector<uint16_t> getBestiaryFinished(const std::shared_ptr<Player> &player) const; - charmRune_t getCharmFromTarget(std::shared_ptr<Player> player, const std::shared_ptr<MonsterType> mtype); + charmRune_t getCharmFromTarget(const std::shared_ptr<Player> &player, const std::shared_ptr<MonsterType> &mtype); - std::map<uint16_t, uint32_t> getBestiaryKillCountByMonsterIDs(std::shared_ptr<Player> player, std::map<uint16_t, std::string> mtype_list) const; - std::map<uint8_t, int16_t> getMonsterElements(const std::shared_ptr<MonsterType> mtype) const; + std::map<uint16_t, uint32_t> getBestiaryKillCountByMonsterIDs(const std::shared_ptr<Player> &player, const std::map<uint16_t, std::string> &mtype_list) const; + std::map<uint8_t, int16_t> getMonsterElements(const std::shared_ptr<MonsterType> &mtype) const; std::map<uint16_t, std::string> findRaceByName(const std::string &race, bool Onlystring = true, BestiaryType_t raceNumber = BESTY_RACE_NONE) const; private: diff --git a/src/io/ioguild.cpp b/src/io/ioguild.cpp index 9d3d628a42d..2e128aed94a 100644 --- a/src/io/ioguild.cpp +++ b/src/io/ioguild.cpp @@ -31,7 +31,7 @@ std::shared_ptr<Guild> IOGuild::loadGuild(uint32_t guildId) { return nullptr; } -void IOGuild::saveGuild(const std::shared_ptr<Guild> guild) { +void IOGuild::saveGuild(const std::shared_ptr<Guild> &guild) { if (!guild) { return; } @@ -66,7 +66,7 @@ void IOGuild::getWarList(uint32_t guildId, GuildWarVector &guildWarVector) { } do { - uint32_t guild1 = result->getNumber<uint32_t>("guild1"); + auto guild1 = result->getNumber<uint32_t>("guild1"); if (guildId != guild1) { guildWarVector.push_back(guild1); } else { diff --git a/src/io/ioguild.hpp b/src/io/ioguild.hpp index cc450841bd1..52a8e7c1cba 100644 --- a/src/io/ioguild.hpp +++ b/src/io/ioguild.hpp @@ -15,7 +15,7 @@ using GuildWarVector = std::vector<uint32_t>; class IOGuild { public: static std::shared_ptr<Guild> loadGuild(uint32_t guildId); - static void saveGuild(const std::shared_ptr<Guild> guild); + static void saveGuild(const std::shared_ptr<Guild> &guild); static uint32_t getGuildIdByName(const std::string &name); static void getWarList(uint32_t guildId, GuildWarVector &guildWarVector); }; diff --git a/src/io/iologindata.cpp b/src/io/iologindata.cpp index 17816f969de..eff416b8358 100644 --- a/src/io/iologindata.cpp +++ b/src/io/iologindata.cpp @@ -73,41 +73,22 @@ uint8_t IOLoginData::getAccountType(uint32_t accountId) { return result->getNumber<uint8_t>("type"); } -void IOLoginData::updateOnlineStatus(uint32_t guid, bool login) { - static phmap::flat_hash_map<uint32_t, bool> updateOnline; - if ((login && updateOnline.find(guid) != updateOnline.end()) || guid <= 0) { - return; - } - - std::ostringstream query; - if (login) { - g_metrics().addUpDownCounter("players_online", 1); - query << "INSERT INTO `players_online` VALUES (" << guid << ')'; - updateOnline[guid] = true; - } else { - g_metrics().addUpDownCounter("players_online", -1); - query << "DELETE FROM `players_online` WHERE `player_id` = " << guid; - updateOnline.erase(guid); - } - Database::getInstance().executeQuery(query.str()); -} - // The boolean "disableIrrelevantInfo" will deactivate the loading of information that is not relevant to the preload, for example, forge, bosstiary, etc. None of this we need to access if the player is offline -bool IOLoginData::loadPlayerById(std::shared_ptr<Player> player, uint32_t id, bool disableIrrelevantInfo /* = true*/) { +bool IOLoginData::loadPlayerById(const std::shared_ptr<Player> &player, uint32_t id, bool disableIrrelevantInfo /* = true*/) { Database &db = Database::getInstance(); std::ostringstream query; query << "SELECT * FROM `players` WHERE `id` = " << id; return loadPlayer(player, db.storeQuery(query.str()), disableIrrelevantInfo); } -bool IOLoginData::loadPlayerByName(std::shared_ptr<Player> player, const std::string &name, bool disableIrrelevantInfo /* = true*/) { +bool IOLoginData::loadPlayerByName(const std::shared_ptr<Player> &player, const std::string &name, bool disableIrrelevantInfo /* = true*/) { Database &db = Database::getInstance(); std::ostringstream query; query << "SELECT * FROM `players` WHERE `name` = " << db.escapeString(name); return loadPlayer(player, db.storeQuery(query.str()), disableIrrelevantInfo); } -bool IOLoginData::loadPlayer(std::shared_ptr<Player> player, DBResult_ptr result, bool disableIrrelevantInfo /* = false*/) { +bool IOLoginData::loadPlayer(const std::shared_ptr<Player> &player, const DBResult_ptr &result, bool disableIrrelevantInfo /* = false*/) { if (!result || !player) { std::string nullptrType = !result ? "Result" : "Player"; g_logger().warn("[{}] - {} is nullptr", __FUNCTION__, nullptrType); @@ -201,7 +182,7 @@ bool IOLoginData::loadPlayer(std::shared_ptr<Player> player, DBResult_ptr result } } -bool IOLoginData::savePlayer(std::shared_ptr<Player> player) { +bool IOLoginData::savePlayer(const std::shared_ptr<Player> &player) { try { bool success = DBTransaction::executeWithinTransaction([player]() { return savePlayerGuard(player); @@ -219,7 +200,7 @@ bool IOLoginData::savePlayer(std::shared_ptr<Player> player) { return false; } -bool IOLoginData::savePlayerGuard(std::shared_ptr<Player> player) { +bool IOLoginData::savePlayerGuard(const std::shared_ptr<Player> &player) { if (!player) { throw DatabaseException("Player nullptr in function: " + std::string(__FUNCTION__)); } @@ -292,7 +273,7 @@ std::string IOLoginData::getNameByGuid(uint32_t guid) { query << "SELECT `name` FROM `players` WHERE `id` = " << guid; DBResult_ptr result = Database::getInstance().storeQuery(query.str()); if (!result) { - return std::string(); + return {}; } return result->getString("name"); } diff --git a/src/io/iologindata.hpp b/src/io/iologindata.hpp index 79fa3b59ad7..29eac0c812f 100644 --- a/src/io/iologindata.hpp +++ b/src/io/iologindata.hpp @@ -19,11 +19,10 @@ class IOLoginData { public: static bool gameWorldAuthentication(const std::string &accountDescriptor, const std::string &sessionOrPassword, std::string &characterName, uint32_t &accountId, bool oldProcotol, const uint32_t ip); static uint8_t getAccountType(uint32_t accountId); - static void updateOnlineStatus(uint32_t guid, bool login); - static bool loadPlayerById(std::shared_ptr<Player> player, uint32_t id, bool disableIrrelevantInfo = true); - static bool loadPlayerByName(std::shared_ptr<Player> player, const std::string &name, bool disableIrrelevantInfo = true); - static bool loadPlayer(std::shared_ptr<Player> player, DBResult_ptr result, bool disableIrrelevantInfo = false); - static bool savePlayer(std::shared_ptr<Player> player); + static bool loadPlayerById(const std::shared_ptr<Player> &player, uint32_t id, bool disableIrrelevantInfo = true); + static bool loadPlayerByName(const std::shared_ptr<Player> &player, const std::string &name, bool disableIrrelevantInfo = true); + static bool loadPlayer(const std::shared_ptr<Player> &player, const DBResult_ptr &result, bool disableIrrelevantInfo = false); + static bool savePlayer(const std::shared_ptr<Player> &player); static uint32_t getGuidByName(const std::string &name); static bool getGuidByNameEx(uint32_t &guid, bool &specialVip, std::string &name); static std::string getNameByGuid(uint32_t guid); @@ -44,5 +43,5 @@ class IOLoginData { static void removeGuidVIPGroupEntry(uint32_t accountId, uint32_t guid); private: - static bool savePlayerGuard(std::shared_ptr<Player> player); + static bool savePlayerGuard(const std::shared_ptr<Player> &player); }; diff --git a/src/io/iomap.cpp b/src/io/iomap.cpp index d39988caa71..3f66f5764ac 100644 --- a/src/io/iomap.cpp +++ b/src/io/iomap.cpp @@ -134,7 +134,7 @@ void IOMap::parseTileArea(FileStream &stream, Map &map, const Position &pos) { const uint16_t x = base_x + tileCoordsX + pos.x; const uint16_t y = base_y + tileCoordsY + pos.y; - const uint8_t z = static_cast<uint8_t>(base_z + pos.z); + const auto z = static_cast<uint8_t>(base_z + pos.z); if (tileType == OTBM_HOUSETILE) { tile->houseId = stream.getU32(); diff --git a/src/io/iomap.hpp b/src/io/iomap.hpp index b730f664853..6ac74690460 100644 --- a/src/io/iomap.hpp +++ b/src/io/iomap.hpp @@ -11,6 +11,7 @@ #include "declarations.hpp" +// TODO: move to .cpp for avoid circular dependencies #include "config/configmanager.hpp" #include "map/house/house.hpp" #include "items/item.hpp" @@ -157,8 +158,8 @@ class IOMap { class IOMapException : public std::exception { public: - explicit IOMapException(const std::string &msg) : - message(msg) { } + explicit IOMapException(std::string msg) : + message(std::move(msg)) { } const char* what() const noexcept override { return message.c_str(); diff --git a/src/io/iomapserialize.cpp b/src/io/iomapserialize.cpp index 4c20d8a6aa1..378f2f4246e 100644 --- a/src/io/iomapserialize.cpp +++ b/src/io/iomapserialize.cpp @@ -108,7 +108,7 @@ bool IOMapSerialize::SaveHouseItemsGuard() { return true; } -bool IOMapSerialize::loadContainer(PropStream &propStream, std::shared_ptr<Container> container) { +bool IOMapSerialize::loadContainer(PropStream &propStream, const std::shared_ptr<Container> &container) { while (container->serializationCount > 0) { if (!loadItem(propStream, container)) { g_logger().warn("Deserialization error for container item: {}", container->getID()); @@ -125,7 +125,7 @@ bool IOMapSerialize::loadContainer(PropStream &propStream, std::shared_ptr<Conta return true; } -bool IOMapSerialize::loadItem(PropStream &propStream, std::shared_ptr<Cylinder> parent, bool isHouseItem /*= false*/) { +bool IOMapSerialize::loadItem(PropStream &propStream, const std::shared_ptr<Cylinder> &parent, bool isHouseItem /*= false*/) { uint16_t id; if (!propStream.read<uint16_t>(id)) { return false; @@ -214,8 +214,8 @@ bool IOMapSerialize::loadItem(PropStream &propStream, std::shared_ptr<Cylinder> return true; } -void IOMapSerialize::saveItem(PropWriteStream &stream, std::shared_ptr<Item> item) { - std::shared_ptr<Container> container = item->getContainer(); +void IOMapSerialize::saveItem(PropWriteStream &stream, const std::shared_ptr<Item> &item) { + const auto &container = item->getContainer(); // Write ID & props stream.write<uint16_t>(item->getID()); @@ -233,7 +233,7 @@ void IOMapSerialize::saveItem(PropWriteStream &stream, std::shared_ptr<Item> ite stream.write<uint8_t>(0x00); // attr end } -void IOMapSerialize::saveTile(PropWriteStream &stream, std::shared_ptr<Tile> tile) { +void IOMapSerialize::saveTile(PropWriteStream &stream, const std::shared_ptr<Tile> &tile) { const TileItemVector* tileItems = tile->getItemList(); if (!tileItems) { return; @@ -280,8 +280,8 @@ bool IOMapSerialize::loadHouseInfo() { auto houseId = result->getNumber<uint32_t>("id"); const auto house = g_game().map.houses.getHouse(houseId); if (house) { - uint32_t owner = result->getNumber<uint32_t>("owner"); - int32_t newOwner = result->getNumber<int32_t>("new_owner"); + auto owner = result->getNumber<uint32_t>("owner"); + auto newOwner = result->getNumber<int32_t>("new_owner"); // Transfer house owner auto isTransferOnRestart = g_configManager().getBoolean(TOGGLE_HOUSE_TRANSFER_ON_SERVER_RESTART); if (isTransferOnRestart && newOwner >= 0) { @@ -368,7 +368,7 @@ bool IOMapSerialize::SaveHouseInfoGuard() { listText.clear(); } - for (std::shared_ptr<Door> door : house->getDoors()) { + for (const std::shared_ptr<Door> &door : house->getDoors()) { if (door->getAccessList(listText) && !listText.empty()) { query << house->getId() << ',' << door->getDoorId() << ',' << db.escapeString(listText) << ',' << version; if (!listUpdate.addRow(query)) { diff --git a/src/io/iomapserialize.hpp b/src/io/iomapserialize.hpp index 08cbac01128..ae1c9ccb5f1 100644 --- a/src/io/iomapserialize.hpp +++ b/src/io/iomapserialize.hpp @@ -21,9 +21,9 @@ class IOMapSerialize { private: static bool SaveHouseInfoGuard(); static bool SaveHouseItemsGuard(); - static void saveItem(PropWriteStream &stream, std::shared_ptr<Item> item); - static void saveTile(PropWriteStream &stream, std::shared_ptr<Tile> tile); + static void saveItem(PropWriteStream &stream, const std::shared_ptr<Item> &item); + static void saveTile(PropWriteStream &stream, const std::shared_ptr<Tile> &tile); - static bool loadContainer(PropStream &propStream, std::shared_ptr<Container> container); - static bool loadItem(PropStream &propStream, std::shared_ptr<Cylinder> parent, bool isHouseItem = false); + static bool loadContainer(PropStream &propStream, const std::shared_ptr<Container> &container); + static bool loadItem(PropStream &propStream, const std::shared_ptr<Cylinder> &parent, bool isHouseItem = false); }; diff --git a/src/io/iomarket.cpp b/src/io/iomarket.cpp index 72f245c56d6..321e251fc6e 100644 --- a/src/io/iomarket.cpp +++ b/src/io/iomarket.cpp @@ -128,7 +128,7 @@ HistoryMarketOfferList IOMarket::getOwnHistory(MarketAction_t action, uint32_t p } do { - HistoryMarketOffer offer; + HistoryMarketOffer offer {}; offer.itemId = result->getNumber<uint16_t>("itemtype"); offer.amount = result->getNumber<uint16_t>("amount"); offer.price = result->getNumber<uint64_t>("price"); @@ -147,7 +147,7 @@ HistoryMarketOfferList IOMarket::getOwnHistory(MarketAction_t action, uint32_t p return offerList; } -void IOMarket::processExpiredOffers(DBResult_ptr result, bool) { +void IOMarket::processExpiredOffers(const DBResult_ptr &result, bool) { if (!result) { return; } @@ -157,8 +157,8 @@ void IOMarket::processExpiredOffers(DBResult_ptr result, bool) { continue; } - const uint32_t playerId = result->getNumber<uint32_t>("player_id"); - const uint16_t amount = result->getNumber<uint16_t>("amount"); + const auto playerId = result->getNumber<uint32_t>("player_id"); + const auto amount = result->getNumber<uint16_t>("amount"); auto tier = getTierFromDatabaseTable(result->getString("tier")); if (result->getNumber<uint16_t>("sale") == 1) { const ItemType &itemType = Item::items[result->getNumber<uint16_t>("itemtype")]; @@ -166,7 +166,7 @@ void IOMarket::processExpiredOffers(DBResult_ptr result, bool) { continue; } - std::shared_ptr<Player> player = g_game().getPlayerByGUID(playerId, true); + const auto &player = g_game().getPlayerByGUID(playerId, true); if (!player) { continue; } @@ -175,7 +175,7 @@ void IOMarket::processExpiredOffers(DBResult_ptr result, bool) { uint16_t tmpAmount = amount; while (tmpAmount > 0) { uint16_t stackCount = std::min<uint16_t>(100, tmpAmount); - std::shared_ptr<Item> item = Item::CreateItem(itemType.id, stackCount); + const auto &item = Item::CreateItem(itemType.id, stackCount); if (g_game().internalAddItem(player->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT) != RETURNVALUE_NOERROR) { g_logger().error("[{}] Ocurred an error to add item with id {} to player {}", __FUNCTION__, itemType.id, player->getName()); @@ -197,7 +197,7 @@ void IOMarket::processExpiredOffers(DBResult_ptr result, bool) { } for (uint16_t i = 0; i < amount; ++i) { - std::shared_ptr<Item> item = Item::CreateItem(itemType.id, subType); + const auto &item = Item::CreateItem(itemType.id, subType); if (g_game().internalAddItem(player->getInbox(), item, INDEX_WHEREEVER, FLAG_NOLIMIT) != RETURNVALUE_NOERROR) { break; } @@ -214,7 +214,7 @@ void IOMarket::processExpiredOffers(DBResult_ptr result, bool) { } else { uint64_t totalPrice = result->getNumber<uint64_t>("price") * amount; - std::shared_ptr<Player> player = g_game().getPlayerByGUID(playerId); + const auto &player = g_game().getPlayerByGUID(playerId); if (player) { player->setBankBalance(player->getBankBalance() + totalPrice); } else { diff --git a/src/io/iomarket.hpp b/src/io/iomarket.hpp index 4292651fb47..5a078bbc1cb 100644 --- a/src/io/iomarket.hpp +++ b/src/io/iomarket.hpp @@ -26,7 +26,7 @@ class IOMarket { static MarketOfferList getOwnOffers(MarketAction_t action, uint32_t playerId); static HistoryMarketOfferList getOwnHistory(MarketAction_t action, uint32_t playerId); - static void processExpiredOffers(DBResult_ptr result, bool); + static void processExpiredOffers(const DBResult_ptr &result, bool); static void checkExpiredOffers(); static uint32_t getPlayerOfferCount(uint32_t playerId); diff --git a/src/io/ioprey.cpp b/src/io/ioprey.cpp index b21f442bf67..39996e0e77d 100644 --- a/src/io/ioprey.cpp +++ b/src/io/ioprey.cpp @@ -253,7 +253,7 @@ IOPrey &IOPrey::getInstance() { } // Prey/Task hunting global class -void IOPrey::checkPlayerPreys(std::shared_ptr<Player> player, uint8_t amount) const { +void IOPrey::checkPlayerPreys(const std::shared_ptr<Player> &player, uint8_t amount) const { if (!player) { return; } @@ -297,7 +297,7 @@ void IOPrey::checkPlayerPreys(std::shared_ptr<Player> player, uint8_t amount) co } } -void IOPrey::parsePreyAction(std::shared_ptr<Player> player, PreySlot_t slotId, PreyAction_t action, PreyOption_t option, int8_t index, uint16_t raceId) const { +void IOPrey::parsePreyAction(const std::shared_ptr<Player> &player, PreySlot_t slotId, PreyAction_t action, PreyOption_t option, int8_t index, uint16_t raceId) const { const auto &slot = player->getPreySlotById(slotId); if (!slot || slot->state == PreyDataState_Locked) { player->sendMessageDialog("To unlock this prey slot first you must buy it on store."); @@ -403,7 +403,7 @@ void IOPrey::parsePreyAction(std::shared_ptr<Player> player, PreySlot_t slotId, player->reloadPreySlot(slotId); } -void IOPrey::parseTaskHuntingAction(std::shared_ptr<Player> player, PreySlot_t slotId, PreyTaskAction_t action, bool upgrade, uint16_t raceId) const { +void IOPrey::parseTaskHuntingAction(const std::shared_ptr<Player> &player, PreySlot_t slotId, PreyTaskAction_t action, bool upgrade, uint16_t raceId) const { const auto &slot = player->getTaskHuntingSlotById(slotId); if (!slot || slot->state == PreyTaskDataState_Locked) { player->sendMessageDialog("To unlock this task hunting slot first you must buy it on store."); diff --git a/src/io/ioprey.hpp b/src/io/ioprey.hpp index df7243df6d6..b7470563d60 100644 --- a/src/io/ioprey.hpp +++ b/src/io/ioprey.hpp @@ -225,10 +225,10 @@ class IOPrey { static IOPrey &getInstance(); - void checkPlayerPreys(std::shared_ptr<Player> player, uint8_t amount) const; - void parsePreyAction(std::shared_ptr<Player> player, PreySlot_t slotId, PreyAction_t action, PreyOption_t option, int8_t index, uint16_t raceId) const; + void checkPlayerPreys(const std::shared_ptr<Player> &player, uint8_t amount) const; + void parsePreyAction(const std::shared_ptr<Player> &player, PreySlot_t slotId, PreyAction_t action, PreyOption_t option, int8_t index, uint16_t raceId) const; - void parseTaskHuntingAction(std::shared_ptr<Player> player, PreySlot_t slotId, PreyTaskAction_t action, bool upgrade, uint16_t raceId) const; + void parseTaskHuntingAction(const std::shared_ptr<Player> &player, PreySlot_t slotId, PreyTaskAction_t action, bool upgrade, uint16_t raceId) const; void initializeTaskHuntOptions(); const std::unique_ptr<TaskHuntingOption> &getTaskRewardOption(const std::unique_ptr<TaskHuntingSlot> &slot) const; diff --git a/src/items/bed.cpp b/src/items/bed.cpp index e40a0f85e0f..830e8f11082 100644 --- a/src/items/bed.cpp +++ b/src/items/bed.cpp @@ -27,7 +27,7 @@ Attr_ReadValue BedItem::readAttr(AttrTypes_t attr, PropStream &propStream) { } if (guid != 0) { - std::string name = IOLoginData::getNameByGuid(guid); + const std::string name = IOLoginData::getNameByGuid(guid); if (!name.empty()) { setAttribute(ItemAttribute_t::DESCRIPTION, name + " is sleeping there."); g_game().setBedSleeper(static_self_cast<BedItem>(), guid); @@ -67,22 +67,22 @@ void BedItem::serializeAttr(PropWriteStream &propWriteStream) const { } std::shared_ptr<BedItem> BedItem::getNextBedItem() { - Direction dir = Item::items[id].bedPartnerDir; - Position targetPos = getNextPosition(dir, getPosition()); + const Direction dir = Item::items[id].bedPartnerDir; + const Position targetPos = getNextPosition(dir, getPosition()); - std::shared_ptr<Tile> tile = g_game().map.getTile(targetPos); + const auto &tile = g_game().map.getTile(targetPos); if (tile == nullptr) { return nullptr; } return tile->getBedItem(); } -bool BedItem::canUse(std::shared_ptr<Player> player) { +bool BedItem::canUse(const std::shared_ptr<Player> &player) { if ((player == nullptr) || (house == nullptr) || !player->isPremium()) { return false; } - auto nextBedItem = getNextBedItem(); + const auto &nextBedItem = getNextBedItem(); if (nextBedItem == nullptr) { return false; } @@ -104,7 +104,7 @@ bool BedItem::canUse(std::shared_ptr<Player> player) { return true; } - auto sleeper = std::make_shared<Player>(nullptr); + const auto sleeper = std::make_shared<Player>(nullptr); if (!IOLoginData::loadPlayerById(sleeper, sleeperGUID)) { return false; } @@ -115,7 +115,7 @@ bool BedItem::canUse(std::shared_ptr<Player> player) { return true; } -bool BedItem::isBedComplete(std::shared_ptr<BedItem> nextBedItem) { +bool BedItem::isBedComplete(const std::shared_ptr<BedItem> &nextBedItem) const { const ItemType &it = Item::items[id]; if (nextBedItem == nullptr) { @@ -132,7 +132,7 @@ bool BedItem::isBedComplete(std::shared_ptr<BedItem> nextBedItem) { return it.bedPartOf == nextBedItem->getID(); } -bool BedItem::trySleep(std::shared_ptr<Player> player) { +bool BedItem::trySleep(const std::shared_ptr<Player> &player) { if (!house || player->isRemoved()) { return false; } @@ -148,7 +148,7 @@ bool BedItem::trySleep(std::shared_ptr<Player> player) { return true; } -bool BedItem::sleep(std::shared_ptr<Player> player) { +bool BedItem::sleep(const std::shared_ptr<Player> &player) { if (house == nullptr) { return false; } @@ -157,7 +157,7 @@ bool BedItem::sleep(std::shared_ptr<Player> player) { return false; } - std::shared_ptr<BedItem> nextBedItem = getNextBedItem(); + const auto &nextBedItem = getNextBedItem(); internalSetSleeper(player); @@ -191,7 +191,7 @@ bool BedItem::sleep(std::shared_ptr<Player> player) { return true; } -void BedItem::wakeUp(std::shared_ptr<Player> player) { +void BedItem::wakeUp(const std::shared_ptr<Player> &player) { if (house == nullptr) { return; } @@ -215,7 +215,7 @@ void BedItem::wakeUp(std::shared_ptr<Player> player) { // update the bedSleepersMap g_game().removeBedSleeper(sleeperGUID); - std::shared_ptr<BedItem> nextBedItem = getNextBedItem(); + const auto &nextBedItem = getNextBedItem(); // unset sleep info internalRemoveSleeper(); @@ -232,10 +232,10 @@ void BedItem::wakeUp(std::shared_ptr<Player> player) { } } -void BedItem::regeneratePlayer(std::shared_ptr<Player> player) const { +void BedItem::regeneratePlayer(const std::shared_ptr<Player> &player) const { const uint32_t sleptTime = time(nullptr) - sleepStart; - std::shared_ptr<Condition> condition = player->getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT); + const auto &condition = player->getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT); if (condition != nullptr) { uint32_t regen; if (condition->getTicks() != -1) { @@ -258,7 +258,7 @@ void BedItem::regeneratePlayer(std::shared_ptr<Player> player) const { player->changeSoul(soulRegen); } -void BedItem::updateAppearance(std::shared_ptr<Player> player) { +void BedItem::updateAppearance(const std::shared_ptr<Player> &player) { const ItemType &it = Item::items[id]; if (it.type == ITEM_TYPE_BED) { if ((player != nullptr) && it.transformToOnUse[player->getSex()] != 0) { @@ -275,8 +275,8 @@ void BedItem::updateAppearance(std::shared_ptr<Player> player) { } } -void BedItem::internalSetSleeper(std::shared_ptr<Player> player) { - std::string desc_str = player->getName() + " is sleeping there."; +void BedItem::internalSetSleeper(const std::shared_ptr<Player> &player) { + const std::string desc_str = player->getName() + " is sleeping there."; sleeperGUID = player->getGUID(); sleepStart = time(nullptr); diff --git a/src/items/bed.hpp b/src/items/bed.hpp index 2aeb6e38e5b..725db01ea1b 100644 --- a/src/items/bed.hpp +++ b/src/items/bed.hpp @@ -37,25 +37,25 @@ class BedItem final : public Item { house = h; } - bool canUse(std::shared_ptr<Player> player); + bool canUse(const std::shared_ptr<Player> &player); - bool isBedComplete(std::shared_ptr<BedItem> nextBedItem); + bool isBedComplete(const std::shared_ptr<BedItem> &nextBedItem) const; - bool trySleep(std::shared_ptr<Player> player); - bool sleep(std::shared_ptr<Player> player); - void wakeUp(std::shared_ptr<Player> player); + bool trySleep(const std::shared_ptr<Player> &player); + bool sleep(const std::shared_ptr<Player> &player); + void wakeUp(const std::shared_ptr<Player> &player); std::shared_ptr<BedItem> getNextBedItem(); friend class MapCache; private: - void updateAppearance(std::shared_ptr<Player> player); - void regeneratePlayer(std::shared_ptr<Player> player) const; - void internalSetSleeper(std::shared_ptr<Player> player); + void updateAppearance(const std::shared_ptr<Player> &player); + void regeneratePlayer(const std::shared_ptr<Player> &player) const; + void internalSetSleeper(const std::shared_ptr<Player> &player); void internalRemoveSleeper(); std::shared_ptr<House> house; - uint64_t sleepStart; - uint32_t sleeperGUID; + uint64_t sleepStart {}; + uint32_t sleeperGUID {}; }; diff --git a/src/items/containers/container.cpp b/src/items/containers/container.cpp index 595ae38dedf..eb6e24c9134 100644 --- a/src/items/containers/container.cpp +++ b/src/items/containers/container.cpp @@ -43,11 +43,11 @@ std::shared_ptr<Container> Container::create(uint16_t type, uint16_t size, bool return std::make_shared<Container>(type, size, unlocked, pagination); } -std::shared_ptr<Container> Container::create(std::shared_ptr<Tile> tile) { +std::shared_ptr<Container> Container::create(const std::shared_ptr<Tile> &tile) { auto container = std::make_shared<Container>(ITEM_BROWSEFIELD, 30, false, true); - TileItemVector* itemVector = tile->getItemList(); + const TileItemVector* itemVector = tile->getItemList(); if (itemVector) { - for (auto &item : *itemVector) { + for (const auto &item : *itemVector) { if (((item->getContainer() || item->hasProperty(CONST_PROP_MOVABLE)) || (item->isWrapable() && !item->hasProperty(CONST_PROP_MOVABLE) && !item->hasProperty(CONST_PROP_BLOCKPATH))) && !item->hasAttribute(ItemAttribute_t::UNIQUEID)) { container->itemlist.push_front(item); item->setParent(container); @@ -81,8 +81,8 @@ Container::~Container() { } std::shared_ptr<Item> Container::clone() const { - std::shared_ptr<Container> clone = std::static_pointer_cast<Container>(Item::clone()); - for (std::shared_ptr<Item> item : itemlist) { + const std::shared_ptr<Container> &clone = std::static_pointer_cast<Container>(Item::clone()); + for (const std::shared_ptr<Item> &item : itemlist) { clone->addItem(item->clone()); } clone->totalWeight = totalWeight; @@ -90,7 +90,7 @@ std::shared_ptr<Item> Container::clone() const { } std::shared_ptr<Container> Container::getParentContainer() { - std::shared_ptr<Thing> thing = getParent(); + const std::shared_ptr<Thing> &thing = getParent(); if (!thing) { return nullptr; } @@ -121,31 +121,31 @@ std::shared_ptr<Container> Container::getRootContainer() { } bool Container::hasParent() { - auto parent = getParent(); + const auto &parent = getParent(); if (!parent) { return false; } - auto creature = parent->getCreature(); - bool isPlayer = creature && creature->getPlayer() != nullptr; + const auto &creature = parent->getCreature(); + const bool &isPlayer = creature && creature->getPlayer() != nullptr; return getID() != ITEM_BROWSEFIELD && !isPlayer; } -void Container::addItem(std::shared_ptr<Item> item) { +void Container::addItem(const std::shared_ptr<Item> &item) { itemlist.push_back(item); item->setParent(getContainer()); } StashContainerList Container::getStowableItems() const { StashContainerList toReturnList; - for (auto item : itemlist) { - if (item->getContainer() != NULL) { - auto subContainer = item->getContainer()->getStowableItems(); - for (auto subContItem : subContainer) { - std::shared_ptr<Item> containerItem = subContItem.first; - toReturnList.push_back(std::pair<std::shared_ptr<Item>, uint32_t>(containerItem, static_cast<uint32_t>(containerItem->getItemCount()))); + for (const auto &item : itemlist) { + if (item->getContainer() != nullptr) { + const auto &subContainer = item->getContainer()->getStowableItems(); + for (const auto &key : subContainer | std::views::keys) { + const auto &containerItem = key; + toReturnList.emplace_back(containerItem, static_cast<uint32_t>(containerItem->getItemCount())); } } else if (item->isItemStorable()) { - toReturnList.push_back(std::pair<std::shared_ptr<Item>, uint32_t>(item, static_cast<uint32_t>(item->getItemCount()))); + toReturnList.emplace_back(item, static_cast<uint32_t>(item->getItemCount())); } } @@ -163,12 +163,12 @@ Attr_ReadValue Container::readAttr(AttrTypes_t attr, PropStream &propStream) { } bool Container::unserializeItemNode(OTB::Loader &loader, const OTB::Node &node, PropStream &propStream, Position &itemPosition) { - bool ret = Item::unserializeItemNode(loader, node, propStream, itemPosition); + const bool ret = Item::unserializeItemNode(loader, node, propStream, itemPosition); if (!ret) { return false; } - for (auto &itemNode : node.children) { + for (const auto &itemNode : node.children) { // load container items if (itemNode.type != OTBM_ITEM) { // unknown type @@ -185,7 +185,7 @@ bool Container::unserializeItemNode(OTB::Loader &loader, const OTB::Node &node, return false; } - std::shared_ptr<Item> item = Item::CreateItem(id, itemPosition); + const auto &item = Item::CreateItem(id, itemPosition); if (!item) { continue; } @@ -200,7 +200,7 @@ bool Container::unserializeItemNode(OTB::Loader &loader, const OTB::Node &node, return true; } -bool Container::countsToLootAnalyzerBalance() { +bool Container::countsToLootAnalyzerBalance() const { if (isCorpse()) { return true; } @@ -232,9 +232,12 @@ std::string Container::getContentDescription(bool oldProtocol) { std::ostringstream &Container::getContentDescription(std::ostringstream &os, bool sendColoredMessage) { bool firstitem = true; for (ContainerIterator it = iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; + const auto &item = *it; + if (!item) { + continue; + } - std::shared_ptr<Container> container = item->getContainer(); + const auto &container = item->getContainer(); if (container && !container->empty()) { continue; } @@ -267,7 +270,7 @@ bool Container::isStoreInbox() const { } bool Container::isStoreInboxFiltered() const { - auto attribute = getAttribute<std::string>(ItemAttribute_t::STORE_INBOX_CATEGORY); + const auto attribute = getAttribute<std::string>(ItemAttribute_t::STORE_INBOX_CATEGORY); if (isStoreInbox() && !attribute.empty() && attribute != "All") { return true; } @@ -279,10 +282,10 @@ std::deque<std::shared_ptr<Item>> Container::getStoreInboxFilteredItems() const const auto enumName = getAttribute<std::string>(ItemAttribute_t::STORE_INBOX_CATEGORY); ItemDeque storeInboxFilteredList; if (isStoreInboxFiltered()) { - for (std::shared_ptr<Item> item : getItemList()) { + for (const std::shared_ptr<Item> &item : getItemList()) { auto itemId = item->getID(); - auto attribute = item->getCustomAttribute("unWrapId"); - uint16_t unWrapId = attribute ? static_cast<uint16_t>(attribute->getInteger()) : 0; + const auto attribute = item->getCustomAttribute("unWrapId"); + const uint16_t unWrapId = attribute ? static_cast<uint16_t>(attribute->getInteger()) : 0; if (unWrapId != 0) { itemId = unWrapId; } @@ -303,8 +306,8 @@ std::vector<ContainerCategory_t> Container::getStoreInboxValidCategories() const stdext::vector_set<ContainerCategory_t> validCategories; for (const auto &item : itemlist) { auto itemId = item->getID(); - auto attribute = item->getCustomAttribute("unWrapId"); - uint16_t unWrapId = attribute ? static_cast<uint16_t>(attribute->getInteger()) : 0; + const auto attribute = item->getCustomAttribute("unWrapId"); + const uint16_t unWrapId = attribute ? static_cast<uint16_t>(attribute->getInteger()) : 0; if (unWrapId != 0) { itemId = unWrapId; } @@ -322,14 +325,14 @@ std::vector<ContainerCategory_t> Container::getStoreInboxValidCategories() const } std::shared_ptr<Item> Container::getFilteredItemByIndex(size_t index) const { - const auto filteredItems = getStoreInboxFilteredItems(); + const auto &filteredItems = getStoreInboxFilteredItems(); if (index >= filteredItems.size()) { return nullptr; } - auto item = filteredItems[index]; + const auto &item = filteredItems[index]; - auto it = std::find(itemlist.begin(), itemlist.end(), item); + const auto it = std::ranges::find(itemlist, item); if (it == itemlist.end()) { return nullptr; } @@ -363,7 +366,7 @@ uint32_t Container::getContainerHoldingCount() { return counter; } -bool Container::isHoldingItem(std::shared_ptr<Item> item) { +bool Container::isHoldingItem(const std::shared_ptr<Item> &item) { for (ContainerIterator it = iterator(); it.hasNext(); it.advance()) { if (*it == item) { return true; @@ -374,8 +377,8 @@ bool Container::isHoldingItem(std::shared_ptr<Item> item) { bool Container::isHoldingItemWithId(const uint16_t id) { for (ContainerIterator it = iterator(); it.hasNext(); it.advance()) { - std::shared_ptr<Item> item = *it; - if (item->getID() == id) { + const auto &item = *it; + if (item && item->getID() == id) { return true; } } @@ -405,8 +408,8 @@ bool Container::isBrowseFieldAndHoldsRewardChest() { return getID() == ITEM_BROWSEFIELD && isHoldingItemWithId(ITEM_REWARD_CHEST); } -void Container::onAddContainerItem(std::shared_ptr<Item> item) { - auto spectators = Spectators().find<Player>(getPosition(), false, 2, 2, 2, 2); +void Container::onAddContainerItem(const std::shared_ptr<Item> &item) { + const auto spectators = Spectators().find<Player>(getPosition(), false, 2, 2, 2, 2); // send to client for (const auto &spectator : spectators) { @@ -419,8 +422,8 @@ void Container::onAddContainerItem(std::shared_ptr<Item> item) { } } -void Container::onUpdateContainerItem(uint32_t index, std::shared_ptr<Item> oldItem, std::shared_ptr<Item> newItem) { - auto spectators = Spectators().find<Player>(getPosition(), false, 2, 2, 2, 2); +void Container::onUpdateContainerItem(uint32_t index, const std::shared_ptr<Item> &oldItem, const std::shared_ptr<Item> &newItem) { + const auto spectators = Spectators().find<Player>(getPosition(), false, 2, 2, 2, 2); // send to client for (const auto &spectator : spectators) { @@ -433,8 +436,8 @@ void Container::onUpdateContainerItem(uint32_t index, std::shared_ptr<Item> oldI } } -void Container::onRemoveContainerItem(uint32_t index, std::shared_ptr<Item> item) { - auto spectators = Spectators().find<Player>(getPosition(), false, 2, 2, 2, 2); +void Container::onRemoveContainerItem(uint32_t index, const std::shared_ptr<Item> &item) { + const auto spectators = Spectators().find<Player>(getPosition(), false, 2, 2, 2, 2); // send change to client for (const auto &spectator : spectators) { @@ -447,8 +450,8 @@ void Container::onRemoveContainerItem(uint32_t index, std::shared_ptr<Item> item } } -ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> &addThing, uint32_t addCount, uint32_t flags, std::shared_ptr<Creature> actor /* = nullptr*/) { - bool childIsOwner = hasBitSet(FLAG_CHILDISOWNER, flags); +ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> &addThing, uint32_t addCount, uint32_t flags, const std::shared_ptr<Creature> &actor /* = nullptr*/) { + const bool childIsOwner = hasBitSet(FLAG_CHILDISOWNER, flags); if (childIsOwner) { // a child container is querying, since we are the top container (not carried by a player) // just return with no error. @@ -459,7 +462,7 @@ ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> & return RETURNVALUE_NOTPOSSIBLE; } - std::shared_ptr<Item> item = addThing->getItem(); + const auto &item = addThing->getItem(); if (item == nullptr) { return RETURNVALUE_NOTPOSSIBLE; } @@ -473,7 +476,7 @@ ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> & } if (item->hasOwner()) { // a non-owner can move the item around but not pick it up - auto toPlayer = getTopParent()->getPlayer(); + const auto &toPlayer = getTopParent()->getPlayer(); if (toPlayer && !item->isOwner(toPlayer)) { return RETURNVALUE_ITEMISNOTYOURS; } @@ -485,16 +488,16 @@ ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> & } std::shared_ptr<Cylinder> cylinder = getParent(); - auto noLimit = hasBitSet(FLAG_NOLIMIT, flags); + const auto noLimit = hasBitSet(FLAG_NOLIMIT, flags); while (cylinder) { if (cylinder == addThing) { return RETURNVALUE_THISISIMPOSSIBLE; } - std::shared_ptr<Container> container = cylinder->getContainer(); + const std::shared_ptr<Container> &container = cylinder->getContainer(); if (!noLimit && container && container->isInbox()) { return RETURNVALUE_CONTAINERNOTENOUGHROOM; } - std::shared_ptr<Cylinder> parent = cylinder->getParent(); + const std::shared_ptr<Cylinder> &parent = cylinder->getParent(); if (cylinder == parent) { g_logger().error("Container::queryAdd: parent == cylinder. Preventing infinite loop."); return RETURNVALUE_NOTPOSSIBLE; @@ -514,7 +517,7 @@ ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> & return RETURNVALUE_CONTAINERISFULL; } - uint32_t addItemCount = addContainer->getItemHoldingCount() + 1; + const uint32_t addItemCount = addContainer->getItemHoldingCount() + 1; if (addItemCount + topParentContainer->getItemHoldingCount() > m_maxItems) { return RETURNVALUE_CONTAINERISFULL; } @@ -529,7 +532,7 @@ ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> & return RETURNVALUE_ONLYAMMOINQUIVER; } - std::shared_ptr<Cylinder> topParent = getTopParent(); + const std::shared_ptr<Cylinder> &topParent = getTopParent(); if (topParent != getContainer()) { return topParent->queryAdd(INDEX_WHEREEVER, item, addCount, flags | FLAG_CHILDISOWNER, actor); } else { @@ -538,7 +541,7 @@ ReturnValue Container::queryAdd(int32_t addIndex, const std::shared_ptr<Thing> & } ReturnValue Container::queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) { - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { maxQueryCount = 0; return RETURNVALUE_NOTPOSSIBLE; @@ -549,7 +552,7 @@ ReturnValue Container::queryMaxCount(int32_t index, const std::shared_ptr<Thing> return RETURNVALUE_NOERROR; } - int32_t freeSlots = std::max<int32_t>(capacity() - size(), 0); + const int32_t freeSlots = std::max<int32_t>(capacity() - size(), 0); if (item->isStackable()) { uint32_t n = 0; @@ -557,16 +560,16 @@ ReturnValue Container::queryMaxCount(int32_t index, const std::shared_ptr<Thing> if (index == INDEX_WHEREEVER) { // Iterate through every item and check how much free stackable slots there is. uint32_t slotIndex = 0; - for (std::shared_ptr<Item> containerItem : itemlist) { + for (const auto &containerItem : itemlist) { if (containerItem != item && containerItem->equals(item) && containerItem->getItemCount() < containerItem->getStackSize()) { - uint32_t remainder = (containerItem->getStackSize() - containerItem->getItemCount()); + const uint32_t remainder = (containerItem->getStackSize() - containerItem->getItemCount()); if (queryAdd(slotIndex++, item, remainder, flags) == RETURNVALUE_NOERROR) { n += remainder; } } } } else { - std::shared_ptr<Item> destItem = getItemByIndex(index); + const auto &destItem = getItemByIndex(index); if (item->equals(destItem) && destItem->getItemCount() < destItem->getStackSize()) { n = destItem->getStackSize() - destItem->getItemCount(); } @@ -586,14 +589,14 @@ ReturnValue Container::queryMaxCount(int32_t index, const std::shared_ptr<Thing> return RETURNVALUE_NOERROR; } -ReturnValue Container::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor /*= nullptr */) { - int32_t index = getThingIndex(thing); +ReturnValue Container::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor /*= nullptr */) { + const int32_t index = getThingIndex(thing); if (index == -1) { g_logger().debug("{} - Failed to get thing index", __FUNCTION__); return RETURNVALUE_NOTPOSSIBLE; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { g_logger().debug("{} - Item is nullptr", __FUNCTION__); return RETURNVALUE_NOTPOSSIBLE; @@ -608,24 +611,24 @@ ReturnValue Container::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t g_logger().debug("{} - Item is not movable", __FUNCTION__); return RETURNVALUE_NOTMOVABLE; } - std::shared_ptr<HouseTile> houseTile = std::dynamic_pointer_cast<HouseTile>(getTopParent()); + const std::shared_ptr<HouseTile> &houseTile = std::dynamic_pointer_cast<HouseTile>(getTopParent()); if (houseTile) { return houseTile->queryRemove(thing, count, flags, actor); } return RETURNVALUE_NOERROR; } -std::shared_ptr<Cylinder> Container::queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) { +std::shared_ptr<Cylinder> Container::queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) { if (!unlocked) { - *destItem = nullptr; + destItem = nullptr; return getContainer(); } if (index == 254 /*move up*/) { index = INDEX_WHEREEVER; - *destItem = nullptr; + destItem = nullptr; - std::shared_ptr<Container> parentContainer = std::dynamic_pointer_cast<Container>(getParent()); + const auto &parentContainer = std::dynamic_pointer_cast<Container>(getParent()); if (parentContainer) { return parentContainer; } @@ -634,7 +637,7 @@ std::shared_ptr<Cylinder> Container::queryDestination(int32_t &index, const std: if (index == 255 /*add wherever*/) { index = INDEX_WHEREEVER; - *destItem = nullptr; + destItem = nullptr; } else if (index >= static_cast<int32_t>(capacity()) && !hasPagination()) { /* if you have a container, maximize it to show all 20 slots @@ -644,39 +647,39 @@ std::shared_ptr<Cylinder> Container::queryDestination(int32_t &index, const std: the client calculates the slot position as if the bag has 20 slots */ index = INDEX_WHEREEVER; - *destItem = nullptr; + destItem = nullptr; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return getContainer(); } if (index != INDEX_WHEREEVER) { - std::shared_ptr<Item> itemFromIndex = getItemByIndex(index); + const auto &itemFromIndex = getItemByIndex(index); if (itemFromIndex) { - *destItem = itemFromIndex; + destItem = itemFromIndex; } - std::shared_ptr<Cylinder> subCylinder = std::dynamic_pointer_cast<Cylinder>(*destItem); + const auto &subCylinder = std::dynamic_pointer_cast<Cylinder>(destItem); if (subCylinder) { index = INDEX_WHEREEVER; - *destItem = nullptr; + destItem = nullptr; return subCylinder; } } - bool autoStack = !hasBitSet(FLAG_IGNOREAUTOSTACK, flags); + const bool autoStack = !hasBitSet(FLAG_IGNOREAUTOSTACK, flags); if (autoStack && item->isStackable() && item->getParent() != getContainer()) { - if (*destItem && (*destItem)->equals(item) && (*destItem)->getItemCount() < (*destItem)->getStackSize()) { + if (destItem && destItem->equals(item) && destItem->getItemCount() < destItem->getStackSize()) { return getContainer(); } // try find a suitable item to stack with uint32_t n = 0; - for (std::shared_ptr<Item> listItem : itemlist) { + for (const auto &listItem : itemlist) { if (listItem != item && listItem->equals(item) && listItem->getItemCount() < listItem->getStackSize()) { - *destItem = listItem; + destItem = listItem; index = n; return getContainer(); } @@ -686,11 +689,11 @@ std::shared_ptr<Cylinder> Container::queryDestination(int32_t &index, const std: return getContainer(); } -void Container::addThing(std::shared_ptr<Thing> thing) { +void Container::addThing(const std::shared_ptr<Thing> &thing) { return addThing(0, thing); } -void Container::addThing(int32_t index, std::shared_ptr<Thing> thing) { +void Container::addThing(int32_t index, const std::shared_ptr<Thing> &thing) { if (!thing) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -699,7 +702,7 @@ void Container::addThing(int32_t index, std::shared_ptr<Thing> thing) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -714,7 +717,7 @@ void Container::addThing(int32_t index, std::shared_ptr<Thing> thing) { } } -void Container::addItemBack(std::shared_ptr<Item> item) { +void Container::addItemBack(const std::shared_ptr<Item> &item) { addItem(item); updateItemWeight(item->getWeight()); @@ -724,13 +727,13 @@ void Container::addItemBack(std::shared_ptr<Item> item) { } } -void Container::updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) { - int32_t index = getThingIndex(thing); +void Container::updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) { + const int32_t index = getThingIndex(thing); if (index == -1) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -746,13 +749,13 @@ void Container::updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint3 } } -void Container::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { - std::shared_ptr<Item> item = thing->getItem(); +void Container::replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) { + const auto &item = thing->getItem(); if (!item) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> replacedItem = getItemByIndex(index); + const auto &replacedItem = getItemByIndex(index); if (!replacedItem) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -769,19 +772,19 @@ void Container::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { replacedItem->resetParent(); } -void Container::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { - std::shared_ptr<Item> item = thing->getItem(); +void Container::removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) { + const auto &item = thing->getItem(); if (item == nullptr) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - int32_t index = getThingIndex(thing); + const int32_t index = getThingIndex(thing); if (index == -1) { return /*RETURNVALUE_NOTPOSSIBLE*/; } if (item->isStackable() && count != item->getItemCount()) { - uint8_t newCount = static_cast<uint8_t>(std::max<int32_t>(0, item->getItemCount() - count)); + const auto newCount = static_cast<uint8_t>(std::max<int32_t>(0, item->getItemCount() - count)); const int32_t oldWeight = item->getWeight(); item->setItemCount(newCount); updateItemWeight(-oldWeight + item->getWeight()); @@ -803,9 +806,9 @@ void Container::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { } } -int32_t Container::getThingIndex(std::shared_ptr<Thing> thing) const { +int32_t Container::getThingIndex(const std::shared_ptr<Thing> &thing) const { int32_t index = 0; - for (std::shared_ptr<Item> item : itemlist) { + for (const std::shared_ptr<Item> &item : itemlist) { if (item == thing) { return index; } @@ -824,7 +827,7 @@ size_t Container::getLastIndex() const { uint32_t Container::getItemTypeCount(uint16_t itemId, int32_t subType /* = -1*/) const { uint32_t count = 0; - for (std::shared_ptr<Item> item : itemlist) { + for (const std::shared_ptr<Item> &item : itemlist) { if (item->getID() == itemId) { count += countByType(item, subType); } @@ -833,7 +836,7 @@ uint32_t Container::getItemTypeCount(uint16_t itemId, int32_t subType /* = -1*/) } std::map<uint32_t, uint32_t> &Container::getAllItemTypeCount(std::map<uint32_t, uint32_t> &countMap) const { - for (std::shared_ptr<Item> item : itemlist) { + for (const std::shared_ptr<Item> &item : itemlist) { countMap[item->getID()] += item->getItemCount(); } return countMap; @@ -850,15 +853,15 @@ ItemVector Container::getItems(bool recursive /*= false*/) { containerItems.push_back(*it); } } else { - for (std::shared_ptr<Item> item : itemlist) { + for (const std::shared_ptr<Item> &item : itemlist) { containerItems.push_back(item); } } return containerItems; } -void Container::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> topParent = getTopParent(); +void Container::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &topParent = getTopParent(); if (topParent->getCreature()) { topParent->postAddNotification(thing, oldParent, index, LINK_TOPPARENT); } else if (topParent == getContainer()) { @@ -871,8 +874,8 @@ void Container::postAddNotification(std::shared_ptr<Thing> thing, std::shared_pt } } -void Container::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> topParent = getTopParent(); +void Container::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &topParent = getTopParent(); if (topParent->getCreature()) { topParent->postRemoveNotification(thing, newParent, index, LINK_TOPPARENT); } else if (topParent == getContainer()) { @@ -885,16 +888,16 @@ void Container::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared } } -void Container::internalAddThing(std::shared_ptr<Thing> thing) { +void Container::internalAddThing(const std::shared_ptr<Thing> &thing) { internalAddThing(0, thing); } -void Container::internalAddThing(uint32_t, std::shared_ptr<Thing> thing) { +void Container::internalAddThing(uint32_t, const std::shared_ptr<Thing> &thing) { if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return; } @@ -904,11 +907,11 @@ void Container::internalAddThing(uint32_t, std::shared_ptr<Thing> thing) { updateItemWeight(item->getWeight()); } -uint16_t Container::getFreeSlots() { +uint16_t Container::getFreeSlots() const { uint16_t counter = std::max<uint16_t>(0, capacity() - size()); - for (std::shared_ptr<Item> item : itemlist) { - if (std::shared_ptr<Container> container = item->getContainer()) { + for (const auto &item : itemlist) { + if (const auto &container = item->getContainer()) { counter += std::max<uint16_t>(0, container->getFreeSlots()); } } @@ -920,20 +923,20 @@ ContainerIterator Container::iterator() { return { getContainer(), static_cast<size_t>(g_configManager().getNumber(MAX_CONTAINER_DEPTH)) }; } -void Container::removeItem(std::shared_ptr<Thing> thing, bool sendUpdateToClient /* = false*/) { +void Container::removeItem(const std::shared_ptr<Thing> &thing, bool sendUpdateToClient /* = false*/) { if (thing == nullptr) { return; } - auto itemToRemove = thing->getItem(); + const auto &itemToRemove = thing->getItem(); if (itemToRemove == nullptr) { return; } - auto it = std::ranges::find(itemlist.begin(), itemlist.end(), itemToRemove); + const auto it = std::ranges::find(itemlist.begin(), itemlist.end(), itemToRemove); if (it != itemlist.end()) { // Send change to client - if (auto thingIndex = getThingIndex(thing); sendUpdateToClient && thingIndex != -1 && getParent()) { + if (const auto thingIndex = getThingIndex(thing); sendUpdateToClient && thingIndex != -1 && getParent()) { onRemoveContainerItem(thingIndex, itemToRemove); } diff --git a/src/items/containers/container.hpp b/src/items/containers/container.hpp index e07b2edff3a..b9840a0b0b5 100644 --- a/src/items/containers/container.hpp +++ b/src/items/containers/container.hpp @@ -134,27 +134,27 @@ class Container : public Item, public Cylinder { public: explicit Container(uint16_t type); Container(uint16_t type, uint16_t size, bool unlocked = true, bool pagination = false); - ~Container(); + ~Container() override; static std::shared_ptr<Container> create(uint16_t type); static std::shared_ptr<Container> create(uint16_t type, uint16_t size, bool unlocked = true, bool pagination = false); - static std::shared_ptr<Container> create(std::shared_ptr<Tile> type); + static std::shared_ptr<Container> create(const std::shared_ptr<Tile> &type); // non-copyable Container(const Container &) = delete; Container &operator=(const Container &) = delete; - std::shared_ptr<Item> clone() const override final; + std::shared_ptr<Item> clone() const final; - std::shared_ptr<Container> getContainer() override final { + std::shared_ptr<Container> getContainer() final { return static_self_cast<Container>(); } - std::shared_ptr<const Container> getContainer() const override final { + std::shared_ptr<const Container> getContainer() const final { return static_self_cast<Container>(); } - std::shared_ptr<Cylinder> getCylinder() override final { + std::shared_ptr<Cylinder> getCylinder() final { return getContainer(); } @@ -207,9 +207,9 @@ class Container : public Item, public Cylinder { return itemlist.rend(); } - bool countsToLootAnalyzerBalance(); + bool countsToLootAnalyzerBalance() const; bool hasParent(); - void addItem(std::shared_ptr<Item> item); + void addItem(const std::shared_ptr<Item> &item); StashContainerList getStowableItems() const; bool isStoreInbox() const; bool isStoreInboxFiltered() const; @@ -217,13 +217,13 @@ class Container : public Item, public Cylinder { std::vector<ContainerCategory_t> getStoreInboxValidCategories() const; std::shared_ptr<Item> getFilteredItemByIndex(size_t index) const; std::shared_ptr<Item> getItemByIndex(size_t index) const; - bool isHoldingItem(std::shared_ptr<Item> item); - bool isHoldingItemWithId(const uint16_t id); + bool isHoldingItem(const std::shared_ptr<Item> &item); + bool isHoldingItemWithId(uint16_t id); uint32_t getItemHoldingCount(); uint32_t getContainerHoldingCount(); - uint16_t getFreeSlots(); - uint32_t getWeight() const override final; + uint16_t getFreeSlots() const; + uint32_t getWeight() const final; bool isUnlocked() const { return !this->isCorpse() && unlocked; @@ -233,62 +233,62 @@ class Container : public Item, public Cylinder { } // cylinder implementations - virtual ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; - ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) override final; - ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override final; - std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) override final; + virtual ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; + ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) final; + ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; + std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) final; - void addThing(std::shared_ptr<Thing> thing) override final; - void addThing(int32_t index, std::shared_ptr<Thing> thing) override final; - void addItemBack(std::shared_ptr<Item> item); + void addThing(const std::shared_ptr<Thing> &thing) final; + void addThing(int32_t index, const std::shared_ptr<Thing> &thing) final; + void addItemBack(const std::shared_ptr<Item> &item); - void updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) override final; - void replaceThing(uint32_t index, std::shared_ptr<Thing> thing) override final; + void updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) final; + void replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) final; - void removeThing(std::shared_ptr<Thing> thing, uint32_t count) override final; + void removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) final; - int32_t getThingIndex(std::shared_ptr<Thing> thing) const override final; - size_t getFirstIndex() const override final; - size_t getLastIndex() const override final; - uint32_t getItemTypeCount(uint16_t itemId, int32_t subType = -1) const override final; - std::map<uint32_t, uint32_t> &getAllItemTypeCount(std::map<uint32_t, uint32_t> &countMap) const override final; - std::shared_ptr<Thing> getThing(size_t index) const override final; + int32_t getThingIndex(const std::shared_ptr<Thing> &thing) const final; + size_t getFirstIndex() const final; + size_t getLastIndex() const final; + uint32_t getItemTypeCount(uint16_t itemId, int32_t subType = -1) const final; + std::map<uint32_t, uint32_t> &getAllItemTypeCount(std::map<uint32_t, uint32_t> &countMap) const final; + std::shared_ptr<Thing> getThing(size_t index) const final; ItemVector getItems(bool recursive = false); - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void internalAddThing(std::shared_ptr<Thing> thing) override final; - void internalAddThing(uint32_t index, std::shared_ptr<Thing> thing) override final; + void internalAddThing(const std::shared_ptr<Thing> &thing) final; + void internalAddThing(uint32_t index, const std::shared_ptr<Thing> &thing) final; - virtual void removeItem(std::shared_ptr<Thing> thing, bool sendUpdateToClient = false); + virtual void removeItem(const std::shared_ptr<Thing> &thing, bool sendUpdateToClient = false); - uint32_t getOwnerId() const override final; + uint32_t getOwnerId() const final; bool isAnyKindOfRewardChest(); bool isAnyKindOfRewardContainer(); bool isBrowseFieldAndHoldsRewardChest(); - bool isInsideContainerWithId(const uint16_t id); + bool isInsideContainerWithId(uint16_t id); protected: std::ostringstream &getContentDescription(std::ostringstream &os, bool oldProtocol); - uint32_t m_maxItems; - uint32_t maxSize; - uint32_t totalWeight = 0; + uint32_t m_maxItems {}; + uint32_t maxSize {}; + uint32_t totalWeight {}; ItemDeque itemlist; - uint32_t serializationCount = 0; + uint32_t serializationCount = {}; - bool unlocked; - bool pagination; + bool unlocked {}; + bool pagination {}; friend class MapCache; private: - void onAddContainerItem(std::shared_ptr<Item> item); - void onUpdateContainerItem(uint32_t index, std::shared_ptr<Item> oldItem, std::shared_ptr<Item> newItem); - void onRemoveContainerItem(uint32_t index, std::shared_ptr<Item> item); + void onAddContainerItem(const std::shared_ptr<Item> &item); + void onUpdateContainerItem(uint32_t index, const std::shared_ptr<Item> &oldItem, const std::shared_ptr<Item> &newItem); + void onRemoveContainerItem(uint32_t index, const std::shared_ptr<Item> &item); std::shared_ptr<Container> getParentContainer(); std::shared_ptr<Container> getTopParentContainer(); diff --git a/src/items/containers/depot/depotchest.cpp b/src/items/containers/depot/depotchest.cpp index 2c7d21ed199..b4372840eeb 100644 --- a/src/items/containers/depot/depotchest.cpp +++ b/src/items/containers/depot/depotchest.cpp @@ -17,8 +17,8 @@ DepotChest::DepotChest(uint16_t type) : pagination = true; } -ReturnValue DepotChest::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor /* = nullptr*/) { - std::shared_ptr<Item> item = thing->getItem(); +ReturnValue DepotChest::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor /* = nullptr*/) { + const auto &item = thing->getItem(); if (item == nullptr) { return RETURNVALUE_NOTPOSSIBLE; } @@ -26,7 +26,7 @@ ReturnValue DepotChest::queryAdd(int32_t index, const std::shared_ptr<Thing> &th return RETURNVALUE_ITEMISNOTYOURS; } - bool skipLimit = hasBitSet(FLAG_NOLIMIT, flags); + const bool skipLimit = hasBitSet(FLAG_NOLIMIT, flags); if (!skipLimit) { int32_t addCount = 0; @@ -35,14 +35,14 @@ ReturnValue DepotChest::queryAdd(int32_t index, const std::shared_ptr<Thing> &th } if (item->getTopParent().get() != this) { - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const std::shared_ptr<Container> &container = item->getContainer()) { addCount = container->getItemHoldingCount() + 1; } else { addCount = 1; } } - if (std::shared_ptr<Cylinder> localParent = getRealParent()) { + if (const std::shared_ptr<Cylinder> &localParent = getRealParent()) { if (localParent->getContainer()->getItemHoldingCount() + addCount > maxDepotItems) { return RETURNVALUE_DEPOTISFULL; } @@ -54,22 +54,22 @@ ReturnValue DepotChest::queryAdd(int32_t index, const std::shared_ptr<Thing> &th return Container::queryAdd(index, thing, count, flags, actor); } -void DepotChest::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> localParent = getParent(); +void DepotChest::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &localParent = getParent(); if (localParent != nullptr) { localParent->postAddNotification(thing, oldParent, index, LINK_PARENT); } } -void DepotChest::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> localParent = getParent(); +void DepotChest::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &localParent = getParent(); if (localParent != nullptr) { localParent->postRemoveNotification(thing, newParent, index, LINK_PARENT); } } std::shared_ptr<Cylinder> DepotChest::getParent() { - auto parentLocked = m_parent.lock(); + const auto &parentLocked = m_parent.lock(); if (parentLocked && parentLocked->getParent()) { return parentLocked->getParent()->getParent(); } diff --git a/src/items/containers/depot/depotchest.hpp b/src/items/containers/depot/depotchest.hpp index 6b64ca2b897..7b357540d8a 100644 --- a/src/items/containers/depot/depotchest.hpp +++ b/src/items/containers/depot/depotchest.hpp @@ -21,10 +21,10 @@ class DepotChest final : public Container { } // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; bool isDepotChest() const override { return true; diff --git a/src/items/containers/depot/depotlocker.cpp b/src/items/containers/depot/depotlocker.cpp index c7320293efd..c5da2beaad6 100644 --- a/src/items/containers/depot/depotlocker.cpp +++ b/src/items/containers/depot/depotlocker.cpp @@ -22,26 +22,26 @@ Attr_ReadValue DepotLocker::readAttr(AttrTypes_t attr, PropStream &propStream) { return Item::readAttr(attr, propStream); } -ReturnValue DepotLocker::queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature>) { +ReturnValue DepotLocker::queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> &) { return RETURNVALUE_NOTENOUGHROOM; } -void DepotLocker::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { - auto parentLocked = m_parent.lock(); +void DepotLocker::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { + const auto &parentLocked = m_parent.lock(); if (parentLocked) { parentLocked->postAddNotification(thing, oldParent, index, LINK_PARENT); } } -void DepotLocker::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { - auto parentLocked = m_parent.lock(); +void DepotLocker::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { + const auto &parentLocked = m_parent.lock(); if (parentLocked) { parentLocked->postRemoveNotification(thing, newParent, index, LINK_PARENT); } } -void DepotLocker::removeInbox(std::shared_ptr<Inbox> inbox) { - auto cit = std::find(itemlist.begin(), itemlist.end(), inbox); +void DepotLocker::removeInbox(const std::shared_ptr<Inbox> &inbox) { + const auto cit = std::ranges::find(itemlist, inbox); if (cit == itemlist.end()) { return; } diff --git a/src/items/containers/depot/depotlocker.hpp b/src/items/containers/depot/depotlocker.hpp index 09d794c444f..a4b2a3f48bf 100644 --- a/src/items/containers/depot/depotlocker.hpp +++ b/src/items/containers/depot/depotlocker.hpp @@ -20,7 +20,7 @@ class DepotLocker final : public Container { return static_self_cast<DepotLocker>(); } - void removeInbox(std::shared_ptr<Inbox> inbox); + void removeInbox(const std::shared_ptr<Inbox> &inbox); // serialization Attr_ReadValue readAttr(AttrTypes_t attr, PropStream &propStream) override; @@ -33,10 +33,10 @@ class DepotLocker final : public Container { } // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; bool canRemove() const override { return false; diff --git a/src/items/containers/inbox/inbox.cpp b/src/items/containers/inbox/inbox.cpp index 220f119645f..8d4ae9b9ca7 100644 --- a/src/items/containers/inbox/inbox.cpp +++ b/src/items/containers/inbox/inbox.cpp @@ -15,14 +15,14 @@ Inbox::Inbox(uint16_t type) : maxInboxItems = std::numeric_limits<uint16_t>::max(); } -ReturnValue Inbox::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t flags, std::shared_ptr<Creature>) { +ReturnValue Inbox::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t flags, const std::shared_ptr<Creature> &) { int32_t addCount = 0; if (!hasBitSet(FLAG_NOLIMIT, flags)) { return RETURNVALUE_CONTAINERNOTENOUGHROOM; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return RETURNVALUE_NOTPOSSIBLE; } @@ -36,7 +36,7 @@ ReturnValue Inbox::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32 } if (item->getTopParent().get() != this) { // MY - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const std::shared_ptr<Container> &container = item->getContainer()) { addCount = container->getItemHoldingCount() + 1; } else { addCount = 1; @@ -50,22 +50,22 @@ ReturnValue Inbox::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32 return RETURNVALUE_NOERROR; } -void Inbox::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> localParent = getParent(); +void Inbox::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &localParent = getParent(); if (localParent != nullptr) { localParent->postAddNotification(thing, oldParent, index, LINK_PARENT); } } -void Inbox::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> localParent = getParent(); +void Inbox::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &localParent = getParent(); if (localParent != nullptr) { localParent->postRemoveNotification(thing, newParent, index, LINK_PARENT); } } std::shared_ptr<Cylinder> Inbox::getParent() { - auto parentLocked = m_parent.lock(); + const auto &parentLocked = m_parent.lock(); if (parentLocked) { return parentLocked->getParent(); } diff --git a/src/items/containers/inbox/inbox.hpp b/src/items/containers/inbox/inbox.hpp index 79eb126edc8..731920f1ded 100644 --- a/src/items/containers/inbox/inbox.hpp +++ b/src/items/containers/inbox/inbox.hpp @@ -20,10 +20,10 @@ class Inbox final : public Container { } // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; bool isInbox() const override { return true; diff --git a/src/items/containers/mailbox/mailbox.cpp b/src/items/containers/mailbox/mailbox.cpp index c558b85e30d..4bba415ada0 100644 --- a/src/items/containers/mailbox/mailbox.cpp +++ b/src/items/containers/mailbox/mailbox.cpp @@ -13,8 +13,8 @@ #include "game/scheduling/save_manager.hpp" #include "map/spectators.hpp" -ReturnValue Mailbox::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t, std::shared_ptr<Creature>) { - std::shared_ptr<Item> item = thing->getItem(); +ReturnValue Mailbox::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t, const std::shared_ptr<Creature> &) { + const auto &item = thing->getItem(); if (item && Mailbox::canSend(item)) { return RETURNVALUE_NOERROR; } @@ -26,50 +26,50 @@ ReturnValue Mailbox::queryMaxCount(int32_t, const std::shared_ptr<Thing> &, uint return RETURNVALUE_NOERROR; } -ReturnValue Mailbox::queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature> /*= nullptr */) { +ReturnValue Mailbox::queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> & /*= nullptr */) { return RETURNVALUE_NOTPOSSIBLE; } -std::shared_ptr<Cylinder> Mailbox::queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item>*, uint32_t &) { +std::shared_ptr<Cylinder> Mailbox::queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item> &, uint32_t &) { return getMailbox(); } -void Mailbox::addThing(std::shared_ptr<Thing> thing) { +void Mailbox::addThing(const std::shared_ptr<Thing> &thing) { return addThing(0, thing); } -void Mailbox::addThing(int32_t, std::shared_ptr<Thing> thing) { +void Mailbox::addThing(int32_t, const std::shared_ptr<Thing> &thing) { if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item && Mailbox::canSend(item)) { sendItem(item); } } -void Mailbox::updateThing(std::shared_ptr<Thing>, uint16_t, uint32_t) { +void Mailbox::updateThing(const std::shared_ptr<Thing> &, uint16_t, uint32_t) { // } -void Mailbox::replaceThing(uint32_t, std::shared_ptr<Thing>) { +void Mailbox::replaceThing(uint32_t, const std::shared_ptr<Thing> &) { // } -void Mailbox::removeThing(std::shared_ptr<Thing>, uint32_t) { +void Mailbox::removeThing(const std::shared_ptr<Thing> &, uint32_t) { // } -void Mailbox::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { +void Mailbox::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { getParent()->postAddNotification(thing, oldParent, index, LINK_PARENT); } -void Mailbox::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { +void Mailbox::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { getParent()->postRemoveNotification(thing, newParent, index, LINK_PARENT); } -bool Mailbox::sendItem(std::shared_ptr<Item> item) const { +bool Mailbox::sendItem(const std::shared_ptr<Item> &item) const { std::string receiver; if (!getReceiver(item, receiver)) { return false; @@ -86,9 +86,9 @@ bool Mailbox::sendItem(std::shared_ptr<Item> item) const { } } - std::shared_ptr<Player> player = g_game().getPlayerByName(receiver, true); + const auto &player = g_game().getPlayerByName(receiver, true); std::string writer; - time_t date = time(0); + time_t date = getTimeNow(); std::string text; if (item && item->getID() == ITEM_LETTER && !item->getAttribute<std::string>(ItemAttribute_t::WRITER).empty()) { writer = item->getAttribute<std::string>(ItemAttribute_t::WRITER); @@ -97,8 +97,8 @@ bool Mailbox::sendItem(std::shared_ptr<Item> item) const { } if (player && item) { if (g_game().internalMoveItem(item->getParent(), player->getInbox(), INDEX_WHEREEVER, item, item->getItemCount(), nullptr, FLAG_NOLIMIT) == RETURNVALUE_NOERROR) { - auto newItem = g_game().transformItem(item, item->getID() + 1); - if (newItem && newItem->getID() == ITEM_LETTER_STAMPED && writer != "") { + const auto &newItem = g_game().transformItem(item, item->getID() + 1); + if (newItem && newItem->getID() == ITEM_LETTER_STAMPED && !writer.empty()) { newItem->setAttribute(ItemAttribute_t::WRITER, writer); newItem->setAttribute(ItemAttribute_t::DATE, date); newItem->setAttribute(ItemAttribute_t::TEXT, text); @@ -114,10 +114,10 @@ bool Mailbox::sendItem(std::shared_ptr<Item> item) const { return false; } -bool Mailbox::getReceiver(std::shared_ptr<Item> item, std::string &name) const { - std::shared_ptr<Container> container = item->getContainer(); +bool Mailbox::getReceiver(const std::shared_ptr<Item> &item, std::string &name) const { + const std::shared_ptr<Container> &container = item->getContainer(); if (container) { - for (std::shared_ptr<Item> containerItem : container->getItemList()) { + for (const std::shared_ptr<Item> &containerItem : container->getItemList()) { if (containerItem->getID() == ITEM_LABEL && getReceiver(containerItem, name)) { return true; } @@ -135,6 +135,6 @@ bool Mailbox::getReceiver(std::shared_ptr<Item> item, std::string &name) const { return true; } -bool Mailbox::canSend(std::shared_ptr<Item> item) { +bool Mailbox::canSend(const std::shared_ptr<Item> &item) { return !item->hasOwner() && (item->getID() == ITEM_PARCEL || item->getID() == ITEM_LETTER); } diff --git a/src/items/containers/mailbox/mailbox.hpp b/src/items/containers/mailbox/mailbox.hpp index 116cd0ee1c4..8891c00339e 100644 --- a/src/items/containers/mailbox/mailbox.hpp +++ b/src/items/containers/mailbox/mailbox.hpp @@ -21,30 +21,30 @@ class Mailbox final : public Item, public Cylinder { return static_self_cast<Mailbox>(); } - std::shared_ptr<Cylinder> getCylinder() override final { + std::shared_ptr<Cylinder> getCylinder() override { return getMailbox(); } // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) override; - ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; - std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) override; + ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; + std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) override; - void addThing(std::shared_ptr<Thing> thing) override; - void addThing(int32_t index, std::shared_ptr<Thing> thing) override; + void addThing(const std::shared_ptr<Thing> &thing) override; + void addThing(int32_t index, const std::shared_ptr<Thing> &thing) override; - void updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) override; - void replaceThing(uint32_t index, std::shared_ptr<Thing> thing) override; + void updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) override; + void replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) override; - void removeThing(std::shared_ptr<Thing> thing, uint32_t count) override; + void removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; private: - bool getReceiver(std::shared_ptr<Item> item, std::string &name) const; - bool sendItem(std::shared_ptr<Item> item) const; + bool getReceiver(const std::shared_ptr<Item> &item, std::string &name) const; + bool sendItem(const std::shared_ptr<Item> &item) const; - static bool canSend(std::shared_ptr<Item> item); + static bool canSend(const std::shared_ptr<Item> &item); }; diff --git a/src/items/containers/rewards/reward.cpp b/src/items/containers/rewards/reward.cpp index 6a8374e8060..f3e4313542d 100644 --- a/src/items/containers/rewards/reward.cpp +++ b/src/items/containers/rewards/reward.cpp @@ -16,12 +16,12 @@ Reward::Reward() : pagination = true; } -ReturnValue Reward::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t, std::shared_ptr<Creature> actor /* = nullptr*/) { - if (actor) { +ReturnValue Reward::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t, const std::shared_ptr<Creature> &actor /* = nullptr*/) { + if (actor || !thing) { return RETURNVALUE_NOTPOSSIBLE; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return RETURNVALUE_NOTPOSSIBLE; } @@ -37,15 +37,15 @@ ReturnValue Reward::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint3 return RETURNVALUE_NOERROR; } -void Reward::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> localParent = getParent(); +void Reward::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &localParent = getParent(); if (localParent != nullptr) { localParent->postAddNotification(thing, oldParent, index, LINK_PARENT); } } -void Reward::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { - std::shared_ptr<Cylinder> localParent = getParent(); +void Reward::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { + const std::shared_ptr<Cylinder> &localParent = getParent(); if (localParent != nullptr) { localParent->postRemoveNotification(thing, newParent, index, LINK_PARENT); } diff --git a/src/items/containers/rewards/reward.hpp b/src/items/containers/rewards/reward.hpp index 1ab3c8f9b70..afdcd1c0d5f 100644 --- a/src/items/containers/rewards/reward.hpp +++ b/src/items/containers/rewards/reward.hpp @@ -11,27 +11,27 @@ #include "items/containers/container.hpp" -class Reward : public Container { +class Reward final : public Container { public: explicit Reward(); - std::shared_ptr<Reward> getReward() final { + std::shared_ptr<Reward> getReward() override { return static_self_cast<Reward>(); } // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) final; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) final; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) final; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; // overrides - bool canRemove() const final { + bool canRemove() const override { return true; } - std::shared_ptr<Cylinder> getParent() final; - std::shared_ptr<Cylinder> getRealParent() final { + std::shared_ptr<Cylinder> getParent() override; + std::shared_ptr<Cylinder> getRealParent() override { return m_parent.lock(); } }; diff --git a/src/items/containers/rewards/rewardchest.cpp b/src/items/containers/rewards/rewardchest.cpp index 96cf9c2edcc..32019b0ce75 100644 --- a/src/items/containers/rewards/rewardchest.cpp +++ b/src/items/containers/rewards/rewardchest.cpp @@ -16,7 +16,7 @@ RewardChest::RewardChest(uint16_t type) : pagination = true; } -ReturnValue RewardChest::queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature> actor /* = nullptr*/) { +ReturnValue RewardChest::queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> &actor /* = nullptr*/) { if (actor) { return RETURNVALUE_NOTPOSSIBLE; } @@ -24,32 +24,32 @@ ReturnValue RewardChest::queryAdd(int32_t, const std::shared_ptr<Thing> &, uint3 return RETURNVALUE_NOERROR; } -void RewardChest::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { - auto parentLocked = m_parent.lock(); +void RewardChest::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { + const auto &parentLocked = m_parent.lock(); if (parentLocked) { parentLocked->postAddNotification(thing, oldParent, index, LINK_PARENT); } } -void RewardChest::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { - auto parentLocked = m_parent.lock(); +void RewardChest::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { + const auto &parentLocked = m_parent.lock(); if (parentLocked) { parentLocked->postRemoveNotification(thing, newParent, index, LINK_PARENT); } } // Second argument is disabled by default because not need to send to client in the RewardChest -void RewardChest::removeItem(std::shared_ptr<Thing> thing, bool /* sendToClient = false*/) { +void RewardChest::removeItem(const std::shared_ptr<Thing> &thing, bool /* sendToClient = false*/) { if (thing == nullptr) { return; } - auto itemToRemove = thing->getItem(); + const auto &itemToRemove = thing->getItem(); if (itemToRemove == nullptr) { return; } - auto it = std::ranges::find(itemlist.begin(), itemlist.end(), itemToRemove); + const auto it = std::ranges::find(itemlist.begin(), itemlist.end(), itemToRemove); if (it != itemlist.end()) { itemlist.erase(it); itemToRemove->resetParent(); diff --git a/src/items/containers/rewards/rewardchest.hpp b/src/items/containers/rewards/rewardchest.hpp index 2960128eb75..6c66865699b 100644 --- a/src/items/containers/rewards/rewardchest.hpp +++ b/src/items/containers/rewards/rewardchest.hpp @@ -15,19 +15,19 @@ class RewardChest final : public Container { public: explicit RewardChest(uint16_t type); - std::shared_ptr<RewardChest> getRewardChest() final { + std::shared_ptr<RewardChest> getRewardChest() override { return static_self_cast<RewardChest>(); } // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) final; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) final; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) final; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - bool canRemove() const final { + bool canRemove() const override { return false; } - void removeItem(std::shared_ptr<Thing> thing, bool sendToClient = false) override; + void removeItem(const std::shared_ptr<Thing> &thing, bool sendToClient = false) override; }; diff --git a/src/items/cylinder.cpp b/src/items/cylinder.cpp index fa61eab2fcb..4a4acbdf108 100644 --- a/src/items/cylinder.cpp +++ b/src/items/cylinder.cpp @@ -11,7 +11,7 @@ std::shared_ptr<VirtualCylinder> VirtualCylinder::virtualCylinder = std::make_shared<VirtualCylinder>(); -int32_t Cylinder::getThingIndex(std::shared_ptr<Thing>) const { +int32_t Cylinder::getThingIndex(const std::shared_ptr<Thing> &) const { return -1; } @@ -35,11 +35,11 @@ std::shared_ptr<Thing> Cylinder::getThing(size_t) const { return nullptr; } -void Cylinder::internalAddThing(std::shared_ptr<Thing>) { +void Cylinder::internalAddThing(const std::shared_ptr<Thing> &) { // } -void Cylinder::internalAddThing(uint32_t, std::shared_ptr<Thing>) { +void Cylinder::internalAddThing(uint32_t, const std::shared_ptr<Thing> &) { // } diff --git a/src/items/cylinder.hpp b/src/items/cylinder.hpp index f6c149dd589..4a0246b81f4 100644 --- a/src/items/cylinder.hpp +++ b/src/items/cylinder.hpp @@ -30,7 +30,7 @@ class Cylinder : virtual public Thing { * \param actor the creature trying to add the thing * \returns ReturnValue holds the return value */ - virtual ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) = 0; + virtual ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) = 0; /** * Query the cylinder how much it can accept @@ -51,7 +51,7 @@ class Cylinder : virtual public Thing { * \param flags optional flags to modify the default behaviour * \returns ReturnValue holds the return value */ - virtual ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> = nullptr) = 0; + virtual ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) = 0; /** * Query the destination cylinder @@ -63,20 +63,20 @@ class Cylinder : virtual public Thing { * this method can modify the flags * \returns Cylinder returns the destination cylinder */ - virtual std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) = 0; + virtual std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) = 0; /** * Add the object to the cylinder * \param thing is the object to add */ - virtual void addThing(std::shared_ptr<Thing> thing) = 0; + virtual void addThing(const std::shared_ptr<Thing> &thing) = 0; /** * Add the object to the cylinder * \param index points to the destination index (inventory slot/container position) * \param thing is the object to add */ - virtual void addThing(int32_t index, std::shared_ptr<Thing> thing) = 0; + virtual void addThing(int32_t index, const std::shared_ptr<Thing> &thing) = 0; /** * Update the item count or type for an object @@ -84,21 +84,21 @@ class Cylinder : virtual public Thing { * \param itemId is the new item id * \param count is the new count value */ - virtual void updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) = 0; + virtual void updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) = 0; /** * Replace an object with a new * \param index is the position to change (inventory slot/container position) * \param thing is the object to update */ - virtual void replaceThing(uint32_t index, std::shared_ptr<Thing> thing) = 0; + virtual void replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) = 0; /** * Remove an object * \param thing is the object to delete * \param count is the new count value */ - virtual void removeThing(std::shared_ptr<Thing> thing, uint32_t count) = 0; + virtual void removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) = 0; /** * Is sent after an operation (move/add) to update internal values @@ -106,7 +106,7 @@ class Cylinder : virtual public Thing { * \param index is the objects new index value * \param link holds the relation the object has to the cylinder */ - virtual void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) = 0; + virtual void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, const CylinderLink_t link = LINK_OWNER) = 0; /** * Is sent after an operation (move/remove) to update internal values @@ -114,14 +114,14 @@ class Cylinder : virtual public Thing { * \param index is the previous index of the removed object * \param link holds the relation the object has to the cylinder */ - virtual void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) = 0; + virtual void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) = 0; /** * Gets the index of an object * \param thing the object to get the index value from * \returns the index of the object, returns -1 if not found */ - virtual int32_t getThingIndex(std::shared_ptr<Thing> thing) const; + virtual int32_t getThingIndex(const std::shared_ptr<Thing> &thing) const; /** * Returns the first index @@ -160,14 +160,14 @@ class Cylinder : virtual public Thing { * Adds an object to the cylinder without sending to the client(s) * \param thing is the object to add */ - virtual void internalAddThing(std::shared_ptr<Thing> thing); + virtual void internalAddThing(const std::shared_ptr<Thing> &thing); /** * Adds an object to the cylinder without sending to the client(s) * \param thing is the object to add * \param index points to the destination index (inventory slot/container position) */ - virtual void internalAddThing(uint32_t index, std::shared_ptr<Thing> thing); + virtual void internalAddThing(uint32_t index, const std::shared_ptr<Thing> &thing); virtual void startDecaying(); }; @@ -176,27 +176,27 @@ class VirtualCylinder final : public Cylinder { public: static std::shared_ptr<VirtualCylinder> virtualCylinder; - virtual ReturnValue queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature> = nullptr) override { + virtual ReturnValue queryAdd(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> & = nullptr) override { return RETURNVALUE_NOTPOSSIBLE; } virtual ReturnValue queryMaxCount(int32_t, const std::shared_ptr<Thing> &, uint32_t, uint32_t &, uint32_t) override { return RETURNVALUE_NOTPOSSIBLE; } - virtual ReturnValue queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature> = nullptr) override { + virtual ReturnValue queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> &actor = nullptr) override { return RETURNVALUE_NOTPOSSIBLE; } - virtual std::shared_ptr<Cylinder> queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item>*, uint32_t &) override { + virtual std::shared_ptr<Cylinder> queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item> &, uint32_t &) override { return nullptr; } - virtual void addThing(std::shared_ptr<Thing>) override { } - virtual void addThing(int32_t, std::shared_ptr<Thing>) override { } - virtual void updateThing(std::shared_ptr<Thing>, uint16_t, uint32_t) override { } - virtual void replaceThing(uint32_t, std::shared_ptr<Thing>) override { } - virtual void removeThing(std::shared_ptr<Thing>, uint32_t) override { } + virtual void addThing(const std::shared_ptr<Thing> &) override { } + virtual void addThing(int32_t, const std::shared_ptr<Thing> &) override { } + virtual void updateThing(const std::shared_ptr<Thing> &, uint16_t, uint32_t) override { } + virtual void replaceThing(uint32_t, const std::shared_ptr<Thing> &) override { } + virtual void removeThing(const std::shared_ptr<Thing> &, uint32_t) override { } - virtual void postAddNotification(std::shared_ptr<Thing>, std::shared_ptr<Cylinder>, int32_t, CylinderLink_t = LINK_OWNER) override { } - virtual void postRemoveNotification(std::shared_ptr<Thing>, std::shared_ptr<Cylinder>, int32_t, CylinderLink_t = LINK_OWNER) override { } + virtual void postAddNotification(const std::shared_ptr<Thing> &, const std::shared_ptr<Cylinder> &, int32_t, CylinderLink_t = LINK_OWNER) override { } + virtual void postRemoveNotification(const std::shared_ptr<Thing> &, const std::shared_ptr<Cylinder> &, int32_t, CylinderLink_t = LINK_OWNER) override { } bool isPushable() override { return false; diff --git a/src/items/decay/decay.cpp b/src/items/decay/decay.cpp index 58bd6095340..52cee455830 100644 --- a/src/items/decay/decay.cpp +++ b/src/items/decay/decay.cpp @@ -45,7 +45,7 @@ void Decay::startDecay(const std::shared_ptr<Item> &item) { stopDecay(item); } - int64_t timestamp = OTSYS_TIME() + duration; + const int64_t timestamp = OTSYS_TIME() + duration; if (decayMap.empty()) { eventId = g_dispatcher().scheduleEvent( std::max<int32_t>(SCHEDULER_MINTICKS, duration), [this] { checkDecay(); }, "Decay::checkDecay" @@ -70,13 +70,14 @@ void Decay::stopDecay(const std::shared_ptr<Item> &item) { return; } if (item->hasAttribute(ItemAttribute_t::DECAYSTATE)) { - auto timestamp = item->getAttribute<int64_t>(ItemAttribute_t::DURATION_TIMESTAMP); + const auto timestamp = item->getAttribute<int64_t>(ItemAttribute_t::DURATION_TIMESTAMP); if (item->hasAttribute(ItemAttribute_t::DURATION_TIMESTAMP)) { - auto it = decayMap.find(timestamp); + const auto it = decayMap.find(timestamp); if (it != decayMap.end()) { auto &decayItems = it->second; - size_t i = 0, end = decayItems.size(); + size_t i = 0; + const size_t end = decayItems.size(); auto decayItem = decayItems[i]; if (end == 1) { if (item == decayItem) { @@ -114,12 +115,13 @@ void Decay::stopDecay(const std::shared_ptr<Item> &item) { } void Decay::checkDecay() { - int64_t timestamp = OTSYS_TIME(); + const int64_t timestamp = OTSYS_TIME(); std::vector<std::shared_ptr<Item>> tempItems; tempItems.reserve(32); // Small preallocation - auto it = decayMap.begin(), end = decayMap.end(); + auto it = decayMap.begin(); + const auto end = decayMap.end(); while (it != end) { if (it->first > timestamp) { break; @@ -129,7 +131,7 @@ void Decay::checkDecay() { auto &decayItems = it->second; tempItems.reserve(tempItems.size() + decayItems.size()); for (auto &decayItem : decayItems) { - tempItems.push_back(decayItem); + tempItems.emplace_back(decayItem); } it = decayMap.erase(it); } @@ -160,7 +162,7 @@ void Decay::internalDecayItem(const std::shared_ptr<Item> &item) { // Remove the item and halt the decay process if a player triggers a bug where the item's decay ID matches its equip or de-equip transformation ID if (it.id == it.transformEquipTo || it.id == it.transformDeEquipTo) { g_game().internalRemoveItem(item); - auto player = item->getHoldingPlayer(); + const auto &player = item->getHoldingPlayer(); if (player) { g_logger().error("[{}] - internalDecayItem failed to player {}, item id is same from transform equip/deequip, " " item id: {}, equip to id: '{}', deequip to id '{}'", @@ -170,7 +172,7 @@ void Decay::internalDecayItem(const std::shared_ptr<Item> &item) { } if (it.decayTo != 0) { - std::shared_ptr<Player> player = item->getHoldingPlayer(); + const auto &player = item->getHoldingPlayer(); if (player) { bool needUpdateSkills = false; for (int32_t i = SKILL_FIRST; i <= SKILL_LAST; ++i) { diff --git a/src/items/decay/decay.hpp b/src/items/decay/decay.hpp index cce3b8b78d5..2a91b36018a 100644 --- a/src/items/decay/decay.hpp +++ b/src/items/decay/decay.hpp @@ -25,7 +25,7 @@ class Decay { private: void checkDecay(); - void internalDecayItem(const std::shared_ptr<Item> &item); + static void internalDecayItem(const std::shared_ptr<Item> &item); uint32_t eventId { 0 }; // order is important, so we use an std::map diff --git a/src/items/functions/item/attribute.cpp b/src/items/functions/item/attribute.cpp index 747b8c90c39..f960dbeb00e 100644 --- a/src/items/functions/item/attribute.cpp +++ b/src/items/functions/item/attribute.cpp @@ -20,12 +20,12 @@ const std::string &ItemAttribute::getAttributeString(ItemAttribute_t type) const return emptyString; } - auto attribute = getAttribute(type); + const auto attribute = getAttribute(type); if (!attribute) { return emptyString; } - return *attribute->getString().get(); + return *attribute->getString(); } const int64_t &ItemAttribute::getAttributeValue(ItemAttribute_t type) const { @@ -34,7 +34,7 @@ const int64_t &ItemAttribute::getAttributeValue(ItemAttribute_t type) const { return emptyInt; } - auto attribute = getAttribute(type); + const auto attribute = getAttribute(type); if (!attribute) { return emptyInt; } @@ -117,22 +117,22 @@ const CustomAttribute* ItemAttribute::getCustomAttribute(const std::string &attr } void ItemAttribute::setCustomAttribute(const std::string &key, const int64_t value) { - CustomAttribute attribute(key, value); + const CustomAttribute attribute(key, value); customAttributeMap[asLowerCaseString(key)] = attribute; } void ItemAttribute::setCustomAttribute(const std::string &key, const std::string &value) { - CustomAttribute attribute(key, value); + const CustomAttribute attribute(key, value); customAttributeMap[asLowerCaseString(key)] = attribute; } void ItemAttribute::setCustomAttribute(const std::string &key, const double value) { - CustomAttribute attribute(key, value); + const CustomAttribute attribute(key, value); customAttributeMap[asLowerCaseString(key)] = attribute; } void ItemAttribute::setCustomAttribute(const std::string &key, const bool value) { - CustomAttribute attribute(key, value); + const CustomAttribute attribute(key, value); customAttributeMap[asLowerCaseString(key)] = attribute; } @@ -141,7 +141,7 @@ void ItemAttribute::addCustomAttribute(const std::string &key, const CustomAttri } bool ItemAttribute::removeCustomAttribute(const std::string &attributeName) { - auto it = customAttributeMap.find(asLowerCaseString(attributeName)); + const auto it = customAttributeMap.find(asLowerCaseString(attributeName)); if (it == customAttributeMap.end()) { return false; } diff --git a/src/items/functions/item/attribute.hpp b/src/items/functions/item/attribute.hpp index a2d3ba128ed..b89920a4f18 100644 --- a/src/items/functions/item/attribute.hpp +++ b/src/items/functions/item/attribute.hpp @@ -15,7 +15,7 @@ class ItemAttributeHelper { public: - bool isAttributeInteger(ItemAttribute_t type) const { + static bool isAttributeInteger(ItemAttribute_t type) { switch (type) { case ItemAttribute_t::STORE: case ItemAttribute_t::ACTIONID: @@ -48,7 +48,7 @@ class ItemAttributeHelper { } } - bool isAttributeString(ItemAttribute_t type) const { + static bool isAttributeString(ItemAttribute_t type) { switch (type) { case ItemAttribute_t::DESCRIPTION: case ItemAttribute_t::TEXT: @@ -88,10 +88,9 @@ class Attributes : public ItemAttributeHelper { } std::variant<int64_t, std::shared_ptr<std::string>> getDefaultValueForType(ItemAttribute_t attributeType) const { - ItemAttributeHelper helper; - if (helper.isAttributeInteger(attributeType)) { + if (ItemAttributeHelper::isAttributeInteger(attributeType)) { return 0; - } else if (helper.isAttributeString(attributeType)) { + } else if (ItemAttributeHelper::isAttributeString(attributeType)) { return std::make_shared<std::string>(); } else { return {}; @@ -116,7 +115,7 @@ class Attributes : public ItemAttributeHelper { return emptyValue; } - const std::shared_ptr<std::string> getString() const { + std::shared_ptr<std::string> getString() const { if (std::holds_alternative<std::shared_ptr<std::string>>(value)) { return std::get<std::shared_ptr<std::string>>(value); } @@ -138,10 +137,10 @@ class ItemAttribute : public ItemAttributeHelper { // CustomAttribute object methods const CustomAttribute* getCustomAttribute(const std::string &attributeName) const; - void setCustomAttribute(const std::string &key, const int64_t value); + void setCustomAttribute(const std::string &key, int64_t value); void setCustomAttribute(const std::string &key, const std::string &value); - void setCustomAttribute(const std::string &key, const double value); - void setCustomAttribute(const std::string &key, const bool value); + void setCustomAttribute(const std::string &key, double value); + void setCustomAttribute(const std::string &key, bool value); void addCustomAttribute(const std::string &key, const CustomAttribute &customAttribute); bool removeCustomAttribute(const std::string &attributeName); @@ -158,12 +157,9 @@ class ItemAttribute : public ItemAttributeHelper { } bool hasAttribute(ItemAttribute_t type) const { - for (const auto &attr : attributeVector) { - if (attr.getAttributeType() == type) { - return true; - } - } - return false; + return std::ranges::any_of(attributeVector, [type](const auto &attr) { + return attr.getAttributeType() == type; + }); } const Attributes* getAttribute(ItemAttribute_t type) const; diff --git a/src/items/functions/item/custom_attribute.cpp b/src/items/functions/item/custom_attribute.cpp index 462ba4b520a..ffe479307ff 100644 --- a/src/items/functions/item/custom_attribute.cpp +++ b/src/items/functions/item/custom_attribute.cpp @@ -15,20 +15,20 @@ CustomAttribute::CustomAttribute() = default; CustomAttribute::~CustomAttribute() = default; // Constructor for int64_t -CustomAttribute::CustomAttribute(const std::string &initStringKey, const int64_t initInt64) : - stringKey(initStringKey), value(initInt64) { +CustomAttribute::CustomAttribute(std::string initStringKey, const int64_t initInt64) : + stringKey(std::move(initStringKey)), value(initInt64) { } // Constructor for string -CustomAttribute::CustomAttribute(const std::string &initStringKey, const std::string &initStringValue) : - stringKey(initStringKey), value(initStringValue) { +CustomAttribute::CustomAttribute(std::string initStringKey, const std::string &initStringValue) : + stringKey(std::move(initStringKey)), value(initStringValue) { } // Constructor for double -CustomAttribute::CustomAttribute(const std::string &initStringKey, const double initDoubleValue) : - stringKey(initStringKey), value(initDoubleValue) { +CustomAttribute::CustomAttribute(std::string initStringKey, const double initDoubleValue) : + stringKey(std::move(initStringKey)), value(initDoubleValue) { } // Constructor for boolean -CustomAttribute::CustomAttribute(const std::string &initStringKey, const bool initBoolValue) : - stringKey(initStringKey), value(initBoolValue) { +CustomAttribute::CustomAttribute(std::string initStringKey, const bool initBoolValue) : + stringKey(std::move(initStringKey)), value(initBoolValue) { } const std::string &CustomAttribute::getStringKey() const { diff --git a/src/items/functions/item/custom_attribute.hpp b/src/items/functions/item/custom_attribute.hpp index e91832c6b6b..b44e20bf477 100644 --- a/src/items/functions/item/custom_attribute.hpp +++ b/src/items/functions/item/custom_attribute.hpp @@ -16,10 +16,10 @@ class CustomAttribute { CustomAttribute(); ~CustomAttribute(); - CustomAttribute(const std::string &initStringKey, const int64_t initInt64Value); - CustomAttribute(const std::string &initStringKey, const std::string &initStringValue); - CustomAttribute(const std::string &initStringKey, const double initDoubleValue); - CustomAttribute(const std::string &initStringKey, const bool initBoolValue); + CustomAttribute(std::string initStringKey, int64_t initInt64Value); + CustomAttribute(std::string initStringKey, const std::string &initStringValue); + CustomAttribute(std::string initStringKey, double initDoubleValue); + CustomAttribute(std::string initStringKey, bool initBoolValue); const std::string &getStringKey() const; diff --git a/src/items/functions/item/item_parse.cpp b/src/items/functions/item/item_parse.cpp index 822d2099df2..8167e301425 100644 --- a/src/items/functions/item/item_parse.cpp +++ b/src/items/functions/item/item_parse.cpp @@ -13,74 +13,74 @@ #include "utils/pugicast.hpp" #include "creatures/combat/combat.hpp" -void ItemParse::initParse(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { +void ItemParse::initParse(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { // Parse all item attributes - ItemParse::parseType(tmpStrValue, attributeNode, valueAttribute, itemType); - ItemParse::parseDescription(tmpStrValue, valueAttribute, itemType); - ItemParse::parseRuneSpellName(tmpStrValue, valueAttribute, itemType); - ItemParse::parseWeight(tmpStrValue, valueAttribute, itemType); - ItemParse::parseShowCount(tmpStrValue, valueAttribute, itemType); - ItemParse::parseArmor(tmpStrValue, valueAttribute, itemType); - ItemParse::parseDefense(tmpStrValue, valueAttribute, itemType); - ItemParse::parseExtraDefense(tmpStrValue, valueAttribute, itemType); - ItemParse::parseAttack(tmpStrValue, valueAttribute, itemType); - ItemParse::parseRotateTo(tmpStrValue, valueAttribute, itemType); - ItemParse::parseWrapContainer(tmpStrValue, valueAttribute, itemType); - ItemParse::parseWrapableTo(tmpStrValue, valueAttribute, itemType); - ItemParse::parseMovable(tmpStrValue, valueAttribute, itemType); - ItemParse::parseBlockProjectTile(tmpStrValue, valueAttribute, itemType); - ItemParse::parsePickupable(tmpStrValue, valueAttribute, itemType); - ItemParse::parseFloorChange(tmpStrValue, valueAttribute, itemType); - ItemParse::parseContainerSize(tmpStrValue, valueAttribute, itemType); - ItemParse::parseFluidSource(tmpStrValue, valueAttribute, itemType); - ItemParse::parseWriteables(tmpStrValue, valueAttribute, itemType); - ItemParse::parseWeaponType(tmpStrValue, valueAttribute, itemType); - ItemParse::parseSlotType(tmpStrValue, valueAttribute, itemType); - ItemParse::parseAmmoType(tmpStrValue, valueAttribute, itemType); - ItemParse::parseShootType(tmpStrValue, valueAttribute, itemType); - ItemParse::parseMagicEffect(tmpStrValue, valueAttribute, itemType); - ItemParse::parseLootType(tmpStrValue, valueAttribute, itemType); - ItemParse::parseRange(tmpStrValue, valueAttribute, itemType); - ItemParse::parseDecayTo(tmpStrValue, valueAttribute, itemType); - ItemParse::parseDuration(tmpStrValue, valueAttribute, itemType); - ItemParse::parseTransform(tmpStrValue, valueAttribute, itemType); - ItemParse::parseCharges(tmpStrValue, valueAttribute, itemType); - ItemParse::parseShowAttributes(tmpStrValue, valueAttribute, itemType); - ItemParse::parseHitChance(tmpStrValue, valueAttribute, itemType); - ItemParse::parseInvisible(tmpStrValue, valueAttribute, itemType); - ItemParse::parseSpeed(tmpStrValue, valueAttribute, itemType); - ItemParse::parseHealthAndMana(tmpStrValue, valueAttribute, itemType); - ItemParse::parseSkills(tmpStrValue, valueAttribute, itemType); - ItemParse::parseCriticalHit(tmpStrValue, valueAttribute, itemType); - ItemParse::parseLifeAndManaLeech(tmpStrValue, valueAttribute, itemType); - ItemParse::parseMaxHitAndManaPoints(tmpStrValue, valueAttribute, itemType); - ItemParse::parseMagicLevelPoint(tmpStrValue, valueAttribute, itemType); - ItemParse::parseFieldAbsorbPercent(tmpStrValue, valueAttribute, itemType); - ItemParse::parseAbsorbPercent(tmpStrValue, valueAttribute, itemType); - ItemParse::parseSupressDrunk(tmpStrValue, valueAttribute, itemType); - ItemParse::parseField(tmpStrValue, attributeNode, valueAttribute, itemType); - ItemParse::parseReplaceable(tmpStrValue, valueAttribute, itemType); - ItemParse::parseLevelDoor(tmpStrValue, valueAttribute, itemType); - ItemParse::parseBeds(tmpStrValue, valueAttribute, itemType); - ItemParse::parseElement(tmpStrValue, valueAttribute, itemType); - ItemParse::parseWalk(tmpStrValue, valueAttribute, itemType); - ItemParse::parseAllowDistanceRead(tmpStrValue, valueAttribute, itemType); - ItemParse::parseImbuement(tmpStrValue, attributeNode, valueAttribute, itemType); - ItemParse::parseAugment(tmpStrValue, attributeNode, valueAttribute, itemType); - ItemParse::parseStackSize(tmpStrValue, valueAttribute, itemType); - ItemParse::parseSpecializedMagicLevelPoint(tmpStrValue, valueAttribute, itemType); - ItemParse::parseMagicShieldCapacity(tmpStrValue, valueAttribute, itemType); - ItemParse::parsePerfecShot(tmpStrValue, valueAttribute, itemType); - ItemParse::parseCleavePercent(tmpStrValue, valueAttribute, itemType); - ItemParse::parseReflectDamage(tmpStrValue, valueAttribute, itemType); - ItemParse::parseTransformOnUse(tmpStrValue, valueAttribute, itemType); - ItemParse::parsePrimaryType(tmpStrValue, valueAttribute, itemType); - ItemParse::parseHouseRelated(tmpStrValue, valueAttribute, itemType); - ItemParse::parseUnscriptedItems(tmpStrValue, attributeNode, valueAttribute, itemType); + ItemParse::parseType(stringValue, attributeNode, valueAttribute, itemType); + ItemParse::parseDescription(stringValue, valueAttribute, itemType); + ItemParse::parseRuneSpellName(stringValue, valueAttribute, itemType); + ItemParse::parseWeight(stringValue, valueAttribute, itemType); + ItemParse::parseShowCount(stringValue, valueAttribute, itemType); + ItemParse::parseArmor(stringValue, valueAttribute, itemType); + ItemParse::parseDefense(stringValue, valueAttribute, itemType); + ItemParse::parseExtraDefense(stringValue, valueAttribute, itemType); + ItemParse::parseAttack(stringValue, valueAttribute, itemType); + ItemParse::parseRotateTo(stringValue, valueAttribute, itemType); + ItemParse::parseWrapContainer(stringValue, valueAttribute, itemType); + ItemParse::parseWrapableTo(stringValue, valueAttribute, itemType); + ItemParse::parseMovable(stringValue, valueAttribute, itemType); + ItemParse::parseBlockProjectTile(stringValue, valueAttribute, itemType); + ItemParse::parsePickupable(stringValue, valueAttribute, itemType); + ItemParse::parseFloorChange(stringValue, valueAttribute, itemType); + ItemParse::parseContainerSize(stringValue, valueAttribute, itemType); + ItemParse::parseFluidSource(stringValue, valueAttribute, itemType); + ItemParse::parseWriteables(stringValue, valueAttribute, itemType); + ItemParse::parseWeaponType(stringValue, valueAttribute, itemType); + ItemParse::parseSlotType(stringValue, valueAttribute, itemType); + ItemParse::parseAmmoType(stringValue, valueAttribute, itemType); + ItemParse::parseShootType(stringValue, valueAttribute, itemType); + ItemParse::parseMagicEffect(stringValue, valueAttribute, itemType); + ItemParse::parseLootType(stringValue, valueAttribute, itemType); + ItemParse::parseRange(stringValue, valueAttribute, itemType); + ItemParse::parseDecayTo(stringValue, valueAttribute, itemType); + ItemParse::parseDuration(stringValue, valueAttribute, itemType); + ItemParse::parseTransform(stringValue, valueAttribute, itemType); + ItemParse::parseCharges(stringValue, valueAttribute, itemType); + ItemParse::parseShowAttributes(stringValue, valueAttribute, itemType); + ItemParse::parseHitChance(stringValue, valueAttribute, itemType); + ItemParse::parseInvisible(stringValue, valueAttribute, itemType); + ItemParse::parseSpeed(stringValue, valueAttribute, itemType); + ItemParse::parseHealthAndMana(stringValue, valueAttribute, itemType); + ItemParse::parseSkills(stringValue, valueAttribute, itemType); + ItemParse::parseCriticalHit(stringValue, valueAttribute, itemType); + ItemParse::parseLifeAndManaLeech(stringValue, valueAttribute, itemType); + ItemParse::parseMaxHitAndManaPoints(stringValue, valueAttribute, itemType); + ItemParse::parseMagicLevelPoint(stringValue, valueAttribute, itemType); + ItemParse::parseFieldAbsorbPercent(stringValue, valueAttribute, itemType); + ItemParse::parseAbsorbPercent(stringValue, valueAttribute, itemType); + ItemParse::parseSupressDrunk(stringValue, valueAttribute, itemType); + ItemParse::parseField(stringValue, attributeNode, valueAttribute, itemType); + ItemParse::parseReplaceable(stringValue, valueAttribute, itemType); + ItemParse::parseLevelDoor(stringValue, valueAttribute, itemType); + ItemParse::parseBeds(stringValue, valueAttribute, itemType); + ItemParse::parseElement(stringValue, valueAttribute, itemType); + ItemParse::parseWalk(stringValue, valueAttribute, itemType); + ItemParse::parseAllowDistanceRead(stringValue, valueAttribute, itemType); + ItemParse::parseImbuement(stringValue, attributeNode, valueAttribute, itemType); + ItemParse::parseAugment(stringValue, attributeNode, valueAttribute, itemType); + ItemParse::parseStackSize(stringValue, valueAttribute, itemType); + ItemParse::parseSpecializedMagicLevelPoint(stringValue, valueAttribute, itemType); + ItemParse::parseMagicShieldCapacity(stringValue, valueAttribute, itemType); + ItemParse::parsePerfecShot(stringValue, valueAttribute, itemType); + ItemParse::parseCleavePercent(stringValue, valueAttribute, itemType); + ItemParse::parseReflectDamage(stringValue, valueAttribute, itemType); + ItemParse::parseTransformOnUse(stringValue, valueAttribute, itemType); + ItemParse::parsePrimaryType(stringValue, valueAttribute, itemType); + ItemParse::parseHouseRelated(stringValue, valueAttribute, itemType); + ItemParse::parseUnscriptedItems(stringValue, attributeNode, valueAttribute, itemType); } void ItemParse::parseDummyRate(pugi::xml_node attributeNode, ItemType &itemType) { - for (auto subAttributeNode : attributeNode.children()) { + for (const auto &subAttributeNode : attributeNode.children()) { pugi::xml_attribute subKeyAttribute = subAttributeNode.attribute("key"); if (!subKeyAttribute) { continue; @@ -93,17 +93,16 @@ void ItemParse::parseDummyRate(pugi::xml_node attributeNode, ItemType &itemType) auto stringValue = asLowerCaseString(subKeyAttribute.as_string()); if (stringValue == "rate") { - uint16_t rate = subValueAttribute.as_uint(); + const uint16_t rate = subValueAttribute.as_uint(); Item::items.addDummyId(itemType.id, rate); } } } -void ItemParse::parseType(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseType(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "type") { - stringValue = asLowerCaseString(valueAttribute.as_string()); - auto itemMap = ItemTypesMap.find(stringValue); + auto stringValue = asLowerCaseString(valueAttribute.as_string()); + const auto &itemMap = ItemTypesMap.find(stringValue); if (itemMap != ItemTypesMap.end()) { itemType.type = itemMap->second; if (itemType.type == ITEM_TYPE_CONTAINER) { @@ -121,8 +120,7 @@ void ItemParse::parseType(const std::string &tmpStrValue, pugi::xml_node attribu } } -void ItemParse::parseDescription(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseDescription(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "description") { itemType.description = valueAttribute.as_string(); if (g_configManager().getBoolean(TOGGLE_GOLD_POUCH_QUICKLOOT_ONLY) && itemType.id == ITEM_GOLD_POUCH) { @@ -133,103 +131,89 @@ void ItemParse::parseDescription(const std::string &tmpStrValue, pugi::xml_attri } } -void ItemParse::parseRuneSpellName(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseRuneSpellName(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "runespellname") { itemType.runeSpellName = valueAttribute.as_string(); } } -void ItemParse::parseWeight(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseWeight(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "weight") { itemType.weight = pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseShowCount(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseShowCount(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "showcount") { itemType.showCount = valueAttribute.as_bool(); } } -void ItemParse::parseArmor(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseArmor(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "armor") { itemType.armor = pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseDefense(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseDefense(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "defense") { itemType.defense = pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseExtraDefense(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseExtraDefense(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "extradef") { itemType.extraDefense = pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseAttack(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseAttack(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "attack") { itemType.attack = pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseRotateTo(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseRotateTo(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "rotateto") { itemType.rotateTo = pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseWrapContainer(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseWrapContainer(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "wrapcontainer") { itemType.wrapContainer = valueAttribute.as_bool(); } } -void ItemParse::parseWrapableTo(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseWrapableTo(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "wrapableto") { itemType.wrapableTo = pugi::cast<int32_t>(valueAttribute.value()); itemType.wrapable = true; } } -void ItemParse::parseMovable(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseMovable(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "movable") { itemType.movable = valueAttribute.as_bool(); } } -void ItemParse::parseBlockProjectTile(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseBlockProjectTile(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "blockprojectile") { itemType.blockProjectile = valueAttribute.as_bool(); } } -void ItemParse::parsePickupable(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parsePickupable(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "allowpickupable" || stringValue == "pickupable") { itemType.pickupable = valueAttribute.as_bool(); } } -void ItemParse::parseFloorChange(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseFloorChange(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "floorchange") { - stringValue = asLowerCaseString(valueAttribute.as_string()); - auto itemMap = TileStatesMap.find(stringValue); + auto lowerString = asLowerCaseString(valueAttribute.as_string()); + const auto &itemMap = TileStatesMap.find(lowerString); if (itemMap != TileStatesMap.end()) { itemType.floorChange = itemMap->second; } else { @@ -238,18 +222,16 @@ void ItemParse::parseFloorChange(const std::string &tmpStrValue, pugi::xml_attri } } -void ItemParse::parseContainerSize(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseContainerSize(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "containersize") { itemType.maxItems = pugi::cast<uint16_t>(valueAttribute.value()); } } -void ItemParse::parseFluidSource(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseFluidSource(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "fluidsource") { - stringValue = asLowerCaseString(valueAttribute.as_string()); - auto itemMap = FluidTypesMap.find(stringValue); + auto lowerString = asLowerCaseString(valueAttribute.as_string()); + const auto &itemMap = FluidTypesMap.find(lowerString); if (itemMap != FluidTypesMap.end()) { itemType.fluidSource = itemMap->second; } else { @@ -258,8 +240,7 @@ void ItemParse::parseFluidSource(const std::string &tmpStrValue, pugi::xml_attri } } -void ItemParse::parseWriteables(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseWriteables(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "readable") { itemType.canReadText = valueAttribute.as_bool(); } else if (stringValue == "writeable") { @@ -272,13 +253,12 @@ void ItemParse::parseWriteables(const std::string &tmpStrValue, pugi::xml_attrib } } -void ItemParse::parseWeaponType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseWeaponType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "weapontype") { - stringValue = asLowerCaseString(valueAttribute.as_string()); - auto itemMap = WeaponTypesMap.find(stringValue); + auto lowerString = asLowerCaseString(valueAttribute.as_string()); + const auto &itemMap = WeaponTypesMap.find(lowerString); if (itemMap != WeaponTypesMap.end()) { - if (tmpStrValue == "spellbook") { + if (stringValue == "spellbook") { itemType.spellbook = true; } itemType.weaponType = itemMap->second; @@ -288,34 +268,33 @@ void ItemParse::parseWeaponType(const std::string &tmpStrValue, pugi::xml_attrib } } -void ItemParse::parseSlotType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseSlotType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "slottype") { itemType.slotPosition = SLOTP_HAND; - stringValue = asLowerCaseString(valueAttribute.as_string()); - if (stringValue == "head") { + auto subStringValue = asLowerCaseString(valueAttribute.as_string()); + if (subStringValue == "head") { itemType.slotPosition |= SLOTP_HEAD; - } else if (stringValue == "body") { + } else if (subStringValue == "body") { itemType.slotPosition |= SLOTP_ARMOR; - } else if (stringValue == "legs") { + } else if (subStringValue == "legs") { itemType.slotPosition |= SLOTP_LEGS; - } else if (stringValue == "feet") { + } else if (subStringValue == "feet") { itemType.slotPosition |= SLOTP_FEET; - } else if (stringValue == "backpack") { + } else if (subStringValue == "backpack") { itemType.slotPosition |= SLOTP_BACKPACK; - } else if (stringValue == "two-handed") { + } else if (subStringValue == "two-handed") { itemType.slotPosition |= SLOTP_TWO_HAND; - } else if (stringValue == "right-hand") { + } else if (subStringValue == "right-hand") { itemType.slotPosition &= ~SLOTP_LEFT; - } else if (stringValue == "left-hand") { + } else if (subStringValue == "left-hand") { itemType.slotPosition &= ~SLOTP_RIGHT; - } else if (stringValue == "necklace") { + } else if (subStringValue == "necklace") { itemType.slotPosition |= SLOTP_NECKLACE; - } else if (stringValue == "ring") { + } else if (subStringValue == "ring") { itemType.slotPosition |= SLOTP_RING; - } else if (stringValue == "ammo") { + } else if (subStringValue == "ammo") { itemType.slotPosition |= SLOTP_AMMO; - } else if (stringValue == "hand") { + } else if (subStringValue == "hand") { itemType.slotPosition |= SLOTP_HAND; } else { g_logger().warn("[itemParseSlotType - Items::parseItemNode] - Unknown slotType {}", valueAttribute.as_string()); @@ -323,8 +302,7 @@ void ItemParse::parseSlotType(const std::string &tmpStrValue, pugi::xml_attribut } } -void ItemParse::parseAmmoType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseAmmoType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "ammotype") { itemType.ammoType = getAmmoType(asLowerCaseString(valueAttribute.as_string())); if (itemType.ammoType == AMMO_NONE) { @@ -333,10 +311,9 @@ void ItemParse::parseAmmoType(const std::string &tmpStrValue, pugi::xml_attribut } } -void ItemParse::parseShootType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseShootType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "shoottype") { - ShootType_t shoot = getShootType(asLowerCaseString(valueAttribute.as_string())); + const ShootType_t &shoot = getShootType(asLowerCaseString(valueAttribute.as_string())); if (shoot != CONST_ANI_NONE) { itemType.shootType = shoot; } else { @@ -345,10 +322,9 @@ void ItemParse::parseShootType(const std::string &tmpStrValue, pugi::xml_attribu } } -void ItemParse::parseMagicEffect(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseMagicEffect(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "effect") { - MagicEffectClasses effect = getMagicEffect(asLowerCaseString(valueAttribute.as_string())); + const MagicEffectClasses &effect = getMagicEffect(asLowerCaseString(valueAttribute.as_string())); if (effect != CONST_ME_NONE) { itemType.magicEffect = effect; } else { @@ -357,29 +333,25 @@ void ItemParse::parseMagicEffect(const std::string &tmpStrValue, pugi::xml_attri } } -void ItemParse::parseLootType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseLootType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "loottype") { itemType.type = Item::items.getLootType(valueAttribute.as_string()); } } -void ItemParse::parseRange(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseRange(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "range") { itemType.shootRange = pugi::cast<uint8_t>(valueAttribute.value()); } } -void ItemParse::parseDecayTo(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseDecayTo(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "decayto") { itemType.decayTo = pugi::cast<uint16_t>(valueAttribute.value()); } } -void ItemParse::parseDuration(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseDuration(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "duration") { itemType.decayTime = pugi::cast<uint32_t>(valueAttribute.value()); } else if (stringValue == "stopduration") { @@ -389,8 +361,7 @@ void ItemParse::parseDuration(const std::string &tmpStrValue, pugi::xml_attribut } } -void ItemParse::parseTransform(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseTransform(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "transformequipto") { itemType.transformEquipTo = pugi::cast<uint16_t>(valueAttribute.value()); if (itemType.transformEquipTo == itemType.decayTo) { @@ -415,8 +386,7 @@ void ItemParse::parseTransform(const std::string &tmpStrValue, pugi::xml_attribu } } -void ItemParse::parseCharges(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseCharges(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "charges") { itemType.charges = pugi::cast<uint32_t>(valueAttribute.value()); } else if (stringValue == "showcharges") { @@ -424,15 +394,13 @@ void ItemParse::parseCharges(const std::string &tmpStrValue, pugi::xml_attribute } } -void ItemParse::parseShowAttributes(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string lowerStringValue = asLowerCaseString(tmpStrValue); - if (lowerStringValue == "showattributes") { +void ItemParse::parseShowAttributes(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue == "showattributes") { itemType.showAttributes = valueAttribute.as_bool(); } } -void ItemParse::parseHitChance(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseHitChance(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "hitchance") { itemType.hitChance = std::min<int8_t>(100, std::max<int8_t>(-100, pugi::cast<int8_t>(valueAttribute.value()))); } else if (stringValue == "maxhitchance") { @@ -440,22 +408,19 @@ void ItemParse::parseHitChance(const std::string &tmpStrValue, pugi::xml_attribu } } -void ItemParse::parseInvisible(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseInvisible(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "invisible") { itemType.getAbilities().invisible = valueAttribute.as_bool(); } } -void ItemParse::parseSpeed(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseSpeed(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "speed") { itemType.getAbilities().speed = pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseHealthAndMana(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseHealthAndMana(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "healthgain") { Abilities &abilities = itemType.getAbilities(); abilities.regeneration = true; @@ -477,8 +442,7 @@ void ItemParse::parseHealthAndMana(const std::string &tmpStrValue, pugi::xml_att } } -void ItemParse::parseSkills(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseSkills(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "skillsword") { itemType.getAbilities().skills[SKILL_SWORD] = pugi::cast<int32_t>(valueAttribute.value()); } else if (stringValue == "skillaxe") { @@ -496,8 +460,7 @@ void ItemParse::parseSkills(const std::string &tmpStrValue, pugi::xml_attribute } } -void ItemParse::parseCriticalHit(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseCriticalHit(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "criticalhitchance") { itemType.getAbilities().skills[SKILL_CRITICAL_HIT_CHANCE] = pugi::cast<int32_t>(valueAttribute.value()); } else if (stringValue == "criticalhitdamage") { @@ -505,8 +468,7 @@ void ItemParse::parseCriticalHit(const std::string &tmpStrValue, pugi::xml_attri } } -void ItemParse::parseLifeAndManaLeech(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseLifeAndManaLeech(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "lifeleechchance") { itemType.getAbilities().skills[SKILL_LIFE_LEECH_CHANCE] = pugi::cast<int32_t>(valueAttribute.value()); } else if (stringValue == "lifeleechamount") { @@ -518,8 +480,7 @@ void ItemParse::parseLifeAndManaLeech(const std::string &tmpStrValue, pugi::xml_ } } -void ItemParse::parseMaxHitAndManaPoints(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseMaxHitAndManaPoints(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "maxhitpoints") { itemType.getAbilities().stats[STAT_MAXHITPOINTS] = pugi::cast<int32_t>(valueAttribute.value()); } else if (stringValue == "maxhitpointspercent") { @@ -531,8 +492,7 @@ void ItemParse::parseMaxHitAndManaPoints(const std::string &tmpStrValue, pugi::x } } -void ItemParse::parseMagicLevelPoint(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseMagicLevelPoint(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "magiclevelpoints" || stringValue == "magicpoints") { itemType.getAbilities().stats[STAT_MAGICPOINTS] = pugi::cast<int32_t>(valueAttribute.value()); } else if (stringValue == "magiclevelpointspercent") { @@ -540,8 +500,7 @@ void ItemParse::parseMagicLevelPoint(const std::string &tmpStrValue, pugi::xml_a } } -void ItemParse::parseFieldAbsorbPercent(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseFieldAbsorbPercent(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "fieldabsorbpercentenergy") { itemType.getAbilities().fieldAbsorbPercent[combatTypeToIndex(COMBAT_ENERGYDAMAGE)] += pugi::cast<int16_t>(valueAttribute.value()); } else if (stringValue == "fieldabsorbpercentfire") { @@ -551,23 +510,22 @@ void ItemParse::parseFieldAbsorbPercent(const std::string &tmpStrValue, pugi::xm } } -void ItemParse::parseAbsorbPercent(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseAbsorbPercent(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "absorbpercentall") { - int16_t value = pugi::cast<int16_t>(valueAttribute.value()); + const auto value = pugi::cast<int16_t>(valueAttribute.value()); Abilities &abilities = itemType.getAbilities(); for (auto &i : abilities.absorbPercent) { i += value; } } else if (stringValue == "absorbpercentelements") { - int16_t value = pugi::cast<int16_t>(valueAttribute.value()); + const auto value = pugi::cast<int16_t>(valueAttribute.value()); Abilities &abilities = itemType.getAbilities(); abilities.absorbPercent[combatTypeToIndex(COMBAT_ENERGYDAMAGE)] += value; abilities.absorbPercent[combatTypeToIndex(COMBAT_FIREDAMAGE)] += value; abilities.absorbPercent[combatTypeToIndex(COMBAT_EARTHDAMAGE)] += value; abilities.absorbPercent[combatTypeToIndex(COMBAT_ICEDAMAGE)] += value; } else if (stringValue == "absorbpercentmagic") { - int16_t value = pugi::cast<int16_t>(valueAttribute.value()); + const auto value = pugi::cast<int16_t>(valueAttribute.value()); Abilities &abilities = itemType.getAbilities(); abilities.absorbPercent[combatTypeToIndex(COMBAT_ENERGYDAMAGE)] += value; abilities.absorbPercent[combatTypeToIndex(COMBAT_FIREDAMAGE)] += value; @@ -600,8 +558,7 @@ void ItemParse::parseAbsorbPercent(const std::string &tmpStrValue, pugi::xml_att } } -void ItemParse::parseSupressDrunk(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseSupressDrunk(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (valueAttribute.as_bool()) { ConditionType_t conditionType = CONDITION_NONE; if (stringValue == "suppressdrunk") { @@ -628,8 +585,8 @@ void ItemParse::parseSupressDrunk(const std::string &tmpStrValue, pugi::xml_attr } } -std::tuple<ConditionId_t, ConditionType_t> ItemParse::parseFieldConditions(std::string lowerStringValue, pugi::xml_attribute valueAttribute) { - lowerStringValue = asLowerCaseString(valueAttribute.as_string()); +std::tuple<ConditionId_t, ConditionType_t> ItemParse::parseFieldConditions(pugi::xml_attribute valueAttribute) { + auto lowerStringValue = asLowerCaseString(valueAttribute.as_string()); ConditionId_t conditionId = CONDITIONID_COMBAT; ConditionType_t conditionType = CONDITION_NONE; if (lowerStringValue == "fire") { @@ -653,8 +610,8 @@ std::tuple<ConditionId_t, ConditionType_t> ItemParse::parseFieldConditions(std:: return std::make_tuple(CONDITIONID_DEFAULT, CONDITION_NONE); } -CombatType_t ItemParse::parseFieldCombatType(std::string lowerStringValue, pugi::xml_attribute valueAttribute) { - lowerStringValue = asLowerCaseString(valueAttribute.as_string()); +CombatType_t ItemParse::parseFieldCombatType(pugi::xml_attribute valueAttribute) { + auto lowerStringValue = asLowerCaseString(valueAttribute.as_string()); if (lowerStringValue == "fire") { return COMBAT_FIREDAMAGE; } else if (lowerStringValue == "energy") { @@ -671,13 +628,13 @@ CombatType_t ItemParse::parseFieldCombatType(std::string lowerStringValue, pugi: return COMBAT_NONE; } -void ItemParse::parseFieldCombatDamage(std::shared_ptr<ConditionDamage> conditionDamage, std::string stringValue, pugi::xml_node attributeNode) { +void ItemParse::parseFieldCombatDamage(const std::shared_ptr<ConditionDamage> &conditionDamage, pugi::xml_node attributeNode) { uint32_t combatTicks = 0; int32_t combatDamage = 0; int32_t combatStart = 0; int32_t combatCount = 1; - for (auto subAttributeNode : attributeNode.children()) { + for (const auto &subAttributeNode : attributeNode.children()) { pugi::xml_attribute subKeyAttribute = subAttributeNode.attribute("key"); if (!subKeyAttribute) { continue; @@ -688,7 +645,7 @@ void ItemParse::parseFieldCombatDamage(std::shared_ptr<ConditionDamage> conditio continue; } - stringValue = asLowerCaseString(subKeyAttribute.as_string()); + auto stringValue = asLowerCaseString(subKeyAttribute.as_string()); if (stringValue == "ticks") { combatTicks = pugi::cast<uint32_t>(subValueAttribute.value()); } else if (stringValue == "count") { @@ -703,7 +660,7 @@ void ItemParse::parseFieldCombatDamage(std::shared_ptr<ConditionDamage> conditio std::list<int32_t> damageList; ConditionDamage::generateDamageList(combatDamage, combatStart, damageList); - for (int32_t damageValue : damageList) { + for (const int32_t damageValue : damageList) { conditionDamage->addDamage(1, combatTicks, -damageValue); } @@ -712,14 +669,14 @@ void ItemParse::parseFieldCombatDamage(std::shared_ptr<ConditionDamage> conditio } } -void ItemParse::parseField(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { - if (tmpStrValue == "field") { +void ItemParse::parseField(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue == "field") { CombatType_t combatType = COMBAT_NONE; std::shared_ptr<ConditionDamage> conditionDamage = nullptr; // Parse fields conditions (fire/energy/poison/drown/physical) - combatType = parseFieldCombatType(tmpStrValue, valueAttribute); - auto [conditionId, conditionType] = parseFieldConditions(tmpStrValue, valueAttribute); + combatType = parseFieldCombatType(valueAttribute); + auto [conditionId, conditionType] = parseFieldConditions(valueAttribute); if (combatType != COMBAT_NONE) { if (conditionDamage) { @@ -730,7 +687,7 @@ void ItemParse::parseField(const std::string &tmpStrValue, pugi::xml_node attrib itemType.combatType = combatType; itemType.conditionDamage = conditionDamage; - parseFieldCombatDamage(conditionDamage, tmpStrValue, attributeNode); + parseFieldCombatDamage(conditionDamage, attributeNode); conditionDamage->setParam(CONDITION_PARAM_FIELD, 1); @@ -741,28 +698,25 @@ void ItemParse::parseField(const std::string &tmpStrValue, pugi::xml_node attrib } } -void ItemParse::parseReplaceable(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseReplaceable(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "replaceable") { itemType.replaceable = valueAttribute.as_bool(); } } -void ItemParse::parseLevelDoor(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseLevelDoor(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "leveldoor") { itemType.levelDoor = pugi::cast<uint32_t>(valueAttribute.value()); } } -void ItemParse::parseBeds(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseBeds(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "partnerdirection") { itemType.bedPartnerDir = getDirection(valueAttribute.as_string()); } if (stringValue == "maletransformto") { - uint16_t valueMale = pugi::cast<uint16_t>(valueAttribute.value()); + const auto valueMale = pugi::cast<uint16_t>(valueAttribute.value()); ItemType &other = Item::items.getItemType(valueMale); itemType.transformToOnUse[PLAYERSEX_MALE] = valueMale; if (other.transformToFree == 0) { @@ -773,7 +727,7 @@ void ItemParse::parseBeds(const std::string &tmpStrValue, pugi::xml_attribute va itemType.transformToOnUse[PLAYERSEX_FEMALE] = valueMale; } } else if (stringValue == "femaletransformto") { - uint16_t valueFemale = pugi::cast<uint16_t>(valueAttribute.value()); + const auto valueFemale = pugi::cast<uint16_t>(valueAttribute.value()); ItemType &other = Item::items.getItemType(valueFemale); itemType.transformToOnUse[PLAYERSEX_FEMALE] = valueFemale; @@ -794,8 +748,7 @@ void ItemParse::parseBeds(const std::string &tmpStrValue, pugi::xml_attribute va } } -void ItemParse::parseElement(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseElement(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "elementice") { Abilities &abilities = itemType.getAbilities(); abilities.elementDamage = pugi::cast<uint16_t>(valueAttribute.value()); @@ -823,8 +776,7 @@ void ItemParse::parseElement(const std::string &tmpStrValue, pugi::xml_attribute } } -void ItemParse::parseWalk(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseWalk(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "walkstack") { itemType.walkStack = valueAttribute.as_bool(); } else if (stringValue == "blocking") { @@ -832,20 +784,19 @@ void ItemParse::parseWalk(const std::string &tmpStrValue, pugi::xml_attribute va } } -void ItemParse::parseAllowDistanceRead(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseAllowDistanceRead(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "allowdistread") { itemType.allowDistRead = booleanString(valueAttribute.as_string()); } } -void ItemParse::parseImbuement(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { - if (tmpStrValue != "imbuementslot") { +void ItemParse::parseImbuement(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue != "imbuementslot") { return; } itemType.imbuementSlot = pugi::cast<uint8_t>(valueAttribute.value()); - for (auto subAttributeNode : attributeNode.children()) { + for (const auto &subAttributeNode : attributeNode.children()) { pugi::xml_attribute subKeyAttribute = subAttributeNode.attribute("key"); if (!subKeyAttribute) { continue; @@ -856,9 +807,9 @@ void ItemParse::parseImbuement(const std::string &tmpStrValue, pugi::xml_node at continue; } - auto itemMap = ImbuementsTypeMap.find(asLowerCaseString(subKeyAttribute.as_string())); + const auto &itemMap = ImbuementsTypeMap.find(asLowerCaseString(subKeyAttribute.as_string())); if (itemMap != ImbuementsTypeMap.end()) { - ImbuementTypes_t imbuementType = getImbuementType(asLowerCaseString(subKeyAttribute.as_string())); + const ImbuementTypes_t imbuementType = getImbuementType(asLowerCaseString(subKeyAttribute.as_string())); if (imbuementType != IMBUEMENT_NONE) { itemType.setImbuementType(imbuementType, pugi::cast<uint16_t>(subValueAttribute.value())); continue; @@ -869,8 +820,8 @@ void ItemParse::parseImbuement(const std::string &tmpStrValue, pugi::xml_node at } } -void ItemParse::parseAugment(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { - if (tmpStrValue != "augments") { +void ItemParse::parseAugment(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue != "augments") { return; } @@ -921,8 +872,7 @@ void ItemParse::parseAugment(const std::string &tmpStrValue, pugi::xml_node attr } } -void ItemParse::parseStackSize(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseStackSize(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { if (stringValue == "stacksize") { auto stackSize = pugi::cast<uint16_t>(valueAttribute.value()); if (stackSize > 255) { @@ -933,8 +883,7 @@ void ItemParse::parseStackSize(const std::string &tmpStrValue, pugi::xml_attribu } } -void ItemParse::parseSpecializedMagicLevelPoint(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseSpecializedMagicLevelPoint(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { Abilities &abilities = itemType.getAbilities(); if (stringValue == "deathmagiclevelpoints") { abilities.specializedMagicLevel[combatTypeToIndex(COMBAT_DEATHDAMAGE)] += pugi::cast<int32_t>(valueAttribute.value()); @@ -963,8 +912,7 @@ void ItemParse::parseSpecializedMagicLevelPoint(const std::string &tmpStrValue, } } -void ItemParse::parseMagicShieldCapacity(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseMagicShieldCapacity(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { Abilities &abilities = itemType.getAbilities(); if (stringValue == "magicshieldcapacitypercent") { abilities.magicShieldCapacityPercent += pugi::cast<int32_t>(valueAttribute.value()); @@ -973,8 +921,7 @@ void ItemParse::parseMagicShieldCapacity(const std::string &tmpStrValue, pugi::x } } -void ItemParse::parsePerfecShot(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parsePerfecShot(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { Abilities &abilities = itemType.getAbilities(); if (stringValue == "perfectshotdamage") { abilities.perfectShotDamage = pugi::cast<int32_t>(valueAttribute.value()); @@ -983,41 +930,39 @@ void ItemParse::parsePerfecShot(const std::string &tmpStrValue, pugi::xml_attrib } } -void ItemParse::parseCleavePercent(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseCleavePercent(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { Abilities &abilities = itemType.getAbilities(); if (stringValue == "cleavepercent") { abilities.cleavePercent += pugi::cast<int32_t>(valueAttribute.value()); } } -void ItemParse::parseReflectDamage(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - std::string stringValue = tmpStrValue; +void ItemParse::parseReflectDamage(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { Abilities &abilities = itemType.getAbilities(); if (stringValue == "reflectdamage") { abilities.reflectFlat[combatTypeToIndex(COMBAT_PHYSICALDAMAGE)] += pugi::cast<int32_t>(valueAttribute.value()); } else if (stringValue == "reflectpercentall") { - int32_t value = pugi::cast<int32_t>(valueAttribute.value()); - std::transform(std::begin(abilities.reflectPercent), std::end(abilities.reflectPercent), std::begin(abilities.reflectPercent), [&](const auto &i) { + auto value = pugi::cast<int32_t>(valueAttribute.value()); + std::ranges::transform(abilities.reflectPercent, std::begin(abilities.reflectPercent), [&](const auto &i) { return i + value; }); } } -void ItemParse::parseTransformOnUse(std::string_view tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - if (tmpStrValue == "transformonuse") { +void ItemParse::parseTransformOnUse(std::string_view stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue == "transformonuse") { itemType.m_transformOnUse = pugi::cast<uint16_t>(valueAttribute.value()); } } -void ItemParse::parsePrimaryType(std::string_view tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - if (tmpStrValue == "primarytype") { +void ItemParse::parsePrimaryType(std::string_view stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue == "primarytype") { itemType.m_primaryType = asLowerCaseString(valueAttribute.as_string()); } } -void ItemParse::parseHouseRelated(std::string_view tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { - if (tmpStrValue == "usedbyhouseguests") { +void ItemParse::parseHouseRelated(std::string_view stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue == "usedbyhouseguests") { g_logger().debug("[{}] item {}, used by guests {}", __FUNCTION__, itemType.id, valueAttribute.as_bool()); itemType.m_canBeUsedByGuests = valueAttribute.as_bool(); } @@ -1029,7 +974,6 @@ void ItemParse::createAndRegisterScript(ItemType &itemType, pugi::xml_node attri moveevent = std::make_shared<MoveEvent>(&g_moveEvents().getScriptInterface()); moveevent->setItemId(itemType.id); moveevent->setEventType(eventType); - moveevent->setFromXML(true); if (eventType == MOVE_EVENT_EQUIP) { moveevent->equipFunction = moveevent->EquipItem; @@ -1063,7 +1007,7 @@ void ItemParse::createAndRegisterScript(ItemType &itemType, pugi::xml_node attri } uint32_t fromDamage = 0; uint32_t toDamage = 0; - for (auto subAttributeNode : attributeNode.children()) { + for (const auto &subAttributeNode : attributeNode.children()) { pugi::xml_attribute subKeyAttribute = subAttributeNode.attribute("key"); if (!subKeyAttribute) { continue; @@ -1132,7 +1076,7 @@ void ItemParse::createAndRegisterScript(ItemType &itemType, pugi::xml_node attri std::string token; while (std::getline(ss, token, ',')) { - token.erase(token.begin(), std::find_if(token.begin(), token.end(), [](unsigned char ch) { + token.erase(token.begin(), std::ranges::find_if(token, [](unsigned char ch) { return !std::isspace(ch); })); token.erase(std::find_if(token.rbegin(), token.rend(), [](unsigned char ch) { @@ -1231,14 +1175,14 @@ void ItemParse::createAndRegisterScript(ItemType &itemType, pugi::xml_node attri } if (weapon) { - if (auto weaponWand = dynamic_pointer_cast<WeaponWand>(weapon)) { + if (const auto &weaponWand = dynamic_pointer_cast<WeaponWand>(weapon)) { g_logger().trace("Added weapon damage from '{}', to '{}'", fromDamage, toDamage); weaponWand->setMinChange(fromDamage); weaponWand->setMaxChange(toDamage); weaponWand->configureWeapon(itemType); } - auto combat = weapon->getCombat(); + const auto &combat = weapon->getCombat(); if (combat) { combat->setupChain(weapon); } @@ -1260,15 +1204,15 @@ void ItemParse::createAndRegisterScript(ItemType &itemType, pugi::xml_node attri } } -void ItemParse::parseUnscriptedItems(std::string_view tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { - if (tmpStrValue == "script") { - std::string scriptName = valueAttribute.as_string(); - auto tokens = split(scriptName.data(), ';'); +void ItemParse::parseUnscriptedItems(std::string_view stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType) { + if (stringValue == "script") { + const std::string scriptName = valueAttribute.as_string(); + const auto tokens = split(scriptName, ';'); for (const auto &token : tokens) { if (token == "moveevent") { g_logger().trace("Registering moveevent for item id '{}', name '{}'", itemType.id, itemType.name); MoveEvent_t eventType = MOVE_EVENT_NONE; - for (auto subAttributeNode : attributeNode.children()) { + for (const auto &subAttributeNode : attributeNode.children()) { pugi::xml_attribute subKeyAttribute = subAttributeNode.attribute("key"); if (!subKeyAttribute) { continue; @@ -1296,9 +1240,9 @@ void ItemParse::parseUnscriptedItems(std::string_view tmpStrValue, pugi::xml_nod createAndRegisterScript(itemType, attributeNode, eventType); } } else if (token == "weapon") { - WeaponType_t weaponType; + WeaponType_t weaponType = {}; g_logger().trace("Registering weapon for item id '{}', name '{}'", itemType.id, itemType.name); - for (auto subAttributeNode : attributeNode.children()) { + for (const auto &subAttributeNode : attributeNode.children()) { pugi::xml_attribute subKeyAttribute = subAttributeNode.attribute("key"); if (!subKeyAttribute) { continue; diff --git a/src/items/functions/item/item_parse.hpp b/src/items/functions/item/item_parse.hpp index fb891e58ed6..6fe6fbcccd3 100644 --- a/src/items/functions/item/item_parse.hpp +++ b/src/items/functions/item/item_parse.hpp @@ -258,77 +258,77 @@ const phmap::flat_hash_map<Augment_t, ConfigKey_t> AugmentWithoutValueDescriptio class ItemParse : public Items { public: - static void initParse(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void initParse(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); private: static void parseDummyRate(pugi::xml_node attributeNode, ItemType &itemType); - static void parseType(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseDescription(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseRuneSpellName(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseWeight(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseShowCount(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseArmor(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseDefense(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseExtraDefense(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseAttack(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseRotateTo(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseWrapContainer(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseWrapableTo(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseMovable(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseBlockProjectTile(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parsePickupable(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseFloorChange(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseContainerSize(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseFluidSource(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseWriteables(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseWeaponType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseSlotType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseAmmoType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseShootType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseMagicEffect(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseLootType(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseRange(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseDecayTo(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseDuration(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseTransform(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseCharges(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseShowAttributes(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseHitChance(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseInvisible(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseSpeed(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseHealthAndMana(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseSkills(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseCriticalHit(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseLifeAndManaLeech(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseMaxHitAndManaPoints(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseMagicLevelPoint(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseFieldAbsorbPercent(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseAbsorbPercent(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseSupressDrunk(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseField(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseReplaceable(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseLevelDoor(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseBeds(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseElement(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseWalk(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseAllowDistanceRead(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseImbuement(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseAugment(const std::string &tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseStackSize(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseSpecializedMagicLevelPoint(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseMagicShieldCapacity(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parsePerfecShot(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseCleavePercent(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseReflectDamage(const std::string &tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseTransformOnUse(std::string_view tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parsePrimaryType(std::string_view tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseHouseRelated(std::string_view tmpStrValue, pugi::xml_attribute valueAttribute, ItemType &itemType); - static void parseUnscriptedItems(std::string_view tmpStrValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseType(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseDescription(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseRuneSpellName(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseWeight(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseShowCount(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseArmor(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseDefense(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseExtraDefense(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseAttack(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseRotateTo(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseWrapContainer(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseWrapableTo(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseMovable(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseBlockProjectTile(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parsePickupable(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseFloorChange(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseContainerSize(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseFluidSource(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseWriteables(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseWeaponType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseSlotType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseAmmoType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseShootType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseMagicEffect(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseLootType(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseRange(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseDecayTo(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseDuration(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseTransform(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseCharges(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseShowAttributes(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseHitChance(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseInvisible(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseSpeed(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseHealthAndMana(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseSkills(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseCriticalHit(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseLifeAndManaLeech(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseMaxHitAndManaPoints(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseMagicLevelPoint(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseFieldAbsorbPercent(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseAbsorbPercent(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseSupressDrunk(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseField(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseReplaceable(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseLevelDoor(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseBeds(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseElement(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseWalk(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseAllowDistanceRead(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseImbuement(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseAugment(const std::string &stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseStackSize(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseSpecializedMagicLevelPoint(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseMagicShieldCapacity(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parsePerfecShot(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseCleavePercent(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseReflectDamage(const std::string &stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseTransformOnUse(std::string_view stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parsePrimaryType(std::string_view stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseHouseRelated(std::string_view stringValue, pugi::xml_attribute valueAttribute, ItemType &itemType); + static void parseUnscriptedItems(std::string_view stringValue, pugi::xml_node attributeNode, pugi::xml_attribute valueAttribute, ItemType &itemType); private: // Parent of the function: static void parseField - static std::tuple<ConditionId_t, ConditionType_t> parseFieldConditions(std::string lowerStringValue, pugi::xml_attribute valueAttribute); - static CombatType_t parseFieldCombatType(std::string string, pugi::xml_attribute valueAttribute); - static void parseFieldCombatDamage(std::shared_ptr<ConditionDamage> conditionDamage, std::string stringValue, pugi::xml_node attributeNode); + static std::tuple<ConditionId_t, ConditionType_t> parseFieldConditions(pugi::xml_attribute valueAttribute); + static CombatType_t parseFieldCombatType(pugi::xml_attribute valueAttribute); + static void parseFieldCombatDamage(const std::shared_ptr<ConditionDamage> &conditionDamage, pugi::xml_node attributeNode); static void createAndRegisterScript(ItemType &itemType, pugi::xml_node attributeNode, MoveEvent_t eventType = MOVE_EVENT_NONE, WeaponType_t weaponType = WEAPON_NONE); }; diff --git a/src/items/item.cpp b/src/items/item.cpp index 43c172b8e7d..7439d1edefc 100644 --- a/src/items/item.cpp +++ b/src/items/item.cpp @@ -67,7 +67,7 @@ std::shared_ptr<Item> Item::CreateItem(const uint16_t type, uint16_t count /*= 0 } else if (it.isBed()) { newItem = std::make_shared<BedItem>(type); } else { - auto itemMap = ItemTransformationMap.find(static_cast<ItemID_t>(it.id)); + const auto itemMap = ItemTransformationMap.find(static_cast<ItemID_t>(it.id)); if (itemMap != ItemTransformationMap.end()) { newItem = std::make_shared<Item>(itemMap->second, count); } else { @@ -75,7 +75,7 @@ std::shared_ptr<Item> Item::CreateItem(const uint16_t type, uint16_t count /*= 0 } } } else if (type > 0 && itemPosition) { - auto position = *itemPosition; + const auto position = *itemPosition; g_logger().warn("[Item::CreateItem] Item with id '{}', in position '{}' not exists in the appearances.dat and cannot be created.", type, position.toString()); } else { g_logger().warn("[Item::CreateItem] Item with id '{}' is not registered and cannot be created.", type); @@ -86,19 +86,19 @@ std::shared_ptr<Item> Item::CreateItem(const uint16_t type, uint16_t count /*= 0 bool Item::getImbuementInfo(uint8_t slot, ImbuementInfo* imbuementInfo) const { const CustomAttribute* attribute = getCustomAttribute(std::to_string(ITEM_IMBUEMENT_SLOT + slot)); - auto info = attribute ? attribute->getAttribute<uint32_t>() : 0; + const auto info = attribute ? attribute->getAttribute<uint32_t>() : 0; imbuementInfo->imbuement = g_imbuements().getImbuement(info & 0xFF); imbuementInfo->duration = info >> 8; return imbuementInfo->duration && imbuementInfo->imbuement; } void Item::setImbuement(uint8_t slot, uint16_t imbuementId, uint32_t duration) { - auto valueDuration = (static_cast<int64_t>(duration > 0 ? (duration << 8) | imbuementId : 0)); + const auto valueDuration = (static_cast<int64_t>(duration > 0 ? (duration << 8) | imbuementId : 0)); setCustomAttribute(std::to_string(ITEM_IMBUEMENT_SLOT + slot), valueDuration); } void Item::addImbuement(uint8_t slot, uint16_t imbuementId, uint32_t duration) { - std::shared_ptr<Player> player = getHoldingPlayer(); + const auto &player = getHoldingPlayer(); if (!player) { return; } @@ -151,7 +151,7 @@ std::shared_ptr<Container> Item::CreateItemAsContainer(const uint16_t type, uint return nullptr; } - std::shared_ptr<Container> newItem = std::make_shared<Container>(type, size); + auto newItem = std::make_shared<Container>(type, size); return newItem; } @@ -195,9 +195,9 @@ std::shared_ptr<Item> Item::CreateItem(uint16_t itemId, Position &itemPosition) Item::Item(const uint16_t itemId, uint16_t itemCount /*= 0*/) : id(itemId) { const ItemType &it = items[id]; - auto itemCharges = it.charges; + const auto itemCharges = it.charges; if (it.isFluidContainer() || it.isSplash()) { - auto fluidType = std::clamp<uint16_t>(itemCount, 1, FLUID_INK); + const auto fluidType = std::clamp<uint16_t>(itemCount, 1, FLUID_INK); setAttribute(ItemAttribute_t::FLUIDTYPE, fluidType); } else if (it.stackable) { if (itemCount != 0) { @@ -224,7 +224,7 @@ Item::Item(const std::shared_ptr<Item> &i) : } std::shared_ptr<Item> Item::clone() const { - std::shared_ptr<Item> item = Item::CreateItem(id, count); + const auto &item = Item::CreateItem(id, count); if (item == nullptr) { g_logger().error("[{}] item is nullptr", __FUNCTION__); return nullptr; @@ -237,7 +237,7 @@ std::shared_ptr<Item> Item::clone() const { return item; } -bool Item::equals(std::shared_ptr<Item> compareItem) const { +bool Item::equals(const std::shared_ptr<Item> &compareItem) const { if (!compareItem) { return false; } @@ -282,7 +282,7 @@ void Item::setDefaultSubtype() { setItemCount(1); - auto itemCharges = it.charges; + const auto itemCharges = it.charges; if (itemCharges != 0) { if (it.stackable) { setItemCount(static_cast<uint8_t>(itemCharges)); @@ -305,7 +305,7 @@ void Item::setID(uint16_t newid) { id = newid; const ItemType &it = Item::items[newid]; - uint32_t newDuration = it.decayTime * 1000; + const uint32_t newDuration = it.decayTime * 1000; if (newDuration == 0 && !it.stopTime && it.decayTo < 0) { // We'll get called startDecay anyway so let's schedule it - actually not in all casses @@ -333,15 +333,15 @@ bool Item::isOwner(uint32_t ownerId) const { const auto &player = g_game().getPlayerByID(ownerId); return player && player->getGUID() == getOwnerId(); } - if (auto player = g_game().getPlayerByGUID(ownerId); player) { + if (const auto &player = g_game().getPlayerByGUID(ownerId); player) { return player->getID() == getOwnerId(); } return false; } std::shared_ptr<Cylinder> Item::getTopParent() { - std::shared_ptr<Cylinder> aux = getParent(); - std::shared_ptr<Cylinder> prevaux = std::dynamic_pointer_cast<Cylinder>(shared_from_this()); + auto aux = getParent(); + auto prevaux = std::dynamic_pointer_cast<Cylinder>(shared_from_this()); if (!aux) { return prevaux; } @@ -358,7 +358,7 @@ std::shared_ptr<Cylinder> Item::getTopParent() { } std::shared_ptr<Tile> Item::getTile() { - std::shared_ptr<Cylinder> cylinder = getTopParent(); + auto cylinder = getTopParent(); // get root cylinder if (cylinder && cylinder->getParent()) { cylinder = cylinder->getParent(); @@ -379,7 +379,7 @@ uint16_t Item::getSubType() const { } std::shared_ptr<Player> Item::getHoldingPlayer() { - std::shared_ptr<Cylinder> p = getParent(); + auto p = getParent(); while (p) { if (p->getCreature()) { return p->getCreature()->getPlayer(); @@ -394,7 +394,7 @@ bool Item::isItemStorable() const { if (isStoreItem() || hasOwner()) { return false; } - auto isContainerAndHasSomethingInside = (getContainer() != NULL) && (getContainer()->getItemList().size() > 0); + const auto isContainerAndHasSomethingInside = (getContainer() != nullptr) && (!getContainer()->getItemList().empty()); return (isStowable() || isContainerAndHasSomethingInside); } @@ -771,7 +771,7 @@ Attr_ReadValue Item::readAttr(AttrTypes_t attr, PropStream &propStream) { return ATTR_READ_ERROR; } - setAttribute(AMOUNT, amount); + setAttribute(ItemAttribute_t::AMOUNT, amount); break; } @@ -819,7 +819,7 @@ Attr_ReadValue Item::readAttr(AttrTypes_t attr, PropStream &propStream) { return ATTR_READ_ERROR; } - setAttribute(OWNER, ownerId); + setAttribute(ItemAttribute_t::OWNER, ownerId); break; } @@ -843,7 +843,7 @@ Attr_ReadValue Item::readAttr(AttrTypes_t attr, PropStream &propStream) { bool Item::unserializeAttr(PropStream &propStream) { uint8_t attr_type; while (propStream.read<uint8_t>(attr_type) && attr_type != 0) { - Attr_ReadValue ret = readAttr(static_cast<AttrTypes_t>(attr_type), propStream); + const Attr_ReadValue ret = readAttr(static_cast<AttrTypes_t>(attr_type), propStream); if (ret == ATTR_READ_ERROR) { return false; } else if (ret == ATTR_READ_END) { @@ -859,7 +859,7 @@ bool Item::unserializeItemNode(OTB::Loader &, const OTB::Node &, PropStream &pro void Item::serializeAttr(PropWriteStream &propWriteStream) const { const ItemType &it = items[id]; - if (auto timeStamp = getAttribute<int64_t>(ItemAttribute_t::STORE)) { + if (const auto timeStamp = getAttribute<int64_t>(ItemAttribute_t::STORE)) { propWriteStream.write<uint8_t>(ATTR_STORE); propWriteStream.write<int64_t>(timeStamp); } @@ -868,13 +868,13 @@ void Item::serializeAttr(PropWriteStream &propWriteStream) const { propWriteStream.write<uint8_t>(getSubType()); } - if (auto charges = getAttribute<uint16_t>(ItemAttribute_t::CHARGES)) { + if (const auto charges = getAttribute<uint16_t>(ItemAttribute_t::CHARGES)) { propWriteStream.write<uint8_t>(ATTR_CHARGES); propWriteStream.write<uint16_t>(charges); } if (it.movable) { - if (auto actionId = getAttribute<uint16_t>(ItemAttribute_t::ACTIONID)) { + if (const auto actionId = getAttribute<uint16_t>(ItemAttribute_t::ACTIONID)) { propWriteStream.write<uint8_t>(ATTR_ACTION_ID); propWriteStream.write<uint16_t>(actionId); } @@ -886,7 +886,7 @@ void Item::serializeAttr(PropWriteStream &propWriteStream) const { propWriteStream.writeString(text); } - if (const uint64_t writtenDate = getAttribute<uint64_t>(ItemAttribute_t::DATE)) { + if (const auto writtenDate = getAttribute<uint64_t>(ItemAttribute_t::DATE)) { propWriteStream.write<uint8_t>(ATTR_WRITTENDATE); propWriteStream.write<uint64_t>(writtenDate); } @@ -908,7 +908,7 @@ void Item::serializeAttr(PropWriteStream &propWriteStream) const { propWriteStream.write<int32_t>(getDuration()); } - if (auto decayState = getDecaying(); + if (const auto decayState = getDecaying(); decayState == DECAYING_TRUE || decayState == DECAYING_PENDING) { propWriteStream.write<uint8_t>(ATTR_DECAYING_STATE); propWriteStream.write<uint8_t>(decayState); @@ -989,17 +989,17 @@ void Item::serializeAttr(PropWriteStream &propWriteStream) const { propWriteStream.write<uint8_t>(getTier()); } - if (hasAttribute(AMOUNT)) { + if (hasAttribute(ItemAttribute_t::AMOUNT)) { propWriteStream.write<uint8_t>(ATTR_AMOUNT); - propWriteStream.write<uint16_t>(getAttribute<uint16_t>(AMOUNT)); + propWriteStream.write<uint16_t>(getAttribute<uint16_t>(ItemAttribute_t::AMOUNT)); } - if (hasAttribute(STORE_INBOX_CATEGORY)) { + if (hasAttribute(ItemAttribute_t::STORE_INBOX_CATEGORY)) { propWriteStream.write<uint8_t>(ATTR_STORE_INBOX_CATEGORY); propWriteStream.writeString(getString(ItemAttribute_t::STORE_INBOX_CATEGORY)); } - if (hasAttribute(OWNER)) { + if (hasAttribute(ItemAttribute_t::OWNER)) { propWriteStream.write<uint8_t>(ATTR_OWNER); propWriteStream.write<uint32_t>(getAttribute<uint32_t>(ItemAttribute_t::OWNER)); } @@ -1025,7 +1025,7 @@ void Item::serializeAttr(PropWriteStream &propWriteStream) const { } } -void Item::setOwner(std::shared_ptr<Creature> owner) { +void Item::setOwner(const std::shared_ptr<Creature> &owner) { auto ownerId = owner->getID(); if (owner->getPlayer()) { ownerId = owner->getPlayer()->getGUID(); @@ -1033,7 +1033,7 @@ void Item::setOwner(std::shared_ptr<Creature> owner) { setOwner(ownerId); } -bool Item::isOwner(std::shared_ptr<Creature> owner) const { +bool Item::isOwner(const std::shared_ptr<Creature> &owner) const { if (!owner) { return false; } @@ -1059,7 +1059,7 @@ std::string Item::getOwnerName() const { return ""; } - auto creature = g_game().getCreatureByID(getOwnerId()); + const auto &creature = g_game().getCreatureByID(getOwnerId()); if (creature) { return creature->getName(); } @@ -1123,7 +1123,7 @@ void Item::checkDecayMapItemOnMove() { } uint32_t Item::getWeight() const { - uint32_t baseWeight = getBaseWeight(); + const uint32_t baseWeight = getBaseWeight(); if (isStackable()) { return baseWeight * std::max<uint32_t>(1, getItemCount()); } @@ -1131,7 +1131,7 @@ uint32_t Item::getWeight() const { } std::vector<std::pair<std::string, std::string>> -Item::getDescriptions(const ItemType &it, std::shared_ptr<Item> item /*= nullptr*/) { +Item::getDescriptions(const ItemType &it, const std::shared_ptr<Item> &item /*= nullptr*/) { std::ostringstream ss; std::vector<std::pair<std::string, std::string>> descriptions; bool isTradeable = true; @@ -1410,7 +1410,7 @@ Item::getDescriptions(const ItemType &it, std::shared_ptr<Item> item /*= nullptr for (uint8_t i = 0; i < item->getImbuementSlot(); ++i) { slotName = fmt::format("Imbuement Slot {}", i + 1); ss.str(""); - const auto castItem = item; + const auto &castItem = item; if (!castItem) { continue; } @@ -1905,7 +1905,7 @@ Item::getDescriptions(const ItemType &it, std::shared_ptr<Item> item /*= nullptr return descriptions; } -std::string Item::parseImbuementDescription(std::shared_ptr<Item> item) { +std::string Item::parseImbuementDescription(const std::shared_ptr<Item> &item) { std::ostringstream s; if (item && item->getImbuementSlot() >= 1) { s << std::endl @@ -1927,7 +1927,7 @@ std::string Item::parseImbuementDescription(std::shared_ptr<Item> item) { continue; } - int minutes = imbuementInfo.duration / 60; + const int minutes = imbuementInfo.duration / 60; int hours = minutes / 60; s << fmt::format("{} {} {:02}:{:02}h", baseImbuement->name, imbuementInfo.imbuement->getName(), hours, minutes % 60); } @@ -1942,12 +1942,12 @@ bool Item::isSavedToHouses() { return it.movable || it.isWrappable() || it.isCarpet() || getDoor() || (getContainer() && !getContainer()->empty()) || it.canWriteText || getBed() || it.m_transformOnUse; } -SoundEffect_t Item::getMovementSound(std::shared_ptr<Cylinder> toCylinder) const { +SoundEffect_t Item::getMovementSound(const std::shared_ptr<Cylinder> &toCylinder) const { if (!toCylinder) { return SoundEffect_t::ITEM_MOVE_DEFAULT; } - if (std::shared_ptr<Container> toContainer = toCylinder->getContainer(); + if (const auto &toContainer = toCylinder->getContainer(); toContainer && toContainer->getHoldingPlayer()) { return SoundEffect_t::ITEM_MOVE_BACKPACK; } @@ -2004,7 +2004,7 @@ SoundEffect_t Item::getMovementSound(std::shared_ptr<Cylinder> toCylinder) const return SoundEffect_t::ITEM_MOVE_DEFAULT; } -std::string Item::parseClassificationDescription(std::shared_ptr<Item> item) { +std::string Item::parseClassificationDescription(const std::shared_ptr<Item> &item) { std::ostringstream string; if (item && item->getClassification() >= 1) { string << std::endl @@ -2037,35 +2037,35 @@ std::string Item::parseShowDurationSpeed(int32_t speed, bool &begin) { return description.str(); } -std::string Item::parseShowDuration(std::shared_ptr<Item> item) { +std::string Item::parseShowDuration(const std::shared_ptr<Item> &item) { if (!item) { return {}; } std::ostringstream description; - uint32_t duration = item->getDuration() / 1000; + const uint32_t duration = item->getDuration() / 1000; if (item && item->hasAttribute(ItemAttribute_t::DURATION) && duration > 0) { description << " that will expire in "; if (duration >= 86400) { - uint16_t days = duration / 86400; - uint16_t hours = (duration % 86400) / 3600; + const uint16_t days = duration / 86400; + const uint16_t hours = (duration % 86400) / 3600; description << days << " day" << (days != 1 ? "s" : ""); if (hours > 0) { description << " and " << hours << " hour" << (hours != 1 ? "s" : ""); } } else if (duration >= 3600) { - uint16_t hours = duration / 3600; - uint16_t minutes = (duration % 3600) / 60; + const uint16_t hours = duration / 3600; + const uint16_t minutes = (duration % 3600) / 60; description << hours << " hour" << (hours != 1 ? "s" : ""); if (minutes > 0) { description << " and " << minutes << " minute" << (minutes != 1 ? "s" : ""); } } else if (duration >= 60) { - uint16_t minutes = duration / 60; + const uint16_t minutes = duration / 60; description << minutes << " minute" << (minutes != 1 ? "s" : ""); - uint16_t seconds = duration % 60; + const uint16_t seconds = duration % 60; if (seconds > 0) { description << " and " << seconds << " second" << (seconds != 1 ? "s" : ""); @@ -2080,14 +2080,14 @@ std::string Item::parseShowDuration(std::shared_ptr<Item> item) { return description.str(); } -std::string Item::parseShowAttributesDescription(std::shared_ptr<Item> item, const uint16_t itemId) { +std::string Item::parseShowAttributesDescription(const std::shared_ptr<Item> &item, const uint16_t itemId) { std::ostringstream itemDescription; const ItemType &itemType = Item::items[itemId]; if (itemType.armor != 0 || (item && item->getArmor() != 0) || itemType.showAttributes) { bool begin = itemType.isQuiver() ? false : true; - int32_t armor = (item ? item->getArmor() : itemType.armor); + const int32_t armor = (item ? item->getArmor() : itemType.armor); if (armor != 0) { if (begin) { itemDescription << " (Arm:" << armor; @@ -2114,7 +2114,7 @@ std::string Item::parseShowAttributesDescription(std::shared_ptr<Item> item, con } for (uint8_t i = SKILL_CRITICAL_HIT_CHANCE; i <= SKILL_LAST; i++) { - auto skill = item ? item->getSkill(static_cast<skills_t>(i)) : itemType.getSkill(static_cast<skills_t>(i)); + const auto skill = item ? item->getSkill(static_cast<skills_t>(i)) : itemType.getSkill(static_cast<skills_t>(i)); if (!skill) { continue; } @@ -2308,8 +2308,8 @@ std::string Item::parseShowAttributesDescription(std::shared_ptr<Item> item, con return itemDescription.str(); } -std::string Item::getDescription(const ItemType &it, int32_t lookDistance, std::shared_ptr<Item> item /*= nullptr*/, int32_t subType /*= -1*/, bool addArticle /*= true*/) { - std::string text = ""; +std::string Item::getDescription(const ItemType &it, int32_t lookDistance, const std::shared_ptr<Item> &item /*= nullptr*/, int32_t subType /*= -1*/, bool addArticle /*= true*/) { + std::string text; std::ostringstream s; s << getNameDescription(it, item, subType, addArticle); @@ -2320,7 +2320,7 @@ std::string Item::getDescription(const ItemType &it, int32_t lookDistance, std:: if (it.isRune()) { if (it.runeLevel > 0 || it.runeMagLevel > 0) { - if (const auto rune = g_spells().getRuneSpell(it.id)) { + if (const auto &rune = g_spells().getRuneSpell(it.id)) { int32_t tmpSubType = subType; if (item) { tmpSubType = item->getSubType(); @@ -3076,7 +3076,7 @@ std::string Item::getDescription(int32_t lookDistance) { return getDescription(it, lookDistance, getItem()); } -std::string Item::getNameDescription(const ItemType &it, std::shared_ptr<Item> item /*= nullptr*/, int32_t subType /*= -1*/, bool addArticle /*= true*/) { +std::string Item::getNameDescription(const ItemType &it, const std::shared_ptr<Item> &item /*= nullptr*/, int32_t subType /*= -1*/, bool addArticle /*= true*/) { if (item) { subType = item->getSubType(); } @@ -3140,9 +3140,9 @@ std::string Item::getWeightDescription(uint32_t weight) const { } std::string Item::getWeightDescription() const { - uint32_t weight = getWeight(); + const uint32_t weight = getWeight(); if (weight == 0) { - return std::string(); + return {}; } return getWeightDescription(weight); } @@ -3227,9 +3227,9 @@ std::shared_ptr<Item> Item::transform(uint16_t itemId, uint16_t itemCount /*= -1 return nullptr; } - std::shared_ptr<Tile> fromTile = cylinder->getTile(); + const auto &fromTile = cylinder->getTile(); if (fromTile) { - auto it = g_game().browseFields.find(fromTile); + const auto it = g_game().browseFields.find(fromTile); if (it != g_game().browseFields.end() && it->second.lock() == cylinder) { cylinder = fromTile; } @@ -3242,8 +3242,8 @@ std::shared_ptr<Item> Item::transform(uint16_t itemId, uint16_t itemCount /*= -1 newItem = Item::CreateItem(itemId, itemCount); } - int32_t itemIndex = cylinder->getThingIndex(static_self_cast<Item>()); - auto duration = getDuration(); + const int32_t itemIndex = cylinder->getThingIndex(static_self_cast<Item>()); + const auto duration = getDuration(); if (duration > 0) { newItem->setDuration(duration); } @@ -3281,16 +3281,17 @@ bool Item::hasMarketAttributes() const { } bool Item::isInsideDepot(bool includeInbox /* = false*/) { - if (std::shared_ptr<Container> thisContainer = getContainer(); thisContainer && (thisContainer->getDepotLocker() || thisContainer->isDepotChest() || (includeInbox && thisContainer->isInbox()))) { + const auto &thisContainer = getContainer(); + if (thisContainer && (thisContainer->getDepotLocker() || thisContainer->isDepotChest() || (includeInbox && thisContainer->isInbox()))) { return true; } - std::shared_ptr<Cylinder> cylinder = getParent(); + const auto &cylinder = getParent(); if (!cylinder) { return false; } - std::shared_ptr<Container> container = cylinder->getContainer(); + auto container = cylinder->getContainer(); if (!container) { return false; } @@ -3307,7 +3308,7 @@ bool Item::isInsideDepot(bool includeInbox /* = false*/) { } void Item::updateTileFlags() { - if (auto tile = getTile()) { + if (const auto &tile = getTile()) { tile->updateTileFlags(static_self_cast<Item>()); } } diff --git a/src/items/item.hpp b/src/items/item.hpp index aa4f10ec4aa..8234d8890df 100644 --- a/src/items/item.hpp +++ b/src/items/item.hpp @@ -56,7 +56,7 @@ class ItemProperties { return attributePtr->hasAttribute(type); } - void removeAttribute(ItemAttribute_t type) { + void removeAttribute(ItemAttribute_t type) const { if (attributePtr) { attributePtr->removeAttribute(type); } @@ -104,7 +104,7 @@ class ItemProperties { return !getCustomAttributeMap().empty(); } - bool removeCustomAttribute(const std::string &attributeName) { + bool removeCustomAttribute(const std::string &attributeName) const { if (!attributePtr) { return false; } @@ -117,7 +117,7 @@ class ItemProperties { } int32_t getDuration() const { - ItemDecayState_t decayState = getDecaying(); + const ItemDecayState_t decayState = getDecaying(); if (decayState == DECAYING_TRUE || decayState == DECAYING_STOPPING) { return std::max<int32_t>(0, getAttribute<int32_t>(ItemAttribute_t::DURATION_TIMESTAMP) - static_cast<int32_t>(OTSYS_TIME())); } else { @@ -215,27 +215,27 @@ class ItemProperties { class Item : virtual public Thing, public ItemProperties, public SharedObject { public: // Factory member to create item of right type based on type - static std::shared_ptr<Item> CreateItem(const uint16_t type, uint16_t count = 0, Position* itemPosition = nullptr); - static std::shared_ptr<Container> CreateItemAsContainer(const uint16_t type, uint16_t size); + static std::shared_ptr<Item> CreateItem(uint16_t type, uint16_t count = 0, Position* itemPosition = nullptr); + static std::shared_ptr<Container> CreateItemAsContainer(uint16_t type, uint16_t size); static std::shared_ptr<Item> CreateItem(uint16_t itemId, Position &itemPosition); static Items items; // Constructor for items - Item(const uint16_t type, uint16_t count = 0); - Item(const std::shared_ptr<Item> &i); + explicit Item(uint16_t type, uint16_t count = 0); + explicit Item(const std::shared_ptr<Item> &i); virtual std::shared_ptr<Item> clone() const; - virtual ~Item() = default; + ~Item() override = default; // non-assignable Item &operator=(const Item &) = delete; - bool equals(std::shared_ptr<Item> compareItem) const; + bool equals(const std::shared_ptr<Item> &compareItem) const; - std::shared_ptr<Item> getItem() override final { + std::shared_ptr<Item> getItem() final { return static_self_cast<Item>(); } - std::shared_ptr<const Item> getItem() const override final { + std::shared_ptr<const Item> getItem() const final { return static_self_cast<Item>(); } virtual std::shared_ptr<Teleport> getTeleport() { @@ -259,13 +259,13 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { bool isSavedToHouses(); - SoundEffect_t getMovementSound(std::shared_ptr<Cylinder> toCylinder) const; + SoundEffect_t getMovementSound(const std::shared_ptr<Cylinder> &toCylinder) const; void setIsLootTrackeable(bool value) { isLootTrackeable = value; } - bool getIsLootTrackeable() { + bool getIsLootTrackeable() const { return isLootTrackeable; } @@ -273,7 +273,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { setAttribute(ItemAttribute_t::OWNER, owner); } - void setOwner(std::shared_ptr<Creature> owner); + void setOwner(const std::shared_ptr<Creature> &owner); virtual uint32_t getOwnerId() const; @@ -281,7 +281,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { std::string getOwnerName() const; - bool isOwner(std::shared_ptr<Creature> owner) const; + bool isOwner(const std::shared_ptr<Creature> &owner) const; bool hasOwner() const { return getOwnerId() != 0; @@ -291,24 +291,24 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { return isStoreItem() || hasOwner(); } - static std::string parseAugmentDescription(std::shared_ptr<Item> item, bool inspect = false) { + static std::string parseAugmentDescription(const std::shared_ptr<Item> &item, bool inspect = false) { if (!item) { return ""; } return items[item->getID()].parseAugmentDescription(inspect); } - static std::string parseImbuementDescription(std::shared_ptr<Item> item); + static std::string parseImbuementDescription(const std::shared_ptr<Item> &item); static std::string parseShowDurationSpeed(int32_t speed, bool &begin); - static std::string parseShowDuration(std::shared_ptr<Item> item); - static std::string parseShowAttributesDescription(std::shared_ptr<Item> item, const uint16_t itemId); - static std::string parseClassificationDescription(std::shared_ptr<Item> item); + static std::string parseShowDuration(const std::shared_ptr<Item> &item); + static std::string parseShowAttributesDescription(const std::shared_ptr<Item> &item, uint16_t itemId); + static std::string parseClassificationDescription(const std::shared_ptr<Item> &item); - static std::vector<std::pair<std::string, std::string>> getDescriptions(const ItemType &it, std::shared_ptr<Item> item = nullptr); - static std::string getDescription(const ItemType &it, int32_t lookDistance, std::shared_ptr<Item> item = nullptr, int32_t subType = -1, bool addArticle = true); - static std::string getNameDescription(const ItemType &it, std::shared_ptr<Item> item = nullptr, int32_t subType = -1, bool addArticle = true); + static std::vector<std::pair<std::string, std::string>> getDescriptions(const ItemType &it, const std::shared_ptr<Item> &item = nullptr); + static std::string getDescription(const ItemType &it, int32_t lookDistance, const std::shared_ptr<Item> &item = nullptr, int32_t subType = -1, bool addArticle = true); + static std::string getNameDescription(const ItemType &it, const std::shared_ptr<Item> &item = nullptr, int32_t subType = -1, bool addArticle = true); static std::string getWeightDescription(const ItemType &it, uint32_t weight, uint32_t count = 1); - std::string getDescription(int32_t lookDistance) override final; + std::string getDescription(int32_t lookDistance) final; std::string getNameDescription(); std::string getWeightDescription() const; @@ -319,10 +319,10 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { virtual void serializeAttr(PropWriteStream &propWriteStream) const; - bool isPushable() override final { + bool isPushable() final { return isMovable(); } - int32_t getThrowRange() const override final { + int32_t getThrowRange() const final { return (isPickupable() ? 15 : 2); } @@ -387,17 +387,17 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { } int32_t getSpeed() const { - int32_t value = items[id].getSpeed(); + const int32_t value = items[id].getSpeed(); return value; } int32_t getSkill(skills_t skill) const { - int32_t value = items[id].getSkill(skill); + const int32_t value = items[id].getSkill(skill); return value; } int32_t getStat(stats_t stat) const { - int32_t value = items[id].getStat(stat); + const int32_t value = items[id].getStat(stat); return value; } @@ -430,7 +430,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { } std::vector<std::shared_ptr<AugmentInfo>> getAugmentsBySpellNameAndType(const std::string &spellName, Augment_t augmentType) const { std::vector<std::shared_ptr<AugmentInfo>> augments; - for (auto &augment : items[id].augments) { + for (const auto &augment : items[id].augments) { if (strcasecmp(augment->spellName.c_str(), spellName.c_str()) == 0 && augment->type == augmentType) { augments.push_back(augment); } @@ -440,7 +440,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { } std::vector<std::shared_ptr<AugmentInfo>> getAugmentsBySpellName(const std::string &spellName) const { std::vector<std::shared_ptr<AugmentInfo>> augments; - for (auto &augment : items[id].augments) { + for (const auto &augment : items[id].augments) { if (strcasecmp(augment->spellName.c_str(), spellName.c_str()) == 0) { augments.push_back(augment); } @@ -565,7 +565,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { } return items[id].name; } - const std::string getPluralName() const { + std::string getPluralName() const { if (hasAttribute(ItemAttribute_t::PLURALNAME)) { return getString(ItemAttribute_t::PLURALNAME); } @@ -616,7 +616,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { void addUniqueId(uint16_t uniqueId); void setDefaultDuration() { - uint32_t duration = getDefaultDuration(); + const uint32_t duration = getDefaultDuration(); if (duration != 0) { setDuration(duration); } @@ -634,7 +634,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { return true; } virtual void onRemoved(); - virtual void onTradeEvent(TradeEvents_t, std::shared_ptr<Player>) { } + virtual void onTradeEvent(TradeEvents_t, const std::shared_ptr<Player> &) { } virtual void startDecaying(); virtual void stopDecaying(); @@ -663,7 +663,7 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { std::shared_ptr<Cylinder> getTopParent(); std::shared_ptr<Tile> getTile() override; bool isRemoved() override { - auto parent = getParent(); + const auto &parent = getParent(); if (parent) { return parent->isRemoved(); } @@ -695,8 +695,8 @@ class Item : virtual public Thing, public ItemProperties, public SharedObject { void clearImbuement(uint8_t slot, uint16_t imbuementId) { return setImbuement(slot, imbuementId, 0); } - bool hasImbuementType(ImbuementTypes_t imbuementType, uint16_t imbuementTier) { - auto it = items[id].imbuementTypes.find(imbuementType); + bool hasImbuementType(ImbuementTypes_t imbuementType, uint16_t imbuementTier) const { + const auto it = items[id].imbuementTypes.find(imbuementType); if (it != items[id].imbuementTypes.end()) { return (it->second >= imbuementTier); } diff --git a/src/items/items.cpp b/src/items/items.cpp index 43dfeabf2dd..c498ef9d8fb 100644 --- a/src/items/items.cpp +++ b/src/items/items.cpp @@ -23,7 +23,7 @@ void Items::clear() { ladders.clear(); dummys.clear(); nameToItems.clear(); - g_moveEvents().clear(true); + g_moveEvents().clear(); g_weapons().clear(true); } @@ -57,15 +57,15 @@ LootTypeNames lootTypeNames = { { "unassigned", ITEM_TYPE_UNASSIGNED }, }; -ItemTypes_t Items::getLootType(const std::string &strValue) { - auto lootType = lootTypeNames.find(strValue); +ItemTypes_t Items::getLootType(const std::string &strValue) const { + const auto lootType = lootTypeNames.find(strValue); if (lootType != lootTypeNames.end()) { return lootType->second; } return ITEM_TYPE_NONE; } -const std::string Items::getAugmentNameByType(Augment_t augmentType) { +std::string Items::getAugmentNameByType(Augment_t augmentType) { std::string augmentTypeName = magic_enum::enum_name(augmentType).data(); augmentTypeName = toStartCaseWithSpace(augmentTypeName); if (!isAugmentWithoutValueDescription(augmentType)) { @@ -153,7 +153,7 @@ void Items::loadFromProtobuf() { // This attribute is only used on 10x protocol, so we should not waste our time iterating it when it's disabled. if (supportAnimation) { for (uint32_t frame_it = 0; frame_it < object.frame_group_size(); ++frame_it) { - FrameGroup objectFrame = object.frame_group(frame_it); + const FrameGroup &objectFrame = object.frame_group(frame_it); if (!objectFrame.has_sprite_info()) { continue; } @@ -243,7 +243,7 @@ bool Items::loadFromXml() { return false; } - for (auto itemNode : doc.child("items").children()) { + for (const auto itemNode : doc.child("items").children()) { if (auto idAttribute = itemNode.attribute("id")) { parseItemNode(itemNode, pugi::cast<uint16_t>(idAttribute.value())); continue; @@ -263,8 +263,8 @@ bool Items::loadFromXml() { continue; } - uint16_t id = pugi::cast<uint16_t>(fromIdAttribute.value()); - uint16_t toId = pugi::cast<uint16_t>(toIdAttribute.value()); + auto id = pugi::cast<uint16_t>(fromIdAttribute.value()); + const auto toId = pugi::cast<uint16_t>(toIdAttribute.value()); while (id <= toId) { parseItemNode(itemNode, id++); } @@ -280,7 +280,7 @@ void Items::buildInventoryList() { } } inventory.shrink_to_fit(); - std::sort(inventory.begin(), inventory.end()); + std::ranges::sort(inventory); } void Items::parseItemNode(const pugi::xml_node &itemNode, uint16_t id) { @@ -299,10 +299,10 @@ void Items::parseItemNode(const pugi::xml_node &itemNode, uint16_t id) { return; } - if (std::string xmlName = itemNode.attribute("name").as_string(); + if (const std::string xmlName = itemNode.attribute("name").as_string(); !xmlName.empty() && itemType.name != xmlName) { if (!itemType.name.empty()) { - if (auto it = std::find_if(nameToItems.begin(), nameToItems.end(), [id](const auto nameMapIt) { + if (const auto it = std::ranges::find_if(nameToItems, [id](const auto nameMapIt) { return nameMapIt.second == id; }); it != nameToItems.end()) { @@ -315,28 +315,28 @@ void Items::parseItemNode(const pugi::xml_node &itemNode, uint16_t id) { } itemType.loaded = true; - pugi::xml_attribute articleAttribute = itemNode.attribute("article"); + const pugi::xml_attribute articleAttribute = itemNode.attribute("article"); if (articleAttribute) { itemType.article = articleAttribute.as_string(); } - pugi::xml_attribute pluralAttribute = itemNode.attribute("plural"); + const pugi::xml_attribute pluralAttribute = itemNode.attribute("plural"); if (pluralAttribute) { itemType.pluralName = pluralAttribute.as_string(); } - for (auto attributeNode : itemNode.children()) { - pugi::xml_attribute keyAttribute = attributeNode.attribute("key"); + for (const auto &attributeNode : itemNode.children()) { + const pugi::xml_attribute keyAttribute = attributeNode.attribute("key"); if (!keyAttribute) { continue; } - pugi::xml_attribute valueAttribute = attributeNode.attribute("value"); + const pugi::xml_attribute valueAttribute = attributeNode.attribute("value"); if (!valueAttribute) { continue; } - std::string tmpStrValue = asLowerCaseString(keyAttribute.as_string()); + const std::string tmpStrValue = asLowerCaseString(keyAttribute.as_string()); auto parseAttribute = ItemParseAttributesMap.find(tmpStrValue); if (parseAttribute != ItemParseAttributesMap.end()) { ItemParse::initParse(tmpStrValue, attributeNode, valueAttribute, itemType); @@ -366,7 +366,7 @@ const ItemType &Items::getItemType(size_t id) const { } uint16_t Items::getItemIdByName(const std::string &name) { - auto result = nameToItems.find(asLowerCaseString(name)); + const auto result = nameToItems.find(asLowerCaseString(name)); if (result == nameToItems.end()) { return 0; diff --git a/src/items/items.hpp b/src/items/items.hpp index 0d6f692d308..d8096b9d104 100644 --- a/src/items/items.hpp +++ b/src/items/items.hpp @@ -10,6 +10,7 @@ #pragma once #include "config/configmanager.hpp" +#include "config/config_enums.hpp" #include "utils/utils_definitions.hpp" #include "declarations.hpp" #include "game/movement/position.hpp" @@ -110,7 +111,7 @@ class ItemType { ItemType(const ItemType &other) = delete; ItemType &operator=(const ItemType &other) = delete; - ItemType(ItemType &&other) = default; + ItemType(ItemType &&other) noexcept = default; ItemType &operator=(ItemType &&other) = default; bool isGroundTile() const { @@ -255,7 +256,7 @@ class ItemType { std::string parseAugmentDescription(bool inspect = false) const; std::string getFormattedAugmentDescription(const std::shared_ptr<AugmentInfo> &augmentInfo) const; - void addAugment(std::string spellName, Augment_t augmentType, int32_t value) { + void addAugment(const std::string &spellName, Augment_t augmentType, int32_t value) { auto augmentInfo = std::make_shared<AugmentInfo>(spellName, augmentType, value); augments.emplace_back(augmentInfo); } @@ -415,7 +416,7 @@ class Items { uint16_t getItemIdByName(const std::string &name); - ItemTypes_t getLootType(const std::string &strValue); + ItemTypes_t getLootType(const std::string &strValue) const; bool loadFromXml(); void parseItemNode(const pugi::xml_node &itemNode, uint16_t id); @@ -445,7 +446,7 @@ class Items { return dummys; } - static const std::string getAugmentNameByType(Augment_t augmentType); + static std::string getAugmentNameByType(Augment_t augmentType); static bool isAugmentWithoutValueDescription(Augment_t augmentType) { static std::vector<Augment_t> vector = { @@ -454,7 +455,7 @@ class Items { Augment_t::StrongImpact, }; - return std::find(vector.begin(), vector.end(), augmentType) != vector.end(); + return std::ranges::find(vector, augmentType) != vector.end(); } private: diff --git a/src/items/items_classification.hpp b/src/items/items_classification.hpp index 601abd328ed..54521fd7675 100644 --- a/src/items/items_classification.hpp +++ b/src/items/items_classification.hpp @@ -17,7 +17,7 @@ struct TierInfo { }; // Classification class for forging system and market. -class ItemClassification { +class ItemClassification final { public: ItemClassification() = default; explicit ItemClassification(uint8_t id) : @@ -32,6 +32,6 @@ class ItemClassification { table.convergenceTransferPrice = convergenceTransferPrice; } - uint8_t id; - std::map<uint8_t, TierInfo> tiers; + uint8_t id {}; + std::map<uint8_t, TierInfo> tiers {}; }; diff --git a/src/items/items_definitions.hpp b/src/items/items_definitions.hpp index 7968e5cd705..35c6b0f293d 100644 --- a/src/items/items_definitions.hpp +++ b/src/items/items_definitions.hpp @@ -621,7 +621,7 @@ enum ItemParseAttributes_t { }; struct ImbuementInfo { - Imbuement* imbuement; + Imbuement* imbuement {}; uint32_t duration = 0; }; @@ -629,7 +629,7 @@ struct AugmentInfo { AugmentInfo(std::string spellName, Augment_t type, int32_t value) : spellName(std::move(spellName)), type(type), value(value) { } - std::string spellName; + std::string spellName {}; Augment_t type; - int32_t value; + int32_t value {}; }; diff --git a/src/items/thing.cpp b/src/items/thing.cpp index 647f312b227..b4c1275d933 100644 --- a/src/items/thing.cpp +++ b/src/items/thing.cpp @@ -11,7 +11,7 @@ #include "items/tile.hpp" const Position &Thing::getPosition() { - std::shared_ptr<Tile> tile = getTile(); + const auto &tile = getTile(); if (!tile) { return Tile::nullptr_tile->getPosition(); } diff --git a/src/items/tile.cpp b/src/items/tile.cpp index 40d3ce86a19..efb1a2401b4 100644 --- a/src/items/tile.cpp +++ b/src/items/tile.cpp @@ -55,7 +55,7 @@ bool Tile::hasProperty(ItemProperty prop) const { } } -bool Tile::hasProperty(std::shared_ptr<Item> exclude, ItemProperty prop) const { +bool Tile::hasProperty(const std::shared_ptr<Item> &exclude, ItemProperty prop) const { if (!exclude) { g_logger().error("[{}]: exclude is nullptr", __FUNCTION__); return false; @@ -68,7 +68,7 @@ bool Tile::hasProperty(std::shared_ptr<Item> exclude, ItemProperty prop) const { } if (const TileItemVector* items = getItemList()) { - for (auto &item : *items) { + for (const auto &item : *items) { if (!item) { g_logger().error("Tile::hasProperty: tile {} has an item which is nullptr", tilePos.toString()); continue; @@ -96,7 +96,7 @@ bool Tile::hasHeight(uint32_t n) const { } if (const TileItemVector* items = getItemList()) { - for (auto &item : *items) { + for (const auto &item : *items) { if (item->hasProperty(CONST_PROP_HASHEIGHT)) { ++height; } @@ -147,9 +147,9 @@ std::shared_ptr<Teleport> Tile::getTeleportItem() const { } if (const TileItemVector* items = getItemList()) { - for (auto it = items->rbegin(), end = items->rend(); it != end; ++it) { - if ((*it)->getTeleport()) { - return (*it)->getTeleport(); + for (const auto &item : std::ranges::reverse_view(*items)) { + if (item->getTeleport()) { + return item->getTeleport(); } } } @@ -166,9 +166,9 @@ std::shared_ptr<MagicField> Tile::getFieldItem() const { } if (const TileItemVector* items = getItemList()) { - for (auto it = items->rbegin(), end = items->rend(); it != end; ++it) { - if ((*it)->getMagicField()) { - return (*it)->getMagicField(); + for (const auto &item : std::ranges::reverse_view(*items)) { + if (item->getMagicField()) { + return item->getMagicField(); } } } @@ -185,9 +185,9 @@ std::shared_ptr<TrashHolder> Tile::getTrashHolder() const { } if (const TileItemVector* items = getItemList()) { - for (auto it = items->rbegin(), end = items->rend(); it != end; ++it) { - if ((*it)->getTrashHolder()) { - return (*it)->getTrashHolder(); + for (const auto &item : std::ranges::reverse_view(*items)) { + if (item->getTrashHolder()) { + return item->getTrashHolder(); } } } @@ -204,9 +204,9 @@ std::shared_ptr<Mailbox> Tile::getMailbox() const { } if (const TileItemVector* items = getItemList()) { - for (auto it = items->rbegin(), end = items->rend(); it != end; ++it) { - if ((*it)->getMailbox()) { - return (*it)->getMailbox(); + for (const auto &item : std::ranges::reverse_view(*items)) { + if (item->getMailbox()) { + return item->getMailbox(); } } } @@ -223,9 +223,9 @@ std::shared_ptr<BedItem> Tile::getBedItem() const { } if (const TileItemVector* items = getItemList()) { - for (auto it = items->rbegin(), end = items->rend(); it != end; ++it) { - if ((*it)->getBed()) { - return (*it)->getBed(); + for (const auto &item : std::ranges::reverse_view(*items)) { + if (item->getBed()) { + return item->getBed(); } } } @@ -250,23 +250,23 @@ std::shared_ptr<Creature> Tile::getBottomCreature() const { return nullptr; } -std::shared_ptr<Creature> Tile::getTopVisibleCreature(std::shared_ptr<Creature> creature) const { +std::shared_ptr<Creature> Tile::getTopVisibleCreature(const std::shared_ptr<Creature> &creature) const { if (const CreatureVector* creatures = getCreatures()) { if (creature) { - std::shared_ptr<Player> player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player && player->isAccessPlayer()) { return getTopCreature(); } - for (auto &tileCreature : *creatures) { + for (const auto &tileCreature : *creatures) { if (creature->canSeeCreature(tileCreature)) { return tileCreature; } } } else { - for (auto &tileCreature : *creatures) { + for (const auto &tileCreature : *creatures) { if (!tileCreature->isInvisible()) { - std::shared_ptr<Player> player = tileCreature->getPlayer(); + const auto &player = tileCreature->getPlayer(); if (!player || !player->isInGhostMode()) { return tileCreature; } @@ -277,25 +277,25 @@ std::shared_ptr<Creature> Tile::getTopVisibleCreature(std::shared_ptr<Creature> return nullptr; } -std::shared_ptr<Creature> Tile::getBottomVisibleCreature(std::shared_ptr<Creature> creature) const { +std::shared_ptr<Creature> Tile::getBottomVisibleCreature(const std::shared_ptr<Creature> &creature) const { if (const CreatureVector* creatures = getCreatures()) { if (creature) { - std::shared_ptr<Player> player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player && player->isAccessPlayer()) { return getBottomCreature(); } - for (auto it = creatures->rbegin(), end = creatures->rend(); it != end; ++it) { - if (creature->canSeeCreature(*it)) { - return *it; + for (const auto &reverseCreature : std::ranges::reverse_view(*creatures)) { + if (creature->canSeeCreature(reverseCreature)) { + return reverseCreature; } } } else { - for (auto it = creatures->rbegin(), end = creatures->rend(); it != end; ++it) { - if (!(*it)->isInvisible()) { - std::shared_ptr<Player> player = (*it)->getPlayer(); + for (const auto &reverseCreature : std::ranges::reverse_view(*creatures)) { + if (!reverseCreature->isInvisible()) { + const auto &player = reverseCreature->getPlayer(); if (!player || !player->isInGhostMode()) { - return *it; + return reverseCreature; } } } @@ -334,8 +334,8 @@ std::shared_ptr<Item> Tile::getItemByTopOrder(int32_t topOrder) { return nullptr; } -std::shared_ptr<Thing> Tile::getTopVisibleThing(std::shared_ptr<Creature> creature) { - std::shared_ptr<Thing> thing = getTopVisibleCreature(creature); +std::shared_ptr<Thing> Tile::getTopVisibleThing(const std::shared_ptr<Creature> &creature) { + const auto &thing = getTopVisibleCreature(creature); if (thing) { return thing; } @@ -360,11 +360,16 @@ std::shared_ptr<Thing> Tile::getTopVisibleThing(std::shared_ptr<Creature> creatu return ground; } -void Tile::onAddTileItem(std::shared_ptr<Item> item) { +void Tile::onAddTileItem(const std::shared_ptr<Item> &item) { + if (!item) { + g_logger().error("Tile::onAddTileItem: item is nullptr"); + return; + } + if ((item->hasProperty(CONST_PROP_MOVABLE) || item->getContainer()) || (item->isWrapable() && !item->hasProperty(CONST_PROP_MOVABLE) && !item->hasProperty(CONST_PROP_BLOCKPATH))) { - auto it = g_game().browseFields.find(static_self_cast<Tile>()); + const auto it = g_game().browseFields.find(static_self_cast<Tile>()); if (it != g_game().browseFields.end()) { - auto lockedCylinder = it->second.lock(); + const auto &lockedCylinder = it->second.lock(); if (lockedCylinder) { lockedCylinder->addItemBack(item); item->setParent(getTile()); @@ -376,7 +381,7 @@ void Tile::onAddTileItem(std::shared_ptr<Item> item) { const Position &cylinderMapPos = getPosition(); - auto spectators = Spectators().find<Creature>(cylinderMapPos, true); + const auto spectators = Spectators().find<Creature>(cylinderMapPos, true); // send to client for (const auto &spectator : spectators) { @@ -401,7 +406,7 @@ void Tile::onAddTileItem(std::shared_ptr<Item> item) { if (getTopTopItem() && getTopTopItem()->canReceiveAutoCarpet()) { return; } - auto house = getHouse(); + const auto &house = getHouse(); if (!house) { return; } @@ -410,36 +415,41 @@ void Tile::onAddTileItem(std::shared_ptr<Item> item) { if (!tile || !tile->getGround() || tile->getGround()->getID() != getGround()->getID()) { continue; } - auto topItem = tile->getTopTopItem(); + const auto &topItem = tile->getTopTopItem(); if (!topItem || !topItem->canReceiveAutoCarpet()) { continue; } // Check if tile is part of the same house - if (auto tileHouse = tile->getHouse(); !tileHouse || house != tileHouse) { + if (const auto &tileHouse = tile->getHouse(); !tileHouse || house != tileHouse) { continue; } // Clear any existing carpet - for (auto tileItem : *tile->getItemList()) { + for (const auto &tileItem : *tile->getItemList()) { if (tileItem && tileItem->isCarpet()) { tile->removeThing(tileItem, tileItem->getItemCount()); } } - auto carpet = item->clone(); + const auto &carpet = item->clone(); carpet->setAttribute(ItemAttribute_t::ACTIONID, IMMOVABLE_ACTION_ID); tile->addThing(carpet); } } } -void Tile::onUpdateTileItem(std::shared_ptr<Item> oldItem, const ItemType &oldType, std::shared_ptr<Item> newItem, const ItemType &newType) { +void Tile::onUpdateTileItem(const std::shared_ptr<Item> &oldItem, const ItemType &oldType, const std::shared_ptr<Item> &newItem, const ItemType &newType) { + if (!oldItem || !newItem) { + g_logger().error("Tile::onUpdateTileItem: oldItem or newItem is nullptr"); + return; + } + if ((newItem->hasProperty(CONST_PROP_MOVABLE) || newItem->getContainer()) || (newItem->isWrapable() && newItem->hasProperty(CONST_PROP_MOVABLE) && !oldItem->hasProperty(CONST_PROP_BLOCKPATH))) { - auto it = g_game().browseFields.find(getTile()); + const auto it = g_game().browseFields.find(getTile()); if (it != g_game().browseFields.end()) { - auto lockedCylinder = it->second.lock(); + const auto &lockedCylinder = it->second.lock(); if (lockedCylinder) { - int32_t index = lockedCylinder->getThingIndex(oldItem); + const int32_t index = lockedCylinder->getThingIndex(oldItem); if (index != -1) { lockedCylinder->replaceThing(index, newItem); newItem->setParent(static_self_cast<Tile>()); @@ -447,11 +457,11 @@ void Tile::onUpdateTileItem(std::shared_ptr<Item> oldItem, const ItemType &oldTy } } } else if ((oldItem->hasProperty(CONST_PROP_MOVABLE) || oldItem->getContainer()) || (oldItem->isWrapable() && !oldItem->hasProperty(CONST_PROP_MOVABLE) && !oldItem->hasProperty(CONST_PROP_BLOCKPATH))) { - auto it = g_game().browseFields.find(getTile()); + const auto it = g_game().browseFields.find(getTile()); if (it != g_game().browseFields.end()) { - auto lockedCylinder = it->second.lock(); + const auto &lockedCylinder = it->second.lock(); if (lockedCylinder) { - std::shared_ptr<Cylinder> oldParent = oldItem->getParent(); + const auto &oldParent = oldItem->getParent(); lockedCylinder->removeThing(oldItem, oldItem->getItemCount()); oldItem->setParent(oldParent); } @@ -460,7 +470,7 @@ void Tile::onUpdateTileItem(std::shared_ptr<Item> oldItem, const ItemType &oldTy const Position &cylinderMapPos = getPosition(); - auto spectators = Spectators().find<Creature>(cylinderMapPos, true); + const auto spectators = Spectators().find<Creature>(cylinderMapPos, true); // send to client for (const auto &spectator : spectators) { @@ -475,17 +485,22 @@ void Tile::onUpdateTileItem(std::shared_ptr<Item> oldItem, const ItemType &oldTy } } -void Tile::onRemoveTileItem(const CreatureVector &spectators, const std::vector<int32_t> &oldStackPosVector, std::shared_ptr<Item> item) { +void Tile::onRemoveTileItem(const CreatureVector &spectators, const std::vector<int32_t> &oldStackPosVector, const std::shared_ptr<Item> &item) { + if (!item) { + g_logger().error("Tile::onRemoveTileItem: item is nullptr"); + return; + } + if ((item->hasProperty(CONST_PROP_MOVABLE) || item->getContainer()) || (item->isWrapable() && !item->hasProperty(CONST_PROP_MOVABLE) && !item->hasProperty(CONST_PROP_BLOCKPATH))) { - auto it = g_game().browseFields.find(getTile()); + const auto it = g_game().browseFields.find(getTile()); if (it != g_game().browseFields.end()) { - auto lockedCylinder = it->second.lock(); + const auto &lockedCylinder = it->second.lock(); if (lockedCylinder) { lockedCylinder->removeThing(item, item->getItemCount()); } } } - for (auto &zone : getZones()) { + for (const auto &zone : getZones()) { zone->itemRemoved(item); } @@ -496,26 +511,26 @@ void Tile::onRemoveTileItem(const CreatureVector &spectators, const std::vector< // send to client size_t i = 0; - for (std::shared_ptr<Creature> spectator : spectators) { - if (std::shared_ptr<Player> tmpPlayer = spectator->getPlayer()) { + for (const auto &spectator : spectators) { + if (const auto &tmpPlayer = spectator->getPlayer()) { tmpPlayer->sendRemoveTileThing(cylinderMapPos, oldStackPosVector[i++]); } } // event methods - for (std::shared_ptr<Creature> spectator : spectators) { + for (const auto &spectator : spectators) { spectator->onRemoveTileItem(static_self_cast<Tile>(), cylinderMapPos, iType, item); } if (!hasFlag(TILESTATE_PROTECTIONZONE) || g_configManager().getBoolean(CLEAN_PROTECTION_ZONES)) { - auto items = getItemList(); + const auto &items = getItemList(); if (!items || items->empty()) { g_game().removeTileToClean(static_self_cast<Tile>()); return; } bool ret = false; - for (auto toCheck : *items) { + for (const auto &toCheck : *items) { if (toCheck->isCleanable()) { ret = true; break; @@ -531,7 +546,7 @@ void Tile::onRemoveTileItem(const CreatureVector &spectators, const std::vector< if (getTopTopItem() && getTopTopItem()->canReceiveAutoCarpet()) { return; } - auto house = getHouse(); + const auto &house = getHouse(); if (!house) { return; } @@ -540,16 +555,16 @@ void Tile::onRemoveTileItem(const CreatureVector &spectators, const std::vector< if (!tile || !tile->getGround() || tile->getGround()->getID() != getGround()->getID()) { continue; } - auto topItem = tile->getTopTopItem(); + const auto &topItem = tile->getTopTopItem(); if (!topItem || !topItem->canReceiveAutoCarpet()) { continue; } // Check if tile is part of the same house - if (auto tileHouse = tile->getHouse(); !tileHouse || house != tileHouse) { + if (const auto &tileHouse = tile->getHouse(); !tileHouse || house != tileHouse) { continue; } - for (auto tileItem : *tile->getItemList()) { + for (const auto &tileItem : *tile->getItemList()) { if (tileItem && tileItem->getID() == item->getID()) { tile->removeThing(tileItem, tileItem->getItemCount()); } @@ -562,19 +577,23 @@ void Tile::onUpdateTile(const CreatureVector &spectators) { const Position &cylinderMapPos = getPosition(); // send to clients - for (std::shared_ptr<Creature> spectator : spectators) { + for (const auto &spectator : spectators) { spectator->getPlayer()->sendUpdateTile(getTile(), cylinderMapPos); } } -ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t tileFlags, std::shared_ptr<Creature>) { +ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t tileFlags, const std::shared_ptr<Creature> &) { + if (!thing) { + return RETURNVALUE_NOTPOSSIBLE; + } + if (hasBitSet(FLAG_NOLIMIT, tileFlags)) { return RETURNVALUE_NOERROR; } - if (auto creature = thing->getCreature()) { + if (const auto &creature = thing->getCreature()) { if (creature->getNpc()) { - ReturnValue returnValue = checkNpcCanWalkIntoTile(); + const ReturnValue returnValue = checkNpcCanWalkIntoTile(); if (returnValue != RETURNVALUE_NOERROR) { return returnValue; } @@ -588,7 +607,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ return RETURNVALUE_NOTPOSSIBLE; } - if (std::shared_ptr<Monster> monster = creature->getMonster()) { + if (const auto &monster = creature->getMonster()) { if (hasFlag(TILESTATE_PROTECTIONZONE | TILESTATE_FLOORCHANGE | TILESTATE_TELEPORT) && (!monster->isFamiliar() || (monster->isFamiliar() && monster->getMaster() && monster->getMaster()->getAttackedCreature()))) { return RETURNVALUE_NOTPOSSIBLE; } @@ -602,19 +621,19 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ const CreatureVector* creatures = getCreatures(); if (monster->canPushCreatures() && !monster->isSummon()) { if (creatures) { - for (auto &tileCreature : *creatures) { + for (const auto &tileCreature : *creatures) { if (tileCreature->getPlayer() && tileCreature->getPlayer()->isInGhostMode()) { continue; } - std::shared_ptr<Monster> creatureMonster = tileCreature->getMonster(); + const auto &creatureMonster = tileCreature->getMonster(); if (!creatureMonster || !tileCreature->isPushable() || (creatureMonster->isSummon() && creatureMonster->getMaster()->getPlayer())) { return RETURNVALUE_NOTPOSSIBLE; } } } } else if (creatures && !creatures->empty()) { - for (auto &tileCreature : *creatures) { + for (const auto &tileCreature : *creatures) { if (!tileCreature->isInGhostMode()) { return RETURNVALUE_NOTENOUGHROOM; } @@ -636,7 +655,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ } if (hasHarmfulField()) { - CombatType_t combatType = getFieldItem()->getCombatType(); + const CombatType_t combatType = getFieldItem()->getCombatType(); // There is 3 options for a monster to enter a magic field // 1) Monster is immune @@ -657,9 +676,9 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ } const CreatureVector* creatures = getCreatures(); - if (std::shared_ptr<Player> player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { if (creatures && !creatures->empty() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, tileFlags) && !player->isAccessPlayer()) { - for (auto &tileCreature : *creatures) { + for (const auto &tileCreature : *creatures) { if (!player->canWalkthrough(tileCreature)) { return RETURNVALUE_NOTPOSSIBLE; } @@ -680,7 +699,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ if (playerTile && playerTile->hasFlag(TILESTATE_PROTECTIONZONE)) { auto maxOnline = g_configManager().getNumber(MAX_PLAYERS_PER_ACCOUNT); if (maxOnline > 1 && player->getAccountType() < ACCOUNT_TYPE_GAMEMASTER && !hasFlag(TILESTATE_PROTECTIONZONE)) { - auto maxOutsizePZ = g_configManager().getNumber(MAX_PLAYERS_OUTSIDE_PZ_PER_ACCOUNT); + const auto maxOutsizePZ = g_configManager().getNumber(MAX_PLAYERS_OUTSIDE_PZ_PER_ACCOUNT); auto accountPlayers = g_game().getPlayersByAccount(player->getAccount()); int countOutsizePZ = 0; for (const auto &accountPlayer : accountPlayers) { @@ -714,7 +733,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ } } } else if (creatures && !creatures->empty() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, tileFlags)) { - for (auto &tileCreature : *creatures) { + for (const auto &tileCreature : *creatures) { if (!tileCreature->isInGhostMode()) { return RETURNVALUE_NOTENOUGHROOM; } @@ -727,7 +746,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ // NO PVP magic wall or wild growth field check if (creature && creature->getPlayer()) { if (const auto fieldList = getItemList()) { - for (auto &findfield : *fieldList) { + for (const auto &findfield : *fieldList) { if (findfield && (findfield->getID() == ITEM_WILDGROWTH_SAFE || findfield->getID() == ITEM_MAGICWALL_SAFE)) { if (!creature->isInGhostMode()) { g_game().internalRemoveItem(findfield, 1); @@ -749,7 +768,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ } if (const auto items = getItemList()) { - for (auto &item : *items) { + for (const auto &item : *items) { const ItemType &iiType = Item::items[item->getID()]; if (iiType.blockSolid && (!iiType.movable || item->hasAttribute(ItemAttribute_t::UNIQUEID))) { return RETURNVALUE_NOTPOSSIBLE; @@ -757,20 +776,20 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ } } } - } else if (auto item = thing->getItem()) { + } else if (const auto &item = thing->getItem()) { const TileItemVector* items = getItemList(); if (items && items->size() >= 0x3E8) { return RETURNVALUE_NOTPOSSIBLE; } - bool itemIsHangable = item->isHangable(); + const bool itemIsHangable = item->isHangable(); if (ground == nullptr && !itemIsHangable) { return RETURNVALUE_NOTPOSSIBLE; } const CreatureVector* creatures = getCreatures(); if (creatures && !creatures->empty() && item->isBlocking() && !hasBitSet(FLAG_IGNOREBLOCKCREATURE, tileFlags)) { - for (auto &tileCreature : *creatures) { + for (const auto &tileCreature : *creatures) { if (!tileCreature->isInGhostMode()) { return RETURNVALUE_NOTENOUGHROOM; } @@ -779,7 +798,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ if (itemIsHangable && hasFlag(TILESTATE_SUPPORTS_HANGABLE)) { if (items) { - for (auto &tileItem : *items) { + for (const auto &tileItem : *items) { if (tileItem->isHangable()) { return RETURNVALUE_NEEDEXCHANGE; } @@ -802,7 +821,7 @@ ReturnValue Tile::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_ } if (items) { - for (auto &tileItem : *items) { + for (const auto &tileItem : *items) { const ItemType &iiType = Item::items[tileItem->getID()]; if (!iiType.blockSolid || iiType.type == ITEM_TYPE_TRASHHOLDER) { continue; @@ -843,13 +862,17 @@ ReturnValue Tile::queryMaxCount(int32_t, const std::shared_ptr<Thing> &, uint32_ return RETURNVALUE_NOERROR; } -ReturnValue Tile::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t tileFlags, std::shared_ptr<Creature> /*= nullptr */) { - int32_t index = getThingIndex(thing); +ReturnValue Tile::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t tileFlags, const std::shared_ptr<Creature> & /*= nullptr */) { + if (!thing) { + return RETURNVALUE_NOTPOSSIBLE; + } + + const int32_t index = getThingIndex(thing); if (index == -1) { return RETURNVALUE_NOTPOSSIBLE; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return RETURNVALUE_NOTPOSSIBLE; } @@ -865,26 +888,26 @@ ReturnValue Tile::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t coun return RETURNVALUE_NOERROR; } -std::shared_ptr<Cylinder> Tile::queryDestination(int32_t &, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &tileFlags) { +std::shared_ptr<Cylinder> Tile::queryDestination(int32_t &, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &tileFlags) { std::shared_ptr<Tile> destTile = nullptr; - *destItem = nullptr; + destItem = nullptr; if (hasFlag(TILESTATE_FLOORCHANGE_DOWN)) { uint16_t dx = tilePos.x; uint16_t dy = tilePos.y; - uint8_t dz = tilePos.z + 1; + const uint8_t dz = tilePos.z + 1; - std::shared_ptr<Tile> southDownTile = g_game().map.getTile(dx, dy - 1, dz); + const auto &southDownTile = g_game().map.getTile(dx, dy - 1, dz); if (southDownTile && southDownTile->hasFlag(TILESTATE_FLOORCHANGE_SOUTH_ALT)) { dy -= 2; destTile = g_game().map.getTile(dx, dy, dz); } else { - std::shared_ptr<Tile> eastDownTile = g_game().map.getTile(dx - 1, dy, dz); + const auto &eastDownTile = g_game().map.getTile(dx - 1, dy, dz); if (eastDownTile && eastDownTile->hasFlag(TILESTATE_FLOORCHANGE_EAST_ALT)) { dx -= 2; destTile = g_game().map.getTile(dx, dy, dz); } else { - std::shared_ptr<Tile> downTile = g_game().map.getTile(dx, dy, dz); + const auto &downTile = g_game().map.getTile(dx, dy, dz); if (downTile) { if (downTile->hasFlag(TILESTATE_FLOORCHANGE_NORTH)) { ++dy; @@ -917,7 +940,7 @@ std::shared_ptr<Cylinder> Tile::queryDestination(int32_t &, const std::shared_pt } else if (hasFlag(TILESTATE_FLOORCHANGE)) { uint16_t dx = tilePos.x; uint16_t dy = tilePos.y; - uint8_t dz = tilePos.z - 1; + const uint8_t dz = tilePos.z - 1; if (hasFlag(TILESTATE_FLOORCHANGE_NORTH)) { --dy; @@ -953,11 +976,11 @@ std::shared_ptr<Cylinder> Tile::queryDestination(int32_t &, const std::shared_pt } if (destTile) { - std::shared_ptr<Thing> destThing = destTile->getTopDownItem(); + const auto &destThing = destTile->getTopDownItem(); if (destThing) { - *destItem = destThing->getItem(); - if (thing->getItem()) { - auto destCylinder = destThing->getCylinder(); + destItem = destThing->getItem(); + if (thing && thing->getItem()) { + const auto &destCylinder = destThing->getCylinder(); if (destCylinder && !destCylinder->getContainer()) { return destThing->getCylinder(); } @@ -981,16 +1004,16 @@ std::vector<std::shared_ptr<Tile>> Tile::getSurroundingTiles() { }; } -void Tile::addThing(std::shared_ptr<Thing> thing) { +void Tile::addThing(const std::shared_ptr<Thing> &thing) { addThing(0, thing); } -void Tile::addThing(int32_t, std::shared_ptr<Thing> thing) { +void Tile::addThing(int32_t, const std::shared_ptr<Thing> &thing) { if (!thing) { - return /*RETURNVALUE_NOTPOSSIBLE*/; + return; // RETURNVALUE_NOTPOSSIBLE } - std::shared_ptr<Creature> creature = thing->getCreature(); + const auto &creature = thing->getCreature(); if (creature) { Spectators::clearCache(); creature->setParent(static_self_cast<Tile>()); @@ -998,7 +1021,7 @@ void Tile::addThing(int32_t, std::shared_ptr<Thing> thing) { CreatureVector* creatures = makeCreatures(); creatures->insert(creatures->begin(), creature); } else { - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -1018,7 +1041,7 @@ void Tile::addThing(int32_t, std::shared_ptr<Thing> thing) { } else { const ItemType &oldType = Item::items[ground->getID()]; - std::shared_ptr<Item> oldGround = ground; + const auto &oldGround = ground; ground->resetParent(); ground = item; resetTileFlags(oldGround); @@ -1030,15 +1053,18 @@ void Tile::addThing(int32_t, std::shared_ptr<Thing> thing) { if (itemType.isSplash() && items) { // remove old splash if exists for (ItemVector::const_iterator it = items->getBeginTopItem(), end = items->getEndTopItem(); it != end; ++it) { - std::shared_ptr<Item> oldSplash = *it; - if (!Item::items[oldSplash->getID()].isSplash()) { - continue; - } + // Need to increment the counter to avoid crash + const std::weak_ptr<Item> &weakSplash = *it; + if (const auto oldSplash = weakSplash.lock()) { + if (!Item::items[oldSplash->getID()].isSplash()) { + continue; + } - removeThing(oldSplash, 1); - oldSplash->resetParent(); - postRemoveNotification(oldSplash, nullptr, 0); - break; + postRemoveNotification(oldSplash, nullptr, 0); + removeThing(oldSplash, 1); + oldSplash->resetParent(); + break; + } } } @@ -1066,19 +1092,21 @@ void Tile::addThing(int32_t, std::shared_ptr<Thing> thing) { if (itemType.isMagicField()) { // remove old field item if exists if (items) { - for (ItemVector::const_iterator it = items->getBeginDownItem(), end = items->getEndDownItem(); it != end; ++it) { - std::shared_ptr<MagicField> oldField = (*it)->getMagicField(); - if (oldField) { - if (oldField->isReplaceable()) { - removeThing(oldField, 1); - - oldField->resetParent(); - postRemoveNotification(oldField, nullptr, 0); - break; - } else { - // This magic field cannot be replaced. - item->resetParent(); - return; + for (auto it = items->getBeginDownItem(), end = items->getEndDownItem(); it != end; ++it) { + std::weak_ptr<Item> weakField = *it; + if (const auto oldField = weakField.lock()) { + auto magicField = oldField->getMagicField(); + if (magicField) { + if (magicField->isReplaceable()) { + postRemoveNotification(magicField, nullptr, 0); + removeThing(magicField, 1); + magicField->resetParent(); + break; + } else { + // This magic field cannot be replaced. + item->resetParent(); + return; + } } } } @@ -1093,13 +1121,17 @@ void Tile::addThing(int32_t, std::shared_ptr<Thing> thing) { } } -void Tile::updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) { - int32_t index = getThingIndex(thing); +void Tile::updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) { + if (!thing) { + return /*RETURNVALUE_NOTPOSSIBLE*/; + } + + const int32_t index = getThingIndex(thing); if (index == -1) { return /*RETURNVALUE_NOTPOSSIBLE*/; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -1113,10 +1145,14 @@ void Tile::updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t c onUpdateTileItem(item, oldType, item, newType); } -void Tile::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { +void Tile::replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) { + if (!thing) { + return; + } + int32_t pos = index; - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return /*RETURNVALUE_NOTPOSSIBLE*/; } @@ -1136,7 +1172,7 @@ void Tile::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { TileItemVector* items = getItemList(); if (items && !isInserted) { - int32_t topItemSize = getTopItemCount(); + const int32_t topItemSize = getTopItemCount(); if (pos < topItemSize) { auto it = items->getBeginTopItem(); it += pos; @@ -1150,7 +1186,7 @@ void Tile::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { pos -= topItemSize; } - CreatureVector* creatures = getCreatures(); + const CreatureVector* creatures = getCreatures(); if (creatures) { if (!isInserted && pos < static_cast<int32_t>(creatures->size())) { return /*RETURNVALUE_NOTPOSSIBLE*/; @@ -1160,7 +1196,7 @@ void Tile::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { } if (items && !isInserted) { - int32_t downItemSize = getDownItemCount(); + const int32_t downItemSize = getDownItemCount(); if (pos < downItemSize) { auto it = items->getBeginDownItem() + pos; oldItem = *it; @@ -1184,12 +1220,16 @@ void Tile::replaceThing(uint32_t index, std::shared_ptr<Thing> thing) { } } -void Tile::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { - std::shared_ptr<Creature> creature = thing->getCreature(); +void Tile::removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) { + if (!thing) { + return; + } + + const auto &creature = thing->getCreature(); if (creature) { CreatureVector* creatures = getCreatures(); if (creatures) { - auto it = std::find(creatures->begin(), creatures->end(), thing); + const auto it = std::ranges::find(*creatures, thing); if (it != creatures->end()) { Spectators::clearCache(); creatures->erase(it); @@ -1198,12 +1238,12 @@ void Tile::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return; } - int32_t index = getThingIndex(item); + const int32_t index = getThingIndex(item); if (index == -1) { return; } @@ -1212,7 +1252,7 @@ void Tile::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { ground->resetParent(); ground = nullptr; - auto spectators = Spectators().find<Creature>(getPosition(), true); + const auto spectators = Spectators().find<Creature>(getPosition(), true); onRemoveTileItem(spectators.data(), std::vector<int32_t>(spectators.size(), 0), item); return; } @@ -1223,38 +1263,38 @@ void Tile::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { } if (item->isAlwaysOnTop()) { - auto it = std::find(items->getBeginTopItem(), items->getEndTopItem(), item); + const auto it = std::find(items->getBeginTopItem(), items->getEndTopItem(), item); if (it == items->getEndTopItem()) { return; } std::vector<int32_t> oldStackPosVector; - auto spectators = Spectators().find<Creature>(getPosition(), true); + const auto spectators = Spectators().find<Creature>(getPosition(), true); for (const auto &spectator : spectators) { if (const auto &tmpPlayer = spectator->getPlayer()) { oldStackPosVector.push_back(getStackposOfItem(tmpPlayer, item)); } } - item->resetParent(); items->erase(it); onRemoveTileItem(spectators.data(), oldStackPosVector, item); + item->resetParent(); } else { - auto it = std::find(items->getBeginDownItem(), items->getEndDownItem(), item); + const auto it = std::find(items->getBeginDownItem(), items->getEndDownItem(), item); if (it == items->getEndDownItem()) { return; } const ItemType &itemType = Item::items[item->getID()]; if (itemType.stackable && count != item->getItemCount()) { - uint8_t newCount = static_cast<uint8_t>(std::max<int32_t>(0, static_cast<int32_t>(item->getItemCount() - count))); + const uint8_t newCount = static_cast<uint8_t>(std::max<int32_t>(0, static_cast<int32_t>(item->getItemCount() - count))); item->setItemCount(newCount); onUpdateTileItem(item, itemType, item, itemType); } else { std::vector<int32_t> oldStackPosVector; - auto spectators = Spectators().find<Creature>(getPosition(), true); + const auto spectators = Spectators().find<Creature>(getPosition(), true); for (const auto &spectator : spectators) { if (const auto &tmpPlayer = spectator->getPlayer()) { oldStackPosVector.push_back(getStackposOfItem(spectator->getPlayer(), item)); @@ -1269,12 +1309,20 @@ void Tile::removeThing(std::shared_ptr<Thing> thing, uint32_t count) { } } -void Tile::removeCreature(std::shared_ptr<Creature> creature) { +void Tile::removeCreature(const std::shared_ptr<Creature> &creature) { + if (!creature) { + return; + } + g_game().map.getMapSector(tilePos.x, tilePos.y)->removeCreature(creature); removeThing(creature, 0); } -int32_t Tile::getThingIndex(std::shared_ptr<Thing> thing) const { +int32_t Tile::getThingIndex(const std::shared_ptr<Thing> &thing) const { + if (!thing) { + return -1; + } + int32_t n = -1; if (ground) { if (ground == thing) { @@ -1285,7 +1333,7 @@ int32_t Tile::getThingIndex(std::shared_ptr<Thing> thing) const { const TileItemVector* items = getItemList(); if (items) { - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item && item->isAlwaysOnTop()) { for (auto it = items->getBeginTopItem(), end = items->getEndTopItem(); it != end; ++it) { ++n; @@ -1300,7 +1348,7 @@ int32_t Tile::getThingIndex(std::shared_ptr<Thing> thing) const { if (const CreatureVector* creatures = getCreatures()) { if (thing->getCreature()) { - for (auto &creature : *creatures) { + for (const auto &creature : *creatures) { ++n; if (creature == thing) { return n; @@ -1312,7 +1360,7 @@ int32_t Tile::getThingIndex(std::shared_ptr<Thing> thing) const { } if (items) { - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item && !item->isAlwaysOnTop()) { for (auto it = items->getBeginDownItem(), end = items->getEndDownItem(); it != end; ++it) { ++n; @@ -1325,7 +1373,7 @@ int32_t Tile::getThingIndex(std::shared_ptr<Thing> thing) const { return -1; } -int32_t Tile::getClientIndexOfCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature) const { +int32_t Tile::getClientIndexOfCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature) const { int32_t n; if (ground) { n = 1; @@ -1339,10 +1387,10 @@ int32_t Tile::getClientIndexOfCreature(std::shared_ptr<Player> player, std::shar } if (const CreatureVector* creatures = getCreatures()) { - for (auto it = creatures->rbegin(); it != creatures->rend(); ++it) { - if (*it == creature) { + for (const auto &reverseCreature : std::ranges::reverse_view(*creatures)) { + if (reverseCreature == creature) { return n; - } else if (player->canSeeCreature(*it)) { + } else if (player->canSeeCreature(reverseCreature)) { ++n; } } @@ -1350,7 +1398,7 @@ int32_t Tile::getClientIndexOfCreature(std::shared_ptr<Player> player, std::shar return -1; } -int32_t Tile::getStackposOfCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature) const { +int32_t Tile::getStackposOfCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature) const { int32_t n; if (ground) { n = 1; @@ -1367,10 +1415,10 @@ int32_t Tile::getStackposOfCreature(std::shared_ptr<Player> player, std::shared_ } if (const CreatureVector* creatures = getCreatures()) { - for (auto it = creatures->rbegin(); it != creatures->rend(); ++it) { - if (*it == creature) { + for (const auto &reverseCreature : std::ranges::reverse_view(*creatures)) { + if (reverseCreature == creature) { return n; - } else if (player->canSeeCreature(*it)) { + } else if (player->canSeeCreature(reverseCreature)) { if (++n >= 10) { return -1; } @@ -1380,7 +1428,7 @@ int32_t Tile::getStackposOfCreature(std::shared_ptr<Player> player, std::shared_ return -1; } -int32_t Tile::getStackposOfItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item) const { +int32_t Tile::getStackposOfItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) const { int32_t n = 0; if (ground) { if (ground == item) { @@ -1408,7 +1456,7 @@ int32_t Tile::getStackposOfItem(std::shared_ptr<Player> player, std::shared_ptr< } if (const CreatureVector* creatures = getCreatures()) { - for (auto &creature : *creatures) { + for (const auto &creature : *creatures) { if (player->canSeeCreature(creature)) { if (++n >= 10) { return -1; @@ -1445,7 +1493,7 @@ uint32_t Tile::getItemTypeCount(uint16_t itemId, int32_t subType /*= -1*/) const const TileItemVector* items = getItemList(); if (items) { - for (auto &item : *items) { + for (const auto &item : *items) { if (item->getID() == itemId) { count += Item::countByType(item, subType); } @@ -1465,7 +1513,7 @@ std::shared_ptr<Thing> Tile::getThing(size_t index) const { const TileItemVector* items = getItemList(); if (items) { - uint32_t topItemSize = items->getTopItemCount(); + const uint32_t topItemSize = items->getTopItemCount(); if (index < topItemSize) { return items->at(items->getDownItemCount() + index); } @@ -1485,13 +1533,17 @@ std::shared_ptr<Thing> Tile::getThing(size_t index) const { return nullptr; } -void Tile::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link /*= LINK_OWNER*/) { +void Tile::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link /*= LINK_OWNER*/) { + if (!thing) { + return; + } + for (const auto &spectator : Spectators().find<Player>(getPosition(), true)) { spectator->getPlayer()->postAddNotification(thing, oldParent, index, LINK_NEAR); } // add a reference to this item, it may be deleted after being added (mailbox for example) - std::shared_ptr<Creature> creature = thing->getCreature(); + const auto &creature = thing->getCreature(); std::shared_ptr<Item> item; if (creature) { item = nullptr; @@ -1501,17 +1553,17 @@ void Tile::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cyl if (link == LINK_OWNER) { if (hasFlag(TILESTATE_TELEPORT)) { - std::shared_ptr<Teleport> teleport = getTeleportItem(); + const auto &teleport = getTeleportItem(); if (teleport) { teleport->addThing(thing); } } else if (hasFlag(TILESTATE_TRASHHOLDER)) { - std::shared_ptr<TrashHolder> trashholder = getTrashHolder(); + const auto &trashholder = getTrashHolder(); if (trashholder) { trashholder->addThing(thing); } } else if (hasFlag(TILESTATE_MAILBOX)) { - std::shared_ptr<Mailbox> mailbox = getMailbox(); + const auto &mailbox = getMailbox(); if (mailbox) { mailbox->addThing(thing); } @@ -1526,7 +1578,11 @@ void Tile::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cyl } } -void Tile::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { +void Tile::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { + if (!thing) { + return; + } + auto spectators = Spectators().find<Player>(getPosition(), true); if (getThingCount() > 8) { @@ -1538,30 +1594,30 @@ void Tile::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr< } // calling movement scripts - std::shared_ptr<Creature> creature = thing->getCreature(); + const auto &creature = thing->getCreature(); if (creature) { g_moveEvents().onCreatureMove(creature, static_self_cast<Tile>(), MOVE_EVENT_STEP_OUT); } else { - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item) { g_moveEvents().onItemMove(item, static_self_cast<Tile>(), false); } } } -void Tile::internalAddThing(std::shared_ptr<Thing> thing) { +void Tile::internalAddThing(const std::shared_ptr<Thing> &thing) { internalAddThing(0, thing); if (!thing || !thing->getParent()) { return; } - if (auto house = thing->getTile()->getHouse()) { - if (std::shared_ptr<Item> item = thing->getItem()) { + if (const auto &house = thing->getTile()->getHouse()) { + if (const auto &item = thing->getItem()) { if (item->getParent().get() != this) { return; } - std::shared_ptr<Door> door = item->getDoor(); + const auto &door = item->getDoor(); if (door && door->getDoorId() != 0) { house->addDoor(door); } @@ -1569,7 +1625,7 @@ void Tile::internalAddThing(std::shared_ptr<Thing> thing) { } } -void Tile::internalAddThing(uint32_t, std::shared_ptr<Thing> thing) { +void Tile::internalAddThing(uint32_t, const std::shared_ptr<Thing> &thing) { if (!thing) { return; } @@ -1579,14 +1635,14 @@ void Tile::internalAddThing(uint32_t, std::shared_ptr<Thing> thing) { thing->setParent(getTile()); - std::shared_ptr<Creature> creature = thing->getCreature(); + const auto &creature = thing->getCreature(); if (creature) { Spectators::clearCache(); CreatureVector* creatures = makeCreatures(); creatures->insert(creatures->begin(), creature); } else { - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item == nullptr) { return; } @@ -1806,11 +1862,11 @@ bool Tile::isMovableBlocking() const { std::shared_ptr<Item> Tile::getUseItem(int32_t index) const { const TileItemVector* items = getItemList(); - if (!items || items->size() == 0) { + if (!items || items->empty()) { return ground; } - if (std::shared_ptr<Thing> thing = getThing(index)) { + if (const auto &thing = getThing(index)) { return thing->getItem(); } @@ -1819,12 +1875,12 @@ std::shared_ptr<Item> Tile::getUseItem(int32_t index) const { std::shared_ptr<Item> Tile::getDoorItem() const { const TileItemVector* items = getItemList(); - if (!items || items->size() == 0) { + if (!items || items->empty()) { return ground; } if (items) { - for (auto &item : *items) { + for (const auto &item : *items) { const ItemType &it = Item::items[item->getID()]; if (it.isDoor()) { return item; @@ -1835,7 +1891,11 @@ std::shared_ptr<Item> Tile::getDoorItem() const { return nullptr; } -void Tile::addZone(std::shared_ptr<Zone> zone) { +void Tile::addZone(const std::shared_ptr<Zone> &zone) { + if (!zone) { + return; + } + zones.emplace(zone); const auto &items = getItemList(); if (items) { diff --git a/src/items/tile.hpp b/src/items/tile.hpp index 1790cd2972a..3bd0017ed38 100644 --- a/src/items/tile.hpp +++ b/src/items/tile.hpp @@ -104,7 +104,7 @@ class Tile : public Cylinder, public SharedObject { static const std::shared_ptr<Tile> &nullptr_tile; Tile(uint16_t x, uint16_t y, uint8_t z) : tilePos(x, y, z) { } - virtual ~Tile() {}; + ~Tile() override = default; // non-copyable Tile(const Tile &) = delete; @@ -121,14 +121,14 @@ class Tile : public Cylinder, public SharedObject { return nullptr; } - int32_t getThrowRange() const override final { + int32_t getThrowRange() const final { return 0; } - bool isPushable() override final { + bool isPushable() final { return false; } - std::shared_ptr<Tile> getTile() override final { + std::shared_ptr<Tile> getTile() final { return static_self_cast<Tile>(); } @@ -144,13 +144,13 @@ class Tile : public Cylinder, public SharedObject { std::shared_ptr<Creature> getTopCreature() const; std::shared_ptr<Creature> getBottomCreature() const; - std::shared_ptr<Creature> getTopVisibleCreature(std::shared_ptr<Creature> creature) const; + std::shared_ptr<Creature> getTopVisibleCreature(const std::shared_ptr<Creature> &creature) const; - std::shared_ptr<Creature> getBottomVisibleCreature(std::shared_ptr<Creature> creature) const; + std::shared_ptr<Creature> getBottomVisibleCreature(const std::shared_ptr<Creature> &creature) const; std::shared_ptr<Item> getTopTopItem() const; std::shared_ptr<Item> getTopDownItem() const; bool isMovableBlocking() const; - std::shared_ptr<Thing> getTopVisibleThing(std::shared_ptr<Creature> creature); + std::shared_ptr<Thing> getTopVisibleThing(const std::shared_ptr<Creature> &creature); std::shared_ptr<Item> getItemByTopOrder(int32_t topOrder); size_t getThingCount() const { @@ -167,7 +167,7 @@ class Tile : public Cylinder, public SharedObject { uint32_t getDownItemCount() const; bool hasProperty(ItemProperty prop) const; - bool hasProperty(std::shared_ptr<Item> exclude, ItemProperty prop) const; + bool hasProperty(const std::shared_ptr<Item> &exclude, ItemProperty prop) const; bool hasFlag(uint32_t flag) const { return hasBitSet(flag, this->flags); @@ -178,7 +178,7 @@ class Tile : public Cylinder, public SharedObject { void resetFlag(uint32_t flag) { this->flags &= ~flag; } - void addZone(std::shared_ptr<Zone> zone); + void addZone(const std::shared_ptr<Zone> &zone); void clearZones(); auto getZones() const { @@ -200,48 +200,48 @@ class Tile : public Cylinder, public SharedObject { bool hasHeight(uint32_t n) const; - std::string getDescription(int32_t lookDistance) override final; + std::string getDescription(int32_t lookDistance) final; - int32_t getClientIndexOfCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature) const; - int32_t getStackposOfCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature) const; - int32_t getStackposOfItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item) const; + int32_t getClientIndexOfCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature) const; + int32_t getStackposOfCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature) const; + int32_t getStackposOfItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) const; // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; - ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) override final; - ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t tileFlags, std::shared_ptr<Creature> actor = nullptr) override; - std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; + ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) final; + ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t tileFlags, const std::shared_ptr<Creature> &actor = nullptr) override; + std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) override; std::vector<std::shared_ptr<Tile>> getSurroundingTiles(); - void addThing(std::shared_ptr<Thing> thing) override final; - void addThing(int32_t index, std::shared_ptr<Thing> thing) override; + void addThing(const std::shared_ptr<Thing> &thing) final; + void addThing(int32_t index, const std::shared_ptr<Thing> &thing) override; void updateTileFlags(const std::shared_ptr<Item> &item); - void updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) override final; - void replaceThing(uint32_t index, std::shared_ptr<Thing> thing) override final; + void updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) final; + void replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) final; - void removeThing(std::shared_ptr<Thing> thing, uint32_t count) override final; + void removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) final; - void removeCreature(std::shared_ptr<Creature> creature); + void removeCreature(const std::shared_ptr<Creature> &creature); - int32_t getThingIndex(std::shared_ptr<Thing> thing) const override final; - size_t getFirstIndex() const override final; - size_t getLastIndex() const override final; - uint32_t getItemTypeCount(uint16_t itemId, int32_t subType = -1) const override final; - std::shared_ptr<Thing> getThing(size_t index) const override final; + int32_t getThingIndex(const std::shared_ptr<Thing> &thing) const final; + size_t getFirstIndex() const final; + size_t getLastIndex() const final; + uint32_t getItemTypeCount(uint16_t itemId, int32_t subType = -1) const final; + std::shared_ptr<Thing> getThing(size_t index) const final; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override final; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override final; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) final; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) final; - void internalAddThing(std::shared_ptr<Thing> thing) override; - void virtual internalAddThing(uint32_t index, std::shared_ptr<Thing> thing) override; + void internalAddThing(const std::shared_ptr<Thing> &thing) override; + void internalAddThing(uint32_t index, const std::shared_ptr<Thing> &thing) override; - const Position &getPosition() override final { + const Position &getPosition() final { return tilePos; } - bool isRemoved() override final { + bool isRemoved() final { return false; } @@ -262,9 +262,9 @@ class Tile : public Cylinder, public SharedObject { } private: - void onAddTileItem(std::shared_ptr<Item> item); - void onUpdateTileItem(std::shared_ptr<Item> oldItem, const ItemType &oldType, std::shared_ptr<Item> newItem, const ItemType &newType); - void onRemoveTileItem(const CreatureVector &spectators, const std::vector<int32_t> &oldStackPosVector, std::shared_ptr<Item> item); + void onAddTileItem(const std::shared_ptr<Item> &item); + void onUpdateTileItem(const std::shared_ptr<Item> &oldItem, const ItemType &oldType, const std::shared_ptr<Item> &newItem, const ItemType &newType); + void onRemoveTileItem(const CreatureVector &spectators, const std::vector<int32_t> &oldStackPosVector, const std::shared_ptr<Item> &item); void onUpdateTile(const CreatureVector &spectators); void setTileFlags(const std::shared_ptr<Item> &item); @@ -276,7 +276,7 @@ class Tile : public Cylinder, public SharedObject { std::shared_ptr<Item> ground = nullptr; Position tilePos; uint32_t flags = 0; - std::unordered_set<std::shared_ptr<Zone>> zones; + std::unordered_set<std::shared_ptr<Zone>> zones {}; }; // Used for walkable tiles, where there is high likeliness of diff --git a/src/items/trashholder.cpp b/src/items/trashholder.cpp index fe95557ce50..42fbe4db4e6 100644 --- a/src/items/trashholder.cpp +++ b/src/items/trashholder.cpp @@ -10,8 +10,12 @@ #include "items/trashholder.hpp" #include "game/game.hpp" -ReturnValue TrashHolder::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t, std::shared_ptr<Creature> actor) { - std::shared_ptr<Item> item = thing->getItem(); +ReturnValue TrashHolder::queryAdd(int32_t, const std::shared_ptr<Thing> &thing, uint32_t, uint32_t, const std::shared_ptr<Creature> &actor) { + if (!thing) { + return RETURNVALUE_NOERROR; + } + + const auto &item = thing->getItem(); if (item == nullptr) { return RETURNVALUE_NOERROR; } @@ -26,24 +30,24 @@ ReturnValue TrashHolder::queryMaxCount(int32_t, const std::shared_ptr<Thing> &, return RETURNVALUE_NOERROR; } -ReturnValue TrashHolder::queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, std::shared_ptr<Creature> /*= nullptr*/) { +ReturnValue TrashHolder::queryRemove(const std::shared_ptr<Thing> &, uint32_t, uint32_t, const std::shared_ptr<Creature> & /*= nullptr */) { return RETURNVALUE_NOTPOSSIBLE; } -std::shared_ptr<Cylinder> TrashHolder::queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item>*, uint32_t &) { +std::shared_ptr<Cylinder> TrashHolder::queryDestination(int32_t &, const std::shared_ptr<Thing> &, std::shared_ptr<Item> &, uint32_t &) { return static_self_cast<TrashHolder>(); } -void TrashHolder::addThing(std::shared_ptr<Thing> thing) { +void TrashHolder::addThing(const std::shared_ptr<Thing> &thing) { return addThing(0, thing); } -void TrashHolder::addThing(int32_t, std::shared_ptr<Thing> thing) { +void TrashHolder::addThing(int32_t, const std::shared_ptr<Thing> &thing) { if (!thing) { return; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (!item) { return; } @@ -54,7 +58,7 @@ void TrashHolder::addThing(int32_t, std::shared_ptr<Thing> thing) { const ItemType &it = Item::items[id]; if (item->isHangable() && it.isGroundTile()) { - std::shared_ptr<Tile> tile = std::dynamic_pointer_cast<Tile>(getParent()); + const std::shared_ptr<Tile> &tile = std::dynamic_pointer_cast<Tile>(getParent()); if (tile && tile->hasFlag(TILESTATE_SUPPORTS_HANGABLE)) { return; } @@ -70,22 +74,22 @@ void TrashHolder::addThing(int32_t, std::shared_ptr<Thing> thing) { } } -void TrashHolder::updateThing(std::shared_ptr<Thing>, uint16_t, uint32_t) { +void TrashHolder::updateThing(const std::shared_ptr<Thing> &, uint16_t, uint32_t) { // } -void TrashHolder::replaceThing(uint32_t, std::shared_ptr<Thing>) { +void TrashHolder::replaceThing(uint32_t, const std::shared_ptr<Thing> &) { // } -void TrashHolder::removeThing(std::shared_ptr<Thing>, uint32_t) { +void TrashHolder::removeThing(const std::shared_ptr<Thing> &, uint32_t) { // } -void TrashHolder::postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t) { +void TrashHolder::postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t) { getParent()->postAddNotification(thing, oldParent, index, LINK_PARENT); } -void TrashHolder::postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t) { +void TrashHolder::postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t) { getParent()->postRemoveNotification(thing, newParent, index, LINK_PARENT); } diff --git a/src/items/trashholder.hpp b/src/items/trashholder.hpp index 771c8687fbd..049260c57e0 100644 --- a/src/items/trashholder.hpp +++ b/src/items/trashholder.hpp @@ -21,24 +21,24 @@ class TrashHolder final : public Item, public Cylinder { return static_self_cast<TrashHolder>(); } - std::shared_ptr<Cylinder> getCylinder() override final { + std::shared_ptr<Cylinder> getCylinder() override { return getTrashHolder(); } // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; ReturnValue queryMaxCount(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t &maxQueryCount, uint32_t flags) override; - ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; - std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) override; + ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; + std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) override; - void addThing(std::shared_ptr<Thing> thing) override; - void addThing(int32_t index, std::shared_ptr<Thing> thing) override; + void addThing(const std::shared_ptr<Thing> &thing) override; + void addThing(int32_t index, const std::shared_ptr<Thing> &thing) override; - void updateThing(std::shared_ptr<Thing> thing, uint16_t itemId, uint32_t count) override; - void replaceThing(uint32_t index, std::shared_ptr<Thing> thing) override; + void updateThing(const std::shared_ptr<Thing> &thing, uint16_t itemId, uint32_t count) override; + void replaceThing(uint32_t index, const std::shared_ptr<Thing> &thing) override; - void removeThing(std::shared_ptr<Thing> thing, uint32_t count) override; + void removeThing(const std::shared_ptr<Thing> &thing, uint32_t count) override; - void postAddNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; - void postRemoveNotification(std::shared_ptr<Thing> thing, std::shared_ptr<Cylinder> newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postAddNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &oldParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; + void postRemoveNotification(const std::shared_ptr<Thing> &thing, const std::shared_ptr<Cylinder> &newParent, int32_t index, CylinderLink_t link = LINK_OWNER) override; }; diff --git a/src/items/weapons/weapons.cpp b/src/items/weapons/weapons.cpp index cce94603a60..f0db2ca4f30 100644 --- a/src/items/weapons/weapons.cpp +++ b/src/items/weapons/weapons.cpp @@ -17,12 +17,12 @@ Weapons::Weapons() = default; Weapons::~Weapons() = default; -const WeaponShared_ptr Weapons::getWeapon(std::shared_ptr<Item> item) const { +WeaponShared_ptr Weapons::getWeapon(const std::shared_ptr<Item> &item) const { if (!item) { return nullptr; } - auto it = weapons.find(item->getID()); + const auto it = weapons.find(item->getID()); if (it == weapons.end()) { return nullptr; } @@ -52,7 +52,7 @@ void Weapons::clear(bool isFromXML /*= false*/) { weapons.clear(); } -bool Weapons::registerLuaEvent(WeaponShared_ptr event, bool fromXML /*= false*/) { +bool Weapons::registerLuaEvent(const WeaponShared_ptr &event, bool fromXML /*= false*/) { weapons[event->getID()] = event; if (fromXML) { event->setFromXML(fromXML); @@ -79,7 +79,7 @@ void Weapon::configureWeapon(const ItemType &it) { id = it.id; } -int32_t Weapon::playerWeaponCheck(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint8_t shootRange) const { +int32_t Weapon::playerWeaponCheck(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint8_t shootRange) const { const Position &playerPos = player->getPosition(); const Position &targetPos = target->getPosition(); if (playerPos.z != targetPos.z) { @@ -129,8 +129,8 @@ int32_t Weapon::playerWeaponCheck(std::shared_ptr<Player> player, std::shared_pt return 100; } -bool Weapon::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target) const { - int32_t damageModifier = playerWeaponCheck(player, target, item->getShootRange()); +bool Weapon::useWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target) const { + const int32_t damageModifier = playerWeaponCheck(player, target, item->getShootRange()); if (damageModifier == 0) { return false; } @@ -139,22 +139,22 @@ bool Weapon::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> ite return true; } -CombatDamage Weapon::getCombatDamage(CombatDamage combat, std::shared_ptr<Player> player, std::shared_ptr<Item> item, int32_t damageModifier) const { +CombatDamage Weapon::getCombatDamage(CombatDamage combat, const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, int32_t damageModifier) const { // Local variables - uint32_t level = player->getLevel(); - int16_t elementalAttack = getElementDamageValue(); - int32_t weaponAttack = std::max<int32_t>(0, item->getAttack()); - int32_t playerSkill = player->getWeaponSkill(item); - float attackFactor = player->getAttackFactor(); // full atk, balanced or full defense + const uint32_t level = player->getLevel(); + const int16_t elementalAttack = getElementDamageValue(); + const int32_t weaponAttack = std::max<int32_t>(0, item->getAttack()); + const int32_t playerSkill = player->getWeaponSkill(item); + const float attackFactor = player->getAttackFactor(); // full atk, balanced or full defense // Getting values factores - int32_t totalAttack = elementalAttack + weaponAttack; - double weaponAttackProportion = (double)weaponAttack / (double)totalAttack; + const int32_t totalAttack = elementalAttack + weaponAttack; + const double weaponAttackProportion = static_cast<double>(weaponAttack) / static_cast<double>(totalAttack); // Calculating damage - int32_t maxDamage = static_cast<int32_t>(Weapons::getMaxWeaponDamage(level, playerSkill, totalAttack, attackFactor, true) * player->getVocation()->meleeDamageMultiplier * damageModifier / 100); - int32_t minDamage = level / 5; - int32_t realDamage = normal_random(minDamage, maxDamage); + const int32_t maxDamage = static_cast<int32_t>(Weapons::getMaxWeaponDamage(level, playerSkill, totalAttack, attackFactor, true) * player->getVocation()->meleeDamageMultiplier * damageModifier / 100); + const int32_t minDamage = level / 5; + const int32_t realDamage = normal_random(minDamage, maxDamage); // Setting damage to combat combat.primary.value = realDamage * weaponAttackProportion; @@ -162,16 +162,16 @@ CombatDamage Weapon::getCombatDamage(CombatDamage combat, std::shared_ptr<Player return combat; } -bool Weapon::useFist(std::shared_ptr<Player> player, std::shared_ptr<Creature> target) { +bool Weapon::useFist(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target) { if (!Position::areInRange<1, 1>(player->getPosition(), target->getPosition())) { return false; } - float attackFactor = player->getAttackFactor(); - int32_t attackSkill = player->getSkillLevel(SKILL_FIST); - int32_t attackValue = 7; + const float attackFactor = player->getAttackFactor(); + const int32_t attackSkill = player->getSkillLevel(SKILL_FIST); + constexpr int32_t attackValue = 7; - int32_t maxDamage = Weapons::getMaxWeaponDamage(player->getLevel(), attackSkill, attackValue, attackFactor, true); + const int32_t maxDamage = Weapons::getMaxWeaponDamage(player->getLevel(), attackSkill, attackValue, attackFactor, true); CombatParams params; params.combatType = COMBAT_PHYSICALDAMAGE; @@ -192,7 +192,7 @@ bool Weapon::useFist(std::shared_ptr<Player> player, std::shared_ptr<Creature> t return true; } -void Weapon::internalUseWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target, int32_t damageModifier, int32_t cleavePercent) const { +void Weapon::internalUseWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target, int32_t damageModifier, int32_t cleavePercent) const { if (player) { if (params.soundCastEffect == SoundEffect_t::SILENCE) { g_game().sendDoubleSoundEffect(player->getPosition(), player->getHitSoundEffect(), player->getAttackSoundEffect(), player); @@ -213,7 +213,7 @@ void Weapon::internalUseWeapon(std::shared_ptr<Player> player, std::shared_ptr<I g_logger().debug("Weapon::internalUseWeapon - Lua callback executed."); } else { CombatDamage damage; - WeaponType_t weaponType = item->getWeaponType(); + const WeaponType_t weaponType = item->getWeaponType(); if (weaponType == WEAPON_AMMO || weaponType == WEAPON_DISTANCE || weaponType == WEAPON_MISSILE) { damage.origin = ORIGIN_RANGED; } else { @@ -256,7 +256,7 @@ void Weapon::internalUseWeapon(std::shared_ptr<Player> player, std::shared_ptr<I onUsedWeapon(player, item, target->getTile()); } -void Weapon::internalUseWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Tile> tile) const { +void Weapon::internalUseWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Tile> &tile) const { if (isLoadedCallback()) { LuaVariant var; var.type = VARIANT_TARGETPOSITION; @@ -270,7 +270,7 @@ void Weapon::internalUseWeapon(std::shared_ptr<Player> player, std::shared_ptr<I onUsedWeapon(player, item, tile); } -void Weapon::onUsedWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Tile> destTile) const { +void Weapon::onUsedWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Tile> &destTile) const { if (!player->hasFlag(PlayerFlags_t::NotGainSkill)) { skills_t skillType; uint32_t skillPoint; @@ -279,7 +279,7 @@ void Weapon::onUsedWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> } } - uint32_t manaCost = getManaCost(player); + const uint32_t manaCost = getManaCost(player); if (manaCost != 0) { player->addManaSpent(manaCost); player->changeMana(-static_cast<int32_t>(manaCost)); @@ -289,7 +289,7 @@ void Weapon::onUsedWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> } } - uint32_t healthCost = getHealthCost(player); + const uint32_t healthCost = getHealthCost(player); if (healthCost != 0) { player->changeHealth(-static_cast<int32_t>(healthCost)); } @@ -329,7 +329,7 @@ void Weapon::onUsedWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> } } -uint32_t Weapon::getManaCost(std::shared_ptr<Player> player) const { +uint32_t Weapon::getManaCost(const std::shared_ptr<Player> &player) const { if (mana != 0) { return mana; } @@ -341,7 +341,7 @@ uint32_t Weapon::getManaCost(std::shared_ptr<Player> player) const { return (player->getMaxMana() * manaPercent) / 100; } -int32_t Weapon::getHealthCost(std::shared_ptr<Player> player) const { +int32_t Weapon::getHealthCost(const std::shared_ptr<Player> &player) const { if (health != 0) { return health; } @@ -353,9 +353,9 @@ int32_t Weapon::getHealthCost(std::shared_ptr<Player> player) const { return (player->getMaxHealth() * healthPercent) / 100; } -bool Weapon::executeUseWeapon(std::shared_ptr<Player> player, const LuaVariant &var) const { +bool Weapon::executeUseWeapon(const std::shared_ptr<Player> &player, const LuaVariant &var) const { // onUseWeapon(player, var) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { std::string playerName = player ? player->getName() : "Player nullptr"; g_logger().error("[Weapon::executeUseWeapon - Player {} weaponId {}]" "Call stack overflow. Too many lua script calls being nested.", @@ -363,7 +363,7 @@ bool Weapon::executeUseWeapon(std::shared_ptr<Player> player, const LuaVariant & return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -371,13 +371,13 @@ bool Weapon::executeUseWeapon(std::shared_ptr<Player> player, const LuaVariant & getScriptInterface()->pushFunction(getScriptId()); LuaScriptInterface::pushUserdata<Player>(L, player); LuaScriptInterface::setMetatable(L, -1, "Player"); - getScriptInterface()->pushVariant(L, var); + LuaScriptInterface::pushVariant(L, var); return getScriptInterface()->callFunction(2); } -void Weapon::decrementItemCount(std::shared_ptr<Item> item) { - uint16_t count = item->getItemCount(); +void Weapon::decrementItemCount(const std::shared_ptr<Item> &item) { + const uint16_t count = item->getItemCount(); if (count > 1) { g_game().transformItem(item, item->getID(), count - 1); } else { @@ -386,7 +386,7 @@ void Weapon::decrementItemCount(std::shared_ptr<Item> item) { } bool Weapon::calculateSkillFormula(const std::shared_ptr<Player> &player, int32_t &attackSkill, int32_t &attackValue, float &attackFactor, int16_t &elementAttack, CombatDamage &damage, bool useCharges /* = false*/) const { - std::shared_ptr<Item> tool = player->getWeapon(); + const auto &tool = player->getWeapon(); if (!tool) { return false; } @@ -400,7 +400,7 @@ bool Weapon::calculateSkillFormula(const std::shared_ptr<Player> &player, int32_ } } - CombatType_t elementType = getElementType(); + const CombatType_t elementType = getElementType(); damage.secondary.type = elementType; bool shouldCalculateSecondaryDamage = false; @@ -411,7 +411,7 @@ bool Weapon::calculateSkillFormula(const std::shared_ptr<Player> &player, int32_ } if (useCharges) { - auto charges = tool->getAttribute<uint16_t>(ItemAttribute_t::CHARGES); + const auto charges = tool->getAttribute<uint16_t>(ItemAttribute_t::CHARGES); if (charges != 0) { g_game().transformItem(tool, tool->getID(), charges - 1); } @@ -443,13 +443,13 @@ void WeaponMelee::configureWeapon(const ItemType &it) { Weapon::configureWeapon(it); } -bool WeaponMelee::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target) const { - int32_t damageModifier = playerWeaponCheck(player, target, item->getShootRange()); +bool WeaponMelee::useWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target) const { + const int32_t damageModifier = playerWeaponCheck(player, target, item->getShootRange()); if (damageModifier == 0) { return false; } - int32_t cleavePercent = player->getCleavePercent(true); + const int32_t cleavePercent = player->getCleavePercent(true); if (cleavePercent > 0) { const Position &targetPos = target->getPosition(); const Position &playerPos = player->getPosition(); @@ -475,12 +475,12 @@ bool WeaponMelee::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item secondCleaveTargetPos.y++; } } - std::shared_ptr<Tile> firstTile = g_game().map.getTile(firstCleaveTargetPos.x, firstCleaveTargetPos.y, firstCleaveTargetPos.z); - std::shared_ptr<Tile> secondTile = g_game().map.getTile(secondCleaveTargetPos.x, secondCleaveTargetPos.y, secondCleaveTargetPos.z); + const auto &firstTile = g_game().map.getTile(firstCleaveTargetPos.x, firstCleaveTargetPos.y, firstCleaveTargetPos.z); + const auto &secondTile = g_game().map.getTile(secondCleaveTargetPos.x, secondCleaveTargetPos.y, secondCleaveTargetPos.z); if (firstTile) { - if (CreatureVector* tileCreatures = firstTile->getCreatures()) { - for (auto &tileCreature : *tileCreatures) { + if (const CreatureVector* tileCreatures = firstTile->getCreatures()) { + for (const auto &tileCreature : *tileCreatures) { if (tileCreature->getMonster() || (tileCreature->getPlayer() && !player->hasSecureMode())) { internalUseWeapon(player, item, tileCreature, damageModifier, cleavePercent); } @@ -488,8 +488,8 @@ bool WeaponMelee::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item } } if (secondTile) { - if (CreatureVector* tileCreatures = secondTile->getCreatures()) { - for (auto &tileCreature : *tileCreatures) { + if (const CreatureVector* tileCreatures = secondTile->getCreatures()) { + for (const auto &tileCreature : *tileCreatures) { if (tileCreature->getMonster() || (tileCreature->getPlayer() && !player->hasSecureMode())) { internalUseWeapon(player, item, tileCreature, damageModifier, cleavePercent); } @@ -503,14 +503,14 @@ bool WeaponMelee::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item return true; } -bool WeaponMelee::getSkillType(std::shared_ptr<Player> player, std::shared_ptr<Item> item, skills_t &skill, uint32_t &skillpoint) const { +bool WeaponMelee::getSkillType(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, skills_t &skill, uint32_t &skillpoint) const { if (player->getAddAttackSkill() && player->getLastAttackBlockType() != BLOCK_IMMUNITY) { skillpoint = 1; } else { skillpoint = 0; } - WeaponType_t weaponType = item->getWeaponType(); + const WeaponType_t weaponType = item->getWeaponType(); switch (weaponType) { case WEAPON_SWORD: { skill = SKILL_SWORD; @@ -533,18 +533,18 @@ bool WeaponMelee::getSkillType(std::shared_ptr<Player> player, std::shared_ptr<I return false; } -int32_t WeaponMelee::getElementDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature>, std::shared_ptr<Item> item) const { +int32_t WeaponMelee::getElementDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &, const std::shared_ptr<Item> &item) const { if (elementType == COMBAT_NONE) { return 0; } - int32_t attackSkill = player->getWeaponSkill(item); - int32_t attackValue = elementDamage; - float attackFactor = player->getAttackFactor(); - uint32_t level = player->getLevel(); + const int32_t attackSkill = player->getWeaponSkill(item); + const int32_t attackValue = elementDamage; + const float attackFactor = player->getAttackFactor(); + const uint32_t level = player->getLevel(); - int32_t maxValue = Weapons::getMaxWeaponDamage(level, attackSkill, attackValue, attackFactor, true); - int32_t minValue = level / 5; + const int32_t maxValue = Weapons::getMaxWeaponDamage(level, attackSkill, attackValue, attackFactor, true); + const int32_t minValue = level / 5; return -normal_random(minValue, static_cast<int32_t>(maxValue * player->getVocation()->meleeDamageMultiplier)); } @@ -553,16 +553,16 @@ int16_t WeaponMelee::getElementDamageValue() const { return elementDamage; } -int32_t WeaponMelee::getWeaponDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature>, std::shared_ptr<Item> item, bool maxDamage /*= false*/) const { +int32_t WeaponMelee::getWeaponDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &, const std::shared_ptr<Item> &item, bool maxDamage /*= false*/) const { using namespace std; - int32_t attackSkill = player->getWeaponSkill(item); - int32_t attackValue = std::max<int32_t>(0, item->getAttack()); - float attackFactor = player->getAttackFactor(); - uint32_t level = player->getLevel(); + const int32_t attackSkill = player->getWeaponSkill(item); + const int32_t attackValue = std::max<int32_t>(0, item->getAttack()); + const float attackFactor = player->getAttackFactor(); + const uint32_t level = player->getLevel(); - int32_t maxValue = static_cast<int32_t>(Weapons::getMaxWeaponDamage(level, attackSkill, attackValue, attackFactor, true) * player->getVocation()->meleeDamageMultiplier); + const int32_t maxValue = static_cast<int32_t>(Weapons::getMaxWeaponDamage(level, attackSkill, attackValue, attackFactor, true) * player->getVocation()->meleeDamageMultiplier); - int32_t minValue = level / 5; + const int32_t minValue = level / 5; if (maxDamage) { return -maxValue; @@ -593,12 +593,12 @@ void WeaponDistance::configureWeapon(const ItemType &it) { Weapon::configureWeapon(it); } -bool WeaponDistance::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target) const { +bool WeaponDistance::useWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target) const { int32_t damageModifier; const ItemType &it = Item::items[id]; if (it.weaponType == WEAPON_AMMO) { - std::shared_ptr<Item> mainWeaponItem = player->getWeapon(true); - const WeaponShared_ptr mainWeapon = g_weapons().getWeapon(mainWeaponItem); + const auto &mainWeaponItem = player->getWeapon(true); + const WeaponShared_ptr &mainWeapon = g_weapons().getWeapon(mainWeaponItem); if (mainWeapon) { damageModifier = mainWeapon->playerWeaponCheck(player, target, mainWeaponItem->getShootRange()); } else { @@ -615,13 +615,13 @@ bool WeaponDistance::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<I bool perfectShot = false; const Position &playerPos = player->getPosition(); const Position &targetPos = target->getPosition(); - int32_t distanceX = Position::getDistanceX(targetPos, playerPos); - int32_t distanceY = Position::getDistanceY(targetPos, playerPos); + const int32_t distanceX = Position::getDistanceX(targetPos, playerPos); + const int32_t distanceY = Position::getDistanceY(targetPos, playerPos); int32_t damageX = player->getPerfectShotDamage(distanceX); int32_t damageY = player->getPerfectShotDamage(distanceY); if (it.weaponType == WEAPON_DISTANCE) { - std::shared_ptr<Item> quiver = player->getInventoryItem(CONST_SLOT_RIGHT); + const auto &quiver = player->getInventoryItem(CONST_SLOT_RIGHT); if (quiver && quiver->getWeaponType()) { if (quiver->getPerfectShotRange() == distanceX) { damageX -= quiver->getPerfectShotDamage(); @@ -637,8 +637,8 @@ bool WeaponDistance::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<I perfectShot = true; } else if (it.hitChance == 0) { // hit chance is based on distance to target and distance skill - uint32_t skill = player->getSkillLevel(SKILL_DISTANCE); - uint32_t distance = std::max<uint32_t>(distanceX, distanceY); + const uint32_t skill = player->getSkillLevel(SKILL_DISTANCE); + const uint32_t distance = std::max<uint32_t>(distanceX, distanceY); uint32_t maxHitChance; if (it.maxHitChance != -1) { @@ -734,7 +734,7 @@ bool WeaponDistance::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<I } if (!perfectShot && item->getWeaponType() == WEAPON_AMMO) { - std::shared_ptr<Item> bow = player->getWeapon(true); + const auto &bow = player->getWeapon(true); if (bow && bow->getHitChance() != 0) { chance += bow->getHitChance(); } @@ -744,7 +744,7 @@ bool WeaponDistance::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<I Weapon::internalUseWeapon(player, item, target, damageModifier); } else { // miss target - std::shared_ptr<Tile> destTile = target->getTile(); + auto destTile = target->getTile(); if (!Position::areInRange<1, 1, 0>(player->getPosition(), target->getPosition())) { static std::vector<std::pair<int32_t, int32_t>> destList { @@ -752,11 +752,11 @@ bool WeaponDistance::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<I }; std::ranges::shuffle(destList.begin(), destList.end(), getRandomGenerator()); - Position destPos = target->getPosition(); + const Position destPos = target->getPosition(); for (const auto &dir : destList) { // Blocking tiles or tiles without ground ain't valid targets for spears - auto tmpTile = g_game().map.getTile(static_cast<uint16_t>(destPos.x + dir.first), static_cast<uint16_t>(destPos.y + dir.second), destPos.z); + const auto &tmpTile = g_game().map.getTile(static_cast<uint16_t>(destPos.x + dir.first), static_cast<uint16_t>(destPos.y + dir.second), destPos.z); if (tmpTile && !tmpTile->hasFlag(TILESTATE_IMMOVABLEBLOCKSOLID) && tmpTile->getGround() != nullptr) { destTile = tmpTile; break; @@ -769,25 +769,25 @@ bool WeaponDistance::useWeapon(std::shared_ptr<Player> player, std::shared_ptr<I return true; } -int32_t WeaponDistance::getElementDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item) const { +int32_t WeaponDistance::getElementDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item) const { if (elementType == COMBAT_NONE) { return 0; } int32_t attackValue = elementDamage; - if (item->getWeaponType() == WEAPON_AMMO) { - std::shared_ptr<Item> weapon = player->getWeapon(true); + if (item && player && item->getWeaponType() == WEAPON_AMMO) { + const auto &weapon = player->getWeapon(true); if (weapon) { attackValue += item->getAttack(); attackValue += weapon->getAttack(); } } - int32_t attackSkill = player->getSkillLevel(SKILL_DISTANCE); - float attackFactor = player->getAttackFactor(); + const int32_t attackSkill = player->getSkillLevel(SKILL_DISTANCE); + const float attackFactor = player->getAttackFactor(); int32_t minValue = std::round(player->getLevel() / 5); - int32_t maxValue = std::round((0.09f * attackFactor) * attackSkill * attackValue + minValue) / 2; + const int32_t maxValue = std::round((0.09f * attackFactor) * attackSkill * attackValue + minValue) / 2; if (target) { if (target->getPlayer()) { @@ -804,12 +804,12 @@ int16_t WeaponDistance::getElementDamageValue() const { return elementDamage; } -int32_t WeaponDistance::getWeaponDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, bool maxDamage /*= false*/) const { +int32_t WeaponDistance::getWeaponDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, bool maxDamage /*= false*/) const { int32_t attackValue = item->getAttack(); bool hasElement = false; - if (item->getWeaponType() == WEAPON_AMMO) { - std::shared_ptr<Item> weapon = player->getWeapon(true); + if (player && item && item->getWeaponType() == WEAPON_AMMO) { + const auto &weapon = player->getWeapon(true); if (weapon) { const ItemType &it = Item::items[item->getID()]; if (it.abilities && it.abilities->elementDamage != 0) { @@ -821,8 +821,8 @@ int32_t WeaponDistance::getWeaponDamage(std::shared_ptr<Player> player, std::sha } } - int32_t attackSkill = player->getSkillLevel(SKILL_DISTANCE); - float attackFactor = player->getAttackFactor(); + const int32_t attackSkill = player->getSkillLevel(SKILL_DISTANCE); + const float attackFactor = player->getAttackFactor(); int32_t minValue = player->getLevel() / 5; int32_t maxValue = std::round((0.09f * attackFactor) * attackSkill * attackValue + minValue); @@ -830,7 +830,7 @@ int32_t WeaponDistance::getWeaponDamage(std::shared_ptr<Player> player, std::sha return -maxValue; } - if (target->getPlayer()) { + if (target && target->getPlayer()) { if (hasElement) { minValue /= 4; } else { @@ -846,10 +846,10 @@ int32_t WeaponDistance::getWeaponDamage(std::shared_ptr<Player> player, std::sha return -normal_random(minValue, (maxValue * static_cast<int32_t>(player->getVocation()->distDamageMultiplier))); } -bool WeaponDistance::getSkillType(std::shared_ptr<Player> player, std::shared_ptr<Item>, skills_t &skill, uint32_t &skillpoint) const { +bool WeaponDistance::getSkillType(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &, skills_t &skill, uint32_t &skillpoint) const { skill = SKILL_DISTANCE; - if (player->getAddAttackSkill()) { + if (player && player->getAddAttackSkill()) { switch (player->getLastAttackBlockType()) { case BLOCK_NONE: { skillpoint = 2; @@ -879,7 +879,7 @@ void WeaponWand::configureWeapon(const ItemType &it) { Weapon::configureWeapon(it); } -int32_t WeaponWand::getWeaponDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature>, std::shared_ptr<Item>, bool maxDamage /* = false*/) const { +int32_t WeaponWand::getWeaponDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &, const std::shared_ptr<Item> &, bool maxDamage /* = false*/) const { if (!g_configManager().getBoolean(TOGGLE_CHAIN_SYSTEM)) { // Returns maximum damage or a random value between minChange and maxChange return maxDamage ? -maxChange : -normal_random(minChange, maxChange); @@ -893,19 +893,19 @@ int32_t WeaponWand::getWeaponDamage(std::shared_ptr<Player> player, std::shared_ [[maybe_unused]] CombatDamage combatDamage; calculateSkillFormula(player, attackSkill, attackValue, attackFactor, elementAttack, combatDamage); - auto magLevel = player->getMagicLevel(); - auto level = player->getLevel(); + const auto magLevel = player->getMagicLevel(); + const auto level = player->getLevel(); // Check if level is greater than zero before performing division - auto levelDivision = level > 0 ? level / 5.0 : 0.0; + const auto levelDivision = level > 0 ? level / 5.0 : 0.0; - auto totalAttackValue = magLevel + attackValue; + const auto totalAttackValue = magLevel + attackValue; // Check if magLevel is greater than zero before performing division - auto magicLevelDivision = totalAttackValue > 0 ? totalAttackValue / 3.0 : 0.0; + const auto magicLevelDivision = totalAttackValue > 0 ? totalAttackValue / 3.0 : 0.0; - double min = levelDivision + magicLevelDivision; - double max = levelDivision + totalAttackValue; + const double min = levelDivision + magicLevelDivision; + const double max = levelDivision + totalAttackValue; // Returns the calculated maximum damage or a random value between the calculated minimum and maximum return maxDamage ? -max : -normal_random(min, max); diff --git a/src/items/weapons/weapons.hpp b/src/items/weapons/weapons.hpp index 59cc23636e2..bbe15e12a7d 100644 --- a/src/items/weapons/weapons.hpp +++ b/src/items/weapons/weapons.hpp @@ -39,12 +39,12 @@ class Weapons final : public Scripts { return inject<Weapons>(); } - const WeaponShared_ptr getWeapon(std::shared_ptr<Item> item) const; + WeaponShared_ptr getWeapon(const std::shared_ptr<Item> &item) const; static int32_t getMaxMeleeDamage(int32_t attackSkill, int32_t attackValue); static int32_t getMaxWeaponDamage(uint32_t level, int32_t attackSkill, int32_t attackValue, float attackFactor, bool isMelee); - bool registerLuaEvent(WeaponShared_ptr event, bool fromXML = false); + bool registerLuaEvent(const WeaponShared_ptr &event, bool fromXML = false); void clear(bool isFromXML = false); private: @@ -62,15 +62,15 @@ class Weapon : public Script { return false; } - int32_t playerWeaponCheck(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint8_t shootRange) const; - static bool useFist(std::shared_ptr<Player> player, std::shared_ptr<Creature> target); - virtual bool useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target) const; + int32_t playerWeaponCheck(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint8_t shootRange) const; + static bool useFist(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target); + virtual bool useWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target) const; - virtual int32_t getWeaponDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, bool maxDamage = false) const = 0; - virtual int32_t getElementDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item) const = 0; + virtual int32_t getWeaponDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, bool maxDamage = false) const = 0; + virtual int32_t getElementDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item) const = 0; virtual CombatType_t getElementType() const = 0; virtual int16_t getElementDamageValue() const = 0; - virtual CombatDamage getCombatDamage(CombatDamage combat, std::shared_ptr<Player> player, std::shared_ptr<Item> item, int32_t damageModifier) const; + virtual CombatDamage getCombatDamage(CombatDamage combat, const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, int32_t damageModifier) const; uint16_t getID() const { return id; } @@ -162,8 +162,8 @@ class Weapon : public Script { wieldInfo |= info; } - void addVocWeaponMap(std::string vocName) { - int32_t vocationId = g_vocations().getVocationId(vocName); + void addVocWeaponMap(const std::string &vocName) { + const int32_t vocationId = g_vocations().getVocationId(vocName); if (vocationId != -1) { vocWeaponMap[vocationId] = true; } @@ -224,17 +224,17 @@ class Weapon : public Script { bool calculateSkillFormula(const std::shared_ptr<Player> &player, int32_t &attackSkill, int32_t &attackValue, float &attackFactor, int16_t &elementAttack, CombatDamage &damage, bool useCharges = false) const; protected: - void internalUseWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target, int32_t damageModifier, int32_t cleavePercent = 0) const; - void internalUseWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Tile> tile) const; + void internalUseWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target, int32_t damageModifier, int32_t cleavePercent = 0) const; + void internalUseWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Tile> &tile) const; private: - virtual bool getSkillType(std::shared_ptr<Player>, std::shared_ptr<Item>, skills_t &, uint32_t &) const { + virtual bool getSkillType(const std::shared_ptr<Player> &, const std::shared_ptr<Item> &, skills_t &, uint32_t &) const { return false; } - uint32_t getManaCost(std::shared_ptr<Player> player) const; - int32_t getHealthCost(std::shared_ptr<Player> player) const; - bool executeUseWeapon(std::shared_ptr<Player> player, const LuaVariant &var) const; + uint32_t getManaCost(const std::shared_ptr<Player> &player) const; + int32_t getHealthCost(const std::shared_ptr<Player> &player) const; + bool executeUseWeapon(const std::shared_ptr<Player> &player, const LuaVariant &var) const; uint16_t id = 0; @@ -252,11 +252,11 @@ class Weapon : public Script { bool premium = false; bool wieldUnproperly = false; bool m_isDisabledChain = false; - std::string vocationString = ""; + std::string vocationString; - void onUsedWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Tile> destTile) const; + void onUsedWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Tile> &destTile) const; - static void decrementItemCount(std::shared_ptr<Item> item); + static void decrementItemCount(const std::shared_ptr<Item> &item); WeaponAction_t action = WEAPONACTION_NONE; CombatParams params; @@ -284,17 +284,17 @@ class WeaponMelee final : public Weapon { void configureWeapon(const ItemType &it) override; - bool useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target) const override; + bool useWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target) const override; - int32_t getWeaponDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, bool maxDamage = false) const override; - int32_t getElementDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item) const override; + int32_t getWeaponDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, bool maxDamage = false) const override; + int32_t getElementDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item) const override; CombatType_t getElementType() const override { return elementType; } virtual int16_t getElementDamageValue() const override; private: - bool getSkillType(std::shared_ptr<Player> player, std::shared_ptr<Item> item, skills_t &skill, uint32_t &skillpoint) const override; + bool getSkillType(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, skills_t &skill, uint32_t &skillpoint) const override; uint16_t elementDamage = 0; CombatType_t elementType = COMBAT_NONE; }; @@ -312,23 +312,23 @@ class WeaponDistance final : public Weapon { return true; } - bool useWeapon(std::shared_ptr<Player> player, std::shared_ptr<Item> item, std::shared_ptr<Creature> target) const override; + bool useWeapon(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::shared_ptr<Creature> &target) const override; - int32_t getWeaponDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, bool maxDamage = false) const override; - int32_t getElementDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item) const override; + int32_t getWeaponDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, bool maxDamage = false) const override; + int32_t getElementDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item) const override; CombatType_t getElementType() const override { return elementType; } virtual int16_t getElementDamageValue() const override; private: - bool getSkillType(std::shared_ptr<Player> player, std::shared_ptr<Item> item, skills_t &skill, uint32_t &skillpoint) const override; + bool getSkillType(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, skills_t &skill, uint32_t &skillpoint) const override; CombatType_t elementType = COMBAT_NONE; uint16_t elementDamage = 0; }; -class WeaponWand final : public Weapon { +class WeaponWand : public Weapon { public: using Weapon::Weapon; @@ -338,8 +338,8 @@ class WeaponWand final : public Weapon { void configureWeapon(const ItemType &it) override; - int32_t getWeaponDamage(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, bool maxDamage = false) const override; - int32_t getElementDamage(std::shared_ptr<Player>, std::shared_ptr<Creature>, std::shared_ptr<Item>) const override { + int32_t getWeaponDamage(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, bool maxDamage = false) const override; + int32_t getElementDamage(const std::shared_ptr<Player> &, const std::shared_ptr<Creature> &, const std::shared_ptr<Item> &) const override { return 0; } CombatType_t getElementType() const override { @@ -355,7 +355,7 @@ class WeaponWand final : public Weapon { } private: - bool getSkillType(std::shared_ptr<Player>, std::shared_ptr<Item>, skills_t &, uint32_t &) const override { + bool getSkillType(const std::shared_ptr<Player> &, const std::shared_ptr<Item> &, skills_t &, uint32_t &) const override { return false; } diff --git a/src/kv/kv.cpp b/src/kv/kv.cpp index 0a7cfe6827d..95b19ca8590 100644 --- a/src/kv/kv.cpp +++ b/src/kv/kv.cpp @@ -21,12 +21,12 @@ KVStore &KVStore::getInstance() { } void KVStore::set(const std::string &key, const std::initializer_list<ValueWrapper> &init_list) { - ValueWrapper wrappedInitList(init_list); + const ValueWrapper wrappedInitList(init_list); set(key, wrappedInitList); } void KVStore::set(const std::string &key, const std::initializer_list<std::pair<const std::string, ValueWrapper>> &init_list) { - ValueWrapper wrappedInitList(init_list); + const ValueWrapper wrappedInitList(init_list); set(key, wrappedInitList); } @@ -37,7 +37,7 @@ void KVStore::set(const std::string &key, const ValueWrapper &value) { void KVStore::setLocked(const std::string &key, const ValueWrapper &value) { logger.trace("KVStore::set({})", key); - auto it = store_.find(key); + const auto it = store_.find(key); if (it != store_.end()) { it->second.first = value; lruQueue_.splice(lruQueue_.begin(), lruQueue_, it->second.second); diff --git a/src/kv/kv.hpp b/src/kv/kv.hpp index c00a0fd4204..eefc97d83c5 100644 --- a/src/kv/kv.hpp +++ b/src/kv/kv.hpp @@ -18,12 +18,14 @@ #include <unordered_set> #include <iomanip> #include <list> + #include <utility> #endif #include "kv/value_wrapper.hpp" class KV : public std::enable_shared_from_this<KV> { public: + virtual ~KV() = default; virtual void set(const std::string &key, const std::initializer_list<ValueWrapper> &init_list) = 0; virtual void set(const std::string &key, const std::initializer_list<std::pair<const std::string, ValueWrapper>> &init_list) = 0; virtual void set(const std::string &key, const ValueWrapper &value) = 0; @@ -47,8 +49,8 @@ class KV : public std::enable_shared_from_this<KV> { static std::string generateUUID() { std::lock_guard<std::mutex> lock(mutex_); - auto now = std::chrono::system_clock::now().time_since_epoch(); - auto milliseconds = std::chrono::duration_cast<std::chrono::milliseconds>(now).count(); + const auto now = std::chrono::system_clock::now().time_since_epoch(); + const auto milliseconds = std::chrono::duration_cast<std::chrono::milliseconds>(now).count(); if (milliseconds != lastTimestamp_) { counter_ = 0; @@ -90,8 +92,8 @@ class KVStore : public KV { store_.clear(); } - std::shared_ptr<KV> scoped(const std::string &scope) override final; - std::unordered_set<std::string> keys(const std::string &prefix = ""); + std::shared_ptr<KV> scoped(const std::string &scope) final; + std::unordered_set<std::string> keys(const std::string &prefix = "") override; protected: phmap::parallel_flat_hash_map<std::string, std::pair<ValueWrapper, std::list<std::string>::iterator>> getStore() { @@ -120,8 +122,8 @@ class KVStore : public KV { class ScopedKV final : public KV { public: - ScopedKV(Logger &logger, KVStore &rootKV, const std::string &prefix) : - logger(logger), rootKV_(rootKV), prefix_(prefix) { } + ScopedKV(Logger &logger, KVStore &rootKV, std::string prefix) : + logger(logger), rootKV_(rootKV), prefix_(std::move(prefix)) { } void set(const std::string &key, const std::initializer_list<ValueWrapper> &init_list) override { rootKV_.set(buildKey(key), init_list); @@ -139,7 +141,7 @@ class ScopedKV final : public KV { template <typename T> T get(const std::string &key, bool forceLoad = false) { - auto optValue = get(key, forceLoad); + const auto optValue = get(key, forceLoad); if (optValue.has_value()) { return optValue->get<T>(); } @@ -150,7 +152,7 @@ class ScopedKV final : public KV { return rootKV_.saveAll(); } - std::shared_ptr<KV> scoped(const std::string &scope) override final { + std::shared_ptr<KV> scoped(const std::string &scope) override { logger.trace("ScopedKV::scoped({})", buildKey(scope)); return std::make_shared<ScopedKV>(logger, rootKV_, buildKey(scope)); } diff --git a/src/kv/kv_sql.cpp b/src/kv/kv_sql.cpp index 18f3c7a3205..0f353048854 100644 --- a/src/kv/kv_sql.cpp +++ b/src/kv/kv_sql.cpp @@ -19,20 +19,20 @@ KVSQL::KVSQL(Database &db, Logger &logger) : KVStore(logger), db(db) { } std::optional<ValueWrapper> KVSQL::load(const std::string &key) { - auto query = fmt::format("SELECT `key_name`, `timestamp`, `value` FROM `kv_store` WHERE `key_name` = {}", db.escapeString(key)); - auto result = db.storeQuery(query); + const auto query = fmt::format("SELECT `key_name`, `timestamp`, `value` FROM `kv_store` WHERE `key_name` = {}", db.escapeString(key)); + const auto result = db.storeQuery(query); if (result == nullptr) { return std::nullopt; } unsigned long size; - auto data = result->getStream("value", size); + const auto data = result->getStream("value", size); if (data == nullptr) { return std::nullopt; } ValueWrapper valueWrapper; - auto timestamp = result->getNumber<uint64_t>("timestamp"); + const auto timestamp = result->getNumber<uint64_t>("timestamp"); Canary::protobuf::kv::ValueWrapper protoValue; if (protoValue.ParseFromArray(data, static_cast<int>(size))) { valueWrapper = ProtoSerializable::fromProto(protoValue, timestamp); @@ -45,8 +45,8 @@ std::optional<ValueWrapper> KVSQL::load(const std::string &key) { std::vector<std::string> KVSQL::loadPrefix(const std::string &prefix /* = ""*/) { std::vector<std::string> keys; std::string keySearch = db.escapeString(prefix + "%"); - auto query = fmt::format("SELECT `key_name` FROM `kv_store` WHERE `key_name` LIKE {}", keySearch); - auto result = db.storeQuery(query); + const auto query = fmt::format("SELECT `key_name` FROM `kv_store` WHERE `key_name` LIKE {}", keySearch); + const auto result = db.storeQuery(query); if (result == nullptr) { return keys; } @@ -66,14 +66,14 @@ bool KVSQL::save(const std::string &key, const ValueWrapper &value) { return update.execute(); } -bool KVSQL::prepareSave(const std::string &key, const ValueWrapper &value, DBInsert &update) { - auto protoValue = ProtoSerializable::toProto(value); +bool KVSQL::prepareSave(const std::string &key, const ValueWrapper &value, DBInsert &update) const { + const auto protoValue = ProtoSerializable::toProto(value); std::string data; if (!protoValue.SerializeToString(&data)) { return false; } if (value.isDeleted()) { - auto query = fmt::format("DELETE FROM `kv_store` WHERE `key_name` = {}", db.escapeString(key)); + const auto query = fmt::format("DELETE FROM `kv_store` WHERE `key_name` = {}", db.escapeString(key)); return db.executeQuery(query); } @@ -83,7 +83,7 @@ bool KVSQL::prepareSave(const std::string &key, const ValueWrapper &value, DBIns bool KVSQL::saveAll() { auto store = getStore(); - bool success = DBTransaction::executeWithinTransaction([this, &store]() { + const bool success = DBTransaction::executeWithinTransaction([this, &store]() { auto update = dbUpdate(); if (!std::ranges::all_of(store, [this, &update](const auto &kv) { const auto &[key, value] = kv; diff --git a/src/kv/kv_sql.hpp b/src/kv/kv_sql.hpp index 43bedada82f..f58f9cc4751 100644 --- a/src/kv/kv_sql.hpp +++ b/src/kv/kv_sql.hpp @@ -26,7 +26,7 @@ class KVSQL final : public KVStore { std::vector<std::string> loadPrefix(const std::string &prefix = "") override; std::optional<ValueWrapper> load(const std::string &key) override; bool save(const std::string &key, const ValueWrapper &value) override; - bool prepareSave(const std::string &key, const ValueWrapper &value, DBInsert &update); + bool prepareSave(const std::string &key, const ValueWrapper &value, DBInsert &update) const; DBInsert dbUpdate(); diff --git a/src/kv/value_wrapper.cpp b/src/kv/value_wrapper.cpp index 72920b6972a..90d86b40358 100644 --- a/src/kv/value_wrapper.cpp +++ b/src/kv/value_wrapper.cpp @@ -13,8 +13,8 @@ ValueWrapper::ValueWrapper(uint64_t timestamp) : timestamp_(timestamp == 0 ? getTimeMsNow() : timestamp) { } -ValueWrapper::ValueWrapper(const ValueVariant &value, uint64_t timestamp) : - data_(value), timestamp_(timestamp == 0 ? getTimeMsNow() : timestamp) { } +ValueWrapper::ValueWrapper(ValueVariant value, uint64_t timestamp) : + data_(std::move(value)), timestamp_(timestamp == 0 ? getTimeMsNow() : timestamp) { } ValueWrapper::ValueWrapper(const std::string &value, uint64_t timestamp) : data_(value), timestamp_(timestamp == 0 ? getTimeMsNow() : timestamp) { } @@ -37,7 +37,7 @@ ValueWrapper::ValueWrapper(const std::initializer_list<std::pair<const std::stri timestamp_(timestamp == 0 ? getTimeMsNow() : timestamp) { } std::optional<ValueWrapper> ValueWrapper::get(const std::string &key) const { - auto pval = std::get_if<MapType>(&data_); + const auto pval = std::get_if<MapType>(&data_); if (!pval) { return std::nullopt; } @@ -55,7 +55,7 @@ std::optional<ValueWrapper> ValueWrapper::get(const std::string &key) const { } std::optional<ValueWrapper> ValueWrapper::get(size_t index) const { - if (auto pval = std::get_if<ArrayType>(&data_)) { + if (const auto pval = std::get_if<ArrayType>(&data_)) { if (index < pval->size()) { return (*pval)[index]; } diff --git a/src/kv/value_wrapper.hpp b/src/kv/value_wrapper.hpp index df1ad85e8df..4bb844dcb97 100644 --- a/src/kv/value_wrapper.hpp +++ b/src/kv/value_wrapper.hpp @@ -24,7 +24,7 @@ class ValueWrapper { public: explicit ValueWrapper(uint64_t timestamp = 0); - explicit(false) ValueWrapper(const ValueVariant &value, uint64_t timestamp = 0); + explicit(false) ValueWrapper(ValueVariant value, uint64_t timestamp = 0); explicit(false) ValueWrapper(const std::string &value, uint64_t timestamp = 0); explicit(false) ValueWrapper(bool value, uint64_t timestamp = 0); explicit(false) ValueWrapper(int value, uint64_t timestamp = 0); diff --git a/src/kv/value_wrapper_proto.cpp b/src/kv/value_wrapper_proto.cpp index e4d60bed354..2235c56e19d 100644 --- a/src/kv/value_wrapper_proto.cpp +++ b/src/kv/value_wrapper_proto.cpp @@ -31,14 +31,14 @@ namespace ProtoHelpers { } void setProtoArrayValue(Canary::protobuf::kv::ValueWrapper &protoValue, const ArrayType &arg) { - auto arrayValue = protoValue.mutable_array_value(); + const auto arrayValue = protoValue.mutable_array_value(); for (const auto &elem : arg) { *arrayValue->add_values() = ProtoSerializable::toProto(elem); } } void setProtoMapValue(Canary::protobuf::kv::ValueWrapper &protoValue, const MapType &arg) { - auto mapValue = protoValue.mutable_map_value(); + const auto mapValue = protoValue.mutable_map_value(); for (const auto &[key, value] : arg) { auto* elem = mapValue->add_items(); elem->set_key(key); diff --git a/src/kv/value_wrapper_proto.hpp b/src/kv/value_wrapper_proto.hpp index 382b91a040b..9d5a61865ab 100644 --- a/src/kv/value_wrapper_proto.hpp +++ b/src/kv/value_wrapper_proto.hpp @@ -21,13 +21,9 @@ using MapType = phmap::flat_hash_map<std::string, std::shared_ptr<ValueWrapper>> using ValueVariant = std::variant<StringType, BooleanType, IntType, DoubleType, ArrayType, MapType>; // Forward declaration for protobuf class -namespace Canary { - namespace protobuf { - namespace kv { - class ValueWrapper; - } // namespace kv - } // namespace protobuf -} // namespace Canary +namespace Canary::protobuf::kv { + class ValueWrapper; +} struct ProtoSerializable { static Canary::protobuf::kv::ValueWrapper toProto(const ValueWrapper &obj); diff --git a/src/lib/di/runtime_provider.hpp b/src/lib/di/runtime_provider.hpp index 1c9292b5e73..70fad336e97 100644 --- a/src/lib/di/runtime_provider.hpp +++ b/src/lib/di/runtime_provider.hpp @@ -44,9 +44,9 @@ namespace extension { template <class T, class TInitialization, class TMemory, class... TArgs> auto get(const TInitialization &, const TMemory &, TArgs &&... args) const { - auto it = bindings_.find(std::type_index(typeid(T))); + const auto it = bindings_.find(std::type_index(typeid(T))); if (it == bindings_.end()) { - return get<T>(std::integral_constant < bool, !std::is_abstract<T>::value && std::is_constructible<T, TArgs...>::value > {}, std::forward<TArgs>(args)...); + return get<T>(std::integral_constant < bool, !std::is_abstract_v<T> && std::is_constructible_v<T, TArgs...> > {}, std::forward<TArgs>(args)...); } return static_cast<T*>(it->second()); } @@ -121,19 +121,19 @@ namespace extension { core::injector<runtime_provider<TErrorPolicy, TScopeTraits>> { core::init {} } { } template <class T> - /*non explicit*/ injector(const T &bindings) : + /*non explicit*/ explicit injector(const T &bindings) : injector() { install(bindings); } - template <class T, std::enable_if_t<!std::is_base_of<core::injector_base, T>::value, int> = 0> + template <class T, std::enable_if_t<!std::is_base_of_v<core::injector_base, T>, int> = 0> void install(const T &binding) { this->cfg().bindings()[std::type_index(typeid(typename T::expected))] = [this, binding] { return make<typename T::given>(binding); }; } - template <class T, std::enable_if_t<std::is_base_of<core::injector_base, T>::value, int> = 0> + template <class T, std::enable_if_t<std::is_base_of_v<core::injector_base, T>, int> = 0> void install(const T &injector) { install(typename T::deps {}, injector, aux::identity<typename T::config> {}); } diff --git a/src/lib/di/shared.hpp b/src/lib/di/shared.hpp index c1e2f0c6743..f57257d7abd 100644 --- a/src/lib/di/shared.hpp +++ b/src/lib/di/shared.hpp @@ -28,7 +28,7 @@ namespace extension { #if !defined(BOOST_DI_NOT_THREAD_SAFE) //<<lock mutex so that move will be synchronized>> - explicit scope(scope &&other) noexcept : + scope(scope &&other) noexcept : scope(std::move(other), std::scoped_lock<std::mutex>(other.mutex_)) { } //<<synchronized move constructor>> scope(scope &&other, const std::scoped_lock<std::mutex> &) noexcept : diff --git a/src/lib/metrics/metrics.hpp b/src/lib/metrics/metrics.hpp index 2a6a1e5838f..428398f7c00 100644 --- a/src/lib/metrics/metrics.hpp +++ b/src/lib/metrics/metrics.hpp @@ -171,7 +171,7 @@ class ScopedLatency { explicit ScopedLatency([[maybe_unused]] std::string_view name, [[maybe_unused]] const std::string &histogramName, [[maybe_unused]] const std::string &scopeKey) {}; explicit ScopedLatency([[maybe_unused]] std::string_view name, [[maybe_unused]] std::set<double> &histogram, [[maybe_unused]] const std::map<std::string, std::string> &attrs = {}, [[maybe_unused]] const std::string &context = std::string()) {}; - void stop() {}; + void stop() const {}; ~ScopedLatency() = default; }; @@ -203,17 +203,17 @@ namespace metrics { Metrics() = default; ~Metrics() = default; - void init([[maybe_unused]] Options opts) {}; - void initHistograms() {}; - void shutdown() {}; + void init([[maybe_unused]] Options opts) const {}; + void initHistograms() const {}; + void shutdown() const {}; static Metrics &getInstance() { return inject<Metrics>(); }; - void addCounter([[maybe_unused]] std::string_view name, [[maybe_unused]] double value, [[maybe_unused]] const std::map<std::string, std::string> &attrs = {}) { } + void addCounter([[maybe_unused]] std::string_view name, [[maybe_unused]] double value, [[maybe_unused]] const std::map<std::string, std::string> &attrs = {}) const { } - void addUpDownCounter([[maybe_unused]] std::string_view name, [[maybe_unused]] int value, [[maybe_unused]] const std::map<std::string, std::string> &attrs = {}) { } + void addUpDownCounter([[maybe_unused]] std::string_view name, [[maybe_unused]] int value, [[maybe_unused]] const std::map<std::string, std::string> &attrs = {}) const { } friend class ScopedLatency; }; diff --git a/src/lib/thread/thread_pool.cpp b/src/lib/thread/thread_pool.cpp index d67fd63b7d9..0d6b6f5be43 100644 --- a/src/lib/thread/thread_pool.cpp +++ b/src/lib/thread/thread_pool.cpp @@ -28,7 +28,7 @@ ThreadPool::ThreadPool(Logger &logger) : start(); } -void ThreadPool::start() { +void ThreadPool::start() const { logger.info("Running with {} threads.", get_thread_count()); } diff --git a/src/lib/thread/thread_pool.hpp b/src/lib/thread/thread_pool.hpp index 69084090308..ecdaaab40e1 100644 --- a/src/lib/thread/thread_pool.hpp +++ b/src/lib/thread/thread_pool.hpp @@ -19,7 +19,7 @@ class ThreadPool : public BS::thread_pool { ThreadPool(const ThreadPool &) = delete; ThreadPool &operator=(const ThreadPool &) = delete; - void start(); + void start() const; void shutdown(); static int16_t getThreadId() { diff --git a/src/lua/callbacks/creaturecallback.cpp b/src/lua/callbacks/creaturecallback.cpp index 11e33a9b1e1..21c4556cdfd 100644 --- a/src/lua/callbacks/creaturecallback.cpp +++ b/src/lua/callbacks/creaturecallback.cpp @@ -14,8 +14,8 @@ bool CreatureCallback::startScriptInterface(int32_t scriptId) { return false; } - if (!scriptInterface->reserveScriptEnv()) { - auto targetCreature = m_targetCreature.lock(); + if (!LuaScriptInterface::reserveScriptEnv()) { + const auto targetCreature = m_targetCreature.lock(); g_logger().error( "[CreatureCallback::startScriptInterface] - {} {} Call stack overflow. Too many lua script calls being nested.", getCreatureClass(targetCreature), @@ -24,8 +24,7 @@ bool CreatureCallback::startScriptInterface(int32_t scriptId) { return false; } - scriptInterface - ->getScriptEnv() + LuaScriptInterface::getScriptEnv() ->setScriptId(scriptId, scriptInterface); L = scriptInterface->getLuaState(); @@ -35,12 +34,12 @@ bool CreatureCallback::startScriptInterface(int32_t scriptId) { return true; } -void CreatureCallback::pushSpecificCreature(std::shared_ptr<Creature> creature) { - if (std::shared_ptr<Npc> npc = creature->getNpc()) { +void CreatureCallback::pushSpecificCreature(const std::shared_ptr<Creature> &creature) { + if (const auto &npc = creature->getNpc()) { LuaScriptInterface::pushUserdata<Npc>(L, npc); - } else if (std::shared_ptr<Monster> monster = creature->getMonster()) { + } else if (const auto &monster = creature->getMonster()) { LuaScriptInterface::pushUserdata<Monster>(L, monster); - } else if (std::shared_ptr<Player> player = creature->getPlayer()) { + } else if (const auto &player = creature->getPlayer()) { LuaScriptInterface::pushUserdata<Player>(L, player); } else { return; @@ -50,7 +49,7 @@ void CreatureCallback::pushSpecificCreature(std::shared_ptr<Creature> creature) LuaScriptInterface::setMetatable(L, -1, getCreatureClass(creature)); } -std::string CreatureCallback::getCreatureClass(std::shared_ptr<Creature> creature) { +std::string CreatureCallback::getCreatureClass(const std::shared_ptr<Creature> &creature) { if (!creature) { return ""; } diff --git a/src/lua/callbacks/creaturecallback.hpp b/src/lua/callbacks/creaturecallback.hpp index f7665720410..cb2e5c4c189 100644 --- a/src/lua/callbacks/creaturecallback.hpp +++ b/src/lua/callbacks/creaturecallback.hpp @@ -15,19 +15,19 @@ class Creature; class CreatureCallback { public: - CreatureCallback(LuaScriptInterface* scriptInterface, std::shared_ptr<Creature> targetCreature) : + CreatureCallback(LuaScriptInterface* scriptInterface, const std::shared_ptr<Creature> &targetCreature) : scriptInterface(scriptInterface), m_targetCreature(targetCreature) {}; - ~CreatureCallback() { } + ~CreatureCallback() = default; bool startScriptInterface(int32_t scriptId); - void pushSpecificCreature(std::shared_ptr<Creature> creature); + void pushSpecificCreature(const std::shared_ptr<Creature> &creature); - bool persistLuaState() { + bool persistLuaState() const { return params > 0 && scriptInterface->callFunction(params); } - void pushCreature(std::shared_ptr<Creature> creature) { + void pushCreature(const std::shared_ptr<Creature> &creature) { params++; LuaScriptInterface::pushUserdata<Creature>(L, creature); LuaScriptInterface::setCreatureMetatable(L, -1, creature); @@ -54,7 +54,7 @@ class CreatureCallback { } protected: - static std::string getCreatureClass(std::shared_ptr<Creature> creature); + static std::string getCreatureClass(const std::shared_ptr<Creature> &creature); private: LuaScriptInterface* scriptInterface; diff --git a/src/lua/callbacks/event_callback.cpp b/src/lua/callbacks/event_callback.cpp index 6591755d18f..0748333fc93 100644 --- a/src/lua/callbacks/event_callback.cpp +++ b/src/lua/callbacks/event_callback.cpp @@ -53,15 +53,15 @@ void EventCallback::setType(EventCallback_t type) { // Lua functions // Creature -bool EventCallback::creatureOnChangeOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::creatureOnChangeOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::creatureOnChangeOutfit - Creature {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName()); return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -75,8 +75,8 @@ bool EventCallback::creatureOnChangeOutfit(std::shared_ptr<Creature> creature, c return getScriptInterface()->callFunction(2); } -ReturnValue EventCallback::creatureOnAreaCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Tile> tile, bool aggressive) const { - if (!getScriptInterface()->reserveScriptEnv()) { +ReturnValue EventCallback::creatureOnAreaCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &tile, bool aggressive) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::creatureOnAreaCombat - " "Creature {} on tile position {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -84,7 +84,7 @@ ReturnValue EventCallback::creatureOnAreaCombat(std::shared_ptr<Creature> creatu return RETURNVALUE_NOTPOSSIBLE; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -103,7 +103,7 @@ ReturnValue EventCallback::creatureOnAreaCombat(std::shared_ptr<Creature> creatu LuaScriptInterface::pushBoolean(L, aggressive); ReturnValue returnValue; - if (getScriptInterface()->protectedCall(L, 3, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 3, 1) != 0) { returnValue = RETURNVALUE_NOTPOSSIBLE; LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { @@ -111,12 +111,12 @@ ReturnValue EventCallback::creatureOnAreaCombat(std::shared_ptr<Creature> creatu lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return returnValue; } -ReturnValue EventCallback::creatureOnTargetCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> target) const { - if (!getScriptInterface()->reserveScriptEnv()) { +ReturnValue EventCallback::creatureOnTargetCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &target) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::creatureOnTargetCombat - " "Creature {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -124,7 +124,7 @@ ReturnValue EventCallback::creatureOnTargetCombat(std::shared_ptr<Creature> crea return RETURNVALUE_NOTPOSSIBLE; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -141,7 +141,7 @@ ReturnValue EventCallback::creatureOnTargetCombat(std::shared_ptr<Creature> crea LuaScriptInterface::setCreatureMetatable(L, -1, target); ReturnValue returnValue; - if (getScriptInterface()->protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { returnValue = RETURNVALUE_NOTPOSSIBLE; LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { @@ -149,12 +149,12 @@ ReturnValue EventCallback::creatureOnTargetCombat(std::shared_ptr<Creature> crea lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return returnValue; } -void EventCallback::creatureOnHear(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> speaker, const std::string &words, SpeakClasses type) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::creatureOnHear(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &speaker, const std::string &words, SpeakClasses type) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::creatureOnHear - " "Creature {} speaker {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -162,7 +162,7 @@ void EventCallback::creatureOnHear(std::shared_ptr<Creature> creature, std::shar return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -180,8 +180,8 @@ void EventCallback::creatureOnHear(std::shared_ptr<Creature> creature, std::shar getScriptInterface()->callVoidFunction(4); } -void EventCallback::creatureOnDrainHealth(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::creatureOnDrainHealth(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::creatureOnDrainHealth - " "Creature {} attacker {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -189,7 +189,7 @@ void EventCallback::creatureOnDrainHealth(std::shared_ptr<Creature> creature, st return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -216,7 +216,7 @@ void EventCallback::creatureOnDrainHealth(std::shared_ptr<Creature> creature, st lua_pushnumber(L, colorPrimary); lua_pushnumber(L, colorSecondary); - if (getScriptInterface()->protectedCall(L, 8, 6) != 0) { + if (LuaScriptInterface::protectedCall(L, 8, 6) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { typePrimary = LuaScriptInterface::getNumber<CombatType_t>(L, -6); @@ -228,7 +228,7 @@ void EventCallback::creatureOnDrainHealth(std::shared_ptr<Creature> creature, st lua_pop(L, 6); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } void EventCallback::creatureOnCombat(std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, CombatDamage &damage) const { @@ -284,8 +284,8 @@ void EventCallback::creatureOnCombat(std::shared_ptr<Creature> attacker, std::sh } // Party -bool EventCallback::partyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Player> player) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::partyOnJoin(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::partyOnJoin - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -293,7 +293,7 @@ bool EventCallback::partyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Pl return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -308,8 +308,8 @@ bool EventCallback::partyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Pl return getScriptInterface()->callFunction(2); } -bool EventCallback::partyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<Player> player) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::partyOnLeave(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::partyOnLeave - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -317,7 +317,7 @@ bool EventCallback::partyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<P return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -332,15 +332,15 @@ bool EventCallback::partyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<P return getScriptInterface()->callFunction(2); } -bool EventCallback::partyOnDisband(std::shared_ptr<Party> party) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::partyOnDisband(const std::shared_ptr<Party> &party) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::partyOnDisband - Party leader {}] Call stack " "overflow. Too many lua script calls being nested.", party->getLeader() ? party->getLeader()->getName() : "unknown"); return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -352,13 +352,13 @@ bool EventCallback::partyOnDisband(std::shared_ptr<Party> party) const { return getScriptInterface()->callFunction(1); } -void EventCallback::partyOnShareExperience(std::shared_ptr<Party> party, uint64_t &exp) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::partyOnShareExperience(const std::shared_ptr<Party> &party, uint64_t &exp) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("Party leader {}. Call stack overflow. Too many lua script calls being nested.", party->getLeader() ? party->getLeader()->getName() : "unknown"); return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -369,19 +369,19 @@ void EventCallback::partyOnShareExperience(std::shared_ptr<Party> party, uint64_ lua_pushnumber(L, exp); - if (getScriptInterface()->protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { exp = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } // Player -bool EventCallback::playerOnBrowseField(std::shared_ptr<Player> player, const Position &position) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::playerOnBrowseField(const std::shared_ptr<Player> &player, const Position &position) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnBrowseField - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -389,7 +389,7 @@ bool EventCallback::playerOnBrowseField(std::shared_ptr<Player> player, const Po return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -403,8 +403,8 @@ bool EventCallback::playerOnBrowseField(std::shared_ptr<Player> player, const Po return getScriptInterface()->callFunction(2); } -void EventCallback::playerOnLook(std::shared_ptr<Player> player, const Position &position, std::shared_ptr<Thing> thing, uint8_t stackpos, int32_t lookDistance) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnLook(const std::shared_ptr<Player> &player, const Position &position, const std::shared_ptr<Thing> &thing, uint8_t stackpos, int32_t lookDistance) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnLook - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -412,7 +412,7 @@ void EventCallback::playerOnLook(std::shared_ptr<Player> player, const Position return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -421,10 +421,10 @@ void EventCallback::playerOnLook(std::shared_ptr<Player> player, const Position LuaScriptInterface::pushUserdata<Player>(L, player); LuaScriptInterface::setMetatable(L, -1, "Player"); - if (std::shared_ptr<Creature> creature = thing->getCreature()) { + if (const auto &creature = thing->getCreature()) { LuaScriptInterface::pushUserdata<Creature>(L, creature); LuaScriptInterface::setCreatureMetatable(L, -1, creature); - } else if (std::shared_ptr<Item> item = thing->getItem()) { + } else if (const auto &item = thing->getItem()) { LuaScriptInterface::pushUserdata<Item>(L, item); LuaScriptInterface::setItemMetatable(L, -1, item); } else { @@ -437,8 +437,8 @@ void EventCallback::playerOnLook(std::shared_ptr<Player> player, const Position getScriptInterface()->callVoidFunction(4); } -void EventCallback::playerOnLookInBattleList(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, int32_t lookDistance) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnLookInBattleList(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, int32_t lookDistance) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnLookInBattleList - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -446,7 +446,7 @@ void EventCallback::playerOnLookInBattleList(std::shared_ptr<Player> player, std return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -463,8 +463,8 @@ void EventCallback::playerOnLookInBattleList(std::shared_ptr<Player> player, std getScriptInterface()->callVoidFunction(3); } -void EventCallback::playerOnLookInTrade(std::shared_ptr<Player> player, std::shared_ptr<Player> partner, std::shared_ptr<Item> item, int32_t lookDistance) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnLookInTrade(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &partner, const std::shared_ptr<Item> &item, int32_t lookDistance) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnLookInTrade - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -472,7 +472,7 @@ void EventCallback::playerOnLookInTrade(std::shared_ptr<Player> player, std::sha return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -492,8 +492,8 @@ void EventCallback::playerOnLookInTrade(std::shared_ptr<Player> player, std::sha getScriptInterface()->callVoidFunction(4); } -bool EventCallback::playerOnLookInShop(std::shared_ptr<Player> player, const ItemType* itemType, uint8_t count) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::playerOnLookInShop(const std::shared_ptr<Player> &player, const ItemType* itemType, uint8_t count) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnLookInShop - " "Player {} itemType {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -501,7 +501,7 @@ bool EventCallback::playerOnLookInShop(std::shared_ptr<Player> player, const Ite return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -518,8 +518,8 @@ bool EventCallback::playerOnLookInShop(std::shared_ptr<Player> player, const Ite return getScriptInterface()->callFunction(3); } -void EventCallback::playerOnRemoveCount(std::shared_ptr<Player> player, std::shared_ptr<Item> item) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnRemoveCount(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnMove - " "Player {} item {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -527,7 +527,7 @@ void EventCallback::playerOnRemoveCount(std::shared_ptr<Player> player, std::sha return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -542,20 +542,20 @@ void EventCallback::playerOnRemoveCount(std::shared_ptr<Player> player, std::sha getScriptInterface()->callFunction(2); } -bool EventCallback::playerOnMoveItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPos, const Position &toPos, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder) const { +bool EventCallback::playerOnMoveItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPos, const Position &toPos, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder) const { if (!getScriptInterface()) { g_logger().error("script interface nullptr"); return false; } - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Action::executeUse - Player {}, on item {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), item->getName()); return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -577,8 +577,8 @@ bool EventCallback::playerOnMoveItem(std::shared_ptr<Player> player, std::shared return getScriptInterface()->callFunction(7); } -void EventCallback::playerOnItemMoved(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPosition, const Position &toPosition, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnItemMoved(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPosition, const Position &toPosition, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnItemMoved - " "Player {} item {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -586,7 +586,7 @@ void EventCallback::playerOnItemMoved(std::shared_ptr<Player> player, std::share return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -608,8 +608,8 @@ void EventCallback::playerOnItemMoved(std::shared_ptr<Player> player, std::share getScriptInterface()->callVoidFunction(7); } -void EventCallback::playerOnChangeZone(std::shared_ptr<Player> player, ZoneType_t zone) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnChangeZone(const std::shared_ptr<Player> &player, ZoneType_t zone) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnChangeZone - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -617,7 +617,7 @@ void EventCallback::playerOnChangeZone(std::shared_ptr<Player> player, ZoneType_ return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -630,8 +630,8 @@ void EventCallback::playerOnChangeZone(std::shared_ptr<Player> player, ZoneType_ getScriptInterface()->callVoidFunction(2); } -bool EventCallback::playerOnMoveCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, const Position &fromPosition, const Position &toPosition) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::playerOnMoveCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, const Position &fromPosition, const Position &toPosition) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnMoveCreature - " "Player {} creature {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -639,7 +639,7 @@ bool EventCallback::playerOnMoveCreature(std::shared_ptr<Player> player, std::sh return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -657,8 +657,8 @@ bool EventCallback::playerOnMoveCreature(std::shared_ptr<Player> player, std::sh return getScriptInterface()->callFunction(4); } -void EventCallback::playerOnReportRuleViolation(std::shared_ptr<Player> player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnReportRuleViolation(const std::shared_ptr<Player> &player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnReportRuleViolation - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -666,7 +666,7 @@ void EventCallback::playerOnReportRuleViolation(std::shared_ptr<Player> player, return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -686,8 +686,8 @@ void EventCallback::playerOnReportRuleViolation(std::shared_ptr<Player> player, getScriptInterface()->callVoidFunction(6); } -void EventCallback::playerOnReportBug(std::shared_ptr<Player> player, const std::string &message, const Position &position, uint8_t category) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnReportBug(const std::shared_ptr<Player> &player, const std::string &message, const Position &position, uint8_t category) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnReportBug - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -695,7 +695,7 @@ void EventCallback::playerOnReportBug(std::shared_ptr<Player> player, const std: return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -711,8 +711,8 @@ void EventCallback::playerOnReportBug(std::shared_ptr<Player> player, const std: getScriptInterface()->callFunction(4); } -bool EventCallback::playerOnTurn(std::shared_ptr<Player> player, Direction direction) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::playerOnTurn(const std::shared_ptr<Player> &player, Direction direction) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnTurn - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -720,7 +720,7 @@ bool EventCallback::playerOnTurn(std::shared_ptr<Player> player, Direction direc return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -734,8 +734,8 @@ bool EventCallback::playerOnTurn(std::shared_ptr<Player> player, Direction direc return getScriptInterface()->callFunction(2); } -bool EventCallback::playerOnTradeRequest(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::playerOnTradeRequest(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnTradeRequest - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -743,7 +743,7 @@ bool EventCallback::playerOnTradeRequest(std::shared_ptr<Player> player, std::sh return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -761,8 +761,8 @@ bool EventCallback::playerOnTradeRequest(std::shared_ptr<Player> player, std::sh return getScriptInterface()->callFunction(3); } -bool EventCallback::playerOnTradeAccept(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item, std::shared_ptr<Item> targetItem) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::playerOnTradeAccept(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &targetItem) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnTradeAccept - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -770,7 +770,7 @@ bool EventCallback::playerOnTradeAccept(std::shared_ptr<Player> player, std::sha return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -791,8 +791,8 @@ bool EventCallback::playerOnTradeAccept(std::shared_ptr<Player> player, std::sha return getScriptInterface()->callFunction(4); } -void EventCallback::playerOnGainExperience(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint64_t &exp, uint64_t rawExp) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnGainExperience(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint64_t &exp, uint64_t rawExp) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnGainExperience - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -800,7 +800,7 @@ void EventCallback::playerOnGainExperience(std::shared_ptr<Player> player, std:: return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -819,18 +819,18 @@ void EventCallback::playerOnGainExperience(std::shared_ptr<Player> player, std:: lua_pushnumber(L, exp); lua_pushnumber(L, rawExp); - if (getScriptInterface()->protectedCall(L, 4, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 4, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { exp = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void EventCallback::playerOnLoseExperience(std::shared_ptr<Player> player, uint64_t &exp) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnLoseExperience(const std::shared_ptr<Player> &player, uint64_t &exp) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnLoseExperience - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -838,7 +838,7 @@ void EventCallback::playerOnLoseExperience(std::shared_ptr<Player> player, uint6 return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -849,18 +849,18 @@ void EventCallback::playerOnLoseExperience(std::shared_ptr<Player> player, uint6 lua_pushnumber(L, exp); - if (getScriptInterface()->protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { exp = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void EventCallback::playerOnGainSkillTries(std::shared_ptr<Player> player, skills_t skill, uint64_t &tries) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnGainSkillTries(const std::shared_ptr<Player> &player, skills_t skill, uint64_t &tries) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnGainSkillTries - " "Player {} skill {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -868,7 +868,7 @@ void EventCallback::playerOnGainSkillTries(std::shared_ptr<Player> player, skill return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -880,18 +880,18 @@ void EventCallback::playerOnGainSkillTries(std::shared_ptr<Player> player, skill lua_pushnumber(L, skill); lua_pushnumber(L, tries); - if (getScriptInterface()->protectedCall(L, 3, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 3, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { tries = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void EventCallback::playerOnCombat(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, CombatDamage &damage) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnCombat(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, CombatDamage &damage) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnCombat - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -899,7 +899,7 @@ void EventCallback::playerOnCombat(std::shared_ptr<Player> player, std::shared_p return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -924,7 +924,7 @@ void EventCallback::playerOnCombat(std::shared_ptr<Player> player, std::shared_p LuaScriptInterface::pushCombatDamage(L, damage); - if (getScriptInterface()->protectedCall(L, 8, 4) != 0) { + if (LuaScriptInterface::protectedCall(L, 8, 4) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { damage.primary.value = std::abs(LuaScriptInterface::getNumber<int32_t>(L, -4)); @@ -949,11 +949,11 @@ void EventCallback::playerOnCombat(std::shared_ptr<Player> player, std::shared_p } } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void EventCallback::playerOnRequestQuestLog(std::shared_ptr<Player> player) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnRequestQuestLog(const std::shared_ptr<Player> &player) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnRequestQuestLog - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -961,7 +961,7 @@ void EventCallback::playerOnRequestQuestLog(std::shared_ptr<Player> player) cons return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -973,8 +973,8 @@ void EventCallback::playerOnRequestQuestLog(std::shared_ptr<Player> player) cons getScriptInterface()->callVoidFunction(1); } -void EventCallback::playerOnRequestQuestLine(std::shared_ptr<Player> player, uint16_t questId) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnRequestQuestLine(const std::shared_ptr<Player> &player, uint16_t questId) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::playerOnRequestQuestLine - " "Player {} questId {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -982,7 +982,7 @@ void EventCallback::playerOnRequestQuestLine(std::shared_ptr<Player> player, uin return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -996,13 +996,13 @@ void EventCallback::playerOnRequestQuestLine(std::shared_ptr<Player> player, uin getScriptInterface()->callVoidFunction(2); } -void EventCallback::playerOnInventoryUpdate(std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool equip) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnInventoryUpdate(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool equip) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[{}] Call stack overflow", __FUNCTION__); return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1020,13 +1020,13 @@ void EventCallback::playerOnInventoryUpdate(std::shared_ptr<Player> player, std: getScriptInterface()->callVoidFunction(4); } -bool EventCallback::playerOnRotateItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, const Position &position) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::playerOnRotateItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const Position &position) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[{}] Call stack overflow", __FUNCTION__); return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1043,8 +1043,8 @@ bool EventCallback::playerOnRotateItem(std::shared_ptr<Player> player, std::shar return getScriptInterface()->callFunction(3); } -void EventCallback::playerOnWalk(std::shared_ptr<Player> player, Direction &dir) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnWalk(const std::shared_ptr<Player> &player, const Direction &dir) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::eventOnWalk - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1052,7 +1052,7 @@ void EventCallback::playerOnWalk(std::shared_ptr<Player> player, Direction &dir) return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1066,8 +1066,8 @@ void EventCallback::playerOnWalk(std::shared_ptr<Player> player, Direction &dir) getScriptInterface()->callVoidFunction(2); } -void EventCallback::playerOnStorageUpdate(std::shared_ptr<Player> player, const uint32_t key, const int32_t value, int32_t oldValue, uint64_t currentTime) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::playerOnStorageUpdate(const std::shared_ptr<Player> &player, const uint32_t key, const int32_t value, int32_t oldValue, uint64_t currentTime) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::eventOnStorageUpdate - " "Player {} key {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1075,7 +1075,7 @@ void EventCallback::playerOnStorageUpdate(std::shared_ptr<Player> player, const return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1113,8 +1113,8 @@ void EventCallback::playerOnThink(std::shared_ptr<Player> player, uint32_t inter } // Monster -void EventCallback::monsterOnDropLoot(std::shared_ptr<Monster> monster, std::shared_ptr<Container> corpse) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::monsterOnDropLoot(const std::shared_ptr<Monster> &monster, const std::shared_ptr<Container> &corpse) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::monsterOnDropLoot - " "Monster corpse {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1122,7 +1122,7 @@ void EventCallback::monsterOnDropLoot(std::shared_ptr<Monster> monster, std::sha return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1137,8 +1137,8 @@ void EventCallback::monsterOnDropLoot(std::shared_ptr<Monster> monster, std::sha return getScriptInterface()->callVoidFunction(2); } -void EventCallback::monsterPostDropLoot(std::shared_ptr<Monster> monster, std::shared_ptr<Container> corpse) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::monsterPostDropLoot(const std::shared_ptr<Monster> &monster, const std::shared_ptr<Container> &corpse) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::monsterPostDropLoot - " "Monster corpse {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1146,7 +1146,7 @@ void EventCallback::monsterPostDropLoot(std::shared_ptr<Monster> monster, std::s return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1161,8 +1161,8 @@ void EventCallback::monsterPostDropLoot(std::shared_ptr<Monster> monster, std::s return getScriptInterface()->callVoidFunction(2); } -void EventCallback::monsterOnSpawn(std::shared_ptr<Monster> monster, const Position &position) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::monsterOnSpawn(const std::shared_ptr<Monster> &monster, const Position &position) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("{} - " "Position {}" ". Call stack overflow. Too many lua script calls being nested.", @@ -1170,7 +1170,7 @@ void EventCallback::monsterOnSpawn(std::shared_ptr<Monster> monster, const Posit return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1180,18 +1180,18 @@ void EventCallback::monsterOnSpawn(std::shared_ptr<Monster> monster, const Posit LuaScriptInterface::setMetatable(L, -1, "Monster"); LuaScriptInterface::pushPosition(L, position); - if (getScriptInterface()->protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } // Npc -void EventCallback::npcOnSpawn(std::shared_ptr<Npc> npc, const Position &position) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::npcOnSpawn(const std::shared_ptr<Npc> &npc, const Position &position) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("{} - " "Position {}" ". Call stack overflow. Too many lua script calls being nested.", @@ -1199,7 +1199,7 @@ void EventCallback::npcOnSpawn(std::shared_ptr<Npc> npc, const Position &positio return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1209,17 +1209,17 @@ void EventCallback::npcOnSpawn(std::shared_ptr<Npc> npc, const Position &positio LuaScriptInterface::setMetatable(L, -1, "Npc"); LuaScriptInterface::pushPosition(L, position); - if (getScriptInterface()->protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { lua_pop(L, 1); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -bool EventCallback::zoneBeforeCreatureEnter(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::zoneBeforeCreatureEnter(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::zoneBeforeCreatureEnter - " "Zone {} Creature {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1227,7 +1227,7 @@ bool EventCallback::zoneBeforeCreatureEnter(std::shared_ptr<Zone> zone, std::sha return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1242,8 +1242,8 @@ bool EventCallback::zoneBeforeCreatureEnter(std::shared_ptr<Zone> zone, std::sha return getScriptInterface()->callFunction(2); } -bool EventCallback::zoneBeforeCreatureLeave(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const { - if (!getScriptInterface()->reserveScriptEnv()) { +bool EventCallback::zoneBeforeCreatureLeave(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::zoneBeforeCreatureLeave - " "Zone {} Creature {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1251,7 +1251,7 @@ bool EventCallback::zoneBeforeCreatureLeave(std::shared_ptr<Zone> zone, std::sha return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1266,8 +1266,8 @@ bool EventCallback::zoneBeforeCreatureLeave(std::shared_ptr<Zone> zone, std::sha return getScriptInterface()->callFunction(2); } -void EventCallback::zoneAfterCreatureEnter(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::zoneAfterCreatureEnter(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::zoneAfterCreatureEnter - " "Zone {} Creature {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1275,7 +1275,7 @@ void EventCallback::zoneAfterCreatureEnter(std::shared_ptr<Zone> zone, std::shar return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -1290,8 +1290,8 @@ void EventCallback::zoneAfterCreatureEnter(std::shared_ptr<Zone> zone, std::shar getScriptInterface()->callVoidFunction(2); } -void EventCallback::zoneAfterCreatureLeave(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const { - if (!getScriptInterface()->reserveScriptEnv()) { +void EventCallback::zoneAfterCreatureLeave(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[EventCallback::zoneAfterCreatureLeave - " "Zone {} Creature {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1299,7 +1299,7 @@ void EventCallback::zoneAfterCreatureLeave(std::shared_ptr<Zone> zone, std::shar return; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); diff --git a/src/lua/callbacks/event_callback.hpp b/src/lua/callbacks/event_callback.hpp index 9e65480c246..fb0eb760a20 100644 --- a/src/lua/callbacks/event_callback.hpp +++ b/src/lua/callbacks/event_callback.hpp @@ -31,7 +31,7 @@ class Zone; * registration, and execution of custom behavior tied to specific game events. * @note It inherits from the Script class, providing scripting capabilities. */ -class EventCallback : public Script { +class EventCallback final : public Script { private: EventCallback_t m_callbackType = EventCallback_t::none; ///< The type of the event callback. std::string m_scriptTypeName; ///< The name associated with the script type. @@ -67,7 +67,7 @@ class EventCallback : public Script { * @brief Sets a new script type name. * @param newName The new name to set for the script type. */ - void setScriptTypeName(const std::string_view newName); + void setScriptTypeName(std::string_view newName); /** * @brief Retrieves the type of the event callback. @@ -93,60 +93,60 @@ class EventCallback : public Script { */ // Creature - bool creatureOnChangeOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit) const; - ReturnValue creatureOnAreaCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Tile> tile, bool aggressive) const; - ReturnValue creatureOnTargetCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> target) const; - void creatureOnHear(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> speaker, const std::string &words, SpeakClasses type) const; - void creatureOnDrainHealth(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary) const; + bool creatureOnChangeOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit) const; + ReturnValue creatureOnAreaCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &tile, bool aggressive) const; + ReturnValue creatureOnTargetCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &target) const; + void creatureOnHear(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &speaker, const std::string &words, SpeakClasses type) const; + void creatureOnDrainHealth(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary) const; void creatureOnCombat(std::shared_ptr<Creature> attacker, std::shared_ptr<Creature> target, CombatDamage &damage) const; // Party - bool partyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Player> player) const; - bool partyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<Player> player) const; - bool partyOnDisband(std::shared_ptr<Party> party) const; - void partyOnShareExperience(std::shared_ptr<Party> party, uint64_t &exp) const; + bool partyOnJoin(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player) const; + bool partyOnLeave(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player) const; + bool partyOnDisband(const std::shared_ptr<Party> &party) const; + void partyOnShareExperience(const std::shared_ptr<Party> &party, uint64_t &exp) const; // Player - bool playerOnBrowseField(std::shared_ptr<Player> player, const Position &position) const; - void playerOnLook(std::shared_ptr<Player> player, const Position &position, std::shared_ptr<Thing> thing, uint8_t stackpos, int32_t lookDistance) const; - void playerOnLookInBattleList(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, int32_t lookDistance) const; - void playerOnLookInTrade(std::shared_ptr<Player> player, std::shared_ptr<Player> partner, std::shared_ptr<Item> item, int32_t lookDistance) const; - bool playerOnLookInShop(std::shared_ptr<Player> player, const ItemType* itemType, uint8_t count) const; - bool playerOnMoveItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPosition, const Position &toPosition, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder) const; - void playerOnItemMoved(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPosition, const Position &toPosition, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder) const; - void playerOnChangeZone(std::shared_ptr<Player> player, ZoneType_t zone) const; - bool playerOnMoveCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, const Position &fromPosition, const Position &toPosition) const; - void playerOnReportRuleViolation(std::shared_ptr<Player> player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation) const; - void playerOnReportBug(std::shared_ptr<Player> player, const std::string &message, const Position &position, uint8_t category) const; - bool playerOnTurn(std::shared_ptr<Player> player, Direction direction) const; - bool playerOnTradeRequest(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item) const; - bool playerOnTradeAccept(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item, std::shared_ptr<Item> targetItem) const; - void playerOnGainExperience(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint64_t &exp, uint64_t rawExp) const; - void playerOnLoseExperience(std::shared_ptr<Player> player, uint64_t &exp) const; - void playerOnGainSkillTries(std::shared_ptr<Player> player, skills_t skill, uint64_t &tries) const; - void playerOnRemoveCount(std::shared_ptr<Player> player, std::shared_ptr<Item> item) const; - void playerOnRequestQuestLog(std::shared_ptr<Player> player) const; - void playerOnRequestQuestLine(std::shared_ptr<Player> player, uint16_t questId) const; - void playerOnStorageUpdate(std::shared_ptr<Player> player, const uint32_t key, const int32_t value, int32_t oldValue, uint64_t currentTime) const; - void playerOnCombat(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, CombatDamage &damage) const; - void playerOnInventoryUpdate(std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool equip) const; - bool playerOnRotateItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, const Position &position) const; - void playerOnWalk(std::shared_ptr<Player> player, Direction &dir) const; + bool playerOnBrowseField(const std::shared_ptr<Player> &player, const Position &position) const; + void playerOnLook(const std::shared_ptr<Player> &player, const Position &position, const std::shared_ptr<Thing> &thing, uint8_t stackpos, int32_t lookDistance) const; + void playerOnLookInBattleList(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, int32_t lookDistance) const; + void playerOnLookInTrade(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &partner, const std::shared_ptr<Item> &item, int32_t lookDistance) const; + bool playerOnLookInShop(const std::shared_ptr<Player> &player, const ItemType* itemType, uint8_t count) const; + bool playerOnMoveItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPosition, const Position &toPosition, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder) const; + void playerOnItemMoved(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPosition, const Position &toPosition, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder) const; + void playerOnChangeZone(const std::shared_ptr<Player> &player, ZoneType_t zone) const; + bool playerOnMoveCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, const Position &fromPosition, const Position &toPosition) const; + void playerOnReportRuleViolation(const std::shared_ptr<Player> &player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation) const; + void playerOnReportBug(const std::shared_ptr<Player> &player, const std::string &message, const Position &position, uint8_t category) const; + bool playerOnTurn(const std::shared_ptr<Player> &player, Direction direction) const; + bool playerOnTradeRequest(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item) const; + bool playerOnTradeAccept(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &targetItem) const; + void playerOnGainExperience(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint64_t &exp, uint64_t rawExp) const; + void playerOnLoseExperience(const std::shared_ptr<Player> &player, uint64_t &exp) const; + void playerOnGainSkillTries(const std::shared_ptr<Player> &player, skills_t skill, uint64_t &tries) const; + void playerOnRemoveCount(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) const; + void playerOnRequestQuestLog(const std::shared_ptr<Player> &player) const; + void playerOnRequestQuestLine(const std::shared_ptr<Player> &player, uint16_t questId) const; + void playerOnStorageUpdate(const std::shared_ptr<Player> &player, uint32_t key, int32_t value, int32_t oldValue, uint64_t currentTime) const; + void playerOnCombat(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, CombatDamage &damage) const; + void playerOnInventoryUpdate(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool equip) const; + bool playerOnRotateItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const Position &position) const; + void playerOnWalk(const std::shared_ptr<Player> &player, const Direction &dir) const; void playerOnThink(std::shared_ptr<Player> player, uint32_t interval) const; // Monster - void monsterOnDropLoot(std::shared_ptr<Monster> monster, std::shared_ptr<Container> corpse) const; - void monsterPostDropLoot(std::shared_ptr<Monster> monster, std::shared_ptr<Container> corpse) const; - void monsterOnSpawn(std::shared_ptr<Monster> monster, const Position &position) const; + void monsterOnDropLoot(const std::shared_ptr<Monster> &monster, const std::shared_ptr<Container> &corpse) const; + void monsterPostDropLoot(const std::shared_ptr<Monster> &monster, const std::shared_ptr<Container> &corpse) const; + void monsterOnSpawn(const std::shared_ptr<Monster> &monster, const Position &position) const; // Npc - void npcOnSpawn(std::shared_ptr<Npc> npc, const Position &position) const; + void npcOnSpawn(const std::shared_ptr<Npc> &npc, const Position &position) const; // Zone - bool zoneBeforeCreatureEnter(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const; - bool zoneBeforeCreatureLeave(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const; - void zoneAfterCreatureEnter(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const; - void zoneAfterCreatureLeave(std::shared_ptr<Zone> zone, std::shared_ptr<Creature> creature) const; + bool zoneBeforeCreatureEnter(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const; + bool zoneBeforeCreatureLeave(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const; + void zoneAfterCreatureEnter(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const; + void zoneAfterCreatureLeave(const std::shared_ptr<Zone> &zone, const std::shared_ptr<Creature> &creature) const; void mapOnLoad(const std::string &mapFullPath) const; }; diff --git a/src/lua/creature/actions.cpp b/src/lua/creature/actions.cpp index c754ffa637c..3673b7c112e 100644 --- a/src/lua/creature/actions.cpp +++ b/src/lua/creature/actions.cpp @@ -25,7 +25,7 @@ void Actions::clear() { actionPositionMap.clear(); } -bool Actions::registerLuaItemEvent(const std::shared_ptr<Action> action) { +bool Actions::registerLuaItemEvent(const std::shared_ptr<Action> &action) { auto itemIdVector = action->getItemIdsVector(); if (itemIdVector.empty()) { return false; @@ -58,7 +58,7 @@ bool Actions::registerLuaItemEvent(const std::shared_ptr<Action> action) { return !itemIdVector.empty(); } -bool Actions::registerLuaUniqueEvent(const std::shared_ptr<Action> action) { +bool Actions::registerLuaUniqueEvent(const std::shared_ptr<Action> &action) { auto uniqueIdVector = action->getUniqueIdsVector(); if (uniqueIdVector.empty()) { return false; @@ -89,7 +89,7 @@ bool Actions::registerLuaUniqueEvent(const std::shared_ptr<Action> action) { return !uniqueIdVector.empty(); } -bool Actions::registerLuaActionEvent(const std::shared_ptr<Action> action) { +bool Actions::registerLuaActionEvent(const std::shared_ptr<Action> &action) { auto actionIdVector = action->getActionIdsVector(); if (actionIdVector.empty()) { return false; @@ -120,7 +120,7 @@ bool Actions::registerLuaActionEvent(const std::shared_ptr<Action> action) { return !actionIdVector.empty(); } -bool Actions::registerLuaPositionEvent(const std::shared_ptr<Action> action) { +bool Actions::registerLuaPositionEvent(const std::shared_ptr<Action> &action) { auto positionVector = action->getPositionsVector(); if (positionVector.empty()) { return false; @@ -149,7 +149,7 @@ bool Actions::registerLuaPositionEvent(const std::shared_ptr<Action> action) { return !positionVector.empty(); } -bool Actions::registerLuaEvent(const std::shared_ptr<Action> action) { +bool Actions::registerLuaEvent(const std::shared_ptr<Action> &action) { // Call all register lua events if (registerLuaItemEvent(action) || registerLuaUniqueEvent(action) || registerLuaActionEvent(action) || registerLuaPositionEvent(action)) { return true; @@ -165,7 +165,7 @@ bool Actions::registerLuaEvent(const std::shared_ptr<Action> action) { return false; } -ReturnValue Actions::canUse(std::shared_ptr<Player> player, const Position &pos) { +ReturnValue Actions::canUse(const std::shared_ptr<Player> &player, const Position &pos) const { if (pos.x != 0xFFFF) { const Position &playerPos = player->getPosition(); if (playerPos.z != pos.z) { @@ -179,15 +179,15 @@ ReturnValue Actions::canUse(std::shared_ptr<Player> player, const Position &pos) return RETURNVALUE_NOERROR; } -ReturnValue Actions::canUse(std::shared_ptr<Player> player, const Position &pos, std::shared_ptr<Item> item) { - const std::shared_ptr<Action> action = getAction(item); +ReturnValue Actions::canUse(const std::shared_ptr<Player> &player, const Position &pos, const std::shared_ptr<Item> &item) { + const auto &action = getAction(item); if (action != nullptr) { return action->canExecuteAction(player, pos); } return RETURNVALUE_NOERROR; } -ReturnValue Actions::canUseFar(std::shared_ptr<Creature> creature, const Position &toPos, bool checkLineOfSight, bool checkFloor) { +ReturnValue Actions::canUseFar(const std::shared_ptr<Creature> &creature, const Position &toPos, bool checkLineOfSight, bool checkFloor) const { if (toPos.x == 0xFFFF) { return RETURNVALUE_NOERROR; } @@ -208,31 +208,30 @@ ReturnValue Actions::canUseFar(std::shared_ptr<Creature> creature, const Positio return RETURNVALUE_NOERROR; } -std::shared_ptr<Action> Actions::getAction(std::shared_ptr<Item> item) { +std::shared_ptr<Action> Actions::getAction(const std::shared_ptr<Item> &item) { if (item->hasAttribute(ItemAttribute_t::UNIQUEID)) { - auto it = uniqueItemMap.find(item->getAttribute<uint16_t>(ItemAttribute_t::UNIQUEID)); + const auto it = uniqueItemMap.find(item->getAttribute<uint16_t>(ItemAttribute_t::UNIQUEID)); if (it != uniqueItemMap.end()) { return it->second; } } if (item->hasAttribute(ItemAttribute_t::ACTIONID)) { - auto it = actionItemMap.find(item->getAttribute<uint16_t>(ItemAttribute_t::ACTIONID)); + const auto it = actionItemMap.find(item->getAttribute<uint16_t>(ItemAttribute_t::ACTIONID)); if (it != actionItemMap.end()) { return it->second; } } - auto it = useItemMap.find(item->getID()); + const auto it = useItemMap.find(item->getID()); if (it != useItemMap.end()) { return it->second; } - if (auto iteratePositions = actionPositionMap.find(item->getPosition()); + if (const auto iteratePositions = actionPositionMap.find(item->getPosition()); iteratePositions != actionPositionMap.end()) { - if (std::shared_ptr<Tile> tile = item->getTile(); - tile) { - if (std::shared_ptr<Player> player = item->getHoldingPlayer(); + if (const auto &tile = item->getTile()) { + if (const auto &player = item->getHoldingPlayer(); player && item->getTopParent() == player) { g_logger().debug("[Actions::getAction] - The position only is valid for use item in the map, player name {}", player->getName()); return nullptr; @@ -246,8 +245,8 @@ std::shared_ptr<Action> Actions::getAction(std::shared_ptr<Item> item) { return g_spells().getRuneSpell(item->getID()); } -ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Position &pos, uint8_t index, std::shared_ptr<Item> item, bool isHotkey) { - if (std::shared_ptr<Door> door = item->getDoor()) { +ReturnValue Actions::internalUseItem(const std::shared_ptr<Player> &player, const Position &pos, uint8_t index, const std::shared_ptr<Item> &item, bool isHotkey) { + if (const auto &door = item->getDoor()) { if (!door->canUse(player)) { return RETURNVALUE_CANNOTUSETHISOBJECT; } @@ -256,7 +255,7 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit auto itemId = item->getID(); const ItemType &itemType = Item::items[itemId]; auto transformTo = itemType.m_transformOnUse; - const std::shared_ptr<Action> action = getAction(item); + const auto &action = getAction(item); if (!action && transformTo > 0 && itemId != transformTo) { if (g_game().transformItem(item, transformTo) == nullptr) { g_logger().warn("[{}] item with id {} failed to transform to item {}", __FUNCTION__, itemId, transformTo); @@ -281,7 +280,7 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit } } - if (std::shared_ptr<BedItem> bed = item->getBed()) { + if (const auto &bed = item->getBed()) { if (!bed->canUse(player)) { return RETURNVALUE_CANNOTUSETHISOBJECT; } @@ -294,12 +293,12 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit return RETURNVALUE_NOERROR; } - if (std::shared_ptr<Container> container = item->getContainer()) { + if (const auto &container = item->getContainer()) { std::shared_ptr<Container> openContainer; // depot container - if (std::shared_ptr<DepotLocker> depot = container->getDepotLocker()) { - std::shared_ptr<DepotLocker> myDepotLocker = player->getDepotLocker(depot->getDepotId()); + if (const auto &depot = container->getDepotLocker()) { + const auto &myDepotLocker = player->getDepotLocker(depot->getDepotId()); myDepotLocker->setParent(depot->getParent()->getTile()); openContainer = myDepotLocker; player->setLastDepotId(depot->getDepotId()); @@ -313,7 +312,7 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit player->removeEmptyRewards(); } - std::shared_ptr<RewardChest> playerRewardChest = player->getRewardChest(); + const auto &playerRewardChest = player->getRewardChest(); if (playerRewardChest->empty()) { return RETURNVALUE_REWARDCHESTISEMPTY; } @@ -326,10 +325,10 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit openContainer = playerRewardChest; } - auto rewardId = container->getAttribute<time_t>(ItemAttribute_t::DATE); + const auto rewardId = container->getAttribute<time_t>(ItemAttribute_t::DATE); // Reward container proxy created when the boss dies if (container->getID() == ITEM_REWARD_CONTAINER && !container->getReward()) { - auto reward = player->getReward(rewardId, false); + const auto &reward = player->getReward(rewardId, false); if (!reward) { return RETURNVALUE_THISISIMPOSSIBLE; } @@ -340,13 +339,13 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit openContainer = reward; } - uint32_t corpseOwner = container->getCorpseOwner(); + const uint32_t corpseOwner = container->getCorpseOwner(); if (container->isRewardCorpse()) { // only players who participated in the fight can open the corpse if (player->getGroup()->id >= GROUP_TYPE_GAMEMASTER) { return RETURNVALUE_YOUCANTOPENCORPSEADM; } - auto reward = player->getReward(rewardId, false); + const auto &reward = player->getReward(rewardId, false); if (!reward) { return RETURNVALUE_YOUARENOTTHEOWNER; } @@ -358,7 +357,7 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit } // open/close container - int32_t oldContainerId = player->getContainerID(openContainer); + const int32_t oldContainerId = player->getContainerID(openContainer); if (oldContainerId != -1) { player->onCloseContainer(openContainer); player->closeContainer(oldContainerId); @@ -386,7 +385,7 @@ ReturnValue Actions::internalUseItem(std::shared_ptr<Player> player, const Posit return RETURNVALUE_CANNOTUSETHISOBJECT; } -bool Actions::useItem(std::shared_ptr<Player> player, const Position &pos, uint8_t index, std::shared_ptr<Item> item, bool isHotkey) { +bool Actions::useItem(const std::shared_ptr<Player> &player, const Position &pos, uint8_t index, const std::shared_ptr<Item> &item, bool isHotkey) { const ItemType &it = Item::items[item->getID()]; if (it.isRune() || it.type == ITEM_TYPE_POTION) { if (player->walkExhausted()) { @@ -395,7 +394,7 @@ bool Actions::useItem(std::shared_ptr<Player> player, const Position &pos, uint8 } } if (isHotkey) { - uint16_t subType = item->getSubType(); + const uint16_t subType = item->getSubType(); showUseHotkeyMessage(player, item, player->getItemTypeCount(item->getID(), subType != item->getItemCount() ? subType : -1)); } @@ -418,7 +417,7 @@ bool Actions::useItem(std::shared_ptr<Player> player, const Position &pos, uint8 return true; } -bool Actions::useItemEx(std::shared_ptr<Player> player, const Position &fromPos, const Position &toPos, uint8_t toStackPos, std::shared_ptr<Item> item, bool isHotkey, std::shared_ptr<Creature> creature /* = nullptr*/) { +bool Actions::useItemEx(const std::shared_ptr<Player> &player, const Position &fromPos, const Position &toPos, uint8_t toStackPos, const std::shared_ptr<Item> &item, bool isHotkey, const std::shared_ptr<Creature> &creature /* = nullptr*/) { const ItemType &it = Item::items[item->getID()]; if (it.isRune() || it.type == ITEM_TYPE_POTION) { if (player->walkExhausted()) { @@ -440,7 +439,7 @@ bool Actions::useItemEx(std::shared_ptr<Player> player, const Position &fromPos, } if (isHotkey) { - uint16_t subType = item->getSubType(); + const uint16_t subType = item->getSubType(); showUseHotkeyMessage(player, item, player->getItemTypeCount(item->getID(), subType != item->getItemCount() ? subType : -1)); } @@ -470,7 +469,7 @@ bool Actions::useItemEx(std::shared_ptr<Player> player, const Position &fromPos, return true; } -void Actions::showUseHotkeyMessage(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint32_t count) { +void Actions::showUseHotkeyMessage(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint32_t count) { std::ostringstream ss; const ItemType &it = Item::items[item->getID()]; @@ -494,7 +493,7 @@ void Actions::showUseHotkeyMessage(std::shared_ptr<Player> player, std::shared_p Action::Action(LuaScriptInterface* interface) : Script(interface) { } -ReturnValue Action::canExecuteAction(std::shared_ptr<Player> player, const Position &toPos) { +ReturnValue Action::canExecuteAction(const std::shared_ptr<Player> &player, const Position &toPos) { if (!allowFarUse) { return g_actions().canUse(player, toPos); } @@ -502,23 +501,23 @@ ReturnValue Action::canExecuteAction(std::shared_ptr<Player> player, const Posit return g_actions().canUseFar(player, toPos, checkLineOfSight, checkFloor); } -std::shared_ptr<Thing> Action::getTarget(std::shared_ptr<Player> player, std::shared_ptr<Creature> targetCreature, const Position &toPosition, uint8_t toStackPos) const { +std::shared_ptr<Thing> Action::getTarget(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &targetCreature, const Position &toPosition, uint8_t toStackPos) const { if (targetCreature != nullptr) { return targetCreature; } return g_game().internalGetThing(player, toPosition, toStackPos, 0, STACKPOS_USETARGET); } -bool Action::executeUse(std::shared_ptr<Player> player, std::shared_ptr<Item> item, const Position &fromPosition, std::shared_ptr<Thing> target, const Position &toPosition, bool isHotkey) { +bool Action::executeUse(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const Position &fromPosition, const std::shared_ptr<Thing> &target, const Position &toPosition, bool isHotkey) { // onUse(player, item, fromPosition, target, toPosition, isHotkey) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Action::executeUse - Player {}, on item {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), item->getName()); return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); diff --git a/src/lua/creature/actions.hpp b/src/lua/creature/actions.hpp index 81a7754a5b1..ed5c6adc399 100644 --- a/src/lua/creature/actions.hpp +++ b/src/lua/creature/actions.hpp @@ -14,14 +14,14 @@ #include "lua/scripts/luascript.hpp" class Action; -class Position; +struct Position; class Action : public Script { public: explicit Action(LuaScriptInterface* interface); // Scripting - virtual bool executeUse(std::shared_ptr<Player> player, std::shared_ptr<Item> item, const Position &fromPosition, std::shared_ptr<Thing> target, const Position &toPosition, bool isHotkey); + virtual bool executeUse(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const Position &fromPosition, const std::shared_ptr<Thing> &target, const Position &toPosition, bool isHotkey); bool getAllowFarUse() const { return allowFarUse; @@ -96,13 +96,13 @@ class Action : public Script { positions.emplace_back(pos); } - virtual ReturnValue canExecuteAction(std::shared_ptr<Player> player, const Position &toPos); + virtual ReturnValue canExecuteAction(const std::shared_ptr<Player> &player, const Position &toPos); virtual bool hasOwnErrorHandler() { return false; } - virtual std::shared_ptr<Thing> getTarget(std::shared_ptr<Player> player, std::shared_ptr<Creature> targetCreature, const Position &toPosition, uint8_t toStackPos) const; + virtual std::shared_ptr<Thing> getTarget(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &targetCreature, const Position &toPosition, uint8_t toStackPos) const; private: std::string getScriptTypeName() const override { @@ -110,8 +110,8 @@ class Action : public Script { } std::function<bool( - std::shared_ptr<Player> player, std::shared_ptr<Item> item, - const Position &fromPosition, std::shared_ptr<Thing> target, + const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, + const Position &fromPosition, const std::shared_ptr<Thing> &target, const Position &toPosition, bool isHotkey )> useFunction = nullptr; @@ -143,24 +143,24 @@ class Actions final : public Scripts { return inject<Actions>(); } - bool useItem(std::shared_ptr<Player> player, const Position &pos, uint8_t index, std::shared_ptr<Item> item, bool isHotkey); - bool useItemEx(std::shared_ptr<Player> player, const Position &fromPos, const Position &toPos, uint8_t toStackPos, std::shared_ptr<Item> item, bool isHotkey, std::shared_ptr<Creature> creature = nullptr); + bool useItem(const std::shared_ptr<Player> &player, const Position &pos, uint8_t index, const std::shared_ptr<Item> &item, bool isHotkey); + bool useItemEx(const std::shared_ptr<Player> &player, const Position &fromPos, const Position &toPos, uint8_t toStackPos, const std::shared_ptr<Item> &item, bool isHotkey, const std::shared_ptr<Creature> &creature = nullptr); - ReturnValue canUse(std::shared_ptr<Player> player, const Position &pos); - ReturnValue canUse(std::shared_ptr<Player> player, const Position &pos, std::shared_ptr<Item> item); - ReturnValue canUseFar(std::shared_ptr<Creature> creature, const Position &toPos, bool checkLineOfSight, bool checkFloor); + ReturnValue canUse(const std::shared_ptr<Player> &player, const Position &pos) const; + ReturnValue canUse(const std::shared_ptr<Player> &player, const Position &pos, const std::shared_ptr<Item> &item); + ReturnValue canUseFar(const std::shared_ptr<Creature> &creature, const Position &toPos, bool checkLineOfSight, bool checkFloor) const; - bool registerLuaItemEvent(const std::shared_ptr<Action> action); - bool registerLuaUniqueEvent(const std::shared_ptr<Action> action); - bool registerLuaActionEvent(const std::shared_ptr<Action> action); - bool registerLuaPositionEvent(const std::shared_ptr<Action> action); - bool registerLuaEvent(const std::shared_ptr<Action> action); + bool registerLuaItemEvent(const std::shared_ptr<Action> &action); + bool registerLuaUniqueEvent(const std::shared_ptr<Action> &action); + bool registerLuaActionEvent(const std::shared_ptr<Action> &action); + bool registerLuaPositionEvent(const std::shared_ptr<Action> &action); + bool registerLuaEvent(const std::shared_ptr<Action> &action); // Clear maps for reloading void clear(); private: - bool hasPosition(Position position) const { - if (auto it = actionPositionMap.find(position); + bool hasPosition(const Position &position) const { + if (const auto it = actionPositionMap.find(position); it != actionPositionMap.end()) { return true; } @@ -171,48 +171,48 @@ class Actions final : public Scripts { return actionPositionMap; } - void setPosition(Position position, std::shared_ptr<Action> action) { + void setPosition(const Position &position, const std::shared_ptr<Action> &action) { actionPositionMap.try_emplace(position, action); } bool hasItemId(uint16_t itemId) const { - if (auto it = useItemMap.find(itemId); + if (const auto it = useItemMap.find(itemId); it != useItemMap.end()) { return true; } return false; } - void setItemId(uint16_t itemId, const std::shared_ptr<Action> action) { + void setItemId(uint16_t itemId, const std::shared_ptr<Action> &action) { useItemMap.try_emplace(itemId, action); } bool hasUniqueId(uint16_t uniqueId) const { - if (auto it = uniqueItemMap.find(uniqueId); + if (const auto it = uniqueItemMap.find(uniqueId); it != uniqueItemMap.end()) { return true; } return false; } - void setUniqueId(uint16_t uniqueId, const std::shared_ptr<Action> action) { + void setUniqueId(uint16_t uniqueId, const std::shared_ptr<Action> &action) { uniqueItemMap.try_emplace(uniqueId, action); } bool hasActionId(uint16_t actionId) const { - if (auto it = actionItemMap.find(actionId); + if (const auto it = actionItemMap.find(actionId); it != actionItemMap.end()) { return true; } return false; } - void setActionId(uint16_t actionId, const std::shared_ptr<Action> action) { + void setActionId(uint16_t actionId, const std::shared_ptr<Action> &action) { actionItemMap.try_emplace(actionId, action); } - ReturnValue internalUseItem(std::shared_ptr<Player> player, const Position &pos, uint8_t index, std::shared_ptr<Item> item, bool isHotkey); - static void showUseHotkeyMessage(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint32_t count); + ReturnValue internalUseItem(const std::shared_ptr<Player> &player, const Position &pos, uint8_t index, const std::shared_ptr<Item> &item, bool isHotkey); + static void showUseHotkeyMessage(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint32_t count); using ActionUseMap = std::map<uint16_t, std::shared_ptr<Action>>; ActionUseMap useItemMap; @@ -220,7 +220,7 @@ class Actions final : public Scripts { ActionUseMap actionItemMap; std::map<Position, std::shared_ptr<Action>> actionPositionMap; - std::shared_ptr<Action> getAction(std::shared_ptr<Item> item); + std::shared_ptr<Action> getAction(const std::shared_ptr<Item> &item); }; constexpr auto g_actions = Actions::getInstance; diff --git a/src/lua/creature/creatureevent.cpp b/src/lua/creature/creatureevent.cpp index 3b7dfdceb4c..48ca3fa52b3 100644 --- a/src/lua/creature/creatureevent.cpp +++ b/src/lua/creature/creatureevent.cpp @@ -12,12 +12,12 @@ #include "creatures/players/player.hpp" void CreatureEvents::clear() { - for (auto &[name, event] : creatureEvents) { + for (const auto &[name, event] : creatureEvents) { event->clearEvent(); } } -bool CreatureEvents::registerLuaEvent(const std::shared_ptr<CreatureEvent> creatureEvent) { +bool CreatureEvents::registerLuaEvent(const std::shared_ptr<CreatureEvent> &creatureEvent) { if (creatureEvent->getEventType() == CREATURE_EVENT_NONE) { g_logger().error( "[{}] - Trying to register event without type for script: {}", @@ -27,7 +27,7 @@ bool CreatureEvents::registerLuaEvent(const std::shared_ptr<CreatureEvent> creat return false; } - const std::shared_ptr<CreatureEvent> oldEvent = getEventByName(creatureEvent->getName(), false); + const auto &oldEvent = getEventByName(creatureEvent->getName(), false); if (oldEvent) { // if there was an event with the same that is not loaded //(happens when realoading), it is reused @@ -44,7 +44,7 @@ bool CreatureEvents::registerLuaEvent(const std::shared_ptr<CreatureEvent> creat } std::shared_ptr<CreatureEvent> CreatureEvents::getEventByName(const std::string &name, bool forceLoaded /*= true*/) { - auto it = creatureEvents.find(name); + const auto it = creatureEvents.find(name); if (it != creatureEvents.end()) { if (!forceLoaded || it->second->isLoaded()) { return it->second; @@ -53,7 +53,7 @@ std::shared_ptr<CreatureEvent> CreatureEvents::getEventByName(const std::string return nullptr; } -bool CreatureEvents::playerLogin(std::shared_ptr<Player> player) const { +bool CreatureEvents::playerLogin(const std::shared_ptr<Player> &player) const { // fire global event if is registered for (const auto &it : creatureEvents) { if (it.second->getEventType() == CREATURE_EVENT_LOGIN) { @@ -65,7 +65,7 @@ bool CreatureEvents::playerLogin(std::shared_ptr<Player> player) const { return true; } -bool CreatureEvents::playerLogout(std::shared_ptr<Player> player) const { +bool CreatureEvents::playerLogout(const std::shared_ptr<Player> &player) const { // fire global event if is registered for (const auto &it : creatureEvents) { if (it.second->getEventType() == CREATURE_EVENT_LOGOUT) { @@ -78,7 +78,7 @@ bool CreatureEvents::playerLogout(std::shared_ptr<Player> player) const { } bool CreatureEvents::playerAdvance( - std::shared_ptr<Player> player, + const std::shared_ptr<Player> &player, skills_t skill, uint32_t oldLevel, uint32_t newLevel @@ -149,11 +149,11 @@ std::string CreatureEvent::getScriptTypeName() const { case CREATURE_EVENT_NONE: default: - return std::string(); + return {}; } } -void CreatureEvent::copyEvent(const std::shared_ptr<CreatureEvent> creatureEvent) { +void CreatureEvent::copyEvent(const std::shared_ptr<CreatureEvent> &creatureEvent) { setScriptId(creatureEvent->getScriptId()); setScriptInterface(creatureEvent->getScriptInterface()); setLoadedCallback(creatureEvent->isLoadedCallback()); @@ -167,16 +167,16 @@ void CreatureEvent::clearEvent() { loaded = false; } -bool CreatureEvent::executeOnLogin(std::shared_ptr<Player> player) const { +bool CreatureEvent::executeOnLogin(const std::shared_ptr<Player> &player) const { // onLogin(player) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeOnLogin - Player {} event {}]" "Call stack overflow. Too many lua script calls being nested.", player->getName(), getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -187,16 +187,16 @@ bool CreatureEvent::executeOnLogin(std::shared_ptr<Player> player) const { return getScriptInterface()->callFunction(1); } -bool CreatureEvent::executeOnLogout(std::shared_ptr<Player> player) const { +bool CreatureEvent::executeOnLogout(const std::shared_ptr<Player> &player) const { // onLogout(player) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeOnLogout - Player {} event {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -207,16 +207,16 @@ bool CreatureEvent::executeOnLogout(std::shared_ptr<Player> player) const { return getScriptInterface()->callFunction(1); } -bool CreatureEvent::executeOnThink(std::shared_ptr<Creature> creature, uint32_t interval) const { +bool CreatureEvent::executeOnThink(const std::shared_ptr<Creature> &creature, uint32_t interval) const { // onThink(creature, interval) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeOnThink - Creature {} event {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName(), getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -229,16 +229,16 @@ bool CreatureEvent::executeOnThink(std::shared_ptr<Creature> creature, uint32_t return getScriptInterface()->callFunction(2); } -bool CreatureEvent::executeOnPrepareDeath(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> killer, int realDamage) const { +bool CreatureEvent::executeOnPrepareDeath(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &killer, int realDamage) const { // onPrepareDeath(creature, killer) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeOnPrepareDeath - Creature {} killer {}" " event {}] Call stack overflow. Too many lua script calls being nested.", creature->getName(), killer->getName(), getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -260,16 +260,16 @@ bool CreatureEvent::executeOnPrepareDeath(std::shared_ptr<Creature> creature, st return getScriptInterface()->callFunction(3); } -bool CreatureEvent::executeOnDeath(std::shared_ptr<Creature> creature, std::shared_ptr<Item> corpse, std::shared_ptr<Creature> killer, std::shared_ptr<Creature> mostDamageKiller, bool lastHitUnjustified, bool mostDamageUnjustified) const { +bool CreatureEvent::executeOnDeath(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &corpse, const std::shared_ptr<Creature> &killer, const std::shared_ptr<Creature> &mostDamageKiller, bool lastHitUnjustified, bool mostDamageUnjustified) const { // onDeath(creature, corpse, lasthitkiller, mostdamagekiller, lasthitunjustified, mostdamageunjustified) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeOnDeath - Creature {} killer {} event {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName(), killer->getName(), getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -300,16 +300,16 @@ bool CreatureEvent::executeOnDeath(std::shared_ptr<Creature> creature, std::shar return getScriptInterface()->callFunction(6); } -bool CreatureEvent::executeAdvance(std::shared_ptr<Player> player, skills_t skill, uint32_t oldLevel, uint32_t newLevel) const { +bool CreatureEvent::executeAdvance(const std::shared_ptr<Player> &player, skills_t skill, uint32_t oldLevel, uint32_t newLevel) const { // onAdvance(player, skill, oldLevel, newLevel) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeAdvance - Player {} event {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -327,19 +327,19 @@ bool CreatureEvent::executeAdvance(std::shared_ptr<Player> player, skills_t skil /** * @deprecated Prefer using registered onDeath events instead for better performance. */ -void CreatureEvent::executeOnKill(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> target, bool lastHit) const { +void CreatureEvent::executeOnKill(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &target, bool lastHit) const { // onKill(creature, target, lastHit) g_logger().warn("[CreatureEvent::executeOnKill - Creature {} target {} event {}] " "Deprecated use of onKill event. Use registered onDeath events instead for better performance.", creature->getName(), target->getName(), getName()); - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeOnKill - Creature {} target {} event {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName(), target->getName(), getName()); return; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -353,9 +353,9 @@ void CreatureEvent::executeOnKill(std::shared_ptr<Creature> creature, std::share getScriptInterface()->callVoidFunction(3); } -void CreatureEvent::executeModalWindow(std::shared_ptr<Player> player, uint32_t modalWindowId, uint8_t buttonId, uint8_t choiceId) const { +void CreatureEvent::executeModalWindow(const std::shared_ptr<Player> &player, uint32_t modalWindowId, uint8_t buttonId, uint8_t choiceId) const { // onModalWindow(player, modalWindowId, buttonId, choiceId) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeModalWindow - " "Player {} modaw window id {} event {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -363,7 +363,7 @@ void CreatureEvent::executeModalWindow(std::shared_ptr<Player> player, uint32_t return; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -379,16 +379,16 @@ void CreatureEvent::executeModalWindow(std::shared_ptr<Player> player, uint32_t getScriptInterface()->callVoidFunction(4); } -bool CreatureEvent::executeTextEdit(std::shared_ptr<Player> player, std::shared_ptr<Item> item, const std::string &text) const { +bool CreatureEvent::executeTextEdit(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::string &text) const { // onTextEdit(player, item, text) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeTextEdit - Player {} event {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -403,9 +403,9 @@ bool CreatureEvent::executeTextEdit(std::shared_ptr<Player> player, std::shared_ return getScriptInterface()->callFunction(3); } -void CreatureEvent::executeHealthChange(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatDamage &damage) const { +void CreatureEvent::executeHealthChange(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatDamage &damage) const { // onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeHealthChange - " "Creature {} attacker {} event {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -413,7 +413,7 @@ void CreatureEvent::executeHealthChange(std::shared_ptr<Creature> creature, std: return; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -430,7 +430,7 @@ void CreatureEvent::executeHealthChange(std::shared_ptr<Creature> creature, std: LuaScriptInterface::pushCombatDamage(L, damage); - if (getScriptInterface()->protectedCall(L, 7, 4) != 0) { + if (LuaScriptInterface::protectedCall(L, 7, 4) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { damage.primary.value = std::abs(LuaScriptInterface::getNumber<int32_t>(L, -4)); @@ -445,12 +445,12 @@ void CreatureEvent::executeHealthChange(std::shared_ptr<Creature> creature, std: } } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void CreatureEvent::executeManaChange(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatDamage &damage) const { +void CreatureEvent::executeManaChange(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatDamage &damage) const { // onManaChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeManaChange - " "Creature {} attacker {} event {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -458,7 +458,7 @@ void CreatureEvent::executeManaChange(std::shared_ptr<Creature> creature, std::s return; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -475,7 +475,7 @@ void CreatureEvent::executeManaChange(std::shared_ptr<Creature> creature, std::s LuaScriptInterface::pushCombatDamage(L, damage); - if (getScriptInterface()->protectedCall(L, 7, 4) != 0) { + if (LuaScriptInterface::protectedCall(L, 7, 4) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { damage.primary.value = LuaScriptInterface::getNumber<int32_t>(L, -4); @@ -485,12 +485,12 @@ void CreatureEvent::executeManaChange(std::shared_ptr<Creature> creature, std::s lua_pop(L, 4); } - getScriptInterface()->resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void CreatureEvent::executeExtendedOpcode(std::shared_ptr<Player> player, uint8_t opcode, const std::string &buffer) const { +void CreatureEvent::executeExtendedOpcode(const std::shared_ptr<Player> &player, uint8_t opcode, const std::string &buffer) const { // onExtendedOpcode(player, opcode, buffer) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[CreatureEvent::executeExtendedOpcode - " "Player {} event {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -498,7 +498,7 @@ void CreatureEvent::executeExtendedOpcode(std::shared_ptr<Player> player, uint8_ return; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); diff --git a/src/lua/creature/creatureevent.hpp b/src/lua/creature/creatureevent.hpp index e34bd8eb75e..06d6a21fb77 100644 --- a/src/lua/creature/creatureevent.hpp +++ b/src/lua/creature/creatureevent.hpp @@ -40,21 +40,21 @@ class CreatureEvent final : public Script { } void clearEvent(); - void copyEvent(const std::shared_ptr<CreatureEvent> creatureEvent); + void copyEvent(const std::shared_ptr<CreatureEvent> &creatureEvent); // scripting - bool executeOnLogin(std::shared_ptr<Player> player) const; - bool executeOnLogout(std::shared_ptr<Player> player) const; - bool executeOnThink(std::shared_ptr<Creature> creature, uint32_t interval) const; - bool executeOnPrepareDeath(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> killer, int realDamage) const; - bool executeOnDeath(std::shared_ptr<Creature> creature, std::shared_ptr<Item> corpse, std::shared_ptr<Creature> killer, std::shared_ptr<Creature> mostDamageKiller, bool lastHitUnjustified, bool mostDamageUnjustified) const; - void executeOnKill(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> target, bool lastHit) const; - bool executeAdvance(std::shared_ptr<Player> player, skills_t, uint32_t, uint32_t) const; - void executeModalWindow(std::shared_ptr<Player> player, uint32_t modalWindowId, uint8_t buttonId, uint8_t choiceId) const; - bool executeTextEdit(std::shared_ptr<Player> player, std::shared_ptr<Item> item, const std::string &text) const; - void executeHealthChange(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatDamage &damage) const; - void executeManaChange(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatDamage &damage) const; - void executeExtendedOpcode(std::shared_ptr<Player> player, uint8_t opcode, const std::string &buffer) const; + bool executeOnLogin(const std::shared_ptr<Player> &player) const; + bool executeOnLogout(const std::shared_ptr<Player> &player) const; + bool executeOnThink(const std::shared_ptr<Creature> &creature, uint32_t interval) const; + bool executeOnPrepareDeath(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &killer, int realDamage) const; + bool executeOnDeath(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &corpse, const std::shared_ptr<Creature> &killer, const std::shared_ptr<Creature> &mostDamageKiller, bool lastHitUnjustified, bool mostDamageUnjustified) const; + void executeOnKill(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &target, bool lastHit) const; + bool executeAdvance(const std::shared_ptr<Player> &player, skills_t, uint32_t, uint32_t) const; + void executeModalWindow(const std::shared_ptr<Player> &player, uint32_t modalWindowId, uint8_t buttonId, uint8_t choiceId) const; + bool executeTextEdit(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, const std::string &text) const; + void executeHealthChange(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatDamage &damage) const; + void executeManaChange(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatDamage &damage) const; + void executeExtendedOpcode(const std::shared_ptr<Player> &player, uint8_t opcode, const std::string &buffer) const; // private: @@ -78,13 +78,13 @@ class CreatureEvents final : public Scripts { } // global events - bool playerLogin(std::shared_ptr<Player> player) const; - bool playerLogout(std::shared_ptr<Player> player) const; - bool playerAdvance(std::shared_ptr<Player> player, skills_t, uint32_t, uint32_t) const; + bool playerLogin(const std::shared_ptr<Player> &player) const; + bool playerLogout(const std::shared_ptr<Player> &player) const; + bool playerAdvance(const std::shared_ptr<Player> &player, skills_t, uint32_t, uint32_t) const; std::shared_ptr<CreatureEvent> getEventByName(const std::string &name, bool forceLoaded = true); - bool registerLuaEvent(const std::shared_ptr<CreatureEvent> event); + bool registerLuaEvent(const std::shared_ptr<CreatureEvent> &event); void removeInvalidEvents(); void clear(); diff --git a/src/lua/creature/events.cpp b/src/lua/creature/events.cpp index 1f101204164..2057a26604c 100644 --- a/src/lua/creature/events.cpp +++ b/src/lua/creature/events.cpp @@ -29,13 +29,13 @@ bool Events::loadFromXml() { info = {}; phmap::flat_hash_set<std::string> classes; - for (auto eventNode : doc.child("events").children()) { + for (const auto &eventNode : doc.child("events").children()) { if (!eventNode.attribute("enabled").as_bool()) { continue; } const std::string &className = eventNode.attribute("class").as_string(); - auto res = classes.emplace(className); + const auto res = classes.emplace(className); if (res.second) { const std::string &lowercase = asLowerCaseString(className); const std::string &scriptName = lowercase + ".lua"; @@ -148,13 +148,13 @@ bool Events::loadFromXml() { } // Monster -void Events::eventMonsterOnSpawn(std::shared_ptr<Monster> monster, const Position &position) { +void Events::eventMonsterOnSpawn(const std::shared_ptr<Monster> &monster, const Position &position) { // Monster:onSpawn(position) or Monster.onSpawn(self, position) if (info.monsterOnSpawn == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("{} - " "Position {}" ". Call stack overflow. Too many lua script calls being nested.", @@ -162,7 +162,7 @@ void Events::eventMonsterOnSpawn(std::shared_ptr<Monster> monster, const Positio return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.monsterOnSpawn, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -172,23 +172,23 @@ void Events::eventMonsterOnSpawn(std::shared_ptr<Monster> monster, const Positio LuaScriptInterface::setMetatable(L, -1, "Monster"); LuaScriptInterface::pushPosition(L, position); - if (scriptInterface.protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } // Npc -void Events::eventNpcOnSpawn(std::shared_ptr<Npc> npc, const Position &position) { +void Events::eventNpcOnSpawn(const std::shared_ptr<Npc> &npc, const Position &position) { // Npc:onSpawn(position) or Npc.onSpawn(self, position) if (info.npcOnSpawn == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("{} - " "Position {}" ". Call stack overflow. Too many lua script calls being nested.", @@ -196,7 +196,7 @@ void Events::eventNpcOnSpawn(std::shared_ptr<Npc> npc, const Position &position) return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.npcOnSpawn, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -206,30 +206,30 @@ void Events::eventNpcOnSpawn(std::shared_ptr<Npc> npc, const Position &position) LuaScriptInterface::setMetatable(L, -1, "Npc"); LuaScriptInterface::pushPosition(L, position); - if (scriptInterface.protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } // Creature -bool Events::eventCreatureOnChangeOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit) { +bool Events::eventCreatureOnChangeOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit) { // Creature:onChangeOutfit(outfit) or Creature.onChangeOutfit(self, outfit) if (info.creatureOnChangeOutfit == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventCreatureOnChangeOutfit - Creature {}] " "Call stack overflow. Too many lua script calls being nested.", creature->getName()); return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.creatureOnChangeOutfit, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -243,13 +243,13 @@ bool Events::eventCreatureOnChangeOutfit(std::shared_ptr<Creature> creature, con return scriptInterface.callFunction(2); } -ReturnValue Events::eventCreatureOnAreaCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Tile> tile, bool aggressive) { +ReturnValue Events::eventCreatureOnAreaCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &tile, bool aggressive) { // Creature:onAreaCombat(tile, aggressive) or Creature.onAreaCombat(self, tile, aggressive) if (info.creatureOnAreaCombat == -1) { return RETURNVALUE_NOERROR; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventCreatureOnAreaCombat - " "Creature {} on tile position {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -257,7 +257,7 @@ ReturnValue Events::eventCreatureOnAreaCombat(std::shared_ptr<Creature> creature return RETURNVALUE_NOTPOSSIBLE; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.creatureOnAreaCombat, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -276,7 +276,7 @@ ReturnValue Events::eventCreatureOnAreaCombat(std::shared_ptr<Creature> creature LuaScriptInterface::pushBoolean(L, aggressive); ReturnValue returnValue; - if (scriptInterface.protectedCall(L, 3, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 3, 1) != 0) { returnValue = RETURNVALUE_NOTPOSSIBLE; LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { @@ -284,17 +284,17 @@ ReturnValue Events::eventCreatureOnAreaCombat(std::shared_ptr<Creature> creature lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return returnValue; } -ReturnValue Events::eventCreatureOnTargetCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> target) { +ReturnValue Events::eventCreatureOnTargetCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &target) { // Creature:onTargetCombat(target) or Creature.onTargetCombat(self, target) if (info.creatureOnTargetCombat == -1) { return RETURNVALUE_NOERROR; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventCreatureOnTargetCombat - " "Creature {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -302,7 +302,7 @@ ReturnValue Events::eventCreatureOnTargetCombat(std::shared_ptr<Creature> creatu return RETURNVALUE_NOTPOSSIBLE; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.creatureOnTargetCombat, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -319,7 +319,7 @@ ReturnValue Events::eventCreatureOnTargetCombat(std::shared_ptr<Creature> creatu LuaScriptInterface::setCreatureMetatable(L, -1, target); ReturnValue returnValue; - if (scriptInterface.protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { returnValue = RETURNVALUE_NOTPOSSIBLE; LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { @@ -327,17 +327,17 @@ ReturnValue Events::eventCreatureOnTargetCombat(std::shared_ptr<Creature> creatu lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); return returnValue; } -void Events::eventCreatureOnHear(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> speaker, const std::string &words, SpeakClasses type) { +void Events::eventCreatureOnHear(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &speaker, const std::string &words, SpeakClasses type) { // Creature:onHear(speaker, words, type) if (info.creatureOnHear == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventCreatureOnHear - " "Creature {} speaker {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -345,7 +345,7 @@ void Events::eventCreatureOnHear(std::shared_ptr<Creature> creature, std::shared return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.creatureOnHear, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -363,12 +363,12 @@ void Events::eventCreatureOnHear(std::shared_ptr<Creature> creature, std::shared scriptInterface.callVoidFunction(4); } -void Events::eventCreatureOnDrainHealth(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary) { +void Events::eventCreatureOnDrainHealth(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary) { if (info.creatureOnDrainHealth == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventCreatureOnDrainHealth - " "Creature {} attacker {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -376,7 +376,7 @@ void Events::eventCreatureOnDrainHealth(std::shared_ptr<Creature> creature, std: return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.creatureOnDrainHealth, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -403,7 +403,7 @@ void Events::eventCreatureOnDrainHealth(std::shared_ptr<Creature> creature, std: lua_pushnumber(L, colorPrimary); lua_pushnumber(L, colorSecondary); - if (scriptInterface.protectedCall(L, 8, 6) != 0) { + if (LuaScriptInterface::protectedCall(L, 8, 6) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { typePrimary = LuaScriptInterface::getNumber<CombatType_t>(L, -6); @@ -415,17 +415,17 @@ void Events::eventCreatureOnDrainHealth(std::shared_ptr<Creature> creature, std: lua_pop(L, 6); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } // Party -bool Events::eventPartyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Player> player) { +bool Events::eventPartyOnJoin(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player) { // Party:onJoin(player) or Party.onJoin(self, player) if (info.partyOnJoin == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPartyOnJoin - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -433,7 +433,7 @@ bool Events::eventPartyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Play return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.partyOnJoin, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -448,13 +448,13 @@ bool Events::eventPartyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Play return scriptInterface.callFunction(2); } -bool Events::eventPartyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<Player> player) { +bool Events::eventPartyOnLeave(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player) { // Party:onLeave(player) or Party.onLeave(self, player) if (info.partyOnLeave == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPartyOnLeave - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -462,7 +462,7 @@ bool Events::eventPartyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<Pla return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.partyOnLeave, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -477,20 +477,20 @@ bool Events::eventPartyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<Pla return scriptInterface.callFunction(2); } -bool Events::eventPartyOnDisband(std::shared_ptr<Party> party) { +bool Events::eventPartyOnDisband(const std::shared_ptr<Party> &party) { // Party:onDisband() or Party.onDisband(self) if (info.partyOnDisband == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPartyOnDisband - Party leader {}] Call stack " "overflow. Too many lua script calls being nested.", party->getLeader() ? party->getLeader()->getName() : "unknown"); return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.partyOnDisband, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -502,18 +502,18 @@ bool Events::eventPartyOnDisband(std::shared_ptr<Party> party) { return scriptInterface.callFunction(1); } -void Events::eventPartyOnShareExperience(std::shared_ptr<Party> party, uint64_t &exp) { +void Events::eventPartyOnShareExperience(const std::shared_ptr<Party> &party, uint64_t &exp) { // Party:onShareExperience(exp) or Party.onShareExperience(self, exp) if (info.partyOnShareExperience == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("Party leader {}. Call stack overflow. Too many lua script calls being nested.", party->getLeader() ? party->getLeader()->getName() : "unknown"); return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.partyOnShareExperience, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -524,24 +524,24 @@ void Events::eventPartyOnShareExperience(std::shared_ptr<Party> party, uint64_t lua_pushnumber(L, exp); - if (scriptInterface.protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { exp = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } // Player -bool Events::eventPlayerOnBrowseField(std::shared_ptr<Player> player, const Position &position) { +bool Events::eventPlayerOnBrowseField(const std::shared_ptr<Player> &player, const Position &position) { // Player:onBrowseField(position) or Player.onBrowseField(self, position) if (info.playerOnBrowseField == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnBrowseField - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -549,7 +549,7 @@ bool Events::eventPlayerOnBrowseField(std::shared_ptr<Player> player, const Posi return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnBrowseField, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -563,13 +563,13 @@ bool Events::eventPlayerOnBrowseField(std::shared_ptr<Player> player, const Posi return scriptInterface.callFunction(2); } -void Events::eventPlayerOnLook(std::shared_ptr<Player> player, const Position &position, std::shared_ptr<Thing> thing, uint8_t stackpos, int32_t lookDistance) { +void Events::eventPlayerOnLook(const std::shared_ptr<Player> &player, const Position &position, const std::shared_ptr<Thing> &thing, uint8_t stackpos, int32_t lookDistance) { // Player:onLook(thing, position, distance) or Player.onLook(self, thing, position, distance) if (info.playerOnLook == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnLook - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -577,7 +577,7 @@ void Events::eventPlayerOnLook(std::shared_ptr<Player> player, const Position &p return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnLook, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -586,10 +586,10 @@ void Events::eventPlayerOnLook(std::shared_ptr<Player> player, const Position &p LuaScriptInterface::pushUserdata<Player>(L, player); LuaScriptInterface::setMetatable(L, -1, "Player"); - if (std::shared_ptr<Creature> creature = thing->getCreature()) { + if (const std::shared_ptr<Creature> &creature = thing->getCreature()) { LuaScriptInterface::pushUserdata<Creature>(L, creature); LuaScriptInterface::setCreatureMetatable(L, -1, creature); - } else if (std::shared_ptr<Item> item = thing->getItem()) { + } else if (const auto &item = thing->getItem()) { LuaScriptInterface::pushUserdata<Item>(L, item); LuaScriptInterface::setItemMetatable(L, -1, item); } else { @@ -602,13 +602,13 @@ void Events::eventPlayerOnLook(std::shared_ptr<Player> player, const Position &p scriptInterface.callVoidFunction(4); } -void Events::eventPlayerOnLookInBattleList(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, int32_t lookDistance) { +void Events::eventPlayerOnLookInBattleList(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, int32_t lookDistance) { // Player:onLookInBattleList(creature, position, distance) or Player.onLookInBattleList(self, creature, position, distance) if (info.playerOnLookInBattleList == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnLookInBattleList - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -616,7 +616,7 @@ void Events::eventPlayerOnLookInBattleList(std::shared_ptr<Player> player, std:: return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnLookInBattleList, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -633,13 +633,13 @@ void Events::eventPlayerOnLookInBattleList(std::shared_ptr<Player> player, std:: scriptInterface.callVoidFunction(3); } -void Events::eventPlayerOnLookInTrade(std::shared_ptr<Player> player, std::shared_ptr<Player> partner, std::shared_ptr<Item> item, int32_t lookDistance) { +void Events::eventPlayerOnLookInTrade(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &partner, const std::shared_ptr<Item> &item, int32_t lookDistance) { // Player:onLookInTrade(partner, item, distance) or Player.onLookInTrade(self, partner, item, distance) if (info.playerOnLookInTrade == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnLookInTrade - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -647,7 +647,7 @@ void Events::eventPlayerOnLookInTrade(std::shared_ptr<Player> player, std::share return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnLookInTrade, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -667,13 +667,13 @@ void Events::eventPlayerOnLookInTrade(std::shared_ptr<Player> player, std::share scriptInterface.callVoidFunction(4); } -bool Events::eventPlayerOnLookInShop(std::shared_ptr<Player> player, const ItemType* itemType, uint8_t count) { +bool Events::eventPlayerOnLookInShop(const std::shared_ptr<Player> &player, const ItemType* itemType, uint8_t count) { // Player:onLookInShop(itemType, count) or Player.onLookInShop(self, itemType, count) if (info.playerOnLookInShop == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnLookInShop - " "Player {} itemType {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -681,7 +681,7 @@ bool Events::eventPlayerOnLookInShop(std::shared_ptr<Player> player, const ItemT return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnLookInShop, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -698,13 +698,13 @@ bool Events::eventPlayerOnLookInShop(std::shared_ptr<Player> player, const ItemT return scriptInterface.callFunction(3); } -bool Events::eventPlayerOnRemoveCount(std::shared_ptr<Player> player, std::shared_ptr<Item> item) { +bool Events::eventPlayerOnRemoveCount(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item) { // Player:onMove() if (info.playerOnRemoveCount == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnMove - " "Player {} item {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -712,7 +712,7 @@ bool Events::eventPlayerOnRemoveCount(std::shared_ptr<Player> player, std::share return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnRemoveCount, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -727,13 +727,13 @@ bool Events::eventPlayerOnRemoveCount(std::shared_ptr<Player> player, std::share return scriptInterface.callFunction(2); } -bool Events::eventPlayerOnMoveItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPosition, const Position &toPosition, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder) { +bool Events::eventPlayerOnMoveItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPosition, const Position &toPosition, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder) { // Player:onMoveItem(item, count, fromPosition, toPosition) or Player.onMoveItem(self, item, count, fromPosition, toPosition, fromCylinder, toCylinder) if (info.playerOnMoveItem == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnMoveItem - " "Player {} item {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -741,7 +741,7 @@ bool Events::eventPlayerOnMoveItem(std::shared_ptr<Player> player, std::shared_p return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnMoveItem, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -763,13 +763,13 @@ bool Events::eventPlayerOnMoveItem(std::shared_ptr<Player> player, std::shared_p return scriptInterface.callFunction(7); } -void Events::eventPlayerOnItemMoved(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPosition, const Position &toPosition, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder) { +void Events::eventPlayerOnItemMoved(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPosition, const Position &toPosition, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder) { // Player:onItemMoved(item, count, fromPosition, toPosition) or Player.onItemMoved(self, item, count, fromPosition, toPosition, fromCylinder, toCylinder) if (info.playerOnItemMoved == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnItemMoved - " "Player {} item {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -777,7 +777,7 @@ void Events::eventPlayerOnItemMoved(std::shared_ptr<Player> player, std::shared_ return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnItemMoved, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -799,13 +799,13 @@ void Events::eventPlayerOnItemMoved(std::shared_ptr<Player> player, std::shared_ scriptInterface.callVoidFunction(7); } -void Events::eventPlayerOnChangeZone(std::shared_ptr<Player> player, ZoneType_t zone) { +void Events::eventPlayerOnChangeZone(const std::shared_ptr<Player> &player, ZoneType_t zone) { // Player:onChangeZone(zone) if (info.playerOnChangeZone == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnChangeZone - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -813,7 +813,7 @@ void Events::eventPlayerOnChangeZone(std::shared_ptr<Player> player, ZoneType_t return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnChangeZone, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -826,13 +826,13 @@ void Events::eventPlayerOnChangeZone(std::shared_ptr<Player> player, ZoneType_t scriptInterface.callVoidFunction(2); } -bool Events::eventPlayerOnMoveCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, const Position &fromPosition, const Position &toPosition) { +bool Events::eventPlayerOnMoveCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, const Position &fromPosition, const Position &toPosition) { // Player:onMoveCreature(creature, fromPosition, toPosition) or Player.onMoveCreature(self, creature, fromPosition, toPosition) if (info.playerOnMoveCreature == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnMoveCreature - " "Player {} creature {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -840,7 +840,7 @@ bool Events::eventPlayerOnMoveCreature(std::shared_ptr<Player> player, std::shar return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnMoveCreature, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -858,13 +858,13 @@ bool Events::eventPlayerOnMoveCreature(std::shared_ptr<Player> player, std::shar return scriptInterface.callFunction(4); } -void Events::eventPlayerOnReportRuleViolation(std::shared_ptr<Player> player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation) { +void Events::eventPlayerOnReportRuleViolation(const std::shared_ptr<Player> &player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation) { // Player:onReportRuleViolation(targetName, reportType, reportReason, comment, translation) if (info.playerOnReportRuleViolation == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnReportRuleViolation - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -872,7 +872,7 @@ void Events::eventPlayerOnReportRuleViolation(std::shared_ptr<Player> player, co return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnReportRuleViolation, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -892,13 +892,13 @@ void Events::eventPlayerOnReportRuleViolation(std::shared_ptr<Player> player, co scriptInterface.callVoidFunction(6); } -bool Events::eventPlayerOnReportBug(std::shared_ptr<Player> player, const std::string &message, const Position &position, uint8_t category) { +bool Events::eventPlayerOnReportBug(const std::shared_ptr<Player> &player, const std::string &message, const Position &position, uint8_t category) { // Player:onReportBug(message, position, category) if (info.playerOnReportBug == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnReportBug - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -906,7 +906,7 @@ bool Events::eventPlayerOnReportBug(std::shared_ptr<Player> player, const std::s return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnReportBug, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -922,13 +922,13 @@ bool Events::eventPlayerOnReportBug(std::shared_ptr<Player> player, const std::s return scriptInterface.callFunction(4); } -bool Events::eventPlayerOnTurn(std::shared_ptr<Player> player, Direction direction) { +bool Events::eventPlayerOnTurn(const std::shared_ptr<Player> &player, Direction direction) { // Player:onTurn(direction) or Player.onTurn(self, direction) if (info.playerOnTurn == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnTurn - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -936,7 +936,7 @@ bool Events::eventPlayerOnTurn(std::shared_ptr<Player> player, Direction directi return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnTurn, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -950,13 +950,13 @@ bool Events::eventPlayerOnTurn(std::shared_ptr<Player> player, Direction directi return scriptInterface.callFunction(2); } -bool Events::eventPlayerOnTradeRequest(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item) { +bool Events::eventPlayerOnTradeRequest(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item) { // Player:onTradeRequest(target, item) if (info.playerOnTradeRequest == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnTradeRequest - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -964,7 +964,7 @@ bool Events::eventPlayerOnTradeRequest(std::shared_ptr<Player> player, std::shar return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnTradeRequest, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -982,13 +982,13 @@ bool Events::eventPlayerOnTradeRequest(std::shared_ptr<Player> player, std::shar return scriptInterface.callFunction(3); } -bool Events::eventPlayerOnTradeAccept(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item, std::shared_ptr<Item> targetItem) { +bool Events::eventPlayerOnTradeAccept(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &targetItem) { // Player:onTradeAccept(target, item, targetItem) if (info.playerOnTradeAccept == -1) { return true; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnTradeAccept - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -996,7 +996,7 @@ bool Events::eventPlayerOnTradeAccept(std::shared_ptr<Player> player, std::share return false; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnTradeAccept, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1017,14 +1017,14 @@ bool Events::eventPlayerOnTradeAccept(std::shared_ptr<Player> player, std::share return scriptInterface.callFunction(4); } -void Events::eventPlayerOnGainExperience(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint64_t &exp, uint64_t rawExp) { +void Events::eventPlayerOnGainExperience(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint64_t &exp, uint64_t rawExp) { // Player:onGainExperience(target, exp, rawExp) // rawExp gives the original exp which is not multiplied if (info.playerOnGainExperience == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnGainExperience - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1032,7 +1032,7 @@ void Events::eventPlayerOnGainExperience(std::shared_ptr<Player> player, std::sh return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnGainExperience, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1051,23 +1051,23 @@ void Events::eventPlayerOnGainExperience(std::shared_ptr<Player> player, std::sh lua_pushnumber(L, exp); lua_pushnumber(L, rawExp); - if (scriptInterface.protectedCall(L, 4, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 4, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { exp = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void Events::eventPlayerOnLoseExperience(std::shared_ptr<Player> player, uint64_t &exp) { +void Events::eventPlayerOnLoseExperience(const std::shared_ptr<Player> &player, uint64_t &exp) { // Player:onLoseExperience(exp) if (info.playerOnLoseExperience == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnLoseExperience - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1075,7 +1075,7 @@ void Events::eventPlayerOnLoseExperience(std::shared_ptr<Player> player, uint64_ return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnLoseExperience, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1086,23 +1086,23 @@ void Events::eventPlayerOnLoseExperience(std::shared_ptr<Player> player, uint64_ lua_pushnumber(L, exp); - if (scriptInterface.protectedCall(L, 2, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 2, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { exp = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void Events::eventPlayerOnGainSkillTries(std::shared_ptr<Player> player, skills_t skill, uint64_t &tries) { +void Events::eventPlayerOnGainSkillTries(const std::shared_ptr<Player> &player, skills_t skill, uint64_t &tries) { // Player:onGainSkillTries(skill, tries) if (info.playerOnGainSkillTries == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnGainSkillTries - " "Player {} skill {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1110,7 +1110,7 @@ void Events::eventPlayerOnGainSkillTries(std::shared_ptr<Player> player, skills_ return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnGainSkillTries, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1122,23 +1122,23 @@ void Events::eventPlayerOnGainSkillTries(std::shared_ptr<Player> player, skills_ lua_pushnumber(L, skill); lua_pushnumber(L, tries); - if (scriptInterface.protectedCall(L, 3, 1) != 0) { + if (LuaScriptInterface::protectedCall(L, 3, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { tries = LuaScriptInterface::getNumber<uint64_t>(L, -1); lua_pop(L, 1); } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void Events::eventPlayerOnCombat(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, CombatDamage &damage) { +void Events::eventPlayerOnCombat(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, CombatDamage &damage) { // Player:onCombat(target, item, primaryDamage, primaryType, secondaryDamage, secondaryType) if (info.playerOnCombat == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnCombat - " "Player {} target {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1146,7 +1146,7 @@ void Events::eventPlayerOnCombat(std::shared_ptr<Player> player, std::shared_ptr return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnCombat, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1171,7 +1171,7 @@ void Events::eventPlayerOnCombat(std::shared_ptr<Player> player, std::shared_ptr LuaScriptInterface::pushCombatDamage(L, damage); - if (scriptInterface.protectedCall(L, 8, 4) != 0) { + if (LuaScriptInterface::protectedCall(L, 8, 4) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(L)); } else { damage.primary.value = std::abs(LuaScriptInterface::getNumber<int32_t>(L, -4)); @@ -1186,16 +1186,16 @@ void Events::eventPlayerOnCombat(std::shared_ptr<Player> player, std::shared_ptr } } - scriptInterface.resetScriptEnv(); + LuaScriptInterface::resetScriptEnv(); } -void Events::eventPlayerOnRequestQuestLog(std::shared_ptr<Player> player) { +void Events::eventPlayerOnRequestQuestLog(const std::shared_ptr<Player> &player) { // Player:onRequestQuestLog() if (info.playerOnRequestQuestLog == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnRequestQuestLog - " "Player {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1203,7 +1203,7 @@ void Events::eventPlayerOnRequestQuestLog(std::shared_ptr<Player> player) { return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnRequestQuestLog, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1215,13 +1215,13 @@ void Events::eventPlayerOnRequestQuestLog(std::shared_ptr<Player> player) { scriptInterface.callVoidFunction(1); } -void Events::eventPlayerOnRequestQuestLine(std::shared_ptr<Player> player, uint16_t questId) { +void Events::eventPlayerOnRequestQuestLine(const std::shared_ptr<Player> &player, uint16_t questId) { // Player::onRequestQuestLine() if (info.playerOnRequestQuestLine == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventPlayerOnRequestQuestLine - " "Player {} questId {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1229,7 +1229,7 @@ void Events::eventPlayerOnRequestQuestLine(std::shared_ptr<Player> player, uint1 return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnRequestQuestLine, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1243,18 +1243,18 @@ void Events::eventPlayerOnRequestQuestLine(std::shared_ptr<Player> player, uint1 scriptInterface.callVoidFunction(2); } -void Events::eventPlayerOnInventoryUpdate(std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool equip) { +void Events::eventPlayerOnInventoryUpdate(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool equip) { // Player:onInventoryUpdate(item, slot, equip) if (info.playerOnInventoryUpdate == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[{}] Call stack overflow", __FUNCTION__); return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnInventoryUpdate, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1272,13 +1272,13 @@ void Events::eventPlayerOnInventoryUpdate(std::shared_ptr<Player> player, std::s scriptInterface.callVoidFunction(4); } -void Events::eventOnStorageUpdate(std::shared_ptr<Player> player, const uint32_t key, const int32_t value, int32_t oldValue, uint64_t currentTime) { +void Events::eventOnStorageUpdate(const std::shared_ptr<Player> &player, const uint32_t key, const int32_t value, int32_t oldValue, uint64_t currentTime) { // Player::onStorageUpdate(key, value, oldValue, currentTime) if (info.playerOnStorageUpdate == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventOnStorageUpdate - " "Player {} key {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1286,7 +1286,7 @@ void Events::eventOnStorageUpdate(std::shared_ptr<Player> player, const uint32_t return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.playerOnStorageUpdate, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); @@ -1304,13 +1304,13 @@ void Events::eventOnStorageUpdate(std::shared_ptr<Player> player, const uint32_t } // Monster -void Events::eventMonsterOnDropLoot(std::shared_ptr<Monster> monster, std::shared_ptr<Container> corpse) { +void Events::eventMonsterOnDropLoot(const std::shared_ptr<Monster> &monster, const std::shared_ptr<Container> &corpse) { // Monster:onDropLoot(corpse) if (info.monsterOnDropLoot == -1) { return; } - if (!scriptInterface.reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[Events::eventMonsterOnDropLoot - " "Monster corpse {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -1318,7 +1318,7 @@ void Events::eventMonsterOnDropLoot(std::shared_ptr<Monster> monster, std::share return; } - ScriptEnvironment* env = scriptInterface.getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(info.monsterOnDropLoot, &scriptInterface); lua_State* L = scriptInterface.getLuaState(); diff --git a/src/lua/creature/events.hpp b/src/lua/creature/events.hpp index 1ec6d4ba81c..d76503fe425 100644 --- a/src/lua/creature/events.hpp +++ b/src/lua/creature/events.hpp @@ -81,49 +81,49 @@ class Events { } // Creature - bool eventCreatureOnChangeOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit); - ReturnValue eventCreatureOnAreaCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Tile> tile, bool aggressive); - ReturnValue eventCreatureOnTargetCombat(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> target); - void eventCreatureOnHear(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> speaker, const std::string &words, SpeakClasses type); - void eventCreatureOnDrainHealth(std::shared_ptr<Creature> creature, std::shared_ptr<Creature> attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary); + bool eventCreatureOnChangeOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit); + ReturnValue eventCreatureOnAreaCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &tile, bool aggressive); + ReturnValue eventCreatureOnTargetCombat(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &target); + void eventCreatureOnHear(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &speaker, const std::string &words, SpeakClasses type); + void eventCreatureOnDrainHealth(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Creature> &attacker, CombatType_t &typePrimary, int32_t &damagePrimary, CombatType_t &typeSecondary, int32_t &damageSecondary, TextColor_t &colorPrimary, TextColor_t &colorSecondary); // Party - bool eventPartyOnJoin(std::shared_ptr<Party> party, std::shared_ptr<Player> player); - bool eventPartyOnLeave(std::shared_ptr<Party> party, std::shared_ptr<Player> player); - bool eventPartyOnDisband(std::shared_ptr<Party> party); - void eventPartyOnShareExperience(std::shared_ptr<Party> party, uint64_t &exp); + bool eventPartyOnJoin(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player); + bool eventPartyOnLeave(const std::shared_ptr<Party> &party, const std::shared_ptr<Player> &player); + bool eventPartyOnDisband(const std::shared_ptr<Party> &party); + void eventPartyOnShareExperience(const std::shared_ptr<Party> &party, uint64_t &exp); // Player - bool eventPlayerOnBrowseField(std::shared_ptr<Player> player, const Position &position); - void eventPlayerOnLook(std::shared_ptr<Player> player, const Position &position, std::shared_ptr<Thing> thing, uint8_t stackpos, int32_t lookDistance); - void eventPlayerOnLookInBattleList(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, int32_t lookDistance); - void eventPlayerOnLookInTrade(std::shared_ptr<Player> player, std::shared_ptr<Player> partner, std::shared_ptr<Item> item, int32_t lookDistance); - bool eventPlayerOnLookInShop(std::shared_ptr<Player> player, const ItemType* itemType, uint8_t count); - bool eventPlayerOnMoveItem(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPosition, const Position &toPosition, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder); - void eventPlayerOnItemMoved(std::shared_ptr<Player> player, std::shared_ptr<Item> item, uint16_t count, const Position &fromPosition, const Position &toPosition, std::shared_ptr<Cylinder> fromCylinder, std::shared_ptr<Cylinder> toCylinder); - void eventPlayerOnChangeZone(std::shared_ptr<Player> player, ZoneType_t zone); - bool eventPlayerOnMoveCreature(std::shared_ptr<Player> player, std::shared_ptr<Creature> creature, const Position &fromPosition, const Position &toPosition); - void eventPlayerOnReportRuleViolation(std::shared_ptr<Player> player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation); - bool eventPlayerOnReportBug(std::shared_ptr<Player> player, const std::string &message, const Position &position, uint8_t category); - bool eventPlayerOnTurn(std::shared_ptr<Player> player, Direction direction); - bool eventPlayerOnTradeRequest(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item); - bool eventPlayerOnTradeAccept(std::shared_ptr<Player> player, std::shared_ptr<Player> target, std::shared_ptr<Item> item, std::shared_ptr<Item> targetItem); - void eventPlayerOnGainExperience(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, uint64_t &exp, uint64_t rawExp); - void eventPlayerOnLoseExperience(std::shared_ptr<Player> player, uint64_t &exp); - void eventPlayerOnGainSkillTries(std::shared_ptr<Player> player, skills_t skill, uint64_t &tries); - bool eventPlayerOnRemoveCount(std::shared_ptr<Player> player, std::shared_ptr<Item> item); - void eventPlayerOnRequestQuestLog(std::shared_ptr<Player> player); - void eventPlayerOnRequestQuestLine(std::shared_ptr<Player> player, uint16_t questId); - void eventOnStorageUpdate(std::shared_ptr<Player> player, const uint32_t key, const int32_t value, int32_t oldValue, uint64_t currentTime); - void eventPlayerOnCombat(std::shared_ptr<Player> player, std::shared_ptr<Creature> target, std::shared_ptr<Item> item, CombatDamage &damage); - void eventPlayerOnInventoryUpdate(std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool equip); + bool eventPlayerOnBrowseField(const std::shared_ptr<Player> &player, const Position &position); + void eventPlayerOnLook(const std::shared_ptr<Player> &player, const Position &position, const std::shared_ptr<Thing> &thing, uint8_t stackpos, int32_t lookDistance); + void eventPlayerOnLookInBattleList(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, int32_t lookDistance); + void eventPlayerOnLookInTrade(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &partner, const std::shared_ptr<Item> &item, int32_t lookDistance); + bool eventPlayerOnLookInShop(const std::shared_ptr<Player> &player, const ItemType* itemType, uint8_t count); + bool eventPlayerOnMoveItem(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPosition, const Position &toPosition, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder); + void eventPlayerOnItemMoved(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, uint16_t count, const Position &fromPosition, const Position &toPosition, const std::shared_ptr<Cylinder> &fromCylinder, const std::shared_ptr<Cylinder> &toCylinder); + void eventPlayerOnChangeZone(const std::shared_ptr<Player> &player, ZoneType_t zone); + bool eventPlayerOnMoveCreature(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &creature, const Position &fromPosition, const Position &toPosition); + void eventPlayerOnReportRuleViolation(const std::shared_ptr<Player> &player, const std::string &targetName, uint8_t reportType, uint8_t reportReason, const std::string &comment, const std::string &translation); + bool eventPlayerOnReportBug(const std::shared_ptr<Player> &player, const std::string &message, const Position &position, uint8_t category); + bool eventPlayerOnTurn(const std::shared_ptr<Player> &player, Direction direction); + bool eventPlayerOnTradeRequest(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item); + bool eventPlayerOnTradeAccept(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target, const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &targetItem); + void eventPlayerOnGainExperience(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, uint64_t &exp, uint64_t rawExp); + void eventPlayerOnLoseExperience(const std::shared_ptr<Player> &player, uint64_t &exp); + void eventPlayerOnGainSkillTries(const std::shared_ptr<Player> &player, skills_t skill, uint64_t &tries); + bool eventPlayerOnRemoveCount(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item); + void eventPlayerOnRequestQuestLog(const std::shared_ptr<Player> &player); + void eventPlayerOnRequestQuestLine(const std::shared_ptr<Player> &player, uint16_t questId); + void eventOnStorageUpdate(const std::shared_ptr<Player> &player, uint32_t key, int32_t value, int32_t oldValue, uint64_t currentTime); + void eventPlayerOnCombat(const std::shared_ptr<Player> &player, const std::shared_ptr<Creature> &target, const std::shared_ptr<Item> &item, CombatDamage &damage); + void eventPlayerOnInventoryUpdate(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool equip); // Monster - void eventMonsterOnDropLoot(std::shared_ptr<Monster> monster, std::shared_ptr<Container> corpse); - void eventMonsterOnSpawn(std::shared_ptr<Monster> monster, const Position &position); + void eventMonsterOnDropLoot(const std::shared_ptr<Monster> &monster, const std::shared_ptr<Container> &corpse); + void eventMonsterOnSpawn(const std::shared_ptr<Monster> &monster, const Position &position); // Monster - void eventNpcOnSpawn(std::shared_ptr<Npc> npc, const Position &position); + void eventNpcOnSpawn(const std::shared_ptr<Npc> &npc, const Position &position); private: LuaScriptInterface scriptInterface; diff --git a/src/lua/creature/movement.cpp b/src/lua/creature/movement.cpp index 64e290d8990..9a08affe324 100644 --- a/src/lua/creature/movement.cpp +++ b/src/lua/creature/movement.cpp @@ -13,39 +13,14 @@ #include "lua/callbacks/events_callbacks.hpp" #include "lua/creature/movement.hpp" -void MoveEvents::clear(bool isFromXML /*= false*/) { - if (isFromXML) { - int numRemoved = 0; - for (auto &pair : itemIdMap) { - MoveEventList &moveEventList = pair.second; - - for (int moveEventType = 0; moveEventType < MOVE_EVENT_LAST; ++moveEventType) { - auto &eventList = moveEventList.moveEvent[moveEventType]; - - eventList.remove_if([&](const std::shared_ptr<MoveEvent> &moveEvent) { - bool removed = moveEvent && moveEvent->isFromXML(); - if (removed) { - g_logger().debug("MoveEvent with id '{}' is from XML and will be removed.", pair.first); - ++numRemoved; - } - return removed; - }); - } - } - - if (numRemoved > 0) { - g_logger().debug("Removed '{}' MoveEvent from XML.", numRemoved); - } - return; - } - +void MoveEvents::clear() { uniqueIdMap.clear(); actionIdMap.clear(); itemIdMap.clear(); positionsMap.clear(); } -bool MoveEvents::registerLuaItemEvent(const std::shared_ptr<MoveEvent> moveEvent) { +bool MoveEvents::registerLuaItemEvent(const std::shared_ptr<MoveEvent> &moveEvent) { auto itemIdVector = moveEvent->getItemIdsVector(); if (itemIdVector.empty()) { return false; @@ -71,7 +46,7 @@ bool MoveEvents::registerLuaItemEvent(const std::shared_ptr<MoveEvent> moveEvent return !itemIdVector.empty(); } -bool MoveEvents::registerLuaActionEvent(const std::shared_ptr<MoveEvent> moveEvent) { +bool MoveEvents::registerLuaActionEvent(const std::shared_ptr<MoveEvent> &moveEvent) { auto actionIdVector = moveEvent->getActionIdsVector(); if (actionIdVector.empty()) { return false; @@ -90,7 +65,7 @@ bool MoveEvents::registerLuaActionEvent(const std::shared_ptr<MoveEvent> moveEve return !actionIdVector.empty(); } -bool MoveEvents::registerLuaUniqueEvent(const std::shared_ptr<MoveEvent> moveEvent) { +bool MoveEvents::registerLuaUniqueEvent(const std::shared_ptr<MoveEvent> &moveEvent) { auto uniqueIdVector = moveEvent->getUniqueIdsVector(); if (uniqueIdVector.empty()) { return false; @@ -109,7 +84,7 @@ bool MoveEvents::registerLuaUniqueEvent(const std::shared_ptr<MoveEvent> moveEve return !uniqueIdVector.empty(); } -bool MoveEvents::registerLuaPositionEvent(const std::shared_ptr<MoveEvent> moveEvent) { +bool MoveEvents::registerLuaPositionEvent(const std::shared_ptr<MoveEvent> &moveEvent) { auto positionVector = moveEvent->getPositionsVector(); if (positionVector.empty()) { return false; @@ -128,7 +103,7 @@ bool MoveEvents::registerLuaPositionEvent(const std::shared_ptr<MoveEvent> moveE return !positionVector.empty(); } -bool MoveEvents::registerLuaEvent(const std::shared_ptr<MoveEvent> moveEvent) { +bool MoveEvents::registerLuaEvent(const std::shared_ptr<MoveEvent> &moveEvent) { // Check if event is correct if (registerLuaItemEvent(moveEvent) || registerLuaUniqueEvent(moveEvent) @@ -145,8 +120,8 @@ bool MoveEvents::registerLuaEvent(const std::shared_ptr<MoveEvent> moveEvent) { } } -bool MoveEvents::registerEvent(const std::shared_ptr<MoveEvent> moveEvent, int32_t id, std::map<int32_t, MoveEventList> &moveListMap) const { - auto it = moveListMap.find(id); +bool MoveEvents::registerEvent(const std::shared_ptr<MoveEvent> &moveEvent, int32_t id, std::map<int32_t, MoveEventList> &moveListMap) const { + const auto it = moveListMap.find(id); if (it == moveListMap.end()) { MoveEventList moveEventList; moveEventList.moveEvent[moveEvent->getEventType()].push_back(moveEvent); @@ -209,9 +184,9 @@ std::shared_ptr<MoveEvent> MoveEvents::getEvent(const std::shared_ptr<Item> &ite } if (item->hasAttribute(ItemAttribute_t::ACTIONID)) { - std::map<int32_t, MoveEventList>::iterator it = actionIdMap.find(item->getAttribute<uint16_t>(ItemAttribute_t::ACTIONID)); + auto it = actionIdMap.find(item->getAttribute<uint16_t>(ItemAttribute_t::ACTIONID)); if (it != actionIdMap.end()) { - std::list<std::shared_ptr<MoveEvent>> moveEventList = it->second.moveEvent[eventType]; + const std::list<std::shared_ptr<MoveEvent>> moveEventList = it->second.moveEvent[eventType]; for (const auto &moveEvent : moveEventList) { if ((moveEvent->getSlot() & slotp) != 0) { return moveEvent; @@ -222,7 +197,7 @@ std::shared_ptr<MoveEvent> MoveEvents::getEvent(const std::shared_ptr<Item> &ite auto it = itemIdMap.find(item->getID()); if (it != itemIdMap.end()) { - std::list<std::shared_ptr<MoveEvent>> &moveEventList = it->second.moveEvent[eventType]; + const std::list<std::shared_ptr<MoveEvent>> &moveEventList = it->second.moveEvent[eventType]; for (const auto &moveEvent : moveEventList) { if ((moveEvent->getSlot() & slotp) != 0) { return moveEvent; @@ -264,8 +239,8 @@ std::shared_ptr<MoveEvent> MoveEvents::getEvent(const std::shared_ptr<Item> &ite return nullptr; } -bool MoveEvents::registerEvent(const std::shared_ptr<MoveEvent> moveEvent, const Position &position, std::map<Position, MoveEventList> &moveListMap) const { - auto it = moveListMap.find(position); +bool MoveEvents::registerEvent(const std::shared_ptr<MoveEvent> &moveEvent, const Position &position, std::map<Position, MoveEventList> &moveListMap) const { + const auto it = moveListMap.find(position); if (it == moveListMap.end()) { MoveEventList moveEventList; moveEventList.moveEvent[moveEvent->getEventType()].push_back(moveEvent); @@ -289,7 +264,7 @@ bool MoveEvents::registerEvent(const std::shared_ptr<MoveEvent> moveEvent, const } std::shared_ptr<MoveEvent> MoveEvents::getEvent(const std::shared_ptr<Tile> &tile, MoveEvent_t eventType) { - if (auto it = positionsMap.find(tile->getPosition()); + if (const auto it = positionsMap.find(tile->getPosition()); it != positionsMap.end()) { std::list<std::shared_ptr<MoveEvent>> &moveEventList = it->second.moveEvent[eventType]; if (!moveEventList.empty()) { @@ -310,19 +285,19 @@ uint32_t MoveEvents::onCreatureMove(const std::shared_ptr<Creature> &creature, c } for (size_t i = tile->getFirstIndex(), j = tile->getLastIndex(); i < j; ++i) { - std::shared_ptr<Thing> thing = tile->getThing(i); + const auto &thing = tile->getThing(i); if (!thing) { continue; } - std::shared_ptr<Item> tileItem = thing->getItem(); + const auto &tileItem = thing->getItem(); if (!tileItem) { continue; } moveEvent = getEvent(tileItem, eventType); if (moveEvent) { - auto step = moveEvent->fireStepEvent(creature, tileItem, pos); + const auto step = moveEvent->fireStepEvent(creature, tileItem, pos); // If there is any problem in the function, we will kill the loop if (step == 0) { break; @@ -334,7 +309,7 @@ uint32_t MoveEvents::onCreatureMove(const std::shared_ptr<Creature> &creature, c } uint32_t MoveEvents::onPlayerEquip(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool isCheck) { - const auto moveEvent = getEvent(item, MOVE_EVENT_EQUIP, slot); + const auto &moveEvent = getEvent(item, MOVE_EVENT_EQUIP, slot); if (!moveEvent) { return 1; } @@ -344,7 +319,7 @@ uint32_t MoveEvents::onPlayerEquip(const std::shared_ptr<Player> &player, const } uint32_t MoveEvents::onPlayerDeEquip(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot) { - const auto moveEvent = getEvent(item, MOVE_EVENT_DEEQUIP, slot); + const auto &moveEvent = getEvent(item, MOVE_EVENT_DEEQUIP, slot); if (!moveEvent) { return 1; } @@ -377,19 +352,19 @@ uint32_t MoveEvents::onItemMove(const std::shared_ptr<Item> &item, const std::sh } for (size_t i = tile->getFirstIndex(), j = tile->getLastIndex(); i < j; ++i) { - std::shared_ptr<Thing> thing = tile->getThing(i); + const auto &thing = tile->getThing(i); if (!thing) { continue; } - std::shared_ptr<Item> tileItem = thing->getItem(); + const auto &tileItem = thing->getItem(); if (!tileItem) { continue; } moveEvent = getEvent(tileItem, eventType2); if (moveEvent) { - auto moveItem = moveEvent->fireAddRemItem(item, tileItem, tile->getPosition()); + const auto &moveItem = moveEvent->fireAddRemItem(item, tileItem, tile->getPosition()); // If there is any problem in the function, we will kill the loop if (moveItem == 0) { break; @@ -428,11 +403,11 @@ std::string MoveEvent::getScriptTypeName() const { __FUNCTION__, getScriptInterface()->getLoadingScriptName() ); - return std::string(); + return {}; } } -uint32_t MoveEvent::StepInField(std::shared_ptr<Creature> creature, std::shared_ptr<Item> item, const Position &) { +uint32_t MoveEvent::StepInField(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &item, const Position &) { if (creature == nullptr) { g_logger().error("[MoveEvent::StepInField] - Creature is nullptr"); return 0; @@ -443,7 +418,7 @@ uint32_t MoveEvent::StepInField(std::shared_ptr<Creature> creature, std::shared_ return 0; } - std::shared_ptr<MagicField> field = item->getMagicField(); + const auto &field = item->getMagicField(); if (field) { field->onStepInField(creature); return 1; @@ -452,18 +427,18 @@ uint32_t MoveEvent::StepInField(std::shared_ptr<Creature> creature, std::shared_ return LUA_ERROR_ITEM_NOT_FOUND; } -uint32_t MoveEvent::StepOutField(std::shared_ptr<Creature>, std::shared_ptr<Item>, const Position &) { +uint32_t MoveEvent::StepOutField(const std::shared_ptr<Creature> &, const std::shared_ptr<Item> &, const Position &) { return 1; } -uint32_t MoveEvent::AddItemField(std::shared_ptr<Item> item, std::shared_ptr<Item>, const Position &) { +uint32_t MoveEvent::AddItemField(const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &, const Position &) { if (item == nullptr) { g_logger().error("[MoveEvent::AddItemField] - Item is nullptr"); return 0; } - if (std::shared_ptr<MagicField> field = item->getMagicField()) { - std::shared_ptr<Tile> tile = item->getTile(); + if (const auto &field = item->getMagicField()) { + const auto &tile = item->getTile(); if (tile == nullptr) { g_logger().debug("[MoveEvent::AddItemField] - Tile is nullptr"); return 0; @@ -486,11 +461,11 @@ uint32_t MoveEvent::AddItemField(std::shared_ptr<Item> item, std::shared_ptr<Ite return LUA_ERROR_ITEM_NOT_FOUND; } -uint32_t MoveEvent::RemoveItemField(std::shared_ptr<Item>, std::shared_ptr<Item>, const Position &) { +uint32_t MoveEvent::RemoveItemField(const std::shared_ptr<Item> &, const std::shared_ptr<Item> &, const Position &) { return 1; } -uint32_t MoveEvent::EquipItem(const std::shared_ptr<MoveEvent> moveEvent, std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool isCheck) { +uint32_t MoveEvent::EquipItem(const std::shared_ptr<MoveEvent> &moveEvent, const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool isCheck) { if (player == nullptr) { g_logger().error("[MoveEvent::EquipItem] - Player is nullptr"); return 0; @@ -544,12 +519,12 @@ uint32_t MoveEvent::EquipItem(const std::shared_ptr<MoveEvent> moveEvent, std::s if (it.abilities) { if (it.abilities->invisible) { - std::shared_ptr<Condition> condition = Condition::createCondition(static_cast<ConditionId_t>(slot), CONDITION_INVISIBLE, -1, 0); + const auto &condition = Condition::createCondition(static_cast<ConditionId_t>(slot), CONDITION_INVISIBLE, -1, 0); player->addCondition(condition); } if (it.abilities->manaShield) { - std::shared_ptr<Condition> condition = Condition::createCondition(static_cast<ConditionId_t>(slot), CONDITION_MANASHIELD, -1, 0); + const auto &condition = Condition::createCondition(static_cast<ConditionId_t>(slot), CONDITION_MANASHIELD, -1, 0); player->addCondition(condition); } @@ -561,7 +536,7 @@ uint32_t MoveEvent::EquipItem(const std::shared_ptr<MoveEvent> moveEvent, std::s player->sendIcons(); if (it.abilities->regeneration) { - std::shared_ptr<Condition> condition = Condition::createCondition(static_cast<ConditionId_t>(slot), CONDITION_REGENERATION, -1, 0); + const auto &condition = Condition::createCondition(static_cast<ConditionId_t>(slot), CONDITION_REGENERATION, -1, 0); if (it.abilities->getHealthGain() != 0) { condition->setParam(CONDITION_PARAM_HEALTHGAIN, it.abilities->getHealthGain()); @@ -611,7 +586,7 @@ uint32_t MoveEvent::EquipItem(const std::shared_ptr<MoveEvent> moveEvent, std::s return 1; } -uint32_t MoveEvent::DeEquipItem(const std::shared_ptr<MoveEvent> MoveEvent, std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool) { +uint32_t MoveEvent::DeEquipItem(const std::shared_ptr<MoveEvent> &, const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool) { if (player == nullptr) { g_logger().error("[MoveEvent::EquipItem] - Player is nullptr"); return 0; @@ -696,7 +671,7 @@ void MoveEvent::setEventType(MoveEvent_t type) { eventType = type; } -uint32_t MoveEvent::fireStepEvent(const std::shared_ptr<Creature> &creature, std::shared_ptr<Item> item, const Position &pos) const { +uint32_t MoveEvent::fireStepEvent(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &item, const Position &pos) const { if (isLoadedCallback()) { return executeStep(creature, item, pos); } else { @@ -704,14 +679,14 @@ uint32_t MoveEvent::fireStepEvent(const std::shared_ptr<Creature> &creature, std } } -bool MoveEvent::executeStep(const std::shared_ptr<Creature> &creature, std::shared_ptr<Item> item, const Position &pos) const { +bool MoveEvent::executeStep(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &item, const Position &pos) const { // onStepIn(creature, item, pos, fromPosition) // onStepOut(creature, item, pos, fromPosition) // Check if the new position is the same as the old one // If it is, log a warning and either teleport the player to their temple position if item type is an teleport - auto fromPosition = creature->getLastPosition(); - if (auto player = creature->getPlayer(); item && fromPosition == pos && getEventType() == MOVE_EVENT_STEP_IN) { + const auto fromPosition = creature->getLastPosition(); + if (const auto &player = creature->getPlayer(); item && fromPosition == pos && getEventType() == MOVE_EVENT_STEP_IN) { if (const ItemType &itemType = Item::items[item->getID()]; player && itemType.isTeleport()) { g_logger().warn("[{}] cannot teleport player: {}, to the same position: {} of fromPosition: {}", __FUNCTION__, player->getName(), pos.toString(), fromPosition.toString()); g_game().internalTeleport(player, player->getTemplePosition()); @@ -722,7 +697,7 @@ bool MoveEvent::executeStep(const std::shared_ptr<Creature> &creature, std::shar return false; } - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { if (item != nullptr) { g_logger().error("[MoveEvent::executeStep - Creature {} item {}, position {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -735,7 +710,7 @@ bool MoveEvent::executeStep(const std::shared_ptr<Creature> &creature, std::shar return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -766,14 +741,14 @@ uint32_t MoveEvent::fireEquip(const std::shared_ptr<Player> &player, const std:: bool MoveEvent::executeEquip(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t onSlot, bool isCheck) const { // onEquip(player, item, slot, isCheck) // onDeEquip(player, item, slot, isCheck) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[MoveEvent::executeEquip - Player {} item {}] " "Call stack overflow. Too many lua script calls being nested.", player->getName(), item->getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -799,7 +774,7 @@ uint32_t MoveEvent::fireAddRemItem(const std::shared_ptr<Item> &item, const std: bool MoveEvent::executeAddRemItem(const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &fromTile, const Position &pos) const { // onAddItem(moveitem, tileitem, pos) // onRemoveItem(moveitem, tileitem, pos) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[MoveEvent::executeAddRemItem - " "Item {} item on tile x: {} y: {} z: {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -807,7 +782,7 @@ bool MoveEvent::executeAddRemItem(const std::shared_ptr<Item> &item, const std:: return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -831,7 +806,7 @@ uint32_t MoveEvent::fireAddRemItem(const std::shared_ptr<Item> &item, const Posi bool MoveEvent::executeAddRemItem(const std::shared_ptr<Item> &item, const Position &pos) const { // onaddItem(moveitem, pos) // onRemoveItem(moveitem, pos) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[MoveEvent::executeAddRemItem - " "Item {} item on tile x: {} y: {} z: {}] " "Call stack overflow. Too many lua script calls being nested.", @@ -839,7 +814,7 @@ bool MoveEvent::executeAddRemItem(const std::shared_ptr<Item> &item, const Posit return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); diff --git a/src/lua/creature/movement.hpp b/src/lua/creature/movement.hpp index b8168f58521..58f42296f40 100644 --- a/src/lua/creature/movement.hpp +++ b/src/lua/creature/movement.hpp @@ -46,7 +46,7 @@ class MoveEvents final : public Scripts { } bool hasPosition(Position position) const { - if (auto it = positionsMap.find(position); + if (const auto it = positionsMap.find(position); it != positionsMap.end()) { return true; } @@ -62,7 +62,7 @@ class MoveEvents final : public Scripts { } bool hasItemId(int32_t itemId) const { - if (auto it = itemIdMap.find(itemId); + if (const auto it = itemIdMap.find(itemId); it != itemIdMap.end()) { return true; } @@ -78,7 +78,7 @@ class MoveEvents final : public Scripts { } bool hasUniqueId(int32_t uniqueId) const { - if (auto it = uniqueIdMap.find(uniqueId); + if (const auto it = uniqueIdMap.find(uniqueId); it != uniqueIdMap.end()) { return true; } @@ -94,7 +94,7 @@ class MoveEvents final : public Scripts { } bool hasActionId(int32_t actionId) const { - if (auto it = actionIdMap.find(actionId); + if (const auto it = actionIdMap.find(actionId); it != actionIdMap.end()) { return true; } @@ -107,19 +107,16 @@ class MoveEvents final : public Scripts { std::shared_ptr<MoveEvent> getEvent(const std::shared_ptr<Item> &item, MoveEvent_t eventType); - bool registerLuaItemEvent(const std::shared_ptr<MoveEvent> moveEvent); - bool registerLuaActionEvent(const std::shared_ptr<MoveEvent> moveEvent); - bool registerLuaUniqueEvent(const std::shared_ptr<MoveEvent> moveEvent); - bool registerLuaPositionEvent(const std::shared_ptr<MoveEvent> moveEvent); - bool registerLuaEvent(const std::shared_ptr<MoveEvent> event); - void clear(bool isFromXML = false); + bool registerLuaItemEvent(const std::shared_ptr<MoveEvent> &moveEvent); + bool registerLuaActionEvent(const std::shared_ptr<MoveEvent> &moveEvent); + bool registerLuaUniqueEvent(const std::shared_ptr<MoveEvent> &moveEvent); + bool registerLuaPositionEvent(const std::shared_ptr<MoveEvent> &moveEvent); + bool registerLuaEvent(const std::shared_ptr<MoveEvent> &event); + void clear(); private: - void clearMap(std::map<int32_t, MoveEventList> &map) const; - void clearPosMap(std::map<Position, MoveEventList> &map); - - bool registerEvent(const std::shared_ptr<MoveEvent> moveEvent, int32_t id, std::map<int32_t, MoveEventList> &moveListMap) const; - bool registerEvent(const std::shared_ptr<MoveEvent> moveEvent, const Position &position, std::map<Position, MoveEventList> &moveListMap) const; + bool registerEvent(const std::shared_ptr<MoveEvent> &moveEvent, int32_t id, std::map<int32_t, MoveEventList> &moveListMap) const; + bool registerEvent(const std::shared_ptr<MoveEvent> &moveEvent, const Position &position, std::map<Position, MoveEventList> &moveListMap) const; std::shared_ptr<MoveEvent> getEvent(const std::shared_ptr<Tile> &tile, MoveEvent_t eventType); std::shared_ptr<MoveEvent> getEvent(const std::shared_ptr<Item> &item, MoveEvent_t eventType, Slots_t slot); @@ -139,7 +136,7 @@ class MoveEvent final : public Script, public SharedObject { MoveEvent_t getEventType() const; void setEventType(MoveEvent_t type); - uint32_t fireStepEvent(const std::shared_ptr<Creature> &creature, std::shared_ptr<Item> item, const Position &pos) const; + uint32_t fireStepEvent(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &item, const Position &pos) const; uint32_t fireAddRemItem(const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &tileItem, const Position &pos) const; uint32_t fireAddRemItem(const std::shared_ptr<Item> &item, const Position &pos) const; uint32_t fireEquip(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool isCheck); @@ -149,7 +146,7 @@ class MoveEvent final : public Script, public SharedObject { } // Scripting to lua interface - bool executeStep(const std::shared_ptr<Creature> &creature, std::shared_ptr<Item> item, const Position &pos) const; + bool executeStep(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &item, const Position &pos) const; bool executeEquip(const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool isCheck) const; bool executeAddRemItem(const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &tileItem, const Position &pos) const; // No have tile item @@ -178,8 +175,8 @@ class MoveEvent final : public Script, public SharedObject { const std::map<uint16_t, bool> &getVocEquipMap() const { return vocEquipMap; } - void addVocEquipMap(std::string vocName) { - uint16_t vocationId = g_vocations().getVocationId(vocName); + void addVocEquipMap(const std::string &vocName) { + const uint16_t vocationId = g_vocations().getVocationId(vocName); if (vocationId != 65535) { vocEquipMap[vocationId] = true; } @@ -217,47 +214,36 @@ class MoveEvent final : public Script, public SharedObject { void setSlot(uint32_t s) { slot = s; } - uint32_t getRequiredLevel() { + uint32_t getRequiredLevel() const { return reqLevel; } void setRequiredLevel(uint32_t level) { reqLevel = level; } - uint32_t getRequiredMagLevel() { + uint32_t getRequiredMagLevel() const { return reqMagLevel; } void setRequiredMagLevel(uint32_t level) { reqMagLevel = level; } - bool needPremium() { + bool needPremium() const { return premium; } void setNeedPremium(bool b) { premium = b; } - uint32_t getWieldInfo() { - return wieldInfo; - } void setWieldInfo(WieldInfo_t info) { wieldInfo |= info; } - static uint32_t StepInField(std::shared_ptr<Creature> creature, std::shared_ptr<Item> item, const Position &pos); - static uint32_t StepOutField(std::shared_ptr<Creature> creature, std::shared_ptr<Item> item, const Position &pos); - - static uint32_t AddItemField(std::shared_ptr<Item> item, std::shared_ptr<Item> tileItem, const Position &pos); - static uint32_t RemoveItemField(std::shared_ptr<Item> item, std::shared_ptr<Item> tileItem, const Position &pos); + static uint32_t StepInField(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &item, const Position &pos); + static uint32_t StepOutField(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Item> &item, const Position &pos); - static uint32_t EquipItem(const std::shared_ptr<MoveEvent> moveEvent, std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool boolean); - static uint32_t DeEquipItem(const std::shared_ptr<MoveEvent> moveEvent, std::shared_ptr<Player> player, std::shared_ptr<Item> item, Slots_t slot, bool boolean); + static uint32_t AddItemField(const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &tileItem, const Position &pos); + static uint32_t RemoveItemField(const std::shared_ptr<Item> &item, const std::shared_ptr<Item> &tileItem, const Position &pos); - void setFromXML(bool newFromXML) { - m_fromXML = newFromXML; - } - - bool isFromXML() const { - return m_fromXML; - } + static uint32_t EquipItem(const std::shared_ptr<MoveEvent> &moveEvent, const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool boolean); + static uint32_t DeEquipItem(const std::shared_ptr<MoveEvent> &, const std::shared_ptr<Player> &player, const std::shared_ptr<Item> &item, Slots_t slot, bool boolean); private: std::string getScriptTypeName() const override; @@ -282,7 +268,7 @@ class MoveEvent final : public Script, public SharedObject { // equipFunction std::function<uint32_t( std::shared_ptr<MoveEvent> moveEvent, - std::shared_ptr<Player> player, + const std::shared_ptr<Player> &player, std::shared_ptr<Item> item, Slots_t slot, bool boolean @@ -298,8 +284,6 @@ class MoveEvent final : public Script, public SharedObject { std::map<uint16_t, bool> vocEquipMap; bool tileItem = false; - bool m_fromXML = false; - std::vector<uint32_t> itemIdVector; std::vector<uint32_t> actionIdVector; std::vector<uint32_t> uniqueIdVector; diff --git a/src/lua/creature/raids.cpp b/src/lua/creature/raids.cpp index 818ad077e77..f9d000c6fdd 100644 --- a/src/lua/creature/raids.cpp +++ b/src/lua/creature/raids.cpp @@ -31,7 +31,7 @@ bool Raids::loadFromXml() { return false; } - for (auto raidNode : doc.child("raids").children()) { + for (const auto &raidNode : doc.child("raids").children()) { std::string name, file; uint32_t interval, margin; @@ -113,14 +113,14 @@ void Raids::checkRaids() { return; } if (!getRunning()) { - uint64_t now = OTSYS_TIME(); + const uint64_t now = OTSYS_TIME(); for (auto it = raidList.begin(), end = raidList.end(); it != end; ++it) { const auto &raid = *it; if (now >= (getLastRaidEnd() + raid->getMargin())) { - auto roll = static_cast<uint32_t>(uniform_random(0, MAX_RAND_RANGE)); - auto required = static_cast<uint32_t>(MAX_RAND_RANGE * raid->getInterval()) / CHECK_RAIDS_INTERVAL; - auto shouldStart = required >= roll; + const auto roll = static_cast<uint32_t>(uniform_random(0, MAX_RAND_RANGE)); + const auto required = static_cast<uint32_t>(MAX_RAND_RANGE * raid->getInterval()) / CHECK_RAIDS_INTERVAL; + const auto shouldStart = required >= roll; if (shouldStart) { setRunning(raid); raid->startRaid(); @@ -161,7 +161,7 @@ bool Raids::reload() { return loadFromXml(); } -std::shared_ptr<Raid> Raids::getRaidByName(const std::string &name) { +std::shared_ptr<Raid> Raids::getRaidByName(const std::string &name) const { for (const auto &raid : raidList) { if (strcasecmp(raid->getName().c_str(), name.c_str()) == 0) { return raid; @@ -176,13 +176,13 @@ bool Raid::loadFromXml(const std::string &filename) { } pugi::xml_document doc; - pugi::xml_parse_result result = doc.load_file(filename.c_str()); + const pugi::xml_parse_result result = doc.load_file(filename.c_str()); if (!result) { printXMLError(__FUNCTION__, filename, result); return false; } - for (auto eventNode : doc.child("raid").children()) { + for (const auto &eventNode : doc.child("raid").children()) { std::shared_ptr<RaidEvent> event; if (strcasecmp(eventNode.name(), "announce") == 0) { event = std::make_shared<AnnounceEvent>(); @@ -206,7 +206,7 @@ bool Raid::loadFromXml(const std::string &filename) { } // sort by delay time - std::sort(raidEvents.begin(), raidEvents.end(), [](const std::shared_ptr<RaidEvent> lhs, const std::shared_ptr<RaidEvent> rhs) { + std::ranges::sort(raidEvents, [](const std::shared_ptr<RaidEvent> &lhs, const std::shared_ptr<RaidEvent> &rhs) { return lhs->getDelay() < rhs->getDelay(); }); @@ -227,13 +227,13 @@ void Raid::startRaid() { } } -void Raid::executeRaidEvent(const std::shared_ptr<RaidEvent> raidEvent) { +void Raid::executeRaidEvent(const std::shared_ptr<RaidEvent> &raidEvent) { if (raidEvent->executeEvent()) { nextEvent++; const auto newRaidEvent = getNextRaidEvent(); if (newRaidEvent) { - uint32_t ticks = static_cast<uint32_t>(std::max<int32_t>(RAID_MINTICKS, newRaidEvent->getDelay() - raidEvent->getDelay())); + const uint32_t ticks = static_cast<uint32_t>(std::max<int32_t>(RAID_MINTICKS, newRaidEvent->getDelay() - raidEvent->getDelay())); nextEventEvent = g_dispatcher().scheduleEvent( ticks, [this, newRaidEvent] { executeRaidEvent(newRaidEvent); }, __FUNCTION__ ); @@ -268,7 +268,7 @@ std::shared_ptr<RaidEvent> Raid::getNextRaidEvent() { } bool RaidEvent::configureRaidEvent(const pugi::xml_node &eventNode) { - pugi::xml_attribute delayAttribute = eventNode.attribute("delay"); + const pugi::xml_attribute delayAttribute = eventNode.attribute("delay"); if (!delayAttribute) { g_logger().error("{} - 'delay' tag missing", __FUNCTION__); return false; @@ -283,7 +283,7 @@ bool AnnounceEvent::configureRaidEvent(const pugi::xml_node &eventNode) { return false; } - pugi::xml_attribute messageAttribute = eventNode.attribute("message"); + const pugi::xml_attribute messageAttribute = eventNode.attribute("message"); if (!messageAttribute) { g_logger().error("{} - " "'message' tag missing for announce event", @@ -292,9 +292,9 @@ bool AnnounceEvent::configureRaidEvent(const pugi::xml_node &eventNode) { } message = messageAttribute.as_string(); - pugi::xml_attribute typeAttribute = eventNode.attribute("type"); + const pugi::xml_attribute typeAttribute = eventNode.attribute("type"); if (typeAttribute) { - std::string tmpStrValue = asLowerCaseString(typeAttribute.as_string()); + const std::string tmpStrValue = asLowerCaseString(typeAttribute.as_string()); if (tmpStrValue == "warning") { messageType = MESSAGE_GAME_HIGHLIGHT; } else if (tmpStrValue == "event") { @@ -374,7 +374,7 @@ bool SingleSpawnEvent::configureRaidEvent(const pugi::xml_node &eventNode) { } bool SingleSpawnEvent::executeEvent() { - std::shared_ptr<Monster> monster = Monster::createMonster(monsterName); + const auto &monster = Monster::createMonster(monsterName); if (!monster) { g_logger().error("{} - Cant create monster {}", __FUNCTION__, monsterName); return false; @@ -396,7 +396,7 @@ bool AreaSpawnEvent::configureRaidEvent(const pugi::xml_node &eventNode) { pugi::xml_attribute attr; if ((attr = eventNode.attribute("radius"))) { - int32_t radius = pugi::cast<int32_t>(attr.value()); + const auto radius = pugi::cast<int32_t>(attr.value()); Position centerPos; if ((attr = eventNode.attribute("centerx"))) { @@ -490,7 +490,7 @@ bool AreaSpawnEvent::configureRaidEvent(const pugi::xml_node &eventNode) { } } - for (auto monsterNode : eventNode.children()) { + for (const auto &monsterNode : eventNode.children()) { const char* name; if ((attr = monsterNode.attribute("name"))) { @@ -535,7 +535,7 @@ bool AreaSpawnEvent::configureRaidEvent(const pugi::xml_node &eventNode) { bool AreaSpawnEvent::executeEvent() { for (const MonsterSpawn &spawn : spawnMonsterList) { - uint32_t amount = uniform_random(spawn.minAmount, spawn.maxAmount); + const uint32_t amount = uniform_random(spawn.minAmount, spawn.maxAmount); for (uint32_t i = 0; i < amount; ++i) { std::shared_ptr<Monster> monster = Monster::createMonster(spawn.name); if (!monster) { @@ -545,7 +545,7 @@ bool AreaSpawnEvent::executeEvent() { bool success = false; for (int32_t tries = 0; tries < MAXIMUM_TRIES_PER_MONSTER; tries++) { - std::shared_ptr<Tile> tile = g_game().map.getTile(static_cast<uint16_t>(uniform_random(fromPos.x, toPos.x)), static_cast<uint16_t>(uniform_random(fromPos.y, toPos.y)), static_cast<uint8_t>(uniform_random(fromPos.z, toPos.z))); + const auto &tile = g_game().map.getTile(static_cast<uint16_t>(uniform_random(fromPos.x, toPos.x)), static_cast<uint16_t>(uniform_random(fromPos.y, toPos.y)), static_cast<uint8_t>(uniform_random(fromPos.z, toPos.z))); if (tile && !tile->isMovableBlocking() && !tile->hasFlag(TILESTATE_PROTECTIONZONE) && tile->getTopCreature() == nullptr && g_game().placeCreature(monster, tile->getPosition(), false, true)) { success = true; monster->setForgeMonster(false); @@ -565,7 +565,7 @@ bool ScriptEvent::configureRaidEvent(const pugi::xml_node &eventNode) { return false; } - pugi::xml_attribute scriptAttribute = eventNode.attribute("script"); + const pugi::xml_attribute scriptAttribute = eventNode.attribute("script"); if (!scriptAttribute) { g_logger().error("{} - " "No script file found for raid", @@ -591,14 +591,14 @@ std::string ScriptEvent::getScriptEventName() const { bool ScriptEvent::executeEvent() { // onRaid() - if (!scriptInterface->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("{} - Script with name {} " "Call stack overflow. Too many lua script calls being nested.", __FUNCTION__, getScriptName()); return false; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(scriptId, scriptInterface); scriptInterface->pushFunction(scriptId); diff --git a/src/lua/creature/raids.hpp b/src/lua/creature/raids.hpp index 0266641edda..0a352e897eb 100644 --- a/src/lua/creature/raids.hpp +++ b/src/lua/creature/raids.hpp @@ -56,11 +56,11 @@ class Raids { std::shared_ptr<Raid> getRunning() { return running; } - void setRunning(const std::shared_ptr<Raid> newRunning) { + void setRunning(const std::shared_ptr<Raid> &newRunning) { running = newRunning; } - std::shared_ptr<Raid> getRaidByName(const std::string &name); + std::shared_ptr<Raid> getRaidByName(const std::string &name) const; uint64_t getLastRaidEnd() const { return lastRaidEnd; @@ -100,7 +100,7 @@ class Raid { void startRaid(); - void executeRaidEvent(const std::shared_ptr<RaidEvent> raidEvent); + void executeRaidEvent(const std::shared_ptr<RaidEvent> &raidEvent); void resetRaid(); std::shared_ptr<RaidEvent> getNextRaidEvent(); @@ -150,7 +150,7 @@ class RaidEvent { } private: - uint32_t delay; + uint32_t delay {}; }; class AnnounceEvent final : public RaidEvent { @@ -202,7 +202,7 @@ class ScriptEvent final : public RaidEvent, public Event { return scriptName; } void setScriptName(std::string name) { - scriptName = name; + scriptName = std::move(name); } bool executeEvent() override; diff --git a/src/lua/creature/talkaction.cpp b/src/lua/creature/talkaction.cpp index 4dbf829d3c5..d1b8b634f59 100644 --- a/src/lua/creature/talkaction.cpp +++ b/src/lua/creature/talkaction.cpp @@ -23,29 +23,29 @@ bool TalkActions::registerLuaEvent(const TalkAction_ptr &talkAction) { return inserted; } -bool TalkActions::checkWord(std::shared_ptr<Player> player, SpeakClasses type, const std::string &words, std::string_view word, const TalkAction_ptr &talkActionPtr) const { - auto spacePos = std::ranges::find_if(words.begin(), words.end(), ::isspace); - std::string firstWord = words.substr(0, spacePos - words.begin()); +bool TalkActions::checkWord(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &words, std::string_view word, const TalkAction_ptr &talkActionPtr) const { + const auto spacePos = std::ranges::find_if(words.begin(), words.end(), ::isspace); + const std::string firstWord = words.substr(0, spacePos - words.begin()); // Check for exact equality from saying word and talkaction stored word if (firstWord != word) { return false; } - auto groupId = player->getGroup()->id; + const auto groupId = player->getGroup()->id; if (groupId < talkActionPtr->getGroupType()) { return false; } std::string param; - size_t wordPos = words.find(word); - size_t talkactionLength = word.length(); + const size_t wordPos = words.find(word); + const size_t talkactionLength = word.length(); if (wordPos != std::string::npos && wordPos + talkactionLength < words.length()) { param = words.substr(wordPos + talkactionLength); trim_left(param, ' '); } - std::string separator = talkActionPtr->getSeparator(); + const std::string separator = talkActionPtr->getSeparator(); if (separator != " ") { if (!param.empty()) { if (param != separator) { @@ -59,7 +59,7 @@ bool TalkActions::checkWord(std::shared_ptr<Player> player, SpeakClasses type, c return talkActionPtr->executeSay(player, words, param, type); } -TalkActionResult_t TalkActions::checkPlayerCanSayTalkAction(std::shared_ptr<Player> player, SpeakClasses type, const std::string &words) const { +TalkActionResult_t TalkActions::checkPlayerCanSayTalkAction(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &words) const { for (const auto &[talkactionWords, talkActionPtr] : talkActions) { if (talkactionWords.find(',') != std::string::npos) { auto wordsList = split(talkactionWords); @@ -77,16 +77,16 @@ TalkActionResult_t TalkActions::checkPlayerCanSayTalkAction(std::shared_ptr<Play return TALKACTION_CONTINUE; } -bool TalkAction::executeSay(std::shared_ptr<Player> player, const std::string &words, const std::string ¶m, SpeakClasses type) const { +bool TalkAction::executeSay(const std::shared_ptr<Player> &player, const std::string &words, const std::string ¶m, SpeakClasses type) const { // onSay(player, words, param, type) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[TalkAction::executeSay - Player {} words {}] " "Call stack overflow. Too many lua script calls being nested. Script name {}", player->getName(), getWords(), getScriptInterface()->getLoadingScriptName()); return false; } - ScriptEnvironment* scriptEnvironment = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* scriptEnvironment = LuaScriptInterface::getScriptEnv(); scriptEnvironment->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); diff --git a/src/lua/creature/talkaction.hpp b/src/lua/creature/talkaction.hpp index 50ade58172d..d11a5487924 100644 --- a/src/lua/creature/talkaction.hpp +++ b/src/lua/creature/talkaction.hpp @@ -19,7 +19,7 @@ class TalkAction; using TalkAction_ptr = std::shared_ptr<TalkAction>; -class TalkAction : public Script { +class TalkAction final : public Script { public: using Script::Script; @@ -48,11 +48,11 @@ class TalkAction : public Script { return separator; } void setSeparator(std::string sep) { - separator = sep; + separator = std::move(sep); } // scripting - bool executeSay(std::shared_ptr<Player> player, const std::string &words, const std::string ¶m, SpeakClasses type) const; + bool executeSay(const std::shared_ptr<Player> &player, const std::string &words, const std::string ¶m, SpeakClasses type) const; // void setGroupType(uint8_t newGroupType); @@ -82,8 +82,8 @@ class TalkActions final : public Scripts { return inject<TalkActions>(); } - bool checkWord(std::shared_ptr<Player> player, SpeakClasses type, const std::string &words, std::string_view word, const TalkAction_ptr &talkActionPtr) const; - TalkActionResult_t checkPlayerCanSayTalkAction(std::shared_ptr<Player> player, SpeakClasses type, const std::string &words) const; + bool checkWord(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &words, std::string_view word, const TalkAction_ptr &talkActionPtr) const; + TalkActionResult_t checkPlayerCanSayTalkAction(const std::shared_ptr<Player> &player, SpeakClasses type, const std::string &words) const; bool registerLuaEvent(const TalkAction_ptr &talkAction); void clear(); diff --git a/src/lua/functions/core/core_functions.hpp b/src/lua/functions/core/core_functions.hpp index c6c14121b06..2a75d148c51 100644 --- a/src/lua/functions/core/core_functions.hpp +++ b/src/lua/functions/core/core_functions.hpp @@ -16,6 +16,12 @@ class CoreFunctions final : LuaScriptInterface { public: + explicit CoreFunctions(lua_State* L) : + LuaScriptInterface("CoreFunctions") { + init(L); + } + ~CoreFunctions() override = default; + static void init(lua_State* L) { CoreGameFunctions::init(L); CoreLibsFunctions::init(L); diff --git a/src/lua/functions/core/game/bank_functions.cpp b/src/lua/functions/core/game/bank_functions.cpp index 26005db41e3..e387a2d1a4c 100644 --- a/src/lua/functions/core/game/bank_functions.cpp +++ b/src/lua/functions/core/game/bank_functions.cpp @@ -13,31 +13,31 @@ int BankFunctions::luaBankCredit(lua_State* L) { // Bank.credit(playerOrGuild, amount) - auto bank = getBank(L, 1); + const auto &bank = getBank(L, 1); if (bank == nullptr) { reportErrorFunc("Bank is nullptr"); return 1; } - uint64_t amount = getNumber<uint64_t>(L, 2); + const uint64_t amount = getNumber<uint64_t>(L, 2); pushBoolean(L, bank->credit(amount)); return 1; } int BankFunctions::luaBankDebit(lua_State* L) { // Bank.debit(playerOrGuild, amount) - auto bank = getBank(L, 1); + const auto &bank = getBank(L, 1); if (bank == nullptr) { reportErrorFunc("Bank is nullptr"); return 1; } - uint64_t amount = getNumber<uint64_t>(L, 2); + const uint64_t amount = getNumber<uint64_t>(L, 2); pushBoolean(L, bank->debit(amount)); return 1; } int BankFunctions::luaBankBalance(lua_State* L) { // Bank.balance(playerOrGuild[, amount]]) - auto bank = getBank(L, 1); + const auto &bank = getBank(L, 1); if (bank == nullptr) { reportErrorFunc("Bank is nullptr"); return 1; @@ -46,19 +46,19 @@ int BankFunctions::luaBankBalance(lua_State* L) { lua_pushnumber(L, bank->balance()); return 1; } - uint64_t amount = getNumber<uint64_t>(L, 2); + const uint64_t amount = getNumber<uint64_t>(L, 2); pushBoolean(L, bank->balance(amount)); return 1; } int BankFunctions::luaBankHasBalance(lua_State* L) { // Bank.hasBalance(playerOrGuild, amount) - auto bank = getBank(L, 1); + const auto &bank = getBank(L, 1); if (bank == nullptr) { reportErrorFunc("Bank is nullptr"); return 1; } - uint64_t amount = getNumber<uint64_t>(L, 2); + const uint64_t amount = getNumber<uint64_t>(L, 2); pushBoolean(L, bank->hasBalance(amount)); return 1; } @@ -107,13 +107,13 @@ int BankFunctions::luaBankWithdraw(lua_State* L) { return 1; } - uint64_t amount = getNumber<uint64_t>(L, 2); + const uint64_t amount = getNumber<uint64_t>(L, 2); if (lua_gettop(L) == 2) { - const auto bank = std::make_shared<Bank>(player); + auto bank = std::make_shared<Bank>(player); pushBoolean(L, bank->withdraw(player, amount)); return 1; } - auto source = getBank(L, 3); + const auto &source = getBank(L, 3); if (source == nullptr) { reportErrorFunc("Source is nullptr"); return 1; @@ -129,7 +129,7 @@ int BankFunctions::luaBankDeposit(lua_State* L) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); return 1; } - const auto bank = std::make_shared<Bank>(player); + auto bank = std::make_shared<Bank>(player); uint64_t amount = 0; if (lua_isnumber(L, 2)) { @@ -142,7 +142,7 @@ int BankFunctions::luaBankDeposit(lua_State* L) { pushBoolean(L, g_game().removeMoney(player, amount) && bank->credit(amount)); return 1; } - auto destination = getBank(L, 3); + const auto &destination = getBank(L, 3); if (destination == nullptr) { reportErrorFunc("Destination is nullptr"); return 1; @@ -156,13 +156,13 @@ std::shared_ptr<Bank> BankFunctions::getBank(lua_State* L, int32_t arg, bool isG return std::make_shared<Bank>(getGuild(L, arg)); } if (isGuild) { - const auto guild = getGuild(L, arg, true); + const auto &guild = getGuild(L, arg, true); if (!guild) { return nullptr; } return std::make_shared<Bank>(guild); } - std::shared_ptr<Player> player = getPlayer(L, arg, true); + const auto &player = getPlayer(L, arg, true); if (!player) { return nullptr; } diff --git a/src/lua/functions/core/game/bank_functions.hpp b/src/lua/functions/core/game/bank_functions.hpp index db450f49469..f2a94a40435 100644 --- a/src/lua/functions/core/game/bank_functions.hpp +++ b/src/lua/functions/core/game/bank_functions.hpp @@ -15,6 +15,12 @@ class Bank; class BankFunctions final : LuaScriptInterface { public: + explicit BankFunctions(lua_State* L) : + LuaScriptInterface("BankFunctions") { + init(L); + } + ~BankFunctions() override = default; + static void init(lua_State* L) { registerTable(L, "Bank"); registerMethod(L, "Bank", "credit", BankFunctions::luaBankCredit); diff --git a/src/lua/functions/core/game/config_functions.cpp b/src/lua/functions/core/game/config_functions.cpp index 7b4b34a9eb3..d8ee6e3ea77 100644 --- a/src/lua/functions/core/game/config_functions.cpp +++ b/src/lua/functions/core/game/config_functions.cpp @@ -35,7 +35,7 @@ void ConfigFunctions::init(lua_State* L) { } int ConfigFunctions::luaConfigManagerGetString(lua_State* L) { - auto key = getNumber<ConfigKey_t>(L, -1); + const auto key = getNumber<ConfigKey_t>(L, -1); if (!key) { reportErrorFunc("Wrong enum"); return 1; @@ -46,7 +46,7 @@ int ConfigFunctions::luaConfigManagerGetString(lua_State* L) { } int ConfigFunctions::luaConfigManagerGetNumber(lua_State* L) { - auto key = getNumber<ConfigKey_t>(L, -1); + const auto key = getNumber<ConfigKey_t>(L, -1); if (!key) { reportErrorFunc("Wrong enum"); return 1; @@ -57,7 +57,7 @@ int ConfigFunctions::luaConfigManagerGetNumber(lua_State* L) { } int ConfigFunctions::luaConfigManagerGetBoolean(lua_State* L) { - auto key = getNumber<ConfigKey_t>(L, -1); + const auto key = getNumber<ConfigKey_t>(L, -1); if (!key) { reportErrorFunc("Wrong enum"); return 1; @@ -71,7 +71,7 @@ int ConfigFunctions::luaConfigManagerGetFloat(lua_State* L) { // configManager.getFloat(key, shouldRound = true) // Ensure the first argument (key) is provided and is a valid enum - auto key = getNumber<ConfigKey_t>(L, 1); + const auto key = getNumber<ConfigKey_t>(L, 1); if (!key) { reportErrorFunc("Wrong enum"); return 1; diff --git a/src/lua/functions/core/game/config_functions.hpp b/src/lua/functions/core/game/config_functions.hpp index 9806a35f426..973ed5c1d63 100644 --- a/src/lua/functions/core/game/config_functions.hpp +++ b/src/lua/functions/core/game/config_functions.hpp @@ -14,6 +14,12 @@ class ConfigFunctions final : LuaScriptInterface { public: + explicit ConfigFunctions(lua_State* L) : + LuaScriptInterface("ConfigFunctions") { + init(L); + } + ~ConfigFunctions() override = default; + static void init(lua_State* L); private: diff --git a/src/lua/functions/core/game/core_game_functions.hpp b/src/lua/functions/core/game/core_game_functions.hpp index 03bcc236daf..f5fe1c9da94 100644 --- a/src/lua/functions/core/game/core_game_functions.hpp +++ b/src/lua/functions/core/game/core_game_functions.hpp @@ -19,6 +19,12 @@ class CoreGameFunctions final : LuaScriptInterface { public: + explicit CoreGameFunctions(lua_State* L) : + LuaScriptInterface("CoreGameFunctions") { + init(L); + } + ~CoreGameFunctions() override = default; + static void init(lua_State* L) { ConfigFunctions::init(L); GameFunctions::init(L); diff --git a/src/lua/functions/core/game/game_functions.cpp b/src/lua/functions/core/game/game_functions.cpp index 064bdd166e1..df123049df7 100644 --- a/src/lua/functions/core/game/game_functions.cpp +++ b/src/lua/functions/core/game/game_functions.cpp @@ -27,7 +27,6 @@ #include "creatures/players/achievement/player_achievement.hpp" #include "creatures/players/cyclopedia/player_badge.hpp" #include "creatures/players/cyclopedia/player_cyclopedia.hpp" -#include "creatures/players/cyclopedia/player_title.hpp" #include "map/spectators.hpp" // Game @@ -39,7 +38,7 @@ int GameFunctions::luaGameCreateMonsterType(lua_State* L) { auto variant = getString(L, 2, ""); const auto alternateName = getString(L, 3, ""); std::set<std::string> names; - auto monsterType = std::make_shared<MonsterType>(name); + const auto monsterType = std::make_shared<MonsterType>(name); if (!monsterType) { lua_pushstring(L, "MonsterType is nullptr"); lua_error(L); @@ -88,12 +87,12 @@ int GameFunctions::luaGameCreateNpcType(lua_State* L) { int GameFunctions::luaGameGetSpectators(lua_State* L) { // Game.getSpectators(position[, multifloor = false[, onlyPlayer = false[, minRangeX = 0[, maxRangeX = 0[, minRangeY = 0[, maxRangeY = 0]]]]]]) const Position &position = getPosition(L, 1); - bool multifloor = getBoolean(L, 2, false); - bool onlyPlayers = getBoolean(L, 3, false); - int32_t minRangeX = getNumber<int32_t>(L, 4, 0); - int32_t maxRangeX = getNumber<int32_t>(L, 5, 0); - int32_t minRangeY = getNumber<int32_t>(L, 6, 0); - int32_t maxRangeY = getNumber<int32_t>(L, 7, 0); + const bool multifloor = getBoolean(L, 2, false); + const bool onlyPlayers = getBoolean(L, 3, false); + const auto minRangeX = getNumber<int32_t>(L, 4, 0); + const auto maxRangeX = getNumber<int32_t>(L, 5, 0); + const auto minRangeY = getNumber<int32_t>(L, 6, 0); + const auto maxRangeY = getNumber<int32_t>(L, 7, 0); Spectators spectators; @@ -106,7 +105,7 @@ int GameFunctions::luaGameGetSpectators(lua_State* L) { lua_createtable(L, spectators.size(), 0); int index = 0; - for (std::shared_ptr<Creature> creature : spectators) { + for (const auto &creature : spectators) { pushUserdata<Creature>(L, creature); setCreatureMetatable(L, -1, creature); lua_rawseti(L, -2, ++index); @@ -124,11 +123,11 @@ int GameFunctions::luaGameGetBestiaryList(lua_State* L) { // Game.getBestiaryList([bool[string or BestiaryType_t]]) lua_newtable(L); int index = 0; - bool name = getBoolean(L, 2, false); + const bool name = getBoolean(L, 2, false); if (lua_gettop(L) <= 2) { - std::map<uint16_t, std::string> mtype_list = g_game().getBestiaryList(); - for (auto ita : mtype_list) { + const std::map<uint16_t, std::string> &mtype_list = g_game().getBestiaryList(); + for (const auto &ita : mtype_list) { if (name) { pushString(L, ita.second); } else { @@ -138,8 +137,8 @@ int GameFunctions::luaGameGetBestiaryList(lua_State* L) { } } else { if (isNumber(L, 2)) { - std::map<uint16_t, std::string> tmplist = g_iobestiary().findRaceByName("CANARY", false, getNumber<BestiaryType_t>(L, 2)); - for (auto itb : tmplist) { + const std::map<uint16_t, std::string> tmplist = g_iobestiary().findRaceByName("CANARY", false, getNumber<BestiaryType_t>(L, 2)); + for (const auto &itb : tmplist) { if (name) { pushString(L, itb.second); } else { @@ -148,8 +147,8 @@ int GameFunctions::luaGameGetBestiaryList(lua_State* L) { lua_rawseti(L, -2, ++index); } } else { - std::map<uint16_t, std::string> tmplist = g_iobestiary().findRaceByName(getString(L, 2)); - for (auto itc : tmplist) { + const std::map<uint16_t, std::string> tmplist = g_iobestiary().findRaceByName(getString(L, 2)); + for (const auto &itc : tmplist) { if (name) { pushString(L, itc.second); } else { @@ -238,7 +237,7 @@ int GameFunctions::luaGameGetTowns(lua_State* L) { lua_createtable(L, towns.size(), 0); int index = 0; - for (auto townEntry : towns) { + for (const auto &townEntry : towns) { pushUserdata<Town>(L, townEntry.second); setMetatable(L, -1, "Town"); lua_rawseti(L, -2, ++index); @@ -252,7 +251,7 @@ int GameFunctions::luaGameGetHouses(lua_State* L) { lua_createtable(L, houses.size(), 0); int index = 0; - for (auto houseEntry : houses) { + for (const auto &houseEntry : houses) { pushUserdata<House>(L, houseEntry.second); setMetatable(L, -1, "House"); lua_rawseti(L, -2, ++index); @@ -268,7 +267,7 @@ int GameFunctions::luaGameGetGameState(lua_State* L) { int GameFunctions::luaGameSetGameState(lua_State* L) { // Game.setGameState(state) - GameState_t state = getNumber<GameState_t>(L, 1); + const GameState_t state = getNumber<GameState_t>(L, 1); g_game().setGameState(state); pushBoolean(L, true); return 1; @@ -282,7 +281,7 @@ int GameFunctions::luaGameGetWorldType(lua_State* L) { int GameFunctions::luaGameSetWorldType(lua_State* L) { // Game.setWorldType(type) - WorldType_t type = getNumber<WorldType_t>(L, 1); + const WorldType_t type = getNumber<WorldType_t>(L, 1); g_game().setWorldType(type); pushBoolean(L, true); return 1; @@ -290,7 +289,7 @@ int GameFunctions::luaGameSetWorldType(lua_State* L) { int GameFunctions::luaGameGetReturnMessage(lua_State* L) { // Game.getReturnMessage(value) - ReturnValue value = getNumber<ReturnValue>(L, 1); + const ReturnValue value = getNumber<ReturnValue>(L, 1); pushString(L, getReturnMessage(value)); return 1; } @@ -308,14 +307,14 @@ int GameFunctions::luaGameCreateItem(lua_State* L) { } } - int32_t count = getNumber<int32_t>(L, 2, 1); + const auto count = getNumber<int32_t>(L, 2, 1); int32_t itemCount = 1; int32_t subType = 1; const ItemType &it = Item::items[itemId]; if (it.hasSubType()) { if (it.stackable) { - itemCount = std::ceil(count / (float_t)it.stackSize); + itemCount = std::ceil(count / static_cast<float_t>(it.stackSize)); } subType = count; @@ -328,7 +327,7 @@ int GameFunctions::luaGameCreateItem(lua_State* L) { position = getPosition(L, 3); } - bool hasTable = itemCount > 1; + const bool hasTable = itemCount > 1; if (hasTable) { lua_newtable(L); } else if (itemCount == 0) { @@ -343,7 +342,7 @@ int GameFunctions::luaGameCreateItem(lua_State* L) { subType -= stackCount; } - std::shared_ptr<Item> item = Item::CreateItem(itemId, stackCount); + const auto &item = Item::CreateItem(itemId, stackCount); if (!item) { if (!hasTable) { lua_pushnil(L); @@ -352,7 +351,7 @@ int GameFunctions::luaGameCreateItem(lua_State* L) { } if (position.x != 0) { - std::shared_ptr<Tile> tile = g_game().map.getTile(position); + const auto &tile = g_game().map.getTile(position); if (!tile) { if (!hasTable) { lua_pushnil(L); @@ -388,7 +387,7 @@ int GameFunctions::luaGameCreateItem(lua_State* L) { int GameFunctions::luaGameCreateContainer(lua_State* L) { // Game.createContainer(itemId, size[, position]) - uint16_t size = getNumber<uint16_t>(L, 2); + const uint16_t size = getNumber<uint16_t>(L, 2); uint16_t id; if (isNumber(L, 1)) { id = getNumber<uint16_t>(L, 1); @@ -400,7 +399,7 @@ int GameFunctions::luaGameCreateContainer(lua_State* L) { } } - std::shared_ptr<Container> container = Item::CreateItemAsContainer(id, size); + const auto &container = Item::CreateItemAsContainer(id, size); if (!container) { lua_pushnil(L); return 1; @@ -408,7 +407,7 @@ int GameFunctions::luaGameCreateContainer(lua_State* L) { if (lua_gettop(L) >= 3) { const Position &position = getPosition(L, 3); - std::shared_ptr<Tile> tile = g_game().map.getTile(position); + const auto &tile = g_game().map.getTile(position); if (!tile) { lua_pushnil(L); return 1; @@ -442,8 +441,8 @@ int GameFunctions::luaGameCreateMonster(lua_State* L) { } const Position &position = getPosition(L, 2); - bool extended = getBoolean(L, 3, false); - bool force = getBoolean(L, 4, false); + const bool extended = getBoolean(L, 3, false); + const bool force = getBoolean(L, 4, false); if (g_game().placeCreature(monster, position, extended, force)) { g_events().eventMonsterOnSpawn(monster, position); g_callbacks().executeCallback(EventCallback_t::monsterOnSpawn, &EventCallback::monsterOnSpawn, monster, position); @@ -471,7 +470,7 @@ int GameFunctions::luaGameCreateMonster(lua_State* L) { int GameFunctions::luaGameGenerateNpc(lua_State* L) { // Game.generateNpc(npcName) - std::shared_ptr<Npc> npc = Npc::createNpc(getString(L, 1)); + const auto &npc = Npc::createNpc(getString(L, 1)); if (!npc) { lua_pushnil(L); return 1; @@ -484,15 +483,15 @@ int GameFunctions::luaGameGenerateNpc(lua_State* L) { int GameFunctions::luaGameCreateNpc(lua_State* L) { // Game.createNpc(npcName, position[, extended = false[, force = false]]) - std::shared_ptr<Npc> npc = Npc::createNpc(getString(L, 1)); + const auto &npc = Npc::createNpc(getString(L, 1)); if (!npc) { lua_pushnil(L); return 1; } const Position &position = getPosition(L, 2); - bool extended = getBoolean(L, 3, false); - bool force = getBoolean(L, 4, false); + const bool extended = getBoolean(L, 3, false); + const bool force = getBoolean(L, 4, false); if (g_game().placeCreature(npc, position, extended, force)) { pushUserdata<Npc>(L, npc); setMetatable(L, -1, "Npc"); @@ -538,7 +537,7 @@ int GameFunctions::luaGameGetBestiaryCharm(lua_State* L) { int GameFunctions::luaGameCreateBestiaryCharm(lua_State* L) { // Game.createBestiaryCharm(id) - if (const std::shared_ptr<Charm> charm = g_iobestiary().getBestiaryCharm(static_cast<charmRune_t>(getNumber<int8_t>(L, 1, 0)), true)) { + if (const std::shared_ptr<Charm> &charm = g_iobestiary().getBestiaryCharm(static_cast<charmRune_t>(getNumber<int8_t>(L, 1, 0)), true)) { pushUserdata<Charm>(L, charm); setMetatable(L, -1, "Charm"); } else { @@ -563,7 +562,7 @@ int GameFunctions::luaGameStartRaid(lua_State* L) { // Game.startRaid(raidName) const std::string &raidName = getString(L, 1); - const auto raid = g_game().raids.getRaidByName(raidName); + const auto &raid = g_game().raids.getRaidByName(raidName); if (!raid || !raid->isLoaded()) { lua_pushnumber(L, RETURNVALUE_NOSUCHRAIDEXISTS); return 1; @@ -585,41 +584,41 @@ int GameFunctions::luaGameGetClientVersion(lua_State* L) { lua_createtable(L, 0, 3); setField(L, "min", CLIENT_VERSION); setField(L, "max", CLIENT_VERSION); - std::string version = fmt::format("{}.{}", CLIENT_VERSION_UPPER, CLIENT_VERSION_LOWER); + const std::string version = fmt::format("{}.{}", CLIENT_VERSION_UPPER, CLIENT_VERSION_LOWER); setField(L, "string", version); return 1; } int GameFunctions::luaGameReload(lua_State* L) { // Game.reload(reloadType) - Reload_t reloadType = getNumber<Reload_t>(L, 1); - if (g_gameReload().getReloadNumber(reloadType) == g_gameReload().getReloadNumber(Reload_t::RELOAD_TYPE_NONE)) { + const Reload_t reloadType = getNumber<Reload_t>(L, 1); + if (GameReload::getReloadNumber(reloadType) == GameReload::getReloadNumber(Reload_t::RELOAD_TYPE_NONE)) { reportErrorFunc("Reload type is none"); pushBoolean(L, false); return 0; } - if (g_gameReload().getReloadNumber(reloadType) >= g_gameReload().getReloadNumber(Reload_t::RELOAD_TYPE_LAST)) { + if (GameReload::getReloadNumber(reloadType) >= GameReload::getReloadNumber(Reload_t::RELOAD_TYPE_LAST)) { reportErrorFunc("Reload type not exist"); pushBoolean(L, false); return 0; } - pushBoolean(L, g_gameReload().init(reloadType)); + pushBoolean(L, GameReload::init(reloadType)); lua_gc(g_luaEnvironment().getLuaState(), LUA_GCCOLLECT, 0); return 1; } int GameFunctions::luaGameHasEffect(lua_State* L) { // Game.hasEffect(effectId) - uint16_t effectId = getNumber<uint16_t>(L, 1); + const uint16_t effectId = getNumber<uint16_t>(L, 1); pushBoolean(L, g_game().hasEffect(effectId)); return 1; } int GameFunctions::luaGameHasDistanceEffect(lua_State* L) { // Game.hasDistanceEffect(effectId) - uint16_t effectId = getNumber<uint16_t>(L, 1); + const uint16_t effectId = getNumber<uint16_t>(L, 1); pushBoolean(L, g_game().hasDistanceEffect(effectId)); return 1; } @@ -628,14 +627,14 @@ int GameFunctions::luaGameGetOfflinePlayer(lua_State* L) { // Game.getOfflinePlayer(name or id) std::shared_ptr<Player> player = nullptr; if (isNumber(L, 1)) { - uint32_t id = getNumber<uint32_t>(L, 1); + const uint32_t id = getNumber<uint32_t>(L, 1); if (id >= Player::getFirstID() && id <= Player::getLastID()) { player = g_game().getPlayerByID(id, true); } else { player = g_game().getPlayerByGUID(id, true); } } else if (isString(L, 1)) { - auto name = getString(L, 1); + const auto name = getString(L, 1); player = g_game().getPlayerByName(name, true); } if (!player) { @@ -650,9 +649,9 @@ int GameFunctions::luaGameGetOfflinePlayer(lua_State* L) { int GameFunctions::luaGameGetNormalizedPlayerName(lua_State* L) { // Game.getNormalizedPlayerName(name[, isNewName = false]) - auto name = getString(L, 1); - auto isNewName = getBoolean(L, 2, false); - std::shared_ptr<Player> player = g_game().getPlayerByName(name, true, isNewName); + const auto name = getString(L, 1); + const auto isNewName = getBoolean(L, 2, false); + const auto &player = g_game().getPlayerByName(name, true, isNewName); if (player) { pushString(L, player->getName()); } else { @@ -663,8 +662,8 @@ int GameFunctions::luaGameGetNormalizedPlayerName(lua_State* L) { int GameFunctions::luaGameGetNormalizedGuildName(lua_State* L) { // Game.getNormalizedGuildName(name) - auto name = getString(L, 1); - const auto guild = g_game().getGuildByName(name, true); + const auto name = getString(L, 1); + const auto &guild = g_game().getGuildByName(name, true); if (guild) { pushString(L, guild->getName()); } else { @@ -675,7 +674,7 @@ int GameFunctions::luaGameGetNormalizedGuildName(lua_State* L) { int GameFunctions::luaGameAddInfluencedMonster(lua_State* L) { // Game.addInfluencedMonster(monster) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -688,15 +687,15 @@ int GameFunctions::luaGameAddInfluencedMonster(lua_State* L) { int GameFunctions::luaGameRemoveInfluencedMonster(lua_State* L) { // Game.removeInfluencedMonster(monsterId) - uint32_t monsterId = getNumber<uint32_t>(L, 1); - auto create = getBoolean(L, 2, false); + const uint32_t monsterId = getNumber<uint32_t>(L, 1); + const auto create = getBoolean(L, 2, false); lua_pushnumber(L, g_game().removeInfluencedMonster(monsterId, create)); return 1; } int GameFunctions::luaGameGetInfluencedMonsters(lua_State* L) { // Game.getInfluencedMonsters() - const auto monsters = g_game().getInfluencedMonsters(); + const auto &monsters = g_game().getInfluencedMonsters(); lua_createtable(L, static_cast<int>(monsters.size()), 0); int index = 0; for (const auto monsterId : monsters) { @@ -713,7 +712,7 @@ int GameFunctions::luaGameGetLadderIds(lua_State* L) { const auto &ladders = Item::items.getLadders(); lua_createtable(L, static_cast<int>(ladders.size()), 0); int index = 0; - for (const auto ladderId : ladders) { + for (const auto &ladderId : ladders) { ++index; lua_pushnumber(L, static_cast<lua_Number>(ladderId)); lua_rawseti(L, -2, index); @@ -743,23 +742,23 @@ int GameFunctions::luaGameGetDummies(lua_State* L) { int GameFunctions::luaGameMakeFiendishMonster(lua_State* L) { // Game.makeFiendishMonster(monsterId[default= 0]) - uint32_t monsterId = getNumber<uint32_t>(L, 1, 0); - auto createForgeableMonsters = getBoolean(L, 2, false); + const auto monsterId = getNumber<uint32_t>(L, 1, 0); + const auto createForgeableMonsters = getBoolean(L, 2, false); lua_pushnumber(L, g_game().makeFiendishMonster(monsterId, createForgeableMonsters)); return 1; } int GameFunctions::luaGameRemoveFiendishMonster(lua_State* L) { // Game.removeFiendishMonster(monsterId) - uint32_t monsterId = getNumber<uint32_t>(L, 1); - auto create = getBoolean(L, 2, false); + const uint32_t monsterId = getNumber<uint32_t>(L, 1); + const auto create = getBoolean(L, 2, false); lua_pushnumber(L, g_game().removeFiendishMonster(monsterId, create)); return 1; } int GameFunctions::luaGameGetFiendishMonsters(lua_State* L) { // Game.getFiendishMonsters() - const auto monsters = g_game().getFiendishMonsters(); + const auto &monsters = g_game().getFiendishMonsters(); lua_createtable(L, static_cast<int>(monsters.size()), 0); int index = 0; @@ -794,7 +793,7 @@ int GameFunctions::luaGameGetTalkActions(lua_State* L) { int GameFunctions::luaGameGetEventCallbacks(lua_State* L) { lua_createtable(L, 0, 0); lua_pushcfunction(L, EventCallbackFunctions::luaEventCallbackLoad); - for (auto [value, name] : magic_enum::enum_entries<EventCallback_t>()) { + for (const auto &[value, name] : magic_enum::enum_entries<EventCallback_t>()) { if (value != EventCallback_t::none) { std::string methodName = magic_enum::enum_name(value).data(); lua_pushstring(L, methodName.c_str()); @@ -815,12 +814,12 @@ int GameFunctions::luaGameRegisterAchievement(lua_State* L) { return 1; } - uint16_t id = getNumber<uint16_t>(L, 1); - std::string name = getString(L, 2); - std::string description = getString(L, 3); - bool secret = getBoolean(L, 4); - uint8_t grade = getNumber<uint8_t>(L, 5); - uint8_t points = getNumber<uint8_t>(L, 6); + const uint16_t id = getNumber<uint16_t>(L, 1); + const std::string name = getString(L, 2); + const std::string description = getString(L, 3); + const bool secret = getBoolean(L, 4); + const uint8_t grade = getNumber<uint8_t>(L, 5); + const uint8_t points = getNumber<uint8_t>(L, 6); g_game().registerAchievement(id, name, description, secret, grade, points); pushBoolean(L, true); return 1; @@ -828,8 +827,8 @@ int GameFunctions::luaGameRegisterAchievement(lua_State* L) { int GameFunctions::luaGameGetAchievementInfoById(lua_State* L) { // Game.getAchievementInfoById(id) - uint16_t id = getNumber<uint16_t>(L, 1); - Achievement achievement = g_game().getAchievementById(id); + const uint16_t id = getNumber<uint16_t>(L, 1); + const Achievement achievement = g_game().getAchievementById(id); if (achievement.id == 0) { reportErrorFunc("Achievement id is wrong"); return 1; @@ -847,8 +846,8 @@ int GameFunctions::luaGameGetAchievementInfoById(lua_State* L) { int GameFunctions::luaGameGetAchievementInfoByName(lua_State* L) { // Game.getAchievementInfoByName(name) - std::string name = getString(L, 1); - Achievement achievement = g_game().getAchievementByName(name); + const std::string name = getString(L, 1); + const Achievement achievement = g_game().getAchievementByName(name); if (achievement.id == 0) { reportErrorFunc("Achievement name is wrong"); return 1; diff --git a/src/lua/functions/core/game/game_functions.hpp b/src/lua/functions/core/game/game_functions.hpp index 70e81061c9c..3c668c54fb4 100644 --- a/src/lua/functions/core/game/game_functions.hpp +++ b/src/lua/functions/core/game/game_functions.hpp @@ -13,6 +13,12 @@ class GameFunctions final : LuaScriptInterface { public: + explicit GameFunctions(lua_State* L) : + LuaScriptInterface("GameFunctions") { + init(L); + } + ~GameFunctions() override = default; + static void init(lua_State* L) { registerTable(L, "Game"); diff --git a/src/lua/functions/core/game/global_functions.cpp b/src/lua/functions/core/game/global_functions.cpp index 958c6deb881..5681dd5d0c9 100644 --- a/src/lua/functions/core/game/global_functions.cpp +++ b/src/lua/functions/core/game/global_functions.cpp @@ -23,22 +23,22 @@ class Creature; int GlobalFunctions::luaDoPlayerAddItem(lua_State* L) { // doPlayerAddItem(cid, itemid, <optional: default: 1> count/subtype, <optional: default: 1> canDropOnMap) // doPlayerAddItem(cid, itemid, <optional: default: 1> count, <optional: default: 1> canDropOnMap, <optional: default: 1>subtype) - std::shared_ptr<Player> player = getPlayer(L, 1); + const auto &player = getPlayer(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 1; } - uint16_t itemId = getNumber<uint16_t>(L, 2); - int32_t count = getNumber<int32_t>(L, 3, 1); - bool canDropOnMap = getBoolean(L, 4, true); - uint16_t subType = getNumber<uint16_t>(L, 5, 1); + const uint16_t itemId = getNumber<uint16_t>(L, 2); + const auto count = getNumber<int32_t>(L, 3, 1); + const bool canDropOnMap = getBoolean(L, 4, true); + auto subType = getNumber<uint16_t>(L, 5, 1); const ItemType &it = Item::items[itemId]; int32_t itemCount; - auto parameters = lua_gettop(L); + const auto parameters = lua_gettop(L); if (parameters > 4) { // subtype already supplied, count then is the amount itemCount = std::max<int32_t>(1, count); @@ -59,7 +59,7 @@ int GlobalFunctions::luaDoPlayerAddItem(lua_State* L) { stackCount = it.stackSize; } - std::shared_ptr<Item> newItem = Item::CreateItem(itemId, stackCount); + const auto &newItem = Item::CreateItem(itemId, stackCount); if (!newItem) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -78,7 +78,7 @@ int GlobalFunctions::luaDoPlayerAddItem(lua_State* L) { if (--itemCount == 0) { if (newItem->getParent()) { - uint32_t uid = getScriptEnv()->addThing(newItem); + const uint32_t uid = getScriptEnv()->addThing(newItem); lua_pushnumber(L, uid); return 1; } else { @@ -101,7 +101,7 @@ int GlobalFunctions::luaIsValidUID(lua_State* L) { int GlobalFunctions::luaIsDepot(lua_State* L) { // isDepot(uid) - std::shared_ptr<Container> container = getScriptEnv()->getContainerByUID(getNumber<uint32_t>(L, -1)); + const auto &container = getScriptEnv()->getContainerByUID(getNumber<uint32_t>(L, -1)); pushBoolean(L, container && container->getDepotLocker()); return 1; } @@ -109,29 +109,29 @@ int GlobalFunctions::luaIsDepot(lua_State* L) { int GlobalFunctions::luaIsMovable(lua_State* L) { // isMovable(uid) // isMovable(uid) - std::shared_ptr<Thing> thing = getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)); + const auto &thing = getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)); pushBoolean(L, thing && thing->isPushable()); return 1; } int GlobalFunctions::luaDoAddContainerItem(lua_State* L) { // doAddContainerItem(uid, itemid, <optional> count/subtype) - uint32_t uid = getNumber<uint32_t>(L, 1); + const uint32_t uid = getNumber<uint32_t>(L, 1); ScriptEnvironment* env = getScriptEnv(); - std::shared_ptr<Container> container = env->getContainerByUID(uid); + const auto &container = env->getContainerByUID(uid); if (!container) { reportErrorFunc(getErrorDesc(LUA_ERROR_CONTAINER_NOT_FOUND)); pushBoolean(L, false); return 1; } - uint16_t itemId = getNumber<uint16_t>(L, 2); + const uint16_t itemId = getNumber<uint16_t>(L, 2); const ItemType &it = Item::items[itemId]; int32_t itemCount = 1; int32_t subType = 1; - uint32_t count = getNumber<uint32_t>(L, 3, 1); + const auto count = getNumber<uint32_t>(L, 3, 1); if (it.hasSubType()) { if (it.stackable) { @@ -144,8 +144,8 @@ int GlobalFunctions::luaDoAddContainerItem(lua_State* L) { } while (itemCount > 0) { - int32_t stackCount = std::min<int32_t>(it.stackSize, subType); - std::shared_ptr<Item> newItem = Item::CreateItem(itemId, stackCount); + const int32_t stackCount = std::min<int32_t>(it.stackSize, subType); + const auto &newItem = Item::CreateItem(itemId, stackCount); if (!newItem) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -179,16 +179,16 @@ int GlobalFunctions::luaDoAddContainerItem(lua_State* L) { int GlobalFunctions::luaGetDepotId(lua_State* L) { // getDepotId(uid) - uint32_t uid = getNumber<uint32_t>(L, -1); + const uint32_t uid = getNumber<uint32_t>(L, -1); - std::shared_ptr<Container> container = getScriptEnv()->getContainerByUID(uid); + const auto &container = getScriptEnv()->getContainerByUID(uid); if (!container) { reportErrorFunc(getErrorDesc(LUA_ERROR_CONTAINER_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<DepotLocker> depotLocker = container->getDepotLocker(); + const auto &depotLocker = container->getDepotLocker(); if (!depotLocker) { reportErrorFunc("Depot not found"); pushBoolean(L, false); @@ -201,14 +201,14 @@ int GlobalFunctions::luaGetDepotId(lua_State* L) { int GlobalFunctions::luaGetWorldTime(lua_State* L) { // getWorldTime() - uint32_t time = g_game().getLightHour(); + const uint32_t time = g_game().getLightHour(); lua_pushnumber(L, time); return 1; } int GlobalFunctions::luaGetWorldLight(lua_State* L) { // getWorldLight() - LightInfo lightInfo = g_game().getWorldLightInfo(); + const LightInfo lightInfo = g_game().getWorldLightInfo(); lua_pushnumber(L, lightInfo.level); lua_pushnumber(L, lightInfo.color); return 2; @@ -216,24 +216,24 @@ int GlobalFunctions::luaGetWorldLight(lua_State* L) { int GlobalFunctions::luaGetWorldUpTime(lua_State* L) { // getWorldUpTime() - uint64_t uptime = (OTSYS_TIME(true) - ProtocolStatus::start) / 1000; + const uint64_t uptime = (OTSYS_TIME(true) - ProtocolStatus::start) / 1000; lua_pushnumber(L, uptime); return 1; } int GlobalFunctions::luaCreateCombatArea(lua_State* L) { // createCombatArea( {area}, <optional> {extArea} ) - ScriptEnvironment* env = getScriptEnv(); + const ScriptEnvironment* env = getScriptEnv(); if (env->getScriptId() != EVENT_ID_LOADING) { reportErrorFunc("This function can only be used while loading the script."); pushBoolean(L, false); return 1; } - uint32_t areaId = g_luaEnvironment().createAreaObject(env->getScriptInterface()); + const uint32_t areaId = g_luaEnvironment().createAreaObject(env->getScriptInterface()); const auto &area = g_luaEnvironment().getAreaObject(areaId); - int parameters = lua_gettop(L); + const int parameters = lua_gettop(L); if (parameters >= 2) { uint32_t rowsExtArea; std::list<uint32_t> listExtArea; @@ -260,17 +260,17 @@ int GlobalFunctions::luaCreateCombatArea(lua_State* L) { int GlobalFunctions::luaDoAreaCombatHealth(lua_State* L) { // doAreaCombatHealth(cid, type, pos, area, min, max, effect[, origin = ORIGIN_SPELL]) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - uint32_t areaId = getNumber<uint32_t>(L, 4); + const uint32_t areaId = getNumber<uint32_t>(L, 4); const auto &area = g_luaEnvironment().getAreaObject(areaId); if (area || areaId == 0) { - CombatType_t combatType = getNumber<CombatType_t>(L, 2); + const CombatType_t combatType = getNumber<CombatType_t>(L, 2); CombatParams params; params.combatType = combatType; @@ -284,7 +284,7 @@ int GlobalFunctions::luaDoAreaCombatHealth(lua_State* L) { damage.instantSpellName = getString(L, 9); damage.runeSpellName = getString(L, 10); if (creature) { - if (auto player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->wheel()->getCombatDataSpell(damage); } } @@ -300,21 +300,21 @@ int GlobalFunctions::luaDoAreaCombatHealth(lua_State* L) { int GlobalFunctions::luaDoTargetCombatHealth(lua_State* L) { // doTargetCombatHealth(cid, target, type, min, max, effect[, origin = ORIGIN_SPELL]) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Creature> target = getCreature(L, 2); + const auto &target = getCreature(L, 2); if (!target) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - CombatType_t combatType = getNumber<CombatType_t>(L, 3); + const CombatType_t combatType = getNumber<CombatType_t>(L, 3); CombatParams params; params.combatType = combatType; @@ -328,7 +328,7 @@ int GlobalFunctions::luaDoTargetCombatHealth(lua_State* L) { damage.instantSpellName = getString(L, 9); damage.runeSpellName = getString(L, 10); if (creature) { - if (auto player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->wheel()->getCombatDataSpell(damage); } } @@ -345,14 +345,14 @@ int GlobalFunctions::luaDoTargetCombatHealth(lua_State* L) { int GlobalFunctions::luaDoAreaCombatMana(lua_State* L) { // doAreaCombatMana(cid, pos, area, min, max, effect[, origin = ORIGIN_SPELL]) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - uint32_t areaId = getNumber<uint32_t>(L, 3); + const uint32_t areaId = getNumber<uint32_t>(L, 3); const auto &area = g_luaEnvironment().getAreaObject(areaId); if (area || areaId == 0) { CombatParams params; @@ -366,12 +366,12 @@ int GlobalFunctions::luaDoAreaCombatMana(lua_State* L) { damage.instantSpellName = getString(L, 8); damage.runeSpellName = getString(L, 9); if (creature) { - if (auto player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->wheel()->getCombatDataSpell(damage); } } - Position pos = getPosition(L, 2); + const Position pos = getPosition(L, 2); Combat::doCombatMana(creature, pos, area, damage, params); pushBoolean(L, true); } else { @@ -383,14 +383,14 @@ int GlobalFunctions::luaDoAreaCombatMana(lua_State* L) { int GlobalFunctions::luaDoTargetCombatMana(lua_State* L) { // doTargetCombatMana(cid, target, min, max, effect[, origin = ORIGIN_SPELL) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Creature> target = getCreature(L, 2); + const auto &target = getCreature(L, 2); if (!target) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -398,8 +398,8 @@ int GlobalFunctions::luaDoTargetCombatMana(lua_State* L) { } CombatParams params; - auto minval = getNumber<int32_t>(L, 3); - auto maxval = getNumber<int32_t>(L, 4); + const auto minval = getNumber<int32_t>(L, 3); + const auto maxval = getNumber<int32_t>(L, 4); params.aggressive = minval + maxval < 0; params.impactEffect = getNumber<uint16_t>(L, 5); @@ -411,7 +411,7 @@ int GlobalFunctions::luaDoTargetCombatMana(lua_State* L) { damage.instantSpellName = getString(L, 7); damage.runeSpellName = getString(L, 8); if (creature) { - if (auto player = creature->getPlayer()) { + if (const auto &player = creature->getPlayer()) { player->wheel()->getCombatDataSpell(damage); } } @@ -423,21 +423,21 @@ int GlobalFunctions::luaDoTargetCombatMana(lua_State* L) { int GlobalFunctions::luaDoAreaCombatCondition(lua_State* L) { // doAreaCombatCondition(cid, pos, area, condition, effect) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - const std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 4); + const auto &condition = getUserdataShared<Condition>(L, 4); if (!condition) { reportErrorFunc(getErrorDesc(LUA_ERROR_CONDITION_NOT_FOUND)); pushBoolean(L, false); return 1; } - uint32_t areaId = getNumber<uint32_t>(L, 3); + const uint32_t areaId = getNumber<uint32_t>(L, 3); const auto &area = g_luaEnvironment().getAreaObject(areaId); if (area || areaId == 0) { CombatParams params; @@ -454,21 +454,21 @@ int GlobalFunctions::luaDoAreaCombatCondition(lua_State* L) { int GlobalFunctions::luaDoTargetCombatCondition(lua_State* L) { // doTargetCombatCondition(cid, target, condition, effect) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Creature> target = getCreature(L, 2); + const auto &target = getCreature(L, 2); if (!target) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - const std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 3); + const auto &condition = getUserdataShared<Condition>(L, 3); if (!condition) { reportErrorFunc(getErrorDesc(LUA_ERROR_CONDITION_NOT_FOUND)); pushBoolean(L, false); @@ -485,14 +485,14 @@ int GlobalFunctions::luaDoTargetCombatCondition(lua_State* L) { int GlobalFunctions::luaDoAreaCombatDispel(lua_State* L) { // doAreaCombatDispel(cid, pos, area, type, effect) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - uint32_t areaId = getNumber<uint32_t>(L, 3); + const uint32_t areaId = getNumber<uint32_t>(L, 3); const auto &area = g_luaEnvironment().getAreaObject(areaId); if (area || areaId == 0) { CombatParams params; @@ -510,14 +510,14 @@ int GlobalFunctions::luaDoAreaCombatDispel(lua_State* L) { int GlobalFunctions::luaDoTargetCombatDispel(lua_State* L) { // doTargetCombatDispel(cid, target, type, effect) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature && (!isNumber(L, 1) || getNumber<uint32_t>(L, 1) != 0)) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Creature> target = getCreature(L, 2); + const auto &target = getCreature(L, 2); if (!target) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -534,21 +534,21 @@ int GlobalFunctions::luaDoTargetCombatDispel(lua_State* L) { int GlobalFunctions::luaDoChallengeCreature(lua_State* L) { // doChallengeCreature(cid, target, targetChangeCooldown) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Creature> target = getCreature(L, 2); + const auto &target = getCreature(L, 2); if (!target) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - int targetChangeCooldown = getNumber<int32_t>(L, 3, 6000); + const int targetChangeCooldown = getNumber<int32_t>(L, 3, 6000); // This function must be defined to take and handle the targetChangeCooldown. target->challengeCreature(creature, targetChangeCooldown); @@ -567,7 +567,7 @@ int GlobalFunctions::luaAddEvent(lua_State* L) { lua_xmove(L, globalState, lua_gettop(L)); } - int parameters = lua_gettop(globalState); + const int parameters = lua_gettop(globalState); if (!isFunction(globalState, -parameters)) { // -parameters means the first parameter from left to right reportErrorFunc("callback parameter should be a function."); pushBoolean(L, false); @@ -584,7 +584,7 @@ int GlobalFunctions::luaAddEvent(lua_State* L) { LuaData_t type = getNumber<LuaData_t>(L, -1); if (type != LuaData_t::Unknown && type <= LuaData_t::Npc) { - indexes.push_back({ i, type }); + indexes.emplace_back(i, type); } lua_pop(globalState, 2); } @@ -653,7 +653,7 @@ int GlobalFunctions::luaAddEvent(lua_State* L) { eventDesc.parameters.push_back(luaL_ref(globalState, LUA_REGISTRYINDEX)); } - uint32_t delay = std::max<uint32_t>(100, getNumber<uint32_t>(globalState, 2)); + const uint32_t delay = std::max<uint32_t>(100, getNumber<uint32_t>(globalState, 2)); lua_pop(globalState, 1); eventDesc.function = luaL_ref(globalState, LUA_REGISTRYINDEX); @@ -667,7 +667,7 @@ int GlobalFunctions::luaAddEvent(lua_State* L) { "LuaEnvironment::executeTimerEvent" ); - g_luaEnvironment().timerEvents.emplace(lastTimerEventId, std::move(eventDesc)); + g_luaEnvironment().timerEvents.try_emplace(lastTimerEventId, std::move(eventDesc)); lua_pushnumber(L, lastTimerEventId++); return 1; } @@ -681,22 +681,22 @@ int GlobalFunctions::luaStopEvent(lua_State* L) { return 1; } - uint32_t eventId = getNumber<uint32_t>(L, 1); + const uint32_t eventId = getNumber<uint32_t>(L, 1); auto &timerEvents = g_luaEnvironment().timerEvents; - auto it = timerEvents.find(eventId); + const auto it = timerEvents.find(eventId); if (it == timerEvents.end()) { pushBoolean(L, false); return 1; } - LuaTimerEventDesc timerEventDesc = std::move(it->second); + const LuaTimerEventDesc timerEventDesc = std::move(it->second); timerEvents.erase(it); g_dispatcher().stopEvent(timerEventDesc.eventId); luaL_unref(globalState, LUA_REGISTRYINDEX, timerEventDesc.function); - for (auto parameter : timerEventDesc.parameters) { + for (const auto parameter : timerEventDesc.parameters) { luaL_unref(globalState, LUA_REGISTRYINDEX, parameter); } @@ -746,7 +746,7 @@ int GlobalFunctions::luaGetWaypointPositionByName(lua_State* L) { // getWaypointPositionByName(name) auto &waypoints = g_game().map.waypoints; - auto it = waypoints.find(getString(L, -1)); + const auto it = waypoints.find(getString(L, -1)); if (it != waypoints.end()) { pushPosition(L, it->second); } else { @@ -757,15 +757,15 @@ int GlobalFunctions::luaGetWaypointPositionByName(lua_State* L) { int GlobalFunctions::luaSendChannelMessage(lua_State* L) { // sendChannelMessage(channelId, type, message) - uint16_t channelId = getNumber<uint16_t>(L, 1); + const uint16_t channelId = getNumber<uint16_t>(L, 1); const auto &channel = g_chat().getChannelById(channelId); if (!channel) { pushBoolean(L, false); return 1; } - SpeakClasses type = getNumber<SpeakClasses>(L, 2); - std::string message = getString(L, 3); + const SpeakClasses type = getNumber<SpeakClasses>(L, 2); + const std::string message = getString(L, 3); channel->sendToAll(message, type); pushBoolean(L, true); return 1; @@ -773,15 +773,15 @@ int GlobalFunctions::luaSendChannelMessage(lua_State* L) { int GlobalFunctions::luaSendGuildChannelMessage(lua_State* L) { // sendGuildChannelMessage(guildId, type, message) - uint32_t guildId = getNumber<uint32_t>(L, 1); + const uint32_t guildId = getNumber<uint32_t>(L, 1); const auto &channel = g_chat().getGuildChannelById(guildId); if (!channel) { pushBoolean(L, false); return 1; } - SpeakClasses type = getNumber<SpeakClasses>(L, 2); - std::string message = getString(L, 3); + const SpeakClasses type = getNumber<SpeakClasses>(L, 2); + const std::string message = getString(L, 3); channel->sendToAll(message, type); pushBoolean(L, true); return 1; @@ -793,20 +793,20 @@ int GlobalFunctions::luaIsType(lua_State* L) { lua_getmetatable(L, -2); lua_rawgeti(L, -2, 'p'); - uint_fast8_t parentsB = getNumber<uint_fast8_t>(L, 1); + const uint_fast8_t parentsB = getNumber<uint_fast8_t>(L, 1); lua_rawgeti(L, -3, 'h'); - size_t hashB = getNumber<size_t>(L, 1); + const size_t hashB = getNumber<size_t>(L, 1); lua_rawgeti(L, -3, 'p'); - uint_fast8_t parentsA = getNumber<uint_fast8_t>(L, 1); + const uint_fast8_t parentsA = getNumber<uint_fast8_t>(L, 1); for (uint_fast8_t i = parentsA; i < parentsB; ++i) { lua_getfield(L, -3, "__index"); lua_replace(L, -4); } lua_rawgeti(L, -4, 'h'); - size_t hashA = getNumber<size_t>(L, 1); + const size_t hashA = getNumber<size_t>(L, 1); pushBoolean(L, hashA == hashB); return 1; @@ -832,14 +832,14 @@ int GlobalFunctions::luaSystemTime(lua_State* L) { int GlobalFunctions::luaGetFormattedTimeRemaining(lua_State* L) { // getFormattedTimeRemaining(time) - time_t time = getNumber<uint32_t>(L, 1); + const time_t time = getNumber<uint32_t>(L, 1); lua_pushstring(L, getFormattedTimeRemaining(time).c_str()); return 1; } int GlobalFunctions::luaReportError(lua_State* L) { // reportError(errorDescription) - auto errorDescription = getString(L, 1); + const auto errorDescription = getString(L, 1); reportError(__func__, errorDescription, true); return 1; } diff --git a/src/lua/functions/core/game/global_functions.hpp b/src/lua/functions/core/game/global_functions.hpp index cef752c6695..2b1e249a5fd 100644 --- a/src/lua/functions/core/game/global_functions.hpp +++ b/src/lua/functions/core/game/global_functions.hpp @@ -13,6 +13,12 @@ class GlobalFunctions final : LuaScriptInterface { public: + explicit GlobalFunctions(lua_State* L) : + LuaScriptInterface("GlobalFunctions") { + init(L); + } + ~GlobalFunctions() override = default; + static void init(lua_State* L) { lua_register(L, "addEvent", GlobalFunctions::luaAddEvent); lua_register(L, "cleanMap", GlobalFunctions::luaCleanMap); diff --git a/src/lua/functions/core/game/lua_enums.cpp b/src/lua/functions/core/game/lua_enums.cpp index a0870052f87..99696e9fb59 100644 --- a/src/lua/functions/core/game/lua_enums.cpp +++ b/src/lua/functions/core/game/lua_enums.cpp @@ -334,7 +334,7 @@ void LuaEnums::initFactionEnums(lua_State* L) { } void LuaEnums::initConditionEnums(lua_State* L) { - for (auto value : magic_enum::enum_values<ConditionType_t>()) { + for (const auto value : magic_enum::enum_values<ConditionType_t>()) { registerMagicEnum(L, value); } } @@ -840,7 +840,7 @@ void LuaEnums::initItemTypeEnums(lua_State* L) { } void LuaEnums::initFluidEnums(lua_State* L) { - for (auto value : magic_enum::enum_values<Fluids_t>()) { + for (const auto value : magic_enum::enum_values<Fluids_t>()) { registerMagicEnum(L, value); } } @@ -912,7 +912,7 @@ void LuaEnums::initItemIdEnums(lua_State* L) { } void LuaEnums::initPlayerFlagEnums(lua_State* L) { - for (auto value : magic_enum::enum_values<PlayerFlags_t>()) { + for (const auto value : magic_enum::enum_values<PlayerFlags_t>()) { registerMagicEnum(L, value); } } @@ -1202,7 +1202,7 @@ void LuaEnums::initReturnValueEnums(lua_State* L) { // Reload void LuaEnums::initReloadTypeEnums(lua_State* L) { - for (auto value : magic_enum::enum_values<Reload_t>()) { + for (const auto value : magic_enum::enum_values<Reload_t>()) { registerMagicEnum(L, value); } } @@ -1226,7 +1226,7 @@ void LuaEnums::initCreaturesEventEnums(lua_State* L) { } void LuaEnums::initForgeEnums(lua_State* L) { - for (auto value : magic_enum::enum_values<ForgeClassifications_t>()) { + for (const auto value : magic_enum::enum_values<ForgeClassifications_t>()) { registerMagicEnum(L, value); } } @@ -1240,7 +1240,7 @@ void LuaEnums::initWebhookEnums(lua_State* L) { } void LuaEnums::initBosstiaryEnums(lua_State* L) { - for (auto value : magic_enum::enum_values<BosstiaryRarity_t>()) { + for (const auto value : magic_enum::enum_values<BosstiaryRarity_t>()) { registerMagicEnum(L, value); } } @@ -1772,31 +1772,31 @@ void LuaEnums::effectsSoundEnums(lua_State* L) { void LuaEnums::initWheelEnums(lua_State* L) { std::string wheelNamespace = "WHEEL_INSTANT_"; - for (auto value : magic_enum::enum_values<WheelInstant_t>()) { + for (const auto value : magic_enum::enum_values<WheelInstant_t>()) { registerMagicEnumNamespace(L, wheelNamespace, value); } wheelNamespace = "WHEEL_STAGE_"; - for (auto value : magic_enum::enum_values<WheelStage_t>()) { + for (const auto value : magic_enum::enum_values<WheelStage_t>()) { registerMagicEnumNamespace(L, wheelNamespace, value); } wheelNamespace = "WHEEL_GRADE_"; - for (auto value : magic_enum::enum_values<WheelSpellGrade_t>()) { + for (const auto value : magic_enum::enum_values<WheelSpellGrade_t>()) { registerMagicEnumNamespace(L, wheelNamespace, value); } wheelNamespace = "WHEEL_AVATAR_SKILL_"; - for (auto value : magic_enum::enum_values<WheelAvatarSkill_t>()) { + for (const auto value : magic_enum::enum_values<WheelAvatarSkill_t>()) { registerMagicEnumNamespace(L, wheelNamespace, value); } wheelNamespace = "WHEEL_STAT_"; - for (auto value : magic_enum::enum_values<WheelStat_t>()) { + for (const auto value : magic_enum::enum_values<WheelStat_t>()) { registerMagicEnumNamespace(L, wheelNamespace, value); } wheelNamespace = "WHEEL_BOOST_"; - for (auto value : magic_enum::enum_values<WheelSpellBoost_t>()) { + for (const auto value : magic_enum::enum_values<WheelSpellBoost_t>()) { registerMagicEnumNamespace(L, wheelNamespace, value); } } diff --git a/src/lua/functions/core/game/lua_enums.hpp b/src/lua/functions/core/game/lua_enums.hpp index d14ca0ceb54..1c2fd18d755 100644 --- a/src/lua/functions/core/game/lua_enums.hpp +++ b/src/lua/functions/core/game/lua_enums.hpp @@ -15,6 +15,12 @@ class LuaEnums final : LuaScriptInterface { public: + explicit LuaEnums(lua_State* L) : + LuaScriptInterface("LuaEnums") { + init(L); + } + ~LuaEnums() override = default; + static void init(lua_State* L); private: diff --git a/src/lua/functions/core/game/modal_window_functions.hpp b/src/lua/functions/core/game/modal_window_functions.hpp index 9d6b9192026..1e2242d8570 100644 --- a/src/lua/functions/core/game/modal_window_functions.hpp +++ b/src/lua/functions/core/game/modal_window_functions.hpp @@ -13,6 +13,12 @@ class ModalWindowFunctions final : LuaScriptInterface { public: + explicit ModalWindowFunctions(lua_State* L) : + LuaScriptInterface("ModalWindowFunctions") { + init(L); + } + ~ModalWindowFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "ModalWindow", "", ModalWindowFunctions::luaModalWindowCreate); registerMetaMethod(L, "ModalWindow", "__eq", ModalWindowFunctions::luaUserdataCompare); diff --git a/src/lua/functions/core/game/zone_functions.cpp b/src/lua/functions/core/game/zone_functions.cpp index d973f1b003c..786edb43f3f 100644 --- a/src/lua/functions/core/game/zone_functions.cpp +++ b/src/lua/functions/core/game/zone_functions.cpp @@ -14,7 +14,7 @@ // Zone int ZoneFunctions::luaZoneCreate(lua_State* L) { // Zone(name) - auto name = getString(L, 2); + const auto name = getString(L, 2); auto zone = Zone::getZone(name); if (!zone) { zone = Zone::addZone(name); @@ -25,8 +25,8 @@ int ZoneFunctions::luaZoneCreate(lua_State* L) { } int ZoneFunctions::luaZoneCompare(lua_State* L) { - auto zone1 = getUserdataShared<Zone>(L, 1); - auto zone2 = getUserdataShared<Zone>(L, 2); + const auto &zone1 = getUserdataShared<Zone>(L, 1); + const auto &zone2 = getUserdataShared<Zone>(L, 2); if (!zone1) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); @@ -44,7 +44,7 @@ int ZoneFunctions::luaZoneCompare(lua_State* L) { int ZoneFunctions::luaZoneGetName(lua_State* L) { // Zone:getName() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); @@ -56,15 +56,15 @@ int ZoneFunctions::luaZoneGetName(lua_State* L) { int ZoneFunctions::luaZoneAddArea(lua_State* L) { // Zone:addArea(fromPos, toPos) - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto fromPos = getPosition(L, 2); - auto toPos = getPosition(L, 3); - auto area = Area(fromPos, toPos); + const auto fromPos = getPosition(L, 2); + const auto toPos = getPosition(L, 3); + const auto area = Area(fromPos, toPos); zone->addArea(area); pushBoolean(L, true); return 1; @@ -72,15 +72,15 @@ int ZoneFunctions::luaZoneAddArea(lua_State* L) { int ZoneFunctions::luaZoneSubtractArea(lua_State* L) { // Zone:subtractArea(fromPos, toPos) - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto fromPos = getPosition(L, 2); - auto toPos = getPosition(L, 3); - auto area = Area(fromPos, toPos); + const auto fromPos = getPosition(L, 2); + const auto toPos = getPosition(L, 3); + const auto area = Area(fromPos, toPos); zone->subtractArea(area); pushBoolean(L, true); return 1; @@ -88,7 +88,7 @@ int ZoneFunctions::luaZoneSubtractArea(lua_State* L) { int ZoneFunctions::luaZoneGetRemoveDestination(lua_State* L) { // Zone:getRemoveDestination() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); return 1; @@ -99,25 +99,25 @@ int ZoneFunctions::luaZoneGetRemoveDestination(lua_State* L) { int ZoneFunctions::luaZoneSetRemoveDestination(lua_State* L) { // Zone:setRemoveDestination(pos) - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); return 1; } - auto pos = getPosition(L, 2); + const auto pos = getPosition(L, 2); zone->setRemoveDestination(pos); return 1; } int ZoneFunctions::luaZoneGetPositions(lua_State* L) { // Zone:getPositions() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto positions = zone->getPositions(); + const auto positions = zone->getPositions(); lua_createtable(L, static_cast<int>(positions.size()), 0); int index = 0; @@ -131,17 +131,17 @@ int ZoneFunctions::luaZoneGetPositions(lua_State* L) { int ZoneFunctions::luaZoneGetCreatures(lua_State* L) { // Zone:getCreatures() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto creatures = zone->getCreatures(); + const auto &creatures = zone->getCreatures(); lua_createtable(L, static_cast<int>(creatures.size()), 0); int index = 0; - for (auto creature : creatures) { + for (const auto &creature : creatures) { index++; pushUserdata<Creature>(L, creature); setCreatureMetatable(L, -1, creature); @@ -152,17 +152,17 @@ int ZoneFunctions::luaZoneGetCreatures(lua_State* L) { int ZoneFunctions::luaZoneGetPlayers(lua_State* L) { // Zone:getPlayers() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto players = zone->getPlayers(); + const auto &players = zone->getPlayers(); lua_createtable(L, static_cast<int>(players.size()), 0); int index = 0; - for (auto player : players) { + for (const auto &player : players) { index++; pushUserdata<Player>(L, player); setMetatable(L, -1, "Player"); @@ -173,17 +173,17 @@ int ZoneFunctions::luaZoneGetPlayers(lua_State* L) { int ZoneFunctions::luaZoneGetMonsters(lua_State* L) { // Zone:getMonsters() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto monsters = zone->getMonsters(); + const auto &monsters = zone->getMonsters(); lua_createtable(L, static_cast<int>(monsters.size()), 0); int index = 0; - for (auto monster : monsters) { + for (const auto &monster : monsters) { index++; pushUserdata<Monster>(L, monster); setMetatable(L, -1, "Monster"); @@ -194,17 +194,17 @@ int ZoneFunctions::luaZoneGetMonsters(lua_State* L) { int ZoneFunctions::luaZoneGetNpcs(lua_State* L) { // Zone:getNpcs() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto npcs = zone->getNpcs(); + const auto &npcs = zone->getNpcs(); lua_createtable(L, static_cast<int>(npcs.size()), 0); int index = 0; - for (auto npc : npcs) { + for (const auto &npc : npcs) { index++; pushUserdata<Npc>(L, npc); setMetatable(L, -1, "Npc"); @@ -215,17 +215,17 @@ int ZoneFunctions::luaZoneGetNpcs(lua_State* L) { int ZoneFunctions::luaZoneGetItems(lua_State* L) { // Zone:getItems() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto items = zone->getItems(); + const auto &items = zone->getItems(); lua_createtable(L, static_cast<int>(items.size()), 0); int index = 0; - for (auto item : items) { + for (const auto &item : items) { index++; pushUserdata<Item>(L, item); setMetatable(L, -1, "Item"); @@ -236,7 +236,7 @@ int ZoneFunctions::luaZoneGetItems(lua_State* L) { int ZoneFunctions::luaZoneRemovePlayers(lua_State* L) { // Zone:removePlayers() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); @@ -249,7 +249,7 @@ int ZoneFunctions::luaZoneRemovePlayers(lua_State* L) { int ZoneFunctions::luaZoneRemoveMonsters(lua_State* L) { // Zone:removeMonsters() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); @@ -261,7 +261,7 @@ int ZoneFunctions::luaZoneRemoveMonsters(lua_State* L) { int ZoneFunctions::luaZoneRemoveNpcs(lua_State* L) { // Zone:removeNpcs() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); @@ -273,13 +273,13 @@ int ZoneFunctions::luaZoneRemoveNpcs(lua_State* L) { int ZoneFunctions::luaZoneSetMonsterVariant(lua_State* L) { // Zone:setMonsterVariant(variant) - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto variant = getString(L, 2); + const auto variant = getString(L, 2); if (variant.empty()) { pushBoolean(L, false); return 1; @@ -291,8 +291,8 @@ int ZoneFunctions::luaZoneSetMonsterVariant(lua_State* L) { int ZoneFunctions::luaZoneGetByName(lua_State* L) { // Zone.getByName(name) - auto name = getString(L, 1); - auto zone = Zone::getZone(name); + const auto name = getString(L, 1); + const auto &zone = Zone::getZone(name); if (!zone) { lua_pushnil(L); return 1; @@ -304,16 +304,16 @@ int ZoneFunctions::luaZoneGetByName(lua_State* L) { int ZoneFunctions::luaZoneGetByPosition(lua_State* L) { // Zone.getByPosition(pos) - auto pos = getPosition(L, 1); - auto tile = g_game().map.getTile(pos); + const auto pos = getPosition(L, 1); + const auto &tile = g_game().map.getTile(pos); if (!tile) { lua_pushnil(L); return 1; } int index = 0; - auto zones = tile->getZones(); + const auto &zones = tile->getZones(); lua_createtable(L, static_cast<int>(zones.size()), 0); - for (auto zone : zones) { + for (const auto &zone : zones) { index++; pushUserdata<Zone>(L, zone); setMetatable(L, -1, "Zone"); @@ -324,10 +324,10 @@ int ZoneFunctions::luaZoneGetByPosition(lua_State* L) { int ZoneFunctions::luaZoneGetAll(lua_State* L) { // Zone.getAll() - auto zones = Zone::getZones(); + const auto &zones = Zone::getZones(); lua_createtable(L, static_cast<int>(zones.size()), 0); int index = 0; - for (auto zone : zones) { + for (const auto &zone : zones) { index++; pushUserdata<Zone>(L, zone); setMetatable(L, -1, "Zone"); @@ -338,7 +338,7 @@ int ZoneFunctions::luaZoneGetAll(lua_State* L) { int ZoneFunctions::luaZoneRefresh(lua_State* L) { // Zone:refresh() - auto zone = getUserdataShared<Zone>(L, 1); + const auto &zone = getUserdataShared<Zone>(L, 1); if (!zone) { reportErrorFunc(getErrorDesc(LUA_ERROR_ZONE_NOT_FOUND)); return 1; diff --git a/src/lua/functions/core/game/zone_functions.hpp b/src/lua/functions/core/game/zone_functions.hpp index 2a3bbd0f8ea..0860595f0a8 100644 --- a/src/lua/functions/core/game/zone_functions.hpp +++ b/src/lua/functions/core/game/zone_functions.hpp @@ -6,6 +6,12 @@ class Zone; class ZoneFunctions final : LuaScriptInterface { public: + explicit ZoneFunctions(lua_State* L) : + LuaScriptInterface("ZoneFunctions") { + init(L); + } + ~ZoneFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Zone", "", ZoneFunctions::luaZoneCreate); registerMetaMethod(L, "Zone", "__eq", ZoneFunctions::luaZoneCompare); diff --git a/src/lua/functions/core/libs/bit_functions.hpp b/src/lua/functions/core/libs/bit_functions.hpp index c2143fde198..3d117e74b55 100644 --- a/src/lua/functions/core/libs/bit_functions.hpp +++ b/src/lua/functions/core/libs/bit_functions.hpp @@ -13,6 +13,12 @@ class BitFunctions final : LuaScriptInterface { public: + explicit BitFunctions(lua_State* L) : + LuaScriptInterface("BitFunctions") { + init(L); + } + ~BitFunctions() override = default; + static void init(lua_State* L) { #ifndef LUAJIT_VERSION registerTable(L, "bit"); diff --git a/src/lua/functions/core/libs/core_libs_functions.hpp b/src/lua/functions/core/libs/core_libs_functions.hpp index 614c59e6e3d..fdfa2d9de81 100644 --- a/src/lua/functions/core/libs/core_libs_functions.hpp +++ b/src/lua/functions/core/libs/core_libs_functions.hpp @@ -19,6 +19,12 @@ class CoreLibsFunctions final : LuaScriptInterface { public: + explicit CoreLibsFunctions(lua_State* L) : + LuaScriptInterface("CoreLibsFunctions") { + init(L); + } + ~CoreLibsFunctions() override = default; + static void init(lua_State* L) { BitFunctions::init(L); DBFunctions::init(L); diff --git a/src/lua/functions/core/libs/db_functions.cpp b/src/lua/functions/core/libs/db_functions.cpp index bdfbac8f501..cd6cb57b9b8 100644 --- a/src/lua/functions/core/libs/db_functions.cpp +++ b/src/lua/functions/core/libs/db_functions.cpp @@ -22,7 +22,7 @@ int DBFunctions::luaDatabaseAsyncExecute(lua_State* L) { if (lua_gettop(L) > 1) { int32_t ref = luaL_ref(L, LUA_REGISTRYINDEX); auto scriptId = getScriptEnv()->getScriptId(); - callback = [ref, scriptId](DBResult_ptr, bool success) { + callback = [ref, scriptId](const DBResult_ptr &, bool success) { lua_State* luaState = g_luaEnvironment().getLuaState(); if (!luaState) { return; @@ -35,7 +35,7 @@ int DBFunctions::luaDatabaseAsyncExecute(lua_State* L) { lua_rawgeti(luaState, LUA_REGISTRYINDEX, ref); pushBoolean(luaState, success); - auto env = getScriptEnv(); + const auto env = getScriptEnv(); env->setScriptId(scriptId, &g_luaEnvironment()); g_luaEnvironment().callFunction(1); @@ -47,7 +47,7 @@ int DBFunctions::luaDatabaseAsyncExecute(lua_State* L) { } int DBFunctions::luaDatabaseStoreQuery(lua_State* L) { - if (DBResult_ptr res = Database::getInstance().storeQuery(getString(L, -1))) { + if (const DBResult_ptr &res = Database::getInstance().storeQuery(getString(L, -1))) { lua_pushnumber(L, ScriptEnvironment::addResult(res)); } else { pushBoolean(L, false); @@ -60,7 +60,7 @@ int DBFunctions::luaDatabaseAsyncStoreQuery(lua_State* L) { if (lua_gettop(L) > 1) { int32_t ref = luaL_ref(L, LUA_REGISTRYINDEX); auto scriptId = getScriptEnv()->getScriptId(); - callback = [ref, scriptId](DBResult_ptr result, bool) { + callback = [ref, scriptId](const DBResult_ptr &result, bool) { lua_State* luaState = g_luaEnvironment().getLuaState(); if (!luaState) { return; @@ -77,7 +77,7 @@ int DBFunctions::luaDatabaseAsyncStoreQuery(lua_State* L) { } else { pushBoolean(luaState, false); } - auto env = getScriptEnv(); + const auto env = getScriptEnv(); env->setScriptId(scriptId, &g_luaEnvironment()); g_luaEnvironment().callFunction(1); @@ -94,7 +94,7 @@ int DBFunctions::luaDatabaseEscapeString(lua_State* L) { } int DBFunctions::luaDatabaseEscapeBlob(lua_State* L) { - uint32_t length = getNumber<uint32_t>(L, 2); + const uint32_t length = getNumber<uint32_t>(L, 2); pushString(L, Database::getInstance().escapeBlob(getString(L, 1).c_str(), length)); return 1; } diff --git a/src/lua/functions/core/libs/db_functions.hpp b/src/lua/functions/core/libs/db_functions.hpp index 99b69f1f7ba..6d95acdeae9 100644 --- a/src/lua/functions/core/libs/db_functions.hpp +++ b/src/lua/functions/core/libs/db_functions.hpp @@ -13,6 +13,12 @@ class DBFunctions final : LuaScriptInterface { public: + explicit DBFunctions(lua_State* L) : + LuaScriptInterface("DBFunctions") { + init(L); + } + ~DBFunctions() override = default; + static void init(lua_State* L) { registerTable(L, "db"); registerMethod(L, "db", "query", DBFunctions::luaDatabaseExecute); diff --git a/src/lua/functions/core/libs/kv_functions.cpp b/src/lua/functions/core/libs/kv_functions.cpp index 7ef21f861f7..d05624c9f41 100644 --- a/src/lua/functions/core/libs/kv_functions.cpp +++ b/src/lua/functions/core/libs/kv_functions.cpp @@ -15,17 +15,17 @@ int KVFunctions::luaKVScoped(lua_State* L) { // KV.scoped(key) | KV:scoped(key) - auto key = getString(L, -1); + const auto key = getString(L, -1); if (isUserdata(L, 1)) { - auto scopedKV = getUserdataShared<KV>(L, 1); - auto newScope = scopedKV->scoped(key); + const auto &scopedKV = getUserdataShared<KV>(L, 1); + const auto &newScope = scopedKV->scoped(key); pushUserdata<KV>(L, newScope); setMetatable(L, -1, "KV"); return 1; } - auto scopedKV = g_kv().scoped(key); + const auto &scopedKV = g_kv().scoped(key); pushUserdata<KV>(L, scopedKV); setMetatable(L, -1, "KV"); return 1; @@ -33,8 +33,8 @@ int KVFunctions::luaKVScoped(lua_State* L) { int KVFunctions::luaKVSet(lua_State* L) { // KV.set(key, value) | scopedKV:set(key, value) - auto key = getString(L, -2); - auto valueWrapper = getValueWrapper(L); + const auto key = getString(L, -2); + const auto &valueWrapper = getValueWrapper(L); if (!valueWrapper) { g_logger().warn("[{}] invalid param type", __FUNCTION__); @@ -43,7 +43,7 @@ int KVFunctions::luaKVSet(lua_State* L) { } if (isUserdata(L, 1)) { - auto scopedKV = getUserdataShared<KV>(L, 1); + const auto &scopedKV = getUserdataShared<KV>(L, 1); scopedKV->set(key, valueWrapper.value()); pushBoolean(L, true); return 1; @@ -64,7 +64,7 @@ int KVFunctions::luaKVGet(lua_State* L) { key = getString(L, -2); } if (isUserdata(L, 1)) { - auto scopedKV = getUserdataShared<KV>(L, 1); + const auto &scopedKV = getUserdataShared<KV>(L, 1); valueWrapper = scopedKV->get(key, forceLoad); } else { valueWrapper = g_kv().get(key, forceLoad); @@ -80,9 +80,9 @@ int KVFunctions::luaKVGet(lua_State* L) { int KVFunctions::luaKVRemove(lua_State* L) { // KV.remove(key) | scopedKV:remove(key) - auto key = getString(L, -1); + const auto key = getString(L, -1); if (isUserdata(L, 1)) { - auto scopedKV = getUserdataShared<KV>(L, 1); + const auto &scopedKV = getUserdataShared<KV>(L, 1); scopedKV->remove(key); } else { g_kv().remove(key); @@ -94,14 +94,14 @@ int KVFunctions::luaKVRemove(lua_State* L) { int KVFunctions::luaKVKeys(lua_State* L) { // KV.keys([prefix = ""]) | scopedKV:keys([prefix = ""]) std::unordered_set<std::string> keys; - std::string prefix = ""; + std::string prefix; if (isString(L, -1)) { prefix = getString(L, -1); } if (isUserdata(L, 1)) { - auto scopedKV = getUserdataShared<KV>(L, 1); + const auto &scopedKV = getUserdataShared<KV>(L, 1); keys = scopedKV->keys(); } else { keys = g_kv().keys(prefix); @@ -131,7 +131,7 @@ std::optional<ValueWrapper> KVFunctions::getValueWrapper(lua_State* L) { ArrayType array; for (int i = 1; i <= lua_objlen(L, -1); ++i) { lua_rawgeti(L, -1, i); - auto value = getValueWrapper(L); + const auto &value = getValueWrapper(L); if (!value) { g_logger().warn("[{}] invalid param type", __FUNCTION__); return std::nullopt; @@ -146,7 +146,7 @@ std::optional<ValueWrapper> KVFunctions::getValueWrapper(lua_State* L) { MapType map; lua_pushnil(L); while (lua_next(L, -2) != 0) { - auto value = getValueWrapper(L); + const auto &value = getValueWrapper(L); if (!value) { g_logger().warn("[{}] invalid param type", __FUNCTION__); return std::nullopt; diff --git a/src/lua/functions/core/libs/kv_functions.hpp b/src/lua/functions/core/libs/kv_functions.hpp index 919901df7f8..4ef47333f2f 100644 --- a/src/lua/functions/core/libs/kv_functions.hpp +++ b/src/lua/functions/core/libs/kv_functions.hpp @@ -27,6 +27,12 @@ struct lua_State; class KVFunctions final : LuaScriptInterface { public: + explicit KVFunctions(lua_State* L) : + LuaScriptInterface("KVFunctions") { + init(L); + } + ~KVFunctions() override = default; + static void init(lua_State* L) { registerTable(L, "kv"); registerMethod(L, "kv", "scoped", KVFunctions::luaKVScoped); diff --git a/src/lua/functions/core/libs/logger_functions.hpp b/src/lua/functions/core/libs/logger_functions.hpp index 2c4dba46cc1..fb3c265f21d 100644 --- a/src/lua/functions/core/libs/logger_functions.hpp +++ b/src/lua/functions/core/libs/logger_functions.hpp @@ -13,6 +13,12 @@ class LoggerFunctions final : public LuaScriptInterface { public: + explicit LoggerFunctions(lua_State* L) : + LuaScriptInterface("LoggerFunctions") { + init(L); + } + ~LoggerFunctions() override = default; + static void init(lua_State* L); private: diff --git a/src/lua/functions/core/libs/metrics_functions.cpp b/src/lua/functions/core/libs/metrics_functions.cpp index bcb233bb5aa..dc9368ab86d 100644 --- a/src/lua/functions/core/libs/metrics_functions.cpp +++ b/src/lua/functions/core/libs/metrics_functions.cpp @@ -18,9 +18,9 @@ void MetricsFunctions::init(lua_State* L) { // Metrics int MetricsFunctions::luaMetricsAddCounter(lua_State* L) { // metrics.addCounter(name, value, attributes) - auto name = getString(L, 1); - auto value = getNumber<double>(L, 2); - auto attributes = getAttributes(L, 3); + const auto name = getString(L, 1); + const auto value = getNumber<double>(L, 2); + const auto attributes = getAttributes(L, 3); g_metrics().addCounter(name, value, attributes); return 1; } diff --git a/src/lua/functions/core/libs/metrics_functions.hpp b/src/lua/functions/core/libs/metrics_functions.hpp index e71f005aaa8..4155646cb51 100644 --- a/src/lua/functions/core/libs/metrics_functions.hpp +++ b/src/lua/functions/core/libs/metrics_functions.hpp @@ -13,6 +13,12 @@ class MetricsFunctions final : public LuaScriptInterface { public: + explicit MetricsFunctions(lua_State* L) : + LuaScriptInterface("MetricsFunctions") { + init(L); + } + ~MetricsFunctions() override = default; + static void init(lua_State* L); private: diff --git a/src/lua/functions/core/libs/result_functions.cpp b/src/lua/functions/core/libs/result_functions.cpp index 46acc07af9f..2c55645b3b8 100644 --- a/src/lua/functions/core/libs/result_functions.cpp +++ b/src/lua/functions/core/libs/result_functions.cpp @@ -10,7 +10,7 @@ #include "lua/functions/core/libs/result_functions.hpp" int ResultFunctions::luaResultGetNumber(lua_State* L) { - DBResult_ptr res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, 1)); + const auto &res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, 1)); if (!res) { pushBoolean(L, false); return 1; @@ -22,7 +22,7 @@ int ResultFunctions::luaResultGetNumber(lua_State* L) { } int ResultFunctions::luaResultGetString(lua_State* L) { - DBResult_ptr res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, 1)); + const auto &res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, 1)); if (!res) { pushBoolean(L, false); return 1; @@ -34,7 +34,7 @@ int ResultFunctions::luaResultGetString(lua_State* L) { } int ResultFunctions::luaResultGetStream(lua_State* L) { - DBResult_ptr res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, 1)); + const auto &res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, 1)); if (!res) { pushBoolean(L, false); return 1; @@ -48,7 +48,7 @@ int ResultFunctions::luaResultGetStream(lua_State* L) { } int ResultFunctions::luaResultNext(lua_State* L) { - DBResult_ptr res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, -1)); + const auto &res = ScriptEnvironment::getResultByID(getNumber<uint32_t>(L, -1)); if (!res) { pushBoolean(L, false); return 1; diff --git a/src/lua/functions/core/libs/result_functions.hpp b/src/lua/functions/core/libs/result_functions.hpp index 4aa25173ed7..7e7f74f1add 100644 --- a/src/lua/functions/core/libs/result_functions.hpp +++ b/src/lua/functions/core/libs/result_functions.hpp @@ -13,6 +13,12 @@ class ResultFunctions final : LuaScriptInterface { public: + explicit ResultFunctions(lua_State* L) : + LuaScriptInterface("ResultFunctions") { + init(L); + } + ~ResultFunctions() override = default; + static void init(lua_State* L) { registerTable(L, "Result"); registerMethod(L, "Result", "getNumber", ResultFunctions::luaResultGetNumber); diff --git a/src/lua/functions/core/network/core_network_functions.hpp b/src/lua/functions/core/network/core_network_functions.hpp index c1e65ec15ac..8f0c3b021ef 100644 --- a/src/lua/functions/core/network/core_network_functions.hpp +++ b/src/lua/functions/core/network/core_network_functions.hpp @@ -15,6 +15,12 @@ class CoreNetworkFunctions final : LuaScriptInterface { public: + explicit CoreNetworkFunctions(lua_State* L) : + LuaScriptInterface("CoreNetworkFunctions") { + init(L); + } + ~CoreNetworkFunctions() override = default; + static void init(lua_State* L) { NetworkMessageFunctions::init(L); WebhookFunctions::init(L); diff --git a/src/lua/functions/core/network/network_message_functions.cpp b/src/lua/functions/core/network/network_message_functions.cpp index c7572b4488b..5b592db3e44 100644 --- a/src/lua/functions/core/network/network_message_functions.cpp +++ b/src/lua/functions/core/network/network_message_functions.cpp @@ -86,7 +86,7 @@ int NetworkMessageFunctions::luaNetworkMessageGetPosition(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAddByte(lua_State* L) { // networkMessage:addByte(number) - uint8_t number = getNumber<uint8_t>(L, 2); + const uint8_t number = getNumber<uint8_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->addByte(number); @@ -99,7 +99,7 @@ int NetworkMessageFunctions::luaNetworkMessageAddByte(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAddU16(lua_State* L) { // networkMessage:addU16(number) - uint16_t number = getNumber<uint16_t>(L, 2); + const uint16_t number = getNumber<uint16_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->add<uint16_t>(number); @@ -112,7 +112,7 @@ int NetworkMessageFunctions::luaNetworkMessageAddU16(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAddU32(lua_State* L) { // networkMessage:addU32(number) - uint32_t number = getNumber<uint32_t>(L, 2); + const uint32_t number = getNumber<uint32_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->add<uint32_t>(number); @@ -125,7 +125,7 @@ int NetworkMessageFunctions::luaNetworkMessageAddU32(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAddU64(lua_State* L) { // networkMessage:addU64(number) - uint64_t number = getNumber<uint64_t>(L, 2); + const uint64_t number = getNumber<uint64_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->add<uint64_t>(number); @@ -138,7 +138,7 @@ int NetworkMessageFunctions::luaNetworkMessageAddU64(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAdd8(lua_State* L) { // networkMessage:add8(number) - auto number = getNumber<int8_t>(L, 2); + const auto number = getNumber<int8_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->add<int8_t>(number); @@ -151,7 +151,7 @@ int NetworkMessageFunctions::luaNetworkMessageAdd8(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAdd16(lua_State* L) { // networkMessage:add16(number) - auto number = getNumber<int16_t>(L, 2); + const auto number = getNumber<int16_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->add<int16_t>(number); @@ -164,7 +164,7 @@ int NetworkMessageFunctions::luaNetworkMessageAdd16(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAdd32(lua_State* L) { // networkMessage:add32(number) - auto number = getNumber<int32_t>(L, 2); + const auto number = getNumber<int32_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->add<int32_t>(number); @@ -177,7 +177,7 @@ int NetworkMessageFunctions::luaNetworkMessageAdd32(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAdd64(lua_State* L) { // networkMessage:add64(number) - auto number = getNumber<int64_t>(L, 2); + const auto number = getNumber<int64_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->add<int64_t>(number); @@ -217,7 +217,7 @@ int NetworkMessageFunctions::luaNetworkMessageAddPosition(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAddDouble(lua_State* L) { // networkMessage:addDouble(number) - double number = getNumber<double>(L, 2); + const double number = getNumber<double>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->addDouble(number); @@ -230,14 +230,14 @@ int NetworkMessageFunctions::luaNetworkMessageAddDouble(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageAddItem(lua_State* L) { // networkMessage:addItem(item, player) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); + const auto &item = getUserdataShared<Item>(L, 2); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); lua_pushnil(L); return 1; } - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 3); + const auto &player = getUserdataShared<Player>(L, 3); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); lua_pushnil(L); @@ -268,7 +268,7 @@ int NetworkMessageFunctions::luaNetworkMessageReset(lua_State* L) { int NetworkMessageFunctions::luaNetworkMessageSkipBytes(lua_State* L) { // networkMessage:skipBytes(number) - int16_t number = getNumber<int16_t>(L, 2); + const int16_t number = getNumber<int16_t>(L, 2); const auto &message = getUserdataShared<NetworkMessage>(L, 1); if (message) { message->skipBytes(number); @@ -287,7 +287,7 @@ int NetworkMessageFunctions::luaNetworkMessageSendToPlayer(lua_State* L) { return 1; } - std::shared_ptr<Player> player = getPlayer(L, 2); + const auto &player = getPlayer(L, 2); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); return 1; diff --git a/src/lua/functions/core/network/network_message_functions.hpp b/src/lua/functions/core/network/network_message_functions.hpp index 5a2982c0d85..783e06aec57 100644 --- a/src/lua/functions/core/network/network_message_functions.hpp +++ b/src/lua/functions/core/network/network_message_functions.hpp @@ -13,6 +13,12 @@ class NetworkMessageFunctions final : LuaScriptInterface { public: + explicit NetworkMessageFunctions(lua_State* L) : + LuaScriptInterface("NetworkMessageFunctions") { + init(L); + } + ~NetworkMessageFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "NetworkMessage", "", NetworkMessageFunctions::luaNetworkMessageCreate); registerMetaMethod(L, "NetworkMessage", "__eq", NetworkMessageFunctions::luaUserdataCompare); diff --git a/src/lua/functions/core/network/webhook_functions.cpp b/src/lua/functions/core/network/webhook_functions.cpp index b24e6184ce3..405996c5bfa 100644 --- a/src/lua/functions/core/network/webhook_functions.cpp +++ b/src/lua/functions/core/network/webhook_functions.cpp @@ -13,10 +13,10 @@ int WebhookFunctions::luaWebhookSendMessage(lua_State* L) { // Webhook.sendMessage(title, message, color, url = "WEBHOOK_DISCORD_URL") | // Webhook.sendMessage(message, url = "WEBHOOK_DISCORD_URL") - std::string title = getString(L, 1); - std::string message = getString(L, 2); - uint32_t color = getNumber<uint32_t>(L, 3, 0); - std::string url = getString(L, -1); + const std::string title = getString(L, 1); + const std::string message = getString(L, 2); + const auto color = getNumber<uint32_t>(L, 3, 0); + const std::string url = getString(L, -1); if (url == title) { g_webhook().sendMessage(title); } else if (url == message) { diff --git a/src/lua/functions/core/network/webhook_functions.hpp b/src/lua/functions/core/network/webhook_functions.hpp index 7d5f53ba4b8..83ecb377c80 100644 --- a/src/lua/functions/core/network/webhook_functions.hpp +++ b/src/lua/functions/core/network/webhook_functions.hpp @@ -13,6 +13,12 @@ class WebhookFunctions final : LuaScriptInterface { public: + explicit WebhookFunctions(lua_State* L) : + LuaScriptInterface("WebhookFunctions") { + init(L); + } + ~WebhookFunctions() override = default; + static void init(lua_State* L) { registerTable(L, "Webhook"); registerMethod(L, "Webhook", "sendMessage", WebhookFunctions::luaWebhookSendMessage); diff --git a/src/lua/functions/creatures/combat/combat_functions.cpp b/src/lua/functions/creatures/combat/combat_functions.cpp index f073cde6aba..13bd3d83098 100644 --- a/src/lua/functions/creatures/combat/combat_functions.cpp +++ b/src/lua/functions/creatures/combat/combat_functions.cpp @@ -28,7 +28,7 @@ int CombatFunctions::luaCombatSetParameter(lua_State* L) { return 1; } - CombatParam_t key = getNumber<CombatParam_t>(L, 2); + const CombatParam_t key = getNumber<CombatParam_t>(L, 2); uint32_t value; if (isBoolean(L, 3)) { value = getBoolean(L, 3) ? 1 : 0; @@ -48,11 +48,11 @@ int CombatFunctions::luaCombatSetFormula(lua_State* L) { return 1; } - formulaType_t type = getNumber<formulaType_t>(L, 2); - double mina = getNumber<double>(L, 3); - double minb = getNumber<double>(L, 4); - double maxa = getNumber<double>(L, 5); - double maxb = getNumber<double>(L, 6); + const formulaType_t type = getNumber<formulaType_t>(L, 2); + const double mina = getNumber<double>(L, 3); + const double minb = getNumber<double>(L, 4); + const double maxa = getNumber<double>(L, 5); + const double maxb = getNumber<double>(L, 6); combat->setPlayerCombatValues(type, mina, minb, maxa, maxb); pushBoolean(L, true); return 1; @@ -86,8 +86,8 @@ int CombatFunctions::luaCombatSetArea(lua_State* L) { int CombatFunctions::luaCombatSetCondition(lua_State* L) { // combat:addCondition(condition) - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 2); - Combat* combat = getUserdata<Combat>(L, 1); + const std::shared_ptr<Condition> &condition = getUserdataShared<Condition>(L, 2); + auto* combat = getUserdata<Combat>(L, 1); if (combat && condition) { combat->addCondition(condition->clone()); pushBoolean(L, true); @@ -105,7 +105,7 @@ int CombatFunctions::luaCombatSetCallback(lua_State* L) { return 1; } - CallBackParam_t key = getNumber<CallBackParam_t>(L, 2); + const CallBackParam_t key = getNumber<CallBackParam_t>(L, 2); if (!combat->setCallback(key)) { lua_pushnil(L); return 1; @@ -143,14 +143,18 @@ int CombatFunctions::luaCombatExecute(lua_State* L) { } if (isUserdata(L, 2)) { - LuaData_t type = getUserdataType(L, 2); + const LuaData_t type = getUserdataType(L, 2); if (type != LuaData_t::Player && type != LuaData_t::Monster && type != LuaData_t::Npc) { pushBoolean(L, false); return 1; } } - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); + if (!creature) { + pushBoolean(L, false); + return 1; + } const LuaVariant &variant = getVariant(L, 3); combat->setInstantSpellName(variant.instantName); @@ -158,7 +162,7 @@ int CombatFunctions::luaCombatExecute(lua_State* L) { bool result = true; switch (variant.type) { case VARIANT_NUMBER: { - std::shared_ptr<Creature> target = g_game().getCreatureByID(variant.number); + const std::shared_ptr<Creature> &target = g_game().getCreatureByID(variant.number); if (!target) { pushBoolean(L, false); return 1; @@ -188,7 +192,7 @@ int CombatFunctions::luaCombatExecute(lua_State* L) { } case VARIANT_STRING: { - std::shared_ptr<Player> target = g_game().getPlayerByName(variant.text); + const std::shared_ptr<Player> &target = g_game().getPlayerByName(variant.text); if (!target) { pushBoolean(L, false); return 1; diff --git a/src/lua/functions/creatures/combat/combat_functions.hpp b/src/lua/functions/creatures/combat/combat_functions.hpp index e031713e98e..a24b7c63bdd 100644 --- a/src/lua/functions/creatures/combat/combat_functions.hpp +++ b/src/lua/functions/creatures/combat/combat_functions.hpp @@ -16,6 +16,12 @@ class CombatFunctions final : LuaScriptInterface { public: + explicit CombatFunctions(lua_State* L) : + LuaScriptInterface("CombatFunctions") { + init(L); + } + ~CombatFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Combat", "", CombatFunctions::luaCombatCreate); registerMetaMethod(L, "Combat", "__eq", CombatFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/combat/condition_functions.cpp b/src/lua/functions/creatures/combat/condition_functions.cpp index e7b1dd331ea..6d08dcf2e40 100644 --- a/src/lua/functions/creatures/combat/condition_functions.cpp +++ b/src/lua/functions/creatures/combat/condition_functions.cpp @@ -13,17 +13,17 @@ int ConditionFunctions::luaConditionCreate(lua_State* L) { // Condition(conditionType, conditionId = CONDITIONID_COMBAT, subid = 0, isPersistent = false) - ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); + const ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); if (conditionType == CONDITION_NONE) { reportErrorFunc("Invalid condition type"); return 1; } - ConditionId_t conditionId = getNumber<ConditionId_t>(L, 3, CONDITIONID_COMBAT); - uint32_t subId = getNumber<uint32_t>(L, 4, 0); - bool isPersistent = getBoolean(L, 5, false); + const auto conditionId = getNumber<ConditionId_t>(L, 3, CONDITIONID_COMBAT); + const auto subId = getNumber<uint32_t>(L, 4, 0); + const bool isPersistent = getBoolean(L, 5, false); - std::shared_ptr<Condition> condition = Condition::createCondition(conditionId, conditionType, 0, 0, false, subId, isPersistent); + const auto &condition = Condition::createCondition(conditionId, conditionType, 0, 0, false, subId, isPersistent); if (condition) { pushUserdata<Condition>(L, condition); setMetatable(L, -1, "Condition"); @@ -44,7 +44,7 @@ int ConditionFunctions::luaConditionDelete(lua_State* L) { int ConditionFunctions::luaConditionGetId(lua_State* L) { // condition:getId() - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { lua_pushnumber(L, condition->getId()); } else { @@ -55,7 +55,7 @@ int ConditionFunctions::luaConditionGetId(lua_State* L) { int ConditionFunctions::luaConditionGetSubId(lua_State* L) { // condition:getSubId() - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { lua_pushnumber(L, condition->getSubId()); } else { @@ -66,7 +66,7 @@ int ConditionFunctions::luaConditionGetSubId(lua_State* L) { int ConditionFunctions::luaConditionGetType(lua_State* L) { // condition:getType() - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { lua_pushnumber(L, condition->getType()); } else { @@ -77,9 +77,9 @@ int ConditionFunctions::luaConditionGetType(lua_State* L) { int ConditionFunctions::luaConditionGetIcons(lua_State* L) { // condition:getIcons() - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { - auto icons = condition->getIcons(); + const auto icons = condition->getIcons(); lua_newtable(L); // Creates a new table on the Lua stack int index = 1; for (const auto &icon : icons) { @@ -94,7 +94,7 @@ int ConditionFunctions::luaConditionGetIcons(lua_State* L) { int ConditionFunctions::luaConditionGetEndTime(lua_State* L) { // condition:getEndTime() - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { lua_pushnumber(L, condition->getEndTime()); } else { @@ -105,7 +105,7 @@ int ConditionFunctions::luaConditionGetEndTime(lua_State* L) { int ConditionFunctions::luaConditionClone(lua_State* L) { // condition:clone() - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { pushUserdata<Condition>(L, condition->clone()); setMetatable(L, -1, "Condition"); @@ -117,7 +117,7 @@ int ConditionFunctions::luaConditionClone(lua_State* L) { int ConditionFunctions::luaConditionGetTicks(lua_State* L) { // condition:getTicks() - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { lua_pushnumber(L, condition->getTicks()); } else { @@ -128,8 +128,8 @@ int ConditionFunctions::luaConditionGetTicks(lua_State* L) { int ConditionFunctions::luaConditionSetTicks(lua_State* L) { // condition:setTicks(ticks) - int32_t ticks = getNumber<int32_t>(L, 2); - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const int32_t ticks = getNumber<int32_t>(L, 2); + const auto &condition = getUserdataShared<Condition>(L, 1); if (condition) { condition->setTicks(ticks); pushBoolean(L, true); @@ -141,13 +141,13 @@ int ConditionFunctions::luaConditionSetTicks(lua_State* L) { int ConditionFunctions::luaConditionSetParameter(lua_State* L) { // condition:setParameter(key, value) - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 1); if (!condition) { lua_pushnil(L); return 1; } - ConditionParam_t key = getNumber<ConditionParam_t>(L, 2); + const ConditionParam_t key = getNumber<ConditionParam_t>(L, 2); int32_t value; if (isBoolean(L, 3)) { value = getBoolean(L, 3) ? 1 : 0; @@ -161,11 +161,11 @@ int ConditionFunctions::luaConditionSetParameter(lua_State* L) { int ConditionFunctions::luaConditionSetFormula(lua_State* L) { // condition:setFormula(mina, minb, maxa, maxb) - double maxb = getNumber<double>(L, 5); - double maxa = getNumber<double>(L, 4); - double minb = getNumber<double>(L, 3); - double mina = getNumber<double>(L, 2); - std::shared_ptr<ConditionSpeed> condition = getUserdataShared<Condition>(L, 1)->dynamic_self_cast<ConditionSpeed>(); + const double maxb = getNumber<double>(L, 5); + const double maxa = getNumber<double>(L, 4); + const double minb = getNumber<double>(L, 3); + const double mina = getNumber<double>(L, 2); + const std::shared_ptr<ConditionSpeed> &condition = getUserdataShared<Condition>(L, 1)->dynamic_self_cast<ConditionSpeed>(); if (condition) { condition->setFormulaVars(mina, minb, maxa, maxb); pushBoolean(L, true); @@ -198,7 +198,7 @@ int ConditionFunctions::luaConditionSetOutfit(lua_State* L) { outfit.lookTypeEx = getNumber<uint16_t>(L, 2); } - std::shared_ptr<ConditionOutfit> condition = getUserdataShared<Condition>(L, 1)->dynamic_self_cast<ConditionOutfit>(); + const std::shared_ptr<ConditionOutfit> &condition = getUserdataShared<Condition>(L, 1)->dynamic_self_cast<ConditionOutfit>(); if (condition) { condition->setOutfit(outfit); pushBoolean(L, true); @@ -210,10 +210,10 @@ int ConditionFunctions::luaConditionSetOutfit(lua_State* L) { int ConditionFunctions::luaConditionAddDamage(lua_State* L) { // condition:addDamage(rounds, time, value) - int32_t value = getNumber<int32_t>(L, 4); - int32_t time = getNumber<int32_t>(L, 3); - int32_t rounds = getNumber<int32_t>(L, 2); - std::shared_ptr<ConditionDamage> condition = getUserdataShared<Condition>(L, 1)->dynamic_self_cast<ConditionDamage>(); + const int32_t value = getNumber<int32_t>(L, 4); + const int32_t time = getNumber<int32_t>(L, 3); + const int32_t rounds = getNumber<int32_t>(L, 2); + const std::shared_ptr<ConditionDamage> &condition = getUserdataShared<Condition>(L, 1)->dynamic_self_cast<ConditionDamage>(); if (condition) { pushBoolean(L, condition->addDamage(rounds, time, value)); } else { diff --git a/src/lua/functions/creatures/combat/condition_functions.hpp b/src/lua/functions/creatures/combat/condition_functions.hpp index 938c5170542..931a4fc2f5e 100644 --- a/src/lua/functions/creatures/combat/condition_functions.hpp +++ b/src/lua/functions/creatures/combat/condition_functions.hpp @@ -13,6 +13,12 @@ class ConditionFunctions final : LuaScriptInterface { public: + explicit ConditionFunctions(lua_State* L) : + LuaScriptInterface("ConditionFunctions") { + init(L); + } + ~ConditionFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Condition", "", ConditionFunctions::luaConditionCreate); registerMetaMethod(L, "Condition", "__eq", ConditionFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/combat/spell_functions.cpp b/src/lua/functions/creatures/combat/spell_functions.cpp index 18fdce42fdb..d4c3c9eed8d 100644 --- a/src/lua/functions/creatures/combat/spell_functions.cpp +++ b/src/lua/functions/creatures/combat/spell_functions.cpp @@ -25,7 +25,7 @@ int SpellFunctions::luaSpellCreate(lua_State* L) { if (isNumber(L, 2)) { uint16_t id = getNumber<uint16_t>(L, 2); - std::shared_ptr<RuneSpell> rune = g_spells().getRuneSpell(id); + const auto &rune = g_spells().getRuneSpell(id); if (rune) { pushUserdata<Spell>(L, rune); @@ -35,8 +35,8 @@ int SpellFunctions::luaSpellCreate(lua_State* L) { spellType = static_cast<SpellType_t>(id); } else if (isString(L, 2)) { - std::string arg = getString(L, 2); - std::shared_ptr<InstantSpell> instant = g_spells().getInstantSpellByName(arg); + const std::string arg = getString(L, 2); + auto instant = g_spells().getInstantSpellByName(arg); if (instant) { pushUserdata<Spell>(L, instant); setMetatable(L, -1, "Spell"); @@ -48,14 +48,14 @@ int SpellFunctions::luaSpellCreate(lua_State* L) { setMetatable(L, -1, "Spell"); return 1; } - std::shared_ptr<RuneSpell> rune = g_spells().getRuneSpellByName(arg); + const auto &rune = g_spells().getRuneSpellByName(arg); if (rune) { pushUserdata<Spell>(L, rune); setMetatable(L, -1, "Spell"); return 1; } - std::string tmp = asLowerCaseString(arg); + const std::string tmp = asLowerCaseString(arg); if (tmp == "instant") { spellType = SPELL_INSTANT; } else if (tmp == "rune") { @@ -64,13 +64,13 @@ int SpellFunctions::luaSpellCreate(lua_State* L) { } if (spellType == SPELL_INSTANT) { - auto spell = std::make_shared<InstantSpell>(getScriptEnv()->getScriptInterface()); + const auto &spell = std::make_shared<InstantSpell>(getScriptEnv()->getScriptInterface()); pushUserdata<Spell>(L, spell); setMetatable(L, -1, "Spell"); spell->spellType = SPELL_INSTANT; return 1; } else if (spellType == SPELL_RUNE) { - auto runeSpell = std::make_shared<RuneSpell>(getScriptEnv()->getScriptInterface()); + const auto &runeSpell = std::make_shared<RuneSpell>(getScriptEnv()->getScriptInterface()); pushUserdata<Spell>(L, runeSpell); setMetatable(L, -1, "Spell"); runeSpell->spellType = SPELL_RUNE; @@ -83,11 +83,10 @@ int SpellFunctions::luaSpellCreate(lua_State* L) { int SpellFunctions::luaSpellOnCastSpell(lua_State* L) { // spell:onCastSpell(callback) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (spell->spellType == SPELL_INSTANT) { - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto instant = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &instant = std::static_pointer_cast<InstantSpell>(spell); if (!instant->loadCallback()) { pushBoolean(L, false); return 1; @@ -95,8 +94,7 @@ int SpellFunctions::luaSpellOnCastSpell(lua_State* L) { instant->setLoadedCallback(true); pushBoolean(L, true); } else if (spell->spellType == SPELL_RUNE) { - std::shared_ptr<Spell> spellBase = getUserdataShared<Spell>(L, 1); - std::shared_ptr<RuneSpell> rune = std::static_pointer_cast<RuneSpell>(spellBase); + const auto &rune = std::static_pointer_cast<RuneSpell>(spell); if (!rune->loadCallback()) { pushBoolean(L, false); return 1; @@ -112,7 +110,7 @@ int SpellFunctions::luaSpellOnCastSpell(lua_State* L) { int SpellFunctions::luaSpellRegister(lua_State* L) { // spell:register() - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (!spell) { reportErrorFunc(getErrorDesc(LUA_ERROR_SPELL_NOT_FOUND)); pushBoolean(L, false); @@ -120,16 +118,16 @@ int SpellFunctions::luaSpellRegister(lua_State* L) { } if (spell->spellType == SPELL_INSTANT) { - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto instant = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &instant = std::static_pointer_cast<InstantSpell>(spellBase); if (!instant->isLoadedCallback()) { pushBoolean(L, false); return 1; } pushBoolean(L, g_spells().registerInstantLuaEvent(instant)); } else if (spell->spellType == SPELL_RUNE) { - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto rune = std::static_pointer_cast<RuneSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &rune = std::static_pointer_cast<RuneSpell>(spellBase); if (rune->getMagicLevel() != 0 || rune->getLevel() != 0) { // Change information in the ItemType to get accurate description ItemType &iType = Item::items.getItemType(rune->getRuneItemId()); @@ -153,7 +151,7 @@ int SpellFunctions::luaSpellRegister(lua_State* L) { int SpellFunctions::luaSpellName(lua_State* L) { // spell:name(name) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushString(L, spell->getName()); @@ -169,7 +167,7 @@ int SpellFunctions::luaSpellName(lua_State* L) { int SpellFunctions::luaSpellId(lua_State* L) { // spell:id(id) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (spell->spellType != SPELL_INSTANT && spell->spellType != SPELL_RUNE) { reportErrorFunc("The method: 'spell:id(id)' is only for use of instant spells and rune spells"); @@ -190,14 +188,14 @@ int SpellFunctions::luaSpellId(lua_State* L) { int SpellFunctions::luaSpellGroup(lua_State* L) { // spell:group(primaryGroup[, secondaryGroup]) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getGroup()); lua_pushnumber(L, spell->getSecondaryGroup()); return 2; } else if (lua_gettop(L) == 2) { - SpellGroup_t group = getNumber<SpellGroup_t>(L, 2); + auto group = getNumber<SpellGroup_t>(L, 2); if (group) { spell->setGroup(group); pushBoolean(L, true); @@ -221,8 +219,8 @@ int SpellFunctions::luaSpellGroup(lua_State* L) { return 1; } } else { - SpellGroup_t primaryGroup = getNumber<SpellGroup_t>(L, 2); - SpellGroup_t secondaryGroup = getNumber<SpellGroup_t>(L, 2); + auto primaryGroup = getNumber<SpellGroup_t>(L, 2); + auto secondaryGroup = getNumber<SpellGroup_t>(L, 2); if (primaryGroup && secondaryGroup) { spell->setGroup(primaryGroup); spell->setSecondaryGroup(secondaryGroup); @@ -265,7 +263,7 @@ int SpellFunctions::luaSpellGroup(lua_State* L) { int SpellFunctions::luaSpellCastSound(lua_State* L) { // get: spell:castSound() set: spell:castSound(effect) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, static_cast<uint16_t>(spell->soundCastEffect)); @@ -281,7 +279,7 @@ int SpellFunctions::luaSpellCastSound(lua_State* L) { int SpellFunctions::luaSpellImpactSound(lua_State* L) { // get: spell:impactSound() set: spell:impactSound(effect) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, static_cast<uint16_t>(spell->soundImpactEffect)); @@ -297,7 +295,7 @@ int SpellFunctions::luaSpellImpactSound(lua_State* L) { int SpellFunctions::luaSpellCooldown(lua_State* L) { // spell:cooldown(cooldown) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getCooldown()); @@ -313,7 +311,7 @@ int SpellFunctions::luaSpellCooldown(lua_State* L) { int SpellFunctions::luaSpellGroupCooldown(lua_State* L) { // spell:groupCooldown(primaryGroupCd[, secondaryGroupCd]) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getGroupCooldown()); @@ -335,7 +333,7 @@ int SpellFunctions::luaSpellGroupCooldown(lua_State* L) { int SpellFunctions::luaSpellLevel(lua_State* L) { // spell:level(lvl) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getLevel()); @@ -351,7 +349,7 @@ int SpellFunctions::luaSpellLevel(lua_State* L) { int SpellFunctions::luaSpellMagicLevel(lua_State* L) { // spell:magicLevel(lvl) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getMagicLevel()); @@ -367,7 +365,7 @@ int SpellFunctions::luaSpellMagicLevel(lua_State* L) { int SpellFunctions::luaSpellMana(lua_State* L) { // spell:mana(mana) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getMana()); @@ -383,7 +381,7 @@ int SpellFunctions::luaSpellMana(lua_State* L) { int SpellFunctions::luaSpellManaPercent(lua_State* L) { // spell:manaPercent(percent) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getManaPercent()); @@ -399,7 +397,7 @@ int SpellFunctions::luaSpellManaPercent(lua_State* L) { int SpellFunctions::luaSpellSoul(lua_State* L) { // spell:soul(soul) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getSoulCost()); @@ -415,7 +413,7 @@ int SpellFunctions::luaSpellSoul(lua_State* L) { int SpellFunctions::luaSpellRange(lua_State* L) { // spell:range(range) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_pushnumber(L, spell->getRange()); @@ -431,7 +429,7 @@ int SpellFunctions::luaSpellRange(lua_State* L) { int SpellFunctions::luaSpellPremium(lua_State* L) { // spell:isPremium(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->isPremium()); @@ -447,7 +445,7 @@ int SpellFunctions::luaSpellPremium(lua_State* L) { int SpellFunctions::luaSpellEnabled(lua_State* L) { // spell:isEnabled(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->isEnabled()); @@ -463,7 +461,7 @@ int SpellFunctions::luaSpellEnabled(lua_State* L) { int SpellFunctions::luaSpellNeedTarget(lua_State* L) { // spell:needTarget(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getNeedTarget()); @@ -479,7 +477,7 @@ int SpellFunctions::luaSpellNeedTarget(lua_State* L) { int SpellFunctions::luaSpellNeedWeapon(lua_State* L) { // spell:needWeapon(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getNeedWeapon()); @@ -495,7 +493,7 @@ int SpellFunctions::luaSpellNeedWeapon(lua_State* L) { int SpellFunctions::luaSpellNeedLearn(lua_State* L) { // spell:needLearn(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getNeedLearn()); @@ -511,7 +509,7 @@ int SpellFunctions::luaSpellNeedLearn(lua_State* L) { int SpellFunctions::luaSpellSelfTarget(lua_State* L) { // spell:isSelfTarget(bool) - if (const auto spell = getUserdataShared<Spell>(L, 1)) { + if (const auto &spell = getUserdataShared<Spell>(L, 1)) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getSelfTarget()); } else { @@ -526,7 +524,7 @@ int SpellFunctions::luaSpellSelfTarget(lua_State* L) { int SpellFunctions::luaSpellBlocking(lua_State* L) { // spell:isBlocking(blockingSolid, blockingCreature) - if (const auto spell = getUserdataShared<Spell>(L, 1)) { + if (const auto &spell = getUserdataShared<Spell>(L, 1)) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getBlockingSolid()); pushBoolean(L, spell->getBlockingCreature()); @@ -544,7 +542,7 @@ int SpellFunctions::luaSpellBlocking(lua_State* L) { int SpellFunctions::luaSpellAggressive(lua_State* L) { // spell:isAggressive(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getAggressive()); @@ -560,7 +558,7 @@ int SpellFunctions::luaSpellAggressive(lua_State* L) { int SpellFunctions::luaSpellAllowOnSelf(lua_State* L) { // spell:allowOnSelf(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getAllowOnSelf()); @@ -576,7 +574,7 @@ int SpellFunctions::luaSpellAllowOnSelf(lua_State* L) { int SpellFunctions::luaSpellPzLocked(lua_State* L) { // spell:isPzLocked(bool) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { pushBoolean(L, spell->getLockedPZ()); @@ -592,12 +590,12 @@ int SpellFunctions::luaSpellPzLocked(lua_State* L) { int SpellFunctions::luaSpellVocation(lua_State* L) { // spell:vocation(vocation) - const auto spell = getUserdataShared<Spell>(L, 1); + const auto &spell = getUserdataShared<Spell>(L, 1); if (spell) { if (lua_gettop(L) == 1) { lua_createtable(L, 0, 0); auto it = 0; - for (auto voc : spell->getVocMap()) { + for (const auto &voc : spell->getVocMap()) { ++it; std::string s = std::to_string(it); const char* pchar = s.c_str(); @@ -606,12 +604,12 @@ int SpellFunctions::luaSpellVocation(lua_State* L) { } setMetatable(L, -1, "Spell"); } else { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc for (int i = 0; i < parameters; ++i) { - if (getString(L, 2 + i).find(";") != std::string::npos) { + if (getString(L, 2 + i).find(';') != std::string::npos) { std::vector<std::string> vocList = explodeString(getString(L, 2 + i), ";"); - int32_t vocationId = g_vocations().getVocationId(vocList[0]); - if (vocList.size() > 0) { + const int32_t vocationId = g_vocations().getVocationId(vocList[0]); + if (!vocList.empty()) { if (vocList[1] == "true") { spell->addVocMap(vocationId, true); } else { @@ -619,7 +617,7 @@ int SpellFunctions::luaSpellVocation(lua_State* L) { } } } else { - int32_t vocationId = g_vocations().getVocationId(getString(L, 2 + i)); + const int32_t vocationId = g_vocations().getVocationId(getString(L, 2 + i)); spell->addVocMap(vocationId, false); } } @@ -634,8 +632,8 @@ int SpellFunctions::luaSpellVocation(lua_State* L) { // only for InstantSpells int SpellFunctions::luaSpellWords(lua_State* L) { // spell:words(words[, separator = ""]) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<InstantSpell>(spellBase); if (spell) { // if spell != SPELL_INSTANT, it means that this actually is no InstantSpell, so we return nil if (spell->spellType != SPELL_INSTANT) { @@ -648,7 +646,7 @@ int SpellFunctions::luaSpellWords(lua_State* L) { pushString(L, spell->getSeparator()); return 2; } else { - std::string sep = ""; + std::string sep; if (lua_gettop(L) == 3) { sep = getString(L, 3); } @@ -665,8 +663,8 @@ int SpellFunctions::luaSpellWords(lua_State* L) { // only for InstantSpells int SpellFunctions::luaSpellNeedDirection(lua_State* L) { // spell:needDirection(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<InstantSpell>(spellBase); if (spell) { // if spell != SPELL_INSTANT, it means that this actually is no InstantSpell, so we return nil if (spell->spellType != SPELL_INSTANT) { @@ -689,8 +687,8 @@ int SpellFunctions::luaSpellNeedDirection(lua_State* L) { // only for InstantSpells int SpellFunctions::luaSpellHasParams(lua_State* L) { // spell:hasParams(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<InstantSpell>(spellBase); if (spell) { // if spell != SPELL_INSTANT, it means that this actually is no InstantSpell, so we return nil if (spell->spellType != SPELL_INSTANT) { @@ -713,8 +711,8 @@ int SpellFunctions::luaSpellHasParams(lua_State* L) { // only for InstantSpells int SpellFunctions::luaSpellHasPlayerNameParam(lua_State* L) { // spell:hasPlayerNameParam(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<InstantSpell>(spellBase); if (spell) { // if spell != SPELL_INSTANT, it means that this actually is no InstantSpell, so we return nil if (spell->spellType != SPELL_INSTANT) { @@ -737,8 +735,8 @@ int SpellFunctions::luaSpellHasPlayerNameParam(lua_State* L) { // only for InstantSpells int SpellFunctions::luaSpellNeedCasterTargetOrDirection(lua_State* L) { // spell:needCasterTargetOrDirection(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<InstantSpell>(spellBase); if (spell) { // if spell != SPELL_INSTANT, it means that this actually is no InstantSpell, so we return nil if (spell->spellType != SPELL_INSTANT) { @@ -761,8 +759,8 @@ int SpellFunctions::luaSpellNeedCasterTargetOrDirection(lua_State* L) { // only for InstantSpells int SpellFunctions::luaSpellIsBlockingWalls(lua_State* L) { // spell:blockWalls(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<InstantSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<InstantSpell>(spellBase); if (spell) { // if spell != SPELL_INSTANT, it means that this actually is no InstantSpell, so we return nil if (spell->spellType != SPELL_INSTANT) { @@ -785,8 +783,8 @@ int SpellFunctions::luaSpellIsBlockingWalls(lua_State* L) { // only for RuneSpells int SpellFunctions::luaSpellRuneId(lua_State* L) { // spell:runeId(id) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<RuneSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<RuneSpell>(spellBase); if (spell) { // if spell != SPELL_RUNE, it means that this actually is no RuneSpell, so we return nil if (spell->spellType != SPELL_RUNE) { @@ -809,8 +807,8 @@ int SpellFunctions::luaSpellRuneId(lua_State* L) { // only for RuneSpells int SpellFunctions::luaSpellCharges(lua_State* L) { // spell:charges(charges) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<RuneSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<RuneSpell>(spellBase); if (spell) { // if spell != SPELL_RUNE, it means that this actually is no RuneSpell, so we return nil if (spell->spellType != SPELL_RUNE) { @@ -833,8 +831,8 @@ int SpellFunctions::luaSpellCharges(lua_State* L) { // only for RuneSpells int SpellFunctions::luaSpellAllowFarUse(lua_State* L) { // spell:allowFarUse(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<RuneSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<RuneSpell>(spellBase); if (spell) { // if spell != SPELL_RUNE, it means that this actually is no RuneSpell, so we return nil if (spell->spellType != SPELL_RUNE) { @@ -857,8 +855,8 @@ int SpellFunctions::luaSpellAllowFarUse(lua_State* L) { // only for RuneSpells int SpellFunctions::luaSpellBlockWalls(lua_State* L) { // spell:blockWalls(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<RuneSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<RuneSpell>(spellBase); if (spell) { // if spell != SPELL_RUNE, it means that this actually is no RuneSpell, so we return nil if (spell->spellType != SPELL_RUNE) { @@ -881,8 +879,8 @@ int SpellFunctions::luaSpellBlockWalls(lua_State* L) { // only for RuneSpells int SpellFunctions::luaSpellCheckFloor(lua_State* L) { // spell:checkFloor(bool) - const auto spellBase = getUserdataShared<Spell>(L, 1); - const auto spell = std::static_pointer_cast<RuneSpell>(spellBase); + const auto &spellBase = getUserdataShared<Spell>(L, 1); + const auto &spell = std::static_pointer_cast<RuneSpell>(spellBase); if (spell) { // if spell != SPELL_RUNE, it means that this actually is no RuneSpell, so we return nil if (spell->spellType != SPELL_RUNE) { diff --git a/src/lua/functions/creatures/combat/spell_functions.hpp b/src/lua/functions/creatures/combat/spell_functions.hpp index ac28d9e5232..429ebe11270 100644 --- a/src/lua/functions/creatures/combat/spell_functions.hpp +++ b/src/lua/functions/creatures/combat/spell_functions.hpp @@ -13,6 +13,12 @@ class SpellFunctions final : LuaScriptInterface { public: + explicit SpellFunctions(lua_State* L) : + LuaScriptInterface("SpellFunctions") { + init(L); + } + ~SpellFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Spell", "", SpellFunctions::luaSpellCreate); registerMetaMethod(L, "Spell", "__eq", SpellFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/combat/variant_functions.cpp b/src/lua/functions/creatures/combat/variant_functions.cpp index 4723e9e8543..67dfefaf264 100644 --- a/src/lua/functions/creatures/combat/variant_functions.cpp +++ b/src/lua/functions/creatures/combat/variant_functions.cpp @@ -15,7 +15,7 @@ int VariantFunctions::luaVariantCreate(lua_State* L) { // Variant(number or string or position or thing) LuaVariant variant; if (isUserdata(L, 2)) { - if (std::shared_ptr<Thing> thing = getThing(L, 2)) { + if (const auto &thing = getThing(L, 2)) { variant.type = VARIANT_TARGETPOSITION; variant.pos = thing->getPosition(); } diff --git a/src/lua/functions/creatures/combat/variant_functions.hpp b/src/lua/functions/creatures/combat/variant_functions.hpp index c62bbc114a8..eba239b221c 100644 --- a/src/lua/functions/creatures/combat/variant_functions.hpp +++ b/src/lua/functions/creatures/combat/variant_functions.hpp @@ -13,6 +13,12 @@ class VariantFunctions final : LuaScriptInterface { public: + explicit VariantFunctions(lua_State* L) : + LuaScriptInterface("VariantFunctions") { + init(L); + } + ~VariantFunctions() override = default; + static void init(lua_State* L) { registerClass(L, "Variant", "", VariantFunctions::luaVariantCreate); diff --git a/src/lua/functions/creatures/creature_functions.cpp b/src/lua/functions/creatures/creature_functions.cpp index 83549818581..e6bee02d8be 100644 --- a/src/lua/functions/creatures/creature_functions.cpp +++ b/src/lua/functions/creatures/creature_functions.cpp @@ -20,7 +20,7 @@ int CreatureFunctions::luaCreatureCreate(lua_State* L) { } else if (isString(L, 2)) { creature = g_game().getCreatureByName(getString(L, 2)); } else if (isUserdata(L, 2)) { - LuaData_t type = getUserdataType(L, 2); + const LuaData_t type = getUserdataType(L, 2); if (type != LuaData_t::Player && type != LuaData_t::Monster && type != LuaData_t::Npc) { lua_pushnil(L); return 1; @@ -41,13 +41,13 @@ int CreatureFunctions::luaCreatureCreate(lua_State* L) { int CreatureFunctions::luaCreatureGetEvents(lua_State* L) { // creature:getEvents(type) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - CreatureEventType_t eventType = getNumber<CreatureEventType_t>(L, 2); + const CreatureEventType_t eventType = getNumber<CreatureEventType_t>(L, 2); const auto eventList = creature->getCreatureEvents(eventType); lua_createtable(L, static_cast<int>(eventList.size()), 0); @@ -61,7 +61,7 @@ int CreatureFunctions::luaCreatureGetEvents(lua_State* L) { int CreatureFunctions::luaCreatureRegisterEvent(lua_State* L) { // creature:registerEvent(name) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { const std::string &name = getString(L, 2); pushBoolean(L, creature->registerCreatureEvent(name)); @@ -74,7 +74,7 @@ int CreatureFunctions::luaCreatureRegisterEvent(lua_State* L) { int CreatureFunctions::luaCreatureUnregisterEvent(lua_State* L) { // creature:unregisterEvent(name) const std::string &name = getString(L, 2); - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, creature->unregisterCreatureEvent(name)); } else { @@ -85,7 +85,7 @@ int CreatureFunctions::luaCreatureUnregisterEvent(lua_State* L) { int CreatureFunctions::luaCreatureIsRemoved(lua_State* L) { // creature:isRemoved() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, creature->isRemoved()); } else { @@ -102,7 +102,7 @@ int CreatureFunctions::luaCreatureIsCreature(lua_State* L) { int CreatureFunctions::luaCreatureIsInGhostMode(lua_State* L) { // creature:isInGhostMode() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, creature->isInGhostMode()); } else { @@ -113,7 +113,7 @@ int CreatureFunctions::luaCreatureIsInGhostMode(lua_State* L) { int CreatureFunctions::luaCreatureIsHealthHidden(lua_State* L) { // creature:isHealthHidden() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, creature->isHealthHidden()); } else { @@ -124,7 +124,7 @@ int CreatureFunctions::luaCreatureIsHealthHidden(lua_State* L) { int CreatureFunctions::luaCreatureCanSee(lua_State* L) { // creature:canSee(position) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { const Position &position = getPosition(L, 2); pushBoolean(L, creature->canSee(position)); @@ -136,9 +136,9 @@ int CreatureFunctions::luaCreatureCanSee(lua_State* L) { int CreatureFunctions::luaCreatureCanSeeCreature(lua_State* L) { // creature:canSeeCreature(creature) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { - std::shared_ptr<Creature> otherCreature = getCreature(L, 2); + const auto &otherCreature = getCreature(L, 2); pushBoolean(L, creature->canSeeCreature(otherCreature)); } else { lua_pushnil(L); @@ -148,13 +148,13 @@ int CreatureFunctions::luaCreatureCanSeeCreature(lua_State* L) { int CreatureFunctions::luaCreatureGetParent(lua_State* L) { // creature:getParent() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - std::shared_ptr<Cylinder> parent = creature->getParent(); + const auto &parent = creature->getParent(); if (!parent) { lua_pushnil(L); return 1; @@ -166,7 +166,7 @@ int CreatureFunctions::luaCreatureGetParent(lua_State* L) { int CreatureFunctions::luaCreatureGetId(lua_State* L) { // creature:getId() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getID()); } else { @@ -177,7 +177,7 @@ int CreatureFunctions::luaCreatureGetId(lua_State* L) { int CreatureFunctions::luaCreatureGetName(lua_State* L) { // creature:getName() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushString(L, creature->getName()); } else { @@ -188,7 +188,7 @@ int CreatureFunctions::luaCreatureGetName(lua_State* L) { int CreatureFunctions::luaCreatureGetTypeName(lua_State* L) { // creature:getTypeName() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushString(L, creature->getTypeName()); } else { @@ -199,13 +199,13 @@ int CreatureFunctions::luaCreatureGetTypeName(lua_State* L) { int CreatureFunctions::luaCreatureGetTarget(lua_State* L) { // creature:getTarget() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> target = creature->getAttackedCreature(); + const auto &target = creature->getAttackedCreature(); if (target) { pushUserdata<Creature>(L, target); setCreatureMetatable(L, -1, target); @@ -217,9 +217,9 @@ int CreatureFunctions::luaCreatureGetTarget(lua_State* L) { int CreatureFunctions::luaCreatureSetTarget(lua_State* L) { // creature:setTarget(target) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { - std::shared_ptr<Creature> target = getCreature(L, 2); + const auto &target = getCreature(L, 2); pushBoolean(L, creature->setAttackedCreature(target)); } else { lua_pushnil(L); @@ -229,13 +229,13 @@ int CreatureFunctions::luaCreatureSetTarget(lua_State* L) { int CreatureFunctions::luaCreatureGetFollowCreature(lua_State* L) { // creature:getFollowCreature() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> followCreature = creature->getFollowCreature(); + const auto &followCreature = creature->getFollowCreature(); if (followCreature) { pushUserdata<Creature>(L, followCreature); setCreatureMetatable(L, -1, followCreature); @@ -247,9 +247,9 @@ int CreatureFunctions::luaCreatureGetFollowCreature(lua_State* L) { int CreatureFunctions::luaCreatureSetFollowCreature(lua_State* L) { // creature:setFollowCreature(followedCreature) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { - std::shared_ptr<Creature> followCreature = getCreature(L, 2); + const auto &followCreature = getCreature(L, 2); pushBoolean(L, creature->setFollowCreature(followCreature)); } else { lua_pushnil(L); @@ -259,13 +259,13 @@ int CreatureFunctions::luaCreatureSetFollowCreature(lua_State* L) { int CreatureFunctions::luaCreatureGetMaster(lua_State* L) { // creature:getMaster() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> master = creature->getMaster(); + const auto &master = creature->getMaster(); if (!master) { lua_pushnil(L); return 1; @@ -278,7 +278,7 @@ int CreatureFunctions::luaCreatureGetMaster(lua_State* L) { int CreatureFunctions::luaCreatureReload(lua_State* L) { // creature:reload() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -291,7 +291,7 @@ int CreatureFunctions::luaCreatureReload(lua_State* L) { int CreatureFunctions::luaCreatureSetMaster(lua_State* L) { // creature:setMaster(master) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -305,13 +305,13 @@ int CreatureFunctions::luaCreatureSetMaster(lua_State* L) { int CreatureFunctions::luaCreatureGetLight(lua_State* L) { // creature:getLight() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - LightInfo lightInfo = creature->getCreatureLight(); + const LightInfo lightInfo = creature->getCreatureLight(); lua_pushnumber(L, lightInfo.level); lua_pushnumber(L, lightInfo.color); return 2; @@ -319,7 +319,7 @@ int CreatureFunctions::luaCreatureGetLight(lua_State* L) { int CreatureFunctions::luaCreatureSetLight(lua_State* L) { // creature:setLight(color, level) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -336,7 +336,7 @@ int CreatureFunctions::luaCreatureSetLight(lua_State* L) { int CreatureFunctions::luaCreatureGetSpeed(lua_State* L) { // creature:getSpeed() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getSpeed()); } else { @@ -347,14 +347,14 @@ int CreatureFunctions::luaCreatureGetSpeed(lua_State* L) { int CreatureFunctions::luaCreatureSetSpeed(lua_State* L) { // creature:setSpeed(speed) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - int32_t speed = getNumber<int32_t>(L, 2); + const int32_t speed = getNumber<int32_t>(L, 2); g_game().setCreatureSpeed(creature, speed); pushBoolean(L, true); return 1; @@ -362,7 +362,7 @@ int CreatureFunctions::luaCreatureSetSpeed(lua_State* L) { int CreatureFunctions::luaCreatureGetBaseSpeed(lua_State* L) { // creature:getBaseSpeed() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getBaseSpeed()); } else { @@ -373,14 +373,14 @@ int CreatureFunctions::luaCreatureGetBaseSpeed(lua_State* L) { int CreatureFunctions::luaCreatureChangeSpeed(lua_State* L) { // creature:changeSpeed(delta) - std::shared_ptr<Creature> creature = getCreature(L, 1); + const auto &creature = getCreature(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - int32_t delta = getNumber<int32_t>(L, 2); + const int32_t delta = getNumber<int32_t>(L, 2); g_game().changeSpeed(creature, delta); pushBoolean(L, true); return 1; @@ -388,7 +388,7 @@ int CreatureFunctions::luaCreatureChangeSpeed(lua_State* L) { int CreatureFunctions::luaCreatureSetDropLoot(lua_State* L) { // creature:setDropLoot(doDrop) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { creature->setDropLoot(getBoolean(L, 2)); pushBoolean(L, true); @@ -400,7 +400,7 @@ int CreatureFunctions::luaCreatureSetDropLoot(lua_State* L) { int CreatureFunctions::luaCreatureSetSkillLoss(lua_State* L) { // creature:setSkillLoss(skillLoss) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { creature->setSkillLoss(getBoolean(L, 2)); pushBoolean(L, true); @@ -412,7 +412,7 @@ int CreatureFunctions::luaCreatureSetSkillLoss(lua_State* L) { int CreatureFunctions::luaCreatureGetPosition(lua_State* L) { // creature:getPosition() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushPosition(L, creature->getPosition()); } else { @@ -423,13 +423,13 @@ int CreatureFunctions::luaCreatureGetPosition(lua_State* L) { int CreatureFunctions::luaCreatureGetTile(lua_State* L) { // creature:getTile() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - std::shared_ptr<Tile> tile = creature->getTile(); + const auto &tile = creature->getTile(); if (tile) { pushUserdata<Tile>(L, tile); setMetatable(L, -1, "Tile"); @@ -441,7 +441,7 @@ int CreatureFunctions::luaCreatureGetTile(lua_State* L) { int CreatureFunctions::luaCreatureGetDirection(lua_State* L) { // creature:getDirection() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getDirection()); } else { @@ -452,7 +452,7 @@ int CreatureFunctions::luaCreatureGetDirection(lua_State* L) { int CreatureFunctions::luaCreatureSetDirection(lua_State* L) { // creature:setDirection(direction) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, g_game().internalCreatureTurn(creature, getNumber<Direction>(L, 2))); } else { @@ -463,7 +463,7 @@ int CreatureFunctions::luaCreatureSetDirection(lua_State* L) { int CreatureFunctions::luaCreatureGetHealth(lua_State* L) { // creature:getHealth() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getHealth()); } else { @@ -474,7 +474,7 @@ int CreatureFunctions::luaCreatureGetHealth(lua_State* L) { int CreatureFunctions::luaCreatureSetHealth(lua_State* L) { // creature:setHealth(health) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -483,7 +483,7 @@ int CreatureFunctions::luaCreatureSetHealth(lua_State* L) { creature->health = std::min<int32_t>(getNumber<uint32_t>(L, 2), creature->healthMax); g_game().addCreatureHealth(creature); - std::shared_ptr<Player> player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { player->sendStats(); } @@ -493,7 +493,7 @@ int CreatureFunctions::luaCreatureSetHealth(lua_State* L) { int CreatureFunctions::luaCreatureAddHealth(lua_State* L) { // creature:addHealth(healthChange, combatType) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -514,7 +514,7 @@ int CreatureFunctions::luaCreatureAddHealth(lua_State* L) { int CreatureFunctions::luaCreatureGetMaxHealth(lua_State* L) { // creature:getMaxHealth() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getMaxHealth()); } else { @@ -525,7 +525,7 @@ int CreatureFunctions::luaCreatureGetMaxHealth(lua_State* L) { int CreatureFunctions::luaCreatureSetMaxHealth(lua_State* L) { // creature:setMaxHealth(maxHealth) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -535,7 +535,7 @@ int CreatureFunctions::luaCreatureSetMaxHealth(lua_State* L) { creature->health = std::min<int32_t>(creature->health, creature->healthMax); g_game().addCreatureHealth(creature); - std::shared_ptr<Player> player = creature->getPlayer(); + const auto &player = creature->getPlayer(); if (player) { player->sendStats(); } @@ -545,7 +545,7 @@ int CreatureFunctions::luaCreatureSetMaxHealth(lua_State* L) { int CreatureFunctions::luaCreatureSetHiddenHealth(lua_State* L) { // creature:setHiddenHealth(hide) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { creature->setHiddenHealth(getBoolean(L, 2)); g_game().addCreatureHealth(creature); @@ -558,7 +558,7 @@ int CreatureFunctions::luaCreatureSetHiddenHealth(lua_State* L) { int CreatureFunctions::luaCreatureIsMoveLocked(lua_State* L) { // creature:isMoveLocked() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, creature->isMoveLocked()); } else { @@ -569,7 +569,7 @@ int CreatureFunctions::luaCreatureIsMoveLocked(lua_State* L) { int CreatureFunctions::luaCreatureSetMoveLocked(lua_State* L) { // creature:setMoveLocked(moveLocked) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { creature->setMoveLocked(getBoolean(L, 2)); pushBoolean(L, true); @@ -581,7 +581,7 @@ int CreatureFunctions::luaCreatureSetMoveLocked(lua_State* L) { int CreatureFunctions::luaCreatureIsDirectionLocked(lua_State* L) { // creature:isDirectionLocked() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, creature->isDirectionLocked()); } else { @@ -592,7 +592,7 @@ int CreatureFunctions::luaCreatureIsDirectionLocked(lua_State* L) { int CreatureFunctions::luaCreatureSetDirectionLocked(lua_State* L) { // creature:setDirectionLocked(directionLocked) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { creature->setDirectionLocked(getBoolean(L, 2)); pushBoolean(L, true); @@ -604,7 +604,7 @@ int CreatureFunctions::luaCreatureSetDirectionLocked(lua_State* L) { int CreatureFunctions::luaCreatureGetSkull(lua_State* L) { // creature:getSkull() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getSkull()); } else { @@ -615,7 +615,7 @@ int CreatureFunctions::luaCreatureGetSkull(lua_State* L) { int CreatureFunctions::luaCreatureSetSkull(lua_State* L) { // creature:setSkull(skull) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { creature->setSkull(getNumber<Skulls_t>(L, 2)); pushBoolean(L, true); @@ -627,7 +627,7 @@ int CreatureFunctions::luaCreatureSetSkull(lua_State* L) { int CreatureFunctions::luaCreatureGetOutfit(lua_State* L) { // creature:getOutfit() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushOutfit(L, creature->getCurrentOutfit()); } else { @@ -638,7 +638,7 @@ int CreatureFunctions::luaCreatureGetOutfit(lua_State* L) { int CreatureFunctions::luaCreatureSetOutfit(lua_State* L) { // creature:setOutfit(outfit) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { Outfit_t outfit = getOutfit(L, 2); if (g_configManager().getBoolean(WARN_UNSAFE_SCRIPTS) && outfit.lookType != 0 && !g_game().isLookTypeRegistered(outfit.lookType)) { @@ -657,17 +657,17 @@ int CreatureFunctions::luaCreatureSetOutfit(lua_State* L) { int CreatureFunctions::luaCreatureGetCondition(lua_State* L) { // creature:getCondition(conditionType[, conditionId = CONDITIONID_COMBAT[, subId = 0]]) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); - ConditionId_t conditionId = getNumber<ConditionId_t>(L, 3, CONDITIONID_COMBAT); - uint32_t subId = getNumber<uint32_t>(L, 4, 0); + const ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); + const auto conditionId = getNumber<ConditionId_t>(L, 3, CONDITIONID_COMBAT); + const auto subId = getNumber<uint32_t>(L, 4, 0); - const std::shared_ptr<Condition> condition = creature->getCondition(conditionType, conditionId, subId); + const auto &condition = creature->getCondition(conditionType, conditionId, subId); if (condition) { pushUserdata<const Condition>(L, condition); setWeakMetatable(L, -1, "Condition"); @@ -679,8 +679,8 @@ int CreatureFunctions::luaCreatureGetCondition(lua_State* L) { int CreatureFunctions::luaCreatureAddCondition(lua_State* L) { // creature:addCondition(condition) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); - std::shared_ptr<Condition> condition = getUserdataShared<Condition>(L, 2); + const auto &creature = getUserdataShared<Creature>(L, 1); + const auto &condition = getUserdataShared<Condition>(L, 2); if (creature && condition) { pushBoolean(L, creature->addCondition(condition->clone())); } else { @@ -691,18 +691,18 @@ int CreatureFunctions::luaCreatureAddCondition(lua_State* L) { int CreatureFunctions::luaCreatureRemoveCondition(lua_State* L) { // creature:removeCondition(conditionType[, conditionId = CONDITIONID_COMBAT[, subId = 0[, force = false]]]) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); - ConditionId_t conditionId = getNumber<ConditionId_t>(L, 3, CONDITIONID_COMBAT); - uint32_t subId = getNumber<uint32_t>(L, 4, 0); - const std::shared_ptr<Condition> condition = creature->getCondition(conditionType, conditionId, subId); + const ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); + const auto conditionId = getNumber<ConditionId_t>(L, 3, CONDITIONID_COMBAT); + const auto subId = getNumber<uint32_t>(L, 4, 0); + const auto &condition = creature->getCondition(conditionType, conditionId, subId); if (condition) { - bool force = getBoolean(L, 5, false); + const bool force = getBoolean(L, 5, false); if (subId == 0) { creature->removeCondition(conditionType, conditionId, force); } else { @@ -717,21 +717,21 @@ int CreatureFunctions::luaCreatureRemoveCondition(lua_State* L) { int CreatureFunctions::luaCreatureHasCondition(lua_State* L) { // creature:hasCondition(conditionType[, subId = 0]) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } - ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); - uint32_t subId = getNumber<uint32_t>(L, 3, 0); + const ConditionType_t conditionType = getNumber<ConditionType_t>(L, 2); + const auto subId = getNumber<uint32_t>(L, 3, 0); pushBoolean(L, creature->hasCondition(conditionType, subId)); return 1; } int CreatureFunctions::luaCreatureIsImmune(lua_State* L) { // creature:isImmune(condition or conditionType) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -739,7 +739,7 @@ int CreatureFunctions::luaCreatureIsImmune(lua_State* L) { if (isNumber(L, 2)) { pushBoolean(L, creature->isImmune(getNumber<ConditionType_t>(L, 2))); - } else if (auto condition = getUserdataShared<Condition>(L, 2)) { + } else if (const auto condition = getUserdataShared<Condition>(L, 2)) { pushBoolean(L, creature->isImmune(condition->getType())); } else { lua_pushnil(L); @@ -749,20 +749,20 @@ int CreatureFunctions::luaCreatureIsImmune(lua_State* L) { int CreatureFunctions::luaCreatureRemove(lua_State* L) { // creature:remove([forced = true]) - std::shared_ptr<Creature>* creaturePtr = getRawUserDataShared<Creature>(L, 1); + auto* creaturePtr = getRawUserDataShared<Creature>(L, 1); if (!creaturePtr) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> creature = *creaturePtr; + const auto &creature = *creaturePtr; if (!creature) { lua_pushnil(L); return 1; } - bool forced = getBoolean(L, 2, true); - if (std::shared_ptr<Player> player = creature->getPlayer()) { + const bool forced = getBoolean(L, 2, true); + if (const auto &player = creature->getPlayer()) { if (forced) { player->removePlayer(true); } else { @@ -779,10 +779,10 @@ int CreatureFunctions::luaCreatureRemove(lua_State* L) { int CreatureFunctions::luaCreatureTeleportTo(lua_State* L) { // creature:teleportTo(position[, pushMovement = false]) - bool pushMovement = getBoolean(L, 3, false); + const bool pushMovement = getBoolean(L, 3, false); const Position &position = getPosition(L, 2); - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature == nullptr) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -790,7 +790,7 @@ int CreatureFunctions::luaCreatureTeleportTo(lua_State* L) { } const Position oldPosition = creature->getPosition(); - if (auto ret = g_game().internalTeleport(creature, position, pushMovement); + if (const auto ret = g_game().internalTeleport(creature, position, pushMovement); ret != RETURNVALUE_NOERROR) { g_logger().debug("[{}] Failed to teleport creature {}, on position {}, error code: {}", __FUNCTION__, creature->getName(), oldPosition.toString(), getReturnMessage(ret)); pushBoolean(L, false); @@ -816,7 +816,7 @@ int CreatureFunctions::luaCreatureTeleportTo(lua_State* L) { int CreatureFunctions::luaCreatureSay(lua_State* L) { // creature:say(text[, type = TALKTYPE_MONSTER_SAY[, ghost = false[, target = nullptr[, position]]]]) - int parameters = lua_gettop(L); + const int parameters = lua_gettop(L); Position position; if (parameters >= 6) { @@ -833,11 +833,11 @@ int CreatureFunctions::luaCreatureSay(lua_State* L) { target = getCreature(L, 5); } - bool ghost = getBoolean(L, 4, false); + const bool ghost = getBoolean(L, 4, false); - SpeakClasses type = getNumber<SpeakClasses>(L, 3, TALKTYPE_MONSTER_SAY); + const auto type = getNumber<SpeakClasses>(L, 3, TALKTYPE_MONSTER_SAY); const std::string &text = getString(L, 2); - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -858,14 +858,14 @@ int CreatureFunctions::luaCreatureSay(lua_State* L) { int CreatureFunctions::luaCreatureGetDamageMap(lua_State* L) { // creature:getDamageMap() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } lua_createtable(L, creature->damageMap.size(), 0); - for (auto damageEntry : creature->damageMap) { + for (const auto damageEntry : creature->damageMap) { lua_createtable(L, 0, 2); setField(L, "total", damageEntry.second.total); setField(L, "ticks", damageEntry.second.ticks); @@ -876,7 +876,7 @@ int CreatureFunctions::luaCreatureGetDamageMap(lua_State* L) { int CreatureFunctions::luaCreatureGetSummons(lua_State* L) { // creature:getSummons() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -897,7 +897,7 @@ int CreatureFunctions::luaCreatureGetSummons(lua_State* L) { int CreatureFunctions::luaCreatureHasBeenSummoned(lua_State* L) { // creature:hasBeenSummoned() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushBoolean(L, creature->hasBeenSummoned()); } else { @@ -909,8 +909,8 @@ int CreatureFunctions::luaCreatureHasBeenSummoned(lua_State* L) { int CreatureFunctions::luaCreatureGetDescription(lua_State* L) { // creature:getDescription(distance) - int32_t distance = getNumber<int32_t>(L, 2); - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const int32_t distance = getNumber<int32_t>(L, 2); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { pushString(L, creature->getDescription(distance)); } else { @@ -921,7 +921,7 @@ int CreatureFunctions::luaCreatureGetDescription(lua_State* L) { int CreatureFunctions::luaCreatureGetPathTo(lua_State* L) { // creature:getPathTo(pos[, minTargetDist = 0[, maxTargetDist = 1[, fullPathSearch = true[, clearSight = true[, maxSearchDist = 0]]]]]) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; @@ -941,7 +941,7 @@ int CreatureFunctions::luaCreatureGetPathTo(lua_State* L) { lua_newtable(L); int index = 0; - for (Direction dir : dirList) { + for (const Direction dir : dirList) { lua_pushnumber(L, dir); lua_rawseti(L, -2, ++index); } @@ -954,21 +954,21 @@ int CreatureFunctions::luaCreatureGetPathTo(lua_State* L) { int CreatureFunctions::luaCreatureMove(lua_State* L) { // creature:move(direction) // creature:move(tile[, flags = 0]) - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { lua_pushnil(L); return 1; } if (isNumber(L, 2)) { - Direction direction = getNumber<Direction>(L, 2); + const Direction direction = getNumber<Direction>(L, 2); if (direction > DIRECTION_LAST) { lua_pushnil(L); return 1; } lua_pushnumber(L, g_game().internalMoveCreature(creature, direction, FLAG_NOLIMIT)); } else { - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 2); + const auto &tile = getUserdataShared<Tile>(L, 2); if (!tile) { lua_pushnil(L); return 1; @@ -980,7 +980,7 @@ int CreatureFunctions::luaCreatureMove(lua_State* L) { int CreatureFunctions::luaCreatureGetZoneType(lua_State* L) { // creature:getZoneType() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature) { lua_pushnumber(L, creature->getZoneType()); } else { @@ -991,7 +991,7 @@ int CreatureFunctions::luaCreatureGetZoneType(lua_State* L) { int CreatureFunctions::luaCreatureGetZones(lua_State* L) { // creature:getZones() - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (creature == nullptr) { lua_pushnil(L); return 1; @@ -1000,7 +1000,7 @@ int CreatureFunctions::luaCreatureGetZones(lua_State* L) { const auto zones = creature->getZones(); lua_createtable(L, static_cast<int>(zones.size()), 0); int index = 0; - for (auto zone : zones) { + for (const auto &zone : zones) { index++; pushUserdata<Zone>(L, zone); setMetatable(L, -1, "Zone"); @@ -1011,7 +1011,7 @@ int CreatureFunctions::luaCreatureGetZones(lua_State* L) { int CreatureFunctions::luaCreatureSetIcon(lua_State* L) { // creature:setIcon(key, category, icon[, number]) - auto creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1022,10 +1022,10 @@ int CreatureFunctions::luaCreatureSetIcon(lua_State* L) { const auto count = getNumber<uint16_t>(L, 5, 0); CreatureIcon creatureIcon; if (category == CreatureIconCategory_t::Modifications) { - auto icon = getNumber<CreatureIconModifications_t>(L, 4); + const auto icon = getNumber<CreatureIconModifications_t>(L, 4); creatureIcon = CreatureIcon(icon, count); } else { - auto icon = getNumber<CreatureIconQuests_t>(L, 4); + const auto icon = getNumber<CreatureIconQuests_t>(L, 4); creatureIcon = CreatureIcon(icon, count); } @@ -1036,7 +1036,7 @@ int CreatureFunctions::luaCreatureSetIcon(lua_State* L) { int CreatureFunctions::luaCreatureGetIcons(lua_State* L) { // creature:getIcons() - const auto creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1057,7 +1057,7 @@ int CreatureFunctions::luaCreatureGetIcons(lua_State* L) { int CreatureFunctions::luaCreatureGetIcon(lua_State* L) { // creature:getIcon(key) - const auto creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1078,7 +1078,7 @@ int CreatureFunctions::luaCreatureGetIcon(lua_State* L) { int CreatureFunctions::luaCreatureRemoveIcon(lua_State* L) { // creature:removeIcon(key) - auto creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1092,7 +1092,7 @@ int CreatureFunctions::luaCreatureRemoveIcon(lua_State* L) { int CreatureFunctions::luaCreatureClearIcons(lua_State* L) { // creature:clearIcons() - auto creature = getUserdataShared<Creature>(L, 1); + const auto &creature = getUserdataShared<Creature>(L, 1); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); diff --git a/src/lua/functions/creatures/creature_functions.hpp b/src/lua/functions/creatures/creature_functions.hpp index 0876bb72901..f0f1d12bb77 100644 --- a/src/lua/functions/creatures/creature_functions.hpp +++ b/src/lua/functions/creatures/creature_functions.hpp @@ -17,6 +17,12 @@ class CreatureFunctions final : LuaScriptInterface { public: + explicit CreatureFunctions(lua_State* L) : + LuaScriptInterface("CreatureFunctions") { + init(L); + } + ~CreatureFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Creature", "", CreatureFunctions::luaCreatureCreate); registerMetaMethod(L, "Creature", "__eq", CreatureFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/monster/charm_functions.cpp b/src/lua/functions/creatures/monster/charm_functions.cpp index 492820b76fa..b90ee4da350 100644 --- a/src/lua/functions/creatures/monster/charm_functions.cpp +++ b/src/lua/functions/creatures/monster/charm_functions.cpp @@ -14,7 +14,7 @@ int CharmFunctions::luaCharmCreate(lua_State* L) { // charm(id) if (isNumber(L, 2)) { - charmRune_t charmid = getNumber<charmRune_t>(L, 2); + const charmRune_t charmid = getNumber<charmRune_t>(L, 2); const auto charmList = g_game().getCharmList(); for (const auto &charm : charmList) { if (charm->id == charmid) { @@ -31,7 +31,7 @@ int CharmFunctions::luaCharmCreate(lua_State* L) { int CharmFunctions::luaCharmName(lua_State* L) { // get: charm:name() set: charm:name(string) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { pushString(L, charm->name); } else { @@ -43,7 +43,7 @@ int CharmFunctions::luaCharmName(lua_State* L) { int CharmFunctions::luaCharmDescription(lua_State* L) { // get: charm:description() set: charm:description(string) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { pushString(L, charm->description); } else { @@ -55,7 +55,7 @@ int CharmFunctions::luaCharmDescription(lua_State* L) { int CharmFunctions::luaCharmType(lua_State* L) { // get: charm:type() set: charm:type(charm_t) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, charm->type); } else { @@ -67,7 +67,7 @@ int CharmFunctions::luaCharmType(lua_State* L) { int CharmFunctions::luaCharmPoints(lua_State* L) { // get: charm:points() set: charm:points(value) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, charm->points); } else { @@ -79,7 +79,7 @@ int CharmFunctions::luaCharmPoints(lua_State* L) { int CharmFunctions::luaCharmDamageType(lua_State* L) { // get: charm:damageType() set: charm:damageType(type) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, charm->dmgtype); } else { @@ -91,7 +91,7 @@ int CharmFunctions::luaCharmDamageType(lua_State* L) { int CharmFunctions::luaCharmPercentage(lua_State* L) { // get: charm:percentage() set: charm:percentage(value) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, charm->percent); } else { @@ -103,7 +103,7 @@ int CharmFunctions::luaCharmPercentage(lua_State* L) { int CharmFunctions::luaCharmChance(lua_State* L) { // get: charm:chance() set: charm:chance(value) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, charm->chance); } else { @@ -115,7 +115,7 @@ int CharmFunctions::luaCharmChance(lua_State* L) { int CharmFunctions::luaCharmMessageCancel(lua_State* L) { // get: charm:messageCancel() set: charm:messageCancel(string) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { pushString(L, charm->cancelMsg); } else { @@ -127,7 +127,7 @@ int CharmFunctions::luaCharmMessageCancel(lua_State* L) { int CharmFunctions::luaCharmMessageServerLog(lua_State* L) { // get: charm:messageServerLog() set: charm:messageServerLog(string) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { pushString(L, charm->logMsg); } else { @@ -139,7 +139,7 @@ int CharmFunctions::luaCharmMessageServerLog(lua_State* L) { int CharmFunctions::luaCharmEffect(lua_State* L) { // get: charm:effect() set: charm:effect(value) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, charm->effect); } else { @@ -151,7 +151,7 @@ int CharmFunctions::luaCharmEffect(lua_State* L) { int CharmFunctions::luaCharmCastSound(lua_State* L) { // get: charm:castSound() set: charm:castSound(sound) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, static_cast<lua_Number>(charm->soundCastEffect)); } else { @@ -163,7 +163,7 @@ int CharmFunctions::luaCharmCastSound(lua_State* L) { int CharmFunctions::luaCharmImpactSound(lua_State* L) { // get: charm:impactSound() set: charm:impactSound(sound) - const auto charm = getUserdataShared<Charm>(L, 1); + const auto &charm = getUserdataShared<Charm>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, static_cast<lua_Number>(charm->soundImpactEffect)); } else { diff --git a/src/lua/functions/creatures/monster/charm_functions.hpp b/src/lua/functions/creatures/monster/charm_functions.hpp index 7be1c8de635..837c1c14fa7 100644 --- a/src/lua/functions/creatures/monster/charm_functions.hpp +++ b/src/lua/functions/creatures/monster/charm_functions.hpp @@ -13,6 +13,12 @@ class CharmFunctions final : LuaScriptInterface { public: + explicit CharmFunctions(lua_State* L) : + LuaScriptInterface("CharmFunctions") { + init(L); + } + ~CharmFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Charm", "", CharmFunctions::luaCharmCreate); registerMetaMethod(L, "Charm", "__eq", CharmFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/monster/loot_functions.cpp b/src/lua/functions/creatures/monster/loot_functions.cpp index e05d86b6340..7442a2f3b54 100644 --- a/src/lua/functions/creatures/monster/loot_functions.cpp +++ b/src/lua/functions/creatures/monster/loot_functions.cpp @@ -12,7 +12,7 @@ int LootFunctions::luaCreateLoot(lua_State* L) { // Loot() will create a new loot item - const auto loot = std::make_shared<Loot>(); + auto loot = std::make_shared<Loot>(); pushUserdata<Loot>(L, loot); setMetatable(L, -1, "Loot"); return 1; @@ -20,7 +20,7 @@ int LootFunctions::luaCreateLoot(lua_State* L) { int LootFunctions::luaLootSetId(lua_State* L) { // loot:setId(id) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { if (isNumber(L, 2)) { loot->lootBlock.id = getNumber<uint16_t>(L, 2); @@ -38,10 +38,10 @@ int LootFunctions::luaLootSetId(lua_State* L) { int LootFunctions::luaLootSetIdFromName(lua_State* L) { // loot:setIdFromName(name) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot && isString(L, 2)) { auto name = getString(L, 2); - auto ids = Item::items.nameToItems.equal_range(asLowerCaseString(name)); + const auto ids = Item::items.nameToItems.equal_range(asLowerCaseString(name)); if (ids.first == Item::items.nameToItems.cend()) { g_logger().warn("[LootFunctions::luaLootSetIdFromName] - " @@ -71,7 +71,7 @@ int LootFunctions::luaLootSetIdFromName(lua_State* L) { int LootFunctions::luaLootSetSubType(lua_State* L) { // loot:setSubType(type) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.subType = getNumber<uint16_t>(L, 2); pushBoolean(L, true); @@ -83,7 +83,7 @@ int LootFunctions::luaLootSetSubType(lua_State* L) { int LootFunctions::luaLootSetChance(lua_State* L) { // loot:setChance(chance) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.chance = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -95,7 +95,7 @@ int LootFunctions::luaLootSetChance(lua_State* L) { int LootFunctions::luaLootSetMinCount(lua_State* L) { // loot:setMinCount(min) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.countmin = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -107,7 +107,7 @@ int LootFunctions::luaLootSetMinCount(lua_State* L) { int LootFunctions::luaLootSetMaxCount(lua_State* L) { // loot:setMaxCount(max) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.countmax = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -119,7 +119,7 @@ int LootFunctions::luaLootSetMaxCount(lua_State* L) { int LootFunctions::luaLootSetActionId(lua_State* L) { // loot:setActionId(actionid) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.actionId = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -131,7 +131,7 @@ int LootFunctions::luaLootSetActionId(lua_State* L) { int LootFunctions::luaLootSetText(lua_State* L) { // loot:setText(text) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.text = getString(L, 2); pushBoolean(L, true); @@ -143,7 +143,7 @@ int LootFunctions::luaLootSetText(lua_State* L) { int LootFunctions::luaLootSetNameItem(lua_State* L) { // loot:setNameItem(name) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.name = getString(L, 2); pushBoolean(L, true); @@ -155,7 +155,7 @@ int LootFunctions::luaLootSetNameItem(lua_State* L) { int LootFunctions::luaLootSetArticle(lua_State* L) { // loot:setArticle(article) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.article = getString(L, 2); pushBoolean(L, true); @@ -167,7 +167,7 @@ int LootFunctions::luaLootSetArticle(lua_State* L) { int LootFunctions::luaLootSetAttack(lua_State* L) { // loot:setAttack(attack) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.attack = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -179,7 +179,7 @@ int LootFunctions::luaLootSetAttack(lua_State* L) { int LootFunctions::luaLootSetDefense(lua_State* L) { // loot:setDefense(defense) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.defense = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -191,7 +191,7 @@ int LootFunctions::luaLootSetDefense(lua_State* L) { int LootFunctions::luaLootSetExtraDefense(lua_State* L) { // loot:setExtraDefense(defense) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.extraDefense = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -203,7 +203,7 @@ int LootFunctions::luaLootSetExtraDefense(lua_State* L) { int LootFunctions::luaLootSetArmor(lua_State* L) { // loot:setArmor(armor) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.armor = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -215,7 +215,7 @@ int LootFunctions::luaLootSetArmor(lua_State* L) { int LootFunctions::luaLootSetShootRange(lua_State* L) { // loot:setShootRange(range) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.shootRange = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -227,7 +227,7 @@ int LootFunctions::luaLootSetShootRange(lua_State* L) { int LootFunctions::luaLootSetHitChance(lua_State* L) { // loot:setHitChance(chance) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { loot->lootBlock.hitChance = getNumber<uint32_t>(L, 2); pushBoolean(L, true); @@ -239,7 +239,7 @@ int LootFunctions::luaLootSetHitChance(lua_State* L) { int LootFunctions::luaLootSetUnique(lua_State* L) { // loot:setUnique(bool) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { if (lua_gettop(L) == 1) { pushBoolean(L, loot->lootBlock.unique); @@ -255,7 +255,7 @@ int LootFunctions::luaLootSetUnique(lua_State* L) { int LootFunctions::luaLootAddChildLoot(lua_State* L) { // loot:addChildLoot(loot) - const auto loot = getUserdataShared<Loot>(L, 1); + const auto &loot = getUserdataShared<Loot>(L, 1); if (loot) { const auto childLoot = getUserdata<Loot>(L, 2); if (childLoot) { diff --git a/src/lua/functions/creatures/monster/loot_functions.hpp b/src/lua/functions/creatures/monster/loot_functions.hpp index 77059307a66..321f6bd8365 100644 --- a/src/lua/functions/creatures/monster/loot_functions.hpp +++ b/src/lua/functions/creatures/monster/loot_functions.hpp @@ -13,6 +13,12 @@ class LootFunctions final : LuaScriptInterface { public: + explicit LootFunctions(lua_State* L) : + LuaScriptInterface("LootFunctions") { + init(L); + } + ~LootFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Loot", "", LootFunctions::luaCreateLoot); diff --git a/src/lua/functions/creatures/monster/monster_functions.cpp b/src/lua/functions/creatures/monster/monster_functions.cpp index cddbca49830..d8f24d1d70d 100644 --- a/src/lua/functions/creatures/monster/monster_functions.cpp +++ b/src/lua/functions/creatures/monster/monster_functions.cpp @@ -47,7 +47,7 @@ int MonsterFunctions::luaMonsterIsMonster(lua_State* L) { int MonsterFunctions::luaMonsterGetType(lua_State* L) { // monster:getType() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { pushUserdata<MonsterType>(L, monster->mType); setMetatable(L, -1, "MonsterType"); @@ -60,9 +60,9 @@ int MonsterFunctions::luaMonsterGetType(lua_State* L) { int MonsterFunctions::luaMonsterSetType(lua_State* L) { // monster:setType(name or raceid, restoreHealth = false) bool restoreHealth = getBoolean(L, 3, false); - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - std::shared_ptr<MonsterType> mType = nullptr; + std::shared_ptr<MonsterType> mType; if (isNumber(L, 2)) { mType = g_monsters().getMonsterTypeByRaceId(getNumber<uint16_t>(L, 2)); } else { @@ -111,7 +111,7 @@ int MonsterFunctions::luaMonsterSetType(lua_State* L) { int MonsterFunctions::luaMonsterGetSpawnPosition(lua_State* L) { // monster:getSpawnPosition() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { pushPosition(L, monster->getMasterPos()); } else { @@ -122,7 +122,7 @@ int MonsterFunctions::luaMonsterGetSpawnPosition(lua_State* L) { int MonsterFunctions::luaMonsterIsInSpawnRange(lua_State* L) { // monster:isInSpawnRange([position]) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { pushBoolean(L, monster->isInSpawnRange(lua_gettop(L) >= 2 ? getPosition(L, 2) : monster->getPosition())); } else { @@ -133,7 +133,7 @@ int MonsterFunctions::luaMonsterIsInSpawnRange(lua_State* L) { int MonsterFunctions::luaMonsterIsIdle(lua_State* L) { // monster:isIdle() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { pushBoolean(L, monster->getIdleStatus()); } else { @@ -144,7 +144,7 @@ int MonsterFunctions::luaMonsterIsIdle(lua_State* L) { int MonsterFunctions::luaMonsterSetIdle(lua_State* L) { // monster:setIdle(idle) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { lua_pushnil(L); return 1; @@ -157,9 +157,9 @@ int MonsterFunctions::luaMonsterSetIdle(lua_State* L) { int MonsterFunctions::luaMonsterIsTarget(lua_State* L) { // monster:isTarget(creature) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); pushBoolean(L, monster->isTarget(creature)); } else { lua_pushnil(L); @@ -169,9 +169,9 @@ int MonsterFunctions::luaMonsterIsTarget(lua_State* L) { int MonsterFunctions::luaMonsterIsOpponent(lua_State* L) { // monster:isOpponent(creature) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); pushBoolean(L, monster->isOpponent(creature)); } else { lua_pushnil(L); @@ -181,9 +181,9 @@ int MonsterFunctions::luaMonsterIsOpponent(lua_State* L) { int MonsterFunctions::luaMonsterIsFriend(lua_State* L) { // monster:isFriend(creature) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); pushBoolean(L, monster->isFriend(creature)); } else { lua_pushnil(L); @@ -193,9 +193,9 @@ int MonsterFunctions::luaMonsterIsFriend(lua_State* L) { int MonsterFunctions::luaMonsterAddFriend(lua_State* L) { // monster:addFriend(creature) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); monster->addFriend(creature); pushBoolean(L, true); } else { @@ -206,9 +206,9 @@ int MonsterFunctions::luaMonsterAddFriend(lua_State* L) { int MonsterFunctions::luaMonsterRemoveFriend(lua_State* L) { // monster:removeFriend(creature) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); monster->removeFriend(creature); pushBoolean(L, true); } else { @@ -219,7 +219,7 @@ int MonsterFunctions::luaMonsterRemoveFriend(lua_State* L) { int MonsterFunctions::luaMonsterGetFriendList(lua_State* L) { // monster:getFriendList() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { lua_pushnil(L); return 1; @@ -239,7 +239,7 @@ int MonsterFunctions::luaMonsterGetFriendList(lua_State* L) { int MonsterFunctions::luaMonsterGetFriendCount(lua_State* L) { // monster:getFriendCount() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { lua_pushnumber(L, monster->getFriendList().size()); } else { @@ -250,14 +250,14 @@ int MonsterFunctions::luaMonsterGetFriendCount(lua_State* L) { int MonsterFunctions::luaMonsterAddTarget(lua_State* L) { // monster:addTarget(creature[, pushFront = false]) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> creature = getCreature(L, 2); - bool pushFront = getBoolean(L, 3, false); + const auto &creature = getCreature(L, 2); + const bool pushFront = getBoolean(L, 3, false); monster->addTarget(creature, pushFront); pushBoolean(L, true); return 1; @@ -265,7 +265,7 @@ int MonsterFunctions::luaMonsterAddTarget(lua_State* L) { int MonsterFunctions::luaMonsterRemoveTarget(lua_State* L) { // monster:removeTarget(creature) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { lua_pushnil(L); return 1; @@ -278,17 +278,17 @@ int MonsterFunctions::luaMonsterRemoveTarget(lua_State* L) { int MonsterFunctions::luaMonsterGetTargetList(lua_State* L) { // monster:getTargetList() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { lua_pushnil(L); return 1; } - const auto targetList = monster->getTargetList(); + const auto &targetList = monster->getTargetList(); lua_createtable(L, targetList.size(), 0); int index = 0; - for (std::shared_ptr<Creature> creature : targetList) { + for (const auto &creature : targetList) { pushUserdata<Creature>(L, creature); setCreatureMetatable(L, -1, creature); lua_rawseti(L, -2, ++index); @@ -298,7 +298,7 @@ int MonsterFunctions::luaMonsterGetTargetList(lua_State* L) { int MonsterFunctions::luaMonsterGetTargetCount(lua_State* L) { // monster:getTargetCount() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { lua_pushnumber(L, monster->getTargetList().size()); } else { @@ -309,10 +309,10 @@ int MonsterFunctions::luaMonsterGetTargetCount(lua_State* L) { int MonsterFunctions::luaMonsterChangeTargetDistance(lua_State* L) { // monster:changeTargetDistance(distance[, duration = 12000]) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - int32_t distance = getNumber<int32_t>(L, 2, 1); - uint32_t duration = getNumber<uint32_t>(L, 3, 12000); + const auto distance = getNumber<int32_t>(L, 2, 1); + const auto duration = getNumber<uint32_t>(L, 3, 12000); pushBoolean(L, monster->changeTargetDistance(distance, duration)); } else { lua_pushnil(L); @@ -322,7 +322,7 @@ int MonsterFunctions::luaMonsterChangeTargetDistance(lua_State* L) { int MonsterFunctions::luaMonsterIsChallenged(lua_State* L) { // monster:isChallenged() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { pushBoolean(L, monster->isChallenged()); } else { @@ -333,9 +333,9 @@ int MonsterFunctions::luaMonsterIsChallenged(lua_State* L) { int MonsterFunctions::luaMonsterSelectTarget(lua_State* L) { // monster:selectTarget(creature) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); pushBoolean(L, monster->selectTarget(creature)); } else { lua_pushnil(L); @@ -345,9 +345,9 @@ int MonsterFunctions::luaMonsterSelectTarget(lua_State* L) { int MonsterFunctions::luaMonsterSearchTarget(lua_State* L) { // monster:searchTarget([searchType = TARGETSEARCH_DEFAULT]) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (monster) { - TargetSearchType_t searchType = getNumber<TargetSearchType_t>(L, 2, TARGETSEARCH_DEFAULT); + const auto &searchType = getNumber<TargetSearchType_t>(L, 2, TARGETSEARCH_DEFAULT); pushBoolean(L, monster->searchTarget(searchType)); } else { lua_pushnil(L); @@ -357,21 +357,21 @@ int MonsterFunctions::luaMonsterSearchTarget(lua_State* L) { int MonsterFunctions::luaMonsterSetSpawnPosition(lua_State* L) { // monster:setSpawnPosition(interval) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { lua_pushnil(L); return 1; } - uint32_t eventschedule = g_eventsScheduler().getSpawnMonsterSchedule(); + const uint32_t eventschedule = g_eventsScheduler().getSpawnMonsterSchedule(); const Position &pos = monster->getPosition(); monster->setMasterPos(pos); - SpawnMonster &spawnMonster = g_game().map.spawnsMonster.getspawnMonsterList().emplace_back(pos, 5); + const auto &spawnMonster = g_game().map.spawnsMonster.getspawnMonsterList().emplace_back(std::make_shared<SpawnMonster>(pos, 5)); uint32_t interval = getNumber<uint32_t>(L, 2, 90) * 1000 * 100 / std::max((uint32_t)1, (g_configManager().getNumber(RATE_SPAWN) * eventschedule)); - spawnMonster.addMonster(monster->mType->typeName, pos, DIRECTION_NORTH, static_cast<uint32_t>(interval)); - spawnMonster.startSpawnMonsterCheck(); + spawnMonster->addMonster(monster->mType->typeName, pos, DIRECTION_NORTH, static_cast<uint32_t>(interval)); + spawnMonster->startSpawnMonsterCheck(); pushBoolean(L, true); return 1; @@ -379,14 +379,14 @@ int MonsterFunctions::luaMonsterSetSpawnPosition(lua_State* L) { int MonsterFunctions::luaMonsterGetRespawnType(lua_State* L) { // monster:getRespawnType() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { lua_pushnil(L); return 1; } - RespawnType respawnType = monster->getRespawnType(); + const RespawnType respawnType = monster->getRespawnType(); lua_pushnumber(L, respawnType.period); pushBoolean(L, respawnType.underground); @@ -395,7 +395,7 @@ int MonsterFunctions::luaMonsterGetRespawnType(lua_State* L) { int MonsterFunctions::luaMonsterGetTimeToChangeFiendish(lua_State* L) { // monster:getTimeToChangeFiendish() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -408,8 +408,8 @@ int MonsterFunctions::luaMonsterGetTimeToChangeFiendish(lua_State* L) { int MonsterFunctions::luaMonsterSetTimeToChangeFiendish(lua_State* L) { // monster:setTimeToChangeFiendish(endTime) - time_t endTime = getNumber<uint32_t>(L, 2, 1); - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const time_t endTime = getNumber<uint32_t>(L, 2, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -422,22 +422,22 @@ int MonsterFunctions::luaMonsterSetTimeToChangeFiendish(lua_State* L) { int MonsterFunctions::luaMonsterGetMonsterForgeClassification(lua_State* L) { // monster:getMonsterForgeClassification() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); return 0; } - auto classification = static_cast<lua_Number>(monster->getMonsterForgeClassification()); + const auto classification = static_cast<lua_Number>(monster->getMonsterForgeClassification()); lua_pushnumber(L, classification); return 1; } int MonsterFunctions::luaMonsterSetMonsterForgeClassification(lua_State* L) { // monster:setMonsterForgeClassification(classication) - ForgeClassifications_t classification = getNumber<ForgeClassifications_t>(L, 2); - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const ForgeClassifications_t classification = getNumber<ForgeClassifications_t>(L, 2); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -450,7 +450,7 @@ int MonsterFunctions::luaMonsterSetMonsterForgeClassification(lua_State* L) { int MonsterFunctions::luaMonsterGetForgeStack(lua_State* L) { // monster:getForgeStack() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -463,8 +463,8 @@ int MonsterFunctions::luaMonsterGetForgeStack(lua_State* L) { int MonsterFunctions::luaMonsterSetForgeStack(lua_State* L) { // monster:setForgeStack(stack) - uint16_t stack = getNumber<uint16_t>(L, 2, 0); - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto stack = getNumber<uint16_t>(L, 2, 0); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -472,7 +472,7 @@ int MonsterFunctions::luaMonsterSetForgeStack(lua_State* L) { } monster->setForgeStack(stack); - auto icon = stack < 15 + const auto icon = stack < 15 ? CreatureIconModifications_t::Influenced : CreatureIconModifications_t::Fiendish; monster->setIcon("forge", CreatureIcon(icon, icon == CreatureIconModifications_t::Influenced ? static_cast<uint8_t>(stack) : 0)); @@ -483,7 +483,7 @@ int MonsterFunctions::luaMonsterSetForgeStack(lua_State* L) { int MonsterFunctions::luaMonsterConfigureForgeSystem(lua_State* L) { // monster:configureForgeSystem() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -496,7 +496,7 @@ int MonsterFunctions::luaMonsterConfigureForgeSystem(lua_State* L) { int MonsterFunctions::luaMonsterClearFiendishStatus(lua_State* L) { // monster:clearFiendishStatus() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -509,7 +509,7 @@ int MonsterFunctions::luaMonsterClearFiendishStatus(lua_State* L) { int MonsterFunctions::luaMonsterIsForgeable(lua_State* L) { // monster:isForgeable() - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -535,7 +535,7 @@ int MonsterFunctions::luaMonsterGetName(lua_State* L) { int MonsterFunctions::luaMonsterSetName(lua_State* L) { // monster:setName(name[, nameDescription]) - auto monster = getUserdataShared<Monster>(L, 1); + const auto &monster = getUserdataShared<Monster>(L, 1); if (!monster) { reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_NOT_FOUND)); pushBoolean(L, false); @@ -553,8 +553,8 @@ int MonsterFunctions::luaMonsterSetName(lua_State* L) { int MonsterFunctions::luaMonsterHazard(lua_State* L) { // get: monster:hazard() ; set: monster:hazard(hazard) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); - bool hazard = getBoolean(L, 2, false); + const auto &monster = getUserdataShared<Monster>(L, 1); + const bool hazard = getBoolean(L, 2, false); if (monster) { if (lua_gettop(L) == 1) { pushBoolean(L, monster->getHazard()); @@ -570,8 +570,8 @@ int MonsterFunctions::luaMonsterHazard(lua_State* L) { int MonsterFunctions::luaMonsterHazardCrit(lua_State* L) { // get: monster:hazardCrit() ; set: monster:hazardCrit(hazardCrit) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); - bool hazardCrit = getBoolean(L, 2, false); + const auto &monster = getUserdataShared<Monster>(L, 1); + const bool hazardCrit = getBoolean(L, 2, false); if (monster) { if (lua_gettop(L) == 1) { pushBoolean(L, monster->getHazardSystemCrit()); @@ -587,8 +587,8 @@ int MonsterFunctions::luaMonsterHazardCrit(lua_State* L) { int MonsterFunctions::luaMonsterHazardDodge(lua_State* L) { // get: monster:hazardDodge() ; set: monster:hazardDodge(hazardDodge) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); - bool hazardDodge = getBoolean(L, 2, false); + const auto &monster = getUserdataShared<Monster>(L, 1); + const bool hazardDodge = getBoolean(L, 2, false); if (monster) { if (lua_gettop(L) == 1) { pushBoolean(L, monster->getHazardSystemDodge()); @@ -604,8 +604,8 @@ int MonsterFunctions::luaMonsterHazardDodge(lua_State* L) { int MonsterFunctions::luaMonsterHazardDamageBoost(lua_State* L) { // get: monster:hazardDamageBoost() ; set: monster:hazardDamageBoost(hazardDamageBoost) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); - bool hazardDamageBoost = getBoolean(L, 2, false); + const auto &monster = getUserdataShared<Monster>(L, 1); + const bool hazardDamageBoost = getBoolean(L, 2, false); if (monster) { if (lua_gettop(L) == 1) { pushBoolean(L, monster->getHazardSystemDamageBoost()); @@ -621,8 +621,8 @@ int MonsterFunctions::luaMonsterHazardDamageBoost(lua_State* L) { int MonsterFunctions::luaMonsterHazardDefenseBoost(lua_State* L) { // get: monster:hazardDefenseBoost() ; set: monster:hazardDefenseBoost(hazardDefenseBoost) - std::shared_ptr<Monster> monster = getUserdataShared<Monster>(L, 1); - bool hazardDefenseBoost = getBoolean(L, 2, false); + const auto &monster = getUserdataShared<Monster>(L, 1); + const bool hazardDefenseBoost = getBoolean(L, 2, false); if (monster) { if (lua_gettop(L) == 1) { pushBoolean(L, monster->getHazardSystemDefenseBoost()); diff --git a/src/lua/functions/creatures/monster/monster_functions.hpp b/src/lua/functions/creatures/monster/monster_functions.hpp index 90f2b526ca4..0674bf64433 100644 --- a/src/lua/functions/creatures/monster/monster_functions.hpp +++ b/src/lua/functions/creatures/monster/monster_functions.hpp @@ -17,6 +17,12 @@ class MonsterFunctions final : LuaScriptInterface { private: + explicit MonsterFunctions(lua_State* L) : + LuaScriptInterface("MonsterFunctions") { + init(L); + } + ~MonsterFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Monster", "Creature", MonsterFunctions::luaMonsterCreate); registerMetaMethod(L, "Monster", "__eq", MonsterFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/monster/monster_spell_functions.cpp b/src/lua/functions/creatures/monster/monster_spell_functions.cpp index e9beb607bfc..63834d0701f 100644 --- a/src/lua/functions/creatures/monster/monster_spell_functions.cpp +++ b/src/lua/functions/creatures/monster/monster_spell_functions.cpp @@ -19,7 +19,7 @@ int MonsterSpellFunctions::luaCreateMonsterSpell(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetType(lua_State* L) { // monsterSpell:setType(type) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->name = getString(L, 2); pushBoolean(L, true); @@ -31,7 +31,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetType(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetScriptName(lua_State* L) { // monsterSpell:setScriptName(name) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->scriptName = getString(L, 2); pushBoolean(L, true); @@ -43,7 +43,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetScriptName(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetChance(lua_State* L) { // monsterSpell:setChance(chance) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->chance = getNumber<uint8_t>(L, 2); pushBoolean(L, true); @@ -55,7 +55,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetChance(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetInterval(lua_State* L) { // monsterSpell:setInterval(interval) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->interval = getNumber<uint16_t>(L, 2); pushBoolean(L, true); @@ -67,7 +67,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetInterval(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetRange(lua_State* L) { // monsterSpell:setRange(range) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->range = getNumber<uint8_t>(L, 2); pushBoolean(L, true); @@ -79,7 +79,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetRange(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetCombatValue(lua_State* L) { // monsterSpell:setCombatValue(min, max) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->minCombatValue = getNumber<int32_t>(L, 2); spell->maxCombatValue = getNumber<int32_t>(L, 3); @@ -92,7 +92,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetCombatValue(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetCombatType(lua_State* L) { // monsterSpell:setCombatType(combatType_t) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->combatType = getNumber<CombatType_t>(L, 2); pushBoolean(L, true); @@ -104,7 +104,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetCombatType(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetAttackValue(lua_State* L) { // monsterSpell:setAttackValue(attack, skill) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->attack = getNumber<int32_t>(L, 2); spell->skill = getNumber<int32_t>(L, 3); @@ -117,7 +117,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetAttackValue(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetNeedTarget(lua_State* L) { // monsterSpell:setNeedTarget(bool) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->needTarget = getBoolean(L, 2); pushBoolean(L, true); @@ -129,7 +129,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetNeedTarget(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetCombatLength(lua_State* L) { // monsterSpell:setCombatLength(length) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->length = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -141,7 +141,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetCombatLength(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetCombatSpread(lua_State* L) { // monsterSpell:setCombatSpread(spread) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->spread = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -153,7 +153,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetCombatSpread(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetCombatRadius(lua_State* L) { // monsterSpell:setCombatRadius(radius) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->radius = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -165,7 +165,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetCombatRadius(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetConditionType(lua_State* L) { // monsterSpell:setConditionType(type) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { auto conditionType = getNumber<uint8_t>(L, 2); if (conditionType == 254) { @@ -185,7 +185,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetConditionType(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetConditionDamage(lua_State* L) { // monsterSpell:setConditionDamage(min, max, start) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->conditionMinDamage = getNumber<int32_t>(L, 2); spell->conditionMaxDamage = getNumber<int32_t>(L, 3); @@ -199,7 +199,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetConditionDamage(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetConditionSpeedChange(lua_State* L) { // monsterSpell:setConditionSpeedChange(speed) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->speedChange = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -211,7 +211,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetConditionSpeedChange(lua_State* L) int MonsterSpellFunctions::luaMonsterSpellSetConditionDuration(lua_State* L) { // monsterSpell:setConditionDuration(duration) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->duration = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -223,7 +223,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetConditionDuration(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetConditionTickInterval(lua_State* L) { // monsterSpell:setConditionTickInterval(interval) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->tickInterval = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -235,7 +235,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetConditionTickInterval(lua_State* L) int MonsterSpellFunctions::luaMonsterSpellSetCombatShootEffect(lua_State* L) { // monsterSpell:setCombatShootEffect(effect) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->shoot = getNumber<ShootType_t>(L, 2); pushBoolean(L, true); @@ -247,7 +247,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetCombatShootEffect(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetCombatEffect(lua_State* L) { // monsterSpell:setCombatEffect(effect) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->effect = getNumber<MagicEffectClasses>(L, 2); pushBoolean(L, true); @@ -259,7 +259,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetCombatEffect(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetOutfitMonster(lua_State* L) { // monsterSpell:setOutfitMonster(effect) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->outfitMonster = getString(L, 2); pushBoolean(L, true); @@ -271,7 +271,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetOutfitMonster(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellSetOutfitItem(lua_State* L) { // monsterSpell:setOutfitItem(effect) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (spell) { spell->outfitItem = getNumber<uint16_t>(L, 2); pushBoolean(L, true); @@ -283,7 +283,7 @@ int MonsterSpellFunctions::luaMonsterSpellSetOutfitItem(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellCastSound(lua_State* L) { // get: monsterSpell:castSound() set: monsterSpell:castSound(sound) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, static_cast<lua_Number>(spell->soundCastEffect)); } else { @@ -295,7 +295,7 @@ int MonsterSpellFunctions::luaMonsterSpellCastSound(lua_State* L) { int MonsterSpellFunctions::luaMonsterSpellImpactSound(lua_State* L) { // get: monsterSpell:impactSound() set: monsterSpell:impactSound(sound) - const auto spell = getUserdataShared<MonsterSpell>(L, 1); + const auto &spell = getUserdataShared<MonsterSpell>(L, 1); if (lua_gettop(L) == 1) { lua_pushnumber(L, static_cast<lua_Number>(spell->soundImpactEffect)); } else { diff --git a/src/lua/functions/creatures/monster/monster_spell_functions.hpp b/src/lua/functions/creatures/monster/monster_spell_functions.hpp index ad737ea9326..e44c5e53470 100644 --- a/src/lua/functions/creatures/monster/monster_spell_functions.hpp +++ b/src/lua/functions/creatures/monster/monster_spell_functions.hpp @@ -13,8 +13,14 @@ class MonsterSpellFunctions final : LuaScriptInterface { public: + explicit MonsterSpellFunctions(lua_State* L) : + LuaScriptInterface("MonsterSpellFunctions") { + init(L); + } + ~MonsterSpellFunctions() override = default; + static void init(lua_State* L) { - registerClass(L, "MonsterSpell", "", MonsterSpellFunctions::luaCreateMonsterSpell); + registerSharedClass(L, "MonsterSpell", "", MonsterSpellFunctions::luaCreateMonsterSpell); registerMethod(L, "MonsterSpell", "setType", MonsterSpellFunctions::luaMonsterSpellSetType); registerMethod(L, "MonsterSpell", "setScriptName", MonsterSpellFunctions::luaMonsterSpellSetScriptName); diff --git a/src/lua/functions/creatures/monster/monster_type_functions.cpp b/src/lua/functions/creatures/monster/monster_type_functions.cpp index 1881e98653c..134b1fa48b9 100644 --- a/src/lua/functions/creatures/monster/monster_type_functions.cpp +++ b/src/lua/functions/creatures/monster/monster_type_functions.cpp @@ -41,7 +41,7 @@ void MonsterTypeFunctions::createMonsterTypeLootLuaTable(lua_State* L, const std int MonsterTypeFunctions::luaMonsterTypeCreate(lua_State* L) { // MonsterType(name or raceid) - std::shared_ptr<MonsterType> monsterType = nullptr; + std::shared_ptr<MonsterType> monsterType; if (isNumber(L, 2)) { monsterType = g_monsters().getMonsterTypeByRaceId(getNumber<uint16_t>(L, 2)); } else { @@ -59,7 +59,7 @@ int MonsterTypeFunctions::luaMonsterTypeCreate(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsAttackable(lua_State* L) { // get: monsterType:isAttackable() set: monsterType:isAttackable(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isAttackable); @@ -75,7 +75,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsAttackable(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsConvinceable(lua_State* L) { // get: monsterType:isConvinceable() set: monsterType:isConvinceable(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isConvinceable); @@ -91,7 +91,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsConvinceable(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsSummonable(lua_State* L) { // get: monsterType:isSummonable() set: monsterType:isSummonable(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isSummonable); @@ -107,7 +107,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsSummonable(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsPreyExclusive(lua_State* L) { // get: monsterType:isPreyExclusive() set: monsterType:isPreyExclusive(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isPreyExclusive); @@ -123,7 +123,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsPreyExclusive(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsPreyable(lua_State* L) { // get: monsterType:isPreyable() set: monsterType:isPreyable(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isPreyable); @@ -139,7 +139,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsPreyable(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsIllusionable(lua_State* L) { // get: monsterType:isIllusionable() set: monsterType:isIllusionable(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isIllusionable); @@ -155,7 +155,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsIllusionable(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsHostile(lua_State* L) { // get: monsterType:isHostile() set: monsterType:isHostile(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isHostile); @@ -171,7 +171,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsHostile(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeFamiliar(lua_State* L) { // get: monsterType:familiar() set: monsterType:familiar(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isFamiliar); @@ -187,7 +187,7 @@ int MonsterTypeFunctions::luaMonsterTypeFamiliar(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsRewardBoss(lua_State* L) { // get: monsterType:isRewardBoss() set: monsterType:isRewardBoss(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isRewardBoss); @@ -203,7 +203,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsRewardBoss(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsPushable(lua_State* L) { // get: monsterType:isPushable() set: monsterType:isPushable(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.pushable); @@ -219,7 +219,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsPushable(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsHealthHidden(lua_State* L) { // get: monsterType:isHealthHidden() set: monsterType:isHealthHidden(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.hiddenHealth); @@ -235,7 +235,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsHealthHidden(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsBlockable(lua_State* L) { // get: monsterType:isBlockable() set: monsterType:isBlockable(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.isBlockable); @@ -251,7 +251,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsBlockable(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeIsForgeCreature(lua_State* L) { // get: monsterType:isForgeCreature() set: monsterType:isForgeCreature(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_TYPE_NOT_FOUND)); @@ -269,7 +269,7 @@ int MonsterTypeFunctions::luaMonsterTypeIsForgeCreature(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCanSpawn(lua_State* L) { // monsterType:canSpawn(pos) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); const Position &position = getPosition(L, 2); if (monsterType) { pushBoolean(L, monsterType->canSpawn(position)); @@ -281,7 +281,7 @@ int MonsterTypeFunctions::luaMonsterTypeCanSpawn(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCanPushItems(lua_State* L) { // get: monsterType:canPushItems() set: monsterType:canPushItems(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.canPushItems); @@ -297,7 +297,7 @@ int MonsterTypeFunctions::luaMonsterTypeCanPushItems(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCanPushCreatures(lua_State* L) { // get: monsterType:canPushCreatures() set: monsterType:canPushCreatures(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.canPushCreatures); @@ -313,7 +313,7 @@ int MonsterTypeFunctions::luaMonsterTypeCanPushCreatures(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCritChance(lua_State* L) { // get: monsterType:critChance() set: monsterType:critChance(int) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 2) { monsterType->info.critChance = getNumber<uint16_t>(L, 2); @@ -327,7 +327,7 @@ int MonsterTypeFunctions::luaMonsterTypeCritChance(lua_State* L) { int32_t MonsterTypeFunctions::luaMonsterTypeName(lua_State* L) { // get: monsterType:name() set: monsterType:name(name) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushString(L, monsterType->name); @@ -343,7 +343,7 @@ int32_t MonsterTypeFunctions::luaMonsterTypeName(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeNameDescription(lua_State* L) { // get: monsterType:nameDescription() set: monsterType:nameDescription(desc) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushString(L, monsterType->nameDescription); @@ -359,7 +359,7 @@ int MonsterTypeFunctions::luaMonsterTypeNameDescription(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypegetCorpseId(lua_State* L) { // monsterType:getCorpseId() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { lua_pushnumber(L, monsterType->info.lookcorpse); } else { @@ -370,7 +370,7 @@ int MonsterTypeFunctions::luaMonsterTypegetCorpseId(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeHealth(lua_State* L) { // get: monsterType:health() set: monsterType:health(health) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.health); @@ -386,7 +386,7 @@ int MonsterTypeFunctions::luaMonsterTypeHealth(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeMaxHealth(lua_State* L) { // get: monsterType:maxHealth() set: monsterType:maxHealth(health) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.healthMax); @@ -402,7 +402,7 @@ int MonsterTypeFunctions::luaMonsterTypeMaxHealth(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeRunHealth(lua_State* L) { // get: monsterType:runHealth() set: monsterType:runHealth(health) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.runAwayHealth); @@ -418,7 +418,7 @@ int MonsterTypeFunctions::luaMonsterTypeRunHealth(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeExperience(lua_State* L) { // get: monsterType:experience() set: monsterType:experience(exp) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.experience); @@ -434,7 +434,7 @@ int MonsterTypeFunctions::luaMonsterTypeExperience(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeFaction(lua_State* L) { // get: monsterType:faction() set: monsterType:faction(faction) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.faction); @@ -450,7 +450,7 @@ int MonsterTypeFunctions::luaMonsterTypeFaction(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeEnemyFactions(lua_State* L) { // get: monsterType:enemyFactions() set: monsterType:enemyFactions(enemyFaction) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_createtable(L, monsterType->info.enemyFactions.size(), 0); @@ -461,7 +461,7 @@ int MonsterTypeFunctions::luaMonsterTypeEnemyFactions(lua_State* L) { lua_rawseti(L, -2, ++index); } } else { - Faction_t faction = getNumber<Faction_t>(L, 2); + const Faction_t faction = getNumber<Faction_t>(L, 2); monsterType->info.enemyFactions.insert(faction); pushBoolean(L, true); } @@ -473,7 +473,7 @@ int MonsterTypeFunctions::luaMonsterTypeEnemyFactions(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeTargetPreferPlayer(lua_State* L) { // get: monsterType:targetPreferPlayer() set: monsterType:targetPreferPlayer(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushboolean(L, monsterType->info.targetPreferPlayer); @@ -489,7 +489,7 @@ int MonsterTypeFunctions::luaMonsterTypeTargetPreferPlayer(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeTargetPreferMaster(lua_State* L) { // get: monsterType:targetPreferMaster() set: monsterType:targetPreferMaster(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.faction); @@ -505,7 +505,7 @@ int MonsterTypeFunctions::luaMonsterTypeTargetPreferMaster(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeRaceid(lua_State* L) { // get: monsterType:raceId() set: monsterType:raceId(id) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.raceid); @@ -522,7 +522,7 @@ int MonsterTypeFunctions::luaMonsterTypeRaceid(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiarytoKill(lua_State* L) { // get: monsterType:BestiarytoKill() set: monsterType:BestiarytoKill(value) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.bestiaryToUnlock); @@ -538,7 +538,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiarytoKill(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiaryFirstUnlock(lua_State* L) { // get: monsterType:BestiaryFirstUnlock() set: monsterType:BestiaryFirstUnlock(value) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.bestiaryFirstUnlock); @@ -554,7 +554,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiaryFirstUnlock(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiarySecondUnlock(lua_State* L) { // get: monsterType:BestiarySecondUnlock() set: monsterType:BestiarySecondUnlock(value) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.bestiarySecondUnlock); @@ -570,7 +570,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiarySecondUnlock(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiaryCharmsPoints(lua_State* L) { // get: monsterType:BestiaryCharmsPoints() set: monsterType:BestiaryCharmsPoints(value) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.bestiaryCharmsPoints); @@ -586,7 +586,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiaryCharmsPoints(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiaryStars(lua_State* L) { // get: monsterType:BestiaryStars() set: monsterType:BestiaryStars(value) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.bestiaryStars); @@ -602,7 +602,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiaryStars(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiaryOccurrence(lua_State* L) { // get: monsterType:BestiaryOccurrence() set: monsterType:BestiaryOccurrence(value) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.bestiaryOccurrence); @@ -618,7 +618,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiaryOccurrence(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiaryLocations(lua_State* L) { // get: monsterType:BestiaryLocations() set: monsterType:BestiaryLocations(string) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushString(L, monsterType->info.bestiaryLocations); @@ -634,7 +634,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiaryLocations(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiaryclass(lua_State* L) { // get: monsterType:Bestiaryclass() set: monsterType:Bestiaryclass(string) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushString(L, monsterType->info.bestiaryClass); @@ -650,12 +650,12 @@ int MonsterTypeFunctions::luaMonsterTypeBestiaryclass(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBestiaryrace(lua_State* L) { // get: monsterType:Bestiaryrace() set: monsterType:Bestiaryrace(raceid) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.bestiaryRace); } else { - BestiaryType_t race = getNumber<BestiaryType_t>(L, 2); + const BestiaryType_t race = getNumber<BestiaryType_t>(L, 2); monsterType->info.bestiaryRace = race; pushBoolean(L, true); } @@ -667,7 +667,7 @@ int MonsterTypeFunctions::luaMonsterTypeBestiaryrace(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCombatImmunities(lua_State* L) { // get: monsterType:combatImmunities() set: monsterType:combatImmunities(immunity) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_TYPE_NOT_FOUND)); @@ -723,7 +723,7 @@ int MonsterTypeFunctions::luaMonsterTypeCombatImmunities(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeConditionImmunities(lua_State* L) { // get: monsterType:conditionImmunities() set: monsterType:conditionImmunities(immunity) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_TYPE_NOT_FOUND)); @@ -781,7 +781,7 @@ int MonsterTypeFunctions::luaMonsterTypeConditionImmunities(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetAttackList(lua_State* L) { // monsterType:getAttackList() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -811,9 +811,9 @@ int MonsterTypeFunctions::luaMonsterTypeGetAttackList(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddAttack(lua_State* L) { // monsterType:addAttack(monsterspell) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { - const auto spell = getUserdataShared<MonsterSpell>(L, 2); + const auto &spell = getUserdataShared<MonsterSpell>(L, 2); if (spell) { spellBlock_t sb; if (g_monsters().deserializeSpell(spell, sb, monsterType->name)) { @@ -832,7 +832,7 @@ int MonsterTypeFunctions::luaMonsterTypeAddAttack(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetDefenseList(lua_State* L) { // monsterType:getDefenseList() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -862,7 +862,7 @@ int MonsterTypeFunctions::luaMonsterTypeGetDefenseList(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetTypeName(lua_State* L) { // monsterType:getTypeName() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { return 1; } @@ -873,9 +873,9 @@ int MonsterTypeFunctions::luaMonsterTypeGetTypeName(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddDefense(lua_State* L) { // monsterType:addDefense(monsterspell) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { - const auto spell = getUserdataShared<MonsterSpell>(L, 2); + const auto &spell = getUserdataShared<MonsterSpell>(L, 2); if (spell) { spellBlock_t sb; if (g_monsters().deserializeSpell(spell, sb, monsterType->name)) { @@ -894,9 +894,9 @@ int MonsterTypeFunctions::luaMonsterTypeAddDefense(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddElement(lua_State* L) { // monsterType:addElement(type, percent) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { - CombatType_t element = getNumber<CombatType_t>(L, 2); + const CombatType_t element = getNumber<CombatType_t>(L, 2); monsterType->info.elementMap[element] = getNumber<int32_t>(L, 3); pushBoolean(L, true); } else { @@ -907,9 +907,9 @@ int MonsterTypeFunctions::luaMonsterTypeAddElement(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddReflect(lua_State* L) { // monsterType:addReflect(type, percent) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { - CombatType_t element = getNumber<CombatType_t>(L, 2); + const CombatType_t element = getNumber<CombatType_t>(L, 2); monsterType->info.reflectMap[element] = getNumber<int32_t>(L, 3); pushBoolean(L, true); } else { @@ -920,9 +920,9 @@ int MonsterTypeFunctions::luaMonsterTypeAddReflect(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddHealing(lua_State* L) { // monsterType:addHealing(type, percent) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { - CombatType_t element = getNumber<CombatType_t>(L, 2); + const CombatType_t element = getNumber<CombatType_t>(L, 2); monsterType->info.healingMap[element] = getNumber<int32_t>(L, 3); pushBoolean(L, true); } else { @@ -933,7 +933,7 @@ int MonsterTypeFunctions::luaMonsterTypeAddHealing(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetElementList(lua_State* L) { // monsterType:getElementList() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -949,7 +949,7 @@ int MonsterTypeFunctions::luaMonsterTypeGetElementList(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddVoice(lua_State* L) { // monsterType:addVoice(sentence, interval, chance, yell) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { voiceBlock_t voice; voice.text = getString(L, 2); @@ -966,7 +966,7 @@ int MonsterTypeFunctions::luaMonsterTypeAddVoice(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetVoices(lua_State* L) { // monsterType:getVoices() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -985,7 +985,7 @@ int MonsterTypeFunctions::luaMonsterTypeGetVoices(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetLoot(lua_State* L) { // monsterType:getLoot() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -997,9 +997,9 @@ int MonsterTypeFunctions::luaMonsterTypeGetLoot(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddLoot(lua_State* L) { // monsterType:addLoot(loot) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { - const auto loot = getUserdataShared<Loot>(L, 2); + const auto &loot = getUserdataShared<Loot>(L, 2); if (loot) { monsterType->loadLoot(monsterType, loot->lootBlock); pushBoolean(L, true); @@ -1014,7 +1014,7 @@ int MonsterTypeFunctions::luaMonsterTypeAddLoot(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetCreatureEvents(lua_State* L) { // monsterType:getCreatureEvents() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -1031,9 +1031,9 @@ int MonsterTypeFunctions::luaMonsterTypeGetCreatureEvents(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeRegisterEvent(lua_State* L) { // monsterType:registerEvent(name) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { - auto eventName = getString(L, 2); + const auto eventName = getString(L, 2); monsterType->info.scripts.insert(eventName); for (const auto &[_, monster] : g_game().getMonsters()) { if (monster->getMonsterType() == monsterType) { @@ -1055,7 +1055,7 @@ int MonsterTypeFunctions::luaMonsterTypeEventOnCallback(lua_State* L) { // monsterType:onSay(callback) // monsterType:onPlayerAttack(callback) // monsterType:onSpawn(callback) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (monsterType->loadCallback(&g_scripts().getScriptInterface())) { pushBoolean(L, true); @@ -1070,7 +1070,7 @@ int MonsterTypeFunctions::luaMonsterTypeEventOnCallback(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeEventType(lua_State* L) { // monstertype:eventType(event) - const auto mType = getUserdataShared<MonsterType>(L, 1); + const auto &mType = getUserdataShared<MonsterType>(L, 1); if (mType) { mType->info.eventType = getNumber<MonstersEvent_t>(L, 2); pushBoolean(L, true); @@ -1082,7 +1082,7 @@ int MonsterTypeFunctions::luaMonsterTypeEventType(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetSummonList(lua_State* L) { // monsterType:getSummonList() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -1102,7 +1102,7 @@ int MonsterTypeFunctions::luaMonsterTypeGetSummonList(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddSummon(lua_State* L) { // monsterType:addSummon(name, interval, chance[, count = 1]) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { summonBlock_t summon; summon.name = getString(L, 2); @@ -1119,7 +1119,7 @@ int MonsterTypeFunctions::luaMonsterTypeAddSummon(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeMaxSummons(lua_State* L) { // get: monsterType:maxSummons() set: monsterType:maxSummons(ammount) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.maxSummons); @@ -1135,7 +1135,7 @@ int MonsterTypeFunctions::luaMonsterTypeMaxSummons(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeArmor(lua_State* L) { // get: monsterType:armor() set: monsterType:armor(armor) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.armor); @@ -1151,7 +1151,7 @@ int MonsterTypeFunctions::luaMonsterTypeArmor(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeMitigation(lua_State* L) { // get: monsterType:mitigation() set: monsterType:mitigation(mitigation) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_TYPE_NOT_FOUND)); @@ -1169,7 +1169,7 @@ int MonsterTypeFunctions::luaMonsterTypeMitigation(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeDefense(lua_State* L) { // get: monsterType:defense() set: monsterType:defense(defense) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.defense); @@ -1185,7 +1185,7 @@ int MonsterTypeFunctions::luaMonsterTypeDefense(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeOutfit(lua_State* L) { // get: monsterType:outfit() set: monsterType:outfit(outfit) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushOutfit(L, monsterType->info.outfit); @@ -1207,7 +1207,7 @@ int MonsterTypeFunctions::luaMonsterTypeOutfit(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeRace(lua_State* L) { // get: monsterType:race() set: monsterType:race(race) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); std::string race = getString(L, 2); if (monsterType) { if (lua_gettop(L) == 1) { @@ -1242,7 +1242,7 @@ int MonsterTypeFunctions::luaMonsterTypeRace(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCorpseId(lua_State* L) { // get: monsterType:corpseId() set: monsterType:corpseId(id) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.lookcorpse); @@ -1258,7 +1258,7 @@ int MonsterTypeFunctions::luaMonsterTypeCorpseId(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeManaCost(lua_State* L) { // get: monsterType:manaCost() set: monsterType:manaCost(mana) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.manaCost); @@ -1274,7 +1274,7 @@ int MonsterTypeFunctions::luaMonsterTypeManaCost(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBaseSpeed(lua_State* L) { // monsterType:baseSpeed() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->getBaseSpeed()); @@ -1289,7 +1289,7 @@ int MonsterTypeFunctions::luaMonsterTypeBaseSpeed(lua_State* L) { } int MonsterTypeFunctions::luaMonsterTypeLight(lua_State* L) { // get: monsterType:light() set: monsterType:light(color, level) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -1309,7 +1309,7 @@ int MonsterTypeFunctions::luaMonsterTypeLight(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeStaticAttackChance(lua_State* L) { // get: monsterType:staticAttackChance() set: monsterType:staticAttackChance(chance) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.staticAttackChance); @@ -1325,7 +1325,7 @@ int MonsterTypeFunctions::luaMonsterTypeStaticAttackChance(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeTargetDistance(lua_State* L) { // get: monsterType:targetDistance() set: monsterType:targetDistance(distance) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.targetDistance); @@ -1341,7 +1341,7 @@ int MonsterTypeFunctions::luaMonsterTypeTargetDistance(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeYellChance(lua_State* L) { // get: monsterType:yellChance() set: monsterType:yellChance(chance) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { if (lua_gettop(L) == 1) { @@ -1362,7 +1362,7 @@ int MonsterTypeFunctions::luaMonsterTypeYellChance(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeYellSpeedTicks(lua_State* L) { // get: monsterType:yellSpeedTicks() set: monsterType:yellSpeedTicks(rate) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.yellSpeedTicks); @@ -1378,7 +1378,7 @@ int MonsterTypeFunctions::luaMonsterTypeYellSpeedTicks(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeChangeTargetChance(lua_State* L) { // monsterType:getChangeTargetChance() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.changeTargetChance); @@ -1394,7 +1394,7 @@ int MonsterTypeFunctions::luaMonsterTypeChangeTargetChance(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeChangeTargetSpeed(lua_State* L) { // get: monsterType:changeTargetSpeed() set: monsterType:changeTargetSpeed(speed) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.changeTargetSpeed); @@ -1410,7 +1410,7 @@ int MonsterTypeFunctions::luaMonsterTypeChangeTargetSpeed(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCanWalkOnEnergy(lua_State* L) { // get: monsterType:canWalkOnEnergy() set: monsterType:canWalkOnEnergy(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.canWalkOnEnergy); @@ -1426,7 +1426,7 @@ int MonsterTypeFunctions::luaMonsterTypeCanWalkOnEnergy(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCanWalkOnFire(lua_State* L) { // get: monsterType:canWalkOnFire() set: monsterType:canWalkOnFire(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.canWalkOnFire); @@ -1442,7 +1442,7 @@ int MonsterTypeFunctions::luaMonsterTypeCanWalkOnFire(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeCanWalkOnPoison(lua_State* L) { // get: monsterType:canWalkOnPoison() set: monsterType:canWalkOnPoison(bool) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { pushBoolean(L, monsterType->info.canWalkOnPoison); @@ -1458,7 +1458,7 @@ int MonsterTypeFunctions::luaMonsterTypeCanWalkOnPoison(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetNearest(lua_State* L) { // monsterType:strategiesTargetNearest() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.strategiesTargetNearest); @@ -1474,7 +1474,7 @@ int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetNearest(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetHealth(lua_State* L) { // monsterType:strategiesTargetHealth() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.strategiesTargetHealth); @@ -1490,7 +1490,7 @@ int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetHealth(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetDamage(lua_State* L) { // monsterType:strategiesTargetDamage() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.strategiesTargetDamage); @@ -1506,7 +1506,7 @@ int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetDamage(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetRandom(lua_State* L) { // monsterType:strategiesTargetRandom() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.strategiesTargetRandom); @@ -1526,7 +1526,7 @@ int MonsterTypeFunctions::luaMonsterTypeStrategiesTargetRandom(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeRespawnTypePeriod(lua_State* L) { // monsterType:respawnTypePeriod() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.respawnType.period); @@ -1542,7 +1542,7 @@ int MonsterTypeFunctions::luaMonsterTypeRespawnTypePeriod(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeRespawnTypeIsUnderground(lua_State* L) { // monsterType:respawnTypeIsUnderground() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (monsterType) { if (lua_gettop(L) == 1) { lua_pushnumber(L, monsterType->info.respawnType.underground); @@ -1559,7 +1559,7 @@ int MonsterTypeFunctions::luaMonsterTypeRespawnTypeIsUnderground(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBossRace(lua_State* L) { // set: monsterType:bosstiaryRace(raceId, class) // get: monsterType:bosstiaryRace() = this return only class name - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_TYPE_NOT_FOUND)); @@ -1573,8 +1573,8 @@ int MonsterTypeFunctions::luaMonsterTypeBossRace(lua_State* L) { } pushString(L, monsterType->info.bosstiaryClass); } else { - auto bossRace = getNumber<uint8_t>(L, 2, 0); - auto bossClass = getString(L, 3); + const auto bossRace = getNumber<uint8_t>(L, 2, 0); + const auto bossClass = getString(L, 3); monsterType->info.bosstiaryRace = magic_enum::enum_value<BosstiaryRarity_t>(bossRace); monsterType->info.bosstiaryClass = bossClass; pushBoolean(L, true); @@ -1586,7 +1586,7 @@ int MonsterTypeFunctions::luaMonsterTypeBossRace(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeBossRaceId(lua_State* L) { // set: monsterType:bossRaceId(raceId) // get: monsterType:bossRaceId() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_MONSTER_TYPE_NOT_FOUND)); @@ -1600,7 +1600,7 @@ int MonsterTypeFunctions::luaMonsterTypeBossRaceId(lua_State* L) { lua_pushnumber(L, static_cast<lua_Number>(monsterType->info.bosstiaryRace)); } } else { - auto raceId = getNumber<uint16_t>(L, 2, 0); + const auto raceId = getNumber<uint16_t>(L, 2, 0); monsterType->info.raceid = raceId; g_ioBosstiary().addBosstiaryMonster(raceId, monsterType->typeName); pushBoolean(L, true); @@ -1611,7 +1611,7 @@ int MonsterTypeFunctions::luaMonsterTypeBossRaceId(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeSoundChance(lua_State* L) { // get: monsterType:soundChance() set: monsterType:soundChance(chance) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1629,7 +1629,7 @@ int MonsterTypeFunctions::luaMonsterTypeSoundChance(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeSoundSpeedTicks(lua_State* L) { // get: monsterType:soundSpeedTicks() set: monsterType:soundSpeedTicks(ticks) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1647,7 +1647,7 @@ int MonsterTypeFunctions::luaMonsterTypeSoundSpeedTicks(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeAddSound(lua_State* L) { // monsterType:addSound(soundId) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1661,7 +1661,7 @@ int MonsterTypeFunctions::luaMonsterTypeAddSound(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeGetSounds(lua_State* L) { // monsterType:getSounds() - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { lua_pushnil(L); return 1; @@ -1680,7 +1680,7 @@ int MonsterTypeFunctions::luaMonsterTypeGetSounds(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypedeathSound(lua_State* L) { // get: monsterType:deathSound() set: monsterType:deathSound(sound) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -1699,7 +1699,7 @@ int MonsterTypeFunctions::luaMonsterTypedeathSound(lua_State* L) { int MonsterTypeFunctions::luaMonsterTypeVariant(lua_State* L) { // get: monsterType:variant() set: monsterType:variant(variantName) - const auto monsterType = getUserdataShared<MonsterType>(L, 1); + const auto &monsterType = getUserdataShared<MonsterType>(L, 1); if (!monsterType) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); diff --git a/src/lua/functions/creatures/monster/monster_type_functions.hpp b/src/lua/functions/creatures/monster/monster_type_functions.hpp index 6923740db41..a10f1619d61 100644 --- a/src/lua/functions/creatures/monster/monster_type_functions.hpp +++ b/src/lua/functions/creatures/monster/monster_type_functions.hpp @@ -13,6 +13,12 @@ class MonsterTypeFunctions final : LuaScriptInterface { public: + explicit MonsterTypeFunctions(lua_State* L) : + LuaScriptInterface("MonsterTypeFunctions") { + init(L); + } + ~MonsterTypeFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "MonsterType", "", MonsterTypeFunctions::luaMonsterTypeCreate); registerMetaMethod(L, "MonsterType", "__eq", MonsterTypeFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/npc/npc_functions.cpp b/src/lua/functions/creatures/npc/npc_functions.cpp index b18814cdae7..d4b18072612 100644 --- a/src/lua/functions/creatures/npc/npc_functions.cpp +++ b/src/lua/functions/creatures/npc/npc_functions.cpp @@ -51,7 +51,7 @@ int NpcFunctions::luaNpcIsNpc(lua_State* L) { int NpcFunctions::luaNpcSetMasterPos(lua_State* L) { // npc:setMasterPos(pos) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); pushBoolean(L, false); @@ -66,7 +66,7 @@ int NpcFunctions::luaNpcSetMasterPos(lua_State* L) { int NpcFunctions::luaNpcGetCurrency(lua_State* L) { // npc:getCurrency() - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); lua_pushnil(L); @@ -78,7 +78,7 @@ int NpcFunctions::luaNpcGetCurrency(lua_State* L) { int NpcFunctions::luaNpcSetCurrency(lua_State* L) { // npc:getCurrency() - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); pushBoolean(L, false); @@ -91,7 +91,7 @@ int NpcFunctions::luaNpcSetCurrency(lua_State* L) { int NpcFunctions::luaNpcGetSpeechBubble(lua_State* L) { // npc:getSpeechBubble() - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); lua_pushnil(L); @@ -103,7 +103,7 @@ int NpcFunctions::luaNpcGetSpeechBubble(lua_State* L) { int NpcFunctions::luaNpcSetSpeechBubble(lua_State* L) { // npc:setSpeechBubble(speechBubble) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); lua_pushnil(L); @@ -115,7 +115,7 @@ int NpcFunctions::luaNpcSetSpeechBubble(lua_State* L) { int NpcFunctions::luaNpcGetName(lua_State* L) { // npc:getName() - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); lua_pushnil(L); @@ -128,7 +128,7 @@ int NpcFunctions::luaNpcGetName(lua_State* L) { int NpcFunctions::luaNpcSetName(lua_State* L) { // npc:setName(name) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); const std::string &name = getString(L, 2); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); @@ -141,7 +141,7 @@ int NpcFunctions::luaNpcSetName(lua_State* L) { int NpcFunctions::luaNpcPlace(lua_State* L) { // npc:place(position[, extended = false[, force = true]]) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); lua_pushnil(L); @@ -149,8 +149,8 @@ int NpcFunctions::luaNpcPlace(lua_State* L) { } const Position &position = getPosition(L, 2); - bool extended = getBoolean(L, 3, false); - bool force = getBoolean(L, 4, true); + const bool extended = getBoolean(L, 3, false); + const bool force = getBoolean(L, 4, true); if (g_game().placeCreature(npc, position, extended, force)) { pushUserdata<Npc>(L, npc); setMetatable(L, -1, "Npc"); @@ -162,7 +162,7 @@ int NpcFunctions::luaNpcPlace(lua_State* L) { int NpcFunctions::luaNpcSay(lua_State* L) { // npc:say(text[, type = TALKTYPE_PRIVATE_NP[, ghost = false[, target = nullptr[, position]]]]) - int parameters = lua_gettop(L); + const int parameters = lua_gettop(L); Position position; if (parameters >= 6) { @@ -179,11 +179,11 @@ int NpcFunctions::luaNpcSay(lua_State* L) { target = getCreature(L, 5); } - bool ghost = getBoolean(L, 4, false); + const bool ghost = getBoolean(L, 4, false); - SpeakClasses type = getNumber<SpeakClasses>(L, 3, TALKTYPE_PRIVATE_NP); + const auto &type = getNumber<SpeakClasses>(L, 3, TALKTYPE_PRIVATE_NP); const std::string &text = getString(L, 2); - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { lua_pushnil(L); return 1; @@ -208,8 +208,8 @@ int NpcFunctions::luaNpcSay(lua_State* L) { */ int NpcFunctions::luaNpcTurnToCreature(lua_State* L) { // npc:turnToCreature(creature, true) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &npc = getUserdataShared<Npc>(L, 1); + const auto &creature = getCreature(L, 2); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); @@ -223,7 +223,7 @@ int NpcFunctions::luaNpcTurnToCreature(lua_State* L) { return 1; } - bool stopEventWalk = getBoolean(L, 3, true); + const bool stopEventWalk = getBoolean(L, 3, true); if (stopEventWalk) { npc->stopEventWalk(); } @@ -234,9 +234,9 @@ int NpcFunctions::luaNpcTurnToCreature(lua_State* L) { int NpcFunctions::luaNpcSetPlayerInteraction(lua_State* L) { // npc:setPlayerInteraction(creature, topic = 0) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); - std::shared_ptr<Creature> creature = getCreature(L, 2); - uint16_t topicId = getNumber<uint16_t>(L, 3, 0); + const auto &npc = getUserdataShared<Npc>(L, 1); + const auto &creature = getCreature(L, 2); + const auto topicId = getNumber<uint16_t>(L, 3, 0); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); @@ -257,8 +257,8 @@ int NpcFunctions::luaNpcSetPlayerInteraction(lua_State* L) { int NpcFunctions::luaNpcRemovePlayerInteraction(lua_State* L) { // npc:removePlayerInteraction() - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &npc = getUserdataShared<Npc>(L, 1); + const auto &creature = getCreature(L, 2); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); @@ -279,8 +279,8 @@ int NpcFunctions::luaNpcRemovePlayerInteraction(lua_State* L) { int NpcFunctions::luaNpcIsInteractingWithPlayer(lua_State* L) { // npc:isInteractingWithPlayer(creature) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &npc = getUserdataShared<Npc>(L, 1); + const auto &creature = getCreature(L, 2); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); @@ -300,9 +300,9 @@ int NpcFunctions::luaNpcIsInteractingWithPlayer(lua_State* L) { int NpcFunctions::luaNpcIsPlayerInteractingOnTopic(lua_State* L) { // npc:isPlayerInteractingOnTopic(creature, topicId = 0) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); - std::shared_ptr<Creature> creature = getCreature(L, 2); - uint32_t topicId = getNumber<uint32_t>(L, 3, 0); + const auto &npc = getUserdataShared<Npc>(L, 1); + const auto &creature = getCreature(L, 2); + const auto topicId = getNumber<uint32_t>(L, 3, 0); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); @@ -322,9 +322,9 @@ int NpcFunctions::luaNpcIsPlayerInteractingOnTopic(lua_State* L) { int NpcFunctions::luaNpcIsInTalkRange(lua_State* L) { // npc:isInTalkRange(position[, range = 4]) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); const Position &position = getPosition(L, 2); - uint32_t range = getNumber<uint32_t>(L, 3, 4); + const auto range = getNumber<uint32_t>(L, 3, 4); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); @@ -338,7 +338,7 @@ int NpcFunctions::luaNpcIsInTalkRange(lua_State* L) { int NpcFunctions::luaNpcOpenShopWindow(lua_State* L) { // npc:openShopWindow(player) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); pushBoolean(L, false); @@ -417,7 +417,7 @@ int NpcFunctions::luaNpcCloseShopWindow(lua_State* L) { return 1; } - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); @@ -434,14 +434,14 @@ int NpcFunctions::luaNpcCloseShopWindow(lua_State* L) { int NpcFunctions::luaNpcIsMerchant(lua_State* L) { // npc:isMerchant() - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto playerGUID = getNumber<uint32_t>(L, 2, 0); + const auto playerGUID = getNumber<uint32_t>(L, 2, 0); const auto &shopItems = npc->getShopItemVector(playerGUID); if (shopItems.empty()) { pushBoolean(L, false); @@ -454,16 +454,16 @@ int NpcFunctions::luaNpcIsMerchant(lua_State* L) { int NpcFunctions::luaNpcGetShopItem(lua_State* L) { // npc:getShopItem(itemId) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_CREATURE_NOT_FOUND)); pushBoolean(L, false); return 1; } - auto playerGUID = getNumber<uint32_t>(L, 2, 0); + const auto playerGUID = getNumber<uint32_t>(L, 2, 0); const auto &shopItems = npc->getShopItemVector(playerGUID); - for (ShopBlock shopBlock : shopItems) { + for (const ShopBlock &shopBlock : shopItems) { setField(L, "id", shopBlock.itemId); setField(L, "name", shopBlock.itemName); setField(L, "subType", shopBlock.itemSubType); @@ -479,7 +479,7 @@ int NpcFunctions::luaNpcGetShopItem(lua_State* L) { int NpcFunctions::luaNpcMove(lua_State* L) { // npc:move(direction) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (npc) { g_game().internalMoveCreature(npc, getNumber<Direction>(L, 2)); } @@ -488,7 +488,7 @@ int NpcFunctions::luaNpcMove(lua_State* L) { int NpcFunctions::luaNpcTurn(lua_State* L) { // npc:turn(direction) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (npc) { g_game().internalCreatureTurn(npc, getNumber<Direction>(L, 2)); } @@ -497,7 +497,7 @@ int NpcFunctions::luaNpcTurn(lua_State* L) { int NpcFunctions::luaNpcFollow(lua_State* L) { // npc:follow(player) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { pushBoolean(L, false); return 1; @@ -515,7 +515,7 @@ int NpcFunctions::luaNpcFollow(lua_State* L) { int NpcFunctions::luaNpcGetId(lua_State* L) { // npc:getId() - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); lua_pushnil(L); @@ -528,7 +528,7 @@ int NpcFunctions::luaNpcGetId(lua_State* L) { int NpcFunctions::luaNpcSellItem(lua_State* L) { // npc:sellItem(player, itemid, amount, <optional: default: 1> subtype, <optional: default: 0> actionid, <optional: default: false> ignoreCap, <optional: default: false> inBackpacks) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); pushBoolean(L, false); @@ -542,12 +542,12 @@ int NpcFunctions::luaNpcSellItem(lua_State* L) { return 1; } - uint16_t itemId = getNumber<uint16_t>(L, 3); - double amount = getNumber<double>(L, 4); - uint16_t subType = getNumber<uint16_t>(L, 5, 1); - uint16_t actionId = getNumber<uint16_t>(L, 6, 0); - bool ignoreCap = getBoolean(L, 7, false); - bool inBackpacks = getBoolean(L, 8, false); + auto itemId = getNumber<uint16_t>(L, 3); + const double amount = getNumber<double>(L, 4); + const auto subType = getNumber<uint16_t>(L, 5, 1); + const auto actionId = getNumber<uint16_t>(L, 6, 0); + const bool ignoreCap = getBoolean(L, 7, false); + const bool inBackpacks = getBoolean(L, 8, false); const ItemType &it = Item::items[itemId]; if (it.id == 0) { @@ -555,9 +555,9 @@ int NpcFunctions::luaNpcSellItem(lua_State* L) { return 1; } - uint32_t shoppingBagPrice = 20; - double shoppingBagSlots = 20; - if (std::shared_ptr<Tile> tile = ignoreCap ? player->getTile() : nullptr; tile) { + constexpr uint32_t shoppingBagPrice = 20; + constexpr double shoppingBagSlots = 20; + if (const auto &tile = ignoreCap ? player->getTile() : nullptr; tile) { double slotsNedeed = 0; if (it.stackable) { slotsNedeed = inBackpacks ? std::ceil(std::ceil(amount / it.stackSize) / shoppingBagSlots) : std::ceil(amount / it.stackSize); @@ -574,7 +574,7 @@ int NpcFunctions::luaNpcSellItem(lua_State* L) { uint64_t pricePerUnit = 0; const auto &shopVector = npc->getShopItemVector(player->getGUID()); - for (ShopBlock shopBlock : shopVector) { + for (const ShopBlock &shopBlock : shopVector) { if (itemId == shopBlock.itemId && shopBlock.itemBuyPrice != 0) { pricePerUnit = shopBlock.itemBuyPrice; break; @@ -584,8 +584,8 @@ int NpcFunctions::luaNpcSellItem(lua_State* L) { const auto &[_, itemsPurchased, backpacksPurchased] = g_game().createItem(player, itemId, amount, subType, actionId, ignoreCap, inBackpacks ? ITEM_SHOPPING_BAG : 0); std::stringstream ss; - uint64_t itemCost = itemsPurchased * pricePerUnit; - uint64_t backpackCost = backpacksPurchased * shoppingBagPrice; + const uint64_t itemCost = itemsPurchased * pricePerUnit; + const uint64_t backpackCost = backpacksPurchased * shoppingBagPrice; if (npc->getCurrency() == ITEM_GOLD_COIN) { if (!g_game().removeMoney(player, itemCost + backpackCost, 0, true)) { g_logger().error("[NpcFunctions::luaNpcSellItem (removeMoney)] - Player {} have a problem for buy item {} on shop for npc {}", player->getName(), itemId, npc->getName()); @@ -646,14 +646,14 @@ int NpcFunctions::luaNpcSellItem(lua_State* L) { int NpcFunctions::luaNpcGetDistanceTo(lua_State* L) { // npc:getDistanceTo(uid) - std::shared_ptr<Npc> npc = getUserdataShared<Npc>(L, 1); + const auto &npc = getUserdataShared<Npc>(L, 1); if (!npc) { reportErrorFunc(getErrorDesc(LUA_ERROR_NPC_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Thing> thing = getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)); + const auto &thing = getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)); pushBoolean(L, thing && thing->isPushable()); if (!thing) { reportErrorFunc(getErrorDesc(LUA_ERROR_THING_NOT_FOUND)); @@ -666,7 +666,7 @@ int NpcFunctions::luaNpcGetDistanceTo(lua_State* L) { if (npcPos.z != thingPos.z) { lua_pushnumber(L, -1); } else { - int32_t dist = std::max<int32_t>(Position::getDistanceX(npcPos, thingPos), Position::getDistanceY(npcPos, thingPos)); + const int32_t dist = std::max<int32_t>(Position::getDistanceX(npcPos, thingPos), Position::getDistanceY(npcPos, thingPos)); lua_pushnumber(L, dist); } return 1; diff --git a/src/lua/functions/creatures/npc/npc_functions.hpp b/src/lua/functions/creatures/npc/npc_functions.hpp index 1622a15c0e7..e03e3f72b25 100644 --- a/src/lua/functions/creatures/npc/npc_functions.hpp +++ b/src/lua/functions/creatures/npc/npc_functions.hpp @@ -15,6 +15,12 @@ class NpcFunctions final : LuaScriptInterface { private: + explicit NpcFunctions(lua_State* L) : + LuaScriptInterface("NpcFunctions") { + init(L); + } + ~NpcFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Npc", "Creature", NpcFunctions::luaNpcCreate); registerMetaMethod(L, "Npc", "__eq", NpcFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/npc/npc_type_functions.cpp b/src/lua/functions/creatures/npc/npc_type_functions.cpp index 2c4123d91db..3e40d2bc63a 100644 --- a/src/lua/functions/creatures/npc/npc_type_functions.cpp +++ b/src/lua/functions/creatures/npc/npc_type_functions.cpp @@ -189,7 +189,7 @@ int NpcTypeFunctions::luaNpcTypeAddShopItem(lua_State* L) { return 1; } - auto shop = getUserdataShared<Shop>(L, 2); + const auto &shop = getUserdataShared<Shop>(L, 2); if (shop) { npcType->loadShop(npcType, shop->shopBlock); pushBoolean(L, true); diff --git a/src/lua/functions/creatures/npc/npc_type_functions.hpp b/src/lua/functions/creatures/npc/npc_type_functions.hpp index ce799c71f20..ee54f124992 100644 --- a/src/lua/functions/creatures/npc/npc_type_functions.hpp +++ b/src/lua/functions/creatures/npc/npc_type_functions.hpp @@ -13,6 +13,12 @@ class NpcTypeFunctions final : LuaScriptInterface { public: + explicit NpcTypeFunctions(lua_State* L) : + LuaScriptInterface("NpcTypeFunctions") { + init(L); + } + ~NpcTypeFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "NpcType", "", NpcTypeFunctions::luaNpcTypeCreate); registerMetaMethod(L, "NpcType", "__eq", NpcTypeFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/npc/shop_functions.cpp b/src/lua/functions/creatures/npc/shop_functions.cpp index 388bda0e977..4265f535e85 100644 --- a/src/lua/functions/creatures/npc/shop_functions.cpp +++ b/src/lua/functions/creatures/npc/shop_functions.cpp @@ -40,7 +40,7 @@ int ShopFunctions::luaShopSetIdFromName(lua_State* L) { const auto &shop = getUserdataShared<Shop>(L, 1); if (shop && isString(L, 2)) { auto name = getString(L, 2); - auto ids = Item::items.nameToItems.equal_range(asLowerCaseString(name)); + const auto ids = Item::items.nameToItems.equal_range(asLowerCaseString(name)); if (ids.first == Item::items.nameToItems.cend()) { g_logger().warn("[ShopFunctions::luaShopSetIdFromName] - " diff --git a/src/lua/functions/creatures/npc/shop_functions.hpp b/src/lua/functions/creatures/npc/shop_functions.hpp index e5a6c9943cc..2d326ff73e2 100644 --- a/src/lua/functions/creatures/npc/shop_functions.hpp +++ b/src/lua/functions/creatures/npc/shop_functions.hpp @@ -13,6 +13,12 @@ class ShopFunctions final : LuaScriptInterface { public: + explicit ShopFunctions(lua_State* L) : + LuaScriptInterface("ShopFunctions") { + init(L); + } + ~ShopFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Shop", "", ShopFunctions::luaCreateShop); registerMethod(L, "Shop", "setId", ShopFunctions::luaShopSetId); diff --git a/src/lua/functions/creatures/player/group_functions.cpp b/src/lua/functions/creatures/player/group_functions.cpp index 2fd414a2e4a..de95a43243a 100644 --- a/src/lua/functions/creatures/player/group_functions.cpp +++ b/src/lua/functions/creatures/player/group_functions.cpp @@ -13,7 +13,7 @@ int GroupFunctions::luaGroupCreate(lua_State* L) { // Group(id) - uint32_t id = getNumber<uint32_t>(L, 2); + const uint32_t id = getNumber<uint32_t>(L, 2); const auto &group = g_game().groups.getGroup(id); if (group) { @@ -101,7 +101,7 @@ int GroupFunctions::luaGroupHasFlag(lua_State* L) { // group:hasFlag(flag) const auto &group = getUserdataShared<Group>(L, 1); if (group) { - auto flag = static_cast<PlayerFlags_t>(getNumber<int>(L, 2)); + const auto flag = static_cast<PlayerFlags_t>(getNumber<int>(L, 2)); pushBoolean(L, group->flags[Groups::getFlagNumber(flag)]); } else { lua_pushnil(L); diff --git a/src/lua/functions/creatures/player/group_functions.hpp b/src/lua/functions/creatures/player/group_functions.hpp index 4a33d1b988e..7729690b771 100644 --- a/src/lua/functions/creatures/player/group_functions.hpp +++ b/src/lua/functions/creatures/player/group_functions.hpp @@ -13,6 +13,12 @@ class GroupFunctions final : LuaScriptInterface { public: + explicit GroupFunctions(lua_State* L) : + LuaScriptInterface("GroupFunctions") { + init(L); + } + ~GroupFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Group", "", GroupFunctions::luaGroupCreate); registerMetaMethod(L, "Group", "__eq", GroupFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/player/guild_functions.cpp b/src/lua/functions/creatures/player/guild_functions.cpp index d5706e0609b..f0d7ac03888 100644 --- a/src/lua/functions/creatures/player/guild_functions.cpp +++ b/src/lua/functions/creatures/player/guild_functions.cpp @@ -12,8 +12,8 @@ #include "lua/functions/creatures/player/guild_functions.hpp" int GuildFunctions::luaGuildCreate(lua_State* L) { - uint32_t id = getNumber<uint32_t>(L, 2); - const auto guild = g_game().getGuild(id); + const uint32_t id = getNumber<uint32_t>(L, 2); + const auto &guild = g_game().getGuild(id); if (guild) { pushUserdata<Guild>(L, guild); setMetatable(L, -1, "Guild"); @@ -24,7 +24,7 @@ int GuildFunctions::luaGuildCreate(lua_State* L) { } int GuildFunctions::luaGuildGetId(lua_State* L) { - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (guild) { lua_pushnumber(L, guild->getId()); } else { @@ -35,7 +35,7 @@ int GuildFunctions::luaGuildGetId(lua_State* L) { int GuildFunctions::luaGuildGetName(lua_State* L) { // guild:getName() - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; @@ -46,7 +46,7 @@ int GuildFunctions::luaGuildGetName(lua_State* L) { int GuildFunctions::luaGuildGetMembersOnline(lua_State* L) { // guild:getMembersOnline() - const auto guild = getUserdataShared<const Guild>(L, 1); + const auto &guild = getUserdataShared<const Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; @@ -56,7 +56,7 @@ int GuildFunctions::luaGuildGetMembersOnline(lua_State* L) { lua_createtable(L, members.size(), 0); int index = 0; - for (std::shared_ptr<Player> player : members) { + for (const auto &player : members) { pushUserdata<Player>(L, player); setMetatable(L, -1, "Player"); lua_rawseti(L, -2, ++index); @@ -66,7 +66,7 @@ int GuildFunctions::luaGuildGetMembersOnline(lua_State* L) { int GuildFunctions::luaGuildGetBankBalance(lua_State* L) { // guild:getBankBalance() - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; @@ -77,7 +77,7 @@ int GuildFunctions::luaGuildGetBankBalance(lua_State* L) { int GuildFunctions::luaGuildSetBankBalance(lua_State* L) { // guild:setBankBalance(bankBalance) - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; @@ -90,14 +90,14 @@ int GuildFunctions::luaGuildSetBankBalance(lua_State* L) { int GuildFunctions::luaGuildAddRank(lua_State* L) { // guild:addRank(id, name, level) - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; } - uint32_t id = getNumber<uint32_t>(L, 2); + const uint32_t id = getNumber<uint32_t>(L, 2); const std::string &name = getString(L, 3); - uint8_t level = getNumber<uint8_t>(L, 4); + const uint8_t level = getNumber<uint8_t>(L, 4); guild->addRank(id, name, level); pushBoolean(L, true); return 1; @@ -105,14 +105,14 @@ int GuildFunctions::luaGuildAddRank(lua_State* L) { int GuildFunctions::luaGuildGetRankById(lua_State* L) { // guild:getRankById(id) - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; } - uint32_t id = getNumber<uint32_t>(L, 2); - GuildRank_ptr rank = guild->getRankById(id); + const uint32_t id = getNumber<uint32_t>(L, 2); + const GuildRank_ptr rank = guild->getRankById(id); if (rank) { lua_createtable(L, 0, 3); setField(L, "id", rank->id); @@ -126,14 +126,14 @@ int GuildFunctions::luaGuildGetRankById(lua_State* L) { int GuildFunctions::luaGuildGetRankByLevel(lua_State* L) { // guild:getRankByLevel(level) - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; } - uint8_t level = getNumber<uint8_t>(L, 2); - GuildRank_ptr rank = guild->getRankByLevel(level); + const uint8_t level = getNumber<uint8_t>(L, 2); + const GuildRank_ptr rank = guild->getRankByLevel(level); if (rank) { lua_createtable(L, 0, 3); setField(L, "id", rank->id); @@ -147,7 +147,7 @@ int GuildFunctions::luaGuildGetRankByLevel(lua_State* L) { int GuildFunctions::luaGuildGetMotd(lua_State* L) { // guild:getMotd() - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; @@ -158,7 +158,7 @@ int GuildFunctions::luaGuildGetMotd(lua_State* L) { int GuildFunctions::luaGuildSetMotd(lua_State* L) { // guild:setMotd(motd) - const auto guild = getUserdataShared<Guild>(L, 1); + const auto &guild = getUserdataShared<Guild>(L, 1); if (!guild) { lua_pushnil(L); return 1; diff --git a/src/lua/functions/creatures/player/guild_functions.hpp b/src/lua/functions/creatures/player/guild_functions.hpp index e5c48244415..d8f844de751 100644 --- a/src/lua/functions/creatures/player/guild_functions.hpp +++ b/src/lua/functions/creatures/player/guild_functions.hpp @@ -13,6 +13,12 @@ class GuildFunctions final : LuaScriptInterface { public: + explicit GuildFunctions(lua_State* L) : + LuaScriptInterface("GuildFunctions") { + init(L); + } + ~GuildFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Guild", "", GuildFunctions::luaGuildCreate); registerMetaMethod(L, "Guild", "__eq", GuildFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/player/mount_functions.cpp b/src/lua/functions/creatures/player/mount_functions.cpp index 3decd6b2321..bbcd8ebff66 100644 --- a/src/lua/functions/creatures/player/mount_functions.cpp +++ b/src/lua/functions/creatures/player/mount_functions.cpp @@ -17,7 +17,7 @@ int MountFunctions::luaCreateMount(lua_State* L) { if (isNumber(L, 2)) { mount = g_game().mounts.getMountByID(getNumber<uint8_t>(L, 2)); } else if (isString(L, 2)) { - std::string mountName = getString(L, 2); + const std::string mountName = getString(L, 2); mount = g_game().mounts.getMountByName(mountName); } else { mount = nullptr; @@ -35,7 +35,7 @@ int MountFunctions::luaCreateMount(lua_State* L) { int MountFunctions::luaMountGetName(lua_State* L) { // mount:getName() - const std::shared_ptr<Mount> mount = getUserdataShared<Mount>(L, 1); + const auto &mount = getUserdataShared<Mount>(L, 1); if (mount) { pushString(L, mount->name); } else { @@ -47,7 +47,7 @@ int MountFunctions::luaMountGetName(lua_State* L) { int MountFunctions::luaMountGetId(lua_State* L) { // mount:getId() - const std::shared_ptr<Mount> mount = getUserdataShared<Mount>(L, 1); + const auto &mount = getUserdataShared<Mount>(L, 1); if (mount) { lua_pushnumber(L, mount->id); } else { @@ -59,7 +59,7 @@ int MountFunctions::luaMountGetId(lua_State* L) { int MountFunctions::luaMountGetClientId(lua_State* L) { // mount:getClientId() - const std::shared_ptr<Mount> mount = getUserdataShared<Mount>(L, 1); + const auto &mount = getUserdataShared<Mount>(L, 1); if (mount) { lua_pushnumber(L, mount->clientId); } else { @@ -71,7 +71,7 @@ int MountFunctions::luaMountGetClientId(lua_State* L) { int MountFunctions::luaMountGetSpeed(lua_State* L) { // mount:getSpeed() - const std::shared_ptr<Mount> mount = getUserdataShared<Mount>(L, 1); + const auto &mount = getUserdataShared<Mount>(L, 1); if (mount) { lua_pushnumber(L, mount->speed); } else { diff --git a/src/lua/functions/creatures/player/mount_functions.hpp b/src/lua/functions/creatures/player/mount_functions.hpp index 3a4db6d6f92..a6ce7003ecc 100644 --- a/src/lua/functions/creatures/player/mount_functions.hpp +++ b/src/lua/functions/creatures/player/mount_functions.hpp @@ -13,6 +13,12 @@ class MountFunctions final : LuaScriptInterface { public: + explicit MountFunctions(lua_State* L) : + LuaScriptInterface("MountFunctions") { + init(L); + } + ~MountFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Mount", "", MountFunctions::luaCreateMount); registerMetaMethod(L, "Mount", "__eq", MountFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/player/party_functions.cpp b/src/lua/functions/creatures/player/party_functions.cpp index 1791016bde3..122e316bd1e 100644 --- a/src/lua/functions/creatures/player/party_functions.cpp +++ b/src/lua/functions/creatures/player/party_functions.cpp @@ -14,13 +14,13 @@ int32_t PartyFunctions::luaPartyCreate(lua_State* L) { // Party(userdata) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 2); + const auto &player = getUserdataShared<Player>(L, 2); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Party> party = player->getParty(); + auto party = player->getParty(); if (!party) { party = Party::create(player); g_game().updatePlayerShield(player); @@ -35,7 +35,7 @@ int32_t PartyFunctions::luaPartyCreate(lua_State* L) { int PartyFunctions::luaPartyDisband(lua_State* L) { // party:disband() - std::shared_ptr<Party>* partyPtr = getRawUserDataShared<Party>(L, 1); + auto* partyPtr = getRawUserDataShared<Party>(L, 1); if (partyPtr && *partyPtr) { std::shared_ptr<Party> &party = *partyPtr; party->disband(); @@ -49,13 +49,13 @@ int PartyFunctions::luaPartyDisband(lua_State* L) { int PartyFunctions::luaPartyGetLeader(lua_State* L) { // party:getLeader() - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (!party) { lua_pushnil(L); return 1; } - std::shared_ptr<Player> leader = party->getLeader(); + const auto &leader = party->getLeader(); if (leader) { pushUserdata<Player>(L, leader); setMetatable(L, -1, "Player"); @@ -73,7 +73,7 @@ int PartyFunctions::luaPartySetLeader(lua_State* L) { return 1; } - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { pushBoolean(L, party->passPartyLeadership(player)); } else { @@ -84,7 +84,7 @@ int PartyFunctions::luaPartySetLeader(lua_State* L) { int PartyFunctions::luaPartyGetMembers(lua_State* L) { // party:getMembers() - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (!party) { lua_pushnil(L); return 1; @@ -92,7 +92,7 @@ int PartyFunctions::luaPartyGetMembers(lua_State* L) { int index = 0; lua_createtable(L, party->getMemberCount(), 0); - for (std::shared_ptr<Player> player : party->getMembers()) { + for (const auto &player : party->getMembers()) { pushUserdata<Player>(L, player); setMetatable(L, -1, "Player"); lua_rawseti(L, -2, ++index); @@ -102,7 +102,7 @@ int PartyFunctions::luaPartyGetMembers(lua_State* L) { int PartyFunctions::luaPartyGetMemberCount(lua_State* L) { // party:getMemberCount() - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { lua_pushnumber(L, party->getMemberCount()); } else { @@ -113,12 +113,12 @@ int PartyFunctions::luaPartyGetMemberCount(lua_State* L) { int PartyFunctions::luaPartyGetInvitees(lua_State* L) { // party:getInvitees() - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { lua_createtable(L, party->getInvitationCount(), 0); int index = 0; - for (std::shared_ptr<Player> player : party->getInvitees()) { + for (const auto &player : party->getInvitees()) { pushUserdata<Player>(L, player); setMetatable(L, -1, "Player"); lua_rawseti(L, -2, ++index); @@ -131,7 +131,7 @@ int PartyFunctions::luaPartyGetInvitees(lua_State* L) { int PartyFunctions::luaPartyGetInviteeCount(lua_State* L) { // party:getInviteeCount() - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { lua_pushnumber(L, party->getInvitationCount()); } else { @@ -148,7 +148,7 @@ int PartyFunctions::luaPartyAddInvite(lua_State* L) { return 1; } - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party && player) { pushBoolean(L, party->invitePlayer(player)); } else { @@ -165,7 +165,7 @@ int PartyFunctions::luaPartyRemoveInvite(lua_State* L) { return 1; } - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party && player) { pushBoolean(L, party->removeInvite(player)); } else { @@ -182,7 +182,7 @@ int PartyFunctions::luaPartyAddMember(lua_State* L) { return 1; } - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party && player) { pushBoolean(L, party->joinParty(player)); } else { @@ -199,7 +199,7 @@ int PartyFunctions::luaPartyRemoveMember(lua_State* L) { return 1; } - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party && player) { pushBoolean(L, party->leaveParty(player)); } else { @@ -210,7 +210,7 @@ int PartyFunctions::luaPartyRemoveMember(lua_State* L) { int PartyFunctions::luaPartyIsSharedExperienceActive(lua_State* L) { // party:isSharedExperienceActive() - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { pushBoolean(L, party->isSharedExperienceActive()); } else { @@ -221,7 +221,7 @@ int PartyFunctions::luaPartyIsSharedExperienceActive(lua_State* L) { int PartyFunctions::luaPartyIsSharedExperienceEnabled(lua_State* L) { // party:isSharedExperienceEnabled() - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { pushBoolean(L, party->isSharedExperienceEnabled()); } else { @@ -232,8 +232,8 @@ int PartyFunctions::luaPartyIsSharedExperienceEnabled(lua_State* L) { int PartyFunctions::luaPartyShareExperience(lua_State* L) { // party:shareExperience(experience) - uint64_t experience = getNumber<uint64_t>(L, 2); - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const uint64_t experience = getNumber<uint64_t>(L, 2); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { party->shareExperience(experience); pushBoolean(L, true); @@ -245,8 +245,8 @@ int PartyFunctions::luaPartyShareExperience(lua_State* L) { int PartyFunctions::luaPartySetSharedExperience(lua_State* L) { // party:setSharedExperience(active) - bool active = getBoolean(L, 2); - std::shared_ptr<Party> party = getUserdataShared<Party>(L, 1); + const bool active = getBoolean(L, 2); + const auto &party = getUserdataShared<Party>(L, 1); if (party) { pushBoolean(L, party->setSharedExperience(party->getLeader(), active)); } else { diff --git a/src/lua/functions/creatures/player/party_functions.hpp b/src/lua/functions/creatures/player/party_functions.hpp index 312a39952fe..79e6a07de71 100644 --- a/src/lua/functions/creatures/player/party_functions.hpp +++ b/src/lua/functions/creatures/player/party_functions.hpp @@ -13,6 +13,12 @@ class PartyFunctions final : LuaScriptInterface { public: + explicit PartyFunctions(lua_State* L) : + LuaScriptInterface("PartyFunctions") { + init(L); + } + ~PartyFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Party", "", PartyFunctions::luaPartyCreate); registerMetaMethod(L, "Party", "__eq", PartyFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/player/player_functions.cpp b/src/lua/functions/creatures/player/player_functions.cpp index cbb0a18afd7..eb9d7d6f50e 100644 --- a/src/lua/functions/creatures/player/player_functions.cpp +++ b/src/lua/functions/creatures/player/player_functions.cpp @@ -15,9 +15,7 @@ #include "creatures/players/player.hpp" #include "creatures/players/wheel/player_wheel.hpp" #include "creatures/players/achievement/player_achievement.hpp" -#include "creatures/players/cyclopedia/player_badge.hpp" #include "creatures/players/cyclopedia/player_cyclopedia.hpp" -#include "creatures/players/cyclopedia/player_title.hpp" #include "game/game.hpp" #include "io/iologindata.hpp" #include "io/ioprey.hpp" @@ -27,12 +25,11 @@ #include "map/spectators.hpp" #include "enums/account_errors.hpp" -#include "enums/account_type.hpp" #include "enums/account_coins.hpp" int PlayerFunctions::luaPlayerSendInventory(lua_State* L) { // player:sendInventory() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -46,19 +43,19 @@ int PlayerFunctions::luaPlayerSendInventory(lua_State* L) { int PlayerFunctions::luaPlayerSendLootStats(lua_State* L) { // player:sendLootStats(item, count) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); + const auto &item = getUserdataShared<Item>(L, 2); if (!item) { lua_pushnil(L); return 1; } - uint8_t count = getNumber<uint8_t>(L, 3, 0); + const auto count = getNumber<uint8_t>(L, 3, 0); if (count == 0) { lua_pushnil(L); return 1; @@ -72,13 +69,13 @@ int PlayerFunctions::luaPlayerSendLootStats(lua_State* L) { int PlayerFunctions::luaPlayerUpdateSupplyTracker(lua_State* L) { // player:updateSupplyTracker(item) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); + const auto &item = getUserdataShared<Item>(L, 2); if (!item) { lua_pushnil(L); return 1; @@ -92,19 +89,19 @@ int PlayerFunctions::luaPlayerUpdateSupplyTracker(lua_State* L) { int PlayerFunctions::luaPlayerUpdateKillTracker(lua_State* L) { // player:updateKillTracker(creature, corpse) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> monster = getUserdataShared<Creature>(L, 2); + const auto &monster = getUserdataShared<Creature>(L, 2); if (!monster) { lua_pushnil(L); return 1; } - std::shared_ptr<Container> corpse = getUserdataShared<Container>(L, 3); + const auto &corpse = getUserdataShared<Container>(L, 3); if (!corpse) { lua_pushnil(L); return 1; @@ -121,7 +118,7 @@ int PlayerFunctions::luaPlayerCreate(lua_State* L) { // Player(id or guid or name or userdata) std::shared_ptr<Player> player; if (isNumber(L, 2)) { - uint32_t id = getNumber<uint32_t>(L, 2); + const uint32_t id = getNumber<uint32_t>(L, 2); if (id >= Player::getFirstID() && id <= Player::getLastID()) { player = g_game().getPlayerByID(id); } else { @@ -155,7 +152,7 @@ int PlayerFunctions::luaPlayerCreate(lua_State* L) { int PlayerFunctions::luaPlayerResetCharmsMonsters(lua_State* L) { // player:resetCharmsBestiary() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setCharmPoints(0); player->setCharmExpansion(false); @@ -173,12 +170,12 @@ int PlayerFunctions::luaPlayerResetCharmsMonsters(lua_State* L) { int PlayerFunctions::luaPlayerUnlockAllCharmRunes(lua_State* L) { // player:unlockAllCharmRunes() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { for (int8_t i = CHARM_WOUND; i <= CHARM_LAST; i++) { const auto charm = g_iobestiary().getBestiaryCharm(static_cast<charmRune_t>(i)); if (charm) { - int32_t value = g_iobestiary().bitToggle(player->getUnlockedRunesBit(), charm, true); + const int32_t value = g_iobestiary().bitToggle(player->getUnlockedRunesBit(), charm, true); player->setUnlockedRunesBit(value); } } @@ -191,7 +188,7 @@ int PlayerFunctions::luaPlayerUnlockAllCharmRunes(lua_State* L) { int PlayerFunctions::luaPlayeraddCharmPoints(lua_State* L) { // player:addCharmPoints() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { int16_t charms = getNumber<int16_t>(L, 2); if (charms >= 0) { @@ -215,7 +212,7 @@ int PlayerFunctions::luaPlayerIsPlayer(lua_State* L) { int PlayerFunctions::luaPlayerGetGuid(lua_State* L) { // player:getGuid() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getGUID()); } else { @@ -226,7 +223,7 @@ int PlayerFunctions::luaPlayerGetGuid(lua_State* L) { int PlayerFunctions::luaPlayerGetIp(lua_State* L) { // player:getIp() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getIP()); } else { @@ -237,7 +234,7 @@ int PlayerFunctions::luaPlayerGetIp(lua_State* L) { int PlayerFunctions::luaPlayerGetAccountId(lua_State* L) { // player:getAccountId() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || player->getAccountId() == 0) { lua_pushnil(L); return 1; @@ -250,7 +247,7 @@ int PlayerFunctions::luaPlayerGetAccountId(lua_State* L) { int PlayerFunctions::luaPlayerGetLastLoginSaved(lua_State* L) { // player:getLastLoginSaved() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getLastLoginSaved()); } else { @@ -261,7 +258,7 @@ int PlayerFunctions::luaPlayerGetLastLoginSaved(lua_State* L) { int PlayerFunctions::luaPlayerGetLastLogout(lua_State* L) { // player:getLastLogout() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getLastLogout()); } else { @@ -272,7 +269,7 @@ int PlayerFunctions::luaPlayerGetLastLogout(lua_State* L) { int PlayerFunctions::luaPlayerGetAccountType(lua_State* L) { // player:getAccountType() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getAccountType()); } else { @@ -283,7 +280,7 @@ int PlayerFunctions::luaPlayerGetAccountType(lua_State* L) { int PlayerFunctions::luaPlayerSetAccountType(lua_State* L) { // player:setAccountType(accountType) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { lua_pushnil(L); return 1; @@ -305,9 +302,9 @@ int PlayerFunctions::luaPlayerSetAccountType(lua_State* L) { int PlayerFunctions::luaPlayerAddBestiaryKill(lua_State* L) { // player:addBestiaryKill(name[, amount = 1]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - const auto mtype = g_monsters().getMonsterType(getString(L, 2)); + const auto &mtype = g_monsters().getMonsterType(getString(L, 2)); if (mtype) { g_iobestiary().addBestiaryKill(player, mtype, getNumber<uint32_t>(L, 3, 1)); pushBoolean(L, true); @@ -322,21 +319,21 @@ int PlayerFunctions::luaPlayerAddBestiaryKill(lua_State* L) { int PlayerFunctions::luaPlayerIsMonsterBestiaryUnlocked(lua_State* L) { // player:isMonsterBestiaryUnlocked(raceId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player == nullptr) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - auto raceId = getNumber<uint16_t>(L, 2, 0); + const auto raceId = getNumber<uint16_t>(L, 2, 0); if (!g_monsters().getMonsterTypeByRaceId(raceId)) { reportErrorFunc("Monster race id not exists"); pushBoolean(L, false); return 0; } - for (uint16_t finishedRaceId : g_iobestiary().getBestiaryFinished(player)) { + for (const uint16_t finishedRaceId : g_iobestiary().getBestiaryFinished(player)) { if (raceId == finishedRaceId) { pushBoolean(L, true); return 1; @@ -349,12 +346,12 @@ int PlayerFunctions::luaPlayerIsMonsterBestiaryUnlocked(lua_State* L) { int PlayerFunctions::luaPlayergetCharmMonsterType(lua_State* L) { // player:getCharmMonsterType(charmRune_t) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - charmRune_t charmid = getNumber<charmRune_t>(L, 2); - uint16_t raceid = player->parseRacebyCharm(charmid, false, 0); + const charmRune_t charmid = getNumber<charmRune_t>(L, 2); + const uint16_t raceid = player->parseRacebyCharm(charmid, false, 0); if (raceid > 0) { - const auto mtype = g_monsters().getMonsterTypeByRaceId(raceid); + const auto &mtype = g_monsters().getMonsterTypeByRaceId(raceid); if (mtype) { pushUserdata<MonsterType>(L, mtype); setMetatable(L, -1, "MonsterType"); @@ -372,7 +369,7 @@ int PlayerFunctions::luaPlayergetCharmMonsterType(lua_State* L) { int PlayerFunctions::luaPlayerRemovePreyStamina(lua_State* L) { // player:removePreyStamina(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { g_ioprey().checkPlayerPreys(player, getNumber<uint8_t>(L, 2, 1)); pushBoolean(L, true); @@ -384,7 +381,7 @@ int PlayerFunctions::luaPlayerRemovePreyStamina(lua_State* L) { int PlayerFunctions::luaPlayerAddPreyCards(lua_State* L) { // player:addPreyCards(amount) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1)) { + if (const auto &player = getUserdataShared<Player>(L, 1)) { player->addPreyCards(getNumber<uint64_t>(L, 2, 0)); pushBoolean(L, true); } else { @@ -395,7 +392,7 @@ int PlayerFunctions::luaPlayerAddPreyCards(lua_State* L) { int PlayerFunctions::luaPlayerGetPreyCards(lua_State* L) { // player:getPreyCards() - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1)) { + if (const auto &player = getUserdataShared<Player>(L, 1)) { lua_pushnumber(L, static_cast<lua_Number>(player->getPreyCards())); } else { lua_pushnil(L); @@ -405,7 +402,7 @@ int PlayerFunctions::luaPlayerGetPreyCards(lua_State* L) { int PlayerFunctions::luaPlayerGetPreyExperiencePercentage(lua_State* L) { // player:getPreyExperiencePercentage(raceId) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1)) { + if (const auto &player = getUserdataShared<Player>(L, 1)) { if (const std::unique_ptr<PreySlot> &slot = player->getPreyWithMonster(getNumber<uint16_t>(L, 2, 0)); slot && slot->isOccupied() && slot->bonus == PreyBonus_Experience && slot->bonusTimeLeft > 0) { lua_pushnumber(L, static_cast<lua_Number>(100 + slot->bonusPercentage)); @@ -420,7 +417,7 @@ int PlayerFunctions::luaPlayerGetPreyExperiencePercentage(lua_State* L) { int PlayerFunctions::luaPlayerRemoveTaskHuntingPoints(lua_State* L) { // player:removeTaskHuntingPoints(amount) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1)) { + if (const auto &player = getUserdataShared<Player>(L, 1)) { pushBoolean(L, player->useTaskHuntingPoints(getNumber<uint64_t>(L, 2, 0))); } else { lua_pushnil(L); @@ -430,7 +427,7 @@ int PlayerFunctions::luaPlayerRemoveTaskHuntingPoints(lua_State* L) { int PlayerFunctions::luaPlayerGetTaskHuntingPoints(lua_State* L) { // player:getTaskHuntingPoints() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player == nullptr) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -443,8 +440,8 @@ int PlayerFunctions::luaPlayerGetTaskHuntingPoints(lua_State* L) { int PlayerFunctions::luaPlayerAddTaskHuntingPoints(lua_State* L) { // player:addTaskHuntingPoints(amount) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1)) { - auto points = getNumber<uint64_t>(L, 2); + if (const auto &player = getUserdataShared<Player>(L, 1)) { + const auto points = getNumber<uint64_t>(L, 2); player->addTaskHuntingPoints(getNumber<uint64_t>(L, 2)); lua_pushnumber(L, static_cast<lua_Number>(points)); } else { @@ -455,7 +452,7 @@ int PlayerFunctions::luaPlayerAddTaskHuntingPoints(lua_State* L) { int PlayerFunctions::luaPlayerGetPreyLootPercentage(lua_State* L) { // player:getPreyLootPercentage(raceid) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1)) { + if (const auto &player = getUserdataShared<Player>(L, 1)) { if (const std::unique_ptr<PreySlot> &slot = player->getPreyWithMonster(getNumber<uint16_t>(L, 2, 0)); slot && slot->isOccupied() && slot->bonus == PreyBonus_Loot) { lua_pushnumber(L, slot->bonusPercentage); @@ -470,7 +467,7 @@ int PlayerFunctions::luaPlayerGetPreyLootPercentage(lua_State* L) { int PlayerFunctions::luaPlayerisMonsterPrey(lua_State* L) { // player:isMonsterPrey(raceid) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1)) { + if (const auto &player = getUserdataShared<Player>(L, 1)) { if (const std::unique_ptr<PreySlot> &slot = player->getPreyWithMonster(getNumber<uint16_t>(L, 2, 0)); slot && slot->isOccupied()) { pushBoolean(L, true); @@ -485,7 +482,7 @@ int PlayerFunctions::luaPlayerisMonsterPrey(lua_State* L) { int PlayerFunctions::luaPlayerPreyThirdSlot(lua_State* L) { // get: player:preyThirdSlot() set: player:preyThirdSlot(bool) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + if (const auto &player = getUserdataShared<Player>(L, 1); const auto &slot = player->getPreySlotById(PreySlot_Three)) { if (!slot) { lua_pushnil(L); @@ -512,7 +509,7 @@ int PlayerFunctions::luaPlayerPreyThirdSlot(lua_State* L) { int PlayerFunctions::luaPlayerTaskThirdSlot(lua_State* L) { // get: player:taskHuntingThirdSlot() set: player:taskHuntingThirdSlot(bool) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + if (const auto &player = getUserdataShared<Player>(L, 1); const auto &slot = player->getTaskHuntingSlotById(PreySlot_Three)) { if (lua_gettop(L) == 1) { pushBoolean(L, slot->state != PreyTaskDataState_Locked); @@ -537,7 +534,7 @@ int PlayerFunctions::luaPlayerTaskThirdSlot(lua_State* L) { int PlayerFunctions::luaPlayercharmExpansion(lua_State* L) { // get: player:charmExpansion() set: player:charmExpansion(bool) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { if (lua_gettop(L) == 1) { pushBoolean(L, player->hasCharmExpansion()); @@ -553,7 +550,7 @@ int PlayerFunctions::luaPlayercharmExpansion(lua_State* L) { int PlayerFunctions::luaPlayerGetCapacity(lua_State* L) { // player:getCapacity() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getCapacity()); } else { @@ -564,7 +561,7 @@ int PlayerFunctions::luaPlayerGetCapacity(lua_State* L) { int PlayerFunctions::luaPlayerSetCapacity(lua_State* L) { // player:setCapacity(capacity) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->capacity = getNumber<uint32_t>(L, 2); player->sendStats(); @@ -577,9 +574,9 @@ int PlayerFunctions::luaPlayerSetCapacity(lua_State* L) { int PlayerFunctions::luaPlayerSetTraining(lua_State* L) { // player:setTraining(value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - bool value = getBoolean(L, 2, false); + const bool value = getBoolean(L, 2, false); player->setTraining(value); pushBoolean(L, true); } else { @@ -590,7 +587,7 @@ int PlayerFunctions::luaPlayerSetTraining(lua_State* L) { int PlayerFunctions::luaPlayerGetIsTraining(lua_State* L) { // player:isTraining() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); @@ -603,7 +600,7 @@ int PlayerFunctions::luaPlayerGetIsTraining(lua_State* L) { int PlayerFunctions::luaPlayerGetFreeCapacity(lua_State* L) { // player:getFreeCapacity() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getFreeCapacity()); } else { @@ -614,7 +611,7 @@ int PlayerFunctions::luaPlayerGetFreeCapacity(lua_State* L) { int PlayerFunctions::luaPlayerGetKills(lua_State* L) { // player:getKills() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -638,7 +635,7 @@ int PlayerFunctions::luaPlayerGetKills(lua_State* L) { int PlayerFunctions::luaPlayerSetKills(lua_State* L) { // player:setKills(kills) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -666,15 +663,15 @@ int PlayerFunctions::luaPlayerSetKills(lua_State* L) { int PlayerFunctions::luaPlayerGetReward(lua_State* L) { // player:getReward(rewardId[, autoCreate = false]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint64_t rewardId = getNumber<uint64_t>(L, 2); - bool autoCreate = getBoolean(L, 3, false); - if (auto reward = player->getReward(rewardId, autoCreate)) { + const uint64_t rewardId = getNumber<uint64_t>(L, 2); + const bool autoCreate = getBoolean(L, 3, false); + if (const auto &reward = player->getReward(rewardId, autoCreate)) { pushUserdata<Item>(L, reward); setItemMetatable(L, -1, reward); } else { @@ -685,13 +682,13 @@ int PlayerFunctions::luaPlayerGetReward(lua_State* L) { int PlayerFunctions::luaPlayerRemoveReward(lua_State* L) { // player:removeReward(rewardId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint32_t rewardId = getNumber<uint32_t>(L, 2); + const uint32_t rewardId = getNumber<uint32_t>(L, 2); player->removeReward(rewardId); pushBoolean(L, true); return 1; @@ -699,7 +696,7 @@ int PlayerFunctions::luaPlayerRemoveReward(lua_State* L) { int PlayerFunctions::luaPlayerGetRewardList(lua_State* L) { // player:getRewardList() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -719,7 +716,7 @@ int PlayerFunctions::luaPlayerGetRewardList(lua_State* L) { int PlayerFunctions::luaPlayerSetDailyReward(lua_State* L) { // player:setDailyReward(value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setDailyReward(getNumber<uint8_t>(L, 2)); pushBoolean(L, true); @@ -731,14 +728,14 @@ int PlayerFunctions::luaPlayerSetDailyReward(lua_State* L) { int PlayerFunctions::luaPlayerGetDepotLocker(lua_State* L) { // player:getDepotLocker(depotId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint32_t depotId = getNumber<uint32_t>(L, 2); - std::shared_ptr<DepotLocker> depotLocker = player->getDepotLocker(depotId); + const uint32_t depotId = getNumber<uint32_t>(L, 2); + const auto &depotLocker = player->getDepotLocker(depotId); if (depotLocker) { depotLocker->setParent(player); pushUserdata<Item>(L, depotLocker); @@ -751,9 +748,9 @@ int PlayerFunctions::luaPlayerGetDepotLocker(lua_State* L) { int PlayerFunctions::luaPlayerGetStashCounter(lua_State* L) { // player:getStashCount() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t sizeStash = getStashSize(player->getStashItems()); + const uint16_t sizeStash = getStashSize(player->getStashItems()); lua_pushnumber(L, sizeStash); } else { lua_pushnil(L); @@ -763,15 +760,15 @@ int PlayerFunctions::luaPlayerGetStashCounter(lua_State* L) { int PlayerFunctions::luaPlayerGetDepotChest(lua_State* L) { // player:getDepotChest(depotId[, autoCreate = false]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint32_t depotId = getNumber<uint32_t>(L, 2); - bool autoCreate = getBoolean(L, 3, false); - std::shared_ptr<DepotChest> depotChest = player->getDepotChest(depotId, autoCreate); + const uint32_t depotId = getNumber<uint32_t>(L, 2); + const bool autoCreate = getBoolean(L, 3, false); + const auto &depotChest = player->getDepotChest(depotId, autoCreate); if (depotChest) { player->setLastDepotId(depotId); pushUserdata<Item>(L, depotChest); @@ -784,13 +781,13 @@ int PlayerFunctions::luaPlayerGetDepotChest(lua_State* L) { int PlayerFunctions::luaPlayerGetInbox(lua_State* L) { // player:getInbox() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Inbox> inbox = player->getInbox(); + const auto &inbox = player->getInbox(); if (inbox) { pushUserdata<Item>(L, inbox); setItemMetatable(L, -1, inbox); @@ -802,7 +799,7 @@ int PlayerFunctions::luaPlayerGetInbox(lua_State* L) { int PlayerFunctions::luaPlayerGetSkullTime(lua_State* L) { // player:getSkullTime() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getSkullTicks()); } else { @@ -813,7 +810,7 @@ int PlayerFunctions::luaPlayerGetSkullTime(lua_State* L) { int PlayerFunctions::luaPlayerSetSkullTime(lua_State* L) { // player:setSkullTime(skullTime) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setSkullTicks(getNumber<int64_t>(L, 2)); pushBoolean(L, true); @@ -825,7 +822,7 @@ int PlayerFunctions::luaPlayerSetSkullTime(lua_State* L) { int PlayerFunctions::luaPlayerGetDeathPenalty(lua_State* L) { // player:getDeathPenalty() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, static_cast<uint32_t>(player->getLostPercent() * 100)); } else { @@ -836,7 +833,7 @@ int PlayerFunctions::luaPlayerGetDeathPenalty(lua_State* L) { int PlayerFunctions::luaPlayerGetExperience(lua_State* L) { // player:getExperience() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getExperience()); } else { @@ -847,10 +844,10 @@ int PlayerFunctions::luaPlayerGetExperience(lua_State* L) { int PlayerFunctions::luaPlayerAddExperience(lua_State* L) { // player:addExperience(experience[, sendText = false]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - int64_t experience = getNumber<int64_t>(L, 2); - bool sendText = getBoolean(L, 3, false); + const int64_t experience = getNumber<int64_t>(L, 2); + const bool sendText = getBoolean(L, 3, false); player->addExperience(nullptr, experience, sendText); pushBoolean(L, true); } else { @@ -861,10 +858,10 @@ int PlayerFunctions::luaPlayerAddExperience(lua_State* L) { int PlayerFunctions::luaPlayerRemoveExperience(lua_State* L) { // player:removeExperience(experience[, sendText = false]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - int64_t experience = getNumber<int64_t>(L, 2); - bool sendText = getBoolean(L, 3, false); + const int64_t experience = getNumber<int64_t>(L, 2); + const bool sendText = getBoolean(L, 3, false); player->removeExperience(experience, sendText); pushBoolean(L, true); } else { @@ -875,7 +872,7 @@ int PlayerFunctions::luaPlayerRemoveExperience(lua_State* L) { int PlayerFunctions::luaPlayerGetLevel(lua_State* L) { // player:getLevel() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getLevel()); } else { @@ -886,7 +883,7 @@ int PlayerFunctions::luaPlayerGetLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetMagicShieldCapacityFlat(lua_State* L) { // player:getMagicShieldCapacityFlat(useCharges) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getMagicShieldCapacityFlat(getBoolean(L, 2, false))); } else { @@ -897,7 +894,7 @@ int PlayerFunctions::luaPlayerGetMagicShieldCapacityFlat(lua_State* L) { int PlayerFunctions::luaPlayerGetMagicShieldCapacityPercent(lua_State* L) { // player:getMagicShieldCapacityPercent(useCharges) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getMagicShieldCapacityPercent(getBoolean(L, 2, false))); } else { @@ -908,13 +905,13 @@ int PlayerFunctions::luaPlayerGetMagicShieldCapacityPercent(lua_State* L) { int PlayerFunctions::luaPlayerSendSpellCooldown(lua_State* L) { // player:sendSpellCooldown(spellId, time) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint8_t spellId = getNumber<uint32_t>(L, 2, 1); - uint32_t time = getNumber<uint32_t>(L, 3, 0); + const uint8_t spellId = getNumber<uint32_t>(L, 2, 1); + const auto time = getNumber<uint32_t>(L, 3, 0); player->sendSpellCooldown(spellId, time); pushBoolean(L, true); @@ -924,13 +921,13 @@ int PlayerFunctions::luaPlayerSendSpellCooldown(lua_State* L) { int PlayerFunctions::luaPlayerSendSpellGroupCooldown(lua_State* L) { // player:sendSpellGroupCooldown(groupId, time) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - SpellGroup_t groupId = getNumber<SpellGroup_t>(L, 2, SPELLGROUP_ATTACK); - uint32_t time = getNumber<uint32_t>(L, 3, 0); + const auto groupId = getNumber<SpellGroup_t>(L, 2, SPELLGROUP_ATTACK); + const auto time = getNumber<uint32_t>(L, 3, 0); player->sendSpellGroupCooldown(groupId, time); pushBoolean(L, true); @@ -940,7 +937,7 @@ int PlayerFunctions::luaPlayerSendSpellGroupCooldown(lua_State* L) { int PlayerFunctions::luaPlayerGetMagicLevel(lua_State* L) { // player:getMagicLevel() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getMagicLevel()); } else { @@ -951,7 +948,7 @@ int PlayerFunctions::luaPlayerGetMagicLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetBaseMagicLevel(lua_State* L) { // player:getBaseMagicLevel() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getBaseMagicLevel()); } else { @@ -962,7 +959,7 @@ int PlayerFunctions::luaPlayerGetBaseMagicLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetMana(lua_State* L) { // player:getMana() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getMana()); } else { @@ -973,14 +970,14 @@ int PlayerFunctions::luaPlayerGetMana(lua_State* L) { int PlayerFunctions::luaPlayerAddMana(lua_State* L) { // player:addMana(manaChange[, animationOnLoss = false]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - int32_t manaChange = getNumber<int32_t>(L, 2); - bool animationOnLoss = getBoolean(L, 3, false); + const int32_t manaChange = getNumber<int32_t>(L, 2); + const bool animationOnLoss = getBoolean(L, 3, false); if (!animationOnLoss && manaChange < 0) { player->changeMana(manaChange); } else { @@ -995,7 +992,7 @@ int PlayerFunctions::luaPlayerAddMana(lua_State* L) { int PlayerFunctions::luaPlayerGetMaxMana(lua_State* L) { // player:getMaxMana() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getMaxMana()); } else { @@ -1022,7 +1019,7 @@ int PlayerFunctions::luaPlayerSetMaxMana(lua_State* L) { int PlayerFunctions::luaPlayerGetManaSpent(lua_State* L) { // player:getManaSpent() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getSpentMana()); } else { @@ -1033,7 +1030,7 @@ int PlayerFunctions::luaPlayerGetManaSpent(lua_State* L) { int PlayerFunctions::luaPlayerAddManaSpent(lua_State* L) { // player:addManaSpent(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->addManaSpent(getNumber<uint64_t>(L, 2)); pushBoolean(L, true); @@ -1045,7 +1042,7 @@ int PlayerFunctions::luaPlayerAddManaSpent(lua_State* L) { int PlayerFunctions::luaPlayerGetBaseMaxHealth(lua_State* L) { // player:getBaseMaxHealth() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->healthMax); } else { @@ -1056,7 +1053,7 @@ int PlayerFunctions::luaPlayerGetBaseMaxHealth(lua_State* L) { int PlayerFunctions::luaPlayerGetBaseMaxMana(lua_State* L) { // player:getBaseMaxMana() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->manaMax); } else { @@ -1067,8 +1064,8 @@ int PlayerFunctions::luaPlayerGetBaseMaxMana(lua_State* L) { int PlayerFunctions::luaPlayerGetSkillLevel(lua_State* L) { // player:getSkillLevel(skillType) - skills_t skillType = getNumber<skills_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const skills_t skillType = getNumber<skills_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player && skillType <= SKILL_LAST) { lua_pushnumber(L, player->skills[skillType].level); } else { @@ -1079,8 +1076,8 @@ int PlayerFunctions::luaPlayerGetSkillLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetEffectiveSkillLevel(lua_State* L) { // player:getEffectiveSkillLevel(skillType) - skills_t skillType = getNumber<skills_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const skills_t skillType = getNumber<skills_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player && skillType <= SKILL_LAST) { lua_pushnumber(L, player->getSkillLevel(skillType)); } else { @@ -1091,8 +1088,8 @@ int PlayerFunctions::luaPlayerGetEffectiveSkillLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetSkillPercent(lua_State* L) { // player:getSkillPercent(skillType) - skills_t skillType = getNumber<skills_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const skills_t skillType = getNumber<skills_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player && skillType <= SKILL_LAST) { lua_pushnumber(L, player->skills[skillType].percent); } else { @@ -1103,8 +1100,8 @@ int PlayerFunctions::luaPlayerGetSkillPercent(lua_State* L) { int PlayerFunctions::luaPlayerGetSkillTries(lua_State* L) { // player:getSkillTries(skillType) - skills_t skillType = getNumber<skills_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const skills_t skillType = getNumber<skills_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player && skillType <= SKILL_LAST) { lua_pushnumber(L, player->skills[skillType].tries); } else { @@ -1115,10 +1112,10 @@ int PlayerFunctions::luaPlayerGetSkillTries(lua_State* L) { int PlayerFunctions::luaPlayerAddSkillTries(lua_State* L) { // player:addSkillTries(skillType, tries) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - skills_t skillType = getNumber<skills_t>(L, 2); - uint64_t tries = getNumber<uint64_t>(L, 3); + const skills_t skillType = getNumber<skills_t>(L, 2); + const uint64_t tries = getNumber<uint64_t>(L, 3); player->addSkillAdvance(skillType, tries); pushBoolean(L, true); } else { @@ -1129,9 +1126,9 @@ int PlayerFunctions::luaPlayerAddSkillTries(lua_State* L) { int PlayerFunctions::luaPlayerSetLevel(lua_State* L) { // player:setLevel(level) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t level = getNumber<uint16_t>(L, 2); + const uint16_t level = getNumber<uint16_t>(L, 2); player->level = level; player->experience = Player::getExpForLevel(level); player->sendStats(); @@ -1145,13 +1142,13 @@ int PlayerFunctions::luaPlayerSetLevel(lua_State* L) { int PlayerFunctions::luaPlayerSetMagicLevel(lua_State* L) { // player:setMagicLevel(level[, manaSpent]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t level = getNumber<uint16_t>(L, 2); + const uint16_t level = getNumber<uint16_t>(L, 2); player->magLevel = level; if (getNumber<uint64_t>(L, 3, 0) > 0) { - uint64_t manaSpent = getNumber<uint64_t>(L, 3); - uint64_t nextReqMana = player->vocation->getReqMana(level + 1); + const uint64_t manaSpent = getNumber<uint64_t>(L, 3); + const uint64_t nextReqMana = player->vocation->getReqMana(level + 1); player->manaSpent = manaSpent; player->magLevelPercent = Player::getPercentLevel(manaSpent, nextReqMana); } else { @@ -1169,14 +1166,14 @@ int PlayerFunctions::luaPlayerSetMagicLevel(lua_State* L) { int PlayerFunctions::luaPlayerSetSkillLevel(lua_State* L) { // player:setSkillLevel(skillType, level[, tries]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - skills_t skillType = getNumber<skills_t>(L, 2); - uint16_t level = getNumber<uint16_t>(L, 3); + const skills_t skillType = getNumber<skills_t>(L, 2); + const uint16_t level = getNumber<uint16_t>(L, 3); player->skills[skillType].level = level; if (getNumber<uint64_t>(L, 4, 0) > 0) { - uint64_t tries = getNumber<uint64_t>(L, 4); - uint64_t nextReqTries = player->vocation->getReqSkillTries(skillType, level + 1); + const uint64_t tries = getNumber<uint64_t>(L, 4); + const uint64_t nextReqTries = player->vocation->getReqSkillTries(skillType, level + 1); player->skills[skillType].tries = tries; player->skills[skillType].percent = Player::getPercentLevel(tries, nextReqTries); } else { @@ -1194,9 +1191,9 @@ int PlayerFunctions::luaPlayerSetSkillLevel(lua_State* L) { int PlayerFunctions::luaPlayerAddOfflineTrainingTime(lua_State* L) { // player:addOfflineTrainingTime(time) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - int32_t time = getNumber<int32_t>(L, 2); + const int32_t time = getNumber<int32_t>(L, 2); player->addOfflineTrainingTime(time); player->sendStats(); pushBoolean(L, true); @@ -1208,7 +1205,7 @@ int PlayerFunctions::luaPlayerAddOfflineTrainingTime(lua_State* L) { int PlayerFunctions::luaPlayerGetOfflineTrainingTime(lua_State* L) { // player:getOfflineTrainingTime() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getOfflineTrainingTime()); } else { @@ -1219,9 +1216,9 @@ int PlayerFunctions::luaPlayerGetOfflineTrainingTime(lua_State* L) { int PlayerFunctions::luaPlayerRemoveOfflineTrainingTime(lua_State* L) { // player:removeOfflineTrainingTime(time) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - int32_t time = getNumber<int32_t>(L, 2); + const int32_t time = getNumber<int32_t>(L, 2); player->removeOfflineTrainingTime(time); player->sendStats(); pushBoolean(L, true); @@ -1233,10 +1230,10 @@ int PlayerFunctions::luaPlayerRemoveOfflineTrainingTime(lua_State* L) { int PlayerFunctions::luaPlayerAddOfflineTrainingTries(lua_State* L) { // player:addOfflineTrainingTries(skillType, tries) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - skills_t skillType = getNumber<skills_t>(L, 2); - uint64_t tries = getNumber<uint64_t>(L, 3); + const skills_t skillType = getNumber<skills_t>(L, 2); + const uint64_t tries = getNumber<uint64_t>(L, 3); pushBoolean(L, player->addOfflineTrainingTries(skillType, tries)); } else { lua_pushnil(L); @@ -1246,7 +1243,7 @@ int PlayerFunctions::luaPlayerAddOfflineTrainingTries(lua_State* L) { int PlayerFunctions::luaPlayerGetOfflineTrainingSkill(lua_State* L) { // player:getOfflineTrainingSkill() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getOfflineTrainingSkill()); } else { @@ -1257,9 +1254,9 @@ int PlayerFunctions::luaPlayerGetOfflineTrainingSkill(lua_State* L) { int PlayerFunctions::luaPlayerSetOfflineTrainingSkill(lua_State* L) { // player:setOfflineTrainingSkill(skillId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - int8_t skillId = getNumber<int8_t>(L, 2); + const int8_t skillId = getNumber<int8_t>(L, 2); player->setOfflineTrainingSkill(skillId); pushBoolean(L, true); } else { @@ -1270,8 +1267,8 @@ int PlayerFunctions::luaPlayerSetOfflineTrainingSkill(lua_State* L) { int PlayerFunctions::luaPlayerOpenStash(lua_State* L) { // player:openStash(isNpc) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); - bool isNpc = getBoolean(L, 2, false); + const auto &player = getUserdataShared<Player>(L, 1); + const bool isNpc = getBoolean(L, 2, false); if (player) { player->sendOpenStash(isNpc); pushBoolean(L, true); @@ -1284,7 +1281,7 @@ int PlayerFunctions::luaPlayerOpenStash(lua_State* L) { int PlayerFunctions::luaPlayerGetItemCount(lua_State* L) { // player:getItemCount(itemId[, subType = -1]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1301,14 +1298,14 @@ int PlayerFunctions::luaPlayerGetItemCount(lua_State* L) { } } - int32_t subType = getNumber<int32_t>(L, 3, -1); + const auto subType = getNumber<int32_t>(L, 3, -1); lua_pushnumber(L, player->getItemTypeCount(itemId, subType)); return 1; } int PlayerFunctions::luaPlayerGetStashItemCount(lua_State* L) { // player:getStashItemCount(itemId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1337,7 +1334,7 @@ int PlayerFunctions::luaPlayerGetStashItemCount(lua_State* L) { int PlayerFunctions::luaPlayerGetItemById(lua_State* L) { // player:getItemById(itemId, deepSearch[, subType = -1]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1353,10 +1350,10 @@ int PlayerFunctions::luaPlayerGetItemById(lua_State* L) { return 1; } } - bool deepSearch = getBoolean(L, 3); - int32_t subType = getNumber<int32_t>(L, 4, -1); + const bool deepSearch = getBoolean(L, 3); + const auto subType = getNumber<int32_t>(L, 4, -1); - std::shared_ptr<Item> item = g_game().findItemOfType(player, itemId, deepSearch, subType); + const auto &item = g_game().findItemOfType(player, itemId, deepSearch, subType); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -1368,7 +1365,7 @@ int PlayerFunctions::luaPlayerGetItemById(lua_State* L) { int PlayerFunctions::luaPlayerGetVocation(lua_State* L) { // player:getVocation() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushUserdata<Vocation>(L, player->getVocation()); setMetatable(L, -1, "Vocation"); @@ -1380,7 +1377,7 @@ int PlayerFunctions::luaPlayerGetVocation(lua_State* L) { int PlayerFunctions::luaPlayerSetVocation(lua_State* L) { // player:setVocation(id or name or userdata) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1414,7 +1411,7 @@ int PlayerFunctions::luaPlayerSetVocation(lua_State* L) { int PlayerFunctions::luaPlayerIsPromoted(lua_State* L) { // player:isPromoted() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushBoolean(L, player->isPromoted()); } else { @@ -1425,7 +1422,7 @@ int PlayerFunctions::luaPlayerIsPromoted(lua_State* L) { int PlayerFunctions::luaPlayerGetSex(lua_State* L) { // player:getSex() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getSex()); } else { @@ -1436,9 +1433,9 @@ int PlayerFunctions::luaPlayerGetSex(lua_State* L) { int PlayerFunctions::luaPlayerSetSex(lua_State* L) { // player:setSex(newSex) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - PlayerSex_t newSex = getNumber<PlayerSex_t>(L, 2); + const PlayerSex_t newSex = getNumber<PlayerSex_t>(L, 2); player->setSex(newSex); pushBoolean(L, true); } else { @@ -1449,7 +1446,7 @@ int PlayerFunctions::luaPlayerSetSex(lua_State* L) { int PlayerFunctions::luaPlayerGetPronoun(lua_State* L) { // player:getPronoun() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getPronoun()); } else { @@ -1460,9 +1457,9 @@ int PlayerFunctions::luaPlayerGetPronoun(lua_State* L) { int PlayerFunctions::luaPlayerSetPronoun(lua_State* L) { // player:setPronoun(newPronoun) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - PlayerPronoun_t newPronoun = getNumber<PlayerPronoun_t>(L, 2); + const PlayerPronoun_t newPronoun = getNumber<PlayerPronoun_t>(L, 2); player->setPronoun(newPronoun); pushBoolean(L, true); } else { @@ -1473,7 +1470,7 @@ int PlayerFunctions::luaPlayerSetPronoun(lua_State* L) { int PlayerFunctions::luaPlayerGetTown(lua_State* L) { // player:getTown() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushUserdata<Town>(L, player->getTown()); setMetatable(L, -1, "Town"); @@ -1491,7 +1488,7 @@ int PlayerFunctions::luaPlayerSetTown(lua_State* L) { return 1; } - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setTown(town); pushBoolean(L, true); @@ -1503,13 +1500,13 @@ int PlayerFunctions::luaPlayerSetTown(lua_State* L) { int PlayerFunctions::luaPlayerGetGuild(lua_State* L) { // player:getGuild() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - const auto guild = player->getGuild(); + const auto &guild = player->getGuild(); if (!guild) { lua_pushnil(L); return 1; @@ -1522,13 +1519,13 @@ int PlayerFunctions::luaPlayerGetGuild(lua_State* L) { int PlayerFunctions::luaPlayerSetGuild(lua_State* L) { // player:setGuild(guild) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - const auto guild = getUserdataShared<Guild>(L, 2); + const auto &guild = getUserdataShared<Guild>(L, 2); player->setGuild(guild); pushBoolean(L, true); @@ -1537,7 +1534,7 @@ int PlayerFunctions::luaPlayerSetGuild(lua_State* L) { int PlayerFunctions::luaPlayerGetGuildLevel(lua_State* L) { // player:getGuildLevel() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player && player->getGuild()) { lua_pushnumber(L, player->getGuildRank()->level); } else { @@ -1548,14 +1545,14 @@ int PlayerFunctions::luaPlayerGetGuildLevel(lua_State* L) { int PlayerFunctions::luaPlayerSetGuildLevel(lua_State* L) { // player:setGuildLevel(level) - uint8_t level = getNumber<uint8_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const uint8_t level = getNumber<uint8_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getGuild()) { lua_pushnil(L); return 1; } - GuildRank_ptr rank = player->getGuild()->getRankByLevel(level); + const auto &rank = player->getGuild()->getRankByLevel(level); if (!rank) { pushBoolean(L, false); } else { @@ -1568,7 +1565,7 @@ int PlayerFunctions::luaPlayerSetGuildLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetGuildNick(lua_State* L) { // player:getGuildNick() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushString(L, player->getGuildNick()); } else { @@ -1580,7 +1577,7 @@ int PlayerFunctions::luaPlayerGetGuildNick(lua_State* L) { int PlayerFunctions::luaPlayerSetGuildNick(lua_State* L) { // player:setGuildNick(nick) const std::string &nick = getString(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setGuildNick(nick); pushBoolean(L, true); @@ -1592,7 +1589,7 @@ int PlayerFunctions::luaPlayerSetGuildNick(lua_State* L) { int PlayerFunctions::luaPlayerGetGroup(lua_State* L) { // player:getGroup() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushUserdata<Group>(L, player->getGroup()); setMetatable(L, -1, "Group"); @@ -1604,13 +1601,13 @@ int PlayerFunctions::luaPlayerGetGroup(lua_State* L) { int PlayerFunctions::luaPlayerSetGroup(lua_State* L) { // player:setGroup(group) - std::shared_ptr<Group> group = getUserdataShared<Group>(L, 2); + const auto &group = getUserdataShared<Group>(L, 2); if (!group) { pushBoolean(L, false); return 1; } - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setGroup(group); pushBoolean(L, true); @@ -1622,10 +1619,10 @@ int PlayerFunctions::luaPlayerSetGroup(lua_State* L) { int PlayerFunctions::luaPlayerSetSpecialContainersAvailable(lua_State* L) { // player:setSpecialContainersAvailable(stashMenu, marketMenu, depotSearchMenu) - bool supplyStashMenu = getBoolean(L, 2, false); - bool marketMenu = getBoolean(L, 3, false); - bool depotSearchMenu = getBoolean(L, 4, false); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const bool supplyStashMenu = getBoolean(L, 2, false); + const bool marketMenu = getBoolean(L, 3, false); + const bool depotSearchMenu = getBoolean(L, 4, false); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setSpecialMenuAvailable(supplyStashMenu, marketMenu, depotSearchMenu); pushBoolean(L, true); @@ -1637,7 +1634,7 @@ int PlayerFunctions::luaPlayerSetSpecialContainersAvailable(lua_State* L) { int PlayerFunctions::luaPlayerGetStamina(lua_State* L) { // player:getStamina() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getStaminaMinutes()); } else { @@ -1648,8 +1645,8 @@ int PlayerFunctions::luaPlayerGetStamina(lua_State* L) { int PlayerFunctions::luaPlayerSetStamina(lua_State* L) { // player:setStamina(stamina) - uint16_t stamina = getNumber<uint16_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const uint16_t stamina = getNumber<uint16_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->staminaMinutes = std::min<uint16_t>(2520, stamina); player->sendStats(); @@ -1661,7 +1658,7 @@ int PlayerFunctions::luaPlayerSetStamina(lua_State* L) { int PlayerFunctions::luaPlayerGetSoul(lua_State* L) { // player:getSoul() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getSoul()); } else { @@ -1672,8 +1669,8 @@ int PlayerFunctions::luaPlayerGetSoul(lua_State* L) { int PlayerFunctions::luaPlayerAddSoul(lua_State* L) { // player:addSoul(soulChange) - int32_t soulChange = getNumber<int32_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const int32_t soulChange = getNumber<int32_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->changeSoul(soulChange); pushBoolean(L, true); @@ -1685,7 +1682,7 @@ int PlayerFunctions::luaPlayerAddSoul(lua_State* L) { int PlayerFunctions::luaPlayerGetMaxSoul(lua_State* L) { // player:getMaxSoul() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player && player->vocation) { lua_pushnumber(L, player->vocation->getSoulMax()); } else { @@ -1696,7 +1693,7 @@ int PlayerFunctions::luaPlayerGetMaxSoul(lua_State* L) { int PlayerFunctions::luaPlayerGetBankBalance(lua_State* L) { // player:getBankBalance() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getBankBalance()); } else { @@ -1707,7 +1704,7 @@ int PlayerFunctions::luaPlayerGetBankBalance(lua_State* L) { int PlayerFunctions::luaPlayerSetBankBalance(lua_State* L) { // player:setBankBalance(bankBalance) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1720,22 +1717,22 @@ int PlayerFunctions::luaPlayerSetBankBalance(lua_State* L) { int PlayerFunctions::luaPlayerGetStorageValue(lua_State* L) { // player:getStorageValue(key) - const auto player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint32_t key = getNumber<uint32_t>(L, 2); + const uint32_t key = getNumber<uint32_t>(L, 2); lua_pushnumber(L, player->getStorageValue(key)); return 1; } int PlayerFunctions::luaPlayerSetStorageValue(lua_State* L) { // player:setStorageValue(key, value) - int32_t value = getNumber<int32_t>(L, 3); - uint32_t key = getNumber<uint32_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const int32_t value = getNumber<int32_t>(L, 3); + const uint32_t key = getNumber<uint32_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (IS_IN_KEYRANGE(key, RESERVED_RANGE)) { std::ostringstream ss; ss << "Accessing reserved range: " << key; @@ -1760,7 +1757,7 @@ int PlayerFunctions::luaPlayerSetStorageValue(lua_State* L) { int PlayerFunctions::luaPlayerGetStorageValueByName(lua_State* L) { // player:getStorageValueByName(name) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -1768,14 +1765,14 @@ int PlayerFunctions::luaPlayerGetStorageValueByName(lua_State* L) { } g_logger().warn("The function 'player:getStorageValueByName' is deprecated and will be removed in future versions, please use KV system"); - auto name = getString(L, 2); + const auto name = getString(L, 2); lua_pushnumber(L, player->getStorageValueByName(name)); return 1; } int PlayerFunctions::luaPlayerSetStorageValueByName(lua_State* L) { // player:setStorageValueByName(storageName, value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -1783,8 +1780,8 @@ int PlayerFunctions::luaPlayerSetStorageValueByName(lua_State* L) { } g_logger().warn("The function 'player:setStorageValueByName' is deprecated and will be removed in future versions, please use KV system"); - auto storageName = getString(L, 2); - int32_t value = getNumber<int32_t>(L, 3); + const auto storageName = getString(L, 2); + const int32_t value = getNumber<int32_t>(L, 3); player->addStorageValueByName(storageName, value); pushBoolean(L, true); @@ -1793,7 +1790,7 @@ int PlayerFunctions::luaPlayerSetStorageValueByName(lua_State* L) { int PlayerFunctions::luaPlayerAddItem(lua_State* L) { // player:addItem(itemId, count = 1, canDropOnMap = true, subType = 1, slot = CONST_SLOT_WHEREEVER, tier = 0) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { pushBoolean(L, false); return 1; @@ -1810,18 +1807,18 @@ int PlayerFunctions::luaPlayerAddItem(lua_State* L) { } } - int32_t count = getNumber<int32_t>(L, 3, 1); - int32_t subType = getNumber<int32_t>(L, 5, 1); + const auto count = getNumber<int32_t>(L, 3, 1); + auto subType = getNumber<int32_t>(L, 5, 1); const ItemType &it = Item::items[itemId]; int32_t itemCount = 1; - int parameters = lua_gettop(L); + const int parameters = lua_gettop(L); if (parameters >= 4) { itemCount = std::max<int32_t>(1, count); } else if (it.hasSubType()) { if (it.stackable) { - itemCount = std::ceil(count / (float_t)it.stackSize); + itemCount = std::ceil(count / static_cast<float_t>(it.stackSize)); } subType = count; @@ -1829,7 +1826,7 @@ int PlayerFunctions::luaPlayerAddItem(lua_State* L) { itemCount = std::max<int32_t>(1, count); } - bool hasTable = itemCount > 1; + const bool hasTable = itemCount > 1; if (hasTable) { lua_newtable(L); } else if (itemCount == 0) { @@ -1837,9 +1834,9 @@ int PlayerFunctions::luaPlayerAddItem(lua_State* L) { return 1; } - bool canDropOnMap = getBoolean(L, 4, true); - Slots_t slot = getNumber<Slots_t>(L, 6, CONST_SLOT_WHEREEVER); - auto tier = getNumber<uint8_t>(L, 7, 0); + const bool canDropOnMap = getBoolean(L, 4, true); + const auto slot = getNumber<Slots_t>(L, 6, CONST_SLOT_WHEREEVER); + const auto tier = getNumber<uint8_t>(L, 7, 0); for (int32_t i = 1; i <= itemCount; ++i) { int32_t stackCount = subType; if (it.stackable) { @@ -1847,7 +1844,7 @@ int PlayerFunctions::luaPlayerAddItem(lua_State* L) { subType -= stackCount; } - std::shared_ptr<Item> item = Item::CreateItem(itemId, stackCount); + const auto &item = Item::CreateItem(itemId, stackCount); if (!item) { if (!hasTable) { lua_pushnil(L); @@ -1885,14 +1882,14 @@ int PlayerFunctions::luaPlayerAddItem(lua_State* L) { int PlayerFunctions::luaPlayerAddItemEx(lua_State* L) { // player:addItemEx(item[, canDropOnMap = false[, index = INDEX_WHEREEVER[, flags = 0]]]) // player:addItemEx(item[, canDropOnMap = true[, slot = CONST_SLOT_WHEREEVER]]) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); + const auto &item = getUserdataShared<Item>(L, 2); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1904,14 +1901,14 @@ int PlayerFunctions::luaPlayerAddItemEx(lua_State* L) { return 1; } - bool canDropOnMap = getBoolean(L, 3, false); + const bool canDropOnMap = getBoolean(L, 3, false); ReturnValue returnValue; if (canDropOnMap) { - Slots_t slot = getNumber<Slots_t>(L, 4, CONST_SLOT_WHEREEVER); + const auto slot = getNumber<Slots_t>(L, 4, CONST_SLOT_WHEREEVER); returnValue = g_game().internalPlayerAddItem(player, item, true, slot); } else { - int32_t index = getNumber<int32_t>(L, 4, INDEX_WHEREEVER); - uint32_t flags = getNumber<uint32_t>(L, 5, 0); + const auto index = getNumber<int32_t>(L, 4, INDEX_WHEREEVER); + const auto flags = getNumber<uint32_t>(L, 5, 0); returnValue = g_game().internalAddItem(player, item, index, flags); } @@ -1924,14 +1921,14 @@ int PlayerFunctions::luaPlayerAddItemEx(lua_State* L) { int PlayerFunctions::luaPlayerAddItemStash(lua_State* L) { // player:addItemStash(itemId, count = 1) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - auto itemId = getNumber<uint16_t>(L, 2); - auto count = getNumber<uint32_t>(L, 3, 1); + const auto itemId = getNumber<uint16_t>(L, 2); + const auto count = getNumber<uint32_t>(L, 3, 1); player->addItemOnStash(itemId, count); pushBoolean(L, true); @@ -1940,7 +1937,7 @@ int PlayerFunctions::luaPlayerAddItemStash(lua_State* L) { int PlayerFunctions::luaPlayerRemoveStashItem(lua_State* L) { // player:removeStashItem(itemId, count) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1963,14 +1960,14 @@ int PlayerFunctions::luaPlayerRemoveStashItem(lua_State* L) { return 1; } - uint32_t count = getNumber<uint32_t>(L, 3); + const uint32_t count = getNumber<uint32_t>(L, 3); pushBoolean(L, player->withdrawItem(itemType.id, count)); return 1; } int PlayerFunctions::luaPlayerRemoveItem(lua_State* L) { // player:removeItem(itemId, count[, subType = -1[, ignoreEquipped = false]]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -1987,22 +1984,22 @@ int PlayerFunctions::luaPlayerRemoveItem(lua_State* L) { } } - uint32_t count = getNumber<uint32_t>(L, 3); - int32_t subType = getNumber<int32_t>(L, 4, -1); - bool ignoreEquipped = getBoolean(L, 5, false); + const uint32_t count = getNumber<uint32_t>(L, 3); + const auto subType = getNumber<int32_t>(L, 4, -1); + const bool ignoreEquipped = getBoolean(L, 5, false); pushBoolean(L, player->removeItemOfType(itemId, count, subType, ignoreEquipped)); return 1; } int PlayerFunctions::luaPlayerSendContainer(lua_State* L) { // player:sendContainer(container) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 2); + const auto &container = getUserdataShared<Container>(L, 2); if (!container) { lua_pushnil(L); return 1; @@ -2015,13 +2012,13 @@ int PlayerFunctions::luaPlayerSendContainer(lua_State* L) { int PlayerFunctions::luaPlayerSendUpdateContainer(lua_State* L) { // player:sendUpdateContainer(container) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - const auto container = getUserdataShared<Container>(L, 2); + const auto &container = getUserdataShared<Container>(L, 2); if (!container) { reportErrorFunc("Container is nullptr"); return 1; @@ -2034,7 +2031,7 @@ int PlayerFunctions::luaPlayerSendUpdateContainer(lua_State* L) { int PlayerFunctions::luaPlayerGetMoney(lua_State* L) { // player:getMoney() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getMoney()); } else { @@ -2045,8 +2042,8 @@ int PlayerFunctions::luaPlayerGetMoney(lua_State* L) { int PlayerFunctions::luaPlayerAddMoney(lua_State* L) { // player:addMoney(money) - uint64_t money = getNumber<uint64_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const uint64_t money = getNumber<uint64_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { g_game().addMoney(player, money); pushBoolean(L, true); @@ -2058,11 +2055,11 @@ int PlayerFunctions::luaPlayerAddMoney(lua_State* L) { int PlayerFunctions::luaPlayerRemoveMoney(lua_State* L) { // player:removeMoney(money[, flags = 0[, useBank = true]]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint64_t money = getNumber<uint64_t>(L, 2); - int32_t flags = getNumber<int32_t>(L, 3, 0); - bool useBank = getBoolean(L, 4, true); + const uint64_t money = getNumber<uint64_t>(L, 2); + const auto flags = getNumber<int32_t>(L, 3, 0); + const bool useBank = getBoolean(L, 4, true); pushBoolean(L, g_game().removeMoney(player, money, flags, useBank)); } else { lua_pushnil(L); @@ -2072,17 +2069,17 @@ int PlayerFunctions::luaPlayerRemoveMoney(lua_State* L) { int PlayerFunctions::luaPlayerShowTextDialog(lua_State* L) { // player:showTextDialog(id or name or userdata[, text[, canWrite[, length]]]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - int32_t length = getNumber<int32_t>(L, 5, -1); - bool canWrite = getBoolean(L, 4, false); + auto length = getNumber<int32_t>(L, 5, -1); + const bool canWrite = getBoolean(L, 4, false); std::string text; - int parameters = lua_gettop(L); + const int parameters = lua_gettop(L); if (parameters >= 3) { text = getString(L, 3); } @@ -2129,17 +2126,17 @@ int PlayerFunctions::luaPlayerSendTextMessage(lua_State* L) { // player:sendTextMessage(type, text[, position, primaryValue = 0, primaryColor = TEXTCOLOR_NONE[, secondaryValue = 0, secondaryColor = TEXTCOLOR_NONE]]) // player:sendTextMessage(type, text, channelId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - int parameters = lua_gettop(L); + const int parameters = lua_gettop(L); TextMessage message(getNumber<MessageClasses>(L, 2), getString(L, 3)); if (parameters == 4) { - uint16_t channelId = getNumber<uint16_t>(L, 4); + const uint16_t channelId = getNumber<uint16_t>(L, 4); const auto &channel = g_chat().getChannel(player, channelId); if (!channel || !channel->hasUser(player)) { pushBoolean(L, false); @@ -2167,14 +2164,14 @@ int PlayerFunctions::luaPlayerSendTextMessage(lua_State* L) { int PlayerFunctions::luaPlayerSendChannelMessage(lua_State* L) { // player:sendChannelMessage(author, text, type, channelId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint16_t channelId = getNumber<uint16_t>(L, 5); - SpeakClasses type = getNumber<SpeakClasses>(L, 4); + const uint16_t channelId = getNumber<uint16_t>(L, 5); + const SpeakClasses type = getNumber<SpeakClasses>(L, 4); const std::string &text = getString(L, 3); const std::string &author = getString(L, 2); player->sendChannelMessage(author, text, type, channelId); @@ -2184,15 +2181,15 @@ int PlayerFunctions::luaPlayerSendChannelMessage(lua_State* L) { int PlayerFunctions::luaPlayerSendPrivateMessage(lua_State* L) { // player:sendPrivateMessage(speaker, text[, type]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Player> speaker = getUserdataShared<Player>(L, 2); + const auto &speaker = getUserdataShared<Player>(L, 2); const std::string &text = getString(L, 3); - SpeakClasses type = getNumber<SpeakClasses>(L, 4, TALKTYPE_PRIVATE_FROM); + const auto type = getNumber<SpeakClasses>(L, 4, TALKTYPE_PRIVATE_FROM); player->sendPrivateMessage(speaker, type, text); pushBoolean(L, true); return 1; @@ -2200,16 +2197,16 @@ int PlayerFunctions::luaPlayerSendPrivateMessage(lua_State* L) { int PlayerFunctions::luaPlayerChannelSay(lua_State* L) { // player:channelSay(speaker, type, text, channelId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> speaker = getCreature(L, 2); - SpeakClasses type = getNumber<SpeakClasses>(L, 3); + const auto &speaker = getCreature(L, 2); + const SpeakClasses type = getNumber<SpeakClasses>(L, 3); const std::string &text = getString(L, 4); - uint16_t channelId = getNumber<uint16_t>(L, 5); + const uint16_t channelId = getNumber<uint16_t>(L, 5); player->sendToChannel(speaker, type, text, channelId); pushBoolean(L, true); return 1; @@ -2217,8 +2214,8 @@ int PlayerFunctions::luaPlayerChannelSay(lua_State* L) { int PlayerFunctions::luaPlayerOpenChannel(lua_State* L) { // player:openChannel(channelId) - uint16_t channelId = getNumber<uint16_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const uint16_t channelId = getNumber<uint16_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { g_game().playerOpenChannel(player->getID(), channelId); pushBoolean(L, true); @@ -2230,20 +2227,20 @@ int PlayerFunctions::luaPlayerOpenChannel(lua_State* L) { int PlayerFunctions::luaPlayerGetSlotItem(lua_State* L) { // player:getSlotItem(slot) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint32_t slot = getNumber<uint32_t>(L, 2); - std::shared_ptr<Thing> thing = player->getThing(slot); + const uint32_t slot = getNumber<uint32_t>(L, 2); + const auto &thing = player->getThing(slot); if (!thing) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -2255,13 +2252,13 @@ int PlayerFunctions::luaPlayerGetSlotItem(lua_State* L) { int PlayerFunctions::luaPlayerGetParty(lua_State* L) { // player:getParty() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Party> party = player->getParty(); + const auto &party = player->getParty(); if (party) { pushUserdata<Party>(L, party); setMetatable(L, -1, "Party"); @@ -2273,7 +2270,7 @@ int PlayerFunctions::luaPlayerGetParty(lua_State* L) { int PlayerFunctions::luaPlayerAddOutfit(lua_State* L) { // player:addOutfit(lookType or name, addon = 0) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { auto addon = getNumber<uint8_t>(L, 3, 0); if (lua_isnumber(L, 2)) { @@ -2298,10 +2295,10 @@ int PlayerFunctions::luaPlayerAddOutfit(lua_State* L) { int PlayerFunctions::luaPlayerAddOutfitAddon(lua_State* L) { // player:addOutfitAddon(lookType, addon) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t lookType = getNumber<uint16_t>(L, 2); - uint8_t addon = getNumber<uint8_t>(L, 3); + const uint16_t lookType = getNumber<uint16_t>(L, 2); + const uint8_t addon = getNumber<uint8_t>(L, 3); player->addOutfit(lookType, addon); pushBoolean(L, true); } else { @@ -2312,9 +2309,9 @@ int PlayerFunctions::luaPlayerAddOutfitAddon(lua_State* L) { int PlayerFunctions::luaPlayerRemoveOutfit(lua_State* L) { // player:removeOutfit(lookType) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t lookType = getNumber<uint16_t>(L, 2); + const uint16_t lookType = getNumber<uint16_t>(L, 2); pushBoolean(L, player->removeOutfit(lookType)); } else { lua_pushnil(L); @@ -2324,10 +2321,10 @@ int PlayerFunctions::luaPlayerRemoveOutfit(lua_State* L) { int PlayerFunctions::luaPlayerRemoveOutfitAddon(lua_State* L) { // player:removeOutfitAddon(lookType, addon) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t lookType = getNumber<uint16_t>(L, 2); - uint8_t addon = getNumber<uint8_t>(L, 3); + const uint16_t lookType = getNumber<uint16_t>(L, 2); + const uint8_t addon = getNumber<uint8_t>(L, 3); pushBoolean(L, player->removeOutfitAddon(lookType, addon)); } else { lua_pushnil(L); @@ -2337,10 +2334,10 @@ int PlayerFunctions::luaPlayerRemoveOutfitAddon(lua_State* L) { int PlayerFunctions::luaPlayerHasOutfit(lua_State* L) { // player:hasOutfit(lookType[, addon = 0]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t lookType = getNumber<uint16_t>(L, 2); - uint8_t addon = getNumber<uint8_t>(L, 3, 0); + const uint16_t lookType = getNumber<uint16_t>(L, 2); + const auto addon = getNumber<uint8_t>(L, 3, 0); pushBoolean(L, player->canWear(lookType, addon)); } else { lua_pushnil(L); @@ -2350,7 +2347,7 @@ int PlayerFunctions::luaPlayerHasOutfit(lua_State* L) { int PlayerFunctions::luaPlayerSendOutfitWindow(lua_State* L) { // player:sendOutfitWindow() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->sendOutfitWindow(); pushBoolean(L, true); @@ -2362,7 +2359,7 @@ int PlayerFunctions::luaPlayerSendOutfitWindow(lua_State* L) { int PlayerFunctions::luaPlayerAddMount(lua_State* L) { // player:addMount(mountId or mountName) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -2372,7 +2369,7 @@ int PlayerFunctions::luaPlayerAddMount(lua_State* L) { if (isNumber(L, 2)) { mountId = getNumber<uint8_t>(L, 2); } else { - const std::shared_ptr<Mount> mount = g_game().mounts.getMountByName(getString(L, 2)); + const auto &mount = g_game().mounts.getMountByName(getString(L, 2)); if (!mount) { lua_pushnil(L); return 1; @@ -2385,7 +2382,7 @@ int PlayerFunctions::luaPlayerAddMount(lua_State* L) { int PlayerFunctions::luaPlayerRemoveMount(lua_State* L) { // player:removeMount(mountId or mountName) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -2395,7 +2392,7 @@ int PlayerFunctions::luaPlayerRemoveMount(lua_State* L) { if (isNumber(L, 2)) { mountId = getNumber<uint8_t>(L, 2); } else { - const std::shared_ptr<Mount> mount = g_game().mounts.getMountByName(getString(L, 2)); + const auto &mount = g_game().mounts.getMountByName(getString(L, 2)); if (!mount) { lua_pushnil(L); return 1; @@ -2408,7 +2405,7 @@ int PlayerFunctions::luaPlayerRemoveMount(lua_State* L) { int PlayerFunctions::luaPlayerHasMount(lua_State* L) { // player:hasMount(mountId or mountName) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -2431,7 +2428,7 @@ int PlayerFunctions::luaPlayerHasMount(lua_State* L) { int PlayerFunctions::luaPlayerAddFamiliar(lua_State* L) { // player:addFamiliar(lookType) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->addFamiliar(getNumber<uint16_t>(L, 2)); pushBoolean(L, true); @@ -2443,9 +2440,9 @@ int PlayerFunctions::luaPlayerAddFamiliar(lua_State* L) { int PlayerFunctions::luaPlayerRemoveFamiliar(lua_State* L) { // player:removeFamiliar(lookType) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t lookType = getNumber<uint16_t>(L, 2); + const uint16_t lookType = getNumber<uint16_t>(L, 2); pushBoolean(L, player->removeFamiliar(lookType)); } else { lua_pushnil(L); @@ -2455,9 +2452,9 @@ int PlayerFunctions::luaPlayerRemoveFamiliar(lua_State* L) { int PlayerFunctions::luaPlayerHasFamiliar(lua_State* L) { // player:hasFamiliar(lookType) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t lookType = getNumber<uint16_t>(L, 2); + const uint16_t lookType = getNumber<uint16_t>(L, 2); pushBoolean(L, player->canFamiliar(lookType)); } else { lua_pushnil(L); @@ -2467,7 +2464,7 @@ int PlayerFunctions::luaPlayerHasFamiliar(lua_State* L) { int PlayerFunctions::luaPlayerSetFamiliarLooktype(lua_State* L) { // player:setFamiliarLooktype(lookType) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setFamiliarLooktype(getNumber<uint16_t>(L, 2)); pushBoolean(L, true); @@ -2479,7 +2476,7 @@ int PlayerFunctions::luaPlayerSetFamiliarLooktype(lua_State* L) { int PlayerFunctions::luaPlayerGetFamiliarLooktype(lua_State* L) { // player:getFamiliarLooktype() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->defaultOutfit.lookFamiliarsType); } else { @@ -2490,7 +2487,7 @@ int PlayerFunctions::luaPlayerGetFamiliarLooktype(lua_State* L) { int PlayerFunctions::luaPlayerGetPremiumDays(lua_State* L) { // player:getPremiumDays() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player && player->getAccount()) { lua_pushnumber(L, player->getAccount()->getPremiumRemainingDays()); } else { @@ -2501,19 +2498,19 @@ int PlayerFunctions::luaPlayerGetPremiumDays(lua_State* L) { int PlayerFunctions::luaPlayerAddPremiumDays(lua_State* L) { // player:addPremiumDays(days) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { lua_pushnil(L); return 1; } - auto premiumDays = player->getAccount()->getPremiumRemainingDays(); + const auto premiumDays = player->getAccount()->getPremiumRemainingDays(); if (premiumDays == std::numeric_limits<uint16_t>::max()) { return 1; } - int32_t addDays = std::min<int32_t>(0xFFFE - premiumDays, getNumber<uint16_t>(L, 2)); + const int32_t addDays = std::min<int32_t>(0xFFFE - premiumDays, getNumber<uint16_t>(L, 2)); if (addDays <= 0) { return 1; } @@ -2530,19 +2527,19 @@ int PlayerFunctions::luaPlayerAddPremiumDays(lua_State* L) { int PlayerFunctions::luaPlayerRemovePremiumDays(lua_State* L) { // player:removePremiumDays(days) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { lua_pushnil(L); return 1; } - auto premiumDays = player->getAccount()->getPremiumRemainingDays(); + const auto premiumDays = player->getAccount()->getPremiumRemainingDays(); if (premiumDays == std::numeric_limits<uint16_t>::max()) { return 1; } - int32_t removeDays = std::min<int32_t>(0xFFFE - premiumDays, getNumber<uint16_t>(L, 2)); + const int32_t removeDays = std::min<int32_t>(0xFFFE - premiumDays, getNumber<uint16_t>(L, 2)); if (removeDays <= 0) { return 1; } @@ -2559,7 +2556,7 @@ int PlayerFunctions::luaPlayerRemovePremiumDays(lua_State* L) { int PlayerFunctions::luaPlayerGetTibiaCoins(lua_State* L) { // player:getTibiaCoins() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); lua_pushnil(L); @@ -2577,7 +2574,7 @@ int PlayerFunctions::luaPlayerGetTibiaCoins(lua_State* L) { int PlayerFunctions::luaPlayerAddTibiaCoins(lua_State* L) { // player:addTibiaCoins(coins) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); lua_pushnil(L); @@ -2603,7 +2600,7 @@ int PlayerFunctions::luaPlayerAddTibiaCoins(lua_State* L) { int PlayerFunctions::luaPlayerRemoveTibiaCoins(lua_State* L) { // player:removeTibiaCoins(coins) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); lua_pushnil(L); @@ -2628,7 +2625,7 @@ int PlayerFunctions::luaPlayerRemoveTibiaCoins(lua_State* L) { int PlayerFunctions::luaPlayerGetTransferableCoins(lua_State* L) { // player:getTransferableCoins() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); lua_pushnil(L); @@ -2646,7 +2643,7 @@ int PlayerFunctions::luaPlayerGetTransferableCoins(lua_State* L) { int PlayerFunctions::luaPlayerAddTransferableCoins(lua_State* L) { // player:addTransferableCoins(coins) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); lua_pushnil(L); @@ -2672,7 +2669,7 @@ int PlayerFunctions::luaPlayerAddTransferableCoins(lua_State* L) { int PlayerFunctions::luaPlayerRemoveTransferableCoins(lua_State* L) { // player:removeTransferableCoins(coins) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player || !player->getAccount()) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); lua_pushnil(L); @@ -2698,8 +2695,8 @@ int PlayerFunctions::luaPlayerRemoveTransferableCoins(lua_State* L) { int PlayerFunctions::luaPlayerHasBlessing(lua_State* L) { // player:hasBlessing(blessing) - uint8_t blessing = getNumber<uint8_t>(L, 2); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const uint8_t blessing = getNumber<uint8_t>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushBoolean(L, player->hasBlessing(blessing)); } else { @@ -2710,14 +2707,14 @@ int PlayerFunctions::luaPlayerHasBlessing(lua_State* L) { int PlayerFunctions::luaPlayerAddBlessing(lua_State* L) { // player:addBlessing(blessing) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint8_t blessing = getNumber<uint8_t>(L, 2); - uint8_t count = getNumber<uint8_t>(L, 3); + const uint8_t blessing = getNumber<uint8_t>(L, 2); + const uint8_t count = getNumber<uint8_t>(L, 3); player->addBlessing(blessing, count); player->sendBlessStatus(); @@ -2727,14 +2724,14 @@ int PlayerFunctions::luaPlayerAddBlessing(lua_State* L) { int PlayerFunctions::luaPlayerRemoveBlessing(lua_State* L) { // player:removeBlessing(blessing) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - uint8_t blessing = getNumber<uint8_t>(L, 2); - uint8_t count = getNumber<uint8_t>(L, 3); + const uint8_t blessing = getNumber<uint8_t>(L, 2); + const uint8_t count = getNumber<uint8_t>(L, 3); if (!player->hasBlessing(blessing)) { pushBoolean(L, false); @@ -2748,7 +2745,7 @@ int PlayerFunctions::luaPlayerRemoveBlessing(lua_State* L) { int PlayerFunctions::luaPlayerGetBlessingCount(lua_State* L) { // player:getBlessingCount(index[, storeCount = false]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); uint8_t index = getNumber<uint8_t>(L, 2); if (index == 0) { index = 1; @@ -2764,14 +2761,14 @@ int PlayerFunctions::luaPlayerGetBlessingCount(lua_State* L) { int PlayerFunctions::luaPlayerCanLearnSpell(lua_State* L) { // player:canLearnSpell(spellName) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } const std::string &spellName = getString(L, 2); - const auto spell = g_spells().getInstantSpellByName(spellName); + const auto &spell = g_spells().getInstantSpellByName(spellName); if (!spell) { reportErrorFunc("Spell \"" + spellName + "\" not found"); pushBoolean(L, false); @@ -2784,7 +2781,7 @@ int PlayerFunctions::luaPlayerCanLearnSpell(lua_State* L) { } const auto vocMap = spell->getVocMap(); - if (vocMap.count(player->getVocationId()) == 0) { + if (!vocMap.contains(player->getVocationId())) { pushBoolean(L, false); } else if (player->getLevel() < spell->getLevel()) { pushBoolean(L, false); @@ -2798,7 +2795,7 @@ int PlayerFunctions::luaPlayerCanLearnSpell(lua_State* L) { int PlayerFunctions::luaPlayerLearnSpell(lua_State* L) { // player:learnSpell(spellName) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { const std::string &spellName = getString(L, 2); player->learnInstantSpell(spellName); @@ -2811,7 +2808,7 @@ int PlayerFunctions::luaPlayerLearnSpell(lua_State* L) { int PlayerFunctions::luaPlayerForgetSpell(lua_State* L) { // player:forgetSpell(spellName) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { const std::string &spellName = getString(L, 2); player->forgetInstantSpell(spellName); @@ -2824,7 +2821,7 @@ int PlayerFunctions::luaPlayerForgetSpell(lua_State* L) { int PlayerFunctions::luaPlayerHasLearnedSpell(lua_State* L) { // player:hasLearnedSpell(spellName) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { const std::string &spellName = getString(L, 2); pushBoolean(L, player->hasLearnedInstantSpell(spellName)); @@ -2836,9 +2833,9 @@ int PlayerFunctions::luaPlayerHasLearnedSpell(lua_State* L) { int PlayerFunctions::luaPlayerSendTutorial(lua_State* L) { // player:sendTutorial(tutorialId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint8_t tutorialId = getNumber<uint8_t>(L, 2); + const uint8_t tutorialId = getNumber<uint8_t>(L, 2); player->sendTutorial(tutorialId); pushBoolean(L, true); } else { @@ -2849,14 +2846,14 @@ int PlayerFunctions::luaPlayerSendTutorial(lua_State* L) { int PlayerFunctions::luaPlayerOpenImbuementWindow(lua_State* L) { // player:openImbuementWindow(item) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 1; } - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); + const auto &item = getUserdataShared<Item>(L, 2); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -2869,7 +2866,7 @@ int PlayerFunctions::luaPlayerOpenImbuementWindow(lua_State* L) { int PlayerFunctions::luaPlayerCloseImbuementWindow(lua_State* L) { // player:closeImbuementWindow() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -2882,10 +2879,10 @@ int PlayerFunctions::luaPlayerCloseImbuementWindow(lua_State* L) { int PlayerFunctions::luaPlayerAddMapMark(lua_State* L) { // player:addMapMark(position, type, description) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { const Position &position = getPosition(L, 2); - uint8_t type = getNumber<uint8_t>(L, 3); + const uint8_t type = getNumber<uint8_t>(L, 3); const std::string &description = getString(L, 4); player->sendAddMarker(position, type, description); pushBoolean(L, true); @@ -2897,7 +2894,7 @@ int PlayerFunctions::luaPlayerAddMapMark(lua_State* L) { int PlayerFunctions::luaPlayerSave(lua_State* L) { // player:save() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { if (!player->isOffline()) { player->loginPosition = player->getPosition(); @@ -2911,7 +2908,7 @@ int PlayerFunctions::luaPlayerSave(lua_State* L) { int PlayerFunctions::luaPlayerPopupFYI(lua_State* L) { // player:popupFYI(message) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { const std::string &message = getString(L, 2); player->sendFYIBox(message); @@ -2924,7 +2921,7 @@ int PlayerFunctions::luaPlayerPopupFYI(lua_State* L) { int PlayerFunctions::luaPlayerIsPzLocked(lua_State* L) { // player:isPzLocked() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushBoolean(L, player->isPzLocked()); } else { @@ -2935,7 +2932,7 @@ int PlayerFunctions::luaPlayerIsPzLocked(lua_State* L) { int PlayerFunctions::luaPlayerGetClient(lua_State* L) { // player:getClient() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_createtable(L, 0, 2); setField(L, "version", player->getProtocolVersion()); @@ -2948,7 +2945,7 @@ int PlayerFunctions::luaPlayerGetClient(lua_State* L) { int PlayerFunctions::luaPlayerGetHouse(lua_State* L) { // player:getHouse() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -2966,7 +2963,7 @@ int PlayerFunctions::luaPlayerGetHouse(lua_State* L) { int PlayerFunctions::luaPlayerSendHouseWindow(lua_State* L) { // player:sendHouseWindow(house, listId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -2978,7 +2975,7 @@ int PlayerFunctions::luaPlayerSendHouseWindow(lua_State* L) { return 1; } - uint32_t listId = getNumber<uint32_t>(L, 3); + const uint32_t listId = getNumber<uint32_t>(L, 3); player->sendHouseWindow(house, listId); pushBoolean(L, true); return 1; @@ -2986,7 +2983,7 @@ int PlayerFunctions::luaPlayerSendHouseWindow(lua_State* L) { int PlayerFunctions::luaPlayerSetEditHouse(lua_State* L) { // player:setEditHouse(house, listId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -2998,7 +2995,7 @@ int PlayerFunctions::luaPlayerSetEditHouse(lua_State* L) { return 1; } - uint32_t listId = getNumber<uint32_t>(L, 3); + const uint32_t listId = getNumber<uint32_t>(L, 3); player->setEditHouse(house, listId); pushBoolean(L, true); return 1; @@ -3006,13 +3003,13 @@ int PlayerFunctions::luaPlayerSetEditHouse(lua_State* L) { int PlayerFunctions::luaPlayerSetGhostMode(lua_State* L) { // player:setGhostMode(enabled) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - bool enabled = getBoolean(L, 2); + const bool enabled = getBoolean(L, 2); if (player->isInGhostMode() == enabled) { pushBoolean(L, true); return 1; @@ -3020,7 +3017,7 @@ int PlayerFunctions::luaPlayerSetGhostMode(lua_State* L) { player->switchGhostMode(); - std::shared_ptr<Tile> tile = player->getTile(); + const auto &tile = player->getTile(); const Position &position = player->getPosition(); for (const auto &spectator : Spectators().find<Player>(position, true)) { @@ -3042,14 +3039,12 @@ int PlayerFunctions::luaPlayerSetGhostMode(lua_State* L) { it.second->vip()->notifyStatusChange(player, VipStatus_t::Offline); } } - IOLoginData::updateOnlineStatus(player->getGUID(), false); } else { for (const auto &it : g_game().getPlayers()) { if (!it.second->isAccessPlayer()) { it.second->vip()->notifyStatusChange(player, player->vip()->getStatus()); } } - IOLoginData::updateOnlineStatus(player->getGUID(), true); } pushBoolean(L, true); return 1; @@ -3057,13 +3052,13 @@ int PlayerFunctions::luaPlayerSetGhostMode(lua_State* L) { int PlayerFunctions::luaPlayerGetContainerId(lua_State* L) { // player:getContainerId(container) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 2); + const auto &container = getUserdataShared<Container>(L, 2); if (container) { lua_pushnumber(L, player->getContainerID(container)); } else { @@ -3074,13 +3069,13 @@ int PlayerFunctions::luaPlayerGetContainerId(lua_State* L) { int PlayerFunctions::luaPlayerGetContainerById(lua_State* L) { // player:getContainerById(id) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::shared_ptr<Container> container = player->getContainerByID(getNumber<uint8_t>(L, 2)); + const auto &container = player->getContainerByID(getNumber<uint8_t>(L, 2)); if (container) { pushUserdata<Container>(L, container); setMetatable(L, -1, "Container"); @@ -3092,7 +3087,7 @@ int PlayerFunctions::luaPlayerGetContainerById(lua_State* L) { int PlayerFunctions::luaPlayerGetContainerIndex(lua_State* L) { // player:getContainerIndex(id) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getContainerIndex(getNumber<uint8_t>(L, 2))); } else { @@ -3103,14 +3098,14 @@ int PlayerFunctions::luaPlayerGetContainerIndex(lua_State* L) { int PlayerFunctions::luaPlayerGetInstantSpells(lua_State* L) { // player:getInstantSpells() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } std::vector<std::shared_ptr<InstantSpell>> spells; - for (auto &[key, spell] : g_spells().getInstantSpells()) { + for (const auto &[key, spell] : g_spells().getInstantSpells()) { if (spell->canCast(player)) { spells.push_back(spell); } @@ -3119,7 +3114,7 @@ int PlayerFunctions::luaPlayerGetInstantSpells(lua_State* L) { lua_createtable(L, spells.size(), 0); int index = 0; - for (auto spell : spells) { + for (const auto &spell : spells) { pushInstantSpell(L, *spell); lua_rawseti(L, -2, ++index); } @@ -3128,8 +3123,8 @@ int PlayerFunctions::luaPlayerGetInstantSpells(lua_State* L) { int PlayerFunctions::luaPlayerCanCast(lua_State* L) { // player:canCast(spell) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); - const auto spell = getUserdataShared<InstantSpell>(L, 2); + const auto &player = getUserdataShared<Player>(L, 1); + const auto &spell = getUserdataShared<InstantSpell>(L, 2); if (player && spell) { pushBoolean(L, spell->canCast(player)); } else { @@ -3140,7 +3135,7 @@ int PlayerFunctions::luaPlayerCanCast(lua_State* L) { int PlayerFunctions::luaPlayerHasChaseMode(lua_State* L) { // player:hasChaseMode() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushBoolean(L, player->chaseMode); } else { @@ -3151,7 +3146,7 @@ int PlayerFunctions::luaPlayerHasChaseMode(lua_State* L) { int PlayerFunctions::luaPlayerHasSecureMode(lua_State* L) { // player:hasSecureMode() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushBoolean(L, player->secureMode); } else { @@ -3162,7 +3157,7 @@ int PlayerFunctions::luaPlayerHasSecureMode(lua_State* L) { int PlayerFunctions::luaPlayerGetFightMode(lua_State* L) { // player:getFightMode() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->fightMode); } else { @@ -3173,7 +3168,7 @@ int PlayerFunctions::luaPlayerGetFightMode(lua_State* L) { int PlayerFunctions::luaPlayerGetBaseXpGain(lua_State* L) { // player:getBaseXpGain() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getBaseXpGain()); } else { @@ -3184,7 +3179,7 @@ int PlayerFunctions::luaPlayerGetBaseXpGain(lua_State* L) { int PlayerFunctions::luaPlayerSetBaseXpGain(lua_State* L) { // player:setBaseXpGain(value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setBaseXpGain(getNumber<uint16_t>(L, 2)); player->sendStats(); @@ -3197,7 +3192,7 @@ int PlayerFunctions::luaPlayerSetBaseXpGain(lua_State* L) { int PlayerFunctions::luaPlayerGetVoucherXpBoost(lua_State* L) { // player:getVoucherXpBoost() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getVoucherXpBoost()); } else { @@ -3208,7 +3203,7 @@ int PlayerFunctions::luaPlayerGetVoucherXpBoost(lua_State* L) { int PlayerFunctions::luaPlayerSetVoucherXpBoost(lua_State* L) { // player:setVoucherXpBoost(value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setVoucherXpBoost(getNumber<uint16_t>(L, 2)); player->sendStats(); @@ -3221,7 +3216,7 @@ int PlayerFunctions::luaPlayerSetVoucherXpBoost(lua_State* L) { int PlayerFunctions::luaPlayerGetGrindingXpBoost(lua_State* L) { // player:getGrindingXpBoost() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getGrindingXpBoost()); } else { @@ -3232,7 +3227,7 @@ int PlayerFunctions::luaPlayerGetGrindingXpBoost(lua_State* L) { int PlayerFunctions::luaPlayerSetGrindingXpBoost(lua_State* L) { // player:setGrindingXpBoost(value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setGrindingXpBoost(getNumber<uint16_t>(L, 2)); player->sendStats(); @@ -3245,7 +3240,7 @@ int PlayerFunctions::luaPlayerSetGrindingXpBoost(lua_State* L) { int PlayerFunctions::luaPlayerGetXpBoostPercent(lua_State* L) { // player:getXpBoostPercent() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getXpBoostPercent()); } else { @@ -3256,9 +3251,9 @@ int PlayerFunctions::luaPlayerGetXpBoostPercent(lua_State* L) { int PlayerFunctions::luaPlayerSetXpBoostPercent(lua_State* L) { // player:setXpBoostPercent(value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t percent = getNumber<uint16_t>(L, 2); + const uint16_t percent = getNumber<uint16_t>(L, 2); player->setXpBoostPercent(percent); pushBoolean(L, true); } else { @@ -3269,7 +3264,7 @@ int PlayerFunctions::luaPlayerSetXpBoostPercent(lua_State* L) { int PlayerFunctions::luaPlayerGetStaminaXpBoost(lua_State* L) { // player:getStaminaXpBoost() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getStaminaXpBoost()); } else { @@ -3280,7 +3275,7 @@ int PlayerFunctions::luaPlayerGetStaminaXpBoost(lua_State* L) { int PlayerFunctions::luaPlayerSetStaminaXpBoost(lua_State* L) { // player:setStaminaXpBoost(value) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { player->setStaminaXpBoost(getNumber<uint16_t>(L, 2)); player->sendStats(); @@ -3293,9 +3288,9 @@ int PlayerFunctions::luaPlayerSetStaminaXpBoost(lua_State* L) { int PlayerFunctions::luaPlayerSetXpBoostTime(lua_State* L) { // player:setXpBoostTime(timeLeft) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { - uint16_t timeLeft = getNumber<uint16_t>(L, 2); + const uint16_t timeLeft = getNumber<uint16_t>(L, 2); player->setXpBoostTime(timeLeft); player->sendStats(); pushBoolean(L, true); @@ -3307,7 +3302,7 @@ int PlayerFunctions::luaPlayerSetXpBoostTime(lua_State* L) { int PlayerFunctions::luaPlayerGetXpBoostTime(lua_State* L) { // player:getXpBoostTime() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getXpBoostTime()); } else { @@ -3318,7 +3313,7 @@ int PlayerFunctions::luaPlayerGetXpBoostTime(lua_State* L) { int PlayerFunctions::luaPlayerGetIdleTime(lua_State* L) { // player:getIdleTime() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { lua_pushnumber(L, player->getIdleTime()); } else { @@ -3329,7 +3324,7 @@ int PlayerFunctions::luaPlayerGetIdleTime(lua_State* L) { int PlayerFunctions::luaPlayerGetFreeBackpackSlots(lua_State* L) { // player:getFreeBackpackSlots() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); } @@ -3339,7 +3334,7 @@ int PlayerFunctions::luaPlayerGetFreeBackpackSlots(lua_State* L) { } int PlayerFunctions::luaPlayerIsOffline(lua_State* L) { - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player) { pushBoolean(L, player->isOffline()); } else { @@ -3351,7 +3346,7 @@ int PlayerFunctions::luaPlayerIsOffline(lua_State* L) { int PlayerFunctions::luaPlayerOpenMarket(lua_State* L) { // player:openMarket() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3365,7 +3360,7 @@ int PlayerFunctions::luaPlayerOpenMarket(lua_State* L) { // Forge int PlayerFunctions::luaPlayerOpenForge(lua_State* L) { // player:openForge() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3379,7 +3374,7 @@ int PlayerFunctions::luaPlayerOpenForge(lua_State* L) { int PlayerFunctions::luaPlayerCloseForge(lua_State* L) { // player:closeForge() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3393,7 +3388,7 @@ int PlayerFunctions::luaPlayerCloseForge(lua_State* L) { int PlayerFunctions::luaPlayerAddForgeDusts(lua_State* L) { // player:addForgeDusts(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3407,7 +3402,7 @@ int PlayerFunctions::luaPlayerAddForgeDusts(lua_State* L) { int PlayerFunctions::luaPlayerRemoveForgeDusts(lua_State* L) { // player:removeForgeDusts(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3421,7 +3416,7 @@ int PlayerFunctions::luaPlayerRemoveForgeDusts(lua_State* L) { int PlayerFunctions::luaPlayerGetForgeDusts(lua_State* L) { // player:getForgeDusts() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3434,7 +3429,7 @@ int PlayerFunctions::luaPlayerGetForgeDusts(lua_State* L) { int PlayerFunctions::luaPlayerSetForgeDusts(lua_State* L) { // player:setForgeDusts() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3448,7 +3443,7 @@ int PlayerFunctions::luaPlayerSetForgeDusts(lua_State* L) { int PlayerFunctions::luaPlayerAddForgeDustLevel(lua_State* L) { // player:addForgeDustLevel(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3462,7 +3457,7 @@ int PlayerFunctions::luaPlayerAddForgeDustLevel(lua_State* L) { int PlayerFunctions::luaPlayerRemoveForgeDustLevel(lua_State* L) { // player:removeForgeDustLevel(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3476,7 +3471,7 @@ int PlayerFunctions::luaPlayerRemoveForgeDustLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetForgeDustLevel(lua_State* L) { // player:getForgeDustLevel() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3489,7 +3484,7 @@ int PlayerFunctions::luaPlayerGetForgeDustLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetForgeSlivers(lua_State* L) { // player:getForgeSlivers() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3503,7 +3498,7 @@ int PlayerFunctions::luaPlayerGetForgeSlivers(lua_State* L) { int PlayerFunctions::luaPlayerGetForgeCores(lua_State* L) { // player:getForgeCores() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3517,14 +3512,14 @@ int PlayerFunctions::luaPlayerGetForgeCores(lua_State* L) { int PlayerFunctions::luaPlayerSetFaction(lua_State* L) { // player:setFaction(factionId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player == nullptr) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - Faction_t factionId = getNumber<Faction_t>(L, 2); + const Faction_t factionId = getNumber<Faction_t>(L, 2); player->setFaction(factionId); pushBoolean(L, true); return 1; @@ -3532,7 +3527,7 @@ int PlayerFunctions::luaPlayerSetFaction(lua_State* L) { int PlayerFunctions::luaPlayerGetFaction(lua_State* L) { // player:getFaction() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (player == nullptr) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3545,21 +3540,21 @@ int PlayerFunctions::luaPlayerGetFaction(lua_State* L) { int PlayerFunctions::luaPlayerIsUIExhausted(lua_State* L) { // player:isUIExhausted() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - uint16_t time = getNumber<uint16_t>(L, 2); + const uint16_t time = getNumber<uint16_t>(L, 2); pushBoolean(L, player->isUIExhausted(time)); return 1; } int PlayerFunctions::luaPlayerUpdateUIExhausted(lua_State* L) { // player:updateUIExhausted(exhaustionTime = 250) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3574,7 +3569,7 @@ int PlayerFunctions::luaPlayerUpdateUIExhausted(lua_State* L) { // Bosstiary Cooldown Timer int PlayerFunctions::luaPlayerBosstiaryCooldownTimer(lua_State* L) { // player:sendBosstiaryCooldownTimer() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3588,16 +3583,16 @@ int PlayerFunctions::luaPlayerBosstiaryCooldownTimer(lua_State* L) { int PlayerFunctions::luaPlayerGetBosstiaryLevel(lua_State* L) { // player:getBosstiaryLevel(name) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + if (const auto &player = getUserdataShared<Player>(L, 1); player) { - const auto mtype = g_monsters().getMonsterType(getString(L, 2)); + const auto &mtype = g_monsters().getMonsterType(getString(L, 2)); if (mtype) { - uint32_t bossId = mtype->info.raceid; + const uint32_t bossId = mtype->info.raceid; if (bossId == 0) { lua_pushnil(L); return 0; } - auto level = g_ioBosstiary().getBossCurrentLevel(player, bossId); + const auto level = g_ioBosstiary().getBossCurrentLevel(player, bossId); lua_pushnumber(L, level); } else { lua_pushnil(L); @@ -3610,16 +3605,16 @@ int PlayerFunctions::luaPlayerGetBosstiaryLevel(lua_State* L) { int PlayerFunctions::luaPlayerGetBosstiaryKills(lua_State* L) { // player:getBosstiaryKills(name) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + if (const auto &player = getUserdataShared<Player>(L, 1); player) { - const auto mtype = g_monsters().getMonsterType(getString(L, 2)); + const auto &mtype = g_monsters().getMonsterType(getString(L, 2)); if (mtype) { - uint32_t bossId = mtype->info.raceid; + const uint32_t bossId = mtype->info.raceid; if (bossId == 0) { lua_pushnil(L); return 0; } - uint32_t currentKills = player->getBestiaryKillCount(static_cast<uint16_t>(bossId)); + const uint32_t currentKills = player->getBestiaryKillCount(static_cast<uint16_t>(bossId)); lua_pushnumber(L, currentKills); } else { lua_pushnil(L); @@ -3632,9 +3627,9 @@ int PlayerFunctions::luaPlayerGetBosstiaryKills(lua_State* L) { int PlayerFunctions::luaPlayerAddBosstiaryKill(lua_State* L) { // player:addBosstiaryKill(name[, amount = 1]) - if (std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + if (const auto &player = getUserdataShared<Player>(L, 1); player) { - const auto mtype = g_monsters().getMonsterType(getString(L, 2)); + const auto &mtype = g_monsters().getMonsterType(getString(L, 2)); if (mtype) { g_ioBosstiary().addBosstiaryKill(player, mtype, getNumber<uint32_t>(L, 3, 1)); pushBoolean(L, true); @@ -3649,7 +3644,7 @@ int PlayerFunctions::luaPlayerAddBosstiaryKill(lua_State* L) { int PlayerFunctions::luaPlayerSetBossPoints(lua_State* L) { // player:setBossPoints() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3663,7 +3658,7 @@ int PlayerFunctions::luaPlayerSetBossPoints(lua_State* L) { int PlayerFunctions::luaPlayerSetRemoveBossTime(lua_State* L) { // player:setRemoveBossTime() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3677,36 +3672,36 @@ int PlayerFunctions::luaPlayerSetRemoveBossTime(lua_State* L) { int PlayerFunctions::luaPlayerGetSlotBossId(lua_State* L) { // player:getSlotBossId(slotId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - uint8_t slotId = getNumber<uint8_t>(L, 2); - auto bossId = player->getSlotBossId(slotId); + const uint8_t slotId = getNumber<uint8_t>(L, 2); + const auto bossId = player->getSlotBossId(slotId); lua_pushnumber(L, static_cast<lua_Number>(bossId)); return 1; } int PlayerFunctions::luaPlayerGetBossBonus(lua_State* L) { // player:getBossBonus(slotId) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - uint8_t slotId = getNumber<uint8_t>(L, 2); - auto bossId = player->getSlotBossId(slotId); + const uint8_t slotId = getNumber<uint8_t>(L, 2); + const auto bossId = player->getSlotBossId(slotId); - uint32_t playerBossPoints = player->getBossPoints(); - uint16_t currentBonus = g_ioBosstiary().calculateLootBonus(playerBossPoints); + const uint32_t playerBossPoints = player->getBossPoints(); + const uint16_t currentBonus = g_ioBosstiary().calculateLootBonus(playerBossPoints); - auto bossLevel = g_ioBosstiary().getBossCurrentLevel(player, bossId); - uint16_t bonusBoss = currentBonus + (bossLevel == 3 ? 25 : 0); + const auto bossLevel = g_ioBosstiary().getBossCurrentLevel(player, bossId); + const uint16_t bonusBoss = currentBonus + (bossLevel == 3 ? 25 : 0); lua_pushnumber(L, static_cast<lua_Number>(bonusBoss)); return 1; @@ -3714,15 +3709,15 @@ int PlayerFunctions::luaPlayerGetBossBonus(lua_State* L) { int PlayerFunctions::luaPlayerSendSingleSoundEffect(lua_State* L) { // player:sendSingleSoundEffect(soundId[, actor = true]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - SoundEffect_t soundEffect = getNumber<SoundEffect_t>(L, 2); - bool actor = getBoolean(L, 3, true); + const SoundEffect_t soundEffect = getNumber<SoundEffect_t>(L, 2); + const bool actor = getBoolean(L, 3, true); player->sendSingleSoundEffect(player->getPosition(), soundEffect, actor ? SourceEffect_t::OWN : SourceEffect_t::GLOBAL); pushBoolean(L, true); @@ -3731,16 +3726,16 @@ int PlayerFunctions::luaPlayerSendSingleSoundEffect(lua_State* L) { int PlayerFunctions::luaPlayerSendDoubleSoundEffect(lua_State* L) { // player:sendDoubleSoundEffect(mainSoundId, secondarySoundId[, actor = true]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - SoundEffect_t mainSoundEffect = getNumber<SoundEffect_t>(L, 2); - SoundEffect_t secondarySoundEffect = getNumber<SoundEffect_t>(L, 3); - bool actor = getBoolean(L, 4, true); + const SoundEffect_t mainSoundEffect = getNumber<SoundEffect_t>(L, 2); + const SoundEffect_t secondarySoundEffect = getNumber<SoundEffect_t>(L, 3); + const bool actor = getBoolean(L, 4, true); player->sendDoubleSoundEffect(player->getPosition(), mainSoundEffect, actor ? SourceEffect_t::OWN : SourceEffect_t::GLOBAL, secondarySoundEffect, actor ? SourceEffect_t::OWN : SourceEffect_t::GLOBAL); pushBoolean(L, true); @@ -3749,7 +3744,7 @@ int PlayerFunctions::luaPlayerSendDoubleSoundEffect(lua_State* L) { int PlayerFunctions::luaPlayerGetName(lua_State* L) { // player:getName() - const auto player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3762,7 +3757,7 @@ int PlayerFunctions::luaPlayerGetName(lua_State* L) { int PlayerFunctions::luaPlayerChangeName(lua_State* L) { // player:changeName(newName) - const auto player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3772,7 +3767,7 @@ int PlayerFunctions::luaPlayerChangeName(lua_State* L) { player->removePlayer(true, true); } player->kv()->remove("namelock"); - auto newName = getString(L, 2); + const auto newName = getString(L, 2); player->setName(newName); g_saveManager().savePlayer(player); return 1; @@ -3780,7 +3775,7 @@ int PlayerFunctions::luaPlayerChangeName(lua_State* L) { int PlayerFunctions::luaPlayerHasGroupFlag(lua_State* L) { // player:hasGroupFlag(flag) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3793,7 +3788,7 @@ int PlayerFunctions::luaPlayerHasGroupFlag(lua_State* L) { int PlayerFunctions::luaPlayerSetGroupFlag(lua_State* L) { // player:setGroupFlag(flag) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3806,7 +3801,7 @@ int PlayerFunctions::luaPlayerSetGroupFlag(lua_State* L) { int PlayerFunctions::luaPlayerRemoveGroupFlag(lua_State* L) { // player:removeGroupFlag(flag) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -3820,7 +3815,7 @@ int PlayerFunctions::luaPlayerRemoveGroupFlag(lua_State* L) { // Hazard system int PlayerFunctions::luaPlayerAddHazardSystemPoints(lua_State* L) { // player:setHazardSystemPoints(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); @@ -3834,7 +3829,7 @@ int PlayerFunctions::luaPlayerAddHazardSystemPoints(lua_State* L) { int PlayerFunctions::luaPlayerGetHazardSystemPoints(lua_State* L) { // player:getHazardSystemPoints() - const auto player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { pushBoolean(L, false); reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); @@ -3847,7 +3842,7 @@ int PlayerFunctions::luaPlayerGetHazardSystemPoints(lua_State* L) { int PlayerFunctions::luaPlayerSetLoyaltyBonus(lua_State* L) { // player:setLoyaltyBonus(amount) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3860,7 +3855,7 @@ int PlayerFunctions::luaPlayerSetLoyaltyBonus(lua_State* L) { int PlayerFunctions::luaPlayerGetLoyaltyBonus(lua_State* L) { // player:getLoyaltyBonus() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3872,7 +3867,7 @@ int PlayerFunctions::luaPlayerGetLoyaltyBonus(lua_State* L) { int PlayerFunctions::luaPlayerGetLoyaltyPoints(lua_State* L) { // player:getLoyaltyPoints() - const auto player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3884,7 +3879,7 @@ int PlayerFunctions::luaPlayerGetLoyaltyPoints(lua_State* L) { int PlayerFunctions::luaPlayerGetLoyaltyTitle(lua_State* L) { // player:getLoyaltyTitle() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3896,7 +3891,7 @@ int PlayerFunctions::luaPlayerGetLoyaltyTitle(lua_State* L) { int PlayerFunctions::luaPlayerSetLoyaltyTitle(lua_State* L) { // player:setLoyaltyTitle(name) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3910,13 +3905,13 @@ int PlayerFunctions::luaPlayerSetLoyaltyTitle(lua_State* L) { // Wheel of destiny system int PlayerFunctions::luaPlayerInstantSkillWOD(lua_State* L) { // player:instantSkillWOD(name[, value]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } - std::string name = getString(L, 2); + const std::string name = getString(L, 2); if (lua_gettop(L) == 2) { pushBoolean(L, player->wheel()->getInstant(name)); } else { @@ -3928,7 +3923,7 @@ int PlayerFunctions::luaPlayerInstantSkillWOD(lua_State* L) { int PlayerFunctions::luaPlayerUpgradeSpellWOD(lua_State* L) { // player:upgradeSpellsWOD([name[, add]]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3939,13 +3934,13 @@ int PlayerFunctions::luaPlayerUpgradeSpellWOD(lua_State* L) { return 1; } - std::string name = getString(L, 2); + const std::string name = getString(L, 2); if (lua_gettop(L) == 2) { lua_pushnumber(L, static_cast<lua_Number>(player->wheel()->getSpellUpgrade(name))); return 1; } - bool add = getBoolean(L, 3); + const bool add = getBoolean(L, 3); if (add) { player->wheel()->upgradeSpell(name); } else { @@ -3958,7 +3953,7 @@ int PlayerFunctions::luaPlayerUpgradeSpellWOD(lua_State* L) { int PlayerFunctions::luaPlayerRevelationStageWOD(lua_State* L) { // player:revelationStageWOD([name[, set]]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -3969,13 +3964,13 @@ int PlayerFunctions::luaPlayerRevelationStageWOD(lua_State* L) { return 1; } - std::string name = getString(L, 2); + const std::string name = getString(L, 2); if (lua_gettop(L) == 2) { lua_pushnumber(L, static_cast<lua_Number>(player->wheel()->getStage(name))); return 1; } - bool value = getNumber<uint8_t>(L, 3); + const bool value = getNumber<uint8_t>(L, 3); player->wheel()->setSpellInstant(name, value); pushBoolean(L, true); @@ -3984,7 +3979,7 @@ int PlayerFunctions::luaPlayerRevelationStageWOD(lua_State* L) { int PlayerFunctions::luaPlayerReloadData(lua_State* L) { // player:reloadData() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -4001,7 +3996,7 @@ int PlayerFunctions::luaPlayerReloadData(lua_State* L) { int PlayerFunctions::luaPlayerOnThinkWheelOfDestiny(lua_State* L) { // player:onThinkWheelOfDestiny([force = false]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -4014,14 +4009,14 @@ int PlayerFunctions::luaPlayerOnThinkWheelOfDestiny(lua_State* L) { int PlayerFunctions::luaPlayerAvatarTimer(lua_State* L) { // player:avatarTimer([value]) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; } if (lua_gettop(L) == 1) { - lua_pushnumber(L, (lua_Number)player->wheel()->getOnThinkTimer(WheelOnThink_t::AVATAR_SPELL)); + lua_pushnumber(L, static_cast<lua_Number>(player->wheel()->getOnThinkTimer(WheelOnThink_t::AVATAR_SPELL))); } else { player->wheel()->setOnThinkTimer(WheelOnThink_t::AVATAR_SPELL, getNumber<int64_t>(L, 2)); pushBoolean(L, true); @@ -4031,21 +4026,21 @@ int PlayerFunctions::luaPlayerAvatarTimer(lua_State* L) { int PlayerFunctions::luaPlayerGetWheelSpellAdditionalArea(lua_State* L) { // player:getWheelSpellAdditionalArea(spellname) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - auto spellName = getString(L, 2); + const auto spellName = getString(L, 2); if (spellName.empty()) { reportErrorFunc("Spell name is empty"); pushBoolean(L, false); return 0; } - auto spell = g_spells().getInstantSpellByName(spellName); + const auto &spell = g_spells().getInstantSpellByName(spellName); if (!spell) { reportErrorFunc(getErrorDesc(LUA_ERROR_SPELL_NOT_FOUND)); pushBoolean(L, false); @@ -4058,21 +4053,21 @@ int PlayerFunctions::luaPlayerGetWheelSpellAdditionalArea(lua_State* L) { int PlayerFunctions::luaPlayerGetWheelSpellAdditionalTarget(lua_State* L) { // player:getWheelSpellAdditionalTarget(spellname) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - auto spellName = getString(L, 2); + const auto spellName = getString(L, 2); if (spellName.empty()) { reportErrorFunc("Spell name is empty"); pushBoolean(L, false); return 0; } - auto spell = g_spells().getInstantSpellByName(spellName); + const auto &spell = g_spells().getInstantSpellByName(spellName); if (!spell) { reportErrorFunc(getErrorDesc(LUA_ERROR_SPELL_NOT_FOUND)); pushBoolean(L, false); @@ -4085,21 +4080,21 @@ int PlayerFunctions::luaPlayerGetWheelSpellAdditionalTarget(lua_State* L) { int PlayerFunctions::luaPlayerGetWheelSpellAdditionalDuration(lua_State* L) { // player:getWheelSpellAdditionalDuration(spellname) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); return 0; } - auto spellName = getString(L, 2); + const auto spellName = getString(L, 2); if (spellName.empty()) { reportErrorFunc("Spell name is empty"); pushBoolean(L, false); return 0; } - auto spell = g_spells().getInstantSpellByName(spellName); + const auto &spell = g_spells().getInstantSpellByName(spellName); if (!spell) { reportErrorFunc(getErrorDesc(LUA_ERROR_SPELL_NOT_FOUND)); pushBoolean(L, false); @@ -4112,7 +4107,7 @@ int PlayerFunctions::luaPlayerGetWheelSpellAdditionalDuration(lua_State* L) { int PlayerFunctions::luaPlayerUpdateConcoction(lua_State* L) { // player:updateConcoction(itemid, timeLeft) - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -4124,7 +4119,7 @@ int PlayerFunctions::luaPlayerUpdateConcoction(lua_State* L) { int PlayerFunctions::luaPlayerClearSpellCooldowns(lua_State* L) { // player:clearSpellCooldowns() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { lua_pushnil(L); return 1; @@ -4136,7 +4131,7 @@ int PlayerFunctions::luaPlayerClearSpellCooldowns(lua_State* L) { int PlayerFunctions::luaPlayerIsVip(lua_State* L) { // player:isVip() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -4148,7 +4143,7 @@ int PlayerFunctions::luaPlayerIsVip(lua_State* L) { int PlayerFunctions::luaPlayerGetVipDays(lua_State* L) { // player:getVipDays() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -4161,7 +4156,7 @@ int PlayerFunctions::luaPlayerGetVipDays(lua_State* L) { int PlayerFunctions::luaPlayerGetVipTime(lua_State* L) { // player:getVipTime() - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -4174,7 +4169,7 @@ int PlayerFunctions::luaPlayerGetVipTime(lua_State* L) { int PlayerFunctions::luaPlayerKV(lua_State* L) { // player:kv() - auto player = getUserdataShared<Player>(L, 1); + const auto &player = getUserdataShared<Player>(L, 1); if (!player) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); pushBoolean(L, false); @@ -4194,7 +4189,7 @@ int PlayerFunctions::luaPlayerGetStoreInbox(lua_State* L) { return 1; } - if (auto item = player->getStoreInbox()) { + if (const auto &item = player->getStoreInbox()) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); } else { @@ -4237,7 +4232,7 @@ int PlayerFunctions::luaPlayerAddAchievement(lua_State* L) { achievementId = g_game().getAchievementByName(getString(L, 2)).id; } - bool success = player->achiev()->add(achievementId, getBoolean(L, 3, true)); + const bool success = player->achiev()->add(achievementId, getBoolean(L, 3, true)); if (success) { player->sendTakeScreenshot(SCREENSHOT_TYPE_ACHIEVEMENT); } @@ -4285,7 +4280,7 @@ int PlayerFunctions::luaPlayerAddAchievementPoints(lua_State* L) { return 1; } - auto points = getNumber<uint16_t>(L, 2); + const auto points = getNumber<uint16_t>(L, 2); if (points > 0) { player->achiev()->addPoints(points); } @@ -4301,7 +4296,7 @@ int PlayerFunctions::luaPlayerRemoveAchievementPoints(lua_State* L) { return 1; } - auto points = getNumber<uint16_t>(L, 2); + const auto points = getNumber<uint16_t>(L, 2); if (points > 0) { player->achiev()->removePoints(points); } @@ -4343,7 +4338,7 @@ int PlayerFunctions::luaPlayerGetTitles(lua_State* L) { return 1; } - auto playerTitles = player->title()->getUnlockedTitles(); + const auto playerTitles = player->title()->getUnlockedTitles(); lua_createtable(L, static_cast<int>(playerTitles.size()), 0); int index = 0; @@ -4384,14 +4379,14 @@ int PlayerFunctions::luaPlayerCreateTransactionSummary(lua_State* L) { return 1; } - auto type = getNumber<uint8_t>(L, 2, 0); + const auto type = getNumber<uint8_t>(L, 2, 0); if (type == 0) { reportErrorFunc(getErrorDesc(LUA_ERROR_VARIANT_NOT_FOUND)); return 1; } - auto amount = getNumber<uint16_t>(L, 3, 1); - auto id = getString(L, 4, ""); + const auto amount = getNumber<uint16_t>(L, 3, 1); + const auto id = getString(L, 4, ""); player->cyclopedia()->updateStoreSummary(type, amount, id); pushBoolean(L, true); @@ -4406,7 +4401,7 @@ int PlayerFunctions::luaPlayerTakeScreenshot(lua_State* L) { return 1; } - auto screenshotType = getNumber<Screenshot_t>(L, 2); + const auto screenshotType = getNumber<Screenshot_t>(L, 2); player->sendTakeScreenshot(screenshotType); pushBoolean(L, true); return 1; @@ -4420,7 +4415,7 @@ int PlayerFunctions::luaPlayerSendIconBakragore(lua_State* L) { return 1; } - auto iconType = getNumber<IconBakragore>(L, 2); + const auto iconType = getNumber<IconBakragore>(L, 2); player->sendIconBakragore(iconType); pushBoolean(L, true); return 1; @@ -4434,7 +4429,7 @@ int PlayerFunctions::luaPlayerRemoveIconBakragore(lua_State* L) { return 1; } - auto iconType = getNumber<IconBakragore>(L, 2, IconBakragore::None); + const auto iconType = getNumber<IconBakragore>(L, 2, IconBakragore::None); if (iconType == IconBakragore::None) { player->removeBakragoreIcons(); } else { diff --git a/src/lua/functions/creatures/player/player_functions.hpp b/src/lua/functions/creatures/player/player_functions.hpp index aa4db5857f7..cfcc685a809 100644 --- a/src/lua/functions/creatures/player/player_functions.hpp +++ b/src/lua/functions/creatures/player/player_functions.hpp @@ -17,7 +17,12 @@ #include "lua/functions/creatures/player/vocation_functions.hpp" class PlayerFunctions final : LuaScriptInterface { -private: + explicit PlayerFunctions(lua_State* L) : + LuaScriptInterface("PlayerFunctions") { + init(L); + } + ~PlayerFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Player", "Creature", PlayerFunctions::luaPlayerCreate); registerMetaMethod(L, "Player", "__eq", PlayerFunctions::luaUserdataCompare); diff --git a/src/lua/functions/creatures/player/vocation_functions.cpp b/src/lua/functions/creatures/player/vocation_functions.cpp index 15e1603cc54..de35c58a198 100644 --- a/src/lua/functions/creatures/player/vocation_functions.cpp +++ b/src/lua/functions/creatures/player/vocation_functions.cpp @@ -19,7 +19,7 @@ int VocationFunctions::luaVocationCreate(lua_State* L) { vocationId = g_vocations().getVocationId(getString(L, 2)); } - std::shared_ptr<Vocation> vocation = g_vocations().getVocation(vocationId); + const auto &vocation = g_vocations().getVocation(vocationId); if (vocation) { pushUserdata<Vocation>(L, vocation); setMetatable(L, -1, "Vocation"); @@ -31,7 +31,7 @@ int VocationFunctions::luaVocationCreate(lua_State* L) { int VocationFunctions::luaVocationGetId(lua_State* L) { // vocation:getId() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getId()); } else { @@ -42,7 +42,7 @@ int VocationFunctions::luaVocationGetId(lua_State* L) { int VocationFunctions::luaVocationGetClientId(lua_State* L) { // vocation:getClientId() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getClientId()); } else { @@ -53,7 +53,7 @@ int VocationFunctions::luaVocationGetClientId(lua_State* L) { int VocationFunctions::luaVocationGetBaseId(lua_State* L) { // vocation:getBaseId() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getBaseId()); } else { @@ -64,7 +64,7 @@ int VocationFunctions::luaVocationGetBaseId(lua_State* L) { int VocationFunctions::luaVocationGetName(lua_State* L) { // vocation:getName() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { pushString(L, vocation->getVocName()); } else { @@ -75,7 +75,7 @@ int VocationFunctions::luaVocationGetName(lua_State* L) { int VocationFunctions::luaVocationGetDescription(lua_State* L) { // vocation:getDescription() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { pushString(L, vocation->getVocDescription()); } else { @@ -86,10 +86,10 @@ int VocationFunctions::luaVocationGetDescription(lua_State* L) { int VocationFunctions::luaVocationGetRequiredSkillTries(lua_State* L) { // vocation:getRequiredSkillTries(skillType, skillLevel) - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { - skills_t skillType = getNumber<skills_t>(L, 2); - uint16_t skillLevel = getNumber<uint16_t>(L, 3); + const skills_t skillType = getNumber<skills_t>(L, 2); + const uint16_t skillLevel = getNumber<uint16_t>(L, 3); lua_pushnumber(L, vocation->getReqSkillTries(skillType, skillLevel)); } else { lua_pushnil(L); @@ -99,9 +99,9 @@ int VocationFunctions::luaVocationGetRequiredSkillTries(lua_State* L) { int VocationFunctions::luaVocationGetRequiredManaSpent(lua_State* L) { // vocation:getRequiredManaSpent(magicLevel) - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { - uint32_t magicLevel = getNumber<uint32_t>(L, 2); + const uint32_t magicLevel = getNumber<uint32_t>(L, 2); lua_pushnumber(L, vocation->getReqMana(magicLevel)); } else { lua_pushnil(L); @@ -111,7 +111,7 @@ int VocationFunctions::luaVocationGetRequiredManaSpent(lua_State* L) { int VocationFunctions::luaVocationGetCapacityGain(lua_State* L) { // vocation:getCapacityGain() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getCapGain()); } else { @@ -122,7 +122,7 @@ int VocationFunctions::luaVocationGetCapacityGain(lua_State* L) { int VocationFunctions::luaVocationGetHealthGain(lua_State* L) { // vocation:getHealthGain() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getHPGain()); } else { @@ -133,7 +133,7 @@ int VocationFunctions::luaVocationGetHealthGain(lua_State* L) { int VocationFunctions::luaVocationGetHealthGainTicks(lua_State* L) { // vocation:getHealthGainTicks() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getHealthGainTicks()); } else { @@ -144,7 +144,7 @@ int VocationFunctions::luaVocationGetHealthGainTicks(lua_State* L) { int VocationFunctions::luaVocationGetHealthGainAmount(lua_State* L) { // vocation:getHealthGainAmount() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getHealthGainAmount()); } else { @@ -155,7 +155,7 @@ int VocationFunctions::luaVocationGetHealthGainAmount(lua_State* L) { int VocationFunctions::luaVocationGetManaGain(lua_State* L) { // vocation:getManaGain() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getManaGain()); } else { @@ -166,7 +166,7 @@ int VocationFunctions::luaVocationGetManaGain(lua_State* L) { int VocationFunctions::luaVocationGetManaGainTicks(lua_State* L) { // vocation:getManaGainTicks() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getManaGainTicks()); } else { @@ -177,7 +177,7 @@ int VocationFunctions::luaVocationGetManaGainTicks(lua_State* L) { int VocationFunctions::luaVocationGetManaGainAmount(lua_State* L) { // vocation:getManaGainAmount() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getManaGainAmount()); } else { @@ -188,7 +188,7 @@ int VocationFunctions::luaVocationGetManaGainAmount(lua_State* L) { int VocationFunctions::luaVocationGetMaxSoul(lua_State* L) { // vocation:getMaxSoul() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getSoulMax()); } else { @@ -199,7 +199,7 @@ int VocationFunctions::luaVocationGetMaxSoul(lua_State* L) { int VocationFunctions::luaVocationGetSoulGainTicks(lua_State* L) { // vocation:getSoulGainTicks() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getSoulGainTicks()); } else { @@ -210,7 +210,7 @@ int VocationFunctions::luaVocationGetSoulGainTicks(lua_State* L) { int VocationFunctions::luaVocationGetBaseAttackSpeed(lua_State* L) { // vocation:getBaseAttackSpeed() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getBaseAttackSpeed()); } else { @@ -221,7 +221,7 @@ int VocationFunctions::luaVocationGetBaseAttackSpeed(lua_State* L) { int VocationFunctions::luaVocationGetAttackSpeed(lua_State* L) { // vocation:getAttackSpeed() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getAttackSpeed()); } else { @@ -232,7 +232,7 @@ int VocationFunctions::luaVocationGetAttackSpeed(lua_State* L) { int VocationFunctions::luaVocationGetBaseSpeed(lua_State* L) { // vocation:getBaseSpeed() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (vocation) { lua_pushnumber(L, vocation->getBaseSpeed()); } else { @@ -243,19 +243,19 @@ int VocationFunctions::luaVocationGetBaseSpeed(lua_State* L) { int VocationFunctions::luaVocationGetDemotion(lua_State* L) { // vocation:getDemotion() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (!vocation) { lua_pushnil(L); return 1; } - uint16_t fromId = vocation->getFromVocation(); + const uint16_t fromId = vocation->getFromVocation(); if (fromId == VOCATION_NONE) { lua_pushnil(L); return 1; } - std::shared_ptr<Vocation> demotedVocation = g_vocations().getVocation(fromId); + const auto &demotedVocation = g_vocations().getVocation(fromId); if (demotedVocation && demotedVocation != vocation) { pushUserdata<Vocation>(L, demotedVocation); setMetatable(L, -1, "Vocation"); @@ -267,19 +267,19 @@ int VocationFunctions::luaVocationGetDemotion(lua_State* L) { int VocationFunctions::luaVocationGetPromotion(lua_State* L) { // vocation:getPromotion() - std::shared_ptr<Vocation> vocation = getUserdataShared<Vocation>(L, 1); + const auto &vocation = getUserdataShared<Vocation>(L, 1); if (!vocation) { lua_pushnil(L); return 1; } - uint16_t promotedId = g_vocations().getPromotedVocation(vocation->getId()); + const uint16_t promotedId = g_vocations().getPromotedVocation(vocation->getId()); if (promotedId == VOCATION_NONE) { lua_pushnil(L); return 1; } - std::shared_ptr<Vocation> promotedVocation = g_vocations().getVocation(promotedId); + const auto &promotedVocation = g_vocations().getVocation(promotedId); if (promotedVocation && promotedVocation != vocation) { pushUserdata<Vocation>(L, promotedVocation); setMetatable(L, -1, "Vocation"); diff --git a/src/lua/functions/creatures/player/vocation_functions.hpp b/src/lua/functions/creatures/player/vocation_functions.hpp index 0895f6ac8d6..7d98131ecb3 100644 --- a/src/lua/functions/creatures/player/vocation_functions.hpp +++ b/src/lua/functions/creatures/player/vocation_functions.hpp @@ -13,6 +13,12 @@ class VocationFunctions final : LuaScriptInterface { public: + explicit VocationFunctions(lua_State* L) : + LuaScriptInterface("VocationFunctions") { + init(L); + } + ~VocationFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Vocation", "", VocationFunctions::luaVocationCreate); registerMetaMethod(L, "Vocation", "__eq", VocationFunctions::luaUserdataCompare); diff --git a/src/lua/functions/events/action_functions.cpp b/src/lua/functions/events/action_functions.cpp index c5cf4c73c29..67ef0af5031 100644 --- a/src/lua/functions/events/action_functions.cpp +++ b/src/lua/functions/events/action_functions.cpp @@ -14,7 +14,7 @@ int ActionFunctions::luaCreateAction(lua_State* L) { // Action() - auto action = std::make_shared<Action>(getScriptEnv()->getScriptInterface()); + const auto action = std::make_shared<Action>(getScriptEnv()->getScriptInterface()); pushUserdata<Action>(L, action); setMetatable(L, -1, "Action"); return 1; @@ -22,7 +22,7 @@ int ActionFunctions::luaCreateAction(lua_State* L) { int ActionFunctions::luaActionOnUse(lua_State* L) { // action:onUse(callback) - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { if (!action->loadCallback()) { pushBoolean(L, false); @@ -39,7 +39,7 @@ int ActionFunctions::luaActionOnUse(lua_State* L) { int ActionFunctions::luaActionRegister(lua_State* L) { // action:register() - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { if (!action->isLoadedCallback()) { pushBoolean(L, false); @@ -56,9 +56,9 @@ int ActionFunctions::luaActionRegister(lua_State* L) { int ActionFunctions::luaActionItemId(lua_State* L) { // action:id(ids) - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc if (parameters > 1) { for (int i = 0; i < parameters; ++i) { action->setItemIdsVector(getNumber<uint16_t>(L, 2 + i)); @@ -76,9 +76,9 @@ int ActionFunctions::luaActionItemId(lua_State* L) { int ActionFunctions::luaActionActionId(lua_State* L) { // action:aid(aids) - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc if (parameters > 1) { for (int i = 0; i < parameters; ++i) { action->setActionIdsVector(getNumber<uint16_t>(L, 2 + i)); @@ -96,9 +96,9 @@ int ActionFunctions::luaActionActionId(lua_State* L) { int ActionFunctions::luaActionUniqueId(lua_State* L) { // action:uid(uids) - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc if (parameters > 1) { for (int i = 0; i < parameters; ++i) { action->setUniqueIdsVector(getNumber<uint16_t>(L, 2 + i)); @@ -120,17 +120,17 @@ int ActionFunctions::luaActionPosition(lua_State* L) { * @param itemId or @param itemName = if item id or string name is set, the item is created on position (if not exists), this variable is nil by default * action:position(positions, itemId or name) */ - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (!action) { reportErrorFunc(getErrorDesc(LUA_ERROR_ACTION_NOT_FOUND)); pushBoolean(L, false); return 1; } - Position position = getPosition(L, 2); + const Position position = getPosition(L, 2); // The parameter "- 1" because self is a parameter aswell, which we want to skip L 1 (UserData) // isNumber(L, 2) is for skip the itemId - if (int parameters = lua_gettop(L) - 1; + if (const int parameters = lua_gettop(L) - 1; parameters > 1 && isNumber(L, 2)) { for (int i = 0; i < parameters; ++i) { action->setPositionsVector(getPosition(L, 2 + i)); @@ -177,7 +177,7 @@ int ActionFunctions::luaActionPosition(lua_State* L) { int ActionFunctions::luaActionAllowFarUse(lua_State* L) { // action:allowFarUse(bool) - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { action->setAllowFarUse(getBoolean(L, 2)); pushBoolean(L, true); @@ -190,7 +190,7 @@ int ActionFunctions::luaActionAllowFarUse(lua_State* L) { int ActionFunctions::luaActionBlockWalls(lua_State* L) { // action:blockWalls(bool) - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { action->setCheckLineOfSight(getBoolean(L, 2)); pushBoolean(L, true); @@ -203,7 +203,7 @@ int ActionFunctions::luaActionBlockWalls(lua_State* L) { int ActionFunctions::luaActionCheckFloor(lua_State* L) { // action:checkFloor(bool) - const auto action = getUserdataShared<Action>(L, 1); + const auto &action = getUserdataShared<Action>(L, 1); if (action) { action->setCheckFloor(getBoolean(L, 2)); pushBoolean(L, true); diff --git a/src/lua/functions/events/action_functions.hpp b/src/lua/functions/events/action_functions.hpp index 952ee746a5a..0816ca9d334 100644 --- a/src/lua/functions/events/action_functions.hpp +++ b/src/lua/functions/events/action_functions.hpp @@ -13,6 +13,12 @@ class ActionFunctions final : LuaScriptInterface { public: + explicit ActionFunctions(lua_State* L) : + LuaScriptInterface("ActionFunctions") { + init(L); + } + ~ActionFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Action", "", ActionFunctions::luaCreateAction); registerMethod(L, "Action", "onUse", ActionFunctions::luaActionOnUse); diff --git a/src/lua/functions/events/creature_event_functions.cpp b/src/lua/functions/events/creature_event_functions.cpp index ddba9f153fd..60ddb08b65a 100644 --- a/src/lua/functions/events/creature_event_functions.cpp +++ b/src/lua/functions/events/creature_event_functions.cpp @@ -13,7 +13,7 @@ int CreatureEventFunctions::luaCreateCreatureEvent(lua_State* L) { // CreatureEvent(eventName) - auto creatureEvent = std::make_shared<CreatureEvent>(getScriptEnv()->getScriptInterface()); + const auto creatureEvent = std::make_shared<CreatureEvent>(getScriptEnv()->getScriptInterface()); creatureEvent->setName(getString(L, 2)); pushUserdata<CreatureEvent>(L, creatureEvent); setMetatable(L, -1, "CreatureEvent"); @@ -22,10 +22,10 @@ int CreatureEventFunctions::luaCreateCreatureEvent(lua_State* L) { int CreatureEventFunctions::luaCreatureEventType(lua_State* L) { // creatureevent:type(callback) - const auto creatureEvent = getUserdataShared<CreatureEvent>(L, 1); + const auto &creatureEvent = getUserdataShared<CreatureEvent>(L, 1); if (creatureEvent) { std::string typeName = getString(L, 2); - std::string tmpStr = asLowerCaseString(typeName); + const std::string tmpStr = asLowerCaseString(typeName); if (tmpStr == "login") { creatureEvent->setEventType(CREATURE_EVENT_LOGIN); } else if (tmpStr == "logout") { @@ -66,7 +66,7 @@ int CreatureEventFunctions::luaCreatureEventType(lua_State* L) { int CreatureEventFunctions::luaCreatureEventRegister(lua_State* L) { // creatureevent:register() - const auto creatureEvent = getUserdataShared<CreatureEvent>(L, 1); + const auto &creatureEvent = getUserdataShared<CreatureEvent>(L, 1); if (creatureEvent) { if (!creatureEvent->isLoadedCallback()) { pushBoolean(L, false); @@ -81,7 +81,7 @@ int CreatureEventFunctions::luaCreatureEventRegister(lua_State* L) { int CreatureEventFunctions::luaCreatureEventOnCallback(lua_State* L) { // creatureevent:onLogin / logout / etc. (callback) - const auto creatureEvent = getUserdataShared<CreatureEvent>(L, 1); + const auto &creatureEvent = getUserdataShared<CreatureEvent>(L, 1); if (creatureEvent) { if (!creatureEvent->loadCallback()) { pushBoolean(L, false); diff --git a/src/lua/functions/events/creature_event_functions.hpp b/src/lua/functions/events/creature_event_functions.hpp index 64b9e6e4eb8..f605d517fbf 100644 --- a/src/lua/functions/events/creature_event_functions.hpp +++ b/src/lua/functions/events/creature_event_functions.hpp @@ -13,6 +13,12 @@ class CreatureEventFunctions final : LuaScriptInterface { public: + explicit CreatureEventFunctions(lua_State* L) : + LuaScriptInterface("CreatureEventFunctions") { + init(L); + } + ~CreatureEventFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "CreatureEvent", "", CreatureEventFunctions::luaCreateCreatureEvent); registerMethod(L, "CreatureEvent", "type", CreatureEventFunctions::luaCreatureEventType); diff --git a/src/lua/functions/events/event_callback_functions.cpp b/src/lua/functions/events/event_callback_functions.cpp index c00300b5f47..db59092f3af 100644 --- a/src/lua/functions/events/event_callback_functions.cpp +++ b/src/lua/functions/events/event_callback_functions.cpp @@ -46,7 +46,7 @@ int EventCallbackFunctions::luaEventCallbackCreate(lua_State* luaState) { } int EventCallbackFunctions::luaEventCallbackType(lua_State* luaState) { - auto callback = getUserdataShared<EventCallback>(luaState, 1); + const auto &callback = getUserdataShared<EventCallback>(luaState, 1); if (!callback) { reportErrorFunc("EventCallback is nil"); return 0; @@ -77,9 +77,8 @@ int EventCallbackFunctions::luaEventCallbackType(lua_State* luaState) { } int EventCallbackFunctions::luaEventCallbackRegister(lua_State* luaState) { - auto callback = getUserdataShared<EventCallback>(luaState, 1); + const auto &callback = getUserdataShared<EventCallback>(luaState, 1); if (!callback) { - reportErrorFunc("EventCallback is nil, failed to register script"); return 0; } @@ -99,7 +98,7 @@ int EventCallbackFunctions::luaEventCallbackRegister(lua_State* luaState) { // Callback functions int EventCallbackFunctions::luaEventCallbackLoad(lua_State* luaState) { - auto callback = getUserdataShared<EventCallback>(luaState, 1); + const auto &callback = getUserdataShared<EventCallback>(luaState, 1); if (!callback) { return 1; } diff --git a/src/lua/functions/events/event_callback_functions.hpp b/src/lua/functions/events/event_callback_functions.hpp index a5fa9e8900c..9623a52169b 100644 --- a/src/lua/functions/events/event_callback_functions.hpp +++ b/src/lua/functions/events/event_callback_functions.hpp @@ -18,8 +18,14 @@ * @details This class encapsulates the Lua binding functions related to event callbacks, * allowing for interaction between the C++ codebase and Lua scripts. */ -class EventCallbackFunctions : public LuaScriptInterface { +class EventCallbackFunctions final : public LuaScriptInterface { public: + explicit EventCallbackFunctions(lua_State* L) : + LuaScriptInterface("EventCallbackFunctions") { + init(L); + } + ~EventCallbackFunctions() override = default; + /** * @brief Initializes the Lua state with the event callback functions. * diff --git a/src/lua/functions/events/events_functions.hpp b/src/lua/functions/events/events_functions.hpp index 6830b7c1a73..4a4e3570a12 100644 --- a/src/lua/functions/events/events_functions.hpp +++ b/src/lua/functions/events/events_functions.hpp @@ -20,6 +20,12 @@ class EventFunctions final : LuaScriptInterface { public: + explicit EventFunctions(lua_State* L) : + LuaScriptInterface("EventFunctions") { + init(L); + } + ~EventFunctions() override = default; + static void init(lua_State* L) { ActionFunctions::init(L); CreatureEventFunctions::init(L); @@ -30,6 +36,4 @@ class EventFunctions final : LuaScriptInterface { EventCallbackFunctions::init(L); /* Move, Creature, Talk, Global events goes all here */ } - -private: }; diff --git a/src/lua/functions/events/events_scheduler_functions.hpp b/src/lua/functions/events/events_scheduler_functions.hpp index bedbf16b4a1..9059bf1fdfb 100644 --- a/src/lua/functions/events/events_scheduler_functions.hpp +++ b/src/lua/functions/events/events_scheduler_functions.hpp @@ -13,6 +13,12 @@ class EventsSchedulerFunctions final : private LuaScriptInterface { public: + explicit EventsSchedulerFunctions(lua_State* L) : + LuaScriptInterface("EventsSchedulerFunctions") { + init(L); + } + ~EventsSchedulerFunctions() override = default; + static void init(lua_State* L) { registerTable(L, "EventsScheduler"); diff --git a/src/lua/functions/events/global_event_functions.cpp b/src/lua/functions/events/global_event_functions.cpp index c858ee9a831..6ec9275fd01 100644 --- a/src/lua/functions/events/global_event_functions.cpp +++ b/src/lua/functions/events/global_event_functions.cpp @@ -10,7 +10,6 @@ #include "lua/functions/events/global_event_functions.hpp" #include "game/game.hpp" #include "lua/global/globalevent.hpp" -#include "lua/scripts/scripts.hpp" #include "utils/tools.hpp" int GlobalEventFunctions::luaCreateGlobalEvent(lua_State* L) { @@ -24,10 +23,10 @@ int GlobalEventFunctions::luaCreateGlobalEvent(lua_State* L) { int GlobalEventFunctions::luaGlobalEventType(lua_State* L) { // globalevent:type(callback) - const auto global = getUserdataShared<GlobalEvent>(L, 1); + const auto &global = getUserdataShared<GlobalEvent>(L, 1); if (global) { - std::string typeName = getString(L, 2); - std::string tmpStr = asLowerCaseString(typeName); + const std::string typeName = getString(L, 2); + const std::string tmpStr = asLowerCaseString(typeName); if (tmpStr == "startup") { global->setEventType(GLOBALEVENT_STARTUP); } else if (tmpStr == "shutdown") { @@ -54,7 +53,7 @@ int GlobalEventFunctions::luaGlobalEventType(lua_State* L) { int GlobalEventFunctions::luaGlobalEventRegister(lua_State* L) { // globalevent:register() - const auto globalevent = getUserdataShared<GlobalEvent>(L, 1); + const auto &globalevent = getUserdataShared<GlobalEvent>(L, 1); if (globalevent) { if (!globalevent->isLoadedCallback()) { pushBoolean(L, false); @@ -74,7 +73,7 @@ int GlobalEventFunctions::luaGlobalEventRegister(lua_State* L) { int GlobalEventFunctions::luaGlobalEventOnCallback(lua_State* L) { // globalevent:onThink / record / etc. (callback) - const auto globalevent = getUserdataShared<GlobalEvent>(L, 1); + const auto &globalevent = getUserdataShared<GlobalEvent>(L, 1); if (globalevent) { if (!globalevent->loadCallback()) { pushBoolean(L, false); @@ -89,12 +88,12 @@ int GlobalEventFunctions::luaGlobalEventOnCallback(lua_State* L) { int GlobalEventFunctions::luaGlobalEventTime(lua_State* L) { // globalevent:time(time) - const auto globalevent = getUserdataShared<GlobalEvent>(L, 1); + const auto &globalevent = getUserdataShared<GlobalEvent>(L, 1); if (globalevent) { std::string timer = getString(L, 2); - std::vector<int32_t> params = vectorAtoi(explodeString(timer, ":")); + const std::vector<int32_t> params = vectorAtoi(explodeString(timer, ":")); - int32_t hour = params.front(); + const int32_t hour = params.front(); if (hour < 0 || hour > 23) { g_logger().error("[GlobalEventFunctions::luaGlobalEventTime] - " "Invalid hour {} for globalevent with name: {}", @@ -129,13 +128,13 @@ int GlobalEventFunctions::luaGlobalEventTime(lua_State* L) { } } - time_t current_time = time(nullptr); + const time_t current_time = time(nullptr); tm* timeinfo = localtime(¤t_time); timeinfo->tm_hour = hour; timeinfo->tm_min = min; timeinfo->tm_sec = sec; - time_t difference = static_cast<time_t>(difftime(mktime(timeinfo), current_time)); + auto difference = static_cast<time_t>(difftime(mktime(timeinfo), current_time)); // If the difference is negative, add 86400 seconds (1 day) to it if (difference < 0) { difference += 86400; @@ -152,7 +151,7 @@ int GlobalEventFunctions::luaGlobalEventTime(lua_State* L) { int GlobalEventFunctions::luaGlobalEventInterval(lua_State* L) { // globalevent:interval(interval) - const auto globalevent = getUserdataShared<GlobalEvent>(L, 1); + const auto &globalevent = getUserdataShared<GlobalEvent>(L, 1); if (globalevent) { globalevent->setInterval(getNumber<uint32_t>(L, 2)); globalevent->setNextExecution(OTSYS_TIME() + getNumber<uint32_t>(L, 2)); diff --git a/src/lua/functions/events/global_event_functions.hpp b/src/lua/functions/events/global_event_functions.hpp index e04072a24e4..41fc57fdfea 100644 --- a/src/lua/functions/events/global_event_functions.hpp +++ b/src/lua/functions/events/global_event_functions.hpp @@ -13,6 +13,12 @@ class GlobalEventFunctions final : LuaScriptInterface { public: + explicit GlobalEventFunctions(lua_State* L) : + LuaScriptInterface("GlobalEventFunctions") { + init(L); + } + ~GlobalEventFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "GlobalEvent", "", GlobalEventFunctions::luaCreateGlobalEvent); registerMethod(L, "GlobalEvent", "type", GlobalEventFunctions::luaGlobalEventType); diff --git a/src/lua/functions/events/move_event_functions.cpp b/src/lua/functions/events/move_event_functions.cpp index cfd8588d19b..0c7277b9234 100644 --- a/src/lua/functions/events/move_event_functions.cpp +++ b/src/lua/functions/events/move_event_functions.cpp @@ -21,10 +21,10 @@ int MoveEventFunctions::luaCreateMoveEvent(lua_State* L) { int MoveEventFunctions::luaMoveEventType(lua_State* L) { // moveevent:type(callback) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { std::string typeName = getString(L, 2); - std::string tmpStr = asLowerCaseString(typeName); + const std::string tmpStr = asLowerCaseString(typeName); if (tmpStr == "stepin") { moveevent->setEventType(MOVE_EVENT_STEP_IN); moveevent->stepFunction = moveevent->StepInField; @@ -58,7 +58,7 @@ int MoveEventFunctions::luaMoveEventType(lua_State* L) { int MoveEventFunctions::luaMoveEventRegister(lua_State* L) { // moveevent:register() - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { // If not scripted, register item event // Example: unscripted_equipments.lua @@ -76,7 +76,7 @@ int MoveEventFunctions::luaMoveEventRegister(lua_State* L) { int MoveEventFunctions::luaMoveEventOnCallback(lua_State* L) { // moveevent:onEquip / deEquip / etc. (callback) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { if (!moveevent->loadCallback()) { pushBoolean(L, false); @@ -92,7 +92,7 @@ int MoveEventFunctions::luaMoveEventOnCallback(lua_State* L) { int MoveEventFunctions::luaMoveEventSlot(lua_State* L) { // moveevent:slot(slot) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (!moveevent) { lua_pushnil(L); return 1; @@ -137,7 +137,7 @@ int MoveEventFunctions::luaMoveEventSlot(lua_State* L) { int MoveEventFunctions::luaMoveEventLevel(lua_State* L) { // moveevent:level(lvl) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { moveevent->setRequiredLevel(getNumber<uint32_t>(L, 2)); moveevent->setWieldInfo(WIELDINFO_LEVEL); @@ -150,7 +150,7 @@ int MoveEventFunctions::luaMoveEventLevel(lua_State* L) { int MoveEventFunctions::luaMoveEventMagLevel(lua_State* L) { // moveevent:magicLevel(lvl) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { moveevent->setRequiredMagLevel(getNumber<uint32_t>(L, 2)); moveevent->setWieldInfo(WIELDINFO_MAGLV); @@ -163,7 +163,7 @@ int MoveEventFunctions::luaMoveEventMagLevel(lua_State* L) { int MoveEventFunctions::luaMoveEventPremium(lua_State* L) { // moveevent:premium(bool) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { moveevent->setNeedPremium(getBoolean(L, 2)); moveevent->setWieldInfo(WIELDINFO_PREMIUM); @@ -176,7 +176,7 @@ int MoveEventFunctions::luaMoveEventPremium(lua_State* L) { int MoveEventFunctions::luaMoveEventVocation(lua_State* L) { // moveevent:vocation(vocName[, showInDescription = false, lastVoc = false]) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { moveevent->addVocEquipMap(getString(L, 2)); moveevent->setWieldInfo(WIELDINFO_VOCREQ); @@ -215,9 +215,9 @@ int MoveEventFunctions::luaMoveEventVocation(lua_State* L) { int MoveEventFunctions::luaMoveEventItemId(lua_State* L) { // moveevent:id(ids) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc if (parameters > 1) { for (int i = 0; i < parameters; ++i) { moveevent->setItemId(getNumber<uint32_t>(L, 2 + i)); @@ -234,9 +234,9 @@ int MoveEventFunctions::luaMoveEventItemId(lua_State* L) { int MoveEventFunctions::luaMoveEventActionId(lua_State* L) { // moveevent:aid(ids) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc if (parameters > 1) { for (int i = 0; i < parameters; ++i) { moveevent->setActionId(getNumber<uint32_t>(L, 2 + i)); @@ -253,9 +253,9 @@ int MoveEventFunctions::luaMoveEventActionId(lua_State* L) { int MoveEventFunctions::luaMoveEventUniqueId(lua_State* L) { // moveevent:uid(ids) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc if (parameters > 1) { for (int i = 0; i < parameters; ++i) { moveevent->setUniqueId(getNumber<uint32_t>(L, 2 + i)); @@ -272,9 +272,9 @@ int MoveEventFunctions::luaMoveEventUniqueId(lua_State* L) { int MoveEventFunctions::luaMoveEventPosition(lua_State* L) { // moveevent:position(positions) - const auto moveevent = getUserdataShared<MoveEvent>(L, 1); + const auto &moveevent = getUserdataShared<MoveEvent>(L, 1); if (moveevent) { - int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc + const int parameters = lua_gettop(L) - 1; // - 1 because self is a parameter aswell, which we want to skip ofc if (parameters > 1) { for (int i = 0; i < parameters; ++i) { moveevent->setPosition(getPosition(L, 2 + i)); diff --git a/src/lua/functions/events/move_event_functions.hpp b/src/lua/functions/events/move_event_functions.hpp index 6e6412bec73..202006257e6 100644 --- a/src/lua/functions/events/move_event_functions.hpp +++ b/src/lua/functions/events/move_event_functions.hpp @@ -13,6 +13,12 @@ class MoveEventFunctions final : LuaScriptInterface { public: + explicit MoveEventFunctions(lua_State* L) : + LuaScriptInterface("MoveEventFunctions") { + init(L); + } + ~MoveEventFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "MoveEvent", "", MoveEventFunctions::luaCreateMoveEvent); registerMethod(L, "MoveEvent", "type", MoveEventFunctions::luaMoveEventType); diff --git a/src/lua/functions/events/talk_action_functions.cpp b/src/lua/functions/events/talk_action_functions.cpp index 4a8e9850d7f..a7ef2594f64 100644 --- a/src/lua/functions/events/talk_action_functions.cpp +++ b/src/lua/functions/events/talk_action_functions.cpp @@ -21,7 +21,7 @@ int TalkActionFunctions::luaCreateTalkAction(lua_State* L) { wordsVector.push_back(getString(L, i)); } - auto talkactionSharedPtr = std::make_shared<TalkAction>(getScriptEnv()->getScriptInterface()); + const auto talkactionSharedPtr = std::make_shared<TalkAction>(getScriptEnv()->getScriptInterface()); talkactionSharedPtr->setWords(wordsVector); pushUserdata<TalkAction>(L, talkactionSharedPtr); setMetatable(L, -1, "TalkAction"); @@ -30,7 +30,7 @@ int TalkActionFunctions::luaCreateTalkAction(lua_State* L) { int TalkActionFunctions::luaTalkActionOnSay(lua_State* L) { // talkAction:onSay(callback) - auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); @@ -47,7 +47,7 @@ int TalkActionFunctions::luaTalkActionOnSay(lua_State* L) { int TalkActionFunctions::luaTalkActionGroupType(lua_State* L) { // talkAction:groupType(GroupType = GROUP_TYPE_NORMAL) - auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); @@ -55,7 +55,7 @@ int TalkActionFunctions::luaTalkActionGroupType(lua_State* L) { } GroupType groupType; - int type = lua_type(L, 2); + const int type = lua_type(L, 2); if (type == LUA_TNUMBER) { groupType = enumFromValue<GroupType>(getNumber<uint8_t>(L, 2)); } else if (type == LUA_TSTRING) { @@ -73,13 +73,13 @@ int TalkActionFunctions::luaTalkActionGroupType(lua_State* L) { } else if (strValue == "god") { groupType = GROUP_TYPE_GOD; } else { - auto string = fmt::format("Invalid group type string value {} for group type for script: {}", strValue, getScriptEnv()->getScriptInterface()->getLoadingScriptName()); + const auto string = fmt::format("Invalid group type string value {} for group type for script: {}", strValue, getScriptEnv()->getScriptInterface()->getLoadingScriptName()); reportErrorFunc(string); pushBoolean(L, false); return 1; } } else { - auto string = fmt::format("Expected number or string value for group type for script: {}", getScriptEnv()->getScriptInterface()->getLoadingScriptName()); + const auto string = fmt::format("Expected number or string value for group type for script: {}", getScriptEnv()->getScriptInterface()->getLoadingScriptName()); reportErrorFunc(string); pushBoolean(L, false); return 1; @@ -92,7 +92,7 @@ int TalkActionFunctions::luaTalkActionGroupType(lua_State* L) { int TalkActionFunctions::luaTalkActionRegister(lua_State* L) { // talkAction:register() - auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); @@ -105,7 +105,7 @@ int TalkActionFunctions::luaTalkActionRegister(lua_State* L) { } if (talkactionSharedPtr->getGroupType() == GROUP_TYPE_NONE) { - auto string = fmt::format("TalkAction with name {} does't have groupType", talkactionSharedPtr->getWords()); + const auto string = fmt::format("TalkAction with name {} does't have groupType", talkactionSharedPtr->getWords()); reportErrorFunc(string); pushBoolean(L, false); return 1; @@ -117,7 +117,7 @@ int TalkActionFunctions::luaTalkActionRegister(lua_State* L) { int TalkActionFunctions::luaTalkActionSeparator(lua_State* L) { // talkAction:separator(sep) - auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); @@ -131,7 +131,7 @@ int TalkActionFunctions::luaTalkActionSeparator(lua_State* L) { int TalkActionFunctions::luaTalkActionGetName(lua_State* L) { // local name = talkAction:getName() - const auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); @@ -144,7 +144,7 @@ int TalkActionFunctions::luaTalkActionGetName(lua_State* L) { int TalkActionFunctions::luaTalkActionGetDescription(lua_State* L) { // local description = talkAction:getDescription() - const auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); @@ -157,7 +157,7 @@ int TalkActionFunctions::luaTalkActionGetDescription(lua_State* L) { int TalkActionFunctions::luaTalkActionSetDescription(lua_State* L) { // local description = talkAction:setDescription() - auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); @@ -171,7 +171,7 @@ int TalkActionFunctions::luaTalkActionSetDescription(lua_State* L) { int TalkActionFunctions::luaTalkActionGetGroupType(lua_State* L) { // local groupType = talkAction:getGroupType() - const auto talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); + const auto &talkactionSharedPtr = getUserdataShared<TalkAction>(L, 1); if (!talkactionSharedPtr) { reportErrorFunc(getErrorDesc(LUA_ERROR_TALK_ACTION_NOT_FOUND)); pushBoolean(L, false); diff --git a/src/lua/functions/events/talk_action_functions.hpp b/src/lua/functions/events/talk_action_functions.hpp index 384688b4722..487f2046d2f 100644 --- a/src/lua/functions/events/talk_action_functions.hpp +++ b/src/lua/functions/events/talk_action_functions.hpp @@ -13,6 +13,12 @@ class TalkActionFunctions final : LuaScriptInterface { public: + explicit TalkActionFunctions(lua_State* L) : + LuaScriptInterface("TalkActionFunctions") { + init(L); + } + ~TalkActionFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "TalkAction", "", TalkActionFunctions::luaCreateTalkAction); registerMethod(L, "TalkAction", "onSay", TalkActionFunctions::luaTalkActionOnSay); diff --git a/src/lua/functions/items/container_functions.cpp b/src/lua/functions/items/container_functions.cpp index 7cc06745b18..f74a1ab2a30 100644 --- a/src/lua/functions/items/container_functions.cpp +++ b/src/lua/functions/items/container_functions.cpp @@ -13,9 +13,9 @@ int ContainerFunctions::luaContainerCreate(lua_State* L) { // Container(uid) - uint32_t id = getNumber<uint32_t>(L, 2); + const uint32_t id = getNumber<uint32_t>(L, 2); - std::shared_ptr<Container> container = getScriptEnv()->getContainerByUID(id); + const auto &container = getScriptEnv()->getContainerByUID(id); if (container) { pushUserdata(L, container); setMetatable(L, -1, "Container"); @@ -27,7 +27,7 @@ int ContainerFunctions::luaContainerCreate(lua_State* L) { int ContainerFunctions::luaContainerGetSize(lua_State* L) { // container:getSize() - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (container) { lua_pushnumber(L, container->size()); } else { @@ -49,7 +49,7 @@ int ContainerFunctions::luaContainerGetMaxCapacity(lua_State* L) { int ContainerFunctions::luaContainerGetCapacity(lua_State* L) { // container:getCapacity() - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (container) { lua_pushnumber(L, container->capacity()); } else { @@ -60,17 +60,17 @@ int ContainerFunctions::luaContainerGetCapacity(lua_State* L) { int ContainerFunctions::luaContainerGetEmptySlots(lua_State* L) { // container:getEmptySlots([recursive = false]) - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (!container) { lua_pushnil(L); return 1; } uint32_t slots = container->capacity() - container->size(); - bool recursive = getBoolean(L, 2, false); + const bool recursive = getBoolean(L, 2, false); if (recursive) { for (ContainerIterator it = container->iterator(); it.hasNext(); it.advance()) { - if (std::shared_ptr<Container> tmpContainer = (*it)->getContainer()) { + if (const auto &tmpContainer = (*it)->getContainer()) { slots += tmpContainer->capacity() - tmpContainer->size(); } } @@ -81,7 +81,7 @@ int ContainerFunctions::luaContainerGetEmptySlots(lua_State* L) { int ContainerFunctions::luaContainerGetItemHoldingCount(lua_State* L) { // container:getItemHoldingCount() - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (container) { lua_pushnumber(L, container->getItemHoldingCount()); } else { @@ -92,14 +92,14 @@ int ContainerFunctions::luaContainerGetItemHoldingCount(lua_State* L) { int ContainerFunctions::luaContainerGetItem(lua_State* L) { // container:getItem(index) - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (!container) { lua_pushnil(L); return 1; } - uint32_t index = getNumber<uint32_t>(L, 2); - std::shared_ptr<Item> item = container->getItemByIndex(index); + const uint32_t index = getNumber<uint32_t>(L, 2); + const auto &item = container->getItemByIndex(index); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -111,8 +111,8 @@ int ContainerFunctions::luaContainerGetItem(lua_State* L) { int ContainerFunctions::luaContainerHasItem(lua_State* L) { // container:hasItem(item) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &item = getUserdataShared<Item>(L, 2); + const auto &container = getUserdataShared<Container>(L, 1); if (container) { pushBoolean(L, container->isHoldingItem(item)); } else { @@ -123,7 +123,7 @@ int ContainerFunctions::luaContainerHasItem(lua_State* L) { int ContainerFunctions::luaContainerAddItem(lua_State* L) { // container:addItem(itemId[, count/subType = 1[, index = INDEX_WHEREEVER[, flags = 0]]]) - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (!container) { lua_pushnil(L); reportErrorFunc("Container is nullptr"); @@ -142,21 +142,21 @@ int ContainerFunctions::luaContainerAddItem(lua_State* L) { } } - uint32_t count = getNumber<uint32_t>(L, 3, 1); + auto count = getNumber<uint32_t>(L, 3, 1); const ItemType &it = Item::items[itemId]; if (it.stackable) { count = std::min<uint16_t>(count, it.stackSize); } - std::shared_ptr<Item> item = Item::CreateItem(itemId, count); + const auto &item = Item::CreateItem(itemId, count); if (!item) { lua_pushnil(L); reportErrorFunc("Item is nullptr"); return 1; } - int32_t index = getNumber<int32_t>(L, 4, INDEX_WHEREEVER); - uint32_t flags = getNumber<uint32_t>(L, 5, 0); + const auto index = getNumber<int32_t>(L, 4, INDEX_WHEREEVER); + const auto flags = getNumber<uint32_t>(L, 5, 0); ReturnValue ret = g_game().internalAddItem(container, item, index, flags); if (ret == RETURNVALUE_NOERROR) { @@ -171,13 +171,13 @@ int ContainerFunctions::luaContainerAddItem(lua_State* L) { int ContainerFunctions::luaContainerAddItemEx(lua_State* L) { // container:addItemEx(item[, index = INDEX_WHEREEVER[, flags = 0]]) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); + const auto &item = getUserdataShared<Item>(L, 2); if (!item) { lua_pushnil(L); return 1; } - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (!container) { lua_pushnil(L); return 1; @@ -189,8 +189,8 @@ int ContainerFunctions::luaContainerAddItemEx(lua_State* L) { return 1; } - int32_t index = getNumber<int32_t>(L, 3, INDEX_WHEREEVER); - uint32_t flags = getNumber<uint32_t>(L, 4, 0); + const auto index = getNumber<int32_t>(L, 3, INDEX_WHEREEVER); + const auto flags = getNumber<uint32_t>(L, 4, 0); ReturnValue ret = g_game().internalAddItem(container, item, index, flags); if (ret == RETURNVALUE_NOERROR) { ScriptEnvironment::removeTempItem(item); @@ -201,7 +201,7 @@ int ContainerFunctions::luaContainerAddItemEx(lua_State* L) { int ContainerFunctions::luaContainerGetCorpseOwner(lua_State* L) { // container:getCorpseOwner() - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (container) { lua_pushnumber(L, container->getCorpseOwner()); } else { @@ -212,7 +212,7 @@ int ContainerFunctions::luaContainerGetCorpseOwner(lua_State* L) { int ContainerFunctions::luaContainerGetItemCountById(lua_State* L) { // container:getItemCountById(itemId[, subType = -1]) - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (!container) { lua_pushnil(L); return 1; @@ -229,14 +229,14 @@ int ContainerFunctions::luaContainerGetItemCountById(lua_State* L) { } } - int32_t subType = getNumber<int32_t>(L, 3, -1); + const auto subType = getNumber<int32_t>(L, 3, -1); lua_pushnumber(L, container->getItemTypeCount(itemId, subType)); return 1; } int ContainerFunctions::luaContainerGetContentDescription(lua_State* L) { // container:getContentDescription([oldProtocol]) - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (container) { pushString(L, container->getContentDescription(getBoolean(L, 2, false))); } else { @@ -247,19 +247,19 @@ int ContainerFunctions::luaContainerGetContentDescription(lua_State* L) { int ContainerFunctions::luaContainerGetItems(lua_State* L) { // container:getItems([recursive = false]) - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (!container) { lua_pushnil(L); return 1; } - bool recursive = getBoolean(L, 2, false); - std::vector<std::shared_ptr<Item>> items = container->getItems(recursive); + const bool recursive = getBoolean(L, 2, false); + const std::vector<std::shared_ptr<Item>> items = container->getItems(recursive); lua_createtable(L, static_cast<int>(items.size()), 0); int index = 0; - for (std::shared_ptr<Item> item : items) { + for (const auto &item : items) { index++; pushUserdata(L, item); setItemMetatable(L, -1, item); @@ -270,14 +270,14 @@ int ContainerFunctions::luaContainerGetItems(lua_State* L) { int ContainerFunctions::luaContainerRegisterReward(lua_State* L) { // container:registerReward() - std::shared_ptr<Container> container = getUserdataShared<Container>(L, 1); + const auto &container = getUserdataShared<Container>(L, 1); if (!container) { lua_pushnil(L); return 1; } - int64_t rewardId = getTimeMsNow(); - std::shared_ptr<Item> rewardContainer = Item::CreateItem(ITEM_REWARD_CONTAINER); + const int64_t rewardId = getTimeMsNow(); + const auto &rewardContainer = Item::CreateItem(ITEM_REWARD_CONTAINER); rewardContainer->setAttribute(ItemAttribute_t::DATE, rewardId); container->setAttribute(ItemAttribute_t::DATE, rewardId); container->internalAddThing(rewardContainer); diff --git a/src/lua/functions/items/container_functions.hpp b/src/lua/functions/items/container_functions.hpp index 568018b45fd..52bb33e6b52 100644 --- a/src/lua/functions/items/container_functions.hpp +++ b/src/lua/functions/items/container_functions.hpp @@ -12,8 +12,13 @@ #include "lua/scripts/luascript.hpp" class ContainerFunctions final : LuaScriptInterface { -public: private: + explicit ContainerFunctions(lua_State* L) : + LuaScriptInterface("ContainerFunctions") { + init(L); + } + ~ContainerFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Container", "Item", ContainerFunctions::luaContainerCreate); registerMetaMethod(L, "Container", "__eq", ContainerFunctions::luaUserdataCompare); diff --git a/src/lua/functions/items/imbuement_functions.cpp b/src/lua/functions/items/imbuement_functions.cpp index 1faed911621..b3676a22183 100644 --- a/src/lua/functions/items/imbuement_functions.cpp +++ b/src/lua/functions/items/imbuement_functions.cpp @@ -13,7 +13,7 @@ int ImbuementFunctions::luaCreateImbuement(lua_State* L) { // Imbuement(id) - uint16_t imbuementId = getNumber<uint16_t>(L, 2); + const uint16_t imbuementId = getNumber<uint16_t>(L, 2); Imbuement* imbuement = g_imbuements().getImbuement(imbuementId); if (imbuement) { @@ -27,7 +27,7 @@ int ImbuementFunctions::luaCreateImbuement(lua_State* L) { int ImbuementFunctions::luaImbuementGetName(lua_State* L) { // imbuement:getName() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (imbuement) { pushString(L, imbuement->getName()); } else { @@ -38,7 +38,7 @@ int ImbuementFunctions::luaImbuementGetName(lua_State* L) { int ImbuementFunctions::luaImbuementGetId(lua_State* L) { // imbuement:getId() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (imbuement) { lua_pushnumber(L, imbuement->getID()); } else { @@ -49,7 +49,7 @@ int ImbuementFunctions::luaImbuementGetId(lua_State* L) { int ImbuementFunctions::luaImbuementGetItems(lua_State* L) { // imbuement:getItems() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (!imbuement) { lua_pushnil(L); return 1; @@ -70,7 +70,7 @@ int ImbuementFunctions::luaImbuementGetItems(lua_State* L) { int ImbuementFunctions::luaImbuementGetBase(lua_State* L) { // imbuement:getBase() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (!imbuement) { lua_pushnil(L); return 1; @@ -95,12 +95,12 @@ int ImbuementFunctions::luaImbuementGetBase(lua_State* L) { int ImbuementFunctions::luaImbuementGetCategory(lua_State* L) { // imbuement:getCategory() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (!imbuement) { lua_pushnil(L); return 1; } - uint16_t categoryId = imbuement->getCategory(); + const uint16_t categoryId = imbuement->getCategory(); const CategoryImbuement* categoryImbuement = g_imbuements().getCategoryByID(categoryId); if (categoryImbuement) { @@ -116,7 +116,7 @@ int ImbuementFunctions::luaImbuementGetCategory(lua_State* L) { int ImbuementFunctions::luaImbuementIsPremium(lua_State* L) { // imbuement:isPremium() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (!imbuement) { lua_pushnil(L); return 1; @@ -128,7 +128,7 @@ int ImbuementFunctions::luaImbuementIsPremium(lua_State* L) { int ImbuementFunctions::luaImbuementGetElementDamage(lua_State* L) { // imbuement:getElementDamage() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (imbuement) { lua_pushnumber(L, imbuement->elementDamage); } else { @@ -139,7 +139,7 @@ int ImbuementFunctions::luaImbuementGetElementDamage(lua_State* L) { int ImbuementFunctions::luaImbuementGetCombatType(lua_State* L) { // imbuement:getCombatType() - Imbuement* imbuement = getUserdata<Imbuement>(L, 1); + const auto* imbuement = getUserdata<Imbuement>(L, 1); if (imbuement) { lua_pushnumber(L, imbuement->combatType); } else { diff --git a/src/lua/functions/items/imbuement_functions.hpp b/src/lua/functions/items/imbuement_functions.hpp index 516fe91a3b1..f86882b1cd2 100644 --- a/src/lua/functions/items/imbuement_functions.hpp +++ b/src/lua/functions/items/imbuement_functions.hpp @@ -13,6 +13,12 @@ class ImbuementFunctions final : LuaScriptInterface { public: + explicit ImbuementFunctions(lua_State* L) : + LuaScriptInterface("ImbuementFunctions") { + init(L); + } + ~ImbuementFunctions() override = default; + static void init(lua_State* L) { registerClass(L, "Imbuement", "", ImbuementFunctions::luaCreateImbuement); registerMetaMethod(L, "Imbuement", "__eq", ImbuementFunctions::luaUserdataCompare); diff --git a/src/lua/functions/items/item_classification_functions.cpp b/src/lua/functions/items/item_classification_functions.cpp index 4df6d6f9ea8..7631e2f8650 100644 --- a/src/lua/functions/items/item_classification_functions.cpp +++ b/src/lua/functions/items/item_classification_functions.cpp @@ -27,7 +27,7 @@ int ItemClassificationFunctions::luaItemClassificationCreate(lua_State* L) { int ItemClassificationFunctions::luaItemClassificationAddTier(lua_State* L) { // itemClassification:addTier(id, core, regularPrice, convergenceFusionPrice, convergenceTransferPrice) - ItemClassification* itemClassification = getUserdata<ItemClassification>(L, 1); + auto* itemClassification = getUserdata<ItemClassification>(L, 1); if (itemClassification) { itemClassification->addTier( getNumber<uint8_t>(L, 2), diff --git a/src/lua/functions/items/item_classification_functions.hpp b/src/lua/functions/items/item_classification_functions.hpp index ebbd9fddd47..29b04268282 100644 --- a/src/lua/functions/items/item_classification_functions.hpp +++ b/src/lua/functions/items/item_classification_functions.hpp @@ -13,6 +13,12 @@ class ItemClassificationFunctions final : LuaScriptInterface { public: + explicit ItemClassificationFunctions(lua_State* L) : + LuaScriptInterface("ItemClassificationFunctions") { + init(L); + } + ~ItemClassificationFunctions() override = default; + static void init(lua_State* L) { registerClass(L, "ItemClassification", "", ItemClassificationFunctions::luaItemClassificationCreate); registerMetaMethod(L, "ItemClassification", "__eq", ItemClassificationFunctions::luaUserdataCompare); diff --git a/src/lua/functions/items/item_functions.cpp b/src/lua/functions/items/item_functions.cpp index 7b5713f29b1..f75e7adb4eb 100644 --- a/src/lua/functions/items/item_functions.cpp +++ b/src/lua/functions/items/item_functions.cpp @@ -19,9 +19,9 @@ class Imbuement; // Item int ItemFunctions::luaItemCreate(lua_State* L) { // Item(uid) - uint32_t id = getNumber<uint32_t>(L, 2); + const uint32_t id = getNumber<uint32_t>(L, 2); - std::shared_ptr<Item> item = getScriptEnv()->getItemByUID(id); + const auto &item = getScriptEnv()->getItemByUID(id); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -58,13 +58,13 @@ int ItemFunctions::luaItemGetContainer(lua_State* L) { int ItemFunctions::luaItemGetParent(lua_State* L) { // item:getParent() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; } - std::shared_ptr<Cylinder> parent = item->getParent(); + const auto &parent = item->getParent(); if (!parent) { lua_pushnil(L); return 1; @@ -76,13 +76,13 @@ int ItemFunctions::luaItemGetParent(lua_State* L) { int ItemFunctions::luaItemGetTopParent(lua_State* L) { // item:getTopParent() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; } - std::shared_ptr<Cylinder> topParent = item->getTopParent(); + const auto &topParent = item->getTopParent(); if (!topParent) { lua_pushnil(L); return 1; @@ -94,7 +94,7 @@ int ItemFunctions::luaItemGetTopParent(lua_State* L) { int ItemFunctions::luaItemGetId(lua_State* L) { // item:getId() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { lua_pushnumber(L, item->getID()); } else { @@ -105,13 +105,13 @@ int ItemFunctions::luaItemGetId(lua_State* L) { int ItemFunctions::luaItemClone(lua_State* L) { // item:clone() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> clone = item->clone(); + const auto &clone = item->clone(); if (!clone) { lua_pushnil(L); return 1; @@ -127,22 +127,22 @@ int ItemFunctions::luaItemClone(lua_State* L) { int ItemFunctions::luaItemSplit(lua_State* L) { // item:split([count = 1]) - std::shared_ptr<Item>* itemPtr = getRawUserDataShared<Item>(L, 1); + const auto &itemPtr = getRawUserDataShared<Item>(L, 1); if (!itemPtr) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = *itemPtr; + const auto &item = *itemPtr; if (!item || !item->isStackable() || item->isRemoved()) { lua_pushnil(L); return 1; } - uint16_t count = std::min<uint16_t>(getNumber<uint16_t>(L, 2, 1), item->getItemCount()); - uint16_t diff = item->getItemCount() - count; + const uint16_t count = std::min<uint16_t>(getNumber<uint16_t>(L, 2, 1), item->getItemCount()); + const uint16_t diff = item->getItemCount() - count; - std::shared_ptr<Item> splitItem = item->clone(); + const auto &splitItem = item->clone(); if (!splitItem) { lua_pushnil(L); return 1; @@ -151,9 +151,9 @@ int ItemFunctions::luaItemSplit(lua_State* L) { splitItem->setItemCount(count); ScriptEnvironment* env = getScriptEnv(); - uint32_t uid = env->addThing(item); + const uint32_t uid = env->addThing(item); - std::shared_ptr<Item> newItem = g_game().transformItem(item, item->getID(), diff); + const auto &newItem = g_game().transformItem(item, item->getID(), diff); if (item->isRemoved()) { env->removeItemByUID(uid); } @@ -174,9 +174,9 @@ int ItemFunctions::luaItemSplit(lua_State* L) { int ItemFunctions::luaItemRemove(lua_State* L) { // item:remove([count = -1]) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { - int32_t count = getNumber<int32_t>(L, 2, -1); + const auto count = getNumber<int32_t>(L, 2, -1); pushBoolean(L, g_game().internalRemoveItem(item, count) == RETURNVALUE_NOERROR); } else { lua_pushnil(L); @@ -186,7 +186,7 @@ int ItemFunctions::luaItemRemove(lua_State* L) { int ItemFunctions::luaItemGetUniqueId(lua_State* L) { // item:getUniqueId() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { uint32_t uniqueId = item->getAttribute<uint16_t>(ItemAttribute_t::UNIQUEID); if (uniqueId == 0) { @@ -201,9 +201,9 @@ int ItemFunctions::luaItemGetUniqueId(lua_State* L) { int ItemFunctions::luaItemGetActionId(lua_State* L) { // item:getActionId() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { - auto actionId = item->getAttribute<uint16_t>(ItemAttribute_t::ACTIONID); + const auto actionId = item->getAttribute<uint16_t>(ItemAttribute_t::ACTIONID); lua_pushnumber(L, actionId); } else { lua_pushnil(L); @@ -213,8 +213,8 @@ int ItemFunctions::luaItemGetActionId(lua_State* L) { int ItemFunctions::luaItemSetActionId(lua_State* L) { // item:setActionId(actionId) - uint16_t actionId = getNumber<uint16_t>(L, 2); - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const uint16_t actionId = getNumber<uint16_t>(L, 2); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { item->setAttribute(ItemAttribute_t::ACTIONID, actionId); pushBoolean(L, true); @@ -226,7 +226,7 @@ int ItemFunctions::luaItemSetActionId(lua_State* L) { int ItemFunctions::luaItemGetCount(lua_State* L) { // item:getCount() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { lua_pushnumber(L, item->getItemCount()); } else { @@ -237,7 +237,7 @@ int ItemFunctions::luaItemGetCount(lua_State* L) { int ItemFunctions::luaItemGetCharges(lua_State* L) { // item:getCharges() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { lua_pushnumber(L, item->getCharges()); } else { @@ -248,7 +248,7 @@ int ItemFunctions::luaItemGetCharges(lua_State* L) { int ItemFunctions::luaItemGetFluidType(lua_State* L) { // item:getFluidType() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { lua_pushnumber(L, static_cast<lua_Number>(item->getAttribute<uint16_t>(ItemAttribute_t::FLUIDTYPE))); } else { @@ -259,7 +259,7 @@ int ItemFunctions::luaItemGetFluidType(lua_State* L) { int ItemFunctions::luaItemGetWeight(lua_State* L) { // item:getWeight() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { lua_pushnumber(L, item->getWeight()); } else { @@ -270,7 +270,7 @@ int ItemFunctions::luaItemGetWeight(lua_State* L) { int ItemFunctions::luaItemGetSubType(lua_State* L) { // item:getSubType() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { lua_pushnumber(L, item->getSubType()); } else { @@ -281,7 +281,7 @@ int ItemFunctions::luaItemGetSubType(lua_State* L) { int ItemFunctions::luaItemGetName(lua_State* L) { // item:getName() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { pushString(L, item->getName()); } else { @@ -292,7 +292,7 @@ int ItemFunctions::luaItemGetName(lua_State* L) { int ItemFunctions::luaItemGetPluralName(lua_State* L) { // item:getPluralName() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { pushString(L, item->getPluralName()); } else { @@ -303,7 +303,7 @@ int ItemFunctions::luaItemGetPluralName(lua_State* L) { int ItemFunctions::luaItemGetArticle(lua_State* L) { // item:getArticle() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { pushString(L, item->getArticle()); } else { @@ -314,7 +314,7 @@ int ItemFunctions::luaItemGetArticle(lua_State* L) { int ItemFunctions::luaItemGetPosition(lua_State* L) { // item:getPosition() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { pushPosition(L, item->getPosition()); } else { @@ -325,13 +325,13 @@ int ItemFunctions::luaItemGetPosition(lua_State* L) { int ItemFunctions::luaItemGetTile(lua_State* L) { // item:getTile() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; } - std::shared_ptr<Tile> tile = item->getTile(); + const auto &tile = item->getTile(); if (tile) { pushUserdata<Tile>(L, tile); setMetatable(L, -1, "Tile"); @@ -343,7 +343,7 @@ int ItemFunctions::luaItemGetTile(lua_State* L) { int ItemFunctions::luaItemHasAttribute(lua_State* L) { // item:hasAttribute(key) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -364,7 +364,7 @@ int ItemFunctions::luaItemHasAttribute(lua_State* L) { int ItemFunctions::luaItemGetAttribute(lua_State* L) { // item:getAttribute(key) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -396,7 +396,7 @@ int ItemFunctions::luaItemGetAttribute(lua_State* L) { int ItemFunctions::luaItemSetAttribute(lua_State* L) { // item:setAttribute(key, value) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -414,7 +414,7 @@ int ItemFunctions::luaItemSetAttribute(lua_State* L) { if (item->isAttributeInteger(attribute)) { switch (attribute) { case ItemAttribute_t::DECAYSTATE: { - if (ItemDecayState_t decayState = getNumber<ItemDecayState_t>(L, 3); + if (const auto decayState = getNumber<ItemDecayState_t>(L, 3); decayState == DECAYING_FALSE || decayState == DECAYING_STOPPING) { g_decay().stopDecay(item); } else { @@ -443,7 +443,7 @@ int ItemFunctions::luaItemSetAttribute(lua_State* L) { item->updateTileFlags(); pushBoolean(L, true); } else if (item->isAttributeString(attribute)) { - auto newAttributeString = getString(L, 3); + const auto newAttributeString = getString(L, 3); item->setAttribute(attribute, newAttributeString); item->updateTileFlags(); pushBoolean(L, true); @@ -455,7 +455,7 @@ int ItemFunctions::luaItemSetAttribute(lua_State* L) { int ItemFunctions::luaItemRemoveAttribute(lua_State* L) { // item:removeAttribute(key) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -487,7 +487,7 @@ int ItemFunctions::luaItemRemoveAttribute(lua_State* L) { int ItemFunctions::luaItemGetCustomAttribute(lua_State* L) { // item:getCustomAttribute(key) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -513,7 +513,7 @@ int ItemFunctions::luaItemGetCustomAttribute(lua_State* L) { int ItemFunctions::luaItemSetCustomAttribute(lua_State* L) { // item:setCustomAttribute(key, value) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -534,7 +534,7 @@ int ItemFunctions::luaItemSetCustomAttribute(lua_State* L) { if (std::floor(doubleValue) < doubleValue) { item->setCustomAttribute(key, doubleValue); } else { - int64_t int64 = getNumber<int64_t>(L, 3); + const int64_t int64 = getNumber<int64_t>(L, 3); item->setCustomAttribute(key, int64); } } else if (isString(L, 3)) { @@ -554,7 +554,7 @@ int ItemFunctions::luaItemSetCustomAttribute(lua_State* L) { int ItemFunctions::luaItemRemoveCustomAttribute(lua_State* L) { // item:removeCustomAttribute(key) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -572,7 +572,7 @@ int ItemFunctions::luaItemRemoveCustomAttribute(lua_State* L) { int ItemFunctions::luaItemCanBeMoved(lua_State* L) { // item:canBeMoved() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { pushBoolean(L, item->canBeMoved()); } else { @@ -583,7 +583,7 @@ int ItemFunctions::luaItemCanBeMoved(lua_State* L) { int ItemFunctions::luaItemSerializeAttributes(lua_State* L) { // item:serializeAttributes() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { lua_pushnil(L); return 1; @@ -600,13 +600,13 @@ int ItemFunctions::luaItemSerializeAttributes(lua_State* L) { int ItemFunctions::luaItemMoveTo(lua_State* L) { // item:moveTo(position or cylinder[, flags]) - std::shared_ptr<Item>* itemPtr = getRawUserDataShared<Item>(L, 1); + const auto &itemPtr = getRawUserDataShared<Item>(L, 1); if (!itemPtr) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = *itemPtr; + const auto &item = *itemPtr; if (!item || item->isRemoved()) { lua_pushnil(L); return 1; @@ -643,7 +643,7 @@ int ItemFunctions::luaItemMoveTo(lua_State* L) { return 1; } - uint32_t flags = getNumber<uint32_t>(L, 3, FLAG_NOLIMIT | FLAG_IGNOREBLOCKITEM | FLAG_IGNOREBLOCKCREATURE | FLAG_IGNORENOTMOVABLE); + const auto flags = getNumber<uint32_t>(L, 3, FLAG_NOLIMIT | FLAG_IGNOREBLOCKITEM | FLAG_IGNOREBLOCKCREATURE | FLAG_IGNORENOTMOVABLE); if (item->getParent() == VirtualCylinder::virtualCylinder) { pushBoolean(L, g_game().internalAddItem(toCylinder, item, INDEX_WHEREEVER, flags) == RETURNVALUE_NOERROR); @@ -660,13 +660,13 @@ int ItemFunctions::luaItemMoveTo(lua_State* L) { int ItemFunctions::luaItemTransform(lua_State* L) { // item:transform(itemId[, count/subType = -1]) - std::shared_ptr<Item>* itemPtr = getRawUserDataShared<Item>(L, 1); + const auto &itemPtr = getRawUserDataShared<Item>(L, 1); if (!itemPtr) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> &item = *itemPtr; + auto &item = *itemPtr; if (!item) { lua_pushnil(L); return 1; @@ -683,7 +683,7 @@ int ItemFunctions::luaItemTransform(lua_State* L) { } } - int32_t subType = getNumber<int32_t>(L, 3, -1); + auto subType = getNumber<int32_t>(L, 3, -1); if (item->getID() == itemId && (subType == -1 || subType == item->getSubType())) { pushBoolean(L, true); return 1; @@ -695,9 +695,9 @@ int ItemFunctions::luaItemTransform(lua_State* L) { } ScriptEnvironment* env = getScriptEnv(); - uint32_t uid = env->addThing(item); + const uint32_t uid = env->addThing(item); - std::shared_ptr<Item> newItem = g_game().transformItem(item, itemId, subType); + const auto &newItem = g_game().transformItem(item, itemId, subType); if (item->isRemoved()) { env->removeItemByUID(uid); } @@ -713,7 +713,7 @@ int ItemFunctions::luaItemTransform(lua_State* L) { int ItemFunctions::luaItemDecay(lua_State* L) { // item:decay(decayId) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { if (isNumber(L, 2)) { ItemType &it = Item::items.getItemType(item->getID()); @@ -730,25 +730,21 @@ int ItemFunctions::luaItemDecay(lua_State* L) { int ItemFunctions::luaItemMoveToSlot(lua_State* L) { // item:moveToSlot(player, slot) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item || item->isRemoved()) { lua_pushnil(L); return 1; } - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 2); + const auto &player = getUserdataShared<Player>(L, 2); if (!player) { lua_pushnil(L); return 1; } - Slots_t slot = getNumber<Slots_t>(L, 3, CONST_SLOT_WHEREEVER); + const auto slot = getNumber<Slots_t>(L, 3, CONST_SLOT_WHEREEVER); - std::shared_ptr<Item> moveItem = nullptr; ReturnValue ret = g_game().internalMoveItem(item->getParent(), player, slot, item, item->getItemCount(), nullptr); - if (moveItem) { - item = moveItem; - } pushBoolean(L, ret == RETURNVALUE_NOERROR); return 1; @@ -756,9 +752,9 @@ int ItemFunctions::luaItemMoveToSlot(lua_State* L) { int ItemFunctions::luaItemGetDescription(lua_State* L) { // item:getDescription(distance) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { - int32_t distance = getNumber<int32_t>(L, 2); + const int32_t distance = getNumber<int32_t>(L, 2); pushString(L, item->getDescription(distance)); } else { lua_pushnil(L); @@ -768,9 +764,9 @@ int ItemFunctions::luaItemGetDescription(lua_State* L) { int ItemFunctions::luaItemHasProperty(lua_State* L) { // item:hasProperty(property) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (item) { - ItemProperty property = getNumber<ItemProperty>(L, 2); + const ItemProperty property = getNumber<ItemProperty>(L, 2); pushBoolean(L, item->hasProperty(property)); } else { lua_pushnil(L); @@ -780,7 +776,7 @@ int ItemFunctions::luaItemHasProperty(lua_State* L) { int ItemFunctions::luaItemGetImbuement(lua_State* L) { // item:getImbuement() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -811,7 +807,7 @@ int ItemFunctions::luaItemGetImbuement(lua_State* L) { int ItemFunctions::luaItemGetImbuementSlot(lua_State* L) { // item:getImbuementSlot() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -825,14 +821,14 @@ int ItemFunctions::luaItemGetImbuementSlot(lua_State* L) { int ItemFunctions::luaItemSetDuration(lua_State* L) { // item:setDuration(minDuration, maxDuration = 0, decayTo = 0, showDuration = true) // Example: item:setDuration(10000, 20000, 2129, false) = random duration from range 10000/20000 - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); return 1; } - uint32_t minDuration = getNumber<uint32_t>(L, 2); + const uint32_t minDuration = getNumber<uint32_t>(L, 2); uint32_t maxDuration = 0; if (lua_gettop(L) > 2) { maxDuration = uniform_random(minDuration, getNumber<uint32_t>(L, 3)); @@ -862,7 +858,7 @@ int ItemFunctions::luaItemSetDuration(lua_State* L) { int ItemFunctions::luaItemIsInsideDepot(lua_State* L) { // item:isInsideDepot([includeInbox = false]) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -875,7 +871,7 @@ int ItemFunctions::luaItemIsInsideDepot(lua_State* L) { int ItemFunctions::luaItemIsContainer(lua_State* L) { // item:isContainer() - const auto item = getUserdataShared<const Item>(L, 1); + const auto &item = getUserdataShared<const Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -889,7 +885,7 @@ int ItemFunctions::luaItemIsContainer(lua_State* L) { int ItemFunctions::luaItemGetTier(lua_State* L) { // item:getTier() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -902,7 +898,7 @@ int ItemFunctions::luaItemGetTier(lua_State* L) { int ItemFunctions::luaItemSetTier(lua_State* L) { // item:setTier(tier) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -916,7 +912,7 @@ int ItemFunctions::luaItemSetTier(lua_State* L) { int ItemFunctions::luaItemGetClassification(lua_State* L) { // item:getClassification() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -929,7 +925,7 @@ int ItemFunctions::luaItemGetClassification(lua_State* L) { int ItemFunctions::luaItemCanReceiveAutoCarpet(lua_State* L) { // item:canReceiveAutoCarpet() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); pushBoolean(L, false); @@ -942,14 +938,14 @@ int ItemFunctions::luaItemCanReceiveAutoCarpet(lua_State* L) { int ItemFunctions::luaItemSetOwner(lua_State* L) { // item:setOwner(creature|creatureId) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); return 0; } if (isUserdata(L, 2)) { - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 2); + const auto &creature = getUserdataShared<Creature>(L, 2); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); return 0; @@ -959,7 +955,7 @@ int ItemFunctions::luaItemSetOwner(lua_State* L) { return 1; } - auto creatureId = getNumber<uint32_t>(L, 2); + const auto creatureId = getNumber<uint32_t>(L, 2); if (creatureId != 0) { item->setOwner(creatureId); pushBoolean(L, true); @@ -972,13 +968,13 @@ int ItemFunctions::luaItemSetOwner(lua_State* L) { int ItemFunctions::luaItemGetOwnerId(lua_State* L) { // item:getOwner() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); return 0; } - if (auto ownerId = item->getOwnerId()) { + if (const auto ownerId = item->getOwnerId()) { lua_pushnumber(L, ownerId); return 1; } @@ -989,14 +985,14 @@ int ItemFunctions::luaItemGetOwnerId(lua_State* L) { int ItemFunctions::luaItemIsOwner(lua_State* L) { // item:isOwner(creature|creatureId) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); return 0; } if (isUserdata(L, 2)) { - std::shared_ptr<Creature> creature = getUserdataShared<Creature>(L, 2); + const auto &creature = getUserdataShared<Creature>(L, 2); if (!creature) { reportErrorFunc(getErrorDesc(LUA_ERROR_PLAYER_NOT_FOUND)); return 0; @@ -1005,7 +1001,7 @@ int ItemFunctions::luaItemIsOwner(lua_State* L) { return 1; } - auto creatureId = getNumber<uint32_t>(L, 2); + const auto creatureId = getNumber<uint32_t>(L, 2); if (creatureId != 0) { pushBoolean(L, item->isOwner(creatureId)); return 1; @@ -1017,13 +1013,13 @@ int ItemFunctions::luaItemIsOwner(lua_State* L) { int ItemFunctions::luaItemGetOwnerName(lua_State* L) { // item:getOwnerName() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); return 0; } - if (auto ownerName = item->getOwnerName(); !ownerName.empty()) { + if (const auto ownerName = item->getOwnerName(); !ownerName.empty()) { pushString(L, ownerName); return 1; } @@ -1034,7 +1030,7 @@ int ItemFunctions::luaItemGetOwnerName(lua_State* L) { int ItemFunctions::luaItemHasOwner(lua_State* L) { // item:hasOwner() - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 1); + const auto &item = getUserdataShared<Item>(L, 1); if (!item) { reportErrorFunc(getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND)); return 1; diff --git a/src/lua/functions/items/item_functions.hpp b/src/lua/functions/items/item_functions.hpp index ab3e91e1648..1cf3764eac8 100644 --- a/src/lua/functions/items/item_functions.hpp +++ b/src/lua/functions/items/item_functions.hpp @@ -17,6 +17,12 @@ class ItemFunctions final : LuaScriptInterface { public: + explicit ItemFunctions(lua_State* L) : + LuaScriptInterface("ItemFunctions") { + init(L); + } + ~ItemFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Item", "", ItemFunctions::luaItemCreate); registerMetaMethod(L, "Item", "__eq", ItemFunctions::luaUserdataCompare); diff --git a/src/lua/functions/items/item_type_functions.cpp b/src/lua/functions/items/item_type_functions.cpp index 333e00bf763..0cf3f4daf00 100644 --- a/src/lua/functions/items/item_type_functions.cpp +++ b/src/lua/functions/items/item_type_functions.cpp @@ -28,7 +28,7 @@ int ItemTypeFunctions::luaItemTypeCreate(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsCorpse(lua_State* L) { // itemType:isCorpse() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isCorpse); } else { @@ -39,7 +39,7 @@ int ItemTypeFunctions::luaItemTypeIsCorpse(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsDoor(lua_State* L) { // itemType:isDoor() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isDoor()); } else { @@ -50,7 +50,7 @@ int ItemTypeFunctions::luaItemTypeIsDoor(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsContainer(lua_State* L) { // itemType:isContainer() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isContainer()); } else { @@ -61,7 +61,7 @@ int ItemTypeFunctions::luaItemTypeIsContainer(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsFluidContainer(lua_State* L) { // itemType:isFluidContainer() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isFluidContainer()); } else { @@ -72,7 +72,7 @@ int ItemTypeFunctions::luaItemTypeIsFluidContainer(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsMovable(lua_State* L) { // itemType:isMovable() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->movable); } else { @@ -83,7 +83,7 @@ int ItemTypeFunctions::luaItemTypeIsMovable(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsRune(lua_State* L) { // itemType:isRune() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isRune()); } else { @@ -94,7 +94,7 @@ int ItemTypeFunctions::luaItemTypeIsRune(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsStackable(lua_State* L) { // itemType:isStackable() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->stackable); } else { @@ -105,7 +105,7 @@ int ItemTypeFunctions::luaItemTypeIsStackable(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsStowable(lua_State* L) { // itemType:isStowable() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->stackable && itemType->wareId > 0); } else { @@ -116,7 +116,7 @@ int ItemTypeFunctions::luaItemTypeIsStowable(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsReadable(lua_State* L) { // itemType:isReadable() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->canReadText); } else { @@ -127,7 +127,7 @@ int ItemTypeFunctions::luaItemTypeIsReadable(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsWritable(lua_State* L) { // itemType:isWritable() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->canWriteText); } else { @@ -138,7 +138,7 @@ int ItemTypeFunctions::luaItemTypeIsWritable(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsBlocking(lua_State* L) { // itemType:isBlocking() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->blockProjectile || itemType->blockSolid); } else { @@ -149,7 +149,7 @@ int ItemTypeFunctions::luaItemTypeIsBlocking(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsGroundTile(lua_State* L) { // itemType:isGroundTile() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isGroundTile()); } else { @@ -160,7 +160,7 @@ int ItemTypeFunctions::luaItemTypeIsGroundTile(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsMagicField(lua_State* L) { // itemType:isMagicField() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isMagicField()); } else { @@ -171,7 +171,7 @@ int ItemTypeFunctions::luaItemTypeIsMagicField(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsMultiUse(lua_State* L) { // itemType:isMultiUse() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isMultiUse()); } else { @@ -182,7 +182,7 @@ int ItemTypeFunctions::luaItemTypeIsMultiUse(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsPickupable(lua_State* L) { // itemType:isPickupable() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isPickupable()); } else { @@ -193,7 +193,7 @@ int ItemTypeFunctions::luaItemTypeIsPickupable(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsKey(lua_State* L) { // itemType:isKey() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isKey()); } else { @@ -204,7 +204,7 @@ int ItemTypeFunctions::luaItemTypeIsKey(lua_State* L) { int ItemTypeFunctions::luaItemTypeIsQuiver(lua_State* L) { // itemType:isQuiver() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->isQuiver()); } else { @@ -215,7 +215,7 @@ int ItemTypeFunctions::luaItemTypeIsQuiver(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetType(lua_State* L) { // itemType:getType() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->type); } else { @@ -226,7 +226,7 @@ int ItemTypeFunctions::luaItemTypeGetType(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetId(lua_State* L) { // itemType:getId() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->id); } else { @@ -237,7 +237,7 @@ int ItemTypeFunctions::luaItemTypeGetId(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetName(lua_State* L) { // itemType:getName() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushString(L, itemType->name); } else { @@ -248,7 +248,7 @@ int ItemTypeFunctions::luaItemTypeGetName(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetPluralName(lua_State* L) { // itemType:getPluralName() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushString(L, itemType->getPluralName()); } else { @@ -259,7 +259,7 @@ int ItemTypeFunctions::luaItemTypeGetPluralName(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetArticle(lua_State* L) { // itemType:getArticle() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushString(L, itemType->article); } else { @@ -270,10 +270,10 @@ int ItemTypeFunctions::luaItemTypeGetArticle(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetDescription(lua_State* L) { // itemType:getDescription([count]) - auto itemType = getUserdata<ItemType>(L, 1); + const auto &itemType = getUserdata<ItemType>(L, 1); if (itemType) { - auto count = getNumber<uint16_t>(L, 2, -1); - auto description = Item::getDescription(*itemType, 1, nullptr, count); + const auto count = getNumber<uint16_t>(L, 2, -1); + const auto description = Item::getDescription(*itemType, 1, nullptr, count); pushString(L, description); } else { lua_pushnil(L); @@ -283,7 +283,7 @@ int ItemTypeFunctions::luaItemTypeGetDescription(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetSlotPosition(lua_State* L) { // itemType:getSlotPosition() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->slotPosition); } else { @@ -294,7 +294,7 @@ int ItemTypeFunctions::luaItemTypeGetSlotPosition(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetCharges(lua_State* L) { // itemType:getCharges() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->charges); } else { @@ -305,7 +305,7 @@ int ItemTypeFunctions::luaItemTypeGetCharges(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetFluidSource(lua_State* L) { // itemType:getFluidSource() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->fluidSource); } else { @@ -316,7 +316,7 @@ int ItemTypeFunctions::luaItemTypeGetFluidSource(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetCapacity(lua_State* L) { // itemType:getCapacity() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->maxItems); } else { @@ -327,35 +327,35 @@ int ItemTypeFunctions::luaItemTypeGetCapacity(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetWeight(lua_State* L) { // itemType:getWeight([count = 1]) - uint16_t count = getNumber<uint16_t>(L, 2, 1); + const auto count = getNumber<uint16_t>(L, 2, 1); - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (!itemType) { lua_pushnil(L); return 1; } - uint64_t weight = static_cast<uint64_t>(itemType->weight) * std::max<int32_t>(1, count); + const uint64_t weight = static_cast<uint64_t>(itemType->weight) * std::max<int32_t>(1, count); lua_pushnumber(L, weight); return 1; } int ItemTypeFunctions::luaItemTypeGetStackSize(lua_State* L) { // itemType:getStackSize() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (!itemType) { lua_pushnil(L); return 1; } - uint64_t stackSize = static_cast<uint64_t>(itemType->stackSize); + const auto stackSize = static_cast<uint64_t>(itemType->stackSize); lua_pushnumber(L, stackSize); return 1; } int ItemTypeFunctions::luaItemTypeGetHitChance(lua_State* L) { // itemType:getHitChance() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->hitChance); } else { @@ -366,7 +366,7 @@ int ItemTypeFunctions::luaItemTypeGetHitChance(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetShootRange(lua_State* L) { // itemType:getShootRange() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->shootRange); } else { @@ -377,7 +377,7 @@ int ItemTypeFunctions::luaItemTypeGetShootRange(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetAttack(lua_State* L) { // itemType:getAttack() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->attack); } else { @@ -388,7 +388,7 @@ int ItemTypeFunctions::luaItemTypeGetAttack(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetDefense(lua_State* L) { // itemType:getDefense() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->defense); } else { @@ -399,7 +399,7 @@ int ItemTypeFunctions::luaItemTypeGetDefense(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetExtraDefense(lua_State* L) { // itemType:getExtraDefense() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->extraDefense); } else { @@ -410,7 +410,7 @@ int ItemTypeFunctions::luaItemTypeGetExtraDefense(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetImbuementSlot(lua_State* L) { // itemType:getImbuementSlot() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->imbuementSlot); } else { @@ -421,7 +421,7 @@ int ItemTypeFunctions::luaItemTypeGetImbuementSlot(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetArmor(lua_State* L) { // itemType:getArmor() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->armor); } else { @@ -432,7 +432,7 @@ int ItemTypeFunctions::luaItemTypeGetArmor(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetWeaponType(lua_State* L) { // itemType:getWeaponType() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->weaponType); } else { @@ -443,7 +443,7 @@ int ItemTypeFunctions::luaItemTypeGetWeaponType(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetAmmoType(lua_State* L) { // itemType:getAmmoType() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->ammoType); } else { @@ -454,7 +454,7 @@ int ItemTypeFunctions::luaItemTypeGetAmmoType(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetElementType(lua_State* L) { // itemType:getElementType() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (!itemType) { lua_pushnil(L); return 1; @@ -471,7 +471,7 @@ int ItemTypeFunctions::luaItemTypeGetElementType(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetElementDamage(lua_State* L) { // itemType:getElementDamage() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (!itemType) { lua_pushnil(L); return 1; @@ -488,7 +488,7 @@ int ItemTypeFunctions::luaItemTypeGetElementDamage(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetTransformEquipId(lua_State* L) { // itemType:getTransformEquipId() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->transformEquipTo); } else { @@ -499,7 +499,7 @@ int ItemTypeFunctions::luaItemTypeGetTransformEquipId(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetTransformDeEquipId(lua_State* L) { // itemType:getTransformDeEquipId() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->transformDeEquipTo); } else { @@ -510,7 +510,7 @@ int ItemTypeFunctions::luaItemTypeGetTransformDeEquipId(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetDestroyId(lua_State* L) { // itemType:getDestroyId() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->destroyTo); } else { @@ -521,7 +521,7 @@ int ItemTypeFunctions::luaItemTypeGetDestroyId(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetDecayId(lua_State* L) { // itemType:getDecayId() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->decayTo); } else { @@ -532,7 +532,7 @@ int ItemTypeFunctions::luaItemTypeGetDecayId(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetRequiredLevel(lua_State* L) { // itemType:getRequiredLevel() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->minReqLevel); } else { @@ -543,7 +543,7 @@ int ItemTypeFunctions::luaItemTypeGetRequiredLevel(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetSpeed(lua_State* L) { // itemType:getSpeed() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (!itemType) { lua_pushnil(L); return 1; @@ -560,7 +560,7 @@ int ItemTypeFunctions::luaItemTypeGetSpeed(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetBaseSpeed(lua_State* L) { // itemType:getBaseSpeed() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->speed); } else { @@ -571,7 +571,7 @@ int ItemTypeFunctions::luaItemTypeGetBaseSpeed(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetDecayTime(lua_State* L) { // itemType:getDecayTime() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->decayTime); } else { @@ -582,7 +582,7 @@ int ItemTypeFunctions::luaItemTypeGetDecayTime(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetShowDuration(lua_State* L) { // itemType:getShowDuration() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushboolean(L, itemType->showDuration); } else { @@ -592,7 +592,7 @@ int ItemTypeFunctions::luaItemTypeGetShowDuration(lua_State* L) { } int ItemTypeFunctions::luaItemTypeGetWrapableTo(lua_State* L) { // itemType:getWrapableTo() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { lua_pushnumber(L, itemType->wrapableTo); } else { @@ -603,7 +603,7 @@ int ItemTypeFunctions::luaItemTypeGetWrapableTo(lua_State* L) { int ItemTypeFunctions::luaItemTypeHasSubType(lua_State* L) { // itemType:hasSubType() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushBoolean(L, itemType->hasSubType()); } else { @@ -614,7 +614,7 @@ int ItemTypeFunctions::luaItemTypeHasSubType(lua_State* L) { int ItemTypeFunctions::luaItemTypeGetVocationString(lua_State* L) { // itemType:getVocationString() - const ItemType* itemType = getUserdata<const ItemType>(L, 1); + const auto* itemType = getUserdata<const ItemType>(L, 1); if (itemType) { pushString(L, itemType->vocationString); } else { diff --git a/src/lua/functions/items/item_type_functions.hpp b/src/lua/functions/items/item_type_functions.hpp index ce53d429804..254831fba56 100644 --- a/src/lua/functions/items/item_type_functions.hpp +++ b/src/lua/functions/items/item_type_functions.hpp @@ -14,6 +14,12 @@ class ItemTypeFunctions final : LuaScriptInterface { public: + explicit ItemTypeFunctions(lua_State* L) : + LuaScriptInterface("ItemTypeFunctions") { + init(L); + } + ~ItemTypeFunctions() override = default; + static void init(lua_State* L) { registerClass(L, "ItemType", "", ItemTypeFunctions::luaItemTypeCreate); registerMetaMethod(L, "ItemType", "__eq", ItemTypeFunctions::luaUserdataCompare); diff --git a/src/lua/functions/items/weapon_functions.cpp b/src/lua/functions/items/weapon_functions.cpp index cd0acf94849..4a02b1c4b29 100644 --- a/src/lua/functions/items/weapon_functions.cpp +++ b/src/lua/functions/items/weapon_functions.cpp @@ -12,17 +12,16 @@ #include "game/game.hpp" #include "items/item.hpp" #include "lua/scripts/lua_environment.hpp" -#include "lua/scripts/scripts.hpp" #include "utils/tools.hpp" int WeaponFunctions::luaCreateWeapon(lua_State* L) { // Weapon(type) - WeaponType_t type = getNumber<WeaponType_t>(L, 2); + const WeaponType_t type = getNumber<WeaponType_t>(L, 2); switch (type) { case WEAPON_SWORD: case WEAPON_AXE: case WEAPON_CLUB: { - if (auto weaponPtr = g_luaEnvironment().createWeaponObject<WeaponMelee>(getScriptEnv()->getScriptInterface())) { + if (const auto &weaponPtr = g_luaEnvironment().createWeaponObject<WeaponMelee>(getScriptEnv()->getScriptInterface())) { pushUserdata<WeaponMelee>(L, weaponPtr); setMetatable(L, -1, "Weapon"); weaponPtr->weaponType = type; @@ -34,7 +33,7 @@ int WeaponFunctions::luaCreateWeapon(lua_State* L) { case WEAPON_MISSILE: case WEAPON_DISTANCE: case WEAPON_AMMO: { - if (auto weaponPtr = g_luaEnvironment().createWeaponObject<WeaponDistance>(getScriptEnv()->getScriptInterface())) { + if (const auto &weaponPtr = g_luaEnvironment().createWeaponObject<WeaponDistance>(getScriptEnv()->getScriptInterface())) { pushUserdata<WeaponDistance>(L, weaponPtr); setMetatable(L, -1, "Weapon"); weaponPtr->weaponType = type; @@ -44,7 +43,7 @@ int WeaponFunctions::luaCreateWeapon(lua_State* L) { break; } case WEAPON_WAND: { - if (auto weaponPtr = g_luaEnvironment().createWeaponObject<WeaponWand>(getScriptEnv()->getScriptInterface())) { + if (const auto &weaponPtr = g_luaEnvironment().createWeaponObject<WeaponWand>(getScriptEnv()->getScriptInterface())) { pushUserdata<WeaponWand>(L, weaponPtr); setMetatable(L, -1, "Weapon"); weaponPtr->weaponType = type; @@ -66,7 +65,7 @@ int WeaponFunctions::luaWeaponAction(lua_State* L) { const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { std::string typeName = getString(L, 2); - std::string tmpStr = asLowerCaseString(typeName); + const std::string tmpStr = asLowerCaseString(typeName); if (tmpStr == "removecount") { weapon->action = WEAPONACTION_REMOVECOUNT; } else if (tmpStr == "removecharge") { @@ -88,7 +87,7 @@ int WeaponFunctions::luaWeaponAction(lua_State* L) { int WeaponFunctions::luaWeaponRegister(lua_State* L) { // weapon:register() - WeaponShared_ptr* weaponPtr = getRawUserDataShared<Weapon>(L, 1); + const WeaponShared_ptr* weaponPtr = getRawUserDataShared<Weapon>(L, 1); if (weaponPtr && *weaponPtr) { WeaponShared_ptr weapon = *weaponPtr; if (weapon->weaponType == WEAPON_DISTANCE || weapon->weaponType == WEAPON_AMMO || weapon->weaponType == WEAPON_MISSILE) { @@ -99,7 +98,7 @@ int WeaponFunctions::luaWeaponRegister(lua_State* L) { weapon = getUserdataShared<WeaponMelee>(L, 1); } - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.weaponType = weapon->weaponType; @@ -268,7 +267,7 @@ int WeaponFunctions::luaWeaponElement(lua_State* L) { if (weapon) { if (!getNumber<CombatType_t>(L, 2)) { std::string element = getString(L, 2); - std::string tmpStrValue = asLowerCaseString(element); + const std::string tmpStrValue = asLowerCaseString(element); if (tmpStrValue == "earth") { weapon->params.combatType = COMBAT_EARTHDAMAGE; } else if (tmpStrValue == "ice") { @@ -364,7 +363,7 @@ int WeaponFunctions::luaWeaponAttack(lua_State* L) { // weapon:attack(atk) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.attack = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -378,7 +377,7 @@ int WeaponFunctions::luaWeaponDefense(lua_State* L) { // weapon:defense(defense[, extraDefense]) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.defense = getNumber<int32_t>(L, 2); if (lua_gettop(L) > 2) { @@ -395,7 +394,7 @@ int WeaponFunctions::luaWeaponRange(lua_State* L) { // weapon:range(range) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.shootRange = getNumber<uint8_t>(L, 2); pushBoolean(L, true); @@ -413,7 +412,7 @@ int WeaponFunctions::luaWeaponCharges(lua_State* L) { if (lua_gettop(L) > 2) { showCharges = getBoolean(L, 3); } - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.charges = getNumber<uint8_t>(L, 2); it.showCharges = showCharges; @@ -432,7 +431,7 @@ int WeaponFunctions::luaWeaponDuration(lua_State* L) { if (lua_gettop(L) > 2) { showDuration = getBoolean(L, 3); } - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.decayTime = getNumber<uint8_t>(L, 2); it.showDuration = showDuration; @@ -451,7 +450,7 @@ int WeaponFunctions::luaWeaponDecayTo(lua_State* L) { if (lua_gettop(L) > 1) { itemid = getNumber<uint16_t>(L, 2); } - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.decayTo = itemid; pushBoolean(L, true); @@ -465,7 +464,7 @@ int WeaponFunctions::luaWeaponTransformEquipTo(lua_State* L) { // weapon:transformEquipTo(itemid) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.transformEquipTo = getNumber<uint16_t>(L, 2); pushBoolean(L, true); @@ -479,7 +478,7 @@ int WeaponFunctions::luaWeaponTransformDeEquipTo(lua_State* L) { // weapon:transformDeEquipTo(itemid) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.transformDeEquipTo = getNumber<uint16_t>(L, 2); pushBoolean(L, true); @@ -493,7 +492,7 @@ int WeaponFunctions::luaWeaponShootType(lua_State* L) { // weapon:shootType(type) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.shootType = getNumber<ShootType_t>(L, 2); pushBoolean(L, true); @@ -507,9 +506,9 @@ int WeaponFunctions::luaWeaponSlotType(lua_State* L) { // weapon:slotType(slot) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); - std::string slot = getString(L, 2); + const std::string slot = getString(L, 2); if (slot == "two-handed") { it.slotPosition = SLOTP_TWO_HAND; @@ -527,7 +526,7 @@ int WeaponFunctions::luaWeaponAmmoType(lua_State* L) { // weapon:ammoType(type) const auto &weapon = getUserdataShared<WeaponDistance>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); std::string type = getString(L, 2); @@ -553,7 +552,7 @@ int WeaponFunctions::luaWeaponHitChance(lua_State* L) { // weapon:hitChance(chance) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.hitChance = getNumber<int8_t>(L, 2); pushBoolean(L, true); @@ -567,7 +566,7 @@ int WeaponFunctions::luaWeaponMaxHitChance(lua_State* L) { // weapon:maxHitChance(max) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); + const uint16_t id = weapon->getID(); ItemType &it = Item::items.getItemType(id); it.maxHitChance = getNumber<int32_t>(L, 2); pushBoolean(L, true); @@ -581,13 +580,13 @@ int WeaponFunctions::luaWeaponExtraElement(lua_State* L) { // weapon:extraElement(atk, combatType) const WeaponShared_ptr &weapon = getUserdataShared<Weapon>(L, 1); if (weapon) { - uint16_t id = weapon->getID(); - ItemType &it = Item::items.getItemType(id); + const uint16_t id = weapon->getID(); + const ItemType &it = Item::items.getItemType(id); it.abilities->elementDamage = getNumber<uint16_t>(L, 2); if (!getNumber<CombatType_t>(L, 3)) { std::string element = getString(L, 3); - std::string tmpStrValue = asLowerCaseString(element); + const std::string tmpStrValue = asLowerCaseString(element); if (tmpStrValue == "earth") { it.abilities->elementType = COMBAT_EARTHDAMAGE; } else if (tmpStrValue == "ice") { diff --git a/src/lua/functions/items/weapon_functions.hpp b/src/lua/functions/items/weapon_functions.hpp index b7ac6fe6aaa..d68146f82bc 100644 --- a/src/lua/functions/items/weapon_functions.hpp +++ b/src/lua/functions/items/weapon_functions.hpp @@ -13,6 +13,12 @@ class WeaponFunctions final : LuaScriptInterface { public: + explicit WeaponFunctions(lua_State* L) : + LuaScriptInterface("WeaponFunctions") { + init(L); + } + ~WeaponFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Weapon", "", WeaponFunctions::luaCreateWeapon); registerMethod(L, "Weapon", "action", WeaponFunctions::luaWeaponAction); diff --git a/src/lua/functions/lua_functions_loader.cpp b/src/lua/functions/lua_functions_loader.cpp index ad52431a661..9d12b2ca97c 100644 --- a/src/lua/functions/lua_functions_loader.cpp +++ b/src/lua/functions/lua_functions_loader.cpp @@ -96,11 +96,11 @@ int LuaFunctionsLoader::protectedCall(lua_State* L, int nargs, int nresults) { return ret; } - int error_index = lua_gettop(L) - nargs; + const int error_index = lua_gettop(L) - nargs; lua_pushcfunction(L, luaErrorHandler); lua_insert(L, error_index); - int ret = lua_pcall(L, nargs, nresults, error_index); + const int ret = lua_pcall(L, nargs, nresults, error_index); lua_remove(L, error_index); return ret; } @@ -132,7 +132,7 @@ void LuaFunctionsLoader::reportError(const char* function, const std::string &er } logMsg << "Error Description: " << error_desc << "\n"; if (stack_trace && scriptInterface) { - std::string stackTrace = scriptInterface->getStackTrace(error_desc); + const std::string stackTrace = scriptInterface->getStackTrace(error_desc); if (!stackTrace.empty() && stackTrace != "N/A") { logMsg << "Stack Trace:\n" << stackTrace << "\n"; @@ -145,7 +145,7 @@ void LuaFunctionsLoader::reportError(const char* function, const std::string &er int LuaFunctionsLoader::luaErrorHandler(lua_State* L) { const std::string &errorMessage = popString(L); - auto interface = getScriptEnv()->getScriptInterface(); + const auto interface = getScriptEnv()->getScriptInterface(); if (!interface) { g_logger().error("[{}]: LuaScriptInterface not found, error: {}", __FUNCTION__, errorMessage); return 0; @@ -184,7 +184,7 @@ void LuaFunctionsLoader::pushVariant(lua_State* L, const LuaVariant &var) { setMetatable(L, -1, "Variant"); } -void LuaFunctionsLoader::pushThing(lua_State* L, std::shared_ptr<Thing> thing) { +void LuaFunctionsLoader::pushThing(lua_State* L, const std::shared_ptr<Thing> &thing) { if (validateDispatcherContext(__FUNCTION__)) { return; } @@ -198,10 +198,10 @@ void LuaFunctionsLoader::pushThing(lua_State* L, std::shared_ptr<Thing> thing) { return; } - if (std::shared_ptr<Item> item = thing->getItem()) { + if (const auto &item = thing->getItem()) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); - } else if (std::shared_ptr<Creature> creature = thing->getCreature()) { + } else if (const auto &creature = thing->getCreature()) { pushUserdata<Creature>(L, creature); setCreatureMetatable(L, -1, creature); } else { @@ -209,18 +209,18 @@ void LuaFunctionsLoader::pushThing(lua_State* L, std::shared_ptr<Thing> thing) { } } -void LuaFunctionsLoader::pushCylinder(lua_State* L, std::shared_ptr<Cylinder> cylinder) { +void LuaFunctionsLoader::pushCylinder(lua_State* L, const std::shared_ptr<Cylinder> &cylinder) { if (validateDispatcherContext(__FUNCTION__)) { return; } - if (std::shared_ptr<Creature> creature = cylinder->getCreature()) { + if (const auto &creature = cylinder->getCreature()) { pushUserdata<Creature>(L, creature); setCreatureMetatable(L, -1, creature); - } else if (std::shared_ptr<Item> parentItem = cylinder->getItem()) { + } else if (const auto &parentItem = cylinder->getItem()) { pushUserdata<Item>(L, parentItem); setItemMetatable(L, -1, parentItem); - } else if (std::shared_ptr<Tile> tile = cylinder->getTile()) { + } else if (const auto &tile = cylinder->getTile()) { pushUserdata<Tile>(L, tile); setMetatable(L, -1, "Tile"); } else if (cylinder == VirtualCylinder::virtualCylinder) { @@ -248,7 +248,7 @@ void LuaFunctionsLoader::pushCallback(lua_State* L, int32_t callback) { std::string LuaFunctionsLoader::popString(lua_State* L) { if (lua_gettop(L) == 0) { - return std::string(); + return {}; } std::string str(getString(L, -1)); @@ -278,13 +278,13 @@ void LuaFunctionsLoader::setWeakMetatable(lua_State* L, int32_t index, const std const std::string &weakName = name + "_weak"; - auto result = weakObjectTypes.emplace(name); + const auto result = weakObjectTypes.emplace(name); if (result.second) { luaL_getmetatable(L, name.c_str()); - int childMetatable = lua_gettop(L); + const int childMetatable = lua_gettop(L); luaL_newmetatable(L, weakName.c_str()); - int metatable = lua_gettop(L); + const int metatable = lua_gettop(L); for (static const std::vector<std::string> methodKeys = { "__index", "__metatable", "__eq" }; const std::string &metaKey : methodKeys) { @@ -293,7 +293,7 @@ void LuaFunctionsLoader::setWeakMetatable(lua_State* L, int32_t index, const std } for (static const std::vector<int> methodIndexes = { 'h', 'p', 't' }; - int metaIndex : methodIndexes) { + const int metaIndex : methodIndexes) { lua_rawgeti(L, childMetatable, metaIndex); lua_rawseti(L, metatable, metaIndex); } @@ -308,7 +308,7 @@ void LuaFunctionsLoader::setWeakMetatable(lua_State* L, int32_t index, const std lua_setmetatable(L, index - 1); } -void LuaFunctionsLoader::setItemMetatable(lua_State* L, int32_t index, std::shared_ptr<Item> item) { +void LuaFunctionsLoader::setItemMetatable(lua_State* L, int32_t index, const std::shared_ptr<Item> &item) { if (validateDispatcherContext(__FUNCTION__)) { return; } @@ -323,7 +323,7 @@ void LuaFunctionsLoader::setItemMetatable(lua_State* L, int32_t index, std::shar lua_setmetatable(L, index - 1); } -void LuaFunctionsLoader::setCreatureMetatable(lua_State* L, int32_t index, std::shared_ptr<Creature> creature) { +void LuaFunctionsLoader::setCreatureMetatable(lua_State* L, int32_t index, const std::shared_ptr<Creature> &creature) { if (validateDispatcherContext(__FUNCTION__)) { return; } @@ -351,8 +351,8 @@ CombatDamage LuaFunctionsLoader::getCombatDamage(lua_State* L) { // Get std::string LuaFunctionsLoader::getFormatedLoggerMessage(lua_State* L) { - std::string format = getString(L, 1); - int n = lua_gettop(L); + const std::string format = getString(L, 1); + const int n = lua_gettop(L); fmt::dynamic_format_arg_store<fmt::format_context> args; for (int i = 2; i <= n; i++) { @@ -363,7 +363,7 @@ std::string LuaFunctionsLoader::getFormatedLoggerMessage(lua_State* L) { } else if (isBoolean(L, i)) { args.push_back(lua_toboolean(L, i) ? "true" : "false"); } else if (isUserdata(L, i)) { - LuaData_t userType = getUserdataType(L, i); + const LuaData_t userType = getUserdataType(L, i); args.push_back(getUserdataTypeName(userType)); } else if (isTable(L, i)) { args.push_back("table"); @@ -390,7 +390,7 @@ std::string LuaFunctionsLoader::getString(lua_State* L, int32_t arg) { size_t len; const char* c_str = lua_tolstring(L, arg, &len); if (!c_str || len == 0) { - return std::string(); + return {}; } return std::string(c_str, len); } @@ -554,7 +554,7 @@ LuaData_t LuaFunctionsLoader::getUserdataType(lua_State* L, int32_t arg) { } lua_rawgeti(L, -1, 't'); - LuaData_t type = getNumber<LuaData_t>(L, -1); + const LuaData_t type = getNumber<LuaData_t>(L, -1); lua_pop(L, 2); return type; @@ -643,11 +643,11 @@ void LuaFunctionsLoader::registerClass(lua_State* L, const std::string &classNam lua_newtable(L); lua_pushvalue(L, -1); lua_setglobal(L, className.c_str()); - int methods = lua_gettop(L); + const int methods = lua_gettop(L); // methodsTable = {} lua_newtable(L); - int methodsTable = lua_gettop(L); + const int methodsTable = lua_gettop(L); if (newFunction) { // className.__call = newFunction @@ -669,7 +669,7 @@ void LuaFunctionsLoader::registerClass(lua_State* L, const std::string &classNam // className.metatable = {} luaL_newmetatable(L, className.c_str()); - int metatable = lua_gettop(L); + const int metatable = lua_gettop(L); // className.metatable.__metatable = className lua_pushvalue(L, methods); @@ -779,7 +779,7 @@ void LuaFunctionsLoader::registerSharedClass(lua_State* L, const std::string &cl } int LuaFunctionsLoader::luaGarbageCollection(lua_State* L) { - auto objPtr = static_cast<std::shared_ptr<SharedObject>*>(lua_touserdata(L, 1)); + const auto objPtr = static_cast<std::shared_ptr<SharedObject>*>(lua_touserdata(L, 1)); if (objPtr) { objPtr->reset(); } @@ -787,7 +787,7 @@ int LuaFunctionsLoader::luaGarbageCollection(lua_State* L) { } int LuaFunctionsLoader::validateDispatcherContext(std::string_view fncName) { - if (g_dispatcher().context().isOn() && g_dispatcher().context().isAsync()) { + if (DispatcherContext::isOn() && g_dispatcher().context().isAsync()) { g_logger().warn("[{}] The call to lua was ignored because the '{}' task is trying to communicate while in async mode.", fncName, g_dispatcher().context().getName()); return LUA_ERRRUN; } diff --git a/src/lua/functions/lua_functions_loader.hpp b/src/lua/functions/lua_functions_loader.hpp index e5251e3a1c3..9c5b65c14bb 100644 --- a/src/lua/functions/lua_functions_loader.hpp +++ b/src/lua/functions/lua_functions_loader.hpp @@ -39,11 +39,11 @@ class LuaFunctionsLoader { static void reportError(const char* function, const std::string &error_desc, bool stack_trace = false); static int luaErrorHandler(lua_State* L); - static void pushThing(lua_State* L, std::shared_ptr<Thing> thing); + static void pushThing(lua_State* L, const std::shared_ptr<Thing> &thing); static void pushVariant(lua_State* L, const LuaVariant &var); static void pushString(lua_State* L, const std::string &value); static void pushCallback(lua_State* L, int32_t callback); - static void pushCylinder(lua_State* L, std::shared_ptr<Cylinder> cylinder); + static void pushCylinder(lua_State* L, const std::shared_ptr<Cylinder> &cylinder); static std::string popString(lua_State* L); static int32_t popCallback(lua_State* L); @@ -56,16 +56,16 @@ class LuaFunctionsLoader { static void setMetatable(lua_State* L, int32_t index, const std::string &name); static void setWeakMetatable(lua_State* L, int32_t index, const std::string &name); - static void setItemMetatable(lua_State* L, int32_t index, std::shared_ptr<Item> item); - static void setCreatureMetatable(lua_State* L, int32_t index, std::shared_ptr<Creature> creature); + static void setItemMetatable(lua_State* L, int32_t index, const std::shared_ptr<Item> &item); + static void setCreatureMetatable(lua_State* L, int32_t index, const std::shared_ptr<Creature> &creature); template <typename T> - static typename std::enable_if<std::is_enum<T>::value, T>::type + static std::enable_if_t<std::is_enum_v<T>, T> getNumber(lua_State* L, int32_t arg) { return static_cast<T>(static_cast<int64_t>(lua_tonumber(L, arg))); } template <typename T> - static typename std::enable_if<std::is_integral<T>::value || std::is_floating_point<T>::value, T>::type getNumber(lua_State* L, int32_t arg) { + static std::enable_if_t<std::is_integral_v<T> || std::is_floating_point_v<T>, T> getNumber(lua_State* L, int32_t arg) { auto number = lua_tonumber(L, arg); // If there is overflow, we return the value 0 if constexpr (std::is_integral_v<T> && std::is_unsigned_v<T>) { diff --git a/src/lua/functions/map/house_functions.cpp b/src/lua/functions/map/house_functions.cpp index 597eec3975e..a07c2dbc5c1 100644 --- a/src/lua/functions/map/house_functions.cpp +++ b/src/lua/functions/map/house_functions.cpp @@ -114,8 +114,8 @@ int HouseFunctions::luaHouseSetHouseOwner(lua_State* L) { return 1; } - uint32_t guid = getNumber<uint32_t>(L, 2); - bool updateDatabase = getBoolean(L, 3, true); + const uint32_t guid = getNumber<uint32_t>(L, 2); + const bool updateDatabase = getBoolean(L, 3, true); house->setOwner(guid, updateDatabase); pushBoolean(L, true); return 1; @@ -123,11 +123,11 @@ int HouseFunctions::luaHouseSetHouseOwner(lua_State* L) { int HouseFunctions::luaHouseSetNewOwnerGuid(lua_State* L) { // house:setNewOwnerGuid(guid[, updateDatabase = true]) - auto house = getUserdataShared<House>(L, 1); + const auto &house = getUserdataShared<House>(L, 1); if (house) { auto isTransferOnRestart = g_configManager().getBoolean(TOGGLE_HOUSE_TRANSFER_ON_SERVER_RESTART); if (isTransferOnRestart && house->hasNewOwnership()) { - const auto player = g_game().getPlayerByGUID(house->getOwner()); + const auto &player = g_game().getPlayerByGUID(house->getOwner()); if (player) { player->sendTextMessage(MESSAGE_EVENT_ADVANCE, "You cannot leave this house. Ownership is already scheduled to be transferred upon the next server restart."); } @@ -135,7 +135,7 @@ int HouseFunctions::luaHouseSetNewOwnerGuid(lua_State* L) { return 1; } - uint32_t guid = getNumber<uint32_t>(L, 2, 0); + const auto guid = getNumber<uint32_t>(L, 2, 0); house->setNewOwnerGuid(guid, false); pushBoolean(L, true); } else { @@ -146,7 +146,7 @@ int HouseFunctions::luaHouseSetNewOwnerGuid(lua_State* L) { int HouseFunctions::luaHouseHasItemOnTile(lua_State* L) { // house:hasItemOnTile() - auto house = getUserdataShared<House>(L, 1); + const auto &house = getUserdataShared<House>(L, 1); if (!house) { reportErrorFunc("House not found"); lua_pushnil(L); @@ -159,7 +159,7 @@ int HouseFunctions::luaHouseHasItemOnTile(lua_State* L) { int HouseFunctions::luaHouseHasNewOwnership(lua_State* L) { // house:hasNewOwnership(guid) - auto house = getUserdataShared<House>(L, 1); + const auto &house = getUserdataShared<House>(L, 1); if (!house) { reportErrorFunc("House not found"); lua_pushnil(L); @@ -174,8 +174,8 @@ int HouseFunctions::luaHouseHasNewOwnership(lua_State* L) { int HouseFunctions::luaHouseStartTrade(lua_State* L) { // house:startTrade(player, tradePartner) const auto &house = getUserdataShared<House>(L, 1); - std::shared_ptr<Player> player = getUserdataShared<Player>(L, 2); - std::shared_ptr<Player> tradePartner = getUserdataShared<Player>(L, 3); + const auto &player = getUserdataShared<Player>(L, 2); + const auto &tradePartner = getUserdataShared<Player>(L, 3); if (!player || !tradePartner || !house) { lua_pushnil(L); @@ -202,7 +202,7 @@ int HouseFunctions::luaHouseStartTrade(lua_State* L) { return 1; } - std::shared_ptr<Item> transferItem = house->getTransferItem(); + const auto &transferItem = house->getTransferItem(); if (!transferItem) { lua_pushnumber(L, RETURNVALUE_YOUCANNOTTRADETHISHOUSE); return 1; @@ -233,11 +233,11 @@ int HouseFunctions::luaHouseGetBeds(lua_State* L) { return 1; } - const auto beds = house->getBeds(); + const auto &beds = house->getBeds(); lua_createtable(L, beds.size(), 0); int index = 0; - for (std::shared_ptr<BedItem> bedItem : beds) { + for (const auto &bedItem : beds) { pushUserdata<Item>(L, bedItem); setItemMetatable(L, -1, bedItem); lua_rawseti(L, -2, ++index); @@ -263,11 +263,11 @@ int HouseFunctions::luaHouseGetDoors(lua_State* L) { return 1; } - const auto doors = house->getDoors(); + const auto &doors = house->getDoors(); lua_createtable(L, doors.size(), 0); int index = 0; - for (std::shared_ptr<Door> door : doors) { + for (const auto &door : doors) { pushUserdata<Item>(L, door); setItemMetatable(L, -1, door); lua_rawseti(L, -2, ++index); @@ -293,7 +293,7 @@ int HouseFunctions::luaHouseGetDoorIdByPosition(lua_State* L) { return 1; } - std::shared_ptr<Door> door = house->getDoorByPosition(getPosition(L, 2)); + const auto &door = house->getDoorByPosition(getPosition(L, 2)); if (door) { lua_pushnumber(L, door->getDoorId()); } else { @@ -310,11 +310,11 @@ int HouseFunctions::luaHouseGetTiles(lua_State* L) { return 1; } - const auto tiles = house->getTiles(); + const auto &tiles = house->getTiles(); lua_newtable(L); int index = 0; - for (std::shared_ptr<Tile> tile : tiles) { + for (const auto &tile : tiles) { pushUserdata<Tile>(L, tile); setMetatable(L, -1, "Tile"); lua_rawseti(L, -2, ++index); @@ -330,14 +330,14 @@ int HouseFunctions::luaHouseGetItems(lua_State* L) { return 1; } - const auto tiles = house->getTiles(); + const auto &tiles = house->getTiles(); lua_newtable(L); int index = 0; - for (std::shared_ptr<Tile> tile : tiles) { - TileItemVector* itemVector = tile->getItemList(); + for (const auto &tile : tiles) { + const TileItemVector* itemVector = tile->getItemList(); if (itemVector) { - for (auto &item : *itemVector) { + for (const auto &item : *itemVector) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); lua_rawseti(L, -2, ++index); @@ -365,7 +365,7 @@ int HouseFunctions::luaHouseCanEditAccessList(lua_State* L) { return 1; } - uint32_t listId = getNumber<uint32_t>(L, 2); + const uint32_t listId = getNumber<uint32_t>(L, 2); const auto &player = getPlayer(L, 3); if (!player) { @@ -386,7 +386,7 @@ int HouseFunctions::luaHouseGetAccessList(lua_State* L) { } std::string list; - uint32_t listId = getNumber<uint32_t>(L, 2); + const uint32_t listId = getNumber<uint32_t>(L, 2); if (house->getAccessList(listId, list)) { pushString(L, list); } else { @@ -403,7 +403,7 @@ int HouseFunctions::luaHouseSetAccessList(lua_State* L) { return 1; } - uint32_t listId = getNumber<uint32_t>(L, 2); + const uint32_t listId = getNumber<uint32_t>(L, 2); const std::string &list = getString(L, 3); house->setAccessList(listId, list); pushBoolean(L, true); @@ -424,7 +424,7 @@ int HouseFunctions::luaHouseKickPlayer(lua_State* L) { return 1; } - auto targetPlayer = getPlayer(L, 3); + const auto &targetPlayer = getPlayer(L, 3); if (!targetPlayer) { reportErrorFunc("Target player is nullptr"); return 1; diff --git a/src/lua/functions/map/house_functions.hpp b/src/lua/functions/map/house_functions.hpp index ede7e1f0998..8d527bf6354 100644 --- a/src/lua/functions/map/house_functions.hpp +++ b/src/lua/functions/map/house_functions.hpp @@ -13,6 +13,12 @@ class HouseFunctions final : LuaScriptInterface { public: + explicit HouseFunctions(lua_State* L) : + LuaScriptInterface("HouseFunctions") { + init(L); + } + ~HouseFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "House", "", HouseFunctions::luaHouseCreate); registerMetaMethod(L, "House", "__eq", HouseFunctions::luaUserdataCompare); diff --git a/src/lua/functions/map/map_functions.hpp b/src/lua/functions/map/map_functions.hpp index 43b025c9155..c89ee760d39 100644 --- a/src/lua/functions/map/map_functions.hpp +++ b/src/lua/functions/map/map_functions.hpp @@ -18,6 +18,12 @@ class MapFunctions final : LuaScriptInterface { public: + explicit MapFunctions(lua_State* L) : + LuaScriptInterface("MapFunctions") { + init(L); + } + ~MapFunctions() override = default; + static void init(lua_State* L) { HouseFunctions::init(L); PositionFunctions::init(L); @@ -25,6 +31,4 @@ class MapFunctions final : LuaScriptInterface { TileFunctions::init(L); TownFunctions::init(L); } - -private: }; diff --git a/src/lua/functions/map/position_functions.cpp b/src/lua/functions/map/position_functions.cpp index 06dc2219965..725dbb339a6 100644 --- a/src/lua/functions/map/position_functions.cpp +++ b/src/lua/functions/map/position_functions.cpp @@ -25,9 +25,9 @@ int PositionFunctions::luaPositionCreate(lua_State* L) { const Position &position = getPosition(L, 2, stackpos); pushPosition(L, position, stackpos); } else { - uint16_t x = getNumber<uint16_t>(L, 2, 0); - uint16_t y = getNumber<uint16_t>(L, 3, 0); - uint8_t z = getNumber<uint8_t>(L, 4, 0); + const auto x = getNumber<uint16_t>(L, 2, 0); + const auto y = getNumber<uint16_t>(L, 3, 0); + const auto z = getNumber<uint8_t>(L, 4, 0); stackpos = getNumber<int32_t>(L, 5, 0); pushPosition(L, Position(x, y, z), stackpos); @@ -100,7 +100,7 @@ int PositionFunctions::luaPositionGetPathTo(lua_State* L) { lua_newtable(L); int index = 0; - for (Direction dir : dirList) { + for (const Direction dir : dirList) { lua_pushnumber(L, dir); lua_rawseti(L, -2, ++index); } @@ -112,7 +112,7 @@ int PositionFunctions::luaPositionGetPathTo(lua_State* L) { int PositionFunctions::luaPositionIsSightClear(lua_State* L) { // position:isSightClear(positionEx[, sameFloor = true]) - bool sameFloor = getBoolean(L, 3, true); + const bool sameFloor = getBoolean(L, 3, true); const Position &positionEx = getPosition(L, 2); const Position &position = getPosition(L, 1); pushBoolean(L, g_game().isSightClear(position, positionEx, sameFloor)); @@ -129,13 +129,13 @@ int PositionFunctions::luaPositionGetTile(lua_State* L) { int PositionFunctions::luaPositionGetZones(lua_State* L) { // position:getZones() const Position &position = getPosition(L, 1); - auto tile = g_game().map.getTile(position); + const auto &tile = g_game().map.getTile(position); if (tile == nullptr) { lua_pushnil(L); return 1; } int index = 0; - for (auto zone : tile->getZones()) { + for (const auto &zone : tile->getZones()) { index++; pushUserdata<Zone>(L, zone); setMetatable(L, -1, "Zone"); @@ -219,7 +219,7 @@ int PositionFunctions::luaPositionSendDistanceEffect(lua_State* L) { spectators.emplace_back(player); } - ShootType_t distanceEffect = getNumber<ShootType_t>(L, 3); + const ShootType_t distanceEffect = getNumber<ShootType_t>(L, 3); const Position &positionEx = getPosition(L, 2); const Position &position = getPosition(L, 1); if (g_configManager().getBoolean(WARN_UNSAFE_SCRIPTS) && !g_game().isDistanceEffectRegistered(distanceEffect)) { @@ -240,8 +240,8 @@ int PositionFunctions::luaPositionSendDistanceEffect(lua_State* L) { int PositionFunctions::luaPositionSendSingleSoundEffect(lua_State* L) { // position:sendSingleSoundEffect(soundId[, actor = nullptr]) const Position &position = getPosition(L, 1); - SoundEffect_t soundEffect = getNumber<SoundEffect_t>(L, 2); - std::shared_ptr<Creature> actor = getCreature(L, 3); + const SoundEffect_t soundEffect = getNumber<SoundEffect_t>(L, 2); + const auto actor = getCreature(L, 3); g_game().sendSingleSoundEffect(position, soundEffect, actor); pushBoolean(L, true); @@ -251,9 +251,9 @@ int PositionFunctions::luaPositionSendSingleSoundEffect(lua_State* L) { int PositionFunctions::luaPositionSendDoubleSoundEffect(lua_State* L) { // position:sendDoubleSoundEffect(mainSoundId, secondarySoundId[, actor = nullptr]) const Position &position = getPosition(L, 1); - SoundEffect_t mainSoundEffect = getNumber<SoundEffect_t>(L, 2); - SoundEffect_t secondarySoundEffect = getNumber<SoundEffect_t>(L, 3); - std::shared_ptr<Creature> actor = getCreature(L, 4); + const SoundEffect_t mainSoundEffect = getNumber<SoundEffect_t>(L, 2); + const SoundEffect_t secondarySoundEffect = getNumber<SoundEffect_t>(L, 3); + const auto &actor = getCreature(L, 4); g_game().sendDoubleSoundEffect(position, mainSoundEffect, secondarySoundEffect, actor); pushBoolean(L, true); diff --git a/src/lua/functions/map/position_functions.hpp b/src/lua/functions/map/position_functions.hpp index 095ec0667c7..4bb6917aecc 100644 --- a/src/lua/functions/map/position_functions.hpp +++ b/src/lua/functions/map/position_functions.hpp @@ -13,8 +13,14 @@ class PositionFunctions final : LuaScriptInterface { public: + explicit PositionFunctions(lua_State* L) : + LuaScriptInterface("PositionFunctions") { + init(L); + } + ~PositionFunctions() override = default; + static void init(lua_State* L) { - registerClass(L, "Position", "", PositionFunctions::luaPositionCreate); + registerSharedClass(L, "Position", "", PositionFunctions::luaPositionCreate); registerMetaMethod(L, "Position", "__add", PositionFunctions::luaPositionAdd); registerMetaMethod(L, "Position", "__sub", PositionFunctions::luaPositionSub); registerMetaMethod(L, "Position", "__eq", PositionFunctions::luaPositionCompare); diff --git a/src/lua/functions/map/teleport_functions.cpp b/src/lua/functions/map/teleport_functions.cpp index 5a5a25a20e6..3a7b397f24c 100644 --- a/src/lua/functions/map/teleport_functions.cpp +++ b/src/lua/functions/map/teleport_functions.cpp @@ -14,9 +14,9 @@ // Teleport int TeleportFunctions::luaTeleportCreate(lua_State* L) { // Teleport(uid) - uint32_t id = getNumber<uint32_t>(L, 2); + const uint32_t id = getNumber<uint32_t>(L, 2); - std::shared_ptr<Item> item = getScriptEnv()->getItemByUID(id); + const auto &item = getScriptEnv()->getItemByUID(id); if (item && item->getTeleport()) { pushUserdata(L, item); setMetatable(L, -1, "Teleport"); @@ -28,7 +28,7 @@ int TeleportFunctions::luaTeleportCreate(lua_State* L) { int TeleportFunctions::luaTeleportGetDestination(lua_State* L) { // teleport:getDestination() - std::shared_ptr<Teleport> teleport = getUserdataShared<Teleport>(L, 1); + const auto &teleport = getUserdataShared<Teleport>(L, 1); if (teleport) { pushPosition(L, teleport->getDestPos()); } else { @@ -39,7 +39,7 @@ int TeleportFunctions::luaTeleportGetDestination(lua_State* L) { int TeleportFunctions::luaTeleportSetDestination(lua_State* L) { // teleport:setDestination(position) - std::shared_ptr<Teleport> teleport = getUserdataShared<Teleport>(L, 1); + const auto &teleport = getUserdataShared<Teleport>(L, 1); if (teleport) { teleport->setDestPos(getPosition(L, 2)); pushBoolean(L, true); diff --git a/src/lua/functions/map/teleport_functions.hpp b/src/lua/functions/map/teleport_functions.hpp index 152cf8f0d9e..57f59a70315 100644 --- a/src/lua/functions/map/teleport_functions.hpp +++ b/src/lua/functions/map/teleport_functions.hpp @@ -13,6 +13,12 @@ class TeleportFunctions final : LuaScriptInterface { public: + explicit TeleportFunctions(lua_State* L) : + LuaScriptInterface("TeleportFunctions") { + init(L); + } + ~TeleportFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Teleport", "Item", TeleportFunctions::luaTeleportCreate); registerMetaMethod(L, "Teleport", "__eq", TeleportFunctions::luaUserdataCompare); diff --git a/src/lua/functions/map/tile_functions.cpp b/src/lua/functions/map/tile_functions.cpp index 8ff44064079..b201d47fb09 100644 --- a/src/lua/functions/map/tile_functions.cpp +++ b/src/lua/functions/map/tile_functions.cpp @@ -17,9 +17,9 @@ int TileFunctions::luaTileCreate(lua_State* L) { if (isTable(L, 2)) { tile = g_game().map.getTile(getPosition(L, 2)); } else { - uint8_t z = getNumber<uint8_t>(L, 4); - uint16_t y = getNumber<uint16_t>(L, 3); - uint16_t x = getNumber<uint16_t>(L, 2); + const uint8_t z = getNumber<uint8_t>(L, 4); + const uint16_t y = getNumber<uint16_t>(L, 3); + const uint16_t x = getNumber<uint16_t>(L, 2); tile = g_game().map.getTile(x, y, z); } @@ -34,7 +34,7 @@ int TileFunctions::luaTileCreate(lua_State* L) { int TileFunctions::luaTileGetPosition(lua_State* L) { // tile:getPosition() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (tile) { pushPosition(L, tile->getPosition()); } else { @@ -45,7 +45,7 @@ int TileFunctions::luaTileGetPosition(lua_State* L) { int TileFunctions::luaTileGetGround(lua_State* L) { // tile:getGround() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (tile && tile->getGround()) { pushUserdata<Item>(L, tile->getGround()); setItemMetatable(L, -1, tile->getGround()); @@ -57,23 +57,23 @@ int TileFunctions::luaTileGetGround(lua_State* L) { int TileFunctions::luaTileGetThing(lua_State* L) { // tile:getThing(index) - int32_t index = getNumber<int32_t>(L, 2); - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const int32_t index = getNumber<int32_t>(L, 2); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Thing> thing = tile->getThing(index); + const auto &thing = tile->getThing(index); if (!thing) { lua_pushnil(L); return 1; } - if (std::shared_ptr<Creature> creature = thing->getCreature()) { + if (const auto &creature = thing->getCreature()) { pushUserdata<Creature>(L, creature); setCreatureMetatable(L, -1, creature); - } else if (std::shared_ptr<Item> item = thing->getItem()) { + } else if (const auto &item = thing->getItem()) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); } else { @@ -84,7 +84,7 @@ int TileFunctions::luaTileGetThing(lua_State* L) { int TileFunctions::luaTileGetThingCount(lua_State* L) { // tile:getThingCount() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (tile) { lua_pushnumber(L, tile->getThingCount()); } else { @@ -95,23 +95,23 @@ int TileFunctions::luaTileGetThingCount(lua_State* L) { int TileFunctions::luaTileGetTopVisibleThing(lua_State* L) { // tile:getTopVisibleThing(creature) - std::shared_ptr<Creature> creature = getCreature(L, 2); - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &creature = getCreature(L, 2); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Thing> thing = tile->getTopVisibleThing(creature); + const auto &thing = tile->getTopVisibleThing(creature); if (!thing) { lua_pushnil(L); return 1; } - if (std::shared_ptr<Creature> visibleCreature = thing->getCreature()) { + if (const auto &visibleCreature = thing->getCreature()) { pushUserdata<Creature>(L, visibleCreature); setCreatureMetatable(L, -1, visibleCreature); - } else if (std::shared_ptr<Item> visibleItem = thing->getItem()) { + } else if (const auto &visibleItem = thing->getItem()) { pushUserdata<Item>(L, visibleItem); setItemMetatable(L, -1, visibleItem); } else { @@ -122,13 +122,13 @@ int TileFunctions::luaTileGetTopVisibleThing(lua_State* L) { int TileFunctions::luaTileGetTopTopItem(lua_State* L) { // tile:getTopTopItem() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = tile->getTopTopItem(); + const auto &item = tile->getTopTopItem(); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -140,13 +140,13 @@ int TileFunctions::luaTileGetTopTopItem(lua_State* L) { int TileFunctions::luaTileGetTopDownItem(lua_State* L) { // tile:getTopDownItem() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = tile->getTopDownItem(); + const auto &item = tile->getTopDownItem(); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -158,13 +158,13 @@ int TileFunctions::luaTileGetTopDownItem(lua_State* L) { int TileFunctions::luaTileGetFieldItem(lua_State* L) { // tile:getFieldItem() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Item> item = tile->getFieldItem(); + const auto &item = tile->getFieldItem(); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -176,7 +176,7 @@ int TileFunctions::luaTileGetFieldItem(lua_State* L) { int TileFunctions::luaTileGetItemById(lua_State* L) { // tile:getItemById(itemId[, subType = -1]) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -192,9 +192,9 @@ int TileFunctions::luaTileGetItemById(lua_State* L) { return 1; } } - int32_t subType = getNumber<int32_t>(L, 3, -1); + const auto subType = getNumber<int32_t>(L, 3, -1); - std::shared_ptr<Item> item = g_game().findItemOfType(tile, itemId, false, subType); + const auto &item = g_game().findItemOfType(tile, itemId, false, subType); if (item) { pushUserdata<Item>(L, item); setItemMetatable(L, -1, item); @@ -206,7 +206,7 @@ int TileFunctions::luaTileGetItemById(lua_State* L) { int TileFunctions::luaTileGetItemByType(lua_State* L) { // tile:getItemByType(itemType) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -214,7 +214,7 @@ int TileFunctions::luaTileGetItemByType(lua_State* L) { bool found; - ItemTypes_t itemType = getNumber<ItemTypes_t>(L, 2); + const ItemTypes_t itemType = getNumber<ItemTypes_t>(L, 2); switch (itemType) { case ITEM_TYPE_TELEPORT: found = tile->hasFlag(TILESTATE_TELEPORT); @@ -244,7 +244,7 @@ int TileFunctions::luaTileGetItemByType(lua_State* L) { return 1; } - if (std::shared_ptr<Item> item = tile->getGround()) { + if (const auto &item = tile->getGround()) { const ItemType &it = Item::items[item->getID()]; if (it.type == itemType) { pushUserdata<Item>(L, item); @@ -270,15 +270,15 @@ int TileFunctions::luaTileGetItemByType(lua_State* L) { int TileFunctions::luaTileGetItemByTopOrder(lua_State* L) { // tile:getItemByTopOrder(topOrder) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - int32_t topOrder = getNumber<int32_t>(L, 2); + const int32_t topOrder = getNumber<int32_t>(L, 2); - std::shared_ptr<Item> item = tile->getItemByTopOrder(topOrder); + const auto &item = tile->getItemByTopOrder(topOrder); if (!item) { lua_pushnil(L); return 1; @@ -291,13 +291,13 @@ int TileFunctions::luaTileGetItemByTopOrder(lua_State* L) { int TileFunctions::luaTileGetItemCountById(lua_State* L) { // tile:getItemCountById(itemId[, subType = -1]) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - int32_t subType = getNumber<int32_t>(L, 3, -1); + const auto subType = getNumber<int32_t>(L, 3, -1); uint16_t itemId; if (isNumber(L, 2)) { @@ -316,13 +316,13 @@ int TileFunctions::luaTileGetItemCountById(lua_State* L) { int TileFunctions::luaTileGetBottomCreature(lua_State* L) { // tile:getBottomCreature() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> creature = tile->getBottomCreature(); + const auto &creature = tile->getBottomCreature(); if (!creature) { lua_pushnil(L); return 1; @@ -335,13 +335,13 @@ int TileFunctions::luaTileGetBottomCreature(lua_State* L) { int TileFunctions::luaTileGetTopCreature(lua_State* L) { // tile:getTopCreature() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> creature = tile->getTopCreature(); + const auto &creature = tile->getTopCreature(); if (!creature) { lua_pushnil(L); return 1; @@ -354,19 +354,19 @@ int TileFunctions::luaTileGetTopCreature(lua_State* L) { int TileFunctions::luaTileGetBottomVisibleCreature(lua_State* L) { // tile:getBottomVisibleCreature(creature) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); if (!creature) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> visibleCreature = tile->getBottomVisibleCreature(creature); + const auto &visibleCreature = tile->getBottomVisibleCreature(creature); if (visibleCreature) { pushUserdata<const Creature>(L, visibleCreature); setCreatureMetatable(L, -1, visibleCreature); @@ -378,19 +378,19 @@ int TileFunctions::luaTileGetBottomVisibleCreature(lua_State* L) { int TileFunctions::luaTileGetTopVisibleCreature(lua_State* L) { // tile:getTopVisibleCreature(creature) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> creature = getCreature(L, 2); + const auto &creature = getCreature(L, 2); if (!creature) { lua_pushnil(L); return 1; } - std::shared_ptr<Creature> visibleCreature = tile->getTopVisibleCreature(creature); + const auto &visibleCreature = tile->getTopVisibleCreature(creature); if (visibleCreature) { pushUserdata<Creature>(L, visibleCreature); setCreatureMetatable(L, -1, visibleCreature); @@ -402,7 +402,7 @@ int TileFunctions::luaTileGetTopVisibleCreature(lua_State* L) { int TileFunctions::luaTileGetItems(lua_State* L) { // tile:getItems() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -427,7 +427,7 @@ int TileFunctions::luaTileGetItems(lua_State* L) { int TileFunctions::luaTileGetItemCount(lua_State* L) { // tile:getItemCount() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -439,7 +439,7 @@ int TileFunctions::luaTileGetItemCount(lua_State* L) { int TileFunctions::luaTileGetDownItemCount(lua_State* L) { // tile:getDownItemCount() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (tile) { lua_pushnumber(L, tile->getDownItemCount()); } else { @@ -450,7 +450,7 @@ int TileFunctions::luaTileGetDownItemCount(lua_State* L) { int TileFunctions::luaTileGetTopItemCount(lua_State* L) { // tile:getTopItemCount() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -462,7 +462,7 @@ int TileFunctions::luaTileGetTopItemCount(lua_State* L) { int TileFunctions::luaTileGetCreatures(lua_State* L) { // tile:getCreatures() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -487,7 +487,7 @@ int TileFunctions::luaTileGetCreatures(lua_State* L) { int TileFunctions::luaTileGetCreatureCount(lua_State* L) { // tile:getCreatureCount() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -499,7 +499,7 @@ int TileFunctions::luaTileGetCreatureCount(lua_State* L) { int TileFunctions::luaTileHasProperty(lua_State* L) { // tile:hasProperty(property[, item]) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -523,13 +523,13 @@ int TileFunctions::luaTileHasProperty(lua_State* L) { int TileFunctions::luaTileGetThingIndex(lua_State* L) { // tile:getThingIndex(thing) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Thing> thing = getThing(L, 2); + const auto &thing = getThing(L, 2); if (thing) { lua_pushnumber(L, tile->getThingIndex(thing)); } else { @@ -540,7 +540,7 @@ int TileFunctions::luaTileGetThingIndex(lua_State* L) { int TileFunctions::luaTileHasFlag(lua_State* L) { // tile:hasFlag(flag) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (tile) { TileFlags_t flag = getNumber<TileFlags_t>(L, 2); pushBoolean(L, tile->hasFlag(flag)); @@ -552,15 +552,15 @@ int TileFunctions::luaTileHasFlag(lua_State* L) { int TileFunctions::luaTileQueryAdd(lua_State* L) { // tile:queryAdd(thing[, flags]) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - std::shared_ptr<Thing> thing = getThing(L, 2); + const auto &thing = getThing(L, 2); if (thing) { - uint32_t flags = getNumber<uint32_t>(L, 3, 0); + const auto flags = getNumber<uint32_t>(L, 3, 0); lua_pushnumber(L, tile->queryAdd(0, thing, 1, flags)); } else { lua_pushnil(L); @@ -570,7 +570,7 @@ int TileFunctions::luaTileQueryAdd(lua_State* L) { int TileFunctions::luaTileAddItem(lua_State* L) { // tile:addItem(itemId[, count/subType = 1[, flags = 0]]) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -587,15 +587,15 @@ int TileFunctions::luaTileAddItem(lua_State* L) { } } - uint32_t subType = getNumber<uint32_t>(L, 3, 1); + const auto subType = getNumber<uint32_t>(L, 3, 1); - std::shared_ptr<Item> item = Item::CreateItem(itemId, std::min<uint32_t>(subType, Item::items[itemId].stackSize)); + const auto &item = Item::CreateItem(itemId, std::min<uint32_t>(subType, Item::items[itemId].stackSize)); if (!item) { lua_pushnil(L); return 1; } - uint32_t flags = getNumber<uint32_t>(L, 4, 0); + const auto flags = getNumber<uint32_t>(L, 4, 0); ReturnValue ret = g_game().internalAddItem(tile, item, INDEX_WHEREEVER, flags); if (ret == RETURNVALUE_NOERROR) { @@ -610,13 +610,13 @@ int TileFunctions::luaTileAddItem(lua_State* L) { int TileFunctions::luaTileAddItemEx(lua_State* L) { // tile:addItemEx(item[, flags = 0]) - std::shared_ptr<Item> item = getUserdataShared<Item>(L, 2); + const auto &item = getUserdataShared<Item>(L, 2); if (!item) { lua_pushnil(L); return 1; } - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; @@ -628,7 +628,7 @@ int TileFunctions::luaTileAddItemEx(lua_State* L) { return 1; } - uint32_t flags = getNumber<uint32_t>(L, 3, 0); + const auto flags = getNumber<uint32_t>(L, 3, 0); ReturnValue ret = g_game().internalAddItem(tile, item, INDEX_WHEREEVER, flags); if (ret == RETURNVALUE_NOERROR) { ScriptEnvironment::removeTempItem(item); @@ -639,13 +639,13 @@ int TileFunctions::luaTileAddItemEx(lua_State* L) { int TileFunctions::luaTileGetHouse(lua_State* L) { // tile:getHouse() - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - if (std::shared_ptr<HouseTile> houseTile = std::dynamic_pointer_cast<HouseTile>(tile)) { + if (const auto &houseTile = std::dynamic_pointer_cast<HouseTile>(tile)) { pushUserdata<House>(L, houseTile->getHouse()); setMetatable(L, -1, "House"); } else { @@ -656,18 +656,18 @@ int TileFunctions::luaTileGetHouse(lua_State* L) { int TileFunctions::luaTileSweep(lua_State* L) { // tile:sweep(actor) - std::shared_ptr<Tile> tile = getUserdataShared<Tile>(L, 1); + const auto &tile = getUserdataShared<Tile>(L, 1); if (!tile) { lua_pushnil(L); return 1; } - auto actor = getPlayer(L, 2); + const auto &actor = getPlayer(L, 2); if (!actor) { lua_pushnil(L); return 1; } - auto house = tile->getHouse(); + const auto &house = tile->getHouse(); if (!house) { g_logger().debug("TileFunctions::luaTileSweep: tile has no house"); lua_pushnil(L); @@ -680,7 +680,7 @@ int TileFunctions::luaTileSweep(lua_State* L) { return 1; } - auto houseTile = std::dynamic_pointer_cast<HouseTile>(tile); + const auto &houseTile = std::dynamic_pointer_cast<HouseTile>(tile); if (!houseTile) { g_logger().debug("TileFunctions::luaTileSweep: tile is not a house tile"); lua_pushnil(L); diff --git a/src/lua/functions/map/tile_functions.hpp b/src/lua/functions/map/tile_functions.hpp index 78e8c44b32c..a1183508b45 100644 --- a/src/lua/functions/map/tile_functions.hpp +++ b/src/lua/functions/map/tile_functions.hpp @@ -13,6 +13,12 @@ class TileFunctions final : LuaScriptInterface { public: + explicit TileFunctions(lua_State* L) : + LuaScriptInterface("TileFunctions") { + init(L); + } + ~TileFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Tile", "", TileFunctions::luaTileCreate); registerMetaMethod(L, "Tile", "__eq", TileFunctions::luaUserdataCompare); diff --git a/src/lua/functions/map/town_functions.hpp b/src/lua/functions/map/town_functions.hpp index 65ff991c2c9..a3e41ec67ae 100644 --- a/src/lua/functions/map/town_functions.hpp +++ b/src/lua/functions/map/town_functions.hpp @@ -13,6 +13,12 @@ class TownFunctions final : LuaScriptInterface { public: + explicit TownFunctions(lua_State* L) : + LuaScriptInterface("TownFunctions") { + init(L); + } + ~TownFunctions() override = default; + static void init(lua_State* L) { registerSharedClass(L, "Town", "", TownFunctions::luaTownCreate); registerMetaMethod(L, "Town", "__eq", TownFunctions::luaUserdataCompare); @@ -24,7 +30,6 @@ class TownFunctions final : LuaScriptInterface { private: static int luaTownCreate(lua_State* L); - static int luaTownGetId(lua_State* L); static int luaTownGetName(lua_State* L); static int luaTownGetTemplePosition(lua_State* L); diff --git a/src/lua/global/baseevents.cpp b/src/lua/global/baseevents.cpp index 78c1195ab28..82606618fb4 100644 --- a/src/lua/global/baseevents.cpp +++ b/src/lua/global/baseevents.cpp @@ -27,10 +27,10 @@ bool BaseEvents::loadFromXml() { g_logger().warn(__FUNCTION__, scriptsName, scriptsName); } - std::string filename = basePath + scriptsName + ".xml"; + const std::string filename = basePath + scriptsName + ".xml"; pugi::xml_document doc; - pugi::xml_parse_result result = doc.load_file(filename.c_str()); + const pugi::xml_parse_result result = doc.load_file(filename.c_str()); if (!result) { printXMLError(__FUNCTION__, filename, result); return false; @@ -38,8 +38,8 @@ bool BaseEvents::loadFromXml() { loaded = true; - for (auto node : doc.child(scriptsName.c_str()).children()) { - Event_ptr event = getEvent(node.name()); + for (const auto &node : doc.child(scriptsName.c_str()).children()) { + const auto &event = getEvent(node.name()); if (!event) { continue; } @@ -64,7 +64,7 @@ bool BaseEvents::loadFromXml() { } if (success) { - registerEvent(std::move(event), node); + registerEvent(event, node); } } return true; @@ -72,7 +72,7 @@ bool BaseEvents::loadFromXml() { bool BaseEvents::reload() { loaded = false; - clear(false); + clear(); return loadFromXml(); } @@ -102,7 +102,7 @@ bool Event::checkScript(const std::string &basePath, const std::string &scriptsN return false; } - int32_t id = testInterface->getEvent(getScriptEventName()); + const int32_t id = testInterface->getEvent(getScriptEventName()); if (id == -1) { g_logger().warn("[Event::checkScript] - Event " "{} not found {}", @@ -127,7 +127,7 @@ bool Event::loadScript(const std::string &scriptFile, const std::string &scriptN return false; } - int32_t id = scriptInterface->getEvent(getScriptEventName()); + const int32_t id = scriptInterface->getEvent(getScriptEventName()); if (id == -1) { g_logger().warn( "[Event::loadScript] - Event {} not found {}", @@ -150,7 +150,7 @@ bool CallBack::loadCallBack(LuaScriptInterface* interface, const std::string &na scriptInterface = interface; - int32_t id = scriptInterface->getEvent(name.c_str()); + const int32_t id = scriptInterface->getEvent(name); if (id == -1) { g_logger().warn("[{}] - Event {} not found", __FUNCTION__, name); return false; diff --git a/src/lua/global/baseevents.hpp b/src/lua/global/baseevents.hpp index 48e2d104a92..e053eb13c94 100644 --- a/src/lua/global/baseevents.hpp +++ b/src/lua/global/baseevents.hpp @@ -12,7 +12,7 @@ #include "lua/scripts/luascript.hpp" class Event; -using Event_ptr = std::unique_ptr<Event>; +using Event_ptr = std::shared_ptr<Event>; /** * @brief Class that describes an event @@ -84,7 +84,7 @@ class Event { * * @return int32_t */ - int32_t getScriptId() { + int32_t getScriptId() const { return scriptId; } @@ -147,8 +147,8 @@ class BaseEvents { virtual LuaScriptInterface &getScriptInterface() = 0; virtual std::string getScriptBaseName() const = 0; virtual Event_ptr getEvent(const std::string &nodeName) = 0; - virtual bool registerEvent(Event_ptr event, const pugi::xml_node &node) = 0; - virtual void clear(bool) = 0; + virtual bool registerEvent(const Event_ptr &event, const pugi::xml_node &node) = 0; + virtual void clear() = 0; bool loaded = false; diff --git a/src/lua/global/globalevent.cpp b/src/lua/global/globalevent.cpp index 9cb24292b12..90116820a39 100644 --- a/src/lua/global/globalevent.cpp +++ b/src/lua/global/globalevent.cpp @@ -28,9 +28,9 @@ void GlobalEvents::clear() { timerMap.clear(); } -bool GlobalEvents::registerLuaEvent(const std::shared_ptr<GlobalEvent> globalEvent) { +bool GlobalEvents::registerLuaEvent(const std::shared_ptr<GlobalEvent> &globalEvent) { if (globalEvent->getEventType() == GLOBALEVENT_TIMER) { - auto result = timerMap.emplace(globalEvent->getName(), globalEvent); + const auto result = timerMap.emplace(globalEvent->getName(), globalEvent); if (result.second) { if (timerEventId == 0) { timerEventId = g_dispatcher().scheduleEvent( @@ -40,12 +40,12 @@ bool GlobalEvents::registerLuaEvent(const std::shared_ptr<GlobalEvent> globalEve return true; } } else if (globalEvent->getEventType() != GLOBALEVENT_NONE) { - auto result = serverMap.emplace(globalEvent->getName(), globalEvent); + const auto result = serverMap.emplace(globalEvent->getName(), globalEvent); if (result.second) { return true; } } else { // think event - auto result = thinkMap.emplace(globalEvent->getName(), globalEvent); + const auto result = thinkMap.emplace(globalEvent->getName(), globalEvent); if (result.second) { if (thinkEventId == 0) { thinkEventId = g_dispatcher().scheduleEvent( @@ -73,13 +73,13 @@ void GlobalEvents::save() const { } void GlobalEvents::timer() { - time_t now = time(nullptr); + const time_t now = time(nullptr); int64_t nextScheduledTime = std::numeric_limits<int64_t>::max(); auto it = timerMap.begin(); while (it != timerMap.end()) { - const auto globalEvent = it->second; + const auto &globalEvent = it->second; int64_t nextExecutionTime = globalEvent->getNextExecution() - now; if (nextExecutionTime > 0) { @@ -114,7 +114,7 @@ void GlobalEvents::timer() { } void GlobalEvents::think() { - int64_t now = OTSYS_TIME(); + const int64_t now = OTSYS_TIME(); int64_t nextScheduledTime = std::numeric_limits<int64_t>::max(); for (const auto &[globalEventName, globalEvent] : thinkMap) { @@ -143,7 +143,7 @@ void GlobalEvents::think() { } if (nextScheduledTime != std::numeric_limits<int64_t>::max()) { - auto delay = static_cast<uint32_t>(nextScheduledTime); + const auto delay = static_cast<uint32_t>(nextScheduledTime); thinkEventId = g_dispatcher().scheduleEvent( delay, [this] { think(); }, "GlobalEvents::think" ); @@ -204,20 +204,20 @@ std::string GlobalEvent::getScriptTypeName() const { return "onSave"; default: g_logger().error("[GlobalEvent::getScriptTypeName] - Invalid event type"); - return std::string(); + return {}; } } bool GlobalEvent::executePeriodChange(LightState_t lightState, LightInfo lightInfo) const { // onPeriodChange(lightState, lightTime) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[GlobalEvent::executePeriodChange - {}] " "Call stack overflow. Too many lua script calls being nested.", getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -228,16 +228,16 @@ bool GlobalEvent::executePeriodChange(LightState_t lightState, LightInfo lightIn return getScriptInterface()->callFunction(2); } -bool GlobalEvent::executeRecord(uint32_t current, uint32_t old) { +bool GlobalEvent::executeRecord(uint32_t current, uint32_t old) const { // onRecord(current, old) - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[GlobalEvent::executeRecord - {}] " "Call stack overflow. Too many lua script calls being nested.", getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); @@ -249,14 +249,14 @@ bool GlobalEvent::executeRecord(uint32_t current, uint32_t old) { } bool GlobalEvent::executeEvent() const { - if (!getScriptInterface()->reserveScriptEnv()) { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("[GlobalEvent::executeEvent - {}] " "Call stack overflow. Too many lua script calls being nested.", getName()); return false; } - ScriptEnvironment* env = getScriptInterface()->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(getScriptId(), getScriptInterface()); lua_State* L = getScriptInterface()->getLuaState(); getScriptInterface()->pushFunction(getScriptId()); diff --git a/src/lua/global/globalevent.hpp b/src/lua/global/globalevent.hpp index 128a743b3fb..cc08bb9c771 100644 --- a/src/lua/global/globalevent.hpp +++ b/src/lua/global/globalevent.hpp @@ -38,7 +38,7 @@ class GlobalEvents final : public Scripts { GlobalEventMap getEventMap(GlobalEvent_t type); - bool registerLuaEvent(const std::shared_ptr<GlobalEvent> globalEvent); + bool registerLuaEvent(const std::shared_ptr<GlobalEvent> &globalEvent); void clear(); private: @@ -53,7 +53,7 @@ class GlobalEvent final : public Script { explicit GlobalEvent(LuaScriptInterface* interface); bool executePeriodChange(LightState_t lightState, LightInfo lightInfo) const; - bool executeRecord(uint32_t current, uint32_t old); + bool executeRecord(uint32_t current, uint32_t old) const; bool executeEvent() const; GlobalEvent_t getEventType() const { @@ -67,7 +67,7 @@ class GlobalEvent final : public Script { return name; } void setName(std::string eventName) { - name = eventName; + name = std::move(eventName); } uint32_t getInterval() const { return interval; diff --git a/src/lua/modules/modules.cpp b/src/lua/modules/modules.cpp index 04cddc43443..1c0484d33e6 100644 --- a/src/lua/modules/modules.cpp +++ b/src/lua/modules/modules.cpp @@ -16,10 +16,15 @@ Modules::Modules() : scriptInterface.initState(); } -void Modules::clear(bool) { +void Modules::clear() { // clear recvbyte list - for (auto &it : recvbyteList) { - it.second.clearEvent(); + for (const auto &[moduleId, modulePtr] : recvbyteList) { + if (moduleId == 0) { + g_logger().error("Invalid module id 0."); + continue; + } + + modulePtr->clearEvent(); } // clear lua state @@ -38,54 +43,56 @@ Event_ptr Modules::getEvent(const std::string &nodeName) { if (strcasecmp(nodeName.c_str(), "module") != 0) { return nullptr; } - return Event_ptr(new Module(&scriptInterface)); + return std::make_unique<Module>(&scriptInterface); } -bool Modules::registerEvent(Event_ptr event, const pugi::xml_node &) { - Module_ptr module { static_cast<Module*>(event.release()) }; - if (module->getEventType() == MODULE_TYPE_NONE) { +bool Modules::registerEvent(const Event_ptr &event, const pugi::xml_node &) { + const auto &modulePtr = std::dynamic_pointer_cast<Module>(event); + if (modulePtr->getEventType() == MODULE_TYPE_NONE) { g_logger().error("Trying to register event without type!"); return false; } - Module* oldModule = getEventByRecvbyte(module->getRecvbyte(), false); + const auto oldModule = getEventByRecvbyte(modulePtr->getRecvbyte(), false); if (oldModule) { - if (!oldModule->isLoaded() && oldModule->getEventType() == module->getEventType()) { - oldModule->copyEvent(module.get()); + if (!oldModule->isLoaded() && oldModule->getEventType() == modulePtr->getEventType()) { + oldModule->copyEvent(modulePtr); + return true; } return false; + } + + const auto it = recvbyteList.find(modulePtr->getRecvbyte()); + if (it != recvbyteList.end()) { + it->second = modulePtr; } else { - auto it = recvbyteList.find(module->getRecvbyte()); - if (it != recvbyteList.end()) { - it->second = *module; - } else { - recvbyteList.emplace(module->getRecvbyte(), std::move(*module)); - } - return true; + recvbyteList.try_emplace(modulePtr->getRecvbyte(), modulePtr); } + return true; } -Module* Modules::getEventByRecvbyte(uint8_t recvbyte, bool force) { - ModulesList::iterator it = recvbyteList.find(recvbyte); - if (it != recvbyteList.end()) { - if (!force || it->second.isLoaded()) { - return &it->second; - } +Module_ptr Modules::getEventByRecvbyte(uint8_t recvbyte, bool force) { + const auto it = recvbyteList.find(recvbyte); + if (it != recvbyteList.end() && (!force || it->second->isLoaded())) { + return it->second; } return nullptr; } void Modules::executeOnRecvbyte(uint32_t playerId, NetworkMessage &msg, uint8_t byte) const { - std::shared_ptr<Player> player = g_game().getPlayerByID(playerId); + const auto &player = g_game().getPlayerByID(playerId); if (!player) { return; } - for (auto &it : recvbyteList) { - Module module = it.second; - if (module.getEventType() == MODULE_TYPE_RECVBYTE && module.getRecvbyte() == byte && player->canRunModule(module.getRecvbyte())) { - player->setModuleDelay(module.getRecvbyte(), module.getDelay()); - module.executeOnRecvbyte(player, msg); + for (const auto &[moduleId, modulePtr] : recvbyteList) { + if (moduleId == 0) { + g_logger().error("Invalid module id 0."); + continue; + } + if (modulePtr->getEventType() == MODULE_TYPE_RECVBYTE && modulePtr->getRecvbyte() == byte && player->canRunModule(modulePtr->getRecvbyte())) { + player->setModuleDelay(modulePtr->getRecvbyte(), modulePtr->getDelay()); + modulePtr->executeOnRecvbyte(player, msg); return; } } @@ -97,15 +104,15 @@ Module::Module(LuaScriptInterface* interface) : bool Module::configureEvent(const pugi::xml_node &node) { delay = 0; - pugi::xml_attribute typeAttribute = node.attribute("type"); + const auto typeAttribute = node.attribute("type"); if (!typeAttribute) { g_logger().error("Missing type for module."); return false; } - std::string tmpStr = asLowerCaseString(typeAttribute.as_string()); + const auto tmpStr = asLowerCaseString(typeAttribute.as_string()); if (tmpStr == "recvbyte") { - pugi::xml_attribute byteAttribute = node.attribute("byte"); + const auto byteAttribute = node.attribute("byte"); if (!byteAttribute) { g_logger().error("Missing byte for module typed recvbyte."); return false; @@ -118,9 +125,9 @@ bool Module::configureEvent(const pugi::xml_node &node) { return false; } - pugi::xml_attribute delayAttribute = node.attribute("delay"); + const auto delayAttribute = node.attribute("delay"); if (delayAttribute) { - delay = static_cast<uint16_t>(delayAttribute.as_uint()); + delay = static_cast<int16_t>(delayAttribute.as_uint()); } loaded = true; @@ -132,15 +139,15 @@ std::string Module::getScriptEventName() const { case MODULE_TYPE_RECVBYTE: return "onRecvbyte"; default: - return std::string(); + return {}; } } -void Module::copyEvent(Module* module) { - scriptId = module->scriptId; - scriptInterface = module->scriptInterface; - scripted = module->scripted; - loaded = module->loaded; +void Module::copyEvent(const Module_ptr &modulePtr) { + scriptId = modulePtr->scriptId; + scriptInterface = modulePtr->scriptInterface; + scripted = modulePtr->scripted; + loaded = modulePtr->loaded; } void Module::clearEvent() { @@ -150,14 +157,13 @@ void Module::clearEvent() { loaded = false; } -void Module::executeOnRecvbyte(std::shared_ptr<Player> player, NetworkMessage &msg) { - // onRecvbyte(player, msg, recvbyte) - if (!scriptInterface->reserveScriptEnv()) { +void Module::executeOnRecvbyte(const std::shared_ptr<Player> &player, NetworkMessage &msg) const { + if (!LuaScriptInterface::reserveScriptEnv()) { g_logger().error("Call stack overflow. Too many lua script calls being nested {}", player->getName()); return; } - ScriptEnvironment* env = scriptInterface->getScriptEnv(); + ScriptEnvironment* env = LuaScriptInterface::getScriptEnv(); env->setScriptId(scriptId, scriptInterface); lua_State* L = scriptInterface->getLuaState(); diff --git a/src/lua/modules/modules.hpp b/src/lua/modules/modules.hpp index 6543138d515..5917013ec90 100644 --- a/src/lua/modules/modules.hpp +++ b/src/lua/modules/modules.hpp @@ -12,17 +12,16 @@ #include "declarations.hpp" #include "lib/di/container.hpp" #include "lua/global/baseevents.hpp" -#include "lua/scripts/luascript.hpp" #include "server/network/message/networkmessage.hpp" class Module; -using Module_ptr = std::unique_ptr<Module>; +using Module_ptr = std::shared_ptr<Module>; class Module final : public Event { public: explicit Module(LuaScriptInterface* interface); - bool configureEvent(const pugi::xml_node &node) final; + bool configureEvent(const pugi::xml_node &node) override; ModuleType_t getEventType() const { return type; @@ -32,26 +31,26 @@ class Module final : public Event { } void clearEvent(); - void copyEvent(Module* creatureEvent); + void copyEvent(const Module_ptr &creatureEvent); // scripting - void executeOnRecvbyte(std::shared_ptr<Player> player, NetworkMessage &msg); + void executeOnRecvbyte(const std::shared_ptr<Player> &player, NetworkMessage &msg) const; // - uint8_t getRecvbyte() { + uint8_t getRecvbyte() const { return recvbyte; } - int16_t getDelay() { + int16_t getDelay() const { return delay; } protected: - std::string getScriptEventName() const final; + std::string getScriptEventName() const override; ModuleType_t type; - uint8_t recvbyte; - int16_t delay; + uint8_t recvbyte {}; + int16_t delay {}; bool loaded; }; @@ -68,16 +67,16 @@ class Modules final : public BaseEvents { } void executeOnRecvbyte(uint32_t playerId, NetworkMessage &msg, uint8_t byte) const; - Module* getEventByRecvbyte(uint8_t recvbyte, bool force); + Module_ptr getEventByRecvbyte(uint8_t recvbyte, bool force); protected: LuaScriptInterface &getScriptInterface() override; std::string getScriptBaseName() const override; Event_ptr getEvent(const std::string &nodeName) override; - bool registerEvent(Event_ptr event, const pugi::xml_node &node) override; - void clear(bool) override final; + bool registerEvent(const Event_ptr &event, const pugi::xml_node &node) override; + void clear() override; - typedef std::map<uint8_t, Module> ModulesList; + using ModulesList = std::map<uint8_t, Module_ptr>; ModulesList recvbyteList; LuaScriptInterface scriptInterface; diff --git a/src/lua/scripts/lua_environment.cpp b/src/lua/scripts/lua_environment.cpp index 04afd75f958..ab4410a357e 100644 --- a/src/lua/scripts/lua_environment.cpp +++ b/src/lua/scripts/lua_environment.cpp @@ -69,7 +69,7 @@ bool LuaEnvironment::closeState() { for (auto &timerEntry : timerEvents) { LuaTimerEventDesc timerEventDesc = std::move(timerEntry.second); - for (int32_t parameter : timerEventDesc.parameters) { + for (const int32_t parameter : timerEventDesc.parameters) { luaL_unref(luaState, LUA_REGISTRYINDEX, parameter); } luaL_unref(luaState, LUA_REGISTRYINDEX, timerEventDesc.function); @@ -94,7 +94,7 @@ LuaScriptInterface* LuaEnvironment::getTestInterface() { } std::shared_ptr<Combat> LuaEnvironment::getCombatObject(uint32_t id) const { - auto it = combatMap.find(id); + const auto it = combatMap.find(id); if (it == combatMap.end()) { return nullptr; } @@ -109,7 +109,7 @@ std::shared_ptr<Combat> LuaEnvironment::createCombatObject(LuaScriptInterface* i } void LuaEnvironment::clearCombatObjects(LuaScriptInterface* interface) { - auto it = combatIdMap.find(interface); + const auto it = combatIdMap.find(interface); if (it == combatIdMap.end()) { return; } @@ -119,7 +119,7 @@ void LuaEnvironment::clearCombatObjects(LuaScriptInterface* interface) { } const std::unique_ptr<AreaCombat> &LuaEnvironment::getAreaObject(uint32_t id) const { - auto it = areaMap.find(id); + const auto it = areaMap.find(id); if (it == areaMap.end()) { return AreaCombatNull; } @@ -133,7 +133,7 @@ uint32_t LuaEnvironment::createAreaObject(LuaScriptInterface* interface) { } void LuaEnvironment::clearAreaObjects(LuaScriptInterface* interface) { - auto it = areaIdMap.find(interface); + const auto it = areaIdMap.find(interface); if (it == areaIdMap.end()) { return; } @@ -148,7 +148,7 @@ void LuaEnvironment::clearAreaObjects(LuaScriptInterface* interface) { } void LuaEnvironment::executeTimerEvent(uint32_t eventIndex) { - auto it = timerEvents.find(eventIndex); + const auto it = timerEvents.find(eventIndex); if (it == timerEvents.end()) { return; } @@ -160,7 +160,7 @@ void LuaEnvironment::executeTimerEvent(uint32_t eventIndex) { lua_rawgeti(luaState, LUA_REGISTRYINDEX, timerEventDesc.function); // push parameters - for (auto parameter : std::views::reverse(timerEventDesc.parameters)) { + for (const auto parameter : std::views::reverse(timerEventDesc.parameters)) { lua_rawgeti(luaState, LUA_REGISTRYINDEX, parameter); } @@ -178,7 +178,7 @@ void LuaEnvironment::executeTimerEvent(uint32_t eventIndex) { // free resources luaL_unref(luaState, LUA_REGISTRYINDEX, timerEventDesc.function); - for (auto parameter : timerEventDesc.parameters) { + for (const auto parameter : timerEventDesc.parameters) { luaL_unref(luaState, LUA_REGISTRYINDEX, parameter); } } diff --git a/src/lua/scripts/lua_environment.hpp b/src/lua/scripts/lua_environment.hpp index b467599cad4..e7751bb4969 100644 --- a/src/lua/scripts/lua_environment.hpp +++ b/src/lua/scripts/lua_environment.hpp @@ -22,7 +22,7 @@ class Cylinder; class Game; class GlobalFunctions; -class LuaEnvironment : public LuaScriptInterface { +class LuaEnvironment final : public LuaScriptInterface { public: static bool shuttingDown; @@ -52,7 +52,7 @@ class LuaEnvironment : public LuaScriptInterface { template <typename T> std::shared_ptr<T> createWeaponObject(LuaScriptInterface* interface) { auto weapon = std::make_shared<T>(interface); - auto weaponId = ++lastWeaponId; + const auto weaponId = ++lastWeaponId; weaponMap[weaponId] = weapon; weaponIdMap[interface].push_back(weaponId); return weapon; @@ -60,7 +60,7 @@ class LuaEnvironment : public LuaScriptInterface { template <typename T> std::shared_ptr<T> getWeaponObject(uint32_t id) const { - auto it = weaponMap.find(id); + const auto it = weaponMap.find(id); if (it == weaponMap.end()) { return nullptr; } @@ -68,7 +68,7 @@ class LuaEnvironment : public LuaScriptInterface { } void clearWeaponObjects(LuaScriptInterface* interface) { - auto it = weaponIdMap.find(interface); + const auto it = weaponIdMap.find(interface); if (it == weaponIdMap.end()) { return; } @@ -89,7 +89,7 @@ class LuaEnvironment : public LuaScriptInterface { private: void executeTimerEvent(uint32_t eventIndex); - phmap::flat_hash_map<uint32_t, LuaTimerEventDesc> timerEvents; + std::unordered_map<uint32_t, LuaTimerEventDesc> timerEvents; uint32_t lastEventTimerId = 1; phmap::flat_hash_map<uint32_t, std::unique_ptr<AreaCombat>> areaMap; @@ -100,8 +100,8 @@ class LuaEnvironment : public LuaScriptInterface { phmap::flat_hash_map<LuaScriptInterface*, std::vector<uint32_t>> combatIdMap; uint32_t lastCombatId = 0; - phmap::flat_hash_map<uint32_t, std::shared_ptr<Weapon>> weaponMap; - phmap::flat_hash_map<LuaScriptInterface*, std::vector<uint32_t>> weaponIdMap; + std::unordered_map<uint32_t, std::shared_ptr<Weapon>> weaponMap; + std::unordered_map<LuaScriptInterface*, std::vector<uint32_t>> weaponIdMap; uint32_t lastWeaponId = 0; LuaScriptInterface* testInterface = nullptr; diff --git a/src/lua/scripts/luascript.cpp b/src/lua/scripts/luascript.cpp index 2daab6c0532..0b55220c9c4 100644 --- a/src/lua/scripts/luascript.cpp +++ b/src/lua/scripts/luascript.cpp @@ -23,7 +23,7 @@ LuaScriptInterface::LuaScriptInterface(std::string initInterfaceName) : } LuaScriptInterface::~LuaScriptInterface() { - closeState(); + LuaScriptInterface::closeState(); } bool LuaScriptInterface::reInitState() { @@ -156,7 +156,7 @@ const std::string &LuaScriptInterface::getFileById(int32_t scriptId) { return loadingFile; } - auto it = cacheFiles.find(scriptId); + const auto it = cacheFiles.find(scriptId); if (it == cacheFiles.end()) { static const std::string &unk = "(Unknown scriptfile)"; return unk; @@ -164,7 +164,7 @@ const std::string &LuaScriptInterface::getFileById(int32_t scriptId) { return it->second; } -std::string LuaScriptInterface::getStackTrace(const std::string &error_desc) { +std::string LuaScriptInterface::getStackTrace(const std::string &error_desc) const { lua_getglobal(luaState, "debug"); if (!isTable(luaState, -1)) { lua_pop(luaState, 1); @@ -193,7 +193,7 @@ std::string LuaScriptInterface::getStackTrace(const std::string &error_desc) { return stackTrace; } -bool LuaScriptInterface::pushFunction(int32_t functionId) { +bool LuaScriptInterface::pushFunction(int32_t functionId) const { lua_rawgeti(luaState, LUA_REGISTRYINDEX, eventTableRef); if (!isTable(luaState, -1)) { return false; @@ -235,7 +235,7 @@ bool LuaScriptInterface::closeState() { return true; } -std::string LuaScriptInterface::getMetricsScope() { +std::string LuaScriptInterface::getMetricsScope() const { metrics::method_latency measure(__METHOD_NAME__); int32_t scriptId; int32_t callbackId; @@ -253,7 +253,7 @@ std::string LuaScriptInterface::getMetricsScope() { if (name.empty()) { return "unknown"; } - auto pos = name.find("data"); + const auto pos = name.find("data"); if (pos != std::string::npos) { name = name.substr(pos); } @@ -262,10 +262,10 @@ std::string LuaScriptInterface::getMetricsScope() { return fmt::format("{}:{}", name, timerEvent ? "timer" : "<direct>"); } -bool LuaScriptInterface::callFunction(int params) { +bool LuaScriptInterface::callFunction(int params) const { metrics::lua_latency measure(getMetricsScope()); bool result = false; - int size = lua_gettop(luaState); + const int size = lua_gettop(luaState); if (protectedCall(luaState, params, 1) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::getString(luaState, -1)); } else { @@ -281,9 +281,9 @@ bool LuaScriptInterface::callFunction(int params) { return result; } -void LuaScriptInterface::callVoidFunction(int params) { +void LuaScriptInterface::callVoidFunction(int params) const { metrics::lua_latency measure(getMetricsScope()); - int size = lua_gettop(luaState); + const int size = lua_gettop(luaState); if (protectedCall(luaState, params, 0) != 0) { LuaScriptInterface::reportError(nullptr, LuaScriptInterface::popString(luaState)); } diff --git a/src/lua/scripts/luascript.hpp b/src/lua/scripts/luascript.hpp index a376babedde..82ed9fa69af 100644 --- a/src/lua/scripts/luascript.hpp +++ b/src/lua/scripts/luascript.hpp @@ -57,12 +57,12 @@ class LuaScriptInterface : public LuaFunctionsLoader { return luaState; } - bool pushFunction(int32_t functionId); + bool pushFunction(int32_t functionId) const; - bool callFunction(int params); - void callVoidFunction(int params); + bool callFunction(int params) const; + void callVoidFunction(int params) const; - std::string getStackTrace(const std::string &error_desc); + std::string getStackTrace(const std::string &error_desc) const; protected: virtual bool closeState(); @@ -72,7 +72,7 @@ class LuaScriptInterface : public LuaFunctionsLoader { std::map<int32_t, std::string> cacheFiles; private: - std::string getMetricsScope(); + std::string getMetricsScope() const; std::string lastLuaError; std::string interfaceName; diff --git a/src/lua/scripts/script_environment.cpp b/src/lua/scripts/script_environment.cpp index e1c5e3a9c85..adbf5e791b0 100644 --- a/src/lua/scripts/script_environment.cpp +++ b/src/lua/scripts/script_environment.cpp @@ -27,10 +27,10 @@ void ScriptEnvironment::resetEnv() { localMap.clear(); tempResults.clear(); - auto pair = tempItems.equal_range(this); - auto it = pair.first; - while (it != pair.second) { - std::shared_ptr<Item> item = it->second; + const auto [fst, snd] = tempItems.equal_range(this); + auto it = fst; + while (it != snd) { + const auto item = it->second; it = tempItems.erase(it); } } @@ -39,7 +39,7 @@ bool ScriptEnvironment::setCallbackId(int32_t newCallbackId, LuaScriptInterface* if (this->callbackId != 0) { // nested callbacks are not allowed if (interface) { - interface->reportErrorFunc("Nested callbacks!"); + LuaScriptInterface::reportErrorFunc("Nested callbacks!"); } return false; } @@ -56,24 +56,24 @@ void ScriptEnvironment::getEventInfo(int32_t &retScriptId, LuaScriptInterface*&r retTimerEvent = this->timerEvent; } -uint32_t ScriptEnvironment::addThing(std::shared_ptr<Thing> thing) { +uint32_t ScriptEnvironment::addThing(const std::shared_ptr<Thing> &thing) { if (!thing || thing->isRemoved()) { return 0; } - std::shared_ptr<Creature> creature = thing->getCreature(); + const auto &creature = thing->getCreature(); if (creature) { return creature->getID(); } - std::shared_ptr<Item> item = thing->getItem(); + const auto &item = thing->getItem(); if (item && item->hasAttribute(ItemAttribute_t::UNIQUEID)) { return item->getAttribute<uint32_t>(ItemAttribute_t::UNIQUEID); } - for (const auto &it : localMap) { - if (it.second == item) { - return it.first; + for (const auto &[itemId, itemPtr] : localMap) { + if (itemPtr == item) { + return itemId; } } @@ -82,8 +82,8 @@ uint32_t ScriptEnvironment::addThing(std::shared_ptr<Thing> thing) { } void ScriptEnvironment::insertItem(uint32_t uid, std::shared_ptr<Item> item) { - auto result = localMap.emplace(uid, item); - if (!result.second) { + const auto [fst, snd] = localMap.emplace(uid, item); + if (!snd) { g_logger().error("Thing uid already taken: {}", uid); } } @@ -94,16 +94,16 @@ std::shared_ptr<Thing> ScriptEnvironment::getThingByUID(uint32_t uid) { } if (uid <= std::numeric_limits<uint16_t>::max()) { - std::shared_ptr<Item> item = g_game().getUniqueItem(static_cast<uint16_t>(uid)); + const auto &item = g_game().getUniqueItem(static_cast<uint16_t>(uid)); if (item && !item->isRemoved()) { return item; } return nullptr; } - auto it = localMap.find(uid); + const auto it = localMap.find(uid); if (it != localMap.end()) { - std::shared_ptr<Item> item = it->second; + const auto &item = it->second; if (!item->isRemoved()) { return item; } @@ -112,7 +112,7 @@ std::shared_ptr<Thing> ScriptEnvironment::getThingByUID(uint32_t uid) { } std::shared_ptr<Item> ScriptEnvironment::getItemByUID(uint32_t uid) { - std::shared_ptr<Thing> thing = getThingByUID(uid); + const auto &thing = getThingByUID(uid); if (!thing) { return nullptr; } @@ -120,7 +120,7 @@ std::shared_ptr<Item> ScriptEnvironment::getItemByUID(uint32_t uid) { } std::shared_ptr<Container> ScriptEnvironment::getContainerByUID(uint32_t uid) { - std::shared_ptr<Item> item = getItemByUID(uid); + const auto &item = getItemByUID(uid); if (!item) { return nullptr; } @@ -133,17 +133,17 @@ void ScriptEnvironment::removeItemByUID(uint32_t uid) { return; } - auto it = localMap.find(uid); + const auto it = localMap.find(uid); if (it != localMap.end()) { localMap.erase(it); } } -void ScriptEnvironment::addTempItem(std::shared_ptr<Item> item) { +void ScriptEnvironment::addTempItem(const std::shared_ptr<Item> &item) { tempItems.emplace(this, item); } -void ScriptEnvironment::removeTempItem(std::shared_ptr<Item> item) { +void ScriptEnvironment::removeTempItem(const std::shared_ptr<Item> &item) { for (auto it = tempItems.begin(), end = tempItems.end(); it != end; ++it) { if (it->second == item) { tempItems.erase(it); @@ -153,12 +153,12 @@ void ScriptEnvironment::removeTempItem(std::shared_ptr<Item> item) { } uint32_t ScriptEnvironment::addResult(DBResult_ptr res) { - tempResults[++lastResultId] = res; + tempResults[++lastResultId] = std::move(res); return lastResultId; } bool ScriptEnvironment::removeResult(uint32_t id) { - auto it = tempResults.find(id); + const auto it = tempResults.find(id); if (it == tempResults.end()) { return false; } @@ -168,7 +168,7 @@ bool ScriptEnvironment::removeResult(uint32_t id) { } DBResult_ptr ScriptEnvironment::getResultByID(uint32_t id) { - auto it = tempResults.find(id); + const auto it = tempResults.find(id); if (it == tempResults.end()) { return nullptr; } diff --git a/src/lua/scripts/script_environment.hpp b/src/lua/scripts/script_environment.hpp index fe89d3f1e5d..54faf81b7c3 100644 --- a/src/lua/scripts/script_environment.hpp +++ b/src/lua/scripts/script_environment.hpp @@ -22,10 +22,10 @@ class LuaScriptInterface; class Cylinder; class Game; -class ScriptEnvironment { +class ScriptEnvironment final { public: ScriptEnvironment(); - virtual ~ScriptEnvironment(); + ~ScriptEnvironment(); // non-copyable ScriptEnvironment(const ScriptEnvironment &) = delete; @@ -42,7 +42,7 @@ class ScriptEnvironment { int32_t getScriptId() const { return scriptId; } - LuaScriptInterface* getScriptInterface() { + LuaScriptInterface* getScriptInterface() const { return interface; } @@ -52,9 +52,9 @@ class ScriptEnvironment { void getEventInfo(int32_t &scriptId, LuaScriptInterface*&scriptInterface, int32_t &callbackId, bool &timerEvent) const; - void addTempItem(std::shared_ptr<Item> item); - static void removeTempItem(std::shared_ptr<Item> item); - uint32_t addThing(std::shared_ptr<Thing> thing); + void addTempItem(const std::shared_ptr<Item> &item); + static void removeTempItem(const std::shared_ptr<Item> &item); + uint32_t addThing(const std::shared_ptr<Thing> &thing); void insertItem(uint32_t uid, std::shared_ptr<Item> item); static DBResult_ptr getResultByID(uint32_t id); @@ -62,7 +62,7 @@ class ScriptEnvironment { static bool removeResult(uint32_t id); void setNpc(std::shared_ptr<Npc> npc) { - curNpc = npc; + curNpc = std::move(npc); } std::shared_ptr<Npc> getNpc() const { return curNpc; @@ -77,7 +77,7 @@ class ScriptEnvironment { using StorageMap = std::map<uint32_t, int32_t>; using DBResultMap = std::map<uint32_t, DBResult_ptr>; - LuaScriptInterface* interface; + LuaScriptInterface* interface {}; // for npc scripts std::shared_ptr<Npc> curNpc = nullptr; @@ -90,9 +90,9 @@ class ScriptEnvironment { uint32_t lastUID = std::numeric_limits<uint16_t>::max(); // script file id - int32_t scriptId; - int32_t callbackId; - bool timerEvent; + int32_t scriptId {}; + int32_t callbackId {}; + bool timerEvent {}; // result map static uint32_t lastResultId; diff --git a/src/lua/scripts/scripts.cpp b/src/lua/scripts/scripts.cpp index 6e2add673d8..1d30e4e4040 100644 --- a/src/lua/scripts/scripts.cpp +++ b/src/lua/scripts/scripts.cpp @@ -40,7 +40,7 @@ bool Scripts::loadEventSchedulerScripts(const std::string &fileName) { return false; } - std::filesystem::recursive_directory_iterator endit; + const std::filesystem::recursive_directory_iterator endit; for (std::filesystem::recursive_directory_iterator it(dir); it != endit; ++it) { if (std::filesystem::is_regular_file(*it) && it->path().extension() == ".lua") { if (it->path().filename().string() == fileName) { @@ -70,13 +70,13 @@ bool Scripts::loadScripts(std::string loadPath, bool isLib, bool reload) { // Recursive iterate through all entries in the directory for (const auto &entry : std::filesystem::recursive_directory_iterator(dir)) { // Get the filename of the entry as a string - const auto realPath = entry.path(); + const auto &realPath = entry.path(); std::string fileFolder = realPath.parent_path().filename().string(); // Script folder, example: "actions" std::string scriptFolder = realPath.parent_path().string(); // Create a string_view for the fileFolder and scriptFolder strings - std::string_view fileFolderView(fileFolder); - std::string_view scriptFolderView(scriptFolder); + const std::string_view fileFolderView(fileFolder); + const std::string_view scriptFolderView(scriptFolder); // Filename, example: "demon.lua" std::string file(realPath.filename().string()); if (!std::filesystem::is_regular_file(entry) || realPath.extension() != ".lua") { diff --git a/src/lua/scripts/scripts.hpp b/src/lua/scripts/scripts.hpp index 7cefaaaf8bd..10ed18ed4f4 100644 --- a/src/lua/scripts/scripts.hpp +++ b/src/lua/scripts/scripts.hpp @@ -85,7 +85,7 @@ class Script { return false; } - int32_t id = scriptInterface->getEvent(); + const int32_t id = scriptInterface->getEvent(); if (id == -1) { g_logger().error("[Script::loadCallback] Event {} not found for script with name {}", getScriptTypeName(), scriptInterface->getLoadingScriptName()); return false; diff --git a/src/map/house/house.cpp b/src/map/house/house.cpp index 9995862c679..f4b2e7e3e85 100644 --- a/src/map/house/house.cpp +++ b/src/map/house/house.cpp @@ -18,7 +18,7 @@ House::House(uint32_t houseId) : id(houseId) { } -void House::addTile(std::shared_ptr<HouseTile> tile) { +void House::addTile(const std::shared_ptr<HouseTile> &tile) { tile->setFlag(TILESTATE_PROTECTIONZONE); houseTiles.push_back(tile); updateDoorDescription(); @@ -63,7 +63,7 @@ void House::clearHouseInfo(bool preventOwnerDeletion) { } } -bool House::tryTransferOwnership(std::shared_ptr<Player> player, bool serverStartup) { +bool House::tryTransferOwnership(const std::shared_ptr<Player> &player, bool serverStartup) { bool transferSuccess = false; if (player) { transferSuccess = transferToDepot(player); @@ -74,7 +74,7 @@ bool House::tryTransferOwnership(std::shared_ptr<Player> player, bool serverStar for (const auto &tile : houseTiles) { if (const CreatureVector* creatures = tile->getCreatures()) { for (int32_t i = creatures->size(); --i >= 0;) { - const auto creature = (*creatures)[i]; + const auto &creature = (*creatures)[i]; kickPlayer(nullptr, creature->getPlayer()); } } @@ -85,7 +85,7 @@ bool House::tryTransferOwnership(std::shared_ptr<Player> player, bool serverStar return transferSuccess; } -void House::setOwner(uint32_t guid, bool updateDatabase /* = true*/, std::shared_ptr<Player> player /* = nullptr*/) { +void House::setOwner(uint32_t guid, bool updateDatabase /* = true*/, const std::shared_ptr<Player> &player /* = nullptr*/) { if (updateDatabase && owner != guid) { Database &db = Database::getInstance(); @@ -101,7 +101,7 @@ void House::setOwner(uint32_t guid, bool updateDatabase /* = true*/, std::shared isLoaded = true; if (owner != 0) { - tryTransferOwnership(std::move(player), false); + tryTransferOwnership(player, false); } else { std::string strRentPeriod = asLowerCaseString(g_configManager().getString(HOUSE_RENT_PERIOD)); time_t currentTime = time(nullptr); @@ -126,12 +126,12 @@ void House::setOwner(uint32_t guid, bool updateDatabase /* = true*/, std::shared Database &db = Database::getInstance(); std::ostringstream query; query << "SELECT `name`, `account_id` FROM `players` WHERE `id` = " << guid; - DBResult_ptr result = db.storeQuery(query.str()); + const DBResult_ptr result = db.storeQuery(query.str()); if (!result) { return; } - std::string name = result->getString("name"); + const std::string name = result->getString("name"); if (!name.empty()) { owner = guid; ownerName = name; @@ -167,7 +167,7 @@ void House::updateDoorDescription() const { } } -AccessHouseLevel_t House::getHouseAccessLevel(std::shared_ptr<Player> player) const { +AccessHouseLevel_t House::getHouseAccessLevel(const std::shared_ptr<Player> &player) const { if (!player) { return HOUSE_OWNER; } @@ -197,12 +197,12 @@ AccessHouseLevel_t House::getHouseAccessLevel(std::shared_ptr<Player> player) co return HOUSE_NOT_INVITED; } -bool House::kickPlayer(std::shared_ptr<Player> player, std::shared_ptr<Player> target) { +bool House::kickPlayer(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target) { if (!target) { return false; } - std::shared_ptr<HouseTile> houseTile = std::dynamic_pointer_cast<HouseTile>(target->getTile()); + const auto &houseTile = std::dynamic_pointer_cast<HouseTile>(target->getTile()); if (!houseTile || houseTile->getHouse() != static_self_cast<House>()) { return false; } @@ -211,7 +211,7 @@ bool House::kickPlayer(std::shared_ptr<Player> player, std::shared_ptr<Player> t return false; } - Position oldPosition = target->getPosition(); + const Position oldPosition = target->getPosition(); if (g_game().internalTeleport(target, getEntryPosition()) == RETURNVALUE_NOERROR) { g_game().addMagicEffect(oldPosition, CONST_ME_POFF); g_game().addMagicEffect(getEntryPosition(), CONST_ME_TELEPORT); @@ -225,7 +225,7 @@ void House::setAccessList(uint32_t listId, const std::string &textlist) { } else if (listId == SUBOWNER_LIST) { subOwnerList.parseList(textlist); } else { - std::shared_ptr<Door> door = getDoorByNumber(listId); + const auto &door = getDoorByNumber(listId); if (door) { door->setAccessList(textlist); } @@ -236,9 +236,9 @@ void House::setAccessList(uint32_t listId, const std::string &textlist) { // kick uninvited players for (const std::shared_ptr<HouseTile> &tile : houseTiles) { - if (CreatureVector* creatures = tile->getCreatures()) { + if (const CreatureVector* creatures = tile->getCreatures()) { for (int32_t i = creatures->size(); --i >= 0;) { - std::shared_ptr<Player> player = (*creatures)[i]->getPlayer(); + const auto &player = (*creatures)[i]->getPlayer(); if (player && !isInvited(player)) { kickPlayer(nullptr, player); } @@ -252,11 +252,11 @@ bool House::transferToDepot() const { return false; } - std::shared_ptr<Player> player = g_game().getPlayerByGUID(owner); + const auto &player = g_game().getPlayerByGUID(owner); if (player) { transferToDepot(player); } else { - std::shared_ptr<Player> tmpPlayer = std::make_shared<Player>(nullptr); + const auto tmpPlayer = std::make_shared<Player>(nullptr); if (!IOLoginData::loadPlayerById(tmpPlayer, owner)) { return false; } @@ -266,11 +266,11 @@ bool House::transferToDepot() const { return true; } -bool House::transferToDepot(std::shared_ptr<Player> player) const { +bool House::transferToDepot(const std::shared_ptr<Player> &player) const { if (townId == 0 || !player) { return false; } - for (const std::shared_ptr<HouseTile> &tile : houseTiles) { + for (const auto &tile : houseTiles) { if (!transferToDepot(player, tile)) { return false; } @@ -278,7 +278,7 @@ bool House::transferToDepot(std::shared_ptr<Player> player) const { return true; } -bool House::transferToDepot(std::shared_ptr<Player> player, std::shared_ptr<HouseTile> tile) const { +bool House::transferToDepot(const std::shared_ptr<Player> &player, const std::shared_ptr<HouseTile> &tile) const { if (townId == 0 || !player) { return false; } @@ -289,7 +289,7 @@ bool House::transferToDepot(std::shared_ptr<Player> player, std::shared_ptr<Hous ItemList moveItemList; if (const TileItemVector* items = tile->getItemList()) { - for (const std::shared_ptr<Item> &item : *items) { + for (const auto &item : *items) { if (item->isWrapable()) { handleWrapableItem(moveItemList, item, player, tile); } else if (item->isPickupable()) { @@ -302,7 +302,7 @@ bool House::transferToDepot(std::shared_ptr<Player> player, std::shared_ptr<Hous std::unordered_set<std::shared_ptr<Player>> playersToSave = { player }; - for (const std::shared_ptr<Item> &item : moveItemList) { + for (const auto &item : moveItemList) { g_logger().debug("[{}] moving item '{}' to depot", __FUNCTION__, item->getName()); auto targetPlayer = player; if (item->hasOwner() && !item->isOwner(targetPlayer)) { @@ -323,9 +323,9 @@ bool House::transferToDepot(std::shared_ptr<Player> player, std::shared_ptr<Hous bool House::hasItemOnTile() const { bool foundItem = false; - for (const std::shared_ptr<HouseTile> &tile : houseTiles) { + for (const auto &tile : houseTiles) { if (const auto &items = tile->getItemList()) { - for (const std::shared_ptr<Item> &item : *items) { + for (const auto &item : *items) { if (!item) { continue; } @@ -360,13 +360,13 @@ void House::setNewOwnership() { hasNewOwnerOnStartup = true; } -void House::handleWrapableItem(ItemList &moveItemList, std::shared_ptr<Item> item, std::shared_ptr<Player> player, std::shared_ptr<HouseTile> houseTile) const { +void House::handleWrapableItem(ItemList &moveItemList, const std::shared_ptr<Item> &item, const std::shared_ptr<Player> &player, const std::shared_ptr<HouseTile> &houseTile) const { if (item->isWrapContainer()) { g_logger().debug("[{}] found wrapable item '{}'", __FUNCTION__, item->getName()); handleContainer(moveItemList, item); } - std::shared_ptr<Item> newItem = g_game().wrapItem(item, houseTile->getHouse()); + const auto &newItem = g_game().wrapItem(item, houseTile->getHouse()); if (newItem->isRemoved() && !newItem->getParent()) { g_logger().warn("[{}] item removed during wrapping - check ground type - player name: {} item id: {} position: {}", __FUNCTION__, player->getName(), item->getID(), houseTile->getPosition().toString()); return; @@ -375,9 +375,9 @@ void House::handleWrapableItem(ItemList &moveItemList, std::shared_ptr<Item> ite moveItemList.push_back(newItem); } -void House::handleContainer(ItemList &moveItemList, std::shared_ptr<Item> item) const { - if (const auto container = item->getContainer()) { - for (const std::shared_ptr<Item> &containerItem : container->getItemList()) { +void House::handleContainer(ItemList &moveItemList, const std::shared_ptr<Item> &item) const { + if (const auto &container = item->getContainer()) { + for (const auto &containerItem : container->getItemList()) { moveItemList.push_back(containerItem); } } @@ -392,7 +392,7 @@ bool House::getAccessList(uint32_t listId, std::string &list) const { return true; } - std::shared_ptr<Door> door = getDoorByNumber(listId); + const auto &door = getDoorByNumber(listId); if (!door) { return false; } @@ -400,25 +400,25 @@ bool House::getAccessList(uint32_t listId, std::string &list) const { return door->getAccessList(list); } -void House::addDoor(std::shared_ptr<Door> door) { +void House::addDoor(const std::shared_ptr<Door> &door) { doorList.push_back(door); door->setHouse(static_self_cast<House>()); updateDoorDescription(); } -void House::removeDoor(std::shared_ptr<Door> door) { - auto it = std::find(doorList.begin(), doorList.end(), door); +void House::removeDoor(const std::shared_ptr<Door> &door) { + auto it = std::ranges::find(doorList, door); if (it != doorList.end()) { doorList.erase(it); } } -void House::addBed(std::shared_ptr<BedItem> bed) { +void House::addBed(const std::shared_ptr<BedItem> &bed) { bedsList.push_back(bed); bed->setHouse(static_self_cast<House>()); } -void House::removeBed(std::shared_ptr<BedItem> bed) { +void House::removeBed(const std::shared_ptr<BedItem> &bed) { bed->setHouse(nullptr); bedsList.remove(bed); } @@ -432,8 +432,8 @@ std::shared_ptr<Door> House::getDoorByNumber(uint32_t doorId) const { return nullptr; } -std::shared_ptr<Door> House::getDoorByPosition(const Position &pos) { - for (std::shared_ptr<Door> door : doorList) { +std::shared_ptr<Door> House::getDoorByPosition(const Position &pos) const { + for (const auto &door : doorList) { if (door->getPosition() == pos) { return door; } @@ -467,15 +467,15 @@ std::shared_ptr<HouseTransferItem> House::getTransferItem() { void House::resetTransferItem() { if (transferItem) { - std::shared_ptr<Item> tmpItem = transferItem; + const auto &tmpItem = transferItem; transferItem = nullptr; transfer_container->resetParent(); transfer_container->removeThing(tmpItem, tmpItem->getItemCount()); } } -std::shared_ptr<HouseTransferItem> HouseTransferItem::createHouseTransferItem(std::shared_ptr<House> house) { - std::shared_ptr<HouseTransferItem> transferItem = std::make_shared<HouseTransferItem>(house); +std::shared_ptr<HouseTransferItem> HouseTransferItem::createHouseTransferItem(const std::shared_ptr<House> &house) { + auto transferItem = std::make_shared<HouseTransferItem>(house); transferItem->setID(ITEM_DOCUMENT_RO); transferItem->setSubType(1); std::ostringstream ss; @@ -484,17 +484,17 @@ std::shared_ptr<HouseTransferItem> HouseTransferItem::createHouseTransferItem(st return transferItem; } -void HouseTransferItem::onTradeEvent(TradeEvents_t event, std::shared_ptr<Player> owner) { +void HouseTransferItem::onTradeEvent(TradeEvents_t event, const std::shared_ptr<Player> &owner) { if (event == ON_TRADE_TRANSFER) { if (house) { auto isTransferOnRestart = g_configManager().getBoolean(TOGGLE_HOUSE_TRANSFER_ON_SERVER_RESTART); auto ownershipTransferMessage = " The ownership will be transferred upon server restart."; - auto boughtMessage = fmt::format("You have successfully bought the house.{}", isTransferOnRestart ? ownershipTransferMessage : ""); - auto soldMessage = fmt::format("You have successfully sold your house.{}", isTransferOnRestart ? ownershipTransferMessage : ""); + const auto boughtMessage = fmt::format("You have successfully bought the house.{}", isTransferOnRestart ? ownershipTransferMessage : ""); + const auto soldMessage = fmt::format("You have successfully sold your house.{}", isTransferOnRestart ? ownershipTransferMessage : ""); owner->sendTextMessage(MESSAGE_EVENT_ADVANCE, boughtMessage); - auto oldOwner = g_game().getPlayerByGUID(house->getOwner()); + const auto oldOwner = g_game().getPlayerByGUID(house->getOwner()); if (oldOwner) { oldOwner->sendTextMessage(MESSAGE_EVENT_ADVANCE, soldMessage); } @@ -509,7 +509,7 @@ void HouseTransferItem::onTradeEvent(TradeEvents_t event, std::shared_ptr<Player } } -bool House::executeTransfer(std::shared_ptr<HouseTransferItem> item, std::shared_ptr<Player> newOwner) { +bool House::executeTransfer(const std::shared_ptr<HouseTransferItem> &item, const std::shared_ptr<Player> &newOwner) { if (transferItem != item) { return false; } @@ -529,7 +529,7 @@ bool House::executeTransfer(std::shared_ptr<HouseTransferItem> item, std::shared } void AccessList::parseList(const std::string &list) { - std::regex regexValidChars("[^a-zA-Z' \n*!@#]+"); + const std::regex regexValidChars("[^a-zA-Z' \n*!@#]+"); std::string validList = std::regex_replace(list, regexValidChars, ""); // Remove empty lines @@ -564,7 +564,7 @@ void AccessList::parseList(const std::string &list) { toLowerCaseString(m_line); - std::string::size_type at_pos = m_line.find('@'); + const std::string::size_type at_pos = m_line.find('@'); if (at_pos != std::string::npos) { if (at_pos == 0) { addGuild(m_line.substr(1)); @@ -583,11 +583,11 @@ void AccessList::parseList(const std::string &list) { } void AccessList::addPlayer(const std::string &name) { - std::shared_ptr<Player> player = g_game().getPlayerByName(name); + const auto &player = g_game().getPlayerByName(name); if (player) { playerList.insert(player->getGUID()); } else { - uint32_t guid = IOLoginData::getGuidByName(name); + const uint32_t guid = IOLoginData::getGuidByName(name); if (guid != 0) { playerList.insert(guid); } @@ -596,12 +596,12 @@ void AccessList::addPlayer(const std::string &name) { namespace { std::shared_ptr<Guild> getGuildByName(const std::string &name) { - uint32_t guildId = IOGuild::getGuildIdByName(name); + const uint32_t guildId = IOGuild::getGuildIdByName(name); if (guildId == 0) { return nullptr; } - auto guild = g_game().getGuild(guildId); + const auto &guild = g_game().getGuild(guildId); if (guild) { return guild; } @@ -611,7 +611,7 @@ namespace { } void AccessList::addGuild(const std::string &name) { - const auto guild = getGuildByName(name); + const auto &guild = getGuildByName(name); if (guild) { for (const auto &rank : guild->getRanks()) { guildRankList.insert(rank->id); @@ -620,16 +620,16 @@ void AccessList::addGuild(const std::string &name) { } void AccessList::addGuildRank(const std::string &name, const std::string &guildName) { - const auto guild = getGuildByName(guildName); + const auto &guild = getGuildByName(guildName); if (guild) { - const GuildRank_ptr rank = guild->getRankByName(name); + const GuildRank_ptr &rank = guild->getRankByName(name); if (rank) { guildRankList.insert(rank->id); } } } -bool AccessList::isInList(std::shared_ptr<Player> player) const { +bool AccessList::isInList(const std::shared_ptr<Player> &player) const { if (allowEveryone) { return true; } @@ -674,7 +674,7 @@ void Door::setHouse(std::shared_ptr<House> newHouse) { } } -bool Door::canUse(std::shared_ptr<Player> player) const { +bool Door::canUse(const std::shared_ptr<Player> &player) const { if (!house) { return true; } @@ -711,7 +711,7 @@ void Door::onRemoved() { } } -std::shared_ptr<House> Houses::getHouseByPlayerId(uint32_t playerId) { +std::shared_ptr<House> Houses::getHouseByPlayerId(uint32_t playerId) const { for (const auto &it : houseMap) { if (it.second->getOwner() == playerId) { return it.second; @@ -722,21 +722,21 @@ std::shared_ptr<House> Houses::getHouseByPlayerId(uint32_t playerId) { bool Houses::loadHousesXML(const std::string &filename) { pugi::xml_document doc; - pugi::xml_parse_result result = doc.load_file(filename.c_str()); + const pugi::xml_parse_result result = doc.load_file(filename.c_str()); if (!result) { printXMLError(__FUNCTION__, filename, result); return false; } - for (auto houseNode : doc.child("houses").children()) { + for (const auto &houseNode : doc.child("houses").children()) { pugi::xml_attribute houseIdAttribute = houseNode.attribute("houseid"); if (!houseIdAttribute) { return false; } - int32_t houseId = pugi::cast<int32_t>(houseIdAttribute.value()); + auto houseId = pugi::cast<int32_t>(houseIdAttribute.value()); - std::shared_ptr<House> house = getHouse(houseId); + const auto &house = getHouse(houseId); if (!house) { g_logger().error("[Houses::loadHousesXML] - Unknown house, id: {}", houseId); return false; @@ -744,7 +744,7 @@ bool Houses::loadHousesXML(const std::string &filename) { house->setName(houseNode.attribute("name").as_string()); - Position entryPos( + const Position entryPos( pugi::cast<uint16_t>(houseNode.attribute("entryx").value()), pugi::cast<uint16_t>(houseNode.attribute("entryy").value()), pugi::cast<uint16_t>(houseNode.attribute("entryz").value()) @@ -776,9 +776,9 @@ void Houses::payHouses(RentPeriod_t rentPeriod) const { return; } - time_t currentTime = time(nullptr); + const time_t currentTime = time(nullptr); for (const auto &it : houseMap) { - std::shared_ptr<House> house = it.second; + const auto &house = it.second; if (house->getOwner() == 0) { continue; } @@ -789,7 +789,7 @@ void Houses::payHouses(RentPeriod_t rentPeriod) const { continue; } - auto player = g_game().getPlayerByGUID(ownerId, true); + const auto &player = g_game().getPlayerByGUID(ownerId, true); if (!player) { // Player doesn't exist, reset house owner house->tryTransferOwnership(nullptr, true); @@ -842,7 +842,7 @@ void Houses::payHouses(RentPeriod_t rentPeriod) const { house->setPaidUntil(paidUntil); } else { if (house->getPayRentWarnings() < 7) { - int32_t daysLeft = 7 - house->getPayRentWarnings(); + const int32_t daysLeft = 7 - house->getPayRentWarnings(); std::shared_ptr<Item> letter = Item::CreateItem(ITEM_LETTER_STAMPED); std::string period; diff --git a/src/map/house/house.hpp b/src/map/house/house.hpp index aa4b746cc0a..a3dc765988f 100644 --- a/src/map/house/house.hpp +++ b/src/map/house/house.hpp @@ -25,7 +25,7 @@ class AccessList { void addGuild(const std::string &name); void addGuildRank(const std::string &name, const std::string &rankName); - bool isInList(std::shared_ptr<Player> player) const; + bool isInList(const std::shared_ptr<Player> &player) const; void getList(std::string &list) const; @@ -63,7 +63,7 @@ class Door final : public Item { return getAttribute<uint32_t>(ItemAttribute_t::DOORID); } - bool canUse(std::shared_ptr<Player> player) const; + bool canUse(const std::shared_ptr<Player> &player) const; void setAccessList(const std::string &textlist); bool getAccessList(std::string &list) const; @@ -83,12 +83,12 @@ using HouseBedItemList = std::list<std::shared_ptr<BedItem>>; class HouseTransferItem final : public Item { public: - static std::shared_ptr<HouseTransferItem> createHouseTransferItem(std::shared_ptr<House> house); + static std::shared_ptr<HouseTransferItem> createHouseTransferItem(const std::shared_ptr<House> &house); explicit HouseTransferItem(std::shared_ptr<House> newHouse) : - Item(0), house(newHouse) { } + Item(0), house(std::move(newHouse)) { } - void onTradeEvent(TradeEvents_t event, std::shared_ptr<Player> owner) override; + void onTradeEvent(TradeEvents_t event, const std::shared_ptr<Player> &owner) override; bool canTransform() const override { return false; } @@ -97,11 +97,11 @@ class HouseTransferItem final : public Item { std::shared_ptr<House> house; }; -class House : public SharedObject { +class House final : public SharedObject { public: explicit House(uint32_t houseId); - void addTile(std::shared_ptr<HouseTile> tile); + void addTile(const std::shared_ptr<HouseTile> &tile); void updateDoorDescription() const; bool canEditAccessList(uint32_t listId, const std::shared_ptr<Player> &player) const; @@ -115,8 +115,8 @@ class House : public SharedObject { return getHouseAccessLevel(player) != HOUSE_NOT_INVITED; } - AccessHouseLevel_t getHouseAccessLevel(std::shared_ptr<Player> player) const; - bool kickPlayer(std::shared_ptr<Player> player, std::shared_ptr<Player> target); + AccessHouseLevel_t getHouseAccessLevel(const std::shared_ptr<Player> &player) const; + bool kickPlayer(const std::shared_ptr<Player> &player, const std::shared_ptr<Player> &target); void setEntryPos(Position pos) { posEntry = pos; @@ -126,7 +126,7 @@ class House : public SharedObject { } void setName(std::string newHouseName) { - this->houseName = newHouseName; + this->houseName = std::move(newHouseName); } const std::string &getName() const { return houseName; @@ -148,8 +148,8 @@ class House : public SharedObject { */ void setNewOwnerGuid(int32_t newOwnerGuid, bool serverStartup); void clearHouseInfo(bool preventOwnerDeletion); - bool tryTransferOwnership(std::shared_ptr<Player> player, bool serverStartup); - void setOwner(uint32_t guid, bool updateDatabase = true, std::shared_ptr<Player> player = nullptr); + bool tryTransferOwnership(const std::shared_ptr<Player> &player, bool serverStartup); + void setOwner(uint32_t guid, bool updateDatabase = true, const std::shared_ptr<Player> &player = nullptr); uint32_t getOwner() const { return owner; } @@ -192,14 +192,14 @@ class House : public SharedObject { return id; } - void addDoor(std::shared_ptr<Door> door); - void removeDoor(std::shared_ptr<Door> door); + void addDoor(const std::shared_ptr<Door> &door); + void removeDoor(const std::shared_ptr<Door> &door); std::shared_ptr<Door> getDoorByNumber(uint32_t doorId) const; - std::shared_ptr<Door> getDoorByPosition(const Position &pos); + std::shared_ptr<Door> getDoorByPosition(const Position &pos) const; std::shared_ptr<HouseTransferItem> getTransferItem(); void resetTransferItem(); - bool executeTransfer(std::shared_ptr<HouseTransferItem> item, std::shared_ptr<Player> player); + bool executeTransfer(const std::shared_ptr<HouseTransferItem> &item, const std::shared_ptr<Player> &player); const HouseTileList &getTiles() const { return houseTiles; @@ -209,8 +209,8 @@ class House : public SharedObject { return doorList; } - void addBed(std::shared_ptr<BedItem> bed); - void removeBed(std::shared_ptr<BedItem> bed); + void addBed(const std::shared_ptr<BedItem> &bed); + void removeBed(const std::shared_ptr<BedItem> &bed); const HouseBedItemList &getBeds() const { return bedsList; } @@ -226,8 +226,8 @@ class House : public SharedObject { return maxBeds; } - bool transferToDepot(std::shared_ptr<Player> player) const; - bool transferToDepot(std::shared_ptr<Player> player, std::shared_ptr<HouseTile> tile) const; + bool transferToDepot(const std::shared_ptr<Player> &player) const; + bool transferToDepot(const std::shared_ptr<Player> &player, const std::shared_ptr<HouseTile> &tile) const; bool hasItemOnTile() const; bool hasNewOwnership() const; @@ -268,8 +268,8 @@ class House : public SharedObject { bool isLoaded = false; - void handleContainer(ItemList &moveItemList, std::shared_ptr<Item> item) const; - void handleWrapableItem(ItemList &moveItemList, std::shared_ptr<Item> item, std::shared_ptr<Player> player, std::shared_ptr<HouseTile> houseTile) const; + void handleContainer(ItemList &moveItemList, const std::shared_ptr<Item> &item) const; + void handleWrapableItem(ItemList &moveItemList, const std::shared_ptr<Item> &item, const std::shared_ptr<Player> &player, const std::shared_ptr<HouseTile> &houseTile) const; }; using HouseMap = std::map<uint32_t, std::shared_ptr<House>>; @@ -284,7 +284,7 @@ class Houses { Houses &operator=(const Houses &) = delete; std::shared_ptr<House> addHouse(uint32_t id) { - if (auto it = houseMap.find(id); it != houseMap.end()) { + if (const auto it = houseMap.find(id); it != houseMap.end()) { return it->second; } @@ -292,14 +292,14 @@ class Houses { } std::shared_ptr<House> getHouse(uint32_t houseId) { - auto it = houseMap.find(houseId); + const auto it = houseMap.find(houseId); if (it == houseMap.end()) { return nullptr; } return it->second; } - std::shared_ptr<House> getHouseByPlayerId(uint32_t playerId); + std::shared_ptr<House> getHouseByPlayerId(uint32_t playerId) const; bool loadHousesXML(const std::string &filename); diff --git a/src/map/house/housetile.cpp b/src/map/house/housetile.cpp index d43be459ee2..0167aa9d906 100644 --- a/src/map/house/housetile.cpp +++ b/src/map/house/housetile.cpp @@ -14,57 +14,57 @@ #include "game/game.hpp" HouseTile::HouseTile(int32_t initX, int32_t initY, int32_t initZ, std::shared_ptr<House> initHouse) : - DynamicTile(initX, initY, initZ), house(initHouse) { } + DynamicTile(initX, initY, initZ), house(std::move(initHouse)) { } -void HouseTile::addThing(int32_t index, std::shared_ptr<Thing> thing) { +void HouseTile::addThing(int32_t index, const std::shared_ptr<Thing> &thing) { Tile::addThing(index, thing); if (!thing || !thing->getParent()) { return; } - if (std::shared_ptr<Item> item = thing->getItem()) { + if (const auto &item = thing->getItem()) { updateHouse(item); } } -void HouseTile::internalAddThing(uint32_t index, std::shared_ptr<Thing> thing) { +void HouseTile::internalAddThing(uint32_t index, const std::shared_ptr<Thing> &thing) { Tile::internalAddThing(index, thing); if (!thing || !thing->getParent()) { return; } - if (std::shared_ptr<Item> item = thing->getItem()) { + if (const auto &item = thing->getItem()) { updateHouse(item); } } -void HouseTile::updateHouse(std::shared_ptr<Item> item) { +void HouseTile::updateHouse(const std::shared_ptr<Item> &item) const { if (item->getParent().get() != this) { return; } - std::shared_ptr<Door> door = item->getDoor(); + const auto &door = item->getDoor(); if (door) { if (door->getDoorId() != 0) { house->addDoor(door); } } else { - std::shared_ptr<BedItem> bed = item->getBed(); + const auto &bed = item->getBed(); if (bed) { house->addBed(bed); } } } -ReturnValue HouseTile::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t tileFlags, std::shared_ptr<Creature> actor /* = nullptr*/) { - if (std::shared_ptr<Creature> creature = thing->getCreature()) { - if (std::shared_ptr<Player> player = creature->getPlayer()) { +ReturnValue HouseTile::queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t tileFlags, const std::shared_ptr<Creature> &actor /* = nullptr*/) { + if (const auto &creature = thing->getCreature()) { + if (const auto &player = creature->getPlayer()) { if (!house->isInvited(player)) { return RETURNVALUE_PLAYERISNOTINVITED; } - } else if (std::shared_ptr<Monster> monster = creature->getMonster()) { + } else if (const auto &monster = creature->getMonster()) { if (monster->isSummon()) { if (!house->isInvited(monster->getMaster()->getPlayer())) { return RETURNVALUE_NOTPOSSIBLE; @@ -77,7 +77,7 @@ ReturnValue HouseTile::queryAdd(int32_t index, const std::shared_ptr<Thing> &thi } } } else if (thing->getItem() && actor) { - std::shared_ptr<Player> actorPlayer = actor->getPlayer(); + const auto &actorPlayer = actor->getPlayer(); if (house && (!house->isInvited(actorPlayer) || house->getHouseAccessLevel(actorPlayer) == HOUSE_GUEST) && g_configManager().getBoolean(ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS)) { return RETURNVALUE_CANNOTTHROW; } @@ -85,12 +85,12 @@ ReturnValue HouseTile::queryAdd(int32_t index, const std::shared_ptr<Thing> &thi return Tile::queryAdd(index, thing, count, tileFlags, actor); } -std::shared_ptr<Cylinder> HouseTile::queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &tileFlags) { - if (std::shared_ptr<Creature> creature = thing->getCreature()) { - if (std::shared_ptr<Player> player = creature->getPlayer()) { +std::shared_ptr<Cylinder> HouseTile::queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &tileFlags) { + if (const auto &creature = thing->getCreature()) { + if (const auto &player = creature->getPlayer()) { if (!house->isInvited(player)) { const Position &entryPos = house->getEntryPosition(); - std::shared_ptr<Tile> destTile = g_game().map.getTile(entryPos); + auto destTile = g_game().map.getTile(entryPos); if (!destTile) { g_logger().error("[HouseTile::queryDestination] - " "Entry not correct for house name: {} " @@ -103,7 +103,7 @@ std::shared_ptr<Cylinder> HouseTile::queryDestination(int32_t &index, const std: } index = -1; - *destItem = nullptr; + destItem = nullptr; return destTile; } } @@ -112,14 +112,14 @@ std::shared_ptr<Cylinder> HouseTile::queryDestination(int32_t &index, const std: return Tile::queryDestination(index, thing, destItem, tileFlags); } -ReturnValue HouseTile::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor /*= nullptr*/) { - std::shared_ptr<Item> item = thing->getItem(); +ReturnValue HouseTile::queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor /*= nullptr */) { + const auto &item = thing->getItem(); if (!item) { return RETURNVALUE_NOTPOSSIBLE; } if (actor && g_configManager().getBoolean(ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS)) { - std::shared_ptr<Player> actorPlayer = actor->getPlayer(); + const auto &actorPlayer = actor->getPlayer(); if (house && !house->isInvited(actorPlayer)) { return RETURNVALUE_NOTPOSSIBLE; } else if (house && house->getHouseAccessLevel(actorPlayer) == HOUSE_GUEST) { diff --git a/src/map/house/housetile.hpp b/src/map/house/housetile.hpp index b661251dbea..6a191d0f84d 100644 --- a/src/map/house/housetile.hpp +++ b/src/map/house/housetile.hpp @@ -15,24 +15,26 @@ class House; class HouseTile final : public DynamicTile { public: + using Tile::addThing; + HouseTile(int32_t x, int32_t y, int32_t z, std::shared_ptr<House> house); // cylinder implementations - ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryAdd(int32_t index, const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; - std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item>* destItem, uint32_t &flags) override; + std::shared_ptr<Cylinder> queryDestination(int32_t &index, const std::shared_ptr<Thing> &thing, std::shared_ptr<Item> &destItem, uint32_t &flags) override; - ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, std::shared_ptr<Creature> actor = nullptr) override; + ReturnValue queryRemove(const std::shared_ptr<Thing> &thing, uint32_t count, uint32_t flags, const std::shared_ptr<Creature> &actor = nullptr) override; - void addThing(int32_t index, std::shared_ptr<Thing> thing) override; - void virtual internalAddThing(uint32_t index, std::shared_ptr<Thing> thing) override; + void addThing(int32_t index, const std::shared_ptr<Thing> &thing) override; + void internalAddThing(uint32_t index, const std::shared_ptr<Thing> &thing) override; std::shared_ptr<House> getHouse() override { return house; } private: - void updateHouse(std::shared_ptr<Item> item); + void updateHouse(const std::shared_ptr<Item> &item) const; std::shared_ptr<House> house; }; diff --git a/src/map/map.cpp b/src/map/map.cpp index 4647deed66c..6ada1d59231 100644 --- a/src/map/map.cpp +++ b/src/map/map.cpp @@ -163,7 +163,7 @@ std::shared_ptr<Tile> Map::getLoadedTile(uint16_t x, uint16_t y, uint8_t z) { return nullptr; } - const auto leaf = getMapSector(x, y); + const auto &leaf = getMapSector(x, y); if (!leaf) { return nullptr; } @@ -173,7 +173,7 @@ std::shared_ptr<Tile> Map::getLoadedTile(uint16_t x, uint16_t y, uint8_t z) { return nullptr; } - const auto tile = floor->getTile(x, y); + const auto &tile = floor->getTile(x, y); return tile; } @@ -182,7 +182,7 @@ std::shared_ptr<Tile> Map::getTile(uint16_t x, uint16_t y, uint8_t z) { return nullptr; } - const auto sector = getMapSector(x, y); + const auto §or = getMapSector(x, y); if (!sector) { return nullptr; } @@ -196,7 +196,7 @@ std::shared_ptr<Tile> Map::getTile(uint16_t x, uint16_t y, uint8_t z) { } void Map::refreshZones(uint16_t x, uint16_t y, uint8_t z) { - const auto tile = getLoadedTile(x, y, z); + const auto &tile = getLoadedTile(x, y, z); if (!tile) { return; } @@ -208,21 +208,21 @@ void Map::refreshZones(uint16_t x, uint16_t y, uint8_t z) { } } -void Map::setTile(uint16_t x, uint16_t y, uint8_t z, std::shared_ptr<Tile> newTile) { +void Map::setTile(uint16_t x, uint16_t y, uint8_t z, const std::shared_ptr<Tile> &newTile) { if (z >= MAP_MAX_LAYERS) { g_logger().error("Attempt to set tile on invalid coordinate: {}", Position(x, y, z).toString()); return; } - if (const auto sector = getMapSector(x, y)) { + if (const auto §or = getMapSector(x, y)) { sector->createFloor(z)->setTile(x, y, newTile); } else { getBestMapSector(x, y)->createFloor(z)->setTile(x, y, newTile); } } -bool Map::placeCreature(const Position ¢erPos, std::shared_ptr<Creature> creature, bool extendedPos /* = false*/, bool forceLogin /* = false*/) { - auto monster = creature->getMonster(); +bool Map::placeCreature(const Position ¢erPos, const std::shared_ptr<Creature> &creature, bool extendedPos /* = false*/, bool forceLogin /* = false*/) { + const auto &monster = creature ? creature->getMonster() : nullptr; if (monster) { monster->ignoreFieldDamage = true; } @@ -230,7 +230,7 @@ bool Map::placeCreature(const Position ¢erPos, std::shared_ptr<Creature> cre bool foundTile; bool placeInPZ; - std::shared_ptr<Tile> tile = getTile(centerPos.x, centerPos.y, centerPos.z); + auto tile = getTile(centerPos.x, centerPos.y, centerPos.z); if (tile) { placeInPZ = tile->hasFlag(TILESTATE_PROTECTIONZONE); ReturnValue ret = tile->queryAdd(0, creature, 1, FLAG_IGNOREBLOCKITEM | FLAG_IGNOREFIELDDAMAGE); @@ -269,11 +269,11 @@ bool Map::placeCreature(const Position ¢erPos, std::shared_ptr<Creature> cre std::shuffle(relList.begin(), relList.begin() + 4, getRandomGenerator()); std::shuffle(relList.begin() + 4, relList.end(), getRandomGenerator()); } else { - std::shuffle(relList.begin(), relList.end(), getRandomGenerator()); + std::ranges::shuffle(relList, getRandomGenerator()); } - for (const auto &it : relList) { - Position tryPos(centerPos.x + it.first, centerPos.y + it.second, centerPos.z); + for (const auto &[xOffset, yOffset] : relList) { + Position tryPos(centerPos.x + xOffset, centerPos.y + yOffset, centerPos.z); tile = getTile(tryPos.x, tryPos.y, tryPos.z); if (!tile || (placeInPZ && !tile->hasFlag(TILESTATE_PROTECTIONZONE))) { @@ -310,11 +310,13 @@ bool Map::placeCreature(const Position ¢erPos, std::shared_ptr<Creature> cre uint32_t flags = 0; std::shared_ptr<Item> toItem = nullptr; - auto toCylinder = tile->queryDestination(index, creature, &toItem, flags); - toCylinder->internalAddThing(creature); + if (tile) { + const auto toCylinder = tile->queryDestination(index, creature, toItem, flags); + toCylinder->internalAddThing(creature); - const Position &dest = toCylinder->getPosition(); - getMapSector(dest.x, dest.y)->addCreature(creature); + const Position &dest = toCylinder->getPosition(); + getMapSector(dest.x, dest.y)->addCreature(creature); + } return true; } @@ -339,11 +341,11 @@ void Map::moveCreature(const std::shared_ptr<Creature> &creature, const std::sha const auto &fromZones = oldTile->getZones(); const auto &toZones = newTile->getZones(); - if (auto ret = g_game().beforeCreatureZoneChange(creature, fromZones, toZones); ret != RETURNVALUE_NOERROR) { + if (const auto &ret = g_game().beforeCreatureZoneChange(creature, fromZones, toZones); ret != RETURNVALUE_NOERROR) { return; } - bool teleport = forceTeleport || !newTile->getGround() || !Position::areInRange<1, 1, 0>(oldPos, newPos); + const bool teleport = forceTeleport || !newTile->getGround() || !Position::areInRange<1, 1, 0>(oldPos, newPos); Spectators spectators; if (!teleport && oldPos.z == newPos.z) { @@ -370,7 +372,7 @@ void Map::moveCreature(const std::shared_ptr<Creature> &creature, const std::sha spectators.find<Creature>(newPos, true, 0, 0, 0, 0, false); } - auto playersSpectators = spectators.filter<Player>(); + const auto playersSpectators = spectators.filter<Player>(); std::vector<int32_t> oldStackPosVector; oldStackPosVector.reserve(playersSpectators.size()); @@ -415,7 +417,7 @@ void Map::moveCreature(const std::shared_ptr<Creature> &creature, const std::sha size_t i = 0; for (const auto &spectator : playersSpectators) { // Use the correct stackpos - int32_t stackpos = oldStackPosVector[i++]; + const int32_t stackpos = oldStackPosVector[i++]; if (stackpos != -1) { const auto &player = spectator->getPlayer(); player->sendCreatureMove(creature, newPos, newTile->getStackposOfCreature(player, creature), oldPos, stackpos, teleport); @@ -449,7 +451,7 @@ bool Map::canThrowObjectTo(const Position &fromPos, const Position &toPos, const return false; } - int32_t deltaz = Position::getDistanceZ(fromPos, toPos); + const int32_t deltaz = Position::getDistanceZ(fromPos, toPos); if (deltaz > MAP_LAYER_VIEW_LIMIT) { return false; } @@ -651,7 +653,7 @@ std::shared_ptr<Tile> Map::canWalkTo(const std::shared_ptr<Creature> &creature, return tile; } -bool Map::getPathMatching(const std::shared_ptr<Creature> &creature, const Position &__targetPos, std::vector<Direction> &dirList, const FrozenPathingConditionCall &pathCondition, const FindPathParams &fpp) { +bool Map::getPathMatching(const std::shared_ptr<Creature> &creature, const Position &_targetPos, std::vector<Direction> &dirList, const FrozenPathingConditionCall &pathCondition, const FindPathParams &fpp) { static int_fast32_t allNeighbors[8][2] = { { -1, 0 }, { 0, 1 }, { 1, 0 }, { 0, -1 }, { -1, -1 }, { 1, -1 }, { 1, 1 }, { -1, 1 } }; @@ -669,7 +671,7 @@ bool Map::getPathMatching(const std::shared_ptr<Creature> &creature, const Posit const bool withoutCreature = creature == nullptr; - Position pos = withoutCreature ? __targetPos : creature->getPosition(); + Position pos = withoutCreature ? _targetPos : creature->getPosition(); Position endPos; AStarNodes nodes(pos.x, pos.y, AStarNodes::getTileWalkCost(creature, getTile(pos.x, pos.y, pos.z))); @@ -677,14 +679,14 @@ bool Map::getPathMatching(const std::shared_ptr<Creature> &creature, const Posit int32_t bestMatch = 0; const auto &startPos = pos; - const auto &targetPos = withoutCreature ? pathCondition.getTargetPos() : __targetPos; + const auto &targetPos = withoutCreature ? pathCondition.getTargetPos() : _targetPos; const int_fast32_t sX = std::abs(targetPos.getX() - pos.getX()); const int_fast32_t sY = std::abs(targetPos.getY() - pos.getY()); uint_fast16_t cntDirs = 0; - AStarNode* found = nullptr; + const AStarNode* found = nullptr; do { AStarNode* n = nodes.getBestNode(); if (!n) { @@ -798,8 +800,8 @@ bool Map::getPathMatching(const std::shared_ptr<Creature> &creature, const Posit pos.x = found->x; pos.y = found->y; - int_fast32_t dx = pos.getX() - prevx; - int_fast32_t dy = pos.getY() - prevy; + const int_fast32_t dx = pos.getX() - prevx; + const int_fast32_t dy = pos.getY() - prevy; prevx = pos.x; prevy = pos.y; @@ -864,7 +866,7 @@ bool Map::getPathMatchingCond(const std::shared_ptr<Creature> &creature, const P uint_fast16_t cntDirs = 0; - AStarNode* found = nullptr; + const AStarNode* found = nullptr; do { AStarNode* n = nodes.getBestNode(); if (!n) { @@ -986,8 +988,8 @@ bool Map::getPathMatchingCond(const std::shared_ptr<Creature> &creature, const P pos.x = found->x; pos.y = found->y; - int_fast32_t dx = pos.getX() - prevx; - int_fast32_t dy = pos.getY() - prevy; + const int_fast32_t dx = pos.getX() - prevx; + const int_fast32_t dy = pos.getY() - prevy; prevx = pos.x; prevy = pos.y; @@ -1018,8 +1020,8 @@ bool Map::getPathMatchingCond(const std::shared_ptr<Creature> &creature, const P return true; } -uint32_t Map::clean() { - uint64_t start = OTSYS_TIME(); +uint32_t Map::clean() const { + const uint64_t start = OTSYS_TIME(); size_t qntTiles = 0; if (g_game().getGameState() == GAME_STATE_NORMAL) { @@ -1034,7 +1036,7 @@ uint32_t Map::clean() { continue; } - if (const auto items = tile->getItemList()) { + if (const auto &items = tile->getItemList()) { ++qntTiles; for (const auto &item : *items) { if (item->isCleanable()) { @@ -1055,7 +1057,7 @@ uint32_t Map::clean() { g_game().setGameState(GAME_STATE_NORMAL); } - uint64_t end = OTSYS_TIME(); + const uint64_t end = OTSYS_TIME(); g_logger().info("CLEAN: Removed {} item{} from {} tile{} in {} seconds", count, (count != 1 ? "s" : ""), qntTiles, (qntTiles != 1 ? "s" : ""), (end - start) / (1000.f)); return count; } diff --git a/src/map/map.hpp b/src/map/map.hpp index f6e38cb3eac..b4b78c7b5f4 100644 --- a/src/map/map.hpp +++ b/src/map/map.hpp @@ -29,9 +29,9 @@ class FrozenPathingConditionCall; * Map class. * Holds all the actual map-data */ -class Map : public MapCache { +class Map final : public MapCache { public: - uint32_t clean(); + uint32_t clean() const; std::filesystem::path getPath() const { return path; @@ -59,7 +59,7 @@ class Map : public MapCache { * \param loadNpcs if true, the map custom npcs is loaded * \returns true if the custom map was loaded successfully */ - void loadMapCustom(const std::string &mapName, bool loadHouses, bool loadMonsters, bool loadNpcs, bool loadZones, const int customMapIndex); + void loadMapCustom(const std::string &mapName, bool loadHouses, bool loadMonsters, bool loadNpcs, bool loadZones, int customMapIndex); void loadHouseInfo(); @@ -95,7 +95,7 @@ class Map : public MapCache { * \param extendedPos If true, the creature will in first-hand be placed 2 tiles away * \param forceLogin If true, placing the creature will not fail becase of obstacles (creatures/chests) */ - bool placeCreature(const Position ¢erPos, std::shared_ptr<Creature> creature, bool extendedPos = false, bool forceLogin = false); + bool placeCreature(const Position ¢erPos, const std::shared_ptr<Creature> &creature, bool extendedPos = false, bool forceLogin = false); void moveCreature(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &newTile, bool forceTeleport = false); @@ -147,8 +147,8 @@ class Map : public MapCache { /** * Set a single tile. */ - void setTile(uint16_t x, uint16_t y, uint8_t z, std::shared_ptr<Tile> newTile); - void setTile(const Position &pos, std::shared_ptr<Tile> newTile) { + void setTile(uint16_t x, uint16_t y, uint8_t z, const std::shared_ptr<Tile> &newTile); + void setTile(const Position &pos, const std::shared_ptr<Tile> &newTile) { setTile(pos.x, pos.y, pos.z, newTile); } std::shared_ptr<Tile> getLoadedTile(uint16_t x, uint16_t y, uint8_t z); diff --git a/src/map/mapcache.cpp b/src/map/mapcache.cpp index bad1315113c..113ed26a32c 100644 --- a/src/map/mapcache.cpp +++ b/src/map/mapcache.cpp @@ -33,12 +33,12 @@ std::shared_ptr<BasicTile> static_tryGetTileFromCache(const std::shared_ptr<Basi return ref ? tiles.try_emplace(ref->hash(), ref).first->second : nullptr; } -void MapCache::flush() { +void MapCache::flush() const { items.clear(); tiles.clear(); } -void MapCache::parseItemAttr(const std::shared_ptr<BasicItem> &BasicItem, std::shared_ptr<Item> item) { +void MapCache::parseItemAttr(const std::shared_ptr<BasicItem> &BasicItem, const std::shared_ptr<Item> &item) const { if (BasicItem->charges > 0) { item->setSubType(BasicItem->charges); } @@ -52,7 +52,7 @@ void MapCache::parseItemAttr(const std::shared_ptr<BasicItem> &BasicItem, std::s } if (item->getTeleport() && (BasicItem->destX != 0 || BasicItem->destY != 0 || BasicItem->destZ != 0)) { - auto dest = Position(BasicItem->destX, BasicItem->destY, BasicItem->destZ); + const auto dest = Position(BasicItem->destX, BasicItem->destY, BasicItem->destZ); item->getTeleport()->setDestPos(dest); } @@ -73,7 +73,7 @@ void MapCache::parseItemAttr(const std::shared_ptr<BasicItem> &BasicItem, std::s } std::shared_ptr<Item> MapCache::createItem(const std::shared_ptr<BasicItem> &BasicItem, Position position) { - auto item = Item::CreateItem(BasicItem->id, position); + const auto &item = Item::CreateItem(BasicItem->id, position); if (!item) { return nullptr; } @@ -102,18 +102,15 @@ std::shared_ptr<Item> MapCache::createItem(const std::shared_ptr<BasicItem> &Bas return item; } -std::shared_ptr<Tile> MapCache::getOrCreateTileFromCache(const std::unique_ptr<Floor> &floor, uint16_t x, uint16_t y) { - const auto cachedTile = floor->getTileCache(x, y); +std::shared_ptr<Tile> MapCache::getOrCreateTileFromCache(const std::shared_ptr<Floor> &floor, uint16_t x, uint16_t y) { + const auto &cachedTile = floor->getTileCache(x, y); const auto oldTile = floor->getTile(x, y); if (!cachedTile) { return oldTile; } - std::unique_lock l(floor->getMutex()); - const uint8_t z = floor->getZ(); - - auto map = static_cast<Map*>(this); + const auto map = dynamic_cast<Map*>(this); std::vector<std::shared_ptr<Creature>> oldCreatureList; if (oldTile) { @@ -125,8 +122,9 @@ std::shared_ptr<Tile> MapCache::getOrCreateTileFromCache(const std::unique_ptr<F } std::shared_ptr<Tile> tile = nullptr; + if (cachedTile->isHouse()) { - const auto house = map->houses.getHouse(cachedTile->houseId); + const auto &house = map->houses.getHouse(cachedTile->houseId); tile = std::make_shared<HouseTile>(x, y, z, house); house->addTile(std::static_pointer_cast<HouseTile>(tile)); } else if (cachedTile->isStatic) { @@ -175,7 +173,7 @@ void MapCache::setBasicTile(uint16_t x, uint16_t y, uint8_t z, const std::shared return; } - const auto tile = static_tryGetTileFromCache(newTile); + const auto &tile = static_tryGetTileFromCache(newTile); if (const auto sector = getMapSector(x, y)) { sector->createFloor(z)->setTileCache(x, y, tile); } else { @@ -183,7 +181,7 @@ void MapCache::setBasicTile(uint16_t x, uint16_t y, uint8_t z, const std::shared } } -std::shared_ptr<BasicItem> MapCache::tryReplaceItemFromCache(const std::shared_ptr<BasicItem> &ref) { +std::shared_ptr<BasicItem> MapCache::tryReplaceItemFromCache(const std::shared_ptr<BasicItem> &ref) const { return static_tryGetItemFromCache(ref); } @@ -228,7 +226,7 @@ MapSector* MapCache::getBestMapSector(uint32_t x, uint32_t y) { } void BasicTile::hash(size_t &h) const { - std::array<uint32_t, 4> arr = { flags, houseId, type, isStatic }; + const std::array<uint32_t, 4> arr = { flags, houseId, type, isStatic }; for (const auto v : arr) { if (v > 0) { stdext::hash_combine(h, v); diff --git a/src/map/mapcache.hpp b/src/map/mapcache.hpp index 429d786972b..eb7a313ffab 100644 --- a/src/map/mapcache.hpp +++ b/src/map/mapcache.hpp @@ -15,7 +15,7 @@ class Map; class Tile; class Item; -class Position; +struct Position; class FileStream; #pragma pack(1) @@ -47,7 +47,7 @@ struct BasicItem { private: void hash(size_t &h) const; - friend class BasicTile; + friend struct BasicTile; }; struct BasicTile { @@ -85,9 +85,9 @@ class MapCache { void setBasicTile(uint16_t x, uint16_t y, uint8_t z, const std::shared_ptr<BasicTile> &BasicTile); - std::shared_ptr<BasicItem> tryReplaceItemFromCache(const std::shared_ptr<BasicItem> &ref); + std::shared_ptr<BasicItem> tryReplaceItemFromCache(const std::shared_ptr<BasicItem> &ref) const; - void flush(); + void flush() const; /** * Creates a map sector. @@ -111,11 +111,11 @@ class MapCache { } protected: - std::shared_ptr<Tile> getOrCreateTileFromCache(const std::unique_ptr<Floor> &floor, uint16_t x, uint16_t y); + std::shared_ptr<Tile> getOrCreateTileFromCache(const std::shared_ptr<Floor> &floor, uint16_t x, uint16_t y); std::unordered_map<uint32_t, MapSector> mapSectors; private: - void parseItemAttr(const std::shared_ptr<BasicItem> &BasicItem, std::shared_ptr<Item> item); + void parseItemAttr(const std::shared_ptr<BasicItem> &BasicItem, const std::shared_ptr<Item> &item) const; std::shared_ptr<Item> createItem(const std::shared_ptr<BasicItem> &BasicItem, Position position); }; diff --git a/src/map/spectators.hpp b/src/map/spectators.hpp index d35bc21721b..b8e56fc9d2e 100644 --- a/src/map/spectators.hpp +++ b/src/map/spectators.hpp @@ -44,7 +44,7 @@ class Spectators { template <typename T> requires std::is_base_of_v<Creature, T> - Spectators filter(); + Spectators filter() const; Spectators insert(const std::shared_ptr<Creature> &creature); Spectators insertAll(const CreatureVector &list); @@ -93,7 +93,7 @@ class Spectators { template <typename T> requires std::is_base_of_v<Creature, T> -Spectators Spectators::filter() { +Spectators Spectators::filter() const { auto specs = Spectators(); specs.creatures.reserve(creatures.size()); diff --git a/src/map/town.hpp b/src/map/town.hpp index d6529fa30ef..6dd91d388be 100644 --- a/src/map/town.hpp +++ b/src/map/town.hpp @@ -10,6 +10,7 @@ #pragma once #include "game/movement/position.hpp" +#include "utils/tools.hpp" class Town { public: @@ -55,16 +56,20 @@ class Towns { } std::shared_ptr<Town> getTown(const std::string &townName) const { - for (const auto &it : townMap) { - if (strcasecmp(townName.c_str(), it.second->getName().c_str()) == 0) { - return it.second; + for (const auto &[townId, town] : townMap) { + if (townId == 0) { + continue; + } + + if (caseInsensitiveCompare(townName, town->getName())) { + return town; } } return nullptr; } std::shared_ptr<Town> getTown(uint32_t townId) const { - auto it = townMap.find(townId); + const auto it = townMap.find(townId); if (it == townMap.end()) { return nullptr; } diff --git a/src/map/utils/astarnodes.cpp b/src/map/utils/astarnodes.cpp index 4645cd30b62..c1561bc7296 100644 --- a/src/map/utils/astarnodes.cpp +++ b/src/map/utils/astarnodes.cpp @@ -69,7 +69,7 @@ bool AStarNodes::createOpenNode(AStarNode* parent, uint32_t x, uint32_t y, int_f return false; } - int32_t retNode = curNode++; + const int32_t retNode = curNode++; openNodes[retNode] = true; AStarNode &node = nodes[retNode]; @@ -112,7 +112,7 @@ AStarNode* AStarNodes::getBestNode() { best_node = (total_cost < best_node_f ? indices_array[i] : best_node); best_node_f = (total_cost < best_node_f ? total_cost : best_node_f); } - return (openNodes[best_node] ? &nodes[best_node] : NULL); + return (openNodes[best_node] ? &nodes[best_node] : nullptr); #elif defined(__AVX2__) const __m256i increment = _mm256_set1_epi32(8); __m256i indices = _mm256_setr_epi32(0, 1, 2, 3, 4, 5, 6, 7); @@ -132,8 +132,8 @@ AStarNode* AStarNodes::getBestNode() { alignas(32) int32_t indices_array[8]; _mm256_store_si256(reinterpret_cast<__m256i*>(indices_array), minindices); - int32_t best_node = indices_array[(_mm_ctz(_mm256_movemask_epi8(_mm256_cmpeq_epi32(minvalues, res))) >> 2)]; - return (openNodes[best_node] ? &nodes[best_node] : NULL); + int32_t best_node = indices_array[(mm_ctz(_mm256_movemask_epi8(_mm256_cmpeq_epi32(minvalues, res))) >> 2)]; + return (openNodes[best_node] ? &nodes[best_node] : nullptr); #elif defined(__SSE4_1__) const __m128i increment = _mm_set1_epi32(4); __m128i indices = _mm_setr_epi32(0, 1, 2, 3); @@ -152,7 +152,7 @@ AStarNode* AStarNodes::getBestNode() { alignas(16) int32_t indices_array[4]; _mm_store_si128(reinterpret_cast<__m128i*>(indices_array), minindices); - int32_t best_node = indices_array[(_mm_ctz(_mm_movemask_epi8(_mm_cmpeq_epi32(minvalues, res))) >> 2)]; + int32_t best_node = indices_array[(mm_ctz(_mm_movemask_epi8(_mm_cmpeq_epi32(minvalues, res))) >> 2)]; return (openNodes[best_node] ? &nodes[best_node] : NULL); #elif defined(__SSE2__) auto _mm_sse2_min_epi32 = [](const __m128i a, const __m128i b) { @@ -182,8 +182,8 @@ AStarNode* AStarNodes::getBestNode() { alignas(16) int32_t indices_array[4]; _mm_store_si128(reinterpret_cast<__m128i*>(indices_array), minindices); - int32_t best_node = indices_array[(_mm_ctz(_mm_movemask_epi8(_mm_cmpeq_epi32(minvalues, res))) >> 2)]; - return (openNodes[best_node] ? &nodes[best_node] : NULL); + int32_t best_node = indices_array[(mm_ctz(_mm_movemask_epi8(_mm_cmpeq_epi32(minvalues, res))) >> 2)]; + return (openNodes[best_node] ? &nodes[best_node] : nullptr); #else int32_t best_node_f = std::numeric_limits<int32_t>::max(); int32_t best_node = -1; @@ -239,7 +239,7 @@ AStarNode* AStarNodes::getNodeByPosition(uint32_t x, uint32_t y) { v[3] = _mm_cmpeq_epi32(_mm_load_si128(reinterpret_cast<const __m128i*>(&nodesTable[pos + 12])), key); const uint32_t mask = _mm_movemask_epi8(_mm_packs_epi16(_mm_packs_epi32(v[0], v[1]), _mm_packs_epi32(v[2], v[3]))); if (mask != 0) { - return &nodes[pos + _mm_ctz(mask)]; + return &nodes[pos + mm_ctz(mask)]; } } curRound = curNode - 8; @@ -249,7 +249,7 @@ AStarNode* AStarNodes::getNodeByPosition(uint32_t x, uint32_t y) { v[1] = _mm_cmpeq_epi32(_mm_load_si128(reinterpret_cast<const __m128i*>(&nodesTable[pos + 4])), key); const uint32_t mask = _mm_movemask_epi8(_mm_packs_epi32(v[0], v[1])); if (mask != 0) { - return &nodes[pos + (_mm_ctz(mask) >> 1)]; + return &nodes[pos + (mm_ctz(mask) >> 1)]; } pos += 8; } @@ -269,7 +269,7 @@ AStarNode* AStarNodes::getNodeByPosition(uint32_t x, uint32_t y) { #endif } -int_fast32_t AStarNodes::getMapWalkCost(AStarNode* node, const Position &neighborPos) { +int_fast32_t AStarNodes::getMapWalkCost(const AStarNode* node, const Position &neighborPos) { // diagonal movement extra cost return (((std::abs(node->x - neighborPos.x) + std::abs(node->y - neighborPos.y)) - 1) * MAP_DIAGONALWALKCOST) + MAP_NORMALWALKCOST; } @@ -283,7 +283,7 @@ int_fast32_t AStarNodes::getTileWalkCost(const std::shared_ptr<Creature> &creatu cost += MAP_NORMALWALKCOST * 4; } if (const auto &field = tile->getFieldItem()) { - CombatType_t combatType = field->getCombatType(); + const CombatType_t combatType = field->getCombatType(); if (!creature->isImmune(combatType) && !creature->hasCondition(Combat::DamageToConditionType(combatType)) && (creature->getMonster() && !creature->getMonster()->canWalkOnFieldType(combatType))) { cost += MAP_NORMALWALKCOST * 18; } diff --git a/src/map/utils/astarnodes.hpp b/src/map/utils/astarnodes.hpp index d66171f0d53..6e4411855bb 100644 --- a/src/map/utils/astarnodes.hpp +++ b/src/map/utils/astarnodes.hpp @@ -30,7 +30,7 @@ class AStarNodes { int32_t getClosedNodes() const; AStarNode* getNodeByPosition(uint32_t x, uint32_t y); - static int_fast32_t getMapWalkCost(AStarNode* node, const Position &neighborPos); + static int_fast32_t getMapWalkCost(const AStarNode* node, const Position &neighborPos); static int_fast32_t getTileWalkCost(const std::shared_ptr<Creature> &creature, const std::shared_ptr<Tile> &tile); private: @@ -40,8 +40,8 @@ class AStarNodes { static constexpr int32_t MAP_DIAGONALWALKCOST = 25; #if defined(__SSE2__) - alignas(16) uint32_t nodesTable[MAX_NODES]; - alignas(64) int32_t calculatedNodes[MAX_NODES]; + alignas(16) uint32_t nodesTable[MAX_NODES] {}; + alignas(64) int32_t calculatedNodes[MAX_NODES] {}; AStarNode nodes[MAX_NODES]; #else AStarNode nodes[MAX_NODES]; diff --git a/src/map/utils/mapsector.cpp b/src/map/utils/mapsector.cpp index 064ff837e8b..36bbd01684d 100644 --- a/src/map/utils/mapsector.cpp +++ b/src/map/utils/mapsector.cpp @@ -20,7 +20,7 @@ void MapSector::addCreature(const std::shared_ptr<Creature> &c) { } void MapSector::removeCreature(const std::shared_ptr<Creature> &c) { - auto iter = std::find(creature_list.begin(), creature_list.end(), c); + auto iter = std::ranges::find(creature_list, c); if (iter == creature_list.end()) { g_logger().error("[{}]: Creature not found in creature_list!", __FUNCTION__); return; @@ -31,7 +31,7 @@ void MapSector::removeCreature(const std::shared_ptr<Creature> &c) { creature_list.pop_back(); if (c->getPlayer()) { - iter = std::find(player_list.begin(), player_list.end(), c); + iter = std::ranges::find(player_list, c); if (iter == player_list.end()) { g_logger().error("[{}]: Player not found in player_list!", __FUNCTION__); return; diff --git a/src/map/utils/mapsector.hpp b/src/map/utils/mapsector.hpp index 7b95db7f78b..58130007e5e 100644 --- a/src/map/utils/mapsector.hpp +++ b/src/map/utils/mapsector.hpp @@ -20,24 +20,27 @@ struct Floor { z(z) { } std::shared_ptr<Tile> getTile(uint16_t x, uint16_t y) const { - std::shared_lock sl(mutex); + std::shared_lock<std::shared_mutex> sl(mutex); return tiles[x & SECTOR_MASK][y & SECTOR_MASK].first; } void setTile(uint16_t x, uint16_t y, std::shared_ptr<Tile> tile) { - tiles[x & SECTOR_MASK][y & SECTOR_MASK].first = tile; + std::unique_lock<std::shared_mutex> ul(mutex); + tiles[x & SECTOR_MASK][y & SECTOR_MASK].first = std::move(tile); } std::shared_ptr<BasicTile> getTileCache(uint16_t x, uint16_t y) const { - std::shared_lock sl(mutex); + std::shared_lock<std::shared_mutex> sl(mutex); return tiles[x & SECTOR_MASK][y & SECTOR_MASK].second; } void setTileCache(uint16_t x, uint16_t y, const std::shared_ptr<BasicTile> &newTile) { + std::unique_lock<std::shared_mutex> ul(mutex); tiles[x & SECTOR_MASK][y & SECTOR_MASK].second = newTile; } const auto &getTiles() const { + std::shared_lock<std::shared_mutex> sl(mutex); return tiles; } @@ -45,13 +48,11 @@ struct Floor { return z; } - auto &getMutex() const { - return mutex; - } - private: std::pair<std::shared_ptr<Tile>, std::shared_ptr<BasicTile>> tiles[SECTOR_SIZE][SECTOR_SIZE] = {}; + mutable std::shared_mutex mutex; + uint8_t z { 0 }; }; @@ -59,32 +60,49 @@ class MapSector { public: MapSector() = default; - // non-copyable MapSector(const MapSector &) = delete; MapSector &operator=(const MapSector &) = delete; - - // non-moveable MapSector(const MapSector &&) = delete; MapSector &operator=(const MapSector &&) = delete; - const std::unique_ptr<Floor> &createFloor(uint32_t z) { - return floors[z] ? floors[z] : (floors[z] = std::make_unique<Floor>(z)); + std::shared_ptr<Floor> createFloor(uint32_t z) { + if (z >= MAP_MAX_LAYERS) { + g_logger().error("Attempt to create floor on invalid coordinate: {}", z); + return nullptr; + } + std::scoped_lock lock(floors_mutex); + if (!floors[z]) { + floors[z] = std::make_shared<Floor>(static_cast<uint8_t>(z)); + } + return floors[z]; } - const std::unique_ptr<Floor> &getFloor(uint8_t z) const { + std::shared_ptr<Floor> getFloor(uint8_t z) { + if (z >= MAP_MAX_LAYERS) { + g_logger().error("Attempt to get floor on invalid coordinate: {}", z); + return nullptr; + } + std::scoped_lock lock(floors_mutex); return floors[z]; } void addCreature(const std::shared_ptr<Creature> &c); + void removeCreature(const std::shared_ptr<Creature> &c); private: static bool newSector; + MapSector* sectorS = nullptr; MapSector* sectorE = nullptr; + std::vector<std::shared_ptr<Creature>> creature_list; std::vector<std::shared_ptr<Creature>> player_list; - std::unique_ptr<Floor> floors[MAP_MAX_LAYERS] = {}; + + mutable std::mutex floors_mutex; + + std::shared_ptr<Floor> floors[MAP_MAX_LAYERS] = {}; + uint32_t floorBits = 0; friend class Spectators; diff --git a/src/pch.hpp b/src/pch.hpp index b89830b9fdb..dea85a93106 100644 --- a/src/pch.hpp +++ b/src/pch.hpp @@ -87,14 +87,10 @@ // FMT Custom Formatter for Enums template <typename E> -struct fmt::formatter<E, std::enable_if_t<std::is_enum_v<E>, char>> : fmt::formatter<std::underlying_type_t<E>> { - template <typename FormatContext> - auto format(E e, FormatContext &ctx) const { - return fmt::formatter<std::underlying_type_t<E>>::format( - static_cast<std::underlying_type_t<E>>(e), ctx - ); - } -}; +std::enable_if_t<std::is_enum_v<E>, std::underlying_type_t<E>> +format_as(E e) { + return static_cast<std::underlying_type_t<E>>(e); +} // GMP #include <gmp.h> @@ -175,9 +171,9 @@ struct fmt::formatter<E, std::enable_if_t<std::is_enum_v<E>, char>> : fmt::forma #include "lua/global/shared_object.hpp" constexpr std::string_view methodName(const char* s) { - std::string_view prettyFunction(s); - size_t bracket = prettyFunction.rfind('('); - size_t space = prettyFunction.rfind(' ', bracket) + 1; + const std::string_view prettyFunction(s); + const size_t bracket = prettyFunction.rfind('('); + const size_t space = prettyFunction.rfind(' ', bracket) + 1; return prettyFunction.substr(space, bracket - space); } diff --git a/src/security/argon.cpp b/src/security/argon.cpp index 52fa4b0c94b..2e0b05ac7a9 100644 --- a/src/security/argon.cpp +++ b/src/security/argon.cpp @@ -52,7 +52,6 @@ uint32_t Argon2::parseBitShift(const std::string &bitShiftStr) const { } bool Argon2::verifyPassword(const std::string &password, const std::string &phash) const { - const std::regex re("\\$([A-Za-z0-9+/]+)\\$([A-Za-z0-9+/]+)"); std::smatch match; if (!std::regex_search(phash, match, re)) { @@ -60,8 +59,8 @@ bool Argon2::verifyPassword(const std::string &password, const std::string &phas return false; } - std::vector<uint8_t> salt = base64_decode(match[1]); - std::vector<uint8_t> hash = base64_decode(match[2]); + const std::vector<uint8_t> salt = base64_decode(match[1]); + const std::vector<uint8_t> hash = base64_decode(match[2]); // Hash the password std::vector<uint8_t> computed_hash(hash.size()); @@ -74,17 +73,17 @@ bool Argon2::verifyPassword(const std::string &password, const std::string &phas return computed_hash == hash; } -std::vector<uint8_t> Argon2::base64_decode(const std::string &input) const { +std::vector<uint8_t> Argon2::base64_decode(const std::string &input) { const std::string base64_chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"; std::vector<uint8_t> ret; int i = 0; uint32_t val = 0; - for (char c : input) { + for (const char c : input) { if (isspace(c) || c == '=') { continue; } - size_t pos = base64_chars.find(c); + const size_t pos = base64_chars.find(c); if (pos == std::string::npos) { g_logger().warn("Invalid character in base64 string"); } else if (pos > std::numeric_limits<uint32_t>::max()) { @@ -94,9 +93,9 @@ std::vector<uint8_t> Argon2::base64_decode(const std::string &input) const { } if (++i % 4 == 0) { - ret.push_back((val >> 16) & 0xFF); - ret.push_back((val >> 8) & 0xFF); - ret.push_back(val & 0xFF); + ret.emplace_back((val >> 16) & 0xFF); + ret.emplace_back((val >> 8) & 0xFF); + ret.emplace_back(val & 0xFF); } } @@ -105,11 +104,11 @@ std::vector<uint8_t> Argon2::base64_decode(const std::string &input) const { g_logger().warn("Invalid length for base64 string"); break; case 2: - ret.push_back((val >> 4) & 0xFF); + ret.emplace_back((val >> 4) & 0xFF); break; case 3: - ret.push_back((val >> 10) & 0xFF); - ret.push_back((val >> 2) & 0xFF); + ret.emplace_back((val >> 10) & 0xFF); + ret.emplace_back((val >> 2) & 0xFF); break; default: g_logger().warn("Unexpected remainder when dividing string length by 4"); diff --git a/src/security/argon.hpp b/src/security/argon.hpp index ea09dcffccb..839ce02a484 100644 --- a/src/security/argon.hpp +++ b/src/security/argon.hpp @@ -25,12 +25,12 @@ class Argon2 { private: uint32_t parseBitShift(const std::string &bitShiftStr) const; bool verifyPassword(const std::string &password, const std::string &phash) const; - std::vector<uint8_t> base64_decode(const std::string &input) const; + static std::vector<uint8_t> base64_decode(const std::string &input); static const std::regex re; static const std::string base64_chars; std::string m_const_str; - uint32_t m_cost; - uint32_t t_cost; - uint32_t parallelism; + uint32_t m_cost {}; + uint32_t t_cost {}; + uint32_t parallelism {}; }; diff --git a/src/security/rsa.cpp b/src/security/rsa.cpp index 536ebdc02d3..f192f6ca3ec 100644 --- a/src/security/rsa.cpp +++ b/src/security/rsa.cpp @@ -26,8 +26,8 @@ RSA &RSA::getInstance() { } void RSA::start() { - const char* p("14299623962416399520070177382898895550795403345466153217470516082934737582776038882967213386204600674145392845853859217990626450972452084065728686565928113"); - const char* q("7630979195970404721891201847792002125535401292779123937207447574596692788513647179235335529307251350570728407373705564708871762033017096809910315212884101"); + const auto p("14299623962416399520070177382898895550795403345466153217470516082934737582776038882967213386204600674145392845853859217990626450972452084065728686565928113"); + const auto q("7630979195970404721891201847792002125535401292779123937207447574596692788513647179235335529307251350570728407373705564708871762033017096809910315212884101"); try { if (!loadPEM("key.pem")) { // file doesn't exist - switch to base10-hardcoded keys @@ -108,13 +108,17 @@ std::string RSA::base64Decrypt(const std::string &input) const { auto posOfCharacter = [](const uint8_t chr) -> uint16_t { if (chr >= 'A' && chr <= 'Z') { return chr - 'A'; - } else if (chr >= 'a' && chr <= 'z') { + } + if (chr >= 'a' && chr <= 'z') { return chr - 'a' + ('Z' - 'A') + 1; - } else if (chr >= '0' && chr <= '9') { + } + if (chr >= '0' && chr <= '9') { return chr - '0' + ('Z' - 'A') + ('z' - 'a') + 2; - } else if (chr == '+' || chr == '-') { + } + if (chr == '+' || chr == '-') { return 62; - } else if (chr == '/' || chr == '_') { + } + if (chr == '/' || chr == '_') { return 63; } g_logger().error("[RSA::base64Decrypt] - Invalid base6409"); @@ -122,19 +126,19 @@ std::string RSA::base64Decrypt(const std::string &input) const { }; if (input.empty()) { - return std::string(); + return {}; } - size_t length = input.length(); + const size_t length = input.length(); size_t pos = 0; std::string output; output.reserve(length / 4 * 3); while (pos < length) { - uint16_t pos1 = posOfCharacter(input[pos + 1]); + const uint16_t pos1 = posOfCharacter(input[pos + 1]); output.push_back(static_cast<std::string::value_type>(((posOfCharacter(input[pos])) << 2) + ((pos1 & 0x30) >> 4))); if (input[pos + 2] != '=' && input[pos + 2] != '.') { - uint16_t pos2 = posOfCharacter(input[pos + 2]); + const uint16_t pos2 = posOfCharacter(input[pos + 2]); output.push_back(static_cast<std::string::value_type>(((pos1 & 0x0f) << 4) + ((pos2 & 0x3c) >> 2))); if (input[pos + 3] != '=' && input[pos + 3] != '.') { output.push_back(static_cast<std::string::value_type>(((pos2 & 0x03) << 6) + posOfCharacter(input[pos + 3]))); @@ -188,7 +192,7 @@ uint16_t RSA::decodeLength(char*&pos) const { void RSA::readHexString(char*&pos, uint16_t length, std::string &output) const { output.reserve(static_cast<size_t>(length) * 2); for (uint16_t i = 0; i < length; ++i) { - auto hex = static_cast<uint8_t>(*pos++); + const auto hex = static_cast<uint8_t>(*pos++); output.push_back("0123456789ABCDEF"[(hex >> 4) & 15]); output.push_back("0123456789ABCDEF"[hex & 15]); } diff --git a/src/security/rsa.hpp b/src/security/rsa.hpp index a6de23b4e13..a6575a5515f 100644 --- a/src/security/rsa.hpp +++ b/src/security/rsa.hpp @@ -13,7 +13,7 @@ class Logger; class RSA { public: - RSA(Logger &logger); + explicit RSA(Logger &logger); ~RSA(); // Singleton - ensures we don't accidentally copy it @@ -34,8 +34,8 @@ class RSA { private: Logger &logger; - mpz_t n; - mpz_t d; + mpz_t n {}; + mpz_t d {}; }; constexpr auto g_RSA = RSA::getInstance; diff --git a/src/server/network/connection/connection.cpp b/src/server/network/connection/connection.cpp index 91f62a7602d..76c954af41c 100644 --- a/src/server/network/connection/connection.cpp +++ b/src/server/network/connection/connection.cpp @@ -16,12 +16,13 @@ #include "game/scheduling/dispatcher.hpp" #include "server/network/message/networkmessage.hpp" #include "server/server.hpp" +#include "utils/tools.hpp" ConnectionManager &ConnectionManager::getInstance() { return inject<ConnectionManager>(); } -Connection_ptr ConnectionManager::createConnection(asio::io_service &io_service, ConstServicePort_ptr servicePort) { +Connection_ptr ConnectionManager::createConnection(asio::io_service &io_service, const ConstServicePort_ptr &servicePort) { auto connection = std::make_shared<Connection>(io_service, servicePort); connections.emplace(connection); return connection; @@ -126,6 +127,7 @@ void Connection::acceptInternal(bool toggleParseHeader) { close(FORCE_CLOSE); } } + void Connection::parseProxyIdentification(const std::error_code &error) { std::scoped_lock lock(connectionLock); readTimer.cancel(); diff --git a/src/server/network/connection/connection.hpp b/src/server/network/connection/connection.hpp index 0666ef35d8d..139bfc73024 100644 --- a/src/server/network/connection/connection.hpp +++ b/src/server/network/connection/connection.hpp @@ -36,7 +36,7 @@ class ConnectionManager { static ConnectionManager &getInstance(); - Connection_ptr createConnection(asio::io_service &io_service, ConstServicePort_ptr servicePort); + Connection_ptr createConnection(asio::io_service &io_service, const ConstServicePort_ptr &servicePort); void releaseConnection(const Connection_ptr &connection); void closeAll(); diff --git a/src/server/network/message/outputmessage.cpp b/src/server/network/message/outputmessage.cpp index bb4dab4526d..ad4589581a9 100644 --- a/src/server/network/message/outputmessage.cpp +++ b/src/server/network/message/outputmessage.cpp @@ -12,8 +12,10 @@ #include "lib/di/container.hpp" #include "server/network/protocol/protocol.hpp" #include "game/scheduling/dispatcher.hpp" +#include "utils/lockfree.hpp" -const std::chrono::milliseconds OUTPUTMESSAGE_AUTOSEND_DELAY { 10 }; +constexpr uint16_t OUTPUTMESSAGE_FREE_LIST_CAPACITY = 2048; +constexpr std::chrono::milliseconds OUTPUTMESSAGE_AUTOSEND_DELAY { 10 }; OutputMessagePool &OutputMessagePool::getInstance() { return inject<OutputMessagePool>(); @@ -27,7 +29,7 @@ void OutputMessagePool::scheduleSendAll() { void OutputMessagePool::sendAll() { // dispatcher thread - for (auto &protocol : bufferedProtocols) { + for (const auto &protocol : bufferedProtocols) { auto &msg = protocol->getCurrentBuffer(); if (msg) { protocol->send(std::move(msg)); @@ -39,7 +41,7 @@ void OutputMessagePool::sendAll() { } } -void OutputMessagePool::addProtocolToAutosend(Protocol_ptr protocol) { +void OutputMessagePool::addProtocolToAutosend(const Protocol_ptr &protocol) { // dispatcher thread if (bufferedProtocols.empty()) { scheduleSendAll(); @@ -49,7 +51,7 @@ void OutputMessagePool::addProtocolToAutosend(Protocol_ptr protocol) { void OutputMessagePool::removeProtocolFromAutosend(const Protocol_ptr &protocol) { // dispatcher thread - auto it = std::ranges::find(bufferedProtocols.begin(), bufferedProtocols.end(), protocol); + const auto it = std::ranges::find(bufferedProtocols, protocol); if (it != bufferedProtocols.end()) { *it = bufferedProtocols.back(); bufferedProtocols.pop_back(); @@ -57,5 +59,5 @@ void OutputMessagePool::removeProtocolFromAutosend(const Protocol_ptr &protocol) } OutputMessage_ptr OutputMessagePool::getOutputMessage() { - return std::make_shared<OutputMessage>(); + return std::allocate_shared<OutputMessage>(LockfreePoolingAllocator<OutputMessage, OUTPUTMESSAGE_FREE_LIST_CAPACITY>()); } diff --git a/src/server/network/message/outputmessage.hpp b/src/server/network/message/outputmessage.hpp index a7e2e72d63f..291ceb335ef 100644 --- a/src/server/network/message/outputmessage.hpp +++ b/src/server/network/message/outputmessage.hpp @@ -11,7 +11,6 @@ #include "server/network/message/networkmessage.hpp" #include "server/network/connection/connection.hpp" -#include "utils/tools.hpp" class Protocol; @@ -100,7 +99,7 @@ class OutputMessagePool { static OutputMessage_ptr getOutputMessage(); - void addProtocolToAutosend(Protocol_ptr protocol); + void addProtocolToAutosend(const Protocol_ptr &protocol); void removeProtocolFromAutosend(const Protocol_ptr &protocol); private: diff --git a/src/server/network/protocol/protocol.cpp b/src/server/network/protocol/protocol.cpp index 72d6e8f3195..61eda412147 100644 --- a/src/server/network/protocol/protocol.cpp +++ b/src/server/network/protocol/protocol.cpp @@ -14,8 +14,9 @@ #include "server/network/message/outputmessage.hpp" #include "security/rsa.hpp" #include "game/scheduling/dispatcher.hpp" +#include "utils/tools.hpp" -Protocol::Protocol(Connection_ptr initConnection) : +Protocol::Protocol(const Connection_ptr &initConnection) : connectionPtr(initConnection) { } void Protocol::onSendMessage(const OutputMessage_ptr &msg) { @@ -50,8 +51,8 @@ bool Protocol::sendRecvMessageCallback(NetworkMessage &msg) { g_dispatcher().addEvent( [&msg, protocolWeak = std::weak_ptr<Protocol>(shared_from_this())]() { - if (auto protocol = protocolWeak.lock()) { - if (auto protocolConnection = protocol->getConnection()) { + if (const auto &protocol = protocolWeak.lock()) { + if (const auto &protocolConnection = protocol->getConnection()) { protocol->parsePacket(msg); protocolConnection->resumeWork(); } @@ -65,7 +66,7 @@ bool Protocol::sendRecvMessageCallback(NetworkMessage &msg) { bool Protocol::onRecvMessage(NetworkMessage &msg) { if (checksumMethod != CHECKSUM_METHOD_NONE) { - uint32_t recvChecksum = msg.get<uint32_t>(); + const auto recvChecksum = msg.get<uint32_t>(); if (checksumMethod == CHECKSUM_METHOD_SEQUENCE) { if (recvChecksum == 0) { // checksum 0 indicate that the packet should be connection ping - 0x1C packet header @@ -73,8 +74,7 @@ bool Protocol::onRecvMessage(NetworkMessage &msg) { return false; } - uint32_t checksum; - checksum = ++clientSequenceNumber; + const uint32_t checksum = ++clientSequenceNumber; if (clientSequenceNumber >= 0x7FFFFFFF) { clientSequenceNumber = 0; } @@ -85,7 +85,7 @@ bool Protocol::onRecvMessage(NetworkMessage &msg) { } } else { uint32_t checksum; - if (int32_t len = msg.getLength() - msg.getBufferPosition(); + if (const int32_t len = msg.getLength() - msg.getBufferPosition(); len > 0) { checksum = adlerChecksum(msg.getBuffer() + msg.getBufferPosition(), len); } else { @@ -120,7 +120,7 @@ void Protocol::send(OutputMessage_ptr msg) const { } void Protocol::disconnect() const { - if (auto connection = getConnection()) { + if (const auto connection = getConnection()) { connection->close(); } } @@ -223,7 +223,7 @@ bool Protocol::RSA_decrypt(NetworkMessage &msg) { return false; } - auto charData = static_cast<char*>(static_cast<void*>(msg.getBuffer())); + const auto charData = static_cast<char*>(static_cast<void*>(msg.getBuffer())); // Does not break strict aliasing g_RSA().decrypt(charData + msg.getBufferPosition()); return (msg.getByte() == 0); @@ -238,7 +238,7 @@ Connection_ptr Protocol::getConnection() const { } uint32_t Protocol::getIP() const { - if (auto protocolConnection = getConnection()) { + if (const auto protocolConnection = getConnection()) { return protocolConnection->getIP(); } @@ -250,7 +250,9 @@ bool Protocol::compression(OutputMessage &outputMessage) const { return false; } - static const thread_local auto &compress = std::make_unique<ZStream>(); + static thread_local auto compress_ptr = std::make_unique<ZStream>(); + static const auto &compress = compress_ptr; + if (!compress->stream) { return false; } diff --git a/src/server/network/protocol/protocol.hpp b/src/server/network/protocol/protocol.hpp index 86dc533ea35..172c9afba32 100644 --- a/src/server/network/protocol/protocol.hpp +++ b/src/server/network/protocol/protocol.hpp @@ -21,7 +21,7 @@ class NetworkMessage; class Protocol : public std::enable_shared_from_this<Protocol> { public: - explicit Protocol(Connection_ptr initConnection); + explicit Protocol(const Connection_ptr &initConnection); virtual ~Protocol() = default; @@ -61,6 +61,7 @@ class Protocol : public std::enable_shared_from_this<Protocol> { void setXTEAKey(const uint32_t* newKey) { std::ranges::copy(newKey, newKey + 4, this->key.begin()); } + void setChecksumMethod(ChecksumMethods_t method) { checksumMethod = method; } diff --git a/src/server/network/protocol/protocolgame.cpp b/src/server/network/protocol/protocolgame.cpp index ae67bad447f..670e37f3bf4 100644 --- a/src/server/network/protocol/protocolgame.cpp +++ b/src/server/network/protocol/protocolgame.cpp @@ -27,7 +27,6 @@ #include "creatures/players/achievement/player_achievement.hpp" #include "creatures/players/cyclopedia/player_badge.hpp" #include "creatures/players/cyclopedia/player_cyclopedia.hpp" -#include "creatures/players/cyclopedia/player_title.hpp" #include "creatures/players/grouping/familiars.hpp" #include "server/network/protocol/protocolgame.hpp" #include "game/scheduling/dispatcher.hpp" @@ -71,7 +70,7 @@ namespace { return totalIterationCount; } - void addOutfitAndMountBytes(NetworkMessage &msg, std::shared_ptr<Item> item, const CustomAttribute* attribute, const std::string &head, const std::string &body, const std::string &legs, const std::string &feet, bool addAddon = false, bool addByte = false) { + void addOutfitAndMountBytes(NetworkMessage &msg, const std::shared_ptr<Item> &item, const CustomAttribute* attribute, const std::string &head, const std::string &body, const std::string &legs, const std::string &feet, bool addAddon = false, bool addByte = false) { auto look = attribute->getAttribute<uint16_t>(); msg.add<uint16_t>(look); if (look != 0) { @@ -116,7 +115,7 @@ namespace { * @param msg The network message to which the imbuement damage should be added. * @param player Pointer to the player for whom the imbuement damage should be handled. */ - void handleImbuementDamage(NetworkMessage &msg, std::shared_ptr<Player> player) { + void handleImbuementDamage(NetworkMessage &msg, const std::shared_ptr<Player> &player) { bool imbueDmg = false; std::shared_ptr<Item> weapon = player->getWeapon(); if (weapon) { @@ -154,7 +153,7 @@ namespace { * * @param[in] player The pointer to the player whose equipped items are considered. */ - void calculateAbsorbValues(std::shared_ptr<Player> player, NetworkMessage &msg, uint8_t &combats) { + void calculateAbsorbValues(const std::shared_ptr<Player> &player, NetworkMessage &msg, uint8_t &combats) { alignas(16) uint16_t damageModifiers[COMBAT_COUNT] = { 10000, 10000, 10000, 10000, 10000, 10000, 10000, 10000, 10000, 10000, 10000, 10000, 10000, 10000 }; for (int32_t slot = CONST_SLOT_FIRST; slot <= CONST_SLOT_LAST; ++slot) { @@ -162,7 +161,7 @@ namespace { continue; } - std::shared_ptr<Item> item = player->getInventoryItem(static_cast<Slots_t>(slot)); + const auto item = player->getInventoryItem(static_cast<Slots_t>(slot)); if (!item) { continue; } @@ -245,12 +244,12 @@ namespace { } } // namespace -ProtocolGame::ProtocolGame(Connection_ptr initConnection) : +ProtocolGame::ProtocolGame(const Connection_ptr &initConnection) : Protocol(initConnection) { version = CLIENT_VERSION; } -void ProtocolGame::AddItem(NetworkMessage &msg, uint16_t id, uint8_t count, uint8_t tier) { +void ProtocolGame::AddItem(NetworkMessage &msg, uint16_t id, uint8_t count, uint8_t tier) const { const ItemType &it = Item::items[id]; msg.add<uint16_t>(it.id); @@ -309,7 +308,7 @@ void ProtocolGame::AddItem(NetworkMessage &msg, uint16_t id, uint8_t count, uint } } -void ProtocolGame::AddItem(NetworkMessage &msg, std::shared_ptr<Item> item) { +void ProtocolGame::AddItem(NetworkMessage &msg, const std::shared_ptr<Item> &item) { if (!item) { return; } @@ -347,7 +346,7 @@ void ProtocolGame::AddItem(NetworkMessage &msg, std::shared_ptr<Item> item) { if (container && containerType == 0 && container->getHoldingPlayer() == player) { uint32_t lootFlags = 0; uint32_t obtainFlags = 0; - for (auto [category, containerMap] : player->m_managedContainers) { + for (const auto &[category, containerMap] : player->m_managedContainers) { if (!isValidObjectCategory(category)) { continue; } @@ -370,7 +369,7 @@ void ProtocolGame::AddItem(NetworkMessage &msg, std::shared_ptr<Item> item) { // Quiver ammo count if (container && containerType == 0 && item->isQuiver() && player->getThing(CONST_SLOT_RIGHT) == item) { uint16_t ammoTotal = 0; - for (std::shared_ptr<Item> listItem : container->getItemList()) { + for (const std::shared_ptr<Item> &listItem : container->getItemList()) { if (player->getLevel() >= Item::items[listItem->getID()].minReqLevel) { ammoTotal += listItem->getItemCount(); } @@ -705,7 +704,7 @@ void ProtocolGame::onRecvFirstMessage(NetworkMessage &msg) { return; } - OperatingSystem_t operatingSystem = static_cast<OperatingSystem_t>(msg.get<uint16_t>()); + auto operatingSystem = static_cast<OperatingSystem_t>(msg.get<uint16_t>()); version = msg.get<uint16_t>(); // Protocol version g_logger().trace("Protocol version: {}", version); @@ -754,7 +753,7 @@ void ProtocolGame::onRecvFirstMessage(NetworkMessage &msg) { std::ostringstream ss; std::string sessionKey = msg.getString(); std::string accountDescriptor = sessionKey; - std::string password = ""; + std::string password; if (authType != "session") { size_t pos = sessionKey.find('\n'); @@ -791,7 +790,7 @@ void ProtocolGame::onRecvFirstMessage(NetworkMessage &msg) { foundPlayer->client->disconnectClient("You are already connected through another client. Please use only one client at a time!"); } - uint32_t timeStamp = msg.get<uint32_t>(); + auto timeStamp = msg.get<uint32_t>(); uint8_t randNumber = msg.getByte(); if (challengeTimestamp != timeStamp || challengeRandom != randNumber) { disconnect(); @@ -799,7 +798,7 @@ void ProtocolGame::onRecvFirstMessage(NetworkMessage &msg) { } // OTCv8 version detection - uint16_t otcV8StringLength = msg.get<uint16_t>(); + auto otcV8StringLength = msg.get<uint16_t>(); if (otcV8StringLength == 5 && msg.getString(5) == "OTCv8") { otclientV8 = msg.get<uint16_t>(); // 253, 260, 261, ... } @@ -885,7 +884,7 @@ void ProtocolGame::onConnect() { // To support 11.10-, not have problems with 11.11+ output->add<uint32_t>(adlerChecksum(output->getOutputBuffer() + sizeof(uint32_t), 8)); - send(std::move(output)); + send(output); } void ProtocolGame::disconnectClient(const std::string &message) const { @@ -941,7 +940,6 @@ void ProtocolGame::parsePacketDead(uint8_t recvbyte) { g_game().removePlayerUniqueLogin(player->getName()); } disconnect(); - IOLoginData::updateOnlineStatus(player->getGUID(), false); return; } @@ -1378,12 +1376,12 @@ void ProtocolGame::parseHotkeyEquip(NetworkMessage &msg) { return; } - uint16_t itemId = msg.get<uint16_t>(); - uint8_t tier = msg.get<uint8_t>(); + auto itemId = msg.get<uint16_t>(); + auto tier = msg.get<uint8_t>(); g_game().playerEquipItem(player->getID(), itemId, Item::items[itemId].upgradeClassification > 0, tier); } -void ProtocolGame::GetTileDescription(std::shared_ptr<Tile> tile, NetworkMessage &msg) { +void ProtocolGame::GetTileDescription(const std::shared_ptr<Tile> &tile, NetworkMessage &msg) { if (oldProtocol) { msg.add<uint16_t>(0x00); // Env effects } @@ -1414,8 +1412,7 @@ void ProtocolGame::GetTileDescription(std::shared_ptr<Tile> tile, NetworkMessage const CreatureVector* creatures = tile->getCreatures(); if (creatures) { bool playerAdded = false; - for (auto it = creatures->rbegin(); it != creatures->rend(); ++it) { - std::shared_ptr<Creature> creature = *it; + for (auto creature : std::ranges::reverse_view(*creatures)) { if (!player->canSeeCreature(creature)) { continue; } @@ -1539,7 +1536,7 @@ void ProtocolGame::checkCreatureAsKnown(uint32_t id, bool &known, uint32_t &remo } } -bool ProtocolGame::canSee(std::shared_ptr<Creature> c) const { +bool ProtocolGame::canSee(const std::shared_ptr<Creature> &c) const { if (!c || !player || c->isRemoved()) { return false; } @@ -1592,12 +1589,12 @@ void ProtocolGame::parseChannelExclude(NetworkMessage &msg) { } void ProtocolGame::parseOpenChannel(NetworkMessage &msg) { - uint16_t channelId = msg.get<uint16_t>(); + auto channelId = msg.get<uint16_t>(); g_game().playerOpenChannel(player->getID(), channelId); } void ProtocolGame::parseCloseChannel(NetworkMessage &msg) { - uint16_t channelId = msg.get<uint16_t>(); + auto channelId = msg.get<uint16_t>(); g_game().playerCloseChannel(player->getID(), channelId); } @@ -1659,7 +1656,7 @@ void ProtocolGame::parseSetOutfit(NetworkMessage &msg) { } uint16_t startBufferPosition = msg.getBufferPosition(); - Module* outfitModule = g_modules().getEventByRecvbyte(0xD3, false); + const auto &outfitModule = g_modules().getEventByRecvbyte(0xD3, false); if (outfitModule) { outfitModule->executeOnRecvbyte(player, msg); } @@ -1694,7 +1691,7 @@ void ProtocolGame::parseSetOutfit(NetworkMessage &msg) { msg.get<uint32_t>(); } else if (outfitType == 2) { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); newOutfit.lookMount = msg.get<uint16_t>(); newOutfit.lookMountHead = std::min<uint8_t>(132, msg.getByte()); @@ -1715,7 +1712,7 @@ void ProtocolGame::parseToggleMount(NetworkMessage &msg) { void ProtocolGame::parseApplyImbuement(NetworkMessage &msg) { uint8_t slot = msg.getByte(); - uint32_t imbuementId = msg.get<uint32_t>(); + auto imbuementId = msg.get<uint32_t>(); bool protectionCharm = msg.getByte() != 0x00; g_game().playerApplyImbuement(player->getID(), imbuementId, slot, protectionCharm); } @@ -1731,7 +1728,7 @@ void ProtocolGame::parseCloseImbuementWindow(NetworkMessage &) { void ProtocolGame::parseUseItem(NetworkMessage &msg) { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); uint8_t index = msg.getByte(); g_game().playerUseItem(player->getID(), pos, stackpos, index, itemId); @@ -1739,19 +1736,19 @@ void ProtocolGame::parseUseItem(NetworkMessage &msg) { void ProtocolGame::parseUseItemEx(NetworkMessage &msg) { Position fromPos = msg.getPosition(); - uint16_t fromItemId = msg.get<uint16_t>(); + auto fromItemId = msg.get<uint16_t>(); uint8_t fromStackPos = msg.getByte(); Position toPos = msg.getPosition(); - uint16_t toItemId = msg.get<uint16_t>(); + auto toItemId = msg.get<uint16_t>(); uint8_t toStackPos = msg.getByte(); g_game().playerUseItemEx(player->getID(), fromPos, fromStackPos, fromItemId, toPos, toStackPos, toItemId); } void ProtocolGame::parseUseWithCreature(NetworkMessage &msg) { Position fromPos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t fromStackPos = msg.getByte(); - uint32_t creatureId = msg.get<uint32_t>(); + auto creatureId = msg.get<uint32_t>(); g_game().playerUseWithCreature(player->getID(), fromPos, fromStackPos, creatureId, itemId); } @@ -1777,7 +1774,7 @@ void ProtocolGame::parseTeleport(NetworkMessage &msg) { void ProtocolGame::parseThrow(NetworkMessage &msg) { Position fromPos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t fromStackpos = msg.getByte(); Position toPos = msg.getPosition(); uint8_t count = msg.getByte(); @@ -1789,13 +1786,13 @@ void ProtocolGame::parseThrow(NetworkMessage &msg) { void ProtocolGame::parseLookAt(NetworkMessage &msg) { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); g_game().playerLookAt(player->getID(), itemId, pos, stackpos); } void ProtocolGame::parseLookInBattleList(NetworkMessage &msg) { - uint32_t creatureId = msg.get<uint32_t>(); + auto creatureId = msg.get<uint32_t>(); g_game().playerLookInBattleList(player->getID(), creatureId); } @@ -1806,7 +1803,7 @@ void ProtocolGame::parseQuickLoot(NetworkMessage &msg) { uint8_t variant = msg.getByte(); const Position pos = msg.getPosition(); - uint16_t itemId = 0; + auto itemId = 0; uint8_t stackpos = 0; bool lootAllCorpses = true; bool autoLoot = true; @@ -1820,7 +1817,6 @@ void ProtocolGame::parseQuickLoot(NetworkMessage &msg) { autoLoot = false; } g_logger().debug("[{}] variant {}, pos {}, itemId {}, stackPos {}", __FUNCTION__, variant, pos.toString(), itemId, stackpos); - g_game().playerQuickLoot(player->getID(), pos, itemId, stackpos, nullptr, lootAllCorpses, autoLoot); } @@ -1831,32 +1827,32 @@ void ProtocolGame::parseLootContainer(NetworkMessage &msg) { uint8_t action = msg.getByte(); if (action == 0) { - ObjectCategory_t category = (ObjectCategory_t)msg.getByte(); + auto category = static_cast<ObjectCategory_t>(msg.getByte()); Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); g_game().playerSetManagedContainer(player->getID(), category, pos, itemId, stackpos, true); } else if (action == 1) { - ObjectCategory_t category = (ObjectCategory_t)msg.getByte(); + auto category = static_cast<ObjectCategory_t>(msg.getByte()); g_game().playerClearManagedContainer(player->getID(), category, true); } else if (action == 2) { - ObjectCategory_t category = (ObjectCategory_t)msg.getByte(); + auto category = static_cast<ObjectCategory_t>(msg.getByte()); g_game().playerOpenManagedContainer(player->getID(), category, true); } else if (action == 3) { bool useMainAsFallback = msg.getByte() == 1; g_game().playerSetQuickLootFallback(player->getID(), useMainAsFallback); } else if (action == 4) { - ObjectCategory_t category = (ObjectCategory_t)msg.getByte(); + auto category = static_cast<ObjectCategory_t>(msg.getByte()); Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); g_logger().debug("[{}] action {}, category {}, pos {}, itemId {}, stackPos {}", __FUNCTION__, action, static_cast<uint8_t>(category), pos.toString(), itemId, stackpos); g_game().playerSetManagedContainer(player->getID(), category, pos, itemId, stackpos, false); } else if (action == 5) { - ObjectCategory_t category = (ObjectCategory_t)msg.getByte(); + auto category = static_cast<ObjectCategory_t>(msg.getByte()); g_game().playerClearManagedContainer(player->getID(), category, false); } else if (action == 6) { - ObjectCategory_t category = (ObjectCategory_t)msg.getByte(); + auto category = static_cast<ObjectCategory_t>(msg.getByte()); g_game().playerOpenManagedContainer(player->getID(), category, false); } @@ -1868,10 +1864,10 @@ void ProtocolGame::parseQuickLootBlackWhitelist(NetworkMessage &msg) { return; } - QuickLootFilter_t filter = (QuickLootFilter_t)msg.getByte(); + auto filter = (QuickLootFilter_t)msg.getByte(); std::vector<uint16_t> listedItems; - uint16_t size = msg.get<uint16_t>(); + auto size = msg.get<uint16_t>(); listedItems.reserve(size); for (int i = 0; i < size; i++) { @@ -1885,7 +1881,7 @@ void ProtocolGame::parseSay(NetworkMessage &msg) { std::string receiver; uint16_t channelId {}; - SpeakClasses type = static_cast<SpeakClasses>(msg.getByte()); + auto type = static_cast<SpeakClasses>(msg.getByte()); switch (type) { case TALKTYPE_PRIVATE_TO: case TALKTYPE_PRIVATE_RED_TO: @@ -1930,38 +1926,38 @@ void ProtocolGame::parseFightModes(NetworkMessage &msg) { } void ProtocolGame::parseAttack(NetworkMessage &msg) { - uint32_t creatureId = msg.get<uint32_t>(); + auto creatureId = msg.get<uint32_t>(); // msg.get<uint32_t>(); creatureId (same as above) g_game().playerSetAttackedCreature(player->getID(), creatureId); } void ProtocolGame::parseFollow(NetworkMessage &msg) { - uint32_t creatureId = msg.get<uint32_t>(); + auto creatureId = msg.get<uint32_t>(); // msg.get<uint32_t>(); creatureId (same as above) g_game().playerFollowCreature(player->getID(), creatureId); } void ProtocolGame::parseTextWindow(NetworkMessage &msg) { - uint32_t windowTextId = msg.get<uint32_t>(); + auto windowTextId = msg.get<uint32_t>(); const std::string newText = msg.getString(); g_game().playerWriteItem(player->getID(), windowTextId, newText); } void ProtocolGame::parseHouseWindow(NetworkMessage &msg) { uint8_t doorId = msg.getByte(); - uint32_t id = msg.get<uint32_t>(); + auto id = msg.get<uint32_t>(); const std::string text = msg.getString(); g_game().playerUpdateHouseWindow(player->getID(), doorId, id, text); } void ProtocolGame::parseLookInShop(NetworkMessage &msg) { - uint16_t id = msg.get<uint16_t>(); + auto id = msg.get<uint16_t>(); uint8_t count = msg.getByte(); g_game().playerLookInShop(player->getID(), id, count); } void ProtocolGame::parsePlayerBuyOnShop(NetworkMessage &msg) { - uint16_t id = msg.get<uint16_t>(); + auto id = msg.get<uint16_t>(); uint8_t count = msg.getByte(); uint16_t amount = oldProtocol ? static_cast<uint16_t>(msg.getByte()) : msg.get<uint16_t>(); bool ignoreCap = msg.getByte() != 0; @@ -1970,7 +1966,7 @@ void ProtocolGame::parsePlayerBuyOnShop(NetworkMessage &msg) { } void ProtocolGame::parsePlayerSellOnShop(NetworkMessage &msg) { - uint16_t id = msg.get<uint16_t>(); + auto id = msg.get<uint16_t>(); uint8_t count = std::max(msg.getByte(), (uint8_t)1); uint16_t amount = oldProtocol ? static_cast<uint16_t>(msg.getByte()) : msg.get<uint16_t>(); bool ignoreEquipped = msg.getByte() != 0; @@ -1980,9 +1976,9 @@ void ProtocolGame::parsePlayerSellOnShop(NetworkMessage &msg) { void ProtocolGame::parseRequestTrade(NetworkMessage &msg) { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); - uint32_t playerId = msg.get<uint32_t>(); + auto playerId = msg.get<uint32_t>(); g_game().playerRequestTrade(player->getID(), pos, stackpos, playerId, itemId); } @@ -1998,13 +1994,13 @@ void ProtocolGame::parseAddVip(NetworkMessage &msg) { } void ProtocolGame::parseRemoveVip(NetworkMessage &msg) { - uint32_t guid = msg.get<uint32_t>(); + auto guid = msg.get<uint32_t>(); g_game().playerRequestRemoveVip(player->getID(), guid); } void ProtocolGame::parseEditVip(NetworkMessage &msg) { std::vector<uint8_t> vipGroupsId; - uint32_t guid = msg.get<uint32_t>(); + auto guid = msg.get<uint32_t>(); const std::string description = msg.getString(); uint32_t icon = std::min<uint32_t>(10, msg.get<uint32_t>()); // 10 is max icon in 9.63 bool notify = msg.getByte() != 0; @@ -2044,7 +2040,7 @@ void ProtocolGame::parseVipGroupActions(NetworkMessage &msg) { void ProtocolGame::parseRotateItem(NetworkMessage &msg) { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); const auto &itemType = Item::items[itemId]; if (itemType.isPodium) { @@ -2056,7 +2052,7 @@ void ProtocolGame::parseRotateItem(NetworkMessage &msg) { void ProtocolGame::parseWrapableItem(NetworkMessage &msg) { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); g_game().playerWrapableItem(player->getID(), pos, stackpos, itemId); } @@ -2071,7 +2067,7 @@ void ProtocolGame::parseInspectionObject(NetworkMessage &msg) { Position pos = msg.getPosition(); g_game().playerInspectItem(player, pos); } else if (inspectionType == INSPECT_NPCTRADE || inspectionType == INSPECT_CYCLOPEDIA) { - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint16_t itemCount = msg.getByte(); g_game().playerInspectItem(player, itemId, static_cast<int8_t>(itemCount), (inspectionType == INSPECT_CYCLOPEDIA)); } @@ -2087,7 +2083,7 @@ void ProtocolGame::sendSessionEndInformation(SessionEndInformations information) disconnect(); } -void ProtocolGame::sendItemInspection(uint16_t itemId, uint8_t itemCount, std::shared_ptr<Item> item, bool cyclopedia) { +void ProtocolGame::sendItemInspection(uint16_t itemId, uint8_t itemCount, const std::shared_ptr<Item> &item, bool cyclopedia) { if (oldProtocol) { return; } @@ -2152,9 +2148,9 @@ void ProtocolGame::parseHighscores(NetworkMessage &msg) { return; } - HighscoreType_t type = static_cast<HighscoreType_t>(msg.getByte()); + auto type = static_cast<HighscoreType_t>(msg.getByte()); uint8_t category = msg.getByte(); - uint32_t vocation = msg.get<uint32_t>(); + auto vocation = msg.get<uint32_t>(); uint16_t page = 1; const std::string worldName = msg.getString(); msg.getByte(); // Game World Category @@ -2174,7 +2170,7 @@ void ProtocolGame::parseTaskHuntingAction(NetworkMessage &msg) { uint8_t slot = msg.getByte(); uint8_t action = msg.getByte(); bool upgrade = msg.getByte() != 0; - uint16_t raceId = msg.get<uint16_t>(); + auto raceId = msg.get<uint16_t>(); if (!g_configManager().getBoolean(TASK_HUNTING_ENABLED)) { return; @@ -2277,7 +2273,7 @@ void ProtocolGame::parseConfigureShowOffSocket(NetworkMessage &msg) { } Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); g_game().playerConfigureShowOffSocket(player->getID(), pos, stackpos, itemId); } @@ -2308,7 +2304,7 @@ void ProtocolGame::parseBestiarysendRaces() { msg.add<uint16_t>(BESTY_RACE_LAST); std::map<uint16_t, std::string> mtype_list = g_game().getBestiaryList(); for (uint8_t i = BESTY_RACE_FIRST; i <= BESTY_RACE_LAST; i++) { - std::string BestClass = ""; + std::string BestClass; uint16_t count = 0; for (const auto &rit : mtype_list) { const auto mtype = g_monsters().getMonsterType(rit.second); @@ -2346,8 +2342,8 @@ void ProtocolGame::parseBestiarysendMonsterData(NetworkMessage &msg) { return; } - uint16_t raceId = msg.get<uint16_t>(); - std::string Class = ""; + auto raceId = msg.get<uint16_t>(); + std::string Class; std::shared_ptr<MonsterType> mtype = nullptr; std::map<uint16_t, std::string> mtype_list = g_game().getBestiaryList(); @@ -2444,9 +2440,9 @@ void ProtocolGame::parseBestiarysendMonsterData(NetworkMessage &msg) { std::map<uint8_t, int16_t> elements = g_iobestiary().getMonsterElements(mtype); newmsg.addByte(elements.size()); - for (auto it = std::begin(elements), end = std::end(elements); it != end; it++) { - newmsg.addByte(it->first); - newmsg.add<uint16_t>(it->second); + for (auto &element : elements) { + newmsg.addByte(element.first); + newmsg.add<uint16_t>(element.second); } newmsg.add<uint16_t>(1); @@ -2469,7 +2465,7 @@ void ProtocolGame::parseBestiarysendMonsterData(NetworkMessage &msg) { } void ProtocolGame::parseCyclopediaMonsterTracker(NetworkMessage &msg) { - uint16_t monsterRaceId = msg.get<uint16_t>(); + auto monsterRaceId = msg.get<uint16_t>(); // Bosstiary tracker: 0 = disabled, 1 = enabled // Bestiary tracker: 1 = enabled auto trackerButtonType = msg.getByte(); @@ -2724,16 +2720,16 @@ void ProtocolGame::parsePartyAnalyzerAction(NetworkMessage &msg) const { return; } - PartyAnalyzerAction_t action = static_cast<PartyAnalyzerAction_t>(msg.getByte()); + auto action = static_cast<PartyAnalyzerAction_t>(msg.getByte()); if (action == PARTYANALYZERACTION_RESET) { party->resetAnalyzer(); } else if (action == PARTYANALYZERACTION_PRICETYPE) { party->switchAnalyzerPriceType(); } else if (action == PARTYANALYZERACTION_PRICEVALUE) { - uint16_t size = msg.get<uint16_t>(); + auto size = msg.get<uint16_t>(); for (uint16_t i = 1; i <= size; i++) { - uint16_t itemId = msg.get<uint16_t>(); - uint64_t price = msg.get<uint64_t>(); + auto itemId = msg.get<uint16_t>(); + auto price = msg.get<uint64_t>(); player->setItemCustomPrice(itemId, price); } party->reloadPrices(); @@ -2757,7 +2753,7 @@ void ProtocolGame::parseLeaderFinderWindow(NetworkMessage &msg) { break; } case 2: { - uint32_t memberID = msg.get<uint32_t>(); + auto memberID = msg.get<uint32_t>(); std::shared_ptr<Player> member = g_game().getPlayerByGUID(memberID); if (!member) { return; @@ -2815,7 +2811,7 @@ void ProtocolGame::parseMemberFinderWindow(NetworkMessage &msg) { if (action == 0) { player->sendTeamFinderList(); } else { - uint32_t leaderID = msg.get<uint32_t>(); + auto leaderID = msg.get<uint32_t>(); std::shared_ptr<Player> leader = g_game().getPlayerByGUID(leaderID); if (!leader) { return; @@ -2846,9 +2842,9 @@ void ProtocolGame::parseSendBuyCharmRune(NetworkMessage &msg) { return; } - charmRune_t runeID = static_cast<charmRune_t>(msg.getByte()); + auto runeID = static_cast<charmRune_t>(msg.getByte()); uint8_t action = msg.getByte(); - uint16_t raceid = msg.get<uint16_t>(); + auto raceid = msg.get<uint16_t>(); g_iobestiary().sendBuyCharmRune(player, runeID, action, raceid); } @@ -2955,14 +2951,14 @@ void ProtocolGame::parseBestiarysendCreatures(NetworkMessage &msg) { std::ostringstream ss; std::map<uint16_t, std::string> race = {}; - std::string text = ""; + std::string text; uint8_t search = msg.getByte(); if (search == 1) { - uint16_t monsterAmount = msg.get<uint16_t>(); + auto monsterAmount = msg.get<uint16_t>(); std::map<uint16_t, std::string> mtype_list = g_game().getBestiaryList(); for (uint16_t monsterCount = 1; monsterCount <= monsterAmount; monsterCount++) { - uint16_t raceid = msg.get<uint16_t>(); + auto raceid = msg.get<uint16_t>(); if (player->getBestiaryKillCount(raceid) > 0) { auto it = mtype_list.find(raceid); if (it != mtype_list.end()) { @@ -3033,7 +3029,7 @@ void ProtocolGame::parseBugReport(NetworkMessage &msg) { } void ProtocolGame::parseGreet(NetworkMessage &msg) { - uint32_t npcId = msg.get<uint32_t>(); + auto npcId = msg.get<uint32_t>(); g_game().playerNpcGreet(player->getID(), npcId); } @@ -3078,22 +3074,22 @@ void ProtocolGame::parseSendResourceBalance() { } void ProtocolGame::parseInviteToParty(NetworkMessage &msg) { - uint32_t targetId = msg.get<uint32_t>(); + auto targetId = msg.get<uint32_t>(); g_game().playerInviteToParty(player->getID(), targetId); } void ProtocolGame::parseJoinParty(NetworkMessage &msg) { - uint32_t targetId = msg.get<uint32_t>(); + auto targetId = msg.get<uint32_t>(); g_game().playerJoinParty(player->getID(), targetId); } void ProtocolGame::parseRevokePartyInvite(NetworkMessage &msg) { - uint32_t targetId = msg.get<uint32_t>(); + auto targetId = msg.get<uint32_t>(); g_game().playerRevokePartyInvitation(player->getID(), targetId); } void ProtocolGame::parsePassPartyLeadership(NetworkMessage &msg) { - uint32_t targetId = msg.get<uint32_t>(); + auto targetId = msg.get<uint32_t>(); g_game().playerPassPartyLeadership(player->getID(), targetId); } @@ -3103,7 +3099,7 @@ void ProtocolGame::parseEnableSharedPartyExperience(NetworkMessage &msg) { } void ProtocolGame::parseQuestLine(NetworkMessage &msg) { - uint16_t questId = msg.get<uint16_t>(); + auto questId = msg.get<uint16_t>(); g_game().playerShowQuestLine(player->getID(), questId); } @@ -3119,8 +3115,8 @@ void ProtocolGame::parseMarketBrowse(NetworkMessage &msg) { } else if ((oldProtocol && browseId == MARKETREQUEST_OWN_HISTORY_OLD) || (!oldProtocol && browseId == MARKETREQUEST_OWN_HISTORY)) { g_game().playerBrowseMarketOwnHistory(player->getID()); } else if (!oldProtocol) { - uint16_t itemId = msg.get<uint16_t>(); - uint8_t tier = msg.get<uint8_t>(); + auto itemId = msg.get<uint16_t>(); + auto tier = msg.get<uint8_t>(); player->sendMarketEnter(player->getLastDepotId()); g_game().playerBrowseMarket(player->getID(), itemId, tier); } else { @@ -3130,13 +3126,13 @@ void ProtocolGame::parseMarketBrowse(NetworkMessage &msg) { void ProtocolGame::parseMarketCreateOffer(NetworkMessage &msg) { uint8_t type = msg.getByte(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t itemTier = 0; if (!oldProtocol && Item::items[itemId].upgradeClassification > 0) { itemTier = msg.getByte(); } - uint16_t amount = msg.get<uint16_t>(); + auto amount = msg.get<uint16_t>(); uint64_t price = oldProtocol ? static_cast<uint64_t>(msg.get<uint32_t>()) : msg.get<uint64_t>(); bool anonymous = (msg.getByte() != 0); if (amount > 0 && price > 0) { @@ -3145,8 +3141,8 @@ void ProtocolGame::parseMarketCreateOffer(NetworkMessage &msg) { } void ProtocolGame::parseMarketCancelOffer(NetworkMessage &msg) { - uint32_t timestamp = msg.get<uint32_t>(); - uint16_t counter = msg.get<uint16_t>(); + auto timestamp = msg.get<uint32_t>(); + auto counter = msg.get<uint16_t>(); if (counter > 0) { g_game().playerCancelMarketOffer(player->getID(), timestamp, counter); } @@ -3155,9 +3151,9 @@ void ProtocolGame::parseMarketCancelOffer(NetworkMessage &msg) { } void ProtocolGame::parseMarketAcceptOffer(NetworkMessage &msg) { - uint32_t timestamp = msg.get<uint32_t>(); - uint16_t counter = msg.get<uint16_t>(); - uint16_t amount = msg.get<uint16_t>(); + auto timestamp = msg.get<uint32_t>(); + auto counter = msg.get<uint16_t>(); + auto amount = msg.get<uint16_t>(); if (amount > 0 && counter > 0) { g_game().playerAcceptMarketOffer(player->getID(), timestamp, counter, amount); } @@ -3166,7 +3162,7 @@ void ProtocolGame::parseMarketAcceptOffer(NetworkMessage &msg) { } void ProtocolGame::parseModalWindowAnswer(NetworkMessage &msg) { - uint32_t id = msg.get<uint32_t>(); + auto id = msg.get<uint32_t>(); uint8_t button = msg.getByte(); uint8_t choice = msg.getByte(); g_game().playerAnswerModalWindow(player->getID(), id, button, choice); @@ -3194,7 +3190,7 @@ void ProtocolGame::parseBrowseField(NetworkMessage &msg) { void ProtocolGame::parseSeekInContainer(NetworkMessage &msg) { uint8_t containerId = msg.getByte(); - uint16_t index = msg.get<uint16_t>(); + auto index = msg.get<uint16_t>(); auto primaryType = msg.getByte(); g_game().playerSeekInContainer(player->getID(), containerId, index, primaryType); } @@ -3228,7 +3224,7 @@ void ProtocolGame::sendChannelEvent(uint16_t channelId, const std::string &playe writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit) { +void ProtocolGame::sendCreatureOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit) { if (!canSee(creature)) { return; } @@ -3253,7 +3249,7 @@ void ProtocolGame::sendCreatureOutfit(std::shared_ptr<Creature> creature, const writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureLight(std::shared_ptr<Creature> creature) { +void ProtocolGame::sendCreatureLight(const std::shared_ptr<Creature> &creature) { if (!canSee(creature)) { return; } @@ -3263,7 +3259,7 @@ void ProtocolGame::sendCreatureLight(std::shared_ptr<Creature> creature) { writeToOutputBuffer(msg); } -void ProtocolGame::addCreatureIcon(NetworkMessage &msg, std::shared_ptr<Creature> creature) { +void ProtocolGame::addCreatureIcon(NetworkMessage &msg, const std::shared_ptr<Creature> &creature) { if (!creature || !player || oldProtocol) { return; } @@ -3280,7 +3276,7 @@ void ProtocolGame::addCreatureIcon(NetworkMessage &msg, std::shared_ptr<Creature } } -void ProtocolGame::sendCreatureIcon(std::shared_ptr<Creature> creature) { +void ProtocolGame::sendCreatureIcon(const std::shared_ptr<Creature> &creature) { if (!creature || !player || oldProtocol) { return; } @@ -3312,7 +3308,7 @@ void ProtocolGame::sendTibiaTime(int32_t time) { writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureWalkthrough(std::shared_ptr<Creature> creature, bool walkthrough) { +void ProtocolGame::sendCreatureWalkthrough(const std::shared_ptr<Creature> &creature, bool walkthrough) { if (!canSee(creature)) { return; } @@ -3324,7 +3320,7 @@ void ProtocolGame::sendCreatureWalkthrough(std::shared_ptr<Creature> creature, b writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureShield(std::shared_ptr<Creature> creature) { +void ProtocolGame::sendCreatureShield(const std::shared_ptr<Creature> &creature) { if (!canSee(creature)) { return; } @@ -3336,7 +3332,7 @@ void ProtocolGame::sendCreatureShield(std::shared_ptr<Creature> creature) { writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureEmblem(std::shared_ptr<Creature> creature) { +void ProtocolGame::sendCreatureEmblem(const std::shared_ptr<Creature> &creature) { if (!creature || !canSee(creature) || oldProtocol) { return; } @@ -3358,7 +3354,7 @@ void ProtocolGame::sendCreatureEmblem(std::shared_ptr<Creature> creature) { writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureSkull(std::shared_ptr<Creature> creature) { +void ProtocolGame::sendCreatureSkull(const std::shared_ptr<Creature> &creature) { if (g_game().getWorldType() != WORLD_TYPE_PVP) { return; } @@ -3374,7 +3370,7 @@ void ProtocolGame::sendCreatureSkull(std::shared_ptr<Creature> creature) { writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureType(std::shared_ptr<Creature> creature, uint8_t creatureType) { +void ProtocolGame::sendCreatureType(const std::shared_ptr<Creature> &creature, uint8_t creatureType) { NetworkMessage msg; msg.addByte(0x95); msg.add<uint32_t>(creature->getID()); @@ -3394,7 +3390,7 @@ void ProtocolGame::sendCreatureType(std::shared_ptr<Creature> creature, uint8_t writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureSquare(std::shared_ptr<Creature> creature, SquareColor_t color) { +void ProtocolGame::sendCreatureSquare(const std::shared_ptr<Creature> &creature, SquareColor_t color) { if (!canSee(creature)) { return; } @@ -3543,7 +3539,7 @@ void ProtocolGame::sendCyclopediaCharacterCombatStats() { if (i == SKILL_LIFE_LEECH_CHANCE || i == SKILL_MANA_LEECH_CHANCE) { continue; } - skills_t skill = static_cast<skills_t>(i); + auto skill = static_cast<skills_t>(i); msg.add<uint16_t>(std::min<int32_t>(player->getSkillLevel(skill), std::numeric_limits<uint16_t>::max())); msg.add<uint16_t>(0); } @@ -3727,7 +3723,7 @@ void ProtocolGame::sendCyclopediaCharacterRecentPvPKills(uint16_t page, uint16_t writeToOutputBuffer(msg); } -void ProtocolGame::sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, std::vector<std::pair<Achievement, uint32_t>> achievementsUnlocked) { +void ProtocolGame::sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, const std::vector<std::pair<Achievement, uint32_t>> &achievementsUnlocked) { if (!player || oldProtocol) { return; } @@ -4295,7 +4291,7 @@ void ProtocolGame::sendBasicData() { for (uint16_t sid : spellsList) { auto spell = g_spells().getInstantSpellById(sid); if (spell && spell->getSpellId() > 0) { - validSpells.push_back(spell); + validSpells.emplace_back(spell); } } @@ -4606,7 +4602,7 @@ void ProtocolGame::sendUnjustifiedPoints(const uint8_t &dayProgress, const uint8 writeToOutputBuffer(msg); } -void ProtocolGame::sendContainer(uint8_t cid, std::shared_ptr<Container> container, bool hasParent, uint16_t firstIndex) { +void ProtocolGame::sendContainer(uint8_t cid, const std::shared_ptr<Container> &container, bool hasParent, uint16_t firstIndex) { if (!player) { return; } @@ -4665,7 +4661,7 @@ void ProtocolGame::sendContainer(uint8_t cid, std::shared_ptr<Container> contain msg.addByte(std::min<uint32_t>(maxItemsToSend, containerSize)); uint32_t i = 0; - for (ItemDeque::const_iterator it = itemList.begin() + firstIndex, end = itemList.end(); i < maxItemsToSend && it != end; ++it, ++i) { + for (auto it = itemList.begin() + firstIndex, end = itemList.end(); i < maxItemsToSend && it != end; ++it, ++i) { AddItem(msg, *it); } } @@ -4731,7 +4727,7 @@ void ProtocolGame::sendLootContainers() { msg.addByte(player->quickLootFallbackToMainContainer ? 1 : 0); std::map<ObjectCategory_t, std::pair<std::shared_ptr<Container>, std::shared_ptr<Container>>> managedContainersMap; - for (auto [category, containersPair] : player->m_managedContainers) { + for (const auto &[category, containersPair] : player->m_managedContainers) { if (containersPair.first && !containersPair.first->isRemoved()) { managedContainersMap[category].first = containersPair.first; } @@ -4743,7 +4739,7 @@ void ProtocolGame::sendLootContainers() { auto msgPosition = msg.getBufferPosition(); msg.skipBytes(1); uint8_t containers = 0; - for (auto [category, containersPair] : managedContainersMap) { + for (const auto &[category, containersPair] : managedContainersMap) { if (!isValidObjectCategory(category)) { continue; } @@ -4760,7 +4756,7 @@ void ProtocolGame::sendLootContainers() { writeToOutputBuffer(msg); } -void ProtocolGame::sendLootStats(std::shared_ptr<Item> item, uint8_t count) { +void ProtocolGame::sendLootStats(const std::shared_ptr<Item> &item, uint8_t count) { if (!item) { return; } @@ -4784,7 +4780,7 @@ void ProtocolGame::sendLootStats(std::shared_ptr<Item> item, uint8_t count) { lootedItem = nullptr; } -void ProtocolGame::sendShop(std::shared_ptr<Npc> npc) { +void ProtocolGame::sendShop(const std::shared_ptr<Npc> &npc) { Benchmark brenchmark; NetworkMessage msg; msg.addByte(0x7A); @@ -5678,7 +5674,7 @@ void ProtocolGame::sendForgeHistory(uint8_t page) { uint16_t pageFirstEntry = (0 < historyVectorLen - (currentPage - 1) * 9) ? historyVectorLen - (currentPage - 1) * 9 : 0; uint16_t pageLastEntry = (0 < historyVectorLen - currentPage * 9) ? historyVectorLen - currentPage * 9 : 0; for (uint16_t entry = pageFirstEntry; entry > pageLastEntry; --entry) { - historyPerPage.push_back(historyVector[entry - 1]); + historyPerPage.emplace_back(historyVector[entry - 1]); } auto historyPageToSend = getVectorIterationIncreaseCount(historyPerPage); @@ -6085,7 +6081,7 @@ void ProtocolGame::sendMarketDetail(uint16_t itemId, uint8_t tier) { writeToOutputBuffer(msg); } -void ProtocolGame::sendTradeItemRequest(const std::string &traderName, std::shared_ptr<Item> item, bool ack) { +void ProtocolGame::sendTradeItemRequest(const std::string &traderName, const std::shared_ptr<Item> &item, bool ack) { NetworkMessage msg; if (ack) { @@ -6104,9 +6100,9 @@ void ProtocolGame::sendTradeItemRequest(const std::string &traderName, std::shar for (const auto &containerItem : container->getItemList()) { const auto &tmpContainer = containerItem->getContainer(); if (tmpContainer) { - listContainer.push_back(tmpContainer); + listContainer.emplace_back(tmpContainer); } - itemList.push_back(containerItem); + itemList.emplace_back(containerItem); } // Removes the object after processing everything, avoiding memory usage after freeing @@ -6137,7 +6133,7 @@ void ProtocolGame::sendCloseContainer(uint8_t cid) { writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureTurn(std::shared_ptr<Creature> creature, uint32_t stackPos) { +void ProtocolGame::sendCreatureTurn(const std::shared_ptr<Creature> &creature, uint32_t stackPos) { if (!canSee(creature)) { return; } @@ -6153,7 +6149,7 @@ void ProtocolGame::sendCreatureTurn(std::shared_ptr<Creature> creature, uint32_t writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureSay(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, const Position* pos /* = nullptr*/) { +void ProtocolGame::sendCreatureSay(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, const Position* pos /* = nullptr*/) { NetworkMessage msg; msg.addByte(0xAA); @@ -6189,7 +6185,7 @@ void ProtocolGame::sendCreatureSay(std::shared_ptr<Creature> creature, SpeakClas writeToOutputBuffer(msg); } -void ProtocolGame::sendToChannel(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, uint16_t channelId) { +void ProtocolGame::sendToChannel(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, uint16_t channelId) { NetworkMessage msg; msg.addByte(0xAA); @@ -6231,7 +6227,7 @@ void ProtocolGame::sendToChannel(std::shared_ptr<Creature> creature, SpeakClasse writeToOutputBuffer(msg); } -void ProtocolGame::sendPrivateMessage(std::shared_ptr<Player> speaker, SpeakClasses type, const std::string &text) { +void ProtocolGame::sendPrivateMessage(const std::shared_ptr<Player> &speaker, SpeakClasses type, const std::string &text) { NetworkMessage msg; msg.addByte(0xAA); static uint32_t statementId = 0; @@ -6266,7 +6262,7 @@ void ProtocolGame::sendCancelTarget() { writeToOutputBuffer(msg); } -void ProtocolGame::sendChangeSpeed(std::shared_ptr<Creature> creature, uint16_t speed) { +void ProtocolGame::sendChangeSpeed(const std::shared_ptr<Creature> &creature, uint16_t speed) { NetworkMessage msg; msg.addByte(0x8F); msg.add<uint32_t>(creature->getID()); @@ -6406,7 +6402,7 @@ void ProtocolGame::removeMagicEffect(const Position &pos, uint16_t type) { writeToOutputBuffer(msg); } -void ProtocolGame::sendCreatureHealth(std::shared_ptr<Creature> creature) { +void ProtocolGame::sendCreatureHealth(const std::shared_ptr<Creature> &creature) { if (creature->isHealthHidden()) { return; } @@ -6423,7 +6419,7 @@ void ProtocolGame::sendCreatureHealth(std::shared_ptr<Creature> creature) { writeToOutputBuffer(msg); } -void ProtocolGame::sendPartyCreatureUpdate(std::shared_ptr<Creature> target) { +void ProtocolGame::sendPartyCreatureUpdate(const std::shared_ptr<Creature> &target) { if (!player || oldProtocol) { return; } @@ -6441,7 +6437,7 @@ void ProtocolGame::sendPartyCreatureUpdate(std::shared_ptr<Creature> target) { writeToOutputBuffer(msg); } -void ProtocolGame::sendPartyCreatureShield(std::shared_ptr<Creature> target) { +void ProtocolGame::sendPartyCreatureShield(const std::shared_ptr<Creature> &target) { uint32_t cid = target->getID(); if (!knownCreatureSet.contains(cid)) { sendPartyCreatureUpdate(target); @@ -6455,7 +6451,7 @@ void ProtocolGame::sendPartyCreatureShield(std::shared_ptr<Creature> target) { writeToOutputBuffer(msg); } -void ProtocolGame::sendPartyCreatureSkull(std::shared_ptr<Creature> target) { +void ProtocolGame::sendPartyCreatureSkull(const std::shared_ptr<Creature> &target) { if (g_game().getWorldType() != WORLD_TYPE_PVP) { return; } @@ -6473,7 +6469,7 @@ void ProtocolGame::sendPartyCreatureSkull(std::shared_ptr<Creature> target) { writeToOutputBuffer(msg); } -void ProtocolGame::sendPartyCreatureHealth(std::shared_ptr<Creature> target, uint8_t healthPercent) { +void ProtocolGame::sendPartyCreatureHealth(const std::shared_ptr<Creature> &target, uint8_t healthPercent) { uint32_t cid = target->getID(); if (!knownCreatureSet.contains(cid)) { sendPartyCreatureUpdate(target); @@ -6487,7 +6483,7 @@ void ProtocolGame::sendPartyCreatureHealth(std::shared_ptr<Creature> target, uin writeToOutputBuffer(msg); } -void ProtocolGame::sendPartyPlayerMana(std::shared_ptr<Player> target, uint8_t manaPercent) { +void ProtocolGame::sendPartyPlayerMana(const std::shared_ptr<Player> &target, uint8_t manaPercent) { uint32_t cid = target->getID(); if (!knownCreatureSet.contains(cid)) { sendPartyCreatureUpdate(target); @@ -6505,7 +6501,7 @@ void ProtocolGame::sendPartyPlayerMana(std::shared_ptr<Player> target, uint8_t m writeToOutputBuffer(msg); } -void ProtocolGame::sendPartyCreatureShowStatus(std::shared_ptr<Creature> target, bool showStatus) { +void ProtocolGame::sendPartyCreatureShowStatus(const std::shared_ptr<Creature> &target, bool showStatus) { uint32_t cid = target->getID(); if (!knownCreatureSet.contains(cid)) { sendPartyCreatureUpdate(target); @@ -6523,7 +6519,7 @@ void ProtocolGame::sendPartyCreatureShowStatus(std::shared_ptr<Creature> target, writeToOutputBuffer(msg); } -void ProtocolGame::sendPartyPlayerVocation(std::shared_ptr<Player> target) { +void ProtocolGame::sendPartyPlayerVocation(const std::shared_ptr<Player> &target) { if (!target) { return; } @@ -6546,7 +6542,7 @@ void ProtocolGame::sendPartyPlayerVocation(std::shared_ptr<Player> target) { writeToOutputBuffer(msg); } -void ProtocolGame::sendPlayerVocation(std::shared_ptr<Player> target) { +void ProtocolGame::sendPlayerVocation(const std::shared_ptr<Player> &target) { if (!player || !target || oldProtocol) { return; } @@ -6575,7 +6571,7 @@ void ProtocolGame::sendMapDescription(const Position &pos) { writeToOutputBuffer(msg); } -void ProtocolGame::sendAddTileItem(const Position &pos, uint32_t stackpos, std::shared_ptr<Item> item) { +void ProtocolGame::sendAddTileItem(const Position &pos, uint32_t stackpos, const std::shared_ptr<Item> &item) { if (!canSee(pos)) { return; } @@ -6588,7 +6584,7 @@ void ProtocolGame::sendAddTileItem(const Position &pos, uint32_t stackpos, std:: writeToOutputBuffer(msg); } -void ProtocolGame::sendUpdateTileItem(const Position &pos, uint32_t stackpos, std::shared_ptr<Item> item) { +void ProtocolGame::sendUpdateTileItem(const Position &pos, uint32_t stackpos, const std::shared_ptr<Item> &item) { if (!canSee(pos)) { return; } @@ -6611,7 +6607,7 @@ void ProtocolGame::sendRemoveTileThing(const Position &pos, uint32_t stackpos) { writeToOutputBuffer(msg); } -void ProtocolGame::sendUpdateTileCreature(const Position &pos, uint32_t stackpos, const std::shared_ptr<Creature> creature) { +void ProtocolGame::sendUpdateTileCreature(const Position &pos, uint32_t stackpos, const std::shared_ptr<Creature> &creature) { if (!canSee(pos)) { return; } @@ -6628,7 +6624,7 @@ void ProtocolGame::sendUpdateTileCreature(const Position &pos, uint32_t stackpos writeToOutputBuffer(msg); } -void ProtocolGame::sendUpdateTile(std::shared_ptr<Tile> tile, const Position &pos) { +void ProtocolGame::sendUpdateTile(const std::shared_ptr<Tile> &tile, const Position &pos) { if (!canSee(pos)) { return; } @@ -6686,7 +6682,7 @@ void ProtocolGame::sendAllowBugReport() { writeToOutputBuffer(msg); } -void ProtocolGame::sendAddCreature(std::shared_ptr<Creature> creature, const Position &pos, int32_t stackpos, bool isLogin) { +void ProtocolGame::sendAddCreature(const std::shared_ptr<Creature> &creature, const Position &pos, int32_t stackpos, bool isLogin) { if (!canSee(pos)) { return; } @@ -6841,7 +6837,7 @@ void ProtocolGame::sendAddCreature(std::shared_ptr<Creature> creature, const Pos } } -void ProtocolGame::sendMoveCreature(std::shared_ptr<Creature> creature, const Position &newPos, int32_t newStackPos, const Position &oldPos, int32_t oldStackPos, bool teleport) { +void ProtocolGame::sendMoveCreature(const std::shared_ptr<Creature> &creature, const Position &newPos, int32_t newStackPos, const Position &oldPos, int32_t oldStackPos, bool teleport) { if (creature == player) { if (oldStackPos >= 10) { sendMapDescription(newPos); @@ -6903,7 +6899,7 @@ void ProtocolGame::sendMoveCreature(std::shared_ptr<Creature> creature, const Po } } -void ProtocolGame::sendInventoryItem(Slots_t slot, std::shared_ptr<Item> item) { +void ProtocolGame::sendInventoryItem(Slots_t slot, const std::shared_ptr<Item> &item) { NetworkMessage msg; if (item) { msg.addByte(0x78); @@ -6945,7 +6941,7 @@ void ProtocolGame::sendInventoryIds() { writeToOutputBuffer(msg); } -void ProtocolGame::sendAddContainerItem(uint8_t cid, uint16_t slot, std::shared_ptr<Item> item) { +void ProtocolGame::sendAddContainerItem(uint8_t cid, uint16_t slot, const std::shared_ptr<Item> &item) { NetworkMessage msg; msg.addByte(0x70); msg.addByte(cid); @@ -6954,7 +6950,7 @@ void ProtocolGame::sendAddContainerItem(uint8_t cid, uint16_t slot, std::shared_ writeToOutputBuffer(msg); } -void ProtocolGame::sendUpdateContainerItem(uint8_t cid, uint16_t slot, std::shared_ptr<Item> item) { +void ProtocolGame::sendUpdateContainerItem(uint8_t cid, uint16_t slot, const std::shared_ptr<Item> &item) { NetworkMessage msg; msg.addByte(0x71); msg.addByte(cid); @@ -6963,7 +6959,7 @@ void ProtocolGame::sendUpdateContainerItem(uint8_t cid, uint16_t slot, std::shar writeToOutputBuffer(msg); } -void ProtocolGame::sendRemoveContainerItem(uint8_t cid, uint16_t slot, std::shared_ptr<Item> lastItem) { +void ProtocolGame::sendRemoveContainerItem(uint8_t cid, uint16_t slot, const std::shared_ptr<Item> &lastItem) { NetworkMessage msg; msg.addByte(0x72); msg.addByte(cid); @@ -6976,7 +6972,7 @@ void ProtocolGame::sendRemoveContainerItem(uint8_t cid, uint16_t slot, std::shar writeToOutputBuffer(msg); } -void ProtocolGame::sendTextWindow(uint32_t windowTextId, std::shared_ptr<Item> item, uint16_t maxlen, bool canWrite) { +void ProtocolGame::sendTextWindow(uint32_t windowTextId, const std::shared_ptr<Item> &item, uint16_t maxlen, bool canWrite) { NetworkMessage msg; msg.addByte(0x96); msg.add<uint32_t>(windowTextId); @@ -7085,7 +7081,7 @@ void ProtocolGame::sendOutfitWindow() { std::vector<std::shared_ptr<Mount>> mounts; for (const auto &mount : g_game().mounts.getMounts()) { if (player->hasMount(mount)) { - mounts.push_back(mount); + mounts.emplace_back(mount); } } @@ -7240,7 +7236,7 @@ void ProtocolGame::sendOutfitWindow() { writeToOutputBuffer(msg); } -void ProtocolGame::sendPodiumWindow(std::shared_ptr<Item> podium, const Position &position, uint16_t itemId, uint8_t stackpos) { +void ProtocolGame::sendPodiumWindow(const std::shared_ptr<Item> &podium, const Position &position, uint16_t itemId, uint8_t stackpos) { if (!podium || oldProtocol) { g_logger().error("[{}] item is nullptr", __FUNCTION__); return; @@ -7456,7 +7452,7 @@ void ProtocolGame::sendPreyData(const std::unique_ptr<PreySlot> &slot) { std::vector<uint16_t> validRaceIds; for (auto raceId : slot->raceIdList) { if (g_monsters().getMonsterTypeByRaceId(raceId)) { - validRaceIds.push_back(raceId); + validRaceIds.emplace_back(raceId); } else { g_logger().error("[ProtocolGame::sendPreyData] - Unknown monster type raceid: {}, removing prey slot from player {}", raceId, player->getName()); // Remove wrong raceid from slot @@ -7622,7 +7618,7 @@ void ProtocolGame::sendModalWindow(const ModalWindow &modalWindow) { } ////////////// Add common messages -void ProtocolGame::AddCreature(NetworkMessage &msg, std::shared_ptr<Creature> creature, bool known, uint32_t remove) { +void ProtocolGame::AddCreature(NetworkMessage &msg, const std::shared_ptr<Creature> &creature, bool known, uint32_t remove) { CreatureType_t creatureType = creature->getType(); std::shared_ptr<Player> otherPlayer = creature->getPlayer(); @@ -7805,7 +7801,7 @@ void ProtocolGame::AddPlayerSkills(NetworkMessage &msg) { if (oldProtocol) { for (uint8_t i = SKILL_FIRST; i <= SKILL_FISHING; ++i) { - skills_t skill = static_cast<skills_t>(i); + auto skill = static_cast<skills_t>(i); msg.add<uint16_t>(std::min<int32_t>(player->getSkillLevel(skill), std::numeric_limits<uint16_t>::max())); msg.add<uint16_t>(player->getBaseSkill(skill)); msg.addByte(std::min<uint8_t>(100, static_cast<uint8_t>(player->getSkillPercent(skill)))); @@ -7817,7 +7813,7 @@ void ProtocolGame::AddPlayerSkills(NetworkMessage &msg) { msg.add<uint16_t>(player->getMagicLevelPercent() * 100); for (uint8_t i = SKILL_FIRST; i <= SKILL_FISHING; ++i) { - skills_t skill = static_cast<skills_t>(i); + auto skill = static_cast<skills_t>(i); msg.add<uint16_t>(std::min<int32_t>(player->getSkillLevel(skill), std::numeric_limits<uint16_t>::max())); msg.add<uint16_t>(player->getBaseSkill(skill)); msg.add<uint16_t>(player->getLoyaltySkill(skill)); @@ -7829,7 +7825,7 @@ void ProtocolGame::AddPlayerSkills(NetworkMessage &msg) { if (!oldProtocol && (i == SKILL_LIFE_LEECH_CHANCE || i == SKILL_MANA_LEECH_CHANCE)) { continue; } - skills_t skill = static_cast<skills_t>(i); + auto skill = static_cast<skills_t>(i); msg.add<uint16_t>(std::min<int32_t>(player->getSkillLevel(skill), std::numeric_limits<uint16_t>::max())); msg.add<uint16_t>(player->getBaseSkill(skill)); } @@ -7893,7 +7889,7 @@ void ProtocolGame::addImbuementInfo(NetworkMessage &msg, uint16_t imbuementId) c msg.add<uint32_t>(baseImbuement->protectionPrice); } -void ProtocolGame::openImbuementWindow(std::shared_ptr<Item> item) { +void ProtocolGame::openImbuementWindow(const std::shared_ptr<Item> &item) { if (!item || item->isRemoved()) { return; } @@ -7960,7 +7956,7 @@ void ProtocolGame::sendMessageDialog(const std::string &message) { writeToOutputBuffer(msg); } -void ProtocolGame::sendImbuementResult(const std::string message) { +void ProtocolGame::sendImbuementResult(const std::string &message) { NetworkMessage msg; msg.addByte(0xED); msg.addByte(0x01); @@ -7992,7 +7988,7 @@ void ProtocolGame::sendSpecialContainersAvailable() { writeToOutputBuffer(msg); } -void ProtocolGame::updatePartyTrackerAnalyzer(const std::shared_ptr<Party> party) { +void ProtocolGame::updatePartyTrackerAnalyzer(const std::shared_ptr<Party> &party) { if (oldProtocol || !player || !party || !party->getLeader()) { return; } @@ -8032,7 +8028,7 @@ void ProtocolGame::updatePartyTrackerAnalyzer(const std::shared_ptr<Party> party writeToOutputBuffer(msg); } -void ProtocolGame::AddCreatureLight(NetworkMessage &msg, std::shared_ptr<Creature> creature) { +void ProtocolGame::AddCreatureLight(NetworkMessage &msg, const std::shared_ptr<Creature> &creature) { LightInfo lightInfo = creature->getCreatureLight(); msg.addByte(0x8D); @@ -8052,7 +8048,7 @@ void ProtocolGame::RemoveTileThing(NetworkMessage &msg, const Position &pos, uin msg.addByte(static_cast<uint8_t>(stackpos)); } -void ProtocolGame::sendKillTrackerUpdate(std::shared_ptr<Container> corpse, const std::string &name, const Outfit_t creatureOutfit) { +void ProtocolGame::sendKillTrackerUpdate(const std::shared_ptr<Container> &corpse, const std::string &name, const Outfit_t creatureOutfit) { if (oldProtocol) { return; } @@ -8079,7 +8075,7 @@ void ProtocolGame::sendKillTrackerUpdate(std::shared_ptr<Container> corpse, cons writeToOutputBuffer(msg); } -void ProtocolGame::sendUpdateSupplyTracker(std::shared_ptr<Item> item) { +void ProtocolGame::sendUpdateSupplyTracker(const std::shared_ptr<Item> &item) { if (oldProtocol || !player || !item) { return; } @@ -8114,7 +8110,7 @@ void ProtocolGame::sendUpdateImpactTracker(CombatType_t type, int32_t amount) { writeToOutputBuffer(msg); } -void ProtocolGame::sendUpdateInputAnalyzer(CombatType_t type, int32_t amount, std::string target) { +void ProtocolGame::sendUpdateInputAnalyzer(CombatType_t type, int32_t amount, const std::string &target) { if (!player || oldProtocol) { return; } @@ -8203,7 +8199,7 @@ void ProtocolGame::sendTaskHuntingData(const std::unique_ptr<TaskHuntingSlot> &s writeToOutputBuffer(msg); } -void ProtocolGame::MoveUpCreature(NetworkMessage &msg, std::shared_ptr<Creature> creature, const Position &newPos, const Position &oldPos) { +void ProtocolGame::MoveUpCreature(NetworkMessage &msg, const std::shared_ptr<Creature> &creature, const Position &newPos, const Position &oldPos) { if (creature != player) { return; } @@ -8247,7 +8243,7 @@ void ProtocolGame::MoveUpCreature(NetworkMessage &msg, std::shared_ptr<Creature> GetMapDescription(oldPos.x - MAP_MAX_CLIENT_VIEW_PORT_X, oldPos.y - MAP_MAX_CLIENT_VIEW_PORT_Y, newPos.z, (MAP_MAX_CLIENT_VIEW_PORT_X + 1) * 2, 1, msg); } -void ProtocolGame::MoveDownCreature(NetworkMessage &msg, std::shared_ptr<Creature> creature, const Position &newPos, const Position &oldPos) { +void ProtocolGame::MoveDownCreature(NetworkMessage &msg, const std::shared_ptr<Creature> &creature, const Position &newPos, const Position &oldPos) { if (creature != player) { return; } @@ -8366,7 +8362,7 @@ void ProtocolGame::parseInventoryImbuements(NetworkMessage &msg) { g_game().playerRequestInventoryImbuements(player->getID(), isTrackerOpen); } -void ProtocolGame::sendInventoryImbuements(const std::map<Slots_t, std::shared_ptr<Item>> items) { +void ProtocolGame::sendInventoryImbuements(const std::map<Slots_t, std::shared_ptr<Item>> &items) { if (oldProtocol) { return; } @@ -8458,7 +8454,7 @@ void ProtocolGame::sendItemsPrice() { writeToOutputBuffer(msg); } -void ProtocolGame::reloadCreature(std::shared_ptr<Creature> creature) { +void ProtocolGame::reloadCreature(const std::shared_ptr<Creature> &creature) { if (!creature || !canSee(creature)) { return; } @@ -8520,11 +8516,11 @@ void ProtocolGame::parseStashWithdraw(NetworkMessage &msg) { return; } - Supply_Stash_Actions_t action = static_cast<Supply_Stash_Actions_t>(msg.getByte()); + auto action = static_cast<Supply_Stash_Actions_t>(msg.getByte()); switch (action) { case SUPPLY_STASH_ACTION_STOW_ITEM: { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); uint32_t count = msg.getByte(); g_game().playerStowItem(player->getID(), pos, itemId, stackpos, count, false); @@ -8532,21 +8528,21 @@ void ProtocolGame::parseStashWithdraw(NetworkMessage &msg) { } case SUPPLY_STASH_ACTION_STOW_CONTAINER: { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); g_game().playerStowItem(player->getID(), pos, itemId, stackpos, 0, false); break; } case SUPPLY_STASH_ACTION_STOW_STACK: { Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); g_game().playerStowItem(player->getID(), pos, itemId, stackpos, 0, true); break; } case SUPPLY_STASH_ACTION_WITHDRAW: { - uint16_t itemId = msg.get<uint16_t>(); - uint32_t count = msg.get<uint32_t>(); + auto itemId = msg.get<uint16_t>(); + auto count = msg.get<uint32_t>(); uint8_t stackpos = msg.getByte(); g_game().playerStashWithdraw(player->getID(), itemId, count, stackpos); break; @@ -8657,7 +8653,7 @@ void ProtocolGame::parseDepotSearchItemRequest(NetworkMessage &msg) { return; } - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t itemTier = 0; if (Item::items[itemId].upgradeClassification > 0) { itemTier = msg.getByte(); @@ -8671,7 +8667,7 @@ void ProtocolGame::parseRetrieveDepotSearch(NetworkMessage &msg) { return; } - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t itemTier = 0; if (Item::items[itemId].upgradeClassification > 0) { itemTier = msg.getByte(); @@ -8690,7 +8686,7 @@ void ProtocolGame::parseOpenParentContainer(NetworkMessage &msg) { g_game().playerRequestOpenContainerFromDepotSearch(player->getID(), pos); } -void ProtocolGame::sendUpdateCreature(std::shared_ptr<Creature> creature) { +void ProtocolGame::sendUpdateCreature(const std::shared_ptr<Creature> &creature) { if (oldProtocol || !creature || !player) { return; } @@ -8717,7 +8713,7 @@ void ProtocolGame::sendUpdateCreature(std::shared_ptr<Creature> creature) { writeToOutputBuffer(msg); } -void ProtocolGame::getForgeInfoMap(std::shared_ptr<Item> item, std::map<uint16_t, std::map<uint8_t, uint16_t>> &itemsMap) const { +void ProtocolGame::getForgeInfoMap(const std::shared_ptr<Item> &item, std::map<uint16_t, std::map<uint8_t, uint16_t>> &itemsMap) const { std::map<uint8_t, uint16_t> itemInfo; itemInfo.insert({ item->getTier(), item->getItemCount() }); auto [first, inserted] = itemsMap.try_emplace(item->getID(), itemInfo); @@ -8737,7 +8733,7 @@ void ProtocolGame::sendForgeSkillStats(NetworkMessage &msg) const { std::vector<Slots_t> slots { CONST_SLOT_LEFT, CONST_SLOT_ARMOR, CONST_SLOT_HEAD, CONST_SLOT_LEGS }; for (const auto &slot : slots) { double_t skill = 0; - if (std::shared_ptr<Item> item = player->getInventoryItem(slot); item) { + if (const auto &item = player->getInventoryItem(slot); item) { const ItemType &it = Item::items[item->getID()]; if (it.isWeapon()) { skill = item->getFatalChance() * 100; @@ -8973,7 +8969,7 @@ void ProtocolGame::parseBosstiarySlot(NetworkMessage &msg) { } uint8_t slotBossId = msg.getByte(); - uint32_t selectedBossId = msg.get<uint32_t>(); + auto selectedBossId = msg.get<uint32_t>(); g_game().playerBosstiarySlot(player->getID(), slotBossId, selectedBossId); } @@ -9016,7 +9012,7 @@ void ProtocolGame::sendPodiumDetails(NetworkMessage &msg, const std::vector<uint } } -void ProtocolGame::sendMonsterPodiumWindow(std::shared_ptr<Item> podium, const Position &position, uint16_t itemId, uint8_t stackPos) { +void ProtocolGame::sendMonsterPodiumWindow(const std::shared_ptr<Item> &podium, const Position &position, uint16_t itemId, uint8_t stackPos) { if (!podium || oldProtocol) { g_logger().error("[{}] item is nullptr", __FUNCTION__); return; @@ -9081,9 +9077,9 @@ void ProtocolGame::parseSetMonsterPodium(NetworkMessage &msg) const { } // For some reason the cip sends uint32_t, but we use uint16_t, so let's just ignore that - uint16_t monsterRaceId = (uint16_t)msg.get<uint32_t>(); + auto monsterRaceId = static_cast<uint16_t>(msg.get<uint32_t>()); Position pos = msg.getPosition(); - uint16_t itemId = msg.get<uint16_t>(); + auto itemId = msg.get<uint16_t>(); uint8_t stackpos = msg.getByte(); uint8_t direction = msg.getByte(); uint8_t podiumVisible = msg.getByte(); diff --git a/src/server/network/protocol/protocolgame.hpp b/src/server/network/protocol/protocolgame.hpp index fc27cd3abfc..01a5e6e7fd8 100644 --- a/src/server/network/protocol/protocolgame.hpp +++ b/src/server/network/protocol/protocolgame.hpp @@ -25,7 +25,6 @@ class House; class Container; class Tile; class Connection; -class Quest; class ProtocolGame; class PreySlot; class TaskHuntingSlot; @@ -66,13 +65,13 @@ class ProtocolGame final : public Protocol { return "gameworld protocol"; } - explicit ProtocolGame(Connection_ptr initConnection); + explicit ProtocolGame(const Connection_ptr &initConnection); void login(const std::string &name, uint32_t accnumber, OperatingSystem_t operatingSystem); void logout(bool displayEffect, bool forced); - void AddItem(NetworkMessage &msg, std::shared_ptr<Item> item); - void AddItem(NetworkMessage &msg, uint16_t id, uint8_t count, uint8_t tier); + void AddItem(NetworkMessage &msg, const std::shared_ptr<Item> &item); + void AddItem(NetworkMessage &msg, uint16_t id, uint8_t count, uint8_t tier) const; uint16_t getVersion() const { return version; @@ -91,7 +90,7 @@ class ProtocolGame final : public Protocol { void checkCreatureAsKnown(uint32_t id, bool &known, uint32_t &removedKnown); bool canSee(int32_t x, int32_t y, int32_t z) const; - bool canSee(std::shared_ptr<Creature>) const; + bool canSee(const std::shared_ptr<Creature> &) const; bool canSee(const Position &pos) const; // we have all the parse methods @@ -129,7 +128,7 @@ class ProtocolGame final : public Protocol { void sendSessionEndInformation(SessionEndInformations information); - void sendItemInspection(uint16_t itemId, uint8_t itemCount, std::shared_ptr<Item> item, bool cyclopedia); + void sendItemInspection(uint16_t itemId, uint8_t itemCount, const std::shared_ptr<Item> &item, bool cyclopedia); void parseInspectionObject(NetworkMessage &msg); void parseFriendSystemAction(NetworkMessage &msg); @@ -162,7 +161,6 @@ class ProtocolGame final : public Protocol { void parseSendBuyCharmRune(NetworkMessage &msg); void parseBestiarysendMonsterData(NetworkMessage &msg); void parseCyclopediaMonsterTracker(NetworkMessage &msg); - void parseObjectInfo(NetworkMessage &msg); void parseTeleport(NetworkMessage &msg); void parseThrow(NetworkMessage &msg); @@ -240,14 +238,14 @@ class ProtocolGame final : public Protocol { void sendChannel(uint16_t channelId, const std::string &channelName, const UsersMap* channelUsers, const InvitedMap* invitedUsers); void sendOpenPrivateChannel(const std::string &receiver); void sendExperienceTracker(int64_t rawExp, int64_t finalExp); - void sendToChannel(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, uint16_t channelId); - void sendPrivateMessage(std::shared_ptr<Player> speaker, SpeakClasses type, const std::string &text); + void sendToChannel(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, uint16_t channelId); + void sendPrivateMessage(const std::shared_ptr<Player> &speaker, SpeakClasses type, const std::string &text); void sendIcons(const std::unordered_set<PlayerIcon> &iconSet, const IconBakragore iconBakragore); void sendIconBakragore(const IconBakragore icon); void sendFYIBox(const std::string &message); - void openImbuementWindow(std::shared_ptr<Item> item); - void sendImbuementResult(const std::string message); + void openImbuementWindow(const std::shared_ptr<Item> &item); + void sendImbuementResult(const std::string &message); void closeImbuementWindow(); void sendItemsPrice(); @@ -255,18 +253,11 @@ class ProtocolGame final : public Protocol { // Forge System void sendForgingData(); void sendOpenForge(); - void sendForgeError(const ReturnValue returnValue); + void sendForgeError(ReturnValue returnValue); void closeForgeWindow(); void parseForgeEnter(NetworkMessage &msg); void parseForgeBrowseHistory(NetworkMessage &msg); - void sendForgeFusionItem( - uint16_t itemId, - uint8_t tier, - bool success, - uint8_t bonus, - uint8_t coreCount, - bool convergence - ); + void sendForgeResult(ForgeAction_t actionType, uint16_t leftItemId, uint8_t leftTier, uint16_t rightItemId, uint8_t rightTier, bool success, uint8_t bonus, uint8_t coreCount, bool convergence); void sendForgeHistory(uint8_t page); void sendForgeSkillStats(NetworkMessage &msg) const; @@ -276,7 +267,7 @@ class ProtocolGame final : public Protocol { void parseSendBosstiarySlots(); void parseBosstiarySlot(NetworkMessage &msg); void sendPodiumDetails(NetworkMessage &msg, const std::vector<uint16_t> &toSendMonsters, bool isBoss) const; - void sendMonsterPodiumWindow(std::shared_ptr<Item> podium, const Position &position, uint16_t itemId, uint8_t stackPos); + void sendMonsterPodiumWindow(const std::shared_ptr<Item> &podium, const Position &position, uint16_t itemId, uint8_t stackPos); void parseSetMonsterPodium(NetworkMessage &msg) const; void sendBosstiaryCooldownTimer(); void sendBosstiaryEntryChanged(uint32_t bossid); @@ -286,28 +277,28 @@ class ProtocolGame final : public Protocol { void sendMagicEffect(const Position &pos, uint16_t type); void removeMagicEffect(const Position &pos, uint16_t type); void sendRestingStatus(uint8_t protection); - void sendCreatureHealth(std::shared_ptr<Creature> creature); - void sendPartyCreatureUpdate(std::shared_ptr<Creature> target); - void sendPartyCreatureShield(std::shared_ptr<Creature> target); - void sendPartyCreatureSkull(std::shared_ptr<Creature> target); - void sendPartyCreatureHealth(std::shared_ptr<Creature> target, uint8_t healthPercent); - void sendPartyPlayerMana(std::shared_ptr<Player> target, uint8_t manaPercent); - void sendPartyCreatureShowStatus(std::shared_ptr<Creature> target, bool showStatus); - void sendPartyPlayerVocation(std::shared_ptr<Player> target); - void sendPlayerVocation(std::shared_ptr<Player> target); + void sendCreatureHealth(const std::shared_ptr<Creature> &creature); + void sendPartyCreatureUpdate(const std::shared_ptr<Creature> &target); + void sendPartyCreatureShield(const std::shared_ptr<Creature> &target); + void sendPartyCreatureSkull(const std::shared_ptr<Creature> &target); + void sendPartyCreatureHealth(const std::shared_ptr<Creature> &target, uint8_t healthPercent); + void sendPartyPlayerMana(const std::shared_ptr<Player> &target, uint8_t manaPercent); + void sendPartyCreatureShowStatus(const std::shared_ptr<Creature> &target, bool showStatus); + void sendPartyPlayerVocation(const std::shared_ptr<Player> &target); + void sendPlayerVocation(const std::shared_ptr<Player> &target); void sendSkills(); void sendPing(); void sendPingBack(); - void sendCreatureTurn(std::shared_ptr<Creature> creature, uint32_t stackpos); - void sendCreatureSay(std::shared_ptr<Creature> creature, SpeakClasses type, const std::string &text, const Position* pos = nullptr); + void sendCreatureTurn(const std::shared_ptr<Creature> &creature, uint32_t stackpos); + void sendCreatureSay(const std::shared_ptr<Creature> &creature, SpeakClasses type, const std::string &text, const Position* pos = nullptr); // Unjust Panel void sendUnjustifiedPoints(const uint8_t &dayProgress, const uint8_t &dayLeft, const uint8_t &weekProgress, const uint8_t &weekLeft, const uint8_t &monthProgress, const uint8_t &monthLeft, const uint8_t &skullDuration); void sendCancelWalk(); - void sendChangeSpeed(std::shared_ptr<Creature> creature, uint16_t speed); + void sendChangeSpeed(const std::shared_ptr<Creature> &creature, uint16_t speed); void sendCancelTarget(); - void sendCreatureOutfit(std::shared_ptr<Creature> creature, const Outfit_t &outfit); + void sendCreatureOutfit(const std::shared_ptr<Creature> &creature, const Outfit_t &outfit); void sendStats(); void sendBasicData(); void sendTextMessage(const TextMessage &message); @@ -322,7 +313,7 @@ class ProtocolGame final : public Protocol { void sendCyclopediaCharacterCombatStats(); void sendCyclopediaCharacterRecentDeaths(uint16_t page, uint16_t pages, const std::vector<RecentDeathEntry> &entries); void sendCyclopediaCharacterRecentPvPKills(uint16_t page, uint16_t pages, const std::vector<RecentPvPKillEntry> &entries); - void sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, std::vector<std::pair<Achievement, uint32_t>> achievementsUnlocked); + void sendCyclopediaCharacterAchievements(uint16_t secretsUnlocked, const std::vector<std::pair<Achievement, uint32_t>> &achievementsUnlocked); void sendCyclopediaCharacterItemSummary(const ItemsTierCountList &inventoryItems, const ItemsTierCountList &storeInboxItems, const StashItemList &supplyStashItems, const ItemsTierCountList &depotBoxItems, const ItemsTierCountList &inboxItems); void sendCyclopediaCharacterOutfitsMounts(); void sendCyclopediaCharacterStoreSummary(); @@ -330,13 +321,13 @@ class ProtocolGame final : public Protocol { void sendCyclopediaCharacterBadges(); void sendCyclopediaCharacterTitles(); - void sendCreatureWalkthrough(std::shared_ptr<Creature> creature, bool walkthrough); - void sendCreatureShield(std::shared_ptr<Creature> creature); - void sendCreatureEmblem(std::shared_ptr<Creature> creature); - void sendCreatureSkull(std::shared_ptr<Creature> creature); - void sendCreatureType(std::shared_ptr<Creature> creature, uint8_t creatureType); + void sendCreatureWalkthrough(const std::shared_ptr<Creature> &creature, bool walkthrough); + void sendCreatureShield(const std::shared_ptr<Creature> &creature); + void sendCreatureEmblem(const std::shared_ptr<Creature> &creature); + void sendCreatureSkull(const std::shared_ptr<Creature> &creature); + void sendCreatureType(const std::shared_ptr<Creature> &creature, uint8_t creatureType); - void sendShop(std::shared_ptr<Npc> npc); + void sendShop(const std::shared_ptr<Npc> &npc); void sendCloseShop(); void sendClientCheck(); void sendGameNews(); @@ -352,15 +343,15 @@ class ProtocolGame final : public Protocol { void sendMarketCancelOffer(const MarketOfferEx &offer); void sendMarketBrowseOwnHistory(const HistoryMarketOfferList &buyOffers, const HistoryMarketOfferList &sellOffers); void sendMarketDetail(uint16_t itemId, uint8_t tier); - void sendTradeItemRequest(const std::string &traderName, std::shared_ptr<Item> item, bool ack); + void sendTradeItemRequest(const std::string &traderName, const std::shared_ptr<Item> &item, bool ack); void sendCloseTrade(); - void updatePartyTrackerAnalyzer(const std::shared_ptr<Party> party); + void updatePartyTrackerAnalyzer(const std::shared_ptr<Party> &party); void sendTextWindow(uint32_t windowTextId, uint32_t itemId, const std::string &text); - void sendTextWindow(uint32_t windowTextId, std::shared_ptr<Item> item, uint16_t maxlen, bool canWrite); + void sendTextWindow(uint32_t windowTextId, const std::shared_ptr<Item> &item, uint16_t maxlen, bool canWrite); void sendHouseWindow(uint32_t windowTextId, const std::string &text); void sendOutfitWindow(); - void sendPodiumWindow(std::shared_ptr<Item> podium, const Position &position, uint16_t itemId, uint8_t stackpos); + void sendPodiumWindow(const std::shared_ptr<Item> &podium, const Position &position, uint16_t itemId, uint8_t stackpos); void sendUpdatedVIPStatus(uint32_t guid, VipStatus_t newStatus); void sendVIP(uint32_t guid, const std::string &name, const std::string &description, uint32_t icon, bool notify, VipStatus_t status); @@ -371,13 +362,13 @@ class ProtocolGame final : public Protocol { void sendFightModes(); - void sendCreatureLight(std::shared_ptr<Creature> creature); - void sendCreatureIcon(std::shared_ptr<Creature> creature); - void sendUpdateCreature(std::shared_ptr<Creature> creature); + void sendCreatureLight(const std::shared_ptr<Creature> &creature); + void sendCreatureIcon(const std::shared_ptr<Creature> &creature); + void sendUpdateCreature(const std::shared_ptr<Creature> &creature); void sendWorldLight(const LightInfo &lightInfo); void sendTibiaTime(int32_t time); - void sendCreatureSquare(std::shared_ptr<Creature> creature, SquareColor_t color); + void sendCreatureSquare(const std::shared_ptr<Creature> &creature, SquareColor_t color); void sendSpellCooldown(uint16_t spellId, uint32_t time); void sendSpellGroupCooldown(SpellGroup_t groupId, uint32_t time); @@ -392,46 +383,46 @@ class ProtocolGame final : public Protocol { // tiles void sendMapDescription(const Position &pos); - void sendAddTileItem(const Position &pos, uint32_t stackpos, std::shared_ptr<Item> item); - void sendUpdateTileItem(const Position &pos, uint32_t stackpos, std::shared_ptr<Item> item); + void sendAddTileItem(const Position &pos, uint32_t stackpos, const std::shared_ptr<Item> &item); + void sendUpdateTileItem(const Position &pos, uint32_t stackpos, const std::shared_ptr<Item> &item); void sendRemoveTileThing(const Position &pos, uint32_t stackpos); - void sendUpdateTileCreature(const Position &pos, uint32_t stackpos, const std::shared_ptr<Creature> creature); - void sendUpdateTile(std::shared_ptr<Tile> tile, const Position &pos); + void sendUpdateTileCreature(const Position &pos, uint32_t stackpos, const std::shared_ptr<Creature> &creature); + void sendUpdateTile(const std::shared_ptr<Tile> &tile, const Position &pos); - void sendAddCreature(std::shared_ptr<Creature> creature, const Position &pos, int32_t stackpos, bool isLogin); - void sendMoveCreature(std::shared_ptr<Creature> creature, const Position &newPos, int32_t newStackPos, const Position &oldPos, int32_t oldStackPos, bool teleport); + void sendAddCreature(const std::shared_ptr<Creature> &creature, const Position &pos, int32_t stackpos, bool isLogin); + void sendMoveCreature(const std::shared_ptr<Creature> &creature, const Position &newPos, int32_t newStackPos, const Position &oldPos, int32_t oldStackPos, bool teleport); // containers - void sendAddContainerItem(uint8_t cid, uint16_t slot, std::shared_ptr<Item> item); - void sendUpdateContainerItem(uint8_t cid, uint16_t slot, std::shared_ptr<Item> item); - void sendRemoveContainerItem(uint8_t cid, uint16_t slot, std::shared_ptr<Item> lastItem); + void sendAddContainerItem(uint8_t cid, uint16_t slot, const std::shared_ptr<Item> &item); + void sendUpdateContainerItem(uint8_t cid, uint16_t slot, const std::shared_ptr<Item> &item); + void sendRemoveContainerItem(uint8_t cid, uint16_t slot, const std::shared_ptr<Item> &lastItem); - void sendContainer(uint8_t cid, std::shared_ptr<Container> container, bool hasParent, uint16_t firstIndex); + void sendContainer(uint8_t cid, const std::shared_ptr<Container> &container, bool hasParent, uint16_t firstIndex); void sendCloseContainer(uint8_t cid); // quickloot void sendLootContainers(); - void sendLootStats(std::shared_ptr<Item> item, uint8_t count); + void sendLootStats(const std::shared_ptr<Item> &item, uint8_t count); // inventory - void sendInventoryItem(Slots_t slot, std::shared_ptr<Item> item); + void sendInventoryItem(Slots_t slot, const std::shared_ptr<Item> &item); void sendInventoryIds(); // messages void sendModalWindow(const ModalWindow &modalWindow); // analyzers - void sendKillTrackerUpdate(std::shared_ptr<Container> corpse, const std::string &name, const Outfit_t creatureOutfit); - void sendUpdateSupplyTracker(std::shared_ptr<Item> item); + void sendKillTrackerUpdate(const std::shared_ptr<Container> &corpse, const std::string &name, Outfit_t creatureOutfit); + void sendUpdateSupplyTracker(const std::shared_ptr<Item> &item); void sendUpdateImpactTracker(CombatType_t type, int32_t amount); - void sendUpdateInputAnalyzer(CombatType_t type, int32_t amount, std::string target); + void sendUpdateInputAnalyzer(CombatType_t type, int32_t amount, const std::string &target); // Hotkey equip/dequip item void parseHotkeyEquip(NetworkMessage &msg); // Help functions // translate a tile to clientreadable format - void GetTileDescription(std::shared_ptr<Tile> tile, NetworkMessage &msg); + void GetTileDescription(const std::shared_ptr<Tile> &tile, NetworkMessage &msg); // translate a floor to clientreadable format void GetFloorDescription(NetworkMessage &msg, int32_t x, int32_t y, int32_t z, int32_t width, int32_t height, int32_t offset, int32_t &skip); @@ -439,7 +430,7 @@ class ProtocolGame final : public Protocol { // translate a map area to clientreadable format void GetMapDescription(int32_t x, int32_t y, int32_t z, int32_t width, int32_t height, NetworkMessage &msg); - void AddCreature(NetworkMessage &msg, std::shared_ptr<Creature> creature, bool known, uint32_t remove); + void AddCreature(NetworkMessage &msg, const std::shared_ptr<Creature> &creature, bool known, uint32_t remove); void AddPlayerStats(NetworkMessage &msg); void AddOutfit(NetworkMessage &msg, const Outfit_t &outfit, bool addMount = true); void AddPlayerSkills(NetworkMessage &msg); @@ -447,15 +438,15 @@ class ProtocolGame final : public Protocol { void sendPremiumTrigger(); void sendMessageDialog(const std::string &message); void AddWorldLight(NetworkMessage &msg, LightInfo lightInfo); - void AddCreatureLight(NetworkMessage &msg, std::shared_ptr<Creature> creature); + void AddCreatureLight(NetworkMessage &msg, const std::shared_ptr<Creature> &creature); // tiles static void RemoveTileThing(NetworkMessage &msg, const Position &pos, uint32_t stackpos); void sendTaskHuntingData(const std::unique_ptr<TaskHuntingSlot> &slot); - void MoveUpCreature(NetworkMessage &msg, std::shared_ptr<Creature> creature, const Position &newPos, const Position &oldPos); - void MoveDownCreature(NetworkMessage &msg, std::shared_ptr<Creature> creature, const Position &newPos, const Position &oldPos); + void MoveUpCreature(NetworkMessage &msg, const std::shared_ptr<Creature> &creature, const Position &newPos, const Position &oldPos); + void MoveDownCreature(NetworkMessage &msg, const std::shared_ptr<Creature> &creature, const Position &newPos, const Position &oldPos); // shop void AddHiddenShopItem(NetworkMessage &msg); @@ -468,12 +459,12 @@ class ProtocolGame final : public Protocol { void sendFeatures(); void parseInventoryImbuements(NetworkMessage &msg); - void sendInventoryImbuements(const std::map<Slots_t, std::shared_ptr<Item>> items); + void sendInventoryImbuements(const std::map<Slots_t, std::shared_ptr<Item>> &items); // reloadCreature - void reloadCreature(std::shared_ptr<Creature> creature); + void reloadCreature(const std::shared_ptr<Creature> &creature); - void getForgeInfoMap(std::shared_ptr<Item> item, std::map<uint16_t, std::map<uint8_t, uint16_t>> &itemsMap) const; + void getForgeInfoMap(const std::shared_ptr<Item> &item, std::map<uint16_t, std::map<uint8_t, uint16_t>> &itemsMap) const; // Wheel void parseOpenWheel(NetworkMessage &msg); @@ -506,13 +497,12 @@ class ProtocolGame final : public Protocol { uint16_t otclientV8 = 0; bool isOTC = false; - void sendInventory(); void sendOpenStash(); void parseStashWithdraw(NetworkMessage &msg); void sendSpecialContainersAvailable(); void addBless(); void parsePacketDead(uint8_t recvbyte); - void addCreatureIcon(NetworkMessage &msg, std::shared_ptr<Creature> creature); + void addCreatureIcon(NetworkMessage &msg, const std::shared_ptr<Creature> &creature); void sendSingleSoundEffect(const Position &pos, SoundEffect_t id, SourceEffect_t source); void sendDoubleSoundEffect(const Position &pos, SoundEffect_t mainSoundId, SourceEffect_t mainSource, SoundEffect_t secondarySoundId, SourceEffect_t secondarySource); diff --git a/src/server/network/protocol/protocollogin.cpp b/src/server/network/protocol/protocollogin.cpp index f182f957cdb..3a7725533aa 100644 --- a/src/server/network/protocol/protocollogin.cpp +++ b/src/server/network/protocol/protocollogin.cpp @@ -17,8 +17,8 @@ #include "core.hpp" #include "enums/account_errors.hpp" -void ProtocolLogin::disconnectClient(const std::string &message) { - auto output = OutputMessagePool::getOutputMessage(); +void ProtocolLogin::disconnectClient(const std::string &message) const { + const auto output = OutputMessagePool::getOutputMessage(); output->addByte(0x0B); output->addString(message); @@ -27,7 +27,7 @@ void ProtocolLogin::disconnectClient(const std::string &message) { disconnect(); } -void ProtocolLogin::getCharacterList(const std::string &accountDescriptor, const std::string &password) { +void ProtocolLogin::getCharacterList(const std::string &accountDescriptor, const std::string &password) const { Account account(accountDescriptor); account.setProtocolCompat(oldProtocol); @@ -105,7 +105,7 @@ void ProtocolLogin::onRecvFirstMessage(NetworkMessage &msg) { msg.skipBytes(2); // client OS - uint16_t version = msg.get<uint16_t>(); + auto version = msg.get<uint16_t>(); // Old protocol support oldProtocol = version == 1100; diff --git a/src/server/network/protocol/protocollogin.hpp b/src/server/network/protocol/protocollogin.hpp index 6652a85625e..d3051119ba3 100644 --- a/src/server/network/protocol/protocollogin.hpp +++ b/src/server/network/protocol/protocollogin.hpp @@ -14,7 +14,7 @@ class NetworkMessage; class OutputMessage; -class ProtocolLogin : public Protocol { +class ProtocolLogin final : public Protocol { public: // static protocol information enum { SERVER_SENDS_FIRST = false }; @@ -24,15 +24,15 @@ class ProtocolLogin : public Protocol { return "login protocol"; } - explicit ProtocolLogin(Connection_ptr loginConnection) : + explicit ProtocolLogin(const Connection_ptr &loginConnection) : Protocol(loginConnection) { } - void onRecvFirstMessage(NetworkMessage &msg); + void onRecvFirstMessage(NetworkMessage &msg) override; private: - void disconnectClient(const std::string &message); + void disconnectClient(const std::string &message) const; - void getCharacterList(const std::string &accountDescriptor, const std::string &password); + void getCharacterList(const std::string &accountDescriptor, const std::string &password) const; bool oldProtocol = false; }; diff --git a/src/server/network/protocol/protocolstatus.cpp b/src/server/network/protocol/protocolstatus.cpp index bed5fd7a9bd..7d0ee35d747 100644 --- a/src/server/network/protocol/protocolstatus.cpp +++ b/src/server/network/protocol/protocolstatus.cpp @@ -24,11 +24,11 @@ std::map<uint32_t, int64_t> ProtocolStatus::ipConnectMap; const uint64_t ProtocolStatus::start = OTSYS_TIME(true); void ProtocolStatus::onRecvFirstMessage(NetworkMessage &msg) { - uint32_t ip = getIP(); + const uint32_t ip = getIP(); if (ip != 0x0100007F) { - std::string ipStr = convertIPToString(ip); + const std::string ipStr = convertIPToString(ip); if (ipStr != g_configManager().getString(IP)) { - std::map<uint32_t, int64_t>::const_iterator it = ipConnectMap.find(ip); + const auto it = ipConnectMap.find(ip); if (it != ipConnectMap.end() && (OTSYS_TIME() < (it->second + g_configManager().getNumber(STATUSQUERY_TIMEOUT)))) { disconnect(); return; @@ -55,7 +55,7 @@ void ProtocolStatus::onRecvFirstMessage(NetworkMessage &msg) { // Another ServerInfo protocol case 0x01: { - uint16_t requestedInfo = msg.get<uint16_t>(); // only a Byte is necessary, though we could add new info here + auto requestedInfo = msg.get<uint16_t>(); // only a Byte is necessary, though we could add new info here std::string characterName; if (requestedInfo & REQUEST_PLAYER_STATUS_INFO) { characterName = msg.getString(); @@ -77,7 +77,7 @@ void ProtocolStatus::onRecvFirstMessage(NetworkMessage &msg) { } void ProtocolStatus::sendStatusString() { - auto output = OutputMessagePool::getOutputMessage(); + const auto output = OutputMessagePool::getOutputMessage(); setRawMessages(true); @@ -90,7 +90,7 @@ void ProtocolStatus::sendStatusString() { tsqp.append_attribute("version") = "1.0"; pugi::xml_node serverinfo = tsqp.append_child("serverinfo"); - uint64_t uptime = (OTSYS_TIME() - ProtocolStatus::start) / 1000; + const uint64_t uptime = (OTSYS_TIME() - ProtocolStatus::start) / 1000; serverinfo.append_attribute("uptime") = std::to_string(uptime).c_str(); serverinfo.append_attribute("ip") = g_configManager().getString(IP).c_str(); serverinfo.append_attribute("servername") = g_configManager().getString(ConfigKey_t::SERVER_NAME).c_str(); @@ -154,14 +154,14 @@ void ProtocolStatus::sendStatusString() { std::ostringstream ss; doc.save(ss, "", pugi::format_raw); - std::string data = ss.str(); + const std::string data = ss.str(); output->addBytes(data.c_str(), data.size()); send(output); disconnect(); } -void ProtocolStatus::sendInfo(uint16_t requestedInfo, const std::string &characterName) { - auto output = OutputMessagePool::getOutputMessage(); +void ProtocolStatus::sendInfo(uint16_t requestedInfo, const std::string &characterName) const { + const auto output = OutputMessagePool::getOutputMessage(); if (requestedInfo & REQUEST_BASIC_SERVER_INFO) { output->addByte(0x10); diff --git a/src/server/network/protocol/protocolstatus.hpp b/src/server/network/protocol/protocolstatus.hpp index 78b03a74333..d5600438734 100644 --- a/src/server/network/protocol/protocolstatus.hpp +++ b/src/server/network/protocol/protocolstatus.hpp @@ -22,13 +22,13 @@ class ProtocolStatus final : public Protocol { return "status protocol"; } - explicit ProtocolStatus(Connection_ptr conn) : + explicit ProtocolStatus(const Connection_ptr &conn) : Protocol(conn) { } void onRecvFirstMessage(NetworkMessage &msg) override; void sendStatusString(); - void sendInfo(uint16_t requestedInfo, const std::string &characterName); + void sendInfo(uint16_t requestedInfo, const std::string &characterName) const; static const uint64_t start; diff --git a/src/server/network/webhook/webhook.cpp b/src/server/network/webhook/webhook.cpp index 6d28e263e54..1f17ec8a0c8 100644 --- a/src/server/network/webhook/webhook.cpp +++ b/src/server/network/webhook/webhook.cpp @@ -23,7 +23,7 @@ Webhook::Webhook(ThreadPool &threadPool) : headers = curl_slist_append(headers, "content-type: application/json"); headers = curl_slist_append(headers, "accept: application/json"); - if (headers == NULL) { + if (headers == nullptr) { g_logger().error("Failed to init curl, appending request headers failed"); return; } @@ -42,9 +42,9 @@ void Webhook::run() { ); } -void Webhook::sendPayload(const std::string &payload, std::string url) { +void Webhook::sendPayload(const std::string &payload, const std::string &url) { std::scoped_lock lock { taskLock }; - webhooks.push_back(std::make_shared<WebhookTask>(payload, url)); + webhooks.emplace_back(std::make_shared<WebhookTask>(payload, url)); } void Webhook::sendMessage(const std::string &title, const std::string &message, int color, std::string url, bool embed) { @@ -87,7 +87,7 @@ int Webhook::sendRequest(const char* url, const char* payload, std::string* resp curl_easy_setopt(curl, CURLOPT_HTTPHEADER, headers); curl_easy_setopt(curl, CURLOPT_USERAGENT, "canary (https://github.com/opentibiabr/canary)"); - CURLcode res = curl_easy_perform(curl); + const CURLcode res = curl_easy_perform(curl); if (res != CURLE_OK) { g_logger().error("Failed to send webhook message with the error: {}", curl_easy_strerror(res)); @@ -105,15 +105,15 @@ int Webhook::sendRequest(const char* url, const char* payload, std::string* resp } size_t Webhook::writeCallback(void* contents, size_t size, size_t nmemb, void* userp) { - size_t real_size = size * nmemb; - auto* str = reinterpret_cast<std::string*>(userp); - str->append(reinterpret_cast<char*>(contents), real_size); + const size_t real_size = size * nmemb; + auto* str = static_cast<std::string*>(userp); + str->append(static_cast<char*>(contents), real_size); return real_size; } std::string Webhook::getPayload(const std::string &title, const std::string &message, int color, bool embed) const { - std::time_t now = getTimeNow(); - std::string time_buf = formatDate(now); + const std::time_t now = getTimeNow(); + const std::string time_buf = formatDate(now); std::stringstream footer_text; footer_text @@ -123,19 +123,19 @@ std::string Webhook::getPayload(const std::string &title, const std::string &mes std::stringstream payload; if (embed) { payload << "{ \"embeds\": [{ "; - payload << "\"title\": \"" << title << "\", "; + payload << R"("title": ")" << title << "\", "; if (!message.empty()) { - payload << "\"description\": \"" << message << "\", "; + payload << R"("description": ")" << message << "\", "; } if (g_configManager().getBoolean(DISCORD_SEND_FOOTER)) { - payload << "\"footer\": { \"text\": \"" << footer_text.str() << "\" }, "; + payload << R"("footer": { "text": ")" << footer_text.str() << "\" }, "; } if (color >= 0) { payload << "\"color\": " << color; } payload << " }] }"; } else { - payload << "{ \"content\": \"" << (!message.empty() ? message : title) << "\" }"; + payload << R"({ "content": ")" << (!message.empty() ? message : title) << "\" }"; } return payload.str(); diff --git a/src/server/network/webhook/webhook.hpp b/src/server/network/webhook/webhook.hpp index bae62a64c35..4ce989099c1 100644 --- a/src/server/network/webhook/webhook.hpp +++ b/src/server/network/webhook/webhook.hpp @@ -30,7 +30,7 @@ class Webhook { void run(); - void sendPayload(const std::string &payload, std::string url); + void sendPayload(const std::string &payload, const std::string &url); void sendMessage(const std::string &title, const std::string &message, int color, std::string url = "", bool embed = true); void sendMessage(const std::string &message, std::string url = ""); diff --git a/src/server/server.cpp b/src/server/server.cpp index 1ef5e01a06d..cc50149af50 100644 --- a/src/server/server.cpp +++ b/src/server/server.cpp @@ -69,7 +69,7 @@ bool ServicePort::is_single_socket() const { std::string ServicePort::get_protocol_names() const { if (services.empty()) { - return std::string(); + return {}; } std::string str = services.front()->get_protocol_name(); @@ -90,15 +90,15 @@ void ServicePort::accept() { acceptor->async_accept(connection->getSocket(), [self = shared_from_this(), connection](const std::error_code &error) { self->onAccept(connection, error); }); } -void ServicePort::onAccept(Connection_ptr connection, const std::error_code &error) { +void ServicePort::onAccept(const Connection_ptr &connection, const std::error_code &error) { if (!error) { if (services.empty()) { return; } - auto remote_ip = connection->getIP(); + const auto remote_ip = connection->getIP(); if (remote_ip != 0 && inject<Ban>().acceptConnection(remote_ip)) { - Service_ptr service = services.front(); + const Service_ptr service = services.front(); if (service->is_single_socket()) { connection->accept(service->make_protocol(connection)); } else { @@ -121,7 +121,7 @@ void ServicePort::onAccept(Connection_ptr connection, const std::error_code &err } Protocol_ptr ServicePort::make_protocol(bool checksummed, NetworkMessage &msg, const Connection_ptr &connection) const { - uint8_t protocolID = msg.getByte(); + const uint8_t protocolID = msg.getByte(); for (auto &service : services) { if (protocolID != service->get_protocol_identifier()) { continue; @@ -134,12 +134,12 @@ Protocol_ptr ServicePort::make_protocol(bool checksummed, NetworkMessage &msg, c return nullptr; } -void ServicePort::onStopServer() { +void ServicePort::onStopServer() const { close(); } -void ServicePort::openAcceptor(std::weak_ptr<ServicePort> weak_service, uint16_t port) { - if (auto service = weak_service.lock()) { +void ServicePort::openAcceptor(const std::weak_ptr<ServicePort> &weak_service, uint16_t port) { + if (const auto service = weak_service.lock()) { service->open(port); } } @@ -152,9 +152,9 @@ void ServicePort::open(uint16_t port) { try { if (g_configManager().getBoolean(BIND_ONLY_GLOBAL_ADDRESS)) { - acceptor.reset(new asio::ip::tcp::acceptor(io_service, asio::ip::tcp::endpoint(asio::ip::address(asio::ip::address_v4::from_string(g_configManager().getString(IP))), serverPort))); + acceptor = std::make_unique<asio::ip::tcp::acceptor>(io_service, asio::ip::tcp::endpoint(asio::ip::address(asio::ip::address_v4::from_string(g_configManager().getString(IP))), serverPort)); } else { - acceptor.reset(new asio::ip::tcp::acceptor(io_service, asio::ip::tcp::endpoint(asio::ip::address(asio::ip::address_v4(INADDR_ANY)), serverPort))); + acceptor = std::make_unique<asio::ip::tcp::acceptor>(io_service, asio::ip::tcp::endpoint(asio::ip::address(asio::ip::address_v4(INADDR_ANY)), serverPort)); } acceptor->set_option(asio::ip::tcp::no_delay(true)); @@ -171,7 +171,7 @@ void ServicePort::open(uint16_t port) { } } -void ServicePort::close() { +void ServicePort::close() const { if (acceptor && acceptor->is_open()) { std::error_code error; acceptor->close(error); @@ -183,6 +183,6 @@ bool ServicePort::add_service(const Service_ptr &new_svc) { return false; } - services.push_back(new_svc); + services.emplace_back(new_svc); return true; } diff --git a/src/server/server.hpp b/src/server/server.hpp index dfb6aef5cf8..0a658f4d26f 100644 --- a/src/server/server.hpp +++ b/src/server/server.hpp @@ -17,6 +17,7 @@ class Protocol; class ServiceBase { public: + virtual ~ServiceBase() = default; virtual bool is_single_socket() const = 0; virtual bool is_checksummed() const = 0; virtual uint8_t get_protocol_identifier() const = 0; @@ -56,17 +57,17 @@ class ServicePort : public std::enable_shared_from_this<ServicePort> { ServicePort(const ServicePort &) = delete; ServicePort &operator=(const ServicePort &) = delete; - static void openAcceptor(std::weak_ptr<ServicePort> weak_service, uint16_t port); + static void openAcceptor(const std::weak_ptr<ServicePort> &weak_service, uint16_t port); void open(uint16_t port); - void close(); + void close() const; bool is_single_socket() const; std::string get_protocol_names() const; bool add_service(const Service_ptr &new_svc); Protocol_ptr make_protocol(bool checksummed, NetworkMessage &msg, const Connection_ptr &connection) const; - void onStopServer(); - void onAccept(Connection_ptr connection, const std::error_code &error); + void onStopServer() const; + void onAccept(const Connection_ptr &connection, const std::error_code &error); private: void accept(); @@ -120,7 +121,7 @@ bool ServiceManager::add(uint16_t port) { ServicePort_ptr service_port; - auto foundServicePort = acceptors.find(port); + const auto foundServicePort = acceptors.find(port); if (foundServicePort == acceptors.end()) { service_port = std::make_shared<ServicePort>(io_service); diff --git a/src/utils/CMakeLists.txt b/src/utils/CMakeLists.txt index 1b2ba9da7f4..d3ce8329d73 100644 --- a/src/utils/CMakeLists.txt +++ b/src/utils/CMakeLists.txt @@ -1,4 +1,5 @@ target_sources(${PROJECT_NAME}_lib PRIVATE + counter_pointer.cpp pugicast.cpp tools.cpp wildcardtree.cpp diff --git a/src/utils/arraylist.hpp b/src/utils/arraylist.hpp index da507e68480..52850929e7d 100644 --- a/src/utils/arraylist.hpp +++ b/src/utils/arraylist.hpp @@ -48,7 +48,7 @@ namespace stdext { bool erase(const T &v) { update(); - const auto &it = std::ranges::find(backContainer, v); + auto it = std::ranges::find(backContainer, v); if (it == backContainer.end()) { return false; } diff --git a/src/utils/benchmark.hpp b/src/utils/benchmark.hpp index 961547efc94..2524866a6a8 100644 --- a/src/utils/benchmark.hpp +++ b/src/utils/benchmark.hpp @@ -9,7 +9,6 @@ #pragma once -#include <ctime> #include <cstdint> #include <chrono> @@ -74,7 +73,7 @@ class Benchmark { } private: - int64_t time() const noexcept { + static int64_t time() noexcept { return std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::system_clock::now().time_since_epoch()).count(); } diff --git a/src/utils/counter_pointer.cpp b/src/utils/counter_pointer.cpp new file mode 100644 index 00000000000..cdd0b56e8af --- /dev/null +++ b/src/utils/counter_pointer.cpp @@ -0,0 +1,31 @@ +/** + * Canary - A free and open-source MMORPG server emulator + * Copyright (©) 2019-2024 OpenTibiaBR <opentibiabr@outlook.com> + * Repository: https://github.com/opentibiabr/canary + * License: https://github.com/opentibiabr/canary/blob/main/LICENSE + * Contributors: https://github.com/opentibiabr/canary/graphs/contributors + * Website: https://docs.opentibiabr.com/ + */ + +#include "utils/counter_pointer.hpp" + +#include "lib/di/container.hpp" +#include "lib/logging/logger.hpp" + +SharedPtrManager &SharedPtrManager::getInstance() { + static SharedPtrManager instance; + return instance; +} + +void SharedPtrManager::countAllReferencesAndClean() { + for (auto it = m_sharedPtrMap.begin(); it != m_sharedPtrMap.end();) { + const auto &sptr = it->second.lock(); + if (sptr) { + g_logger().debug("Counting references of shared_ptr ({}): {}", it->first, sptr.use_count()); + ++it; + } else { + g_logger().debug("Object {} was destroyed and will be removed from the map.", it->first); + it = m_sharedPtrMap.erase(it); + } + } +} diff --git a/src/utils/counter_pointer.hpp b/src/utils/counter_pointer.hpp new file mode 100644 index 00000000000..15e2b56ef53 --- /dev/null +++ b/src/utils/counter_pointer.hpp @@ -0,0 +1,34 @@ +/** + * Canary - A free and open-source MMORPG server emulator + * Copyright (©) 2019-2024 OpenTibiaBR <opentibiabr@outlook.com> + * Repository: https://github.com/opentibiabr/canary + * License: https://github.com/opentibiabr/canary/blob/main/LICENSE + * Contributors: https://github.com/opentibiabr/canary/graphs/contributors + * Website: https://docs.opentibiabr.com/ + */ + +#pragma once + +class SharedPtrManager { +public: + SharedPtrManager() = default; + ~SharedPtrManager() = default; + + // Singleton - ensures we don't accidentally copy it. + SharedPtrManager(const SharedPtrManager &) = delete; + SharedPtrManager &operator=(const SharedPtrManager &) = delete; + + static SharedPtrManager &getInstance(); + + template <typename T> + void store(const std::string &name, const std::shared_ptr<T> &ptr) { + m_sharedPtrMap[name] = ptr; + } + + void countAllReferencesAndClean(); + +private: + std::unordered_map<std::string, std::weak_ptr<void>> m_sharedPtrMap; +}; + +constexpr auto g_counterPointer = SharedPtrManager::getInstance; diff --git a/src/utils/hash.hpp b/src/utils/hash.hpp index 6b819c9bb7d..7acee5551e7 100644 --- a/src/utils/hash.hpp +++ b/src/utils/hash.hpp @@ -1,8 +1,8 @@ #pragma once namespace stdext { - template <class _Kty> - using hash = phmap::Hash<_Kty>; + template <class Kty> + using hash = phmap::Hash<Kty>; // Robin Hood lib inline size_t hash_int(uint64_t x) noexcept { @@ -17,19 +17,19 @@ namespace stdext { seed ^= h + 0x9e3779b9 + (seed << 6) + (seed >> 2); } - void hash_combine(size_t &seed, uint64_t v) { + inline void hash_combine(size_t &seed, uint64_t v) { hash_union(seed, hash_int(v)); } - void hash_combine(size_t &seed, uint32_t v) { + inline void hash_combine(size_t &seed, uint32_t v) { hash_union(seed, hash_int(v)); } - void hash_combine(size_t &seed, uint16_t v) { + inline void hash_combine(size_t &seed, uint16_t v) { hash_union(seed, hash_int(v)); } - void hash_combine(size_t &seed, uint8_t v) { + inline void hash_combine(size_t &seed, uint8_t v) { hash_union(seed, hash_int(v)); } diff --git a/src/utils/lockfree.hpp b/src/utils/lockfree.hpp new file mode 100644 index 00000000000..be245c051b0 --- /dev/null +++ b/src/utils/lockfree.hpp @@ -0,0 +1,68 @@ +/** + * Canary - A free and open-source MMORPG server emulator + * Copyright (©) 2019-2024 OpenTibiaBR <opentibiabr@outlook.com> + * Repository: https://github.com/opentibiabr/canary + * License: https://github.com/opentibiabr/canary/blob/main/LICENSE + * Contributors: https://github.com/opentibiabr/canary/graphs/contributors + * Website: https://docs.opentibiabr.com/ + */ + +#pragma once + +#include <atomic_queue/atomic_queue.h> + +template <typename T, size_t CAPACITY> +struct LockfreeFreeList { + using FreeList = atomic_queue::AtomicQueue2<T*, CAPACITY>; + + static FreeList &get() { + static FreeList freeList; + return freeList; + } + + static void preallocate(size_t count) { + auto &freeList = get(); + for (size_t i = 0; i < count; ++i) { + auto p = static_cast<T*>(::operator new(sizeof(T), static_cast<std::align_val_t>(alignof(T)))); + if (!freeList.try_push(p)) { + ::operator delete(p, static_cast<std::align_val_t>(alignof(T))); + break; + } + } + } +}; + +template <typename T, size_t CAPACITY> +class LockfreePoolingAllocator { +public: + using value_type = T; + + template <typename U> + struct rebind { + using other = LockfreePoolingAllocator<U, CAPACITY>; + }; + + LockfreePoolingAllocator() noexcept = default; + + template <typename U> + explicit LockfreePoolingAllocator(const LockfreePoolingAllocator<U, CAPACITY> &) noexcept { } + + ~LockfreePoolingAllocator() = default; + + T* allocate(std::size_t n) { + if (n == 1) { + T* p; + if (LockfreeFreeList<T, CAPACITY>::get().try_pop(p)) { + return p; + } + } + return static_cast<T*>(::operator new(n * sizeof(T))); + } + + void deallocate(T* p, std::size_t n) const noexcept { + if (n == 1 && LockfreeFreeList<T, CAPACITY>::get().try_push(p)) { + return; + } + ::operator delete(p); + } +}; diff --git a/src/utils/pugicast.hpp b/src/utils/pugicast.hpp index d09532a2d5c..b59e95d37ab 100644 --- a/src/utils/pugicast.hpp +++ b/src/utils/pugicast.hpp @@ -19,7 +19,7 @@ namespace pugi { T value; // Set the last character to parse - std::string_view string(str); + const std::string_view string(str); const auto last = str + string.size(); // Convert the string to the specified type diff --git a/src/utils/simd.hpp b/src/utils/simd.hpp index 7e57e75bfad..f1116f1ce86 100644 --- a/src/utils/simd.hpp +++ b/src/utils/simd.hpp @@ -56,11 +56,11 @@ #ifdef _MSC_VER #include <intrin.h> -__forceinline unsigned int _mm_ctz(unsigned int value) { +__forceinline unsigned int mm_ctz(unsigned int value) { unsigned long i = 0; _BitScanForward(&i, value); return static_cast<unsigned int>(i); } #else - #define _mm_ctz __builtin_ctz + #define mm_ctz __builtin_ctz #endif diff --git a/src/utils/tools.cpp b/src/utils/tools.cpp index 0037651f21c..301d2c61cf8 100644 --- a/src/utils/tools.cpp +++ b/src/utils/tools.cpp @@ -13,6 +13,9 @@ #include "items/item.hpp" #include "enums/object_category.hpp" +#include "absl/debugging/stacktrace.h" +#include "absl/debugging/symbolize.h" + void printXMLError(const std::string &where, const std::string &fileName, const pugi::xml_parse_result &result) { g_logger().error("[{}] Failed to load {}: {}", where, fileName, result.description()); @@ -25,14 +28,14 @@ void printXMLError(const std::string &where, const std::string &fileName, const uint32_t currentLine = 1; std::string line; - size_t offset = static_cast<size_t>(result.offset); + const auto offset = static_cast<size_t>(result.offset); size_t lineOffsetPosition = 0; size_t index = 0; size_t bytes; do { bytes = fread(buffer, 1, 32768, file); for (size_t i = 0; i < bytes; ++i) { - char ch = buffer[i]; + const char ch = buffer[i]; if (ch == '\n') { if ((index + i) >= offset) { lineOffsetPosition = line.length() - ((index + i) - offset); @@ -135,7 +138,7 @@ std::string transformToSHA1(const std::string &input) { uint32_t length_low = 0; uint32_t length_high = 0; - for (char ch : input) { + for (const char ch : input) { messageBlock[index++] = ch; length_low += 8; @@ -177,7 +180,7 @@ std::string transformToSHA1(const std::string &input) { processSHA1MessageBlock(messageBlock, H); char hexstring[41]; - static const char hexDigits[] = { "0123456789abcdef" }; + static constexpr char hexDigits[] = { "0123456789abcdef" }; for (int hashByte = 20; --hashByte >= 0;) { const uint8_t byte = H[hashByte >> 2] >> (((3 - hashByte) & 3) << 3); index = hashByte << 1; @@ -189,8 +192,8 @@ std::string transformToSHA1(const std::string &input) { uint16_t getStashSize(const std::map<uint16_t, uint32_t> &itemList) { uint16_t size = 0; - for (auto item : itemList) { - size += ceil(item.second / (float_t)Item::items[item.first].stackSize); + for (const auto &[itemId, itemCount] : itemList) { + size += ceil(itemCount / static_cast<float_t>(Item::items[itemId].stackSize)); } return size; } @@ -226,14 +229,14 @@ std::string generateToken(const std::string &key, uint32_t ticks) { message.assign(transformToSHA1(oKeyPad)); // calculate hmac offset - uint32_t offset = static_cast<uint32_t>(std::stol(message.substr(39, 1), nullptr, 16) & 0xF); + const auto offset = static_cast<uint32_t>(std::stol(message.substr(39, 1), nullptr, 16) & 0xF); // get truncated hash - uint32_t truncHash = std::stol(message.substr(2 * offset, 8), nullptr, 16) & 0x7FFFFFFF; + const uint32_t truncHash = std::stol(message.substr(2 * offset, 8), nullptr, 16) & 0x7FFFFFFF; message.assign(std::to_string(truncHash)); // return only last AUTHENTICATOR_DIGITS (default 6) digits, also asserts exactly 6 digits - uint32_t hashLen = message.length(); + const uint32_t hashLen = message.length(); message.assign(message.substr(hashLen - std::min(hashLen, AUTHENTICATOR_DIGITS))); message.insert(0, AUTHENTICATOR_DIGITS - std::min(hashLen, AUTHENTICATOR_DIGITS), '0'); return message; @@ -258,7 +261,7 @@ void trim_left(std::string &source, char t) { } std::string keepFirstWordOnly(std::string &str) { - size_t spacePos = str.find(' '); + const size_t spacePos = str.find(' '); if (spacePos != std::string::npos) { str.erase(spacePos); } @@ -267,7 +270,7 @@ std::string keepFirstWordOnly(std::string &str) { } void toLowerCaseString(std::string &source) { - std::transform(source.begin(), source.end(), source.begin(), tolower); + std::ranges::transform(source, source.begin(), tolower); } std::string asLowerCaseString(std::string source) { @@ -276,7 +279,7 @@ std::string asLowerCaseString(std::string source) { } std::string asUpperCaseString(std::string source) { - std::transform(source.begin(), source.end(), source.begin(), toupper); + std::ranges::transform(source, source.begin(), toupper); return source; } @@ -284,7 +287,7 @@ std::string toCamelCase(const std::string &str) { std::string result; bool capitalizeNext = false; - for (char ch : str) { + for (const char ch : str) { if (ch == '_' || std::isspace(ch) || ch == '-') { capitalizeNext = true; } else { @@ -304,7 +307,7 @@ std::string toPascalCase(const std::string &str) { std::string result; bool capitalizeNext = true; - for (char ch : str) { + for (const char ch : str) { if (ch == '_' || std::isspace(ch) || ch == '-') { capitalizeNext = true; } else { @@ -322,7 +325,7 @@ std::string toPascalCase(const std::string &str) { std::string toSnakeCase(const std::string &str) { std::string result; - for (char ch : str) { + for (const char ch : str) { if (std::isupper(ch)) { result += '_'; result += std::tolower(ch); @@ -338,7 +341,7 @@ std::string toSnakeCase(const std::string &str) { std::string toKebabCase(const std::string &str) { std::string result; - for (char ch : str) { + for (const char ch : str) { if (std::isupper(ch)) { result += '-'; result += std::tolower(ch); @@ -355,7 +358,7 @@ std::string toKebabCase(const std::string &str) { std::string toStartCaseWithSpace(const std::string &str) { std::string result; for (size_t i = 0; i < str.length(); ++i) { - char ch = str[i]; + const char ch = str[i]; if (i == 0 || std::isupper(ch)) { if (i > 0) { result += ' '; @@ -399,7 +402,8 @@ int32_t uniform_random(int32_t minNumber, int32_t maxNumber) { static std::uniform_int_distribution<int32_t> uniformRand; if (minNumber == maxNumber) { return minNumber; - } else if (minNumber > maxNumber) { + } + if (minNumber > maxNumber) { std::swap(minNumber, maxNumber); } return uniformRand(getRandomGenerator(), std::uniform_int_distribution<int32_t>::param_type(minNumber, maxNumber)); @@ -427,9 +431,12 @@ void trimString(std::string &str) { } std::string convertIPToString(uint32_t ip) { - char buffer[17]; - fmt::format_to_n(buffer, sizeof(buffer), "{}.{}.{}.{}", ip & 0xFF, (ip >> 8) & 0xFF, (ip >> 16) & 0xFF, (ip >> 24)); - return buffer; + std::array<char, 16> buffer; + auto result = fmt::format_to_n(buffer.data(), buffer.size() - 1, "{}.{}.{}.{}", ip & 0xFF, (ip >> 8) & 0xFF, (ip >> 16) & 0xFF, (ip >> 24)); + + buffer[std::min(result.size, buffer.size() - 1)] = '\0'; + + return std::string(buffer.data()); } std::string formatDate(time_t time) { @@ -461,8 +468,8 @@ std::string formatTime(time_t time) { std::string formatEnumName(std::string_view name) { std::string result { name.begin(), name.end() }; - std::replace(result.begin(), result.end(), '_', ' '); - std::transform(result.begin(), result.end(), result.begin(), [](unsigned char c) { return std::tolower(c); }); + std::ranges::replace(result, '_', ' '); + std::ranges::transform(result, result.begin(), [](unsigned char c) { return std::tolower(c); }); return result; } @@ -471,19 +478,20 @@ std::time_t getTimeNow() { } int64_t getTimeMsNow() { - auto duration = std::chrono::system_clock::now().time_since_epoch(); + const auto duration = std::chrono::system_clock::now().time_since_epoch(); return std::chrono::duration_cast<std::chrono::milliseconds>(duration).count(); } int64_t getTimeUsNow() { - auto duration = std::chrono::system_clock::now().time_since_epoch(); + const auto duration = std::chrono::system_clock::now().time_since_epoch(); return std::chrono::duration_cast<std::chrono::microseconds>(duration).count(); } BedItemPart_t getBedPart(const std::string_view string) { if (string == "pillow" || string == "1") { return BED_PILLOW_PART; - } else if (string == "blanket" || string == "2") { + } + if (string == "blanket" || string == "2") { return BED_BLANKET_PART; } return BED_NONE_PART; @@ -559,12 +567,12 @@ Position getNextPosition(Direction direction, Position pos) { } Direction getDirectionTo(const Position &from, const Position &to, bool exactDiagonalOnly /* =true*/) { - int_fast32_t dx = Position::getOffsetX(from, to); - int_fast32_t dy = Position::getOffsetY(from, to); + const int_fast32_t dx = Position::getOffsetX(from, to); + const int_fast32_t dy = Position::getOffsetY(from, to); if (exactDiagonalOnly) { - int_fast32_t absDx = std::abs(dx); - int_fast32_t absDy = std::abs(dy); + const int_fast32_t absDx = std::abs(dx); + const int_fast32_t absDy = std::abs(dy); /* * Only consider diagonal if dx and dy are equal (exact diagonal). @@ -885,7 +893,7 @@ SpawnTypeNames spawnTypeNames = { }; MagicEffectClasses getMagicEffect(const std::string &strValue) { - auto magicEffect = magicEffectNames.find(strValue); + const auto magicEffect = magicEffectNames.find(strValue); if (magicEffect != magicEffectNames.end()) { return magicEffect->second; } @@ -893,7 +901,7 @@ MagicEffectClasses getMagicEffect(const std::string &strValue) { } ShootType_t getShootType(const std::string &strValue) { - auto shootType = shootTypeNames.find(strValue); + const auto shootType = shootTypeNames.find(strValue); if (shootType != shootTypeNames.end()) { return shootType->second; } @@ -901,7 +909,7 @@ ShootType_t getShootType(const std::string &strValue) { } Ammo_t getAmmoType(const std::string &strValue) { - auto ammoType = ammoTypeNames.find(strValue); + const auto ammoType = ammoTypeNames.find(strValue); if (ammoType != ammoTypeNames.end()) { return ammoType->second; } @@ -909,7 +917,7 @@ Ammo_t getAmmoType(const std::string &strValue) { } WeaponAction_t getWeaponAction(const std::string &strValue) { - auto weaponAction = weaponActionNames.find(strValue); + const auto weaponAction = weaponActionNames.find(strValue); if (weaponAction != weaponActionNames.end()) { return weaponAction->second; } @@ -917,7 +925,7 @@ WeaponAction_t getWeaponAction(const std::string &strValue) { } Skulls_t getSkullType(const std::string &strValue) { - auto skullType = skullNames.find(strValue); + const auto skullType = skullNames.find(strValue); if (skullType != skullNames.end()) { return skullType->second; } @@ -925,7 +933,7 @@ Skulls_t getSkullType(const std::string &strValue) { } ImbuementTypes_t getImbuementType(const std::string &strValue) { - auto imbuementType = imbuementTypeNames.find(strValue); + const auto imbuementType = imbuementTypeNames.find(strValue); if (imbuementType != imbuementTypeNames.end()) { return imbuementType->second; } @@ -937,7 +945,7 @@ ImbuementTypes_t getImbuementType(const std::string &strValue) { * It will be dropped with monsters. Use RespawnPeriod_t instead. */ SpawnType_t getSpawnType(const std::string &strValue) { - auto spawnType = spawnTypeNames.find(strValue); + const auto spawnType = spawnTypeNames.find(strValue); if (spawnType != spawnTypeNames.end()) { return spawnType->second; } @@ -1001,7 +1009,7 @@ uint32_t adlerChecksum(const uint8_t* data, size_t length) { return 0; } - const uint16_t adler = 65521; + constexpr uint16_t adler = 65521; uint32_t a = 1, b = 0; @@ -1032,7 +1040,7 @@ std::string ucfirst(std::string str) { } std::string ucwords(std::string str) { - size_t strLength = str.length(); + const size_t strLength = str.length(); if (strLength == 0) { return str; } @@ -1052,7 +1060,7 @@ bool booleanString(const std::string &str) { return false; } - char ch = tolower(str.front()); + const char ch = tolower(str.front()); return ch != 'f' && ch != 'n' && ch != '0'; } @@ -1073,7 +1081,7 @@ std::string getWeaponName(WeaponType_t weaponType) { case WEAPON_MISSILE: return "missile"; default: - return std::string(); + return {}; } } @@ -1090,7 +1098,7 @@ WeaponType_t getWeaponType(const std::string &name) { { "missile", WeaponType_t::WEAPON_MISSILE } }; - auto it = type_mapping.find(name); + const auto it = type_mapping.find(name); if (it != type_mapping.end()) { return it->second; } @@ -1110,7 +1118,7 @@ MoveEvent_t getMoveEventType(const std::string &name) { { "removeitemitemtile", MOVE_EVENT_REMOVE_ITEM_ITEMTILE } }; - auto it = move_event_type_mapping.find(name); + const auto it = move_event_type_mapping.find(name); if (it != move_event_type_mapping.end()) { return it->second; } @@ -1119,7 +1127,7 @@ MoveEvent_t getMoveEventType(const std::string &name) { } std::string getCombatName(CombatType_t combatType) { - auto combatName = combatTypeNames.find(combatType); + const auto combatName = combatTypeNames.find(combatType); if (combatName != combatTypeNames.end()) { return combatName->second; } @@ -1127,7 +1135,7 @@ std::string getCombatName(CombatType_t combatType) { } CombatType_t getCombatTypeByName(const std::string &combatname) { - auto it = std::find_if(combatTypeNames.begin(), combatTypeNames.end(), [combatname](const std::pair<CombatType_t, std::string> &pair) { + const auto it = std::ranges::find_if(combatTypeNames, [&combatname](const std::pair<CombatType_t, std::string> &pair) { return pair.second == combatname; }); @@ -1135,7 +1143,7 @@ CombatType_t getCombatTypeByName(const std::string &combatname) { } size_t combatTypeToIndex(CombatType_t combatType) { - auto enum_index_opt = magic_enum::enum_index(combatType); + const auto enum_index_opt = magic_enum::enum_index(combatType); if (enum_index_opt.has_value() && enum_index_opt.value() < COMBAT_COUNT) { return enum_index_opt.value(); } else { @@ -1148,7 +1156,7 @@ size_t combatTypeToIndex(CombatType_t combatType) { } std::string combatTypeToName(CombatType_t combatType) { - std::string_view name = magic_enum::enum_name(combatType); + const std::string_view name = magic_enum::enum_name(combatType); if (!name.empty() && combatType < COMBAT_COUNT) { return formatEnumName(name); } else { @@ -1167,59 +1175,86 @@ CombatType_t indexToCombatType(size_t v) { ItemAttribute_t stringToItemAttribute(const std::string &str) { if (str == "store") { return ItemAttribute_t::STORE; - } else if (str == "aid") { + } + if (str == "aid") { return ItemAttribute_t::ACTIONID; - } else if (str == "uid") { + } + if (str == "uid") { return ItemAttribute_t::UNIQUEID; - } else if (str == "description") { + } + if (str == "description") { return ItemAttribute_t::DESCRIPTION; - } else if (str == "text") { + } + if (str == "text") { return ItemAttribute_t::TEXT; - } else if (str == "date") { + } + if (str == "date") { return ItemAttribute_t::DATE; - } else if (str == "writer") { + } + if (str == "writer") { return ItemAttribute_t::WRITER; - } else if (str == "name") { + } + if (str == "name") { return ItemAttribute_t::NAME; - } else if (str == "article") { + } + if (str == "article") { return ItemAttribute_t::ARTICLE; - } else if (str == "pluralname") { + } + if (str == "pluralname") { return ItemAttribute_t::PLURALNAME; - } else if (str == "weight") { + } + if (str == "weight") { return ItemAttribute_t::WEIGHT; - } else if (str == "attack") { + } + if (str == "attack") { return ItemAttribute_t::ATTACK; - } else if (str == "defense") { + } + if (str == "defense") { return ItemAttribute_t::DEFENSE; - } else if (str == "extradefense") { + } + if (str == "extradefense") { return ItemAttribute_t::EXTRADEFENSE; - } else if (str == "armor") { + } + if (str == "armor") { return ItemAttribute_t::ARMOR; - } else if (str == "hitchance") { + } + if (str == "hitchance") { return ItemAttribute_t::HITCHANCE; - } else if (str == "shootrange") { + } + if (str == "shootrange") { return ItemAttribute_t::SHOOTRANGE; - } else if (str == "owner") { + } + if (str == "owner") { return ItemAttribute_t::OWNER; - } else if (str == "duration") { + } + if (str == "duration") { return ItemAttribute_t::DURATION; - } else if (str == "decaystate") { + } + if (str == "decaystate") { return ItemAttribute_t::DECAYSTATE; - } else if (str == "corpseowner") { + } + if (str == "corpseowner") { return ItemAttribute_t::CORPSEOWNER; - } else if (str == "charges") { + } + if (str == "charges") { return ItemAttribute_t::CHARGES; - } else if (str == "fluidtype") { + } + if (str == "fluidtype") { return ItemAttribute_t::FLUIDTYPE; - } else if (str == "doorid") { + } + if (str == "doorid") { return ItemAttribute_t::DOORID; - } else if (str == "timestamp") { + } + if (str == "timestamp") { return ItemAttribute_t::DURATION_TIMESTAMP; - } else if (str == "amount") { + } + if (str == "amount") { return ItemAttribute_t::AMOUNT; - } else if (str == "tier") { + } + if (str == "tier") { return ItemAttribute_t::TIER; - } else if (str == "lootmessagesuffix") { + } + if (str == "lootmessagesuffix") { return ItemAttribute_t::LOOTMESSAGE_SUFFIX; } @@ -1523,20 +1558,26 @@ int64_t OTSYS_TIME(bool useTime) { } SpellGroup_t stringToSpellGroup(const std::string &value) { - std::string tmpStr = asLowerCaseString(value); + const std::string tmpStr = asLowerCaseString(value); if (tmpStr == "attack" || tmpStr == "1") { return SPELLGROUP_ATTACK; - } else if (tmpStr == "healing" || tmpStr == "2") { + } + if (tmpStr == "healing" || tmpStr == "2") { return SPELLGROUP_HEALING; - } else if (tmpStr == "support" || tmpStr == "3") { + } + if (tmpStr == "support" || tmpStr == "3") { return SPELLGROUP_SUPPORT; - } else if (tmpStr == "special" || tmpStr == "4") { + } + if (tmpStr == "special" || tmpStr == "4") { return SPELLGROUP_SPECIAL; - } else if (tmpStr == "crippling" || tmpStr == "6") { + } + if (tmpStr == "crippling" || tmpStr == "6") { return SPELLGROUP_CRIPPLING; - } else if (tmpStr == "focus" || tmpStr == "7") { + } + if (tmpStr == "focus" || tmpStr == "7") { return SPELLGROUP_FOCUS; - } else if (tmpStr == "ultimatestrikes" || tmpStr == "8") { + } + if (tmpStr == "ultimatestrikes" || tmpStr == "8") { return SPELLGROUP_ULTIMATESTRIKES; } @@ -1551,20 +1592,20 @@ SpellGroup_t stringToSpellGroup(const std::string &value) { */ void capitalizeWords(std::string &source) { toLowerCaseString(source); - uint8_t size = (uint8_t)source.size(); + const auto size = static_cast<uint8_t>(source.size()); for (uint8_t i = 0; i < size; i++) { if (i == 0) { - source[i] = (char)toupper(source[i]); + source[i] = static_cast<char>(toupper(source[i])); } else if (source[i - 1] == ' ' || source[i - 1] == '\'') { source[i] = (char)toupper(source[i]); } } } -void capitalizeWordsIgnoringString(std::string &source, const std::string stringToIgnore) { +void capitalizeWordsIgnoringString(std::string &source, const std::string &stringToIgnore) { toLowerCaseString(source); - auto size = static_cast<uint8_t>(source.size()); - auto indexFound = source.find(stringToIgnore); + const auto size = static_cast<uint8_t>(source.size()); + const auto indexFound = source.find(stringToIgnore); for (uint8_t i = 0; i < size; i++) { if (indexFound != std::string::npos && indexFound > 0 && std::cmp_greater(i, static_cast<uint8_t>(indexFound - 1)) && i < (indexFound + stringToIgnore.size())) { @@ -1586,31 +1627,32 @@ void consoleHandlerExit() { if (isatty(STDIN_FILENO)) { getchar(); } - return; } NameEval_t validateName(const std::string &name) { StringVector prohibitedWords = { "owner", "gamemaster", "hoster", "admin", "staff", "tibia", "account", "god", "anal", "ass", "fuck", "sex", "hitler", "pussy", "dick", "rape", "cm", "gm", "tutor", "counsellor", "god" }; StringVector toks; - std::regex regexValidChars("^[a-zA-Z' ]+$"); + const std::regex regexValidChars("^[a-zA-Z' ]+$"); std::stringstream ss(name); - std::istream_iterator<std::string> begin(ss); - std::istream_iterator<std::string> end; + const std::istream_iterator<std::string> begin(ss); + const std::istream_iterator<std::string> end; std::copy(begin, end, std::back_inserter(toks)); if (name.length() < 3 || name.length() > 18) { return INVALID_LENGTH; } - if (!std::regex_match(name, regexValidChars)) { // invalid chars in name + if (!std::regex_match(name, regexValidChars)) { return INVALID_CHARACTER; } - for (std::string str : toks) { + for (const std::string &str : toks) { if (str.length() < 2) { return INVALID_TOKEN_LENGTH; - } else if (std::find(prohibitedWords.begin(), prohibitedWords.end(), str) != prohibitedWords.end()) { // searching for prohibited words + } + + if (std::ranges::find(prohibitedWords, str) != prohibitedWords.end()) { return INVALID_FORBIDDEN; } } @@ -1677,7 +1719,7 @@ std::string getObjectCategoryName(ObjectCategory_t category) { case OBJECTCATEGORY_DEFAULT: return "Unassigned Loot"; default: - return std::string(); + return {}; } } @@ -1720,31 +1762,31 @@ uint8_t forgeBonus(int32_t number) { return 0; } // Dust not consumed - else if (number >= 7400 && number < 9000) { + if (number >= 7400 && number < 9000) { return 1; } // Cores not consumed - else if (number >= 9000 && number < 9500) { + if (number >= 9000 && number < 9500) { return 2; } // Gold not consumed - else if (number >= 9500 && number < 9525) { + if (number >= 9500 && number < 9525) { return 3; } // Second item retained with decreased tier - else if (number >= 9525 && number < 9550) { + if (number >= 9525 && number < 9550) { return 4; } // Second item retained with unchanged tier - else if (number >= 9550 && number < 9950) { + if (number >= 9550 && number < 9950) { return 5; } // Second item retained with increased tier - else if (number >= 9950 && number < 9975) { + if (number >= 9950 && number < 9975) { return 6; } // Gain two tiers - else if (number >= 9975) { + if (number >= 9975) { return 7; } @@ -1752,9 +1794,9 @@ uint8_t forgeBonus(int32_t number) { } std::string formatPrice(std::string price, bool space /* = false*/) { - std::ranges::reverse(price.begin(), price.end()); + std::ranges::reverse(price); price = std::regex_replace(price, std::regex("000"), "k"); - std::ranges::reverse(price.begin(), price.end()); + std::ranges::reverse(price); if (space) { price = std::regex_replace(price, std::regex("k"), " k", std::regex_constants::format_first_only); } @@ -1875,9 +1917,9 @@ std::vector<std::string> split(const std::string &str, char delimiter /* = ','*/ } std::string getFormattedTimeRemaining(uint32_t time) { - time_t timeRemaining = time - getTimeNow(); + const time_t timeRemaining = time - getTimeNow(); - int days = static_cast<int>(std::floor(timeRemaining / 86400)); + const int days = static_cast<int>(std::floor(timeRemaining / 86400)); std::stringstream output; if (days > 1) { @@ -1885,9 +1927,9 @@ std::string getFormattedTimeRemaining(uint32_t time) { return output.str(); } - int hours = static_cast<int>(std::floor((timeRemaining % 86400) / 3600)); - int minutes = static_cast<int>(std::floor((timeRemaining % 3600) / 60)); - int seconds = static_cast<int>(timeRemaining % 60); + const auto hours = static_cast<int>(std::floor((timeRemaining % 86400) / 3600)); + const auto minutes = static_cast<int>(std::floor((timeRemaining % 3600) / 60)); + const auto seconds = static_cast<int>(timeRemaining % 60); if (hours == 0 && minutes == 0 && seconds > 0) { output << " less than 1 minute"; @@ -1967,8 +2009,10 @@ void sleep_for(uint64_t ms) { */ std::string toKey(const std::string &str) { std::string key = asLowerCaseString(str); - std::replace(key.begin(), key.end(), ' ', '-'); - key.erase(std::remove_if(key.begin(), key.end(), [](char c) { return std::isspace(c); }), key.end()); + std::ranges::replace(key, ' ', '-'); + std::erase_if(key, [](char c) { + return std::isspace(c); + }); return key; } @@ -2002,3 +2046,23 @@ bool caseInsensitiveCompare(std::string_view str1, std::string_view str2, size_t return std::tolower(static_cast<unsigned char>(c1)) == std::tolower(static_cast<unsigned char>(c2)); }); } + +void printStackTrace() { + if (g_logger().getLevel() == "info") { + return; + } + + constexpr int kMaxFrames = 64; + std::array<void*, kMaxFrames> stack; + int numFrames = absl::GetStackTrace(stack.data(), kMaxFrames, 0); + absl::InitializeSymbolizer(""); + g_logger().info("Stack trace captured:"); + for (int i = 0; i < numFrames; ++i) { + char symbolBuffer[1024]; + if (absl::Symbolize(stack[i], symbolBuffer, sizeof(symbolBuffer))) { + g_logger().info("{}: {}", i, symbolBuffer); + } else { + g_logger().info("{}: [Unknown function]", i); + } + } +} diff --git a/src/utils/tools.hpp b/src/utils/tools.hpp index e6acddd43f2..ad1df76509c 100644 --- a/src/utils/tools.hpp +++ b/src/utils/tools.hpp @@ -10,7 +10,7 @@ #pragma once namespace pugi { - class xml_parse_result; + struct xml_parse_result; } struct Position; @@ -29,7 +29,7 @@ enum MoveEvent_t : uint8_t; enum NameEval_t : uint8_t; enum BedItemPart_t : uint8_t; enum ObjectCategory_t : uint8_t; -enum ItemAttribute_t : uint64_t; +enum class ItemAttribute_t : uint64_t; enum ReturnValue : uint16_t; enum SpellGroup_t : uint8_t; enum Cipbia_Elementals_t : uint8_t; @@ -77,7 +77,7 @@ int32_t uniform_random(int32_t minNumber, int32_t maxNumber); int32_t normal_random(int32_t minNumber, int32_t maxNumber); bool boolean_random(double probability = 0.5); -BedItemPart_t getBedPart(const std::string_view string); +BedItemPart_t getBedPart(std::string_view string); Direction getDirection(const std::string &string); Position getNextPosition(Direction direction, Position pos); @@ -155,7 +155,7 @@ const char* getReturnMessage(ReturnValue value); void sleep_for(uint64_t ms); void capitalizeWords(std::string &source); -void capitalizeWordsIgnoringString(std::string &source, const std::string stringToIgnore); +void capitalizeWordsIgnoringString(std::string &source, const std::string &stringToIgnore); void consoleHandlerExit(); NameEval_t validateName(const std::string &name); @@ -208,3 +208,5 @@ EnumType enumFromValue(UnderlyingType value) { } bool caseInsensitiveCompare(std::string_view str1, std::string_view str2, size_t length = std::string_view::npos); + +void printStackTrace(); diff --git a/src/utils/vectorsort.hpp b/src/utils/vectorsort.hpp index 0a3618b963f..c9dc35e0d4a 100644 --- a/src/utils/vectorsort.hpp +++ b/src/utils/vectorsort.hpp @@ -27,7 +27,7 @@ namespace stdext { bool erase(const T &v) { update(); - const auto &it = std::ranges::lower_bound(container, v); + auto it = std::ranges::lower_bound(container, v); if (it == container.end()) { return false; } diff --git a/src/utils/wildcardtree.cpp b/src/utils/wildcardtree.cpp index a8ddf98e442..37f29caa2c5 100644 --- a/src/utils/wildcardtree.cpp +++ b/src/utils/wildcardtree.cpp @@ -10,7 +10,7 @@ #include "utils/wildcardtree.hpp" std::shared_ptr<WildcardTreeNode> WildcardTreeNode::getChild(char ch) { - auto it = children.find(ch); + const auto it = children.find(ch); if (it == children.end()) { return nullptr; } @@ -18,7 +18,7 @@ std::shared_ptr<WildcardTreeNode> WildcardTreeNode::getChild(char ch) { } std::shared_ptr<WildcardTreeNode> WildcardTreeNode::getChild(char ch) const { - auto it = children.find(ch); + const auto it = children.find(ch); if (it == children.end()) { return nullptr; } @@ -26,22 +26,22 @@ std::shared_ptr<WildcardTreeNode> WildcardTreeNode::getChild(char ch) const { } std::shared_ptr<WildcardTreeNode> WildcardTreeNode::addChild(char ch, bool breakp) { - std::shared_ptr<WildcardTreeNode> child = getChild(ch); + auto child = getChild(ch); if (child) { if (breakp && !child->breakpoint) { child->breakpoint = true; } } else { - auto pair = children.emplace(std::piecewise_construct, std::forward_as_tuple(ch), std::forward_as_tuple(std::make_shared<WildcardTreeNode>(breakp))); - child = pair.first->second; + const auto [fst, snd] = children.emplace(std::piecewise_construct, std::forward_as_tuple(ch), std::forward_as_tuple(std::make_shared<WildcardTreeNode>(breakp))); + child = fst->second; } return child; } void WildcardTreeNode::insert(const std::string &str) { - std::shared_ptr<WildcardTreeNode> cur = static_self_cast<WildcardTreeNode>(); + auto cur = static_self_cast<WildcardTreeNode>(); - size_t length = str.length() - 1; + const size_t length = str.length() - 1; for (size_t pos = 0; pos < length; ++pos) { cur = cur->addChild(str[pos], false); } @@ -50,7 +50,7 @@ void WildcardTreeNode::insert(const std::string &str) { } void WildcardTreeNode::remove(const std::string &str) { - std::shared_ptr<WildcardTreeNode> cur = static_self_cast<WildcardTreeNode>(); + auto cur = static_self_cast<WildcardTreeNode>(); std::stack<std::shared_ptr<WildcardTreeNode>> path; path.push(cur); @@ -84,7 +84,7 @@ void WildcardTreeNode::remove(const std::string &str) { ReturnValue WildcardTreeNode::findOne(const std::string &query, std::string &result) const { auto cur = static_self_cast<const WildcardTreeNode>(); - for (char pos : query) { + for (const char &pos : query) { cur = cur->getChild(pos); if (!cur) { return RETURNVALUE_PLAYERWITHTHISNAMEISNOTONLINE; @@ -94,14 +94,14 @@ ReturnValue WildcardTreeNode::findOne(const std::string &query, std::string &res result = query; do { - size_t size = cur->children.size(); + const size_t size = cur->children.size(); if (size == 0) { return RETURNVALUE_NOERROR; } else if (size > 1 || cur->breakpoint) { return RETURNVALUE_NAMEISTOOAMBIGUOUS; } - auto it = cur->children.begin(); + const auto it = cur->children.begin(); result += it->first; cur = it->second; } while (true); diff --git a/src/utils/wildcardtree.hpp b/src/utils/wildcardtree.hpp index 9f3d2cf8ece..ccbad316ebd 100644 --- a/src/utils/wildcardtree.hpp +++ b/src/utils/wildcardtree.hpp @@ -11,7 +11,7 @@ #include "declarations.hpp" -class WildcardTreeNode : public SharedObject { +class WildcardTreeNode final : public SharedObject { public: explicit WildcardTreeNode(bool initBreakpoint) : breakpoint(initBreakpoint) { } diff --git a/vcpkg.json b/vcpkg.json index 1549bf6a851..e5a83b21263 100644 --- a/vcpkg.json +++ b/vcpkg.json @@ -19,6 +19,7 @@ "spdlog", "zlib", "bshoshany-thread-pool", + "atomic-queue", { "name": "opentelemetry-cpp", "default-features": true,