Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default Python requests user agent to something specific to awscurl #213

Open
noah-guillory opened this issue Oct 18, 2024 · 3 comments

Comments

@noah-guillory
Copy link

Hi! What do you think about setting the user agent that's sent along with requests to something that indicates that requests are coming from awscurl? I ask because I've had it come up where it would have been useful during debugging something on my end that someone used your tool to call our API.

This is something that seems like a straightforward change since requests has an option that lets you set the user agent. I'm thinking something similar to the user agent of Curl where it's just awscurl/${version_number}.

Your thoughts? I'm happy to contribute a PR for this as well.

@okigan
Copy link
Owner

okigan commented Oct 18, 2024 via email

@noah-guillory
Copy link
Author

That is fair, could get around this by passing through the header with the -H flag. I guess it's more of a question to you if a default user agent header that contains awscurl is desirable or not?

@okigan
Copy link
Owner

okigan commented Oct 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants