Part1and2 #1
Open
Part1and2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2021 00:26
aqus
approved these changes
Jan 11, 2022
| .photo{ | ||
| display: flex; | ||
| width: 180px; | ||
| height: 180px; |
There was a problem hiding this comment.
из-за задания жесткого размера фотографии искажаются пропорции
МОжно поменять img на div и поставить фото на background, в таком случае пропорции искажаться не будут
| .button { | ||
| margin-top: 57px; | ||
| width: 168px; | ||
| height: 46px; |
There was a problem hiding this comment.
лучше не ограничивать размеры кнопки, чтобы она растягивалась по содержимому. Достаточно добавить паддингов.
Например, если ваша карточка будет локализована на немецкий, то в этом случае весь текст может уже не влезть и будет примерно так
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.