Bust cover image cache after uploading a new image #8489
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Converting back to draft as I just saw the comment about cache invalidation #8480 (comment) |
- Refresh cover image on page, right after save - Previously required page reload for changes to show up on page
| facilityFetch(); | ||
| fetchImage(); | ||
| setCoverImageEdited(true); |
There was a problem hiding this comment.
Can we wait till the fetch image is done (in the loading state itself of the image edit modal) before running facility fetch?
There was a problem hiding this comment.
Sure, so something like this?
There was a problem hiding this comment.
yes, but ensure the loading state is shown in the image edit modal till it completes.
| const [coverImageLoaded, setCoverImageLoaded] = useState(false); | ||
| const [coverImageUrl, setCoverImageUrl] = useState<string | undefined>(""); |
There was a problem hiding this comment.
And these unnecessay useStates too could be removed that way.
There was a problem hiding this comment.
Well, coverImageLoaded is set based on the image load (addressing #8480 (comment)). Can remove the second one though.
There was a problem hiding this comment.
but that state is being used only to decide whether the tooltip should be shown or not right? but when we are going to remove the tooltip anyhow, this state is not needed in the first place right?
There was a problem hiding this comment.
but that state is being used only to decide whether the tooltip should be shown or not right? but when we are going to remove the tooltip anyhow, this state is not needed in the first place right?
Yep, but are we removing the tool tip entirely? I thought it was to remove tool tip on successful image load.
yes, but ensure the loading state is shown in the image edit modal till it completes.
Hmm, well the modal closes immediately, so shouldn't be an issue. On a side note, we could use the tool tip here (and remove the coverImageLoaded state).
| imageUrl += "?" + Date.now(); | ||
| setCoverImageUrl(imageUrl); |
There was a problem hiding this comment.
Let's not add query params. We know for sure that it always fetches the latest image with query params present. There's no need to perform the vary header method when giving query params right.
There was a problem hiding this comment.
Will remove 👍 I added query params since fetch/vary header behavior wasn't consistent on Firefox (though it's fine on Safari).
| credentials: "include", | ||
| mode: "no-cors", |
There was a problem hiding this comment.
are these headers required? how does this differ from with and without these?
There was a problem hiding this comment.
credentials isn't required, mode is though; was getting 502 error for the fetch call without it.
sainak
changed the title
|
with ohcnetwork/care#2472 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist