Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Diagnosis at Discharge field when patient is discharged #8390

Merged
merged 23 commits into from
Oct 1, 2024
Merged

Added Diagnosis at Discharge field when patient is discharged #8390

merged 23 commits into from
Oct 1, 2024

Conversation

JOSHIK27
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@JOSHIK27 JOSHIK27 requested a review from a team as a code owner August 22, 2024 07:27
@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024

@JOSHIK27 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 755c4bc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c6fb6d41c7240008c820b2
😎 Deploy Preview https://deploy-preview-8390--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JOSHIK27 JOSHIK27 mentioned this pull request Aug 22, 2024
Closed
4 tasks
rithviknishad
rithviknishad requested changes Aug 22, 2024
View reviewed changes
src/Components/Facility/DischargeModal.tsx Outdated Show resolved Hide resolved
src/Components/Facility/DischargeModal.tsx Outdated Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 627d02e
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66c6f1668fbd1e00081bee4e

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 9f2f9d6
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66c6f17c05be5a00080491d2

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Aug 22, 2024
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Aug 22, 2024
@samholics
Copy link

can we rename the "Diagnoses" to "Diagnosis at Discharge" pls?
image

@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit f334814
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66fab35171c4e30009dbbf1c
😎 Deploy Preview https://deploy-preview-8390--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member

can we rename the "Diagnoses" to "Diagnosis at Discharge" pls?

@samholics Done

@samholics
Copy link

Tested working fine @rithviknishad @nihal467

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024 •
edited
Loading

@JOSHIK27

image

  • When we open an active consultation page, it is throwing not found an error with 404
  • the cypress was failing as well, verify the test is also passing

CC: @rithviknishad

@github-actions github-actions bot removed the stale label Sep 20, 2024
@nihal467
Copy link
Member

nihal467 commented Sep 23, 2024 •
edited
Loading

@JOSHIK27

image

  • After creating a new consultation with medicine for a patient, there is something went wrong error thrown on the frontend

image

  • when you open any live consultation page, it is also throwing something went wrong error

image

  • Click on the details of the failing action and try to run the failing test manually; then you can debug it properly. For now, in general, the Cypress failure is due to a bug in the PR.

@nihal467 nihal467 removed their assignment Sep 23, 2024
@JOSHIK27
Copy link
Contributor Author

@JOSHIK27

image

  • After creating a new consultation with medicine for a patient, there is something went wrong error thrown on the frontend

image

  • when you open any live consultation page, it is also throwing something went wrong error

image

  • Click on the details of the failing action and try to run the failing test manually; then you can debug it properly. For now, in general, the Cypress failure is due to a bug in the PR.

Sure... Iam working on it.

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Sep 23, 2024
@JOSHIK27
Copy link
Contributor Author

JOSHIK27 commented Sep 25, 2024 •
edited
Loading

I ran a test that failed here (facility/homepage),weirdly it passed when locally tested on same branch as the pr.
@nihal467 @rithviknishad
The other test that failed is patientlogupdate, when i tested locally it failed (1 pass, 4 fail as same as here). I am assuming facility/homepage failed due to timeouts here. I will look into patientlogupdate test manually and figure out.
image
image

@rithviknishad rithviknishad added needs testing and removed test failed Deploy-Failed Deplyment is not showing preview labels Sep 30, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 99d79de into ohcnetwork:develop Oct 1, 2024
23 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

@JOSHIK27 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@shivankacker shivankacker shivankacker approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discharge diagnosis
6 participants
@JOSHIK27 @samholics @rithviknishad @nihal467 @shivankacker @khavinshankar