Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP Days Chip in Patient List and Patient Dashboard #7252

Closed
wants to merge 5 commits into from
Closed

Add IP Days Chip in Patient List and Patient Dashboard #7252

wants to merge 5 commits into from

Conversation

konavivekramakrishna
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner February 22, 2024 18:16
@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 2:22pm

@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b651e30
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/662698fbd4c11f00086b1ca5
😎 Deploy Preview https://deploy-preview-7252--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@konavivekramakrishna konavivekramakrishna changed the title Add IP Days Added IP Days Chip in Patient List and Patient Dashboard Feb 22, 2024
Ashesh3
Ashesh3 requested changes Feb 22, 2024
View reviewed changes
src/Utils/utils.ts Outdated Show resolved Hide resolved
@rithviknishad rithviknishad added reviewed reviewed by a core member and removed needs review labels Feb 23, 2024
@nihal467
Copy link
Member

@konavivekramakrishna
image

  • Make the IP Days a circle badge on the consultation page similar to the MEWS score.

@nihal467 nihal467 added changes required and removed needs testing reviewed reviewed by a core member labels Feb 28, 2024
@konavivekramakrishna
Copy link
Contributor Author

image

edge case when the year is 0202 it returns NaN

should this be handled?

@github-actions GitHub Actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 13, 2024
@rithviknishad
Copy link
Member

edge case when the year is 0202 it returns NaN

can be ignored. newer data wouldn't have weird years right.

@konavivekramakrishna konavivekramakrishna marked this pull request as draft April 16, 2024 14:08
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 16, 2024
@konavivekramakrishna konavivekramakrishna marked this pull request as ready for review April 18, 2024 13:16
@konavivekramakrishna
Copy link
Contributor Author

  • image
  • image

@nihal467
Copy link
Member

@konavivekramakrishna
image

the badge is missing text in the patient list view

@konavivekramakrishna
Copy link
Contributor Author

konavivekramakrishna commented Apr 24, 2024 •
edited
Loading

I did't understand,

can you please specify what text it is missing,

IG everything is working as intended

@rithviknishad
Copy link
Member

@nihal467 could you elaborate a bit more? Everything seems fine to me, IP Days are present in the patient list as well as consultation dashboard.

@konavivekramakrishna konavivekramakrishna changed the title Added IP Days Chip in Patient List and Patient Dashboard Add IP Days Chip in Patient List and Patient Dashboard Apr 25, 2024
@nihal467
Copy link
Member

nihal467 commented Apr 29, 2024 •
edited
Loading

@rithviknishad can you push the two minor fix :

image

  • add a prefix in the patient list page "IP Days"
  • only show this badge if the patient is having a live consultation
  • once the patient is discharged, in the consultation page retain number of days badge (not working now)

@rithviknishad
Copy link
Member

Closing as completed in #7735

@rithviknishad rithviknishad mentioned this pull request Apr 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
test failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Day of Admission: Patient
4 participants
@konavivekramakrishna @nihal467 @rithviknishad @Ashesh3