Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blood Pressure: Temp. fix to treat negative values as undefined #6987

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 6, 2024

Proposed Changes

Before

image

After

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner January 6, 2024 14:27
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 06907f2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/659963678071ba0008497101
😎 Deploy Preview https://deploy-preview-6987--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Jan 6, 2024 2:27pm

@rithviknishad rithviknishad requested a review from Ashesh3 January 6, 2024 14:28
@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Jan 6, 2024
Copy link

cypress bot commented Jan 6, 2024

Passing run #1840 ↗︎

0 95 0 0 Flakiness 0

Details:

Blood Pressure: Temp. fix to treat negative values as undefined
Project: CARE Commit: 06907f293b
Status: Passed Duration: 02:11 💡
Started: Jan 6, 2024 2:31 PM Ended: Jan 6, 2024 2:33 PM

Review all test suite changes for PR #6987 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jan 6, 2024

LGTM

@khavinshankar khavinshankar merged commit 7f6cc0c into develop Jan 6, 2024
43 of 44 checks passed
@khavinshankar khavinshankar deleted the bp--treat-negative-as-undefined branch January 6, 2024 14:55
Copy link

github-actions bot commented Jan 6, 2024

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing P1 breaking issue or vital feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BP chart is showing -1 value in the patient consultation page
4 participants