Fix: Permission Handling Issues in Microphone and Camera Capture Dialogs #8830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM |
khavinshankar
requested changes
Oct 22, 2024
Comment on lines
48
to
49
| msg: "Please grant microphone permission to record audio.", | ||
| }); |
|
👋 Hi, @shauryag2002, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
…o issues/8829/camera-audio-permissions
github-actions
bot
added
Deploy-Failed
|
@shauryag2002 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Record audiomodal, the recording timer now starts only after the user grants microphone access. If permission is denied, an appropriate error message is displayed to the user.Open Cameramodal, when camera access is blocked, a proper error message is shown instead of an empty container. The camera no longer freezes after clicking theSwitchbutton, and a clear message is displayed if the camera cannot be switched.Video:
record_audio.mp4
@ohcnetwork/care-fe-code-reviewers
Merge Checklist