Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Needed for Advanced Filter and Sort By Features in Patients Tab #8810

Closed
Rishith25 opened this issue Oct 17, 2024 · 4 comments
Closed

Comments

@Rishith25
Copy link
Contributor

Description:

There is a need for clarification on the expected behavior of the Advanced Filter and Sort By functionalities in the Patients tab. Currently, clearing the advanced filter resets the sorting order, which is not the intended behavior.

Steps to Reproduce:

Navigate to the Patients tab.
Sort the patient data by name.
Apply an Advanced Filter (e.g., filter by gender).
Clear the Advanced Filter.

Expected Behavior:

When the Advanced Filter is cleared, the sorting order (by name) should remain unchanged. Users should be able to retain the sort order regardless of filter status.

Screenshots or Videos:

Recording.2024-10-17.105829.mp4
@bodhish
Copy link
Member

bodhish commented Oct 17, 2024

The purpose of the clear button is to clear all applied filters. Its expected to clear the sort filter also.

@rithviknishad to reconfirm.

@rithviknishad
Copy link
Member

rithviknishad commented Oct 17, 2024

As a user, I'd expect the behaviour to be "reset everything to original state" in mind, and hence that'd include the sort filter too.

Just checked with github issues page too 😄
Clearing the filters also removes the applied sort ordering too.

@rithviknishad
Copy link
Member

Should we consider renaming the clear button to something more appropriate instead? @bodhish

@bodhish
Copy link
Member

bodhish commented Oct 17, 2024

Nah, let's get feedback from users and then decide if they complain

@github-project-automation github-project-automation bot moved this to Triage in Care Oct 17, 2024
@Jacobjeevan Jacobjeevan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Care Oct 28, 2024
@Jacobjeevan Jacobjeevan moved this from Done to Triage in Care Oct 28, 2024
@Jacobjeevan Jacobjeevan removed this from Care Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants