Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary API Call on Profile Update Without Changes #8804

Closed
JavidSumra opened this issue Oct 16, 2024 · 2 comments · Fixed by #8809
Closed

Unnecessary API Call on Profile Update Without Changes #8804

JavidSumra opened this issue Oct 16, 2024 · 2 comments · Fixed by #8809
Assignees

Comments

@JavidSumra
Copy link
Contributor

Bug Description:

When updating the user profile without making any changes to the form fields, a "PATCH" request is still sent to the backend, even though no updates have been made.


Steps to Reproduce:

  1. Navigate to "/user/profile"
  2. Click on "Edit User Profile"
  3. Scroll down and click the "Update" button without modifying any fields
  4. Observe that a PATCH request is made to the backend despite no changes

Expected Behavior:

No API call should be triggered if there are no updates made to the form fields.

Screenshots or Videos

2024-10-16.17-28-43-88.mp4

Desktop:

  • OS: Windows
  • Browser: Chrome
  • Version: 129.0.6668.101

Additional Context:

An extra API call is unnecessary if no data has been modified.

@JavidSumra
Copy link
Contributor Author

I would like to take on this issue and work on it.

@rithviknishad
Copy link
Member

Nice find @JavidSumra

Expected behaviour:

Update button to be disabled if nothing changed

@github-project-automation github-project-automation bot moved this to Triage in Care Oct 16, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Oct 16, 2024
@rithviknishad rithviknishad moved this from Up Next to Review required in Care Oct 17, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants