Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes "Created-at" section peeping out of "Doctor's discussion" #8796

Conversation

Sulochan-khadka
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner October 15, 2024 14:44
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 0a79141
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6725d62fcc5b6a0008df7884
😎 Deploy Preview https://deploy-preview-8796--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

image

@Sulochan-khadka the issue still persist

@bodhish
Copy link
Member

bodhish commented Oct 21, 2024

@Sulochan-khadka when you are making a PR please make sure that its working. I would highly recommend you to complete the Merge checklist when you submit a PR.

  • Prep screenshot or demo video for changelog entry, and attach it to issue.

☝️ we have added this in the merge checklist for the author to catch accidental bugs that he maynot have caught, a demo would actually be help them discover it better.

@Sulochan-khadka
Copy link
Contributor Author

@nihal467 @bodhish Apologies for the inconvenience caused. Actually i only explored the bug in patient's notes and not in discussion notes. Therefore, was a bit confused. Have solved both the bugs...

Patent's notes:

Screenshot 2024-10-21 at 4 23 56 PM

Discussion notes:

Screenshot 2024-10-21 at 4 25 34 PM

Copy link

👋 Hi, @Sulochan-khadka,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 23, 2024
@Jacobjeevan
Copy link
Contributor

@Sulochan-khadka Can you resolve the conflicts?

@Sulochan-khadka
Copy link
Contributor Author

@Sulochan-khadka Can you resolve the conflicts?

While merging , it is showing error in this line :
"import { pluginMap } from "./pluginMap"; " Does this file exists. @nihal467 @rithviknishad

@Jacobjeevan
Copy link
Contributor

While merging , it is showing error in this line : "import { pluginMap } from "./pluginMap"; " Does this file exists. @nihal467 @rithviknishad

https://github.com/ohcnetwork/care_fe?tab=readme-ov-file#install-the-required-dependencies will create the file

@rithviknishad rithviknishad removed test failed merge conflict pull requests with merge conflict labels Nov 2, 2024
@rithviknishad rithviknishad changed the title fixes:"Created-at" section peeping out of "Doctor's discussion" fixes "Created-at" section peeping out of "Doctor's discussion" Nov 2, 2024
@rithviknishad rithviknishad merged commit 3757705 into ohcnetwork:develop Nov 2, 2024
22 of 23 checks passed
Copy link

github-actions bot commented Nov 2, 2024

@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Created-at" section peeping out of "Doctor's discussion"
5 participants