Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent recursive redirect between session expired and root #8777

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • fix: prevent recursive redirect between session expired and root

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner October 14, 2024 08:43
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit af36ff4
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670cd9b13eea510008edfd85
😎 Deploy Preview https://deploy-preview-8777--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad self-assigned this Oct 14, 2024
Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: af36ff4
Status: ✅  Deploy successful!
Preview URL: https://29f8c594.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-fix-reursive-r.care-fe.pages.dev

View logs

Copy link

cypress bot commented Oct 14, 2024

CARE    Run #3633

Run Properties:  status check passed Passed #3633  •  git commit af36ff4063: fix: prevent recursive redirect between session expired and root
Project CARE
Run status status check passed Passed #3633
Run duration 03m 17s
Commit git commit af36ff4063: fix: prevent recursive redirect between session expired and root
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 7518c6b into develop Oct 15, 2024
30 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/reursive-redirect-bw-session-expired-and-root branch October 15, 2024 09:25
Copy link

@rithviknishad @rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants