Enhance Patient Search UI with Smart Component.. #8725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@Jash2606 can you please fix the failing cypress tests |
Hey @khavinshankar, could you help me figure out the error? I'm new to Cypress testing and open-source contributions, so any guidance would be appreciated. Thanks! |
bodhish
requested changes
Oct 7, 2024
There was a problem hiding this comment.
@Jash2606 when we add designs in an issue, we expect it to be in sync.
The current implementation is a super hacky version of the design.
If I was building it:
- It would have been a component
- the component accepts a config (its not going to be just these inputs it can be anything right)
- it will use a single state to store the user input and selected type
- the design will be 100% match
/will let users switch the selected input type.
|
@Jash2606 closing this PR as it is inactive. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Video:
Screen.Recording.2024-10-05.222521.mp4
Merge Checklist