Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment overflow and ensure content fits within div #8722

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Fix comment overflow and ensure content fits within div #8722

merged 11 commits into from
Oct 22, 2024

Conversation

chakribontha
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@chakribontha chakribontha requested a review from a team as a code owner October 5, 2024 12:54
@netlify Netlify
Copy link

netlify bot commented Oct 5, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1d5b173
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670d5b6c273f110008becf92
😎 Deploy Preview https://deploy-preview-8722--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodhish
bodhish requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add @tailwindcss/typography and add prose class to fix it.

@chakribontha
Copy link
Contributor Author

chakribontha commented Oct 8, 2024 •
edited
Loading

Hey @bodhish ,

I've made the necessary changes to address the comment-wrapping issue and linked it to issue #8743 . Please check it out.

Thanks for the feedback!

@bodhish
Copy link
Member

bodhish commented Oct 9, 2024

why create another PR? Just add the commit to this branch and it should solve the issue.

@bodhish bodhish mentioned this pull request Oct 9, 2024
Closed
dependabot bot and others added 8 commits October 9, 2024 14:29
@dependabot @chakribontha
Bump @fontsource/inter from 5.0.21 to 5.1.0 (ohcnetwork#8709)
4fdca22
@Jacobjeevan @chakribontha
Move print button inside the body (ohcnetwork#8704)
4c3a423
@shivankacker @chakribontha
Allows configuring available languages through env and adds Hindi to …
b69b605 
…CARE (ohcnetwork#8692)
@bodhish @nihal467 @chakribontha
Re-build sidebar UI (ohcnetwork#8680)
07d6c07 
Co-authored-by: Mohammed Nihal <[email protected]>
@bodhish @gigincg
@rithviknishad @chakribontha
Add support for shadcn and clean up components (ohcnetwork#8706)
d82eee1 
... also added figtree as default font 

Co-authored-by: Gigin George <[email protected]>
Co-authored-by: rithviknishad <[email protected]>
@rithviknishad @bodhish
@gigincg @chakribontha
Remove External Results; Remove unused references in Patient Registra…
9b14273 
…tion Cypress Test (ohcnetwork#8737)

Co-authored-by: Bodhish Thomas <[email protected]>
Co-authored-by: Gigin George <[email protected]>
@chakribontha
Fixed comment wrapping and applied @tailwindcss/typography with prose…
656f8e4 
… class
@chakribontha
Merge branch 'ohcnetwork:develop' into issues/8699/comment-wrap-fixed
c306b7e
@chakribontha chakribontha requested a review from bodhish October 9, 2024 09:12
bodhish
bodhish reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need text justify?

@chakribontha chakribontha requested a review from bodhish October 9, 2024 19:46
@nihal467
Copy link
Member

@chakribontha
image

  • in the resource page, the text in the comments are properly utilising the right area

@bodhish bodhish mentioned this pull request Oct 21, 2024
Closed
@samholics
Copy link

samholics commented Oct 21, 2024 •
edited
Loading

tested, working fine @nihal467
comments on resource is utilizing the right hand side area
image

@chakribontha chakribontha requested a review from bodhish October 21, 2024 10:28
@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing labels Oct 21, 2024
@khavinshankar khavinshankar merged commit c23b16c into ohcnetwork:develop Oct 22, 2024
24 checks passed
@github-actions GitHub Actions
Copy link

@chakribontha Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Bug in the Shifting Section and Resource Section- Comment Box Display Issue
8 participants
@chakribontha @bodhish @nihal467 @samholics @khavinshankar @Jacobjeevan @shivankacker @rithviknishad