Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error Messages Persist in UserAdd Component #8721

Merged

Conversation

shauryag2002
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Video of change:

Merge Checklist

error_display_fix.mp4
  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shauryag2002 shauryag2002 requested a review from a team as a code owner October 5, 2024 11:19
Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit fcfb2f2
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670120b3225ca500085e4787
😎 Deploy Preview https://deploy-preview-8721--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Oct 8, 2024

LGTM

@shauryag2002
Copy link
Contributor Author

LGTM

Wait @nihal467 Before merging this, I am converting every form's error message persist in care_fe and after that you can merge that commit.

@khavinshankar
Copy link
Member

@shauryag2002 Will merge this PR, we are planning on removing redux (#8731), so these would be covered in that, if not feel free to make a new PR.

And incase if you are looking for open issues, https://github.com/ohcnetwork/care_fe/issues?q=is%3Aissue%20state%3Aopen%20no%3Aassignee

@khavinshankar khavinshankar merged commit 0befd6b into ohcnetwork:develop Oct 9, 2024
26 checks passed
Copy link

github-actions bot commented Oct 9, 2024

@shauryag2002 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Messages Persist in UserAdd Component When Typing or Selecting Items
4 participants