Noufalrahim/feat/added units to pressure sore #8715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
requested changes
Oct 5, 2024
src/Locale/en/Consultation.json
Outdated
Comment on lines
80
to
81
| "width_label__cm": "Width (cm)", | ||
| "length_label__cm": "Length (cm)" |
There was a problem hiding this comment.
Suggested change
| "width_label__cm": "Width (cm)", | |
| "length_label__cm": "Length (cm)" | |
| "width": "Width ({{ unit }})", | |
| "length": "Length ({{ unit }})" |
| @@ -129,7 +132,7 @@ const RegionEditor = (props: RegionEditorProps) => { | |||
| <br /> | |||
| <div className="grid grid-cols-2 gap-2"> | |||
| <TextFormField | |||
| label="Width" | |||
| label={t("width_label__cm")} | |||
There was a problem hiding this comment.
Suggested change
| label={t("width_label__cm")} | |
| label={t("width", { unit: "cm" })} |
| @@ -141,7 +144,7 @@ const RegionEditor = (props: RegionEditorProps) => { | |||
| onChange={(e) => update({ width: parseFloat(e.value) })} | |||
| /> | |||
| <TextFormField | |||
| label="Length" | |||
| label={t("length_label__cm")} | |||
There was a problem hiding this comment.
Suggested change
| label={t("length_label__cm")} | |
| label={t("length", { unit: "cm" })} |
rithviknishad
approved these changes
Oct 5, 2024
…://github.com/noufalrahim/care_fe into noufalrahim/feat/added-units-to-pressure-sore
|
@noufalrahim please add human firendly title and description for the PR. We also expect you to complete the #Merge Checklist |
|
👋 Hi, @noufalrahim, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
@noufalrahim can you push the changes requested by @bodhish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist