Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped resource and shifting boards to the KanbanBoard component and removed react-dnd #8713

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Revamped resource and shifting boards to the KanbanBoard component and removed react-dnd #8713

merged 5 commits into from
Oct 13, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Oct 4, 2024 •
edited
Loading

Proposed Changes

Screenshot 2024-10-07 at 12 19 55 PM Screenshot 2024-10-07 at 12 19 43 PM

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner October 4, 2024 17:51
@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit c7c9ec9
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670a72be3eea510008951140
😎 Deploy Preview https://deploy-preview-8713--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7c9ec9
Status: ✅  Deploy successful!
Preview URL: https://729b7622.care-fe.pages.dev
Branch Preview URL: https://shifting-board.care-fe.pages.dev

View logs

@cypress Cypress
Copy link

cypress bot commented Oct 4, 2024 •
edited
Loading

CARE    Run #3625

Run Properties:  status check passed Passed #3625  •  git commit c7c9ec9b90: Revamped resource and shifting boards to the KanbanBoard component and removed r...
Project CARE
Run status status check passed Passed #3625
Run duration 03m 10s
Commit git commit c7c9ec9b90: Revamped resource and shifting boards to the KanbanBoard component and removed r...
Committer Shivank Kacker
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124

@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

@shivankacker we have plans to add more boards like these
image
Make sure the KanbanBoard component is clean.

@shivankacker
Copy link
Member Author

@bodhish yup the KanbanBoard component is made to be reused in the future. It is easy to configure and supports infinite scroll.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Oct 8, 2024

@shivankacker can you clear the merge conflict

@nihal467
Copy link
Member

nihal467 commented Oct 8, 2024 •
edited by shivankacker
Loading

@shivankacker

image

  • the exported shifting CSV file names are not correct
  • can you clear the merge conflict

rest of the functionality looks good

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 9, 2024
@shivankacker
Copy link
Member Author

@nihal467 fixed

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Oct 9, 2024 •
edited
Loading

LGTM @shivankacker @khavinshankar can you clear the merge conflict

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 12, 2024
@khavinshankar khavinshankar merged commit ed3be2b into develop Oct 13, 2024
25 of 26 checks passed
@khavinshankar khavinshankar deleted the shifting-board branch October 13, 2024 00:08
@github-actions GitHub Actions
Copy link

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix shifting and resource board scroll and drag Replace React-DND
4 participants
@shivankacker @bodhish @nihal467 @khavinshankar