Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to see full content of notes of prescriptions #8643

Closed
nihal467 opened this issue Sep 26, 2024 · 3 comments · Fixed by #8647
Closed

Unable to see full content of notes of prescriptions #8643

nihal467 opened this issue Sep 26, 2024 · 3 comments · Fixed by #8647
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@nihal467
Copy link
Member

Describe the bug

When you write a PRN prescription notes for more than 3 lines, the edit prescription page will show a read more button in the note field, but when you try to click on the read more button, the medicine details collapse

To Reproduce
Steps to reproduce the behavior:

  1. Go to the patient tab and click on any active consultation page
  2. click on the medicine section in the nav bar
  3. click on edit prescription and add a prn prescription with three lines note
  4. once save, on the edit prescription page, click on the read more button
  5. See an error

Expected behavior

read more button on the edit prescription page should work properly

Screenshots

image

@nihal467 nihal467 added the bug Something isn't working label Sep 26, 2024
@nihal467 nihal467 added this to Care Sep 26, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Sep 26, 2024
@nihal467 nihal467 moved this from Triage to Up Next in Care Sep 26, 2024
@rithviknishad
Copy link
Member

Let's not wrap the Notes field in a <ReadMore /> component and keep it simple like other fields. The prescription card itself is collapsible if a short version is required, and it'd be simpler to just show all details in full in the expanded view of a prescription.

@rithviknishad rithviknishad changed the title Unable to edit PRN prescription notes in the medicine module Unable to see full content of notes of prescriptions Sep 26, 2024
@vishwansh01
Copy link
Contributor

@nihal467 I would like to take this issue

@vishwansh01
Copy link
Contributor

@nihal467
I just created a pull request solving this issue: #8647

@rithviknishad rithviknishad moved this from Up Next to Review required in Care Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants