fix: added tooltips for Discussion Notes icons (#8618) #8637

syedfardeenjeelani · 2024-09-26T11:34:07Z

Proposed Changes

Fixes Add tooltip for Discussion Notes Icons #8618 (Add tooltips for Discussion Notes Icons)
Added tooltips for icons in the Discussion Notes module:
- "Open in full window"
- "Minimize"
- "Close"
- "Reply"
- "Send"
- "Edit"

Demo Video

icons.1.mp4

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews.
Completion of QA.

netlify · 2024-09-26T11:34:26Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`3c8ac9e`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/670fb2bd7841da00085cc549
😎 Deploy Preview	https://deploy-preview-8637--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

LGTM, but do keep the representable texts in i18n locale files and use useTranslations as mentioned in the PR merge checklist

…i/care_fe into fix/issue-8618

rithviknishad · 2024-09-26T16:57:08Z

src/Locale/en/Consultation.json

+  "open_in_full_window": "Open in full window",
+  "minimize_screen":"Minimize",
+  "close_screen":"Close",
+  "send_message":"Send"


Let's keep it in Common.json as these texts by themselves are generic although maybe used in Consultation and/or anywhere else.

src/Locale/en/Asset.json

…i/care_fe into fix/issue-8618

…e to incorrect previous placement

nihal467 · 2024-09-27T11:18:10Z

LGTM

github-actions · 2024-09-30T19:50:35Z

👋 Hi, @syedfardeenjeelani,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

bodhish

CC @rithviknishad

src/Components/Common/components/Page.tsx

Co-authored-by: Bodhish Thomas <[email protected]>

bodhish · 2024-10-02T19:20:07Z

src/Locale/en/Common.json

@@ -231,6 +231,11 @@
  "SORT_OPTIONS__-name": "Patient name Z-A",
  "SORT_OPTIONS__bed__name": "Bed No. 1-N",
  "SORT_OPTIONS__-bed__name": "Bed No. N-1",
+  "open_in_full_window": "Open in full window",


I think Fullscreen is better 🤔

bodhish · 2024-10-02T19:20:52Z

src/Locale/en/Common.json

+  "open_in_full_window": "Open in full window",
+  "minimize_screen":"Minimize",
+  "close_screen":"Close",
+  "send_discussion_message":"Send",


Can't this be just Send? 🤔 Same for the others as its added to the common.

Can't this be just Send? 🤔 Same for the others as its added to the common.

please review the changes @bodhish

wq: :wq

rithviknishad · 2024-10-13T09:28:32Z

Sync your fork's develop branch with latest develop, and merge develop to your PR branch. And while resolving conflicts, move the newly added keys to en.json file and delete the Common.json

Co-authored-by: Bodhish Thomas <[email protected]>

rithviknishad

Ensure prettier is configured and used properly.

src/Locale/en.json

nihal467 · 2024-10-14T09:03:27Z

LGTM

github-actions · 2024-10-16T10:24:20Z

👋 Hi, @syedfardeenjeelani,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2024-10-16T13:13:25Z

👋 Hi, @syedfardeenjeelani,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

fix: add tooltips for Discussion Notes icons (#8618)

729edf2

syedfardeenjeelani requested a review from a team as a code owner September 26, 2024 11:34

syedfardeenjeelani added 2 commits September 26, 2024 17:05

Update Page.tsx

1c590d4

Update PatientNoteCard.tsx

59197ed

rithviknishad reviewed Sep 26, 2024

View reviewed changes

syedfardeenjeelani and others added 3 commits September 26, 2024 19:31

added representable texts in i18n locale files

0b98c7a

Merge branch 'fix/issue-8618' of https://github.com/syedfardeenjeelan…

adb4a9b

…i/care_fe into fix/issue-8618

Merge branch 'develop' into fix/issue-8618

5f564f8

rithviknishad requested changes Sep 26, 2024

View reviewed changes

syedfardeenjeelani added 3 commits September 26, 2024 22:36

moved texts to commonJs

7316d32

Merge branch 'fix/issue-8618' of https://github.com/syedfardeenjeelan…

9148491

…i/care_fe into fix/issue-8618

Revert: Moved resume file from 'common' back to 'assets' directory du…

f77d4af

…e to incorrect previous placement

rithviknishad approved these changes Sep 27, 2024

View reviewed changes

rithviknishad added the needs testing label Sep 27, 2024

nihal467 added 2 commits September 27, 2024 09:25

Merge branch 'develop' into fix/issue-8618

ea9d99a

Merge branch 'develop' into fix/issue-8618

6f4559d

nihal467 added tested and removed needs testing labels Sep 27, 2024

github-actions bot added the merge conflict pull requests with merge conflict label Sep 30, 2024

bodhish requested changes Sep 30, 2024

View reviewed changes

src/Components/Common/components/Page.tsx Outdated Show resolved Hide resolved

rithviknishad and others added 2 commits October 1, 2024 09:07

Update src/Components/Common/components/Page.tsx

d8634dd

Co-authored-by: Bodhish Thomas <[email protected]>

Merge branch 'develop' into fix/issue-8618

aeb9a9a

rithviknishad added hacktoberfest-accepted and removed merge conflict pull requests with merge conflict labels Oct 1, 2024

rithviknishad requested a review from bodhish October 1, 2024 09:10

khavinshankar approved these changes Oct 1, 2024

View reviewed changes

bodhish requested changes Oct 2, 2024

View reviewed changes

syedfardeenjeelani and others added 3 commits October 13, 2024 14:54

Update Page.tsx

246b51f

Update PatientNoteCard.tsx

0352002

moved texts to commonJs

94044c2

wq: :wq

rithviknishad closed this Oct 13, 2024

rithviknishad reopened this Oct 13, 2024

syedfardeenjeelani and others added 6 commits October 13, 2024 15:00

fix: changed the name of tooltips

3d9614c

Update src/Components/Common/components/Page.tsx

4838926

Co-authored-by: Bodhish Thomas <[email protected]>

fix: changed the name of tooltips

082f271

fix: forked the latest changes

8701a7e

fix: forked the latest changes

cd9c325

Update en.json

9ce188a

rithviknishad removed changes required merge conflict pull requests with merge conflict labels Oct 13, 2024

rithviknishad approved these changes Oct 13, 2024

View reviewed changes

src/Locale/en.json Outdated Show resolved Hide resolved

Update src/Locale/en.json

e454e25

rithviknishad added the needs testing label Oct 13, 2024

added tooltip for edit icon

a7a3f95

nihal467 added needs review tested and removed needs testing labels Oct 14, 2024

github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024

Merge branch 'develop' into fix/issue-8618

3c8ac9e

github-actions bot removed the merge conflict pull requests with merge conflict label Oct 16, 2024

github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024

syedfardeenjeelani closed this by deleting the head repository Oct 20, 2024

bodhish mentioned this pull request Oct 21, 2024

fix: added tooltip for Discussion Notes Icons #8618 #8837

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: added tooltips for Discussion Notes icons (#8618) #8637

fix: added tooltips for Discussion Notes icons (#8618) #8637

syedfardeenjeelani commented Sep 26, 2024 •

edited by nihal467

Loading

netlify bot commented Sep 26, 2024 •

edited

Loading

rithviknishad left a comment •

edited

Loading

rithviknishad Sep 26, 2024 •

edited

Loading

nihal467 commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

bodhish left a comment

bodhish Oct 2, 2024

bodhish Oct 2, 2024

syedfardeenjeelani Oct 3, 2024

rithviknishad commented Oct 13, 2024

rithviknishad left a comment

nihal467 commented Oct 14, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

fix: added tooltips for Discussion Notes icons (#8618) #8637

fix: added tooltips for Discussion Notes icons (#8618) #8637

Conversation

syedfardeenjeelani commented Sep 26, 2024 • edited by nihal467 Loading

Proposed Changes

Demo Video

Merge Checklist

netlify bot commented Sep 26, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

rithviknishad left a comment • edited Loading

Choose a reason for hiding this comment

rithviknishad Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

nihal467 commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

bodhish left a comment

Choose a reason for hiding this comment

bodhish Oct 2, 2024

Choose a reason for hiding this comment

bodhish Oct 2, 2024

Choose a reason for hiding this comment

syedfardeenjeelani Oct 3, 2024

Choose a reason for hiding this comment

rithviknishad commented Oct 13, 2024

rithviknishad left a comment

Choose a reason for hiding this comment

nihal467 commented Oct 14, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

syedfardeenjeelani commented Sep 26, 2024 •

edited by nihal467

Loading

netlify bot commented Sep 26, 2024 •

edited

Loading

rithviknishad left a comment •

edited

Loading

rithviknishad Sep 26, 2024 •

edited

Loading