Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show validation error message on facility cover image upload #8625

Closed
2 tasks
nihal467 opened this issue Sep 25, 2024 · 5 comments · Fixed by #8639
Closed
2 tasks

Show validation error message on facility cover image upload #8625

nihal467 opened this issue Sep 25, 2024 · 5 comments · Fixed by #8639
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@nihal467
Copy link
Member

nihal467 commented Sep 25, 2024

Describe the bug

When we are trying to upload a cover image (attached with this issue) to a facility, the frontend is throwing the "something went wrong" error

Note: When you capture image using the camera component in the cover image module, its working

To Reproduce
Steps to reproduce the behavior:

  1. Go to the facility tab
  2. click on any facility card
  3. try to upload a facility cover image
  4. See error

Expected behavior

  • when we upload a facility cover image, it should work properly
  • Rather than "something went wrong" , proper error's should be thrown incase of failure

Screenshots
87

image

@nihal467 nihal467 added bug Something isn't working P1 breaking issue or vital feature labels Sep 25, 2024
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.

@sainak
Copy link
Member

sainak commented Sep 25, 2024

backend response:

{"cover_image":["Image width is greater than the maximum allowed width of 1024 pixels.","Image height is greater than the maximum allowed height of 1024 pixels."]}

https://github.com/ohcnetwork/care/blob/11b62ee48998edad6db55fee337ff8e063bd1a0e/care/utils/models/validators.py#L339-L346

@sainak sainak changed the title Facility Cover Image Upload is not working Show validation error message on facility cover image upload Sep 25, 2024
@syedfardeenjeelani
Copy link
Contributor

can i work on this issue ? @sainak @nihal467

@rithviknishad rithviknishad removed the P1 breaking issue or vital feature label Sep 26, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Sep 26, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Sep 26, 2024
@nihal467
Copy link
Member Author

@syedfardeenjeelani Could you please prioritize pushing the fix by the end of today? We need to address this issue as soon as possible before our upcoming weekly release.

@syedfardeenjeelani
Copy link
Contributor

Hey @nihal467 , I’ve completed the work on issue #8618 locally. Now, I’ll be moving on to this new issue and i will try my best to have it wrapped up by the end of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants