Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Asset Info Popover to Camera Feed in Consultation Page #8615

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Added Asset Info Popover to Camera Feed in Consultation Page #8615

merged 5 commits into from
Sep 30, 2024

Conversation

Jacobjeevan
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Jacobjeevan
Added Assetinfo to Camera Feed
84ab7fb 
- Moved VitalsMonitorAssetPopover to Common (renamed to MonitorAssetPopover, making it a reusable component)
	- Added className as a prop for styling PopoverPanel
	- Moved the styling specific to Vitals Popover (position on screen) to the class name
	- Using the same prop for positioning Popover for Camera feed page
- Added Asset information Popover to Camera Feed page
@Jacobjeevan
Merge branch 'develop' into issues/8399-Assetinfo-Camerafeed
7313178
@Jacobjeevan Jacobjeevan requested a review from a team as a code owner September 25, 2024 04:54
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit c5ad33d
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66fa4684b68fa0000965b6c3
😎 Deploy Preview https://deploy-preview-8615--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion

src/Components/Common/MonitorAssetPopover.tsx Outdated Show resolved Hide resolved
src/Components/Common/MonitorAssetPopover.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Sep 27, 2024 •
edited
Loading

LGTM

@nihal467 nihal467 added tested Cypress Test Pending The Cypress test are to be verified and removed needs testing labels Sep 27, 2024
@nihal467 nihal467 removed the Cypress Test Pending The Cypress test are to be verified label Sep 30, 2024
@bodhish bodhish merged commit d76d6d8 into ohcnetwork:develop Sep 30, 2024
22 checks passed
@github-actions GitHub Actions
Copy link

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@Jacobjeevan Jacobjeevan deleted the issues/8399-Assetinfo-Camerafeed branch October 9, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add asset info pop-up for camera feed in consultation page
4 participants
@Jacobjeevan @nihal467 @rithviknishad @bodhish