Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set profile pictures #8606

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 24, 2024

Proposed Changes

backend pr : ohcnetwork/care#2253

Screen.Recording.2024-06-08.at.11.28.01.AM.mov

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner September 24, 2024 07:17
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit f208942
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67160817c7794d000819b2db
😎 Deploy Preview https://deploy-preview-8606--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: f208942
Status: ✅  Deploy successful!
Preview URL: https://178be46b.care-fe.pages.dev
Branch Preview URL: https://issues-3924-support-for-prof.care-fe.pages.dev

View logs

Copy link

cypress bot commented Sep 24, 2024

CARE    Run #3718

Run Properties:  status check passed Passed #3718  •  git commit f2089428a8: Allow users to set profile pictures
Project CARE
Run status status check passed Passed #3718
Run duration 03m 04s
Commit git commit f2089428a8: Allow users to set profile pictures
Committer Aakash Singh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@bodhish bodhish changed the title Ass user profile pictures Allow users to set profile pictures Sep 24, 2024
src/Components/Common/Sidebar/SidebarUserCard.tsx Outdated Show resolved Hide resolved
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

@sainak can you update the status here?

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the stale label Oct 16, 2024
@bodhish
Copy link
Member

bodhish commented Oct 18, 2024

@sainak do update the status here

@sainak sainak self-assigned this Oct 18, 2024
@sainak
Copy link
Member Author

sainak commented Oct 18, 2024

@bodhish I'm refactoring the code to merge the facility cover image upload and user cover image upload components

@github-actions github-actions bot removed the stale label Oct 19, 2024
@sainak sainak force-pushed the issues/3924/support-for-profile-pic branch from 4270f0a to 2d9d8a9 Compare October 20, 2024 21:16
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 20, 2024
src/Components/Common/AvatarEditModal.tsx Dismissed Show dismissed Hide dismissed
@sainak sainak force-pushed the issues/3924/support-for-profile-pic branch 2 times, most recently from 99adfcd to 4e576ab Compare October 20, 2024 21:27
@sainak sainak force-pushed the issues/3924/support-for-profile-pic branch from 4e576ab to 9eb78a4 Compare October 21, 2024 04:13
src/Components/Common/Avatar.tsx Outdated Show resolved Hide resolved
src/Components/Common/Avatar.tsx Show resolved Hide resolved
Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should add avatar previews in the /users page as well

src/Components/Common/AvatarEditable.tsx Show resolved Hide resolved
src/Components/Common/AvatarEditModal.tsx Show resolved Hide resolved
@samholics
Copy link

tested, working fine @nihal467

@nihal467
Copy link
Member

LGTM

@rithviknishad rithviknishad merged commit 5b3a86a into develop Oct 22, 2024
32 checks passed
@rithviknishad rithviknishad deleted the issues/3924/support-for-profile-pic branch October 22, 2024 08:22
Copy link

@sainak @sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Allow users to add profile picture in care platform
7 participants