Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp media player #8437

Merged
merged 18 commits into from
Sep 18, 2024
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 28, 2024

Proposed Changes

  • Replace hls player with mss on safari
  • remove hls related code
  • remove old unused components

https://developer.apple.com/support/app-store/
https://caniuse.com/mdn-api_managedmediasource_streaming

closes #8540

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner August 28, 2024 12:45
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 3:48pm

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit fb7951d
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66eabceb05a7bd0008d1ffbf
😎 Deploy Preview https://deploy-preview-8437--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Sep 4, 2024

CARE    Run #3385

Run Properties:  status check passed Passed #3385  •  git commit fb7951d2d7: Revamp media player
Project CARE
Branch Review sainak/feat/use-managed-media-source
Run status status check passed Passed #3385
Run duration 03m 09s
Commit git commit fb7951d2d7: Revamp media player
Committer Aakash Singh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎

@github-actions github-actions bot added the stale label Sep 12, 2024
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed stale labels Sep 17, 2024
@sainak sainak changed the title Replace hls player with mss on safari Revamp media player Sep 17, 2024
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Sep 17, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 17, 2024
@nihal467
Copy link
Member

video is visible is all devices now LGTM

@nihal467 nihal467 added tested and removed needs testing test failed Deploy-Failed Deplyment is not showing preview labels Sep 18, 2024
src/Components/CameraFeed/videoPlayer.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/videoPlayer.tsx Outdated Show resolved Hide resolved
src/Components/CameraFeed/FeedAlert.tsx Show resolved Hide resolved
src/Components/CameraFeed/FeedNetworkSignal.tsx Outdated Show resolved Hide resolved
@khavinshankar khavinshankar merged commit 383dfbc into develop Sep 18, 2024
26 checks passed
@khavinshankar khavinshankar deleted the sainak/feat/use-managed-media-source branch September 18, 2024 12:31
Copy link

@sainak @sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all direct API calls from frontend to middleware
4 participants