Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Facility Cover Image Uploads on Mobile Screens #8402

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Enable Facility Cover Image Uploads on Mobile Screens #8402

merged 4 commits into from
Aug 22, 2024

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Aug 22, 2024 •
edited by nihal467
Loading

Proposed Changes

  • Fixes cover image edit for mobile devices
  • Remove imageKey Implementation for Cover Images
  • Fix Edit Cover Image for Mobile Devices

@rithviknishad Can you confirm that removing the imageKey wouldn't cause any issues

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@gigincg gigincg requested a review from a team as a code owner August 22, 2024 14:30
@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 4:57pm

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 078d514
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c76ddbdce20b0008290bde
😎 Deploy Preview https://deploy-preview-8402--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad previously approved these changes Aug 22, 2024
View reviewed changes
@cypress Cypress
Copy link

cypress bot commented Aug 22, 2024 •
edited
Loading


Test summary

126 • 0 • 0 • 0

Run details
Project CARE
Status Passed
Commit da22112
Started Aug 22, 2024 4:53 PM
Ended Aug 22, 2024 4:57 PM
Duration 03:18 💡
OS Linux Ubuntu -
Browser Chrome 128

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@rithviknishad rithviknishad dismissed their stale review August 22, 2024 14:39

imageKey was intended to force refresh the image, as the signed url wouldn't change

@rithviknishad
Copy link
Member

rithviknishad commented Aug 22, 2024 •
edited
Loading

@rithviknishad Can you confirm that removing the imageKey wouldn't cause any issues

@gigincg ?imageKey was originally intended to force refresh the image as the signed URL for a facility wouldn't change even when the cover image was changed.

@gigincg gigincg changed the title Optimize Facility Cover Image Uploads for auto-refresh Enable Facility Cover Image Uploads on Mobile Screens Aug 22, 2024
@nihal467
Copy link
Member

LGTM

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 6c18e2b into develop Aug 22, 2024
25 of 27 checks passed
@khavinshankar khavinshankar deleted the cover_image_8401 branch August 22, 2024 17:06
@github-actions GitHub Actions
Copy link

@gigincg Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
@gigincg @khavinshankar @UdaySagar-Git
Enable Facility Cover Image Uploads on Mobile Screens (ohcnetwork#8402)
c26c3de 
* Optimize Facility Cover Image for Reload

* Fix Edit Cover Image for Mobile Screens

* Revert temp assignment

* fixed lint

---------

Co-authored-by: Khavin Shankar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gigincg @rithviknishad @nihal467 @khavinshankar