Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Functional Next and Prev Button #8361

Conversation

renoseHarsh
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@renoseHarsh renoseHarsh requested a review from a team as a code owner August 19, 2024 20:28
Copy link

vercel bot commented Aug 19, 2024

@renoseHarsh is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 57aabdb
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c7682dffe28e0009843d4a
😎 Deploy Preview https://deploy-preview-8361--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Components/Common/FilePreviewDialog.tsx Outdated Show resolved Hide resolved
src/Components/Common/FilePreviewDialog.tsx Outdated Show resolved Hide resolved
src/Components/Common/FilePreviewDialog.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

image
image

  • the buttons in the mobile view, making the preview image smaller compared to the existing staging version so that I would say, keep the buttons at the top or bottom in the mobile view only, so the preview image is forced to be smaller

cc: @rithviknishad

@renoseHarsh
Copy link
Contributor Author

This was the fix I was able to come up with but this doesn't set the buttons in a row when the screen is small so they look something like this
Screenshot 2024-08-21 at 10 16 28 PM
This happens because the left button, center content, and right button are inside a row flex grid, which is changed to a column when the screen is small. Is there a way to set the left button, and right button to row without putting a div outside them?

The other way I thought of was to always have the buttons be down there even when the screen is big or small.
Screenshot 2024-08-21 at 10 20 54 PM

The last solution I thought of was to have two sets of buttons one on the left and right side of the center content which gets hidden when on a mobile screen, and the other set of buttons below the center content which gets hidden when screen a big screen will this work as there would duplicate code?

Please tell me if there is a better way of doing this that I am missing.

Copy link

👋 Hi, @renoseHarsh,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 23, 2024
@renoseHarsh renoseHarsh deleted the issues/8321/Add_Next_and_Previous branch October 17, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required merge conflict pull requests with merge conflict needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Next and Previous Scroll button for files preview
3 participants