Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable submit buttons in patient registration and encounter form when request is being processed #8353

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Disable submit buttons in patient registration and encounter form when request is being processed to avoid probable race conditions.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner August 19, 2024 14:41
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 2:43pm

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bf12856
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c35a01f8ed13000807aebf
😎 Deploy Preview https://deploy-preview-8353--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member Author

rithviknishad commented Aug 19, 2024

Closing as new PR will be raised to avoid potential race conditions by using abort controller, as the disable logic does not have any effect as it'd anyways be in loading state even when the button is clicked.

@rithviknishad rithviknishad added invalid This doesn't seem right and removed needs testing labels Aug 19, 2024
@rithviknishad rithviknishad deleted the rithviknishad/fix/disable-buttons-on-loading-for-registration-and-encounter branch December 1, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right P1 breaking issue or vital feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant