Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused components and packages #8339

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 19, 2024

Proposed Changes

  • Remove unused component Transition (was previously used by Rescript component)
  • Remove unused component Tooltip
  • Remove unused package react-transition-group
  • Remove unused types packages (current versions have type definitions)

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner August 19, 2024 06:05
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 2:33pm

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a41954b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c35780bf6c8a0008baf81f
😎 Deploy Preview https://deploy-preview-8339--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad changed the title Remove unused Transition block and other unused packages Remove unused Transition component and other unused packages Aug 19, 2024
Copy link

cypress bot commented Aug 19, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit a41954b
Started Aug 19, 2024 2:37 PM
Ended Aug 19, 2024 2:40 PM
Duration 02:55 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@rithviknishad rithviknishad changed the title Remove unused Transition component and other unused packages Remove unused components and other unused packages Aug 20, 2024
@rithviknishad rithviknishad changed the title Remove unused components and other unused packages Remove unused components and packages Aug 20, 2024
@nihal467
Copy link
Member

Build ,cypress & random test looks good

@khavinshankar khavinshankar merged commit 5eed756 into develop Aug 21, 2024
71 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/remove-unused-deps branch August 21, 2024 04:44
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants