Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Enhancement for Middleware Override Workflow. #8335

Open
5 tasks
nihal467 opened this issue Aug 16, 2024 · 17 comments
Open
5 tasks

UX Enhancement for Middleware Override Workflow. #8335

nihal467 opened this issue Aug 16, 2024 · 17 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@nihal467
Copy link
Member

nihal467 commented Aug 16, 2024

Is your feature request related to a problem? Please describe.

Currently, when the middleware of an asset is taken from the facility configuration page or location management page, the middleware field is auto-filled as a placeholder. By hovering over the exclamation button, the user can understand from which page this middleware is pre-filled.

However, new users are raising concerns that they are finding it difficult to understand the priority-based asset middleware overrides. For example, the middleware specified in the asset configuration is given the highest priority, followed by location management, and lastly, the facility configuration

image
image

Describe the solution you'd like

Screenshot 2024-08-16 161325

  • When the asset configuration is pre-filled from the location management or facility page, instead of making the user hover over the exclamation mark, add fine text below the input box, along with the pre-filled middleware placeholder, to provide details about the middleware's source.

image

  • Implement a similar pre-filling behavior in the placeholder and fine text for the location management edit page.
  • In the location creation form, under the middleware field, add fine text indicating that if left blank, the facility middleware will be applied to assets.

image

  • In the location management card, display the facility configuration middleware with a "Pre-filled Facility Middleware" badge if no middleware is set for the location.

image

  • Under the facility configuration middleware field, add fine text stating that the facility middleware will be applied to all assets when asset and location middleware are Unspecified.

Note:

  • In the relevant places, Try to add the facility name or location in the fine text so users can easily understand the exact source, rather than a general fine text message.
  • The attached UI is a sample mock-up for reference. Feel free to share the proper UI mock-up on the issue before starting work on it.
@nihal467
Copy link
Member Author

nihal467 commented Aug 16, 2024

discussion label was removed as @gigincg approved the issue

@rithviknishad rithviknishad moved this from Triage to Up Next in Care Aug 19, 2024
@gigincg gigincg added the good first issue Good for newcomers label Aug 22, 2024
@saikiranpatil
Copy link

I am interested to solve this issue, but i am having trouble in understanding, can anyone explain how to reproduce the above, and what changes are to be added. @gigincg @nihal467

@nihal467
Copy link
Member Author

@saikiranpatil are you still interested in working on this issue

@saikiranpatil
Copy link

@saikiranpatil are you still interested in working on this issue

Yes

@saikiranpatil
Copy link

i am having trouble in understanding, can anyone explain how to reproduce the above, and what changes are to be added.

@nihal467
Copy link
Member Author

Steps to Access Facility Middleware Page

  1. Go to the facility tab
  2. click on the view facility button on any facility card
  3. once you are in the page click on the manage facility button
  4. from the dropdown, click the config facility button
  5. you will be seeing the below page

image

steps to access location middleware page

  1. Follow the above step 1-3
  2. then from dropdown click the location management button
  3. click on the add location button on the top right corner
  4. you will be seeing the below page

image

steps to access asset middleware page

  1. follow the top step 1-3
  2. then from the dropdown click the view asset button
  3. click on any camera asset card ( It will have a camera icon ) , case not available create a new asset
  4. now click on the configuration button
  5. you will be seeing the below page

image

  • middleware preference for a device is given for the one available on the asset configuration page, if not available there, its be taken from the location management page if not available it is also it been taken from the facility middleware page.

  • the action items are mentioned under the description of solution

@github-actions github-actions bot added the stale label Sep 25, 2024
@ayushpatil2122
Copy link
Contributor

Image
is this looks good ?

@github-actions github-actions bot added needs-triage question Further information is requested labels Nov 30, 2024
@ayushpatil2122
Copy link
Contributor

i want to work on this issue to me

@github-actions github-actions bot removed the stale label Dec 7, 2024
@saikiranpatil
Copy link

sorry @nihal467, i was unable to complete this these days. But now i have made changes so that the page looks like this

Image
as you mentioned we have various cases to show messages, so I have added a new attribute message to FormFeild component to display messages.

I found this color and font weight of the message suitable, please let me know if we need any changes.

@saikiranpatil
Copy link

shall i create a PR?

@nihal467
Copy link
Member Author

nihal467 commented Dec 9, 2024

@saikiranpatil create a PR for review purpose

@saikiranpatil
Copy link

  • Implement a similar pre-filling behavior in the placeholder and fine text for the location management edit page.

when the location middleware is empty, what is the use of prefetching in edit location page. doesn't that lead to confusion. I kept it empty for now, should i make any changes in that?

@github-actions github-actions bot added the question Further information is requested label Dec 10, 2024
@saikiranpatil
Copy link

@nihal467 i have created a PR

@nihal467
Copy link
Member Author

nihal467 commented Dec 19, 2024

@saikiranpatil what is the status of this issue, are you still working on this?

@nihal467 nihal467 removed question Further information is requested needs-triage labels Dec 19, 2024
@AdityaJ2305
Copy link
Contributor

Hey @nihal467 @rithviknishad , I would like to take up this issue

@Jacobjeevan
Copy link
Contributor

@saikiranpatil Are you still working on this?

@rishabhr4
Copy link

hey @Jacobjeevan @nihal467 can i work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Up Next
Development

Successfully merging a pull request may close this issue.

7 participants