Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIV and IV ventilator mode & Oxygen support Modality mode have no data reflection in patient consultation page #8264

Closed
2 tasks
nihal467 opened this issue Aug 6, 2024 · 12 comments · Fixed by #8781

Comments

@nihal467
Copy link
Member

nihal467 commented Aug 6, 2024

Describe the bug

In the patient consultation page, currently, there is a badge present their respiratory support is either NIV, IV, or OS but the related ventilator mode or modality mode is shown nowhere in the platform

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to patient consultation page
  2. Click on log update and file the detailed log updated
  3. post creation, go to the consultation page.
  4. See error

Screenshots
image
image

Expected behavior

@github-project-automation github-project-automation bot moved this to Triage in Care Aug 6, 2024
@aparnacoronasafe aparnacoronasafe removed their assignment Aug 19, 2024
@github-actions github-actions bot added the stale label Sep 3, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Sep 4, 2024
@rithviknishad rithviknishad moved this from Up Next to Triage in Care Sep 4, 2024
@Jacobjeevan
Copy link
Contributor

@rithviknishad Mind assigning this to me? Thanks!

@rithviknishad rithviknishad moved this from Triage to Up Next in Care Oct 1, 2024
@Jacobjeevan Jacobjeevan moved this from Up Next to In Progress in Care Oct 3, 2024
@Jacobjeevan
Copy link
Contributor

I've added the vertical line as a marker, though it looks a bit weird when we switch to bar graph.

Image

Image

On a side note, if we adding the modality in the graphs themselves, wouldn't it make more sense to add the line markers to the points themselves, than the mid-points 🤔 @nihal467

For ex: with the marker line, the image (in the original post) makes it seem like C-PAP started before 2:32 on 19/08/2024.

@nihal467
Copy link
Member Author

nihal467 commented Oct 3, 2024

I've added the vertical line as a marker, though it looks a bit weird when we switch to bar graph.

Image

Image

On a side note, if we adding the modality in the graphs themselves, wouldn't it make more sense to add the line markers to the points themselves, than the mid-points 🤔 @nihal467

For ex: with the marker line, the image (in the original post) makes it seem like C-PAP started before 2:32 on 19/08/2024.

@aparnacoronasafe can you comment on this

@Jacobjeevan Jacobjeevan moved this from In Progress to Review required in Care Oct 7, 2024
@Jacobjeevan Jacobjeevan moved this from Review required to In Progress in Care Oct 7, 2024
@Jacobjeevan Jacobjeevan added question Further information is requested work-in-progress and removed question Further information is requested labels Oct 7, 2024
@aparnacoronasafe
Copy link
Member

aparnacoronasafe commented Oct 8, 2024

@Jacobjeevan This was discussed over slack.

Are there any specific issues to be addressed here?

I agree that the bar graph view does not look great. What are the alternatives we have?

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Oct 8, 2024

@Jacobjeevan This was discussed over slack.

Are there any specific issues to be addressed here?

Nothing as of now 👍

I agree that the bar graph view does not look great. What are the alternatives we have?

I'm checking the charts library we are using to see if there are any other alternatives; will update you 👍 @aparnacoronasafe

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Oct 9, 2024

I tried switching to Mark Area, which works for line charts but doesn't render correctly for bar charts; it seems to combine consecutive modes/modalities. I've attached the Mark Line ones below for reference.

Edit: For Mark Area, switching to bar chart converts all existing charts to bar, hence why we are seeing the issue below.

Mark Area

Mark Line

This is the one used earlier, but rendered with labels.

With different label position

@aparnacoronasafe Well, we could use the markArea feature and disable the switching to bar charts feature for these graphs, depends on how important/useful they are, or we can use markLine if the renders above work (can adjust the label position as needed).

@aparnacoronasafe
Copy link
Member

aparnacoronasafe commented Oct 11, 2024

@Jacobjeevan i think mark area looks better.

Let's retain the bar graph option as well?

Also could you add (IV/NIV/O2) also against the ventilator mode/oxygen modality mentioned?

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Oct 11, 2024

@Jacobjeevan i think mark area looks better.

Let's retain the bar graph option as well?

Also could you add (IV/NIV/O2) also against the ventilator mode/oxygen modality mentioned?

@aparnacoronasafe Sure, we can add those.

We can keep the bar graphs, however there's some inconsistency in how it depicts the data for markArea🤔

For example: In the line chart, NP starts at 2:45PM (which is correct), but switching to bar chart, NP shows up later (I've highlighted 2:45PM on the bar chart below). Not only that, but the time divisions between NP/SFM/HFNC isn't as clear.

@Jacobjeevan Jacobjeevan moved this from In Progress to Review required in Care Oct 14, 2024
@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Oct 15, 2024

After discussing with team, going with the markLine since markArea presents inaccurate data when switching to bar charts. Here's how the latest looks.

image image image

@aparnacoronasafe
Copy link
Member

aparnacoronasafe commented Oct 18, 2024

Looks good @Jacobjeevan

However, I donot see the current ventilator mode marked in the graph. in the above eg, IV-PCV should also be marked in the right end of the graph right? Could you check?

@Jacobjeevan
Copy link
Contributor

Looks good @Jacobjeevan

However, I donot see the current ventilator mode marked in the graph. in the above eg, IV-PCV should also be marked in the right end of the graph right? Could you check?

@aparnacoronasafe ah, good catch, I had excluded the latest datapoint to render markArea graphs; I'll get it fixed 👍

@Jacobjeevan
Copy link
Contributor

Fixed the above (render the most recent modality/mode on graph).

Image

@Jacobjeevan Jacobjeevan moved this from Review required to In Progress in Care Oct 25, 2024
@Jacobjeevan Jacobjeevan moved this from In Progress to Review required in Care Oct 28, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants