-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIV and IV ventilator mode & Oxygen support Modality mode have no data reflection in patient consultation page #8264
Comments
@rithviknishad Mind assigning this to me? Thanks! |
I've added the vertical line as a marker, though it looks a bit weird when we switch to bar graph. On a side note, if we adding the modality in the graphs themselves, wouldn't it make more sense to add the line markers to the points themselves, than the mid-points 🤔 @nihal467 For ex: with the marker line, the image (in the original post) makes it seem like C-PAP started before 2:32 on 19/08/2024. |
@aparnacoronasafe can you comment on this |
@Jacobjeevan This was discussed over slack. Are there any specific issues to be addressed here? I agree that the bar graph view does not look great. What are the alternatives we have? |
Nothing as of now 👍
I'm checking the charts library we are using to see if there are any other alternatives; will update you 👍 @aparnacoronasafe |
I tried switching to Mark Area, which works for line charts but doesn't render correctly for bar charts; it seems to combine consecutive modes/modalities. I've attached the Mark Line ones below for reference. Edit: For Mark Area, switching to bar chart converts all existing charts to bar, hence why we are seeing the issue below. Mark AreaMark LineThis is the one used earlier, but rendered with labels. With different label position @aparnacoronasafe Well, we could use the markArea feature and disable the switching to bar charts feature for these graphs, depends on how important/useful they are, or we can use markLine if the renders above work (can adjust the label position as needed). |
@Jacobjeevan i think mark area looks better. Let's retain the bar graph option as well? Also could you add (IV/NIV/O2) also against the ventilator mode/oxygen modality mentioned? |
@aparnacoronasafe Sure, we can add those. We can keep the bar graphs, however there's some inconsistency in how it depicts the data for markArea🤔 For example: In the line chart, NP starts at 2:45PM (which is correct), but switching to bar chart, NP shows up later (I've highlighted 2:45PM on the bar chart below). Not only that, but the time divisions between NP/SFM/HFNC isn't as clear. |
Looks good @Jacobjeevan However, I donot see the current ventilator mode marked in the graph. in the above eg, IV-PCV should also be marked in the right end of the graph right? Could you check? |
@aparnacoronasafe ah, good catch, I had excluded the latest datapoint to render markArea graphs; I'll get it fixed 👍 |
Describe the bug
In the patient consultation page, currently, there is a badge present their respiratory support is either NIV, IV, or OS but the related ventilator mode or modality mode is shown nowhere in the platform
To Reproduce
Steps to reproduce the behavior:
Screenshots
Expected behavior
Add a table on the "ventilation tab" in patient dashboard (https://care-staging.ohc.network/facility/da95c77c-cf2f-4400-be53-6da766951552/patient/70ff1884-89ca-43fd-bc6c-2354cff9457d/consultation/9b1b3f6d-581d-46f3-8279-456596defd35/ventilator). The table to appear on top of the ventilator tab before the graphs of PIP and MAP
Indicate change in modality and vantilator mode/oxygen modality by adding a vertical line as marker on the time series graphs for the various parameters
The text was updated successfully, but these errors were encountered: