Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions raised by the addSourceBuffer method #8199

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Jul 23, 2024

This pull request addresses an issue where exceptions raised by the addSourceBuffer method were not being handled properly.
https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/addSourceBuffer#exceptions

fixes #8200

@sainak sainak requested a review from a team as a code owner July 23, 2024 11:26
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e6ccb7a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/669f954438d5c50008f76611
😎 Deploy Preview https://deploy-preview-8199--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 11:35am

Copy link

cypress bot commented Jul 23, 2024

Passing run #2926 ↗︎

0 126 0 0 Flakiness 0

Details:

Handle exceptions raised by the addSourceBuffer method
Project: CARE Commit: e6ccb7ab65
Status: Passed Duration: 03:22 💡
Started: Jul 23, 2024 11:39 AM Ended: Jul 23, 2024 11:42 AM

Review all test suite changes for PR #8199 ↗︎

@nihal467
Copy link
Member

@sainak is this ready for testing

@nihal467
Copy link
Member

camera feed looks good in laptop and iphones

@khavinshankar khavinshankar merged commit f4e2e39 into develop Aug 1, 2024
63 checks passed
@khavinshankar khavinshankar deleted the sainak/fix/mse-add-source-buffer branch August 1, 2024 05:47
Copy link

github-actions bot commented Aug 1, 2024

@sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants