Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Validation check for phone number in patient list page #8189

Closed
nihal467 opened this issue Jul 22, 2024 · 6 comments · Fixed by #8394
Closed

Improve the Validation check for phone number in patient list page #8189

nihal467 opened this issue Jul 22, 2024 · 6 comments · Fixed by #8394
Assignees
Labels

Comments

@nihal467
Copy link
Member

Describe the bug

Currently, we are checking if the phone numbers entered are valid or not, on each input, let's say we want to type "9846856118", on inputting 9 itself, the error message start showing " enter valid number number " until we finish the number

To Reproduce
Steps to reproduce the behavior:

  1. Go to patient list page
  2. enter the phone number
  3. See error

Expected behavior

Once the user go out of focus only the validation check should take place,

Note: we already experimented with one approach, but in that, if user inputs 9 digits, the error is not thrown 5a33cb7

Screenshots

image

@saloni0419
Copy link
Contributor

@rithviknishad @nihal467 can you please assign this issue to me

Copy link

github-actions bot commented Aug 6, 2024

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Aug 6, 2024
@nihal467
Copy link
Member Author

@saloni0419 Are you still working on this issue? Please respond with the current status. If no response is received within the next 48 hours, you will be unassigned due to inactivity.

@github-actions github-actions bot removed the stale label Aug 12, 2024
@saloni0419
Copy link
Contributor

@nihal467 sorry for the late reply. i was busy somewhere . i am unassigning myself

@saloni0419 saloni0419 removed their assignment Aug 15, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Aug 15, 2024
@Nithin9585
Copy link
Contributor

@nihal467 can you please assign this issue to me

@Nithin9585
Copy link
Contributor

Hi @rithviknishad sir, could you please review my PR #8394 (comment) when you get a chance? It addresses issue #8189 by improving the validation check for phone numbers on the patient list page.

Thank you!

@rithviknishad rithviknishad moved this from Up Next to In Progress in Care Aug 22, 2024
@rithviknishad rithviknishad self-assigned this Sep 30, 2024
@rithviknishad rithviknishad moved this from In Progress to Review required in Care Oct 4, 2024
@rithviknishad rithviknishad removed their assignment Oct 15, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants