Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop date-fns infavor of dayjs #7842

Closed
khavinshankar opened this issue May 17, 2024 · 4 comments
Closed

Drop date-fns infavor of dayjs #7842

khavinshankar opened this issue May 17, 2024 · 4 comments
Assignees
Labels

Comments

@khavinshankar
Copy link
Member

khavinshankar commented May 17, 2024

Both Day.js and date-fns provide similar functionality for date and time manipulation. We have decided to remove date-fns in favor of dayjs due to its minimal package size.

@khavinshankar khavinshankar self-assigned this May 17, 2024
Copy link

github-actions bot commented Jun 1, 2024

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Jun 1, 2024
@shivankacker
Copy link
Member

@khavinshankar
Day.js is 666kb,
date-fns is 22Mb
why are we removing Day.js? Is it because of more functionality? 😅

@github-actions github-actions bot removed the stale label Jun 3, 2024
@khavinshankar
Copy link
Member Author

Oh my bad, I wrote it in reverse 😅

@khavinshankar khavinshankar changed the title Drop dayjs infavor of date-fns Drop date-fns infavor of dayjs Jul 2, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Jul 2, 2024
@github-actions github-actions bot added the stale label Aug 15, 2024
@gigincg gigincg added wishlist and removed stale labels Aug 19, 2024
@rithviknishad
Copy link
Member

Closing as completed in #8318

@github-project-automation github-project-automation bot moved this from Triage to Done in Care Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants