Adding proper error message for Camera config page #7696
Conversation
|
@hrit2773 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@nihal467 updated the error message to wrong configuration credentials. can you plz review this |
|
@nihal467 can i get a review on this PR is the cypress test failing due to timeout issues |
|
LGTM |
| if (key === "operateAsset") { | ||
| Notification.Error({ | ||
| msg: "Wrong Middleware Hostname...!", | ||
| }); | ||
| } else { |
There was a problem hiding this comment.
This seems like a hack. Also, I thought we moved to useQuery. Please check src/Utils/request/useQuery.ts. If the middleware API calls still use fireRequest, please consider refactoring it to useQuery.
cc: @rithviknishad
There was a problem hiding this comment.
@khavinshankar the middleware api call uses fire request.. of course I can change it to useQuery if @rithviknishad agrees to it
There was a problem hiding this comment.
The existing usages of operateAsset was hard to switch to using useQuery/request as there were places where we were passing the redux's dispatch as params to the functions inside it.
However, switching to newer camera feed components would solve the issue as it is not using the deprecated operateAsset. (Eg: #7654)
The newer camera feed components handles the error messages as expected and wouldn't have this underlying issue in the first place.
@hrit2773 Do you want to switch to using the newer camera feed components in the asset config page? If yes, you can make a separate PR.
|
@hrit2773 any update on the PR |
|
Closing as we haven't moved ahead. |
Proposed Changes