Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close import asset pop-up #7607

Closed
nihal467 opened this issue Apr 14, 2024 · 7 comments · Fixed by #7367
Closed

Auto-close import asset pop-up #7607

nihal467 opened this issue Apr 14, 2024 · 7 comments · Fixed by #7367
Assignees

Comments

@nihal467
Copy link
Member

Describe the bug

When we complete the asset import, the pop-up is not auto closing

To Reproduce
Steps to reproduce the behavior:

  1. Go to asset tab, click on the import asset icon
  2. Upload a excel file
  3. once the upload is complete
  4. See error

Expected behavior

Upon completing the upload, the import assets pop-up should auto-close

Screenshots

image

@Sulochan-khadka
Copy link
Contributor

@nihal467 may I solve this issue? If and only if it is not already reported.

@Sulochan-khadka
Copy link
Contributor

@nihal467 may you provide me the file that is accepted in this or instruct me to solve "Please check the row 2 of the column Last Service Date" error.

@nihal467
Copy link
Member Author

nihal467 commented Apr 16, 2024

@Sulochan-khadka just fill in the asset creation mandatory field in the excel sheet and try to upload it

@UdaySagar-Git
Copy link
Contributor

@Sulochan-khadka @nihal467 this issue is already covered in my pr #7367

i will fix the merge conficts and push it as soon as possible

@Sulochan-khadka
Copy link
Contributor

@UdaySagar-Git it is great that you solved the issue. But hear me out once mate, solving multiple issues with a single PR is a great achievement but solving issues in a PR that does not associate with it primarily is not a good idea. The reason is , tracking the issues and its corresponding PR becomes not very easy. I saw your PR and it was not originally meant to solve this issue. Please do not take my statements otherwise, just wanted to share some workflow tips that I gained from this repo.

@Sulochan-khadka
Copy link
Contributor

BTW, thank you for solving the issue @UdaySagar-Git , @nihal467 just assign this issue to @UdaySagar-Git and mention this issue in his PR #7367

@UdaySagar-Git
Copy link
Contributor

@Sulochan-khadka , I completely agree with you, buddy! 😀 That PR involved a couple of changes in packages, which in turn resulted in a very large PR.
I'll keep that in mind from next time.

@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants