-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-close import asset pop-up #7607
Comments
@nihal467 may I solve this issue? If and only if it is not already reported. |
@nihal467 may you provide me the file that is accepted in this or instruct me to solve "Please check the row 2 of the column Last Service Date" error. |
@Sulochan-khadka just fill in the asset creation mandatory field in the excel sheet and try to upload it |
@Sulochan-khadka @nihal467 this issue is already covered in my pr #7367 i will fix the merge conficts and push it as soon as possible |
@UdaySagar-Git it is great that you solved the issue. But hear me out once mate, solving multiple issues with a single PR is a great achievement but solving issues in a PR that does not associate with it primarily is not a good idea. The reason is , tracking the issues and its corresponding PR becomes not very easy. I saw your PR and it was not originally meant to solve this issue. Please do not take my statements otherwise, just wanted to share some workflow tips that I gained from this repo. |
BTW, thank you for solving the issue @UdaySagar-Git , @nihal467 just assign this issue to @UdaySagar-Git and mention this issue in his PR #7367 |
@Sulochan-khadka , I completely agree with you, buddy! 😀 That PR involved a couple of changes in packages, which in turn resulted in a very large PR. |
Describe the bug
When we complete the asset import, the pop-up is not auto closing
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Upon completing the upload, the import assets pop-up should auto-close
Screenshots
The text was updated successfully, but these errors were encountered: