Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the "Setting and filter" button behavior in CNS and Live feed page #7600

Closed
2 tasks
nihal467 opened this issue Apr 14, 2024 · 3 comments · Fixed by #8156
Closed
2 tasks

change the "Setting and filter" button behavior in CNS and Live feed page #7600

nihal467 opened this issue Apr 14, 2024 · 3 comments · Fixed by #8156
Assignees
Labels
good first issue Good for newcomers stale

Comments

@nihal467
Copy link
Member

nihal467 commented Apr 14, 2024

Describe the bug

when the filters are active in the CNS and live feed page, the button does not show any difference.

To Reproduce
Steps to reproduce the behavior:

  1. Go to facility cns page
  2. Click on cns page
  3. apply any filters
  4. See error

Expected behavior

  • change the checkbox on "Hide Monitor without patient" to "Show Monitor without Patient" and bydefault it should be unchecked
  • Neither the Filter by location is in use or show monitor without patient is ticked a , the "Setting and filter" button should be having a primary color button. {Similar behavior of the filter button in the log update filter in the patient consultation page}

Screenshots

image

Copy link

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 30, 2024
@rithviknishad rithviknishad added good first issue Good for newcomers and removed stale labels Apr 30, 2024
@tankh99
Copy link

tankh99 commented Apr 30, 2024

Hi there, I would like to take up this issue. @nihal467 @rithviknishad

I'd like to clarify a few things

  1. Can I assume that instead of

"Show Monitor without Patient"

You meant "Show Monitors without patient? Since the existing code already had the plural term

  1. What exactly did you mean by

Neither the Filter by location is in use or show monitor without patient is ticked a

Your sentence got cut off.

Also, when you mentioned "log update filter", is the bright red "Log Update" button the one you're referring to, or is it something else? This screenshot was taken in the Patient Details page
Screenshot 2024-05-01 at 7 46 46 AM

Copy link

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stale
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants