Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Ventilator Parameters Input - Validate Consultation Bed for Linked Ventilator Asset is resolved #7522

Conversation

manasvi-gaur
Copy link
Contributor

@manasvi-gaur manasvi-gaur commented Apr 2, 2024

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Copy link

vercel bot commented Apr 2, 2024

@manasvi-gaur is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 48683cf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66557f313dbafd0008e84a35
😎 Deploy Preview https://deploy-preview-7522--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@manasvi-gaur manasvi-gaur marked this pull request as ready for review April 5, 2024 16:09
@manasvi-gaur manasvi-gaur requested a review from a team as a code owner April 5, 2024 16:09
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 15, 2024
@manasvi-gaur manasvi-gaur changed the title [Enhancement] Ventilator Parameters Input - Validate Consultation Bed for Linked Ventilator Asset is getting resolved [Enhancement] Ventilator Parameters Input - Validate Consultation Bed for Linked Ventilator Asset is resolved Apr 16, 2024
@manasvi-gaur
Copy link
Contributor Author

@rithviknishad I have made relevant changes, kindly review the PR

@nihal467
Copy link
Member

image
image

@manasvi-gaur The issue remains unresolved; the validation check isn't functioning properly. I created a ventilator-related parameter input for a patient without a ventilator asset linked to their bed, yet no notification was triggered.

Copy link

github-actions bot commented May 6, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 6, 2024
@manasvi-gaur
Copy link
Contributor Author

@nihal467 @rithviknishad, but in my setup its working perfectly without an asset, we can't create a log of critical type with ventilator parameter its showing alert window with functionality to add assets

image

here its notifying to add assets before proceeding while adding ventilator parameter
image

@rithviknishad
Copy link
Member

@manasvi-gaur I was able to replicate the issue.

If we submit by editing only the following fields shown in the screenshot, we are able to submit the form without linking a ventilator.

It does works only for changes in fields under the Respiratory Support subtitle.

image

cc: @nihal467

@manasvi-gaur
Copy link
Contributor Author

@nihal467 @rithviknishad done, I have made all relevant changes but for that single condition that was failing, due to my examination I was unable to fix that earlier, sorry for inconvenience

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f238475 into ohcnetwork:develop May 28, 2024
30 of 31 checks passed
Copy link

@manasvi-gaur Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Ventilator Parameters Input - Validate Consultation Bed for Linked Ventilator Asset
5 participants