Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of Users under each facility #7509

Closed
NNSiri opened this issue Apr 1, 2024 · 11 comments
Closed

Number of Users under each facility #7509

NNSiri opened this issue Apr 1, 2024 · 11 comments

Comments

@NNSiri
Copy link

NNSiri commented Apr 1, 2024

The users are mixed up when viewed
On viewing View users feature, we are randomly seeing all the users mixed up for each facility.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Facilities - Eg Gokak '

  2. Click on 'manage Facility'

  3. Scroll down to 'View Users'

  4. See error - 39 users are shown

  5. Go to 'Users'

  6. Click on 'Advance filters'

  7. Scroll down to 'State: Karntaka, District : Belagavi '

  8. See error: We see 11 Users for Gokak.

Expected behavior
Under (View Facility - Manage Facility - view users) we have to see only the users linked to that particular facility as home facility.

Screenshots
When Belagavi district is viewed

WhatsApp Image 2024-04-01 at 14 25 23_28fc8fa2

When Gokak facility is viewed separately
**Deskt
WhatsApp Image 2024-04-01 at 14 24 10_4508456b

op (please complete the following information):**

  • Browser [e.g. chrome, ]
@hrit2773
Copy link
Contributor

hrit2773 commented Apr 1, 2024

@rithviknishad @NNSiri can you assign this to me

@hrit2773
Copy link
Contributor

hrit2773 commented Apr 1, 2024

@NNSiri @rithviknishad this issue should be solved from the backend side by adding extra filter field to filter it according to the home facility. This would be a better approach can you assign this to me I will make a PR and if possible you can move this issue to the care backend and assign me

@hrit2773
Copy link
Contributor

hrit2773 commented Apr 2, 2024

I can make part by part PR one in frontend and other in backend. Can you plz assign me so that I can start working

@hrit2773
Copy link
Contributor

@rithviknishad can I take this up?

@NNSiri
Copy link
Author

NNSiri commented Apr 16, 2024

Any update on this issue ?

@hrit2773
Copy link
Contributor

@NNSiri I'm ready to take this up I have had a look on this issue last week. there is no filter for the users based on home facility field that needs to be added it's a frontend and backend issue waiting for a confirmation from @rithviknishad

@rithviknishad
Copy link
Member

@hrit2773 We could develop a better UX to explicitly convey to the users what is being shown, whether the listed users belong to home or linked facilities. One could interpret it differently if not mentioned.

@hrit2773
Copy link
Contributor

@rithviknishad let's give an option to choose whether to show all the users associated with that facility or just with home facility.. how would that be?

@rithviknishad
Copy link
Member

Works, maybe a checkbox saying "include linked facilities"

@hrit2773
Copy link
Contributor

@rithviknishad yes so the tasks to do would be

  1. adding a checkbox to select whether to filter based on home facility or linked facility
  2. adding a filter for home facility
  3. writing test cases

@nihal467
Copy link
Member

#7685 the issue is resolved

@github-project-automation github-project-automation bot moved this from Triage to Done in Care Apr 27, 2024
@hrit2773 hrit2773 removed their assignment May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants