Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facilities added but not displayed in Users. #7474

Closed
Sulochan-khadka opened this issue Mar 25, 2024 · 8 comments · Fixed by #7494
Closed

Facilities added but not displayed in Users. #7474

Sulochan-khadka opened this issue Mar 25, 2024 · 8 comments · Fixed by #7494
Assignees
@Sulochan-khadka
Labels
bug Something isn't working P1 breaking issue or vital feature

Comments

@Sulochan-khadka
Copy link
Contributor

Describe the bug
On linking a new facility to user, it is not displayed though it has been added(probably since on adding again, it shows already added).

To Reproduce
Steps to reproduce the behavior:

  1. Go to Facilites tab
  2. Click on View facility on any facility
  3. select View users from the manage facility dropdown
  4. Click on "Click here to show "
  5. add new facility
  6. It is not displayed but on again adding , it shows error "User already has permission to this facility ".

Expected behavior
The attached facility should be displayed.

Screenshots/Video

2024-03-26.01-05-45.mp4
@github-project-automation github-project-automation bot moved this to Triage in Care Mar 25, 2024
@Sulochan-khadka Sulochan-khadka closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Care Mar 25, 2024
@Sulochan-khadka Sulochan-khadka closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@Sulochan-khadka
Copy link
Contributor Author

Kindly ignore the above video since the OBS freezed in-between. I will be uploading the video here.

@Sulochan-khadka
Copy link
Contributor Author

2024-03-26.01-21-52.mp4

@Sulochan-khadka
Copy link
Contributor Author

@nihal467 @rithviknishad Kindly assign this issue to me to start working on it.

@rithviknishad
Copy link
Member

@Sulochan-khadka we can instead use the Linked Facilities slide over here like how we have in the users list page.

@rithviknishad rithviknishad moved this from Done to Up Next in Care Mar 27, 2024
@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad I have raised a PR for this. Kindly review it and merge! Also let me know if there are improvements needed.

@Sulochan-khadka
Copy link
Contributor Author

Pr number is #7494

@rithviknishad rithviknishad mentioned this issue Mar 29, 2024
Merged
6 tasks
@Sulochan-khadka Sulochan-khadka mentioned this issue Apr 14, 2024
Closed
3 tasks
@nihal467 nihal467 added bug Something isn't working P1 breaking issue or vital feature labels Apr 14, 2024
@github-actions GitHub Actions
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.
@Sulochan-khadka kindly acknowledge this message by commenting 'Acknowledged' below.

@Sulochan-khadka
Copy link
Contributor Author

Acknowledged

khavinshankar pushed a commit that referenced this issue Apr 16, 2024
@Sulochan-khadka @rithviknishad
"Solved facility linking issue under manage facilities/view users"#7474…
d6bce0f 
… (#7494)

* fixes-7474

* Update FacilityUsers.tsx

* Lint errors fix

* Commented out showFacilities

* keeping showLinkFacility

* fix lint and remove unused code

---------

Co-authored-by: Rithvik Nishad <[email protected]>
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sulochan-khadka Sulochan-khadka

Labels
bug Something isn't working P1 breaking issue or vital feature
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"Solved facility linking issue under manage facilities/view users"#7474 Sulochan-khadka/care_fe
3 participants
@rithviknishad @nihal467 @Sulochan-khadka